text:
Jul 25, 2007:
- 11:44 PM Changeset in webkit [24638] by
- 2 edits1 add in trunk/WebKitSite
Rubber stamped by Adam.
Added WebKit Project Goals.
- nav.inc: added a nav link.
- projects/goals.html: Added.
- 9:32 PM WikiStart edited by
- (diff)
- 6:50 PM Changeset in webkit [24637] by
- 5 edits in trunk
Reviewed by Mark.
- follow-up to previous change
- kjs/ustring.cpp: (KJS::UString::operator=): Make sure to reset the length when replacing the buffer contents for a single-owned string.
Reviewed by Mark.
- follow-up to previous change to avoid assertion failures in debug
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): hold JSLock when needed (WebCore::XMLHttpRequest::open): ditto (WebCore::XMLHttpRequest::didFinishLoading): ditto (WebCore::XMLHttpRequest::didReceiveData): ditto
- xml/XMLHttpRequest.h:
- 5:08 PM Changeset in webkit [24636] by
- 3 edits4 adds in trunk
Reviewed by Darin.
iDisk: Web iDisk & main iDisk appear blank
- http/tests/loading/cached-scripts-expected.txt: Added.
- http/tests/loading/cached-scripts.html: Added.
- http/tests/loading/resources: Added.
- http/tests/loading/resources/cached-scripts-subframe.html: Added.
Reviewed by Darin.
iDisk: Web iDisk & main iDisk appear blank
Prepend any remaining text that scripts might have written.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
- 3:45 PM Changeset in webkit [24635] by
- 3 edits in branches/feature-branch/WebCore
Reviewed by Oliver.
Unify absoluteRects() of RenderSVGTSpan & RenderSVGTextPath.
The RenderSVGTextPath one was still using the old, wrong concept.
- 3:15 PM Changeset in webkit [24634] by
- 8 edits6 adds in trunk
Reviewed by .
- mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
- ChangeLog:
- DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/FrameLoadDelegate.h:
- DumpRenderTree/PolicyDelegate.h: Added.
- DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/ResourceLoadDelegate.h:
- 2:50 PM Changeset in webkit [24633] by
- 21 edits7 adds in trunk
Reviewed by Darin.
- JavaScriptCore part of fix for <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
Also, as a side effect of optimizations included in this patch:
- 7% speedup on JavaScript iBench
- 4% speedup on "Celtic Kane" JS benchmark
The basic idea is explained in a big comment in collector.cpp. When unusually
large objecs are allocated, we push the next GC closer on the assumption that
most objects are short-lived.
I also did the following two optimizations in the course of tuning
this not to be a performance regression:
1) Change UString::Rep to hold a self-pointer as the baseString in
the unshared case, instead of a null pointer; this removes a
number of null checks in hot code because many places already
wanted to use the rep itself or the baseString as appropriate.
2) Avoid creating duplicate StringImpls when creating a
StringInstance (the object wrapper for a JS string) or calling
their methods. Since a temporary wrapper object is made every time
a string method is called, this resulted in two useless extra
StringImpls being allocated for no reason whenever a String method
was invoked on a string value. Now we bypass those.
- kjs/collector.cpp: (KJS::): (KJS::Collector::recordExtraCost): Basics of the extra cost mechanism. (KJS::Collector::allocate): ditto (KJS::Collector::collect): ditto
- kjs/collector.h: (KJS::Collector::reportExtraMemoryCost): ditto
- kjs/array_object.cpp: (ArrayInstance::ArrayInstance): record extra cost
- kjs/internal.cpp: (KJS::StringImp::toObject): don't create a whole new StringImpl just to be the internal value of a StringInstance! StringImpls are immutable so there's no point tot his.
- kjs/internal.h: (KJS::StringImp::StringImp): report extra cost
- kjs/string_object.cpp: (KJS::StringInstance::StringInstance): new version that takes a StringImp (KJS::StringProtoFunc::callAsFunction): don't create a whole new StringImpl just to convert self to string! we already have one in the internal value
- kjs/string_object.h: report extra cost
- kjs/ustring.cpp: All changes to handle baseString being self instead of null in the unshared case. (KJS::): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::copyForWriting):
- kjs/ustring.h: (KJS::UString::Rep::baseIsSelf): new method, now that baseString is self instead of null in the unshared case we can't just null check. (KJS::UString::Rep::data): adjusted as mentioned above (KJS::UString::cost): new method to compute the cost for a UString, for use by StringImpl.
- kjs/value.cpp: (KJS::jsString): style fixups. (KJS::jsOwnedString): new method, use this for strings allocated from UStrings held by the parse tree. Tracking their cost as part of string cost is pointless, because garbage collecting them will not actually free the relevant string buffer.
- kjs/value.h: prototyped jsOwnedString.
- kjs/nodes.cpp: (StringNode::evaluate): use jsOwnedString as appropriate (RegExpNode::evaluate): ditto (PropertyNameNode::evaluate): ditto (ForInNode::execute): ditto
- JavaScriptCore.exp: Exported some new symbols.
Reviewed by Darin.
- fixed <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
With this plus related JavaScriptCore changes, a number of XMLHttpRequest situations that
result in huge data sets are addressed, including a single huge responseXML on an XMR done
repeatedly, or accessing responseText repeatedly during loading of a single large XHR.
In addition to the GC changes in JavaScriptCore, I changed responseText to be stored as a
KJS::UString instead of a WebCore::String so that the JavaScript responseText value can
share the buffer (indeed multiple intermediate responseTexts can share its buffer).
First of all, here's some manual test cases that will each blow out the process VM without this fix,
but will settle into decent steady state with.
- manual-tests/memory: Added.
- manual-tests/memory/MessageUidsAlreadyDownloaded2: Added.
- manual-tests/memory/string-growth.html: Added.
- manual-tests/memory/xhr-multiple-requests-responseText.html: Added.
- manual-tests/memory/xhr-multiple-requests-responseXML.html: Added.
- manual-tests/memory/xhr-multiple-requests.html: Added.
- manual-tests/memory/xhr-repeated-string-access.xml: Added.
And here's the actual code changes:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Record extra cost if the document is frameless (counting the nodes doesn't make a measurable performance difference here in any case I could find)
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Adjust for the fact that ressponseText is now stored as a UString.
- bindings/js/kjs_binding.cpp: (KJS::jsOwnedStringOrNull): New helper.
- bindings/js/kjs_binding.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): It's a UString! (WebCore::XMLHttpRequest::getResponseXML): handle the fact that m_responseText is a UString. (WebCore::XMLHttpRequest::XMLHttpRequest): ditto. (WebCore::XMLHttpRequest::abort): call dropProtection (WebCore::XMLHttpRequest::didFinishLoading): call dropProtection (WebCore::XMLHttpRequest::dropProtection): after removing our GC protection, report extra cost of this XHR's responseText buffer.
- xml/XMLHttpRequest.h:
- 2:41 PM Changeset in webkit [24632] by
- 5 edits in trunk/WebCore
Reviewed by Brady.
<rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
This made the container element redundant, so it has been removed. Now the outline element and the delete button
both get appended to the target element and positioned based on that container element. This removes the need
to update the width and height when the target contents changed.
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Change the style properties and remove the container element. (WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
- editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
- editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.
- 2:35 PM Changeset in webkit [24631] by
- 2 edits in trunk/WebCore
Reviewed by Darin.
CrashTracer: [USER] 1 crash in Mail at WebCore::PluginTokenizer::writeRawData(char const*, int)
Make sure to layout so we'll have a renderer. Also null-check the renderer for extra safety.
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
- 1:54 PM Changeset in webkit [24630] by
- 4 edits in trunk/WebKit/win
2007-07-25 Ada Chan <email@example.com>
Reviewed by Adam and Steve.
Implemented some DOM methods and other fixes for <rdar://problem/5311601>.
- DOMCoreClasses.cpp: (DOMNode::ownerDocument): implemented (DOMDocument::getComputedStyle): get the DOMElement via QueryInterface (DOMElement::QueryInterface):
- DOMHTMLClasses.cpp: (DOMHTMLDocument::body): fixed leak (DOMHTMLFormElement::action): implemented (DOMHTMLFormElement::method): ditto (DOMHTMLInputElement::form): ditto (DOMHTMLTextAreaElement::form): ditto
- Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement
- 1:12 PM Changeset in webkit [24629] by
- 2 edits in trunk/WebKitTools
Fix build for some reported systems.
- 1:02 PM BuildingGdk edited by
- (diff)
- 12:14 PM Changeset in webkit [24628] by
- 4 edits in branches/feature-branch/WebCore
Reviewed by Sam.
Let <textPath> be recognized within the ObjC bindings.
Forgot to add that months ago.
- 12:07 PM Changeset in webkit [24627] by
- 2 edits in trunk/LayoutTests
Reviewed by .
- mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.
- 12:01 PM Changeset in webkit [24626] by
- 1 edit in trunk/LayoutTests/mac/leopard/Skipped
- 11:48 AM Changeset in webkit [24625] by
- 2 edits in trunk/LayoutTests
Reviewed by .
- mac/leopard/Skipped: Adding to skip list to avoid false failure
- 9:54 AM Changeset in webkit [24624] by
- 6 edits in trunk/WebCore
Reviewed by Maciej, Darin.
Add ResourceHandle::setClient to resolve some messiness with handle
releasing. Clear the client when ResourceLoader is going to release
the handle to prevent crashes in the case where somebody still holds a
reference (this doesn't seem to currently happen in practice). Add
NULL-checking for ResourceHandle implementations using the client.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::fireBlockedFailure): (WebCore::ResourceHandle::setClient):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
- 8:52 AM Changeset in webkit [24623] by
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=11756 <rdar://problem/5286420>
Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canTarget):
- 8:50 AM Changeset in webkit [24622] by
- 2 edits in trunk/LayoutTests
Reviewed by .
- Reverted
- win/Skipped:
- 8:49 AM Changeset in webkit [24621] by
- 4 edits4 adds in trunk
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com
- fast/text/reset-emptyRun-expected.checksum: Added.
- fast/text/reset-emptyRun-expected.png: Added.
- fast/text/reset-emptyRun-expected.txt: Added.
- fast/text/reset-emptyRun.html: Added.
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com
Test: fast/text/reset-emptyRun.html
- platform/BidiResolver.h: (WebCore::::deleteRuns): Re-add a line that was removed for no reason at all during refactoring in r24485.
- rendering/bidi.cpp: (WebCore::BidiState::deleteRuns): Ditto.
- 8:44 AM Changeset in webkit [24620] by
- 2 edits in trunk/LayoutTests
Reviewed by .
- Forgot to checking the changes to the skipped list so the win bot doesn't fail.
- win/Skipped:
- 2:57 AM Changeset in webkit [24619] by
- 8 edits6 deletes in trunk
Roll out r24618 as it broke 600+ layout tests.
- 2:08 AM Changeset in webkit [24618] by
- 8 edits6 adds in trunk
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Tests that feed:// urls can still be followed when clicked.
- http/tests/security/feed-urls-from-remote-expected.txt: Added.
- http/tests/security/feed-urls-from-remote.html: Added.
- http/tests/security/resources/feed.html: Added.
- http/tests/security/resources/feed.xml: Added.
- win/Skipped:
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
- ChangeLog:
- DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/FrameLoadDelegate.h:
- DumpRenderTree/PolicyDelegate.h: Added.
- DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/ResourceLoadDelegate.h:
Jul 24, 2007:
- 10:38 PM Changeset in webkit [24617] by
- 2 edits in trunk/LayoutTests
Reviewed by Adam Roben
<rdar://problem/5313504> - Some Back/Forward tests fail on Leopard
- mac/leopard/Skipped: Remove from the skipped list as they work now
- 9:37 PM Changeset in webkit [24616] by
- 13 edits in trunk
Reviewed by Adam and Justin.
<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:.
Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
This required lifting local code from DragController.cpp into the shared methods
Frame::visiblePositionForPoint and Frame::documentAtPoint.
- WebCore.exp:
- editing/Editor.cpp: (WebCore::Editor::rangeForPoint):
- editing/Editor.h:
- page/DragController.cpp: (WebCore::DragController::dragEnded): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag): (WebCore::DragController::placeDragCaret):
- page/DragController.h:
- page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): (WebCore::Frame::documentAtPoint):
- page/Frame.h:
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm:
Reviewed by Adam and Justin.
<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebView.mm: (-[WebView moveDragCaretToPoint:]): (-[WebView removeDragCaret]): (-[WebView editableDOMRangeForPoint:]):
- 6:22 PM Changeset in webkit [24615] by
- 2 edits in trunk/WebCore
Rubber-stamped by Adam Roben.
Remove unused .strip files.
- WebCore.xcodeproj/project.pbxproj:
- 6:21 PM Changeset in webkit [24614] by
- 1 copy in tags/Safari-522.14.3b
New tag.
- 6:20 PM Changeset in webkit [24613] by
- 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION
Bump version for submit
- 6:20 PM Changeset in webkit [24612] by
- 2 edits in trunk/LayoutTests
Adding to the Leopard skip list to avoid a test that hangs due to a CFNetwork bug.
- mac/leopard/Skipped:
- 6:10 PM Changeset in webkit [24611] by
- 1 copy in tags/Safari-522.15.5b
New tag.
- 6:04 PM Changeset in webkit [24610] by
- 1 edit in trunk/LayoutTests/mac/leopard/Skipped
Updating skipped list
- 5:53 PM Changeset in webkit [24609] by
- 3 edits in trunk/LayoutTests
Updating test to put JS code in the onload handler helps to avoid intermittent failures.
<rdar://problem/5313531> REGRESSION(Leopard): editing/pasteboard/copy-in-password-field.html sometimes fails
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/pasteboard/copy-in-password-field.html:
- 5:02 PM Changeset in webkit [24608] by
- 3 edits2 adds in trunk
Reviewed by Hyatt.
Test for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
- fast/css/getComputedStyle-border-box-expected.txt: Added.
- fast/css/getComputedStyle-border-box.html: Added.
Reviewed by Hyatt.
Fix for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
Test: fast/css/getComputedStyle-border-box.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.
- 4:36 PM Changeset in webkit [24607] by
- 2 edits in trunk/WebCore
Reviewed by Kevin Decker.
REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages
Null check the loader.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start):
- 4:31 PM Changeset in webkit [24606] by
- 2 edits in trunk/WebKit
Reviewed by Anders.
<rdar://problem/4699455> REGRESSION (Safari 2->Safari 3): Adobe Reader 7.0.8 plug-in doesn't work
- Plugins/WebNetscapePluginEmbeddedView.h: Added a #define that renames this class to "WebNetscapePluginDocumentView" This is necessary because the Adobe 7.x Acrobat plug-in has a hard coded check for a view named "WebNetscapePluginDocumentView" and will not function correctly if it doesn't find a view in the hierarchy without the old class name.
- 3:59 PM Changeset in webkit [24605] by
- 12 edits105 adds in branches/feature-branch
Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)
- 3:23 PM Changeset in webkit [24604] by
- 103 edits4 adds in trunk
Reviewed by Hyatt and Adam.
Added and updated tests for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
The metrics have changed for the anonymous block inside popup buttons.
- fast/forms/menulist-narrow-width-expected.checksum: Added.
- fast/forms/menulist-narrow-width-expected.png: Added.
- fast/forms/menulist-narrow-width-expected.txt: Added.
- fast/forms/menulist-narrow-width.html: Added.
- editing/pasteboard/4641033-expected.txt:
- editing/pasteboard/4944770-1-expected.txt:
- editing/pasteboard/4944770-2-expected.txt:
- editing/pasteboard/select-element-1-expected.txt:
- editing/selection/caret-before-select-expected.txt:
- editing/selection/replaced-boundaries-3-expected.txt:
- editing/selection/select-box-expected.txt:
- editing/selection/select-element-paragraph-boundary-expected.txt:
- fast/block/float/float-avoidance-expected.txt:
- fast/block/margin-collapse/103-expected.txt:
- fast/forms/001-expected.checksum:
- fast/forms/001-expected.png:
- fast/forms/001-expected.txt:
- fast/forms/003-expected.txt:
- fast/forms/004-expected.txt:
- fast/forms/HTMLOptionElement_label01-expected.txt:
- fast/forms/HTMLOptionElement_label02-expected.txt:
- fast/forms/HTMLOptionElement_label03-expected.txt:
- fast/forms/HTMLOptionElement_label04-expected.txt:
- fast/forms/HTMLOptionElement_label06-expected.txt:
- fast/forms/HTMLOptionElement_label07-expected.txt:
- fast/forms/control-restrict-line-height-expected.txt:
- fast/forms/disabled-select-change-index-expected.txt:
- fast/forms/form-element-geometry-expected.txt:
- fast/forms/menulist-separator-painting-expected.txt:
- fast/forms/menulist-width-change-expected.txt:
- fast/forms/option-script-expected.txt:
- fast/forms/option-strip-whitespace-expected.txt:
- fast/forms/option-text-clip-expected.txt:
- fast/forms/select-accesskey-expected.txt:
- fast/forms/select-align-expected.txt:
- fast/forms/select-baseline-expected.txt:
- fast/forms/select-change-listbox-to-popup-expected.txt:
- fast/forms/select-disabled-appearance-expected.txt:
- fast/forms/select-initial-position-expected.txt:
- fast/forms/select-selected-expected.txt:
- fast/forms/select-size-expected.txt:
- fast/forms/select-style-expected.txt:
- fast/forms/select-visual-hebrew-expected.txt:
- fast/forms/select-writing-direction-natural-expected.txt:
- fast/forms/stuff-on-my-optgroup-expected.txt:
- fast/html/keygen-expected.txt:
- fast/invalid/014-expected.txt:
- fast/invalid/residual-style-expected.txt:
- fast/parser/document-write-option-expected.txt:
- fast/replaced/replaced-breaking-expected.txt:
- fast/replaced/replaced-breaking-mixture-expected.txt:
- fast/replaced/three-selects-break-expected.txt:
- fast/replaced/width100percent-expected.txt:
- fast/text/international/bidi-menulist-expected.txt:
- http/tests/navigation/anchor-basic-expected.txt:
- http/tests/navigation/anchor-frames-expected.txt:
- http/tests/navigation/anchor-goback-expected.txt:
- http/tests/navigation/anchor-subframeload-expected.txt:
- http/tests/navigation/javascriptlink-basic-expected.txt:
- http/tests/navigation/javascriptlink-frames-expected.txt:
- http/tests/navigation/javascriptlink-goback-expected.txt:
- http/tests/navigation/javascriptlink-subframeload-expected.txt:
- http/tests/navigation/metaredirect-basic-expected.txt:
- http/tests/navigation/metaredirect-frames-expected.txt:
- http/tests/navigation/metaredirect-goback-expected.txt:
- http/tests/navigation/metaredirect-subframeload-expected.txt:
- http/tests/navigation/post-goback2-expected.txt:
- http/tests/navigation/postredirect-goback2-expected.txt:
- http/tests/navigation/redirect302-basic-expected.txt:
- http/tests/navigation/redirect302-frames-expected.txt:
- http/tests/navigation/redirect302-goback-expected.txt:
- http/tests/navigation/redirect302-subframeload-expected.txt:
- http/tests/navigation/relativeanchor-basic-expected.txt:
- http/tests/navigation/relativeanchor-frames-expected.txt:
- http/tests/navigation/relativeanchor-goback-expected.txt:
- http/tests/navigation/slowmetaredirect-basic-expected.txt:
- http/tests/navigation/slowtimerredirect-basic-expected.txt:
- http/tests/navigation/success200-basic-expected.txt:
- http/tests/navigation/success200-frames-expected.txt:
- http/tests/navigation/success200-frames-loadsame-expected.txt:
- http/tests/navigation/success200-goback-expected.txt:
- http/tests/navigation/success200-loadsame-expected.txt:
- http/tests/navigation/success200-reload-expected.txt:
- http/tests/navigation/success200-subframeload-expected.txt:
- http/tests/navigation/timerredirect-basic-expected.txt:
- http/tests/navigation/timerredirect-frames-expected.txt:
- http/tests/navigation/timerredirect-goback-expected.txt:
- http/tests/navigation/timerredirect-subframeload-expected.txt:
- tables/mozilla/bugs/bug1188-expected.txt:
- tables/mozilla/bugs/bug18359-expected.txt:
- tables/mozilla/bugs/bug2479-3-expected.txt:
- tables/mozilla/bugs/bug2479-4-expected.txt:
- tables/mozilla/bugs/bug29326-expected.txt:
- tables/mozilla/bugs/bug33855-expected.txt:
- tables/mozilla/bugs/bug4382-expected.txt:
- tables/mozilla/bugs/bug96334-expected.txt:
- tables/mozilla/core/margins-expected.txt:
- tables/mozilla/dom/tableDom-expected.txt:
- tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
Reviewed by Hyatt and Adam.
Fix for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
Removed hack that forced large padding on popup buttons. Now we put that padding in the inner block, so that
the specified width will be honored.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme. (WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box. This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box, that will get clipped too. (WebCore::RenderMenuList::calcPrefWidths): Add in the inner box's padding and border to the pref widths.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control. Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case. (WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically. Don't draw the arrows if they won't fit horizontally. Reset padding. Since WinIE doesn't honor padding for popups, its not critical to support padding at this time. (WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here. Instead, we're going to set the padding on the inner block of the select. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto. (WebCore::RenderThemeMac::popupInternalPaddingLeft): Added. Provides internal padding values for RenderMenuList. (WebCore::RenderThemeMac::popupInternalPaddingRight): ditto. (WebCore::RenderThemeMac::popupInternalPaddingTop): ditto. (WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeSafari.cpp: The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences. This code should be refactored and shared, but now did not seem like the right time to do that refactoring. (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::adjustMenuListStyle): (WebCore::RenderThemeSafari::popupInternalPaddingLeft): (WebCore::RenderThemeSafari::popupInternalPaddingRight): (WebCore::RenderThemeSafari::popupInternalPaddingTop): (WebCore::RenderThemeSafari::popupInternalPaddingBottom): (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
- rendering/RenderThemeSafari.h:
- rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList. (WebCore::RenderTheme::popupInternalPaddingLeft): (WebCore::RenderTheme::popupInternalPaddingRight): (WebCore::RenderTheme::popupInternalPaddingTop): (WebCore::RenderTheme::popupInternalPaddingBottom):
- 1:58 PM Changeset in webkit [24603] by
- 4 edits2 adds2 deletes in trunk/WebCore
replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.
- 1:43 PM Changeset in webkit [24602] by
- 2 edits in trunk/WebKit/win
Removed touch of WebKit.rc to prevent rebuilds of the rc file.
The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.
Rubber-stamped by Adam.
- WebKit.vcproj/WebKit.vcproj:
- 1:05 PM Changeset in webkit [24601] by
- 1 copy in tags/Safari-522.15.4b
New tag.
- 12:49 PM Changeset in webkit [24600] by
- 3 edits in trunk/WebKitQt
These are no longer necessary or used.
- 12:03 PM Changeset in webkit [24599] by
- 3 edits8 adds in trunk
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
- and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
- fast/multicol/negativeColumnWidth-expected.checksum: Added.
- fast/multicol/negativeColumnWidth-expected.png: Added.
- fast/multicol/negativeColumnWidth-expected.txt: Added.
- fast/multicol/negativeColumnWidth.html: Added.
- fast/multicol/zeroColumnCount-expected.checksum: Added.
- fast/multicol/zeroColumnCount-expected.png: Added.
- fast/multicol/zeroColumnCount-expected.txt: Added.
- fast/multicol/zeroColumnCount.html: Added.
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
- and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value for column-width and column-count. Since the spec does not address what to do with negative values for these properties, we are patching the rendering code instead of the parser.
- 11:49 AM Changeset in webkit [24598] by
- 2 edits in S60/branches/3.1m/WebCore
2007-07-20 vmalaiya, <firstname.lastname@example.com>
Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before
an attempt to retrieve information from it.
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
- 11:47 AM Changeset in webkit [24597] by
- 2 edits in S60/trunk/WebCore
2007-07-20 vmalaiya, <email@example.com>
Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before
an attempt to retrieve information from it.
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
- 11:44 AM Changeset in webkit [24596] by
- 2 edits in trunk/WebCore
Reviewed by Steve.
REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1
Close the file before handing off the file name to the plug-in.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::destroyStream):
- 11:29 AM Changeset in webkit [24595] by
- 3 edits in trunk/WebCore
2007-07-24 Alp Toker <email@example.com>
Reviewed by Adam.
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
Remove unnecessary label from widget instances.
Render check and radio widgets correctly.
Determine the widget state and render it appropriately.
- platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton):
- platform/gdk/RenderThemeGdk.h:
- 9:55 AM Applications using WebKit edited by
- Including PageOutline (diff)
- 7:52 AM Changeset in webkit [24594] by
- 1 copy in tags/JavaScriptCore-419.2.1/JavaScriptCore
New tag (part 2).
- 7:51 AM Changeset in webkit [24593] by
- 1 add in tags/JavaScriptCore-419.2.1
New tag (part 1).
- 7:51 AM Changeset in webkit [24592] by
- 1 copy in tags/JavaScriptCore-418.6.1/JavaScriptCore
New tag (part 2).
- 7:50 AM Changeset in webkit [24591] by
- 1 add in tags/JavaScriptCore-418.6.1
New tag (part 1).
- 7:48 AM Changeset in webkit [24590] by
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
- 7:47 AM Changeset in webkit [24589] by
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
2007-07-25 Mark Rowe <firstname.lastname@example.com>
Build fix for GCC 3.3.
- pcre/pcre_compile.c: Remove unused variables.
- 7:44 AM Changeset in webkit [24588] by
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
- 7:44 AM Changeset in webkit [24587] by
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
2007-07-25 Mark Rowe <email@example.com>
Build fix for GCC 3.3.
- pcre/pcre_compile.c: Remove unused variables.
- 5:56 AM Changeset in webkit [24586] by
- 82 edits in trunk/WebCore/page/inspector/Images
Set the correct svn:mime-type on WebCore/page/inspector/Images/*.png
- 5:21 AM Changeset in webkit [24585] by
- 5 edits in trunk
2007-07-24 Mark Rowe <email@example.com>
Reviewed by Antti.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release] to dispose of it in a manner that won't leak under Obj-C GC.
- platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription. (WebCore::ContextMenu::insertItem): ditto.
2007-07-24 Mark Rowe <firstname.lastname@example.com>
Reviewed by Antti.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Release platformItem as we were transferred its ownership by releasePlatformDescription.
- 4:47 AM Changeset in webkit [24584] by
- 2 edits in trunk/WebCore
Roll out r24583, it needs further consideration.
- 4:42 AM BuildingOnLinux edited by
- (diff)
- 4:40 AM Changeset in webkit [24583] by
- 2 edits in trunk/WebCore
2007-07-24 Mark Rowe <firstname.lastname@example.com>
Reviewed by Oliver.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release the platformItem after we take ownership of it from the ContextMenuItem.
- 3:38 AM BuildingOnLinux edited by
- (diff)
- 3:36 AM BuildingOnLinux created by
- 3:23 AM WikiStart edited by
- (diff)
- 2:55 AM Changeset in webkit [24582] by
- 34 edits6 adds2 deletes in trunk
2007-07-24 Mitz Pettel <firstname.lastname@example.com>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)
Test: fast/text/drawBidiText.html
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- manual-tests/chrome-bidi-text.html: Added.
- manual-tests/resources/chrome-bidi-text-window.html: Added.
- platform/BidiReorderCharacters.cpp: Removed.
- platform/BidiReorderCharacters.h: Removed.
- platform/BidiResolver.h: (WebCore::BidiCharacterRun::start): Added accessor method. (WebCore::BidiCharacterRun::stop): Ditto. (WebCore::BidiCharacterRun::level): Ditto. (WebCore::BidiCharacterRun::next): Ditto. (WebCore::::appendRun): Added default implementation.
- platform/TextStyle.h: (WebCore::TextStyle::setDirectionalOverride): Added accessor method.
- platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver- compliant iterator over the characters in a TextRun. (WebCore::TextRunIterator::offset): (WebCore::TextRunIterator::increment): (WebCore::TextRunIterator::atEnd): (WebCore::TextRunIterator::current): (WebCore::TextRunIterator::direction): (WebCore::TextRunIterator::operator==): (WebCore::TextRunIterator::operator!=): (WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode Bidi Algorithm to the text and draws the resulting unidirectional runs in the right order and with the right directionality.
- platform/graphics/GraphicsContext.h:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Replaced the use of a character buffer and BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' because that CSS property is an implementation detail of WebCore's visual Hebrew support, and the UA stylesheet sets it to 'logical' for this form control. Authors can specify the ordering using the 'direction' and 'unicode-bidi' properties.
- platform/win/WebCoreTextRenderer.cpp: (WebCore::isOneLeftToRightRun): Added. Checks if the text consists of a single left-to-right run, in which case it requires no bidi processing. (WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text is not entirely left-to-right.
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Replaced the use of a character buffer in BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' for the same reason stated above.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the run-rounding modes used when drawing to match those used when measuring.
2007-07-24 Mitz Pettel <email@example.com>
Reviewed by Darin.
- test, updated tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)
- fast/forms/HTMLOptionElement_label05-expected.checksum:
- fast/forms/HTMLOptionElement_label05-expected.png:
- fast/forms/listbox-deselect-scroll-expected.checksum:
- fast/forms/listbox-deselect-scroll-expected.png:
- fast/forms/listbox-width-change-expected.checksum:
- fast/forms/listbox-width-change-expected.png:
- fast/forms/option-strip-whitespace-expected.checksum:
- fast/forms/option-strip-whitespace-expected.png:
- fast/forms/select-change-popup-to-listbox-expected.checksum:
- fast/forms/select-change-popup-to-listbox-expected.png:
- fast/forms/select-initial-position-expected.checksum:
- fast/forms/select-initial-position-expected.png:
- fast/text/drawBidiText-expected.checksum: Added.
- fast/text/drawBidiText-expected.png: Added.
- fast/text/drawBidiText-expected.txt: Added.
- fast/text/drawBidiText.html: Added.
- fast/text/international/bidi-listbox-atsui-expected.checksum:
- fast/text/international/bidi-listbox-atsui-expected.png:
- fast/text/international/bidi-listbox-atsui-expected.txt:
- fast/text/international/bidi-listbox-atsui.html: Removed the visual ordering cases.
- fast/text/international/bidi-listbox-expected.checksum:
- fast/text/international/bidi-listbox-expected.png:
- fast/text/international/bidi-listbox-expected.txt:
- fast/text/international/bidi-listbox.html: Removed the visual ordering cases because the patch removed special handling of visual ordering.
- 2:29 AM Changeset in webkit [24581] by
- 1 copy in tags/JavaScriptCore-4522.10.1/JavaScriptCore
New tag (part 2).
- 2:29 AM Changeset in webkit [24580] by
- 1 add in tags/JavaScriptCore-4522.10.1
New tag (part 1).
- 2:28 AM Changeset in webkit [24579] by
- 1 edit in branches/Safari-522/JavaScriptCore/Configurations/Version.xcconfig
- 2:28 AM Changeset in webkit [24578] by
- 6 edits in branches/Safari-522/JavaScriptCore
2007-07-24 Mark Rowe <email@example.com>
Merge r24453.
2007-07-19 Darin Adler <Darin Adler>
Reviewed by Geoff.
- fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions
It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.
Turned off the following features of PCRE (some of these are simply parsed and not implemented):
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?0) (and 1-9)
Added the following:
\u \v
Because of \v, the js1_2/regexp/special_characters.js test now passes.
To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.
I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.
- kjs/regexp.h:
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.
- pcre/pcre-config.h: Set JAVASCRIPT to 1.
- pcre/pcre_internal.h: Added ESC_v.
- pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.
- tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.
- 2:28 AM Changeset in webkit [24577] by
- 2 edits in branches/Safari-522/JavaScriptCore
2007-07-24 Mark Rowe <firstname.lastname@example.com>
Merge r24430.
2007-07-18 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
- fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"
Test: fast/js/regexp-charclass-crash.html
- pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.
- 2:15 AM Changeset in webkit [24576] by
- 1 copy in tags/JavaScriptCore-312.3.3/JavaScriptCore
New tag (part 2).
- 2:14 AM Changeset in webkit [24575] by
- 1 add in tags/JavaScriptCore-312.3.3
New tag (part 1).
- 2:13 AM Changeset in webkit [24574] by
- 1 edit in branches/Safari-1-3-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj
- 2:13 AM Changeset in webkit [24573] by
- 2 edits in branches/Safari-1-3-branch/JavaScriptCore
Merge fix for <rdar://problems/5355025&5355062>.
- 2:07 AM Changeset in webkit [24572] by
- 1 copy in tags/JavaScriptCore-419.2/JavaScriptCore
New tag (part 2).
- 2:07 AM Changeset in webkit [24571] by
- 1 add in tags/JavaScriptCore-419.2
New tag (part 1).
- 2:07 AM Changeset in webkit [24570] by
- 1 edit in branches/Safari-2.0-dashboard/JavaScriptCore/Info.plist
- 2:07 AM Changeset in webkit [24569] by
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.
- 2:01 AM Changeset in webkit [24568] by
- 1 copy in tags/JavaScriptCore-418.6/JavaScriptCore
New tag (part 2).
- 2:01 AM Changeset in webkit [24567] by
- 1 add in tags/JavaScriptCore-418.6
New tag (part 1).
- 2:00 AM Changeset in webkit [24566] by
- 1 edit in branches/Safari-2.0-system/JavaScriptCore/Info.plist
- 2:00 AM Changeset in webkit [24565] by
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.
Jul 23, 2007:
- 11:54 PM Changeset in webkit [24564] by
- 2 edits in trunk/WebCore
Reviewed by Steve.
Windows build fix, remove superfluous !
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
- 11:31 PM Changeset in webkit [24563] by
- 2 edits in trunk/WebKit/win
Fixes to versioning script.
Reviewed by Ada.
- WebKit.vcproj/auto-version.sh:
- 9:11 PM Changeset in webkit [24562] by
- 7 edits in trunk
Implement IWebHistoryItem::[set]AlternateTitle
Add an assignment operator for BString that takes a BSTR
Reviewed by Geoff and Oliver.
- platform/win/BString.cpp: (WebCore::BString::operator=):
- platform/win/BString.h:
Implement IWebHistoryItem::[set]AlternateTitle
The argument types were reversed for these two methods, so I fixed that as
Reviewed by Geoff and Oliver.
- Interfaces/IWebHistoryItem.idl:
- WebHistoryItem.cpp: (WebHistoryItem::setAlternateTitle): Implemented. (WebHistoryItem::alternateTitle): Implemented.
- WebHistoryItem.h:
- 8:59 PM Changeset in webkit [24561] by
- 3 edits8 adds in trunk
Reviewed by Geoff.
<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)
- editing/selection/5354455-1-expected.checksum: Added.
- editing/selection/5354455-1-expected.png: Added.
- editing/selection/5354455-1-expected.txt: Added.
- editing/selection/5354455-1.html: Added.
- editing/selection/5354455-2-expected.checksum: Added.
- editing/selection/5354455-2-expected.png: Added.
- editing/selection/5354455-2-expected.txt: Added.
- editing/selection/5354455-2.html: Added.
Reviewed by Geoff.
<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)
- page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): In non-editable content, only do word selection over text. In editable content, we will continue to select images, line breaks and other elements on right-clicks, to match TextEdit. For now, in editable content, we'll live with the cases where positionForPoint creates selections that aren't underneath the mouse. These aren't regressions because we've always done word selection on right clicks in editable content.
- 8:09 PM Changeset in webkit [24560] by
- 3 edits2 adds in trunk
Reviewed by Oliver.
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region
- fast/dom/Document/open-with-pending-load-expected.txt: Added.
- fast/dom/Document/open-with-pending-load.html: Added.
Reviewed by Oliver.
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region
If Document::open is called and there's a pending load that has not yet started,
that load should be cancelled.
- dom/Document.cpp: (WebCore::Document::open):
- 8:01 PM Changeset in webkit [24559] by
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff.
<rdar://problem/5121461> REGRESSION: Unable to load JigZone puzzle
- bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative):
Call RootObject::gcProtect on the global object, thereby putting it in the
"protect count" set which is used for checking if a native handle is valid.
- 7:36 PM RunWebKitTestsDesign edited by
- (diff)
- 6:22 PM Changeset in webkit [24558] by
- 2 edits in trunk/LayoutTests
Reviewed by Mark.
Remove http/tests/multipart/invalid-image-data.html which no longer fails on Leopard.
- mac/leopard/Skipped:
- 6:00 PM Changeset in webkit [24557] by
- 6 edits in trunk/LayoutTests
<rdar://problem/5228167> REGRESSION: editing/execCommand/5119244.html failing on Leopard
Removed another use of the ⎷ entity. See below.
- editing/execCommand/5119244-expected.checksum:
- editing/execCommand/5119244-expected.png:
- editing/execCommand/5119244-expected.txt:
- editing/execCommand/5119244.html:
- mac/leopard/Skipped:
- 5:46 PM Changeset in webkit [24556] by
- 6 edits in trunk/LayoutTests
Reviewed by Oliver.
<rdar://problem/5228164> REGRESSION: editing/deleting/5144139-2.html fails on Leopard
Removed the use of the ⎷ entity, which is available on
Leopard but not Tiger. Perhaps because it is not available in Ahem
but is available in some fallback font that ships with Leopard but not Tiger.
It's OK to remove because its use wasn't necessary to test the fix for 5144139.
- editing/deleting/5144139-2-expected.checksum:
- editing/deleting/5144139-2-expected.png:
- editing/deleting/5144139-2-expected.txt:
- editing/deleting/5144139-2.html:
- mac/leopard/Skipped:
- 5:44 PM Changeset in webkit [24555] by
- 4 edits in tags/Safari-5522.12.1
- 5:44 PM Changeset in webkit [24554] by
- 4 edits in tags/Safari-5522.12.1
Merge r24545.
Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.
- 5:39 PM Changeset in webkit [24553] by
- 5 edits in trunk/WebKit/win
2007-07-23 Ada Chan <email@example.com>
Reviewed by Steve.
Added a new text drawing method that allows caller to override the font smoothing level.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit_debug.def:
- WebKitGraphics.cpp: (WebDrawText):
- WebKitGraphics.h:
- 5:37 PM Changeset in webkit [24552] by
- 4 edits in trunk/WebKitLibraries
2007-07-23 Ada Chan <firstname.lastname@example.com>
Reviewed by Steve.
Update WebKitSystemInterface.{h,lib}.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 5:33 PM Changeset in webkit [24551] by
- 1 copy in tags/Safari-5522.12.1
New tag.
- 5:04 PM Changeset in webkit [24550] by
- 5 edits in trunk/WebCore
Reviewed by Hyatt.
<rdar://problem/5242145> REGRESSION: Clicking on symbol in documentation often doesn't scroll to symbol
A renderer for the anchor wasn't always available at the time parsing finished. So we need
to bail out of gotoAnchor if stylesheets are pending and remember to call gotoAnchor later
once all of the pending stylesheets load.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_gotoAnchorNeededAfterStylesheetsLoad to false. (WebCore::Document::stylesheetLoaded): If we have no more pending stylesheets, call gotoAnchor if needed.
- dom/Document.h: (WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad): New method. (WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Bail early if the document still has pending stylesheets.
- loader/FrameLoader.h: Make gotoAnchor() public.
- 4:16 PM Changeset in webkit [24549] by
- 2 edits in trunk/WebCore
Reviewed by Darin
- fixed <rdar://problem/5327887> Printing Mail note (or Safari page) with misspelled word prints red underline
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): When printing, bail out without doing any work. Also moved a couple of lines down below another early bailout since they were pointless above it.
- 3:17 PM Changeset in webkit [24548] by
- 1 copy in tags/Safari-522.15.3b
New tag.
- 2:58 PM Changeset in webkit [24547] by
- 2 edits in trunk/WebKitTools
Fix qt DRT to suppress js popup alerts and log instead.
- 2:35 PM Changeset in webkit [24546] by
- 2 edits in trunk/JavaScriptCore
- pcre/pcre_compile.c: Roll back a tiny accidental change in the unused !JAVASCRIPT side of an #ifdef. This has no effect when using PCRE in JAVASCRIPT mode as we do, but seems worth rolling back.
- 2:29 PM Changeset in webkit [24545] by
- 4 edits in trunk
Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.
- 2:19 PM Changeset in webkit [24544] by
- 6 edits in branches/Safari-522-2/JavaScriptCore
Merged fix from r24453.
- 2:15 PM Changeset in webkit [24543] by
- 3 edits2 copies in branches/Safari-522-2
Merged fix from r24430.
- 2:06 PM TestFormUpload created by
- 2:06 PM WebKit Team edited by
- (diff)
- 2:03 PM Changeset in webkit [24542] by
- 8 edits3 adds in trunk
Reviewed by Darin.
Added initial pseudo-hangul IM, and tests for behaviour of hangul (<rdar://problem/5352152>)
Updated keydown-keypress-preventDefault to be correct, and to have an demonstrate that keys have been inserted.
Updated kotoeri test to perform more validation and check against updated behaviour
- editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Added.
- editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Added.
- editing/input/mac/hangul.js: Added.
- editing/input/mac/kotoeri-enter-to-confirm-and-newline.html:
- fast/events/keydown-keypress-preventDefault-expected.txt:
- fast/events/keydown-keypress-preventDefault.html:
Reviewed by Darin.
<rdar://problem/5353577> WebKit key event behaviour needs to better match other browsers keyevent behaviour
<rdar://problem/5352152> REGRESSION (24399-24479): Pressing Enter in a search field at apple.com no longer starts a search with Korean IM
<rdar://problem/5352649> WebKit should send keyDown event on autorepeat keyDowns
Perform Input Method call first so that our behaviour is determined by whether or not
the input method has actually handle the event, rather than by making guesses based
on the existences of marked text. This fixes issues with IMs that have side effects
even on events they do not handle.
Refactored the code in order to improve clarity given the hoisting required by performing
the IM call earlier.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
Reviewed by Darin.
We have to be able to support insertText: followed by doCommandBySelector: in
order to support the 2- and 3-Set Korean and RuSwitcher IMs at least.
- WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):
- 1:27 PM Changeset in webkit [24541] by
- 9 edits3 adds in trunk
Reviewed by Darin.
Google calendar settings page crashes
- fast/dom/destroy-selected-radio-button-crash-expected.txt: Added.
- fast/dom/destroy-selected-radio-button-crash.html: Added.
Reviewed by Darin.
Google calendar settings page crashes
Move handling of checked radio buttons to a new class, HTMLFormElement::CheckedRadioButtons.
Each <form> element has an instance of this class. For radio buttons without a containing
form, the document has an instance of HTMLFormElement::CheckedRadioButtons where the
state of those radio buttons will be stored.
be stored.
This also fixes another bug where removing a checked radio button that does not have a
containing form would not remove the radio button from the checked radio buttons map,
which could lead to a crash due to a dangling pointer.
- dom/Document.cpp: (WebCore::Document::~Document):
- dom/Document.h: (WebCore::Document::checkedRadioButtons):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::CheckedRadioButtons::didCheckButton): (WebCore::HTMLFormElement::CheckedRadioButtons::checkedButtonForGroup): (WebCore::HTMLFormElement::CheckedRadioButtons::removeButtonIfChecked):
- html/HTMLFormElement.h: (WebCore::HTMLFormElement::checkedRadioButtons):
- html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::insertedIntoTree):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::checkedRadioButtons): (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
- manual-tests/remove-form-node-with-radio-buttons-crash.html: Added.
- 1:23 PM Changeset in webkit [24540] by
- 3 edits in trunk/WebKit
Reverting change 24535 now that a solution has been found that doesn't
involve exposing an interface unnecessarily.
- WebView/WebHTMLView.mm:
- WebView/WebHTMLViewPrivate.h:
- 11:51 AM Changeset in webkit [24539] by
- 4 adds in trunk/LayoutTests/fast/inline
Add layout test for continuation hang.
- 11:50 AM Changeset in webkit [24538] by
- 3 edits in trunk/WebCore
Fix for 5350587, hang in iExploder text 8101. The code that painted outlines for continuations was buggy
in that it assumed the chain was always inline-block-inline, but this is only true for the innermost chained
continuation. To make this more robust, we always just use the inline's containing block's containing block,
which should be guaranteed to enclose all renderers in the continuation chain. In addition, there is now a
null check (to guarantee no more hangs) and an assert (to check if we hit this situation again where the block
used to paint does not properly enclose the continuation chain).
Reviewed by beth
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContinuationOutlines):
- rendering/InlineFlowBox.cpp: (WebCore::RenderInline::paint):
- 11:16 AM Changeset in webkit [24537] by
- 16 edits1 move21 adds in trunk
2007-07-22 Holger Hans Peter Freyther <email@example.com>
Reviewed by Adam.
Add WebKit/gtk/Api and WebCoreSupport API to the INCLUDEPATH to allow GdkLauncher to be
build against it.
- WebKit.pri:
2007-07-22 Holger Hans Peter Freyther <email@example.com>
Reviewed by Adam.
Add the WebKit/Gtk API to the buildsystem, ask qmake to create a
pkg-config file and install headers and libraries.
Start to emit signals from FrameLoaderClientGdk, hide the kit Frame
inside the the FrameLoaderClientGdk.
Move ChromeClientGdk to WebKit/gtk/WebCoreSupport
- WebCore.pro:
- loader/gdk/FrameLoaderClientGdk.cpp:
- loader/gdk/FrameLoaderClientGdk.h:
- platform/gdk/ChromeClientGdk.h: Removed.
- platform/gdk/FrameGdk.cpp: Remove code not belonging here
- platform/gdk/FrameGdk.h:
- platform/gdk/ScrollViewGdk.cpp: The gdkDrawable won't exist at that time and it is fine
- platform/gdk/TemporaryLinkStubs.cpp: Removed ChromeClientGdk stubs
2007-07-22 Holger Hans Peter Freyther <email@example.com>
Reviewed by Adam.
Add the first API and partial implementation of the WebKit/Gtk port as
of http://bugs.webkit.org/show_bug.cgi?id=14678.
The delegates of WebView will be modeled as signals. Delegates like the
WebPolicyDelegate will be implemented as signals with default handlers.
Start moving files to WebKit/gtk/WebCoreSupport.
- gtk: Added.
- gtk/Api: Added.
- gtk/Api/headers.pri: Added.
- gtk/Api/webkitgtk-marshal.list: Added.
- gtk/Api/webkitgtkdefines.h: Added.
- gtk/Api/webkitgtkframe.cpp: Added.
- gtk/Api/webkitgtkframe.h: Added.
- gtk/Api/webkitgtkframedata.cpp: Added.
- gtk/Api/webkitgtkframedata.h: Added.
- gtk/Api/webkitgtkglobal.cpp: Added.
- gtk/Api/webkitgtkglobal.h: Added.
- gtk/Api/webkitgtknetworkrequest.cpp: Added.
- gtk/Api/webkitgtknetworkrequest.h: Added.
- gtk/Api/webkitgtkpage.cpp: Added.
- gtk/Api/webkitgtkpage.h: Added.
- gtk/Api/webkitgtkprivate.cpp: Added.
- gtk/Api/webkitgtkprivate.h: Added.
- gtk/Api/webkitgtksettings.cpp: Added.
- gtk/Api/webkitgtksettings.h: Added.
- gtk/WebCoreSupport: Added.
- gtk/WebCoreSupport/ChromeClientGdk.cpp: Added. (WebCore::ChromeClientGdk::ChromeClientGdk): (WebCore::ChromeClientGdk::chromeDestroyed): (WebCore::ChromeClientGdk::windowRect): (WebCore::ChromeClientGdk::setWindowRect): (WebCore::ChromeClientGdk::pageRect): (WebCore::ChromeClientGdk::scaleFactor): (WebCore::ChromeClientGdk::focus): (WebCore::ChromeClientGdk::unfocus): (WebCore::ChromeClientGdk::createWindow): (WebCore::ChromeClientGdk::createModalDialog): (WebCore::ChromeClientGdk::show): (WebCore::ChromeClientGdk::canRunModal): (WebCore::ChromeClientGdk::runModal): (WebCore::ChromeClientGdk::setToolbarsVisible): (WebCore::ChromeClientGdk::toolbarsVisible): (WebCore::ChromeClientGdk::setStatusbarVisible): (WebCore::ChromeClientGdk::statusbarVisible): (WebCore::ChromeClientGdk::setScrollbarsVisible): (WebCore::ChromeClientGdk::scrollbarsVisible): (WebCore::ChromeClientGdk::setMenubarVisible): (WebCore::ChromeClientGdk::menubarVisible): (WebCore::ChromeClientGdk::setResizable): (WebCore::ChromeClientGdk::closeWindowSoon): (WebCore::ChromeClientGdk::canTakeFocus): (WebCore::ChromeClientGdk::takeFocus): (WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::addMessageToConsole): (WebCore::ChromeClientGdk::runJavaScriptAlert): (WebCore::ChromeClientGdk::runJavaScriptConfirm): (WebCore::ChromeClientGdk::runJavaScriptPrompt): (WebCore::ChromeClientGdk::setStatusbarText): (WebCore::ChromeClientGdk::shouldInterruptJavaScript): (WebCore::ChromeClientGdk::tabsToLinks): (WebCore::ChromeClientGdk::windowResizerRect): (WebCore::ChromeClientGdk::addToDirtyRegion): (WebCore::ChromeClientGdk::scrollBackingStore): (WebCore::ChromeClientGdk::updateBackingStore): (WebCore::ChromeClientGdk::mouseDidMoveOverElement): (WebCore::ChromeClientGdk::setToolTip): (WebCore::ChromeClientGdk::print):
- gtk/WebCoreSupport/ChromeClientGdk.h: Added.
2007-07-22 Holger Hans Peter Freyther <firstname.lastname@example.com>
Reviewed by Adam.
Make the GdkLauncher use the new WebKit/Gtk API. Change webkitdirs.pm to
honor --qmakearg for the Gdk/Gtk build as well.
- GdkLauncher/main.cpp: Switch to the new API
- Scripts/webkitdirs.pm: Allow to specify --qmakearg, e.g. to control the WEBKIT_{INC,LIB}_DIR
- 10:16 AM Changeset in webkit [24536] by
- 5 edits in trunk/WebKit/win
Implement IDOMElement::setAttribute
This method was mistakenly called "setResult" in DOMCore.idl, so I
fixed that as well.
Needed for <rdar://problem/5314906>.
Reviewed by Ada.
- DOMCoreClasses.cpp: (DOMElement::setAttribute): Implemented/renamed.
- DOMCoreClasses.h: Renamed setResult => setAttribute.
- DOMHTMLClasses.h: Ditto.
- Interfaces/DOMCore.idl: Ditto.
- 9:37 AM Changeset in webkit [24535] by
- 3 edits in trunk/WebKit
Reviewed by Oliver Hunt.
Expose [WebHTMLView hasMarkedText] to
fix <rdar://problem/4830074> autocomplete breaks Japanese typing
- WebView/WebHTMLView.mm:
- WebView/WebHTMLViewPrivate.h:
- 3:26 AM Changeset in webkit [24534] by
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- fix remaining problems with Window shadowing
- kjs/nodes.cpp: (VarDeclNode::evaluate): Tweak the special case a little.
- 1:48 AM Changeset in webkit [24533] by
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- fix Window shadowing regressions caused by the previous commit.
- kjs/nodes.cpp: (VarDeclNode::evaluate): Handle the case of global scope specially.
- 12:10 AM Changeset in webkit [24532] by
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
-fixed <rdar://problem/5353293> REGRESSION (r24287): 1% i-Bench JS slowdown from JavaScript compatibility fix (14719)
My fix for this actually resulted in JS iBench being 1% faster than before the regression
and the Celtic Kane benchmark being 5% faster than before the regression.
- kjs/nodes.cpp: (VarDeclNode::handleSlowCase): factored out the slow code path to be out of line. (VarDeclNode::evaluate): I did a couple of things: (1) Don't check if the variable is already declared by looking for the property in the variable object, that code path was dead code. (2) Special-case the common case where the top of the scope and the variable object are the same; in that case the variable must always be in the variable object. (3) Don't return a jsString() of the variable name, nothing uses the return value from this node types evaluate method.
- kjs/nodes.h:
Jul 22, 2007:
- 11:53 PM RunWebKitTestsDesign edited by
- (diff)
- 10:45 PM Changeset in webkit [24531] by
- 5 edits in trunk/WebCore
Reviewed by Adam.
<rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
- bindings/js/kjs_window.cpp:
- bindings/js/kjs_window.h: (KJS::Window::impl): inlined
- page/DOMWindow.cpp:
- page/DOMWindow.h: (WebCore::DOMWindow::frame): inlined
- 10:42 PM Changeset in webkit [24530] by
- 2 edits in trunk/LayoutTests
Fix typo.
- fast/dom/Window/window-function-name-getter-precedence.html:
- 10:30 PM Changeset in webkit [24529] by
- 2 edits in trunk/WebCore
- platform/ContextMenu.cpp: Added missing include.
- 10:28 PM Changeset in webkit [24528] by
- 3 edits2 adds in trunk
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
- fast/dom/Window/window-function-name-getter-precedence-expected.txt: Added.
- fast/dom/Window/window-function-name-getter-precedence.html: Added.
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
Test: fast/dom/Window/window-function-name-getter-precedence.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions before the custom name getter.
- 10:25 PM Changeset in webkit [24527] by
- 2 edits in trunk/WebCore
Reviewed by Adam.
- fix <rdar://problem/5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
- platform/ContextMenu.cpp: (WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function creates an object that's the caller's responsibility to delete. (WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap, since setSubMenu does not take ownership, and hence the objects were leaking. (WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto. (WebCore::createAndAppendSpellingSubMenu): Ditto. (WebCore::createAndAppendSpeechSubMenu): Ditto. (WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
- 10:00 PM Changeset in webkit [24526] by
- 2 edits6 adds in trunk/WebKitSite
Reviewed by Adam Roben.
Add information on getting a useful crash log on Mac and Windows.
- nav.inc:
- quality/crashlogs.html: Added.
- quality/mac_reportbox.jpg: Added.
- quality/mac_viewtrace.jpg: Added.
- quality/win_installwatson.jpg: Added.
- quality/win_watsongui.jpg: Added.
- quality/win_watsoninstalled.jpg: Added.
- 9:38 PM Changeset in webkit [24525] by
- 2 edits in trunk/WebKitTools
- DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]): Fix a leak by releasing the array used here.
- 7:59 PM RunWebKitTestsDesign edited by
- (diff)
- 7:59 PM RunWebKitTestsDesign edited by
- (diff)
- 7:53 PM RunWebKitTestsDesign edited by
- (diff)
- 7:53 PM RunWebKitTestsDesign edited by
- (diff)
- 7:51 PM RunWebKitTestsDesign edited by
- (diff)
- 3:47 PM Changeset in webkit [24524] by
- 4 edits in trunk
Reviewed by Kevin Decker.
- fix <rdar://problem/5126394> REGRESSION: Crash after clicking back button in test application (13250) http://bugs.webkit.org/show_bug.cgi?id=13250
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): If the object returns 0 for _imp, convert that to "undefined", since callers can't cope with a JSValue of 0.
Reviewed by Kevin Decker.
- fix <rdar://problem/5126394> REGRESSION: Crash after clicking back button in test application (13250) http://bugs.webkit.org/show_bug.cgi?id=13250
- bindings/objc/WebScriptObject.mm: (_didExecute): Removed unnecessary check for isValid() since the _rootObject method already takes care of that check. (-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject. (-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript. (-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. Added a second check of _isSafeScript after calling get to get the function object, since arbitrary changes could occur in there, including navigation to a new frame. This also takes care of null checking the second call to _imp. (-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject valueForKey:]): Ditto. (-[WebScriptObject removeWebScriptKey:]): Ditto. (-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed unnecessary local variable and const_cast from the call to the _imp method. (-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. (-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto. (-[WebScriptObject JSObject]): Ditto.
- 3:24 PM Changeset in webkit [24523] by
- 2 edits1 add in trunk/WebKitTools
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14713 Script to update iExploder cssproperties.in file based on CSSPropertyNames.in
Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
of WebCore/css/CSSPropertyNames.in. Also updated cssproperties.in.
- Scripts/update-iexploder-cssproperties: Added.
- iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script. Added new CSS3 property section and Moved box-sizing property to it.
- 2:10 PM Changeset in webkit [24522] by
- 4 edits1 move in trunk/LayoutTests
Reviewed by Sam.
Moving input method tests to editing/input/mac
- editing/input/mac: Copied from fast/events/inputmethods.
- fast/events/inputmethods: Removed.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Removed.
- fast/events/inputmethods/kotoeri.js: Removed.
- fast/events/inputmethods/logger.js: Removed.
- win/Skipped:
Reviewed by Sam.
Add Mac input methods to qt skip list
- Skipped:
- 1:32 PM Changeset in webkit [24521] by
- 1 edit in trunk/WebCore/ChangeLog
Updated reviewers.
- 1:31 PM Changeset in webkit [24520] by
- 3 edits in trunk/WebCore
Reviewed by Anders.
- speculative fix for <rdar://problem/5337500> CrashTracer: [USER] 4 crashes in Mail at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
- editing/markup.cpp: Added AttributeChange class. (WebCore::completeURLs): Changed function so that all the URL completion is done in a separate pass after finding all the URL attributes. This is safer, since actually applying an attribute change could have any arbitrary effect on the document; it's tricky to iterate a document while it's being modified and we don't have the checks here that would be needed to make that work in pathological cases.
- 1:02 PM Changeset in webkit [24519] by
- 2 edits in trunk/LayoutTests
Reviewed by Adam.
Add the input methods tests to the windows skip list
until we work to how to make them platform agnostic
- win/Skipped:
- 12:51 PM Changeset in webkit [24518] by
- 1 edit in trunk/WebCore/ChangeLog
Update Bugzilla bug number in Radar bug title based on feedback from Mitz.
- 12:46 PM Changeset in webkit [24517] by
- 5 edits5 adds in trunk
Reviewed by Darin.
Initial input method test case, this tests the behaviour of the
enter key in our "kotoeri" engine.
- fast/events/inputmethods: Added.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Added.
- fast/events/inputmethods/kotoeri.js: Added.
- fast/events/inputmethods/logger.js: Added.
Reviewed by Darin.
Add preliminary support for testing Input Method/WebKit behaviour and interaction
in DRT. This provides the NSTextInput API which is most of what should be necessary
to mimic the event sequences Input Methods trigger.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TextInputController.h:
- DumpRenderTree/TextInputController.m: (-[WebHTMLView interpretKeyEvents:]): (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController initWithWebView:]): (-[TextInputController dealloc]): (-[TextInputController textInput]): (-[TextInputController setInputMethodHandler:]): (-[TextInputController interpretKeyEvents:withSender:]):
- 12:43 PM Changeset in webkit [24516] by
- 2 edits in trunk/WebCore
Reviewed by Adam.
- fix <rdar://problem/5350604> REGRESSION: Crash in inspector controller code after clicking back button in test application (13250)
- page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource): Replace an assertion that was firing with some code that at least doesn't immediately crash.
- 12:08 PM Changeset in webkit [24515] by
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 11:43 AM Changeset in webkit [24514] by
- 2 edits in trunk/WebCore
Reviewed by Anders.
- improve the fix for <rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
- loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all the resources so they don't try to use a stale DocLoader pointer later.
Jul 21, 2007:
- 3:29 PM Changeset in webkit [24513] by
- 4 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fixed typos and markup in the following manual tests
- manual-tests/accidental-strict-mode.html:
- manual-tests/caretScrolling.html:
- manual-tests/close-on-closedWindow.html:
- 3:27 PM Changeset in webkit [24512] by
- 7 edits in trunk
Reviewed by Mitz.
Update tests for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value
- fast/css/computed-style-expected.txt:
- fast/css/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle-background-position-expected.txt:
Reviewed by Mitz.
Patch for <rdar://problem/5352013>
The computed style for background-position is wrong for the initial value
- Set the initial value for background-position-x and background-position-y (and therefore background-position) to 0% instead of 0px.
- rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::BackgroundLayer):
- rendering/RenderStyle.h: (WebCore::RenderStyle::initialBackgroundXPosition): (WebCore::RenderStyle::initialBackgroundYPosition):
- 3:07 PM Changeset in webkit [24511] by
- 2 edits in trunk/WebKit/win
2007-07-21 Ada Chan <firstname.lastname@example.com>
Reviewed by Adam.
Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
Need to set the last visited time before calling WebHistory::addItem().
- WebHistory.cpp: (WebHistory::addItemForURL):
- 2:38 PM Changeset in webkit [24510] by
- 2 edits in trunk/WebKit
Fix REGRESSION: Right-click/control-click broken
Reviewed by Mitz.
- WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): Update defaultItemsCount after removing items from the defaultItems array.
- 4:41 AM Changeset in webkit [24509] by
- 2 edits in tags/Safari-5522.12/WebCore
Merge r24468.
2007-07-20 Mark Rowe <firstname.lastname@example.com>
Reviewed by Maciej.
Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
to avoid creating a global initializer. This fixes the build for x86_64.
- loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
- 4:41 AM Changeset in webkit [24508] by
- 2 edits in tags/Safari-5522.12/WebKit
Merge r24442.
Fix <rdar://problem/5344972> REGRESSION: A error dialog occurs when attempting to ctrl-click in a iChat message window (webview)
Reviewed by Oliver.
- WebCoreSupport/WebContextMenuClient.mm:
(fixMenusToSendToOldClients): Don't check for the Inspect Element item
if we have fewer than 2 items.
- 4:10 AM Changeset in webkit [24507] by
- 4 edits in trunk
- 4:09 AM Changeset in webkit [24506] by
- 1 copy in tags/Safari-5522.12
New tag.


text:
New Movies in Sioux Falls Theaters
Here's a look at what's new in Sioux falls and area theaters. Scroll down for theaters and showtimes.
Opening February 21st:
Pompeii (Action / Drama - Rated PG-13) A slave-turned-gladiator finds himself in a race against time to save his true love, who has been betrothed to a corrupt Roman Senator. As Mount Vesuvius erupts, he must fight to save his beloved as Pompeii crumbles around him.
3 Days to Kill (Action / Thriller - Rated PG-13) A dying Secret Service Agent trying to reconnect with his estranged daughter is offered an experimental drug that could save his life in exchange for one last assignment. Starring Kevin Costner
BONUS: Divergent (In theaters & IMAX March 21, 2014)
West Mall 7 (All seats $3.00)

subset: commoncrawl


text:
(Full disclosure: I'm already an active participant here and at StackOverflow, but for reasons that should hopefully be obvious, I'm choosing to ask this particular question anonymously).
I currently work for a small software shop that produces software that's sold commercially to manage small- to mid-size business in a couple of fairly specialized industries. Because these industries are customer-facing, a large portion of the software is related to storing and managing customer information. In particular, the storage (and securing) of customer credit card information. With that, of course, comes PCI compliance.
To make a long story short, I'm left with a couple of questions about why certain things were done the way they were, and I'm unfortunately without much of a resource at the moment. This is a very small shop (I report directly to the owner, as does the only other full-time employee), and the owner doesn't have an answer to these questions, and the previous developer is...err...unavailable.
Issue 1: Periodic Re-encryption
As of now, the software prompts the user to do a wholesale re-encryption of all of the sensitive information in the database (basically credit card numbers and user passwords) if either of these conditions is true:
There are any NON-encrypted pieces of sensitive information in the database (added through a manual database statement instead of through the business object, for example). This should not happen during the ordinary use of the software.
The current key has been in use for more than a particular period of time. I believe it's 12 months, but I'm not certain of that. The point here is that the key "expires".
This is my first foray into commercial solution development that deals with PCI, so I am unfortunately uneducated on the practices involved. Is there some aspect of PCI compliance that mandates (or even just strongly recommends) periodic key updating?
This isn't a huge issue for me other than I don't currently have a good explanation to give to end users if they ask why they are being prompted to run it.
Question 1: Is the concept of key expiration standard, and, if so, is that simply industry-standard or an element of PCI?
Issue 2: Key Storage
Here's my real issue...the encryption key is stored in the database, just obfuscated. The key is padded on the left and right with a few garbage bytes and some bits are twiddled, but fundamentally there's nothing stopping an enterprising person from examining our (dotfuscated) code, determining the pattern used to turn the stored key into the real key, then using that key to run amok. This seems like a horrible practice to me, but I want to make sure that this isn't just one of those "grin and bear it" practices that people in this industry have taken to. I have developed an alternative approach that would prevent such an attack, but I'm just looking for a sanity check here.
Question 2: Is this method of key storage--namely storing the key in the database using an obfuscation method that exists in client code--normal or crazy?
Believe me, I know that free advice is worth every penny that I've paid for it, nobody here is an attorney (or at least isn't offering legal advice), caveat emptor, etc. etc., but I'm looking for any input that you all can provide. Thank you in advance!


text: Welcome to the place I chose to be the vault for all the little treasures that have to be cherished! In light of that I've decided to make my fairy cocoon brooches collection the birthmark of this blog. I hope for new ideas to flourish and spring with life just as little fairies break free from the silken and lustrous cocoons and bring beautiful magic to the world.


text:
Melbourne Showgrounds is Melbourne's largest and most versatile venue, offering unique and flexible indoor and outdoor spaces designed to host a variety of events and activities including trade shows, exhibitions, expos, festivals and much, much more.
10,000sqm indoor contemporary exhibition and events space located at the Epsom Road entry point to Melbourne Showgrounds. Exhibition Pavilion features concrete floors, single/three phase power, gas radiant heating, toilet facilities, ATM, wireless internet and excellent access.
Exhibition Pavilion is suitable for a variety of exhibitions and events.
A 3,000sqm clear span pavilion, perfectly situated to support events already utilising Exhibition Pavilion or Expo Hall, Boulevard Pavilion is ideal for exhibitions, product displays and tradeshows.
A 2,135sqm opulent and historic space, with a number of intimate function rooms with climate control and internal toilet facilities.
Royal Block is the ideal location for functions, banquets, conferences, exhibitor retreats and more.
Located in the centre of Melbourne Showgrounds is the visually spectacular Grand Pavilion. At 8,000sqm and spanning almost half the size of the playing surface of the MCG, Grand Pavilion features multiple access points, wireless internet and single/three phase power ideal for large-scale tradeshows and corporate events.
A 2,000sqm two storey large steel frame structure with climate control, multiple entry points, vehicular access, concrete flooring, single/three phase power and toilet facilities, Town Square Pavilion is an ideal location for exhibitions, displays and tradeshows.
A 1,500sqm heritage-listed brick pavilion with concrete flooring, and a large clear interior. Restored to create the perfect atmosphere for exhibitions, tradeshows, television advertising location and special events.
A 1,300sqm undercover space with the freedom of being outdoors and the comfort of covered roofing, with tiered grandstand seating for 750 people, the possibilities are endless.
A 1,900sqm modern, permanently carpeted large open space with vehicular access and weight bearing floors, RASV Centre is suitable for tradeshows, retail events, examinations, TV productions and more.
The Main Arena is a showcase venue featuring a 9,000sqm grassed area with flood lighting and permanent grandstand seating for over 4,300 people.
11,000sqm of grassed outdoor space with grandstand seating for 2,275 people and the capability to host an array of events such as music festivals, exhibitions, graduations and social events.
Want to know what's happening at Melbourne Showgrounds? Whether you are planning an event or attending an event, be the first to know the latest news, event updates and venue information by signing up to the Melbourne Showgrounds email subscription.
SubscribeDo you live or work close to Melbourne Showgrounds?
Melbourne Showgrounds notification service ensures residents and businesses in close proximity of the venue are kept up to date with information regarding forthcoming events including traffic management and public transport detail, schedules, expected crowds, event content and contact details.
If you would like to receive these notifications via email or SMS, simply register your details here.


text:
Barbara Walters' 'Most Fascinating People of 2011′ List Contains Dangerously High Levels of Kardashian
Every year, Barbara Walters releases her list of the 'Most Fascinating People of the Year.' The 2011 list includes a couple of people you could probably guess would be on the list.
It also includes more than a few people that will make you scratch your head and ask "did they change the meaning of the word 'fascinating'?" (Yes, the Kardashians are on the list.)
This year's list includes every single member of the Kardashian Klan (though thankfully they count as only one entry) 'X Factor' head honcho Simon Cowell, Royal relative Pippa Middleton, Donald Trump, 'Modern Family' stars Eric Stonestreet and Jesse Tyler Ferguson, Yankees shortstop Derek Jeter and singer Katy Perry. What, no Ryan Gosling? The internet will not be pleased.
The number one pick won't be revealed until the show airs on December 14. Any guesses? Let us know below. (Our pick is "No No No Cat.")
[via Hollywood Reporter]


text:
James Morris hails from Rio Rancho, NM and has been playing fantasy sports for just over 15 years. Not only does he write the Bengals fantasy section, but he also does the Miami Dolphins fantasy section. Crossing over, Morris writes the fantasy sections for the Minnesota Timberwolves in the NBA. Just send him an email and he will reply back the same day with your answer. Or, find him on Twitter (Fantasyguy23) and get all your NFL news before it hits the national media. *
One of the most underrated fantasy players in all fantasy football has to be Andy Dalton. Heck, he could be one of the most underappreciated players in the NFL if you look at what the national media says about him most weeks. The truth is fantasy football is all about statistics; it takes out human emotion and bias and JUST looks at what a player does on the field.
So far this season Dalton is ranked 11th on NFL.com for fantasy QBs, which is better than guys like Tom Brady, Colin Kaepernick and Michael Vick, all of which are owned in more NFL.com leagues than Dalton.
While Dalton is owned in 83.7 percent of NFL.com leagues, he is started in just 12.5 percent of them. Meaning, he is sitting on people's benches while they start guys like Brady, Kaepernick and Alex Smith. That's right, Smith is owned in 58.1 percent of NFL.com leagues, but started in 16.7 percent of them and ranks out two spots below Dalton at 13th for QBs.
The point I was trying to make Bengals fans is you should never listen to those big box websites or national media on who is good and who is not. They are often wrong and almost always have their opinions skewed by some bias that has little to not merit. If you look at the stats and take your personal opinion out of the equation like I do, then you will find that you'll be right more times than you are wrong! WHO DEY!
Andy Dalton – QB, Bengals: Even though Dalton is ranked 11th overall for fantasy QBs on NFL.com, I've seen him ranked as low as 16th by a major fantasy website. The Jets are giving up 18.4 fantasy PPG this season, but Dalton now has Marvin Jones playing opposite A.J. Green and that is stabilizing the WR corps. Dalton is a good fill-in option for those with their QB on a bye.
Colin Kaepernick – QB, 49ers: If there was ever a week to play Kaepernick and all other 49ers players, it would be this one. The Jaguars are a mess on offense and defense, making them a great team to shadow with fantasy players all season long. Even though I am not a fan of the WR weapons the 49ers have, I am positive that they will find a way to put up quality fantasy stats across the board given the even more pronounced problems the Jaguars have.
Zac Stacy – RB, Rams: With the Rams losing their QB for the season, Stacy and the running game will play an even more prominent role within the offense going forward. As you'll see below, I think the passing game is in for some rough times this week and the running game is what they are going to fall back on when the QB struggles. Stacy is a top-tier RB2 this week just because of the touches I think he will see.
Fred Jackson – RB, Bills: With C.J. Spiller almost a lock to miss Week 8, that leaves Jackson as the starting running back for the Bills. The Saints give up 17.5 fantasy PPG this season to RBs, and Jackson has finished with single-digit fantasy totals in just one week this season on NFL.com's standard scoring format. Jackson is in the upper portion of the RB2 rankings, but has real upside into the RB1 rankings.
Jarrett Boykins – WR, Packers: Boykins took over for Randall Cobb after his injury and didn't fail to impress in Week 7 with his 103 receiving yards and a touchdown against the Browns. This week he gets the Vikings and they have allowed the 10th-most fantasy points to WRs each week with an average of 14.7 PPG. Right now he is owned in just 39.6 percent of NFL.com leagues, and that number should be about double. Aaron Rodgers can make even a backup WR a fantasy stud.
Terrence Williams – WR, Cowboys: With so much attention paid to Dez Bryant, Williams has the unique ability to get open and not have to worry about teams bringing help from a safety. This week the Cowboys take on a Lions defense that gives up 26.7 fantasy PPG to WRs this season, sixth worst in the NFL. Williams has pushed Miles Austin to the bench and he is a must-own player (48.5 percent owned on NFL.com) in the second half of the season.
Jordan Reed – TE, Redskins: The Florida Gators product made a statement last week with his 9 receptions for 134 yards and a touchdown against the Bears. Robert Griffin III seems to have found himself a new toy to play with and that is just fine for fantasy owners as they are scrambling to fill in for bye-week players and injured guys like Jermichael Finley. The Broncos allow 9.8 fantasy PPG to TEs this season, which is right below the Bears at 9.9. So, if he can light up the Bears for 9/134/1, he should have success again this week against the Broncos.
New Orleans Saints Defense: This week the Saints figure to jump out to an early lead and cause the Bills to play catch-up ball for most of the game. Playing from behind means throwing, and that usually means forcing the ball, which in turn usually leads to turnovers. The Saints are a solid low-end starting fantasy defense for those who normally use one of the bye week defenses.
Kellen Clemens – QB, Rams: The ONLY reason Clemens made this list is because NFL.com has him projected to finish with the ninth-most fantasy points for a QB at 20.68. That is absolutely absurd considering the Seahawks allow just 14.9 fantasy PPG to QBs (third best in the NFL), and Sam Bradford only managed those points one time this season (Week 2 against the Falcons he scored 26.58). Bradford is clearly head and shoulders above Clemens as a QB, yet NFL.com thinks Clemens is going have more success with the same weapons.
Terrelle Pryor – QB, Raiders: Pryor has been picked up in about 40 percent of NFL.com leagues since the start of the season after being drafted in about four percent of them to start. This week the Raiders take on the Steelers and once again NFL.com has the projections wrong! They are projecting Pryor to finish with the third-most fantasy points this week (25.28) despite playing the Steelers, who boast the second-best defense at stopping fantasy QBs with 14.1 fantasy PPG allowed. This is EXACTLY why you don't listen to the projections that come from NFL.com, ESPN.com, Yahoo.com, CBSSportsline.com, etc. They often make absolutely no sense and can't even be rationalized with stats.
Chris Ivory – RB, Jets: Last week Ivory broke out for 104 yards on the ground against the Patriots, so fantasy owners immediately put him in their lineups for this week. Not so fast. The Bengals defense is ninth in the NFL against fantasy RBs with 14.7 PPG allowed, whereas the Patriots are 18th in the NFL and give up 17.6 PPG. I don't think he will find as many open lanes this week and is likely to fall into the low-end RB2 or flex rankings when the final whistle blows.
Joseph Randle – RB, Cowboys: As quickly as Randle's fantasy star rose, it came crashing back to Earth with DeMarco Murray back in the lineup. Murray may not play a full complement of snaps this week, but he is sure to play enough to stalemate any value that Randle would have provided. At best Randle can hope for some random score on some odd play, but that's not something I would bet on in Week 8 of the fantasy football season.
Dwayne Bowe – WR, Chiefs: The Chiefs are the only undefeated team left in the NFL (7-0), but the mark has to be bittersweet for Bowe, who is owned in 86.3 percent of NFL.com leagues. And ranked 54th among WRs. As sad as it is, Bowe's highest totals this season are 5 catches and 66 yards receiving in a game. This week he takes on the Browns and cover-corner Joe Haden, and that is not a matchup I see him winning. If Boykins is available in your league still, I'd cut Bowe for him.
Marques Colston – WR, Saints: This is the one prediction I truly think could actually go 180 degrees in the opposite direction. Just as easily as I could see Colston being a complete dud like he has been for most of the season, I could also see him racking up 7-9 catches with 150 yards receiving and a TD or two. Jimmy Graham is likely out this week, meaning Drew Brees will need someone to throw to against the generous Bills defense (second-most fantasy points allowed to WRs with 33.1 PPG). History has a way of repeating itself, and Colston has been a complete and total non-factor in too many games this season to bet against.
Joseph Fauria – TE, Lions: The problem with guys like Fauria is they have one good week (34 yards receiving and 3 TDs in Week 6), and those waiver wire trolls that are in every league run to their computer and pick them up. Fauria followed up those Week 6 numbers with one catch for 14 yards (four targets) and no touchdowns in Week 7. Fauria is a classic example of fantasy owners chasing points, which you should NEVER do. We all missed the 3 TD week; suck it up and drive on!
Arizona Cardinals Defense: Once you get past the top 4-5 defenses, the next 7-8 are all bunched up into the same rankings really. Normally the Cardinals are in that top 4-5 group, but this week they run into a Falcons team that did quite well last week without star WR Julio Jones and starting RB Steven Jackson. This week the Falcons get Jackson back, but will still be without Roddy White. Even with Harry Douglas as the team's No. 1 WR, Matt Ryan proved he can make plays no matter who is out there on the field for his team. The Cardinals are a low-end starting defense this week, and I would much rather see the Saints or Steelers defenses in my lineup.
Remember, You can email me, follow me on Twitter, or find me on Facebook to get your fantasy fix and have your questions answered.