text:
Mar 29, 2009:
- 7:49 PM Changeset in webkit [42097] by
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <email@example.com>
Requested by Antti Koivisto.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added a better comment.
- 7:21 PM Changeset in webkit [42096] by
- 3 edits2 adds in trunk
2009-03-29 Darin Adler <firstname.lastname@example.com>
Reviewed by Dan Bernstein.
Bug 23445: Copying certain hidden text causes a crash
Test: editing/pasteboard/copy-display-none.html
- editing/markup.cpp: (WebCore::createMarkup): Added a check for the case where adjusting the start node moves the start of the selection past the end of the range entirely. If we try to iterate we'll never hit the end of the range and will probably crash iterating the rest of the document.
2009-03-29 Darin Adler <firstname.lastname@example.com>
Reviewed by Dan Bernstein.
Bug 23445: Copying certain hidden text causes a crash
- editing/pasteboard/copy-display-none-expected.txt: Added.
- editing/pasteboard/copy-display-none.html: Added.
- 6:59 PM Changeset in webkit [42095] by
- 3 edits in trunk/WebCore
2009-03-29 Darin Adler <firstname.lastname@example.com>
Reviewed by Dan Bernstein.
Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
but there is an Apple-internal website I was able to use to reproduce and fix.
- loader/CachedResource.h: Made makePurgeable public.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable so we can get its data if it hasn't yet been purged.
- 5:06 PM Changeset in webkit [42094] by
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <email@example.com>
Fix build again.
- loader/EmptyClients.h: Fix typo in name of FormState.h.
- 4:53 PM Changeset in webkit [42093] by
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <email@example.com>
Try to fix the release build.
- history/CachedPage.cpp: Make include unconditional, not debug-only.
- 4:51 PM Changeset in webkit [42092] by
- 2 edits in trunk/WebCore
Undo the previous build fix.
- 4:44 PM Changeset in webkit [42091] by
- 2 edits in trunk/WebCore
Fix build break.
- 4:29 PM Changeset in webkit [42090] by
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog.
- 4:29 PM Changeset in webkit [42089] by
- 3 edits in trunk/WebCore
2009-03-29 Dmitry Titov <firstname.lastname@example.com>
Reviewed by Darin Adler.
Fix Chromium build break.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
- 4:26 PM Changeset in webkit [42088] by
- 2 edits in trunk/WebCore
2009-03-29 Dmitry Titov <email@example.com>
Reviewed by Darin Adler.
Fix Chromium build break.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
- 11:09 AM Changeset in webkit [42087] by
- 2 edits in trunk/WebCore
2009-03-29 Darin Adler <firstname.lastname@example.com>
Another attempt to fix the Qt build.
- WebCore.pro: Added CheckedRadioButtons.cpp.
- 11:00 AM Changeset in webkit [42086] by
- 3 edits in trunk/WebKit/qt
2009-03-29 Darin Adler <firstname.lastname@example.com>
Try to fix Qt build.
- WebCoreSupport/EditorClientQt.cpp: Added include of HTMLElement.h.
- WebCoreSupport/FrameLoaderClientQt.cpp: Added include of FormState.h. (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): Removed unneeded call to detachChildren, which is called by FrameLoader right after this. (WebCore::FrameLoaderClientQt::createFrame): Use loadURLIntoChildFrame as other platforms do in the corresponding functions.
- 10:31 AM Changeset in webkit [42085] by
- 2 edits in trunk/WebKitTools
2009-03-29 Darin Adler <email@example.com>
- DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix Qt building of DumpRenderTree.
- 10:15 AM Changeset in webkit [42084] by
- 34 edits2 copies in trunk
2009-03-29 Darin Adler <firstname.lastname@example.com>
Reviewed by Cameron Zwarich.
Bug 24921: remove include of HTMLFormElement.h from Document.h
- GNUmakefile.am: Added CheckedRadioButtons source files.
- WebCore.scons: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
- dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
- dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
- dom/Document.h: Removed unneeded includes, including HTMLFormElement.h. Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
- dom/Node.idl: Changed the type of parentElement from Node to Element for two reasons. 1) Node was incorrect, since parentElement returns an Element. 2) The bindings won't compile any more unless they know parentElement's return value is an Element due to include changes.
- html/HTMLFormElement.cpp: Moved definitions of the functions in the CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
- html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons class to the new CheckedRadioButtons.h.
- html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
- page/Chrome.cpp: (WebCore::Chrome::createWindow): Tweaked formatting.
- css/CSSGrammar.y: Added newly-needed include.
- dom/Range.cpp: Ditto.
- editing/BreakBlockquoteCommand.cpp: Ditto.
- editing/CompositeEditCommand.cpp: Ditto.
- editing/InsertLineBreakCommand.cpp: Ditto.
- editing/ModifySelectionListLevel.cpp: Ditto.
- editing/RemoveFormatCommand.cpp: Ditto.
- editing/TextIterator.cpp: Ditto.
- editing/VisiblePosition.cpp: Ditto.
- loader/DocLoader.cpp: Ditto.
- page/AccessibilityRenderObject.cpp: Ditto.
- page/Page.cpp: Ditto.
- rendering/RenderBlock.cpp: Ditto.
- rendering/RenderLayer.cpp: Ditto.
- rendering/RenderObject.h: Ditto.
- storage/LocalStorageArea.cpp: Ditto.
- storage/SessionStorageArea.cpp: Ditto.
2009-03-29 Darin Adler <email@example.com>
Reviewed by Cameron Zwarich.
- Plugins/WebNullPluginView.mm: Added now-needed includes.
- WebView/WebHTMLRepresentation.mm: Ditto.
- WebView/WebHTMLView.mm: Ditto.
- 10:14 AM Changeset in webkit [42083] by
- 2 edits in trunk/LayoutTests
2009-03-29 Darin Adler <email@example.com>
Reviewed by Cameron Zwarich.
- fast/forms/targeted-frame-submission.html: Fixes from review comments.
- 10:11 AM Changeset in webkit [42082] by
- 22 edits in trunk
2009-03-29 Darin Adler <email@example.com>
Reviewed by Cameron Zwarich.
Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
Don't rely on delegate methods to guess whether a queued step starts a load or not, because
script-triggered loads can't be detected that way. Instead have the steps themselves indicate
whether or not a load was triggered.
- DumpRenderTree/LayoutTestController.cpp: (queueLoadingScriptCallback): Added. Version for scripts that perform loads. (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads. (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and queueNonLoadingScript. (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now. (LayoutTestController::queueForwardNavigation): Ditto. (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's platform-independent. (LayoutTestController::queueNonLoadingScript): Ditto. (LayoutTestController::queueReload): Moved here since it's platform-independent now.
- DumpRenderTree/LayoutTestController.h: Ditto.
- DumpRenderTree/WorkQueue.cpp: (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
- DumpRenderTree/WorkQueue.h: Ditto.
- DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item started a load. Removed unused getter functions. Made invoke functions private. Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (processWork): Use the new WorkQueue::processWork function to implement the new rule.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement the new rule.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/mac/WorkQueueItemMac.mm: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement the new rule. Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement the new rule.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
- DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): Return false when we fail, true when we succeed. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
2009-03-29 Darin Adler <firstname.lastname@example.com>
Reviewed by Cameron Zwarich.
Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
- fast/forms/targeted-frame-submission.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
- http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a script that can instead just be run immedidately.
- http/tests/navigation/onload-navigation-iframe-timeout.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
- http/tests/navigation/onload-navigation-iframe.html: Ditto.
- http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of queueScript for scripts that don't involve submitting a form. Use queueLoadingScript for scripts that do involve submitting a form.
- 8:37 AM Changeset in webkit [42081] by
- 4 edits2 adds in trunk
2009-03-29 Darin Adler <email@example.com>
Reviewed by Dan Bernstein.
<rdar://problem/6015407> attr parsing should allow only identifiers
Test: fast/css/attr-parsing.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out identifiers that start with "-".
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test case works. This has the pleasant side effect of fixing a bug too.
2009-03-29 Darin Adler <email@example.com>
Reviewed by Dan Bernstein.
<rdar://problem/6015407> attr parsing should allow only identifiers
- fast/css/attr-parsing-expected.txt: Added.
- fast/css/attr-parsing.html: Added.
- 8:17 AM Changeset in webkit [42080] by
- 1 edit4 adds in trunk/LayoutTests
2009-03-29 Darin Adler <firstname.lastname@example.com>
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
Landed the test case from this bug. The bug was fixed by the fix for bug 24740 below.
- fast/forms/range-thumb-height-percentage.html: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Added.
- 2:45 AM Changeset in webkit [42079] by
- 2 edits in trunk/WebCore
<rdar://problem/6492712> Cross-origin redirects are not handled correctly.
Forgot to save the file after applying changes for review comments.
- 2:16 AM Changeset in webkit [42078] by
- 5 edits4 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6492712> Cross-origin redirects are not handled correctly.
Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::WebCoreSynchronousLoader::willSendRequest): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge): (WebCore::WebCoreSynchronousLoader::load): Match Mac behavior more closely - we shouldn't rely on underlying library handling of synchronous requests.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest delegate method for a redirect.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Match async behavior more closely.
Mar 28, 2009:
- 10:27 PM Changeset in webkit [42077] by
- 2 edits in trunk/WebKitTools
Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.
- 5:16 PM Changeset in webkit [42076] by
- 2 edits in trunk/WebCore
2009-03-28 Darin Adler <email@example.com>
Reviewed by Mark Rowe.
Bug 24914: empty-string assertion crash when running storage tests
- storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Don't store empty version strings in the map, since empty strings are per-thread.
- 2:16 PM Changeset in webkit [42075] by
- 2 edits in trunk/WebKit/gtk
2009-03-28 Xan Lopez <email@example.com>
Reviewed by Mark Rowe.
[GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function
Set the right visibility to the WebKitSoupAuthDialog get_type
- webkit/webkitsoupauthdialog.h:
- 1:17 PM Changeset in webkit [42074] by
- 2 edits in trunk/WebKit/wx
wx build fix. Remove call to now private method.
- 11:43 AM Changeset in webkit [42073] by
- 4 edits in trunk/WebCore
2009-03-28 Dmitry Titov <email@example.com>
Reviewed by Dimitri Glazkov.
Fixes for Chromium build.
- bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
- bindings/v8/custom/V8CustomEventListener.h: ditto.
- dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.
- 9:59 AM Changeset in webkit [42072] by
- 2 edits1 delete in trunk/WebCore
2009-03-28 Dimitri Glazkov <Dimitri Glazkov>
Not reviewed, correcting landing error.
Custom bindings should be in v8/custom, not v8.
- bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.
- 9:48 AM Changeset in webkit [42071] by
- 1 edit1 add in trunk/WebCore
2009-03-28 Mike Belshe <email@example.com>
Reviewed by Dimitri Glazkov.
Add V8 custom bindings for DOMWindow.
- bindings/v8/custom/V8DOMWindowCustom.cpp: Added.
- 9:24 AM Changeset in webkit [42070] by
- 1 edit1 add in trunk/WebCore
2009-03-28 Mike Belshe <firstname.lastname@example.com>
Reviewed by Dimitri Glazkov.
Add V8 custom bindings for HTMLDocument.
- bindings/v8/V8HTMLDocumentCustom.cpp: Added.
- 1:55 AM Changeset in webkit [42069] by
- 3 edits in trunk/WebKit/gtk
2009-03-28 Jan Michael Alonzo <email@example.com>
Gtk build fix. Not reviewed.
FrameLoader::loadURL and FrameLoader::detachChildren went private
per changes in http://trac.webkit.org/changeset/42055. Follow
Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
loadURL and FrameLoader::detachParent for detachChildrem.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
- webkit/webkitwebview.cpp:
Mar 27, 2009:
- 10:11 PM Changeset in webkit [42068] by
- 2 edits in trunk/JavaScriptCore
Fix non-AllInOneFile builds.
- 9:04 PM Changeset in webkit [42067] by
- 3 edits1 add1 delete in trunk/LayoutTests
Update text-content-type-with-binary-extension.html to use a .sitx file of random data rather
than a .m4a to ensure that WebKit doesn't handle the resource as a full-frame media element if the network
layer sniffs it as audio/mp4 rather than application/octet-stream.
Rubber-stamped by Dan Bernstein.
- http/tests/loading/resources/.htaccess:
- http/tests/loading/resources/binaryData.m4a: Removed.
- http/tests/loading/resources/binaryData.sitx: Added.
- http/tests/loading/text-content-type-with-binary-extension.html:
- 9:04 PM Changeset in webkit [42066] by
- 1 edit in trunk/LayoutTests/platform/mac-snowleopard/Skipped
Fix syntax of Skipped file.
- 8:50 PM Changeset in webkit [42065] by
- 16 edits3 adds in trunk
Improve performance of Function.prototype.call
Reviewed by Gavin Barraclough
Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.
When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.
- 7:54 PM Changeset in webkit [42064] by
- 2 edits in trunk/LayoutTests
Skip two plug-in tests that are failing due to <rdar://problem/6733642>.
Rubber-stamped by Oliver Hunt.
- platform/mac-snowleopard/Skipped:
- 7:46 PM Changeset in webkit [42063] by
- 3 edits2 copies4 moves1 add in trunk/LayoutTests
Land updated results for two SVG tests involving Geeza Pro.
Rubber-stamped by Dan Bernstein.
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum.
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
- platform/mac-leopard/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.checksum.
- platform/mac-leopard/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
- platform/mac-leopard/svg/text/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt.
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- 7:40 PM Changeset in webkit [42062] by
- 4 edits in trunk/WebCore
Fix two SVG test failures in 64-bit.
Reviewed by Sam Weinig.
getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings. In 32-bit this was
identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.
The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
but requires an exception be thrown when a negative value is passed. This results in the JS bindings handling the
check for a negative value and lets the implementation treat the arguments purely as unsigned values.
- svg/SVGTextContentElement.cpp:
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- 5:49 PM Changeset in webkit [42061] by
- 3 edits in trunk/WebCore
2009-03-27 Darin Adler <firstname.lastname@example.com>
Reviewed by Sam Weinig.
Get mailto code out of FrameLoader.
- html/HTMLFormElement.cpp: (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto logic so HTMLFormElement::submit isn't full of ugly bits. This includes the part of the logic that involves transformeing the URL that was previously inside FrameLoader. (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and also release the data for slightly less refcount churn.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto, since HTMLFormElement now properly prepares both the URL and the form data.
- 5:41 PM Changeset in webkit [42060] by
- 5 edits in trunk/WebCore
Reviewed by Mark Rowe.
- fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Changed to use EOTHeader. (WebCore::createFontCustomPlatformData): Ditto.
- platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to the size of an EOTPrefix. (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in the prefix. (WebCore::EOTHeader::appendBigEndianString): Changed the static appendBigEndianStringToEOTHeader() into this member function. (WebCore::EOTHeader::appendPaddingShort): Added. (WebCore::getEOTHeader): Changed to use EOTHeader.
- platform/graphics/opentype/OpenTypeUtilities.h: (WebCore::EOTHeader::size): (WebCore::EOTHeader::data): (WebCore::EOTHeader::prefix):
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Changed to use EOTHeader. (WebCore::createFontCustomPlatformData): Ditto.
- 5:06 PM Changeset in webkit [42059] by
- 2 edits in trunk/WebKit
2009-03-27 Darin Adler <email@example.com>
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 5:06 PM Changeset in webkit [42058] by
- 2 edits in trunk/WebKitTools
2009-03-27 Darin Adler <email@example.com>
Reviewed by Sam Weinig.
- Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.
- 4:55 PM Changeset in webkit [42057] by
- 19 edits in trunk/LayoutTests
2009-03-27 Darin Adler <firstname.lastname@example.com>
Reviewed by Sam Weinig.
Made our mailto form submission tests work more reliably by using the new
layoutTestController.waitForPolicyDelegate function.
- fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate rather than relying on the form submission happening immediately.
- fast/forms/mailto/advanced-get.html: Ditto.
- fast/forms/mailto/advanced-put.html: Ditto.
- fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
- fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
- fast/forms/mailto/get-multiple-items.html: Ditto.
- fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
- fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
- fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
- fast/forms/mailto/get-non-ascii.html: Ditto.
- fast/forms/mailto/get-overwrite-query.html: Ditto.
- fast/forms/mailto/post-append-query.html: Ditto.
- fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
- fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
- fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
- fast/forms/mailto/post-multiple-items.html: Ditto.
- fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
- fast/forms/mailto/post-text-plain.html: Ditto.
- 4:55 PM Changeset in webkit [42056] by
- 15 edits in trunk/WebKitTools
2009-03-27 Darin Adler <firstname.lastname@example.com>
Reviewed by Sam Weinig.
Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
tests work.
- DumpRenderTree/AccessibilityController.cpp: (getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's no reason to use reinterpret_cast just to get from void* to a specific type. (getRootElementCallback): Ditto.
- DumpRenderTree/AccessibilityUIElement.cpp: (toAXElement): Ditto.
- DumpRenderTree/GCController.cpp: (collectCallback): Ditto. (collectOnAlternateThreadCallback): Ditto. (getJSObjectCountCallback): Ditto.
- DumpRenderTree/LayoutTestController.cpp: (many functions): Ditto. (waitForPolicyDelegateCallback): Added. (LayoutTestController::staticFunctions): Sorted functions by name. Added waitForPolicyDelegate.
- DumpRenderTree/LayoutTestController.h: Sorted functions by name. Added waitForPolicyDelegate.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the policy delegate. (runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just before loading an empty page. This prevents extra policy delegate calls from being logged.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then tells the policy delegate to notify when done, then points the web view at the policy delegate.
- DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.
- DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added code to do notifyDone if controllerToNotifyDone is set. (-[PolicyDelegate setControllerToNotifyDone:]): Added.
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the policy delegate. Also moved the call to resetUndoManager in here. (runTest): Removed the call to resetUndoManager (see above). Added an additional call to resetWebViewToConsistentStateBeforeTesting to match the Mac code.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): 0, not NULL.
- DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0. (PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if m_controllerToNotifyDone is set.
- DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and m_controllerToNotifyDone.
- 4:37 PM Changeset in webkit [42055] by
- 6 edits in trunk/WebCore
2009-03-27 Darin Adler <email@example.com>
Reviewed by Sam Weinig.
To prepare for work on a form loading fix, remove some unused functions,
consolidate some functions, and make many more functions private in
- WebCore.base.exp: Remove some unused entry points, update another.
- dom/Document.cpp: (WebCore::Document::detach): Clear m_frame directly instead of using clearFramePointer.
- dom/Document.h: Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Consolidate the two functions of this name into a single function. Also changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::submitForm): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::scheduleLocationChange): Call completeURL explicitly so we can remove the version of changeLocation that does completeURL for us. (WebCore::FrameLoader::redirectionTimerFired): Ditto. (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem directly so we don't need a setProvisionalHistoryItem function. (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at m_quickRedirectComing directly so we don't need a isQuickRedirectComing function. (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData function here because this is the only caller. If we want to make the resulting function smaller we should refactor some other way. Also streamlined the user-chosen encoding logic, but did not change what it does. (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::loadPostRequest): Ditto. (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from the didNotOpenURL function here, since this was the only caller.
- loader/FrameLoader.h: Removed include of FormState.h and used a forward declaration instead. Removed unneeded forward declation of Element. Moved many functions into the private section, and removed some other unused or uneeded functions.
- 4:23 PM Changeset in webkit [42054] by
- 4 edits2 adds in trunk
2009-03-27 Xiaomei Ji <email@example.com>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=24303
Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.
Test: editing/selection/extend-selection.html
- editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock): Added (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly implemented for character and word granularity, all other granularities are treated as "forward". (WebCore::SelectionController::modifyExtendingForward): Renamed modifyExtendingRightForward() to this. (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly implemented for character and word granularity, all other granularities are treated as "backward". (WebCore::SelectionController::modifyExtendingBackward): Renamed modifyExtendingLeftBackward() to this. (WebCore::SelectionController::modify): Change to call either the left/right or backward/forward methods depending on the 'dir' argument for extends.
- editing/SelectionController.h:
- 4:15 PM Changeset in webkit [42053] by
- 3 edits in trunk/WebKitTools
2009-03-27 Sam Weinig <email@example.com>
Reviewed by Gavin Barraclough.
Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
- Scripts/prepare-ChangeLog:
- Scripts/svn-create-patch:
- 3:34 PM Changeset in webkit [42052] by
- 2 edits in trunk/WebCore
2009-03-27 John Abd-El-Malek <firstname.lastname@example.com>
Reviewed by Eric Seidel.
Fix navigator.plugins.refresh(false) in Chromium.
- plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginData::refresh):
- 3:31 PM Changeset in webkit [42051] by
- 4 edits in trunk/WebCore
Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
virtual to fix the broken layout tests from my last commit.
Reviewed by Mark Rowe.
- dom/Element.cpp: (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
- dom/Element.h:
- html/HTMLBodyElement.h:
- 2:34 PM Changeset in webkit [42050] by
- 2 edits in trunk/WebCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N2)
Reviewed by Sam Weinig.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
items after each node is removed, leading to O(N2) behaviour. By inlining the batch removal in to setLength we can avoid
this gratuitous recalcuation.
- 1:45 PM Changeset in webkit [42049] by
- 2 edits in trunk/WebCore
2009-03-27 Dirk Schulze <email@example.com>
Reviewed by Eric Seidel.
We don't support images for GtkCursors yet. We need a placeholder to avoid crashes.
I took crosshair to have a common behavior with firefox.
[GTK] SVG - Crash on setting the cursor icon
- platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):
- 1:36 PM Changeset in webkit [42048] by
- 7 edits in trunk
Remove redundant attributes and functions from IDL files that have the
same attributes and functions defined in the super class.
Reviewed by Simon Fraser.
- WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
- bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
- html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth and scrollHeight.
- html/HTMLElement.idl: Remove blur and focus.
- 11:44 AM Changeset in webkit [42047] by
- 2 edits in trunk/WebKitTools/DumpRenderTree/mac
Fix the Mac DumpRenderTree build.
- 11:37 AM Changeset in webkit [42046] by
- 6 edits in trunk
Don't include substitute data URLs in global history redirect chains
Don't include substitute data URLs in global history redirect chains
Reviewed by Darin Adler.
This might be testable if:
- support were added to DRT for providing substitute data on failed loads
- support were added to DRT for dumping redirect chains
I tried doing the above and was still unable to make a test.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList): Call updateGlobalHistoryRedirectLinks only if the load succeeded (i.e., there is no unreachableURL). Previous the FrameLoaderClient implementations were unconditionally calling updateGlobalHistoryRedirectLinks from within updateGlobalHistory.
Don't include substitute data URLs in global history redirect chains
Reviewed by Darin Adler.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Don't call updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Added an assertion to help catch cases where we might be adding a substitute data URL into a redirect chain.
Don't include substitute data URLs in global history redirect chains
Reviewed by Darin Adler.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Don't call updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Added an assertion to help catch cases where we might be adding a substitute data URL into a redirect chain.
- 11:27 AM Changeset in webkit [42045] by
- 2 edits in trunk/WebKit/mac
2009-03-27 Darin Adler <firstname.lastname@example.com>
Reviewed by Adam Roben.
<rdar://problem/6541923> REGRESSION (r38629): Tab cycle in empty tab is broken
- WebView/WebHTMLView.mm: (-[WebHTMLView _wantsKeyDownForEvent:]): Only return YES when we have a Frame.
- 11:07 AM Changeset in webkit [42044] by
- 5 edits1 delete in trunk/WebCore
2009-03-27 Peter Kasting <firstname.lastname@example.com>
Reviewed by Eric Seidel.
Chromium port did not render decorations for <input type="search">.
This copies RenderThemeWin.*.
- css/themeChromiumWin.css: Removed.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsButton):
- rendering/RenderThemeChromiumLinux.h: (WebCore::RenderThemeChromiumLinux::paintSearchField):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumWin::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumWin::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsButton):
- rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::paintSearchField):
- 11:02 AM Changeset in webkit [42043] by
- 7 edits4 adds in trunk
2009-03-27 David Hyatt <firstname.lastname@example.com>
Reviewed by Simon Fraser
If an object has a self-painting layer, don't count it as part of a block's visual overflow.
This fix has only been made for block-level children. The inline-level case is still broken
(and covered by an existing bug).
Added fast/block/positioning/negative-rel-position.html
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
2009-03-27 David Hyatt <firstname.lastname@example.com>
Reviewed by Simon Fraser
Test case for relative positioning bug.
- fast/block/positioning/negative-rel-position.html: Added.
- platform/mac/fast/block/positioning/negative-rel-position-expected.checksum: Added.
- platform/mac/fast/block/positioning/negative-rel-position-expected.png: Added.
- platform/mac/fast/block/positioning/negative-rel-position-expected.txt: Added.
- 11:00 AM Changeset in webkit [42042] by
- 2 edits in trunk/WebCore
2009-03-27 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Darin Adler.
REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed
Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.
I've filed <rdar://problem/6731022> against the Movies widget.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
- 10:53 AM Changeset in webkit [42041] by
- 5 edits in trunk/WebKit/mac
2009-03-27 Darin Adler <firstname.lastname@example.com>
Reviewed by John Sullivan and Anders Carlsson.
<rdar://problem/5987442> Pasteboard not exposed to WebEditingDelegate for WebViewInsertActionPasted (needed for system services)
Added SPI to tell which pasteboard is currently being inserted.
I chose to put it on WebView to be forward-looking since we're migrating things
from WebHTMLView to WebView in the future.
- WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Add calls to _setInsertionPasteboard. (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
- WebView/WebView.mm: (-[WebViewPrivate dealloc]): Assert the pasteboard is nil. (-[WebViewPrivate finalize]): Ditto. (-[WebView _insertionPasteboard]): Return the pastebaord. (-[WebView _setInsertionPasteboard:]): Set the pasteboard.
- WebView/WebViewInternal.h: Added _setInsertionPasteboard.
- WebView/WebViewPrivate.h: Added _insertionPasteboard.
- 10:50 AM Changeset in webkit [42040] by
- 8 edits1 add in trunk
Expose new DOM methods as public Objective-C API.
2009-03-25 Timothy Hatcher <email@example.com>
Expose new DOM methods as public Objective-C API.
<rdar://problem/5837350> Expose new DOM classes and methods
as public API (match the additions to the JavaScript DOM)
Reviewed by NOBODY (OOPS!).
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMHTML.h:
- bindings/objc/DOMPrivate.h:
- bindings/objc/PublicDOMInterfaces.h:
2009-03-25 Timothy Hatcher <firstname.lastname@example.com>
Expose new DOM methods as public Objective-C API.
<rdar://problem/5837350> Expose new DOM classes and methods
as public API (match the additions to the JavaScript DOM)
Reviewed by NOBODY (OOPS!).
- MigrateHeaders.make:
- 10:45 AM Changeset in webkit [42039] by
- 2 edits in trunk/WebCore
2009-03-27 Zack Rusin <firstname.lastname@example.com>
Reviewed by Simon Hausmann.
Fix propagation of fill rules when rendering paths in the Qt build.
- 10:40 AM Changeset in webkit [42038] by
- 3 edits in trunk/WebCore
2009-03-27 Zack Rusin <email@example.com>
Reviewed by Tor Arne Vestbø.
Fix text field theming in the Qt build with the KDE 4 Oxygen
style by adjusting the size vertically and horizontally to
set padding on the element equal to the width of the style painted border.
- 9:23 AM Changeset in webkit [42037] by
- 3 edits in trunk/JavaScriptCore
2009-03-27 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Bug 24884: Include strings.h for strcasecmp()
- 6:05 AM Changeset in webkit [42036] by
- 2 edits in trunk/WebCore
2009-03-27 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Build fix for GNU mode RVCT compilation
- 5:59 AM Changeset in webkit [42035] by
- 2 edits in trunk/WebKit/qt
2009-03-27 Erik L. Bunce <firstname.lastname@example.com>
Reviewed by Simon Hausmann.
Fixes an incorrect case in tst_qwebpage.
- 5:50 AM Changeset in webkit [42034] by
- 2 edits in trunk/WebCore
2009-03-27 Erik L. Bunce <firstname.lastname@example.com>
Reviewed by Simon Hausmann.
Make text of the writing direction items more user friendly.
- 5:47 AM Changeset in webkit [42033] by
- 2 edits in trunk/WebCore
2009-03-27 Erik L. Bunce <firstname.lastname@example.com>
Reviewed by Simon Hausmann.
Fixed the Qt 4.4 Mac build with netscape plugins enabled.
- 4:54 AM Changeset in webkit [42032] by
- 4 edits in trunk/WebKit/qt
2009-03-27 Erik L. Bunce <email@example.com>
Reviewed by Simon Hausmann.
Add new editing related QWebPage::WebActions
- Clipboard: PasteAndMatchStyle
- Formatting: RemoveFormat, ToggleStrikethrough, ToggleSubscript, and ToggleSuperscript
- List Editing: InsertUnorderedList, InsertOrderedList, Indent, Outdent
- Paragraph Justification: AlignCenter, AlignJustified, AlignLeft, AlignRight
Improved selection and editing tests.
Mar 26, 2009:
- 11:16 PM Changeset in webkit [42031] by
- 3 edits in trunk/LayoutTests
Reviewed by David Hyatt.
Update fast/repaint/lines-with-layout-delta.html pixel results.
Hyatt says it's a progression, blame him if it ain't.
- platform/mac/fast/repaint/lines-with-layout-delta-expected.checksum:
- platform/mac/fast/repaint/lines-with-layout-delta-expected.png:
- 10:19 PM Changeset in webkit [42030] by
- 2 edits in trunk/WebCore
Try and fix the Qt build.
- platform/text/TextEncodingDetectorNone.cpp:
- 9:56 PM Changeset in webkit [42029] by
- 2 edits in trunk/WebCore
2009-03-26 Eric Carlson <firstname.lastname@example.com>
Reviewed by Simon Fraser.
24874: HTMLMediaElement: 'duration' defaults to NaN, deal with it
The 'duration' attribute is NaN when no media is available, so the
media element should take care when comparing with duration().
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Don't compare with duration when it is NaN. (WebCore::HTMLMediaElement::endedPlayback): Ditto.
- 9:30 PM Changeset in webkit [42028] by
- 6 edits2 moves1 delete in trunk/LayoutTests
Update layout test results for changes to Geeza Pro.
- platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Renamed from LayoutTests/platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum.
- platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png.
- platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
- platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
- 8:21 PM Changeset in webkit [42027] by
- 3 edits in trunk/WebCore
Fix the build.
- 7:51 PM Changeset in webkit [42026] by
- 4 edits in trunk/WebCore
2009-03-26 Jungshik Shin <firstname.lastname@example.com>
Reviewed by Cameron Zwarich.
- Fix the crash in setHintEncoding
- Fix build failures on Tiger and Qt. UnusedParam.h was not included by TextEncodingDetector{None,ICU}.cpp in the patch landed in r42023 for http://bugs.webkit.org/show_bug.cgi?id=16482
- loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::setHintEncoding):
- platform/text/TextEncodingDetectorICU.cpp:
- platform/text/TextEncodingDetectorNone.cpp:
- 6:27 PM Changeset in webkit [42025] by
- 2 edits in trunk/WebCore
2009-03-26 Simon Fraser <firstname.lastname@example.com>
Build fix when ACCELERATED_COMPOSITING is turned on.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing):
- 6:12 PM Changeset in webkit [42024] by
- 3 edits in trunk/WebCore
2009-03-26 Simon Fraser <firstname.lastname@example.com>
Reviewed by Dave Hyatt
Change the terminology from "inner content layer" to "direct compositing"
for cases where we can push an image directly over to the compositing system,
without having to draw it.
Clean up much of the code which looks at style to determine if this is possible,
and fix some bugs when backgrounds change dynamically.
- rendering/RenderLayerBacking.cpp: (WebCore::hasBorderOutlineOrShadow): (WebCore::hasBoxDecorations): (WebCore::hasBoxDecorationsWithBackgroundImage): (WebCore::RenderLayerBacking::canBeSimpleContainerCompositingLayer): (WebCore::RenderLayerBacking::canUseDirectCompositing): (WebCore::RenderLayerBacking::detectDrawingOptimizations): (WebCore::RenderLayerBacking::rendererContentChanged): (WebCore::RenderLayerBacking::updateImageContents):
- rendering/RenderLayerBacking.h:
- 5:28 PM Changeset in webkit [42023] by
- 1 edit4 adds in trunk/WebCore
No additional review, committing previously reviewed files for build fix only.
Add files I missed when commiting Jungshik's patch in r42022.
- icu/unicode/ucsdet.h: Added.
- platform/text/TextEncodingDetector.h: Added.
- platform/text/TextEncodingDetectorICU.cpp: Added. (WebCore::detectTextEncoding):
- platform/text/TextEncodingDetectorNone.cpp: Added. (WebCore::detectTextEncoding):
- 5:01 PM Changeset in webkit [42022] by
- 18 edits in trunk
2009-03-26 Jungshik Shin <email@example.com>
Reviewed by Alexey Proskuryakov.
Add an encoding detector 'hook' to TextResourceDecoder.
- add |usesEncodingDetector| to Settings. It's off by default.
- add a new encoding source type |EncodingFromParent| to distinguish cases when the encoding is inherited from the parent frame from cases when it's actually auto-detected.
- add TextEncodingDetector* to platform/text. Currently, the only implementation uses ICU. Stub is added for ports that do not use ICU and a build on Tiger. Mac OS Tiger comes with ICU 3.2 that does not support encoding detector.
- add ucsdet.h to icu/unicode for ports using ICU.
Layout tests will be added once bug 20534 is fixed and a WebPreference
can be controlled in test_shell. With UsesEncodingDetector off, there
is no change to test.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCore/GNUmakefile.am
- WebCore/WebCore.pro
- WebCore/WebCore.scons
- WebCore/WebCoreSources.bkl
- WebCore.base.exp
- icu/unicode/ucsdet.h
- loader/FrameLoader.cpp: (WebCore::FrameLoader::write): turn on/off encoding detector depending on Settings and set hintEncoding of TextResourceDecoder to the parent frame encoding if necessary and the security policy allows refering to the parent frame encoding.
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::checkForCSSCharset): add check for EncodingFromParentFrame (WebCore::TextResourceDecoder::checkForHeadCharset): ditto (WebCore::TextResourceDecoder::shouldAutoDetect): (WebCore::TextResourceDecoder::decode): call encoding detector if shouldAutoDetect returns true. (WebCore::TextResourceDecoder::flush): if encoding is not determined by now, call encoding detector if shouldAutoDetect returns true.
- loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::): (WebCore::TextResourceDecoder::create): (WebCore::TextResourceDecoder::setHintEncoding): (WebCore::TextResourceDecoder::source):
- page/Settings.cpp: add m_usesEncodingDetector (WebCore::Settings::Settings): (WebCore::Settings::setUsesEncodingDetector):
- page/Settings.h: (WebCore::Settings::usesEncodingDetector):
- platform/text/TextEncodingDetector.h: Added.
- platform/text/TextEncodingDetectorICU.cpp: Added. (WebCore::detectTextEncoding):
- platform/text/TextEncodingDetectorNone.cpp: Added. (WebCore::detectTextEncoding):
- 4:50 PM Changeset in webkit [42021] by
- 13 edits in trunk/WebCore
2009-03-26 Darin Adler <email@example.com>
Reviewed by Geoff Garen.
Removed code that casts EventListener down to derived classes
without type checking. A crash could happen if you added event
listeners with Objective-C and then manipulated the class with
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark): Removed all the casts and used the markIfNotNull function and mark functions on EventListener instead.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Ditto.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): Ditto.
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::mark): Ditto.
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): Ditto.
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
- bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Used function, the new name for what used to be called listenerObj. (WebCore::JSAbstractEventListener::virtualIsInline): Renamed since this doesn't need to be virtual for callers who have a pointer to this class, not the base class. (WebCore::JSEventListener::function): Renamed from listenerObj. (WebCore::JSProtectedEventListener::function): Ditto.
- bindings/js/JSEventListener.h: Removed unneeded forward class declarations. Made all virtual functions private since there's no need to call any of them on a particular derived class, only on EventListener. Explicitly declare JSEventListener::mark as virtual since it's now overriding a function in the EventListener base class. Made JSProtectedEventListener::m_globalObject protected so the JSLazyEventListener derived class can use it directly instead of using a virtual function to get the pointer.
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Use m_globalObject instead of globalObject since the latter is a virtual function and there's no need to pay virtual function overhead. (WebCore::JSLazyEventListener::function): Renamed from listenerObj.
- bindings/js/JSLazyEventListener.h: Moved forward declaration of the Node class here from JSEventListener.h.
- bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded cast to JSEventListener when getting the script object from a listener.
- dom/EventListener.h: Added virtual function and mark functions so we can extract the JavaScript function object or mark a JavaScript event listener in a type safe manner.
- 4:25 PM Changeset in webkit [42020] by
- 4 edits in trunk/WebCore
2009-03-26 Peter Kasting <email@example.com>
Reviewed by Adele Peterson.
Use CSS file instead of code to adjust search field styling.
- css/themeWin.css:
- rendering/RenderThemeWin.cpp:
- rendering/RenderThemeWin.h:
- 3:53 PM Changeset in webkit [42019] by
- 10 edits2 copies in trunk/WebCore
2009-03-26 Darin Adler <firstname.lastname@example.com>
Reviewed by Geoff Garen.
Split JSLazyEventListener out into its own separate source file.
We'll be removing JSAbstractEventListener and JSProtectedEventListener soon,
so leave those in the same file with JSEventListener.
- GNUmakefile.am: Added JSLazyEventListener.
- WebCore.pro: Ditto.
- WebCore.scons: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/js/JSEventListener.cpp: Removed the JSLazyEventListener part. Removed unneeded includes. Removed incorrect ASSERT_CLASS_FITS_IN_CELL, since JSAbstractEventListener is not derived from JSCell.
- bindings/js/JSEventListener.h: Removed the JSLazyEventListener part and the now-unneeded include of PlatformString.h.
- bindings/js/JSLazyEventListener.cpp: Copied from bindings/js/JSEventListener.cpp. Kept only the JSLazyEventListener part. (WebCore::eventParameterName): Made this have internal linkage by adding "static". Also moved the default case out of the switch statement so we will get a warning if we omit any cases in the future.
- bindings/js/JSLazyEventListener.h: Copied from bindings/js/JSEventListener.h. Kept only the JSLazyEventListener part.
- bindings/js/ScriptController.cpp: Removed unneeded includes and sorted the remanining ones. Include JSLazyEventListener.h instead of JSEventListener.h.
- 3:31 PM Changeset in webkit [42018] by
- 15 edits in trunk
2009-03-26 Darin Adler <email@example.com>
Reviewed by Geoff Garen.
Renamed JSUnprotectedEventListener to JSEventListener.
And related renames.
Soon Geoff will make all JavaScript event listeners use mark instead
of protect, so there's no need to emphasize "unprotected".
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::jsEventListeners): (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::listenerObj): (WebCore::JSEventListener::globalObject): (WebCore::JSEventListener::clearGlobalObject): (WebCore::JSEventListener::mark):
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::create):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::mark): (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/scripts/CodeGeneratorJS.pm: All just renaming.
2009-03-26 Darin Adler <email@example.com>
Reviewed by Geoff Garen.
- Scripts/do-webcore-rename:Update for rename of JSUnprotectedEventListener to JSEventListener.
- 3:21 PM Changeset in webkit [42017] by
- 12 edits in trunk
2009-03-26 Darin Adler <firstname.lastname@example.com>
Reviewed by Geoff Garen.
Renamed JSEventListener to JSProtectedEventListener.
And related renames.
Soon Geoff will make all JavaScript event listeners use mark instead
of protect, and so this class will be be obsolete. We will rename
JSUnrpotectedEventListener to JSEventListener in the next check-in,
since that one will remain.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::jsProtectedEventListeners): (WebCore::JSDOMGlobalObject::jsProtectedInlineEventListeners):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSEventListener.cpp: (WebCore::JSProtectedEventListener::JSProtectedEventListener): (WebCore::JSProtectedEventListener::~JSProtectedEventListener): (WebCore::JSProtectedEventListener::listenerObj): (WebCore::JSProtectedEventListener::globalObject): (WebCore::JSProtectedEventListener::clearGlobalObject): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSEventListener.h: (WebCore::JSProtectedEventListener::create):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener): All just renaming.
2009-03-26 Darin Adler <firstname.lastname@example.com>
Reviewed by Geoff Garen.
- Scripts/do-webcore-rename: Update for rename of JSEventListener to JSProtectedEventListener. This includes all the related renames, but not that one because that one renames the file.
- 2:28 PM Changeset in webkit [42016] by
- 2 edits in trunk/JavaScriptCore
Copy testapi.js to $WebKitOutputDir on Windows
Part of Bug 24856: run-javascriptcore-tests should run testapi on
This matches what Mac does, which will help once we enable running
testapi from run-javascriptcore-tests on Windows.
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Copy testapi.js next to testapi.exe.
- 1:39 PM Changeset in webkit [42015] by
- 4 edits in trunk
- 1:38 PM Changeset in webkit [42014] by
- 1 copy in tags/Safari-6530.4
New tag.
- 1:35 PM Changeset in webkit [42013] by
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix <rdar://problem/6725042> BidiResolver::createBidiRunsForLine can create runs extending beyond the end
No test because Safari does not use this version of
createBidiRunsForLine() with the end iterator not pointing to the end
of the text run.
- platform/text/BidiResolver.h: (WebCore::BidiResolver::appendRun): Cap the end of the run at the end of the line and set the reachedEndOfLine flag. This mirrors the logic in the specialized version of appendRun() in bidi.cpp, which is why the problem did not show up in HTML. Also avoid creating empty runs.
- 1:18 PM Changeset in webkit [42012] by
- 2 edits in trunk/WebKitTools
Reduce run-webkit-tests's time out limit to 15 seconds (or 2.5 minutes under GuardMalloc)
The previous limit was 60 seconds (or 10 minutes under GuardMalloc).
There's no evidence that we need the limit to be this long, and having
it be so long just makes timed-out tests take forever to complete.
DRT's watchdog timer is 10 seconds, so still has time to fire before
run-webkit-tests will cut it off.
Reviewed by Simon Fraser.
- Scripts/run-webkit-tests: (sub readFromDumpToolWithTimer): Reduced the limit to 15 seconds (or 2.5 mintues under GuardMalloc).
- 1:10 PM Changeset in webkit [42011] by
- 6 edits in trunk/WebKitTools
Make DRT's watchdog timer actually work on Windows
We were previously trying to use a CFRunLoopTimer for the watchdog
timer on Windows. This doesn't work because we don't use a CFRunLoop
on the main thread on Windows.
This patch changes the watchdog timer on Windows be a normal Windows
Reviewed by Simon Fraser.
- DumpRenderTree/DumpRenderTree.h: Moved declaration of waitToDumpWatchdog from here...
- DumpRenderTree/mac/DumpRenderTreeMac.h: ...to here.
- DumpRenderTree/win/DumpRenderTree.cpp: (invalidateAnyPreviousWaitToDumpWatchdog): Added. This function cancels an existing watchdog timer. (dump): Call invalidateAnyPreviousWaitToDumpWatchdog. This will prevent watchdogs from previous tests firing during subsequent ones. This matches Mac's behavior.
- DumpRenderTree/win/DumpRenderTreeWin.h: Added a declaration of waitToDumpWatchdog.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (waitUntilDoneWatchdogFired): Converted this to be a Windows TIMERPROC. (LayoutTestController::setWaitToDump): Changed to use SetTimer instead of CFRunLoopAddTimer.
- 11:48 AM Changeset in webkit [42010] by
- 4 edits in trunk/WebKit/mac
2009-03-26 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Dan Bernstein.
- Fix <rdar://problem/6687055> and <rdar://problem/6713639>.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvalidateRect): Call NetscapePluginInstanceProxy::invalidateRect.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::cleanup): Stop the request timer, set m_pluginView to nil.
No need to set m_pluginView to nil here anymore, it's now done in cleanup().
Assert that the plug-in view is not nil.
Call setNeedsDisplayInRect here.
- 11:34 AM Changeset in webkit [42009] by
- 6 edits10 adds in trunk
2009-03-26 Simon Fraser <firstname.lastname@example.com>
Reviewed by Dave Hyatt
Tests: compositing/overflow/ancestor-overflow.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h: (WebCore::ClipRects::infiniteRect): New static method that returns a large rect that is used by the clipping logic.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use parentClipRects(), rather than calculateRects(), to compute the overflow rect that we'll use to create a masking layer for composited clipping.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::clippedByAncestor): Use parentClipRects() to see whether there's a layer between us and our compositing ancestor which applies clipping.
A layer which imposes clipping to its children doesn't have to be a stacking
context; it might be a normal flow layer; in either case, we can rely on the
hasCompositingDescendant() bit.
- 11:18 AM Changeset in webkit [42008] by
- 1 edit1 delete in trunk/WebKitLibraries
Remove SafariThemeConstants.h, which is now provided by WebKitSupportLibrary
- win/include/SafariTheme: Removed.
- win/include/SafariTheme/SafariThemeConstants.h: Removed.
- 10:05 AM Changeset in webkit [42007] by
- 2 edits in trunk/WebCore
Escape key should dismiss select menu
Reviewed by Adam Roben.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
- 9:12 AM Changeset in webkit [42006] by
- 2 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Make sure the script uses LF line endings even on Windows.
- 8:21 AM Changeset in webkit [42005] by
- 2 edits in trunk/WebKit/qt
2009-03-26 Simon Hausmann <email@example.com>
Rubber-stamped by Tor Arne Vestbø.
Fix the documentation of the QLocale usage in userAgentForUrl.
- 8:06 AM Changeset in webkit [42004] by
- 2 edits in trunk/LayoutTests
2009-03-25 Brian Weinstein <firstname.lastname@example.com>
Update Windows skipped list based on failures in r41995, to try and make Windows build-bot green.
Reviewed by Adam Roben
- platform/win/Skipped:
- 7:26 AM Changeset in webkit [42003] by
- 4 edits in trunk/WebKit/win
Reviewed by Adam Roben.
- add close() to the WebView API.
- Interfaces/IWebView.idl:
- WebView.cpp: (WebView::close):
- WebView.h:
- 7:24 AM Changeset in webkit [42002] by
- 37 edits in trunk/WebCore
2009-03-26 Eli Fidler <firstname.lastname@example.com>
Reviewed by George Staikos.
Remove warnings all over the place by making operator precedence
explicit in cases like x && y z. No functional change.
- 4:43 AM Changeset in webkit [42001] by
- 2 edits in trunk/WebCore
2009-03-26 Gustavo Noronha Silva <email@example.com>
Reviewed by Holger Freyther.
[GTK] 401 responses cause rogue content to be loaded
Our soup code handles 401 responses itself, so we should not feed
the headers and data of those responses to the loader.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback):
- 2:31 AM Changeset in webkit [42000] by
- 3 edits in trunk/WebKit/qt
2009-03-20 Erik L. Bunce <email@example.com>
Reviewed by Simon Hausmann.
Fix for InsertParagraphSeparator and InsertLineSeparator so that
QWebPage::action() creates QActions for them. Also make sure they get
updated appropriately.
- Api/qwebpage.cpp: (QWebPagePrivate::updateEditorActions): (QWebPage::action):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textEditing):
Mar 25, 2009:
- 7:39 PM Changeset in webkit [41999] by
- 2 edits in trunk/JavaScriptCore
Fix exception handling for instanceof in the interpreter.
Reviewed by Geoff Garen
- 7:34 PM Changeset in webkit [41998] by
- 2 edits in trunk/JavaScriptCore
2009-03-25 Geoffrey Garen <firstname.lastname@example.com>
Reviewed by Cameron Zwarich.
Fixed <rdar://problem/6724011> Write to freed memory in JSC::Label::deref
when reloading http://helpme.att.net/speedtest/
- bytecompiler/BytecodeGenerator.h: Reversed the declaration order for m_labelScopes and m_labels to reverse their destruction order. m_labelScopes has references to memory within m_labels, so its destructor needs to run first.
- 7:12 PM Changeset in webkit [41997] by
- 3 edits in trunk/WebCore
2009-03-25 Geoffrey Garen <email@example.com>
Reviewed by Oliver Hunt and Darin Adler.
Fixed <rdar://problem/6603167> Crash in WebKit!JSC::JSGlobalObject::resetPrototype
during Stress test (#3 & #7 WER crashes for Safari 4 Beta)
The problem was that allocation of the global object would, for just a
moment, leave the global object's prototype unprotected from GC. This
bug doesn't apply to non-global DOM objects because their prototypes are
cached and marked by the global object.
No test case because the crashing condition is hard to deterministically
produce in a normal build, and in a Windows Release build with
COLLECT_ON_EVERY_ALLOCATION set to 1, existing tests crash/hang.
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript): Protect the global object's prototype from GC during construction, since the global object does not yet point to it, and therefore won't mark it.
- 6:38 PM Changeset in webkit [41996] by
- 9 edits10 adds in trunk
2009-03-25 Dean Jackson <email@example.com>
Reviewed by Simon Fraser
When using hardware compositing, some images can be directly
rendered by the hardware - no need to draw them into a separate
context, therefore saving memory.
Only images with certain style properties can be directly
composited - basically anything that is not a simple image requires
the usual rendering path (eg. if the image has borders).
Test: compositing/direct-image-compositing.html
- manual-tests/resources/simple_image.png: Added.
- manual-tests/simple-image-compositing.html: Added.
- platform/graphics/Image.h:
- move this to public
- rendering/RenderImage.cpp:
- poke compositing layer if image has changed
- let the compositing layer know that it can render the image
- rendering/RenderImage.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseInnerContentLayer): (WebCore::RenderLayerBacking::detectDrawingOptimizations): (WebCore::RenderLayerBacking::rendererContentChanged):
- rendering/RenderLayerBacking.h:
- code to hook up direct compositing of images where possible
- 4:41 PM Changeset in webkit [41995] by
- 2 edits in trunk/WebKitTools
Update test result search path for Windows now that it has updated versions of ICU, libxml2, and friends.
Rubber-stamped by Steve Falkenburg.
- Scripts/run-webkit-tests:
- 4:06 PM Changeset in webkit [41994] by
- 2 edits in trunk/WebKit/mac
2009-03-25 Anders Carlsson <firstname.lastname@example.com>
Reviewed by Darin Adler.
CrashTracer: [REGRESSION] 51 crashes in Safari at com.apple.WebKit ⢠WebNetscapePluginStream::deliverData + 775
Don't release m_deliveryData since it's a RetainPtr. Also, use adoptNS instead of releasing newDeliveryData manually.
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::deliverData):
- 3:37 PM Changeset in webkit [41993] by
- 8 edits in trunk/LayoutTests
2009-03-25 Simon Fraser <email@example.com>
Reviewed by Anders Carlsson.
Update layout test results for
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 3:24 PM Changeset in webkit [41992] by
- 2 edits in trunk/WebCore
2009-03-25 David Levin <firstname.lastname@example.com>
Reviewed by Dimitri Glazkov.
Chromium build fix. Fix #include in V8NodeFilterCondition.cpp due to the
rename of V8NodeFilter to V8NodeFilterCondition.
- bindings/v8/V8NodeFilterCondition.cpp:
- 3:15 PM Changeset in webkit [41991] by
- 5 edits in trunk/WebCore
Reviewed by Darin Adler.
Remove dead code and style cleanup
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): Coverty was annoyed that we didn't initialize all of our members. I agree, but I didn't want to paste all 8 members each time, so I just cleaned up the existing constructors and left them.
- page/FocusController.cpp: (WebCore::FocusController::setFocusedNode): "node" was checked just above and is already known to be non-null
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::insertOnlyThisLayer): We were already using parentLayer w/o a NULL check above, so just add an explicit ASSERT and use it w/o NULL check (WebCore::RenderLayer::resize): element is already ASSERTed above, no need to null check it here
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): currentCell.cell was just assigned to the value "cell" which is known to be non-null, no need to null check again.
- 3:14 PM Changeset in webkit [41990] by
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
Move ASSERT(foo) to before where foo-> is used
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Move ASSERTs to the top of the function, code was using "node" before ASSERT(node), once I moved ASSERT(node) to the top of the function it made sense to move the rest of them there too.
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): move ASSERT(object) to *before* we use "object" :)
- 3:14 PM Changeset in webkit [41989] by
- 2 edits in trunk/WebCore
Reviewed by Simon Fraser.
Make TextTokenizer ASSERT that the buffer was freed
- loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::~TextTokenizer): (WebCore::TextTokenizer::finish): Make it clear by adding a ~TextTokenizer that finish() will always be called and the memory never leaked.
- 3:14 PM Changeset in webkit [41988] by
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
I don't have a test case where we were taking the wrong path here
However, adding an ASSERT(lBreak.obj) before this usage caused
multiple bidi tests to fail, so lBreak.obj can be null here.
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): lBreak.obj can be null, so we can't call ->isBR() on it unconditionally.
- 3:11 PM Changeset in webkit [41987] by
- 3 edits4 adds in trunk
2009-03-25 Simon Fraser <email@example.com>
Reviewed by Darin Adler
When the slider range is zero, avoid a divide by zero, which caused the
thumb to be positioned off in the weeds, which broke painting.
Test: media/video-empty-source.html
- rendering/RenderSlider.cpp: (WebCore::SliderRange::proportionFromValue): (WebCore::SliderRange::valueFromProportion): (WebCore::sliderPosition): (WebCore::RenderSlider::setValueForPosition):
- 3:04 PM Changeset in webkit [41986] by
- 6 edits in trunk/WebCore
Reviewed by Simon Fraser.
Style cleanup and dead code removal in dom, editing
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner): (WebCore::ContainerNode::getRect): Coverty was (rightly) confused as to what the hell "o" was being used for and whether or not it would ever be NULL. I added some ASSERTS so that people (and machines) would be less confused about the logic in getUpperLeftCorner/getLowerRightCorner
- dom/Document.cpp: (WebCore::Document::recalcStyle): Remove dead code, this block already checked that change == Force
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle): Coverty correctly identified that traversePreviousNodePostOrder can return NULL, thus prev will be null, and we don't really explicitly handle it (like we probably should) It's OK though, because we end up creating a null position object, which may not have been what we intended, but we certainly don't crash.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Remove dead code, insertionPosition.node() is already checked to be non-null above.
- editing/markup.cpp: (WebCore::appendStartMarkup): removed dead code, annotate is already known to be true at this point in the file !annotate was checked above, and break; was called.
- 3:04 PM Changeset in webkit [41985] by
- 4 edits in trunk/WebCore
Reviewed by Simon Fraser.
CSS dead code removal and cleanup from Coverty errors
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Every other place in the code we check settings() for NULL, so I made these places check too, even though we should never be resolving style against a document which has no frame (which I believe is the only time settings() can be null)
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::styleSheetChanged): Removing dead code, "root" can never be null here.
- css/SVGCSSStyleSelector.cpp: (WebCore::colorFromSVGColorCSSValue): (WebCore::CSSStyleSelector::applySVGProperty): Extra returns in the old macros caused dead code. Removing the old macros and use modern ones instead. :) Extra null checks to value were not needed. Added an ASSERT at the top of the function to make it clear that value will never be NULL. Added colorFromSVGColorCSSValue to clean up the code a little.
- 3:04 PM Changeset in webkit [41984] by
- 3 edits in trunk/WebCore
Reviewed by Simon Fraser.
Font fallback cleanup and added ASSERT for GlyphPageTreeNode
- css/CSSFontSelector.cpp: (WebCore::compareFontFaces): Coverty was concerned that it was possible to index off the end of weightFallbackRuleSets I can't read the code well enough to tell, so I tried to make the code clearer and added an ASSERT.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Coverty believes we can crash here due to j being larger than GlyphPage::size. I think to is already known to be < GlyphPage::size due to the min() statement above, but not being sure I added an ASSERT.
- 3:04 PM Changeset in webkit [41983] by
- 9 edits in trunk/WebCore
Reviewed by Simon Fraser.
Coverty inspired fixes in Animations/Transforms
- page/animation/AnimationBase.h: Fix animate() signatures to match so that the virtual methods actually override one another. :)
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList): Attempt to fix this method, prevAnimation was never set to anything but NULL, as far as I can tell the author originally intended to update it at the end of the loop, which is what I changed this code to do.
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::animate): Make method signature match AnimationBase::animate
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate): Make method signature match AnimationBase::animate
- page/animation/KeyframeAnimation.h:
- platform/graphics/transforms/PerspectiveTransformOperation.cpp: (WebCore::PerspectiveTransformOperation::blend): if (blendToIdentity) already returned above.
- platform/graphics/transforms/RotateTransformOperation.cpp: (WebCore::RotateTransformOperation::blend): if (blendToIdentity) already returned above.
- 2:31 PM Changeset in webkit [41982] by
- 3 edits in trunk/WebCore
2009-03-25 Eli Fidler <firstname.lastname@example.com>
Reviewed by George Staikos.
Fix compiler warnings regarding assignments in if statements.
- 2:25 PM Changeset in webkit [41981] by
- 3 edits2 adds in trunk
Reviewed by Dave Hyatt.
- fix <rdar://problem/6472150> repro crash in RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using menus
Test: fast/inline/continuation-positioned-reparenting.html
- rendering/RenderInline.cpp: (WebCore::RenderInline::splitFlow): When repurposing the existing container as the "pre" block, clear its positioned objects list, because positioned descendants may end up in a different block after the split.
Reviewed by Dave Hyatt.
- test for <rdar://problem/6472150> repro crash in RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using menus
- fast/inline/continuation-positioned-reparenting-expected.txt: Added.
- fast/inline/continuation-positioned-reparenting.html: Added.
- 12:52 PM Changeset in webkit [41980] by
- 3 edits4 adds in trunk
2009-03-24 Simon Fraser <firstname.lastname@example.com>
Reviewed by Dave Hyatt
Length values in transform operations need to take zoom into account.
Test: fast/transforms/transforms-with-zoom.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations):
- 12:36 PM Applications using WebKit edited by
- (diff)
- 12:23 PM Changeset in webkit [41979] by
- 9 edits in trunk
2009-03-25 David Hyatt <firstname.lastname@example.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24809, background-clip/origin don't use the correct
values. Add support for the new values (while preserving the old values for backwards
Changed some existing test cases to use the new values.
- css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty):
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillBox):
- css/CSSValueKeywords.in:
2009-03-25 David Hyatt <firstname.lastname@example.com>
Reviewed by Simon Fraser.
Change a few test cases to use the new values just to verify that they work.
- fast/backgrounds/size/backgroundSize17.html:
- fast/backgrounds/size/backgroundSize18.html:
- fast/backgrounds/size/backgroundSize19.html:
- fast/gradients/simple-gradients.html:
- 11:18 AM Changeset in webkit [41978] by
- 3 edits4 adds in trunk
2009-03-25 Brett Wilson <email@example.com>
Reviewed by Dimitri Glazkov.
Fix complex text opacity on the Chromium Windows port.
Test: fast/text/complex-text-opacity.html
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
2009-03-25 Brett Wilson <firstname.lastname@example.com>
Reviewed by Dimitri Glazkov.
Fix complex text opacity on the Chromium Windows port.
- fast/text/complex-text-opacity.html: Added.
- platform/mac/fast/text/complex-text-opacity-expected.checksum: Added.
- platform/mac/fast/text/complex-text-opacity-expected.png: Added.
- platform/mac/fast/text/complex-text-opacity-expected.txt: Added.
- 10:30 AM Changeset in webkit [41977] by
- 3 edits in trunk/WebKit/mac
Reviewed by Kevin Decker.
<rdar://problem/6453738> call SetWindow when user creates a new tab
CoreGraphics plug-ins now receive an NPP_SetWindow call when moving to a background tab.
Flash is excluded from this change in behavior, as it has historical WebKit-specific code
that isn't compatible with this change.
- Plugins/WebNetscapePluginView.h:
Added an _isFlash ivar.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _createPlugin]):
Set the new _isFlash ivar based on the bundle identifier.
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
When using the CG drawing model and in a non-drawable state, set the portState
to NULL and return early.
(-[WebNetscapePluginView updateAndSetWindow]):
When using the CG drawing model, call -setWindowIfNecessary even if the portState is NULL.
Flash is an exception to this, due to its historical behavior.
(-[WebNetscapePluginView setWindowIfNecessary]):
Removed an assertion that was no longer true. The [NSView focus] view
is no longer guaranteed to be 'self' at this point.
Also modified the debug logging for CG plug-ins to include the size of the
window's clipRect, which was useful in verifying the correct behavior of this patch.
- 10:07 AM Changeset in webkit [41976] by
- 3 edits4 adds in trunk
2009-03-25 David Hyatt <email@example.com>
Reviewed by Eric Seidel
Fix for bug 23198, border images should not clip to border radii. The border-image should just ignore
the border-radius, since the assumption is that any desired rounding will be built into the border-image
Note that I do not agree with this change, but I am matching the spec.
Added fast/borders/border-image-border-radius.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
2009-03-25 David Hyatt <firstname.lastname@example.com>
Reviewed by Eric Seidel
Test case for bug 23198.
- fast/borders/border-image-border-radius.html: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.checksum: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.png: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.txt: Added.
- 8:09 AM Changeset in webkit [41975] by
- 2 edits in trunk/WebCore
2009-03-25 Gustavo Noronha Silva <firstname.lastname@example.com>
Reviewed by Holger Freyther.
[GTK] requests download instead of displaying page
Fix the Content-Type headers we get from soup, so that we set a
proper media type on the ResourceResponse.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- 7:49 AM Changeset in webkit [41974] by
- 2 edits in trunk/WebCore
2009-03-25 Gustavo Noronha Silva <email@example.com>
Reviewed by Holger Freyther.
[GTK] responses with status code >= 400 should not be given special treatment
Do not special case requests that have HTTP responses >=
- Redirects are handled automatically by libsoup, but the rest of the responses should be treated like any other.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::): (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback): (WebCore::finishedCallback):
- 7:36 AM Changeset in webkit [41973] by
- 5 edits in trunk/WebCore
2009-03-25 Darin Adler <email@example.com>
Reviewed by John Sullivan.
Tidy up LegacyWebArchive a bit. And don't include favicons in web archives when
they are being used only for selections, not an entire document.
- WebCore.base.exp: Remove exported function that's not used in WebKit.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createPropertyListRepresentation): Made a static member function so it can share private things with other member functions. Added some FIXME comments to a branch of code I think is dead. Changed boolean argument into a named one. Renamed to match other similar functions. (WebCore::LegacyWebArchive::createResourceResponseFromPropertyListData): Ditto. (WebCore::LegacyWebArchive::createResource): Ditto. (WebCore::LegacyWebArchive::create): Merged the create and init functions. (WebCore::LegacyWebArchive::rawDataRepresentation): Added some assertions because we should never fail to write (we can fail to read). (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Made a static member function as above. (WebCore::LegacyWebArchive::createFromSelection): Ditto. (WebCore::LegacyWebArchive::create): Iterate the vector with indices rather than iterators. Only include the favicon if the first node is the document since we don't want to include the favicon when copying and pasting.
- loader/archive/cf/LegacyWebArchive.h: Made one of the create functions private. Made the Mac-specific functions be static member functions. Made other helpers be static member functions. Removed the nit function.
- loader/archive/cf/LegacyWebArchiveMac.mm: (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Updated comment and made this a static member function. (WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto. Also made it so we only type cast in one place.
- 7:34 AM Changeset in webkit [41972] by
- 12 edits2 adds in trunk
2009-03-25 Darin Adler <email@example.com>
Reviewed by David Hyatt.
Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
Test: media/video-display-none-crash.html
The problem here was that RenderSlider was trying to position its thumb in a way that
requires it to call updateLayout inside rendering code. The right way to position a
child renderer is to do layout, so I had to write a layout function. And then fix a few
other small problems shown by the same test case.
- rendering/RenderSlider.cpp: Made defaultTrackLength have internal linkage. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML prefix for public DOM classes, not elements used as implementation details. Made SliderThumbElement function members private and got rid of unneeded default argument value for shadowParent. (WebCore::SliderRange::SliderRange): Added. Parses precision, max, and min attributes. (WebCore::SliderRange::clampValue): Added. Does standard clamping based on the above. (WebCore::SliderRange::valueFromElement): Added. Reads the value from the element in a way that clamps to the range. (WebCore::sliderPosition): Added. Computes the slider position: a double. (WebCore::SliderThumbElement::SliderThumbElement): Removed unneeded explicit initialization of m_initialClickPoint. (WebCore::SliderThumbElement::defaultEventHandler): Call setValueForPosition instead of calling setCurrentPosition and valueChanged. (WebCore::RenderSlider::RenderSlider): Remove unneeded explicit initialization of m_thumb. (WebCore::RenderSlider::styleDidChange): Remove unneeded second argument to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): Remove unneeded second argument. Get rid of code setting the position to relative and setting the left and top. We now handle positioning in a custom layout function. (WebCore::RenderSlider::layout): Rewrote to handle positioning of the thumb as layout. (WebCore::RenderSlider::updateFromElement): Added code to immediately update the value in the element if it's out of range. This clamping used to be done as a side effect of setPositionFromValue. Also, this has nothing to do with the renderer, so at some point it could be moved into HTMLInputElement. Removed call to setPositionFromValue and instead just rely on the call to setNeedsLayout. Fix the setNeedsLayout call to be a normal setNeedsLayout(true), not a setNeedsLayout(true, false), because we do want this to be propagated to the parent -- it's not called during layout. (WebCore::RenderSlider::setValueForPosition): Refactor to use the new SliderRange class. Also don't call setCurrentPosition; instead just call setNeedsLayout. (WebCore::RenderSlider::currentPosition): Use the actual position of the renderer rather than the style to find the position; that means this needs to be done after layout is done. Also removed unneeded runtime checks and replaced them with assertions, after checking all callers to see they already guarantee this. (WebCore::RenderSlider::trackSize): Removed unneeded runtime checks and replaced them with assertions, after checking all callers to see they already guarantee this. (WebCore::RenderSlider::inDragMode): Added a null check for m_thumb so this won't crash if called early on a brand new RenderSlider.
- rendering/RenderSlider.h: Made all functions private except for forwardEvent and inDragMode. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML prefix for public DOM classes, not elements used as implementation details. Made the mouseEventIsInThumb function non-virtual. Removed the return value and argument from setPositionFromValue. Removed valueChanged and setCurrentPosition. Removed the oldStyle argument to createThumbStyle (see above). Made SliderThumbElement a friend so it can use some private member functions.
2009-03-25 Darin Adler <email@example.com>
Reviewed by David Hyatt.
Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
- media/video-display-none-crash-expected.txt: Added.
- media/video-display-none-crash.html: Added.
- platform/mac/fast/forms/box-shadow-override-expected.txt: Updated since a slider's thumb is no longer relative-positioned and hence no longer gets its own layer.
- platform/mac/fast/forms/input-appearance-height-expected.txt: Ditto.
- platform/mac/fast/forms/slider-padding-expected.txt: Ditto.
- platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Ditto.
- platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Ditto.
- platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
- platform/mac/media/video-controls-rendering-expected.txt: Ditto.
- platform/mac/media/video-display-toggle-expected.txt: Ditto.
- 7:31 AM Changeset in webkit [41971] by
- 2 edits in trunk/WebKit/gtk
2009-03-25 Gustavo Noronha Silva <email@example.com>
Reviewed by Holger Freyther.
[GTK] tooltip position doesn't update when hovering consecutive links
Work-around tooltips not updating their location when the elements
are consecutive, by clearing the tooltip when handling
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- 6:01 AM Changeset in webkit [41970] by
- 5 edits in trunk/WebCore
2009-03-25 Eli Fidler <firstname.lastname@example.com>
Reviewed by George Staikos.
Fix ambiguous else cases by adding braces to nested if()s with elses.
- 5:00 AM Changeset in webkit [41969] by
- 3 edits in trunk/WebKit/gtk
2009-03-23 Alejandro Garcia Castro <firstname.lastname@example.com>
Reviewed by Holger Freyther.
[Gtk] Current API does not allow us to open target="_blank" links
in new tabs instead of windows
Added a signal to the API (new-window-policy-decision-requested)
that allows the browser to decide the policy for the new window
request, if the signal is not handled we open the new window as
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebview.cpp:


text: Michelle Kwan had a surprising, cute, and quick cameo on last night's episode of Kathy Griffin: My Life on the D-List on the Bravo network. Kathy made a bulimic joke about them holding each other's hair while they throw up their meal and Michelle smiled and gave an embarrassed, cute look at her while holding her face with both hands. She was so beautiful! Maybe those who missed it can catch it on a re-run.

subset: commoncrawl


text:
Ordering from USA/Canada? Try our North American shop!
There are items in your cart.
You have no items in your shopping cart.
Availability : Out of stock
Regular Price:
Special Price:
Email to a Friend
Sign up for price alert
Sign up to get notified when this product is back in stock


text:
Southern Arizona Campus
Choose your location to find out more about the degree programs and courses offered at our campuses and learning centers.
Meet face-to-face in your community and in real time with your teachers, fellow classmates and student support specialists.
In addition to our popular, innovative online education, University of Phoenix has campuses across the United States to meet your needs.
Campus Map
Career and Coaching Center
Meet your new career coaches at the Phoenix Main Campus and discover how they can help you map your path to success.


text: Sunny Scarf Print Maxi Dress Style: 570065173 Out of Stock Love it? Everyone else did too. This item sold out! Use our search tool, chat online or call 1.888.855.4986 to find something equally desirable. The maxi dress goes for the bold in our vibrant scarf print. Gathered at the bodice for an elegant drape. Built-in shell at front and back chest. Length 56.5". 95% polyester, 5% spandex. Machine wash. Imported. Read More… Share on Facebook Tweet Pin


text:
Your Account
Your vacuum comes with one. Even your blender comes with one. But your PC--something that costs a whole lot more and is likely to be used daily and for tasks of far greater importance and complexity--doesn't come with a printed manual. Thankfully, that's not a problem any longer: PCs: The Missing Manual explains everything you need to know about PCs, both inside and out, and how to keep them running smoothly and working the way you want them to work.
A complete PC manual for both beginners and power users, PCs: The Missing Manual has something for everyone. PC novices will appreciate the unassuming, straightforward tutorials on PC basics, such as hooking up a monitor, keyboard, mouse, printer, and scanner. Families will enjoy sections on networking several computers to share an Internet connection, sharing one monitor between two PCs, connecting portable media players, and creating a home theater system. Adventurous PC users will like the clear photos explaining how to take your PC apart and replace or upgrade any failing parts; IT professionals will be grateful to have something to hand to their coworkers who need solid, trusted information about using their PC.
In PCs: The Missing Manual, bestselling computer author Andy Rathbone delivers simple, reliable advice on the kinds of things PC users confront every day. He shows you how to connect and configure today's must-have devices (including digital cameras, portable music players, digital camcorders, and keychain drives); burn CDs and DVDs; scan and fax documents, and more. His section on the Internet explains how to choose the best Internet Service Provider and web browser for your needs; send email; find information quickly on the Web; share photos online; set up a blog; set up a webcam; access TV and radio through the Internet; and shop safely online. And Rathbone delivers plenty of guidance on keep your privacy and your PC safe by installing firewalls, creating safe passwords, running antivirus software, removing spyware and adware, and backing up important files.
David A. Karp is the author of the bestselling Windows Annoyances series of books and the founder of Annoyances.org. He writes for PC Magazine and his latest books include eBay Hacks and the upcoming eBay: The Missing Manual.
View David A. Karp's full profile page.
Andy Rathbone first wrote "Windows for Dummies" back in 1992, and since then he's updated the book for every subsequent version of the operating system. All of the editions combined have sold more than 11 million copies. He's also the author of "Upgrading and Fixing Your PC for Dummies" and "Tivo for Dummies". All told, Andy has more than 15 million books in print, making him one of the bestselling computer book writers on the planet. He's been on bestseller lists of the New York Times, USA Today, Publisher's Weekly, and many others.
View Andy Rathbone's full profile page.
(based on 1 review)
Ratings Distribution
5 Stars
4 Stars
3 Stars
2 Stars
1 Stars
Reviewed by 1 customer
Displaying review 1
Back to top
(1 of 1 customers found this review helpful)
PCs: The missing manual - Excellent read
By Eagle8
from Undisclosed
Comments about oreilly PCs: The Missing Manual:
This is an easy to read and greatly detailed manual for beginners, that fills in a lot of missing facts from Microsoft's not-so-helpful "Help and Support' files There are many graphics and detailed pictures to support the explanations and directions given in the text as well as information on everything from reading/writing DVD's to using USB ports, installing programs to network setup and a Bluetooth devices how-to in Windows XP. There's even detailed explanations and helpful pictures on how to upgrade RAM (memory) and install or uninstall hardware in the pc itself.This manual is not written in 'computerese' and is rather a more polite "computers for dummies' for those of us a little sensitive to that phraseology. The table of contents at the front of the book enables the reader to quickly find the section he/she is looking for. There's also a very handy alphabetical index at the back of the book to make it much easier to quickly go to the page that has the information required.Altogether, this 'Missing Manual' by Andy Rathbone is a very good buy and a must-have item for anyone wanting to learn more about their computer and how to service or maintain them without having to shop it out to expensive computer repair stores. The information on common software applications isalso very helpful and I would recommend this book to anyone who is wanting to learn to be more self-sufficient in upgrading and maintaining it themselves.
Was this review helpful? Yes / No
- You may also flag this review
© 2016, O'Reilly Media, Inc.
(707) 827-7019(800) 889-8969
All trademarks and registered trademarks appearing on oreilly.com are the property of their respective owners.