BornAgain: Issues 2019-01-15T14:37:36Z Scientific Computing Group Redmine Bug #2288 (Backlog): Remove numerical instability at q=0 for 2d paracrystal 2019-01-15T14:37:36Z herck <p>Similar to what was done for the radial paracrystal.</p> Configuration #2216 (Backlog): Remove stgz extension in BornAgainCPack.cmake 2018-11-06T14:43:35Z herck Feature #2205 (Backlog): Replace difference plot in fitobserver with the true metric used for min... 2018-10-18T11:47:46Z herck Feature #2094 (Backlog): Remove restrictions (absence of magnetic scattering) for all IComputations 2018-06-20T09:54:20Z herck Refactoring #2050 (Backlog): Remove dependence of SessionModel::copyItem on XML serialization 2018-05-14T16:24:50Z herck <p>Currently SessionModel::copyItem uses SessionXML to generate a copy of a SessionItem and its children. However, in some cases this leads to inconsistencies (e.g. <a class="issue tracker-1 status-3 priority-4 priority-default closed" title="GUI-&gt; Crash on Instrument-&gt;Clone (Resolved)" href="">#2049</a>) because some child items should not be copied literally (e.g. unique id's).</p> Refactoring #1990 (Backlog): Remove duplicate type definitions in BornAgainNamespace.h and item_c... 2018-02-28T13:08:50Z herck Refactoring #1887 (Backlog): Switch to new signal/slot mechanism in Qt (since c++11) 2017-11-10T15:40:00Z herck <p>The new signal/slot mechanism doesn't require slots to be declared as such (they can be any callable).<br />Removing the explicit 'slot' declaration also relaxes the requirements on the argument types of the slot (they no longer need to be registered in the Qt metatype system).<br />To still be able to easily see if a method is used solely as a slot, we could impose the naming convention:<br />Every method that is only used as a slot, should start with 'on'.</p> Refactoring #1766 (Backlog): Replace all form factors in sample creation by shapes 2017-02-16T12:58:42Z herck A simple particle would then contain a shape and a material. Internally, the correct form factors, which still exist, would be generated during a computation.<br />This would accomplish: <ul> <li>Clearer separation between particles' description and the underlying computations (as is mostly the case for all other objects)</li> <li>No need for onChange(), since the shapes would be purely defined by their constructor arguments</li> <li>The shape classes could be shared inside the GUI, allowing an unified generation of vertices for 3D view and some calculations</li> <li>This shared description would then also allow easier implementation of support for 3D files describing a certain shape</li> <li>Custom form factors can then also indicate their real space sizes to determine if they cross layer interfaces</li> </ul> <p>For custom form factors in Python, a specific shape could be used that accepts a (overriden) form factor. This would also be the approach in case of shapes defined by some 3D file format.</p> <p>Related to <a class="issue tracker-4 status-6 priority-4 priority-default closed child" title="omit »FormFactor« from particle geometry class names (Rejected)" href="">#1567</a>.</p> Refactoring #1731 (Backlog): Reduce number of TODOs in code 2016-12-07T13:54:04Z herck <p>Currently counting 105.</p> Feature #1612 (Backlog): Specular peak: add forward scattering amplitudes to specular amplitude 2016-10-06T09:26:14Z herck Refactoring #1089 (Backlog): Refactor interface of evaluate(pol) of Form Factors 2015-05-21T11:45:13Z herck <p>Pass SimulationElement objects instead of the list of vectors and angle-bins.<br />Make sure that when a 'mean' k_f is used, it is the one corresponding to the mean outgoing angles (see also getMeanQ() in SimulationElement)</p> Feature #726 (Backlog): Provide numerically stable calculation of R,T coefficients for magnetic case 2014-07-09T08:27:50Z herck <p>As part of the refactoring for curing the instabilities caused by thick layers, the scalar calculation for R, T coefficients was adapted.<br />A similar adaptation should be done for the magnetic case: see classes <strong>SpecularMagnetic</strong> and <strong>SpecularMagnetic_v2</strong>.</p> Feature #697 (Backlog): Use Monte Carlo integration over all incoherent parameters 2014-06-04T10:44:20Z herck <p>MC integration is already used (can be switched on) for integrating over the bin in reciprocal space.<br />This type of integration can also be used for every type of incoherent sums (beam divergence, incoherent orientations of a nanoparticle, ...)</p> Refactoring #409 (Backlog): Remove duplicate functions "evaluate" and "evaluatePol" 2013-09-25T09:12:12Z herck <p>Both form factors and interference functions contain "evaluate" and "evaluatePol" methods for scalar and matrix amplitudes/intensities respectively.<br />By passing the return value as an argument and providing an interface for them, this duplication could be reduced.</p> Documentation #330 (Backlog): Take care of kz=0 case appropriately 2013-07-17T09:19:35Z herck Right now, when kz is exactly zero inside a layer, a possible linear amplitude profile is not taken care of.<br />Instead, the following happens: <ul> <li>kz=0 in the top layer of a multilayer sample with more than one layer: this means zero glancing angle and we take T0=1 and R0=-1 (as this represents the correct limit). All boundary conditions at the interfaces are put to zero;</li> <li>kz=0 in the only layer: in this case, we only have Born approximation and T=1 and R=0;</li> <li>kz=0 in a layer, other than the top layer of a multilayer sample: while the correct boundary conditions will be calculated, the used profile is a constant one and T=boundary value of wavefunction and R=0.</li> </ul>