Code review comment for lp:~jindallo/nearby-scope/convergence-ui-support

Kyle Nitzsche (knitzsche) wrote :

Hi Jin,

The general approach we discussed is to:
* use high cardinalities to ensure their are enough results to fill in the rows
* limit vertical space in different layouts with collapsed-rows

It seems that this often takes a different approach:
* set collapsed-rows to 0 (which IIRC means show them all without limit)
* limit the number of results with cardinality

Is there a reason you did it this way? Or would you consider doing it the way we discussed?


« Back to merge proposal