• Vasily Averin's avatar
    lockd: fix "list_add double add" caused by legacy signal interface · 81833de1
    Vasily Averin authored
    restart_grace() uses hardcoded init_net.
    It can cause to "list_add double add" in following scenario:
    1) nfsd and lockd was started in several net namespaces
    2) nfsd in init_net was stopped (lockd was not stopped because
     it have users from another net namespaces)
    3) lockd got signal, called restart_grace() -> set_grace_period()
     and enabled lock_manager in hardcoded init_net.
    4) nfsd in init_net is started again,
     its lockd_up() calls set_grace_period() and tries to add
     lock_manager into init_net 2nd time.
    Jeff Layton suggest:
    "Make it safe to call locks_start_grace multiple times on the same
    lock_manager. If it's already on the global grace_list, then don't try
    to add it again.  (But we don't intentionally add twice, so for now we
    WARN about that case.)
    With this change, we also need to ensure that the nfsd4 lock manager
    initializes the list before we call locks_start_grace. While we're at
    it, move the rest of the nfsd_net initialization into
    nfs4_state_create_net. I see no reason to have it spread over two
    functions like it is today."
    Suggested patch was updated to generate warning in described situation.
    Suggested-by: default avatarJeff Layton <jlayton@redhat.com>
    Signed-off-by: default avatarVasily Averin <vvs@virtuozzo.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Last commit
Last update
Makefile Loading commit data...
grace.c Loading commit data...
nfsacl.c Loading commit data...