Skip to content
This repository


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Feb 25, 2009

  1. Allan Caffee

    trace: Fixed a minor typo in an error message.

    Signed-off-by: Allan Caffee <>
    Signed-off-by: Junio C Hamano <>
    allancaffee authored gitster committed

Dec 04, 2007

  1. Christian Couder

    Trace and quote with argv: get rid of unneeded count argument.

    Now that str_buf takes care of all the allocations, there is
    no more gain to pass an argument count.
    So this patch removes the "count" argument from:
    	- "sq_quote_argv"
    	- "trace_argv_printf"
    and all the callers.
    Signed-off-by: Christian Couder <>
    Signed-off-by: Junio C Hamano <>
    chriscool authored gitster committed

Nov 26, 2007

  1. sprohaska

    Use is_absolute_path() in diff-lib.c, lockfile.c, setup.c, trace.c

    Using the helper function to test for absolute paths makes porting easier.
    Signed-off-by: Steffen Prohaska <>
    Signed-off-by: Junio C Hamano <>
    sprohaska authored gitster committed

Nov 14, 2007

  1. Shawn O. Pearce

    Handle broken vsnprintf implementations in strbuf

    Solaris 9's vsnprintf implementation returns -1 if we pass it a
    buffer of length 0.  The only way to get it to give us the actual
    length necessary for the formatted string is to grow the buffer
    out to have at least 1 byte available in the strbuf and then ask
    it to compute the length.
    If the available space is 0 I'm growing it out by 64 to ensure
    we will get an accurate length estimate from all implementations.
    Some callers may need to grow the strbuf again but 64 should be a
    reasonable enough initial growth.
    We also no longer silently fail to append to the string when we are
    faced with a broken vsnprintf implementation.  On Solaris 9 this
    silent failure caused me to no longer be able to execute "git clone"
    as we tried to exec the empty string rather than "git-clone".
    Signed-off-by: Shawn O. Pearce <>
    Signed-off-by: Junio C Hamano <>
    spearce authored gitster committed

Sep 21, 2007

  1. Pierre Habouzit

    sq_quote_argv and add_to_string rework with strbuf's.

    * sq_quote_buf is made public, and works on a strbuf.
    * sq_quote_argv also works on a strbuf.
    * make sq_quote_argv take a "maxlen" argument to check the buffer won't grow
      too big.
    Signed-off-by: Pierre Habouzit <>
    Signed-off-by: Junio C Hamano <>
    MadCoder authored gitster committed
  2. Pierre Habouzit

    nfv?asprintf are broken without va_copy, workaround them.

    * drop nfasprintf.
    * move nfvasprintf into imap-send.c back, and let it work on a 8k buffer,
      and die() in case of overflow. It should be enough for imap commands, if
      someone cares about imap-send, he's welcomed to fix it properly.
    * replace nfvasprintf use in merge-recursive with a copy of the strbuf_addf
      logic, it's one place, we'll live with it.
      To ease the change, output_buffer string list is replaced with a strbuf ;)
    * rework trace.c to call vsnprintf itself.  It's used to format strerror()s
      and git command names, it should never be more than a few octets long, let
      it work on a 8k static buffer with vsnprintf or die loudly.
    Signed-off-by: Pierre Habouzit <>
    MadCoder authored gitster committed

Mar 11, 2007

  1. git-branch, git-checkout: autosetup for remote branch tracking

    In order to track and build on top of a branch 'topic' you track from
    your upstream repository, you often would end up doing this sequence:
      git checkout -b mytopic origin/topic
      git config --add branch.mytopic.remote origin
      git config --add branch.mytopic.merge refs/heads/topic
    This would first fork your own 'mytopic' branch from the 'topic'
    branch you track from the 'origin' repository; then it would set up two
    configuration variables so that 'git pull' without parameters does the
    right thing while you are on your own 'mytopic' branch.
    This commit adds a --track option to git-branch, so that "git
    branch --track mytopic origin/topic" performs the latter two actions
    when creating your 'mytopic' branch.
    If the configuration variable branch.autosetupmerge is set to true, you
    do not have to pass the --track option explicitly; further patches in
    this series allow setting the variable with a "git remote add" option.
    The configuration variable is off by default, and there is a --no-track
    option to countermand it even if the variable is set.
    Signed-off-by: Paolo Bonzini  <>
    Signed-off-by: Junio C Hamano <>
    Paolo Bonzini authored Junio C Hamano committed

Jan 08, 2007

  1. Andy Whitcroft

    short i/o: clean up the naming for the write_{in,or}_xxx family

    We recently introduced a write_in_full() which would either write
    the specified object or emit an error message and fail.  In order
    to fix the read side we now want to introduce a read_in_full()
    but without an error emit.  This patch cleans up the naming
    of this family of calls:
    1) convert the existing write_or_whine() to write_or_whine_pipe()
       to better indicate its pipe specific nature,
    2) convert the existing write_in_full() calls to write_or_whine()
       to better indicate its nature,
    3) introduce a write_in_full() providing a write or fail semantic,
    4) convert write_or_whine() and write_or_whine_pipe() to use
    Signed-off-by: Andy Whitcroft <>
    Signed-off-by: Junio C Hamano <>
    awhitcroft authored Junio C Hamano committed

Oct 14, 2006

  1. Christian Couder

    Fix tracing when GIT_TRACE is set to an empty string.

    Signed-off-by: Christian Couder <>
    Signed-off-by: Junio C Hamano <>
    chriscool authored Junio C Hamano committed

Sep 13, 2006

  1. Christian Couder

    Fix space in string " false" problem in "trace.c".

    Signed-off-by: Christian Couder <>
    Signed-off-by: Junio C Hamano <>
    chriscool authored Junio C Hamano committed

Sep 02, 2006

  1. Christian Couder

    Trace into a file or an open fd and refactor tracing code.

    If GIT_TRACE is set to an absolute path (starting with a
    '/' character), we interpret this as a file path and we
    trace into it.
    Also if GIT_TRACE is set to an integer value greater than
    1 and lower than 10, we interpret this as an open fd value
    and we trace into it.
    Note that this behavior is not compatible with the
    previous one.
    We also trace whole messages using one write(2) call to
    make sure messages from processes do net get mixed up in
    the middle.
    This patch makes it possible to get trace information when
    running "make test".
    Signed-off-by: Christian Couder <>
    Signed-off-by: Junio C Hamano <>
    chriscool authored Junio C Hamano committed
Something went wrong with that request. Please try again.