He was a member of the Legislative Council of Hong Kong and a vice-chairman of the Democratic Party of Hong Kong.
He was also the 5th President of the Hong Kong Institute of Education. He is at present an official member of the Executive Council of Hong Kong.