{"action":"created","comment":{"url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/comments/120581522","pull_request_review_id":42554395,"id":120581522,"diff_hunk":"@@ -72,13 +65,12 @@\n           }\n         },\n         \"doctors\": {\n-          \"type\": \"text\",\n-          \"analyzer\": \"gp_name_analyzer\",\n-          \"fields\": {\n-            \"keyword\": {\n-              \"type\": \"keyword\",\n-              \"ignore_above\": 256\n-            }\n+          \"type\": \"nested\",","path":"data/mapping/mapping.json","position":65,"original_position":65,"commit_id":"4d293f38650b41a43455fe4e5ddc044737b4bd7d","original_commit_id":"4d293f38650b41a43455fe4e5ddc044737b4bd7d","user":{"login":"neilbmclaughlin","id":212582,"avatar_url":"https://avatars1.githubusercontent.com/u/212582?v=3","gravatar_id":"","url":"https://api.github.com/users/neilbmclaughlin","html_url":"https://github.com/neilbmclaughlin","followers_url":"https://api.github.com/users/neilbmclaughlin/followers","following_url":"https://api.github.com/users/neilbmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/neilbmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/neilbmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilbmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/neilbmclaughlin/orgs","repos_url":"https://api.github.com/users/neilbmclaughlin/repos","events_url":"https://api.github.com/users/neilbmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/neilbmclaughlin/received_events","type":"User","site_admin":false},"body":"Doctors needs to be nested as, with the existing string array of doctors names, a search for 'Andrew Smith' with find a match in [ 'Dr Jane Smith', 'Dr Andrew Jones'].\r\n\r\nThe problem is described [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html).","created_at":"2017-06-07T09:52:25Z","updated_at":"2017-06-07T09:52:25Z","html_url":"https://github.com/nhsuk/profiles-db-elastic/pull/22#discussion_r120581522","pull_request_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/comments/120581522"},"html":{"href":"https://github.com/nhsuk/profiles-db-elastic/pull/22#discussion_r120581522"},"pull_request":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22","id":122283370,"html_url":"https://github.com/nhsuk/profiles-db-elastic/pull/22","diff_url":"https://github.com/nhsuk/profiles-db-elastic/pull/22.diff","patch_url":"https://github.com/nhsuk/profiles-db-elastic/pull/22.patch","issue_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/22","number":22,"state":"open","locked":false,"title":"Common terms search","user":{"login":"neilbmclaughlin","id":212582,"avatar_url":"https://avatars1.githubusercontent.com/u/212582?v=3","gravatar_id":"","url":"https://api.github.com/users/neilbmclaughlin","html_url":"https://github.com/neilbmclaughlin","followers_url":"https://api.github.com/users/neilbmclaughlin/followers","following_url":"https://api.github.com/users/neilbmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/neilbmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/neilbmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilbmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/neilbmclaughlin/orgs","repos_url":"https://api.github.com/users/neilbmclaughlin/repos","events_url":"https://api.github.com/users/neilbmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/neilbmclaughlin/received_events","type":"User","site_admin":false},"body":"I've moved some of the tests around to allow `scripts/test` to be run in the container both locally and in CI.\r\n\r\nDue to the reshaping of the `doctors` property this is a breaking change for `gp-finder` which will be resolved by https://github.com/nhsuk/gp-finder/pull/128.","created_at":"2017-05-24T17:33:31Z","updated_at":"2017-06-07T09:52:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d77293aa26d7228933222a0b78617d89b5bce443","assignee":{"login":"st3v3nhunt","id":639706,"avatar_url":"https://avatars3.githubusercontent.com/u/639706?v=3","gravatar_id":"","url":"https://api.github.com/users/st3v3nhunt","html_url":"https://github.com/st3v3nhunt","followers_url":"https://api.github.com/users/st3v3nhunt/followers","following_url":"https://api.github.com/users/st3v3nhunt/following{/other_user}","gists_url":"https://api.github.com/users/st3v3nhunt/gists{/gist_id}","starred_url":"https://api.github.com/users/st3v3nhunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st3v3nhunt/subscriptions","organizations_url":"https://api.github.com/users/st3v3nhunt/orgs","repos_url":"https://api.github.com/users/st3v3nhunt/repos","events_url":"https://api.github.com/users/st3v3nhunt/events{/privacy}","received_events_url":"https://api.github.com/users/st3v3nhunt/received_events","type":"User","site_admin":false},"assignees":[{"login":"st3v3nhunt","id":639706,"avatar_url":"https://avatars3.githubusercontent.com/u/639706?v=3","gravatar_id":"","url":"https://api.github.com/users/st3v3nhunt","html_url":"https://github.com/st3v3nhunt","followers_url":"https://api.github.com/users/st3v3nhunt/followers","following_url":"https://api.github.com/users/st3v3nhunt/following{/other_user}","gists_url":"https://api.github.com/users/st3v3nhunt/gists{/gist_id}","starred_url":"https://api.github.com/users/st3v3nhunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st3v3nhunt/subscriptions","organizations_url":"https://api.github.com/users/st3v3nhunt/orgs","repos_url":"https://api.github.com/users/st3v3nhunt/repos","events_url":"https://api.github.com/users/st3v3nhunt/events{/privacy}","received_events_url":"https://api.github.com/users/st3v3nhunt/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"beseven","id":1902266,"avatar_url":"https://avatars3.githubusercontent.com/u/1902266?v=3","gravatar_id":"","url":"https://api.github.com/users/beseven","html_url":"https://github.com/beseven","followers_url":"https://api.github.com/users/beseven/followers","following_url":"https://api.github.com/users/beseven/following{/other_user}","gists_url":"https://api.github.com/users/beseven/gists{/gist_id}","starred_url":"https://api.github.com/users/beseven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beseven/subscriptions","organizations_url":"https://api.github.com/users/beseven/orgs","repos_url":"https://api.github.com/users/beseven/repos","events_url":"https://api.github.com/users/beseven/events{/privacy}","received_events_url":"https://api.github.com/users/beseven/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22/commits","review_comments_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22/comments","review_comment_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/22/comments","statuses_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/statuses/4d293f38650b41a43455fe4e5ddc044737b4bd7d","head":{"label":"nhsuk:feature/common-terms-search","ref":"feature/common-terms-search","sha":"4d293f38650b41a43455fe4e5ddc044737b4bd7d","user":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars1.githubusercontent.com/u/18658529?v=3","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":87811101,"name":"profiles-db-elastic","full_name":"nhsuk/profiles-db-elastic","owner":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars1.githubusercontent.com/u/18658529?v=3","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhsuk/profiles-db-elastic","description":"Elasticsearch repository of profile data","fork":false,"url":"https://api.github.com/repos/nhsuk/profiles-db-elastic","forks_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/forks","keys_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/teams","hooks_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/hooks","issue_events_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/events{/number}","events_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/events","assignees_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/assignees{/user}","branches_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/branches{/branch}","tags_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/tags","blobs_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/statuses/{sha}","languages_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/languages","stargazers_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/stargazers","contributors_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/contributors","subscribers_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/subscribers","subscription_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/subscription","commits_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/contents/{+path}","compare_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/merges","archive_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/downloads","issues_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues{/number}","pulls_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls{/number}","milestones_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/milestones{/number}","notifications_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/labels{/name}","releases_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/releases{/id}","deployments_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/deployments","created_at":"2017-04-10T12:59:33Z","updated_at":"2017-05-03T11:12:20Z","pushed_at":"2017-06-06T21:26:16Z","git_url":"git://github.com/nhsuk/profiles-db-elastic.git","ssh_url":"git@github.com:nhsuk/profiles-db-elastic.git","clone_url":"https://github.com/nhsuk/profiles-db-elastic.git","svn_url":"https://github.com/nhsuk/profiles-db-elastic","homepage":null,"size":8226,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"nhsuk:master","ref":"master","sha":"587e5a4e75477eb73313e6d29420dcb6371adffb","user":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars1.githubusercontent.com/u/18658529?v=3","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":87811101,"name":"profiles-db-elastic","full_name":"nhsuk/profiles-db-elastic","owner":{"login":"nhsuk","id":18658529,"avatar_url":"https://avatars1.githubusercontent.com/u/18658529?v=3","gravatar_id":"","url":"https://api.github.com/users/nhsuk","html_url":"https://github.com/nhsuk","followers_url":"https://api.github.com/users/nhsuk/followers","following_url":"https://api.github.com/users/nhsuk/following{/other_user}","gists_url":"https://api.github.com/users/nhsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/nhsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhsuk/subscriptions","organizations_url":"https://api.github.com/users/nhsuk/orgs","repos_url":"https://api.github.com/users/nhsuk/repos","events_url":"https://api.github.com/users/nhsuk/events{/privacy}","received_events_url":"https://api.github.com/users/nhsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhsuk/profiles-db-elastic","description":"Elasticsearch repository of profile data","fork":false,"url":"https://api.github.com/repos/nhsuk/profiles-db-elastic","forks_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/forks","keys_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/teams","hooks_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/hooks","issue_events_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/events{/number}","events_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/events","assignees_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/assignees{/user}","branches_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/branches{/branch}","tags_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/tags","blobs_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/statuses/{sha}","languages_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/languages","stargazers_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/stargazers","contributors_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/contributors","subscribers_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/subscribers","subscription_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/subscription","commits_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/contents/{+path}","compare_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/merges","archive_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/downloads","issues_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues{/number}","pulls_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls{/number}","milestones_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/milestones{/number}","notifications_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/labels{/name}","releases_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/releases{/id}","deployments_url":"https://api.github.com/repos/nhsuk/profiles-db-elastic/deployments","created_at":"2017-04-10T12:59:33Z","updated_at":"2017-05-03T11:12:20Z","pushed_at":"2017-06-06T21:26:16Z","git_url":"git://github.com/nhsuk/profiles-db-elastic.git","ssh_url":"git@github.com:nhsuk/profiles-db-elastic.git","clone_url":"https://github.com/nhsuk/profiles-db-elastic.git","svn_url":"https://github.com/nhsuk/profiles-db-elastic","homepage":null,"size":8226,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22"},"html":{"href":"https://github.com/nhsuk/profiles-db-elastic/pull/22"},"issue":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/22"},"comments":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/nhsuk/profiles-db-elastic/statuses/4d293f38650b41a43455fe4e5ddc044737b4bd7d"}}}}
{"actor":{"display_login":"neilbmclaughlin"}}