{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/gitlab-plugin/issues/614","repository_url":"https://api.github.com/repos/jenkinsci/gitlab-plugin","labels_url":"https://api.github.com/repos/jenkinsci/gitlab-plugin/issues/614/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/gitlab-plugin/issues/614/comments","events_url":"https://api.github.com/repos/jenkinsci/gitlab-plugin/issues/614/events","html_url":"https://github.com/jenkinsci/gitlab-plugin/pull/614","id":253425103,"number":614,"title":"Adds support for GitLabAPI V4 while keeping support for V3","user":{"login":"Argelbargel","id":54041,"avatar_url":"https://avatars1.githubusercontent.com/u/54041?v=4","gravatar_id":"","url":"https://api.github.com/users/Argelbargel","html_url":"https://github.com/Argelbargel","followers_url":"https://api.github.com/users/Argelbargel/followers","following_url":"https://api.github.com/users/Argelbargel/following{/other_user}","gists_url":"https://api.github.com/users/Argelbargel/gists{/gist_id}","starred_url":"https://api.github.com/users/Argelbargel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Argelbargel/subscriptions","organizations_url":"https://api.github.com/users/Argelbargel/orgs","repos_url":"https://api.github.com/users/Argelbargel/repos","events_url":"https://api.github.com/users/Argelbargel/events{/privacy}","received_events_url":"https://api.github.com/users/Argelbargel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2017-08-28T19:07:22Z","updated_at":"2017-10-11T23:03:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jenkinsci/gitlab-plugin/pulls/614","html_url":"https://github.com/jenkinsci/gitlab-plugin/pull/614","diff_url":"https://github.com/jenkinsci/gitlab-plugin/pull/614.diff","patch_url":"https://github.com/jenkinsci/gitlab-plugin/pull/614.patch"},"body":"This is an enhancement of PR #596 which adds support for gitlab-api v4 while keeping support for v3\r\n(as i forked jenkins/gitlab-plugin i could not find a simple way to add to @ZJvandeWeg 's PR). \r\nGitLabConnectionConfig has a new configuration option \"API-Level\" in the advanced configuration section where you can switch between v3 and v4. Default is \"autodetect\" which tries to determine which api-endpoint is available (v3 is preferred for now). The result of the autodetection is cached after the first request to the server.\r\n\r\nAdditionally, i've tried to change the name of the classes so that the class-names correspond with the names of the getters and variables, thus GitLabApi is now called GitLabClient.\r\n\r\nThis is just some fancy code to switch the interface-definitions used to create a gitlab-rest-client. i'm not sure if switching between apis will work for existing jobs which do not have both the id and iid of merge-requests stored somewhere - could be that we have to change other parts to build a seamless upgrade path to v4."},"comment":{"url":"https://api.github.com/repos/jenkinsci/gitlab-plugin/issues/comments/335973230","html_url":"https://github.com/jenkinsci/gitlab-plugin/pull/614#issuecomment-335973230","issue_url":"https://api.github.com/repos/jenkinsci/gitlab-plugin/issues/614","id":335973230,"user":{"login":"omehegan","id":1775894,"avatar_url":"https://avatars0.githubusercontent.com/u/1775894?v=4","gravatar_id":"","url":"https://api.github.com/users/omehegan","html_url":"https://github.com/omehegan","followers_url":"https://api.github.com/users/omehegan/followers","following_url":"https://api.github.com/users/omehegan/following{/other_user}","gists_url":"https://api.github.com/users/omehegan/gists{/gist_id}","starred_url":"https://api.github.com/users/omehegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omehegan/subscriptions","organizations_url":"https://api.github.com/users/omehegan/orgs","repos_url":"https://api.github.com/users/omehegan/repos","events_url":"https://api.github.com/users/omehegan/events{/privacy}","received_events_url":"https://api.github.com/users/omehegan/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T23:03:46Z","updated_at":"2017-10-11T23:03:46Z","author_association":"MEMBER","body":"@Argelbargel the docker setup does not even include test jobs, you would need to create some. I just thought that might help you try to replicate the issue @Alexxtheonly is seeing."}}
{"actor":{"display_login":"omehegan"}}