{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/154392082","pull_request_review_id":80553343,"id":154392082,"diff_hunk":"@@ -0,0 +1,38 @@\n+class QpidProton < Formula\n+  desc \"High-performance, lightweight AMQP 1.0 messaging library\"\n+  homepage \"https://qpid.apache.org/proton/\"\n+  url \"https://www.apache.org/dyn/closer.lua?path=qpid/proton/0.18.0/qpid-proton-0.18.0.tar.gz\"\n+  sha256 \"7f54c3555a8482d439759c087d656d881369252af23f209f1fd5a7e4a8c59bd7\"\n+  head \"git://git.apache.org/qpid-proton.git\"\n+\n+  depends_on \"cmake\" => :build\n+  depends_on \"libuv\"\n+  depends_on \"openssl\"\n+\n+  def install\n+    ENV[\"OPENSSL_ROOT_DIR\"] = Formula[\"openssl\"].opt_prefix\n+\n+    system \"cmake\", \".\", \"-DBUILD_BINDINGS=\",\n+                         \"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=#{lib}\",\n+                         *std_cmake_args\n+    system \"make\", \"install\"\n+  end\n+\n+  test do\n+    (testpath/\"test.c\").write <<-EOS.undent","path":"Formula/qpid-proton.rb","position":null,"original_position":22,"commit_id":"be20d133cc521eddc62b3de0a484c88332b517d3","original_commit_id":"7833a92ca7f987e3712be4a0c93fc02dcf4d4174","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"Could but they're not actually equivalent :(","created_at":"2017-12-01T16:46:02Z","updated_at":"2017-12-01T16:46:02Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/19414#discussion_r154392082","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/154392082"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/19414#discussion_r154392082"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414"}},"in_reply_to_id":154390784},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414","id":146522970,"html_url":"https://github.com/Homebrew/homebrew-core/pull/19414","diff_url":"https://github.com/Homebrew/homebrew-core/pull/19414.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/19414.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19414","number":19414,"state":"open","locked":false,"title":"qpid-proton 0.18.0 (new formula)","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nReplaces #10111 (which was closed)\r\n\r\nI've intentionally left out the building of bindings as was controversial in #10111, and tried to keep this as small as possible such that it only builds the library.  I think we can do the language bindings in follow up PRs if necessary...thinking we could leverage optional params like `--with-ruby-binding`, `--with-python-binding`, etc, but want to get the opinions from the core team on how to proceed first.\r\n\r\nAlso I left out the cyrus_sasl (libsasl2) optional dependency, because I don't see it in homebrew.  I'll probably have to create a separate formula for it eventually, but it looks beastly.\r\n\r\n---\r\n\r\ncc @gberginc @blomquisg @kbrock ","created_at":"2017-10-13T18:22:16Z","updated_at":"2017-12-01T16:46:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"170122c627a482f9dbaeca5a86aa7a3b550211cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19414/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/be20d133cc521eddc62b3de0a484c88332b517d3","head":{"label":"Fryguy:qpid-proton","ref":"qpid-proton","sha":"be20d133cc521eddc62b3de0a484c88332b517d3","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"repo":{"id":106854750,"name":"homebrew-core","full_name":"Fryguy/homebrew-core","owner":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fryguy/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/Fryguy/homebrew-core","forks_url":"https://api.github.com/repos/Fryguy/homebrew-core/forks","keys_url":"https://api.github.com/repos/Fryguy/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fryguy/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fryguy/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Fryguy/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Fryguy/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Fryguy/homebrew-core/events","assignees_url":"https://api.github.com/repos/Fryguy/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Fryguy/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Fryguy/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Fryguy/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fryguy/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fryguy/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fryguy/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fryguy/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Fryguy/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Fryguy/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Fryguy/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Fryguy/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Fryguy/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Fryguy/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fryguy/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fryguy/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fryguy/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fryguy/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Fryguy/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fryguy/homebrew-core/merges","archive_url":"https://api.github.com/repos/Fryguy/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fryguy/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Fryguy/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Fryguy/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Fryguy/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Fryguy/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fryguy/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Fryguy/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Fryguy/homebrew-core/deployments","created_at":"2017-10-13T17:36:04Z","updated_at":"2017-10-13T17:36:36Z","pushed_at":"2017-12-01T16:42:12Z","git_url":"git://github.com/Fryguy/homebrew-core.git","ssh_url":"git@github.com:Fryguy/homebrew-core.git","clone_url":"https://github.com/Fryguy/homebrew-core.git","svn_url":"https://github.com/Fryguy/homebrew-core","homepage":"https://brew.sh","size":145264,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"60251bdd8da0c4a38deaad68bb92cf4bc605a76b","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2017-12-01T06:46:14Z","pushed_at":"2017-12-01T16:42:14Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":155375,"stargazers_count":2573,"watchers_count":2573,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3577,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"bsd-2-clause","name":"BSD 2-clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":3577,"open_issues":105,"watchers":2573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/19414"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19414"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19414/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19414/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/be20d133cc521eddc62b3de0a484c88332b517d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ilovezfs"}}