{"action":"created","comment":{"url":"https://api.github.com/repos/browscap/browscap/pulls/comments/113752775","pull_request_review_id":35168443,"id":113752775,"diff_hunk":"@@ -40,7 +40,9 @@\n         },\n         {\n           \"match\": \"#DEVICE#/#MAJORVER#.#MINORVER# Release/* WAP.Browser/1.0*\",\n-          \"device\": \"Motorola W220\"","path":"resources/user-agents/browsers/motorola-internet-browser/motorola-internet-browser-1-0.json","position":4,"original_position":4,"commit_id":"e3b16dd3ec6a5b189234787a2602b0cea23ae47f","original_commit_id":"e3b16dd3ec6a5b189234787a2602b0cea23ae47f","user":{"login":"jaydiablo","id":136907,"avatar_url":"https://avatars3.githubusercontent.com/u/136907?v=3","gravatar_id":"","url":"https://api.github.com/users/jaydiablo","html_url":"https://github.com/jaydiablo","followers_url":"https://api.github.com/users/jaydiablo/followers","following_url":"https://api.github.com/users/jaydiablo/following{/other_user}","gists_url":"https://api.github.com/users/jaydiablo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydiablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydiablo/subscriptions","organizations_url":"https://api.github.com/users/jaydiablo/orgs","repos_url":"https://api.github.com/users/jaydiablo/repos","events_url":"https://api.github.com/users/jaydiablo/events{/privacy}","received_events_url":"https://api.github.com/users/jaydiablo/received_events","type":"User","site_admin":false},"body":"Devices object missing (mistake on my part from #1403)","created_at":"2017-04-27T17:14:21Z","updated_at":"2017-04-27T17:19:55Z","html_url":"https://github.com/browscap/browscap/pull/1405#discussion_r113752775","pull_request_url":"https://api.github.com/repos/browscap/browscap/pulls/1405","_links":{"self":{"href":"https://api.github.com/repos/browscap/browscap/pulls/comments/113752775"},"html":{"href":"https://github.com/browscap/browscap/pull/1405#discussion_r113752775"},"pull_request":{"href":"https://api.github.com/repos/browscap/browscap/pulls/1405"}}},"pull_request":{"url":"https://api.github.com/repos/browscap/browscap/pulls/1405","id":117988389,"html_url":"https://github.com/browscap/browscap/pull/1405","diff_url":"https://github.com/browscap/browscap/pull/1405.diff","patch_url":"https://github.com/browscap/browscap/pull/1405.patch","issue_url":"https://api.github.com/repos/browscap/browscap/issues/1405","number":1405,"state":"open","locked":false,"title":"Updating YaBrowser pattern to catch new iOS 10.3 UA, adding YaApp","user":{"login":"jaydiablo","id":136907,"avatar_url":"https://avatars3.githubusercontent.com/u/136907?v=3","gravatar_id":"","url":"https://api.github.com/users/jaydiablo","html_url":"https://github.com/jaydiablo","followers_url":"https://api.github.com/users/jaydiablo/followers","following_url":"https://api.github.com/users/jaydiablo/following{/other_user}","gists_url":"https://api.github.com/users/jaydiablo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydiablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydiablo/subscriptions","organizations_url":"https://api.github.com/users/jaydiablo/orgs","repos_url":"https://api.github.com/users/jaydiablo/repos","events_url":"https://api.github.com/users/jaydiablo/events{/privacy}","received_events_url":"https://api.github.com/users/jaydiablo/received_events","type":"User","site_admin":false},"body":"Fixes #1406\n\nMost YaBrowser useragents for iOS don’t have the `Version/10.0` part, which the YaBrowser patterns aren’t setup to handle, so this was detecting as Safari Webview.\n\nI downloaded the YaBrowser app to my phone and confirmed that on iOS 10.3 the `Version/10.0` piece has been added.\n\nTo keep from having to add a separate pattern for this, I just added an asterisk after the `(*khtml*like*gecko*)` part of the pattern, but that doesn’t make it long enough to be longer than the Safari Webview 10.0 pattern.  So I added `Mobile/*` to the end of the pattern, which does make it long enough and matches the useragents previous to iOS 10.3.\n\nHowever, that caused a test to fail because that test had this useragent:\n\n>Mozilla/5.0 (iPhone; CPU iPhone OS 10_2_1 like Mac OS X) AppleWebKit/602.4.6 (KHTML, like Gecko) YaBrowser/16.3.3.4 YaApp_iOS/3.11\n\nWhich doesn’t contain the `Mobile` keyword at all.\n\nWith some research and downloading of Yandex apps, I found this UA to actually belong to the “Yandex App” (https://itunes.apple.com/us/app/yandex-one-app-for-news-weather-and-more/id1050704155?mt=8).\n\nSo I added some patterns to detect that app (and modified the test).\n\nI grabbed some YaBrowser iOS UAs from our logs, and some YaApp iOS agents as well to add to the test suite.","created_at":"2017-04-27T17:12:47Z","updated_at":"2017-04-27T17:19:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fced6ea77b75df9e74a4b537c03f14f11b1e4ba2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/browscap/browscap/pulls/1405/commits","review_comments_url":"https://api.github.com/repos/browscap/browscap/pulls/1405/comments","review_comment_url":"https://api.github.com/repos/browscap/browscap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/browscap/browscap/issues/1405/comments","statuses_url":"https://api.github.com/repos/browscap/browscap/statuses/e3b16dd3ec6a5b189234787a2602b0cea23ae47f","head":{"label":"jaydiablo:issue-1406","ref":"issue-1406","sha":"e3b16dd3ec6a5b189234787a2602b0cea23ae47f","user":{"login":"jaydiablo","id":136907,"avatar_url":"https://avatars3.githubusercontent.com/u/136907?v=3","gravatar_id":"","url":"https://api.github.com/users/jaydiablo","html_url":"https://github.com/jaydiablo","followers_url":"https://api.github.com/users/jaydiablo/followers","following_url":"https://api.github.com/users/jaydiablo/following{/other_user}","gists_url":"https://api.github.com/users/jaydiablo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydiablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydiablo/subscriptions","organizations_url":"https://api.github.com/users/jaydiablo/orgs","repos_url":"https://api.github.com/users/jaydiablo/repos","events_url":"https://api.github.com/users/jaydiablo/events{/privacy}","received_events_url":"https://api.github.com/users/jaydiablo/received_events","type":"User","site_admin":false},"repo":{"id":81615032,"name":"browscap","full_name":"jaydiablo/browscap","owner":{"login":"jaydiablo","id":136907,"avatar_url":"https://avatars3.githubusercontent.com/u/136907?v=3","gravatar_id":"","url":"https://api.github.com/users/jaydiablo","html_url":"https://github.com/jaydiablo","followers_url":"https://api.github.com/users/jaydiablo/followers","following_url":"https://api.github.com/users/jaydiablo/following{/other_user}","gists_url":"https://api.github.com/users/jaydiablo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydiablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydiablo/subscriptions","organizations_url":"https://api.github.com/users/jaydiablo/orgs","repos_url":"https://api.github.com/users/jaydiablo/repos","events_url":"https://api.github.com/users/jaydiablo/events{/privacy}","received_events_url":"https://api.github.com/users/jaydiablo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaydiablo/browscap","description":":page_with_curl: The main project repository","fork":true,"url":"https://api.github.com/repos/jaydiablo/browscap","forks_url":"https://api.github.com/repos/jaydiablo/browscap/forks","keys_url":"https://api.github.com/repos/jaydiablo/browscap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaydiablo/browscap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaydiablo/browscap/teams","hooks_url":"https://api.github.com/repos/jaydiablo/browscap/hooks","issue_events_url":"https://api.github.com/repos/jaydiablo/browscap/issues/events{/number}","events_url":"https://api.github.com/repos/jaydiablo/browscap/events","assignees_url":"https://api.github.com/repos/jaydiablo/browscap/assignees{/user}","branches_url":"https://api.github.com/repos/jaydiablo/browscap/branches{/branch}","tags_url":"https://api.github.com/repos/jaydiablo/browscap/tags","blobs_url":"https://api.github.com/repos/jaydiablo/browscap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaydiablo/browscap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaydiablo/browscap/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaydiablo/browscap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaydiablo/browscap/statuses/{sha}","languages_url":"https://api.github.com/repos/jaydiablo/browscap/languages","stargazers_url":"https://api.github.com/repos/jaydiablo/browscap/stargazers","contributors_url":"https://api.github.com/repos/jaydiablo/browscap/contributors","subscribers_url":"https://api.github.com/repos/jaydiablo/browscap/subscribers","subscription_url":"https://api.github.com/repos/jaydiablo/browscap/subscription","commits_url":"https://api.github.com/repos/jaydiablo/browscap/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaydiablo/browscap/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaydiablo/browscap/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaydiablo/browscap/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaydiablo/browscap/contents/{+path}","compare_url":"https://api.github.com/repos/jaydiablo/browscap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaydiablo/browscap/merges","archive_url":"https://api.github.com/repos/jaydiablo/browscap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaydiablo/browscap/downloads","issues_url":"https://api.github.com/repos/jaydiablo/browscap/issues{/number}","pulls_url":"https://api.github.com/repos/jaydiablo/browscap/pulls{/number}","milestones_url":"https://api.github.com/repos/jaydiablo/browscap/milestones{/number}","notifications_url":"https://api.github.com/repos/jaydiablo/browscap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaydiablo/browscap/labels{/name}","releases_url":"https://api.github.com/repos/jaydiablo/browscap/releases{/id}","deployments_url":"https://api.github.com/repos/jaydiablo/browscap/deployments","created_at":"2017-02-10T23:04:49Z","updated_at":"2017-02-10T23:04:53Z","pushed_at":"2017-04-27T17:12:46Z","git_url":"git://github.com/jaydiablo/browscap.git","ssh_url":"git@github.com:jaydiablo/browscap.git","clone_url":"https://github.com/jaydiablo/browscap.git","svn_url":"https://github.com/jaydiablo/browscap","homepage":"http://browscap.org/","size":24512,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"browscap:master","ref":"master","sha":"e3f6e3481da9ebcf7b399487c2febf5db1f719d9","user":{"login":"browscap","id":2726905,"avatar_url":"https://avatars2.githubusercontent.com/u/2726905?v=3","gravatar_id":"","url":"https://api.github.com/users/browscap","html_url":"https://github.com/browscap","followers_url":"https://api.github.com/users/browscap/followers","following_url":"https://api.github.com/users/browscap/following{/other_user}","gists_url":"https://api.github.com/users/browscap/gists{/gist_id}","starred_url":"https://api.github.com/users/browscap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browscap/subscriptions","organizations_url":"https://api.github.com/users/browscap/orgs","repos_url":"https://api.github.com/users/browscap/repos","events_url":"https://api.github.com/users/browscap/events{/privacy}","received_events_url":"https://api.github.com/users/browscap/received_events","type":"Organization","site_admin":false},"repo":{"id":7802677,"name":"browscap","full_name":"browscap/browscap","owner":{"login":"browscap","id":2726905,"avatar_url":"https://avatars2.githubusercontent.com/u/2726905?v=3","gravatar_id":"","url":"https://api.github.com/users/browscap","html_url":"https://github.com/browscap","followers_url":"https://api.github.com/users/browscap/followers","following_url":"https://api.github.com/users/browscap/following{/other_user}","gists_url":"https://api.github.com/users/browscap/gists{/gist_id}","starred_url":"https://api.github.com/users/browscap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browscap/subscriptions","organizations_url":"https://api.github.com/users/browscap/orgs","repos_url":"https://api.github.com/users/browscap/repos","events_url":"https://api.github.com/users/browscap/events{/privacy}","received_events_url":"https://api.github.com/users/browscap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/browscap/browscap","description":":page_with_curl: The main project repository","fork":false,"url":"https://api.github.com/repos/browscap/browscap","forks_url":"https://api.github.com/repos/browscap/browscap/forks","keys_url":"https://api.github.com/repos/browscap/browscap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/browscap/browscap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/browscap/browscap/teams","hooks_url":"https://api.github.com/repos/browscap/browscap/hooks","issue_events_url":"https://api.github.com/repos/browscap/browscap/issues/events{/number}","events_url":"https://api.github.com/repos/browscap/browscap/events","assignees_url":"https://api.github.com/repos/browscap/browscap/assignees{/user}","branches_url":"https://api.github.com/repos/browscap/browscap/branches{/branch}","tags_url":"https://api.github.com/repos/browscap/browscap/tags","blobs_url":"https://api.github.com/repos/browscap/browscap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/browscap/browscap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/browscap/browscap/git/refs{/sha}","trees_url":"https://api.github.com/repos/browscap/browscap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/browscap/browscap/statuses/{sha}","languages_url":"https://api.github.com/repos/browscap/browscap/languages","stargazers_url":"https://api.github.com/repos/browscap/browscap/stargazers","contributors_url":"https://api.github.com/repos/browscap/browscap/contributors","subscribers_url":"https://api.github.com/repos/browscap/browscap/subscribers","subscription_url":"https://api.github.com/repos/browscap/browscap/subscription","commits_url":"https://api.github.com/repos/browscap/browscap/commits{/sha}","git_commits_url":"https://api.github.com/repos/browscap/browscap/git/commits{/sha}","comments_url":"https://api.github.com/repos/browscap/browscap/comments{/number}","issue_comment_url":"https://api.github.com/repos/browscap/browscap/issues/comments{/number}","contents_url":"https://api.github.com/repos/browscap/browscap/contents/{+path}","compare_url":"https://api.github.com/repos/browscap/browscap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/browscap/browscap/merges","archive_url":"https://api.github.com/repos/browscap/browscap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/browscap/browscap/downloads","issues_url":"https://api.github.com/repos/browscap/browscap/issues{/number}","pulls_url":"https://api.github.com/repos/browscap/browscap/pulls{/number}","milestones_url":"https://api.github.com/repos/browscap/browscap/milestones{/number}","notifications_url":"https://api.github.com/repos/browscap/browscap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/browscap/browscap/labels{/name}","releases_url":"https://api.github.com/repos/browscap/browscap/releases{/id}","deployments_url":"https://api.github.com/repos/browscap/browscap/deployments","created_at":"2013-01-24T16:58:26Z","updated_at":"2017-04-19T23:56:33Z","pushed_at":"2017-04-27T17:12:48Z","git_url":"git://github.com/browscap/browscap.git","ssh_url":"git@github.com:browscap/browscap.git","clone_url":"https://github.com/browscap/browscap.git","svn_url":"https://github.com/browscap/browscap","homepage":"http://browscap.org/","size":24503,"stargazers_count":176,"watchers_count":176,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":15,"forks":28,"open_issues":15,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/browscap/browscap/pulls/1405"},"html":{"href":"https://github.com/browscap/browscap/pull/1405"},"issue":{"href":"https://api.github.com/repos/browscap/browscap/issues/1405"},"comments":{"href":"https://api.github.com/repos/browscap/browscap/issues/1405/comments"},"review_comments":{"href":"https://api.github.com/repos/browscap/browscap/pulls/1405/comments"},"review_comment":{"href":"https://api.github.com/repos/browscap/browscap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/browscap/browscap/pulls/1405/commits"},"statuses":{"href":"https://api.github.com/repos/browscap/browscap/statuses/e3b16dd3ec6a5b189234787a2602b0cea23ae47f"}}}}
{"actor":{"display_login":"jaydiablo"}}