{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/150391797","pull_request_review_id":75940285,"id":150391797,"diff_hunk":"@@ -0,0 +1,40 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+#pragma once\n+\n+namespace GeneralizedHarmonic {\n+template <size_t Dim>\n+struct SpacetimeMetric;","path":"src/Evolution/Systems/GeneralizedHarmonic/TagsDeclarations.hpp","position":8,"original_position":8,"commit_id":"68269b47ca7635115b1daef3fb17a63f4927d405","original_commit_id":"68269b47ca7635115b1daef3fb17a63f4927d405","user":{"login":"nilsdeppe","id":13531030,"avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"Why not call this `Psi`? (I'm not requesting a change, just asking for the reason :) )","created_at":"2017-11-11T19:43:14Z","updated_at":"2017-11-11T20:03:41Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/349#discussion_r150391797","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/150391797"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/349#discussion_r150391797"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349","id":151833369,"html_url":"https://github.com/sxs-collaboration/spectre/pull/349","diff_url":"https://github.com/sxs-collaboration/spectre/pull/349.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/349.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/349","number":349,"state":"open","locked":false,"title":"Add GeneralizedHarmonic RHS evaluation. ","user":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nAdd's the Generalized Harmonic RHS evaluation. Only this part of the evolution system is being ported for now to allow testing of analytic solutions to Einstein's equations. \r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [x] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] Follows [code review guidelines](https://sxs-collaboration.github.io/spectre/code_review_guide.html)\r\n- [ ] Code has documentation and unit tests\r\n- [ ] Private member variables have a trailing underscore\r\n- [ ] Do not use [Hungarian notation](https://en.wikipedia.org/wiki/Hungarian_notation), e.g. `double* pd_blah` is bad\r\n- [ ] Header order:\r\n  1. hpp corresponding to cpp (only in cpp files)\r\n  2. Blank line (only in cpp files)\r\n  3. STL and externals (in alphabetical order)\r\n  4. Blank line\r\n  5. SpECTRE includes (in alphabetical order)\r\n- [ ] File lists in CMake are alphabetical\r\n- [ ] Correct `noexcept` specification for functions (if unsure, mark `noexcept`)\r\n- [ ] Mark objects `const` whenever possible\r\n- [ ] Almost always `auto`, except with expression templates, i.e. `DataVector`\r\n- [ ] All commits for performance changes provide quantitative evidence and the tests used to obtain said evidence.\r\n- [ ] Make sure error messages are helpful, e.g. \"The number of grid points in the matrix 'F' is not the same as the number of grid points in the determinant.\"\r\n\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n","created_at":"2017-11-10T06:11:44Z","updated_at":"2017-11-11T20:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b03cb62cf9f0ef5c974954f2d3d4d37a517624e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/349/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/68269b47ca7635115b1daef3fb17a63f4927d405","head":{"label":"osheamonn:add_gh_rhs","ref":"add_gh_rhs","sha":"68269b47ca7635115b1daef3fb17a63f4927d405","user":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"repo":{"id":94911451,"name":"spectre","full_name":"osheamonn/spectre","owner":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osheamonn/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/osheamonn/spectre","forks_url":"https://api.github.com/repos/osheamonn/spectre/forks","keys_url":"https://api.github.com/repos/osheamonn/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osheamonn/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osheamonn/spectre/teams","hooks_url":"https://api.github.com/repos/osheamonn/spectre/hooks","issue_events_url":"https://api.github.com/repos/osheamonn/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/osheamonn/spectre/events","assignees_url":"https://api.github.com/repos/osheamonn/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/osheamonn/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/osheamonn/spectre/tags","blobs_url":"https://api.github.com/repos/osheamonn/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osheamonn/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osheamonn/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/osheamonn/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osheamonn/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/osheamonn/spectre/languages","stargazers_url":"https://api.github.com/repos/osheamonn/spectre/stargazers","contributors_url":"https://api.github.com/repos/osheamonn/spectre/contributors","subscribers_url":"https://api.github.com/repos/osheamonn/spectre/subscribers","subscription_url":"https://api.github.com/repos/osheamonn/spectre/subscription","commits_url":"https://api.github.com/repos/osheamonn/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/osheamonn/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/osheamonn/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/osheamonn/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/osheamonn/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/osheamonn/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osheamonn/spectre/merges","archive_url":"https://api.github.com/repos/osheamonn/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osheamonn/spectre/downloads","issues_url":"https://api.github.com/repos/osheamonn/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/osheamonn/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/osheamonn/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/osheamonn/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osheamonn/spectre/labels{/name}","releases_url":"https://api.github.com/repos/osheamonn/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/osheamonn/spectre/deployments","created_at":"2017-06-20T16:17:41Z","updated_at":"2017-06-20T16:17:43Z","pushed_at":"2017-11-10T22:54:47Z","git_url":"git://github.com/osheamonn/spectre.git","ssh_url":"git@github.com:osheamonn/spectre.git","clone_url":"https://github.com/osheamonn/spectre.git","svn_url":"https://github.com/osheamonn/spectre","homepage":null,"size":3993,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"6c57abf13699699f21fa617643495cd99dc9a992","user":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2017-11-01T15:21:16Z","pushed_at":"2017-11-11T19:41:00Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":4973,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":58,"forks":9,"open_issues":58,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/349"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/349"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/68269b47ca7635115b1daef3fb17a63f4927d405"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nilsdeppe"}}