{"action":"created","issue":{"url":"https://api.github.com/repos/jcbrand/converse.js/issues/796","repository_url":"https://api.github.com/repos/jcbrand/converse.js","labels_url":"https://api.github.com/repos/jcbrand/converse.js/issues/796/labels{/name}","comments_url":"https://api.github.com/repos/jcbrand/converse.js/issues/796/comments","events_url":"https://api.github.com/repos/jcbrand/converse.js/issues/796/events","html_url":"https://github.com/jcbrand/converse.js/pull/796","id":211762330,"number":796,"title":"Adds the send button at bottom of chatbox","user":{"login":"saganshul","id":11960067,"avatar_url":"https://avatars1.githubusercontent.com/u/11960067?v=3","gravatar_id":"","url":"https://api.github.com/users/saganshul","html_url":"https://github.com/saganshul","followers_url":"https://api.github.com/users/saganshul/followers","following_url":"https://api.github.com/users/saganshul/following{/other_user}","gists_url":"https://api.github.com/users/saganshul/gists{/gist_id}","starred_url":"https://api.github.com/users/saganshul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saganshul/subscriptions","organizations_url":"https://api.github.com/users/saganshul/orgs","repos_url":"https://api.github.com/users/saganshul/repos","events_url":"https://api.github.com/users/saganshul/events{/privacy}","received_events_url":"https://api.github.com/users/saganshul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-03T18:13:15Z","updated_at":"2017-03-06T08:07:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jcbrand/converse.js/pulls/796","html_url":"https://github.com/jcbrand/converse.js/pull/796","diff_url":"https://github.com/jcbrand/converse.js/pull/796.diff","patch_url":"https://github.com/jcbrand/converse.js/pull/796.patch"},"body":"## Description\r\nFollowing changes creates a send button functionality at the bottom of chatbox. This is fix regarding the issue #682.\r\n\r\nFollowing changes creates a new function in converse-chatview.js which handles event triggered on clicking the send button and rests are UI changes.\r\n\r\n## Reviewer\r\n@jcbrand \r\n\r\n## Screenshots\r\nPlease find the attached screenshot of this changes.\r\n![screenshot from 2017-03-03 23-39-42](https://cloud.githubusercontent.com/assets/11960067/23562990/c47115c0-006a-11e7-99ce-2556e84ed58e.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jcbrand/converse.js/issues/comments/284327814","html_url":"https://github.com/jcbrand/converse.js/pull/796#issuecomment-284327814","issue_url":"https://api.github.com/repos/jcbrand/converse.js/issues/796","id":284327814,"user":{"login":"jcbrand","id":683911,"avatar_url":"https://avatars2.githubusercontent.com/u/683911?v=3","gravatar_id":"","url":"https://api.github.com/users/jcbrand","html_url":"https://github.com/jcbrand","followers_url":"https://api.github.com/users/jcbrand/followers","following_url":"https://api.github.com/users/jcbrand/following{/other_user}","gists_url":"https://api.github.com/users/jcbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbrand/subscriptions","organizations_url":"https://api.github.com/users/jcbrand/orgs","repos_url":"https://api.github.com/users/jcbrand/repos","events_url":"https://api.github.com/users/jcbrand/events{/privacy}","received_events_url":"https://api.github.com/users/jcbrand/received_events","type":"User","site_admin":false},"created_at":"2017-03-06T08:07:01Z","updated_at":"2017-03-06T08:07:01Z","body":"Thanks.\r\n\r\nI don't want converse.js to have send buttons by default, and since the change requires CSS, it's not so easy to have this option configurable.\r\n\r\nI think what we can do here is to make this a separate plugin, and we can then mention it in the documentation and link to it. We can even put the actual code of the plugin into the plugin documentation as a reference implementation.\r\n\r\nIf you want to contribute to GSoC, then you'll in any case have to learn how to create a plugin, so this will be good experience.\r\n\r\nYou're welcome to put the plugin code into your own Github repo."}}
{"actor":{"display_login":"jcbrand"}}