{"action":"created","issue":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/6189","repository_url":"https://api.github.com/repos/bokeh/bokeh","labels_url":"https://api.github.com/repos/bokeh/bokeh/issues/6189/labels{/name}","comments_url":"https://api.github.com/repos/bokeh/bokeh/issues/6189/comments","events_url":"https://api.github.com/repos/bokeh/bokeh/issues/6189/events","html_url":"https://github.com/bokeh/bokeh/pull/6189","id":223879229,"number":6189,"title":"Canavandl/export png","user":{"login":"canavandl","id":2198981,"avatar_url":"https://avatars3.githubusercontent.com/u/2198981?v=3","gravatar_id":"","url":"https://api.github.com/users/canavandl","html_url":"https://github.com/canavandl","followers_url":"https://api.github.com/users/canavandl/followers","following_url":"https://api.github.com/users/canavandl/following{/other_user}","gists_url":"https://api.github.com/users/canavandl/gists{/gist_id}","starred_url":"https://api.github.com/users/canavandl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canavandl/subscriptions","organizations_url":"https://api.github.com/users/canavandl/orgs","repos_url":"https://api.github.com/users/canavandl/repos","events_url":"https://api.github.com/users/canavandl/events{/privacy}","received_events_url":"https://api.github.com/users/canavandl/received_events","type":"User","site_admin":false},"labels":[{"id":88661915,"url":"https://api.github.com/repos/bokeh/bokeh/labels/status:%20WIP","name":"status: WIP","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-24T16:34:58Z","updated_at":"2017-05-15T14:28:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bokeh/bokeh/pulls/6189","html_url":"https://github.com/bokeh/bokeh/pull/6189","diff_url":"https://github.com/bokeh/bokeh/pull/6189.diff","patch_url":"https://github.com/bokeh/bokeh/pull/6189.patch"},"body":"Canavandl/export png\r\n\r\n- [x] issues: fixes #538 \r\n- [ ] tests added / passed\r\n- [ ] release document entry (if new feature or API change)\r\n\r\nTodo:\r\n- [x] check that phantomjs is installed and raise dependency exception if not\r\n- [x] better figure out layout width/height\r\n- [x] check browser console for errors and warn\r\n- [x] test that themes work\r\n- [ ] better figure out render wait time\r\n- [x] test that custom templates work\r\n\r\nQuestions:\r\n* Do we allow for specified output size or just use document size?\r\n* How will we support or warn about sizing modes?\r\n* Is it ok to force inline resources?"},"comment":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/comments/301492232","html_url":"https://github.com/bokeh/bokeh/pull/6189#issuecomment-301492232","issue_url":"https://api.github.com/repos/bokeh/bokeh/issues/6189","id":301492232,"user":{"login":"canavandl","id":2198981,"avatar_url":"https://avatars3.githubusercontent.com/u/2198981?v=3","gravatar_id":"","url":"https://api.github.com/users/canavandl","html_url":"https://github.com/canavandl","followers_url":"https://api.github.com/users/canavandl/followers","following_url":"https://api.github.com/users/canavandl/following{/other_user}","gists_url":"https://api.github.com/users/canavandl/gists{/gist_id}","starred_url":"https://api.github.com/users/canavandl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canavandl/subscriptions","organizations_url":"https://api.github.com/users/canavandl/orgs","repos_url":"https://api.github.com/users/canavandl/repos","events_url":"https://api.github.com/users/canavandl/events{/privacy}","received_events_url":"https://api.github.com/users/canavandl/received_events","type":"User","site_admin":false},"created_at":"2017-05-15T14:28:42Z","updated_at":"2017-05-15T14:28:42Z","body":"I'm going to mark this as \"ready\". It works on OS-X, Ubuntu and Windows 10.\r\n\r\nThere's some \"unanswered\"\r\n\r\n* Do we allow for specified output size or just use document size?\r\n  * Currently we generate a png that's the size of the layout. We could potentially resize the png based on height/width kwargs, but i'd be worried about changing the aspect ratio of things. There's also plenty of other tools to resize/crop a png, so maybe not dealing with size is fine.\r\n* How will we support or warn about sizing modes?\r\n  * The sizing modes \"work\", but the default PhantomJS window size is 350x300 so the plots end up pretty small. I think it might be best to add a warning to the ``export`` docstring to notify users that sizing modes probably won't behave well.\r\n* Is it ok to force inline resources?"}}
{"actor":{"display_login":"canavandl"}}