{"action":"created","comment":{"url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/comments/122802647","pull_request_review_id":44948987,"id":122802647,"diff_hunk":"@@ -66,7 +66,7 @@ class LocationDAO {\n         // generate ES query to search for locations\n         def esQuery = getESSearchQuery(q, null, null,\n                                        null, null, null,\n-                                       isOpen, pageNumber, pageSize)\n+                                       isOpen, null, pageNumber, pageSize)","path":"src/main/groovy/edu/oregonstate/mist/locations/frontend/db/LocationDAO.groovy","position":21,"original_position":21,"commit_id":"d288b106e4bcac24e9af3fa9f74592b5624b4b9a","original_commit_id":"d288b106e4bcac24e9af3fa9f74592b5624b4b9a","user":{"login":"floppyears","id":273918,"avatar_url":"https://avatars0.githubusercontent.com/u/273918?v=3","gravatar_id":"","url":"https://api.github.com/users/floppyears","html_url":"https://github.com/floppyears","followers_url":"https://api.github.com/users/floppyears/followers","following_url":"https://api.github.com/users/floppyears/following{/other_user}","gists_url":"https://api.github.com/users/floppyears/gists{/gist_id}","starred_url":"https://api.github.com/users/floppyears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floppyears/subscriptions","organizations_url":"https://api.github.com/users/floppyears/orgs","repos_url":"https://api.github.com/users/floppyears/repos","events_url":"https://api.github.com/users/floppyears/events{/privacy}","received_events_url":"https://api.github.com/users/floppyears/received_events","type":"User","site_admin":false},"body":"Hmm, I wonder if we should change the getESSearchQuery method to use a map with named arguments? It would simplify the code that calls that method: http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments . Depending on when we plan to refactor the code to use the ES library / sdk, we could hold off on the code change.","created_at":"2017-06-19T19:32:18Z","updated_at":"2017-06-19T19:34:41Z","html_url":"https://github.com/osu-mist/locations-frontend-api/pull/28#discussion_r122802647","pull_request_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/comments/122802647"},"html":{"href":"https://github.com/osu-mist/locations-frontend-api/pull/28#discussion_r122802647"},"pull_request":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28","id":125423875,"html_url":"https://github.com/osu-mist/locations-frontend-api/pull/28","diff_url":"https://github.com/osu-mist/locations-frontend-api/pull/28.diff","patch_url":"https://github.com/osu-mist/locations-frontend-api/pull/28.patch","issue_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/28","number":28,"state":"open","locked":false,"title":"Feature/co 815 gender inclusive rr implementation","user":{"login":"jaredkosanovic","id":10245860,"avatar_url":"https://avatars3.githubusercontent.com/u/10245860?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredkosanovic","html_url":"https://github.com/jaredkosanovic","followers_url":"https://api.github.com/users/jaredkosanovic/followers","following_url":"https://api.github.com/users/jaredkosanovic/following{/other_user}","gists_url":"https://api.github.com/users/jaredkosanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredkosanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredkosanovic/subscriptions","organizations_url":"https://api.github.com/users/jaredkosanovic/orgs","repos_url":"https://api.github.com/users/jaredkosanovic/repos","events_url":"https://api.github.com/users/jaredkosanovic/events{/privacy}","received_events_url":"https://api.github.com/users/jaredkosanovic/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-13T17:53:16Z","updated_at":"2017-06-19T19:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c173fa9fde237e534d2dc65d37c52acf80c8ad6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28/commits","review_comments_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28/comments","review_comment_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/28/comments","statuses_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/statuses/d288b106e4bcac24e9af3fa9f74592b5624b4b9a","head":{"label":"osu-mist:feature/CO-815-gender-inclusive-rr-implementation","ref":"feature/CO-815-gender-inclusive-rr-implementation","sha":"d288b106e4bcac24e9af3fa9f74592b5624b4b9a","user":{"login":"osu-mist","id":6473936,"avatar_url":"https://avatars2.githubusercontent.com/u/6473936?v=3","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"repo":{"id":49225651,"name":"locations-frontend-api","full_name":"osu-mist/locations-frontend-api","owner":{"login":"osu-mist","id":6473936,"avatar_url":"https://avatars2.githubusercontent.com/u/6473936?v=3","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osu-mist/locations-frontend-api","description":"Locations API frontend that consumes data from elasticsearch.","fork":false,"url":"https://api.github.com/repos/osu-mist/locations-frontend-api","forks_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/forks","keys_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/teams","hooks_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/hooks","issue_events_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/events{/number}","events_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/events","assignees_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/assignees{/user}","branches_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/branches{/branch}","tags_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/tags","blobs_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/statuses/{sha}","languages_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/languages","stargazers_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/stargazers","contributors_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/contributors","subscribers_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/subscribers","subscription_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/subscription","commits_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/contents/{+path}","compare_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/merges","archive_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/downloads","issues_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues{/number}","pulls_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls{/number}","milestones_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/milestones{/number}","notifications_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/labels{/name}","releases_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/releases{/id}","deployments_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/deployments","created_at":"2016-01-07T19:26:25Z","updated_at":"2016-11-17T18:56:39Z","pushed_at":"2017-06-13T18:38:13Z","git_url":"git://github.com/osu-mist/locations-frontend-api.git","ssh_url":"git@github.com:osu-mist/locations-frontend-api.git","clone_url":"https://github.com/osu-mist/locations-frontend-api.git","svn_url":"https://github.com/osu-mist/locations-frontend-api","homepage":null,"size":965,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"osu-mist:develop","ref":"develop","sha":"13b6ff5d62261ca9f9cc2fe2208c05d337ff01e8","user":{"login":"osu-mist","id":6473936,"avatar_url":"https://avatars2.githubusercontent.com/u/6473936?v=3","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"repo":{"id":49225651,"name":"locations-frontend-api","full_name":"osu-mist/locations-frontend-api","owner":{"login":"osu-mist","id":6473936,"avatar_url":"https://avatars2.githubusercontent.com/u/6473936?v=3","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osu-mist/locations-frontend-api","description":"Locations API frontend that consumes data from elasticsearch.","fork":false,"url":"https://api.github.com/repos/osu-mist/locations-frontend-api","forks_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/forks","keys_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/teams","hooks_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/hooks","issue_events_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/events{/number}","events_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/events","assignees_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/assignees{/user}","branches_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/branches{/branch}","tags_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/tags","blobs_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/statuses/{sha}","languages_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/languages","stargazers_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/stargazers","contributors_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/contributors","subscribers_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/subscribers","subscription_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/subscription","commits_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/contents/{+path}","compare_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/merges","archive_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/downloads","issues_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues{/number}","pulls_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls{/number}","milestones_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/milestones{/number}","notifications_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/labels{/name}","releases_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/releases{/id}","deployments_url":"https://api.github.com/repos/osu-mist/locations-frontend-api/deployments","created_at":"2016-01-07T19:26:25Z","updated_at":"2016-11-17T18:56:39Z","pushed_at":"2017-06-13T18:38:13Z","git_url":"git://github.com/osu-mist/locations-frontend-api.git","ssh_url":"git@github.com:osu-mist/locations-frontend-api.git","clone_url":"https://github.com/osu-mist/locations-frontend-api.git","svn_url":"https://github.com/osu-mist/locations-frontend-api","homepage":null,"size":965,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28"},"html":{"href":"https://github.com/osu-mist/locations-frontend-api/pull/28"},"issue":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/28"},"comments":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/osu-mist/locations-frontend-api/statuses/d288b106e4bcac24e9af3fa9f74592b5624b4b9a"}}}}
{"actor":{"display_login":"floppyears"}}