{"action":"created","comment":{"url":"https://api.github.com/repos/WebAssembly/spec/pulls/comments/116161535","pull_request_review_id":37762942,"id":116161535,"diff_hunk":"@@ -377,6 +518,31 @@\n .. |Bexpr| mathdef:: \\xref{binary/instructions}{binary-expr}{\\B{expr}}\n \n \n+.. Instructions, textual non-terminals\n+\n+.. |Tmemarg| mathdef:: \\xref{text/instructions}{text-memarg}{\\T{memarg}}\n+.. |Talign| mathdef:: \\xref{text/instructions}{text-memarg}{\\T{align}}\n+.. |Toffset| mathdef:: \\xref{text/instructions}{text-memarg}{\\T{offset}}\n+\n+.. |Tlabel| mathdef:: \\xref{text/instructions}{text-label}{\\T{label}}\n+.. |Tinstr| mathdef:: \\xref{text/instructions}{text-instr}{\\T{instr}}\n+.. |Tplaininstr| mathdef:: \\xref{text/instructions}{text-plaininstr}{\\T{plaininstr}}\n+.. |Tblockinstr| mathdef:: \\xref{text/instructions}{text-blockinstr}{\\T{blockinstr}}\n+.. |Tfoldedinstr| mathdef:: \\xref{text/instructions}{text-foldedinstr}{\\T{foldedinstr}}\n+.. |Texpr| mathdef:: \\xref{text/instructions}{text-expr}{\\T{expr}}\n+\n+\n+.. Context, textual\n+\n+.. |TYPEDEFS| mathdef:: \\K{typedefs}\n+\n+\n+.. Contexts, meta functions\n+\n+.. |idfresh| mathdef:: ~\\xref{text/conventions}{text-id-fresh}{\\mbox{fresh}}","path":"document/math.def","position":null,"original_position":222,"commit_id":"a90213076341c666dcd989d556ed25bef9940b5c","original_commit_id":"ef40721cdc6a6638a53b5f09b20a0584a0a42a5e","user":{"login":"rossberg-chromium","id":4247099,"avatar_url":"https://avatars3.githubusercontent.com/u/4247099?v=3","gravatar_id":"","url":"https://api.github.com/users/rossberg-chromium","html_url":"https://github.com/rossberg-chromium","followers_url":"https://api.github.com/users/rossberg-chromium/followers","following_url":"https://api.github.com/users/rossberg-chromium/following{/other_user}","gists_url":"https://api.github.com/users/rossberg-chromium/gists{/gist_id}","starred_url":"https://api.github.com/users/rossberg-chromium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossberg-chromium/subscriptions","organizations_url":"https://api.github.com/users/rossberg-chromium/orgs","repos_url":"https://api.github.com/users/rossberg-chromium/repos","events_url":"https://api.github.com/users/rossberg-chromium/events{/privacy}","received_events_url":"https://api.github.com/users/rossberg-chromium/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2017-05-12T06:45:18Z","updated_at":"2017-05-12T06:46:18Z","html_url":"https://github.com/WebAssembly/spec/pull/471#discussion_r116161535","pull_request_url":"https://api.github.com/repos/WebAssembly/spec/pulls/471","_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/comments/116161535"},"html":{"href":"https://github.com/WebAssembly/spec/pull/471#discussion_r116161535"},"pull_request":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/471"}}},"pull_request":{"url":"https://api.github.com/repos/WebAssembly/spec/pulls/471","id":120148778,"html_url":"https://github.com/WebAssembly/spec/pull/471","diff_url":"https://github.com/WebAssembly/spec/pull/471.diff","patch_url":"https://github.com/WebAssembly/spec/pull/471.patch","issue_url":"https://api.github.com/repos/WebAssembly/spec/issues/471","number":471,"state":"open","locked":false,"title":"[spec] Text format","user":{"login":"rossberg-chromium","id":4247099,"avatar_url":"https://avatars3.githubusercontent.com/u/4247099?v=3","gravatar_id":"","url":"https://api.github.com/users/rossberg-chromium","html_url":"https://github.com/rossberg-chromium","followers_url":"https://api.github.com/users/rossberg-chromium/followers","following_url":"https://api.github.com/users/rossberg-chromium/following{/other_user}","gists_url":"https://api.github.com/users/rossberg-chromium/gists{/gist_id}","starred_url":"https://api.github.com/users/rossberg-chromium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossberg-chromium/subscriptions","organizations_url":"https://api.github.com/users/rossberg-chromium/orgs","repos_url":"https://api.github.com/users/rossberg-chromium/repos","events_url":"https://api.github.com/users/rossberg-chromium/events{/privacy}","received_events_url":"https://api.github.com/users/rossberg-chromium/received_events","type":"User","site_admin":false},"body":"This PR specifies the text format, based on earlier discussion between @binji, @lukewagner, @sunfishcode, and myself. Preview at http://webassembly.github.io/spec/\r\n\r\nThe changes relative to the .wast format currently implemented in the interpreter and other tools are the following.\r\n\r\nRemovals:\r\n\r\n- some of the more baroque forms of sugar for `if`\r\n- binary module bodies\r\n- anything script related (assertions, invokes, etc)\r\n- (we had discussed removing the optional module name as well, but in the light of design PR #1055, we probably want to keep it?)\r\n\r\nAdditions:\r\n\r\n- \\u{...} escapes in strings (see below)\r\n- more than just one inline export (that is, you can write (func $f (export \"f1\") (export \"f2\") ...), closing a gap in the syntax)\r\n- the toplevel (module ...) is optional\r\n\r\nChanges:\r\n\r\nI took the liberty to propose one breaking change to make the syntax forward compatible with some of the future extensions that have been discussed:\r\n\r\n- non-empty block signatures must now be written (result i32), in order to generalise cleanly to function signatures\r\n\r\nUnicode:\r\n\r\n- the lexical syntax is defined in terms of Unicode characters (i.e., code points)\r\n- comments and strings may contain mostly arbitrary Unicode, the rest stays within ASCII\r\n- in strings, a Unicode character denotes its UTF-8 encoding\r\n- in strings, Unicode characters can be given explicitly with \\u{...} notation\r\n- .wat files are assumed to be encoded in UTF-8\r\n\r\nThe PR includes changes to the interpreter implementing the Unicode support (but not yet the other changes).\r\n\r\nMisc Remarks:\r\n\r\n- formatting characters: currently only the minimum set of formatting characters are allowed as white space (\\t, \\n, \\r); we could include more, e.g. the whole set of ASCII \"format effectors\" (\\b, \\v, \\f), but you quickly get into a lot of Unicode complexity if you want to go further than that\r\n\r\n- Unicode in comments: similarly, in order to avoid getting into Unicode specifics, any legal code point is currently allowed in comments; should we be more restrictive?\r\n\r\n- binary module bodies: they would seem pretty unusual for a \"text\" format, so are not included. Is there a reason to keep them?\r\n\r\n- abbreviations: to avoid combinatorial complexity in defining the AST to map on, most syntactic sugar is specified in the form of \"abbreviations\", simple rewritings into the core syntax\r\n\r\n- inline function signatures: I tried to come up with a decent way to describe their rewriting into type indices (and the potential insertion of new type definitions) in terms of rules, but ultimately gave up; it's too cumbersome to express succinctly; so this is the one part that is left partially informal (though hopefully still unambiguous)\r\n\r\n- formatting: many of the rules do not currently fit the page width; I left them as is for now, and plan to clean up layout issues once the spec is complete, probably tweaking some layout parameters as well\r\n\r\n- PDF: currently doesn't build; due to various limitations of MathJax (such as the inability to use packages) I had to resort to some hacks for special characters that apparently don't work in proper LaTeX; will fix later\r\n\r\n- tests: lots of stuff we could write tests for, e.g. regarding the Unicode support...\r\n","created_at":"2017-05-11T16:27:07Z","updated_at":"2017-05-12T06:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41bb65b4517de9d2925c8f2599dd9fb01558998e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebAssembly/spec/pulls/471/commits","review_comments_url":"https://api.github.com/repos/WebAssembly/spec/pulls/471/comments","review_comment_url":"https://api.github.com/repos/WebAssembly/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAssembly/spec/issues/471/comments","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/a90213076341c666dcd989d556ed25bef9940b5c","head":{"label":"WebAssembly:spec.textual","ref":"spec.textual","sha":"a90213076341c666dcd989d556ed25bef9940b5c","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars3.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":40598815,"name":"spec","full_name":"WebAssembly/spec","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars3.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/spec","description":"Staging ground for artifacts related to an MVP spec","fork":false,"url":"https://api.github.com/repos/WebAssembly/spec","forks_url":"https://api.github.com/repos/WebAssembly/spec/forks","keys_url":"https://api.github.com/repos/WebAssembly/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/spec/teams","hooks_url":"https://api.github.com/repos/WebAssembly/spec/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/spec/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/spec/events","assignees_url":"https://api.github.com/repos/WebAssembly/spec/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/spec/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/spec/tags","blobs_url":"https://api.github.com/repos/WebAssembly/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/spec/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/spec/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/spec/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/spec/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/spec/subscription","commits_url":"https://api.github.com/repos/WebAssembly/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/spec/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/spec/merges","archive_url":"https://api.github.com/repos/WebAssembly/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/spec/downloads","issues_url":"https://api.github.com/repos/WebAssembly/spec/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/spec/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/spec/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/spec/deployments","created_at":"2015-08-12T12:15:16Z","updated_at":"2017-05-08T07:02:33Z","pushed_at":"2017-05-12T06:42:56Z","git_url":"git://github.com/WebAssembly/spec.git","ssh_url":"git@github.com:WebAssembly/spec.git","clone_url":"https://github.com/WebAssembly/spec.git","svn_url":"https://github.com/WebAssembly/spec","homepage":"http://webassembly.github.io/","size":12540,"stargazers_count":864,"watchers_count":864,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":94,"mirror_url":null,"open_issues_count":17,"forks":94,"open_issues":17,"watchers":864,"default_branch":"master"}},"base":{"label":"WebAssembly:spec.exec.1","ref":"spec.exec.1","sha":"8576afb3b1a96b82933538f0a9544e67c77dee42","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars3.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":40598815,"name":"spec","full_name":"WebAssembly/spec","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars3.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/spec","description":"Staging ground for artifacts related to an MVP spec","fork":false,"url":"https://api.github.com/repos/WebAssembly/spec","forks_url":"https://api.github.com/repos/WebAssembly/spec/forks","keys_url":"https://api.github.com/repos/WebAssembly/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/spec/teams","hooks_url":"https://api.github.com/repos/WebAssembly/spec/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/spec/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/spec/events","assignees_url":"https://api.github.com/repos/WebAssembly/spec/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/spec/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/spec/tags","blobs_url":"https://api.github.com/repos/WebAssembly/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/spec/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/spec/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/spec/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/spec/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/spec/subscription","commits_url":"https://api.github.com/repos/WebAssembly/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/spec/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/spec/merges","archive_url":"https://api.github.com/repos/WebAssembly/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/spec/downloads","issues_url":"https://api.github.com/repos/WebAssembly/spec/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/spec/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/spec/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/spec/deployments","created_at":"2015-08-12T12:15:16Z","updated_at":"2017-05-08T07:02:33Z","pushed_at":"2017-05-12T06:42:56Z","git_url":"git://github.com/WebAssembly/spec.git","ssh_url":"git@github.com:WebAssembly/spec.git","clone_url":"https://github.com/WebAssembly/spec.git","svn_url":"https://github.com/WebAssembly/spec","homepage":"http://webassembly.github.io/","size":12540,"stargazers_count":864,"watchers_count":864,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":94,"mirror_url":null,"open_issues_count":17,"forks":94,"open_issues":17,"watchers":864,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/471"},"html":{"href":"https://github.com/WebAssembly/spec/pull/471"},"issue":{"href":"https://api.github.com/repos/WebAssembly/spec/issues/471"},"comments":{"href":"https://api.github.com/repos/WebAssembly/spec/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/WebAssembly/spec/statuses/a90213076341c666dcd989d556ed25bef9940b5c"}}}}
{"actor":{"display_login":"rossberg-chromium"}}