{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/25016","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/25016/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/25016/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/25016/events","html_url":"https://github.com/tgstation/tgstation/pull/25016","id":213579325,"number":25016,"title":"The Identity System w/ tweaks","user":{"login":"JJRcop","id":5211576,"avatar_url":"https://avatars1.githubusercontent.com/u/5211576?v=3","gravatar_id":"","url":"https://api.github.com/users/JJRcop","html_url":"https://github.com/JJRcop","followers_url":"https://api.github.com/users/JJRcop/followers","following_url":"https://api.github.com/users/JJRcop/following{/other_user}","gists_url":"https://api.github.com/users/JJRcop/gists{/gist_id}","starred_url":"https://api.github.com/users/JJRcop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JJRcop/subscriptions","organizations_url":"https://api.github.com/users/JJRcop/orgs","repos_url":"https://api.github.com/users/JJRcop/repos","events_url":"https://api.github.com/users/JJRcop/events{/privacy}","received_events_url":"https://api.github.com/users/JJRcop/received_events","type":"User","site_admin":false},"labels":[{"id":149581322,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Feature","name":"Feature","color":"009800","default":false},{"id":181676257,"url":"https://api.github.com/repos/tgstation/tgstation/labels/FUCK","name":"FUCK","color":"000000","default":false},{"id":260619936,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Ready%20for%20Review","name":"Ready for Review","color":"ffdfa2","default":false},{"id":255847001,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Work%20In%20Progress","name":"Work In Progress","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2017-03-12T03:48:23Z","updated_at":"2017-03-21T09:52:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/25016","html_url":"https://github.com/tgstation/tgstation/pull/25016","diff_url":"https://github.com/tgstation/tgstation/pull/25016.diff","patch_url":"https://github.com/tgstation/tgstation/pull/25016.patch"},"body":"Previous PR: #23693\r\n\r\nPlease put feedback on the concept of the system in [this forum thread](https://tgstation13.org/phpBB/viewtopic.php?f=9&t=9598), and keep this github page for code discussion only.\r\n\r\n\r\n:cl:\r\nadd: Adds the identity system, which changes the way you see names.\r\nadd: Instead of instantly knowing everyone's name, you have to learn their names. This can be done by examining them, or manually setting their name with the new identity manager. <b><a href='https://tgstation13.org/wiki/Identity'>More info here.</a></b>\r\n/:cl:\r\n\r\nYou no longer see everyone's names instantly when they speak, what you see is dependent of how you remember their name.\r\nI recommend you read the [ugly wiki article](https://tgstation13.org/wiki/User:JJRcop/Identity) I wrote as that is more comprehensive (Hopefully it will be rewritten by someone who knows what they are doing :))\r\n\r\nI may need to get a temporary freeze worked out a'la #20793 during the retrofitting process. No really.\r\n\r\n- [X] Complete code for identity system (subject to change from feedback)\r\n- [X] Code approved\r\n  - [x] examine needs to be better\r\n  - [x] click on names in chat to rename them, don't use the identity manager for this, but keep it around still\r\n  - [x] make the names in chat not blue all the time so that accents are visible\r\n  - [x] list lengths should be defines\r\n  - [x] move global regex vars to be static vars in the procs\r\n  - [x] raz doesn't like var/_these_vars\r\n  ~limited range for faceprint gathering?~\r\n  - [x] config file for pre-knowns\r\n  - [x] add accents\r\n  ~some form of help~\r\n  - [x] potential garbage issues for identity manager\r\n- [X] Retrofitting for logging\r\n- [x] Retrofitting for visible_message, show_message, audible_message\r\n- [x] Retrofitting for to_chat\r\n- [x] fix \"subjextsd=list\" aka various misspellings of \"subjects\"\r\n- [x] identity list garbage collection"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/288028014","html_url":"https://github.com/tgstation/tgstation/pull/25016#issuecomment-288028014","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/25016","id":288028014,"user":{"login":"optimumtact","id":2544323,"avatar_url":"https://avatars1.githubusercontent.com/u/2544323?v=3","gravatar_id":"","url":"https://api.github.com/users/optimumtact","html_url":"https://github.com/optimumtact","followers_url":"https://api.github.com/users/optimumtact/followers","following_url":"https://api.github.com/users/optimumtact/following{/other_user}","gists_url":"https://api.github.com/users/optimumtact/gists{/gist_id}","starred_url":"https://api.github.com/users/optimumtact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimumtact/subscriptions","organizations_url":"https://api.github.com/users/optimumtact/orgs","repos_url":"https://api.github.com/users/optimumtact/repos","events_url":"https://api.github.com/users/optimumtact/events{/privacy}","received_events_url":"https://api.github.com/users/optimumtact/received_events","type":"User","site_admin":false},"created_at":"2017-03-21T09:52:54Z","updated_at":"2017-03-21T09:52:54Z","body":"@PKPenguin321 can you follow up with the host and other headmins on that or should I?\r\n\r\nI'm happy for headmins to weigh in on code but I'd rather they all got involved than just one person respresenting their opinion as being final, especially when you're elected as a triumvirate."}}
{"actor":{"display_login":"optimumtact"}}