{"action":"created","issue":{"url":"https://api.github.com/repos/nusmodifications/nusmods/issues/554","repository_url":"https://api.github.com/repos/nusmodifications/nusmods","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/554/labels{/name}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/554/comments","events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/554/events","html_url":"https://github.com/nusmodifications/nusmods/pull/554","id":284345396,"number":554,"title":"Include module table in timetable image export","user":{"login":"yangshun","id":1315101,"avatar_url":"https://avatars3.githubusercontent.com/u/1315101?v=4","gravatar_id":"","url":"https://api.github.com/users/yangshun","html_url":"https://github.com/yangshun","followers_url":"https://api.github.com/users/yangshun/followers","following_url":"https://api.github.com/users/yangshun/following{/other_user}","gists_url":"https://api.github.com/users/yangshun/gists{/gist_id}","starred_url":"https://api.github.com/users/yangshun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangshun/subscriptions","organizations_url":"https://api.github.com/users/yangshun/orgs","repos_url":"https://api.github.com/users/yangshun/repos","events_url":"https://api.github.com/users/yangshun/events{/privacy}","received_events_url":"https://api.github.com/users/yangshun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-24T06:18:17Z","updated_at":"2017-12-24T09:23:31Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/554","html_url":"https://github.com/nusmodifications/nusmods/pull/554","diff_url":"https://github.com/nusmodifications/nusmods/pull/554.diff","patch_url":"https://github.com/nusmodifications/nusmods/pull/554.patch"},"body":"I think people would complain if the timetable image export didn't include the exam timetable, which students were used to having, so I'm including it here. There are some hacks used:\r\n\r\n1. I have to use `document.getElementById` instead of using `ref`. Somehow it crashes when I shift the `ref` higher up. I think the current approach is still feasible.\r\n2. The stuff to be excluded will be temporarily (< 1s) hidden from view while `domtoimage` converts the DOM to an image. It's ugly but it's a reasonable trade-off IMO. Try it out in the Netlify preview and see for yourself.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments/353774500","html_url":"https://github.com/nusmodifications/nusmods/pull/554#issuecomment-353774500","issue_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/554","id":353774500,"user":{"login":"taneliang","id":12784593,"avatar_url":"https://avatars2.githubusercontent.com/u/12784593?v=4","gravatar_id":"","url":"https://api.github.com/users/taneliang","html_url":"https://github.com/taneliang","followers_url":"https://api.github.com/users/taneliang/followers","following_url":"https://api.github.com/users/taneliang/following{/other_user}","gists_url":"https://api.github.com/users/taneliang/gists{/gist_id}","starred_url":"https://api.github.com/users/taneliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taneliang/subscriptions","organizations_url":"https://api.github.com/users/taneliang/orgs","repos_url":"https://api.github.com/users/taneliang/repos","events_url":"https://api.github.com/users/taneliang/events{/privacy}","received_events_url":"https://api.github.com/users/taneliang/received_events","type":"User","site_admin":false},"created_at":"2017-12-24T09:23:31Z","updated_at":"2017-12-24T09:23:31Z","author_association":"CONTRIBUTOR","body":"This breaks timetable export on mobile (at least on Chrome on Android) though; only the visible part of the timetable gets captured, along with a scrollbar."}}
{"actor":{"display_login":"taneliang"}}