{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/150721904","pull_request_review_id":76313308,"id":150721904,"diff_hunk":"@@ -28,14 +28,12 @@ export class LiveAnnouncer implements OnDestroy {\n \n   constructor(\n       @Optional() @Inject(LIVE_ANNOUNCER_ELEMENT_TOKEN) elementToken: any,\n-      platform: Platform) {\n-    // Only do anything if we're on the browser platform.\n-    if (platform.isBrowser) {\n-      // We inject the live element as `any` because the constructor signature cannot reference\n-      // browser globals (HTMLElement) on non-browser environments, since having a class decorator\n-      // causes TypeScript to preserve the constructor signature types.\n-      this._liveElement = elementToken || this._createLiveElement();\n-    }\n+      @Inject(DOCUMENT) private _document: any) {","path":"src/cdk/a11y/live-announcer.ts","position":21,"original_position":21,"commit_id":"c24e05d5fa26a2e554285325a92914db6a195d08","original_commit_id":"c24e05d5fa26a2e554285325a92914db6a195d08","user":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"body":"I think you can do:\r\n```ts\r\n@Inject(DOCUMENT) private _document: Document|Document\r\n```\r\nIt shouldn't preserve the type info for \"computed\" types; I think this will trick it will still giving type safety","created_at":"2017-11-14T02:20:41Z","updated_at":"2017-11-14T02:23:11Z","html_url":"https://github.com/angular/material2/pull/8422#discussion_r150721904","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/8422","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/150721904"},"html":{"href":"https://github.com/angular/material2/pull/8422#discussion_r150721904"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/8422"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/8422","id":152327141,"html_url":"https://github.com/angular/material2/pull/8422","diff_url":"https://github.com/angular/material2/pull/8422.diff","patch_url":"https://github.com/angular/material2/pull/8422.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/8422","number":8422,"state":"open","locked":false,"title":"fix(overlay): better handling of server-side rendering","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"body":"Fixes multiple server-side rendering issues in the overlay that were causing errors when an overlay is opened in Universal.\r\n\r\nFixes #8412.","created_at":"2017-11-13T19:34:46Z","updated_at":"2017-11-14T02:23:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b352855de66de170bbf4d7c6664ef3787350bcf5","assignee":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/8422/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/8422/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/8422/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/c24e05d5fa26a2e554285325a92914db6a195d08","head":{"label":"crisbeto:8412/overlay-ssr","ref":"8412/overlay-ssr","sha":"c24e05d5fa26a2e554285325a92914db6a195d08","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"repo":{"id":60285287,"name":"material2","full_name":"crisbeto/material2","owner":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crisbeto/material2","description":"Material Design components for Angular 2","fork":true,"url":"https://api.github.com/repos/crisbeto/material2","forks_url":"https://api.github.com/repos/crisbeto/material2/forks","keys_url":"https://api.github.com/repos/crisbeto/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crisbeto/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crisbeto/material2/teams","hooks_url":"https://api.github.com/repos/crisbeto/material2/hooks","issue_events_url":"https://api.github.com/repos/crisbeto/material2/issues/events{/number}","events_url":"https://api.github.com/repos/crisbeto/material2/events","assignees_url":"https://api.github.com/repos/crisbeto/material2/assignees{/user}","branches_url":"https://api.github.com/repos/crisbeto/material2/branches{/branch}","tags_url":"https://api.github.com/repos/crisbeto/material2/tags","blobs_url":"https://api.github.com/repos/crisbeto/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crisbeto/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crisbeto/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/crisbeto/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crisbeto/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/crisbeto/material2/languages","stargazers_url":"https://api.github.com/repos/crisbeto/material2/stargazers","contributors_url":"https://api.github.com/repos/crisbeto/material2/contributors","subscribers_url":"https://api.github.com/repos/crisbeto/material2/subscribers","subscription_url":"https://api.github.com/repos/crisbeto/material2/subscription","commits_url":"https://api.github.com/repos/crisbeto/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/crisbeto/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/crisbeto/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/crisbeto/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/crisbeto/material2/contents/{+path}","compare_url":"https://api.github.com/repos/crisbeto/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crisbeto/material2/merges","archive_url":"https://api.github.com/repos/crisbeto/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crisbeto/material2/downloads","issues_url":"https://api.github.com/repos/crisbeto/material2/issues{/number}","pulls_url":"https://api.github.com/repos/crisbeto/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/crisbeto/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/crisbeto/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crisbeto/material2/labels{/name}","releases_url":"https://api.github.com/repos/crisbeto/material2/releases{/id}","deployments_url":"https://api.github.com/repos/crisbeto/material2/deployments","created_at":"2016-06-02T17:50:34Z","updated_at":"2017-09-20T05:06:25Z","pushed_at":"2017-11-13T22:06:35Z","git_url":"git://github.com/crisbeto/material2.git","ssh_url":"git@github.com:crisbeto/material2.git","clone_url":"https://github.com/crisbeto/material2.git","svn_url":"https://github.com/crisbeto/material2","homepage":"https://material.angular.io/","size":11224,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"8dfe470c3013c8d76cd7e65b95814401a9ed29a5","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2017-11-14T01:27:44Z","pushed_at":"2017-11-14T01:55:32Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io","size":10323,"stargazers_count":11819,"watchers_count":11819,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2808,"mirror_url":null,"archived":false,"open_issues_count":907,"forks":2808,"open_issues":907,"watchers":11819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/8422"},"html":{"href":"https://github.com/angular/material2/pull/8422"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/8422"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/8422/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/8422/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/8422/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/c24e05d5fa26a2e554285325a92914db6a195d08"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jelbourn"}}