{"action":"created","issue":{"url":"https://api.github.com/repos/typesafehub/sbteclipse/issues/352","repository_url":"https://api.github.com/repos/typesafehub/sbteclipse","labels_url":"https://api.github.com/repos/typesafehub/sbteclipse/issues/352/labels{/name}","comments_url":"https://api.github.com/repos/typesafehub/sbteclipse/issues/352/comments","events_url":"https://api.github.com/repos/typesafehub/sbteclipse/issues/352/events","html_url":"https://github.com/typesafehub/sbteclipse/issues/352","id":268501613,"number":352,"title":"feature request: need a way to specify an alternative default build files directory","user":{"login":"philwalk","id":3171734,"avatar_url":"https://avatars3.githubusercontent.com/u/3171734?v=4","gravatar_id":"","url":"https://api.github.com/users/philwalk","html_url":"https://github.com/philwalk","followers_url":"https://api.github.com/users/philwalk/followers","following_url":"https://api.github.com/users/philwalk/following{/other_user}","gists_url":"https://api.github.com/users/philwalk/gists{/gist_id}","starred_url":"https://api.github.com/users/philwalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwalk/subscriptions","organizations_url":"https://api.github.com/users/philwalk/orgs","repos_url":"https://api.github.com/users/philwalk/repos","events_url":"https://api.github.com/users/philwalk/events{/privacy}","received_events_url":"https://api.github.com/users/philwalk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-25T18:29:43Z","updated_at":"2017-10-31T14:47:16Z","closed_at":null,"author_association":"NONE","body":"Many projects include a 'bin' directory, typically containing shell scripts related to the project.  Unfortunately, the default value for the build output files directory is also 'bin', with the result that after issuing \"sbt eclipse\", the next subsequent \"clean\" from within the Eclipse Run menu will delete this directory, including potentially edited but not-yet-checked-in changes. \r\n\r\nSome projects have started including a warning in user documentation (see for example [http://dotty.epfl.ch/docs/contributing/eclipse.html](http://dotty.epfl.ch/docs/contributing/eclipse.html).\r\n\r\nTwo suggestions, either of which would reduce this risk:\r\n\r\n1. change the default directory from \"bin\" to \"classes\" (or \"build\"?)\r\n2. allow the default directory to be managed with an environment variable, or other project-specific configuration\r\n\r\nThere appear to be exactly four references to the string literal \"bin\" in the project:\r\n\r\n```\r\nsrc/main/scala-sbt-0.13/com/typesafe/sbteclipse/core/Eclipse.scala:  (Seq(\"bin\") map EclipseClasspathEntry.Output)\r\nsrc/main/scala-sbt-1.0/com/typesafe/sbteclipse/core/Eclipse.scala:   (Seq(\"bin\") map EclipseClasspathEntry.Output)\r\nsrc/sbt-test/sbteclipse/02-contents/tasks.sbt:                       if (!(classpath.child contains <classpathentry kind=\"output\" path=\"bin\"/>))\r\nsrc/sbt-test/sbteclipse/02-contents/tasks.sbt:                       error(\"\"\"Expected .classpath of root project to contain <classpathentry kind=\"output\" path=\"bin\"/> \"\"\")\r\n```\r\n\r\nThanks for considering this. I would be happy to do a pull request and provide a proposed fix for your review. "},"comment":{"url":"https://api.github.com/repos/typesafehub/sbteclipse/issues/comments/340785512","html_url":"https://github.com/typesafehub/sbteclipse/issues/352#issuecomment-340785512","issue_url":"https://api.github.com/repos/typesafehub/sbteclipse/issues/352","id":340785512,"user":{"login":"philwalk","id":3171734,"avatar_url":"https://avatars3.githubusercontent.com/u/3171734?v=4","gravatar_id":"","url":"https://api.github.com/users/philwalk","html_url":"https://github.com/philwalk","followers_url":"https://api.github.com/users/philwalk/followers","following_url":"https://api.github.com/users/philwalk/following{/other_user}","gists_url":"https://api.github.com/users/philwalk/gists{/gist_id}","starred_url":"https://api.github.com/users/philwalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwalk/subscriptions","organizations_url":"https://api.github.com/users/philwalk/orgs","repos_url":"https://api.github.com/users/philwalk/repos","events_url":"https://api.github.com/users/philwalk/events{/privacy}","received_events_url":"https://api.github.com/users/philwalk/received_events","type":"User","site_admin":false},"created_at":"2017-10-31T14:47:16Z","updated_at":"2017-10-31T14:47:16Z","author_association":"NONE","body":"I would prefer that dotty not change the name of their scripts directory,\nas it follows a decades old standard and many developers are familiar with\nit.  Below my eclipse workspace, there are 82 .git directories and 121\n'bin' directories.   This is the only project I'm familiar with that uses\n'bin' as the binary output directory.  Much more common would be 'classes',\n'build', or 'target'.  If it weren't already legacy behavior, I would favor\nchanging the sbteclipse default.\n\nOn Mon, Oct 30, 2017 at 2:02 PM, Ben McCann <notifications@github.com>\nwrote:\n\n> dotty is open to changing the name of their scripts directory in case you\n> want to submit a PR there lampepfl/dotty#3401\n> <https://github.com/lampepfl/dotty/issues/3401>. We should still fix this\n> issue because the eclipseOutput setting should be made to work, but I\n> think that it'd also be nice if they didn't use the bin directory so that\n> you didn't need to change the default settings\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/typesafehub/sbteclipse/issues/352#issuecomment-340566760>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ADBlluCMOBVGcsAhqK_GokV1s2zuBl4Aks5sxis6gaJpZM4QGdBh>\n> .\n>\n"}}
{"actor":{"display_login":"philwalk"}}