{"action":"reopened","number":2456,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/2456","id":128330794,"html_url":"https://github.com/apache/zeppelin/pull/2456","diff_url":"https://github.com/apache/zeppelin/pull/2456.diff","patch_url":"https://github.com/apache/zeppelin/pull/2456.patch","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/2456","number":2456,"state":"open","locked":false,"title":"[ZEPPELIN-2714] Soft-code Spark UI button visualization","user":{"login":"necosta","id":26248959,"avatar_url":"https://avatars2.githubusercontent.com/u/26248959?v=3","gravatar_id":"","url":"https://api.github.com/users/necosta","html_url":"https://github.com/necosta","followers_url":"https://api.github.com/users/necosta/followers","following_url":"https://api.github.com/users/necosta/following{/other_user}","gists_url":"https://api.github.com/users/necosta/gists{/gist_id}","starred_url":"https://api.github.com/users/necosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/necosta/subscriptions","organizations_url":"https://api.github.com/users/necosta/orgs","repos_url":"https://api.github.com/users/necosta/repos","events_url":"https://api.github.com/users/necosta/events{/privacy}","received_events_url":"https://api.github.com/users/necosta/received_events","type":"User","site_admin":false},"body":"### What is this PR for?\r\nWhen \"spark.ui.enabled\" property is set to \"false\" we should not show the Spark UI button.\r\nWe keep the same behaviour when this property does not exist or when it exists and it's set to true.\r\n\r\n### What type of PR is it?\r\n[ Improvement]\r\n\r\n### What is the Jira issue?\r\n* https://issues.apache.org/jira/browse/ZEPPELIN-2714\r\n\r\n### How should this be tested?\r\n1. Open Zeppelin, go to Interpreter > Spark\r\n1. Click spark ui > msg: \"No spark application running\"\r\n1. Go to a paragraph, run \"sc.parallelize(1 to 100).count()\", check \"SPARK JOB\" button\r\n1. Go to Interpreter > Spark > Set \"spark.ui.enabled\" to \"false\"\r\n1. Rerun paragraph > \"SPARK JOB\" button not visible\r\n1. Go to Interpreter > Spark > \"spark ui\" button not visible\r\nAlso, test with \"spark.ui.enabled\"=\"true\" and other workflow combinations\r\n\r\n### Questions:\r\n* Does the licenses files need update? N\r\n* Is there breaking changes for older versions? N\r\n* Does this needs documentation? N\r\n","created_at":"2017-06-30T09:32:55Z","updated_at":"2017-07-06T15:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40b250e27751aad2612c8c1029cb771784ce7b17","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zeppelin/pulls/2456/commits","review_comments_url":"https://api.github.com/repos/apache/zeppelin/pulls/2456/comments","review_comment_url":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/2456/comments","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/278a23ee31cd7cc90a587124ca15c53e62af8e45","head":{"label":"nokia:zeppelin2714","ref":"zeppelin2714","sha":"278a23ee31cd7cc90a587124ca15c53e62af8e45","user":{"login":"nokia","id":341053,"avatar_url":"https://avatars2.githubusercontent.com/u/341053?v=3","gravatar_id":"","url":"https://api.github.com/users/nokia","html_url":"https://github.com/nokia","followers_url":"https://api.github.com/users/nokia/followers","following_url":"https://api.github.com/users/nokia/following{/other_user}","gists_url":"https://api.github.com/users/nokia/gists{/gist_id}","starred_url":"https://api.github.com/users/nokia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nokia/subscriptions","organizations_url":"https://api.github.com/users/nokia/orgs","repos_url":"https://api.github.com/users/nokia/repos","events_url":"https://api.github.com/users/nokia/events{/privacy}","received_events_url":"https://api.github.com/users/nokia/received_events","type":"Organization","site_admin":false},"repo":{"id":85287151,"name":"zeppelin","full_name":"nokia/zeppelin","owner":{"login":"nokia","id":341053,"avatar_url":"https://avatars2.githubusercontent.com/u/341053?v=3","gravatar_id":"","url":"https://api.github.com/users/nokia","html_url":"https://github.com/nokia","followers_url":"https://api.github.com/users/nokia/followers","following_url":"https://api.github.com/users/nokia/following{/other_user}","gists_url":"https://api.github.com/users/nokia/gists{/gist_id}","starred_url":"https://api.github.com/users/nokia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nokia/subscriptions","organizations_url":"https://api.github.com/users/nokia/orgs","repos_url":"https://api.github.com/users/nokia/repos","events_url":"https://api.github.com/users/nokia/events{/privacy}","received_events_url":"https://api.github.com/users/nokia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nokia/zeppelin","description":"Mirror of Apache Zeppelin","fork":true,"url":"https://api.github.com/repos/nokia/zeppelin","forks_url":"https://api.github.com/repos/nokia/zeppelin/forks","keys_url":"https://api.github.com/repos/nokia/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nokia/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nokia/zeppelin/teams","hooks_url":"https://api.github.com/repos/nokia/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/nokia/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/nokia/zeppelin/events","assignees_url":"https://api.github.com/repos/nokia/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/nokia/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/nokia/zeppelin/tags","blobs_url":"https://api.github.com/repos/nokia/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nokia/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nokia/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nokia/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nokia/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/nokia/zeppelin/languages","stargazers_url":"https://api.github.com/repos/nokia/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/nokia/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/nokia/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/nokia/zeppelin/subscription","commits_url":"https://api.github.com/repos/nokia/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nokia/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nokia/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nokia/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nokia/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/nokia/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nokia/zeppelin/merges","archive_url":"https://api.github.com/repos/nokia/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nokia/zeppelin/downloads","issues_url":"https://api.github.com/repos/nokia/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/nokia/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/nokia/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/nokia/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nokia/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/nokia/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/nokia/zeppelin/deployments","created_at":"2017-03-17T08:14:31Z","updated_at":"2017-03-17T08:14:35Z","pushed_at":"2017-07-06T14:07:34Z","git_url":"git://github.com/nokia/zeppelin.git","ssh_url":"git@github.com:nokia/zeppelin.git","clone_url":"https://github.com/nokia/zeppelin.git","svn_url":"https://github.com/nokia/zeppelin","homepage":"","size":58336,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"155a55b5609b9cdab9369b35b97218623dc1de8e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32848140,"name":"zeppelin","full_name":"apache/zeppelin","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/zeppelin","description":"Mirror of Apache Zeppelin","fork":false,"url":"https://api.github.com/repos/apache/zeppelin","forks_url":"https://api.github.com/repos/apache/zeppelin/forks","keys_url":"https://api.github.com/repos/apache/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zeppelin/teams","hooks_url":"https://api.github.com/repos/apache/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/apache/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zeppelin/events","assignees_url":"https://api.github.com/repos/apache/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zeppelin/tags","blobs_url":"https://api.github.com/repos/apache/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zeppelin/languages","stargazers_url":"https://api.github.com/repos/apache/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/apache/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/apache/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/apache/zeppelin/subscription","commits_url":"https://api.github.com/repos/apache/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zeppelin/merges","archive_url":"https://api.github.com/repos/apache/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zeppelin/downloads","issues_url":"https://api.github.com/repos/apache/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/apache/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zeppelin/deployments","created_at":"2015-03-25T07:00:06Z","updated_at":"2017-07-06T07:45:36Z","pushed_at":"2017-07-06T14:07:37Z","git_url":"git://github.com/apache/zeppelin.git","ssh_url":"git@github.com:apache/zeppelin.git","clone_url":"https://github.com/apache/zeppelin.git","svn_url":"https://github.com/apache/zeppelin","homepage":"","size":58739,"stargazers_count":2964,"watchers_count":2964,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1495,"mirror_url":"git://git.apache.org/incubator-zeppelin.git","open_issues_count":141,"forks":1495,"open_issues":141,"watchers":2964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/2456"},"html":{"href":"https://github.com/apache/zeppelin/pull/2456"},"issue":{"href":"https://api.github.com/repos/apache/zeppelin/issues/2456"},"comments":{"href":"https://api.github.com/repos/apache/zeppelin/issues/2456/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/2456/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/2456/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zeppelin/statuses/278a23ee31cd7cc90a587124ca15c53e62af8e45"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":12,"maintainer_can_modify":true,"commits":4,"additions":96,"deletions":39,"changed_files":5}}
{"actor":{"display_login":"necosta"}}