{"action":"created","comment":{"url":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments/139294879","pull_request_review_id":63211321,"id":139294879,"diff_hunk":"@@ -5,7 +5,31 @@ set -xe\n type autoreconf || exit 1\n type pkg-config || exit 1\n \n-ctags_files=`make -f makefiles/list-translator-input.mak --no-print-directory`\n+gen_bsdmakefile() {\n+\tset +xe\n+\techo -e '.DONE:\\n\\t@echo \"Please use GNU Make (gmake) to build this project\"\\n.DEFAULT:\\n\\t@echo \"Please use GNU Make (gmake) to build this project\"' > BSDmakefile","path":"autogen.sh","position":7,"original_position":7,"commit_id":"e49db10b79e2e697c05f1550c96889457a59a67f","original_commit_id":"e49db10b79e2e697c05f1550c96889457a59a67f","user":{"login":"b4n","id":793526,"avatar_url":"https://avatars2.githubusercontent.com/u/793526?v=4","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"body":"Also, would it be handy to forward the call to GNU Make automatically?  If\r\n```makefile\r\n.DONE .DEFAULT:\r\n\t@echo \"Please use GNU Make (gmake) to build this project\"\r\n\tmake $@\r\n```\r\nis enough it seems handy.  OK, maybe it's trickier because we'd like to forward some of the `MAKEFLAGS` but they are not all compatible between GNU and BSD make (e.g. I know NetBSD make adds a `-J` option GNU make doesn't understand to `MAKEFLAGS` when the user uses `-j`).  Just a suggestion in case it wasn't already considered.","created_at":"2017-09-16T20:35:37Z","updated_at":"2017-09-16T20:37:44Z","html_url":"https://github.com/universal-ctags/ctags/pull/1554#discussion_r139294879","pull_request_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments/139294879"},"html":{"href":"https://github.com/universal-ctags/ctags/pull/1554#discussion_r139294879"},"pull_request":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554"}},"in_reply_to_id":139294787},"pull_request":{"url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554","id":141456980,"html_url":"https://github.com/universal-ctags/ctags/pull/1554","diff_url":"https://github.com/universal-ctags/ctags/pull/1554.diff","patch_url":"https://github.com/universal-ctags/ctags/pull/1554.patch","issue_url":"https://api.github.com/repos/universal-ctags/ctags/issues/1554","number":1554,"state":"open","locked":false,"title":"Fixed build script for BSD systems","user":{"login":"mqudsi","id":606923,"avatar_url":"https://avatars3.githubusercontent.com/u/606923?v=4","gravatar_id":"","url":"https://api.github.com/users/mqudsi","html_url":"https://github.com/mqudsi","followers_url":"https://api.github.com/users/mqudsi/followers","following_url":"https://api.github.com/users/mqudsi/following{/other_user}","gists_url":"https://api.github.com/users/mqudsi/gists{/gist_id}","starred_url":"https://api.github.com/users/mqudsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqudsi/subscriptions","organizations_url":"https://api.github.com/users/mqudsi/orgs","repos_url":"https://api.github.com/users/mqudsi/repos","events_url":"https://api.github.com/users/mqudsi/events{/privacy}","received_events_url":"https://api.github.com/users/mqudsi/received_events","type":"User","site_admin":false},"body":"In autogen.sh, don't assume that the correct Makefile interpreter is\r\n`make`. The syntax of the Makefile generated by autotools is not\r\ncompatible with BSD Make, and must be built with GNU Make (gmake)\r\ninstead.\r\n\r\nIn addition to detecting BSD platforms (via uname) and using gmake\r\ninstead of make, autogen.sh also generates a BSDmakefile in the\r\ntop-level directory. In its presence, BSD Make will use it instead of a\r\ngeneric Makefile, and BSD users will be informed that they should use\r\ngmake instead of make to buil the project.\r\n\r\nTested on FreeBSD.","created_at":"2017-09-16T18:30:00Z","updated_at":"2017-09-16T20:37:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"520e1303ffb3eb155ff222afbb7d56f45cdb2645","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554/commits","review_comments_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554/comments","review_comment_url":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments{/number}","comments_url":"https://api.github.com/repos/universal-ctags/ctags/issues/1554/comments","statuses_url":"https://api.github.com/repos/universal-ctags/ctags/statuses/e49db10b79e2e697c05f1550c96889457a59a67f","head":{"label":"mqudsi:bsdbuild","ref":"bsdbuild","sha":"e49db10b79e2e697c05f1550c96889457a59a67f","user":{"login":"mqudsi","id":606923,"avatar_url":"https://avatars3.githubusercontent.com/u/606923?v=4","gravatar_id":"","url":"https://api.github.com/users/mqudsi","html_url":"https://github.com/mqudsi","followers_url":"https://api.github.com/users/mqudsi/followers","following_url":"https://api.github.com/users/mqudsi/following{/other_user}","gists_url":"https://api.github.com/users/mqudsi/gists{/gist_id}","starred_url":"https://api.github.com/users/mqudsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqudsi/subscriptions","organizations_url":"https://api.github.com/users/mqudsi/orgs","repos_url":"https://api.github.com/users/mqudsi/repos","events_url":"https://api.github.com/users/mqudsi/events{/privacy}","received_events_url":"https://api.github.com/users/mqudsi/received_events","type":"User","site_admin":false},"repo":{"id":103773566,"name":"ctags","full_name":"mqudsi/ctags","owner":{"login":"mqudsi","id":606923,"avatar_url":"https://avatars3.githubusercontent.com/u/606923?v=4","gravatar_id":"","url":"https://api.github.com/users/mqudsi","html_url":"https://github.com/mqudsi","followers_url":"https://api.github.com/users/mqudsi/followers","following_url":"https://api.github.com/users/mqudsi/following{/other_user}","gists_url":"https://api.github.com/users/mqudsi/gists{/gist_id}","starred_url":"https://api.github.com/users/mqudsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqudsi/subscriptions","organizations_url":"https://api.github.com/users/mqudsi/orgs","repos_url":"https://api.github.com/users/mqudsi/repos","events_url":"https://api.github.com/users/mqudsi/events{/privacy}","received_events_url":"https://api.github.com/users/mqudsi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mqudsi/ctags","description":"A maintained ctags implementation","fork":true,"url":"https://api.github.com/repos/mqudsi/ctags","forks_url":"https://api.github.com/repos/mqudsi/ctags/forks","keys_url":"https://api.github.com/repos/mqudsi/ctags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mqudsi/ctags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mqudsi/ctags/teams","hooks_url":"https://api.github.com/repos/mqudsi/ctags/hooks","issue_events_url":"https://api.github.com/repos/mqudsi/ctags/issues/events{/number}","events_url":"https://api.github.com/repos/mqudsi/ctags/events","assignees_url":"https://api.github.com/repos/mqudsi/ctags/assignees{/user}","branches_url":"https://api.github.com/repos/mqudsi/ctags/branches{/branch}","tags_url":"https://api.github.com/repos/mqudsi/ctags/tags","blobs_url":"https://api.github.com/repos/mqudsi/ctags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mqudsi/ctags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mqudsi/ctags/git/refs{/sha}","trees_url":"https://api.github.com/repos/mqudsi/ctags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mqudsi/ctags/statuses/{sha}","languages_url":"https://api.github.com/repos/mqudsi/ctags/languages","stargazers_url":"https://api.github.com/repos/mqudsi/ctags/stargazers","contributors_url":"https://api.github.com/repos/mqudsi/ctags/contributors","subscribers_url":"https://api.github.com/repos/mqudsi/ctags/subscribers","subscription_url":"https://api.github.com/repos/mqudsi/ctags/subscription","commits_url":"https://api.github.com/repos/mqudsi/ctags/commits{/sha}","git_commits_url":"https://api.github.com/repos/mqudsi/ctags/git/commits{/sha}","comments_url":"https://api.github.com/repos/mqudsi/ctags/comments{/number}","issue_comment_url":"https://api.github.com/repos/mqudsi/ctags/issues/comments{/number}","contents_url":"https://api.github.com/repos/mqudsi/ctags/contents/{+path}","compare_url":"https://api.github.com/repos/mqudsi/ctags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mqudsi/ctags/merges","archive_url":"https://api.github.com/repos/mqudsi/ctags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mqudsi/ctags/downloads","issues_url":"https://api.github.com/repos/mqudsi/ctags/issues{/number}","pulls_url":"https://api.github.com/repos/mqudsi/ctags/pulls{/number}","milestones_url":"https://api.github.com/repos/mqudsi/ctags/milestones{/number}","notifications_url":"https://api.github.com/repos/mqudsi/ctags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mqudsi/ctags/labels{/name}","releases_url":"https://api.github.com/repos/mqudsi/ctags/releases{/id}","deployments_url":"https://api.github.com/repos/mqudsi/ctags/deployments","created_at":"2017-09-16T18:11:17Z","updated_at":"2017-09-16T18:11:22Z","pushed_at":"2017-09-16T19:52:43Z","git_url":"git://github.com/mqudsi/ctags.git","ssh_url":"git@github.com:mqudsi/ctags.git","clone_url":"https://github.com/mqudsi/ctags.git","svn_url":"https://github.com/mqudsi/ctags","homepage":"https://ctags.io","size":10437,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"universal-ctags:master","ref":"master","sha":"c37967d583ee87dfa0b69b68a2c9a1ef95ea5c67","user":{"login":"universal-ctags","id":9616766,"avatar_url":"https://avatars2.githubusercontent.com/u/9616766?v=4","gravatar_id":"","url":"https://api.github.com/users/universal-ctags","html_url":"https://github.com/universal-ctags","followers_url":"https://api.github.com/users/universal-ctags/followers","following_url":"https://api.github.com/users/universal-ctags/following{/other_user}","gists_url":"https://api.github.com/users/universal-ctags/gists{/gist_id}","starred_url":"https://api.github.com/users/universal-ctags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/universal-ctags/subscriptions","organizations_url":"https://api.github.com/users/universal-ctags/orgs","repos_url":"https://api.github.com/users/universal-ctags/repos","events_url":"https://api.github.com/users/universal-ctags/events{/privacy}","received_events_url":"https://api.github.com/users/universal-ctags/received_events","type":"Organization","site_admin":false},"repo":{"id":578839,"name":"ctags","full_name":"universal-ctags/ctags","owner":{"login":"universal-ctags","id":9616766,"avatar_url":"https://avatars2.githubusercontent.com/u/9616766?v=4","gravatar_id":"","url":"https://api.github.com/users/universal-ctags","html_url":"https://github.com/universal-ctags","followers_url":"https://api.github.com/users/universal-ctags/followers","following_url":"https://api.github.com/users/universal-ctags/following{/other_user}","gists_url":"https://api.github.com/users/universal-ctags/gists{/gist_id}","starred_url":"https://api.github.com/users/universal-ctags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/universal-ctags/subscriptions","organizations_url":"https://api.github.com/users/universal-ctags/orgs","repos_url":"https://api.github.com/users/universal-ctags/repos","events_url":"https://api.github.com/users/universal-ctags/events{/privacy}","received_events_url":"https://api.github.com/users/universal-ctags/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/universal-ctags/ctags","description":"A maintained ctags implementation","fork":false,"url":"https://api.github.com/repos/universal-ctags/ctags","forks_url":"https://api.github.com/repos/universal-ctags/ctags/forks","keys_url":"https://api.github.com/repos/universal-ctags/ctags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/universal-ctags/ctags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/universal-ctags/ctags/teams","hooks_url":"https://api.github.com/repos/universal-ctags/ctags/hooks","issue_events_url":"https://api.github.com/repos/universal-ctags/ctags/issues/events{/number}","events_url":"https://api.github.com/repos/universal-ctags/ctags/events","assignees_url":"https://api.github.com/repos/universal-ctags/ctags/assignees{/user}","branches_url":"https://api.github.com/repos/universal-ctags/ctags/branches{/branch}","tags_url":"https://api.github.com/repos/universal-ctags/ctags/tags","blobs_url":"https://api.github.com/repos/universal-ctags/ctags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/universal-ctags/ctags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/universal-ctags/ctags/git/refs{/sha}","trees_url":"https://api.github.com/repos/universal-ctags/ctags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/universal-ctags/ctags/statuses/{sha}","languages_url":"https://api.github.com/repos/universal-ctags/ctags/languages","stargazers_url":"https://api.github.com/repos/universal-ctags/ctags/stargazers","contributors_url":"https://api.github.com/repos/universal-ctags/ctags/contributors","subscribers_url":"https://api.github.com/repos/universal-ctags/ctags/subscribers","subscription_url":"https://api.github.com/repos/universal-ctags/ctags/subscription","commits_url":"https://api.github.com/repos/universal-ctags/ctags/commits{/sha}","git_commits_url":"https://api.github.com/repos/universal-ctags/ctags/git/commits{/sha}","comments_url":"https://api.github.com/repos/universal-ctags/ctags/comments{/number}","issue_comment_url":"https://api.github.com/repos/universal-ctags/ctags/issues/comments{/number}","contents_url":"https://api.github.com/repos/universal-ctags/ctags/contents/{+path}","compare_url":"https://api.github.com/repos/universal-ctags/ctags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/universal-ctags/ctags/merges","archive_url":"https://api.github.com/repos/universal-ctags/ctags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/universal-ctags/ctags/downloads","issues_url":"https://api.github.com/repos/universal-ctags/ctags/issues{/number}","pulls_url":"https://api.github.com/repos/universal-ctags/ctags/pulls{/number}","milestones_url":"https://api.github.com/repos/universal-ctags/ctags/milestones{/number}","notifications_url":"https://api.github.com/repos/universal-ctags/ctags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/universal-ctags/ctags/labels{/name}","releases_url":"https://api.github.com/repos/universal-ctags/ctags/releases{/id}","deployments_url":"https://api.github.com/repos/universal-ctags/ctags/deployments","created_at":"2010-03-25T10:43:13Z","updated_at":"2017-09-16T13:12:39Z","pushed_at":"2017-09-16T19:52:44Z","git_url":"git://github.com/universal-ctags/ctags.git","ssh_url":"git@github.com:universal-ctags/ctags.git","clone_url":"https://github.com/universal-ctags/ctags.git","svn_url":"https://github.com/universal-ctags/ctags","homepage":"https://ctags.io","size":10435,"stargazers_count":1479,"watchers_count":1479,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":124,"forks":213,"open_issues":124,"watchers":1479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554"},"html":{"href":"https://github.com/universal-ctags/ctags/pull/1554"},"issue":{"href":"https://api.github.com/repos/universal-ctags/ctags/issues/1554"},"comments":{"href":"https://api.github.com/repos/universal-ctags/ctags/issues/1554/comments"},"review_comments":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554/comments"},"review_comment":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/universal-ctags/ctags/pulls/1554/commits"},"statuses":{"href":"https://api.github.com/repos/universal-ctags/ctags/statuses/e49db10b79e2e697c05f1550c96889457a59a67f"}},"author_association":"NONE"}}
{"actor":{"display_login":"b4n"}}