{"action":"created","issue":{"url":"https://api.github.com/repos/cakephp/authentication/issues/155","repository_url":"https://api.github.com/repos/cakephp/authentication","labels_url":"https://api.github.com/repos/cakephp/authentication/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/cakephp/authentication/issues/155/comments","events_url":"https://api.github.com/repos/cakephp/authentication/issues/155/events","html_url":"https://github.com/cakephp/authentication/issues/155","id":280842865,"number":155,"title":"Feedback: Status Codes","user":{"login":"inoas","id":20972207,"avatar_url":"https://avatars0.githubusercontent.com/u/20972207?v=4","gravatar_id":"","url":"https://api.github.com/users/inoas","html_url":"https://github.com/inoas","followers_url":"https://api.github.com/users/inoas/followers","following_url":"https://api.github.com/users/inoas/following{/other_user}","gists_url":"https://api.github.com/users/inoas/gists{/gist_id}","starred_url":"https://api.github.com/users/inoas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoas/subscriptions","organizations_url":"https://api.github.com/users/inoas/orgs","repos_url":"https://api.github.com/users/inoas/repos","events_url":"https://api.github.com/users/inoas/events{/privacy}","received_events_url":"https://api.github.com/users/inoas/received_events","type":"User","site_admin":false},"labels":[{"id":490638364,"url":"https://api.github.com/repos/cakephp/authentication/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":498862700,"url":"https://api.github.com/repos/cakephp/authentication/labels/RFC","name":"RFC","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-12-10T20:40:40Z","updated_at":"2017-12-12T12:03:03Z","closed_at":null,"author_association":"NONE","body":"About the Status Codes:\r\n\r\n```\r\n    1: Success (Result::SUCCESS)\r\n    0: Failure (Result::FAILURE)\r\n    -1: Identify not found (Result::FAILURE_IDENTITY_NOT_FOUND)\r\n    -2: Credentials invalid (Result::FAILURE_CREDENTIAL_INVALID)\r\n    -3: Any other kind of failure (Result::FAILURE_OTHER)\r\n    -4: Credentials not found (Result::FAILURE_CREDENTIALS_NOT_FOUND)\r\n```\r\n\r\nThe numbers are weird ...\r\n- There are no holes to add more inbetween or have them grouped\r\n- Working with negative status codes makes stuff harder to work with as you cannot easily use strpos\r\n- They do not follow posix-style or http-style (why not one of them?)\r\n- They are ordered strange... identity not found > credentials not found > credentials invalid > any other failure or so would make more sense.\r\n- This shows PHP misses atoms :(."},"comment":{"url":"https://api.github.com/repos/cakephp/authentication/issues/comments/351031991","html_url":"https://github.com/cakephp/authentication/issues/155#issuecomment-351031991","issue_url":"https://api.github.com/repos/cakephp/authentication/issues/155","id":351031991,"user":{"login":"dereuromark","id":39854,"avatar_url":"https://avatars0.githubusercontent.com/u/39854?v=4","gravatar_id":"","url":"https://api.github.com/users/dereuromark","html_url":"https://github.com/dereuromark","followers_url":"https://api.github.com/users/dereuromark/followers","following_url":"https://api.github.com/users/dereuromark/following{/other_user}","gists_url":"https://api.github.com/users/dereuromark/gists{/gist_id}","starred_url":"https://api.github.com/users/dereuromark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereuromark/subscriptions","organizations_url":"https://api.github.com/users/dereuromark/orgs","repos_url":"https://api.github.com/users/dereuromark/repos","events_url":"https://api.github.com/users/dereuromark/events{/privacy}","received_events_url":"https://api.github.com/users/dereuromark/received_events","type":"User","site_admin":false},"created_at":"2017-12-12T12:03:03Z","updated_at":"2017-12-12T12:03:03Z","author_association":"MEMBER","body":"@burzum If the value does not matter for code usage, then why not using speaking and proper string codes in the first place? Those numbers really are confusing, especially when somewhere between log file content and debug output."}}
{"actor":{"display_login":"dereuromark"}}