{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3x/pulls/comments/95163180","pull_request_review_id":15708991,"id":95163180,"diff_hunk":"@@ -114,24 +128,31 @@ type debugger struct {\n \tentries [][]*debuggerEntry\n }\n \n-func (d *debugger) append(event debuggerEvent, ref int, stack []byte) {\n+func (d *debugger) append(event debuggerEvent, ref int, pc []uintptr) {\n \tif len(d.entries) == 0 {\n \t\td.entries = make([][]*debuggerEntry, 1, tracebackCycles)\n \t}\n \tidx := len(d.entries) - 1\n-\td.entries[idx] = append(d.entries[idx], &debuggerEntry{\n-\t\tevent: event,\n-\t\tref:   ref,\n-\t\tstack: stack,\n-\t\tt:     time.Now(),\n-\t})\n+\tentry := tracebackEntryPool.Get().(*debuggerEntry)\n+\tentry.event = event\n+\tentry.ref = ref\n+\tentry.pc = pc\n+\tentry.t = time.Now()\n+\td.entries[idx] = append(d.entries[idx], entry)\n \tif event == decRefEvent && ref == 0 {\n \t\tif len(d.entries) == tracebackCycles {\n \t\t\t// Shift all tracebacks back one if at end of traceback cycles\n+\t\t\tslice := d.entries[0]\n+\t\t\tfor i, entry := range slice {\n+\t\t\t\ttracebackCallersPool.Put(entry.pc)","path":"checked/debug.go","position":79,"original_position":74,"commit_id":"3cc957a3adf2a224ce1d2c05b4435e1c429982b4","original_commit_id":"d0469a0313c60c1f9db58e103eb118c9ad08f748","user":{"login":"robskillington","id":339615,"avatar_url":"https://avatars.githubusercontent.com/u/339615?v=3","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"body":"I believe that the `interface{}` version of the `[]uintptr` retains the pointer to the still allocated array.  \r\n\r\nNil'ing it out below only releases the root from the `*debuggerEntry` to the `[]uintptr` which the pool still holds onto.","created_at":"2017-01-09T14:22:43Z","updated_at":"2017-01-09T14:22:44Z","html_url":"https://github.com/m3db/m3x/pull/38#discussion_r95163180","pull_request_url":"https://api.github.com/repos/m3db/m3x/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3x/pulls/comments/95163180"},"html":{"href":"https://github.com/m3db/m3x/pull/38#discussion_r95163180"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3x/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3x/pulls/38","id":100136331,"html_url":"https://github.com/m3db/m3x/pull/38","diff_url":"https://github.com/m3db/m3x/pull/38.diff","patch_url":"https://github.com/m3db/m3x/pull/38.patch","issue_url":"https://api.github.com/repos/m3db/m3x/issues/38","number":38,"state":"open","locked":false,"title":"Use program counters instead of stacks to track ref count usage","user":{"login":"robskillington","id":339615,"avatar_url":"https://avatars.githubusercontent.com/u/339615?v=3","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"body":"cc @kobolog @xichen2020 @cw9 @martin-mao ","created_at":"2017-01-04T15:42:50Z","updated_at":"2017-01-09T14:22:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbeea2a4d2d049035344c6af1ac5292ac311f9a8","assignee":{"login":"kobolog","id":318866,"avatar_url":"https://avatars.githubusercontent.com/u/318866?v=3","gravatar_id":"","url":"https://api.github.com/users/kobolog","html_url":"https://github.com/kobolog","followers_url":"https://api.github.com/users/kobolog/followers","following_url":"https://api.github.com/users/kobolog/following{/other_user}","gists_url":"https://api.github.com/users/kobolog/gists{/gist_id}","starred_url":"https://api.github.com/users/kobolog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobolog/subscriptions","organizations_url":"https://api.github.com/users/kobolog/orgs","repos_url":"https://api.github.com/users/kobolog/repos","events_url":"https://api.github.com/users/kobolog/events{/privacy}","received_events_url":"https://api.github.com/users/kobolog/received_events","type":"User","site_admin":false},"assignees":[{"login":"kobolog","id":318866,"avatar_url":"https://avatars.githubusercontent.com/u/318866?v=3","gravatar_id":"","url":"https://api.github.com/users/kobolog","html_url":"https://github.com/kobolog","followers_url":"https://api.github.com/users/kobolog/followers","following_url":"https://api.github.com/users/kobolog/following{/other_user}","gists_url":"https://api.github.com/users/kobolog/gists{/gist_id}","starred_url":"https://api.github.com/users/kobolog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobolog/subscriptions","organizations_url":"https://api.github.com/users/kobolog/orgs","repos_url":"https://api.github.com/users/kobolog/repos","events_url":"https://api.github.com/users/kobolog/events{/privacy}","received_events_url":"https://api.github.com/users/kobolog/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3x/pulls/38/commits","review_comments_url":"https://api.github.com/repos/m3db/m3x/pulls/38/comments","review_comment_url":"https://api.github.com/repos/m3db/m3x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3x/issues/38/comments","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/3cc957a3adf2a224ce1d2c05b4435e1c429982b4","head":{"label":"m3db:r/use-pc-instead-of-stack","ref":"r/use-pc-instead-of-stack","sha":"3cc957a3adf2a224ce1d2c05b4435e1c429982b4","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64251470,"name":"m3x","full_name":"m3db/m3x","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3x","description":"Common utility classes used across M3 components","fork":false,"url":"https://api.github.com/repos/m3db/m3x","forks_url":"https://api.github.com/repos/m3db/m3x/forks","keys_url":"https://api.github.com/repos/m3db/m3x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3x/teams","hooks_url":"https://api.github.com/repos/m3db/m3x/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3x/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3x/events","assignees_url":"https://api.github.com/repos/m3db/m3x/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3x/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3x/tags","blobs_url":"https://api.github.com/repos/m3db/m3x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3x/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3x/languages","stargazers_url":"https://api.github.com/repos/m3db/m3x/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3x/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3x/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3x/subscription","commits_url":"https://api.github.com/repos/m3db/m3x/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3x/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3x/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3x/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3x/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3x/merges","archive_url":"https://api.github.com/repos/m3db/m3x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3x/downloads","issues_url":"https://api.github.com/repos/m3db/m3x/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3x/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3x/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3x/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3x/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3x/deployments","created_at":"2016-07-26T20:16:52Z","updated_at":"2016-10-23T22:42:11Z","pushed_at":"2017-01-09T14:20:46Z","git_url":"git://github.com/m3db/m3x.git","ssh_url":"git@github.com:m3db/m3x.git","clone_url":"https://github.com/m3db/m3x.git","svn_url":"https://github.com/m3db/m3x","homepage":null,"size":119,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"fcb5878c2ad11ab932afc2d30810da4a23986d0e","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64251470,"name":"m3x","full_name":"m3db/m3x","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3x","description":"Common utility classes used across M3 components","fork":false,"url":"https://api.github.com/repos/m3db/m3x","forks_url":"https://api.github.com/repos/m3db/m3x/forks","keys_url":"https://api.github.com/repos/m3db/m3x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3x/teams","hooks_url":"https://api.github.com/repos/m3db/m3x/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3x/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3x/events","assignees_url":"https://api.github.com/repos/m3db/m3x/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3x/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3x/tags","blobs_url":"https://api.github.com/repos/m3db/m3x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3x/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3x/languages","stargazers_url":"https://api.github.com/repos/m3db/m3x/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3x/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3x/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3x/subscription","commits_url":"https://api.github.com/repos/m3db/m3x/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3x/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3x/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3x/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3x/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3x/merges","archive_url":"https://api.github.com/repos/m3db/m3x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3x/downloads","issues_url":"https://api.github.com/repos/m3db/m3x/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3x/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3x/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3x/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3x/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3x/deployments","created_at":"2016-07-26T20:16:52Z","updated_at":"2016-10-23T22:42:11Z","pushed_at":"2017-01-09T14:20:46Z","git_url":"git://github.com/m3db/m3x.git","ssh_url":"git@github.com:m3db/m3x.git","clone_url":"https://github.com/m3db/m3x.git","svn_url":"https://github.com/m3db/m3x","homepage":null,"size":119,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3x/pulls/38"},"html":{"href":"https://github.com/m3db/m3x/pull/38"},"issue":{"href":"https://api.github.com/repos/m3db/m3x/issues/38"},"comments":{"href":"https://api.github.com/repos/m3db/m3x/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3x/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3x/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3x/statuses/3cc957a3adf2a224ce1d2c05b4435e1c429982b4"}}}}
{"actor":{"display_login":"robskillington"}}