{"action":"created","comment":{"url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/comments/97392914","pull_request_review_id":18000819,"id":97392914,"diff_hunk":"@@ -1,4 +1,4 @@\n-import { Client } from 'src/client';\n+import Client from 'src/client';","path":"test/unit/client.test.js","position":2,"original_position":2,"commit_id":"e7da9a8caa6ecc02f339a7e92edaf5a05076d8cb","original_commit_id":"b6f6ba4cfcafbd72dac6a57bf6c24e518c9b7636","user":{"login":"thomasconner","id":950052,"avatar_url":"https://avatars.githubusercontent.com/u/950052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false},"body":"No it won't. Apps would access the `Client` on the `Kinvey` namespace.","created_at":"2017-01-23T19:13:09Z","updated_at":"2017-01-23T19:13:09Z","html_url":"https://github.com/Kinvey/js-sdk/pull/94#discussion_r97392914","pull_request_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/comments/97392914"},"html":{"href":"https://github.com/Kinvey/js-sdk/pull/94#discussion_r97392914"},"pull_request":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94","id":100931292,"html_url":"https://github.com/Kinvey/js-sdk/pull/94","diff_url":"https://github.com/Kinvey/js-sdk/pull/94.diff","patch_url":"https://github.com/Kinvey/js-sdk/pull/94.patch","issue_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/94","number":94,"state":"open","locked":false,"title":"Refactor","user":{"login":"thomasconner","id":950052,"avatar_url":"https://avatars.githubusercontent.com/u/950052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false},"body":"#### Description\r\nThis PR updates several parts of the SDK to allow further development.\r\n\r\n#### Changes\r\n- Export all modules so they are easily extensible by shims.\r\n- Create aliases using babel to prevent long `../../../` expressions when importing modules\r\n- Expose the rack architecture to allow shims to provide custom implmentations for network and cache middleware\r\n- Clean some minor things with the way modules are exported","created_at":"2017-01-10T18:48:55Z","updated_at":"2017-01-23T19:13:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba45b0e74b8b96e4aa04c674693e7f4717ca7b13","assignee":{"login":"tejasranade","id":1953831,"avatar_url":"https://avatars.githubusercontent.com/u/1953831?v=3","gravatar_id":"","url":"https://api.github.com/users/tejasranade","html_url":"https://github.com/tejasranade","followers_url":"https://api.github.com/users/tejasranade/followers","following_url":"https://api.github.com/users/tejasranade/following{/other_user}","gists_url":"https://api.github.com/users/tejasranade/gists{/gist_id}","starred_url":"https://api.github.com/users/tejasranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejasranade/subscriptions","organizations_url":"https://api.github.com/users/tejasranade/orgs","repos_url":"https://api.github.com/users/tejasranade/repos","events_url":"https://api.github.com/users/tejasranade/events{/privacy}","received_events_url":"https://api.github.com/users/tejasranade/received_events","type":"User","site_admin":false},"assignees":[{"login":"tejasranade","id":1953831,"avatar_url":"https://avatars.githubusercontent.com/u/1953831?v=3","gravatar_id":"","url":"https://api.github.com/users/tejasranade","html_url":"https://github.com/tejasranade","followers_url":"https://api.github.com/users/tejasranade/followers","following_url":"https://api.github.com/users/tejasranade/following{/other_user}","gists_url":"https://api.github.com/users/tejasranade/gists{/gist_id}","starred_url":"https://api.github.com/users/tejasranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejasranade/subscriptions","organizations_url":"https://api.github.com/users/tejasranade/orgs","repos_url":"https://api.github.com/users/tejasranade/repos","events_url":"https://api.github.com/users/tejasranade/events{/privacy}","received_events_url":"https://api.github.com/users/tejasranade/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94/commits","review_comments_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94/comments","review_comment_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/94/comments","statuses_url":"https://api.github.com/repos/Kinvey/js-sdk/statuses/e7da9a8caa6ecc02f339a7e92edaf5a05076d8cb","head":{"label":"Kinvey:refactor","ref":"refactor","sha":"e7da9a8caa6ecc02f339a7e92edaf5a05076d8cb","user":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"repo":{"id":30971013,"name":"js-sdk","full_name":"Kinvey/js-sdk","owner":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinvey/js-sdk","description":"JavaScript Core SDK - shared code for all Kinvey JS SDKs","fork":false,"url":"https://api.github.com/repos/Kinvey/js-sdk","forks_url":"https://api.github.com/repos/Kinvey/js-sdk/forks","keys_url":"https://api.github.com/repos/Kinvey/js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinvey/js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinvey/js-sdk/teams","hooks_url":"https://api.github.com/repos/Kinvey/js-sdk/hooks","issue_events_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Kinvey/js-sdk/events","assignees_url":"https://api.github.com/repos/Kinvey/js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Kinvey/js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Kinvey/js-sdk/tags","blobs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinvey/js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinvey/js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinvey/js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinvey/js-sdk/languages","stargazers_url":"https://api.github.com/repos/Kinvey/js-sdk/stargazers","contributors_url":"https://api.github.com/repos/Kinvey/js-sdk/contributors","subscribers_url":"https://api.github.com/repos/Kinvey/js-sdk/subscribers","subscription_url":"https://api.github.com/repos/Kinvey/js-sdk/subscription","commits_url":"https://api.github.com/repos/Kinvey/js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinvey/js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinvey/js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinvey/js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Kinvey/js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinvey/js-sdk/merges","archive_url":"https://api.github.com/repos/Kinvey/js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinvey/js-sdk/downloads","issues_url":"https://api.github.com/repos/Kinvey/js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinvey/js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinvey/js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinvey/js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Kinvey/js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Kinvey/js-sdk/deployments","created_at":"2015-02-18T15:20:34Z","updated_at":"2016-12-06T20:42:56Z","pushed_at":"2017-01-23T16:36:54Z","git_url":"git://github.com/Kinvey/js-sdk.git","ssh_url":"git@github.com:Kinvey/js-sdk.git","clone_url":"https://github.com/Kinvey/js-sdk.git","svn_url":"https://github.com/Kinvey/js-sdk","homepage":"http://devcenter.kinvey.com","size":23691,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"Kinvey:master","ref":"master","sha":"4864aef655f343e698482a058fbbeabf576d1f11","user":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"repo":{"id":30971013,"name":"js-sdk","full_name":"Kinvey/js-sdk","owner":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinvey/js-sdk","description":"JavaScript Core SDK - shared code for all Kinvey JS SDKs","fork":false,"url":"https://api.github.com/repos/Kinvey/js-sdk","forks_url":"https://api.github.com/repos/Kinvey/js-sdk/forks","keys_url":"https://api.github.com/repos/Kinvey/js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinvey/js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinvey/js-sdk/teams","hooks_url":"https://api.github.com/repos/Kinvey/js-sdk/hooks","issue_events_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Kinvey/js-sdk/events","assignees_url":"https://api.github.com/repos/Kinvey/js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Kinvey/js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Kinvey/js-sdk/tags","blobs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinvey/js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinvey/js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinvey/js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinvey/js-sdk/languages","stargazers_url":"https://api.github.com/repos/Kinvey/js-sdk/stargazers","contributors_url":"https://api.github.com/repos/Kinvey/js-sdk/contributors","subscribers_url":"https://api.github.com/repos/Kinvey/js-sdk/subscribers","subscription_url":"https://api.github.com/repos/Kinvey/js-sdk/subscription","commits_url":"https://api.github.com/repos/Kinvey/js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinvey/js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinvey/js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinvey/js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Kinvey/js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinvey/js-sdk/merges","archive_url":"https://api.github.com/repos/Kinvey/js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinvey/js-sdk/downloads","issues_url":"https://api.github.com/repos/Kinvey/js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinvey/js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinvey/js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinvey/js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Kinvey/js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Kinvey/js-sdk/deployments","created_at":"2015-02-18T15:20:34Z","updated_at":"2016-12-06T20:42:56Z","pushed_at":"2017-01-23T16:36:54Z","git_url":"git://github.com/Kinvey/js-sdk.git","ssh_url":"git@github.com:Kinvey/js-sdk.git","clone_url":"https://github.com/Kinvey/js-sdk.git","svn_url":"https://github.com/Kinvey/js-sdk","homepage":"http://devcenter.kinvey.com","size":23691,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94"},"html":{"href":"https://github.com/Kinvey/js-sdk/pull/94"},"issue":{"href":"https://api.github.com/repos/Kinvey/js-sdk/issues/94"},"comments":{"href":"https://api.github.com/repos/Kinvey/js-sdk/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/Kinvey/js-sdk/statuses/e7da9a8caa6ecc02f339a7e92edaf5a05076d8cb"}}}}
{"actor":{"display_login":"thomasconner"}}