{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/9","id":117001800,"html_url":"https://github.com/nodatime/nodatime.serialization/pull/9","diff_url":"https://github.com/nodatime/nodatime.serialization/pull/9.diff","patch_url":"https://github.com/nodatime/nodatime.serialization/pull/9.patch","issue_url":"https://api.github.com/repos/nodatime/nodatime.serialization/issues/9","number":9,"state":"closed","locked":false,"title":"Add typeinfo cache in NodaConverterBase","user":{"login":"krlm","id":1184144,"avatar_url":"https://avatars1.githubusercontent.com/u/1184144?v=4","gravatar_id":"","url":"https://api.github.com/users/krlm","html_url":"https://github.com/krlm","followers_url":"https://api.github.com/users/krlm/followers","following_url":"https://api.github.com/users/krlm/following{/other_user}","gists_url":"https://api.github.com/users/krlm/gists{/gist_id}","starred_url":"https://api.github.com/users/krlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlm/subscriptions","organizations_url":"https://api.github.com/users/krlm/orgs","repos_url":"https://api.github.com/users/krlm/repos","events_url":"https://api.github.com/users/krlm/events{/privacy}","received_events_url":"https://api.github.com/users/krlm/received_events","type":"User","site_admin":false},"body":"`CanConvert` pops up in hot path on my asp.net core load tests. Would you consider adding this type info cache here?\r\n\r\nPS. This might be a valid case to use `ConditionalWeakTable`. I'll check later how does it impact performance. ","created_at":"2017-04-21T14:48:25Z","updated_at":"2017-09-01T18:43:46Z","closed_at":"2017-09-01T18:43:46Z","merged_at":null,"merge_commit_sha":"6481cd6ca530e7aaa1decd6a14dfd8fc935970b5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/9/commits","review_comments_url":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/9/comments","review_comment_url":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodatime/nodatime.serialization/issues/9/comments","statuses_url":"https://api.github.com/repos/nodatime/nodatime.serialization/statuses/238886ccb99a144408c5bb10583690d65e7c11a7","head":{"label":"krlm:typeinfo-cache","ref":"typeinfo-cache","sha":"238886ccb99a144408c5bb10583690d65e7c11a7","user":{"login":"krlm","id":1184144,"avatar_url":"https://avatars1.githubusercontent.com/u/1184144?v=4","gravatar_id":"","url":"https://api.github.com/users/krlm","html_url":"https://github.com/krlm","followers_url":"https://api.github.com/users/krlm/followers","following_url":"https://api.github.com/users/krlm/following{/other_user}","gists_url":"https://api.github.com/users/krlm/gists{/gist_id}","starred_url":"https://api.github.com/users/krlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlm/subscriptions","organizations_url":"https://api.github.com/users/krlm/orgs","repos_url":"https://api.github.com/users/krlm/repos","events_url":"https://api.github.com/users/krlm/events{/privacy}","received_events_url":"https://api.github.com/users/krlm/received_events","type":"User","site_admin":false},"repo":{"id":88991872,"name":"nodatime.serialization","full_name":"krlm/nodatime.serialization","owner":{"login":"krlm","id":1184144,"avatar_url":"https://avatars1.githubusercontent.com/u/1184144?v=4","gravatar_id":"","url":"https://api.github.com/users/krlm","html_url":"https://github.com/krlm","followers_url":"https://api.github.com/users/krlm/followers","following_url":"https://api.github.com/users/krlm/following{/other_user}","gists_url":"https://api.github.com/users/krlm/gists{/gist_id}","starred_url":"https://api.github.com/users/krlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlm/subscriptions","organizations_url":"https://api.github.com/users/krlm/orgs","repos_url":"https://api.github.com/users/krlm/repos","events_url":"https://api.github.com/users/krlm/events{/privacy}","received_events_url":"https://api.github.com/users/krlm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krlm/nodatime.serialization","description":"Serialization projects for Noda Time","fork":true,"url":"https://api.github.com/repos/krlm/nodatime.serialization","forks_url":"https://api.github.com/repos/krlm/nodatime.serialization/forks","keys_url":"https://api.github.com/repos/krlm/nodatime.serialization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krlm/nodatime.serialization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krlm/nodatime.serialization/teams","hooks_url":"https://api.github.com/repos/krlm/nodatime.serialization/hooks","issue_events_url":"https://api.github.com/repos/krlm/nodatime.serialization/issues/events{/number}","events_url":"https://api.github.com/repos/krlm/nodatime.serialization/events","assignees_url":"https://api.github.com/repos/krlm/nodatime.serialization/assignees{/user}","branches_url":"https://api.github.com/repos/krlm/nodatime.serialization/branches{/branch}","tags_url":"https://api.github.com/repos/krlm/nodatime.serialization/tags","blobs_url":"https://api.github.com/repos/krlm/nodatime.serialization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krlm/nodatime.serialization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krlm/nodatime.serialization/git/refs{/sha}","trees_url":"https://api.github.com/repos/krlm/nodatime.serialization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krlm/nodatime.serialization/statuses/{sha}","languages_url":"https://api.github.com/repos/krlm/nodatime.serialization/languages","stargazers_url":"https://api.github.com/repos/krlm/nodatime.serialization/stargazers","contributors_url":"https://api.github.com/repos/krlm/nodatime.serialization/contributors","subscribers_url":"https://api.github.com/repos/krlm/nodatime.serialization/subscribers","subscription_url":"https://api.github.com/repos/krlm/nodatime.serialization/subscription","commits_url":"https://api.github.com/repos/krlm/nodatime.serialization/commits{/sha}","git_commits_url":"https://api.github.com/repos/krlm/nodatime.serialization/git/commits{/sha}","comments_url":"https://api.github.com/repos/krlm/nodatime.serialization/comments{/number}","issue_comment_url":"https://api.github.com/repos/krlm/nodatime.serialization/issues/comments{/number}","contents_url":"https://api.github.com/repos/krlm/nodatime.serialization/contents/{+path}","compare_url":"https://api.github.com/repos/krlm/nodatime.serialization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krlm/nodatime.serialization/merges","archive_url":"https://api.github.com/repos/krlm/nodatime.serialization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krlm/nodatime.serialization/downloads","issues_url":"https://api.github.com/repos/krlm/nodatime.serialization/issues{/number}","pulls_url":"https://api.github.com/repos/krlm/nodatime.serialization/pulls{/number}","milestones_url":"https://api.github.com/repos/krlm/nodatime.serialization/milestones{/number}","notifications_url":"https://api.github.com/repos/krlm/nodatime.serialization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krlm/nodatime.serialization/labels{/name}","releases_url":"https://api.github.com/repos/krlm/nodatime.serialization/releases{/id}","deployments_url":"https://api.github.com/repos/krlm/nodatime.serialization/deployments","created_at":"2017-04-21T14:24:06Z","updated_at":"2017-04-21T14:24:08Z","pushed_at":"2017-05-08T18:59:26Z","git_url":"git://github.com/krlm/nodatime.serialization.git","ssh_url":"git@github.com:krlm/nodatime.serialization.git","clone_url":"https://github.com/krlm/nodatime.serialization.git","svn_url":"https://github.com/krlm/nodatime.serialization","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodatime:master","ref":"master","sha":"2bcd23a22136294dc923dcb16d80aca5978d34fc","user":{"login":"nodatime","id":10754831,"avatar_url":"https://avatars2.githubusercontent.com/u/10754831?v=4","gravatar_id":"","url":"https://api.github.com/users/nodatime","html_url":"https://github.com/nodatime","followers_url":"https://api.github.com/users/nodatime/followers","following_url":"https://api.github.com/users/nodatime/following{/other_user}","gists_url":"https://api.github.com/users/nodatime/gists{/gist_id}","starred_url":"https://api.github.com/users/nodatime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodatime/subscriptions","organizations_url":"https://api.github.com/users/nodatime/orgs","repos_url":"https://api.github.com/users/nodatime/repos","events_url":"https://api.github.com/users/nodatime/events{/privacy}","received_events_url":"https://api.github.com/users/nodatime/received_events","type":"Organization","site_admin":false},"repo":{"id":51815089,"name":"nodatime.serialization","full_name":"nodatime/nodatime.serialization","owner":{"login":"nodatime","id":10754831,"avatar_url":"https://avatars2.githubusercontent.com/u/10754831?v=4","gravatar_id":"","url":"https://api.github.com/users/nodatime","html_url":"https://github.com/nodatime","followers_url":"https://api.github.com/users/nodatime/followers","following_url":"https://api.github.com/users/nodatime/following{/other_user}","gists_url":"https://api.github.com/users/nodatime/gists{/gist_id}","starred_url":"https://api.github.com/users/nodatime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodatime/subscriptions","organizations_url":"https://api.github.com/users/nodatime/orgs","repos_url":"https://api.github.com/users/nodatime/repos","events_url":"https://api.github.com/users/nodatime/events{/privacy}","received_events_url":"https://api.github.com/users/nodatime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodatime/nodatime.serialization","description":"Serialization projects for Noda Time","fork":false,"url":"https://api.github.com/repos/nodatime/nodatime.serialization","forks_url":"https://api.github.com/repos/nodatime/nodatime.serialization/forks","keys_url":"https://api.github.com/repos/nodatime/nodatime.serialization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodatime/nodatime.serialization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodatime/nodatime.serialization/teams","hooks_url":"https://api.github.com/repos/nodatime/nodatime.serialization/hooks","issue_events_url":"https://api.github.com/repos/nodatime/nodatime.serialization/issues/events{/number}","events_url":"https://api.github.com/repos/nodatime/nodatime.serialization/events","assignees_url":"https://api.github.com/repos/nodatime/nodatime.serialization/assignees{/user}","branches_url":"https://api.github.com/repos/nodatime/nodatime.serialization/branches{/branch}","tags_url":"https://api.github.com/repos/nodatime/nodatime.serialization/tags","blobs_url":"https://api.github.com/repos/nodatime/nodatime.serialization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodatime/nodatime.serialization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodatime/nodatime.serialization/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodatime/nodatime.serialization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodatime/nodatime.serialization/statuses/{sha}","languages_url":"https://api.github.com/repos/nodatime/nodatime.serialization/languages","stargazers_url":"https://api.github.com/repos/nodatime/nodatime.serialization/stargazers","contributors_url":"https://api.github.com/repos/nodatime/nodatime.serialization/contributors","subscribers_url":"https://api.github.com/repos/nodatime/nodatime.serialization/subscribers","subscription_url":"https://api.github.com/repos/nodatime/nodatime.serialization/subscription","commits_url":"https://api.github.com/repos/nodatime/nodatime.serialization/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodatime/nodatime.serialization/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodatime/nodatime.serialization/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodatime/nodatime.serialization/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodatime/nodatime.serialization/contents/{+path}","compare_url":"https://api.github.com/repos/nodatime/nodatime.serialization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodatime/nodatime.serialization/merges","archive_url":"https://api.github.com/repos/nodatime/nodatime.serialization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodatime/nodatime.serialization/downloads","issues_url":"https://api.github.com/repos/nodatime/nodatime.serialization/issues{/number}","pulls_url":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls{/number}","milestones_url":"https://api.github.com/repos/nodatime/nodatime.serialization/milestones{/number}","notifications_url":"https://api.github.com/repos/nodatime/nodatime.serialization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodatime/nodatime.serialization/labels{/name}","releases_url":"https://api.github.com/repos/nodatime/nodatime.serialization/releases{/id}","deployments_url":"https://api.github.com/repos/nodatime/nodatime.serialization/deployments","created_at":"2016-02-16T06:59:29Z","updated_at":"2017-08-31T15:28:42Z","pushed_at":"2017-07-24T10:16:00Z","git_url":"git://github.com/nodatime/nodatime.serialization.git","ssh_url":"git@github.com:nodatime/nodatime.serialization.git","clone_url":"https://github.com/nodatime/nodatime.serialization.git","svn_url":"https://github.com/nodatime/nodatime.serialization","homepage":null,"size":47,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/9"},"html":{"href":"https://github.com/nodatime/nodatime.serialization/pull/9"},"issue":{"href":"https://api.github.com/repos/nodatime/nodatime.serialization/issues/9"},"comments":{"href":"https://api.github.com/repos/nodatime/nodatime.serialization/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodatime/nodatime.serialization/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/nodatime/nodatime.serialization/statuses/238886ccb99a144408c5bb10583690d65e7c11a7"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":10,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jskeet"}}