{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/15385","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/15385/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/15385/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/15385/events","html_url":"https://github.com/openshift/origin/pull/15385","id":244487342,"number":15385,"title":"Moved locking to protect a read of a map in the router","user":{"login":"knobunc","id":10033853,"avatar_url":"https://avatars1.githubusercontent.com/u/10033853?v=4","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false},"labels":[{"id":210156239,"url":"https://api.github.com/repos/openshift/origin/labels/component/routing","name":"component/routing","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"knobunc","id":10033853,"avatar_url":"https://avatars1.githubusercontent.com/u/10033853?v=4","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false},"assignees":[{"login":"knobunc","id":10033853,"avatar_url":"https://avatars1.githubusercontent.com/u/10033853?v=4","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/21","html_url":"https://github.com/openshift/origin/milestone/21","labels_url":"https://api.github.com/repos/openshift/origin/milestones/21/labels","id":2380090,"number":21,"title":"3.7.0","description":"","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":106,"closed_issues":17,"state":"open","created_at":"2017-03-12T06:20:11Z","updated_at":"2017-07-21T06:04:54Z","due_on":"2017-08-29T07:00:00Z","closed_at":null},"comments":8,"created_at":"2017-07-20T20:28:48Z","updated_at":"2017-07-21T13:41:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/15385","html_url":"https://github.com/openshift/origin/pull/15385","diff_url":"https://github.com/openshift/origin/pull/15385.diff","patch_url":"https://github.com/openshift/origin/pull/15385.patch"},"body":"The locking was not protecting a read, so a simultaneous write would\r\ncrash the router.  I made a bunch of new functions that implemented\r\nthe functional part of the function without the locking, then made the\r\nlocking functions acquire the lock and then call the internal part.\r\nThen in the rename, I moved the lock acquisition earlier and called\r\nthe internal functions.\r\n\r\nIn brief: re-jiggered the code so we could lock properly.\r\n\r\nFixes bug 1473031 (https://bugzilla.redhat.com/show_bug.cgi?id=1473031)"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/317003914","html_url":"https://github.com/openshift/origin/pull/15385#issuecomment-317003914","issue_url":"https://api.github.com/repos/openshift/origin/issues/15385","id":317003914,"user":{"login":"knobunc","id":10033853,"avatar_url":"https://avatars1.githubusercontent.com/u/10033853?v=4","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false},"created_at":"2017-07-21T13:41:42Z","updated_at":"2017-07-21T13:41:42Z","body":"[test] flaked on https://github.com/openshift/origin/issues/14385 (logs https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3353/)"}}
{"actor":{"display_login":"knobunc"}}