{"action":"closed","number":705,"pull_request":{"url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/705","id":111843583,"html_url":"https://github.com/savoirfairelinux/sous-chef/pull/705","diff_url":"https://github.com/savoirfairelinux/sous-chef/pull/705.diff","patch_url":"https://github.com/savoirfairelinux/sous-chef/pull/705.patch","issue_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/705","number":705,"state":"closed","locked":false,"title":"Fixed #627: Node.js packages are outdated","user":{"login":"peakwinter","id":997174,"avatar_url":"https://avatars0.githubusercontent.com/u/997174?v=3","gravatar_id":"","url":"https://api.github.com/users/peakwinter","html_url":"https://github.com/peakwinter","followers_url":"https://api.github.com/users/peakwinter/followers","following_url":"https://api.github.com/users/peakwinter/following{/other_user}","gists_url":"https://api.github.com/users/peakwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/peakwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peakwinter/subscriptions","organizations_url":"https://api.github.com/users/peakwinter/orgs","repos_url":"https://api.github.com/users/peakwinter/repos","events_url":"https://api.github.com/users/peakwinter/events{/privacy}","received_events_url":"https://api.github.com/users/peakwinter/received_events","type":"User","site_admin":false},"body":"## Fixes #627 by @lingxiaoyang \r\n\r\n### Changes proposed in this pull request:\r\n\r\n* Update the versions of all JS dependencies (both frontend and for Gulp)\r\n* Import vendor JS/CSS/images from npm packages, rather than having them hard-coded into this repository.\r\n* Set the Docker environment to use Node.JS 6.x (LTS) versions, instead of 4.x.\r\n\r\n### Status\r\n\r\n- [X] READY\r\n- [ ] HOLD\r\n- [ ] WIP (Work-In-Progress)\r\n\r\n### How to verify this change\r\n\r\n* Rebuild the Docker dev environment using `docker-compose build && docker-compose up`.\r\n* Launch the Docker dev environment using `docker exec -it $IDOFWEBCONTAINER bash`.\r\n* Run `node --version && npm --version`\r\n* Ensure the new npm dependencies install properly with `cd /code/tools/gulp && npm install`\r\n* Ensure the Gulp pipeline runs successfully with `cd /code/tools/gulp && gulp watch`\r\n* Open the dev server at `http://localhost:8000` and ensure all assets are properly loading on various screens.\r\n\r\n### Deployment notes and migration\r\n\r\n- [ ] Migration is needed for this change\r\n- [X] Environment rebuild is needed for this change\r\n\r\nIt is imperative to **rebuild your docker-compose environment** using `docker-compose build` so the new repos for Node.JS 6.x can be properly installed.\r\n\r\n### New translatable strings\r\n\r\n- [ ] If applicable, I have included updated .po files with new strings (see https://github.com/savoirfairelinux/sous-chef/blob/dev/docs/internationalization.adoc)\r\n\r\n### Additional notes\r\n\r\nnone\r\n","created_at":"2017-03-21T18:03:56Z","updated_at":"2017-03-21T19:28:43Z","closed_at":"2017-03-21T19:28:43Z","merged_at":"2017-03-21T19:28:43Z","merge_commit_sha":"13231f99ba0020da0230e289d0c22b6156ed6cf1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/705/commits","review_comments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/705/comments","review_comment_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/705/comments","statuses_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/statuses/e3781970ee0ad2fdd8cc6289b760018b85c96b17","head":{"label":"peakwinter:fix_627","ref":"fix_627","sha":"e3781970ee0ad2fdd8cc6289b760018b85c96b17","user":{"login":"peakwinter","id":997174,"avatar_url":"https://avatars0.githubusercontent.com/u/997174?v=3","gravatar_id":"","url":"https://api.github.com/users/peakwinter","html_url":"https://github.com/peakwinter","followers_url":"https://api.github.com/users/peakwinter/followers","following_url":"https://api.github.com/users/peakwinter/following{/other_user}","gists_url":"https://api.github.com/users/peakwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/peakwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peakwinter/subscriptions","organizations_url":"https://api.github.com/users/peakwinter/orgs","repos_url":"https://api.github.com/users/peakwinter/repos","events_url":"https://api.github.com/users/peakwinter/events{/privacy}","received_events_url":"https://api.github.com/users/peakwinter/received_events","type":"User","site_admin":false},"repo":{"id":85092430,"name":"sous-chef","full_name":"peakwinter/sous-chef","owner":{"login":"peakwinter","id":997174,"avatar_url":"https://avatars0.githubusercontent.com/u/997174?v=3","gravatar_id":"","url":"https://api.github.com/users/peakwinter","html_url":"https://github.com/peakwinter","followers_url":"https://api.github.com/users/peakwinter/followers","following_url":"https://api.github.com/users/peakwinter/following{/other_user}","gists_url":"https://api.github.com/users/peakwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/peakwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peakwinter/subscriptions","organizations_url":"https://api.github.com/users/peakwinter/orgs","repos_url":"https://api.github.com/users/peakwinter/repos","events_url":"https://api.github.com/users/peakwinter/events{/privacy}","received_events_url":"https://api.github.com/users/peakwinter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peakwinter/sous-chef","description":"Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.","fork":true,"url":"https://api.github.com/repos/peakwinter/sous-chef","forks_url":"https://api.github.com/repos/peakwinter/sous-chef/forks","keys_url":"https://api.github.com/repos/peakwinter/sous-chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peakwinter/sous-chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peakwinter/sous-chef/teams","hooks_url":"https://api.github.com/repos/peakwinter/sous-chef/hooks","issue_events_url":"https://api.github.com/repos/peakwinter/sous-chef/issues/events{/number}","events_url":"https://api.github.com/repos/peakwinter/sous-chef/events","assignees_url":"https://api.github.com/repos/peakwinter/sous-chef/assignees{/user}","branches_url":"https://api.github.com/repos/peakwinter/sous-chef/branches{/branch}","tags_url":"https://api.github.com/repos/peakwinter/sous-chef/tags","blobs_url":"https://api.github.com/repos/peakwinter/sous-chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peakwinter/sous-chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peakwinter/sous-chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/peakwinter/sous-chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peakwinter/sous-chef/statuses/{sha}","languages_url":"https://api.github.com/repos/peakwinter/sous-chef/languages","stargazers_url":"https://api.github.com/repos/peakwinter/sous-chef/stargazers","contributors_url":"https://api.github.com/repos/peakwinter/sous-chef/contributors","subscribers_url":"https://api.github.com/repos/peakwinter/sous-chef/subscribers","subscription_url":"https://api.github.com/repos/peakwinter/sous-chef/subscription","commits_url":"https://api.github.com/repos/peakwinter/sous-chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/peakwinter/sous-chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/peakwinter/sous-chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/peakwinter/sous-chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/peakwinter/sous-chef/contents/{+path}","compare_url":"https://api.github.com/repos/peakwinter/sous-chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peakwinter/sous-chef/merges","archive_url":"https://api.github.com/repos/peakwinter/sous-chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peakwinter/sous-chef/downloads","issues_url":"https://api.github.com/repos/peakwinter/sous-chef/issues{/number}","pulls_url":"https://api.github.com/repos/peakwinter/sous-chef/pulls{/number}","milestones_url":"https://api.github.com/repos/peakwinter/sous-chef/milestones{/number}","notifications_url":"https://api.github.com/repos/peakwinter/sous-chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peakwinter/sous-chef/labels{/name}","releases_url":"https://api.github.com/repos/peakwinter/sous-chef/releases{/id}","deployments_url":"https://api.github.com/repos/peakwinter/sous-chef/deployments","created_at":"2017-03-15T15:55:09Z","updated_at":"2017-03-15T15:55:11Z","pushed_at":"2017-03-21T19:13:07Z","git_url":"git://github.com/peakwinter/sous-chef.git","ssh_url":"git@github.com:peakwinter/sous-chef.git","clone_url":"https://github.com/peakwinter/sous-chef.git","svn_url":"https://github.com/peakwinter/sous-chef","homepage":"","size":9150,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"savoirfairelinux:dev","ref":"dev","sha":"567c7466a596f2a671a0e410f902158b7c4a868a","user":{"login":"savoirfairelinux","id":2735545,"avatar_url":"https://avatars0.githubusercontent.com/u/2735545?v=3","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"repo":{"id":50676845,"name":"sous-chef","full_name":"savoirfairelinux/sous-chef","owner":{"login":"savoirfairelinux","id":2735545,"avatar_url":"https://avatars0.githubusercontent.com/u/2735545?v=3","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/savoirfairelinux/sous-chef","description":"Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.","fork":false,"url":"https://api.github.com/repos/savoirfairelinux/sous-chef","forks_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/forks","keys_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/teams","hooks_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/hooks","issue_events_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/events{/number}","events_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/events","assignees_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/assignees{/user}","branches_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/branches{/branch}","tags_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/tags","blobs_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/statuses/{sha}","languages_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/languages","stargazers_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/stargazers","contributors_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/contributors","subscribers_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/subscribers","subscription_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/subscription","commits_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/contents/{+path}","compare_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/merges","archive_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/downloads","issues_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues{/number}","pulls_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls{/number}","milestones_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/milestones{/number}","notifications_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/labels{/name}","releases_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/releases{/id}","deployments_url":"https://api.github.com/repos/savoirfairelinux/sous-chef/deployments","created_at":"2016-01-29T16:56:04Z","updated_at":"2017-02-25T15:51:50Z","pushed_at":"2017-03-21T19:28:42Z","git_url":"git://github.com/savoirfairelinux/sous-chef.git","ssh_url":"git@github.com:savoirfairelinux/sous-chef.git","clone_url":"https://github.com/savoirfairelinux/sous-chef.git","svn_url":"https://github.com/savoirfairelinux/sous-chef","homepage":"","size":9082,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":25,"forks":41,"open_issues":25,"watchers":27,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/705"},"html":{"href":"https://github.com/savoirfairelinux/sous-chef/pull/705"},"issue":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/705"},"comments":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/issues/705/comments"},"review_comments":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/705/comments"},"review_comment":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/pulls/705/commits"},"statuses":{"href":"https://api.github.com/repos/savoirfairelinux/sous-chef/statuses/e3781970ee0ad2fdd8cc6289b760018b85c96b17"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lingxiaoyang","id":8630726,"avatar_url":"https://avatars2.githubusercontent.com/u/8630726?v=3","gravatar_id":"","url":"https://api.github.com/users/lingxiaoyang","html_url":"https://github.com/lingxiaoyang","followers_url":"https://api.github.com/users/lingxiaoyang/followers","following_url":"https://api.github.com/users/lingxiaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lingxiaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lingxiaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingxiaoyang/subscriptions","organizations_url":"https://api.github.com/users/lingxiaoyang/orgs","repos_url":"https://api.github.com/users/lingxiaoyang/repos","events_url":"https://api.github.com/users/lingxiaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lingxiaoyang/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"maintainer_can_modify":false,"commits":10,"additions":289,"deletions":7690,"changed_files":34}}
{"actor":{"display_login":"lingxiaoyang"}}