{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/102617933","pull_request_review_id":23378296,"id":102617933,"diff_hunk":"@@ -17,7 +17,12 @@\n         <name>dfs.cluster.administrators</name>\n         <value>{{ADMINISTRATORS}}</value>\n     </property>\n-\n+    {{#TLS_ENABLED}}\n+    <property>\n+        <name>dfs.http.policy</name>\n+        <value>HTTP_AND_HTTPS</value>","path":"frameworks/hdfs/src/main/dist/hdfs-site.xml","position":8,"original_position":8,"commit_id":"33a13f2ebc1d13d6f7e3fad2cf26ec5447ace86f","original_commit_id":"33a13f2ebc1d13d6f7e3fad2cf26ec5447ace86f","user":{"login":"mohitsoni","id":102390,"avatar_url":"https://avatars.githubusercontent.com/u/102390?v=3","gravatar_id":"","url":"https://api.github.com/users/mohitsoni","html_url":"https://github.com/mohitsoni","followers_url":"https://api.github.com/users/mohitsoni/followers","following_url":"https://api.github.com/users/mohitsoni/following{/other_user}","gists_url":"https://api.github.com/users/mohitsoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mohitsoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohitsoni/subscriptions","organizations_url":"https://api.github.com/users/mohitsoni/orgs","repos_url":"https://api.github.com/users/mohitsoni/repos","events_url":"https://api.github.com/users/mohitsoni/events{/privacy}","received_events_url":"https://api.github.com/users/mohitsoni/received_events","type":"User","site_admin":false},"body":"It can be templated. Other values are:\r\n- HTTP_ONLY\r\n- HTTPS_ONLY\r\n- HTTP_AND_HTTPS","created_at":"2017-02-23T01:16:31Z","updated_at":"2017-02-23T01:16:31Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/597#discussion_r102617933","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/102617933"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/597#discussion_r102617933"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597","id":107530002,"html_url":"https://github.com/mesosphere/dcos-commons/pull/597","diff_url":"https://github.com/mesosphere/dcos-commons/pull/597.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/597.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/597","number":597,"state":"open","locked":false,"title":"Adds basic TLS Support","user":{"login":"mohitsoni","id":102390,"avatar_url":"https://avatars.githubusercontent.com/u/102390?v=3","gravatar_id":"","url":"https://api.github.com/users/mohitsoni","html_url":"https://github.com/mohitsoni","followers_url":"https://api.github.com/users/mohitsoni/followers","following_url":"https://api.github.com/users/mohitsoni/following{/other_user}","gists_url":"https://api.github.com/users/mohitsoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mohitsoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohitsoni/subscriptions","organizations_url":"https://api.github.com/users/mohitsoni/orgs","repos_url":"https://api.github.com/users/mohitsoni/repos","events_url":"https://api.github.com/users/mohitsoni/events{/privacy}","received_events_url":"https://api.github.com/users/mohitsoni/received_events","type":"User","site_admin":false},"body":"* Adds TLS support to HDFS.\r\n* TLS can be enabled by setting `service.tls_enabled` flag to true.\r\n* Added a new install certificate feature inside the bootstrap go binary. This feature will allow installing DC/OS injected certificate inside the JRE's keystore that's present inside the task sandbox.\r\n\r\nNote about current implementation:\r\n* It relies on the default JDK keystore, and doesn't generate a separate keystore and truststore for HDFS. This is something that can be re-visited in future. This is not the most secure way for doing this.\r\n* Current implementation also turns off ssl host verification, as the DC/OS generated certs that are injected in the sandbox doesn't have Common Name set to task's A-Record. Once DC/OS starts injecting certs with correct Common Name, we can turn on ssl host verification.","created_at":"2017-02-23T00:21:19Z","updated_at":"2017-02-23T01:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a0a2cdc1420d26f7cb967ddb6477cae104b4161","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/597/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/33a13f2ebc1d13d6f7e3fad2cf26ec5447ace86f","head":{"label":"mesosphere:tls-support","ref":"tls-support","sha":"33a13f2ebc1d13d6f7e3fad2cf26ec5447ace86f","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":null,"fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2017-02-21T10:53:48Z","pushed_at":"2017-02-23T01:02:34Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":25753,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":30,"forks":39,"open_issues":30,"watchers":49,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"ccdda984a73579ccaceed6e9579c66ff6cd8d0e5","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":null,"fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2017-02-21T10:53:48Z","pushed_at":"2017-02-23T01:02:34Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":25753,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":30,"forks":39,"open_issues":30,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/597"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/597"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/597/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/597/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/33a13f2ebc1d13d6f7e3fad2cf26ec5447ace86f"}}}}
{"actor":{"display_login":"mohitsoni"}}