{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/15479","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/15479/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/15479/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/15479/events","html_url":"https://github.com/cockroachdb/cockroach/pull/15479","id":225158648,"number":15479,"title":"sql: run TestMonotonicInserts with distsql both off and on","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars2.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-28T18:31:07Z","updated_at":"2017-04-30T15:21:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/15479","html_url":"https://github.com/cockroachdb/cockroach/pull/15479","diff_url":"https://github.com/cockroachdb/cockroach/pull/15479.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/15479.patch"},"body":"I think this test is important enough to run with both classic and distsql."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/298238312","html_url":"https://github.com/cockroachdb/cockroach/pull/15479#issuecomment-298238312","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/15479","id":298238312,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars3.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2017-04-30T15:21:43Z","updated_at":"2017-04-30T15:21:43Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReviewed 4 of 4 files at r1.\nReview status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.\n\n---\n\n*[pkg/sql/monotonic_insert_test.go, line 87 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/15479#-KizREIyu-WEYyrkUo4J:-KizREIyu-WEYyrkUo4K:bo3lopp) ([raw file](https://github.com/cockroachdb/cockroach/blob/906672f00235c02339d5240267a9aeaf4541f5ab/pkg/sql/monotonic_insert_test.go#L87)):*\n> ```Go\n> \n> \tfor _, distSQLMode := range []sql.DistSQLExecMode{sql.DistSQLOff, sql.DistSQLOn} {\n> \t\tt.Run(fmt.Sprintf(\"distsql%s\", distSQLMode), func(t *testing.T) {\n> ```\n\ncan you make this `\"distsql=%s\"` (add an equal sign)\n\n---\n\n*[pkg/sql/session.go, line 30 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/15479#-KizRcfKM00tkLUnAvXK:-KizRcfKM00tkLUnAvXL:blxqfzk) ([raw file](https://github.com/cockroachdb/cockroach/blob/906672f00235c02339d5240267a9aeaf4541f5ab/pkg/sql/session.go#L30)):*\n> ```Go\n> \t\"golang.org/x/net/trace\"\n> \n> \t\"strings\"\n> ```\n\nmove up to stdlib imports please\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/15479#-:-KizRzpnVTb1UT97Adix:bnfp4nl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}