{"action":"created","comment":{"url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments/135459322","pull_request_review_id":58872115,"id":135459322,"diff_hunk":"@@ -1,6 +1,6 @@\n pkgname=sdl2\n pkgver=2.0.5\n-pkgrel=0\n+pkgrel=9999","path":"aports/main/sdl2/APKBUILD","position":4,"original_position":4,"commit_id":"02ed33317d5903ca7c9452e27fad5f0aab4e268a","original_commit_id":"02ed33317d5903ca7c9452e27fad5f0aab4e268a","user":{"login":"drebrez","id":1611547,"avatar_url":"https://avatars0.githubusercontent.com/u/1611547?v=4","gravatar_id":"","url":"https://api.github.com/users/drebrez","html_url":"https://github.com/drebrez","followers_url":"https://api.github.com/users/drebrez/followers","following_url":"https://api.github.com/users/drebrez/following{/other_user}","gists_url":"https://api.github.com/users/drebrez/gists{/gist_id}","starred_url":"https://api.github.com/users/drebrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drebrez/subscriptions","organizations_url":"https://api.github.com/users/drebrez/orgs","repos_url":"https://api.github.com/users/drebrez/repos","events_url":"https://api.github.com/users/drebrez/events{/privacy}","received_events_url":"https://api.github.com/users/drebrez/received_events","type":"User","site_admin":false},"body":"@craftyguy I think the pkgrel should be changed to `1` and you can have to increase the pkgver number (https://wiki.archlinux.org/index.php/PKGBUILD#pkgver)","created_at":"2017-08-28T07:39:45Z","updated_at":"2017-08-28T07:45:02Z","html_url":"https://github.com/postmarketOS/pmbootstrap/pull/476#discussion_r135459322","pull_request_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476","_links":{"self":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments/135459322"},"html":{"href":"https://github.com/postmarketOS/pmbootstrap/pull/476#discussion_r135459322"},"pull_request":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476"}}},"pull_request":{"url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476","id":137854373,"html_url":"https://github.com/postmarketOS/pmbootstrap/pull/476","diff_url":"https://github.com/postmarketOS/pmbootstrap/pull/476.diff","patch_url":"https://github.com/postmarketOS/pmbootstrap/pull/476.patch","issue_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/476","number":476,"state":"open","locked":false,"title":"Add osk-sdl as default luks unlock mechanism on boot","user":{"login":"craftyguy","id":1474209,"avatar_url":"https://avatars2.githubusercontent.com/u/1474209?v=4","gravatar_id":"","url":"https://api.github.com/users/craftyguy","html_url":"https://github.com/craftyguy","followers_url":"https://api.github.com/users/craftyguy/followers","following_url":"https://api.github.com/users/craftyguy/following{/other_user}","gists_url":"https://api.github.com/users/craftyguy/gists{/gist_id}","starred_url":"https://api.github.com/users/craftyguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftyguy/subscriptions","organizations_url":"https://api.github.com/users/craftyguy/orgs","repos_url":"https://api.github.com/users/craftyguy/repos","events_url":"https://api.github.com/users/craftyguy/events{/privacy}","received_events_url":"https://api.github.com/users/craftyguy/received_events","type":"User","site_admin":false},"body":"This PR updates osk-sdl APKBUILD to point to a SHA in osk-sdl repo where backspace, shift, and keyboard layers are implemented. \r\n\r\nThis PR also integrates osk-sdl into the postmarketos-mkinitfs package, so that osk-sdl and its dependencies are built into the initramfs and osk-sdl is run on boot if the rootfs is encrypted.\r\n\r\nThis works really well on my N900's touch screen, but I have some concerns about:\r\n\r\n1) tslib may need to be calibrated on other devices. I can provide instructions how if this is necessary for capacitive touchscreens. Info also found in the tslib project readme. You will create a `pointercal` file that needs to be installed to `/etc` in the device rootfs and `mkinitfs` will pick it up. See rx51 device package for an example.\r\n\r\n2) If your device's touchscreen driver does **not** create any of the following devices then you MUST set `deviceinfo_touchscreen_dev` to point to the touchscreen device (see `device-nokia-rx51/deviceinfo` in this PR for an example):\r\n\r\n```\r\n/dev/input/ts\r\n/dev/input/touchscreen\r\n/dev/input/event0\r\ndev/touchscreen/ucb1x00\r\n```\r\n[It seems tslib only looks at those locations for the touchscreen device.](https://github.com/kergoth/tslib#setup-and-configure-tslib)\r\n\r\n\r\n3) I'm most likely pulling in more than is necessary into the initramfs for osk-sdl/SDL2/directfb to function. I would appreciate some help in making this slimmer, if it's possible!\r\n\r\n\r\nPlease test as much as you can! \r\n\r\nIf you find bugs with osk-sdl, [please report them in the osk-sdl repo](https://github.com/postmarketOS/osk-sdl/issues) and NOT here in the PR or in the pmbootstrap repo!\r\n","created_at":"2017-08-28T00:16:46Z","updated_at":"2017-08-28T07:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14be4353882bd6d8e16452b1a524e0efdbcea85d","assignee":{"login":"craftyguy","id":1474209,"avatar_url":"https://avatars2.githubusercontent.com/u/1474209?v=4","gravatar_id":"","url":"https://api.github.com/users/craftyguy","html_url":"https://github.com/craftyguy","followers_url":"https://api.github.com/users/craftyguy/followers","following_url":"https://api.github.com/users/craftyguy/following{/other_user}","gists_url":"https://api.github.com/users/craftyguy/gists{/gist_id}","starred_url":"https://api.github.com/users/craftyguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftyguy/subscriptions","organizations_url":"https://api.github.com/users/craftyguy/orgs","repos_url":"https://api.github.com/users/craftyguy/repos","events_url":"https://api.github.com/users/craftyguy/events{/privacy}","received_events_url":"https://api.github.com/users/craftyguy/received_events","type":"User","site_admin":false},"assignees":[{"login":"craftyguy","id":1474209,"avatar_url":"https://avatars2.githubusercontent.com/u/1474209?v=4","gravatar_id":"","url":"https://api.github.com/users/craftyguy","html_url":"https://github.com/craftyguy","followers_url":"https://api.github.com/users/craftyguy/followers","following_url":"https://api.github.com/users/craftyguy/following{/other_user}","gists_url":"https://api.github.com/users/craftyguy/gists{/gist_id}","starred_url":"https://api.github.com/users/craftyguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftyguy/subscriptions","organizations_url":"https://api.github.com/users/craftyguy/orgs","repos_url":"https://api.github.com/users/craftyguy/repos","events_url":"https://api.github.com/users/craftyguy/events{/privacy}","received_events_url":"https://api.github.com/users/craftyguy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ollieparanoid","id":6033024,"avatar_url":"https://avatars1.githubusercontent.com/u/6033024?v=4","gravatar_id":"","url":"https://api.github.com/users/ollieparanoid","html_url":"https://github.com/ollieparanoid","followers_url":"https://api.github.com/users/ollieparanoid/followers","following_url":"https://api.github.com/users/ollieparanoid/following{/other_user}","gists_url":"https://api.github.com/users/ollieparanoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ollieparanoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollieparanoid/subscriptions","organizations_url":"https://api.github.com/users/ollieparanoid/orgs","repos_url":"https://api.github.com/users/ollieparanoid/repos","events_url":"https://api.github.com/users/ollieparanoid/events{/privacy}","received_events_url":"https://api.github.com/users/ollieparanoid/received_events","type":"User","site_admin":false},{"login":"MartijnBraam","id":6928199,"avatar_url":"https://avatars0.githubusercontent.com/u/6928199?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnBraam","html_url":"https://github.com/MartijnBraam","followers_url":"https://api.github.com/users/MartijnBraam/followers","following_url":"https://api.github.com/users/MartijnBraam/following{/other_user}","gists_url":"https://api.github.com/users/MartijnBraam/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnBraam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnBraam/subscriptions","organizations_url":"https://api.github.com/users/MartijnBraam/orgs","repos_url":"https://api.github.com/users/MartijnBraam/repos","events_url":"https://api.github.com/users/MartijnBraam/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnBraam/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476/commits","review_comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476/comments","review_comment_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/476/comments","statuses_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/02ed33317d5903ca7c9452e27fad5f0aab4e268a","head":{"label":"postmarketOS:feature/add_osk_initramfs","ref":"feature/add_osk_initramfs","sha":"02ed33317d5903ca7c9452e27fad5f0aab4e268a","user":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"repo":{"id":92542047,"name":"pmbootstrap","full_name":"postmarketOS/pmbootstrap","owner":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmarketOS/pmbootstrap","description":"Sophisticated chroot/build/flash tool to develop and install postmarketOS","fork":false,"url":"https://api.github.com/repos/postmarketOS/pmbootstrap","forks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/forks","keys_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/teams","hooks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/hooks","issue_events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/events","assignees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/tags","blobs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/languages","stargazers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/stargazers","contributors_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contributors","subscribers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscribers","subscription_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscription","commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/merges","archive_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/downloads","issues_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/labels{/name}","releases_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/deployments","created_at":"2017-05-26T19:25:47Z","updated_at":"2017-08-28T07:26:43Z","pushed_at":"2017-08-28T01:31:51Z","git_url":"git://github.com/postmarketOS/pmbootstrap.git","ssh_url":"git@github.com:postmarketOS/pmbootstrap.git","clone_url":"https://github.com/postmarketOS/pmbootstrap.git","svn_url":"https://github.com/postmarketOS/pmbootstrap","homepage":"","size":4782,"stargazers_count":551,"watchers_count":551,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":83,"forks":46,"open_issues":83,"watchers":551,"default_branch":"master"}},"base":{"label":"postmarketOS:master","ref":"master","sha":"25bad18830d665f0eef0ccdf85f72deb6a673d6e","user":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"repo":{"id":92542047,"name":"pmbootstrap","full_name":"postmarketOS/pmbootstrap","owner":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmarketOS/pmbootstrap","description":"Sophisticated chroot/build/flash tool to develop and install postmarketOS","fork":false,"url":"https://api.github.com/repos/postmarketOS/pmbootstrap","forks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/forks","keys_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/teams","hooks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/hooks","issue_events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/events","assignees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/tags","blobs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/languages","stargazers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/stargazers","contributors_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contributors","subscribers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscribers","subscription_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscription","commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/merges","archive_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/downloads","issues_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/labels{/name}","releases_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/deployments","created_at":"2017-05-26T19:25:47Z","updated_at":"2017-08-28T07:26:43Z","pushed_at":"2017-08-28T01:31:51Z","git_url":"git://github.com/postmarketOS/pmbootstrap.git","ssh_url":"git@github.com:postmarketOS/pmbootstrap.git","clone_url":"https://github.com/postmarketOS/pmbootstrap.git","svn_url":"https://github.com/postmarketOS/pmbootstrap","homepage":"","size":4782,"stargazers_count":551,"watchers_count":551,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":83,"forks":46,"open_issues":83,"watchers":551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476"},"html":{"href":"https://github.com/postmarketOS/pmbootstrap/pull/476"},"issue":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/476"},"comments":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/02ed33317d5903ca7c9452e27fad5f0aab4e268a"}}}}
{"actor":{"display_login":"drebrez"}}