{"action":"created","issue":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/444","repository_url":"https://api.github.com/repos/jprichardson/node-fs-extra","labels_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/444/labels{/name}","comments_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/444/comments","events_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/444/events","html_url":"https://github.com/jprichardson/node-fs-extra/pull/444","id":237124041,"number":444,"title":"Support util.promisify on node>=8 (Fixes issue #442)","user":{"login":"danielgindi","id":366926,"avatar_url":"https://avatars2.githubusercontent.com/u/366926?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgindi","html_url":"https://github.com/danielgindi","followers_url":"https://api.github.com/users/danielgindi/followers","following_url":"https://api.github.com/users/danielgindi/following{/other_user}","gists_url":"https://api.github.com/users/danielgindi/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgindi/subscriptions","organizations_url":"https://api.github.com/users/danielgindi/orgs","repos_url":"https://api.github.com/users/danielgindi/repos","events_url":"https://api.github.com/users/danielgindi/events{/privacy}","received_events_url":"https://api.github.com/users/danielgindi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-06-20T08:01:02Z","updated_at":"2017-06-20T14:05:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/pulls/444","html_url":"https://github.com/jprichardson/node-fs-extra/pull/444","diff_url":"https://github.com/jprichardson/node-fs-extra/pull/444.diff","patch_url":"https://github.com/jprichardson/node-fs-extra/pull/444.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/comments/309765547","html_url":"https://github.com/jprichardson/node-fs-extra/pull/444#issuecomment-309765547","issue_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/444","id":309765547,"user":{"login":"danielgindi","id":366926,"avatar_url":"https://avatars2.githubusercontent.com/u/366926?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgindi","html_url":"https://github.com/danielgindi","followers_url":"https://api.github.com/users/danielgindi/followers","following_url":"https://api.github.com/users/danielgindi/following{/other_user}","gists_url":"https://api.github.com/users/danielgindi/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgindi/subscriptions","organizations_url":"https://api.github.com/users/danielgindi/orgs","repos_url":"https://api.github.com/users/danielgindi/repos","events_url":"https://api.github.com/users/danielgindi/events{/privacy}","received_events_url":"https://api.github.com/users/danielgindi/received_events","type":"User","site_admin":false},"created_at":"2017-06-20T14:05:51Z","updated_at":"2017-06-20T14:05:51Z","body":"There's something very unclear here. Seems like a misunderstanding:\r\n\r\n1. `util.promisify(fs.read)(...).then.` in the PR now works as it should (returning object)\r\n2. `fs.read(...).then...` works like in previous versions, backwards compatible. *node v0-8 versions do not support this syntax anyway.`. Should we make a breaking change and return an object too?\r\n3. What the heck do we need `util.promisify` for? We detect that there's a `util.promisify`, and add the promisify functionality. This happens on node-v8 only, which is the only version that has a special object returned anyway."}}
{"actor":{"display_login":"danielgindi"}}