{"action":"created","comment":{"url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/comments/128947030","pull_request_review_id":51670660,"id":128947030,"diff_hunk":"@@ -131,7 +131,7 @@ public static void validate(JsonNode patch) throws InvalidJsonPatchException {\n     }\n \n     public static JsonNode apply(JsonNode patch, JsonNode source, EnumSet<CompatibilityFlags> flags) throws JsonPatchApplicationException {\n-        ApplyProcessor processor = new ApplyProcessor(source);\n+        InPlaceApplyProcessor processor = new InPlaceApplyProcessor(source);","path":"src/main/java/com/flipkart/zjsonpatch/JsonPatch.java","position":5,"original_position":5,"commit_id":"c7e6598716c256473b34444fca9bde78f7dda7a0","original_commit_id":"c7e6598716c256473b34444fca9bde78f7dda7a0","user":{"login":"vishwakarma","id":2070697,"avatar_url":"https://avatars1.githubusercontent.com/u/2070697?v=4","gravatar_id":"","url":"https://api.github.com/users/vishwakarma","html_url":"https://github.com/vishwakarma","followers_url":"https://api.github.com/users/vishwakarma/followers","following_url":"https://api.github.com/users/vishwakarma/following{/other_user}","gists_url":"https://api.github.com/users/vishwakarma/gists{/gist_id}","starred_url":"https://api.github.com/users/vishwakarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishwakarma/subscriptions","organizations_url":"https://api.github.com/users/vishwakarma/orgs","repos_url":"https://api.github.com/users/vishwakarma/repos","events_url":"https://api.github.com/users/vishwakarma/events{/privacy}","received_events_url":"https://api.github.com/users/vishwakarma/received_events","type":"User","site_admin":false},"body":"Shouldn't this be\r\nCopyingApplyProcessor processor = new CopyingApplyProcessor(source);\r\nLets have deepCopy() as default behaviour, Since as per RFC source json should not be modified.\r\nHence, after your chance, we will have 2 public APIs, app() & applyInPlace().\r\n","created_at":"2017-07-24T04:18:19Z","updated_at":"2017-07-24T04:18:19Z","html_url":"https://github.com/flipkart-incubator/zjsonpatch/pull/43#discussion_r128947030","pull_request_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/comments/128947030"},"html":{"href":"https://github.com/flipkart-incubator/zjsonpatch/pull/43#discussion_r128947030"},"pull_request":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43","id":131944416,"html_url":"https://github.com/flipkart-incubator/zjsonpatch/pull/43","diff_url":"https://github.com/flipkart-incubator/zjsonpatch/pull/43.diff","patch_url":"https://github.com/flipkart-incubator/zjsonpatch/pull/43.patch","issue_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/issues/43","number":43,"state":"open","locked":false,"title":"introducing JsonPatch.applyInPlace","user":{"login":"hugebdu","id":1109601,"avatar_url":"https://avatars0.githubusercontent.com/u/1109601?v=4","gravatar_id":"","url":"https://api.github.com/users/hugebdu","html_url":"https://github.com/hugebdu","followers_url":"https://api.github.com/users/hugebdu/followers","following_url":"https://api.github.com/users/hugebdu/following{/other_user}","gists_url":"https://api.github.com/users/hugebdu/gists{/gist_id}","starred_url":"https://api.github.com/users/hugebdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugebdu/subscriptions","organizations_url":"https://api.github.com/users/hugebdu/orgs","repos_url":"https://api.github.com/users/hugebdu/repos","events_url":"https://api.github.com/users/hugebdu/events{/privacy}","received_events_url":"https://api.github.com/users/hugebdu/received_events","type":"User","site_admin":false},"body":"@vishwakarma here we go :)\r\n\r\nresolves https://github.com/flipkart-incubator/zjsonpatch/issues/41","created_at":"2017-07-23T18:47:01Z","updated_at":"2017-07-24T04:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8f3ac17622f7bf965619ec796e79365e4b79377","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43/commits","review_comments_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43/comments","review_comment_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/issues/43/comments","statuses_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/statuses/c7e6598716c256473b34444fca9bde78f7dda7a0","head":{"label":"hugebdu:master","ref":"master","sha":"c7e6598716c256473b34444fca9bde78f7dda7a0","user":{"login":"hugebdu","id":1109601,"avatar_url":"https://avatars0.githubusercontent.com/u/1109601?v=4","gravatar_id":"","url":"https://api.github.com/users/hugebdu","html_url":"https://github.com/hugebdu","followers_url":"https://api.github.com/users/hugebdu/followers","following_url":"https://api.github.com/users/hugebdu/following{/other_user}","gists_url":"https://api.github.com/users/hugebdu/gists{/gist_id}","starred_url":"https://api.github.com/users/hugebdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugebdu/subscriptions","organizations_url":"https://api.github.com/users/hugebdu/orgs","repos_url":"https://api.github.com/users/hugebdu/repos","events_url":"https://api.github.com/users/hugebdu/events{/privacy}","received_events_url":"https://api.github.com/users/hugebdu/received_events","type":"User","site_admin":false},"repo":{"id":98101377,"name":"zjsonpatch","full_name":"hugebdu/zjsonpatch","owner":{"login":"hugebdu","id":1109601,"avatar_url":"https://avatars0.githubusercontent.com/u/1109601?v=4","gravatar_id":"","url":"https://api.github.com/users/hugebdu","html_url":"https://github.com/hugebdu","followers_url":"https://api.github.com/users/hugebdu/followers","following_url":"https://api.github.com/users/hugebdu/following{/other_user}","gists_url":"https://api.github.com/users/hugebdu/gists{/gist_id}","starred_url":"https://api.github.com/users/hugebdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugebdu/subscriptions","organizations_url":"https://api.github.com/users/hugebdu/orgs","repos_url":"https://api.github.com/users/hugebdu/repos","events_url":"https://api.github.com/users/hugebdu/events{/privacy}","received_events_url":"https://api.github.com/users/hugebdu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hugebdu/zjsonpatch","description":"This is an implementation of RFC 6902 JSON Patch written in Java","fork":true,"url":"https://api.github.com/repos/hugebdu/zjsonpatch","forks_url":"https://api.github.com/repos/hugebdu/zjsonpatch/forks","keys_url":"https://api.github.com/repos/hugebdu/zjsonpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hugebdu/zjsonpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hugebdu/zjsonpatch/teams","hooks_url":"https://api.github.com/repos/hugebdu/zjsonpatch/hooks","issue_events_url":"https://api.github.com/repos/hugebdu/zjsonpatch/issues/events{/number}","events_url":"https://api.github.com/repos/hugebdu/zjsonpatch/events","assignees_url":"https://api.github.com/repos/hugebdu/zjsonpatch/assignees{/user}","branches_url":"https://api.github.com/repos/hugebdu/zjsonpatch/branches{/branch}","tags_url":"https://api.github.com/repos/hugebdu/zjsonpatch/tags","blobs_url":"https://api.github.com/repos/hugebdu/zjsonpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hugebdu/zjsonpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hugebdu/zjsonpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/hugebdu/zjsonpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hugebdu/zjsonpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/hugebdu/zjsonpatch/languages","stargazers_url":"https://api.github.com/repos/hugebdu/zjsonpatch/stargazers","contributors_url":"https://api.github.com/repos/hugebdu/zjsonpatch/contributors","subscribers_url":"https://api.github.com/repos/hugebdu/zjsonpatch/subscribers","subscription_url":"https://api.github.com/repos/hugebdu/zjsonpatch/subscription","commits_url":"https://api.github.com/repos/hugebdu/zjsonpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/hugebdu/zjsonpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/hugebdu/zjsonpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/hugebdu/zjsonpatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/hugebdu/zjsonpatch/contents/{+path}","compare_url":"https://api.github.com/repos/hugebdu/zjsonpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hugebdu/zjsonpatch/merges","archive_url":"https://api.github.com/repos/hugebdu/zjsonpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hugebdu/zjsonpatch/downloads","issues_url":"https://api.github.com/repos/hugebdu/zjsonpatch/issues{/number}","pulls_url":"https://api.github.com/repos/hugebdu/zjsonpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/hugebdu/zjsonpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/hugebdu/zjsonpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hugebdu/zjsonpatch/labels{/name}","releases_url":"https://api.github.com/repos/hugebdu/zjsonpatch/releases{/id}","deployments_url":"https://api.github.com/repos/hugebdu/zjsonpatch/deployments","created_at":"2017-07-23T13:56:50Z","updated_at":"2017-07-23T13:56:51Z","pushed_at":"2017-07-23T18:44:52Z","git_url":"git://github.com/hugebdu/zjsonpatch.git","ssh_url":"git@github.com:hugebdu/zjsonpatch.git","clone_url":"https://github.com/hugebdu/zjsonpatch.git","svn_url":"https://github.com/hugebdu/zjsonpatch","homepage":"","size":111,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flipkart-incubator:master","ref":"master","sha":"a7c1de97405028ca3fe0078d57b6599a46354604","user":{"login":"flipkart-incubator","id":7090545,"avatar_url":"https://avatars2.githubusercontent.com/u/7090545?v=4","gravatar_id":"","url":"https://api.github.com/users/flipkart-incubator","html_url":"https://github.com/flipkart-incubator","followers_url":"https://api.github.com/users/flipkart-incubator/followers","following_url":"https://api.github.com/users/flipkart-incubator/following{/other_user}","gists_url":"https://api.github.com/users/flipkart-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/flipkart-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipkart-incubator/subscriptions","organizations_url":"https://api.github.com/users/flipkart-incubator/orgs","repos_url":"https://api.github.com/users/flipkart-incubator/repos","events_url":"https://api.github.com/users/flipkart-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/flipkart-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":26768047,"name":"zjsonpatch","full_name":"flipkart-incubator/zjsonpatch","owner":{"login":"flipkart-incubator","id":7090545,"avatar_url":"https://avatars2.githubusercontent.com/u/7090545?v=4","gravatar_id":"","url":"https://api.github.com/users/flipkart-incubator","html_url":"https://github.com/flipkart-incubator","followers_url":"https://api.github.com/users/flipkart-incubator/followers","following_url":"https://api.github.com/users/flipkart-incubator/following{/other_user}","gists_url":"https://api.github.com/users/flipkart-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/flipkart-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flipkart-incubator/subscriptions","organizations_url":"https://api.github.com/users/flipkart-incubator/orgs","repos_url":"https://api.github.com/users/flipkart-incubator/repos","events_url":"https://api.github.com/users/flipkart-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/flipkart-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flipkart-incubator/zjsonpatch","description":"This is an implementation of RFC 6902 JSON Patch written in Java","fork":false,"url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch","forks_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/forks","keys_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/teams","hooks_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/hooks","issue_events_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/issues/events{/number}","events_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/events","assignees_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/assignees{/user}","branches_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/branches{/branch}","tags_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/tags","blobs_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/languages","stargazers_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/stargazers","contributors_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/contributors","subscribers_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/subscribers","subscription_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/subscription","commits_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/contents/{+path}","compare_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/merges","archive_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/downloads","issues_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/issues{/number}","pulls_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/labels{/name}","releases_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/releases{/id}","deployments_url":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/deployments","created_at":"2014-11-17T17:23:43Z","updated_at":"2017-07-14T12:33:57Z","pushed_at":"2017-07-24T04:05:30Z","git_url":"git://github.com/flipkart-incubator/zjsonpatch.git","ssh_url":"git@github.com:flipkart-incubator/zjsonpatch.git","clone_url":"https://github.com/flipkart-incubator/zjsonpatch.git","svn_url":"https://github.com/flipkart-incubator/zjsonpatch","homepage":"","size":109,"stargazers_count":126,"watchers_count":126,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":6,"forks":54,"open_issues":6,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43"},"html":{"href":"https://github.com/flipkart-incubator/zjsonpatch/pull/43"},"issue":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/issues/43"},"comments":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/flipkart-incubator/zjsonpatch/statuses/c7e6598716c256473b34444fca9bde78f7dda7a0"}}}}
{"actor":{"display_login":"vishwakarma"}}