{"action":"created","comment":{"url":"https://api.github.com/repos/ni/VireoSDK/pulls/comments/119448056","pull_request_review_id":41328112,"id":119448056,"diff_hunk":"@@ -1733,9 +1731,29 @@ VIREO_FUNCTION_SIGNATURE1(IsEQAccumulator, void)\n         while (ExecutionContext::IsNotCulDeSac(pInstruction)) {\n             pInstruction = _PROGMEM_PTR(pInstruction, _function)(pInstruction);\n             if (!*dest)\n-                return null;\n+                return true;\n         }\n     }\n+    return false;\n+}\n+//------------------------------------------------------------\n+// Accumulators are used for elements of an array and elements of a cluster\n+VIREO_FUNCTION_SIGNATURE1(IsEQAccumulator, void)\n+{\n+    BinaryCompareInstruction* binop = (BinaryCompareInstruction*)_ParamPointer(0);\n+    if (DoIsEQBinayCompareAccumulator(binop)) {\n+        return null;\n+    }\n+    return _this;\n+}\n+//------------------------------------------------------------\n+// Accumulators are used for elements of an array and elements of a cluster\n+VIREO_FUNCTION_SIGNATURE1(IsEQSearchAccumulator, void)\n+{\n+    BinaryCompareInstruction* binop = (BinaryCompareInstruction*)_ParamPointer(0);\n+    if (DoIsEQBinayCompareAccumulator(binop)) {\n+        return null;\n+    }","path":"source/core/GenericFunctions.cpp","position":38,"original_position":48,"commit_id":"e0b884dfded2c4436154ef08e1bf3a817968cfb5","original_commit_id":"e0b884dfded2c4436154ef08e1bf3a817968cfb5","user":{"login":"spathiwa","id":860388,"avatar_url":"https://avatars3.githubusercontent.com/u/860388?v=3","gravatar_id":"","url":"https://api.github.com/users/spathiwa","html_url":"https://github.com/spathiwa","followers_url":"https://api.github.com/users/spathiwa/followers","following_url":"https://api.github.com/users/spathiwa/following{/other_user}","gists_url":"https://api.github.com/users/spathiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/spathiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spathiwa/subscriptions","organizations_url":"https://api.github.com/users/spathiwa/orgs","repos_url":"https://api.github.com/users/spathiwa/repos","events_url":"https://api.github.com/users/spathiwa/events{/privacy}","received_events_url":"https://api.github.com/users/spathiwa/received_events","type":"User","site_admin":false},"body":"I don't think this wrap is necessary, see my other comment on LTSortAccumulator.\r\n","created_at":"2017-05-31T19:13:53Z","updated_at":"2017-05-31T19:15:28Z","html_url":"https://github.com/ni/VireoSDK/pull/278#discussion_r119448056","pull_request_url":"https://api.github.com/repos/ni/VireoSDK/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/comments/119448056"},"html":{"href":"https://github.com/ni/VireoSDK/pull/278#discussion_r119448056"},"pull_request":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/ni/VireoSDK/pulls/278","id":123345036,"html_url":"https://github.com/ni/VireoSDK/pull/278","diff_url":"https://github.com/ni/VireoSDK/pull/278.diff","patch_url":"https://github.com/ni/VireoSDK/pull/278.patch","issue_url":"https://api.github.com/repos/ni/VireoSDK/issues/278","number":278,"state":"open","locked":false,"title":"Fixes to Array defects","user":{"login":"cglzaguilar","id":8452083,"avatar_url":"https://avatars0.githubusercontent.com/u/8452083?v=3","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false},"body":"DE12861 Sort1DArray primitive incorrectly sorts NaN, -inf and inf\r\nDE12894 Search1DArray primitive doesn't find NaN\r\nDE12895 Threshold1DArray primitive doesn't work properly with Infinity, NaN and other cases","created_at":"2017-05-31T19:03:39Z","updated_at":"2017-05-31T19:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e933c4091efc7b617600dcd6cc59d1a04a59cf5e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sanmut","id":23344166,"avatar_url":"https://avatars1.githubusercontent.com/u/23344166?v=3","gravatar_id":"","url":"https://api.github.com/users/sanmut","html_url":"https://github.com/sanmut","followers_url":"https://api.github.com/users/sanmut/followers","following_url":"https://api.github.com/users/sanmut/following{/other_user}","gists_url":"https://api.github.com/users/sanmut/gists{/gist_id}","starred_url":"https://api.github.com/users/sanmut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanmut/subscriptions","organizations_url":"https://api.github.com/users/sanmut/orgs","repos_url":"https://api.github.com/users/sanmut/repos","events_url":"https://api.github.com/users/sanmut/events{/privacy}","received_events_url":"https://api.github.com/users/sanmut/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ni/VireoSDK/pulls/278/commits","review_comments_url":"https://api.github.com/repos/ni/VireoSDK/pulls/278/comments","review_comment_url":"https://api.github.com/repos/ni/VireoSDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ni/VireoSDK/issues/278/comments","statuses_url":"https://api.github.com/repos/ni/VireoSDK/statuses/e0b884dfded2c4436154ef08e1bf3a817968cfb5","head":{"label":"cglzaguilar:ArrayBugs2","ref":"ArrayBugs2","sha":"e0b884dfded2c4436154ef08e1bf3a817968cfb5","user":{"login":"cglzaguilar","id":8452083,"avatar_url":"https://avatars0.githubusercontent.com/u/8452083?v=3","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false},"repo":{"id":82117315,"name":"VireoSDK","full_name":"cglzaguilar/VireoSDK","owner":{"login":"cglzaguilar","id":8452083,"avatar_url":"https://avatars0.githubusercontent.com/u/8452083?v=3","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cglzaguilar/VireoSDK","description":"Compact runtime for a subset of LabVIEW","fork":true,"url":"https://api.github.com/repos/cglzaguilar/VireoSDK","forks_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/forks","keys_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/teams","hooks_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/hooks","issue_events_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/issues/events{/number}","events_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/events","assignees_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/assignees{/user}","branches_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/branches{/branch}","tags_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/tags","blobs_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/languages","stargazers_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/stargazers","contributors_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/contributors","subscribers_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/subscribers","subscription_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/subscription","commits_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/contents/{+path}","compare_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/merges","archive_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/downloads","issues_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/issues{/number}","pulls_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/labels{/name}","releases_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/releases{/id}","deployments_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/deployments","created_at":"2017-02-15T23:27:26Z","updated_at":"2017-02-15T23:27:30Z","pushed_at":"2017-05-31T19:01:51Z","git_url":"git://github.com/cglzaguilar/VireoSDK.git","ssh_url":"git@github.com:cglzaguilar/VireoSDK.git","clone_url":"https://github.com/cglzaguilar/VireoSDK.git","svn_url":"https://github.com/cglzaguilar/VireoSDK","homepage":"http://ni.github.io/VireoSDK/","size":23906,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"incoming"}},"base":{"label":"ni:incoming","ref":"incoming","sha":"886589753bbddd02adfa21c793d98b9fd0fa745f","user":{"login":"ni","id":5598284,"avatar_url":"https://avatars0.githubusercontent.com/u/5598284?v=3","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":18154590,"name":"VireoSDK","full_name":"ni/VireoSDK","owner":{"login":"ni","id":5598284,"avatar_url":"https://avatars0.githubusercontent.com/u/5598284?v=3","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/VireoSDK","description":"Compact runtime for a subset of LabVIEW","fork":false,"url":"https://api.github.com/repos/ni/VireoSDK","forks_url":"https://api.github.com/repos/ni/VireoSDK/forks","keys_url":"https://api.github.com/repos/ni/VireoSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/VireoSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/VireoSDK/teams","hooks_url":"https://api.github.com/repos/ni/VireoSDK/hooks","issue_events_url":"https://api.github.com/repos/ni/VireoSDK/issues/events{/number}","events_url":"https://api.github.com/repos/ni/VireoSDK/events","assignees_url":"https://api.github.com/repos/ni/VireoSDK/assignees{/user}","branches_url":"https://api.github.com/repos/ni/VireoSDK/branches{/branch}","tags_url":"https://api.github.com/repos/ni/VireoSDK/tags","blobs_url":"https://api.github.com/repos/ni/VireoSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/VireoSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/VireoSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/VireoSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/VireoSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/VireoSDK/languages","stargazers_url":"https://api.github.com/repos/ni/VireoSDK/stargazers","contributors_url":"https://api.github.com/repos/ni/VireoSDK/contributors","subscribers_url":"https://api.github.com/repos/ni/VireoSDK/subscribers","subscription_url":"https://api.github.com/repos/ni/VireoSDK/subscription","commits_url":"https://api.github.com/repos/ni/VireoSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/VireoSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/VireoSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/VireoSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/VireoSDK/contents/{+path}","compare_url":"https://api.github.com/repos/ni/VireoSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/VireoSDK/merges","archive_url":"https://api.github.com/repos/ni/VireoSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/VireoSDK/downloads","issues_url":"https://api.github.com/repos/ni/VireoSDK/issues{/number}","pulls_url":"https://api.github.com/repos/ni/VireoSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/VireoSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/VireoSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/VireoSDK/labels{/name}","releases_url":"https://api.github.com/repos/ni/VireoSDK/releases{/id}","deployments_url":"https://api.github.com/repos/ni/VireoSDK/deployments","created_at":"2014-03-26T21:30:22Z","updated_at":"2017-05-26T09:26:54Z","pushed_at":"2017-05-31T19:10:57Z","git_url":"git://github.com/ni/VireoSDK.git","ssh_url":"git@github.com:ni/VireoSDK.git","clone_url":"https://github.com/ni/VireoSDK.git","svn_url":"https://github.com/ni/VireoSDK","homepage":"http://ni.github.io/VireoSDK/","size":24468,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":27,"forks":13,"open_issues":27,"watchers":17,"default_branch":"incoming"}},"_links":{"self":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/278"},"html":{"href":"https://github.com/ni/VireoSDK/pull/278"},"issue":{"href":"https://api.github.com/repos/ni/VireoSDK/issues/278"},"comments":{"href":"https://api.github.com/repos/ni/VireoSDK/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/ni/VireoSDK/statuses/e0b884dfded2c4436154ef08e1bf3a817968cfb5"}}}}
{"actor":{"display_login":"spathiwa"}}