{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/144310493","pull_request_review_id":68944490,"id":144310493,"diff_hunk":"@@ -151,18 +157,30 @@\n \tsheetType = /obj/item/stack/sheet/mineral/silver\r\n \tmax_integrity = 300\r\n \r\n+/obj/structure/mineral_door/silver/Initialize()\r\n+\t. = ..()\r\n+\tAddComponent(/datum/component/rad_insulation, RAD_HEAVY_INSULATION)\r\n+\r\n /obj/structure/mineral_door/gold\r\n \tname = \"gold door\"\r\n \ticon_state = \"gold\"\r\n \tsheetType = /obj/item/stack/sheet/mineral/gold\r\n \r\n+/obj/structure/mineral_door/gold/Initialize()\r\n+\t. = ..()\r\n+\tAddComponent(/datum/component/rad_insulation, RAD_HEAVY_INSULATION)\r\n+\r\n /obj/structure/mineral_door/uranium\r\n \tname = \"uranium door\"\r\n \ticon_state = \"uranium\"\r\n \tsheetType = /obj/item/stack/sheet/mineral/uranium\r\n \tmax_integrity = 300\r\n \tlight_range = 2\r\n \r\n+/obj/structure/mineral_door/uranium/Initialize()\r\n+\t. = ..()\r\n+\tqdel(GetComponent(/datum/component/rad_insulation))\r","path":"code/game/objects/structures/mineral_doors.dm","position":39,"original_position":39,"commit_id":"9e2d63c1c5c2c8711900aabc4a87870436c4ab45","original_commit_id":"9e2d63c1c5c2c8711900aabc4a87870436c4ab45","user":{"login":"Cyberboss","id":8171642,"avatar_url":"https://avatars3.githubusercontent.com/u/8171642?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyberboss","html_url":"https://github.com/Cyberboss","followers_url":"https://api.github.com/users/Cyberboss/followers","following_url":"https://api.github.com/users/Cyberboss/following{/other_user}","gists_url":"https://api.github.com/users/Cyberboss/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyberboss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyberboss/subscriptions","organizations_url":"https://api.github.com/users/Cyberboss/orgs","repos_url":"https://api.github.com/users/Cyberboss/repos","events_url":"https://api.github.com/users/Cyberboss/events{/privacy}","received_events_url":"https://api.github.com/users/Cyberboss/received_events","type":"User","site_admin":false},"body":"Instead of deleting new components like this, Add a common proc that you just override for /uranium","created_at":"2017-10-12T14:42:46Z","updated_at":"2017-10-12T14:45:47Z","html_url":"https://github.com/tgstation/tgstation/pull/30909#discussion_r144310493","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/30909","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/144310493"},"html":{"href":"https://github.com/tgstation/tgstation/pull/30909#discussion_r144310493"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/30909"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/30909","id":142180985,"html_url":"https://github.com/tgstation/tgstation/pull/30909","diff_url":"https://github.com/tgstation/tgstation/pull/30909.diff","patch_url":"https://github.com/tgstation/tgstation/pull/30909.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/30909","number":30909,"state":"open","locked":false,"title":"Radiation rework and subsystem","user":{"login":"ninjanomnom","id":1234602,"avatar_url":"https://avatars3.githubusercontent.com/u/1234602?v=4","gravatar_id":"","url":"https://api.github.com/users/ninjanomnom","html_url":"https://github.com/ninjanomnom","followers_url":"https://api.github.com/users/ninjanomnom/followers","following_url":"https://api.github.com/users/ninjanomnom/following{/other_user}","gists_url":"https://api.github.com/users/ninjanomnom/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjanomnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjanomnom/subscriptions","organizations_url":"https://api.github.com/users/ninjanomnom/orgs","repos_url":"https://api.github.com/users/ninjanomnom/repos","events_url":"https://api.github.com/users/ninjanomnom/events{/privacy}","received_events_url":"https://api.github.com/users/ninjanomnom/received_events","type":"User","site_admin":false},"body":":cl: ninjanomnom\r\nrefactor: Radiation has been completely overhauled.\r\nadd: A new radiation subsystem and spreading mechanics.\r\nadd: Walls and other dense objects insulate you from radiation.\r\nadd: Geiger counters now store the last burst of radiation so you can view it at your leisure or show it to someone. Examine it.\r\nadd: Geiger counters can check mobs for contaminated objects. Scan yourself before you leave to make sure you aren't carrying dangerous radioactive items.\r\nsoundadd: Geiger counters have realistic sounds and the radiation pulse spam in chat has been replaced.\r\nbalance: Radiation is more deadly and causes burns at high intensities, WEAR YOUR RADSUITS.\r\nbalance: However residue radiation is far slower acting and kills you with toxin.\r\nbalance: Rad collectors are nerfed. No more supercharging with pressurized plasma. No more collector spam either.\r\nbalance: Engine output is a lot more stable as a result of collector changes.\r\nbalance: Monkeys need more rads and take more time to turn into gorillas.\r\ntweak: Over 100% on the DNA computer means your subject is now taking damage.\r\n/:cl:\r\n\r\nThe goal of this is to remove snowflake applications of radiation and make it act realistically. With this system radiation can be insulated and it also now obeys the inverse square law. Overall this is a buff to radiation.\r\n\r\nTODO:\r\n- [x] Write the basic systems\r\n- [x] Add radiation insulation to various turfs and structures\r\n- [x] Find and convert all snowflake usages of radiation damage\r\n- [x] Finish up radiation contamination\r\n- [x] Reduce resource usage (Might need to do more)\r\n- [x] Fix runtimes\r\n- [ ] Remap supermatter chambers (Will be done when the code is approved)\r\n- [x] Test and balance\r\n\r\nIssues:\r\n- [x] ~~The SM gas interactions don't work well with power scaling~~ Fixed with some tweaks\r\n- [x] ~~Contaminated tiles are building up rads when they shouldn't be~~ Bad use of log()\r\n- [x] ~~Figure out exactly why the range gets so high (more insulation maybe?)~~ See above\r\n- [x] ~~The high end is too high and the low end too low for mobs to handle well~~ Rewrote mob rad handling\r\n- [x] ~~Genetics radiation needs to be fixed~~ Rad damage is matched with the others\r\n- [x] ~~Mobs aren't getting toxin damage~~ Bad return","created_at":"2017-09-20T19:19:00Z","updated_at":"2017-10-12T14:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05c9a7f941fe1b1510f1456ab86df45f2be60682","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/tgstation/tgstation/milestones/24","html_url":"https://github.com/tgstation/tgstation/milestone/24","labels_url":"https://api.github.com/repos/tgstation/tgstation/milestones/24/labels","id":2440848,"number":24,"title":"Fuckup of the year 2017","description":"Here we learn from our mistakes. Or refuse to.","creator":{"login":"AnturK","id":4047233,"avatar_url":"https://avatars3.githubusercontent.com/u/4047233?v=4","gravatar_id":"","url":"https://api.github.com/users/AnturK","html_url":"https://github.com/AnturK","followers_url":"https://api.github.com/users/AnturK/followers","following_url":"https://api.github.com/users/AnturK/following{/other_user}","gists_url":"https://api.github.com/users/AnturK/gists{/gist_id}","starred_url":"https://api.github.com/users/AnturK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnturK/subscriptions","organizations_url":"https://api.github.com/users/AnturK/orgs","repos_url":"https://api.github.com/users/AnturK/repos","events_url":"https://api.github.com/users/AnturK/events{/privacy}","received_events_url":"https://api.github.com/users/AnturK/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2017-04-06T19:13:18Z","updated_at":"2017-10-06T18:57:33Z","due_on":"2017-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/30909/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/30909/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/30909/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/9e2d63c1c5c2c8711900aabc4a87870436c4ab45","head":{"label":"ninjanomnom:its-ya-boy-inverse-square-law","ref":"its-ya-boy-inverse-square-law","sha":"9e2d63c1c5c2c8711900aabc4a87870436c4ab45","user":{"login":"ninjanomnom","id":1234602,"avatar_url":"https://avatars3.githubusercontent.com/u/1234602?v=4","gravatar_id":"","url":"https://api.github.com/users/ninjanomnom","html_url":"https://github.com/ninjanomnom","followers_url":"https://api.github.com/users/ninjanomnom/followers","following_url":"https://api.github.com/users/ninjanomnom/following{/other_user}","gists_url":"https://api.github.com/users/ninjanomnom/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjanomnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjanomnom/subscriptions","organizations_url":"https://api.github.com/users/ninjanomnom/orgs","repos_url":"https://api.github.com/users/ninjanomnom/repos","events_url":"https://api.github.com/users/ninjanomnom/events{/privacy}","received_events_url":"https://api.github.com/users/ninjanomnom/received_events","type":"User","site_admin":false},"repo":{"id":89131271,"name":"tgstation","full_name":"ninjanomnom/tgstation","owner":{"login":"ninjanomnom","id":1234602,"avatar_url":"https://avatars3.githubusercontent.com/u/1234602?v=4","gravatar_id":"","url":"https://api.github.com/users/ninjanomnom","html_url":"https://github.com/ninjanomnom","followers_url":"https://api.github.com/users/ninjanomnom/followers","following_url":"https://api.github.com/users/ninjanomnom/following{/other_user}","gists_url":"https://api.github.com/users/ninjanomnom/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjanomnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjanomnom/subscriptions","organizations_url":"https://api.github.com/users/ninjanomnom/orgs","repos_url":"https://api.github.com/users/ninjanomnom/repos","events_url":"https://api.github.com/users/ninjanomnom/events{/privacy}","received_events_url":"https://api.github.com/users/ninjanomnom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ninjanomnom/tgstation","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/ninjanomnom/tgstation","forks_url":"https://api.github.com/repos/ninjanomnom/tgstation/forks","keys_url":"https://api.github.com/repos/ninjanomnom/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninjanomnom/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninjanomnom/tgstation/teams","hooks_url":"https://api.github.com/repos/ninjanomnom/tgstation/hooks","issue_events_url":"https://api.github.com/repos/ninjanomnom/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/ninjanomnom/tgstation/events","assignees_url":"https://api.github.com/repos/ninjanomnom/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/ninjanomnom/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/ninjanomnom/tgstation/tags","blobs_url":"https://api.github.com/repos/ninjanomnom/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninjanomnom/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninjanomnom/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninjanomnom/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninjanomnom/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/ninjanomnom/tgstation/languages","stargazers_url":"https://api.github.com/repos/ninjanomnom/tgstation/stargazers","contributors_url":"https://api.github.com/repos/ninjanomnom/tgstation/contributors","subscribers_url":"https://api.github.com/repos/ninjanomnom/tgstation/subscribers","subscription_url":"https://api.github.com/repos/ninjanomnom/tgstation/subscription","commits_url":"https://api.github.com/repos/ninjanomnom/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninjanomnom/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninjanomnom/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninjanomnom/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninjanomnom/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/ninjanomnom/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninjanomnom/tgstation/merges","archive_url":"https://api.github.com/repos/ninjanomnom/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninjanomnom/tgstation/downloads","issues_url":"https://api.github.com/repos/ninjanomnom/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/ninjanomnom/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/ninjanomnom/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/ninjanomnom/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninjanomnom/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/ninjanomnom/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/ninjanomnom/tgstation/deployments","created_at":"2017-04-23T09:34:37Z","updated_at":"2017-04-23T09:34:52Z","pushed_at":"2017-10-12T05:51:53Z","git_url":"git://github.com/ninjanomnom/tgstation.git","ssh_url":"git@github.com:ninjanomnom/tgstation.git","clone_url":"https://github.com/ninjanomnom/tgstation.git","svn_url":"https://github.com/ninjanomnom/tgstation","homepage":"http://www.tgstation13.org/","size":971992,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"6ac06d90d2d9602f8af05258ddd721d1d6a2a342","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2017-10-12T10:46:36Z","pushed_at":"2017-10-12T14:35:37Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":972679,"stargazers_count":412,"watchers_count":412,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1568,"mirror_url":null,"open_issues_count":965,"forks":1568,"open_issues":965,"watchers":412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/30909"},"html":{"href":"https://github.com/tgstation/tgstation/pull/30909"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/30909"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/30909/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/30909/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/30909/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/9e2d63c1c5c2c8711900aabc4a87870436c4ab45"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Cyberboss"}}