{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/113082581","pull_request_review_id":34444486,"id":113082581,"diff_hunk":"@@ -28,32 +28,62 @@ cdef class Receiver(object):\n   cpdef receive(self, WindowedValue windowed_value)\n \n \n+cdef class DoFnMethodWrapper(object):\n+  cdef public object args\n+  cdef public object defaults\n+  cdef public object method_value\n+\n+\n+cdef class DoFnSignature(object):\n+  cdef public DoFnMethodWrapper process_method\n+  cdef public DoFnMethodWrapper start_bundle_method\n+  cdef public DoFnMethodWrapper finish_bundle_method\n+  cdef public object do_fn\n+","path":"sdks/python/apache_beam/runners/common.pxd","position":15,"original_position":15,"commit_id":"808764c4a38282e717053eb0bf5a2a72c5519003","original_commit_id":"808764c4a38282e717053eb0bf5a2a72c5519003","user":{"login":"sb2nov","id":1517779,"avatar_url":"https://avatars1.githubusercontent.com/u/1517779?v=3","gravatar_id":"","url":"https://api.github.com/users/sb2nov","html_url":"https://github.com/sb2nov","followers_url":"https://api.github.com/users/sb2nov/followers","following_url":"https://api.github.com/users/sb2nov/following{/other_user}","gists_url":"https://api.github.com/users/sb2nov/gists{/gist_id}","starred_url":"https://api.github.com/users/sb2nov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sb2nov/subscriptions","organizations_url":"https://api.github.com/users/sb2nov/orgs","repos_url":"https://api.github.com/users/sb2nov/repos","events_url":"https://api.github.com/users/sb2nov/events{/privacy}","received_events_url":"https://api.github.com/users/sb2nov/received_events","type":"User","site_admin":false},"body":"Do validate functions need to be mentioned here","created_at":"2017-04-24T23:55:19Z","updated_at":"2017-04-24T23:57:08Z","html_url":"https://github.com/apache/beam/pull/2519#discussion_r113082581","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/2519","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/113082581"},"html":{"href":"https://github.com/apache/beam/pull/2519#discussion_r113082581"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/2519"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/2519","id":115660290,"html_url":"https://github.com/apache/beam/pull/2519","diff_url":"https://github.com/apache/beam/pull/2519.diff","patch_url":"https://github.com/apache/beam/pull/2519.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/2519","number":2519,"state":"open","locked":false,"title":"[BEAM-1925] Updates DoFn invocation logic to be more extensible.","user":{"login":"chamikaramj","id":10819857,"avatar_url":"https://avatars0.githubusercontent.com/u/10819857?v=3","gravatar_id":"","url":"https://api.github.com/users/chamikaramj","html_url":"https://github.com/chamikaramj","followers_url":"https://api.github.com/users/chamikaramj/followers","following_url":"https://api.github.com/users/chamikaramj/following{/other_user}","gists_url":"https://api.github.com/users/chamikaramj/gists{/gist_id}","starred_url":"https://api.github.com/users/chamikaramj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamikaramj/subscriptions","organizations_url":"https://api.github.com/users/chamikaramj/orgs","repos_url":"https://api.github.com/users/chamikaramj/repos","events_url":"https://api.github.com/users/chamikaramj/events{/privacy}","received_events_url":"https://api.github.com/users/chamikaramj/received_events","type":"User","site_admin":false},"body":"Adds following abstractions.\r\n\r\nDoFnSignature: describes the signature of a given DoFn object.\r\nDoFnInvoker: defines a particular way for invoking DoFn methods.\r\n\r\nI believe existing tests cover the updated code paths.","created_at":"2017-04-13T00:04:29Z","updated_at":"2017-04-24T23:57:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c78a2bb2f234326fb7939b2c46252ca97b8222","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/2519/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/2519/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/2519/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/808764c4a38282e717053eb0bf5a2a72c5519003","head":{"label":"chamikaramj:sdf_direct_runner2","ref":"sdf_direct_runner2","sha":"808764c4a38282e717053eb0bf5a2a72c5519003","user":{"login":"chamikaramj","id":10819857,"avatar_url":"https://avatars0.githubusercontent.com/u/10819857?v=3","gravatar_id":"","url":"https://api.github.com/users/chamikaramj","html_url":"https://github.com/chamikaramj","followers_url":"https://api.github.com/users/chamikaramj/followers","following_url":"https://api.github.com/users/chamikaramj/following{/other_user}","gists_url":"https://api.github.com/users/chamikaramj/gists{/gist_id}","starred_url":"https://api.github.com/users/chamikaramj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamikaramj/subscriptions","organizations_url":"https://api.github.com/users/chamikaramj/orgs","repos_url":"https://api.github.com/users/chamikaramj/repos","events_url":"https://api.github.com/users/chamikaramj/events{/privacy}","received_events_url":"https://api.github.com/users/chamikaramj/received_events","type":"User","site_admin":false},"repo":{"id":61584074,"name":"beam","full_name":"chamikaramj/beam","owner":{"login":"chamikaramj","id":10819857,"avatar_url":"https://avatars0.githubusercontent.com/u/10819857?v=3","gravatar_id":"","url":"https://api.github.com/users/chamikaramj","html_url":"https://github.com/chamikaramj","followers_url":"https://api.github.com/users/chamikaramj/followers","following_url":"https://api.github.com/users/chamikaramj/following{/other_user}","gists_url":"https://api.github.com/users/chamikaramj/gists{/gist_id}","starred_url":"https://api.github.com/users/chamikaramj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamikaramj/subscriptions","organizations_url":"https://api.github.com/users/chamikaramj/orgs","repos_url":"https://api.github.com/users/chamikaramj/repos","events_url":"https://api.github.com/users/chamikaramj/events{/privacy}","received_events_url":"https://api.github.com/users/chamikaramj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chamikaramj/beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/chamikaramj/beam","forks_url":"https://api.github.com/repos/chamikaramj/beam/forks","keys_url":"https://api.github.com/repos/chamikaramj/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chamikaramj/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chamikaramj/beam/teams","hooks_url":"https://api.github.com/repos/chamikaramj/beam/hooks","issue_events_url":"https://api.github.com/repos/chamikaramj/beam/issues/events{/number}","events_url":"https://api.github.com/repos/chamikaramj/beam/events","assignees_url":"https://api.github.com/repos/chamikaramj/beam/assignees{/user}","branches_url":"https://api.github.com/repos/chamikaramj/beam/branches{/branch}","tags_url":"https://api.github.com/repos/chamikaramj/beam/tags","blobs_url":"https://api.github.com/repos/chamikaramj/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chamikaramj/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chamikaramj/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/chamikaramj/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chamikaramj/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/chamikaramj/beam/languages","stargazers_url":"https://api.github.com/repos/chamikaramj/beam/stargazers","contributors_url":"https://api.github.com/repos/chamikaramj/beam/contributors","subscribers_url":"https://api.github.com/repos/chamikaramj/beam/subscribers","subscription_url":"https://api.github.com/repos/chamikaramj/beam/subscription","commits_url":"https://api.github.com/repos/chamikaramj/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/chamikaramj/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/chamikaramj/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/chamikaramj/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/chamikaramj/beam/contents/{+path}","compare_url":"https://api.github.com/repos/chamikaramj/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chamikaramj/beam/merges","archive_url":"https://api.github.com/repos/chamikaramj/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chamikaramj/beam/downloads","issues_url":"https://api.github.com/repos/chamikaramj/beam/issues{/number}","pulls_url":"https://api.github.com/repos/chamikaramj/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/chamikaramj/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/chamikaramj/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chamikaramj/beam/labels{/name}","releases_url":"https://api.github.com/repos/chamikaramj/beam/releases{/id}","deployments_url":"https://api.github.com/repos/chamikaramj/beam/deployments","created_at":"2016-06-20T22:15:27Z","updated_at":"2017-01-26T21:29:16Z","pushed_at":"2017-04-24T22:14:32Z","git_url":"git://github.com/chamikaramj/beam.git","ssh_url":"git@github.com:chamikaramj/beam.git","clone_url":"https://github.com/chamikaramj/beam.git","svn_url":"https://github.com/chamikaramj/beam","homepage":null,"size":32495,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"781c15522d188c461e991515173304b94b1190ae","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Mirror of Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2017-04-23T23:06:08Z","pushed_at":"2017-04-24T23:46:42Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":32915,"stargazers_count":1096,"watchers_count":1096,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":596,"mirror_url":"git://git.apache.org/beam.git","open_issues_count":76,"forks":596,"open_issues":76,"watchers":1096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/2519"},"html":{"href":"https://github.com/apache/beam/pull/2519"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/2519"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/2519/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/2519/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/2519/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/808764c4a38282e717053eb0bf5a2a72c5519003"}}}}
{"actor":{"display_login":"sb2nov"}}