{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/154057673","pull_request_review_id":80161204,"id":154057673,"diff_hunk":"@@ -121,7 +121,6 @@ describe('GGRC.Components.editablePeopleGroup', function () {\n     });\n \n     it('should return full list when showPeopleGroupModal is false', () => {\n-      debugger;","path":"src/ggrc/assets/javascripts/components/people/tests/editable-people-group_spec.js","position":null,"original_position":4,"commit_id":"4706d74bd6edec04328046a95297ed22fa04c7ef","original_commit_id":"eae5007610c33bf32bee1ee4f2810f32043565fc","user":{"login":"tor4","id":3773902,"avatar_url":"https://avatars2.githubusercontent.com/u/3773902?v=4","gravatar_id":"","url":"https://api.github.com/users/tor4","html_url":"https://github.com/tor4","followers_url":"https://api.github.com/users/tor4/followers","following_url":"https://api.github.com/users/tor4/following{/other_user}","gists_url":"https://api.github.com/users/tor4/gists{/gist_id}","starred_url":"https://api.github.com/users/tor4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tor4/subscriptions","organizations_url":"https://api.github.com/users/tor4/orgs","repos_url":"https://api.github.com/users/tor4/repos","events_url":"https://api.github.com/users/tor4/events{/privacy}","received_events_url":"https://api.github.com/users/tor4/received_events","type":"User","site_admin":false},"body":"Removed in another PR.","created_at":"2017-11-30T12:09:30Z","updated_at":"2017-11-30T12:09:30Z","html_url":"https://github.com/google/ggrc-core/pull/6850#discussion_r154057673","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/6850","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/154057673"},"html":{"href":"https://github.com/google/ggrc-core/pull/6850#discussion_r154057673"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6850"}},"in_reply_to_id":153502250},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/6850","id":154758214,"html_url":"https://github.com/google/ggrc-core/pull/6850","diff_url":"https://github.com/google/ggrc-core/pull/6850.diff","patch_url":"https://github.com/google/ggrc-core/pull/6850.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/6850","number":6850,"state":"open","locked":false,"title":"GGRC-3902 Highlight GCA changes in revisions compare modal","user":{"login":"tor4","id":3773902,"avatar_url":"https://avatars2.githubusercontent.com/u/3773902?v=4","gravatar_id":"","url":"https://api.github.com/users/tor4","html_url":"https://github.com/tor4","followers_url":"https://api.github.com/users/tor4/followers","following_url":"https://api.github.com/users/tor4/following{/other_user}","gists_url":"https://api.github.com/users/tor4/gists{/gist_id}","starred_url":"https://api.github.com/users/tor4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tor4/subscriptions","organizations_url":"https://api.github.com/users/tor4/orgs","repos_url":"https://api.github.com/users/tor4/repos","events_url":"https://api.github.com/users/tor4/events{/privacy}","received_events_url":"https://api.github.com/users/tor4/received_events","type":"User","site_admin":false},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\nGCA changes are not highlighted in revisions compare modal.\r\n\r\n# Steps to test the changes\r\n\r\n1. Have audit with snapshot\r\n2. Update original for snapshot object\r\n3. Open revisions compare modal\r\n\r\n# Solution description\r\n\r\nComparing didn't work because of changes in markup. Update GCAs comparing logic.\r\n\r\n# Sanity checklist\r\n\r\n- [x] I have clicked through the app to make sure my changes work and not break the app.\r\n- [x] I have applied the correct milestone and labels.\r\n- [x] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [x] My changes are covered by tests.\r\n- [x] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] db_reset runs without errors or warnings.\r\n- [ ] db_reset ggrc-qa.sql runs without errors or warnings.\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [ ] Labels and milestone are correctly set.\r\n- [ ] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [ ] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2017-11-27T09:20:00Z","updated_at":"2017-11-30T12:09:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93cf38c13e3c6bd1d11b3904181c52adde8203ab","assignee":{"login":"YuriChupyrkin","id":4204416,"avatar_url":"https://avatars0.githubusercontent.com/u/4204416?v=4","gravatar_id":"","url":"https://api.github.com/users/YuriChupyrkin","html_url":"https://github.com/YuriChupyrkin","followers_url":"https://api.github.com/users/YuriChupyrkin/followers","following_url":"https://api.github.com/users/YuriChupyrkin/following{/other_user}","gists_url":"https://api.github.com/users/YuriChupyrkin/gists{/gist_id}","starred_url":"https://api.github.com/users/YuriChupyrkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuriChupyrkin/subscriptions","organizations_url":"https://api.github.com/users/YuriChupyrkin/orgs","repos_url":"https://api.github.com/users/YuriChupyrkin/repos","events_url":"https://api.github.com/users/YuriChupyrkin/events{/privacy}","received_events_url":"https://api.github.com/users/YuriChupyrkin/received_events","type":"User","site_admin":false},"assignees":[{"login":"YuriChupyrkin","id":4204416,"avatar_url":"https://avatars0.githubusercontent.com/u/4204416?v=4","gravatar_id":"","url":"https://api.github.com/users/YuriChupyrkin","html_url":"https://github.com/YuriChupyrkin","followers_url":"https://api.github.com/users/YuriChupyrkin/followers","following_url":"https://api.github.com/users/YuriChupyrkin/following{/other_user}","gists_url":"https://api.github.com/users/YuriChupyrkin/gists{/gist_id}","starred_url":"https://api.github.com/users/YuriChupyrkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuriChupyrkin/subscriptions","organizations_url":"https://api.github.com/users/YuriChupyrkin/orgs","repos_url":"https://api.github.com/users/YuriChupyrkin/repos","events_url":"https://api.github.com/users/YuriChupyrkin/events{/privacy}","received_events_url":"https://api.github.com/users/YuriChupyrkin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/71","html_url":"https://github.com/google/ggrc-core/milestone/71","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/71/labels","id":2928889,"number":71,"title":"0.10.37-Raspberry","description":"","creator":{"login":"alieh-rymasheuski","id":9883236,"avatar_url":"https://avatars2.githubusercontent.com/u/9883236?v=4","gravatar_id":"","url":"https://api.github.com/users/alieh-rymasheuski","html_url":"https://github.com/alieh-rymasheuski","followers_url":"https://api.github.com/users/alieh-rymasheuski/followers","following_url":"https://api.github.com/users/alieh-rymasheuski/following{/other_user}","gists_url":"https://api.github.com/users/alieh-rymasheuski/gists{/gist_id}","starred_url":"https://api.github.com/users/alieh-rymasheuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alieh-rymasheuski/subscriptions","organizations_url":"https://api.github.com/users/alieh-rymasheuski/orgs","repos_url":"https://api.github.com/users/alieh-rymasheuski/repos","events_url":"https://api.github.com/users/alieh-rymasheuski/events{/privacy}","received_events_url":"https://api.github.com/users/alieh-rymasheuski/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":30,"state":"open","created_at":"2017-11-21T17:02:40Z","updated_at":"2017-11-30T10:11:53Z","due_on":"2017-12-19T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/6850/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/6850/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/6850/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/4706d74bd6edec04328046a95297ed22fa04c7ef","head":{"label":"tor4:GGRC-3902","ref":"GGRC-3902","sha":"4706d74bd6edec04328046a95297ed22fa04c7ef","user":{"login":"tor4","id":3773902,"avatar_url":"https://avatars2.githubusercontent.com/u/3773902?v=4","gravatar_id":"","url":"https://api.github.com/users/tor4","html_url":"https://github.com/tor4","followers_url":"https://api.github.com/users/tor4/followers","following_url":"https://api.github.com/users/tor4/following{/other_user}","gists_url":"https://api.github.com/users/tor4/gists{/gist_id}","starred_url":"https://api.github.com/users/tor4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tor4/subscriptions","organizations_url":"https://api.github.com/users/tor4/orgs","repos_url":"https://api.github.com/users/tor4/repos","events_url":"https://api.github.com/users/tor4/events{/privacy}","received_events_url":"https://api.github.com/users/tor4/received_events","type":"User","site_admin":false},"repo":{"id":96882769,"name":"ggrc-core","full_name":"tor4/ggrc-core","owner":{"login":"tor4","id":3773902,"avatar_url":"https://avatars2.githubusercontent.com/u/3773902?v=4","gravatar_id":"","url":"https://api.github.com/users/tor4","html_url":"https://github.com/tor4","followers_url":"https://api.github.com/users/tor4/followers","following_url":"https://api.github.com/users/tor4/following{/other_user}","gists_url":"https://api.github.com/users/tor4/gists{/gist_id}","starred_url":"https://api.github.com/users/tor4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tor4/subscriptions","organizations_url":"https://api.github.com/users/tor4/orgs","repos_url":"https://api.github.com/users/tor4/repos","events_url":"https://api.github.com/users/tor4/events{/privacy}","received_events_url":"https://api.github.com/users/tor4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tor4/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/tor4/ggrc-core","forks_url":"https://api.github.com/repos/tor4/ggrc-core/forks","keys_url":"https://api.github.com/repos/tor4/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tor4/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tor4/ggrc-core/teams","hooks_url":"https://api.github.com/repos/tor4/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/tor4/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/tor4/ggrc-core/events","assignees_url":"https://api.github.com/repos/tor4/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/tor4/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/tor4/ggrc-core/tags","blobs_url":"https://api.github.com/repos/tor4/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tor4/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tor4/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tor4/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tor4/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/tor4/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/tor4/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/tor4/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/tor4/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/tor4/ggrc-core/subscription","commits_url":"https://api.github.com/repos/tor4/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tor4/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tor4/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tor4/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tor4/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/tor4/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tor4/ggrc-core/merges","archive_url":"https://api.github.com/repos/tor4/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tor4/ggrc-core/downloads","issues_url":"https://api.github.com/repos/tor4/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/tor4/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/tor4/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/tor4/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tor4/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/tor4/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/tor4/ggrc-core/deployments","created_at":"2017-07-11T10:46:45Z","updated_at":"2017-07-11T10:46:52Z","pushed_at":"2017-11-30T11:35:47Z","git_url":"git://github.com/tor4/ggrc-core.git","ssh_url":"git@github.com:tor4/ggrc-core.git","clone_url":"https://github.com/tor4/ggrc-core.git","svn_url":"https://github.com/tor4/ggrc-core","homepage":null,"size":68502,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"google:dev","ref":"dev","sha":"a4883a7b37206dbe7271c27ece23870fda2feeee","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2017-11-28T20:48:42Z","pushed_at":"2017-11-30T11:35:49Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":70911,"stargazers_count":242,"watchers_count":242,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":171,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":171,"open_issues":46,"watchers":242,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6850"},"html":{"href":"https://github.com/google/ggrc-core/pull/6850"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/6850"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/6850/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6850/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6850/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/4706d74bd6edec04328046a95297ed22fa04c7ef"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tor4"}}