{"action":"created","comment":{"url":"https://api.github.com/repos/getkirby/toolkit/pulls/comments/119935250","pull_request_review_id":41864482,"id":119935250,"diff_hunk":"@@ -155,7 +155,15 @@ protected function header($curl, $header) {\n \n     if(!empty($parts[0]) && !empty($parts[1])) {\n       $key = array_shift($parts);\n-      $this->headers[$key] = implode(':', $parts);\n+\n+      if (empty($this->headers[$key])) {","path":"lib/remote.php","position":6,"original_position":6,"commit_id":"4192ee4ac3f00d4b5d3eb370fb889ca4363c965c","original_commit_id":"4192ee4ac3f00d4b5d3eb370fb889ca4363c965c","user":{"login":"lukasbestle","id":1595007,"avatar_url":"https://avatars3.githubusercontent.com/u/1595007?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasbestle","html_url":"https://github.com/lukasbestle","followers_url":"https://api.github.com/users/lukasbestle/followers","following_url":"https://api.github.com/users/lukasbestle/following{/other_user}","gists_url":"https://api.github.com/users/lukasbestle/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasbestle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasbestle/subscriptions","organizations_url":"https://api.github.com/users/lukasbestle/orgs","repos_url":"https://api.github.com/users/lukasbestle/repos","events_url":"https://api.github.com/users/lukasbestle/events{/privacy}","received_events_url":"https://api.github.com/users/lukasbestle/received_events","type":"User","site_admin":false},"body":"Please use `!isset()` here. `empty()` behaves quite strangely.","created_at":"2017-06-02T19:30:19Z","updated_at":"2017-06-02T19:31:09Z","html_url":"https://github.com/getkirby/toolkit/pull/237#discussion_r119935250","pull_request_url":"https://api.github.com/repos/getkirby/toolkit/pulls/237","_links":{"self":{"href":"https://api.github.com/repos/getkirby/toolkit/pulls/comments/119935250"},"html":{"href":"https://github.com/getkirby/toolkit/pull/237#discussion_r119935250"},"pull_request":{"href":"https://api.github.com/repos/getkirby/toolkit/pulls/237"}}},"pull_request":{"url":"https://api.github.com/repos/getkirby/toolkit/pulls/237","id":123001749,"html_url":"https://github.com/getkirby/toolkit/pull/237","diff_url":"https://github.com/getkirby/toolkit/pull/237.diff","patch_url":"https://github.com/getkirby/toolkit/pull/237.patch","issue_url":"https://api.github.com/repos/getkirby/toolkit/issues/237","number":237,"state":"open","locked":false,"title":"Return duplicade HTTP header fields in remote as array.","user":{"login":"Zegnat","id":490579,"avatar_url":"https://avatars3.githubusercontent.com/u/490579?v=3","gravatar_id":"","url":"https://api.github.com/users/Zegnat","html_url":"https://github.com/Zegnat","followers_url":"https://api.github.com/users/Zegnat/followers","following_url":"https://api.github.com/users/Zegnat/following{/other_user}","gists_url":"https://api.github.com/users/Zegnat/gists{/gist_id}","starred_url":"https://api.github.com/users/Zegnat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zegnat/subscriptions","organizations_url":"https://api.github.com/users/Zegnat/orgs","repos_url":"https://api.github.com/users/Zegnat/repos","events_url":"https://api.github.com/users/Zegnat/events{/privacy}","received_events_url":"https://api.github.com/users/Zegnat/received_events","type":"User","site_admin":false},"body":"Fixes #234 per discussion in #235. No header field name normalisation,\r\nbut no more loss of data.","created_at":"2017-05-30T09:01:16Z","updated_at":"2017-06-02T19:31:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31501e415931dafd97e37fa4272b76f04e6feab4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/getkirby/toolkit/pulls/237/commits","review_comments_url":"https://api.github.com/repos/getkirby/toolkit/pulls/237/comments","review_comment_url":"https://api.github.com/repos/getkirby/toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getkirby/toolkit/issues/237/comments","statuses_url":"https://api.github.com/repos/getkirby/toolkit/statuses/4192ee4ac3f00d4b5d3eb370fb889ca4363c965c","head":{"label":"Zegnat:remote-headers-array","ref":"remote-headers-array","sha":"4192ee4ac3f00d4b5d3eb370fb889ca4363c965c","user":{"login":"Zegnat","id":490579,"avatar_url":"https://avatars3.githubusercontent.com/u/490579?v=3","gravatar_id":"","url":"https://api.github.com/users/Zegnat","html_url":"https://github.com/Zegnat","followers_url":"https://api.github.com/users/Zegnat/followers","following_url":"https://api.github.com/users/Zegnat/following{/other_user}","gists_url":"https://api.github.com/users/Zegnat/gists{/gist_id}","starred_url":"https://api.github.com/users/Zegnat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zegnat/subscriptions","organizations_url":"https://api.github.com/users/Zegnat/orgs","repos_url":"https://api.github.com/users/Zegnat/repos","events_url":"https://api.github.com/users/Zegnat/events{/privacy}","received_events_url":"https://api.github.com/users/Zegnat/received_events","type":"User","site_admin":false},"repo":{"id":75460930,"name":"toolkit","full_name":"Zegnat/toolkit","owner":{"login":"Zegnat","id":490579,"avatar_url":"https://avatars3.githubusercontent.com/u/490579?v=3","gravatar_id":"","url":"https://api.github.com/users/Zegnat","html_url":"https://github.com/Zegnat","followers_url":"https://api.github.com/users/Zegnat/followers","following_url":"https://api.github.com/users/Zegnat/following{/other_user}","gists_url":"https://api.github.com/users/Zegnat/gists{/gist_id}","starred_url":"https://api.github.com/users/Zegnat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zegnat/subscriptions","organizations_url":"https://api.github.com/users/Zegnat/orgs","repos_url":"https://api.github.com/users/Zegnat/repos","events_url":"https://api.github.com/users/Zegnat/events{/privacy}","received_events_url":"https://api.github.com/users/Zegnat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zegnat/toolkit","description":"The Kirby toolkit","fork":true,"url":"https://api.github.com/repos/Zegnat/toolkit","forks_url":"https://api.github.com/repos/Zegnat/toolkit/forks","keys_url":"https://api.github.com/repos/Zegnat/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zegnat/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zegnat/toolkit/teams","hooks_url":"https://api.github.com/repos/Zegnat/toolkit/hooks","issue_events_url":"https://api.github.com/repos/Zegnat/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/Zegnat/toolkit/events","assignees_url":"https://api.github.com/repos/Zegnat/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/Zegnat/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/Zegnat/toolkit/tags","blobs_url":"https://api.github.com/repos/Zegnat/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zegnat/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zegnat/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zegnat/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zegnat/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Zegnat/toolkit/languages","stargazers_url":"https://api.github.com/repos/Zegnat/toolkit/stargazers","contributors_url":"https://api.github.com/repos/Zegnat/toolkit/contributors","subscribers_url":"https://api.github.com/repos/Zegnat/toolkit/subscribers","subscription_url":"https://api.github.com/repos/Zegnat/toolkit/subscription","commits_url":"https://api.github.com/repos/Zegnat/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zegnat/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zegnat/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zegnat/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zegnat/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/Zegnat/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zegnat/toolkit/merges","archive_url":"https://api.github.com/repos/Zegnat/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zegnat/toolkit/downloads","issues_url":"https://api.github.com/repos/Zegnat/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/Zegnat/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Zegnat/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Zegnat/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zegnat/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/Zegnat/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/Zegnat/toolkit/deployments","created_at":"2016-12-03T08:06:49Z","updated_at":"2016-12-03T08:06:50Z","pushed_at":"2017-05-30T09:01:23Z","git_url":"git://github.com/Zegnat/toolkit.git","ssh_url":"git@github.com:Zegnat/toolkit.git","clone_url":"https://github.com/Zegnat/toolkit.git","svn_url":"https://github.com/Zegnat/toolkit","homepage":"http://getkirby.com","size":561,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"getkirby:master","ref":"master","sha":"97ec59f2ccdac789f15188bfbd67e2484beca3f6","user":{"login":"getkirby","id":6985611,"avatar_url":"https://avatars2.githubusercontent.com/u/6985611?v=3","gravatar_id":"","url":"https://api.github.com/users/getkirby","html_url":"https://github.com/getkirby","followers_url":"https://api.github.com/users/getkirby/followers","following_url":"https://api.github.com/users/getkirby/following{/other_user}","gists_url":"https://api.github.com/users/getkirby/gists{/gist_id}","starred_url":"https://api.github.com/users/getkirby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getkirby/subscriptions","organizations_url":"https://api.github.com/users/getkirby/orgs","repos_url":"https://api.github.com/users/getkirby/repos","events_url":"https://api.github.com/users/getkirby/events{/privacy}","received_events_url":"https://api.github.com/users/getkirby/received_events","type":"Organization","site_admin":false},"repo":{"id":17861131,"name":"toolkit","full_name":"getkirby/toolkit","owner":{"login":"getkirby","id":6985611,"avatar_url":"https://avatars2.githubusercontent.com/u/6985611?v=3","gravatar_id":"","url":"https://api.github.com/users/getkirby","html_url":"https://github.com/getkirby","followers_url":"https://api.github.com/users/getkirby/followers","following_url":"https://api.github.com/users/getkirby/following{/other_user}","gists_url":"https://api.github.com/users/getkirby/gists{/gist_id}","starred_url":"https://api.github.com/users/getkirby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getkirby/subscriptions","organizations_url":"https://api.github.com/users/getkirby/orgs","repos_url":"https://api.github.com/users/getkirby/repos","events_url":"https://api.github.com/users/getkirby/events{/privacy}","received_events_url":"https://api.github.com/users/getkirby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getkirby/toolkit","description":"The Kirby toolkit","fork":false,"url":"https://api.github.com/repos/getkirby/toolkit","forks_url":"https://api.github.com/repos/getkirby/toolkit/forks","keys_url":"https://api.github.com/repos/getkirby/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getkirby/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getkirby/toolkit/teams","hooks_url":"https://api.github.com/repos/getkirby/toolkit/hooks","issue_events_url":"https://api.github.com/repos/getkirby/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/getkirby/toolkit/events","assignees_url":"https://api.github.com/repos/getkirby/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/getkirby/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/getkirby/toolkit/tags","blobs_url":"https://api.github.com/repos/getkirby/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getkirby/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getkirby/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/getkirby/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getkirby/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/getkirby/toolkit/languages","stargazers_url":"https://api.github.com/repos/getkirby/toolkit/stargazers","contributors_url":"https://api.github.com/repos/getkirby/toolkit/contributors","subscribers_url":"https://api.github.com/repos/getkirby/toolkit/subscribers","subscription_url":"https://api.github.com/repos/getkirby/toolkit/subscription","commits_url":"https://api.github.com/repos/getkirby/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/getkirby/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/getkirby/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/getkirby/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/getkirby/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/getkirby/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getkirby/toolkit/merges","archive_url":"https://api.github.com/repos/getkirby/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getkirby/toolkit/downloads","issues_url":"https://api.github.com/repos/getkirby/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/getkirby/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/getkirby/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/getkirby/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getkirby/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/getkirby/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/getkirby/toolkit/deployments","created_at":"2014-03-18T09:59:11Z","updated_at":"2017-05-09T10:51:23Z","pushed_at":"2017-05-30T09:01:17Z","git_url":"git://github.com/getkirby/toolkit.git","ssh_url":"git@github.com:getkirby/toolkit.git","clone_url":"https://github.com/getkirby/toolkit.git","svn_url":"https://github.com/getkirby/toolkit","homepage":"http://getkirby.com","size":592,"stargazers_count":73,"watchers_count":73,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":27,"forks":58,"open_issues":27,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getkirby/toolkit/pulls/237"},"html":{"href":"https://github.com/getkirby/toolkit/pull/237"},"issue":{"href":"https://api.github.com/repos/getkirby/toolkit/issues/237"},"comments":{"href":"https://api.github.com/repos/getkirby/toolkit/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/getkirby/toolkit/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/getkirby/toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getkirby/toolkit/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/getkirby/toolkit/statuses/4192ee4ac3f00d4b5d3eb370fb889ca4363c965c"}}}}
{"actor":{"display_login":"lukasbestle"}}