{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/justinsheehy/vertree/pulls/4","id":100181916,"html_url":"https://github.com/justinsheehy/vertree/pull/4","diff_url":"https://github.com/justinsheehy/vertree/pull/4.diff","patch_url":"https://github.com/justinsheehy/vertree/pull/4.patch","issue_url":"https://api.github.com/repos/justinsheehy/vertree/issues/4","number":4,"state":"closed","locked":false,"title":"Add multi-cas support and a bunch of other stuff","user":{"login":"andrewjstone","id":466937,"avatar_url":"https://avatars.githubusercontent.com/u/466937?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewjstone","html_url":"https://github.com/andrewjstone","followers_url":"https://api.github.com/users/andrewjstone/followers","following_url":"https://api.github.com/users/andrewjstone/following{/other_user}","gists_url":"https://api.github.com/users/andrewjstone/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewjstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewjstone/subscriptions","organizations_url":"https://api.github.com/users/andrewjstone/orgs","repos_url":"https://api.github.com/users/andrewjstone/repos","events_url":"https://api.github.com/users/andrewjstone/events{/privacy}","received_events_url":"https://api.github.com/users/andrewjstone/received_events","type":"User","site_admin":false},"body":"Fix build: Remove serde and quickcheck_macros\r\nAdd Delete operation and verify path for all ops\r\n\r\nRemove all uses of RefCell\r\n\r\nRefCell was used to provide \"interior mutability\" to Nodes, so that\r\ndurin COW operations such as insert, delete, etc.. the newly created\r\nnodes could be mutated such that children could be linked to their\r\nparents. This allows maintaining logical immutability of the tree while\r\nstill allowing mutation during construction.\r\n\r\nHowever, using RefCell makes the tree `!Sync`, meaning that it can't be\r\ntransferred across threads. This is unnacceptable since the tree is\r\nlogically immutable and one of the main purposes of a COW tree is that\r\nit can be safely shared across threads for reads.\r\n\r\nThe `!Sync` issue could be fixed by explicitly declaring the tree `Sync`\r\nand overriding the compiler. It's unclear to me what consequences this\r\nwould have, although it's likely safe.\r\n\r\nAlternatively, RefCell could just be removed altogether and replaced\r\nwith unsafe code during tree construction. Due to the fact that RefCell\r\nwas not enough to replace all uses of unsafe code (specifically during\r\nmutable iteration), and it already was somewhat prevelant in the\r\ncodebase, this was the solution I chose. This also has the side effect\r\nof removing all the obfuscating `.borrow()` calls in the same functions\r\ncontaining unsafe code.\r\n\r\nRemove extra path validations, fix bug in tree.find\r\n\r\nAdd a property based test for tree.find and PathIter\r\n\r\nFix PathIter and set operations\r\n\r\nEnsure PathIter can iterate over nodes at the same level in the tree when the\r\npath of one node is a prefix of the path of another.\r\n\r\nSet Intersection, difference, and symmetric difference aren't actually\r\ncommutative. Change the signature to only accept to paths.\r\n\r\nAdd `Empty` Value","created_at":"2017-01-04T20:21:27Z","updated_at":"2017-01-04T20:38:05Z","closed_at":"2017-01-04T20:38:05Z","merged_at":"2017-01-04T20:38:05Z","merge_commit_sha":"c0a5a94b02d21c0141f580053ae3e5a4fe4f15a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/justinsheehy/vertree/pulls/4/commits","review_comments_url":"https://api.github.com/repos/justinsheehy/vertree/pulls/4/comments","review_comment_url":"https://api.github.com/repos/justinsheehy/vertree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/justinsheehy/vertree/issues/4/comments","statuses_url":"https://api.github.com/repos/justinsheehy/vertree/statuses/4592e025589e455e246d31d2c9661405920e258f","head":{"label":"justinsheehy:CAS_and_Transactions","ref":"CAS_and_Transactions","sha":"4592e025589e455e246d31d2c9661405920e258f","user":{"login":"justinsheehy","id":72740,"avatar_url":"https://avatars.githubusercontent.com/u/72740?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsheehy","html_url":"https://github.com/justinsheehy","followers_url":"https://api.github.com/users/justinsheehy/followers","following_url":"https://api.github.com/users/justinsheehy/following{/other_user}","gists_url":"https://api.github.com/users/justinsheehy/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsheehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsheehy/subscriptions","organizations_url":"https://api.github.com/users/justinsheehy/orgs","repos_url":"https://api.github.com/users/justinsheehy/repos","events_url":"https://api.github.com/users/justinsheehy/events{/privacy}","received_events_url":"https://api.github.com/users/justinsheehy/received_events","type":"User","site_admin":false},"repo":{"id":71577187,"name":"vertree","full_name":"justinsheehy/vertree","owner":{"login":"justinsheehy","id":72740,"avatar_url":"https://avatars.githubusercontent.com/u/72740?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsheehy","html_url":"https://github.com/justinsheehy","followers_url":"https://api.github.com/users/justinsheehy/followers","following_url":"https://api.github.com/users/justinsheehy/following{/other_user}","gists_url":"https://api.github.com/users/justinsheehy/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsheehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsheehy/subscriptions","organizations_url":"https://api.github.com/users/justinsheehy/orgs","repos_url":"https://api.github.com/users/justinsheehy/repos","events_url":"https://api.github.com/users/justinsheehy/events{/privacy}","received_events_url":"https://api.github.com/users/justinsheehy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinsheehy/vertree","description":"a tree. with versions.","fork":false,"url":"https://api.github.com/repos/justinsheehy/vertree","forks_url":"https://api.github.com/repos/justinsheehy/vertree/forks","keys_url":"https://api.github.com/repos/justinsheehy/vertree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinsheehy/vertree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinsheehy/vertree/teams","hooks_url":"https://api.github.com/repos/justinsheehy/vertree/hooks","issue_events_url":"https://api.github.com/repos/justinsheehy/vertree/issues/events{/number}","events_url":"https://api.github.com/repos/justinsheehy/vertree/events","assignees_url":"https://api.github.com/repos/justinsheehy/vertree/assignees{/user}","branches_url":"https://api.github.com/repos/justinsheehy/vertree/branches{/branch}","tags_url":"https://api.github.com/repos/justinsheehy/vertree/tags","blobs_url":"https://api.github.com/repos/justinsheehy/vertree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinsheehy/vertree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinsheehy/vertree/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinsheehy/vertree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinsheehy/vertree/statuses/{sha}","languages_url":"https://api.github.com/repos/justinsheehy/vertree/languages","stargazers_url":"https://api.github.com/repos/justinsheehy/vertree/stargazers","contributors_url":"https://api.github.com/repos/justinsheehy/vertree/contributors","subscribers_url":"https://api.github.com/repos/justinsheehy/vertree/subscribers","subscription_url":"https://api.github.com/repos/justinsheehy/vertree/subscription","commits_url":"https://api.github.com/repos/justinsheehy/vertree/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinsheehy/vertree/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinsheehy/vertree/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinsheehy/vertree/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinsheehy/vertree/contents/{+path}","compare_url":"https://api.github.com/repos/justinsheehy/vertree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinsheehy/vertree/merges","archive_url":"https://api.github.com/repos/justinsheehy/vertree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinsheehy/vertree/downloads","issues_url":"https://api.github.com/repos/justinsheehy/vertree/issues{/number}","pulls_url":"https://api.github.com/repos/justinsheehy/vertree/pulls{/number}","milestones_url":"https://api.github.com/repos/justinsheehy/vertree/milestones{/number}","notifications_url":"https://api.github.com/repos/justinsheehy/vertree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinsheehy/vertree/labels{/name}","releases_url":"https://api.github.com/repos/justinsheehy/vertree/releases{/id}","deployments_url":"https://api.github.com/repos/justinsheehy/vertree/deployments","created_at":"2016-10-21T15:22:17Z","updated_at":"2016-12-16T21:35:45Z","pushed_at":"2017-01-04T20:38:06Z","git_url":"git://github.com/justinsheehy/vertree.git","ssh_url":"git@github.com:justinsheehy/vertree.git","clone_url":"https://github.com/justinsheehy/vertree.git","svn_url":"https://github.com/justinsheehy/vertree","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"justinsheehy:master","ref":"master","sha":"6813b08478bd8159a58c8e28d7a09029c545bc01","user":{"login":"justinsheehy","id":72740,"avatar_url":"https://avatars.githubusercontent.com/u/72740?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsheehy","html_url":"https://github.com/justinsheehy","followers_url":"https://api.github.com/users/justinsheehy/followers","following_url":"https://api.github.com/users/justinsheehy/following{/other_user}","gists_url":"https://api.github.com/users/justinsheehy/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsheehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsheehy/subscriptions","organizations_url":"https://api.github.com/users/justinsheehy/orgs","repos_url":"https://api.github.com/users/justinsheehy/repos","events_url":"https://api.github.com/users/justinsheehy/events{/privacy}","received_events_url":"https://api.github.com/users/justinsheehy/received_events","type":"User","site_admin":false},"repo":{"id":71577187,"name":"vertree","full_name":"justinsheehy/vertree","owner":{"login":"justinsheehy","id":72740,"avatar_url":"https://avatars.githubusercontent.com/u/72740?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsheehy","html_url":"https://github.com/justinsheehy","followers_url":"https://api.github.com/users/justinsheehy/followers","following_url":"https://api.github.com/users/justinsheehy/following{/other_user}","gists_url":"https://api.github.com/users/justinsheehy/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsheehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsheehy/subscriptions","organizations_url":"https://api.github.com/users/justinsheehy/orgs","repos_url":"https://api.github.com/users/justinsheehy/repos","events_url":"https://api.github.com/users/justinsheehy/events{/privacy}","received_events_url":"https://api.github.com/users/justinsheehy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinsheehy/vertree","description":"a tree. with versions.","fork":false,"url":"https://api.github.com/repos/justinsheehy/vertree","forks_url":"https://api.github.com/repos/justinsheehy/vertree/forks","keys_url":"https://api.github.com/repos/justinsheehy/vertree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinsheehy/vertree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinsheehy/vertree/teams","hooks_url":"https://api.github.com/repos/justinsheehy/vertree/hooks","issue_events_url":"https://api.github.com/repos/justinsheehy/vertree/issues/events{/number}","events_url":"https://api.github.com/repos/justinsheehy/vertree/events","assignees_url":"https://api.github.com/repos/justinsheehy/vertree/assignees{/user}","branches_url":"https://api.github.com/repos/justinsheehy/vertree/branches{/branch}","tags_url":"https://api.github.com/repos/justinsheehy/vertree/tags","blobs_url":"https://api.github.com/repos/justinsheehy/vertree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinsheehy/vertree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinsheehy/vertree/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinsheehy/vertree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinsheehy/vertree/statuses/{sha}","languages_url":"https://api.github.com/repos/justinsheehy/vertree/languages","stargazers_url":"https://api.github.com/repos/justinsheehy/vertree/stargazers","contributors_url":"https://api.github.com/repos/justinsheehy/vertree/contributors","subscribers_url":"https://api.github.com/repos/justinsheehy/vertree/subscribers","subscription_url":"https://api.github.com/repos/justinsheehy/vertree/subscription","commits_url":"https://api.github.com/repos/justinsheehy/vertree/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinsheehy/vertree/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinsheehy/vertree/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinsheehy/vertree/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinsheehy/vertree/contents/{+path}","compare_url":"https://api.github.com/repos/justinsheehy/vertree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinsheehy/vertree/merges","archive_url":"https://api.github.com/repos/justinsheehy/vertree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinsheehy/vertree/downloads","issues_url":"https://api.github.com/repos/justinsheehy/vertree/issues{/number}","pulls_url":"https://api.github.com/repos/justinsheehy/vertree/pulls{/number}","milestones_url":"https://api.github.com/repos/justinsheehy/vertree/milestones{/number}","notifications_url":"https://api.github.com/repos/justinsheehy/vertree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinsheehy/vertree/labels{/name}","releases_url":"https://api.github.com/repos/justinsheehy/vertree/releases{/id}","deployments_url":"https://api.github.com/repos/justinsheehy/vertree/deployments","created_at":"2016-10-21T15:22:17Z","updated_at":"2016-12-16T21:35:45Z","pushed_at":"2017-01-04T20:38:06Z","git_url":"git://github.com/justinsheehy/vertree.git","ssh_url":"git@github.com:justinsheehy/vertree.git","clone_url":"https://github.com/justinsheehy/vertree.git","svn_url":"https://github.com/justinsheehy/vertree","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/justinsheehy/vertree/pulls/4"},"html":{"href":"https://github.com/justinsheehy/vertree/pull/4"},"issue":{"href":"https://api.github.com/repos/justinsheehy/vertree/issues/4"},"comments":{"href":"https://api.github.com/repos/justinsheehy/vertree/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/justinsheehy/vertree/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/justinsheehy/vertree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/justinsheehy/vertree/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/justinsheehy/vertree/statuses/4592e025589e455e246d31d2c9661405920e258f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andrewjstone","id":466937,"avatar_url":"https://avatars.githubusercontent.com/u/466937?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewjstone","html_url":"https://github.com/andrewjstone","followers_url":"https://api.github.com/users/andrewjstone/followers","following_url":"https://api.github.com/users/andrewjstone/following{/other_user}","gists_url":"https://api.github.com/users/andrewjstone/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewjstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewjstone/subscriptions","organizations_url":"https://api.github.com/users/andrewjstone/orgs","repos_url":"https://api.github.com/users/andrewjstone/repos","events_url":"https://api.github.com/users/andrewjstone/events{/privacy}","received_events_url":"https://api.github.com/users/andrewjstone/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":750,"deletions":639,"changed_files":13}}
{"actor":{"display_login":"andrewjstone"}}