{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/397","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/397/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/397/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/397/events","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/397","id":238626402,"number":397,"title":"Move inventory & scanner flags to yaml config files.","user":{"login":"blueandgold","id":6977544,"avatar_url":"https://avatars0.githubusercontent.com/u/6977544?v=3","gravatar_id":"","url":"https://api.github.com/users/blueandgold","html_url":"https://github.com/blueandgold","followers_url":"https://api.github.com/users/blueandgold/followers","following_url":"https://api.github.com/users/blueandgold/following{/other_user}","gists_url":"https://api.github.com/users/blueandgold/gists{/gist_id}","starred_url":"https://api.github.com/users/blueandgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueandgold/subscriptions","organizations_url":"https://api.github.com/users/blueandgold/orgs","repos_url":"https://api.github.com/users/blueandgold/repos","events_url":"https://api.github.com/users/blueandgold/events{/privacy}","received_events_url":"https://api.github.com/users/blueandgold/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2017-06-26T18:15:47Z","updated_at":"2017-07-01T00:23:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/397","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/397","diff_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/397.diff","patch_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/397.patch"},"body":"This PR started with the flags used by inventory, but grew to cover scanner as well since a lot of flags were common to both modules.  So, 3 yaml configs: inventory, scanner, and shared.\r\n\r\nSince this PR is already pretty sweeping, I punted on updating the pylints in the files that I touched, which are a lot.  My grand plan is to take a day (this friday or next week) and update them in one shot.\r\n\r\nLast note: I have not yet tested the forseti-instance.py yet, but I believe there are a few more changes there still to be done, but will do so."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/comments/312398423","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/397#issuecomment-312398423","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/397","id":312398423,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars1.githubusercontent.com/in/254?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-07-01T00:23:31Z","updated_at":"2017-07-01T00:23:31Z","body":"# [Codecov](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`master@0adcddd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `66.05%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397/graphs/tree.svg?token=bUTEy1SiZ0&width=650&height=150&src=pr)](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             master     #397   +/-   ##\n=========================================\n  Coverage          ?   76.63%           \n=========================================\n  Files             ?      147           \n  Lines             ?     6374           \n  Branches          ?        0           \n=========================================\n  Hits              ?     4885           \n  Misses            ?     1489           \n  Partials          ?        0\n```\n\n\n| [Impacted Files](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [google/cloud/security/common/gcp\\_type/resource.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfdHlwZS9yZXNvdXJjZS5weQ==) | `98.33% <ø> (ø)` | |\n| [google/cloud/security/common/gcp\\_type/folder.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfdHlwZS9mb2xkZXIucHk=) | `100% <ø> (ø)` | |\n| [...gle/cloud/security/common/gcp\\_type/organization.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfdHlwZS9vcmdhbml6YXRpb24ucHk=) | `100% <ø> (ø)` | |\n| [google/cloud/security/common/gcp\\_type/project.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfdHlwZS9wcm9qZWN0LnB5) | `90.9% <ø> (ø)` | |\n| [...loud/security/scanner/scanners/bigquery\\_scanner.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L3NjYW5uZXIvc2Nhbm5lcnMvYmlncXVlcnlfc2Nhbm5lci5weQ==) | `35.29% <0%> (ø)` | |\n| [google/cloud/security/common/gcp\\_api/iam.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfYXBpL2lhbS5weQ==) | `0% <0%> (ø)` | |\n| [...gle/cloud/security/common/gcp\\_api/cloud\\_billing.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfYXBpL2Nsb3VkX2JpbGxpbmcucHk=) | `0% <0%> (ø)` | |\n| [.../security/common/gcp\\_api/cloud\\_resource\\_manager.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfYXBpL2Nsb3VkX3Jlc291cmNlX21hbmFnZXIucHk=) | `96.03% <100%> (ø)` | |\n| [google/cloud/security/common/gcp\\_api/storage.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L2NvbW1vbi9nY3BfYXBpL3N0b3JhZ2UucHk=) | `45.9% <100%> (ø)` | |\n| [...ud/security/scanner/audit/cloudsql\\_rules\\_engine.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL3NlY3VyaXR5L3NjYW5uZXIvYXVkaXQvY2xvdWRzcWxfcnVsZXNfZW5naW5lLnB5) | `65.38% <100%> (ø)` | |\n| ... and [31 more](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=footer). Last update [0adcddd...ca825e4](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/397?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}