{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/14","id":146426559,"html_url":"https://github.com/bandwidth-throttle/token-bucket/pull/14","diff_url":"https://github.com/bandwidth-throttle/token-bucket/pull/14.diff","patch_url":"https://github.com/bandwidth-throttle/token-bucket/pull/14.patch","issue_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/14","number":14,"state":"closed","locked":false,"title":"Disallow inheritance","user":{"login":"malkusch","id":1623984,"avatar_url":"https://avatars3.githubusercontent.com/u/1623984?v=4","gravatar_id":"","url":"https://api.github.com/users/malkusch","html_url":"https://github.com/malkusch","followers_url":"https://api.github.com/users/malkusch/followers","following_url":"https://api.github.com/users/malkusch/following{/other_user}","gists_url":"https://api.github.com/users/malkusch/gists{/gist_id}","starred_url":"https://api.github.com/users/malkusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malkusch/subscriptions","organizations_url":"https://api.github.com/users/malkusch/orgs","repos_url":"https://api.github.com/users/malkusch/repos","events_url":"https://api.github.com/users/malkusch/events{/privacy}","received_events_url":"https://api.github.com/users/malkusch/received_events","type":"User","site_admin":false},"body":"I didn't declare classes as final and people do at least think about\r\ninheriting. I don't support that, as I had inheritance never in mind\r\nwhile designing those classes.\r\n\r\nThis is a breaking change and will require a major version bump.\r\n\r\nSee also: #13","created_at":"2017-10-13T10:45:53Z","updated_at":"2017-10-13T10:49:05Z","closed_at":"2017-10-13T10:49:05Z","merged_at":"2017-10-13T10:49:05Z","merge_commit_sha":"3caaafbb86a23efc04875091fbdbb016d7fd7b06","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/14/commits","review_comments_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/14/comments","review_comment_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/14/comments","statuses_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/statuses/96de2c32e105429fd21763c88e477cf9b87eabf6","head":{"label":"bandwidth-throttle:final","ref":"final","sha":"96de2c32e105429fd21763c88e477cf9b87eabf6","user":{"login":"bandwidth-throttle","id":12967475,"avatar_url":"https://avatars0.githubusercontent.com/u/12967475?v=4","gravatar_id":"","url":"https://api.github.com/users/bandwidth-throttle","html_url":"https://github.com/bandwidth-throttle","followers_url":"https://api.github.com/users/bandwidth-throttle/followers","following_url":"https://api.github.com/users/bandwidth-throttle/following{/other_user}","gists_url":"https://api.github.com/users/bandwidth-throttle/gists{/gist_id}","starred_url":"https://api.github.com/users/bandwidth-throttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bandwidth-throttle/subscriptions","organizations_url":"https://api.github.com/users/bandwidth-throttle/orgs","repos_url":"https://api.github.com/users/bandwidth-throttle/repos","events_url":"https://api.github.com/users/bandwidth-throttle/events{/privacy}","received_events_url":"https://api.github.com/users/bandwidth-throttle/received_events","type":"Organization","site_admin":false},"repo":{"id":37725198,"name":"token-bucket","full_name":"bandwidth-throttle/token-bucket","owner":{"login":"bandwidth-throttle","id":12967475,"avatar_url":"https://avatars0.githubusercontent.com/u/12967475?v=4","gravatar_id":"","url":"https://api.github.com/users/bandwidth-throttle","html_url":"https://github.com/bandwidth-throttle","followers_url":"https://api.github.com/users/bandwidth-throttle/followers","following_url":"https://api.github.com/users/bandwidth-throttle/following{/other_user}","gists_url":"https://api.github.com/users/bandwidth-throttle/gists{/gist_id}","starred_url":"https://api.github.com/users/bandwidth-throttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bandwidth-throttle/subscriptions","organizations_url":"https://api.github.com/users/bandwidth-throttle/orgs","repos_url":"https://api.github.com/users/bandwidth-throttle/repos","events_url":"https://api.github.com/users/bandwidth-throttle/events{/privacy}","received_events_url":"https://api.github.com/users/bandwidth-throttle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bandwidth-throttle/token-bucket","description":"Implementation of the Token Bucket algorithm in PHP.","fork":false,"url":"https://api.github.com/repos/bandwidth-throttle/token-bucket","forks_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/forks","keys_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/teams","hooks_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/hooks","issue_events_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/events{/number}","events_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/events","assignees_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/assignees{/user}","branches_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/branches{/branch}","tags_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/tags","blobs_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/refs{/sha}","trees_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/statuses/{sha}","languages_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/languages","stargazers_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/stargazers","contributors_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/contributors","subscribers_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/subscribers","subscription_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/subscription","commits_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/commits{/sha}","git_commits_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/commits{/sha}","comments_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/comments{/number}","issue_comment_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/comments{/number}","contents_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/contents/{+path}","compare_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/merges","archive_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/downloads","issues_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues{/number}","pulls_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls{/number}","milestones_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/milestones{/number}","notifications_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/labels{/name}","releases_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/releases{/id}","deployments_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/deployments","created_at":"2015-06-19T14:07:28Z","updated_at":"2017-10-03T12:45:08Z","pushed_at":"2017-10-13T10:49:05Z","git_url":"git://github.com/bandwidth-throttle/token-bucket.git","ssh_url":"git@github.com:bandwidth-throttle/token-bucket.git","clone_url":"https://github.com/bandwidth-throttle/token-bucket.git","svn_url":"https://github.com/bandwidth-throttle/token-bucket","homepage":null,"size":401,"stargazers_count":277,"watchers_count":277,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":5,"forks":23,"open_issues":5,"watchers":277,"default_branch":"master"}},"base":{"label":"bandwidth-throttle:master","ref":"master","sha":"77b7f25df17e9e8321371faeac73b07b89b9d9a0","user":{"login":"bandwidth-throttle","id":12967475,"avatar_url":"https://avatars0.githubusercontent.com/u/12967475?v=4","gravatar_id":"","url":"https://api.github.com/users/bandwidth-throttle","html_url":"https://github.com/bandwidth-throttle","followers_url":"https://api.github.com/users/bandwidth-throttle/followers","following_url":"https://api.github.com/users/bandwidth-throttle/following{/other_user}","gists_url":"https://api.github.com/users/bandwidth-throttle/gists{/gist_id}","starred_url":"https://api.github.com/users/bandwidth-throttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bandwidth-throttle/subscriptions","organizations_url":"https://api.github.com/users/bandwidth-throttle/orgs","repos_url":"https://api.github.com/users/bandwidth-throttle/repos","events_url":"https://api.github.com/users/bandwidth-throttle/events{/privacy}","received_events_url":"https://api.github.com/users/bandwidth-throttle/received_events","type":"Organization","site_admin":false},"repo":{"id":37725198,"name":"token-bucket","full_name":"bandwidth-throttle/token-bucket","owner":{"login":"bandwidth-throttle","id":12967475,"avatar_url":"https://avatars0.githubusercontent.com/u/12967475?v=4","gravatar_id":"","url":"https://api.github.com/users/bandwidth-throttle","html_url":"https://github.com/bandwidth-throttle","followers_url":"https://api.github.com/users/bandwidth-throttle/followers","following_url":"https://api.github.com/users/bandwidth-throttle/following{/other_user}","gists_url":"https://api.github.com/users/bandwidth-throttle/gists{/gist_id}","starred_url":"https://api.github.com/users/bandwidth-throttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bandwidth-throttle/subscriptions","organizations_url":"https://api.github.com/users/bandwidth-throttle/orgs","repos_url":"https://api.github.com/users/bandwidth-throttle/repos","events_url":"https://api.github.com/users/bandwidth-throttle/events{/privacy}","received_events_url":"https://api.github.com/users/bandwidth-throttle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bandwidth-throttle/token-bucket","description":"Implementation of the Token Bucket algorithm in PHP.","fork":false,"url":"https://api.github.com/repos/bandwidth-throttle/token-bucket","forks_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/forks","keys_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/teams","hooks_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/hooks","issue_events_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/events{/number}","events_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/events","assignees_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/assignees{/user}","branches_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/branches{/branch}","tags_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/tags","blobs_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/refs{/sha}","trees_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/statuses/{sha}","languages_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/languages","stargazers_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/stargazers","contributors_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/contributors","subscribers_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/subscribers","subscription_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/subscription","commits_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/commits{/sha}","git_commits_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/git/commits{/sha}","comments_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/comments{/number}","issue_comment_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/comments{/number}","contents_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/contents/{+path}","compare_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/merges","archive_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/downloads","issues_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues{/number}","pulls_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls{/number}","milestones_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/milestones{/number}","notifications_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/labels{/name}","releases_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/releases{/id}","deployments_url":"https://api.github.com/repos/bandwidth-throttle/token-bucket/deployments","created_at":"2015-06-19T14:07:28Z","updated_at":"2017-10-03T12:45:08Z","pushed_at":"2017-10-13T10:49:05Z","git_url":"git://github.com/bandwidth-throttle/token-bucket.git","ssh_url":"git@github.com:bandwidth-throttle/token-bucket.git","clone_url":"https://github.com/bandwidth-throttle/token-bucket.git","svn_url":"https://github.com/bandwidth-throttle/token-bucket","homepage":null,"size":401,"stargazers_count":277,"watchers_count":277,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":5,"forks":23,"open_issues":5,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/14"},"html":{"href":"https://github.com/bandwidth-throttle/token-bucket/pull/14"},"issue":{"href":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/14"},"comments":{"href":"https://api.github.com/repos/bandwidth-throttle/token-bucket/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bandwidth-throttle/token-bucket/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/bandwidth-throttle/token-bucket/statuses/96de2c32e105429fd21763c88e477cf9b87eabf6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"malkusch","id":1623984,"avatar_url":"https://avatars3.githubusercontent.com/u/1623984?v=4","gravatar_id":"","url":"https://api.github.com/users/malkusch","html_url":"https://github.com/malkusch","followers_url":"https://api.github.com/users/malkusch/followers","following_url":"https://api.github.com/users/malkusch/following{/other_user}","gists_url":"https://api.github.com/users/malkusch/gists{/gist_id}","starred_url":"https://api.github.com/users/malkusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malkusch/subscriptions","organizations_url":"https://api.github.com/users/malkusch/orgs","repos_url":"https://api.github.com/users/malkusch/repos","events_url":"https://api.github.com/users/malkusch/events{/privacy}","received_events_url":"https://api.github.com/users/malkusch/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":15,"changed_files":15}}
{"actor":{"display_login":"malkusch"}}