{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/12721","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/12721/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/12721/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/12721/events","html_url":"https://github.com/grpc/grpc/pull/12721","id":260743656,"number":12721,"title":"Make ruby google RPC status conversion return nil if the status-details trailer was missing","user":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"labels":[{"id":170781264,"url":"https://api.github.com/repos/grpc/grpc/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":166332946,"url":"https://api.github.com/repos/grpc/grpc/labels/lang/ruby","name":"lang/ruby","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-26T19:35:26Z","updated_at":"2017-09-27T18:56:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/12721","html_url":"https://github.com/grpc/grpc/pull/12721","diff_url":"https://github.com/grpc/grpc/pull/12721.diff","patch_url":"https://github.com/grpc/grpc/pull/12721.patch"},"body":"This is per feedback on this new utility in the 1.6.2 release (cc @geigerj).  Raising a protobuf parser error when the trailer containing the `Google::Rpc::Status` serialized protobuf is missing (which is expected to happen right now when talking to any server that hasn't implemented the new `Google::Rpc::Status` trailer yet),  doesn't provide enough useful info to the caller. This separates the \"error return values\" from the conversion utility into\r\n\r\n1. Converting `GRPC::Core::Status` to `Google::Rpc::Status` returns `nil` if the trailer to create the `Google::Rpc::Status` is missing.\r\n\r\n2. Converting `GRPC::Core::Status` to `Google::Rpc::Status` raises a protobuf parser error if the trailer to create the `Google::Rpc::Status` is present but doesn't contain a serialized `Google::Rpc::Status` (raising an error here because this case is unexpected and is likely due to an error within grpc)."},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/332621686","html_url":"https://github.com/grpc/grpc/pull/12721#issuecomment-332621686","issue_url":"https://api.github.com/repos/grpc/grpc/issues/12721","id":332621686,"user":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"created_at":"2017-09-27T18:56:58Z","updated_at":"2017-09-27T18:56:58Z","author_association":"CONTRIBUTOR","body":"failures:\r\n* https://github.com/grpc/grpc/issues/12740\r\n* https://github.com/grpc/grpc/issues/12723"}}
{"actor":{"display_login":"apolcyn"}}