{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments/111812014","pull_request_review_id":33080131,"id":111812014,"diff_hunk":"@@ -88,11 +86,10 @@ def build_resource_for_web_client(hs):\n                 \"the location of the source to serve via the configuration\\n\"\n                 \"option `web_client_location`\\n\\n\"\n                 \"To install the `matrix-angular-sdk` via pip, run:\\n\\n\"\n-                \"    pip install '%(dep)s'\\n\"\n+                \"    pip install matrix-angular-sdk\\n\"\n                 \"\\n\"\n                 \"You can also disable hosting of the webclient via the\\n\"\n                 \"configuration option `web_client`\\n\"\n-                % {\"dep\": DEPENDENCY_LINKS[\"matrix-angular-sdk\"]}","path":"synapse/app/homeserver.py","position":20,"original_position":20,"commit_id":"54f9a4cb59e358941b0b410633cd568b79f3e393","original_commit_id":"54f9a4cb59e358941b0b410633cd568b79f3e393","user":{"login":"APwhitehat","id":20104174,"avatar_url":"https://avatars0.githubusercontent.com/u/20104174?v=3","gravatar_id":"","url":"https://api.github.com/users/APwhitehat","html_url":"https://github.com/APwhitehat","followers_url":"https://api.github.com/users/APwhitehat/followers","following_url":"https://api.github.com/users/APwhitehat/following{/other_user}","gists_url":"https://api.github.com/users/APwhitehat/gists{/gist_id}","starred_url":"https://api.github.com/users/APwhitehat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/APwhitehat/subscriptions","organizations_url":"https://api.github.com/users/APwhitehat/orgs","repos_url":"https://api.github.com/users/APwhitehat/repos","events_url":"https://api.github.com/users/APwhitehat/events{/privacy}","received_events_url":"https://api.github.com/users/APwhitehat/received_events","type":"User","site_admin":false},"body":"String substitution could be failing because there is no key \"matrix-angular-sdk\" in DEPENDENCY_LINKS, see https://github.com/matrix-org/synapse/blob/master/synapse/python_dependencies.py#L76\r\nAlso it seems to be put into CONDITIONAL_REQUIREMENTS as \"web_client\".\r\n  \r\nI'm sort of new here so I could be wrong. 😛 ","created_at":"2017-04-17T20:17:29Z","updated_at":"2017-04-17T20:17:29Z","html_url":"https://github.com/matrix-org/synapse/pull/2131#discussion_r111812014","pull_request_url":"https://api.github.com/repos/matrix-org/synapse/pulls/2131","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments/111812014"},"html":{"href":"https://github.com/matrix-org/synapse/pull/2131#discussion_r111812014"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/2131"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/2131","id":116096500,"html_url":"https://github.com/matrix-org/synapse/pull/2131","diff_url":"https://github.com/matrix-org/synapse/pull/2131.diff","patch_url":"https://github.com/matrix-org/synapse/pull/2131.patch","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/2131","number":2131,"state":"open","locked":false,"title":"web_server_root documentation fix","user":{"login":"matthewjwolff","id":10929061,"avatar_url":"https://avatars2.githubusercontent.com/u/10929061?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewjwolff","html_url":"https://github.com/matthewjwolff","followers_url":"https://api.github.com/users/matthewjwolff/followers","following_url":"https://api.github.com/users/matthewjwolff/following{/other_user}","gists_url":"https://api.github.com/users/matthewjwolff/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjwolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjwolff/subscriptions","organizations_url":"https://api.github.com/users/matthewjwolff/orgs","repos_url":"https://api.github.com/users/matthewjwolff/repos","events_url":"https://api.github.com/users/matthewjwolff/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjwolff/received_events","type":"User","site_admin":false},"body":"The config option web_server_root is very sparsely documented. In my case, I wanted to see if I could get the matrix homeserver to host the riot.im electron app sources. To remedy the lack in documentation, I\r\n\r\n1. Made the generated ``homeserver.yaml`` include information about this field. (``synapse/config/server.py``)\r\n\r\n2. Changed the Readme portion for Arch Linux users. The AngularJS sdk is not distributed with the synapse package, so running synapse with the default ``homeserver.yaml`` will fail on Arch if matrix-synpase is installed from the repo. This is documented on the Arch wiki but not here.\r\n\r\n3. Removed the string substitution from the error message in ``synapse/app/homeserver.py``. The error message implies that it will only be printed if matrix-angular-sdk is not installed. But if matrix-angular-sdk is not installed, the program will crash when trying to perform the string substitution and not print the error message, defeating its purpose. If there's a better way to prevent this error, please enlighten me. \r\n\r\nI saw that yall welcome additions to ``AUTHORS.rst``. I feel like this fix isn't big enough for it to be appropriate to put my name next to the real developers. But hey if yall are fine with it I'd be happy to put my name there.\r\n\r\nSigned-off-by: Matthew Wolff <matthewjwolff@gmail.com>","created_at":"2017-04-17T06:16:23Z","updated_at":"2017-04-17T20:17:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9afa05737120a911d4d4c9184d71fc184a035358","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/synapse/pulls/2131/commits","review_comments_url":"https://api.github.com/repos/matrix-org/synapse/pulls/2131/comments","review_comment_url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/2131/comments","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/54f9a4cb59e358941b0b410633cd568b79f3e393","head":{"label":"matthewjwolff:develop","ref":"develop","sha":"54f9a4cb59e358941b0b410633cd568b79f3e393","user":{"login":"matthewjwolff","id":10929061,"avatar_url":"https://avatars2.githubusercontent.com/u/10929061?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewjwolff","html_url":"https://github.com/matthewjwolff","followers_url":"https://api.github.com/users/matthewjwolff/followers","following_url":"https://api.github.com/users/matthewjwolff/following{/other_user}","gists_url":"https://api.github.com/users/matthewjwolff/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjwolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjwolff/subscriptions","organizations_url":"https://api.github.com/users/matthewjwolff/orgs","repos_url":"https://api.github.com/users/matthewjwolff/repos","events_url":"https://api.github.com/users/matthewjwolff/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjwolff/received_events","type":"User","site_admin":false},"repo":{"id":88471601,"name":"synapse","full_name":"matthewjwolff/synapse","owner":{"login":"matthewjwolff","id":10929061,"avatar_url":"https://avatars2.githubusercontent.com/u/10929061?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewjwolff","html_url":"https://github.com/matthewjwolff","followers_url":"https://api.github.com/users/matthewjwolff/followers","following_url":"https://api.github.com/users/matthewjwolff/following{/other_user}","gists_url":"https://api.github.com/users/matthewjwolff/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjwolff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjwolff/subscriptions","organizations_url":"https://api.github.com/users/matthewjwolff/orgs","repos_url":"https://api.github.com/users/matthewjwolff/repos","events_url":"https://api.github.com/users/matthewjwolff/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjwolff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewjwolff/synapse","description":"Synapse: Matrix reference homeserver","fork":true,"url":"https://api.github.com/repos/matthewjwolff/synapse","forks_url":"https://api.github.com/repos/matthewjwolff/synapse/forks","keys_url":"https://api.github.com/repos/matthewjwolff/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewjwolff/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewjwolff/synapse/teams","hooks_url":"https://api.github.com/repos/matthewjwolff/synapse/hooks","issue_events_url":"https://api.github.com/repos/matthewjwolff/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matthewjwolff/synapse/events","assignees_url":"https://api.github.com/repos/matthewjwolff/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matthewjwolff/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matthewjwolff/synapse/tags","blobs_url":"https://api.github.com/repos/matthewjwolff/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewjwolff/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewjwolff/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewjwolff/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewjwolff/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewjwolff/synapse/languages","stargazers_url":"https://api.github.com/repos/matthewjwolff/synapse/stargazers","contributors_url":"https://api.github.com/repos/matthewjwolff/synapse/contributors","subscribers_url":"https://api.github.com/repos/matthewjwolff/synapse/subscribers","subscription_url":"https://api.github.com/repos/matthewjwolff/synapse/subscription","commits_url":"https://api.github.com/repos/matthewjwolff/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewjwolff/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewjwolff/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewjwolff/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewjwolff/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matthewjwolff/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewjwolff/synapse/merges","archive_url":"https://api.github.com/repos/matthewjwolff/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewjwolff/synapse/downloads","issues_url":"https://api.github.com/repos/matthewjwolff/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matthewjwolff/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewjwolff/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewjwolff/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewjwolff/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matthewjwolff/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matthewjwolff/synapse/deployments","created_at":"2017-04-17T04:56:12Z","updated_at":"2017-04-17T04:56:16Z","pushed_at":"2017-04-17T06:38:39Z","git_url":"git://github.com/matthewjwolff/synapse.git","ssh_url":"git@github.com:matthewjwolff/synapse.git","clone_url":"https://github.com/matthewjwolff/synapse.git","svn_url":"https://github.com/matthewjwolff/synapse","homepage":"http://matrix.org","size":14273,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"78f0ddbfadefd877b161094d467d4863bd8890f9","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars1.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"name":"synapse","full_name":"matrix-org/synapse","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars1.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2017-04-17T16:07:04Z","pushed_at":"2017-04-17T15:18:35Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"git@github.com:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":14289,"stargazers_count":1858,"watchers_count":1858,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":628,"forks":238,"open_issues":628,"watchers":1858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/2131"},"html":{"href":"https://github.com/matrix-org/synapse/pull/2131"},"issue":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/2131"},"comments":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/2131/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/2131/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/2131/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/synapse/statuses/54f9a4cb59e358941b0b410633cd568b79f3e393"}}}}
{"actor":{"display_login":"APwhitehat"}}