{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/comments/109534964","pull_request_review_id":30644453,"id":109534964,"diff_hunk":"@@ -0,0 +1,111 @@\n+﻿using NuGet.Protocol.Core.Types;\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using NuGet.Protocol;\n+using System.Reflection;\n+\n+namespace NuGet.Services.Metadata.Catalog.Monitoring.Validation.Test\n+{\n+    /// <summary>\n+    /// Creates <see cref=\"IValidationTestRunner\"/>s using <see cref=\"SourceRepository\"/>s.\n+    /// </summary>\n+    public class ValidationTestRunnerFactory","path":"src/Catalog/Monitoring/Validation/Test/ValidationTestRunnerFactory.cs","position":13,"original_position":13,"commit_id":"1229ba2cb0bd1cf36325dc891c5ae167855b9414","original_commit_id":"1229ba2cb0bd1cf36325dc891c5ae167855b9414","user":{"login":"joelverhagen","id":94054,"avatar_url":"https://avatars3.githubusercontent.com/u/94054?v=3","gravatar_id":"","url":"https://api.github.com/users/joelverhagen","html_url":"https://github.com/joelverhagen","followers_url":"https://api.github.com/users/joelverhagen/followers","following_url":"https://api.github.com/users/joelverhagen/following{/other_user}","gists_url":"https://api.github.com/users/joelverhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/joelverhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelverhagen/subscriptions","organizations_url":"https://api.github.com/users/joelverhagen/orgs","repos_url":"https://api.github.com/users/joelverhagen/repos","events_url":"https://api.github.com/users/joelverhagen/events{/privacy}","received_events_url":"https://api.github.com/users/joelverhagen/received_events","type":"User","site_admin":false},"body":">ValidationTestRunnerFactory [](start = 17, length = 27)\r\n\r\nThis code is black magic, needs lots of tests","created_at":"2017-04-03T22:00:06Z","updated_at":"2017-04-03T22:00:07Z","html_url":"https://github.com/NuGet/NuGet.Services.Metadata/pull/151#discussion_r109534964","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/comments/109534964"},"html":{"href":"https://github.com/NuGet/NuGet.Services.Metadata/pull/151#discussion_r109534964"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151","id":113752209,"html_url":"https://github.com/NuGet/NuGet.Services.Metadata/pull/151","diff_url":"https://github.com/NuGet/NuGet.Services.Metadata/pull/151.diff","patch_url":"https://github.com/NuGet/NuGet.Services.Metadata/pull/151.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/151","number":151,"state":"open","locked":false,"title":"V3 monitoring job: baseline","user":{"login":"scottbommarito","id":18014088,"avatar_url":"https://avatars0.githubusercontent.com/u/18014088?v=3","gravatar_id":"","url":"https://api.github.com/users/scottbommarito","html_url":"https://github.com/scottbommarito","followers_url":"https://api.github.com/users/scottbommarito/followers","following_url":"https://api.github.com/users/scottbommarito/following{/other_user}","gists_url":"https://api.github.com/users/scottbommarito/gists{/gist_id}","starred_url":"https://api.github.com/users/scottbommarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottbommarito/subscriptions","organizations_url":"https://api.github.com/users/scottbommarito/orgs","repos_url":"https://api.github.com/users/scottbommarito/repos","events_url":"https://api.github.com/users/scottbommarito/events{/privacy}","received_events_url":"https://api.github.com/users/scottbommarito/received_events","type":"User","site_admin":false},"body":"This PR consists of the infrastructure from which the V3 validations will run. It introduces the `EndpointMonitoringJob`, which runs off the catalog through the `ValidationTestCollector`.\r\n\r\nA couple notes:\r\n\r\n- I had to refactor the audit record parser and the v2 feed parser from `Feed2Catalog` so that it could be used by this job as well. I added some additional unit tests to counteract this but I can add more if necessary.\r\n\r\n- Adding additional validations to run on packages is done by declaring a new class in the `NuGet.Services.Metadata.Catalog` assembly that inherits from `ValidationTestRunner` and `IValidationTestRunner<IEndPointToTest>` and then implementing the `ShouldRun` and `RunInternal` methods. The job will find the class automatically.\r\n\r\n- I have implemented three simple validations on our registration blobs for testing purposes. Additional validations will be added in the future.","created_at":"2017-04-01T00:00:44Z","updated_at":"2017-04-03T22:00:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/151/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/statuses/1229ba2cb0bd1cf36325dc891c5ae167855b9414","head":{"label":"NuGet:sb-monitoringjobs","ref":"sb-monitoringjobs","sha":"1229ba2cb0bd1cf36325dc891c5ae167855b9414","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars1.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":16930969,"name":"NuGet.Services.Metadata","full_name":"NuGet/NuGet.Services.Metadata","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars1.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Services.Metadata","description":"NuGet's Metadata Service","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata","forks_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/deployments","created_at":"2014-02-18T00:00:53Z","updated_at":"2016-12-13T12:09:38Z","pushed_at":"2017-04-03T20:45:10Z","git_url":"git://github.com/NuGet/NuGet.Services.Metadata.git","ssh_url":"git@github.com:NuGet/NuGet.Services.Metadata.git","clone_url":"https://github.com/NuGet/NuGet.Services.Metadata.git","svn_url":"https://github.com/NuGet/NuGet.Services.Metadata","homepage":null,"size":10213,"stargazers_count":13,"watchers_count":13,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":13,"default_branch":"master"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"d6be0fa30ac99f2e1a8b108587f37118553d21ef","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars1.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":16930969,"name":"NuGet.Services.Metadata","full_name":"NuGet/NuGet.Services.Metadata","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars1.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Services.Metadata","description":"NuGet's Metadata Service","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata","forks_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/deployments","created_at":"2014-02-18T00:00:53Z","updated_at":"2016-12-13T12:09:38Z","pushed_at":"2017-04-03T20:45:10Z","git_url":"git://github.com/NuGet/NuGet.Services.Metadata.git","ssh_url":"git@github.com:NuGet/NuGet.Services.Metadata.git","clone_url":"https://github.com/NuGet/NuGet.Services.Metadata.git","svn_url":"https://github.com/NuGet/NuGet.Services.Metadata","homepage":null,"size":10213,"stargazers_count":13,"watchers_count":13,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151"},"html":{"href":"https://github.com/NuGet/NuGet.Services.Metadata/pull/151"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/151"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Services.Metadata/statuses/1229ba2cb0bd1cf36325dc891c5ae167855b9414"}}}}
{"actor":{"display_login":"joelverhagen"}}