{"push_id":1771457416,"size":4,"distinct_size":4,"ref":"refs/heads/master","head":"5c975e58cda8b2412d447c1af7b00e01ecaea758","before":"a4d0b55966458f3ba97683689695acc391ad61ec","commits":[{"sha":"4093382fc495fbe8fb7c21d0ff6c2ea12955457d","author":{"name":"David Rodríguez","email":"46f11081f5b9864972d12c0084d0564195b11908@riseup.net"},"message":"Enable rubocop encoding checks (#1414)\n\n* Add some missing blank lines\r\n\r\n* Enable rubocop's encoding checks and auto-correct","distinct":true,"url":"https://api.github.com/repos/deivid-rodriguez/decidim/commits/4093382fc495fbe8fb7c21d0ff6c2ea12955457d"},{"sha":"dcfa610f22ee9054f1a51613d10db24393926b58","author":{"name":"decidim-bot","email":"8e425b8516841123e2c01673011d39b450259029@users.noreply.github.com"},"message":"New Crowdin translations (#1415)\n\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)\r\n\r\n* New translations en.yml (Basque)","distinct":true,"url":"https://api.github.com/repos/deivid-rodriguez/decidim/commits/dcfa610f22ee9054f1a51613d10db24393926b58"},{"sha":"9e636a8497fe055bb3a5086ee0062b2750e12b4a","author":{"name":"David Rodríguez","email":"46f11081f5b9864972d12c0084d0564195b11908@riseup.net"},"message":"Fix tests in local environment (#1416)\n\n* Remove unnecessary gitignore\r\n\r\n* Register an icon for dummy feature\r\n\r\nOtherwise a nil asset is registered and causes precompilation to fail\r\nwith this error:\r\n\r\n```\r\nFailure/Error: <%= stylesheet_link_tag    'application', media: 'all' %>\r\n\r\nActionView::Template::Error:\r\n  unknown filter type: nil\r\n```\r\n\r\nIt didn't happen previously because assets were precompiled _before_\r\ntests, and thus before the dummy feature with missing icon was\r\nregistered. That's also why it doesn't happen in CI.\r\n\r\n* Relax capybara timeout\r\n\r\nSince assets are now precompiled on first access, the first test might\r\nactually timeout. Let's make sure that doesn't happen.\r\n\r\n* Keep CI & local behaviour consistent","distinct":true,"url":"https://api.github.com/repos/deivid-rodriguez/decidim/commits/9e636a8497fe055bb3a5086ee0062b2750e12b4a"},{"sha":"5c975e58cda8b2412d447c1af7b00e01ecaea758","author":{"name":"David Rodríguez","email":"46f11081f5b9864972d12c0084d0564195b11908@riseup.net"},"message":"Hookable menus (#1401)\n\n* Hookable menus, base version\r\n\r\n* Add a conditional display parameter to menus\r\n\r\n* Remove the need for lambdas\r\n\r\n* Refactor menus\r\n\r\nI didn't like the fact that menus were globally registered long lived\r\nobjects whose evaluated items had to be re(set) on every rendering. Not\r\nsure if that was likely to cause any issue (concurrency, maybe) but I\r\nstill like it better to separate long lived globally registered objects\r\n(`MenuRegistry` now) from each instance of an actual menu dependent on\r\nthe view context (`Menu` now).\r\n\r\n* Don't leak visibility to the presentation layer\r\n\r\nI feel it's cleaner this way. This remove the possibity for presenters\r\nto easily display invisible items. Presenters wanting to do that should\r\nfeel pain.\r\n\r\n* Better active_class selection in admin menu\r\n\r\n* Remove unused options\r\n\r\n* Don't need to pass in the active class\r\n\r\n* Move :li to the menu item presenter\r\n\r\nIt belongs there.\r\n\r\n* Remove unnecessary magic\r\n\r\n* Don't generate empty CSS classes\r\n\r\n* Extract two more methods\r\n\r\n* Resolve active class independently of active_link_to\r\n\r\n* Expose only `active` for now in MenuItem\r\n\r\nI won't store the whole hash of options for now. Since I'm adding\r\noptions in the presenter too, it'll make the code less clear in exchange\r\nfor a potential future improvement. Ditch it.\r\n\r\n* Allow passing CSS classes when creating presenter\r\n\r\n* Normalize markup between menus\r\n\r\n* Styling main menu is done from a wrapper <div> over the <ul> tag.\r\n* Styling menu items is done from a wrapper <li> over the <a> tag.\r\n\r\nThis makes markup in both admin & main menu consistent.\r\n\r\n* Rename menu presenter main methods to \"render\"\r\n\r\nThe initial idea was to display different formats from the same\r\npresenter. With the current implementation, it no longer makes sense.\r\n\r\n* Migrate admin menu to the new menu API\r\n\r\n* Remove unused admin stylesheet\r\n\r\n* Migrate system menu to the menu API\r\n\r\n* Missing EOF\r\n\r\n* Fix bug with root path active link detection\r\n\r\nIf we match the active class by exact URL, it won't be properly detected\r\nfor paths without trailing slash, like /admin (instead of /admin/).\r\n\r\n* Assign fixed positions to default menus\r\n\r\nSo extensions can easily place new items wherever they want reliably.","distinct":true,"url":"https://api.github.com/repos/deivid-rodriguez/decidim/commits/5c975e58cda8b2412d447c1af7b00e01ecaea758"}]}
{"actor":{"display_login":"deivid-rodriguez"}}