{"action":"opened","issue":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/437","repository_url":"https://api.github.com/repos/se-edu/addressbook-level4","labels_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/437/labels{/name}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/437/comments","events_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/437/events","html_url":"https://github.com/se-edu/addressbook-level4/issues/437","id":230891829,"number":437,"title":"LogicManager constructor takes in a redundant Storage parameter","user":{"login":"yamgent","id":3168908,"avatar_url":"https://avatars2.githubusercontent.com/u/3168908?v=3","gravatar_id":"","url":"https://api.github.com/users/yamgent","html_url":"https://github.com/yamgent","followers_url":"https://api.github.com/users/yamgent/followers","following_url":"https://api.github.com/users/yamgent/following{/other_user}","gists_url":"https://api.github.com/users/yamgent/gists{/gist_id}","starred_url":"https://api.github.com/users/yamgent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamgent/subscriptions","organizations_url":"https://api.github.com/users/yamgent/orgs","repos_url":"https://api.github.com/users/yamgent/repos","events_url":"https://api.github.com/users/yamgent/events{/privacy}","received_events_url":"https://api.github.com/users/yamgent/received_events","type":"User","site_admin":false},"labels":[{"id":455436217,"url":"https://api.github.com/repos/se-edu/addressbook-level4/labels/a-CodeQuality","name":"a-CodeQuality","color":"d4c5f9","default":false},{"id":449825308,"url":"https://api.github.com/repos/se-edu/addressbook-level4/labels/c.Enhancement","name":"c.Enhancement","color":"d6f5f5","default":false},{"id":432685900,"url":"https://api.github.com/repos/se-edu/addressbook-level4/labels/p.Low","name":"p.Low","color":"ffb3b3","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-24T01:06:22Z","updated_at":"2017-05-24T01:06:22Z","closed_at":null,"body":"The LogicManager does not utilize the Storage in any way. Therefore it is a redundant parameter.\r\n\r\n```\r\n    public LogicManager(Model model, Storage storage) {\r\n        this.model = model;\r\n        this.parser = new Parser();\r\n    }\r\n```\r\n\r\nHowever, this issue will become irrelevant if we fix #158 / merge #212, although PR #212 is on hold due to YAGNI principle. "}}
{"actor":{"display_login":"yamgent"}}