{"action":"created","comment":{"url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/comments/114343142","pull_request_review_id":35801238,"id":114343142,"diff_hunk":"@@ -0,0 +1,62 @@\n+#!/bin/bash\n+#\n+# IMPORTANT: Change this file only in directory NodeDebug!\n+","path":"NodeDebug/entry_point.sh","position":4,"original_position":4,"commit_id":"b0a199184e4224b41bee421c922e92113dbd2898","original_commit_id":"b0a199184e4224b41bee421c922e92113dbd2898","user":{"login":"diemol","id":5992658,"avatar_url":"https://avatars2.githubusercontent.com/u/5992658?v=3","gravatar_id":"","url":"https://api.github.com/users/diemol","html_url":"https://github.com/diemol","followers_url":"https://api.github.com/users/diemol/followers","following_url":"https://api.github.com/users/diemol/following{/other_user}","gists_url":"https://api.github.com/users/diemol/gists{/gist_id}","starred_url":"https://api.github.com/users/diemol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemol/subscriptions","organizations_url":"https://api.github.com/users/diemol/orgs","repos_url":"https://api.github.com/users/diemol/repos","events_url":"https://api.github.com/users/diemol/events{/privacy}","received_events_url":"https://api.github.com/users/diemol/received_events","type":"User","site_admin":false},"body":"File added to handle the `entry_point.sh` in the same way it is done for the StandaloneDebug images. Things get changed here and the file is copied to the appropriate folders.","created_at":"2017-05-02T15:14:36Z","updated_at":"2017-05-02T15:14:36Z","html_url":"https://github.com/SeleniumHQ/docker-selenium/pull/477#discussion_r114343142","pull_request_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477","_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/comments/114343142"},"html":{"href":"https://github.com/SeleniumHQ/docker-selenium/pull/477#discussion_r114343142"},"pull_request":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477"}}},"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477","id":118574943,"html_url":"https://github.com/SeleniumHQ/docker-selenium/pull/477","diff_url":"https://github.com/SeleniumHQ/docker-selenium/pull/477.diff","patch_url":"https://github.com/SeleniumHQ/docker-selenium/pull/477.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/issues/477","number":477,"state":"open","locked":false,"title":"Run all processes with seluser instead of root","user":{"login":"diemol","id":5992658,"avatar_url":"https://avatars2.githubusercontent.com/u/5992658?v=3","gravatar_id":"","url":"https://api.github.com/users/diemol","html_url":"https://github.com/diemol","followers_url":"https://api.github.com/users/diemol/followers","following_url":"https://api.github.com/users/diemol/following{/other_user}","gists_url":"https://api.github.com/users/diemol/gists{/gist_id}","starred_url":"https://api.github.com/users/diemol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemol/subscriptions","organizations_url":"https://api.github.com/users/diemol/orgs","repos_url":"https://api.github.com/users/diemol/repos","events_url":"https://api.github.com/users/diemol/events{/privacy}","received_events_url":"https://api.github.com/users/diemol/received_events","type":"User","site_admin":false},"body":"While checking #474, I found that in some images the processes are run by `seluser` and in other ones they are run with `seluser` and `root`  (specially in the debug ones). E.g.:\r\n\r\n```\r\ndocker run --rm -p 4444:4444 -p 5900:5900 -v /dev/shm:/dev/shm --shm-size=1g selenium/standalone-chrome-debug:3.4.0-chromium\r\n\r\ndocker exec -ti objective_stonebraker bash\r\n\r\nroot@be3eb04ea476:/# ps -aux\r\nUSER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND\r\nroot         1  0.0  0.1  20996  3280 ?        Ss+  14:44   0:00 /bin/bash /opt/bin/entry_point.sh\r\nroot        21  0.0  0.0  20992  1616 ?        S+   14:44   0:00 /bin/bash /opt/bin/entry_point.sh\r\nroot        26  0.0  0.0   4508  1632 ?        S+   14:44   0:00 /bin/sh /usr/bin/xvfb-run -n 99 --server-args=-screen 0 1360x1020x24 -ac +extension RANDR java -jar /opt/selenium/se\r\nroot        38  0.8  2.6 217096 54464 ?        Sl+  14:44   0:00 Xvfb :99 -screen 0 1360x1020x24 -ac +extension RANDR -nolisten tcp -auth /tmp/xvfb-run.l7EYS6/Xauthority\r\nroot        43  3.0  2.3 2966204 48284 ?       Sl+  14:44   0:01 java -jar /opt/selenium/selenium-server-standalone.jar\r\nroot        56  1.8  0.5 114212 10972 ?        S+   14:44   0:00 fluxbox -display :99.0\r\nroot        57  0.2  0.6 113380 13536 ?        S+   14:44   0:00 x11vnc -forever -usepw -shared -rfbport 5900 -display :99.0\r\nroot        78  1.0  0.1  21196  3672 ?        Ss   14:45   0:00 bash\r\nroot        87  0.0  0.1  37364  3276 ?        R+   14:45   0:00 ps -aux\r\n```\r\n\r\nI went through all the `Dockerfiles` and `entry_point.sh` and improved them so all the processes run now with `seluser`.\r\n\r\nI executed the tests and they passed, I also tested it so the fix done in #459 and #469 don't get lost.\r\n\r\n@ddavison \r\nI will add some comments next to the commits to make this PR easier to review.\r\n\r\n@elgalu, can you please also help to review this PR?  \r\n\r\n- [x] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/docker-selenium/blob/master/CONTRIBUTING.md#contributing-code-to-selenium)\r\n","created_at":"2017-05-02T15:00:18Z","updated_at":"2017-05-02T15:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70313c4a392a22b5b7599f91b9e8a850052a75f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/issues/477/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/statuses/b0a199184e4224b41bee421c922e92113dbd2898","head":{"label":"diemol:master","ref":"master","sha":"b0a199184e4224b41bee421c922e92113dbd2898","user":{"login":"diemol","id":5992658,"avatar_url":"https://avatars2.githubusercontent.com/u/5992658?v=3","gravatar_id":"","url":"https://api.github.com/users/diemol","html_url":"https://github.com/diemol","followers_url":"https://api.github.com/users/diemol/followers","following_url":"https://api.github.com/users/diemol/following{/other_user}","gists_url":"https://api.github.com/users/diemol/gists{/gist_id}","starred_url":"https://api.github.com/users/diemol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemol/subscriptions","organizations_url":"https://api.github.com/users/diemol/orgs","repos_url":"https://api.github.com/users/diemol/repos","events_url":"https://api.github.com/users/diemol/events{/privacy}","received_events_url":"https://api.github.com/users/diemol/received_events","type":"User","site_admin":false},"repo":{"id":88548101,"name":"docker-selenium","full_name":"diemol/docker-selenium","owner":{"login":"diemol","id":5992658,"avatar_url":"https://avatars2.githubusercontent.com/u/5992658?v=3","gravatar_id":"","url":"https://api.github.com/users/diemol","html_url":"https://github.com/diemol","followers_url":"https://api.github.com/users/diemol/followers","following_url":"https://api.github.com/users/diemol/following{/other_user}","gists_url":"https://api.github.com/users/diemol/gists{/gist_id}","starred_url":"https://api.github.com/users/diemol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemol/subscriptions","organizations_url":"https://api.github.com/users/diemol/orgs","repos_url":"https://api.github.com/users/diemol/repos","events_url":"https://api.github.com/users/diemol/events{/privacy}","received_events_url":"https://api.github.com/users/diemol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diemol/docker-selenium","description":"Docker images for Selenium Standalone Server","fork":true,"url":"https://api.github.com/repos/diemol/docker-selenium","forks_url":"https://api.github.com/repos/diemol/docker-selenium/forks","keys_url":"https://api.github.com/repos/diemol/docker-selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diemol/docker-selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diemol/docker-selenium/teams","hooks_url":"https://api.github.com/repos/diemol/docker-selenium/hooks","issue_events_url":"https://api.github.com/repos/diemol/docker-selenium/issues/events{/number}","events_url":"https://api.github.com/repos/diemol/docker-selenium/events","assignees_url":"https://api.github.com/repos/diemol/docker-selenium/assignees{/user}","branches_url":"https://api.github.com/repos/diemol/docker-selenium/branches{/branch}","tags_url":"https://api.github.com/repos/diemol/docker-selenium/tags","blobs_url":"https://api.github.com/repos/diemol/docker-selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diemol/docker-selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diemol/docker-selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/diemol/docker-selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diemol/docker-selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/diemol/docker-selenium/languages","stargazers_url":"https://api.github.com/repos/diemol/docker-selenium/stargazers","contributors_url":"https://api.github.com/repos/diemol/docker-selenium/contributors","subscribers_url":"https://api.github.com/repos/diemol/docker-selenium/subscribers","subscription_url":"https://api.github.com/repos/diemol/docker-selenium/subscription","commits_url":"https://api.github.com/repos/diemol/docker-selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/diemol/docker-selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/diemol/docker-selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/diemol/docker-selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/diemol/docker-selenium/contents/{+path}","compare_url":"https://api.github.com/repos/diemol/docker-selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diemol/docker-selenium/merges","archive_url":"https://api.github.com/repos/diemol/docker-selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diemol/docker-selenium/downloads","issues_url":"https://api.github.com/repos/diemol/docker-selenium/issues{/number}","pulls_url":"https://api.github.com/repos/diemol/docker-selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/diemol/docker-selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/diemol/docker-selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diemol/docker-selenium/labels{/name}","releases_url":"https://api.github.com/repos/diemol/docker-selenium/releases{/id}","deployments_url":"https://api.github.com/repos/diemol/docker-selenium/deployments","created_at":"2017-04-17T20:31:50Z","updated_at":"2017-04-17T20:31:53Z","pushed_at":"2017-05-02T10:20:30Z","git_url":"git://github.com/diemol/docker-selenium.git","ssh_url":"git@github.com:diemol/docker-selenium.git","clone_url":"https://github.com/diemol/docker-selenium.git","svn_url":"https://github.com/diemol/docker-selenium","homepage":"https://hub.docker.com/r/selenium/","size":508,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"fe860cbcbf627a2e95d88bf073fdae4acd73888c","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars1.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":26768643,"name":"docker-selenium","full_name":"SeleniumHQ/docker-selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars1.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/docker-selenium","description":"Docker images for Selenium Standalone Server","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/docker-selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/releases{/id}","deployments_url":"https://api.github.com/repos/SeleniumHQ/docker-selenium/deployments","created_at":"2014-11-17T17:39:22Z","updated_at":"2017-05-02T09:23:10Z","pushed_at":"2017-05-02T15:00:19Z","git_url":"git://github.com/SeleniumHQ/docker-selenium.git","ssh_url":"git@github.com:SeleniumHQ/docker-selenium.git","clone_url":"https://github.com/SeleniumHQ/docker-selenium.git","svn_url":"https://github.com/SeleniumHQ/docker-selenium","homepage":"https://hub.docker.com/r/selenium/","size":490,"stargazers_count":1498,"watchers_count":1498,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":600,"mirror_url":null,"open_issues_count":115,"forks":600,"open_issues":115,"watchers":1498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477"},"html":{"href":"https://github.com/SeleniumHQ/docker-selenium/pull/477"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/issues/477"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/docker-selenium/statuses/b0a199184e4224b41bee421c922e92113dbd2898"}}}}
{"actor":{"display_login":"diemol"}}