{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/northstar/issues/541","repository_url":"https://api.github.com/repos/DoSomething/northstar","labels_url":"https://api.github.com/repos/DoSomething/northstar/issues/541/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/northstar/issues/541/comments","events_url":"https://api.github.com/repos/DoSomething/northstar/issues/541/events","html_url":"https://github.com/DoSomething/northstar/pull/541","id":205982130,"number":541,"title":"Fix incorrect label on log.","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-07T18:58:59Z","updated_at":"2017-02-07T19:11:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/541","html_url":"https://github.com/DoSomething/northstar/pull/541","diff_url":"https://github.com/DoSomething/northstar/pull/541.diff","patch_url":"https://github.com/DoSomething/northstar/pull/541.patch"},"body":"#### What's this PR do?\r\nI'm a real dummy and accidentally logged the opposite of `exists` on this line (see the location of the `!` before and after for details). This made the logs real confusing. 💩\r\n\r\n#### How should this be reviewed?\r\n👀\r\n\r\n#### Checklist\r\n- [ ] Documentation added for changed endpoints.\r\n- [ ] Tests added for new features/bug fixes.\r\n- [ ] Post a message in #api if this includes something that causes a rebuild!  "},"comment":{"url":"https://api.github.com/repos/DoSomething/northstar/issues/comments/278108524","html_url":"https://github.com/DoSomething/northstar/pull/541#issuecomment-278108524","issue_url":"https://api.github.com/repos/DoSomething/northstar/issues/541","id":278108524,"user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"created_at":"2017-02-07T19:11:56Z","updated_at":"2017-02-07T19:11:56Z","body":"> Took me a second to realize the difference, this is because its the incorrect value in that log statement?\r\n\r\nYep. The function is asking whether something is revoked, so \"not exists\" (which is why we returned `! AuthCode::where(...)->exists()` originally). When I added in the logging, I saved the \"negated\" version of that exists check to `$exists`, even though it probably should have been named `$revoked`.\r\n\r\nThis PR just shuffles the `!` around so that the `$exists` variable is what it says it is."}}
{"actor":{"display_login":"DFurnes"}}