{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/is/pulls/comments/145851286","pull_request_review_id":70713494,"id":145851286,"diff_hunk":"@@ -190,6 +191,7 @@ const isEmptyMapOrSet = x => (is.map(x) || is.set(x)) && x.size === 0;\n \n is.empty = x => !x || isEmptyStringOrArray(x) || isEmptyObject(x) || isEmptyMapOrSet(x);\n is.emptyOrWhitespace = x => is.empty(x) || isWhiteSpaceString(x);\n+is.emoji = x => is.string(x) && emojiRegex.test(x);","path":"index.js","position":12,"original_position":12,"commit_id":"e13599e5d7c9b680f34d6cdf3c1ef9bd25adc19d","original_commit_id":"e13599e5d7c9b680f34d6cdf3c1ef9bd25adc19d","user":{"login":"brandon93s","id":4730164,"avatar_url":"https://avatars0.githubusercontent.com/u/4730164?v=4","gravatar_id":"","url":"https://api.github.com/users/brandon93s","html_url":"https://github.com/brandon93s","followers_url":"https://api.github.com/users/brandon93s/followers","following_url":"https://api.github.com/users/brandon93s/following{/other_user}","gists_url":"https://api.github.com/users/brandon93s/gists{/gist_id}","starred_url":"https://api.github.com/users/brandon93s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandon93s/subscriptions","organizations_url":"https://api.github.com/users/brandon93s/orgs","repos_url":"https://api.github.com/users/brandon93s/repos","events_url":"https://api.github.com/users/brandon93s/events{/privacy}","received_events_url":"https://api.github.com/users/brandon93s/received_events","type":"User","site_admin":false},"body":"The name implies we are checking for a single emoji, but this currently returns true for any string that _contains_ an emoji:\r\n\r\n```js\r\nemojiRegex.test('this is a test 🙏')\r\n// => true\r\n```\r\n\r\nShould we consider a different name? Or behavior? Something along the lines of `is.stringWithEmoji` maybe.","created_at":"2017-10-19T23:48:47Z","updated_at":"2017-10-19T23:54:17Z","html_url":"https://github.com/sindresorhus/is/pull/24#discussion_r145851286","pull_request_url":"https://api.github.com/repos/sindresorhus/is/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/is/pulls/comments/145851286"},"html":{"href":"https://github.com/sindresorhus/is/pull/24#discussion_r145851286"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/is/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/is/pulls/24","id":147684796,"html_url":"https://github.com/sindresorhus/is/pull/24","diff_url":"https://github.com/sindresorhus/is/pull/24.diff","patch_url":"https://github.com/sindresorhus/is/pull/24.patch","issue_url":"https://api.github.com/repos/sindresorhus/is/issues/24","number":24,"state":"open","locked":false,"title":"Add `is.emoji()`","user":{"login":"yeskunall","id":14703164,"avatar_url":"https://avatars2.githubusercontent.com/u/14703164?v=4","gravatar_id":"","url":"https://api.github.com/users/yeskunall","html_url":"https://github.com/yeskunall","followers_url":"https://api.github.com/users/yeskunall/followers","following_url":"https://api.github.com/users/yeskunall/following{/other_user}","gists_url":"https://api.github.com/users/yeskunall/gists{/gist_id}","starred_url":"https://api.github.com/users/yeskunall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeskunall/subscriptions","organizations_url":"https://api.github.com/users/yeskunall/orgs","repos_url":"https://api.github.com/users/yeskunall/repos","events_url":"https://api.github.com/users/yeskunall/events{/privacy}","received_events_url":"https://api.github.com/users/yeskunall/received_events","type":"User","site_admin":false},"body":":unicorn: 🎊 🎉","created_at":"2017-10-19T22:55:40Z","updated_at":"2017-10-19T23:54:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b81853ba03a7dee104f584605a8b94a44e1d310","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/is/pulls/24/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/is/pulls/24/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/is/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/is/issues/24/comments","statuses_url":"https://api.github.com/repos/sindresorhus/is/statuses/e13599e5d7c9b680f34d6cdf3c1ef9bd25adc19d","head":{"label":"yeskunall:add-is-emoji","ref":"add-is-emoji","sha":"e13599e5d7c9b680f34d6cdf3c1ef9bd25adc19d","user":{"login":"yeskunall","id":14703164,"avatar_url":"https://avatars2.githubusercontent.com/u/14703164?v=4","gravatar_id":"","url":"https://api.github.com/users/yeskunall","html_url":"https://github.com/yeskunall","followers_url":"https://api.github.com/users/yeskunall/followers","following_url":"https://api.github.com/users/yeskunall/following{/other_user}","gists_url":"https://api.github.com/users/yeskunall/gists{/gist_id}","starred_url":"https://api.github.com/users/yeskunall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeskunall/subscriptions","organizations_url":"https://api.github.com/users/yeskunall/orgs","repos_url":"https://api.github.com/users/yeskunall/repos","events_url":"https://api.github.com/users/yeskunall/events{/privacy}","received_events_url":"https://api.github.com/users/yeskunall/received_events","type":"User","site_admin":false},"repo":{"id":104603634,"name":"is","full_name":"yeskunall/is","owner":{"login":"yeskunall","id":14703164,"avatar_url":"https://avatars2.githubusercontent.com/u/14703164?v=4","gravatar_id":"","url":"https://api.github.com/users/yeskunall","html_url":"https://github.com/yeskunall","followers_url":"https://api.github.com/users/yeskunall/followers","following_url":"https://api.github.com/users/yeskunall/following{/other_user}","gists_url":"https://api.github.com/users/yeskunall/gists{/gist_id}","starred_url":"https://api.github.com/users/yeskunall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeskunall/subscriptions","organizations_url":"https://api.github.com/users/yeskunall/orgs","repos_url":"https://api.github.com/users/yeskunall/repos","events_url":"https://api.github.com/users/yeskunall/events{/privacy}","received_events_url":"https://api.github.com/users/yeskunall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yeskunall/is","description":"Type check values: `is.string('🦄') //=> true`","fork":true,"url":"https://api.github.com/repos/yeskunall/is","forks_url":"https://api.github.com/repos/yeskunall/is/forks","keys_url":"https://api.github.com/repos/yeskunall/is/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeskunall/is/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeskunall/is/teams","hooks_url":"https://api.github.com/repos/yeskunall/is/hooks","issue_events_url":"https://api.github.com/repos/yeskunall/is/issues/events{/number}","events_url":"https://api.github.com/repos/yeskunall/is/events","assignees_url":"https://api.github.com/repos/yeskunall/is/assignees{/user}","branches_url":"https://api.github.com/repos/yeskunall/is/branches{/branch}","tags_url":"https://api.github.com/repos/yeskunall/is/tags","blobs_url":"https://api.github.com/repos/yeskunall/is/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeskunall/is/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeskunall/is/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeskunall/is/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeskunall/is/statuses/{sha}","languages_url":"https://api.github.com/repos/yeskunall/is/languages","stargazers_url":"https://api.github.com/repos/yeskunall/is/stargazers","contributors_url":"https://api.github.com/repos/yeskunall/is/contributors","subscribers_url":"https://api.github.com/repos/yeskunall/is/subscribers","subscription_url":"https://api.github.com/repos/yeskunall/is/subscription","commits_url":"https://api.github.com/repos/yeskunall/is/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeskunall/is/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeskunall/is/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeskunall/is/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeskunall/is/contents/{+path}","compare_url":"https://api.github.com/repos/yeskunall/is/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeskunall/is/merges","archive_url":"https://api.github.com/repos/yeskunall/is/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeskunall/is/downloads","issues_url":"https://api.github.com/repos/yeskunall/is/issues{/number}","pulls_url":"https://api.github.com/repos/yeskunall/is/pulls{/number}","milestones_url":"https://api.github.com/repos/yeskunall/is/milestones{/number}","notifications_url":"https://api.github.com/repos/yeskunall/is/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeskunall/is/labels{/name}","releases_url":"https://api.github.com/repos/yeskunall/is/releases{/id}","deployments_url":"https://api.github.com/repos/yeskunall/is/deployments","created_at":"2017-09-23T22:42:38Z","updated_at":"2017-09-23T22:42:40Z","pushed_at":"2017-10-19T22:53:56Z","git_url":"git://github.com/yeskunall/is.git","ssh_url":"git@github.com:yeskunall/is.git","clone_url":"https://github.com/yeskunall/is.git","svn_url":"https://github.com/yeskunall/is","homepage":null,"size":958,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"cdd4829edfec08131dade41ab353b7f1d004f8ff","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars1.githubusercontent.com/u/170270?v=4","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":104379939,"name":"is","full_name":"sindresorhus/is","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars1.githubusercontent.com/u/170270?v=4","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/is","description":"Type check values: `is.string('🦄') //=> true`","fork":false,"url":"https://api.github.com/repos/sindresorhus/is","forks_url":"https://api.github.com/repos/sindresorhus/is/forks","keys_url":"https://api.github.com/repos/sindresorhus/is/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/is/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/is/teams","hooks_url":"https://api.github.com/repos/sindresorhus/is/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/is/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/is/events","assignees_url":"https://api.github.com/repos/sindresorhus/is/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/is/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/is/tags","blobs_url":"https://api.github.com/repos/sindresorhus/is/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/is/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/is/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/is/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/is/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/is/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/is/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/is/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/is/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/is/subscription","commits_url":"https://api.github.com/repos/sindresorhus/is/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/is/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/is/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/is/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/is/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/is/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/is/merges","archive_url":"https://api.github.com/repos/sindresorhus/is/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/is/downloads","issues_url":"https://api.github.com/repos/sindresorhus/is/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/is/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/is/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/is/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/is/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/is/releases{/id}","deployments_url":"https://api.github.com/repos/sindresorhus/is/deployments","created_at":"2017-09-21T17:46:08Z","updated_at":"2017-10-19T08:24:26Z","pushed_at":"2017-10-19T22:55:41Z","git_url":"git://github.com/sindresorhus/is.git","ssh_url":"git@github.com:sindresorhus/is.git","clone_url":"https://github.com/sindresorhus/is.git","svn_url":"https://github.com/sindresorhus/is","homepage":null,"size":959,"stargazers_count":301,"watchers_count":301,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":4,"forks":17,"open_issues":4,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/is/pulls/24"},"html":{"href":"https://github.com/sindresorhus/is/pull/24"},"issue":{"href":"https://api.github.com/repos/sindresorhus/is/issues/24"},"comments":{"href":"https://api.github.com/repos/sindresorhus/is/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/is/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/is/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/is/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/is/statuses/e13599e5d7c9b680f34d6cdf3c1ef9bd25adc19d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brandon93s"}}