{"action":"created","comment":{"url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/comments/104799076","pull_request_review_id":25651813,"id":104799076,"diff_hunk":"@@ -135,7 +134,7 @@ type API = ReqBody '[JSON] String :> Post '[JSON] String\n api :: Proxy API\n api = Proxy\n \n-type ParamsAPI = QueryParam \"one\" String :> QueryParam \"two\" String :> Get '[JSON] String\n+type ParamsAPI = QueryParam \"one\" String :> QueryParam \"two\" String :> Get '[JSON] ()","path":"test/Servant/QuickCheck/InternalSpec.hs","position":null,"original_position":24,"commit_id":"6be669716544e279fc248c0bc5e4d1d4fb6a1563","original_commit_id":"6be669716544e279fc248c0bc5e4d1d4fb6a1563","user":{"login":"declension","id":3322808,"avatar_url":"https://avatars3.githubusercontent.com/u/3322808?v=3","gravatar_id":"","url":"https://api.github.com/users/declension","html_url":"https://github.com/declension","followers_url":"https://api.github.com/users/declension/followers","following_url":"https://api.github.com/users/declension/following{/other_user}","gists_url":"https://api.github.com/users/declension/gists{/gist_id}","starred_url":"https://api.github.com/users/declension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/declension/subscriptions","organizations_url":"https://api.github.com/users/declension/orgs","repos_url":"https://api.github.com/users/declension/repos","events_url":"https://api.github.com/users/declension/events{/privacy}","received_events_url":"https://api.github.com/users/declension/received_events","type":"User","site_admin":false},"body":"Riiiiight. That's better too - I'll update the PR.\r\n\r\nIn fact I've realised that the bug also applies to `QueryFlag`s so will replicate for those (almost identical)","created_at":"2017-03-07T22:37:27Z","updated_at":"2017-03-07T22:37:27Z","html_url":"https://github.com/haskell-servant/servant-quickcheck/pull/24#discussion_r104799076","pull_request_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/comments/104799076"},"html":{"href":"https://github.com/haskell-servant/servant-quickcheck/pull/24#discussion_r104799076"},"pull_request":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24","id":109258973,"html_url":"https://github.com/haskell-servant/servant-quickcheck/pull/24","diff_url":"https://github.com/haskell-servant/servant-quickcheck/pull/24.diff","patch_url":"https://github.com/haskell-servant/servant-quickcheck/pull/24.patch","issue_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/issues/24","number":24,"state":"open","locked":false,"title":"Fix multiple QueryParams","user":{"login":"declension","id":3322808,"avatar_url":"https://avatars3.githubusercontent.com/u/3322808?v=3","gravatar_id":"","url":"https://api.github.com/users/declension","html_url":"https://github.com/declension","followers_url":"https://api.github.com/users/declension/followers","following_url":"https://api.github.com/users/declension/following{/other_user}","gists_url":"https://api.github.com/users/declension/gists{/gist_id}","starred_url":"https://api.github.com/users/declension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/declension/subscriptions","organizations_url":"https://api.github.com/users/declension/orgs","repos_url":"https://api.github.com/users/declension/repos","events_url":"https://api.github.com/users/declension/events{/privacy}","received_events_url":"https://api.github.com/users/declension/received_events","type":"User","site_admin":false},"body":" * Add test API taking multiple `QueryParam`s\r\n * Add basic test using this API, generating an endpoint to ensure correct HTTP `one=foo&two=bar` query string generation is happening (that fails on `master`)\r\n * Fix (re)creation of query string to append `&` before the new parameter if there is already a built query string.\r\n\r\nFixes #23.","created_at":"2017-03-06T13:33:50Z","updated_at":"2017-03-07T22:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06ac4ef833a4d002d48517ec8b99a804070b00b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24/commits","review_comments_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24/comments","review_comment_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/issues/24/comments","statuses_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/statuses/6be669716544e279fc248c0bc5e4d1d4fb6a1563","head":{"label":"declension:23-fix-queryparams","ref":"23-fix-queryparams","sha":"6be669716544e279fc248c0bc5e4d1d4fb6a1563","user":{"login":"declension","id":3322808,"avatar_url":"https://avatars3.githubusercontent.com/u/3322808?v=3","gravatar_id":"","url":"https://api.github.com/users/declension","html_url":"https://github.com/declension","followers_url":"https://api.github.com/users/declension/followers","following_url":"https://api.github.com/users/declension/following{/other_user}","gists_url":"https://api.github.com/users/declension/gists{/gist_id}","starred_url":"https://api.github.com/users/declension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/declension/subscriptions","organizations_url":"https://api.github.com/users/declension/orgs","repos_url":"https://api.github.com/users/declension/repos","events_url":"https://api.github.com/users/declension/events{/privacy}","received_events_url":"https://api.github.com/users/declension/received_events","type":"User","site_admin":false},"repo":{"id":84071701,"name":"servant-quickcheck","full_name":"declension/servant-quickcheck","owner":{"login":"declension","id":3322808,"avatar_url":"https://avatars3.githubusercontent.com/u/3322808?v=3","gravatar_id":"","url":"https://api.github.com/users/declension","html_url":"https://github.com/declension","followers_url":"https://api.github.com/users/declension/followers","following_url":"https://api.github.com/users/declension/following{/other_user}","gists_url":"https://api.github.com/users/declension/gists{/gist_id}","starred_url":"https://api.github.com/users/declension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/declension/subscriptions","organizations_url":"https://api.github.com/users/declension/orgs","repos_url":"https://api.github.com/users/declension/repos","events_url":"https://api.github.com/users/declension/events{/privacy}","received_events_url":"https://api.github.com/users/declension/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/declension/servant-quickcheck","description":null,"fork":true,"url":"https://api.github.com/repos/declension/servant-quickcheck","forks_url":"https://api.github.com/repos/declension/servant-quickcheck/forks","keys_url":"https://api.github.com/repos/declension/servant-quickcheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/declension/servant-quickcheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/declension/servant-quickcheck/teams","hooks_url":"https://api.github.com/repos/declension/servant-quickcheck/hooks","issue_events_url":"https://api.github.com/repos/declension/servant-quickcheck/issues/events{/number}","events_url":"https://api.github.com/repos/declension/servant-quickcheck/events","assignees_url":"https://api.github.com/repos/declension/servant-quickcheck/assignees{/user}","branches_url":"https://api.github.com/repos/declension/servant-quickcheck/branches{/branch}","tags_url":"https://api.github.com/repos/declension/servant-quickcheck/tags","blobs_url":"https://api.github.com/repos/declension/servant-quickcheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/declension/servant-quickcheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/declension/servant-quickcheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/declension/servant-quickcheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/declension/servant-quickcheck/statuses/{sha}","languages_url":"https://api.github.com/repos/declension/servant-quickcheck/languages","stargazers_url":"https://api.github.com/repos/declension/servant-quickcheck/stargazers","contributors_url":"https://api.github.com/repos/declension/servant-quickcheck/contributors","subscribers_url":"https://api.github.com/repos/declension/servant-quickcheck/subscribers","subscription_url":"https://api.github.com/repos/declension/servant-quickcheck/subscription","commits_url":"https://api.github.com/repos/declension/servant-quickcheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/declension/servant-quickcheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/declension/servant-quickcheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/declension/servant-quickcheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/declension/servant-quickcheck/contents/{+path}","compare_url":"https://api.github.com/repos/declension/servant-quickcheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/declension/servant-quickcheck/merges","archive_url":"https://api.github.com/repos/declension/servant-quickcheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/declension/servant-quickcheck/downloads","issues_url":"https://api.github.com/repos/declension/servant-quickcheck/issues{/number}","pulls_url":"https://api.github.com/repos/declension/servant-quickcheck/pulls{/number}","milestones_url":"https://api.github.com/repos/declension/servant-quickcheck/milestones{/number}","notifications_url":"https://api.github.com/repos/declension/servant-quickcheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/declension/servant-quickcheck/labels{/name}","releases_url":"https://api.github.com/repos/declension/servant-quickcheck/releases{/id}","deployments_url":"https://api.github.com/repos/declension/servant-quickcheck/deployments","created_at":"2017-03-06T12:40:20Z","updated_at":"2017-03-06T12:40:22Z","pushed_at":"2017-03-07T21:25:19Z","git_url":"git://github.com/declension/servant-quickcheck.git","ssh_url":"git@github.com:declension/servant-quickcheck.git","clone_url":"https://github.com/declension/servant-quickcheck.git","svn_url":"https://github.com/declension/servant-quickcheck","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell-servant:master","ref":"master","sha":"47391784ceb6c27c39026b3243078b7c0abfa662","user":{"login":"haskell-servant","id":10049283,"avatar_url":"https://avatars3.githubusercontent.com/u/10049283?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-servant","html_url":"https://github.com/haskell-servant","followers_url":"https://api.github.com/users/haskell-servant/followers","following_url":"https://api.github.com/users/haskell-servant/following{/other_user}","gists_url":"https://api.github.com/users/haskell-servant/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-servant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-servant/subscriptions","organizations_url":"https://api.github.com/users/haskell-servant/orgs","repos_url":"https://api.github.com/users/haskell-servant/repos","events_url":"https://api.github.com/users/haskell-servant/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-servant/received_events","type":"Organization","site_admin":false},"repo":{"id":56890476,"name":"servant-quickcheck","full_name":"haskell-servant/servant-quickcheck","owner":{"login":"haskell-servant","id":10049283,"avatar_url":"https://avatars3.githubusercontent.com/u/10049283?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-servant","html_url":"https://github.com/haskell-servant","followers_url":"https://api.github.com/users/haskell-servant/followers","following_url":"https://api.github.com/users/haskell-servant/following{/other_user}","gists_url":"https://api.github.com/users/haskell-servant/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-servant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-servant/subscriptions","organizations_url":"https://api.github.com/users/haskell-servant/orgs","repos_url":"https://api.github.com/users/haskell-servant/repos","events_url":"https://api.github.com/users/haskell-servant/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-servant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell-servant/servant-quickcheck","description":null,"fork":false,"url":"https://api.github.com/repos/haskell-servant/servant-quickcheck","forks_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/forks","keys_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/teams","hooks_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/hooks","issue_events_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/events","assignees_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/tags","blobs_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/languages","stargazers_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/stargazers","contributors_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/contributors","subscribers_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/subscribers","subscription_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/subscription","commits_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/merges","archive_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/downloads","issues_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/labels{/name}","releases_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/releases{/id}","deployments_url":"https://api.github.com/repos/haskell-servant/servant-quickcheck/deployments","created_at":"2016-04-22T23:21:20Z","updated_at":"2017-02-09T10:11:19Z","pushed_at":"2017-03-07T21:25:20Z","git_url":"git://github.com/haskell-servant/servant-quickcheck.git","ssh_url":"git@github.com:haskell-servant/servant-quickcheck.git","clone_url":"https://github.com/haskell-servant/servant-quickcheck.git","svn_url":"https://github.com/haskell-servant/servant-quickcheck","homepage":null,"size":107,"stargazers_count":11,"watchers_count":11,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24"},"html":{"href":"https://github.com/haskell-servant/servant-quickcheck/pull/24"},"issue":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/issues/24"},"comments":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/haskell-servant/servant-quickcheck/statuses/6be669716544e279fc248c0bc5e4d1d4fb6a1563"}}}}
{"actor":{"display_login":"declension"}}