{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/96034398","pull_request_review_id":16610416,"id":96034398,"diff_hunk":"@@ -68,15 +93,15 @@ struct base_uint_test : beast::unit_test::suite\n         {\n             BEAST_EXPECT(d == --t);\n         }","path":"src/test/basics/base_uint_test.cpp","position":79,"original_position":79,"commit_id":"1e3f3b23f61d9eabb54033f2bb12c245c075850d","original_commit_id":"1e3f3b23f61d9eabb54033f2bb12c245c075850d","user":{"login":"mwshortt","id":8865272,"avatar_url":"https://avatars.githubusercontent.com/u/8865272?v=3","gravatar_id":"","url":"https://api.github.com/users/mwshortt","html_url":"https://github.com/mwshortt","followers_url":"https://api.github.com/users/mwshortt/followers","following_url":"https://api.github.com/users/mwshortt/following{/other_user}","gists_url":"https://api.github.com/users/mwshortt/gists{/gist_id}","starred_url":"https://api.github.com/users/mwshortt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwshortt/subscriptions","organizations_url":"https://api.github.com/users/mwshortt/orgs","repos_url":"https://api.github.com/users/mwshortt/repos","events_url":"https://api.github.com/users/mwshortt/events{/privacy}","received_events_url":"https://api.github.com/users/mwshortt/received_events","type":"User","site_admin":false},"body":"Sure! I see some test format duplication in these three blocks: \r\nhttps://github.com/mellery451/rippled/blob/1e3f3b23f61d9eabb54033f2bb12c245c075850d/src/test/basics/base_uint_test.cpp#L64-L76\r\nhttps://github.com/mellery451/rippled/blob/1e3f3b23f61d9eabb54033f2bb12c245c075850d/src/test/basics/base_uint_test.cpp#L84-L95\r\nhttps://github.com/mellery451/rippled/blob/1e3f3b23f61d9eabb54033f2bb12c245c075850d/src/test/basics/base_uint_test.cpp#L104-L116\r\nThey are testing different items, but the expects are very similar. \r\nI was wondering what your thoughts were about abstracting the duplicate test functionality into a separate function versus leaving it as is.","created_at":"2017-01-13T17:22:31Z","updated_at":"2017-01-13T17:22:31Z","html_url":"https://github.com/ripple/rippled/pull/1962#discussion_r96034398","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1962","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/96034398"},"html":{"href":"https://github.com/ripple/rippled/pull/1962#discussion_r96034398"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1962"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1962","id":100942318,"html_url":"https://github.com/ripple/rippled/pull/1962","diff_url":"https://github.com/ripple/rippled/pull/1962.diff","patch_url":"https://github.com/ripple/rippled/pull/1962.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1962","number":1962,"state":"open","locked":false,"title":"Eliminate protocol header dependency (RIPD-1234):","user":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"body":"Eliminate checks using sha512half, add coverage for xor and SetHex.","created_at":"2017-01-10T19:55:19Z","updated_at":"2017-01-13T17:22:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6453f0e1c1d91653d28c86f73fb7dbd3c0c2b8b4","assignee":{"login":"mwshortt","id":8865272,"avatar_url":"https://avatars.githubusercontent.com/u/8865272?v=3","gravatar_id":"","url":"https://api.github.com/users/mwshortt","html_url":"https://github.com/mwshortt","followers_url":"https://api.github.com/users/mwshortt/followers","following_url":"https://api.github.com/users/mwshortt/following{/other_user}","gists_url":"https://api.github.com/users/mwshortt/gists{/gist_id}","starred_url":"https://api.github.com/users/mwshortt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwshortt/subscriptions","organizations_url":"https://api.github.com/users/mwshortt/orgs","repos_url":"https://api.github.com/users/mwshortt/repos","events_url":"https://api.github.com/users/mwshortt/events{/privacy}","received_events_url":"https://api.github.com/users/mwshortt/received_events","type":"User","site_admin":false},"assignees":[{"login":"mwshortt","id":8865272,"avatar_url":"https://avatars.githubusercontent.com/u/8865272?v=3","gravatar_id":"","url":"https://api.github.com/users/mwshortt","html_url":"https://github.com/mwshortt","followers_url":"https://api.github.com/users/mwshortt/followers","following_url":"https://api.github.com/users/mwshortt/following{/other_user}","gists_url":"https://api.github.com/users/mwshortt/gists{/gist_id}","starred_url":"https://api.github.com/users/mwshortt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwshortt/subscriptions","organizations_url":"https://api.github.com/users/mwshortt/orgs","repos_url":"https://api.github.com/users/mwshortt/repos","events_url":"https://api.github.com/users/mwshortt/events{/privacy}","received_events_url":"https://api.github.com/users/mwshortt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1962/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1962/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1962/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/1e3f3b23f61d9eabb54033f2bb12c245c075850d","head":{"label":"mellery451:l10n_basic_uint","ref":"l10n_basic_uint","sha":"1e3f3b23f61d9eabb54033f2bb12c245c075850d","user":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"repo":{"id":63169724,"name":"rippled","full_name":"mellery451/rippled","owner":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mellery451/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/mellery451/rippled","forks_url":"https://api.github.com/repos/mellery451/rippled/forks","keys_url":"https://api.github.com/repos/mellery451/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mellery451/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mellery451/rippled/teams","hooks_url":"https://api.github.com/repos/mellery451/rippled/hooks","issue_events_url":"https://api.github.com/repos/mellery451/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/mellery451/rippled/events","assignees_url":"https://api.github.com/repos/mellery451/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/mellery451/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/mellery451/rippled/tags","blobs_url":"https://api.github.com/repos/mellery451/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mellery451/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mellery451/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/mellery451/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mellery451/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/mellery451/rippled/languages","stargazers_url":"https://api.github.com/repos/mellery451/rippled/stargazers","contributors_url":"https://api.github.com/repos/mellery451/rippled/contributors","subscribers_url":"https://api.github.com/repos/mellery451/rippled/subscribers","subscription_url":"https://api.github.com/repos/mellery451/rippled/subscription","commits_url":"https://api.github.com/repos/mellery451/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/mellery451/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/mellery451/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/mellery451/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/mellery451/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/mellery451/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mellery451/rippled/merges","archive_url":"https://api.github.com/repos/mellery451/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mellery451/rippled/downloads","issues_url":"https://api.github.com/repos/mellery451/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/mellery451/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/mellery451/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/mellery451/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mellery451/rippled/labels{/name}","releases_url":"https://api.github.com/repos/mellery451/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/mellery451/rippled/deployments","created_at":"2016-07-12T15:29:01Z","updated_at":"2016-07-12T15:29:12Z","pushed_at":"2017-01-13T16:40:02Z","git_url":"git://github.com/mellery451/rippled.git","ssh_url":"git@github.com:mellery451/rippled.git","clone_url":"https://github.com/mellery451/rippled.git","svn_url":"https://github.com/mellery451/rippled","homepage":"https://ripple.com","size":79786,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"87273e21d83b3ad72b184cae6c99cf4895b42dc0","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the Ripple Consensus Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2017-01-12T14:52:22Z","pushed_at":"2017-01-13T02:46:31Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":79785,"stargazers_count":1202,"watchers_count":1202,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":381,"mirror_url":null,"open_issues_count":135,"forks":381,"open_issues":135,"watchers":1202,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1962"},"html":{"href":"https://github.com/ripple/rippled/pull/1962"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1962"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1962/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1962/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1962/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/1e3f3b23f61d9eabb54033f2bb12c245c075850d"}}}}
{"actor":{"display_login":"mwshortt"}}