{"action":"created","comment":{"url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments/149194743","pull_request_review_id":74551674,"id":149194743,"diff_hunk":"@@ -48,7 +49,9 @@ module.exports = {\n     ];\n \n     // keeping old legacy videoRaw\n-    const showTimer = options.videoRaw ? false : options.videoParams.addTimer;\n+    const showTimer = options.videoRaw\n+      ? false\n+      : options.videoParams.addTimer || videoDefaults.addTimer;","path":"lib/support/video/finetune/ffmpegRemoveOrangeAndAddText.js","position":17,"original_position":17,"commit_id":"e72dbd19defdf17b8bdbbcc69164ac15dfff3a82","original_commit_id":"e72dbd19defdf17b8bdbbcc69164ac15dfff3a82","user":{"login":"tobli","id":540266,"avatar_url":"https://avatars3.githubusercontent.com/u/540266?v=4","gravatar_id":"","url":"https://api.github.com/users/tobli","html_url":"https://github.com/tobli","followers_url":"https://api.github.com/users/tobli/followers","following_url":"https://api.github.com/users/tobli/following{/other_user}","gists_url":"https://api.github.com/users/tobli/gists{/gist_id}","starred_url":"https://api.github.com/users/tobli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobli/subscriptions","organizations_url":"https://api.github.com/users/tobli/orgs","repos_url":"https://api.github.com/users/tobli/repos","events_url":"https://api.github.com/users/tobli/events{/privacy}","received_events_url":"https://api.github.com/users/tobli/received_events","type":"User","site_admin":false},"body":"This is incorrect. showTimer will be set to true for the following case:\r\n```\r\noptions = {\r\nvideoParams: {addTimer: false}\r\n}\r\n```","created_at":"2017-11-06T20:31:47Z","updated_at":"2017-11-06T20:31:47Z","html_url":"https://github.com/sitespeedio/browsertime/pull/394#discussion_r149194743","pull_request_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments/149194743"},"html":{"href":"https://github.com/sitespeedio/browsertime/pull/394#discussion_r149194743"},"pull_request":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394","id":150869736,"html_url":"https://github.com/sitespeedio/browsertime/pull/394","diff_url":"https://github.com/sitespeedio/browsertime/pull/394.diff","patch_url":"https://github.com/sitespeedio/browsertime/pull/394.patch","issue_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/394","number":394,"state":"closed","locked":false,"title":"Use default values instead of taking undefined from cli","user":{"login":"soulgalore","id":540757,"avatar_url":"https://avatars2.githubusercontent.com/u/540757?v=4","gravatar_id":"","url":"https://api.github.com/users/soulgalore","html_url":"https://github.com/soulgalore","followers_url":"https://api.github.com/users/soulgalore/followers","following_url":"https://api.github.com/users/soulgalore/following{/other_user}","gists_url":"https://api.github.com/users/soulgalore/gists{/gist_id}","starred_url":"https://api.github.com/users/soulgalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulgalore/subscriptions","organizations_url":"https://api.github.com/users/soulgalore/orgs","repos_url":"https://api.github.com/users/soulgalore/repos","events_url":"https://api.github.com/users/soulgalore/events{/privacy}","received_events_url":"https://api.github.com/users/soulgalore/received_events","type":"User","site_admin":false},"body":"Lets add these values as constants before we merge. Then we can remove these defaults in sitespeed.io and have cleaner code.","created_at":"2017-11-06T14:44:49Z","updated_at":"2017-11-06T20:31:47Z","closed_at":"2017-11-06T20:14:35Z","merged_at":"2017-11-06T20:14:35Z","merge_commit_sha":"7b6f8c3997f8e0d8b2bfa9b13af849e3c592a846","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394/commits","review_comments_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394/comments","review_comment_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/394/comments","statuses_url":"https://api.github.com/repos/sitespeedio/browsertime/statuses/e72dbd19defdf17b8bdbbcc69164ac15dfff3a82","head":{"label":"sitespeedio:add-defaults","ref":"add-defaults","sha":"e72dbd19defdf17b8bdbbcc69164ac15dfff3a82","user":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars3.githubusercontent.com/u/5693541?v=4","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"repo":{"id":12298355,"name":"browsertime","full_name":"sitespeedio/browsertime","owner":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars3.githubusercontent.com/u/5693541?v=4","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sitespeedio/browsertime","description":"Your browser, your page, your scripts!","fork":false,"url":"https://api.github.com/repos/sitespeedio/browsertime","forks_url":"https://api.github.com/repos/sitespeedio/browsertime/forks","keys_url":"https://api.github.com/repos/sitespeedio/browsertime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sitespeedio/browsertime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sitespeedio/browsertime/teams","hooks_url":"https://api.github.com/repos/sitespeedio/browsertime/hooks","issue_events_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/events{/number}","events_url":"https://api.github.com/repos/sitespeedio/browsertime/events","assignees_url":"https://api.github.com/repos/sitespeedio/browsertime/assignees{/user}","branches_url":"https://api.github.com/repos/sitespeedio/browsertime/branches{/branch}","tags_url":"https://api.github.com/repos/sitespeedio/browsertime/tags","blobs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sitespeedio/browsertime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/refs{/sha}","trees_url":"https://api.github.com/repos/sitespeedio/browsertime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sitespeedio/browsertime/statuses/{sha}","languages_url":"https://api.github.com/repos/sitespeedio/browsertime/languages","stargazers_url":"https://api.github.com/repos/sitespeedio/browsertime/stargazers","contributors_url":"https://api.github.com/repos/sitespeedio/browsertime/contributors","subscribers_url":"https://api.github.com/repos/sitespeedio/browsertime/subscribers","subscription_url":"https://api.github.com/repos/sitespeedio/browsertime/subscription","commits_url":"https://api.github.com/repos/sitespeedio/browsertime/commits{/sha}","git_commits_url":"https://api.github.com/repos/sitespeedio/browsertime/git/commits{/sha}","comments_url":"https://api.github.com/repos/sitespeedio/browsertime/comments{/number}","issue_comment_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/comments{/number}","contents_url":"https://api.github.com/repos/sitespeedio/browsertime/contents/{+path}","compare_url":"https://api.github.com/repos/sitespeedio/browsertime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sitespeedio/browsertime/merges","archive_url":"https://api.github.com/repos/sitespeedio/browsertime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sitespeedio/browsertime/downloads","issues_url":"https://api.github.com/repos/sitespeedio/browsertime/issues{/number}","pulls_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls{/number}","milestones_url":"https://api.github.com/repos/sitespeedio/browsertime/milestones{/number}","notifications_url":"https://api.github.com/repos/sitespeedio/browsertime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sitespeedio/browsertime/labels{/name}","releases_url":"https://api.github.com/repos/sitespeedio/browsertime/releases{/id}","deployments_url":"https://api.github.com/repos/sitespeedio/browsertime/deployments","created_at":"2013-08-22T14:00:15Z","updated_at":"2017-10-29T12:03:35Z","pushed_at":"2017-11-06T20:25:48Z","git_url":"git://github.com/sitespeedio/browsertime.git","ssh_url":"git@github.com:sitespeedio/browsertime.git","clone_url":"https://github.com/sitespeedio/browsertime.git","svn_url":"https://github.com/sitespeedio/browsertime","homepage":"","size":84353,"stargazers_count":238,"watchers_count":238,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":31,"forks":46,"open_issues":31,"watchers":238,"default_branch":"master"}},"base":{"label":"sitespeedio:master","ref":"master","sha":"a31a719244e3c1109323fe386aea264a76b6825e","user":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars3.githubusercontent.com/u/5693541?v=4","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"repo":{"id":12298355,"name":"browsertime","full_name":"sitespeedio/browsertime","owner":{"login":"sitespeedio","id":5693541,"avatar_url":"https://avatars3.githubusercontent.com/u/5693541?v=4","gravatar_id":"","url":"https://api.github.com/users/sitespeedio","html_url":"https://github.com/sitespeedio","followers_url":"https://api.github.com/users/sitespeedio/followers","following_url":"https://api.github.com/users/sitespeedio/following{/other_user}","gists_url":"https://api.github.com/users/sitespeedio/gists{/gist_id}","starred_url":"https://api.github.com/users/sitespeedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitespeedio/subscriptions","organizations_url":"https://api.github.com/users/sitespeedio/orgs","repos_url":"https://api.github.com/users/sitespeedio/repos","events_url":"https://api.github.com/users/sitespeedio/events{/privacy}","received_events_url":"https://api.github.com/users/sitespeedio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sitespeedio/browsertime","description":"Your browser, your page, your scripts!","fork":false,"url":"https://api.github.com/repos/sitespeedio/browsertime","forks_url":"https://api.github.com/repos/sitespeedio/browsertime/forks","keys_url":"https://api.github.com/repos/sitespeedio/browsertime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sitespeedio/browsertime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sitespeedio/browsertime/teams","hooks_url":"https://api.github.com/repos/sitespeedio/browsertime/hooks","issue_events_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/events{/number}","events_url":"https://api.github.com/repos/sitespeedio/browsertime/events","assignees_url":"https://api.github.com/repos/sitespeedio/browsertime/assignees{/user}","branches_url":"https://api.github.com/repos/sitespeedio/browsertime/branches{/branch}","tags_url":"https://api.github.com/repos/sitespeedio/browsertime/tags","blobs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sitespeedio/browsertime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sitespeedio/browsertime/git/refs{/sha}","trees_url":"https://api.github.com/repos/sitespeedio/browsertime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sitespeedio/browsertime/statuses/{sha}","languages_url":"https://api.github.com/repos/sitespeedio/browsertime/languages","stargazers_url":"https://api.github.com/repos/sitespeedio/browsertime/stargazers","contributors_url":"https://api.github.com/repos/sitespeedio/browsertime/contributors","subscribers_url":"https://api.github.com/repos/sitespeedio/browsertime/subscribers","subscription_url":"https://api.github.com/repos/sitespeedio/browsertime/subscription","commits_url":"https://api.github.com/repos/sitespeedio/browsertime/commits{/sha}","git_commits_url":"https://api.github.com/repos/sitespeedio/browsertime/git/commits{/sha}","comments_url":"https://api.github.com/repos/sitespeedio/browsertime/comments{/number}","issue_comment_url":"https://api.github.com/repos/sitespeedio/browsertime/issues/comments{/number}","contents_url":"https://api.github.com/repos/sitespeedio/browsertime/contents/{+path}","compare_url":"https://api.github.com/repos/sitespeedio/browsertime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sitespeedio/browsertime/merges","archive_url":"https://api.github.com/repos/sitespeedio/browsertime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sitespeedio/browsertime/downloads","issues_url":"https://api.github.com/repos/sitespeedio/browsertime/issues{/number}","pulls_url":"https://api.github.com/repos/sitespeedio/browsertime/pulls{/number}","milestones_url":"https://api.github.com/repos/sitespeedio/browsertime/milestones{/number}","notifications_url":"https://api.github.com/repos/sitespeedio/browsertime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sitespeedio/browsertime/labels{/name}","releases_url":"https://api.github.com/repos/sitespeedio/browsertime/releases{/id}","deployments_url":"https://api.github.com/repos/sitespeedio/browsertime/deployments","created_at":"2013-08-22T14:00:15Z","updated_at":"2017-10-29T12:03:35Z","pushed_at":"2017-11-06T20:25:48Z","git_url":"git://github.com/sitespeedio/browsertime.git","ssh_url":"git@github.com:sitespeedio/browsertime.git","clone_url":"https://github.com/sitespeedio/browsertime.git","svn_url":"https://github.com/sitespeedio/browsertime","homepage":"","size":84353,"stargazers_count":238,"watchers_count":238,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":31,"forks":46,"open_issues":31,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394"},"html":{"href":"https://github.com/sitespeedio/browsertime/pull/394"},"issue":{"href":"https://api.github.com/repos/sitespeedio/browsertime/issues/394"},"comments":{"href":"https://api.github.com/repos/sitespeedio/browsertime/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sitespeedio/browsertime/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/sitespeedio/browsertime/statuses/e72dbd19defdf17b8bdbbcc69164ac15dfff3a82"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tobli"}}