{"action":"closed","number":2309,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/2309","id":120672689,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2309","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2309.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2309.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2309","number":2309,"state":"closed","locked":false,"title":"logging: omit resource from each log entry","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars2.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"Following from https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2305, we can do the same optimization for the resource. We don't need to attach the resource to each entry if we instead attach it to the `entries.write` call. This should reduce the on-the-wire packet size and will be marginally faster.\r\n\r\nAs a result, there is nothing async left in `Log.prototype.decorateEntries_` so I have converted it to a sync function.\r\n\r\nIt would be easier to review each commit individually.","created_at":"2017-05-15T19:10:44Z","updated_at":"2017-05-17T17:25:56Z","closed_at":"2017-05-17T17:25:56Z","merged_at":"2017-05-17T17:25:56Z","merge_commit_sha":"08cdfe09d391c9200ff61bf7e51961b7e96f0e46","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/2309/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/2309/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2309/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/statuses/fa9dcd6980bb98deccb6e160fb1ecf81d84d93fe","head":{"label":"ofrobots:omit-resource","ref":"omit-resource","sha":"fa9dcd6980bb98deccb6e160fb1ecf81d84d93fe","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars2.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"repo":{"id":37570480,"name":"google-cloud-node","full_name":"ofrobots/google-cloud-node","owner":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars2.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ofrobots/google-cloud-node","description":"Google Cloud Client Library for Node.js","fork":true,"url":"https://api.github.com/repos/ofrobots/google-cloud-node","forks_url":"https://api.github.com/repos/ofrobots/google-cloud-node/forks","keys_url":"https://api.github.com/repos/ofrobots/google-cloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofrobots/google-cloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofrobots/google-cloud-node/teams","hooks_url":"https://api.github.com/repos/ofrobots/google-cloud-node/hooks","issue_events_url":"https://api.github.com/repos/ofrobots/google-cloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/ofrobots/google-cloud-node/events","assignees_url":"https://api.github.com/repos/ofrobots/google-cloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/ofrobots/google-cloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/ofrobots/google-cloud-node/tags","blobs_url":"https://api.github.com/repos/ofrobots/google-cloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofrobots/google-cloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofrobots/google-cloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofrobots/google-cloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofrobots/google-cloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/ofrobots/google-cloud-node/languages","stargazers_url":"https://api.github.com/repos/ofrobots/google-cloud-node/stargazers","contributors_url":"https://api.github.com/repos/ofrobots/google-cloud-node/contributors","subscribers_url":"https://api.github.com/repos/ofrobots/google-cloud-node/subscribers","subscription_url":"https://api.github.com/repos/ofrobots/google-cloud-node/subscription","commits_url":"https://api.github.com/repos/ofrobots/google-cloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofrobots/google-cloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofrobots/google-cloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofrobots/google-cloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofrobots/google-cloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/ofrobots/google-cloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofrobots/google-cloud-node/merges","archive_url":"https://api.github.com/repos/ofrobots/google-cloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofrobots/google-cloud-node/downloads","issues_url":"https://api.github.com/repos/ofrobots/google-cloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/ofrobots/google-cloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/ofrobots/google-cloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/ofrobots/google-cloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofrobots/google-cloud-node/labels{/name}","releases_url":"https://api.github.com/repos/ofrobots/google-cloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/ofrobots/google-cloud-node/deployments","created_at":"2015-06-17T03:31:54Z","updated_at":"2016-11-22T20:12:14Z","pushed_at":"2017-05-17T16:27:04Z","git_url":"git://github.com/ofrobots/google-cloud-node.git","ssh_url":"git@github.com:ofrobots/google-cloud-node.git","clone_url":"https://github.com/ofrobots/google-cloud-node.git","svn_url":"https://github.com/ofrobots/google-cloud-node","homepage":"https://googlecloudplatform.github.io/gcloud-node/","size":19816,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"b1fbd2e53065f6574cfbfc5e87031a04196738fe","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19483273,"name":"google-cloud-node","full_name":"GoogleCloudPlatform/google-cloud-node","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-node","description":"Google Cloud Client Library for Node.js","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/deployments","created_at":"2014-05-06T06:18:00Z","updated_at":"2017-05-17T13:21:00Z","pushed_at":"2017-05-17T17:25:56Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-node.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-node.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-node.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-node","homepage":"https://googlecloudplatform.github.io/google-cloud-node/","size":21255,"stargazers_count":1351,"watchers_count":1351,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":309,"mirror_url":null,"open_issues_count":89,"forks":309,"open_issues":89,"watchers":1351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/2309"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2309"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2309"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2309/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/2309/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/2309/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/statuses/fa9dcd6980bb98deccb6e160fb1ecf81d84d93fe"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars3.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"comments":3,"review_comments":12,"maintainer_can_modify":false,"commits":8,"additions":77,"deletions":166,"changed_files":6}}
{"actor":{"display_login":"stephenplusplus"}}