{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/15","id":142656647,"html_url":"https://github.com/itszero/wdio-browserstack-service/pull/15","diff_url":"https://github.com/itszero/wdio-browserstack-service/pull/15.diff","patch_url":"https://github.com/itszero/wdio-browserstack-service/pull/15.patch","issue_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/issues/15","number":15,"state":"closed","locked":false,"title":"Resets session fail count on reload","user":{"login":"aliking","id":739776,"avatar_url":"https://avatars2.githubusercontent.com/u/739776?v=4","gravatar_id":"","url":"https://api.github.com/users/aliking","html_url":"https://github.com/aliking","followers_url":"https://api.github.com/users/aliking/followers","following_url":"https://api.github.com/users/aliking/following{/other_user}","gists_url":"https://api.github.com/users/aliking/gists{/gist_id}","starred_url":"https://api.github.com/users/aliking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliking/subscriptions","organizations_url":"https://api.github.com/users/aliking/orgs","repos_url":"https://api.github.com/users/aliking/repos","events_url":"https://api.github.com/users/aliking/events{/privacy}","received_events_url":"https://api.github.com/users/aliking/received_events","type":"User","site_admin":false},"body":"Hi, this fixes an issue that I'm seeing, but want to be sure I'm thinking of other people's cases.\r\n\r\nI've set up an example that is similar to my use case here: https://github.com/aliking/webdriverio-browserstack\r\n\r\nI'm using mocha bdd on browserstack, and I'm using a hook to reload before every example in my spec files, so that each has its own session. \r\n\r\nIf I run a test that has multiple examples in it, any examples that run after a fail also get marked failed on Browserstack. \r\n\r\nThat example has two spec files, each with two trivial examples: fail_pass.js has one example that fails, then one that passes. The other is called pass_fail.js (you get the idea). \r\n\r\nWhen I run it, my local reporting of the tests is correct; 2 passes, 2 fails. But on browserstack, there are 3 fails. \r\n\r\nThis seems like the simplest way to fix my issue. Can you think of other cases where you wouldn't want to reset the failure count on reload?","created_at":"2017-09-22T19:53:26Z","updated_at":"2017-10-24T19:37:48Z","closed_at":"2017-10-24T19:37:48Z","merged_at":null,"merge_commit_sha":"32dd7ece8adf02f55c550cbe463012dce0c8526e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/15/commits","review_comments_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/15/comments","review_comment_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/issues/15/comments","statuses_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/statuses/e9af5aeb089c9bbd46cf93f0d777cf82aca7b50c","head":{"label":"aliking:master","ref":"master","sha":"e9af5aeb089c9bbd46cf93f0d777cf82aca7b50c","user":{"login":"aliking","id":739776,"avatar_url":"https://avatars2.githubusercontent.com/u/739776?v=4","gravatar_id":"","url":"https://api.github.com/users/aliking","html_url":"https://github.com/aliking","followers_url":"https://api.github.com/users/aliking/followers","following_url":"https://api.github.com/users/aliking/following{/other_user}","gists_url":"https://api.github.com/users/aliking/gists{/gist_id}","starred_url":"https://api.github.com/users/aliking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliking/subscriptions","organizations_url":"https://api.github.com/users/aliking/orgs","repos_url":"https://api.github.com/users/aliking/repos","events_url":"https://api.github.com/users/aliking/events{/privacy}","received_events_url":"https://api.github.com/users/aliking/received_events","type":"User","site_admin":false},"repo":{"id":104492871,"name":"wdio-browserstack-service","full_name":"aliking/wdio-browserstack-service","owner":{"login":"aliking","id":739776,"avatar_url":"https://avatars2.githubusercontent.com/u/739776?v=4","gravatar_id":"","url":"https://api.github.com/users/aliking","html_url":"https://github.com/aliking","followers_url":"https://api.github.com/users/aliking/followers","following_url":"https://api.github.com/users/aliking/following{/other_user}","gists_url":"https://api.github.com/users/aliking/gists{/gist_id}","starred_url":"https://api.github.com/users/aliking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliking/subscriptions","organizations_url":"https://api.github.com/users/aliking/orgs","repos_url":"https://api.github.com/users/aliking/repos","events_url":"https://api.github.com/users/aliking/events{/privacy}","received_events_url":"https://api.github.com/users/aliking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aliking/wdio-browserstack-service","description":"WebdriverIO Browserstack Service","fork":true,"url":"https://api.github.com/repos/aliking/wdio-browserstack-service","forks_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/forks","keys_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/teams","hooks_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/hooks","issue_events_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/issues/events{/number}","events_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/events","assignees_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/assignees{/user}","branches_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/branches{/branch}","tags_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/tags","blobs_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/statuses/{sha}","languages_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/languages","stargazers_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/stargazers","contributors_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/contributors","subscribers_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/subscribers","subscription_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/subscription","commits_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/contents/{+path}","compare_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/merges","archive_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/downloads","issues_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/issues{/number}","pulls_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/pulls{/number}","milestones_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/milestones{/number}","notifications_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/labels{/name}","releases_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/releases{/id}","deployments_url":"https://api.github.com/repos/aliking/wdio-browserstack-service/deployments","created_at":"2017-09-22T15:57:40Z","updated_at":"2017-09-22T15:57:42Z","pushed_at":"2017-10-12T01:39:34Z","git_url":"git://github.com/aliking/wdio-browserstack-service.git","ssh_url":"git@github.com:aliking/wdio-browserstack-service.git","clone_url":"https://github.com/aliking/wdio-browserstack-service.git","svn_url":"https://github.com/aliking/wdio-browserstack-service","homepage":null,"size":42,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"itszero:master","ref":"master","sha":"8805e6e3cb9053909240afdfd7193bbc3e9beb85","user":{"login":"itszero","id":9305,"avatar_url":"https://avatars3.githubusercontent.com/u/9305?v=4","gravatar_id":"","url":"https://api.github.com/users/itszero","html_url":"https://github.com/itszero","followers_url":"https://api.github.com/users/itszero/followers","following_url":"https://api.github.com/users/itszero/following{/other_user}","gists_url":"https://api.github.com/users/itszero/gists{/gist_id}","starred_url":"https://api.github.com/users/itszero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itszero/subscriptions","organizations_url":"https://api.github.com/users/itszero/orgs","repos_url":"https://api.github.com/users/itszero/repos","events_url":"https://api.github.com/users/itszero/events{/privacy}","received_events_url":"https://api.github.com/users/itszero/received_events","type":"User","site_admin":false},"repo":{"id":64913071,"name":"wdio-browserstack-service","full_name":"itszero/wdio-browserstack-service","owner":{"login":"itszero","id":9305,"avatar_url":"https://avatars3.githubusercontent.com/u/9305?v=4","gravatar_id":"","url":"https://api.github.com/users/itszero","html_url":"https://github.com/itszero","followers_url":"https://api.github.com/users/itszero/followers","following_url":"https://api.github.com/users/itszero/following{/other_user}","gists_url":"https://api.github.com/users/itszero/gists{/gist_id}","starred_url":"https://api.github.com/users/itszero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itszero/subscriptions","organizations_url":"https://api.github.com/users/itszero/orgs","repos_url":"https://api.github.com/users/itszero/repos","events_url":"https://api.github.com/users/itszero/events{/privacy}","received_events_url":"https://api.github.com/users/itszero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itszero/wdio-browserstack-service","description":"WebdriverIO Browserstack Service","fork":false,"url":"https://api.github.com/repos/itszero/wdio-browserstack-service","forks_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/forks","keys_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/teams","hooks_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/hooks","issue_events_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/issues/events{/number}","events_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/events","assignees_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/assignees{/user}","branches_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/branches{/branch}","tags_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/tags","blobs_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/statuses/{sha}","languages_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/languages","stargazers_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/stargazers","contributors_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/contributors","subscribers_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/subscribers","subscription_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/subscription","commits_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/contents/{+path}","compare_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/merges","archive_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/downloads","issues_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/issues{/number}","pulls_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls{/number}","milestones_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/milestones{/number}","notifications_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/labels{/name}","releases_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/releases{/id}","deployments_url":"https://api.github.com/repos/itszero/wdio-browserstack-service/deployments","created_at":"2016-08-04T07:34:05Z","updated_at":"2017-04-13T22:01:53Z","pushed_at":"2017-10-24T19:36:56Z","git_url":"git://github.com/itszero/wdio-browserstack-service.git","ssh_url":"git@github.com:itszero/wdio-browserstack-service.git","clone_url":"https://github.com/itszero/wdio-browserstack-service.git","svn_url":"https://github.com/itszero/wdio-browserstack-service","homepage":null,"size":34,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":7,"open_issues":0,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/15"},"html":{"href":"https://github.com/itszero/wdio-browserstack-service/pull/15"},"issue":{"href":"https://api.github.com/repos/itszero/wdio-browserstack-service/issues/15"},"comments":{"href":"https://api.github.com/repos/itszero/wdio-browserstack-service/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/itszero/wdio-browserstack-service/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/itszero/wdio-browserstack-service/statuses/e9af5aeb089c9bbd46cf93f0d777cf82aca7b50c"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":10,"maintainer_can_modify":false,"commits":6,"additions":282,"deletions":10,"changed_files":4}}
{"actor":{"display_login":"itszero"}}