{"action":"created","comment":{"url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/comments/109647406","pull_request_review_id":30750432,"id":109647406,"diff_hunk":"@@ -0,0 +1,109 @@\n+import unittest\n+import os\n+from modules.amity import Amity, Room\n+from modules.person import Person, Fellow, Staff\n+from modules.room import Office, LivingSpace\n+\n+\n+class TestClassInheritance(unittest.TestCase):\n+    def setUp(self):\n+        self. test_amity = Amity\n+        self.test_person = Person\n+        self.fellow = Fellow\n+        self.staff = Staff\n+        self.living_space = LivingSpace\n+        self.office = Office\n+\n+    '''checks the class relationships'''\n+\n+    def test_office_is_subclass(self):\n+        self.assertIsInstance(Office, Room)\n+\n+    def test_living_space_is_subclass(self):\n+        self.assertIsInstance(LivingSpace, Room)\n+\n+    def test_room_is_subclass(self):\n+        self.assertIsInstance(Room, Amity)\n+\n+    def test_staff_is_subclass(self):\n+        self.assertIsInstance(Staff, Person)\n+\n+    def test_fellow_is_subclass(self):\n+        self.assertIsInstance(Fellow, Person)\n+\n+    def test_create_living_space(self):\n+        '''test if it creates living space and assert has 4 spaces'''\n+        self.assertEqual(self.living_space.create_room, 4)\n+\n+    def test_create_office(self):\n+        '''test if it creates office  and has 6 spaces'''\n+        self.assertEqual(self.office.create_room, [\"room name\"])\n+\n+    def test_room_is_office(self):\n+        '''test if room created is an office'''\n+        self.assertEqual(self.test_amity.create_room, {\"Valarys\":\"Office\"})\n+\n+    def test_room_is_living_space(self):\n+        '''test if room created is a living space'''\n+        self.assertEqual(self.test_amity.create_room, {\"King's Landing\":\"Living Space\"})\n+\n+    def test_room_exists(self):\n+        '''test if a room exists from a list of rooms'''\n+        self.assertIn(self.test_amity.view_rooms, [\"King's Landing\"])\n+\n+    def test_check_office_has_space(self):\n+        '''test if office has space. If list is equal to 6 the office space is full.'''\n+        self.assertEqual(self.office.check_office_has_space, 6)\n+\n+    def test_check_living_space_has_space(self):\n+        '''test if the living space has space. If the allocated is 4 it raises an assert'''\n+        self.assertEqual(self.living_space.check_living_space_has_space, 4)\n+\n+    def test_add_person(self):\n+        '''tests that person has been created'''\n+        self.add_person = Person()\n+        self.new_person = self.staff or self.fellow\n+        self.assertEqual(self.new_person.add_person, {\"emp_id\": \"name\"} )","path":"tests/class_test.py","position":66,"original_position":66,"commit_id":"fef1337228edfc7bee4db2f9770fc4569833a54c","original_commit_id":"fef1337228edfc7bee4db2f9770fc4569833a54c","user":{"login":"andela-mallan","id":21034048,"avatar_url":"https://avatars0.githubusercontent.com/u/21034048?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-mallan","html_url":"https://github.com/andela-mallan","followers_url":"https://api.github.com/users/andela-mallan/followers","following_url":"https://api.github.com/users/andela-mallan/following{/other_user}","gists_url":"https://api.github.com/users/andela-mallan/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-mallan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-mallan/subscriptions","organizations_url":"https://api.github.com/users/andela-mallan/orgs","repos_url":"https://api.github.com/users/andela-mallan/repos","events_url":"https://api.github.com/users/andela-mallan/events{/privacy}","received_events_url":"https://api.github.com/users/andela-mallan/received_events","type":"User","site_admin":false},"body":"The `add_person` method takes 2 positional args. None provided here. The error maybe not from the assertion but something close to the comment on **line 44**","created_at":"2017-04-04T12:23:35Z","updated_at":"2017-04-04T12:36:32Z","html_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau/pull/1#discussion_r109647406","pull_request_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/comments/109647406"},"html":{"href":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau/pull/1#discussion_r109647406"},"pull_request":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1","id":114104868,"html_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau/pull/1","diff_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau/pull/1.diff","patch_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau/pull/1.patch","issue_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/1","number":1,"state":"open","locked":false,"title":"Unit tests for CP1","user":{"login":"nzaujk","id":26301996,"avatar_url":"https://avatars1.githubusercontent.com/u/26301996?v=3","gravatar_id":"","url":"https://api.github.com/users/nzaujk","html_url":"https://github.com/nzaujk","followers_url":"https://api.github.com/users/nzaujk/followers","following_url":"https://api.github.com/users/nzaujk/following{/other_user}","gists_url":"https://api.github.com/users/nzaujk/gists{/gist_id}","starred_url":"https://api.github.com/users/nzaujk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzaujk/subscriptions","organizations_url":"https://api.github.com/users/nzaujk/orgs","repos_url":"https://api.github.com/users/nzaujk/repos","events_url":"https://api.github.com/users/nzaujk/events{/privacy}","received_events_url":"https://api.github.com/users/nzaujk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-04T09:27:12Z","updated_at":"2017-04-04T12:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b3b8d1f2ca146f27e34f9167036d9707929de9f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/1/comments","statuses_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/statuses/fef1337228edfc7bee4db2f9770fc4569833a54c","head":{"label":"nzaujk:ch_tests","ref":"ch_tests","sha":"fef1337228edfc7bee4db2f9770fc4569833a54c","user":{"login":"nzaujk","id":26301996,"avatar_url":"https://avatars1.githubusercontent.com/u/26301996?v=3","gravatar_id":"","url":"https://api.github.com/users/nzaujk","html_url":"https://github.com/nzaujk","followers_url":"https://api.github.com/users/nzaujk/followers","following_url":"https://api.github.com/users/nzaujk/following{/other_user}","gists_url":"https://api.github.com/users/nzaujk/gists{/gist_id}","starred_url":"https://api.github.com/users/nzaujk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzaujk/subscriptions","organizations_url":"https://api.github.com/users/nzaujk/orgs","repos_url":"https://api.github.com/users/nzaujk/repos","events_url":"https://api.github.com/users/nzaujk/events{/privacy}","received_events_url":"https://api.github.com/users/nzaujk/received_events","type":"User","site_admin":false},"repo":{"id":87165131,"name":"cp1-amity-room_allocation_nzau","full_name":"nzaujk/cp1-amity-room_allocation_nzau","owner":{"login":"nzaujk","id":26301996,"avatar_url":"https://avatars1.githubusercontent.com/u/26301996?v=3","gravatar_id":"","url":"https://api.github.com/users/nzaujk","html_url":"https://github.com/nzaujk","followers_url":"https://api.github.com/users/nzaujk/followers","following_url":"https://api.github.com/users/nzaujk/following{/other_user}","gists_url":"https://api.github.com/users/nzaujk/gists{/gist_id}","starred_url":"https://api.github.com/users/nzaujk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzaujk/subscriptions","organizations_url":"https://api.github.com/users/nzaujk/orgs","repos_url":"https://api.github.com/users/nzaujk/repos","events_url":"https://api.github.com/users/nzaujk/events{/privacy}","received_events_url":"https://api.github.com/users/nzaujk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau","description":null,"fork":false,"url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau","forks_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/forks","keys_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/teams","hooks_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/hooks","issue_events_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/events{/number}","events_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/events","assignees_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/assignees{/user}","branches_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/branches{/branch}","tags_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/tags","blobs_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/refs{/sha}","trees_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/statuses/{sha}","languages_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/languages","stargazers_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/stargazers","contributors_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/contributors","subscribers_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/subscribers","subscription_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/subscription","commits_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/commits{/sha}","git_commits_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/commits{/sha}","comments_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/comments{/number}","issue_comment_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/comments{/number}","contents_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/contents/{+path}","compare_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/merges","archive_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/downloads","issues_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues{/number}","pulls_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls{/number}","milestones_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/milestones{/number}","notifications_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/labels{/name}","releases_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/releases{/id}","deployments_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/deployments","created_at":"2017-04-04T08:45:25Z","updated_at":"2017-04-04T08:45:25Z","pushed_at":"2017-04-04T09:27:13Z","git_url":"git://github.com/nzaujk/cp1-amity-room_allocation_nzau.git","ssh_url":"git@github.com:nzaujk/cp1-amity-room_allocation_nzau.git","clone_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau.git","svn_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nzaujk:master","ref":"master","sha":"880db8858d7017970733917f3ba28643e5c8409a","user":{"login":"nzaujk","id":26301996,"avatar_url":"https://avatars1.githubusercontent.com/u/26301996?v=3","gravatar_id":"","url":"https://api.github.com/users/nzaujk","html_url":"https://github.com/nzaujk","followers_url":"https://api.github.com/users/nzaujk/followers","following_url":"https://api.github.com/users/nzaujk/following{/other_user}","gists_url":"https://api.github.com/users/nzaujk/gists{/gist_id}","starred_url":"https://api.github.com/users/nzaujk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzaujk/subscriptions","organizations_url":"https://api.github.com/users/nzaujk/orgs","repos_url":"https://api.github.com/users/nzaujk/repos","events_url":"https://api.github.com/users/nzaujk/events{/privacy}","received_events_url":"https://api.github.com/users/nzaujk/received_events","type":"User","site_admin":false},"repo":{"id":87165131,"name":"cp1-amity-room_allocation_nzau","full_name":"nzaujk/cp1-amity-room_allocation_nzau","owner":{"login":"nzaujk","id":26301996,"avatar_url":"https://avatars1.githubusercontent.com/u/26301996?v=3","gravatar_id":"","url":"https://api.github.com/users/nzaujk","html_url":"https://github.com/nzaujk","followers_url":"https://api.github.com/users/nzaujk/followers","following_url":"https://api.github.com/users/nzaujk/following{/other_user}","gists_url":"https://api.github.com/users/nzaujk/gists{/gist_id}","starred_url":"https://api.github.com/users/nzaujk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzaujk/subscriptions","organizations_url":"https://api.github.com/users/nzaujk/orgs","repos_url":"https://api.github.com/users/nzaujk/repos","events_url":"https://api.github.com/users/nzaujk/events{/privacy}","received_events_url":"https://api.github.com/users/nzaujk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau","description":null,"fork":false,"url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau","forks_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/forks","keys_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/teams","hooks_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/hooks","issue_events_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/events{/number}","events_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/events","assignees_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/assignees{/user}","branches_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/branches{/branch}","tags_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/tags","blobs_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/refs{/sha}","trees_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/statuses/{sha}","languages_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/languages","stargazers_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/stargazers","contributors_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/contributors","subscribers_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/subscribers","subscription_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/subscription","commits_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/commits{/sha}","git_commits_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/git/commits{/sha}","comments_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/comments{/number}","issue_comment_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/comments{/number}","contents_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/contents/{+path}","compare_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/merges","archive_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/downloads","issues_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues{/number}","pulls_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls{/number}","milestones_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/milestones{/number}","notifications_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/labels{/name}","releases_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/releases{/id}","deployments_url":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/deployments","created_at":"2017-04-04T08:45:25Z","updated_at":"2017-04-04T08:45:25Z","pushed_at":"2017-04-04T09:27:13Z","git_url":"git://github.com/nzaujk/cp1-amity-room_allocation_nzau.git","ssh_url":"git@github.com:nzaujk/cp1-amity-room_allocation_nzau.git","clone_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau.git","svn_url":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1"},"html":{"href":"https://github.com/nzaujk/cp1-amity-room_allocation_nzau/pull/1"},"issue":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/1"},"comments":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nzaujk/cp1-amity-room_allocation_nzau/statuses/fef1337228edfc7bee4db2f9770fc4569833a54c"}}}}
{"actor":{"display_login":"andela-mallan"}}