{"action":"closed","number":1460,"pull_request":{"url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1460","id":107474163,"html_url":"https://github.com/openstreetmap/openstreetmap-website/pull/1460","diff_url":"https://github.com/openstreetmap/openstreetmap-website/pull/1460.diff","patch_url":"https://github.com/openstreetmap/openstreetmap-website/pull/1460.patch","issue_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1460","number":1460,"state":"closed","locked":false,"title":"User factory associations for all factories","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"body":"We have a User factory now, might as well use it!\r\n\r\nThere were two tests that made assumptions about the user_id of objects generated by factories. For the `test_api_details` the assumption was that the message was sender was also user_id 1. I think the test is clearer by having two messages, since having a message sent to yourself is a bit curious.","created_at":"2017-02-22T18:55:24Z","updated_at":"2017-02-22T19:48:19Z","closed_at":"2017-02-22T19:48:19Z","merged_at":"2017-02-22T19:48:19Z","merge_commit_sha":"a3618d2b5fcb991fef7786fbbbfd6d3e0ac88d28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1460/commits","review_comments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1460/comments","review_comment_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1460/comments","statuses_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/statuses/a3618d2b5fcb991fef7786fbbbfd6d3e0ac88d28","head":{"label":"gravitystorm:factories_everywhere","ref":"factories_everywhere","sha":"a3618d2b5fcb991fef7786fbbbfd6d3e0ac88d28","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":1174982,"name":"openstreetmap-website","full_name":"gravitystorm/openstreetmap-website","owner":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gravitystorm/openstreetmap-website","description":"The Rails application powering OpenStreetMap","fork":true,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-website","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/releases{/id}","deployments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/deployments","created_at":"2010-12-16T19:10:32Z","updated_at":"2016-10-26T09:44:41Z","pushed_at":"2017-02-22T18:59:01Z","git_url":"git://github.com/gravitystorm/openstreetmap-website.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-website.git","clone_url":"https://github.com/gravitystorm/openstreetmap-website.git","svn_url":"https://github.com/gravitystorm/openstreetmap-website","homepage":"http://www.openstreetmap.org/","size":249951,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"openstreetmap:master","ref":"master","sha":"1a5161a9c803d88c72456fa80ad79e6141e1d7ce","user":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars.githubusercontent.com/u/261431?v=3","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"repo":{"id":641512,"name":"openstreetmap-website","full_name":"openstreetmap/openstreetmap-website","owner":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars.githubusercontent.com/u/261431?v=3","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstreetmap/openstreetmap-website","description":"Mirror of the Rails application powering http://www.openstreetmap.org (hosted at git://git.openstreetmap.org/rails.git)","fork":false,"url":"https://api.github.com/repos/openstreetmap/openstreetmap-website","forks_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/forks","keys_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/teams","hooks_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/hooks","issue_events_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/events{/number}","events_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/events","assignees_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/assignees{/user}","branches_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/branches{/branch}","tags_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/tags","blobs_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/statuses/{sha}","languages_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/languages","stargazers_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/stargazers","contributors_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/contributors","subscribers_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/subscribers","subscription_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/subscription","commits_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/contents/{+path}","compare_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/merges","archive_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/downloads","issues_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues{/number}","pulls_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls{/number}","milestones_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/milestones{/number}","notifications_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/labels{/name}","releases_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/releases{/id}","deployments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/deployments","created_at":"2010-05-01T16:22:12Z","updated_at":"2017-02-20T14:19:41Z","pushed_at":"2017-02-22T19:48:15Z","git_url":"git://github.com/openstreetmap/openstreetmap-website.git","ssh_url":"git@github.com:openstreetmap/openstreetmap-website.git","clone_url":"https://github.com/openstreetmap/openstreetmap-website.git","svn_url":"https://github.com/openstreetmap/openstreetmap-website","homepage":"","size":249963,"stargazers_count":596,"watchers_count":596,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":381,"mirror_url":null,"open_issues_count":291,"forks":381,"open_issues":291,"watchers":596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1460"},"html":{"href":"https://github.com/openstreetmap/openstreetmap-website/pull/1460"},"issue":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1460"},"comments":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1460/comments"},"review_comments":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1460/comments"},"review_comment":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1460/commits"},"statuses":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/statuses/a3618d2b5fcb991fef7786fbbbfd6d3e0ac88d28"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tomhughes","id":147741,"avatar_url":"https://avatars.githubusercontent.com/u/147741?v=3","gravatar_id":"","url":"https://api.github.com/users/tomhughes","html_url":"https://github.com/tomhughes","followers_url":"https://api.github.com/users/tomhughes/followers","following_url":"https://api.github.com/users/tomhughes/following{/other_user}","gists_url":"https://api.github.com/users/tomhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/tomhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomhughes/subscriptions","organizations_url":"https://api.github.com/users/tomhughes/orgs","repos_url":"https://api.github.com/users/tomhughes/repos","events_url":"https://api.github.com/users/tomhughes/events{/privacy}","received_events_url":"https://api.github.com/users/tomhughes/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":25,"changed_files":10}}
{"actor":{"display_login":"tomhughes"}}