{"action":"opened","number":4289,"pull_request":{"url":"https://api.github.com/repos/qTox/qTox/pulls/4289","id":112592685,"html_url":"https://github.com/qTox/qTox/pull/4289","diff_url":"https://github.com/qTox/qTox/pull/4289.diff","patch_url":"https://github.com/qTox/qTox/pull/4289.patch","issue_url":"https://api.github.com/repos/qTox/qTox/issues/4289","number":4289,"state":"open","locked":false,"title":"[WIP] Remove plaintext passwords","user":{"login":"sudden6","id":5585762,"avatar_url":"https://avatars1.githubusercontent.com/u/5585762?v=3","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"body":"This PR removes all instances where a passwords were stored as `QString` and replaces them with `ToxEncrypt` passkeys. This improves performance (key derivation is only run once) as well as security (can't leak plaintext passwords).\r\n\r\n@Diadlo @noavarice I'm not entirely sure what I do with `const ToxEncrypt* Profile::getPasskey()` is the correct way to make the `ToxEncrypt` object usable for encryption and decryption. Is there maybe a better way not involving raw pointers?","created_at":"2017-03-25T16:38:24Z","updated_at":"2017-03-25T16:38:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qTox/qTox/pulls/4289/commits","review_comments_url":"https://api.github.com/repos/qTox/qTox/pulls/4289/comments","review_comment_url":"https://api.github.com/repos/qTox/qTox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/4289/comments","statuses_url":"https://api.github.com/repos/qTox/qTox/statuses/236a3d7bba14b2fab576196862921b9f1b2cffaf","head":{"label":"sudden6:remove_plaintext_pw","ref":"remove_plaintext_pw","sha":"236a3d7bba14b2fab576196862921b9f1b2cffaf","user":{"login":"sudden6","id":5585762,"avatar_url":"https://avatars1.githubusercontent.com/u/5585762?v=3","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"repo":{"id":30754426,"name":"qTox","full_name":"sudden6/qTox","owner":{"login":"sudden6","id":5585762,"avatar_url":"https://avatars1.githubusercontent.com/u/5585762?v=3","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sudden6/qTox","description":"Powerful Tox client that follows the Tox design guidelines. Formerly called toxgui","fork":true,"url":"https://api.github.com/repos/sudden6/qTox","forks_url":"https://api.github.com/repos/sudden6/qTox/forks","keys_url":"https://api.github.com/repos/sudden6/qTox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sudden6/qTox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sudden6/qTox/teams","hooks_url":"https://api.github.com/repos/sudden6/qTox/hooks","issue_events_url":"https://api.github.com/repos/sudden6/qTox/issues/events{/number}","events_url":"https://api.github.com/repos/sudden6/qTox/events","assignees_url":"https://api.github.com/repos/sudden6/qTox/assignees{/user}","branches_url":"https://api.github.com/repos/sudden6/qTox/branches{/branch}","tags_url":"https://api.github.com/repos/sudden6/qTox/tags","blobs_url":"https://api.github.com/repos/sudden6/qTox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sudden6/qTox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sudden6/qTox/git/refs{/sha}","trees_url":"https://api.github.com/repos/sudden6/qTox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sudden6/qTox/statuses/{sha}","languages_url":"https://api.github.com/repos/sudden6/qTox/languages","stargazers_url":"https://api.github.com/repos/sudden6/qTox/stargazers","contributors_url":"https://api.github.com/repos/sudden6/qTox/contributors","subscribers_url":"https://api.github.com/repos/sudden6/qTox/subscribers","subscription_url":"https://api.github.com/repos/sudden6/qTox/subscription","commits_url":"https://api.github.com/repos/sudden6/qTox/commits{/sha}","git_commits_url":"https://api.github.com/repos/sudden6/qTox/git/commits{/sha}","comments_url":"https://api.github.com/repos/sudden6/qTox/comments{/number}","issue_comment_url":"https://api.github.com/repos/sudden6/qTox/issues/comments{/number}","contents_url":"https://api.github.com/repos/sudden6/qTox/contents/{+path}","compare_url":"https://api.github.com/repos/sudden6/qTox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sudden6/qTox/merges","archive_url":"https://api.github.com/repos/sudden6/qTox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sudden6/qTox/downloads","issues_url":"https://api.github.com/repos/sudden6/qTox/issues{/number}","pulls_url":"https://api.github.com/repos/sudden6/qTox/pulls{/number}","milestones_url":"https://api.github.com/repos/sudden6/qTox/milestones{/number}","notifications_url":"https://api.github.com/repos/sudden6/qTox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sudden6/qTox/labels{/name}","releases_url":"https://api.github.com/repos/sudden6/qTox/releases{/id}","deployments_url":"https://api.github.com/repos/sudden6/qTox/deployments","created_at":"2015-02-13T11:55:07Z","updated_at":"2016-11-06T21:12:38Z","pushed_at":"2017-03-25T15:19:47Z","git_url":"git://github.com/sudden6/qTox.git","ssh_url":"git@github.com:sudden6/qTox.git","clone_url":"https://github.com/sudden6/qTox.git","svn_url":"https://github.com/sudden6/qTox","homepage":"http://utoxisfinished.info","size":25521,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qTox:master","ref":"master","sha":"9236763865ba3096382bd2cdbff85a540d0f5546","user":{"login":"qTox","id":9519241,"avatar_url":"https://avatars2.githubusercontent.com/u/9519241?v=3","gravatar_id":"","url":"https://api.github.com/users/qTox","html_url":"https://github.com/qTox","followers_url":"https://api.github.com/users/qTox/followers","following_url":"https://api.github.com/users/qTox/following{/other_user}","gists_url":"https://api.github.com/users/qTox/gists{/gist_id}","starred_url":"https://api.github.com/users/qTox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qTox/subscriptions","organizations_url":"https://api.github.com/users/qTox/orgs","repos_url":"https://api.github.com/users/qTox/repos","events_url":"https://api.github.com/users/qTox/events{/privacy}","received_events_url":"https://api.github.com/users/qTox/received_events","type":"Organization","site_admin":false},"repo":{"id":21179164,"name":"qTox","full_name":"qTox/qTox","owner":{"login":"qTox","id":9519241,"avatar_url":"https://avatars2.githubusercontent.com/u/9519241?v=3","gravatar_id":"","url":"https://api.github.com/users/qTox","html_url":"https://github.com/qTox","followers_url":"https://api.github.com/users/qTox/followers","following_url":"https://api.github.com/users/qTox/following{/other_user}","gists_url":"https://api.github.com/users/qTox/gists{/gist_id}","starred_url":"https://api.github.com/users/qTox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qTox/subscriptions","organizations_url":"https://api.github.com/users/qTox/orgs","repos_url":"https://api.github.com/users/qTox/repos","events_url":"https://api.github.com/users/qTox/events{/privacy}","received_events_url":"https://api.github.com/users/qTox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qTox/qTox","description":"The most feature-rich Tox client; P2P instant messaging, audio and video calls.","fork":false,"url":"https://api.github.com/repos/qTox/qTox","forks_url":"https://api.github.com/repos/qTox/qTox/forks","keys_url":"https://api.github.com/repos/qTox/qTox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qTox/qTox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qTox/qTox/teams","hooks_url":"https://api.github.com/repos/qTox/qTox/hooks","issue_events_url":"https://api.github.com/repos/qTox/qTox/issues/events{/number}","events_url":"https://api.github.com/repos/qTox/qTox/events","assignees_url":"https://api.github.com/repos/qTox/qTox/assignees{/user}","branches_url":"https://api.github.com/repos/qTox/qTox/branches{/branch}","tags_url":"https://api.github.com/repos/qTox/qTox/tags","blobs_url":"https://api.github.com/repos/qTox/qTox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qTox/qTox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qTox/qTox/git/refs{/sha}","trees_url":"https://api.github.com/repos/qTox/qTox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qTox/qTox/statuses/{sha}","languages_url":"https://api.github.com/repos/qTox/qTox/languages","stargazers_url":"https://api.github.com/repos/qTox/qTox/stargazers","contributors_url":"https://api.github.com/repos/qTox/qTox/contributors","subscribers_url":"https://api.github.com/repos/qTox/qTox/subscribers","subscription_url":"https://api.github.com/repos/qTox/qTox/subscription","commits_url":"https://api.github.com/repos/qTox/qTox/commits{/sha}","git_commits_url":"https://api.github.com/repos/qTox/qTox/git/commits{/sha}","comments_url":"https://api.github.com/repos/qTox/qTox/comments{/number}","issue_comment_url":"https://api.github.com/repos/qTox/qTox/issues/comments{/number}","contents_url":"https://api.github.com/repos/qTox/qTox/contents/{+path}","compare_url":"https://api.github.com/repos/qTox/qTox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qTox/qTox/merges","archive_url":"https://api.github.com/repos/qTox/qTox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qTox/qTox/downloads","issues_url":"https://api.github.com/repos/qTox/qTox/issues{/number}","pulls_url":"https://api.github.com/repos/qTox/qTox/pulls{/number}","milestones_url":"https://api.github.com/repos/qTox/qTox/milestones{/number}","notifications_url":"https://api.github.com/repos/qTox/qTox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qTox/qTox/labels{/name}","releases_url":"https://api.github.com/repos/qTox/qTox/releases{/id}","deployments_url":"https://api.github.com/repos/qTox/qTox/deployments","created_at":"2014-06-24T20:09:04Z","updated_at":"2017-03-25T12:29:09Z","pushed_at":"2017-03-25T14:18:49Z","git_url":"git://github.com/qTox/qTox.git","ssh_url":"git@github.com:qTox/qTox.git","clone_url":"https://github.com/qTox/qTox.git","svn_url":"https://github.com/qTox/qTox","homepage":"https://qtox.github.io/","size":27875,"stargazers_count":1260,"watchers_count":1260,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"open_issues_count":509,"forks":348,"open_issues":509,"watchers":1260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qTox/qTox/pulls/4289"},"html":{"href":"https://github.com/qTox/qTox/pull/4289"},"issue":{"href":"https://api.github.com/repos/qTox/qTox/issues/4289"},"comments":{"href":"https://api.github.com/repos/qTox/qTox/issues/4289/comments"},"review_comments":{"href":"https://api.github.com/repos/qTox/qTox/pulls/4289/comments"},"review_comment":{"href":"https://api.github.com/repos/qTox/qTox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qTox/qTox/pulls/4289/commits"},"statuses":{"href":"https://api.github.com/repos/qTox/qTox/statuses/236a3d7bba14b2fab576196862921b9f1b2cffaf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":134,"deletions":178,"changed_files":8}}
{"actor":{"display_login":"sudden6"}}