{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/154814539","pull_request_review_id":81034265,"id":154814539,"diff_hunk":"@@ -0,0 +1,3 @@\n+#!/bin/sh\n+alias gcloud=\"(docker images google/cloud-sdk || docker pull google/cloud-sdk) > /dev/null;docker run -ti --rm --net=\"host\" -v $HOME/.config:/root/.config -v /var/run/docker.sock:/var/run/docker.sock google/cloud-sdk gcloud\"\n+alias gsutil=\"(docker images google/cloud-sdk || docker pull google/cloud-sdk) > /dev/null;docker run -ti --rm --net=\"host\" -v $HOME/.config:/root/.config google/cloud-sdk gsutil\"","path":"coreos-base/oem-gce/files/files/google-cloud-sdk.sh","position":3,"original_position":3,"commit_id":"f979a298104ef93a90fcc0f20772271cc8398727","original_commit_id":"44e1f7ff62a16653e0a5119dd480d766c1420cc7","user":{"login":"dm0-","id":1379865,"avatar_url":"https://avatars0.githubusercontent.com/u/1379865?v=4","gravatar_id":"","url":"https://api.github.com/users/dm0-","html_url":"https://github.com/dm0-","followers_url":"https://api.github.com/users/dm0-/followers","following_url":"https://api.github.com/users/dm0-/following{/other_user}","gists_url":"https://api.github.com/users/dm0-/gists{/gist_id}","starred_url":"https://api.github.com/users/dm0-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dm0-/subscriptions","organizations_url":"https://api.github.com/users/dm0-/orgs","repos_url":"https://api.github.com/users/dm0-/repos","events_url":"https://api.github.com/users/dm0-/events{/privacy}","received_events_url":"https://api.github.com/users/dm0-/received_events","type":"User","site_admin":false},"body":"Maybe drop the quotes from `--net=\"host\"`.  They aren't needed, and they unquote the alias string.  It makes no difference in this case, but it's reminiscent of actual problems.","created_at":"2017-12-05T00:16:22Z","updated_at":"2017-12-05T00:16:40Z","html_url":"https://github.com/coreos/coreos-overlay/pull/2936#discussion_r154814539","pull_request_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/154814539"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/2936#discussion_r154814539"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936","id":156116942,"html_url":"https://github.com/coreos/coreos-overlay/pull/2936","diff_url":"https://github.com/coreos/coreos-overlay/pull/2936.diff","patch_url":"https://github.com/coreos/coreos-overlay/pull/2936.patch","issue_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/2936","number":2936,"state":"open","locked":false,"title":"coreos-base/oem-*: move Ignition base/default configs into OEMs","user":{"login":"bgilbert","id":361374,"avatar_url":"https://avatars1.githubusercontent.com/u/361374?v=4","gravatar_id":"","url":"https://api.github.com/users/bgilbert","html_url":"https://github.com/bgilbert","followers_url":"https://api.github.com/users/bgilbert/followers","following_url":"https://api.github.com/users/bgilbert/following{/other_user}","gists_url":"https://api.github.com/users/bgilbert/gists{/gist_id}","starred_url":"https://api.github.com/users/bgilbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgilbert/subscriptions","organizations_url":"https://api.github.com/users/bgilbert/orgs","repos_url":"https://api.github.com/users/bgilbert/repos","events_url":"https://api.github.com/users/bgilbert/events{/privacy}","received_events_url":"https://api.github.com/users/bgilbert/received_events","type":"User","site_admin":false},"body":"For https://github.com/coreos/ignition/pull/475. Configs are as of coreos/ignition@dc992fff72cf45fbed14d2144d05a9df91eb2bd6. Tested with QEMU, PXE, ISO, Azure, DigitalOcean, EC2, GCE, OCI, Packet, and VMware Workstation. Not tested with OpenStack or Brightbox.\r\n\r\nThis PR will be updated with a bootengine bump after https://github.com/coreos/bootengine/pull/135 merges.","created_at":"2017-12-04T06:09:48Z","updated_at":"2017-12-05T00:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82ab2e7e664f3c61c5e25e8093b0b632665f84bd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/2936/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/f979a298104ef93a90fcc0f20772271cc8398727","head":{"label":"bgilbert:external-oem-configs","ref":"external-oem-configs","sha":"f979a298104ef93a90fcc0f20772271cc8398727","user":{"login":"bgilbert","id":361374,"avatar_url":"https://avatars1.githubusercontent.com/u/361374?v=4","gravatar_id":"","url":"https://api.github.com/users/bgilbert","html_url":"https://github.com/bgilbert","followers_url":"https://api.github.com/users/bgilbert/followers","following_url":"https://api.github.com/users/bgilbert/following{/other_user}","gists_url":"https://api.github.com/users/bgilbert/gists{/gist_id}","starred_url":"https://api.github.com/users/bgilbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgilbert/subscriptions","organizations_url":"https://api.github.com/users/bgilbert/orgs","repos_url":"https://api.github.com/users/bgilbert/repos","events_url":"https://api.github.com/users/bgilbert/events{/privacy}","received_events_url":"https://api.github.com/users/bgilbert/received_events","type":"User","site_admin":false},"repo":{"id":78249523,"name":"coreos-overlay","full_name":"bgilbert/coreos-overlay","owner":{"login":"bgilbert","id":361374,"avatar_url":"https://avatars1.githubusercontent.com/u/361374?v=4","gravatar_id":"","url":"https://api.github.com/users/bgilbert","html_url":"https://github.com/bgilbert","followers_url":"https://api.github.com/users/bgilbert/followers","following_url":"https://api.github.com/users/bgilbert/following{/other_user}","gists_url":"https://api.github.com/users/bgilbert/gists{/gist_id}","starred_url":"https://api.github.com/users/bgilbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgilbert/subscriptions","organizations_url":"https://api.github.com/users/bgilbert/orgs","repos_url":"https://api.github.com/users/bgilbert/repos","events_url":"https://api.github.com/users/bgilbert/events{/privacy}","received_events_url":"https://api.github.com/users/bgilbert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgilbert/coreos-overlay","description":"Custom ebuilds for Container Linux","fork":true,"url":"https://api.github.com/repos/bgilbert/coreos-overlay","forks_url":"https://api.github.com/repos/bgilbert/coreos-overlay/forks","keys_url":"https://api.github.com/repos/bgilbert/coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgilbert/coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgilbert/coreos-overlay/teams","hooks_url":"https://api.github.com/repos/bgilbert/coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/bgilbert/coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/bgilbert/coreos-overlay/events","assignees_url":"https://api.github.com/repos/bgilbert/coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/bgilbert/coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/bgilbert/coreos-overlay/tags","blobs_url":"https://api.github.com/repos/bgilbert/coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgilbert/coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgilbert/coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgilbert/coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgilbert/coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/bgilbert/coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/bgilbert/coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/bgilbert/coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/bgilbert/coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/bgilbert/coreos-overlay/subscription","commits_url":"https://api.github.com/repos/bgilbert/coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgilbert/coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgilbert/coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgilbert/coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgilbert/coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/bgilbert/coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgilbert/coreos-overlay/merges","archive_url":"https://api.github.com/repos/bgilbert/coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgilbert/coreos-overlay/downloads","issues_url":"https://api.github.com/repos/bgilbert/coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/bgilbert/coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/bgilbert/coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/bgilbert/coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgilbert/coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/bgilbert/coreos-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/bgilbert/coreos-overlay/deployments","created_at":"2017-01-07T00:42:36Z","updated_at":"2017-01-07T00:42:41Z","pushed_at":"2017-12-04T05:59:03Z","git_url":"git://github.com/bgilbert/coreos-overlay.git","ssh_url":"git@github.com:bgilbert/coreos-overlay.git","clone_url":"https://github.com/bgilbert/coreos-overlay.git","svn_url":"https://github.com/bgilbert/coreos-overlay","homepage":"http://coreos.com/docs/sdk/","size":13161,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"f510619e73f14f1652f2f72e8ad739bb050da056","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":8488820,"name":"coreos-overlay","full_name":"coreos/coreos-overlay","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-overlay","description":"Custom ebuilds for Container Linux","fork":false,"url":"https://api.github.com/repos/coreos/coreos-overlay","forks_url":"https://api.github.com/repos/coreos/coreos-overlay/forks","keys_url":"https://api.github.com/repos/coreos/coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-overlay/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-overlay/events","assignees_url":"https://api.github.com/repos/coreos/coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-overlay/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-overlay/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-overlay/merges","archive_url":"https://api.github.com/repos/coreos/coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-overlay/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/coreos-overlay/deployments","created_at":"2013-02-28T21:43:07Z","updated_at":"2017-12-03T10:52:02Z","pushed_at":"2017-12-04T06:09:49Z","git_url":"git://github.com/coreos/coreos-overlay.git","ssh_url":"git@github.com:coreos/coreos-overlay.git","clone_url":"https://github.com/coreos/coreos-overlay.git","svn_url":"https://github.com/coreos/coreos-overlay","homepage":"http://coreos.com/docs/sdk/","size":13434,"stargazers_count":215,"watchers_count":215,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":48,"license":null,"forks":207,"open_issues":48,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/2936"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/2936"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/2936/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/2936/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-overlay/statuses/f979a298104ef93a90fcc0f20772271cc8398727"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dm0-"}}