{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/117181281","pull_request_review_id":38864334,"id":117181281,"diff_hunk":"@@ -144,7 +144,6 @@ func (hk *HyperKube) Run(args []string) error {\n \t\targs = baseFlags.Args()\n \t\tif len(args) > 0 && len(args[0]) > 0 {\n \t\t\tserverName = args[0]\n-\t\t\tbaseCommand = baseCommand + \" \" + serverName","path":"cmd/hyperkube/hyperkube.go","position":4,"original_position":4,"commit_id":"e9937d117d5c5c35ac4d6a0639e15d24d6805d41","original_commit_id":"e9937d117d5c5c35ac4d6a0639e15d24d6805d41","user":{"login":"YuPengZTE","id":20062886,"avatar_url":"https://avatars1.githubusercontent.com/u/20062886?v=3","gravatar_id":"","url":"https://api.github.com/users/YuPengZTE","html_url":"https://github.com/YuPengZTE","followers_url":"https://api.github.com/users/YuPengZTE/followers","following_url":"https://api.github.com/users/YuPengZTE/following{/other_user}","gists_url":"https://api.github.com/users/YuPengZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/YuPengZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuPengZTE/subscriptions","organizations_url":"https://api.github.com/users/YuPengZTE/orgs","repos_url":"https://api.github.com/users/YuPengZTE/repos","events_url":"https://api.github.com/users/YuPengZTE/events{/privacy}","received_events_url":"https://api.github.com/users/YuPengZTE/received_events","type":"User","site_admin":false},"body":"After it, the \"baseCommand\" is not used.","created_at":"2017-05-18T07:54:52Z","updated_at":"2017-05-18T07:54:52Z","html_url":"https://github.com/kubernetes/kubernetes/pull/46018#discussion_r117181281","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/117181281"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/46018#discussion_r117181281"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018","id":121215863,"html_url":"https://github.com/kubernetes/kubernetes/pull/46018","diff_url":"https://github.com/kubernetes/kubernetes/pull/46018.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/46018.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46018","number":46018,"state":"open","locked":false,"title":"ineffectual assignment to baseCommand, delete it","user":{"login":"YuPengZTE","id":20062886,"avatar_url":"https://avatars1.githubusercontent.com/u/20062886?v=3","gravatar_id":"","url":"https://api.github.com/users/YuPengZTE","html_url":"https://github.com/YuPengZTE","followers_url":"https://api.github.com/users/YuPengZTE/followers","following_url":"https://api.github.com/users/YuPengZTE/following{/other_user}","gists_url":"https://api.github.com/users/YuPengZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/YuPengZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuPengZTE/subscriptions","organizations_url":"https://api.github.com/users/YuPengZTE/orgs","repos_url":"https://api.github.com/users/YuPengZTE/repos","events_url":"https://api.github.com/users/YuPengZTE/events{/privacy}","received_events_url":"https://api.github.com/users/YuPengZTE/received_events","type":"User","site_admin":false},"body":"Signed-off-by: yupengzte <yu.peng36@zte.com.cn>\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2017-05-18T07:14:42Z","updated_at":"2017-05-18T07:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dfe6b944a911c9333336eed4e5009e827e2123f","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars1.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars1.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46018/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e9937d117d5c5c35ac4d6a0639e15d24d6805d41","head":{"label":"YuPengZTE:devBaseCommand","ref":"devBaseCommand","sha":"e9937d117d5c5c35ac4d6a0639e15d24d6805d41","user":{"login":"YuPengZTE","id":20062886,"avatar_url":"https://avatars1.githubusercontent.com/u/20062886?v=3","gravatar_id":"","url":"https://api.github.com/users/YuPengZTE","html_url":"https://github.com/YuPengZTE","followers_url":"https://api.github.com/users/YuPengZTE/followers","following_url":"https://api.github.com/users/YuPengZTE/following{/other_user}","gists_url":"https://api.github.com/users/YuPengZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/YuPengZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuPengZTE/subscriptions","organizations_url":"https://api.github.com/users/YuPengZTE/orgs","repos_url":"https://api.github.com/users/YuPengZTE/repos","events_url":"https://api.github.com/users/YuPengZTE/events{/privacy}","received_events_url":"https://api.github.com/users/YuPengZTE/received_events","type":"User","site_admin":false},"repo":{"id":67663117,"name":"kubernetes","full_name":"YuPengZTE/kubernetes","owner":{"login":"YuPengZTE","id":20062886,"avatar_url":"https://avatars1.githubusercontent.com/u/20062886?v=3","gravatar_id":"","url":"https://api.github.com/users/YuPengZTE","html_url":"https://github.com/YuPengZTE","followers_url":"https://api.github.com/users/YuPengZTE/followers","following_url":"https://api.github.com/users/YuPengZTE/following{/other_user}","gists_url":"https://api.github.com/users/YuPengZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/YuPengZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuPengZTE/subscriptions","organizations_url":"https://api.github.com/users/YuPengZTE/orgs","repos_url":"https://api.github.com/users/YuPengZTE/repos","events_url":"https://api.github.com/users/YuPengZTE/events{/privacy}","received_events_url":"https://api.github.com/users/YuPengZTE/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YuPengZTE/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/YuPengZTE/kubernetes","forks_url":"https://api.github.com/repos/YuPengZTE/kubernetes/forks","keys_url":"https://api.github.com/repos/YuPengZTE/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YuPengZTE/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YuPengZTE/kubernetes/teams","hooks_url":"https://api.github.com/repos/YuPengZTE/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/YuPengZTE/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/YuPengZTE/kubernetes/events","assignees_url":"https://api.github.com/repos/YuPengZTE/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/YuPengZTE/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/YuPengZTE/kubernetes/tags","blobs_url":"https://api.github.com/repos/YuPengZTE/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YuPengZTE/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YuPengZTE/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/YuPengZTE/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YuPengZTE/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/YuPengZTE/kubernetes/languages","stargazers_url":"https://api.github.com/repos/YuPengZTE/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/YuPengZTE/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/YuPengZTE/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/YuPengZTE/kubernetes/subscription","commits_url":"https://api.github.com/repos/YuPengZTE/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/YuPengZTE/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/YuPengZTE/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/YuPengZTE/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/YuPengZTE/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/YuPengZTE/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YuPengZTE/kubernetes/merges","archive_url":"https://api.github.com/repos/YuPengZTE/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YuPengZTE/kubernetes/downloads","issues_url":"https://api.github.com/repos/YuPengZTE/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/YuPengZTE/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/YuPengZTE/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/YuPengZTE/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YuPengZTE/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/YuPengZTE/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/YuPengZTE/kubernetes/deployments","created_at":"2016-09-08T02:58:53Z","updated_at":"2016-09-08T02:59:23Z","pushed_at":"2017-05-18T07:47:07Z","git_url":"git://github.com/YuPengZTE/kubernetes.git","ssh_url":"git@github.com:YuPengZTE/kubernetes.git","clone_url":"https://github.com/YuPengZTE/kubernetes.git","svn_url":"https://github.com/YuPengZTE/kubernetes","homepage":"http://kubernetes.io","size":426376,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7abb2641c5b6939d401618abe688c128708402cc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-05-18T07:07:18Z","pushed_at":"2017-05-18T07:47:10Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":647922,"stargazers_count":23270,"watchers_count":23270,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8187,"mirror_url":null,"open_issues_count":5651,"forks":8187,"open_issues":5651,"watchers":23270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/46018"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46018"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46018/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46018/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e9937d117d5c5c35ac4d6a0639e15d24d6805d41"}}}}
{"actor":{"display_login":"YuPengZTE"}}