{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/issues/165","repository_url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common","labels_url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/issues/165/comments","events_url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/issues/165/events","html_url":"https://github.com/phetsims/circuit-construction-kit-common/issues/165","id":164578798,"number":165,"title":"Solder should be in front of wires","user":{"login":"samreid","id":679486,"avatar_url":"https://avatars0.githubusercontent.com/u/679486?v=4","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"labels":[{"id":507745295,"url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/labels/circuit-construction-kit:layering","name":"circuit-construction-kit:layering","color":"006b75","default":false},{"id":100815525,"url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/labels/type:bug","name":"type:bug","color":"FF00AA","default":false}],"state":"open","locked":false,"assignee":{"login":"samreid","id":679486,"avatar_url":"https://avatars0.githubusercontent.com/u/679486?v=4","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"assignees":[{"login":"samreid","id":679486,"avatar_url":"https://avatars0.githubusercontent.com/u/679486?v=4","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-07-08T17:32:38Z","updated_at":"2017-07-31T04:23:01Z","closed_at":null,"body":"In #48 we decided the solder should be in front of the wires.  However, @phet-steele identified a case where this is failing:\n\nA wire will appear above the solder in the following scenario, seen in the #126 version. Before trying to reproduce, note it is VERY important to watch the order of events. The order in which wires/components are taken from the toolbox and placed into the play area is the whole reason this procedure works:\n1. Place any number of objects into the play area. Doesn't matter what they are.\n2. Take a wire and place it in the play area. Do NOT let it attach to anything, just place it by its lonesome.\n3. Now, connections MUST be made by dragging objects _from_ step 1 _towards_ wires from step 2. Reversing this order will not yield incorrect solder layering.\n\n![cckbb05](https://cloud.githubusercontent.com/assets/5863899/15872885/07a7158c-2cb9-11e6-98ec-3a05052a0e88.gif)\n"},"comment":{"url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/issues/comments/318964016","html_url":"https://github.com/phetsims/circuit-construction-kit-common/issues/165#issuecomment-318964016","issue_url":"https://api.github.com/repos/phetsims/circuit-construction-kit-common/issues/165","id":318964016,"user":{"login":"samreid","id":679486,"avatar_url":"https://avatars0.githubusercontent.com/u/679486?v=4","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T04:23:01Z","updated_at":"2017-07-31T04:23:01Z","body":"The proposed fix is implemented above.  It should address https://github.com/phetsims/circuit-construction-kit-common/issues/165#issuecomment-318744912 and it removed nearly 100 lines of complex layering code by making the layers separate instead of interleaved.\r\n\r\n@phet-steele and @arouinfar can you please test the https://github.com/phetsims/circuit-construction-kit-common/issues/165#issuecomment-318744912 and generally make sure play area layering is good for schematic and lifelike?  Here's a dev version:\r\n\r\nhttp://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.120/circuit-construction-kit-dc_en.html"}}
{"actor":{"display_login":"samreid"}}