{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/142152171","pull_request_review_id":66471497,"id":142152171,"diff_hunk":"@@ -87,16 +89,20 @@ open class PersistentNetworkMapCache(private val serviceHub: ServiceHubInternal)\n                     .sortedBy { it.name.toString() }\n         }\n \n+    private val nodeInfoSerializer = NodeInfoSerializer(serviceHub.configuration.baseDirectory)\n+\n     init {\n         loadFromFiles()\n         serviceHub.database.transaction { loadFromDB() }\n     }\n \n     private fun loadFromFiles() {\n         logger.info(\"Loading network map from files..\")\n-        for (node in NodeInfoSerializer().loadFromDirectory(serviceHub.configuration.baseDirectory)) {\n+        for (node in nodeInfoSerializer.loadFromDirectory()) {\n             addNode(node)\n         }\n+\n+        nodeInfoSerializer.directoryObservable().subscribe { node -> addNode(node)}","path":"node/src/main/kotlin/net/corda/node/services/network/PersistentNetworkMapCache.kt","position":null,"original_position":47,"commit_id":"067b5e1bbbf69faefab786bc4e86f09daf7beab3","original_commit_id":"aec67c14dfb0bd856c38947558b3be3384798a6d","user":{"login":"al-r3","id":30873160,"avatar_url":"https://avatars3.githubusercontent.com/u/30873160?v=4","gravatar_id":"","url":"https://api.github.com/users/al-r3","html_url":"https://github.com/al-r3","followers_url":"https://api.github.com/users/al-r3/followers","following_url":"https://api.github.com/users/al-r3/following{/other_user}","gists_url":"https://api.github.com/users/al-r3/gists{/gist_id}","starred_url":"https://api.github.com/users/al-r3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al-r3/subscriptions","organizations_url":"https://api.github.com/users/al-r3/orgs","repos_url":"https://api.github.com/users/al-r3/repos","events_url":"https://api.github.com/users/al-r3/events{/privacy}","received_events_url":"https://api.github.com/users/al-r3/received_events","type":"User","site_admin":false},"body":"discussed off-line, done","created_at":"2017-10-02T14:21:27Z","updated_at":"2017-10-02T14:21:27Z","html_url":"https://github.com/corda/corda/pull/1623#discussion_r142152171","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/1623","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/142152171"},"html":{"href":"https://github.com/corda/corda/pull/1623#discussion_r142152171"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/1623"}},"in_reply_to_id":142110054},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/1623","id":142847899,"html_url":"https://github.com/corda/corda/pull/1623","diff_url":"https://github.com/corda/corda/pull/1623.diff","patch_url":"https://github.com/corda/corda/pull/1623.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/1623","number":1623,"state":"open","locked":false,"title":"[CORDA-442]  Add filesystem polling to nodeInfos on disk.","user":{"login":"al-r3","id":30873160,"avatar_url":"https://avatars3.githubusercontent.com/u/30873160?v=4","gravatar_id":"","url":"https://api.github.com/users/al-r3","html_url":"https://github.com/al-r3","followers_url":"https://api.github.com/users/al-r3/followers","following_url":"https://api.github.com/users/al-r3/following{/other_user}","gists_url":"https://api.github.com/users/al-r3/gists{/gist_id}","starred_url":"https://api.github.com/users/al-r3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al-r3/subscriptions","organizations_url":"https://api.github.com/users/al-r3/orgs","repos_url":"https://api.github.com/users/al-r3/repos","events_url":"https://api.github.com/users/al-r3/events{/privacy}","received_events_url":"https://api.github.com/users/al-r3/received_events","type":"User","site_admin":false},"body":"Add the logic in node to poll for new serialized nodes to appear on disk.\r\n\r\nNewly discovered nodes are automatically added to the PersistentNetworkMapCache","created_at":"2017-09-25T10:35:38Z","updated_at":"2017-10-02T14:21:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdef9b21ed3c7247c6e6934651006a61b760270a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/1623/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/1623/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/1623/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/067b5e1bbbf69faefab786bc4e86f09daf7beab3","head":{"label":"corda:arri_netmap_diskpolling","ref":"arri_netmap_diskpolling","sha":"067b5e1bbbf69faefab786bc4e86f09daf7beab3","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2017-10-02T10:39:47Z","pushed_at":"2017-10-02T14:20:57Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":98549,"stargazers_count":1014,"watchers_count":1014,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":113,"forks":293,"open_issues":113,"watchers":1014,"default_branch":"master"}},"base":{"label":"corda:arri_netmap_disk2","ref":"arri_netmap_disk2","sha":"7136e60357ea164f02d1572c8ec661be142524ba","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2017-10-02T10:39:47Z","pushed_at":"2017-10-02T14:20:57Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":98549,"stargazers_count":1014,"watchers_count":1014,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":113,"forks":293,"open_issues":113,"watchers":1014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/1623"},"html":{"href":"https://github.com/corda/corda/pull/1623"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/1623"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/1623/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/1623/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/1623/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/067b5e1bbbf69faefab786bc4e86f09daf7beab3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"al-r3"}}