{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/comments/118232584","pull_request_review_id":40002927,"id":118232584,"diff_hunk":"@@ -50,35 +50,35 @@ Reference:\n \"\"\"\n module Stress\n \n-using GeometryTypes, Compat, FixedSizeArrays\n+using GeometryTypes, Compat, StaticArrays\n import Base: start, next, done, *\n \n-function (*){T<:LinAlg.BlasFloat,S<:FixedArray}(A::StridedMatrix{T}, x::StridedVector{S})\n+function (*){T<:LinAlg.BlasFloat,S<:StaticArray}(A::StridedMatrix{T}, x::StridedVector{S})\n     A_mul_B!(similar(x, S, size(A,1)), A, x)\n end\n \n-immutable Layout{M1<:AbstractMatrix, M2<:AbstractMatrix, VP<:AbstractVector,FT<:AbstractFloat}\n+immutable Layout{M1<:AbstractMatrix, M2<:AbstractMatrix, VP<:AbstractVector, FT<:AbstractFloat}\n     δ::M1\n     weights::M2\n     positions::VP\n-    pinvLw::Matrix{FT}\n+    pinvLw::Matrix{Float64}\n     iterations::Int\n     abstols::FT\n     reltols::FT\n     abstolx::FT\n end\n \n \n-function initialweights(D, T=eltype(D))\n+function initialweights(D)\n     map(D) do d\n-        x = T(d^(-2.0))\n-        isfinite(x) ? x : zero(T)\n+        x = Float64(d^(-2.0))","path":"src/stress.jl","position":32,"original_position":32,"commit_id":"e47a4265d8a158adfc23d6a405c46351428e3612","original_commit_id":"e47a4265d8a158adfc23d6a405c46351428e3612","user":{"login":"abhijithanilkumar","id":8404278,"avatar_url":"https://avatars1.githubusercontent.com/u/8404278?v=3","gravatar_id":"","url":"https://api.github.com/users/abhijithanilkumar","html_url":"https://github.com/abhijithanilkumar","followers_url":"https://api.github.com/users/abhijithanilkumar/followers","following_url":"https://api.github.com/users/abhijithanilkumar/following{/other_user}","gists_url":"https://api.github.com/users/abhijithanilkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/abhijithanilkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhijithanilkumar/subscriptions","organizations_url":"https://api.github.com/users/abhijithanilkumar/orgs","repos_url":"https://api.github.com/users/abhijithanilkumar/repos","events_url":"https://api.github.com/users/abhijithanilkumar/events{/privacy}","received_events_url":"https://api.github.com/users/abhijithanilkumar/received_events","type":"User","site_admin":false},"body":"Passing T to initialweights was the original setup. And doing `x = T(d) ^ T(-2.0)` still generates Any.","created_at":"2017-05-24T12:01:22Z","updated_at":"2017-05-24T12:01:22Z","html_url":"https://github.com/JuliaGraphs/NetworkLayout.jl/pull/14#discussion_r118232584","pull_request_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/comments/118232584"},"html":{"href":"https://github.com/JuliaGraphs/NetworkLayout.jl/pull/14#discussion_r118232584"},"pull_request":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14","id":121673641,"html_url":"https://github.com/JuliaGraphs/NetworkLayout.jl/pull/14","diff_url":"https://github.com/JuliaGraphs/NetworkLayout.jl/pull/14.diff","patch_url":"https://github.com/JuliaGraphs/NetworkLayout.jl/pull/14.patch","issue_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/14","number":14,"state":"open","locked":false,"title":"Release that supports Julia 0.6","user":{"login":"abhijithanilkumar","id":8404278,"avatar_url":"https://avatars1.githubusercontent.com/u/8404278?v=3","gravatar_id":"","url":"https://api.github.com/users/abhijithanilkumar","html_url":"https://github.com/abhijithanilkumar","followers_url":"https://api.github.com/users/abhijithanilkumar/followers","following_url":"https://api.github.com/users/abhijithanilkumar/following{/other_user}","gists_url":"https://api.github.com/users/abhijithanilkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/abhijithanilkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhijithanilkumar/subscriptions","organizations_url":"https://api.github.com/users/abhijithanilkumar/orgs","repos_url":"https://api.github.com/users/abhijithanilkumar/repos","events_url":"https://api.github.com/users/abhijithanilkumar/events{/privacy}","received_events_url":"https://api.github.com/users/abhijithanilkumar/received_events","type":"User","site_admin":false},"body":"* Use StaticArrays instead of FixedSizeArrays\r\n* Fix Deprecation warnings\r\n* Fix type issues","created_at":"2017-05-21T19:56:27Z","updated_at":"2017-05-24T12:01:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ed0831e349907431142d837c7e78005a19b51aa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14/commits","review_comments_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14/comments","review_comment_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/14/comments","statuses_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/statuses/e47a4265d8a158adfc23d6a405c46351428e3612","head":{"label":"JuliaGraphs:v0.6-dev","ref":"v0.6-dev","sha":"e47a4265d8a158adfc23d6a405c46351428e3612","user":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars3.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"repo":{"id":64144607,"name":"NetworkLayout.jl","full_name":"JuliaGraphs/NetworkLayout.jl","owner":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars3.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGraphs/NetworkLayout.jl","description":"Layout algorithms for graphs and trees in pure Julia.","fork":false,"url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl","forks_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/forks","keys_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/events","assignees_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/merges","archive_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/deployments","created_at":"2016-07-25T15:08:12Z","updated_at":"2017-05-04T18:06:24Z","pushed_at":"2017-05-21T20:55:33Z","git_url":"git://github.com/JuliaGraphs/NetworkLayout.jl.git","ssh_url":"git@github.com:JuliaGraphs/NetworkLayout.jl.git","clone_url":"https://github.com/JuliaGraphs/NetworkLayout.jl.git","svn_url":"https://github.com/JuliaGraphs/NetworkLayout.jl","homepage":"","size":78,"stargazers_count":15,"watchers_count":15,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":15,"default_branch":"master"}},"base":{"label":"JuliaGraphs:master","ref":"master","sha":"ce5f15fbaed4e20cb1c73a1bcd61d2ab147cac02","user":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars3.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"repo":{"id":64144607,"name":"NetworkLayout.jl","full_name":"JuliaGraphs/NetworkLayout.jl","owner":{"login":"JuliaGraphs","id":10791402,"avatar_url":"https://avatars3.githubusercontent.com/u/10791402?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGraphs","html_url":"https://github.com/JuliaGraphs","followers_url":"https://api.github.com/users/JuliaGraphs/followers","following_url":"https://api.github.com/users/JuliaGraphs/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGraphs/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGraphs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGraphs/subscriptions","organizations_url":"https://api.github.com/users/JuliaGraphs/orgs","repos_url":"https://api.github.com/users/JuliaGraphs/repos","events_url":"https://api.github.com/users/JuliaGraphs/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGraphs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGraphs/NetworkLayout.jl","description":"Layout algorithms for graphs and trees in pure Julia.","fork":false,"url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl","forks_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/forks","keys_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/events","assignees_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/merges","archive_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/deployments","created_at":"2016-07-25T15:08:12Z","updated_at":"2017-05-04T18:06:24Z","pushed_at":"2017-05-21T20:55:33Z","git_url":"git://github.com/JuliaGraphs/NetworkLayout.jl.git","ssh_url":"git@github.com:JuliaGraphs/NetworkLayout.jl.git","clone_url":"https://github.com/JuliaGraphs/NetworkLayout.jl.git","svn_url":"https://github.com/JuliaGraphs/NetworkLayout.jl","homepage":"","size":78,"stargazers_count":15,"watchers_count":15,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14"},"html":{"href":"https://github.com/JuliaGraphs/NetworkLayout.jl/pull/14"},"issue":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/14"},"comments":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaGraphs/NetworkLayout.jl/statuses/e47a4265d8a158adfc23d6a405c46351428e3612"}}}}
{"actor":{"display_login":"abhijithanilkumar"}}