{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/127940956","pull_request_review_id":50572404,"id":127940956,"diff_hunk":"@@ -51,8 +51,9 @@ const (\n \t\t\tVALUES(?,0,?,?,?)`\n \tinsertSequencedLeafSQL = `INSERT INTO SequencedLeafData(TreeId,LeafIdentityHash,MerkleLeafHash,SequenceNumber)\n \t\t\tVALUES(?,?,?,?)`\n-\tselectSequencedLeafCountSQL  = \"SELECT COUNT(*) FROM SequencedLeafData WHERE TreeId=?\"\n-\tselectLatestSignedLogRootSQL = `SELECT TreeHeadTimestamp,TreeSize,RootHash,TreeRevision,RootSignature\n+\tselectSequencedLeafCountSQL   = \"SELECT COUNT(*) FROM SequencedLeafData WHERE TreeId=?\"","path":"storage/mysql/log_storage.go","position":6,"original_position":6,"commit_id":"5c029f16b22d3a3e320ad98daf780f48c56e1868","original_commit_id":"b91cced1db68706426ccd845a85ae519dda1ea6f","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"body":"if there are 20B entries in the queue, then I'd want to know - even if that data was 20mins out of date.\r\nWe can build quicker proxy metrics (e.g. `Rate(Sum(ctfe.num_added)) - Rate(Sum(signer.sequenced)))`) too, but ground-truth is the number of rows in the table, and it'd be nice to have that on a graph.\r\n\r\nIf this murders the DBs then we can revisit (this is really what I meant by \"alright for now\").","created_at":"2017-07-18T10:44:44Z","updated_at":"2017-07-18T10:44:45Z","html_url":"https://github.com/google/trillian/pull/745#discussion_r127940956","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/745","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/127940956"},"html":{"href":"https://github.com/google/trillian/pull/745#discussion_r127940956"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/745"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/745","id":130634773,"html_url":"https://github.com/google/trillian/pull/745","diff_url":"https://github.com/google/trillian/pull/745.diff","patch_url":"https://github.com/google/trillian/pull/745.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/745","number":745,"state":"open","locked":false,"title":"Adds a GetUnsequencedCount() to LogStorage.","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-14T17:22:48Z","updated_at":"2017-07-18T10:44:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c81eeea506609f7620d87dbd3f9c1c64890aeb78","assignee":{"login":"codingllama","id":12500300,"avatar_url":"https://avatars3.githubusercontent.com/u/12500300?v=4","gravatar_id":"","url":"https://api.github.com/users/codingllama","html_url":"https://github.com/codingllama","followers_url":"https://api.github.com/users/codingllama/followers","following_url":"https://api.github.com/users/codingllama/following{/other_user}","gists_url":"https://api.github.com/users/codingllama/gists{/gist_id}","starred_url":"https://api.github.com/users/codingllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingllama/subscriptions","organizations_url":"https://api.github.com/users/codingllama/orgs","repos_url":"https://api.github.com/users/codingllama/repos","events_url":"https://api.github.com/users/codingllama/events{/privacy}","received_events_url":"https://api.github.com/users/codingllama/received_events","type":"User","site_admin":false},"assignees":[{"login":"codingllama","id":12500300,"avatar_url":"https://avatars3.githubusercontent.com/u/12500300?v=4","gravatar_id":"","url":"https://api.github.com/users/codingllama","html_url":"https://github.com/codingllama","followers_url":"https://api.github.com/users/codingllama/followers","following_url":"https://api.github.com/users/codingllama/following{/other_user}","gists_url":"https://api.github.com/users/codingllama/gists{/gist_id}","starred_url":"https://api.github.com/users/codingllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingllama/subscriptions","organizations_url":"https://api.github.com/users/codingllama/orgs","repos_url":"https://api.github.com/users/codingllama/repos","events_url":"https://api.github.com/users/codingllama/events{/privacy}","received_events_url":"https://api.github.com/users/codingllama/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/745/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/745/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/745/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/5c029f16b22d3a3e320ad98daf780f48c56e1868","head":{"label":"AlCutter:unseq_count","ref":"unseq_count","sha":"5c029f16b22d3a3e320ad98daf780f48c56e1868","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"repo":{"id":60775946,"name":"trillian","full_name":"AlCutter/trillian","owner":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlCutter/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/AlCutter/trillian","forks_url":"https://api.github.com/repos/AlCutter/trillian/forks","keys_url":"https://api.github.com/repos/AlCutter/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlCutter/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlCutter/trillian/teams","hooks_url":"https://api.github.com/repos/AlCutter/trillian/hooks","issue_events_url":"https://api.github.com/repos/AlCutter/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/AlCutter/trillian/events","assignees_url":"https://api.github.com/repos/AlCutter/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/AlCutter/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/AlCutter/trillian/tags","blobs_url":"https://api.github.com/repos/AlCutter/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlCutter/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlCutter/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlCutter/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlCutter/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/AlCutter/trillian/languages","stargazers_url":"https://api.github.com/repos/AlCutter/trillian/stargazers","contributors_url":"https://api.github.com/repos/AlCutter/trillian/contributors","subscribers_url":"https://api.github.com/repos/AlCutter/trillian/subscribers","subscription_url":"https://api.github.com/repos/AlCutter/trillian/subscription","commits_url":"https://api.github.com/repos/AlCutter/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlCutter/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlCutter/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlCutter/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlCutter/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/AlCutter/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlCutter/trillian/merges","archive_url":"https://api.github.com/repos/AlCutter/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlCutter/trillian/downloads","issues_url":"https://api.github.com/repos/AlCutter/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/AlCutter/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/AlCutter/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/AlCutter/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlCutter/trillian/labels{/name}","releases_url":"https://api.github.com/repos/AlCutter/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/AlCutter/trillian/deployments","created_at":"2016-06-09T13:14:33Z","updated_at":"2016-12-19T15:07:06Z","pushed_at":"2017-07-18T10:34:09Z","git_url":"git://github.com/AlCutter/trillian.git","ssh_url":"git@github.com:AlCutter/trillian.git","clone_url":"https://github.com/AlCutter/trillian.git","svn_url":"https://github.com/AlCutter/trillian","homepage":null,"size":6942,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"2f08bb2a313c66f44b0fc31342a356321a439e3b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2017-07-18T07:50:17Z","pushed_at":"2017-07-18T10:34:11Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":"","size":6882,"stargazers_count":570,"watchers_count":570,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":46,"forks":81,"open_issues":46,"watchers":570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/745"},"html":{"href":"https://github.com/google/trillian/pull/745"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/745"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/745/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/745/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/745/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/5c029f16b22d3a3e320ad98daf780f48c56e1868"}}}}
{"actor":{"display_login":"AlCutter"}}