{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/jwala/pulls/comments/110730785","pull_request_review_id":31923806,"id":110730785,"diff_hunk":"@@ -138,7 +152,15 @@ public WebServer getWebServer(final String aWebServerName) {\n     public WebServer updateWebServer(final UpdateWebServerRequest anUpdateWebServerCommand,\n                                      final User anUpdatingUser) {\n         anUpdateWebServerCommand.validate();\n-\n+        try {\n+            if (null != jvmPersistenceService.findJvmByExactName(anUpdateWebServerCommand.getNewName())) {","path":"jwala-services/src/main/java/com/cerner/jwala/service/webserver/impl/WebServerServiceImpl.java","position":48,"original_position":48,"commit_id":"104ccf36c8c116365ce9c582e6fad07d9445e31b","original_commit_id":"104ccf36c8c116365ce9c582e6fad07d9445e31b","user":{"login":"jmahmoodcc","id":25931975,"avatar_url":"https://avatars0.githubusercontent.com/u/25931975?v=3","gravatar_id":"","url":"https://api.github.com/users/jmahmoodcc","html_url":"https://github.com/jmahmoodcc","followers_url":"https://api.github.com/users/jmahmoodcc/followers","following_url":"https://api.github.com/users/jmahmoodcc/following{/other_user}","gists_url":"https://api.github.com/users/jmahmoodcc/gists{/gist_id}","starred_url":"https://api.github.com/users/jmahmoodcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmahmoodcc/subscriptions","organizations_url":"https://api.github.com/users/jmahmoodcc/orgs","repos_url":"https://api.github.com/users/jmahmoodcc/repos","events_url":"https://api.github.com/users/jmahmoodcc/events{/privacy}","received_events_url":"https://api.github.com/users/jmahmoodcc/received_events","type":"User","site_admin":false},"body":"Remove the \"if != null\"","created_at":"2017-04-10T18:36:12Z","updated_at":"2017-04-10T18:36:46Z","html_url":"https://github.com/cerner/jwala/pull/67#discussion_r110730785","pull_request_url":"https://api.github.com/repos/cerner/jwala/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/cerner/jwala/pulls/comments/110730785"},"html":{"href":"https://github.com/cerner/jwala/pull/67#discussion_r110730785"},"pull_request":{"href":"https://api.github.com/repos/cerner/jwala/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/jwala/pulls/67","id":114988782,"html_url":"https://github.com/cerner/jwala/pull/67","diff_url":"https://github.com/cerner/jwala/pull/67.diff","patch_url":"https://github.com/cerner/jwala/pull/67.patch","issue_url":"https://api.github.com/repos/cerner/jwala/issues/67","number":67,"state":"open","locked":false,"title":"cannot have same jvm and webserver name validation","user":{"login":"rahulsayini","id":10622064,"avatar_url":"https://avatars1.githubusercontent.com/u/10622064?v=3","gravatar_id":"","url":"https://api.github.com/users/rahulsayini","html_url":"https://github.com/rahulsayini","followers_url":"https://api.github.com/users/rahulsayini/followers","following_url":"https://api.github.com/users/rahulsayini/following{/other_user}","gists_url":"https://api.github.com/users/rahulsayini/gists{/gist_id}","starred_url":"https://api.github.com/users/rahulsayini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rahulsayini/subscriptions","organizations_url":"https://api.github.com/users/rahulsayini/orgs","repos_url":"https://api.github.com/users/rahulsayini/repos","events_url":"https://api.github.com/users/rahulsayini/events{/privacy}","received_events_url":"https://api.github.com/users/rahulsayini/received_events","type":"User","site_admin":false},"body":"Before you contribute, please review these guidelines to help ensure a smooth process for everyone.\r\n\r\nThanks.\r\n\r\n* Read [how to properly contribute to open source projects on Github][1].\r\n* Fork the project.\r\n* Use a feature branch.\r\n* Write [good commit messages][2].\r\n* Use the same coding conventions as the rest of the project.\r\n* Commit locally and push to your fork until you are happy with your contribution.\r\n* Make sure to add tests and verify all the tests are passing when merging upstream.\r\n* Add an entry to the [Changelog][3] accordingly.\r\n* Please add your name to the [CONTRIBUTORS.md][7] file. Adding your name to the [CONTRIBUTORS.md][7] file signifies agreement to all rights and reservations provided by the [License][4].\r\n* [Squash related commits together][5].\r\n* Open a [pull request][6].\r\n* The pull request will be reviewed by the community and merged by the project committers.\r\n\r\n[1]: http://gun.io/blog/how-to-github-fork-branch-and-pull-request\r\n[2]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html\r\n[3]: ./CHANGELOG.md\r\n[4]: ./LICENSE\r\n[5]: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html\r\n[6]: https://help.github.com/articles/using-pull-requests\r\n[7]: ./CONTRIBUTORS.md\r\n","created_at":"2017-04-09T14:48:49Z","updated_at":"2017-04-10T18:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8901870475b0f462af26881dfd93d2e55aed4bcc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/jwala/pulls/67/commits","review_comments_url":"https://api.github.com/repos/cerner/jwala/pulls/67/comments","review_comment_url":"https://api.github.com/repos/cerner/jwala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/jwala/issues/67/comments","statuses_url":"https://api.github.com/repos/cerner/jwala/statuses/104ccf36c8c116365ce9c582e6fad07d9445e31b","head":{"label":"cerner:service-name-conflict","ref":"service-name-conflict","sha":"104ccf36c8c116365ce9c582e6fad07d9445e31b","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":82604742,"name":"jwala","full_name":"cerner/jwala","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/jwala","description":"A web application that provides management for a group of Tomcat servers","fork":false,"url":"https://api.github.com/repos/cerner/jwala","forks_url":"https://api.github.com/repos/cerner/jwala/forks","keys_url":"https://api.github.com/repos/cerner/jwala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/jwala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/jwala/teams","hooks_url":"https://api.github.com/repos/cerner/jwala/hooks","issue_events_url":"https://api.github.com/repos/cerner/jwala/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/jwala/events","assignees_url":"https://api.github.com/repos/cerner/jwala/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/jwala/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/jwala/tags","blobs_url":"https://api.github.com/repos/cerner/jwala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/jwala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/jwala/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/jwala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/jwala/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/jwala/languages","stargazers_url":"https://api.github.com/repos/cerner/jwala/stargazers","contributors_url":"https://api.github.com/repos/cerner/jwala/contributors","subscribers_url":"https://api.github.com/repos/cerner/jwala/subscribers","subscription_url":"https://api.github.com/repos/cerner/jwala/subscription","commits_url":"https://api.github.com/repos/cerner/jwala/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/jwala/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/jwala/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/jwala/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/jwala/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/jwala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/jwala/merges","archive_url":"https://api.github.com/repos/cerner/jwala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/jwala/downloads","issues_url":"https://api.github.com/repos/cerner/jwala/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/jwala/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/jwala/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/jwala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/jwala/labels{/name}","releases_url":"https://api.github.com/repos/cerner/jwala/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/jwala/deployments","created_at":"2017-02-20T21:31:29Z","updated_at":"2017-04-09T12:17:25Z","pushed_at":"2017-04-10T18:30:33Z","git_url":"git://github.com/cerner/jwala.git","ssh_url":"git@github.com:cerner/jwala.git","clone_url":"https://github.com/cerner/jwala.git","svn_url":"https://github.com/cerner/jwala","homepage":null,"size":27598,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":5,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"676ee598199ab959d2ab6136ab81d20f71b0b75c","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":82604742,"name":"jwala","full_name":"cerner/jwala","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/jwala","description":"A web application that provides management for a group of Tomcat servers","fork":false,"url":"https://api.github.com/repos/cerner/jwala","forks_url":"https://api.github.com/repos/cerner/jwala/forks","keys_url":"https://api.github.com/repos/cerner/jwala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/jwala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/jwala/teams","hooks_url":"https://api.github.com/repos/cerner/jwala/hooks","issue_events_url":"https://api.github.com/repos/cerner/jwala/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/jwala/events","assignees_url":"https://api.github.com/repos/cerner/jwala/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/jwala/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/jwala/tags","blobs_url":"https://api.github.com/repos/cerner/jwala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/jwala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/jwala/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/jwala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/jwala/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/jwala/languages","stargazers_url":"https://api.github.com/repos/cerner/jwala/stargazers","contributors_url":"https://api.github.com/repos/cerner/jwala/contributors","subscribers_url":"https://api.github.com/repos/cerner/jwala/subscribers","subscription_url":"https://api.github.com/repos/cerner/jwala/subscription","commits_url":"https://api.github.com/repos/cerner/jwala/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/jwala/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/jwala/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/jwala/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/jwala/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/jwala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/jwala/merges","archive_url":"https://api.github.com/repos/cerner/jwala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/jwala/downloads","issues_url":"https://api.github.com/repos/cerner/jwala/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/jwala/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/jwala/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/jwala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/jwala/labels{/name}","releases_url":"https://api.github.com/repos/cerner/jwala/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/jwala/deployments","created_at":"2017-02-20T21:31:29Z","updated_at":"2017-04-09T12:17:25Z","pushed_at":"2017-04-10T18:30:33Z","git_url":"git://github.com/cerner/jwala.git","ssh_url":"git@github.com:cerner/jwala.git","clone_url":"https://github.com/cerner/jwala.git","svn_url":"https://github.com/cerner/jwala","homepage":null,"size":27598,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/jwala/pulls/67"},"html":{"href":"https://github.com/cerner/jwala/pull/67"},"issue":{"href":"https://api.github.com/repos/cerner/jwala/issues/67"},"comments":{"href":"https://api.github.com/repos/cerner/jwala/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/jwala/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/jwala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/jwala/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/jwala/statuses/104ccf36c8c116365ce9c582e6fad07d9445e31b"}}}}
{"actor":{"display_login":"jmahmoodcc"}}