{"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/136997371","pull_request_review_id":60608945,"id":136997371,"diff_hunk":"@@ -1465,6 +1465,7 @@ g_process_finish(void)\n #endif\n \n   g_process_remove_pidfile();\n+  reloc_deinit(); /* path_cache needed for calculating pidfile location above */\n }","path":"lib/gprocess.c","position":5,"original_position":5,"commit_id":"3aae4b193f141b83e87730a70c9a6db35ae971f2","original_commit_id":"8c5a990489837de4f3f451fa5b4c41d857cc7974","user":{"login":"furiel","id":11007226,"avatar_url":"https://avatars0.githubusercontent.com/u/11007226?v=4","gravatar_id":"","url":"https://api.github.com/users/furiel","html_url":"https://github.com/furiel","followers_url":"https://api.github.com/users/furiel/followers","following_url":"https://api.github.com/users/furiel/following{/other_user}","gists_url":"https://api.github.com/users/furiel/gists{/gist_id}","starred_url":"https://api.github.com/users/furiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furiel/subscriptions","organizations_url":"https://api.github.com/users/furiel/orgs","repos_url":"https://api.github.com/users/furiel/repos","events_url":"https://api.github.com/users/furiel/events{/privacy}","received_events_url":"https://api.github.com/users/furiel/received_events","type":"User","site_admin":false},"body":"Thanks, I'll go with 2).","created_at":"2017-09-05T14:05:52Z","updated_at":"2017-09-05T14:05:52Z","html_url":"https://github.com/balabit/syslog-ng/pull/1649#discussion_r136997371","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/136997371"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/1649#discussion_r136997371"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649"}},"in_reply_to_id":136812437},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649","id":136784420,"html_url":"https://github.com/balabit/syslog-ng/pull/1649","diff_url":"https://github.com/balabit/syslog-ng/pull/1649.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/1649.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/1649","number":1649,"state":"open","locked":false,"title":"memleak hunting: cleanup based on valgrind report","user":{"login":"furiel","id":11007226,"avatar_url":"https://avatars0.githubusercontent.com/u/11007226?v=4","gravatar_id":"","url":"https://api.github.com/users/furiel","html_url":"https://github.com/furiel","followers_url":"https://api.github.com/users/furiel/followers","following_url":"https://api.github.com/users/furiel/following{/other_user}","gists_url":"https://api.github.com/users/furiel/gists{/gist_id}","starred_url":"https://api.github.com/users/furiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furiel/subscriptions","organizations_url":"https://api.github.com/users/furiel/orgs","repos_url":"https://api.github.com/users/furiel/repos","events_url":"https://api.github.com/users/furiel/events{/privacy}","received_events_url":"https://api.github.com/users/furiel/received_events","type":"User","site_admin":false},"body":"This patchet intends to fix some entries in valgrind report. All of these issues are minors, i.e non of them accumulate over time. All of these changes intended to be cosmetic, explicitely calling deinits/frees, instead of just adding new exceptions to a valgrind suppress file.\r\n\r\nCredits for @bkil-syslogng for https://github.com/balabit/syslog-ng/pull/975, which gave much inspiration for this pull request.\r\nOnly there are two commits in 975 that were not ported. I list them here for documentation reason.\r\n-  g_process_set_argv_space. There were a lot of fight on these recently. The proposed change is still incomplete, see https://github.com/balabit/syslog-ng/pull/1528 for details.\r\n- g_static_mutex_free. Syslog-ng mutexes are typically statically initialized. The glib documentation states that \"[...] You don't have to call this functions for a GStaticMutex with an unbounded lifetime, i.e. objects declared 'static', [...]\". In the glib implementation, when someone calls lock in the first time on such a static mutex, glib will allocate using malloc on the fly, but there is no automatic deallocation mechanism provided. As that malloc is not freed, valgrind reports it as still reachable memory. The suggested patch calls explicitely g_static_mutex_free-s on these objects. This should work, though I feel this change somewhat risky, because the documentation states we do not have to call such function. There is a small chance (very low, because we are talking about a deprecated mutex api to begin with ...) that some automatic deallocation would be introduced glib at some point. Especially, this leak comes from the design of glib, I don't want to fix it from syslog-ng side. That's why I did not pick that patch.\r\n\r\nThe dns_cache part is reported in: https://github.com/balabit/syslog-ng/issues/1400","created_at":"2017-08-21T15:21:56Z","updated_at":"2017-09-05T14:05:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24a80fe34681fb91fbae21094c60754bc1617b5c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/1649/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/3aae4b193f141b83e87730a70c9a6db35ae971f2","head":{"label":"furiel:instead-of-suppr","ref":"instead-of-suppr","sha":"3aae4b193f141b83e87730a70c9a6db35ae971f2","user":{"login":"furiel","id":11007226,"avatar_url":"https://avatars0.githubusercontent.com/u/11007226?v=4","gravatar_id":"","url":"https://api.github.com/users/furiel","html_url":"https://github.com/furiel","followers_url":"https://api.github.com/users/furiel/followers","following_url":"https://api.github.com/users/furiel/following{/other_user}","gists_url":"https://api.github.com/users/furiel/gists{/gist_id}","starred_url":"https://api.github.com/users/furiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furiel/subscriptions","organizations_url":"https://api.github.com/users/furiel/orgs","repos_url":"https://api.github.com/users/furiel/repos","events_url":"https://api.github.com/users/furiel/events{/privacy}","received_events_url":"https://api.github.com/users/furiel/received_events","type":"User","site_admin":false},"repo":{"id":87412101,"name":"syslog-ng","full_name":"furiel/syslog-ng","owner":{"login":"furiel","id":11007226,"avatar_url":"https://avatars0.githubusercontent.com/u/11007226?v=4","gravatar_id":"","url":"https://api.github.com/users/furiel","html_url":"https://github.com/furiel","followers_url":"https://api.github.com/users/furiel/followers","following_url":"https://api.github.com/users/furiel/following{/other_user}","gists_url":"https://api.github.com/users/furiel/gists{/gist_id}","starred_url":"https://api.github.com/users/furiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furiel/subscriptions","organizations_url":"https://api.github.com/users/furiel/orgs","repos_url":"https://api.github.com/users/furiel/repos","events_url":"https://api.github.com/users/furiel/events{/privacy}","received_events_url":"https://api.github.com/users/furiel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/furiel/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":true,"url":"https://api.github.com/repos/furiel/syslog-ng","forks_url":"https://api.github.com/repos/furiel/syslog-ng/forks","keys_url":"https://api.github.com/repos/furiel/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/furiel/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/furiel/syslog-ng/teams","hooks_url":"https://api.github.com/repos/furiel/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/furiel/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/furiel/syslog-ng/events","assignees_url":"https://api.github.com/repos/furiel/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/furiel/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/furiel/syslog-ng/tags","blobs_url":"https://api.github.com/repos/furiel/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/furiel/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/furiel/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/furiel/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/furiel/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/furiel/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/furiel/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/furiel/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/furiel/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/furiel/syslog-ng/subscription","commits_url":"https://api.github.com/repos/furiel/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/furiel/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/furiel/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/furiel/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/furiel/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/furiel/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/furiel/syslog-ng/merges","archive_url":"https://api.github.com/repos/furiel/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/furiel/syslog-ng/downloads","issues_url":"https://api.github.com/repos/furiel/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/furiel/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/furiel/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/furiel/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/furiel/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/furiel/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/furiel/syslog-ng/deployments","created_at":"2017-04-06T09:35:22Z","updated_at":"2017-04-06T09:35:27Z","pushed_at":"2017-09-05T13:22:29Z","git_url":"git://github.com/furiel/syslog-ng.git","ssh_url":"git@github.com:furiel/syslog-ng.git","clone_url":"https://github.com/furiel/syslog-ng.git","svn_url":"https://github.com/furiel/syslog-ng","homepage":"http://www.syslog-ng.org/","size":20669,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"3c1b630eee51ca2dca791e3a9e126346adb7d42b","user":{"login":"balabit","id":986981,"avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"name":"syslog-ng","full_name":"balabit/syslog-ng","owner":{"login":"balabit","id":986981,"avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2017-09-03T05:25:28Z","pushed_at":"2017-09-05T13:22:30Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"http://www.syslog-ng.org/","size":20827,"stargazers_count":628,"watchers_count":628,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":227,"forks":179,"open_issues":227,"watchers":628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/1649"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/1649"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/1649/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/1649/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/3aae4b193f141b83e87730a70c9a6db35ae971f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"furiel"}}