{"action":"created","issue":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/80","repository_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops","labels_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/80/comments","events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/80/events","html_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/80","id":236846149,"number":80,"title":"'data_access' TF module: Safer bucket names","user":{"login":"xoen","id":238563,"avatar_url":"https://avatars3.githubusercontent.com/u/238563?v=3","gravatar_id":"","url":"https://api.github.com/users/xoen","html_url":"https://github.com/xoen","followers_url":"https://api.github.com/users/xoen/followers","following_url":"https://api.github.com/users/xoen/following{/other_user}","gists_url":"https://api.github.com/users/xoen/gists{/gist_id}","starred_url":"https://api.github.com/users/xoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoen/subscriptions","organizations_url":"https://api.github.com/users/xoen/orgs","repos_url":"https://api.github.com/users/xoen/repos","events_url":"https://api.github.com/users/xoen/events{/privacy}","received_events_url":"https://api.github.com/users/xoen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-19T10:27:19Z","updated_at":"2017-06-21T10:22:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/80","html_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/80","diff_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/80.diff","patch_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/80.patch"},"body":"Team slugs coming from GitHub may contains characters which are not valid\r\nin an S3 bucket name, e.g. underscores (`_`).\r\n\r\nWe're keeping it simple for now and just replacing the invalid characters with an hyphen (`-`).\r\n\r\n**NOTE**: This changes doesn't handle all the S3 limitations but it should be good\r\nenough for the time being.\r\n\r\nSee: http://docs.aws.amazon.com/en_gb/AmazonS3/latest/dev/BucketRestrictions.html\r\n\r\n\r\n#### Ticket\r\n\r\nhttps://trello.com/c/fp3eVZyG/231-s-createteambucket-lambda-to-sanitize-team-name-to-not-fail-when-containing-s"},"comment":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/comments/310036266","html_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/80#issuecomment-310036266","issue_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/80","id":310036266,"user":{"login":"xoen","id":238563,"avatar_url":"https://avatars3.githubusercontent.com/u/238563?v=3","gravatar_id":"","url":"https://api.github.com/users/xoen","html_url":"https://github.com/xoen","followers_url":"https://api.github.com/users/xoen/followers","following_url":"https://api.github.com/users/xoen/following{/other_user}","gists_url":"https://api.github.com/users/xoen/gists{/gist_id}","starred_url":"https://api.github.com/users/xoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoen/subscriptions","organizations_url":"https://api.github.com/users/xoen/orgs","repos_url":"https://api.github.com/users/xoen/repos","events_url":"https://api.github.com/users/xoen/events{/privacy}","received_events_url":"https://api.github.com/users/xoen/received_events","type":"User","site_admin":false},"created_at":"2017-06-21T10:22:52Z","updated_at":"2017-06-21T10:22:52Z","body":"Done: https://github.com/ministryofjustice/analytics-platform-ops/pull/80/commits/becc7ca15a966e3d76e9f4f3a881f92b0062be8d"}}
{"actor":{"display_login":"xoen"}}