{"action":"created","comment":{"url":"https://api.github.com/repos/takipi/takipi-storage/pulls/comments/148006668","pull_request_review_id":73179821,"id":148006668,"diff_hunk":"@@ -16,31 +16,75 @@\n public class MultiFetcher {\n     \n     private static final Logger logger = LoggerFactory.getLogger(MultiFetcher.class);\n+    private static long maxCacheSize = 33554432;\n     \n     private final TaskExecutor taskExecutor;\n+    private final static S3Cache cache;\n+    \n+    static {\n+        if (maxCacheSize > 0) {","path":"src/main/java/com/takipi/oss/storage/resources/fs/multifetcher/MultiFetcher.java","position":23,"original_position":23,"commit_id":"75920fd9f2efe2a5592468818d0df7487739a5dd","original_commit_id":"75920fd9f2efe2a5592468818d0df7487739a5dd","user":{"login":"davidlevanon","id":11028929,"avatar_url":"https://avatars1.githubusercontent.com/u/11028929?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlevanon","html_url":"https://github.com/davidlevanon","followers_url":"https://api.github.com/users/davidlevanon/followers","following_url":"https://api.github.com/users/davidlevanon/following{/other_user}","gists_url":"https://api.github.com/users/davidlevanon/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlevanon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlevanon/subscriptions","organizations_url":"https://api.github.com/users/davidlevanon/orgs","repos_url":"https://api.github.com/users/davidlevanon/repos","events_url":"https://api.github.com/users/davidlevanon/events{/privacy}","received_events_url":"https://api.github.com/users/davidlevanon/received_events","type":"User","site_admin":false},"body":"What does this mean? Is it typo?","created_at":"2017-10-31T14:09:53Z","updated_at":"2017-10-31T14:29:42Z","html_url":"https://github.com/takipi/takipi-storage/pull/28#discussion_r148006668","pull_request_url":"https://api.github.com/repos/takipi/takipi-storage/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/takipi/takipi-storage/pulls/comments/148006668"},"html":{"href":"https://github.com/takipi/takipi-storage/pull/28#discussion_r148006668"},"pull_request":{"href":"https://api.github.com/repos/takipi/takipi-storage/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/takipi/takipi-storage/pulls/28","id":148004590,"html_url":"https://github.com/takipi/takipi-storage/pull/28","diff_url":"https://github.com/takipi/takipi-storage/pull/28.diff","patch_url":"https://github.com/takipi/takipi-storage/pull/28.patch","issue_url":"https://api.github.com/repos/takipi/takipi-storage/issues/28","number":28,"state":"open","locked":false,"title":"Feature/8842/add caching","user":{"login":"mervyn2017","id":29354127,"avatar_url":"https://avatars3.githubusercontent.com/u/29354127?v=4","gravatar_id":"","url":"https://api.github.com/users/mervyn2017","html_url":"https://github.com/mervyn2017","followers_url":"https://api.github.com/users/mervyn2017/followers","following_url":"https://api.github.com/users/mervyn2017/following{/other_user}","gists_url":"https://api.github.com/users/mervyn2017/gists{/gist_id}","starred_url":"https://api.github.com/users/mervyn2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mervyn2017/subscriptions","organizations_url":"https://api.github.com/users/mervyn2017/orgs","repos_url":"https://api.github.com/users/mervyn2017/repos","events_url":"https://api.github.com/users/mervyn2017/events{/privacy}","received_events_url":"https://api.github.com/users/mervyn2017/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-22T17:42:19Z","updated_at":"2017-10-31T14:29:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"385ef7a629dcf8ed0796285efe3a78287872ed60","assignee":{"login":"shimonmagal","id":11137000,"avatar_url":"https://avatars1.githubusercontent.com/u/11137000?v=4","gravatar_id":"","url":"https://api.github.com/users/shimonmagal","html_url":"https://github.com/shimonmagal","followers_url":"https://api.github.com/users/shimonmagal/followers","following_url":"https://api.github.com/users/shimonmagal/following{/other_user}","gists_url":"https://api.github.com/users/shimonmagal/gists{/gist_id}","starred_url":"https://api.github.com/users/shimonmagal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shimonmagal/subscriptions","organizations_url":"https://api.github.com/users/shimonmagal/orgs","repos_url":"https://api.github.com/users/shimonmagal/repos","events_url":"https://api.github.com/users/shimonmagal/events{/privacy}","received_events_url":"https://api.github.com/users/shimonmagal/received_events","type":"User","site_admin":false},"assignees":[{"login":"shimonmagal","id":11137000,"avatar_url":"https://avatars1.githubusercontent.com/u/11137000?v=4","gravatar_id":"","url":"https://api.github.com/users/shimonmagal","html_url":"https://github.com/shimonmagal","followers_url":"https://api.github.com/users/shimonmagal/followers","following_url":"https://api.github.com/users/shimonmagal/following{/other_user}","gists_url":"https://api.github.com/users/shimonmagal/gists{/gist_id}","starred_url":"https://api.github.com/users/shimonmagal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shimonmagal/subscriptions","organizations_url":"https://api.github.com/users/shimonmagal/orgs","repos_url":"https://api.github.com/users/shimonmagal/repos","events_url":"https://api.github.com/users/shimonmagal/events{/privacy}","received_events_url":"https://api.github.com/users/shimonmagal/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/takipi/takipi-storage/pulls/28/commits","review_comments_url":"https://api.github.com/repos/takipi/takipi-storage/pulls/28/comments","review_comment_url":"https://api.github.com/repos/takipi/takipi-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/takipi/takipi-storage/issues/28/comments","statuses_url":"https://api.github.com/repos/takipi/takipi-storage/statuses/75920fd9f2efe2a5592468818d0df7487739a5dd","head":{"label":"takipi:feature/8842/add-caching","ref":"feature/8842/add-caching","sha":"75920fd9f2efe2a5592468818d0df7487739a5dd","user":{"login":"takipi","id":3494378,"avatar_url":"https://avatars1.githubusercontent.com/u/3494378?v=4","gravatar_id":"","url":"https://api.github.com/users/takipi","html_url":"https://github.com/takipi","followers_url":"https://api.github.com/users/takipi/followers","following_url":"https://api.github.com/users/takipi/following{/other_user}","gists_url":"https://api.github.com/users/takipi/gists{/gist_id}","starred_url":"https://api.github.com/users/takipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takipi/subscriptions","organizations_url":"https://api.github.com/users/takipi/orgs","repos_url":"https://api.github.com/users/takipi/repos","events_url":"https://api.github.com/users/takipi/events{/privacy}","received_events_url":"https://api.github.com/users/takipi/received_events","type":"Organization","site_admin":false},"repo":{"id":29150662,"name":"takipi-storage","full_name":"takipi/takipi-storage","owner":{"login":"takipi","id":3494378,"avatar_url":"https://avatars1.githubusercontent.com/u/3494378?v=4","gravatar_id":"","url":"https://api.github.com/users/takipi","html_url":"https://github.com/takipi","followers_url":"https://api.github.com/users/takipi/followers","following_url":"https://api.github.com/users/takipi/following{/other_user}","gists_url":"https://api.github.com/users/takipi/gists{/gist_id}","starred_url":"https://api.github.com/users/takipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takipi/subscriptions","organizations_url":"https://api.github.com/users/takipi/orgs","repos_url":"https://api.github.com/users/takipi/repos","events_url":"https://api.github.com/users/takipi/events{/privacy}","received_events_url":"https://api.github.com/users/takipi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/takipi/takipi-storage","description":"Takipi storage server for hybrid on-prem","fork":false,"url":"https://api.github.com/repos/takipi/takipi-storage","forks_url":"https://api.github.com/repos/takipi/takipi-storage/forks","keys_url":"https://api.github.com/repos/takipi/takipi-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takipi/takipi-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takipi/takipi-storage/teams","hooks_url":"https://api.github.com/repos/takipi/takipi-storage/hooks","issue_events_url":"https://api.github.com/repos/takipi/takipi-storage/issues/events{/number}","events_url":"https://api.github.com/repos/takipi/takipi-storage/events","assignees_url":"https://api.github.com/repos/takipi/takipi-storage/assignees{/user}","branches_url":"https://api.github.com/repos/takipi/takipi-storage/branches{/branch}","tags_url":"https://api.github.com/repos/takipi/takipi-storage/tags","blobs_url":"https://api.github.com/repos/takipi/takipi-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takipi/takipi-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takipi/takipi-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/takipi/takipi-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takipi/takipi-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/takipi/takipi-storage/languages","stargazers_url":"https://api.github.com/repos/takipi/takipi-storage/stargazers","contributors_url":"https://api.github.com/repos/takipi/takipi-storage/contributors","subscribers_url":"https://api.github.com/repos/takipi/takipi-storage/subscribers","subscription_url":"https://api.github.com/repos/takipi/takipi-storage/subscription","commits_url":"https://api.github.com/repos/takipi/takipi-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/takipi/takipi-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/takipi/takipi-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/takipi/takipi-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/takipi/takipi-storage/contents/{+path}","compare_url":"https://api.github.com/repos/takipi/takipi-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takipi/takipi-storage/merges","archive_url":"https://api.github.com/repos/takipi/takipi-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takipi/takipi-storage/downloads","issues_url":"https://api.github.com/repos/takipi/takipi-storage/issues{/number}","pulls_url":"https://api.github.com/repos/takipi/takipi-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/takipi/takipi-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/takipi/takipi-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takipi/takipi-storage/labels{/name}","releases_url":"https://api.github.com/repos/takipi/takipi-storage/releases{/id}","deployments_url":"https://api.github.com/repos/takipi/takipi-storage/deployments","created_at":"2015-01-12T18:47:27Z","updated_at":"2017-08-01T22:36:13Z","pushed_at":"2017-10-31T11:47:02Z","git_url":"git://github.com/takipi/takipi-storage.git","ssh_url":"git@github.com:takipi/takipi-storage.git","clone_url":"https://github.com/takipi/takipi-storage.git","svn_url":"https://github.com/takipi/takipi-storage","homepage":"https://www.overops.com","size":235,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":4,"default_branch":"develop"}},"base":{"label":"takipi:s3-storage","ref":"s3-storage","sha":"567b274e043641b4e02605bcea7d4565cb0995ed","user":{"login":"takipi","id":3494378,"avatar_url":"https://avatars1.githubusercontent.com/u/3494378?v=4","gravatar_id":"","url":"https://api.github.com/users/takipi","html_url":"https://github.com/takipi","followers_url":"https://api.github.com/users/takipi/followers","following_url":"https://api.github.com/users/takipi/following{/other_user}","gists_url":"https://api.github.com/users/takipi/gists{/gist_id}","starred_url":"https://api.github.com/users/takipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takipi/subscriptions","organizations_url":"https://api.github.com/users/takipi/orgs","repos_url":"https://api.github.com/users/takipi/repos","events_url":"https://api.github.com/users/takipi/events{/privacy}","received_events_url":"https://api.github.com/users/takipi/received_events","type":"Organization","site_admin":false},"repo":{"id":29150662,"name":"takipi-storage","full_name":"takipi/takipi-storage","owner":{"login":"takipi","id":3494378,"avatar_url":"https://avatars1.githubusercontent.com/u/3494378?v=4","gravatar_id":"","url":"https://api.github.com/users/takipi","html_url":"https://github.com/takipi","followers_url":"https://api.github.com/users/takipi/followers","following_url":"https://api.github.com/users/takipi/following{/other_user}","gists_url":"https://api.github.com/users/takipi/gists{/gist_id}","starred_url":"https://api.github.com/users/takipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takipi/subscriptions","organizations_url":"https://api.github.com/users/takipi/orgs","repos_url":"https://api.github.com/users/takipi/repos","events_url":"https://api.github.com/users/takipi/events{/privacy}","received_events_url":"https://api.github.com/users/takipi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/takipi/takipi-storage","description":"Takipi storage server for hybrid on-prem","fork":false,"url":"https://api.github.com/repos/takipi/takipi-storage","forks_url":"https://api.github.com/repos/takipi/takipi-storage/forks","keys_url":"https://api.github.com/repos/takipi/takipi-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takipi/takipi-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takipi/takipi-storage/teams","hooks_url":"https://api.github.com/repos/takipi/takipi-storage/hooks","issue_events_url":"https://api.github.com/repos/takipi/takipi-storage/issues/events{/number}","events_url":"https://api.github.com/repos/takipi/takipi-storage/events","assignees_url":"https://api.github.com/repos/takipi/takipi-storage/assignees{/user}","branches_url":"https://api.github.com/repos/takipi/takipi-storage/branches{/branch}","tags_url":"https://api.github.com/repos/takipi/takipi-storage/tags","blobs_url":"https://api.github.com/repos/takipi/takipi-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takipi/takipi-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takipi/takipi-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/takipi/takipi-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takipi/takipi-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/takipi/takipi-storage/languages","stargazers_url":"https://api.github.com/repos/takipi/takipi-storage/stargazers","contributors_url":"https://api.github.com/repos/takipi/takipi-storage/contributors","subscribers_url":"https://api.github.com/repos/takipi/takipi-storage/subscribers","subscription_url":"https://api.github.com/repos/takipi/takipi-storage/subscription","commits_url":"https://api.github.com/repos/takipi/takipi-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/takipi/takipi-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/takipi/takipi-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/takipi/takipi-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/takipi/takipi-storage/contents/{+path}","compare_url":"https://api.github.com/repos/takipi/takipi-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takipi/takipi-storage/merges","archive_url":"https://api.github.com/repos/takipi/takipi-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takipi/takipi-storage/downloads","issues_url":"https://api.github.com/repos/takipi/takipi-storage/issues{/number}","pulls_url":"https://api.github.com/repos/takipi/takipi-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/takipi/takipi-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/takipi/takipi-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takipi/takipi-storage/labels{/name}","releases_url":"https://api.github.com/repos/takipi/takipi-storage/releases{/id}","deployments_url":"https://api.github.com/repos/takipi/takipi-storage/deployments","created_at":"2015-01-12T18:47:27Z","updated_at":"2017-08-01T22:36:13Z","pushed_at":"2017-10-31T11:47:02Z","git_url":"git://github.com/takipi/takipi-storage.git","ssh_url":"git@github.com:takipi/takipi-storage.git","clone_url":"https://github.com/takipi/takipi-storage.git","svn_url":"https://github.com/takipi/takipi-storage","homepage":"https://www.overops.com","size":235,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/takipi/takipi-storage/pulls/28"},"html":{"href":"https://github.com/takipi/takipi-storage/pull/28"},"issue":{"href":"https://api.github.com/repos/takipi/takipi-storage/issues/28"},"comments":{"href":"https://api.github.com/repos/takipi/takipi-storage/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/takipi/takipi-storage/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/takipi/takipi-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/takipi/takipi-storage/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/takipi/takipi-storage/statuses/75920fd9f2efe2a5592468818d0df7487739a5dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidlevanon"}}