{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/16900","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/16900/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16900/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/16900/events","html_url":"https://github.com/nodejs/node/pull/16900","id":272513907,"number":16900,"title":"deps: cherry-pick b8331cc030 from upstream V8","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"labels":[{"id":171787391,"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":176191361,"url":"https://api.github.com/repos/nodejs/node/labels/V8%20Engine","name":"V8 Engine","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-09T10:31:48Z","updated_at":"2017-11-09T10:32:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16900","html_url":"https://github.com/nodejs/node/pull/16900","diff_url":"https://github.com/nodejs/node/pull/16900.diff","patch_url":"https://github.com/nodejs/node/pull/16900.patch"},"body":"Original commit message:\r\n\r\n    I believe the paths to the V8 include headers are incorrect. The\r\n    paths to other sources seem to be relative to the parent directory.\r\n\r\n    When building Node.js I get the following warning on Windows:\r\n    Warning: Missing input files:\r\n    deps\\v8\\src\\..\\..\\include\\v8-inspector-protocol.h\r\n    deps\\v8\\src\\..\\..\\include\\v8-inspector.h\r\n\r\n    This commit updates the two include paths.\r\n\r\n    Bug:\r\n    Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f\r\n    Reviewed-on: https://chromium-review.googlesource.com/743981\r\n    Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>\r\n    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>\r\n    Cr-Commit-Position: refs/heads/master@{#49121}\r\n\r\nThis commit also increments the v8_embedder_string version.\r\n\r\nFixes: https://github.com/nodejs/node/issues/16614\r\nRefs: https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9\r\n\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ndeps\r\n\r\ncc @nodejs/v8 "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/343113755","html_url":"https://github.com/nodejs/node/pull/16900#issuecomment-343113755","issue_url":"https://api.github.com/repos/nodejs/node/issues/16900","id":343113755,"user":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"created_at":"2017-11-09T10:32:21Z","updated_at":"2017-11-09T10:32:21Z","author_association":"MEMBER","body":"CI: https://ci.nodejs.org/job/node-test-pull-request/11321/"}}
{"actor":{"display_login":"danbev"}}