{"action":"created","comment":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/133523816","pull_request_review_id":56715327,"id":133523816,"diff_hunk":"@@ -428,11 +428,12 @@ CCR.xdmod.ReportCheckbox = Ext.extend(Ext.form.Checkbox,  {\n \n       };\n \n+       var action = checked ? '/add' : '/remove';\n       this.fireEvent('toggled_checkbox', checked ? 'add_to_queue' : 'remove_from_queue');\n \n       conn.request({\n \n-         url: 'controllers/chart_pool.php',\n+          url: XDMoD.REST.url + '/charts/pools' + action,","path":"html/gui/js/report_builder/Reporting.js","position":10,"original_position":10,"commit_id":"08d29bfd00c6738e7dbcd2b05c900b2b45b6c4b9","original_commit_id":"08d29bfd00c6738e7dbcd2b05c900b2b45b6c4b9","user":{"login":"plessbd","id":683012,"avatar_url":"https://avatars2.githubusercontent.com/u/683012?v=4","gravatar_id":"","url":"https://api.github.com/users/plessbd","html_url":"https://github.com/plessbd","followers_url":"https://api.github.com/users/plessbd/followers","following_url":"https://api.github.com/users/plessbd/following{/other_user}","gists_url":"https://api.github.com/users/plessbd/gists{/gist_id}","starred_url":"https://api.github.com/users/plessbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plessbd/subscriptions","organizations_url":"https://api.github.com/users/plessbd/orgs","repos_url":"https://api.github.com/users/plessbd/repos","events_url":"https://api.github.com/users/plessbd/events{/privacy}","received_events_url":"https://api.github.com/users/plessbd/received_events","type":"User","site_admin":false},"body":"Then I would say, we should fix up the lines below so that this at least look better (as long as it isn't to much work to placate travis)","created_at":"2017-08-16T18:04:49Z","updated_at":"2017-08-16T18:04:49Z","html_url":"https://github.com/ubccr/xdmod/pull/215#discussion_r133523816","pull_request_url":"https://api.github.com/repos/ubccr/xdmod/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/133523816"},"html":{"href":"https://github.com/ubccr/xdmod/pull/215#discussion_r133523816"},"pull_request":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/215","id":135377444,"html_url":"https://github.com/ubccr/xdmod/pull/215","diff_url":"https://github.com/ubccr/xdmod/pull/215.diff","patch_url":"https://github.com/ubccr/xdmod/pull/215.patch","issue_url":"https://api.github.com/repos/ubccr/xdmod/issues/215","number":215,"state":"open","locked":false,"title":"Migrate ChartPool Controller to new Rest Stack","user":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"body":"## Description\r\nMigrating the 'chart_pool' controller / routes to the new REST Stack. \r\n\r\n## Motivation and Context\r\nBecause we don't want to support two rest stacks. \r\n\r\n## Tests performed\r\nA suite of tests contained in `open_xdmod/modules/xdmod/integration_tests/lib/Controllers/ChartPoolTest.php`\r\nIt provides tests for the following: \r\n  - missing fields when /add is called  by a group of users.\r\n    - fields: chart_id, chart_drill_details, chart_date_desc\r\n    - users: cd, pi, usr\r\n  - missing fields when /remove is called by a group of users\r\n    - fields: chart_id\r\n    - users: cd, pi, usr\r\n  - the same chart cannot be added twice by various users\r\n    - users: cd, pi, usr\r\n  - that a various users should be able to add a chart and then remove it. \r\n  - that the public user cannot add / remove charts\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [X] Code Refactor \r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project as found in the **CONTRIBUTING** document.\r\n- [X] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n","created_at":"2017-08-11T16:57:38Z","updated_at":"2017-08-16T18:04:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a870c990375ca5f41dfb3d13c377456c34b0d93","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/ubccr/xdmod/milestones/5","html_url":"https://github.com/ubccr/xdmod/milestone/5","labels_url":"https://api.github.com/repos/ubccr/xdmod/milestones/5/labels","id":2686438,"number":5,"title":"v7.1.0","description":"","creator":{"login":"smgallo","id":2301909,"avatar_url":"https://avatars1.githubusercontent.com/u/2301909?v=4","gravatar_id":"","url":"https://api.github.com/users/smgallo","html_url":"https://github.com/smgallo","followers_url":"https://api.github.com/users/smgallo/followers","following_url":"https://api.github.com/users/smgallo/following{/other_user}","gists_url":"https://api.github.com/users/smgallo/gists{/gist_id}","starred_url":"https://api.github.com/users/smgallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smgallo/subscriptions","organizations_url":"https://api.github.com/users/smgallo/orgs","repos_url":"https://api.github.com/users/smgallo/repos","events_url":"https://api.github.com/users/smgallo/events{/privacy}","received_events_url":"https://api.github.com/users/smgallo/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":5,"state":"open","created_at":"2017-08-07T19:30:59Z","updated_at":"2017-08-16T13:17:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ubccr/xdmod/pulls/215/commits","review_comments_url":"https://api.github.com/repos/ubccr/xdmod/pulls/215/comments","review_comment_url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubccr/xdmod/issues/215/comments","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/08d29bfd00c6738e7dbcd2b05c900b2b45b6c4b9","head":{"label":"ryanrath:migrate/rest/chartpool","ref":"migrate/rest/chartpool","sha":"08d29bfd00c6738e7dbcd2b05c900b2b45b6c4b9","user":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"repo":{"id":77923709,"name":"xdmod","full_name":"ryanrath/xdmod","owner":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanrath/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":true,"url":"https://api.github.com/repos/ryanrath/xdmod","forks_url":"https://api.github.com/repos/ryanrath/xdmod/forks","keys_url":"https://api.github.com/repos/ryanrath/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanrath/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanrath/xdmod/teams","hooks_url":"https://api.github.com/repos/ryanrath/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ryanrath/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ryanrath/xdmod/events","assignees_url":"https://api.github.com/repos/ryanrath/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ryanrath/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ryanrath/xdmod/tags","blobs_url":"https://api.github.com/repos/ryanrath/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanrath/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanrath/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanrath/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanrath/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanrath/xdmod/languages","stargazers_url":"https://api.github.com/repos/ryanrath/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ryanrath/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ryanrath/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ryanrath/xdmod/subscription","commits_url":"https://api.github.com/repos/ryanrath/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanrath/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanrath/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanrath/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanrath/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ryanrath/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanrath/xdmod/merges","archive_url":"https://api.github.com/repos/ryanrath/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanrath/xdmod/downloads","issues_url":"https://api.github.com/repos/ryanrath/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ryanrath/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanrath/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanrath/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanrath/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ryanrath/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ryanrath/xdmod/deployments","created_at":"2017-01-03T14:23:30Z","updated_at":"2017-01-03T14:23:34Z","pushed_at":"2017-08-16T17:50:13Z","git_url":"git://github.com/ryanrath/xdmod.git","ssh_url":"git@github.com:ryanrath/xdmod.git","clone_url":"https://github.com/ryanrath/xdmod.git","svn_url":"https://github.com/ryanrath/xdmod","homepage":"http://open.xdmod.org","size":5693,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"xdmod6.5"}},"base":{"label":"ubccr:xdmod7.1","ref":"xdmod7.1","sha":"3f5a98c411d061967bb5c7daac0a1c5dc3e79807","user":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"repo":{"id":72233032,"name":"xdmod","full_name":"ubccr/xdmod","owner":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubccr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":false,"url":"https://api.github.com/repos/ubccr/xdmod","forks_url":"https://api.github.com/repos/ubccr/xdmod/forks","keys_url":"https://api.github.com/repos/ubccr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubccr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubccr/xdmod/teams","hooks_url":"https://api.github.com/repos/ubccr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ubccr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ubccr/xdmod/events","assignees_url":"https://api.github.com/repos/ubccr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ubccr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ubccr/xdmod/tags","blobs_url":"https://api.github.com/repos/ubccr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubccr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubccr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubccr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ubccr/xdmod/languages","stargazers_url":"https://api.github.com/repos/ubccr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ubccr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ubccr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ubccr/xdmod/subscription","commits_url":"https://api.github.com/repos/ubccr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubccr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubccr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubccr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubccr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ubccr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubccr/xdmod/merges","archive_url":"https://api.github.com/repos/ubccr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubccr/xdmod/downloads","issues_url":"https://api.github.com/repos/ubccr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ubccr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ubccr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ubccr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubccr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ubccr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ubccr/xdmod/deployments","created_at":"2016-10-28T18:41:25Z","updated_at":"2017-06-14T09:54:52Z","pushed_at":"2017-08-16T17:50:15Z","git_url":"git://github.com/ubccr/xdmod.git","ssh_url":"git@github.com:ubccr/xdmod.git","clone_url":"https://github.com/ubccr/xdmod.git","svn_url":"https://github.com/ubccr/xdmod","homepage":"http://open.xdmod.org","size":5227,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":12,"forks":19,"open_issues":12,"watchers":17,"default_branch":"xdmod7.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/215"},"html":{"href":"https://github.com/ubccr/xdmod/pull/215"},"issue":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/215"},"comments":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/ubccr/xdmod/statuses/08d29bfd00c6738e7dbcd2b05c900b2b45b6c4b9"}}}}
{"actor":{"display_login":"plessbd"}}