{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/113009047","pull_request_review_id":34366147,"id":113009047,"diff_hunk":"@@ -7183,5 +7183,714 @@ static void F()\n                     generation0,\n                     ImmutableArray.Create(new SemanticEdit(SemanticEditKind.Update, f0, f1, GetSyntaxMapFromMarkers(source0, source1), preserveLocalVariables: true))));\n         }\n+\n+        [Fact]\n+        public void OutVar()\n+        {\n+            var source0 = MarkedSource(@\"\n+class C\n+{\n+    static void F(out int x, out int y) { x = 1; y = 2; }\n+    static int G() { F(out int x, out var y); return x + y; }\n+}\");\n+            var source1 = MarkedSource(@\"\n+class C\n+{\n+    static void F(out int x, out int y) { x = 1; y = 2; }\n+    static int G() { F(out int x, out var z); return x + z; }\n+}\");\n+\n+            var source2 = MarkedSource(@\"\n+class C\n+{\n+    static void F(out int x, out int y) { x = 1; y = 2; }\n+    static int G() { F(out int x, out int y); return x + y; }\n+}\");\n+\n+            var compilation0 = CreateStandardCompilation(source0.Tree, options: ComSafeDebugDll);\n+            var compilation1 = compilation0.WithSource(source1.Tree);\n+            var compilation2 = compilation1.WithSource(source2.Tree);\n+\n+            var f0 = compilation0.GetMember<MethodSymbol>(\"C.G\");\n+            var f1 = compilation1.GetMember<MethodSymbol>(\"C.G\");\n+            var f2 = compilation1.GetMember<MethodSymbol>(\"C.G\");\n+\n+            var v0 = CompileAndVerify(compilation0);\n+            var md0 = ModuleMetadata.CreateFromImage(v0.EmittedAssemblyData);\n+\n+            var generation0 = EmitBaseline.CreateInitialBaseline(md0, v0.CreateSymReader().GetEncMethodDebugInfo);\n+            var diff1 = compilation1.EmitDifference(\n+                generation0,\n+                ImmutableArray.Create(\n+                    new SemanticEdit(SemanticEditKind.Update, f0, f1, preserveLocalVariables: true)));\n+\n+            diff1.VerifyIL(\"C.G\", @\"\n+{\n+  // Code size       19 (0x13)\n+  .maxstack  2\n+  .locals init (int V_0, //x\n+                int V_1, //z\n+                int V_2)\n+  IL_0000:  nop\n+  IL_0001:  ldloca.s   V_0\n+  IL_0003:  ldloca.s   V_1\n+  IL_0005:  call       \"\"void C.F(out int, out int)\"\"\n+  IL_000a:  nop\n+  IL_000b:  ldloc.0\n+  IL_000c:  ldloc.1\n+  IL_000d:  add\n+  IL_000e:  stloc.2\n+  IL_000f:  br.s       IL_0011\n+  IL_0011:  ldloc.2\n+  IL_0012:  ret\n+}\n+\");\n+            var v1 = CompileAndVerify(compilation1);\n+            var md1 = ModuleMetadata.CreateFromImage(v1.EmittedAssemblyData);\n+\n+            var generation1 = EmitBaseline.CreateInitialBaseline(md1, v1.CreateSymReader().GetEncMethodDebugInfo);\n+            var diff2 = compilation1.EmitDifference(\n+                generation0,\n+                ImmutableArray.Create(\n+                    new SemanticEdit(SemanticEditKind.Update, f1, f2, preserveLocalVariables: true)));\n+\n+            diff1.VerifyIL(\"C.G\", @\"\n+{\n+  // Code size       19 (0x13)\n+  .maxstack  2\n+  .locals init (int V_0, //x\n+                int V_1, //z\n+                int V_2)\n+  IL_0000:  nop\n+  IL_0001:  ldloca.s   V_0\n+  IL_0003:  ldloca.s   V_1\n+  IL_0005:  call       \"\"void C.F(out int, out int)\"\"\n+  IL_000a:  nop\n+  IL_000b:  ldloc.0\n+  IL_000c:  ldloc.1\n+  IL_000d:  add\n+  IL_000e:  stloc.2\n+  IL_000f:  br.s       IL_0011\n+  IL_0011:  ldloc.2\n+  IL_0012:  ret\n+}\n+\");\n+        }\n+\n+        [Fact]\n+        public void PatternVariable_TypeChange()\n+        {\n+            var source0 = MarkedSource(@\"\n+class C\n+{\n+    static int F(object o) { if (o is int i) { return i; } return 0; }\n+}\");\n+            var source1 = MarkedSource(@\"\n+class C\n+{\n+    static int F(object o) { if (o is bool i) { return i ? 1 : 0; } return 0; }\n+}\");\n+\n+            var source2 = MarkedSource(@\"\n+class C\n+{\n+    static int F(object o) { if (o is int j) { return j; } return 0; }\n+}\");\n+\n+            var compilation0 = CreateStandardCompilation(source0.Tree, options: ComSafeDebugDll);\n+            var compilation1 = compilation0.WithSource(source1.Tree);\n+            var compilation2 = compilation1.WithSource(source2.Tree);\n+\n+            var f0 = compilation0.GetMember<MethodSymbol>(\"C.F\");\n+            var f1 = compilation1.GetMember<MethodSymbol>(\"C.F\");\n+            var f2 = compilation1.GetMember<MethodSymbol>(\"C.F\");\n+\n+            var v0 = CompileAndVerify(compilation0);","path":"src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs","position":126,"original_position":126,"commit_id":"a09ce3025aff1716ae65dc05793938a2e24b9dc7","original_commit_id":"a09ce3025aff1716ae65dc05793938a2e24b9dc7","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars3.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":">v0 [](start = 16, length = 2)\r\n\r\nAdd v0.VerifyIL(\"C.F\", ...) to see what the baseline IL is.","created_at":"2017-04-24T17:36:29Z","updated_at":"2017-04-24T17:36:29Z","html_url":"https://github.com/dotnet/roslyn/pull/18893#discussion_r113009047","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18893","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/113009047"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18893#discussion_r113009047"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18893"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/18893","id":117078025,"html_url":"https://github.com/dotnet/roslyn/pull/18893","diff_url":"https://github.com/dotnet/roslyn/pull/18893.diff","patch_url":"https://github.com/dotnet/roslyn/pull/18893.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/18893","number":18893,"state":"open","locked":false,"title":"Enc tests","user":{"login":"ivanbasov","id":5455484,"avatar_url":"https://avatars1.githubusercontent.com/u/5455484?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"body":"Work is in progress. Tests are designed: ready for review. Need to verify that tests asserts are valid.\r\n\r\n**Customer scenario**\r\n\r\nThese are new unit tests to support C# 7.0 features in ENC.\r\n\r\n**Bugs this fixes:**\r\n\r\ntowards to #17896, #12435 and #12436\r\n\r\n**Workarounds, if any**\r\n\r\n\r\n**Risk**\r\n\r\nLow\r\n\r\n**Performance impact**\r\n\r\nNone\r\n\r\n**Is this a regression from a previous update?**\r\n\r\n**Root cause analysis:**\r\n\r\n**How was the bug found?**\r\n\r\nPlanned\r\n","created_at":"2017-04-21T22:25:43Z","updated_at":"2017-04-24T17:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d259fb54a9f4301ac3d3f88e6c4e06f8286c0d4f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18893/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18893/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/18893/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/a09ce3025aff1716ae65dc05793938a2e24b9dc7","head":{"label":"ivanbasov:EncTests","ref":"EncTests","sha":"a09ce3025aff1716ae65dc05793938a2e24b9dc7","user":{"login":"ivanbasov","id":5455484,"avatar_url":"https://avatars1.githubusercontent.com/u/5455484?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"repo":{"id":85608790,"name":"roslyn","full_name":"ivanbasov/roslyn","owner":{"login":"ivanbasov","id":5455484,"avatar_url":"https://avatars1.githubusercontent.com/u/5455484?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivanbasov/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/ivanbasov/roslyn","forks_url":"https://api.github.com/repos/ivanbasov/roslyn/forks","keys_url":"https://api.github.com/repos/ivanbasov/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanbasov/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanbasov/roslyn/teams","hooks_url":"https://api.github.com/repos/ivanbasov/roslyn/hooks","issue_events_url":"https://api.github.com/repos/ivanbasov/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/ivanbasov/roslyn/events","assignees_url":"https://api.github.com/repos/ivanbasov/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/ivanbasov/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/ivanbasov/roslyn/tags","blobs_url":"https://api.github.com/repos/ivanbasov/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanbasov/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanbasov/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanbasov/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanbasov/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanbasov/roslyn/languages","stargazers_url":"https://api.github.com/repos/ivanbasov/roslyn/stargazers","contributors_url":"https://api.github.com/repos/ivanbasov/roslyn/contributors","subscribers_url":"https://api.github.com/repos/ivanbasov/roslyn/subscribers","subscription_url":"https://api.github.com/repos/ivanbasov/roslyn/subscription","commits_url":"https://api.github.com/repos/ivanbasov/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanbasov/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanbasov/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanbasov/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanbasov/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/ivanbasov/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanbasov/roslyn/merges","archive_url":"https://api.github.com/repos/ivanbasov/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanbasov/roslyn/downloads","issues_url":"https://api.github.com/repos/ivanbasov/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/ivanbasov/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanbasov/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanbasov/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanbasov/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/ivanbasov/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/ivanbasov/roslyn/deployments","created_at":"2017-03-20T17:55:57Z","updated_at":"2017-03-20T17:56:36Z","pushed_at":"2017-04-21T22:21:19Z","git_url":"git://github.com/ivanbasov/roslyn.git","ssh_url":"git@github.com:ivanbasov/roslyn.git","clone_url":"https://github.com/ivanbasov/roslyn.git","svn_url":"https://github.com/ivanbasov/roslyn","homepage":"","size":203862,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ee32351dd2aa588ac7e60a9fdc99ffa894d51f5b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-04-24T15:46:42Z","pushed_at":"2017-04-24T17:25:39Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":206158,"stargazers_count":7408,"watchers_count":7408,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1797,"mirror_url":null,"open_issues_count":3556,"forks":1797,"open_issues":3556,"watchers":7408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18893"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18893"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18893"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18893/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18893/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18893/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/a09ce3025aff1716ae65dc05793938a2e24b9dc7"}}}}
{"actor":{"display_login":"tmat"}}