{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/482","repository_url":"https://api.github.com/repos/vaadin/vaadin-combo-box","labels_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/482/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/482/events","html_url":"https://github.com/vaadin/vaadin-combo-box/pull/482","id":242210938,"number":482,"title":"replace `vaadin.` with `window.vaadin.`","user":{"login":"nkrishnaswami","id":5997156,"avatar_url":"https://avatars1.githubusercontent.com/u/5997156?v=3","gravatar_id":"","url":"https://api.github.com/users/nkrishnaswami","html_url":"https://github.com/nkrishnaswami","followers_url":"https://api.github.com/users/nkrishnaswami/followers","following_url":"https://api.github.com/users/nkrishnaswami/following{/other_user}","gists_url":"https://api.github.com/users/nkrishnaswami/gists{/gist_id}","starred_url":"https://api.github.com/users/nkrishnaswami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkrishnaswami/subscriptions","organizations_url":"https://api.github.com/users/nkrishnaswami/orgs","repos_url":"https://api.github.com/users/nkrishnaswami/repos","events_url":"https://api.github.com/users/nkrishnaswami/events{/privacy}","received_events_url":"https://api.github.com/users/nkrishnaswami/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-11T23:12:20Z","updated_at":"2017-07-12T06:34:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/482","html_url":"https://github.com/vaadin/vaadin-combo-box/pull/482","diff_url":"https://github.com/vaadin/vaadin-combo-box/pull/482.diff","patch_url":"https://github.com/vaadin/vaadin-combo-box/pull/482.patch"},"body":"Using both `window.vaadin` and `vaadin` to refer to the same namespace breaks compiling in closure. This has been encountered and worked around/fixed in `vaadin-grid` by using a consistent name (`window.vaadin`) in https://github.com/vaadin/vaadin-grid/pull/872/\r\n\r\nThis patch applies the analogous change to `vaadin-combo-box`.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-combo-box/482)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/comments/314668251","html_url":"https://github.com/vaadin/vaadin-combo-box/pull/482#issuecomment-314668251","issue_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/482","id":314668251,"user":{"login":"tomivirkki","id":1222264,"avatar_url":"https://avatars2.githubusercontent.com/u/1222264?v=3","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"created_at":"2017-07-12T06:34:30Z","updated_at":"2017-07-12T06:34:30Z","body":"Related issue: https://github.com/vaadin/vaadin-grid/pull/886\r\n\r\nLooks like replacing `vaadin.` with `window.vaadin.` alone didn't fix the issue in vaadin-grid after all."}}
{"actor":{"display_login":"tomivirkki"}}