{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/136152420","pull_request_review_id":59651345,"id":136152420,"diff_hunk":"@@ -0,0 +1,126 @@\n+/** @file\n+\n+  Configuration of Forwarded HTTP header option.\n+\n+  @section license License\n+\n+  Licensed to the Apache Software Foundation (ASF) under one\n+  or more contributor license agreements.  See the NOTICE file\n+  distributed with this work for additional information\n+  regarding copyright ownership.  The ASF licenses this file\n+  to you under the Apache License, Version 2.0 (the\n+  \"License\"); you may not use this file except in compliance\n+  with the License.  You may obtain a copy of the License at\n+\n+      http://www.apache.org/licenses/LICENSE-2.0\n+\n+  Unless required by applicable law or agreed to in writing, software\n+  distributed under the License is distributed on an \"AS IS\" BASIS,\n+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+  See the License for the specific language governing permissions and\n+  limitations under the License.\n+ */\n+\n+#include <bitset>\n+#include <string>\n+#include <cctype>\n+\n+#include <ts/string_view.h>\n+#include <ts/MemView.h>\n+\n+#include <HttpConfig.h>\n+\n+namespace HttpForwarded\n+{\n+OptionBitSet\n+optStrToBitset(ts::string_view optConfigStr, std::string &error)","path":"proxy/http/ForwardedConfig.cc","position":36,"original_position":36,"commit_id":"601c98ac5b709608048d0e05d366b20226d86efb","original_commit_id":"601c98ac5b709608048d0e05d366b20226d86efb","user":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"body":"Reasons to use std::string here:\r\n\r\n- std::string is optimized to not dynamically allocate memory for smaller strings.\r\n- If ops people say they need clearer error messages here that require dynamic generation, the change is localized to one function.\r\n- It's advantageous as defensive programming to limit the use of raw pointers.\r\n\r\nI'd like to hear the thinking of @SolidWallOfCode and @bryancall on this.","created_at":"2017-08-30T18:27:31Z","updated_at":"2017-08-30T18:27:32Z","html_url":"https://github.com/apache/trafficserver/pull/2446#discussion_r136152420","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/2446","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/136152420"},"html":{"href":"https://github.com/apache/trafficserver/pull/2446#discussion_r136152420"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2446"}},"in_reply_to_id":136116078},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/2446","id":138285166,"html_url":"https://github.com/apache/trafficserver/pull/2446","diff_url":"https://github.com/apache/trafficserver/pull/2446.diff","patch_url":"https://github.com/apache/trafficserver/pull/2446.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/2446","number":2446,"state":"open","locked":false,"title":"Add support for Forwarded HTTP header tag (RFC7239).","user":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"body":"Submitted for issue https://github.com/apache/trafficserver/issues/1071 .","created_at":"2017-08-29T21:11:56Z","updated_at":"2017-08-30T18:27:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fee396f1034662230963d744f6c758de645fa3ef","assignee":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars2.githubusercontent.com/u/1545753?v=4","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"assignees":[{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars2.githubusercontent.com/u/1545753?v=4","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/6","html_url":"https://github.com/apache/trafficserver/milestone/6","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/6/labels","id":1763406,"number":6,"title":"8.0.0","description":"","creator":{"login":"zwoop","id":202131,"avatar_url":"https://avatars1.githubusercontent.com/u/202131?v=4","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":506,"state":"open","created_at":"2016-05-12T22:13:34Z","updated_at":"2017-08-30T16:57:15Z","due_on":"2017-10-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/2446/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/2446/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/2446/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/601c98ac5b709608048d0e05d366b20226d86efb","head":{"label":"ywkaras:Forwarded","ref":"Forwarded","sha":"601c98ac5b709608048d0e05d366b20226d86efb","user":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"repo":{"id":93207586,"name":"trafficserver","full_name":"ywkaras/trafficserver","owner":{"login":"ywkaras","id":29132227,"avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ywkaras/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/ywkaras/trafficserver","forks_url":"https://api.github.com/repos/ywkaras/trafficserver/forks","keys_url":"https://api.github.com/repos/ywkaras/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywkaras/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywkaras/trafficserver/teams","hooks_url":"https://api.github.com/repos/ywkaras/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/ywkaras/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/ywkaras/trafficserver/events","assignees_url":"https://api.github.com/repos/ywkaras/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/ywkaras/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/ywkaras/trafficserver/tags","blobs_url":"https://api.github.com/repos/ywkaras/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywkaras/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywkaras/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywkaras/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywkaras/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/ywkaras/trafficserver/languages","stargazers_url":"https://api.github.com/repos/ywkaras/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/ywkaras/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/ywkaras/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/ywkaras/trafficserver/subscription","commits_url":"https://api.github.com/repos/ywkaras/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywkaras/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywkaras/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywkaras/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywkaras/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/ywkaras/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywkaras/trafficserver/merges","archive_url":"https://api.github.com/repos/ywkaras/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywkaras/trafficserver/downloads","issues_url":"https://api.github.com/repos/ywkaras/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/ywkaras/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/ywkaras/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/ywkaras/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywkaras/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/ywkaras/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/ywkaras/trafficserver/deployments","created_at":"2017-06-02T22:13:24Z","updated_at":"2017-06-02T22:13:33Z","pushed_at":"2017-08-29T20:31:52Z","git_url":"git://github.com/ywkaras/trafficserver.git","ssh_url":"git@github.com:ywkaras/trafficserver.git","clone_url":"https://github.com/ywkaras/trafficserver.git","svn_url":"https://github.com/ywkaras/trafficserver","homepage":null,"size":71093,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7dc2033487a846d2eff431d58ad80cfc4479c452","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2017-08-30T16:16:00Z","pushed_at":"2017-08-30T18:18:49Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":72653,"stargazers_count":586,"watchers_count":586,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"open_issues_count":174,"forks":450,"open_issues":174,"watchers":586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2446"},"html":{"href":"https://github.com/apache/trafficserver/pull/2446"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/2446"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/2446/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2446/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/2446/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/601c98ac5b709608048d0e05d366b20226d86efb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ywkaras"}}