{"action":"closed","number":4195,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/4195","id":135216758,"html_url":"https://github.com/Azure/azure-cli/pull/4195","diff_url":"https://github.com/Azure/azure-cli/pull/4195.diff","patch_url":"https://github.com/Azure/azure-cli/pull/4195.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/4195","number":4195,"state":"closed","locked":false,"title":"[ACR] Add support to pipe docker password using --password-stdin option","user":{"login":"djyou","id":3630974,"avatar_url":"https://avatars3.githubusercontent.com/u/3630974?v=4","gravatar_id":"","url":"https://api.github.com/users/djyou","html_url":"https://github.com/djyou","followers_url":"https://api.github.com/users/djyou/followers","following_url":"https://api.github.com/users/djyou/following{/other_user}","gists_url":"https://api.github.com/users/djyou/gists{/gist_id}","starred_url":"https://api.github.com/users/djyou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djyou/subscriptions","organizations_url":"https://api.github.com/users/djyou/orgs","repos_url":"https://api.github.com/users/djyou/repos","events_url":"https://api.github.com/users/djyou/events{/privacy}","received_events_url":"https://api.github.com/users/djyou/received_events","type":"User","site_admin":false},"body":"Newer versions of `docker` added a new `--password-stdin` option for docker login to take the password from stdin, so that the OS won't log the password, but now it also complains when `--password` option is used.\r\n```\r\naz acr login -n MyRegistry\r\nWARNING! Using --password via the CLI is insecure. Use --password-stdin.\r\n```\r\nThis change is to use `--password-stdin` option if possible.\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n### General Guidelines\r\n\r\n- [x] The PR has modified HISTORY.rst with an appropriate description of the change (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).\r\n\r\n### Command Guidelines\r\n\r\n- [x] Each command and parameter has a meaningful description.\r\n- [x] Each new command has a test.\r\n\r\n(see [Authoring Command Modules](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules))\r\n","created_at":"2017-08-10T20:35:35Z","updated_at":"2017-09-25T23:22:01Z","closed_at":"2017-09-25T23:22:01Z","merged_at":null,"merge_commit_sha":"e47822a3ef4c6c518638f5f167a0c8e85ae9a31e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/4195/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/4195/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/4195/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/8ecd3c892d268d98b7e5a556175636ddb1777d09","head":{"label":"AppPlatPerf:doyou/warning","ref":"doyou/warning","sha":"8ecd3c892d268d98b7e5a556175636ddb1777d09","user":{"login":"AppPlatPerf","id":8304256,"avatar_url":"https://avatars1.githubusercontent.com/u/8304256?v=4","gravatar_id":"","url":"https://api.github.com/users/AppPlatPerf","html_url":"https://github.com/AppPlatPerf","followers_url":"https://api.github.com/users/AppPlatPerf/followers","following_url":"https://api.github.com/users/AppPlatPerf/following{/other_user}","gists_url":"https://api.github.com/users/AppPlatPerf/gists{/gist_id}","starred_url":"https://api.github.com/users/AppPlatPerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppPlatPerf/subscriptions","organizations_url":"https://api.github.com/users/AppPlatPerf/orgs","repos_url":"https://api.github.com/users/AppPlatPerf/repos","events_url":"https://api.github.com/users/AppPlatPerf/events{/privacy}","received_events_url":"https://api.github.com/users/AppPlatPerf/received_events","type":"Organization","site_admin":false},"repo":{"id":65927884,"name":"azure-cli","full_name":"AppPlatPerf/azure-cli","owner":{"login":"AppPlatPerf","id":8304256,"avatar_url":"https://avatars1.githubusercontent.com/u/8304256?v=4","gravatar_id":"","url":"https://api.github.com/users/AppPlatPerf","html_url":"https://github.com/AppPlatPerf","followers_url":"https://api.github.com/users/AppPlatPerf/followers","following_url":"https://api.github.com/users/AppPlatPerf/following{/other_user}","gists_url":"https://api.github.com/users/AppPlatPerf/gists{/gist_id}","starred_url":"https://api.github.com/users/AppPlatPerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppPlatPerf/subscriptions","organizations_url":"https://api.github.com/users/AppPlatPerf/orgs","repos_url":"https://api.github.com/users/AppPlatPerf/repos","events_url":"https://api.github.com/users/AppPlatPerf/events{/privacy}","received_events_url":"https://api.github.com/users/AppPlatPerf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppPlatPerf/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/AppPlatPerf/azure-cli","forks_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/forks","keys_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/teams","hooks_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/events","assignees_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/tags","blobs_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/languages","stargazers_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/subscription","commits_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/merges","archive_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/downloads","issues_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/AppPlatPerf/azure-cli/deployments","created_at":"2016-08-17T17:24:59Z","updated_at":"2016-10-24T16:36:58Z","pushed_at":"2017-09-25T21:26:53Z","git_url":"git://github.com/AppPlatPerf/azure-cli.git","ssh_url":"git@github.com:AppPlatPerf/azure-cli.git","clone_url":"https://github.com/AppPlatPerf/azure-cli.git","svn_url":"https://github.com/AppPlatPerf/azure-cli","homepage":null,"size":27502,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"d5612493fd2fc58a6b93e8c510a1a2157445fed1","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2017-09-24T12:52:30Z","pushed_at":"2017-09-25T23:14:54Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":27636,"stargazers_count":515,"watchers_count":515,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":584,"forks":282,"open_issues":584,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/4195"},"html":{"href":"https://github.com/Azure/azure-cli/pull/4195"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/4195"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/4195/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/4195/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/4195/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/8ecd3c892d268d98b7e5a556175636ddb1777d09"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":13,"maintainer_can_modify":false,"commits":2,"additions":58,"deletions":23,"changed_files":1}}
{"actor":{"display_login":"djyou"}}