{"action":"opened","number":68,"pull_request":{"url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/68","id":154657511,"html_url":"https://github.com/fxmontigny/ng2-ace-editor/pull/68","diff_url":"https://github.com/fxmontigny/ng2-ace-editor/pull/68.diff","patch_url":"https://github.com/fxmontigny/ng2-ace-editor/pull/68.patch","issue_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/issues/68","number":68,"state":"open","locked":false,"title":"Add typescript and angular plugins to rollup config. Rebuild dist.","user":{"login":"bmcbarron","id":1638768,"avatar_url":"https://avatars2.githubusercontent.com/u/1638768?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcbarron","html_url":"https://github.com/bmcbarron","followers_url":"https://api.github.com/users/bmcbarron/followers","following_url":"https://api.github.com/users/bmcbarron/following{/other_user}","gists_url":"https://api.github.com/users/bmcbarron/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcbarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcbarron/subscriptions","organizations_url":"https://api.github.com/users/bmcbarron/orgs","repos_url":"https://api.github.com/users/bmcbarron/repos","events_url":"https://api.github.com/users/bmcbarron/events{/privacy}","received_events_url":"https://api.github.com/users/bmcbarron/received_events","type":"User","site_admin":false},"body":"This fixes issue #67 for me. (Also #65, if I'm correctly inferring that they are the same issue)\r\n\r\nThe interesting changes are in the root directory. Everything in dist/ is a result of running \"npm run build\". Not that I limited the Typescript dependency to ~2.4, since @angular/cli does not currently support 2.5+.\r\n\r\nFor anyone who wants to try this in the meantime, know that you can't take a dependency on a git subdirectory in your package.json. Instead, you'll need to clone in a sibling directory, and then add a dependency like \"file:../ng2-ace-editor/dist\". It's hacky, but should get you working until this is fixed.\r\n\r\nUsing that technique, I can successfully run with \"ng serve --aot --preserve-symlinks\".\r\n\r\nCheers, Bri","created_at":"2017-11-25T23:48:11Z","updated_at":"2017-11-25T23:48:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/68/commits","review_comments_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/68/comments","review_comment_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/issues/68/comments","statuses_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/statuses/6565b15059e83ce26b1f05e509c1965d613c14c7","head":{"label":"bmcbarron:rollup-plugins","ref":"rollup-plugins","sha":"6565b15059e83ce26b1f05e509c1965d613c14c7","user":{"login":"bmcbarron","id":1638768,"avatar_url":"https://avatars2.githubusercontent.com/u/1638768?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcbarron","html_url":"https://github.com/bmcbarron","followers_url":"https://api.github.com/users/bmcbarron/followers","following_url":"https://api.github.com/users/bmcbarron/following{/other_user}","gists_url":"https://api.github.com/users/bmcbarron/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcbarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcbarron/subscriptions","organizations_url":"https://api.github.com/users/bmcbarron/orgs","repos_url":"https://api.github.com/users/bmcbarron/repos","events_url":"https://api.github.com/users/bmcbarron/events{/privacy}","received_events_url":"https://api.github.com/users/bmcbarron/received_events","type":"User","site_admin":false},"repo":{"id":112040291,"name":"ng2-ace-editor","full_name":"bmcbarron/ng2-ace-editor","owner":{"login":"bmcbarron","id":1638768,"avatar_url":"https://avatars2.githubusercontent.com/u/1638768?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcbarron","html_url":"https://github.com/bmcbarron","followers_url":"https://api.github.com/users/bmcbarron/followers","following_url":"https://api.github.com/users/bmcbarron/following{/other_user}","gists_url":"https://api.github.com/users/bmcbarron/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcbarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcbarron/subscriptions","organizations_url":"https://api.github.com/users/bmcbarron/orgs","repos_url":"https://api.github.com/users/bmcbarron/repos","events_url":"https://api.github.com/users/bmcbarron/events{/privacy}","received_events_url":"https://api.github.com/users/bmcbarron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmcbarron/ng2-ace-editor","description":"Ace editor integration with typescript for angular 2","fork":true,"url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor","forks_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/forks","keys_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/teams","hooks_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/hooks","issue_events_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/issues/events{/number}","events_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/events","assignees_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/assignees{/user}","branches_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/branches{/branch}","tags_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/tags","blobs_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/languages","stargazers_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/stargazers","contributors_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/contributors","subscribers_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/subscribers","subscription_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/subscription","commits_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/contents/{+path}","compare_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/merges","archive_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/downloads","issues_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/issues{/number}","pulls_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/labels{/name}","releases_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/releases{/id}","deployments_url":"https://api.github.com/repos/bmcbarron/ng2-ace-editor/deployments","created_at":"2017-11-25T23:00:28Z","updated_at":"2017-11-25T23:00:30Z","pushed_at":"2017-11-25T23:14:25Z","git_url":"git://github.com/bmcbarron/ng2-ace-editor.git","ssh_url":"git@github.com:bmcbarron/ng2-ace-editor.git","clone_url":"https://github.com/bmcbarron/ng2-ace-editor.git","svn_url":"https://github.com/bmcbarron/ng2-ace-editor","homepage":"","size":313,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fxmontigny:master","ref":"master","sha":"a1cef26ed7df40090e803198edacec29114dfb00","user":{"login":"fxmontigny","id":6552764,"avatar_url":"https://avatars1.githubusercontent.com/u/6552764?v=4","gravatar_id":"","url":"https://api.github.com/users/fxmontigny","html_url":"https://github.com/fxmontigny","followers_url":"https://api.github.com/users/fxmontigny/followers","following_url":"https://api.github.com/users/fxmontigny/following{/other_user}","gists_url":"https://api.github.com/users/fxmontigny/gists{/gist_id}","starred_url":"https://api.github.com/users/fxmontigny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxmontigny/subscriptions","organizations_url":"https://api.github.com/users/fxmontigny/orgs","repos_url":"https://api.github.com/users/fxmontigny/repos","events_url":"https://api.github.com/users/fxmontigny/events{/privacy}","received_events_url":"https://api.github.com/users/fxmontigny/received_events","type":"User","site_admin":false},"repo":{"id":65021595,"name":"ng2-ace-editor","full_name":"fxmontigny/ng2-ace-editor","owner":{"login":"fxmontigny","id":6552764,"avatar_url":"https://avatars1.githubusercontent.com/u/6552764?v=4","gravatar_id":"","url":"https://api.github.com/users/fxmontigny","html_url":"https://github.com/fxmontigny","followers_url":"https://api.github.com/users/fxmontigny/followers","following_url":"https://api.github.com/users/fxmontigny/following{/other_user}","gists_url":"https://api.github.com/users/fxmontigny/gists{/gist_id}","starred_url":"https://api.github.com/users/fxmontigny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxmontigny/subscriptions","organizations_url":"https://api.github.com/users/fxmontigny/orgs","repos_url":"https://api.github.com/users/fxmontigny/repos","events_url":"https://api.github.com/users/fxmontigny/events{/privacy}","received_events_url":"https://api.github.com/users/fxmontigny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fxmontigny/ng2-ace-editor","description":"Ace editor integration with typescript for angular 2","fork":true,"url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor","forks_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/forks","keys_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/teams","hooks_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/hooks","issue_events_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/issues/events{/number}","events_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/events","assignees_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/assignees{/user}","branches_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/branches{/branch}","tags_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/tags","blobs_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/languages","stargazers_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/stargazers","contributors_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/contributors","subscribers_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/subscribers","subscription_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/subscription","commits_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/contents/{+path}","compare_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/merges","archive_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/downloads","issues_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/issues{/number}","pulls_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/labels{/name}","releases_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/releases{/id}","deployments_url":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/deployments","created_at":"2016-08-05T13:42:54Z","updated_at":"2017-11-21T15:55:14Z","pushed_at":"2017-11-24T15:04:01Z","git_url":"git://github.com/fxmontigny/ng2-ace-editor.git","ssh_url":"git@github.com:fxmontigny/ng2-ace-editor.git","clone_url":"https://github.com/fxmontigny/ng2-ace-editor.git","svn_url":"https://github.com/fxmontigny/ng2-ace-editor","homepage":"","size":313,"stargazers_count":82,"watchers_count":82,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":17,"forks":35,"open_issues":17,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/68"},"html":{"href":"https://github.com/fxmontigny/ng2-ace-editor/pull/68"},"issue":{"href":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/issues/68"},"comments":{"href":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/fxmontigny/ng2-ace-editor/statuses/6565b15059e83ce26b1f05e509c1965d613c14c7"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":412,"deletions":742,"changed_files":25}}
{"actor":{"display_login":"bmcbarron"}}