{"action":"created","issue":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/6709","repository_url":"https://api.github.com/repos/openlayers/openlayers","labels_url":"https://api.github.com/repos/openlayers/openlayers/issues/6709/labels{/name}","comments_url":"https://api.github.com/repos/openlayers/openlayers/issues/6709/comments","events_url":"https://api.github.com/repos/openlayers/openlayers/issues/6709/events","html_url":"https://github.com/openlayers/openlayers/issues/6709","id":221610566,"number":6709,"title":"'Draw and Modify Features' example got a bug after v3.18.2","user":{"login":"hajjimurad","id":11183111,"avatar_url":"https://avatars0.githubusercontent.com/u/11183111?v=3","gravatar_id":"","url":"https://api.github.com/users/hajjimurad","html_url":"https://github.com/hajjimurad","followers_url":"https://api.github.com/users/hajjimurad/followers","following_url":"https://api.github.com/users/hajjimurad/following{/other_user}","gists_url":"https://api.github.com/users/hajjimurad/gists{/gist_id}","starred_url":"https://api.github.com/users/hajjimurad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hajjimurad/subscriptions","organizations_url":"https://api.github.com/users/hajjimurad/orgs","repos_url":"https://api.github.com/users/hajjimurad/repos","events_url":"https://api.github.com/users/hajjimurad/events{/privacy}","received_events_url":"https://api.github.com/users/hajjimurad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-13T16:10:15Z","updated_at":"2017-04-14T03:44:31Z","closed_at":null,"body":"If you draw LineString in the following Example\r\nhttp://openlayers.org/en/latest/examples/draw-and-modify-features.html?q=Collection,\r\nwhere ending point is very close to the starting point, you'll end up with the following\r\n![image](https://cloud.githubusercontent.com/assets/11183111/25013452/e06b2b3e-2073-11e7-80c4-21ee5c287de4.png)\r\nI.e. drawing doesn't stop, when you release mouse button.\r\n\r\nThe bug appeared in version **v3.19.0**, but in **v3.18.2** the behavior was correct."},"comment":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/comments/294078973","html_url":"https://github.com/openlayers/openlayers/issues/6709#issuecomment-294078973","issue_url":"https://api.github.com/repos/openlayers/openlayers/issues/6709","id":294078973,"user":{"login":"tschaub","id":41094,"avatar_url":"https://avatars3.githubusercontent.com/u/41094?v=3","gravatar_id":"","url":"https://api.github.com/users/tschaub","html_url":"https://github.com/tschaub","followers_url":"https://api.github.com/users/tschaub/followers","following_url":"https://api.github.com/users/tschaub/following{/other_user}","gists_url":"https://api.github.com/users/tschaub/gists{/gist_id}","starred_url":"https://api.github.com/users/tschaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschaub/subscriptions","organizations_url":"https://api.github.com/users/tschaub/orgs","repos_url":"https://api.github.com/users/tschaub/repos","events_url":"https://api.github.com/users/tschaub/events{/privacy}","received_events_url":"https://api.github.com/users/tschaub/received_events","type":"User","site_admin":false},"created_at":"2017-04-14T03:44:31Z","updated_at":"2017-04-14T03:44:31Z","body":"Without bringing in the modify interaction, a difference in behavior can be seen in these two examples:\r\n\r\n * http://openlayers.org/en/v3.18.2/examples/draw-features.html\r\n * http://openlayers.org/en/v3.19.0/examples/draw-features.html\r\n\r\nWhen you draw a line in freehand mode in 3.18.2 drawing did not stop in this sequence: shift, down, drag, up (not near the first point).  I think this could be described as a bug.\r\n\r\nWhen you do the same in 3.19.0, drawing does stop in this sequence: shift, down, drag, up (not near the first point).  This could be described as a bug fix.\r\n\r\nIn 3.18.2, if the up occurs close to the down, drawing finishes.  This could be called an accidental feature.  In 3.19.2, if the up occurs close to the down, drawing *doesn't* finish.  I'd call this a bug.\r\n\r\nSo, there are probably different interpretations of what is correct and what is a bug.  But I think that the least unexpected behavior would be to have drawing finish on up when you are in freehand mode - regardless of whether or not you are close to the first point.\r\n\r\nYou can see that freehand polygon drawing is also inconsistent in 3.19.0.  Drawing finishes on up (expected) *except* if the up is near the down (unexpected)."}}
{"actor":{"display_login":"tschaub"}}