{"action":"created","issue":{"url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes/issues/442","repository_url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes","labels_url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes/issues/442/labels{/name}","comments_url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes/issues/442/comments","events_url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes/issues/442/events","html_url":"https://github.com/humanmade/Custom-Meta-Boxes/pull/442","id":264537539,"number":442,"title":"Remove passing-by-reference of get_values method","user":{"login":"mikeselander","id":3021494,"avatar_url":"https://avatars1.githubusercontent.com/u/3021494?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeselander","html_url":"https://github.com/mikeselander","followers_url":"https://api.github.com/users/mikeselander/followers","following_url":"https://api.github.com/users/mikeselander/following{/other_user}","gists_url":"https://api.github.com/users/mikeselander/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeselander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeselander/subscriptions","organizations_url":"https://api.github.com/users/mikeselander/orgs","repos_url":"https://api.github.com/users/mikeselander/repos","events_url":"https://api.github.com/users/mikeselander/events{/privacy}","received_events_url":"https://api.github.com/users/mikeselander/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-11T10:39:42Z","updated_at":"2017-10-11T16:31:54Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes/pulls/442","html_url":"https://github.com/humanmade/Custom-Meta-Boxes/pull/442","diff_url":"https://github.com/humanmade/Custom-Meta-Boxes/pull/442.diff","patch_url":"https://github.com/humanmade/Custom-Meta-Boxes/pull/442.patch"},"body":"We were passing the get_values method by reference in field classes. I do not understand why and can't find a good reason to keep it this way.\r\n\r\nResolves #420\r\n\r\n*I have:*\r\n - [ ] Run WordPress VIP PHPCS check and code parses without errors\r\n - [ ] Added any new PHPUnit tests\r\n - [ ] Run PHPUnit and all tests are passing after adding any necessary new tests\r\n - [ ] Tested feature/bugfix on single and multisite install\r\n\r\n@mikeselander\r\n"},"comment":{"url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes/issues/comments/335868959","html_url":"https://github.com/humanmade/Custom-Meta-Boxes/pull/442#issuecomment-335868959","issue_url":"https://api.github.com/repos/humanmade/Custom-Meta-Boxes/issues/442","id":335868959,"user":{"login":"mikeselander","id":3021494,"avatar_url":"https://avatars1.githubusercontent.com/u/3021494?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeselander","html_url":"https://github.com/mikeselander","followers_url":"https://api.github.com/users/mikeselander/followers","following_url":"https://api.github.com/users/mikeselander/following{/other_user}","gists_url":"https://api.github.com/users/mikeselander/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeselander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeselander/subscriptions","organizations_url":"https://api.github.com/users/mikeselander/orgs","repos_url":"https://api.github.com/users/mikeselander/repos","events_url":"https://api.github.com/users/mikeselander/events{/privacy}","received_events_url":"https://api.github.com/users/mikeselander/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T16:31:54Z","updated_at":"2017-10-11T16:31:54Z","author_association":"OWNER","body":"@barryceelen you could definitely be right, was messing about this afternoon and I'll need to test this more thoroughly. I'll take a look at what you put!"}}
{"actor":{"display_login":"mikeselander"}}