{"action":"created","issue":{"url":"https://api.github.com/repos/dannyvankooten/browserpass/issues/152","repository_url":"https://api.github.com/repos/dannyvankooten/browserpass","labels_url":"https://api.github.com/repos/dannyvankooten/browserpass/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/dannyvankooten/browserpass/issues/152/comments","events_url":"https://api.github.com/repos/dannyvankooten/browserpass/issues/152/events","html_url":"https://github.com/dannyvankooten/browserpass/pull/152","id":260033477,"number":152,"title":"WIP: keyboar selection in list using arrow keys","user":{"login":"turboMaCk","id":2130305,"avatar_url":"https://avatars0.githubusercontent.com/u/2130305?v=4","gravatar_id":"","url":"https://api.github.com/users/turboMaCk","html_url":"https://github.com/turboMaCk","followers_url":"https://api.github.com/users/turboMaCk/followers","following_url":"https://api.github.com/users/turboMaCk/following{/other_user}","gists_url":"https://api.github.com/users/turboMaCk/gists{/gist_id}","starred_url":"https://api.github.com/users/turboMaCk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turboMaCk/subscriptions","organizations_url":"https://api.github.com/users/turboMaCk/orgs","repos_url":"https://api.github.com/users/turboMaCk/repos","events_url":"https://api.github.com/users/turboMaCk/events{/privacy}","received_events_url":"https://api.github.com/users/turboMaCk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-09-23T19:36:01Z","updated_at":"2017-09-25T09:47:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dannyvankooten/browserpass/pulls/152","html_url":"https://github.com/dannyvankooten/browserpass/pull/152","diff_url":"https://github.com/dannyvankooten/browserpass/pull/152.diff","patch_url":"https://github.com/dannyvankooten/browserpass/pull/152.patch"},"body":"This is still work in progress (missing FF version).\r\n\r\nI've really missed arrow keys selection so I've coded it myself. I'm opening this PR early in case you're interested to review and discuss it. If you're not interested in this feature, feel free to close this PR - I can always use my own version of extension anyway. In case you're interested I'm going to clean code a bit implement the same feature for firefox as well as include changes from code review."},"comment":{"url":"https://api.github.com/repos/dannyvankooten/browserpass/issues/comments/331831747","html_url":"https://github.com/dannyvankooten/browserpass/pull/152#issuecomment-331831747","issue_url":"https://api.github.com/repos/dannyvankooten/browserpass/issues/152","id":331831747,"user":{"login":"maximbaz","id":1177900,"avatar_url":"https://avatars2.githubusercontent.com/u/1177900?v=4","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"created_at":"2017-09-25T09:47:23Z","updated_at":"2017-09-25T09:47:23Z","author_association":"COLLABORATOR","body":"1. Let's not overload `Tab` behavior, what you implemented for arrows is good and intuitive.\r\n2. The chance of people using both `Tab` and arrows is small, but if you have an idea on how to fix arrows while the entire form is focused - let's try it."}}
{"actor":{"display_login":"maximbaz"}}