{"action":"created","issue":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/664","repository_url":"https://api.github.com/repos/alexcrichton/futures-rs","labels_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/664/labels{/name}","comments_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/664/comments","events_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/664/events","html_url":"https://github.com/alexcrichton/futures-rs/pull/664","id":278047581,"number":664,"title":"convert Run to Notify API, properly gate all deprecated items with with-deprecated","user":{"login":"stbuehler","id":528446,"avatar_url":"https://avatars1.githubusercontent.com/u/528446?v=4","gravatar_id":"","url":"https://api.github.com/users/stbuehler","html_url":"https://github.com/stbuehler","followers_url":"https://api.github.com/users/stbuehler/followers","following_url":"https://api.github.com/users/stbuehler/following{/other_user}","gists_url":"https://api.github.com/users/stbuehler/gists{/gist_id}","starred_url":"https://api.github.com/users/stbuehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbuehler/subscriptions","organizations_url":"https://api.github.com/users/stbuehler/orgs","repos_url":"https://api.github.com/users/stbuehler/repos","events_url":"https://api.github.com/users/stbuehler/events{/privacy}","received_events_url":"https://api.github.com/users/stbuehler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-30T09:16:09Z","updated_at":"2017-11-30T20:50:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/664","html_url":"https://github.com/alexcrichton/futures-rs/pull/664","diff_url":"https://github.com/alexcrichton/futures-rs/pull/664.diff","patch_url":"https://github.com/alexcrichton/futures-rs/pull/664.patch"},"body":"`Run` (created by `Spawn::execute`) still used the deprecated `Unpark` API; use `Notify` instead. (`Run` and friends are still required by `futures-cpupool`, so they probably shouldn't be marked deprecated just yet).\r\n\r\nAfter this no public non-deprecated feature uses deprecated features, and the second commit will add `#[cfg(feature = \"with-deprecated\")]` to all `deprecated` and `allow(deprecated)`  items.\r\n\r\nWithout `with-deprecated` it will always use the stub `UnparkEvents` and `BorrowedEvents` from the `core` implementation.\r\n\r\nThis should improve benchmarks without `with-deprecated` overall, but `unbounded_uncontended` and `thread_yield_multi_thread` seem to get slower by this..."},"comment":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/comments/348316771","html_url":"https://github.com/alexcrichton/futures-rs/pull/664#issuecomment-348316771","issue_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/664","id":348316771,"user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T20:50:26Z","updated_at":"2017-11-30T20:50:26Z","author_association":"OWNER","body":"Thanks for the PR! The `with-deprecated` feature though was sort of a hack added awhile back which we unfortunately can't actually expand like this in a backwards compatible fashion. For example if a crate disabled default features and then didn't enable `with-deprecated` this commit could run the risk of \"deleting\" used apis for that crate.\r\n\r\nCould this for now just include the `execute` changes? We can hopefully eventually just remove the `with-deprecated` business entirely!"}}
{"actor":{"display_login":"alexcrichton"}}