{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/6403","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/6403/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/6403/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/6403/events","html_url":"https://github.com/minetest/minetest/issues/6403","id":256513920,"number":6403,"title":"Fix floating sand by turning it into sandstone","user":{"login":"Wuzzy2","id":1675853,"avatar_url":"https://avatars1.githubusercontent.com/u/1675853?v=4","gravatar_id":"","url":"https://api.github.com/users/Wuzzy2","html_url":"https://github.com/Wuzzy2","followers_url":"https://api.github.com/users/Wuzzy2/followers","following_url":"https://api.github.com/users/Wuzzy2/following{/other_user}","gists_url":"https://api.github.com/users/Wuzzy2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wuzzy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wuzzy2/subscriptions","organizations_url":"https://api.github.com/users/Wuzzy2/orgs","repos_url":"https://api.github.com/users/Wuzzy2/repos","events_url":"https://api.github.com/users/Wuzzy2/events{/privacy}","received_events_url":"https://api.github.com/users/Wuzzy2/received_events","type":"User","site_admin":false},"labels":[{"id":73368996,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Mapgen","name":"@ Mapgen","color":"009800","default":false},{"id":285897422,"url":"https://api.github.com/repos/minetest/minetest/labels/Request%20/%20Suggestion","name":"Request / Suggestion","color":"8db4e0","default":false}],"state":"open","locked":false,"assignee":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"assignees":[{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-09-10T14:29:33Z","updated_at":"2017-09-11T20:47:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This is 50% bug report and 50% feature request. :D \r\n\r\nIn the v7 mapgen (and possibly others, I haven't tested) it is common for falling nodes like sand to float, especially in deserts. Floating sand is relatively easy to find.\r\nThis is very common around cave entries. Sometimes the amount of floating sand can be quite large and the CPU will cry when they start falling all at once. xD So in general the mapgen should avoid to generate floating falling nodes.\r\n\r\nHere's an example with coords and seed:\r\n![](https://i.imgur.com/tw0bPY2.png)\r\nhttps://i.imgur.com/tw0bPY2.png\r\n\r\nMy creative idea to fix this is to simply turn any floating falling node into a different non-falling node. A floating falling node is any node which is a falling node above a non-walkable node. To simplify this check, the mapgen might only check against air, water and lava.\r\nFor example, sand becomes sandstone, silver sand becomes silver sandstone, etc.\r\n\r\nI'm not sure how the engine could support this with the Biome API. Maybe add a `*_solidified` variant (or whatever you like to call it) for each `node`.\r\nThat is:\r\n\r\n* `node_top_solidified` is the “solidified” version of `node_top`\r\n* `node_filler_solidified` is the “solidified” version of `node_filler`\r\n* and so on\r\n* If `nil`, the node is not modified even when floating. This is entirely optional\r\n* Therefore, if the subgame does not implement this, nothing is changed\r\n\r\nNow a subgame like Minetest Game could simply add `node_top_solidified = \"default:desertsandstone\"` and `node_filler_solidified = \"default:desertsandstone\"` to the desert biome definition. This not only fixes floating sand, but also makes some interesting-looking cave entrances or bridges. Like this (built by me, I replaced the desert sand by hand):\r\n\r\n![](https://i.imgur.com/H9CPgWi.png)\r\n\r\nI don't know if we have floating sand in v6.\r\n\r\nI'm posting this in `minetest` and not `minetest_game` because you'll find deserts and sand in virtually all subgames."},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/328653728","html_url":"https://github.com/minetest/minetest/issues/6403#issuecomment-328653728","issue_url":"https://api.github.com/repos/minetest/minetest/issues/6403","id":328653728,"user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T20:47:25Z","updated_at":"2017-09-11T20:47:25Z","author_association":"MEMBER","body":"PR #6408 "}}
{"actor":{"display_login":"paramat"}}