{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/150572132","pull_request_review_id":76140332,"id":150572132,"diff_hunk":"@@ -1329,7 +1322,9 @@ def apply_role(role, inst, in_queue, bootstrap = false)\n \n       node.save if save_it\n     end\n+  end\n \n+  def deploy(new_elements, role, old_role, batches, bootstrap, node_attr_cache, inst)","path":"crowbar_framework/app/models/service_object.rb","position":171,"original_position":171,"commit_id":"5b35390c6f240155204fff64a2506dc176fc58ce","original_commit_id":"5b35390c6f240155204fff64a2506dc176fc58ce","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Metrics/AbcSize: Assignment Branch Condition size for deploy is too high. [101.9/30] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricsabcsize, http://c2.com/cgi/wiki?AbcMetric)<br>Metrics/CyclomaticComplexity: Cyclomatic complexity for deploy is too high. [10/6]<br>Metrics/MethodLength: Method has too many lines. [81/50] (https://github.com/bbatsov/ruby-style-guide#short-methods)<br>Metrics/PerceivedComplexity: Perceived complexity for deploy is too high. [11/7]<br>Metrics/ParameterLists: Avoid parameter lists longer than 5 parameters. [7/5] (https://github.com/bbatsov/ruby-style-guide#too-many-params)","created_at":"2017-11-13T15:32:39Z","updated_at":"2017-11-13T15:32:39Z","html_url":"https://github.com/crowbar/crowbar-core/pull/1425#discussion_r150572132","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/150572132"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1425#discussion_r150572132"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425","id":151889890,"html_url":"https://github.com/crowbar/crowbar-core/pull/1425","diff_url":"https://github.com/crowbar/crowbar-core/pull/1425.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/1425.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1425","number":1425,"state":"open","locked":false,"title":"[WIP] crowbar_framwork: refactor apply role first step","user":{"login":"Itxaka","id":1447686,"avatar_url":"https://avatars3.githubusercontent.com/u/1447686?v=4","gravatar_id":"","url":"https://api.github.com/users/Itxaka","html_url":"https://github.com/Itxaka","followers_url":"https://api.github.com/users/Itxaka/followers","following_url":"https://api.github.com/users/Itxaka/following{/other_user}","gists_url":"https://api.github.com/users/Itxaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Itxaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itxaka/subscriptions","organizations_url":"https://api.github.com/users/Itxaka/orgs","repos_url":"https://api.github.com/users/Itxaka/repos","events_url":"https://api.github.com/users/Itxaka/events{/privacy}","received_events_url":"https://api.github.com/users/Itxaka/received_events","type":"User","site_admin":false},"body":"Extract the first part of apply role into a new method. Create 2\r\ndifferent Exceptions to be able to exit immediately and catch those to\r\nreturn the proper messages to the user\r\n","created_at":"2017-11-10T11:53:58Z","updated_at":"2017-11-13T15:32:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3142aa16a097157a150b79ed5ab6e3abdcb31cce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ilausuch","id":11134265,"avatar_url":"https://avatars2.githubusercontent.com/u/11134265?v=4","gravatar_id":"","url":"https://api.github.com/users/ilausuch","html_url":"https://github.com/ilausuch","followers_url":"https://api.github.com/users/ilausuch/followers","following_url":"https://api.github.com/users/ilausuch/following{/other_user}","gists_url":"https://api.github.com/users/ilausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/ilausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilausuch/subscriptions","organizations_url":"https://api.github.com/users/ilausuch/orgs","repos_url":"https://api.github.com/users/ilausuch/repos","events_url":"https://api.github.com/users/ilausuch/events{/privacy}","received_events_url":"https://api.github.com/users/ilausuch/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1425/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/5b35390c6f240155204fff64a2506dc176fc58ce","head":{"label":"Itxaka:split_apply_role","ref":"split_apply_role","sha":"5b35390c6f240155204fff64a2506dc176fc58ce","user":{"login":"Itxaka","id":1447686,"avatar_url":"https://avatars3.githubusercontent.com/u/1447686?v=4","gravatar_id":"","url":"https://api.github.com/users/Itxaka","html_url":"https://github.com/Itxaka","followers_url":"https://api.github.com/users/Itxaka/followers","following_url":"https://api.github.com/users/Itxaka/following{/other_user}","gists_url":"https://api.github.com/users/Itxaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Itxaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itxaka/subscriptions","organizations_url":"https://api.github.com/users/Itxaka/orgs","repos_url":"https://api.github.com/users/Itxaka/repos","events_url":"https://api.github.com/users/Itxaka/events{/privacy}","received_events_url":"https://api.github.com/users/Itxaka/received_events","type":"User","site_admin":false},"repo":{"id":97498179,"name":"crowbar-core","full_name":"Itxaka/crowbar-core","owner":{"login":"Itxaka","id":1447686,"avatar_url":"https://avatars3.githubusercontent.com/u/1447686?v=4","gravatar_id":"","url":"https://api.github.com/users/Itxaka","html_url":"https://github.com/Itxaka","followers_url":"https://api.github.com/users/Itxaka/followers","following_url":"https://api.github.com/users/Itxaka/following{/other_user}","gists_url":"https://api.github.com/users/Itxaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Itxaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itxaka/subscriptions","organizations_url":"https://api.github.com/users/Itxaka/orgs","repos_url":"https://api.github.com/users/Itxaka/repos","events_url":"https://api.github.com/users/Itxaka/events{/privacy}","received_events_url":"https://api.github.com/users/Itxaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Itxaka/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/Itxaka/crowbar-core","forks_url":"https://api.github.com/repos/Itxaka/crowbar-core/forks","keys_url":"https://api.github.com/repos/Itxaka/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Itxaka/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Itxaka/crowbar-core/teams","hooks_url":"https://api.github.com/repos/Itxaka/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/Itxaka/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/Itxaka/crowbar-core/events","assignees_url":"https://api.github.com/repos/Itxaka/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/Itxaka/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/Itxaka/crowbar-core/tags","blobs_url":"https://api.github.com/repos/Itxaka/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Itxaka/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Itxaka/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Itxaka/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Itxaka/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Itxaka/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/Itxaka/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/Itxaka/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/Itxaka/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/Itxaka/crowbar-core/subscription","commits_url":"https://api.github.com/repos/Itxaka/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Itxaka/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Itxaka/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Itxaka/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Itxaka/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/Itxaka/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Itxaka/crowbar-core/merges","archive_url":"https://api.github.com/repos/Itxaka/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Itxaka/crowbar-core/downloads","issues_url":"https://api.github.com/repos/Itxaka/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/Itxaka/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Itxaka/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Itxaka/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Itxaka/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/Itxaka/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/Itxaka/crowbar-core/deployments","created_at":"2017-07-17T16:36:23Z","updated_at":"2017-07-17T16:36:26Z","pushed_at":"2017-11-13T15:32:29Z","git_url":"git://github.com/Itxaka/crowbar-core.git","ssh_url":"git@github.com:Itxaka/crowbar-core.git","clone_url":"https://github.com/Itxaka/crowbar-core.git","svn_url":"https://github.com/Itxaka/crowbar-core","homepage":null,"size":108807,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"da25993c0748607399d3ac04b1598905f749362e","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2017-06-29T15:15:45Z","pushed_at":"2017-11-13T15:32:30Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":108791,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":50,"forks":48,"open_issues":50,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1425"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1425"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1425/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1425/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/5b35390c6f240155204fff64a2506dc176fc58ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}