{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/kaegi/MorphMan/pulls/17","id":109173666,"html_url":"https://github.com/kaegi/MorphMan/pull/17","diff_url":"https://github.com/kaegi/MorphMan/pull/17.diff","patch_url":"https://github.com/kaegi/MorphMan/pull/17.patch","issue_url":"https://api.github.com/repos/kaegi/MorphMan/issues/17","number":17,"state":"closed","locked":false,"title":"Provide separate options to set the various optional tags","user":{"login":"gnprice","id":28173,"avatar_url":"https://avatars2.githubusercontent.com/u/28173?v=3","gravatar_id":"","url":"https://api.github.com/users/gnprice","html_url":"https://github.com/gnprice","followers_url":"https://api.github.com/users/gnprice/followers","following_url":"https://api.github.com/users/gnprice/following{/other_user}","gists_url":"https://api.github.com/users/gnprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gnprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnprice/subscriptions","organizations_url":"https://api.github.com/users/gnprice/orgs","repos_url":"https://api.github.com/users/gnprice/repos","events_url":"https://api.github.com/users/gnprice/events{/privacy}","received_events_url":"https://api.github.com/users/gnprice/received_events","type":"User","site_admin":false},"body":"I find the `mm_tooLong` and `mm_badLength` tags super noisy, because\r\nthey appear on tons of notes, so I appreciate the option to disable\r\nthem.  But I'd like to do so while still setting the `mm_priority`\r\ntag, which by definition only appears on notes useful for a priority\r\nmorpheme, which isn't so common.\r\n\r\nHere, provide separate toggles for the three optional tags.  For a\r\nuser with the omnibus `Option_SetNotRequiredTags` setting in their\r\nconfig -- including any user running this version for the first time\r\nafter using the previous version of MorphMan -- we migrate that\r\nsetting to the three new settings, giving exactly the same behavior.\r\n\r\nFor new users without an existing config, set the default to silence\r\nthe two noisy tags while still setting `mm_priority`.\r\n\r\nOne harmless but confusing gotcha when testing this change: if you\r\ndisable a tag and recalculate, the tag may still exist on some notes\r\nif you have the `only update k+2 and below` setting set (as I do.)\r\nThis is probably the right behavior, in keeping with the general point\r\nof that setting.\r\n\r\nThe PreferencesDialog code gets a very small refactor to make\r\n`self.boolOptionList` shared across all the frames/tabs of the\r\ndialog.  I like how very generic and crisp the relevant logic in\r\n`readConfigFromGui` is, and how this change doesn't have to touch\r\nthat method at all to introduce the new checkboxes.","created_at":"2017-03-06T00:27:22Z","updated_at":"2017-03-07T06:53:31Z","closed_at":"2017-03-07T06:53:30Z","merged_at":null,"merge_commit_sha":"88493f2cbc55cdf5eae82f25db016ca0522af890","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaegi/MorphMan/pulls/17/commits","review_comments_url":"https://api.github.com/repos/kaegi/MorphMan/pulls/17/comments","review_comment_url":"https://api.github.com/repos/kaegi/MorphMan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaegi/MorphMan/issues/17/comments","statuses_url":"https://api.github.com/repos/kaegi/MorphMan/statuses/604c850d91225cbe53d5da49631a34a0320ac86b","head":{"label":"gnprice:optional-tags","ref":"optional-tags","sha":"604c850d91225cbe53d5da49631a34a0320ac86b","user":{"login":"gnprice","id":28173,"avatar_url":"https://avatars2.githubusercontent.com/u/28173?v=3","gravatar_id":"","url":"https://api.github.com/users/gnprice","html_url":"https://github.com/gnprice","followers_url":"https://api.github.com/users/gnprice/followers","following_url":"https://api.github.com/users/gnprice/following{/other_user}","gists_url":"https://api.github.com/users/gnprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gnprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnprice/subscriptions","organizations_url":"https://api.github.com/users/gnprice/orgs","repos_url":"https://api.github.com/users/gnprice/repos","events_url":"https://api.github.com/users/gnprice/events{/privacy}","received_events_url":"https://api.github.com/users/gnprice/received_events","type":"User","site_admin":false},"repo":{"id":83876705,"name":"MorphMan","full_name":"gnprice/MorphMan","owner":{"login":"gnprice","id":28173,"avatar_url":"https://avatars2.githubusercontent.com/u/28173?v=3","gravatar_id":"","url":"https://api.github.com/users/gnprice","html_url":"https://github.com/gnprice","followers_url":"https://api.github.com/users/gnprice/followers","following_url":"https://api.github.com/users/gnprice/following{/other_user}","gists_url":"https://api.github.com/users/gnprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gnprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnprice/subscriptions","organizations_url":"https://api.github.com/users/gnprice/orgs","repos_url":"https://api.github.com/users/gnprice/repos","events_url":"https://api.github.com/users/gnprice/events{/privacy}","received_events_url":"https://api.github.com/users/gnprice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gnprice/MorphMan","description":"Anki plugin that reorders language cards based on the words you know","fork":true,"url":"https://api.github.com/repos/gnprice/MorphMan","forks_url":"https://api.github.com/repos/gnprice/MorphMan/forks","keys_url":"https://api.github.com/repos/gnprice/MorphMan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnprice/MorphMan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnprice/MorphMan/teams","hooks_url":"https://api.github.com/repos/gnprice/MorphMan/hooks","issue_events_url":"https://api.github.com/repos/gnprice/MorphMan/issues/events{/number}","events_url":"https://api.github.com/repos/gnprice/MorphMan/events","assignees_url":"https://api.github.com/repos/gnprice/MorphMan/assignees{/user}","branches_url":"https://api.github.com/repos/gnprice/MorphMan/branches{/branch}","tags_url":"https://api.github.com/repos/gnprice/MorphMan/tags","blobs_url":"https://api.github.com/repos/gnprice/MorphMan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnprice/MorphMan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnprice/MorphMan/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnprice/MorphMan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnprice/MorphMan/statuses/{sha}","languages_url":"https://api.github.com/repos/gnprice/MorphMan/languages","stargazers_url":"https://api.github.com/repos/gnprice/MorphMan/stargazers","contributors_url":"https://api.github.com/repos/gnprice/MorphMan/contributors","subscribers_url":"https://api.github.com/repos/gnprice/MorphMan/subscribers","subscription_url":"https://api.github.com/repos/gnprice/MorphMan/subscription","commits_url":"https://api.github.com/repos/gnprice/MorphMan/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnprice/MorphMan/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnprice/MorphMan/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnprice/MorphMan/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnprice/MorphMan/contents/{+path}","compare_url":"https://api.github.com/repos/gnprice/MorphMan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnprice/MorphMan/merges","archive_url":"https://api.github.com/repos/gnprice/MorphMan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnprice/MorphMan/downloads","issues_url":"https://api.github.com/repos/gnprice/MorphMan/issues{/number}","pulls_url":"https://api.github.com/repos/gnprice/MorphMan/pulls{/number}","milestones_url":"https://api.github.com/repos/gnprice/MorphMan/milestones{/number}","notifications_url":"https://api.github.com/repos/gnprice/MorphMan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnprice/MorphMan/labels{/name}","releases_url":"https://api.github.com/repos/gnprice/MorphMan/releases{/id}","deployments_url":"https://api.github.com/repos/gnprice/MorphMan/deployments","created_at":"2017-03-04T07:50:02Z","updated_at":"2017-03-04T07:50:04Z","pushed_at":"2017-03-07T06:37:46Z","git_url":"git://github.com/gnprice/MorphMan.git","ssh_url":"git@github.com:gnprice/MorphMan.git","clone_url":"https://github.com/gnprice/MorphMan.git","svn_url":"https://github.com/gnprice/MorphMan","homepage":"","size":11705,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kaegi:master","ref":"master","sha":"661c611631cc901be8bfb6b9449621b53a584a0e","user":{"login":"kaegi","id":16853465,"avatar_url":"https://avatars1.githubusercontent.com/u/16853465?v=3","gravatar_id":"","url":"https://api.github.com/users/kaegi","html_url":"https://github.com/kaegi","followers_url":"https://api.github.com/users/kaegi/followers","following_url":"https://api.github.com/users/kaegi/following{/other_user}","gists_url":"https://api.github.com/users/kaegi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaegi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaegi/subscriptions","organizations_url":"https://api.github.com/users/kaegi/orgs","repos_url":"https://api.github.com/users/kaegi/repos","events_url":"https://api.github.com/users/kaegi/events{/privacy}","received_events_url":"https://api.github.com/users/kaegi/received_events","type":"User","site_admin":false},"repo":{"id":70213152,"name":"MorphMan","full_name":"kaegi/MorphMan","owner":{"login":"kaegi","id":16853465,"avatar_url":"https://avatars1.githubusercontent.com/u/16853465?v=3","gravatar_id":"","url":"https://api.github.com/users/kaegi","html_url":"https://github.com/kaegi","followers_url":"https://api.github.com/users/kaegi/followers","following_url":"https://api.github.com/users/kaegi/following{/other_user}","gists_url":"https://api.github.com/users/kaegi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaegi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaegi/subscriptions","organizations_url":"https://api.github.com/users/kaegi/orgs","repos_url":"https://api.github.com/users/kaegi/repos","events_url":"https://api.github.com/users/kaegi/events{/privacy}","received_events_url":"https://api.github.com/users/kaegi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaegi/MorphMan","description":"Anki plugin that reorders language cards based on the words you know","fork":true,"url":"https://api.github.com/repos/kaegi/MorphMan","forks_url":"https://api.github.com/repos/kaegi/MorphMan/forks","keys_url":"https://api.github.com/repos/kaegi/MorphMan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaegi/MorphMan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaegi/MorphMan/teams","hooks_url":"https://api.github.com/repos/kaegi/MorphMan/hooks","issue_events_url":"https://api.github.com/repos/kaegi/MorphMan/issues/events{/number}","events_url":"https://api.github.com/repos/kaegi/MorphMan/events","assignees_url":"https://api.github.com/repos/kaegi/MorphMan/assignees{/user}","branches_url":"https://api.github.com/repos/kaegi/MorphMan/branches{/branch}","tags_url":"https://api.github.com/repos/kaegi/MorphMan/tags","blobs_url":"https://api.github.com/repos/kaegi/MorphMan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaegi/MorphMan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaegi/MorphMan/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaegi/MorphMan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaegi/MorphMan/statuses/{sha}","languages_url":"https://api.github.com/repos/kaegi/MorphMan/languages","stargazers_url":"https://api.github.com/repos/kaegi/MorphMan/stargazers","contributors_url":"https://api.github.com/repos/kaegi/MorphMan/contributors","subscribers_url":"https://api.github.com/repos/kaegi/MorphMan/subscribers","subscription_url":"https://api.github.com/repos/kaegi/MorphMan/subscription","commits_url":"https://api.github.com/repos/kaegi/MorphMan/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaegi/MorphMan/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaegi/MorphMan/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaegi/MorphMan/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaegi/MorphMan/contents/{+path}","compare_url":"https://api.github.com/repos/kaegi/MorphMan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaegi/MorphMan/merges","archive_url":"https://api.github.com/repos/kaegi/MorphMan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaegi/MorphMan/downloads","issues_url":"https://api.github.com/repos/kaegi/MorphMan/issues{/number}","pulls_url":"https://api.github.com/repos/kaegi/MorphMan/pulls{/number}","milestones_url":"https://api.github.com/repos/kaegi/MorphMan/milestones{/number}","notifications_url":"https://api.github.com/repos/kaegi/MorphMan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaegi/MorphMan/labels{/name}","releases_url":"https://api.github.com/repos/kaegi/MorphMan/releases{/id}","deployments_url":"https://api.github.com/repos/kaegi/MorphMan/deployments","created_at":"2016-10-07T03:40:23Z","updated_at":"2017-02-25T15:14:41Z","pushed_at":"2017-03-07T06:37:47Z","git_url":"git://github.com/kaegi/MorphMan.git","ssh_url":"git@github.com:kaegi/MorphMan.git","clone_url":"https://github.com/kaegi/MorphMan.git","svn_url":"https://github.com/kaegi/MorphMan","homepage":"","size":11679,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaegi/MorphMan/pulls/17"},"html":{"href":"https://github.com/kaegi/MorphMan/pull/17"},"issue":{"href":"https://api.github.com/repos/kaegi/MorphMan/issues/17"},"comments":{"href":"https://api.github.com/repos/kaegi/MorphMan/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/kaegi/MorphMan/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/kaegi/MorphMan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaegi/MorphMan/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/kaegi/MorphMan/statuses/604c850d91225cbe53d5da49631a34a0320ac86b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":70,"deletions":36,"changed_files":3}}
{"actor":{"display_login":"gnprice"}}