{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/28478","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/28478/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/28478/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/28478/events","html_url":"https://github.com/tgstation/tgstation/pull/28478","id":236072018,"number":28478,"title":"[WIP] Implements Reverb!!","user":{"login":"Tacolizard","id":7098330,"avatar_url":"https://avatars2.githubusercontent.com/u/7098330?v=3","gravatar_id":"","url":"https://api.github.com/users/Tacolizard","html_url":"https://github.com/Tacolizard","followers_url":"https://api.github.com/users/Tacolizard/followers","following_url":"https://api.github.com/users/Tacolizard/following{/other_user}","gists_url":"https://api.github.com/users/Tacolizard/gists{/gist_id}","starred_url":"https://api.github.com/users/Tacolizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tacolizard/subscriptions","organizations_url":"https://api.github.com/users/Tacolizard/orgs","repos_url":"https://api.github.com/users/Tacolizard/repos","events_url":"https://api.github.com/users/Tacolizard/events{/privacy}","received_events_url":"https://api.github.com/users/Tacolizard/received_events","type":"User","site_admin":false},"labels":[{"id":149581322,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Feature","name":"Feature","color":"009800","default":false},{"id":255847001,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Work%20In%20Progress","name":"Work In Progress","color":"006B75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-06-15T04:08:52Z","updated_at":"2017-06-15T09:42:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/28478","html_url":"https://github.com/tgstation/tgstation/pull/28478","diff_url":"https://github.com/tgstation/tgstation/pull/28478.diff","patch_url":"https://github.com/tgstation/tgstation/pull/28478.patch"},"body":":cl: Tacolizard\r\nadd: Sounds now have reverb effects, the reverb is determined by whichever area the sound source is located.\r\n/:cl:\r\n\r\nYet another idea borrowed from Goonstation, this PR adds reverb to sounds. This is actually a better implementation than Goonstation's, because theirs uses the `environment` var to set reverb effects. The `environment` var modifies ALL currently playing sounds, meaning that if one sound is playing with reverb, another sound that plays without reverb or with different reverb settings will override the first sound's reverb. This implementation uses the `echo` var, which can do the same thing as environment except it only applies to single sounds. I have created a list of all the different `environment` presets so they can be used with `echo`.\r\n\r\n**for mappers and coders:**\r\nThis reverb system is area-based. Each area can have a `sound_environment` var, which is a number 0-25 that sets which environment preset to use. This preset determines the sound of the reverb.\r\n\r\n**what will this do?**\r\nReverb is the echo effect that happens when a sound bounces off surfaces in any natural space. The sounds in our game (most of them) are recorded to minimize reverb as much as possible. This is done to allow the people who use the sounds to apply reverb. Without reverb, things sound unnatural, but the addition of reverb makes things sound like they are in a real environment. You really have to hear it to understand.\r\n\r\nTODO:\r\n[] Make the reverb play again**oh my god i need help with this I echo refuses to be set to anything**\r\n[] Implement occlusion"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/308682671","html_url":"https://github.com/tgstation/tgstation/pull/28478#issuecomment-308682671","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/28478","id":308682671,"user":{"login":"improvedname","id":24854897,"avatar_url":"https://avatars0.githubusercontent.com/u/24854897?v=3","gravatar_id":"","url":"https://api.github.com/users/improvedname","html_url":"https://github.com/improvedname","followers_url":"https://api.github.com/users/improvedname/followers","following_url":"https://api.github.com/users/improvedname/following{/other_user}","gists_url":"https://api.github.com/users/improvedname/gists{/gist_id}","starred_url":"https://api.github.com/users/improvedname/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improvedname/subscriptions","organizations_url":"https://api.github.com/users/improvedname/orgs","repos_url":"https://api.github.com/users/improvedname/repos","events_url":"https://api.github.com/users/improvedname/events{/privacy}","received_events_url":"https://api.github.com/users/improvedname/received_events","type":"User","site_admin":false},"created_at":"2017-06-15T09:42:07Z","updated_at":"2017-06-15T09:42:07Z","body":"https://www.youtube.com/watch?v=9U2CePgS1Rc"}}
{"actor":{"display_login":"improvedname"}}