{"action":"created","issue":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2230","repository_url":"https://api.github.com/repos/buttonmen-dev/buttonmen","labels_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2230/labels{/name}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2230/comments","events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2230/events","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2230","id":241299506,"number":2230,"title":"Added the ability to show multiple players' or buttons' records, to the 'record' script.","user":{"login":"irilyth","id":4923138,"avatar_url":"https://avatars5.githubusercontent.com/u/4923138?v=4","gravatar_id":"","url":"https://api.github.com/users/irilyth","html_url":"https://github.com/irilyth","followers_url":"https://api.github.com/users/irilyth/followers","following_url":"https://api.github.com/users/irilyth/following{/other_user}","gists_url":"https://api.github.com/users/irilyth/gists{/gist_id}","starred_url":"https://api.github.com/users/irilyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irilyth/subscriptions","organizations_url":"https://api.github.com/users/irilyth/orgs","repos_url":"https://api.github.com/users/irilyth/repos","events_url":"https://api.github.com/users/irilyth/events{/privacy}","received_events_url":"https://api.github.com/users/irilyth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-07-07T15:29:47Z","updated_at":"2017-07-16T04:59:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/2230","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2230","diff_url":"https://github.com/buttonmen-dev/buttonmen/pull/2230.diff","patch_url":"https://github.com/buttonmen-dev/buttonmen/pull/2230.patch"},"body":"http://jenkins.buttonweavers.com:8080/job/buttonmen-irilyth/49/ (if it passes)"},"comment":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/comments/315585755","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2230#issuecomment-315585755","issue_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2230","id":315585755,"user":{"login":"irilyth","id":4923138,"avatar_url":"https://avatars5.githubusercontent.com/u/4923138?v=4","gravatar_id":"","url":"https://api.github.com/users/irilyth","html_url":"https://github.com/irilyth","followers_url":"https://api.github.com/users/irilyth/followers","following_url":"https://api.github.com/users/irilyth/following{/other_user}","gists_url":"https://api.github.com/users/irilyth/gists{/gist_id}","starred_url":"https://api.github.com/users/irilyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irilyth/subscriptions","organizations_url":"https://api.github.com/users/irilyth/orgs","repos_url":"https://api.github.com/users/irilyth/repos","events_url":"https://api.github.com/users/irilyth/events{/privacy}","received_events_url":"https://api.github.com/users/irilyth/received_events","type":"User","site_admin":false},"created_at":"2017-07-16T04:59:05Z","updated_at":"2017-07-16T04:59:05Z","body":"> I would suggest running 10 page loads of the history page showing 'all history for irilyth', and 10 page loads of an active game. Timing could be done with a stopwatch, since we don't need a huge amount of precision. What we're looking for here is a gross difference in load times (e.g., 20% increase), something noticeable.\r\n\r\nOk, sure.\r\n\r\nFor the game page, I used http://www.buttonweavers.com/ui/game.html?game=25256, which has a long chat log, and for the history page, http://www.buttonweavers.com/ui/history.html#!playerNameA=irilyth. For each, I did a shift-reload each time, to avoid the cache as much as possible. I did ten tests before running the script (./record button all), the game page first and then the history page, then ran the script and did ten tests again, then killed the script and did ten tests again. I reloaded the page ten times in a row, with a lap timer on a stopwatch app on my phone, hitting \"lap\" on the timer and \"shift-ctrl-r\" on my keyboard at approximately the same time.\r\n\r\nGame page results:\r\n\r\nbefore | during | after\r\n------ | ------ | -----\r\n3.36 | 4.99 | 2.77\r\n2.61 | 4.30 | 3.57\r\n3.13 | 4.00 | 3.33\r\n3.28 | 4.36 | 3.26\r\n2.95 | 3.71 | 3.39\r\n3.40 | 3.97 | 3.63\r\n2.86 | 3.58 | 3.21\r\n3.16 | 3.12 | 3.03\r\n2.69 | 3.80 | 2.81\r\n2.87 | 3.15 | 2.99\r\n\r\nTotals: 30.31 before, 38.98 during, 31.99 after.\r\n\r\nHistory page results:\r\n\r\nbefore | during | after\r\n------ | ------ | -----\r\n7.41  | 10.81 | 7.31\r\n6.93  | 10.76 | 6.82\r\n6.29  | 12.96 | 7.29\r\n6.21  | 8.62  | 7.47\r\n5.88  | 11.21 | 6.97\r\n7.00  | 10.78 | 6.62\r\n5.67  | 11.96 | 8.14\r\n6.53  | 10.33 | 6.50\r\n6.20  | 11.24 | 7.45\r\n12.68 | 9.82  | 6.45\r\n\r\nTotals: 70.80 before, 108.49 during, 71.02 after.\r\n\r\nThis was all between around 12:30 and 01:00 Eastern."}}
{"actor":{"display_login":"irilyth"}}