{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/209","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/209/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/209/events","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/209","id":235674972,"number":209,"title":"Removes psych as a dependency","user":{"login":"NickLaMuro","id":314014,"avatar_url":"https://avatars3.githubusercontent.com/u/314014?v=3","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-06-13T20:00:04Z","updated_at":"2017-06-13T21:24:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/209","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/209","diff_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/209.diff","patch_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/209.patch"},"body":"The psych dependency was added back when some monkey patches still existed in our codebase, were merged in my Aaron Patterson, and the one from ruby core was not updated to the latest version:\n\nhttps://github.com/ManageIQ/manageiq/commit/907a679\n\nNow that we support ruby 2.3+, the psych is on version 2.1+, so this dependency is no longer needed:\n\n```console\n$ irb\nirb(main):001:0> Psych\nNameError: uninitialized constant Psych\nfrom (irb):1 from /Users/nicklamuro/.rubies/ruby-2.3.3/bin/irb:11:in `<main>'\nirb(main):002:0> require 'psych'\n=> true\nirb(main):003:0> Psych.methods\n=> [:dump, :load, :quick_emit, :parse, :load_file, ... ]\nirb(main):004:0> Psych.method(:dump).source_location\n=> [\"/Users/nicklamuro/.rubies/ruby-2.3.3/lib/ruby/2.3.0/psych.rb\", 411]\nirb(main):005:0>  Psych::VERSION\n=> \"2.1.0\"\nirb(main):006:0>\n```"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/comments/308253135","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/209#issuecomment-308253135","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/209","id":308253135,"user":{"login":"NickLaMuro","id":314014,"avatar_url":"https://avatars3.githubusercontent.com/u/314014?v=3","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"created_at":"2017-06-13T21:24:22Z","updated_at":"2017-06-13T21:24:22Z","body":"@jrafanie @Fryguy thoughts on this one?\r\n\r\nI mostly have been having to comment out this line in development mode since I use [zeus](https://github.com/burke/zeus) for testing, and it loads psych outside of bundler, so that becomes a problem since there are conflicting versions.  #selfishPR"}}
{"actor":{"display_login":"NickLaMuro"}}