{"action":"created","comment":{"url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/comments/144234253","pull_request_review_id":68861549,"id":144234253,"diff_hunk":"@@ -415,6 +416,13 @@ def test011_post_nodes_vms_vmid_migrate(self):\n         vms = new_core0_client.client.kvm.list()\n         self.assertIn(self.data['id'], [x['name'] for x in vms])\n \n+        self.lg.info('check that the node, VM0 moved to, is cleaned up')\n+        res = new_core0_client.client.bash('ps -a | grep \"sshd.config\"').get()\n+        self.assertNotIn('myvm', res.stdout)\n+        res = new_core0_client.client.bash('ls /tmp').get()\n+        self.assertNotIn('myvm', res.stdout)","path":"tests/0_orchestrator/test_suite/testcases/basic_tests/test07_vms_apis.py","position":16,"original_position":16,"commit_id":"8cab0ce987d39f30a78338e6cc0082ef4e14a854","original_commit_id":"8cab0ce987d39f30a78338e6cc0082ef4e14a854","user":{"login":"ahmedelsayed-93","id":24386820,"avatar_url":"https://avatars1.githubusercontent.com/u/24386820?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmedelsayed-93","html_url":"https://github.com/ahmedelsayed-93","followers_url":"https://api.github.com/users/ahmedelsayed-93/followers","following_url":"https://api.github.com/users/ahmedelsayed-93/following{/other_user}","gists_url":"https://api.github.com/users/ahmedelsayed-93/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedelsayed-93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedelsayed-93/subscriptions","organizations_url":"https://api.github.com/users/ahmedelsayed-93/orgs","repos_url":"https://api.github.com/users/ahmedelsayed-93/repos","events_url":"https://api.github.com/users/ahmedelsayed-93/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedelsayed-93/received_events","type":"User","site_admin":false},"body":"myvm should be the vm id (self.data['id'])\r\n","created_at":"2017-10-12T09:15:01Z","updated_at":"2017-10-12T09:15:01Z","html_url":"https://github.com/zero-os/0-orchestrator/pull/1202#discussion_r144234253","pull_request_url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/comments/144234253"},"html":{"href":"https://github.com/zero-os/0-orchestrator/pull/1202#discussion_r144234253"},"pull_request":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202"}}},"pull_request":{"url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202","id":146151549,"html_url":"https://github.com/zero-os/0-orchestrator/pull/1202","diff_url":"https://github.com/zero-os/0-orchestrator/pull/1202.diff","patch_url":"https://github.com/zero-os/0-orchestrator/pull/1202.patch","issue_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues/1202","number":1202,"state":"open","locked":false,"title":"make sure the node is cleaned up after vm migration","user":{"login":"john-kheir","id":15011431,"avatar_url":"https://avatars1.githubusercontent.com/u/15011431?v=4","gravatar_id":"","url":"https://api.github.com/users/john-kheir","html_url":"https://github.com/john-kheir","followers_url":"https://api.github.com/users/john-kheir/followers","following_url":"https://api.github.com/users/john-kheir/following{/other_user}","gists_url":"https://api.github.com/users/john-kheir/gists{/gist_id}","starred_url":"https://api.github.com/users/john-kheir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-kheir/subscriptions","organizations_url":"https://api.github.com/users/john-kheir/orgs","repos_url":"https://api.github.com/users/john-kheir/repos","events_url":"https://api.github.com/users/john-kheir/events{/privacy}","received_events_url":"https://api.github.com/users/john-kheir/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-12T08:53:26Z","updated_at":"2017-10-12T09:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6866f7175f9de03979344a2df6fdcefba69437f6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202/commits","review_comments_url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202/comments","review_comment_url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues/1202/comments","statuses_url":"https://api.github.com/repos/zero-os/0-orchestrator/statuses/8cab0ce987d39f30a78338e6cc0082ef4e14a854","head":{"label":"zero-os:task-1181","ref":"task-1181","sha":"8cab0ce987d39f30a78338e6cc0082ef4e14a854","user":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"repo":{"id":84221732,"name":"0-orchestrator","full_name":"zero-os/0-orchestrator","owner":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zero-os/0-orchestrator","description":"Zero-OS orchestration server. Provides a RESTfull api to manage a pool of Zero-OS nodes.","fork":false,"url":"https://api.github.com/repos/zero-os/0-orchestrator","forks_url":"https://api.github.com/repos/zero-os/0-orchestrator/forks","keys_url":"https://api.github.com/repos/zero-os/0-orchestrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-os/0-orchestrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-os/0-orchestrator/teams","hooks_url":"https://api.github.com/repos/zero-os/0-orchestrator/hooks","issue_events_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues/events{/number}","events_url":"https://api.github.com/repos/zero-os/0-orchestrator/events","assignees_url":"https://api.github.com/repos/zero-os/0-orchestrator/assignees{/user}","branches_url":"https://api.github.com/repos/zero-os/0-orchestrator/branches{/branch}","tags_url":"https://api.github.com/repos/zero-os/0-orchestrator/tags","blobs_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-os/0-orchestrator/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-os/0-orchestrator/languages","stargazers_url":"https://api.github.com/repos/zero-os/0-orchestrator/stargazers","contributors_url":"https://api.github.com/repos/zero-os/0-orchestrator/contributors","subscribers_url":"https://api.github.com/repos/zero-os/0-orchestrator/subscribers","subscription_url":"https://api.github.com/repos/zero-os/0-orchestrator/subscription","commits_url":"https://api.github.com/repos/zero-os/0-orchestrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-os/0-orchestrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-os/0-orchestrator/contents/{+path}","compare_url":"https://api.github.com/repos/zero-os/0-orchestrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-os/0-orchestrator/merges","archive_url":"https://api.github.com/repos/zero-os/0-orchestrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-os/0-orchestrator/downloads","issues_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues{/number}","pulls_url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-os/0-orchestrator/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-os/0-orchestrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-os/0-orchestrator/labels{/name}","releases_url":"https://api.github.com/repos/zero-os/0-orchestrator/releases{/id}","deployments_url":"https://api.github.com/repos/zero-os/0-orchestrator/deployments","created_at":"2017-03-07T16:29:57Z","updated_at":"2017-10-01T09:26:46Z","pushed_at":"2017-10-12T08:53:33Z","git_url":"git://github.com/zero-os/0-orchestrator.git","ssh_url":"git@github.com:zero-os/0-orchestrator.git","clone_url":"https://github.com/zero-os/0-orchestrator.git","svn_url":"https://github.com/zero-os/0-orchestrator","homepage":"","size":7565,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":115,"forks":4,"open_issues":115,"watchers":1,"default_branch":"master"}},"base":{"label":"zero-os:master","ref":"master","sha":"b9a7d99a20358524edfcb5dfd15a5a9c66b6f93a","user":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"repo":{"id":84221732,"name":"0-orchestrator","full_name":"zero-os/0-orchestrator","owner":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zero-os/0-orchestrator","description":"Zero-OS orchestration server. Provides a RESTfull api to manage a pool of Zero-OS nodes.","fork":false,"url":"https://api.github.com/repos/zero-os/0-orchestrator","forks_url":"https://api.github.com/repos/zero-os/0-orchestrator/forks","keys_url":"https://api.github.com/repos/zero-os/0-orchestrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-os/0-orchestrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-os/0-orchestrator/teams","hooks_url":"https://api.github.com/repos/zero-os/0-orchestrator/hooks","issue_events_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues/events{/number}","events_url":"https://api.github.com/repos/zero-os/0-orchestrator/events","assignees_url":"https://api.github.com/repos/zero-os/0-orchestrator/assignees{/user}","branches_url":"https://api.github.com/repos/zero-os/0-orchestrator/branches{/branch}","tags_url":"https://api.github.com/repos/zero-os/0-orchestrator/tags","blobs_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-os/0-orchestrator/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-os/0-orchestrator/languages","stargazers_url":"https://api.github.com/repos/zero-os/0-orchestrator/stargazers","contributors_url":"https://api.github.com/repos/zero-os/0-orchestrator/contributors","subscribers_url":"https://api.github.com/repos/zero-os/0-orchestrator/subscribers","subscription_url":"https://api.github.com/repos/zero-os/0-orchestrator/subscription","commits_url":"https://api.github.com/repos/zero-os/0-orchestrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-os/0-orchestrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-os/0-orchestrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-os/0-orchestrator/contents/{+path}","compare_url":"https://api.github.com/repos/zero-os/0-orchestrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-os/0-orchestrator/merges","archive_url":"https://api.github.com/repos/zero-os/0-orchestrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-os/0-orchestrator/downloads","issues_url":"https://api.github.com/repos/zero-os/0-orchestrator/issues{/number}","pulls_url":"https://api.github.com/repos/zero-os/0-orchestrator/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-os/0-orchestrator/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-os/0-orchestrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-os/0-orchestrator/labels{/name}","releases_url":"https://api.github.com/repos/zero-os/0-orchestrator/releases{/id}","deployments_url":"https://api.github.com/repos/zero-os/0-orchestrator/deployments","created_at":"2017-03-07T16:29:57Z","updated_at":"2017-10-01T09:26:46Z","pushed_at":"2017-10-12T08:53:33Z","git_url":"git://github.com/zero-os/0-orchestrator.git","ssh_url":"git@github.com:zero-os/0-orchestrator.git","clone_url":"https://github.com/zero-os/0-orchestrator.git","svn_url":"https://github.com/zero-os/0-orchestrator","homepage":"","size":7565,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":115,"forks":4,"open_issues":115,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202"},"html":{"href":"https://github.com/zero-os/0-orchestrator/pull/1202"},"issue":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/issues/1202"},"comments":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/issues/1202/comments"},"review_comments":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202/comments"},"review_comment":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/pulls/1202/commits"},"statuses":{"href":"https://api.github.com/repos/zero-os/0-orchestrator/statuses/8cab0ce987d39f30a78338e6cc0082ef4e14a854"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ahmedelsayed-93"}}