{"action":"created","issue":{"url":"https://api.github.com/repos/Exiv2/exiv2/issues/116","repository_url":"https://api.github.com/repos/Exiv2/exiv2","labels_url":"https://api.github.com/repos/Exiv2/exiv2/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/Exiv2/exiv2/issues/116/comments","events_url":"https://api.github.com/repos/Exiv2/exiv2/issues/116/events","html_url":"https://github.com/Exiv2/exiv2/pull/116","id":264461531,"number":116,"title":"Add Unit tests with Google Test","user":{"login":"piponazo","id":102645,"avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"piponazo","id":102645,"avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false},"assignees":[{"login":"piponazo","id":102645,"avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-10-11T05:28:58Z","updated_at":"2017-10-12T14:22:19Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Exiv2/exiv2/pulls/116","html_url":"https://github.com/Exiv2/exiv2/pull/116","diff_url":"https://github.com/Exiv2/exiv2/pull/116.diff","patch_url":"https://github.com/Exiv2/exiv2/pull/116.patch"},"body":"In this PR I introduce the support to add unit tests with the Google Test and Google Mock frameworks.\r\n\r\nBy default the compilation of the unit tests is disabled. One can enable it toggling the CMake Option  **EXIV2_BUILD_UNIT_TESTS**. Once that variable is enabled, CMake will try to find GTest and GMock in your system. I also added these dependencies to conan, so if you use conan it should be automatic to bring those dependencies to your system.\r\n\r\nI just added few simple unit tests as example of how to use the framework and how to add new tests into the project.\r\n\r\nThe tests are running correctly on travis-ci for Linux and Mac. On Windows I am having a problem (they crash when AppVeyor execute them) and I disabled their execution temporarily.\r\n\r\nLet me known about your thoughts."},"comment":{"url":"https://api.github.com/repos/Exiv2/exiv2/issues/comments/336152672","html_url":"https://github.com/Exiv2/exiv2/pull/116#issuecomment-336152672","issue_url":"https://api.github.com/repos/Exiv2/exiv2/issues/116","id":336152672,"user":{"login":"piponazo","id":102645,"avatar_url":"https://avatars0.githubusercontent.com/u/102645?v=4","gravatar_id":"","url":"https://api.github.com/users/piponazo","html_url":"https://github.com/piponazo","followers_url":"https://api.github.com/users/piponazo/followers","following_url":"https://api.github.com/users/piponazo/following{/other_user}","gists_url":"https://api.github.com/users/piponazo/gists{/gist_id}","starred_url":"https://api.github.com/users/piponazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piponazo/subscriptions","organizations_url":"https://api.github.com/users/piponazo/orgs","repos_url":"https://api.github.com/users/piponazo/repos","events_url":"https://api.github.com/users/piponazo/events{/privacy}","received_events_url":"https://api.github.com/users/piponazo/received_events","type":"User","site_admin":false},"created_at":"2017-10-12T14:22:19Z","updated_at":"2017-10-12T14:22:19Z","author_association":"COLLABORATOR","body":"Umh! So you actually do not have libraries for GMock (there are only .so files for gtest). That is probably the problem. Can you check why it does not install the libgmock.so files ?\r\n\r\nAnyways, I would also appretiate if you try to use conan to bring the dependencies and tell me if it works in that way for you :)"}}
{"actor":{"display_login":"piponazo"}}