{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1374","repository_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1374/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1374/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/1374/events","html_url":"https://github.com/kubernetes-incubator/service-catalog/issues/1374","id":264954692,"number":1374,"title":"Make it easier to debug situations where a secret is created without data","user":{"login":"pmorie","id":366488,"avatar_url":"https://avatars2.githubusercontent.com/u/366488?v=4","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-12T14:04:20Z","updated_at":"2017-10-12T21:06:24Z","closed_at":"2017-10-12T21:06:24Z","author_association":"MEMBER","body":"@shawn-hurley ran into an issue today where a secret was created without any data; it's currently difficult to debug this because we don't have anything in the logs to help us out:\r\n\r\n```console\r\n    23 controller_binding.go:161] Processing ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nI1012 12:51:32.074045      23 controller.go:388] Creating client for ClusterServiceBroker ansible-service-broker, URL: https://asb.ansible-service-broker.svc:1338/ansible-service-broker/\r\nI1012 12:51:32.074692      23 controller_binding.go:245] Adding/Updating ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nI1012 12:51:32.081388      23 controller_binding.go:853] Setting ServiceBinding 'demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf' condition \"Ready\" to False\r\nI1012 12:51:32.081495      23 controller_binding.go:864] Setting lastTransitionTime for ServiceBinding \"demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\" condition \"Ready\" to 2017-10-12 12:51:32.081370476 +0000 UTC\r\nI1012 12:51:32.081552      23 controller_binding.go:892] Updating status for ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nI1012 12:51:32.206665      23 controller_binding.go:745] Creating/updating Secret demo-app/dh-rhscl-postgresql-apb-gv55h-credentials-m3189\r\nI1012 12:51:32.223444      23 controller_binding.go:853] Setting ServiceBinding 'demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf' condition \"Ready\" to True\r\nI1012 12:51:32.223566      23 controller_binding.go:873] Found status change for ServiceBinding \"demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\" condition \"Ready\": \"False\" -> \"True\"; setting lastTransitionTime to 2017-10-12 12:51:32.223431258 +0000 UTC\r\nI1012 12:51:32.223589      23 controller_binding.go:892] Updating status for ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nI1012 12:51:32.233964      23 controller_binding.go:540] Successfully bound to ServiceInstance demo-app/dh-rhscl-postgresql-apb-gv55h of ClusterServiceClass 27793015fe45db2fbc1deb7372cc4036 at ClusterServiceBroker ansible-service-broker\r\nI1012 12:51:32.234605      23 event.go:218] Event(v1.ObjectReference{Kind:\"ServiceBinding\", Namespace:\"demo-app\", Name:\"dh-rhscl-postgresql-apb-gv55h-f2wwf\", UID:\"12645727-af4c-11e7-9dec-0242ac110004\", APIVersion:\"servicecatalog.k8s.io\", ResourceVersion:\"79\", FieldPath:\"\"}): type: 'Normal' reason: 'InjectedBindResult' Injected bind result\r\nI1012 12:51:32.268551      23 controller_binding.go:161] Processing ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nI1012 12:51:32.275900      23 controller.go:388] Creating client for ClusterServiceBroker ansible-service-broker, URL: https://asb.ansible-service-broker.svc:1338/ansible-service-broker/\r\nI1012 12:51:32.276396      23 controller_binding.go:245] Adding/Updating ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nI1012 12:51:32.315919      23 controller_binding.go:745] Creating/updating Secret demo-app/dh-rhscl-postgresql-apb-gv55h-credentials-m3189\r\nI1012 12:51:32.321382      23 controller_binding.go:853] Setting ServiceBinding 'demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf' condition \"Ready\" to True\r\nI1012 12:51:32.321411      23 controller_binding.go:873] Found status change for ServiceBinding \"demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\" condition \"Ready\": \"False\" -> \"True\"; setting lastTransitionTime to 2017-10-12 12:51:32.321375303 +0000 UTC\r\nI1012 12:51:32.321428      23 controller_binding.go:892] Updating status for ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nE1012 12:51:32.324442      23 controller_binding.go:895] Error updating status for ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf\r\nI1012 12:51:32.324511      23 controller.go:232] Error syncing ServiceBinding demo-app/dh-rhscl-postgresql-apb-gv55h-f2wwf: Operation cannot be fulfilled on servicebindings.servicecatalog.k8s.io \"dh-rhscl-postgresql-apb-gv55h-f2wwf\": the object has been modified; please apply your changes to the latest version and try again\r\n```\r\n\r\nCreated secret:\r\n\r\n```yaml\r\napiVersion: v1\r\nkind: Secret\r\nmetadata:\r\n  creationTimestamp: 2017-10-12T12:51:32Z\r\n  name: dh-rhscl-postgresql-apb-gv55h-credentials-m3189\r\n  namespace: demo-app\r\n  ownerReferences:\r\n  - apiVersion: servicecatalog.k8s.io/v1beta1\r\n    blockOwnerDeletion: true\r\n    controller: true\r\n    kind: ServiceBinding\r\n    name: dh-rhscl-postgresql-apb-gv55h-f2wwf\r\n    uid: 12645727-af4c-11e7-9dec-0242ac110004\r\n  resourceVersion: \"2553\"\r\n  selfLink: /api/v1/namespaces/demo-app/secrets/dh-rhscl-postgresql-apb-gv55h-credentials-m3189\r\n  uid: 1294b04b-af4c-11e7-996c-c85b76064d75\r\ntype: Opaque\r\n```\r\n\r\nWe should make this easier to debug somehow, but should definitely not log the response body unless the user sets a special flag (ie, normal verbose flag for client should not log response body)."}}
{"actor":{"display_login":"kibbles-n-bytes"}}