{"action":"created","comment":{"url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/comments/148307850","pull_request_review_id":73529612,"id":148307850,"diff_hunk":"@@ -39,78 +39,73 @@ RegExpUtils =\n \n   # Test cases: https://regex101.com/r/pD7iS5/3\n   urlRegex: ({matchEntireString} = {}) ->\n-    commonTlds = ['com', 'org', 'edu', 'gov', 'uk', 'net', 'ca', 'de', 'jp', 'fr', 'au', 'us', 'ru', 'ch', 'it', 'nl', 'se', 'no', 'es', 'mil', 'ly', 'co', 'in', 'it', 'co\\.uk', 'info', 'biz', 'ai']\n+    commonTlds = ['com', 'org', 'edu', 'gov', 'uk', 'net', 'ca', 'de', 'jp', 'fr', 'au', 'us', 'ru', 'ch', 'it', 'nl', 'se', 'no', 'es', 'mil', 'ly', 'biz', 'ai', 'info', 'it', 'to', 'io', 'co', 'eu', 'aero', 'jobs', 'mobi', 'at', 'be', 'br', 'cn' ]\n \n     parts = [\n       '('\n-        # one of:\n+        # one of\n         '('\n-          # This OR block matches any TLD if the URL includes a scheme, and only\n-          # the top ten TLDs if the scheme is omitted.\n-          # YES - https://nylas.ai\n-          # YES - https://10.2.3.1\n-          # YES - nylas.com\n-          # NO  - nylas.ai\n+          # scheme, ala https://\n+          '([A-Za-z]{3,9}:(?:\\\\/\\\\/))?'\n+\n+          # username:password (optional)\n+          '(?:\\\\w+:\\\\w+@)?'\n+\n+          # one of:\n           '('\n-            # scheme, ala https:// (mandatory)\n-            '([A-Za-z]{3,9}:(?:\\\\/\\\\/))'\n \n-            # username:password (optional)\n-            '(?:[\\\\-;:&=\\\\+\\\\$,\\\\w]+@)?'\n+            # domain with common tld\n+            '(?:(?:[-\\\\w\\\\d{1-3}]+\\\\.)+(?:' + commonTlds.join('|') + '))'\n \n-            # one of:\n-            '('\n-              # domain with any tld","path":"packages/client-app/src/regexp-utils.coffee","position":36,"original_position":36,"commit_id":"ecb282a908626bf7af91db9d7efbec9a11bf33d5","original_commit_id":"ecb282a908626bf7af91db9d7efbec9a11bf33d5","user":{"login":"nirmit","id":431140,"avatar_url":"https://avatars0.githubusercontent.com/u/431140?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmit","html_url":"https://github.com/nirmit","followers_url":"https://api.github.com/users/nirmit/followers","following_url":"https://api.github.com/users/nirmit/following{/other_user}","gists_url":"https://api.github.com/users/nirmit/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmit/subscriptions","organizations_url":"https://api.github.com/users/nirmit/orgs","repos_url":"https://api.github.com/users/nirmit/repos","events_url":"https://api.github.com/users/nirmit/events{/privacy}","received_events_url":"https://api.github.com/users/nirmit/received_events","type":"User","site_admin":false},"body":"The reason I removed it was because `filename.js` would also appear as a valid domain if we keep it free.  Also, if people didn't put spaces after the periods in their sentences, we might incorrectly assume them as URLs.","created_at":"2017-11-01T16:18:54Z","updated_at":"2017-11-01T16:18:54Z","html_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/149#discussion_r148307850","pull_request_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/comments/148307850"},"html":{"href":"https://github.com/nylas-mail-lives/nylas-mail/pull/149#discussion_r148307850"},"pull_request":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149"}},"in_reply_to_id":148302356},"pull_request":{"url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149","id":150039592,"html_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/149","diff_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/149.diff","patch_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/149.patch","issue_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/149","number":149,"state":"open","locked":false,"title":"Fix url parsing","user":{"login":"nirmit","id":431140,"avatar_url":"https://avatars0.githubusercontent.com/u/431140?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmit","html_url":"https://github.com/nirmit","followers_url":"https://api.github.com/users/nirmit/followers","following_url":"https://api.github.com/users/nirmit/following{/other_user}","gists_url":"https://api.github.com/users/nirmit/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmit/subscriptions","organizations_url":"https://api.github.com/users/nirmit/orgs","repos_url":"https://api.github.com/users/nirmit/repos","events_url":"https://api.github.com/users/nirmit/events{/privacy}","received_events_url":"https://api.github.com/users/nirmit/received_events","type":"User","site_admin":false},"body":"Missing escapes resulted in incorrect regex being generated that caused issue #147. Tested via decaffienated.\r\n\r\nFixes #147 (references #148)","created_at":"2017-11-01T13:32:58Z","updated_at":"2017-11-01T16:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c072829e127c0acd4cb58e474aacfd04903df58","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149/commits","review_comments_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149/comments","review_comment_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/149/comments","statuses_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/statuses/ecb282a908626bf7af91db9d7efbec9a11bf33d5","head":{"label":"nirmit:fix-url-parsing","ref":"fix-url-parsing","sha":"ecb282a908626bf7af91db9d7efbec9a11bf33d5","user":{"login":"nirmit","id":431140,"avatar_url":"https://avatars0.githubusercontent.com/u/431140?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmit","html_url":"https://github.com/nirmit","followers_url":"https://api.github.com/users/nirmit/followers","following_url":"https://api.github.com/users/nirmit/following{/other_user}","gists_url":"https://api.github.com/users/nirmit/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmit/subscriptions","organizations_url":"https://api.github.com/users/nirmit/orgs","repos_url":"https://api.github.com/users/nirmit/repos","events_url":"https://api.github.com/users/nirmit/events{/privacy}","received_events_url":"https://api.github.com/users/nirmit/received_events","type":"User","site_admin":false},"repo":{"id":108356217,"name":"nylas-mail","full_name":"nirmit/nylas-mail","owner":{"login":"nirmit","id":431140,"avatar_url":"https://avatars0.githubusercontent.com/u/431140?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmit","html_url":"https://github.com/nirmit","followers_url":"https://api.github.com/users/nirmit/followers","following_url":"https://api.github.com/users/nirmit/following{/other_user}","gists_url":"https://api.github.com/users/nirmit/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmit/subscriptions","organizations_url":"https://api.github.com/users/nirmit/orgs","repos_url":"https://api.github.com/users/nirmit/repos","events_url":"https://api.github.com/users/nirmit/events{/privacy}","received_events_url":"https://api.github.com/users/nirmit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nirmit/nylas-mail","description":":love_letter: An extensible desktop mail app built on the modern web.","fork":true,"url":"https://api.github.com/repos/nirmit/nylas-mail","forks_url":"https://api.github.com/repos/nirmit/nylas-mail/forks","keys_url":"https://api.github.com/repos/nirmit/nylas-mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nirmit/nylas-mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nirmit/nylas-mail/teams","hooks_url":"https://api.github.com/repos/nirmit/nylas-mail/hooks","issue_events_url":"https://api.github.com/repos/nirmit/nylas-mail/issues/events{/number}","events_url":"https://api.github.com/repos/nirmit/nylas-mail/events","assignees_url":"https://api.github.com/repos/nirmit/nylas-mail/assignees{/user}","branches_url":"https://api.github.com/repos/nirmit/nylas-mail/branches{/branch}","tags_url":"https://api.github.com/repos/nirmit/nylas-mail/tags","blobs_url":"https://api.github.com/repos/nirmit/nylas-mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nirmit/nylas-mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nirmit/nylas-mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/nirmit/nylas-mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nirmit/nylas-mail/statuses/{sha}","languages_url":"https://api.github.com/repos/nirmit/nylas-mail/languages","stargazers_url":"https://api.github.com/repos/nirmit/nylas-mail/stargazers","contributors_url":"https://api.github.com/repos/nirmit/nylas-mail/contributors","subscribers_url":"https://api.github.com/repos/nirmit/nylas-mail/subscribers","subscription_url":"https://api.github.com/repos/nirmit/nylas-mail/subscription","commits_url":"https://api.github.com/repos/nirmit/nylas-mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/nirmit/nylas-mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/nirmit/nylas-mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/nirmit/nylas-mail/issues/comments{/number}","contents_url":"https://api.github.com/repos/nirmit/nylas-mail/contents/{+path}","compare_url":"https://api.github.com/repos/nirmit/nylas-mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nirmit/nylas-mail/merges","archive_url":"https://api.github.com/repos/nirmit/nylas-mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nirmit/nylas-mail/downloads","issues_url":"https://api.github.com/repos/nirmit/nylas-mail/issues{/number}","pulls_url":"https://api.github.com/repos/nirmit/nylas-mail/pulls{/number}","milestones_url":"https://api.github.com/repos/nirmit/nylas-mail/milestones{/number}","notifications_url":"https://api.github.com/repos/nirmit/nylas-mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nirmit/nylas-mail/labels{/name}","releases_url":"https://api.github.com/repos/nirmit/nylas-mail/releases{/id}","deployments_url":"https://api.github.com/repos/nirmit/nylas-mail/deployments","created_at":"2017-10-26T03:20:33Z","updated_at":"2017-10-26T03:20:41Z","pushed_at":"2017-11-01T13:31:42Z","git_url":"git://github.com/nirmit/nylas-mail.git","ssh_url":"git@github.com:nirmit/nylas-mail.git","clone_url":"https://github.com/nirmit/nylas-mail.git","svn_url":"https://github.com/nirmit/nylas-mail","homepage":"","size":89719,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nylas-mail-lives:master","ref":"master","sha":"ab07fcc6a048631c34bc0aeb845033da56965195","user":{"login":"nylas-mail-lives","id":28964600,"avatar_url":"https://avatars2.githubusercontent.com/u/28964600?v=4","gravatar_id":"","url":"https://api.github.com/users/nylas-mail-lives","html_url":"https://github.com/nylas-mail-lives","followers_url":"https://api.github.com/users/nylas-mail-lives/followers","following_url":"https://api.github.com/users/nylas-mail-lives/following{/other_user}","gists_url":"https://api.github.com/users/nylas-mail-lives/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas-mail-lives/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas-mail-lives/subscriptions","organizations_url":"https://api.github.com/users/nylas-mail-lives/orgs","repos_url":"https://api.github.com/users/nylas-mail-lives/repos","events_url":"https://api.github.com/users/nylas-mail-lives/events{/privacy}","received_events_url":"https://api.github.com/users/nylas-mail-lives/received_events","type":"Organization","site_admin":false},"repo":{"id":92449475,"name":"nylas-mail","full_name":"nylas-mail-lives/nylas-mail","owner":{"login":"nylas-mail-lives","id":28964600,"avatar_url":"https://avatars2.githubusercontent.com/u/28964600?v=4","gravatar_id":"","url":"https://api.github.com/users/nylas-mail-lives","html_url":"https://github.com/nylas-mail-lives","followers_url":"https://api.github.com/users/nylas-mail-lives/followers","following_url":"https://api.github.com/users/nylas-mail-lives/following{/other_user}","gists_url":"https://api.github.com/users/nylas-mail-lives/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas-mail-lives/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas-mail-lives/subscriptions","organizations_url":"https://api.github.com/users/nylas-mail-lives/orgs","repos_url":"https://api.github.com/users/nylas-mail-lives/repos","events_url":"https://api.github.com/users/nylas-mail-lives/events{/privacy}","received_events_url":"https://api.github.com/users/nylas-mail-lives/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nylas-mail-lives/nylas-mail","description":":love_letter: An extensible desktop mail app built on the modern web.","fork":false,"url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail","forks_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/forks","keys_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/teams","hooks_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/hooks","issue_events_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/events{/number}","events_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/events","assignees_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/assignees{/user}","branches_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/branches{/branch}","tags_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/tags","blobs_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/statuses/{sha}","languages_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/languages","stargazers_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/stargazers","contributors_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/contributors","subscribers_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/subscribers","subscription_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/subscription","commits_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/comments{/number}","contents_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/contents/{+path}","compare_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/merges","archive_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/downloads","issues_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues{/number}","pulls_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls{/number}","milestones_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/milestones{/number}","notifications_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/labels{/name}","releases_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/releases{/id}","deployments_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/deployments","created_at":"2017-05-25T22:27:43Z","updated_at":"2017-11-01T08:35:16Z","pushed_at":"2017-11-01T13:32:59Z","git_url":"git://github.com/nylas-mail-lives/nylas-mail.git","ssh_url":"git@github.com:nylas-mail-lives/nylas-mail.git","clone_url":"https://github.com/nylas-mail-lives/nylas-mail.git","svn_url":"https://github.com/nylas-mail-lives/nylas-mail","homepage":"","size":89685,"stargazers_count":288,"watchers_count":288,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":38,"forks":31,"open_issues":38,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149"},"html":{"href":"https://github.com/nylas-mail-lives/nylas-mail/pull/149"},"issue":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/149"},"comments":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/statuses/ecb282a908626bf7af91db9d7efbec9a11bf33d5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nirmit"}}