{"push_id":2066474683,"size":1,"distinct_size":1,"ref":"refs/heads/32609_defreference_voldriver_on_error","head":"e043e017d6263be41f64e631771b97d0fe00c04c","before":"c053400010478ad7972bd35dbe5a0921a0f415c7","commits":[{"sha":"e043e017d6263be41f64e631771b97d0fe00c04c","author":{"name":"Brian Goff","email":"7c85cf8ae7443f547a26fb59a1f52171e1274aa1@gmail.com"},"message":"Fixup some issues with plugin refcounting\n\nIn some circumstances we were not properly releasing plugin references,\nleading to failures in removing a plugin with no way to recover other\nthan restarting the daemon.\n\n1. If volume create fails (in the driver)\n2. If a driver validation fails (should be rare)\n3. If trying to get a plugin that does not match the passed in capability\n\nIdeally the test for 1 and 2 would just be a unit test, however the\nplugin interfaces are too complicated as `plugingetter` relies on\ngithub.com/pkg/plugin/Client (a concrete type), which will require\nspinning up services from within the unit test... it just wouldn't be a\nunit test at this point.\nI attempted to refactor this a bit, but since both libnetwork and\nswarmkit are reliant on `plugingetter` as well, this would not work.\nThis really requires a re-write of the lower-level plugin management to\ndecouple these pieces.\n\nSigned-off-by: Brian Goff <cpuguy83@gmail.com>","distinct":true,"url":"https://api.github.com/repos/cpuguy83/docker/commits/e043e017d6263be41f64e631771b97d0fe00c04c"}]}
{"actor":{"display_login":"cpuguy83"}}