{"action":"closed","issue":{"url":"https://api.github.com/repos/Overv/VulkanTutorial/issues/60","repository_url":"https://api.github.com/repos/Overv/VulkanTutorial","labels_url":"https://api.github.com/repos/Overv/VulkanTutorial/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/Overv/VulkanTutorial/issues/60/comments","events_url":"https://api.github.com/repos/Overv/VulkanTutorial/issues/60/events","html_url":"https://github.com/Overv/VulkanTutorial/issues/60","id":249778589,"number":60,"title":"transitionImageLayout function doesn't follow the spec","user":{"login":"vazgriz","id":7607513,"avatar_url":"https://avatars0.githubusercontent.com/u/7607513?v=4","gravatar_id":"","url":"https://api.github.com/users/vazgriz","html_url":"https://github.com/vazgriz","followers_url":"https://api.github.com/users/vazgriz/followers","following_url":"https://api.github.com/users/vazgriz/following{/other_user}","gists_url":"https://api.github.com/users/vazgriz/gists{/gist_id}","starred_url":"https://api.github.com/users/vazgriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vazgriz/subscriptions","organizations_url":"https://api.github.com/users/vazgriz/orgs","repos_url":"https://api.github.com/users/vazgriz/repos","events_url":"https://api.github.com/users/vazgriz/events{/privacy}","received_events_url":"https://api.github.com/users/vazgriz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"Overv","id":285063,"avatar_url":"https://avatars3.githubusercontent.com/u/285063?v=4","gravatar_id":"","url":"https://api.github.com/users/Overv","html_url":"https://github.com/Overv","followers_url":"https://api.github.com/users/Overv/followers","following_url":"https://api.github.com/users/Overv/following{/other_user}","gists_url":"https://api.github.com/users/Overv/gists{/gist_id}","starred_url":"https://api.github.com/users/Overv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Overv/subscriptions","organizations_url":"https://api.github.com/users/Overv/orgs","repos_url":"https://api.github.com/users/Overv/repos","events_url":"https://api.github.com/users/Overv/events{/privacy}","received_events_url":"https://api.github.com/users/Overv/received_events","type":"User","site_admin":false},"assignees":[{"login":"Overv","id":285063,"avatar_url":"https://avatars3.githubusercontent.com/u/285063?v=4","gravatar_id":"","url":"https://api.github.com/users/Overv","html_url":"https://github.com/Overv","followers_url":"https://api.github.com/users/Overv/followers","following_url":"https://api.github.com/users/Overv/following{/other_user}","gists_url":"https://api.github.com/users/Overv/gists{/gist_id}","starred_url":"https://api.github.com/users/Overv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Overv/subscriptions","organizations_url":"https://api.github.com/users/Overv/orgs","repos_url":"https://api.github.com/users/Overv/repos","events_url":"https://api.github.com/users/Overv/events{/privacy}","received_events_url":"https://api.github.com/users/Overv/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-08-12T01:05:52Z","updated_at":"2017-08-15T19:27:12Z","closed_at":"2017-08-15T19:27:12Z","body":"The table in Section 6.1.3, specifies what pipeline stage each access mask can be accessed in. For example, when `dstAccessMask` is `VK_ACCESS_TRANSFER_WRITE_BIT`, `dstStageMask` must be `VK_PIPELINE_STAGE_TRANSFER_BIT`. The current function always uses `VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT` for the source and dest stage.\r\n\r\nThe easiest way to correct this would be choosing the source and dest stages alongside the access masks\r\n\r\n```\r\nVkPipelineStageFlags source;\r\nVkPipelineStageFlags dest;\r\n\r\nif (oldLayout == VK_IMAGE_LAYOUT_UNDEFINED && newLayout == VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) {\r\n    barrier.srcAccessMask = 0;\r\n    barrier.dstAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT;\r\n\r\n    source = VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT;\r\n    dest = VK_PIPELINE_STAGE_TRANSFER_BIT;\r\n}\r\n\r\n...\r\n\r\nvkCmdPipelineBarrier(\r\n    commandBuffer,\r\n    source, dest,\r\n    0,\r\n    0, nullptr,\r\n    0, nullptr,\r\n    1, &barrier\r\n);\r\n```"}}
{"actor":{"display_login":"Overv"}}