{"action":"created","issue":{"url":"https://api.github.com/repos/iheartradio/play-swagger/issues/170","repository_url":"https://api.github.com/repos/iheartradio/play-swagger","labels_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/170/comments","events_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/170/events","html_url":"https://github.com/iheartradio/play-swagger/pull/170","id":245121895,"number":170,"title":"Add capability of mapping types to some optional type…","user":{"login":"asan","id":154874,"avatar_url":"https://avatars3.githubusercontent.com/u/154874?v=4","gravatar_id":"","url":"https://api.github.com/users/asan","html_url":"https://github.com/asan","followers_url":"https://api.github.com/users/asan/followers","following_url":"https://api.github.com/users/asan/following{/other_user}","gists_url":"https://api.github.com/users/asan/gists{/gist_id}","starred_url":"https://api.github.com/users/asan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asan/subscriptions","organizations_url":"https://api.github.com/users/asan/orgs","repos_url":"https://api.github.com/users/asan/repos","events_url":"https://api.github.com/users/asan/events{/privacy}","received_events_url":"https://api.github.com/users/asan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-24T15:40:04Z","updated_at":"2017-07-24T15:46:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/170","html_url":"https://github.com/iheartradio/play-swagger/pull/170","diff_url":"https://github.com/iheartradio/play-swagger/pull/170.diff","patch_url":"https://github.com/iheartradio/play-swagger/pull/170.patch"},"body":"… in swagger-custom-mappings.yml\r\nI'm looking for some way to map custom type to optional param in documentation(for example i have `option[string with shapeless.tag.tagged]` which i want to map to `option[string]`) but i can't find any way to express it in yml.\r\nSo this PR adds optional param required(default true, so it backword compatable) in type mapping.\r\nExample:\r\n```yml\r\n---\r\n  - type: option\\[string with shapeless\\.tag\\.tagged\\]\r\n    required: false\r\n    specAsParameter:\r\n      - type: string\r\n```\r\nthis maps `option[string with shapeless.tag.tagged]` to `option[string]`\r\n\r\nPS: in play 2.6 branch it possible to use:\r\n```scala\r\n implicit val csmFormat = Json.using[Json.WithDefaultValues].reads[CustomTypeMapping]\r\n```\r\ninstead of creating Reads by hand"},"comment":{"url":"https://api.github.com/repos/iheartradio/play-swagger/issues/comments/317465203","html_url":"https://github.com/iheartradio/play-swagger/pull/170#issuecomment-317465203","issue_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/170","id":317465203,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-07-24T15:46:03Z","updated_at":"2017-07-24T15:46:03Z","body":"\n[![Coverage Status](https://coveralls.io/builds/12524123/badge)](https://coveralls.io/builds/12524123)\n\nCoverage decreased (-0.5%) to 89.72% when pulling **c1f2c20a491a71a832400ace44a979e36262cb82 on asan:feature-type-maps-to-optional** into **a49b9f7f081c7237547e1f9228cb78ff12d72a05 on iheartradio:master**.\n"}}
{"actor":{"display_login":"coveralls"}}