{"action":"closed","number":80,"pull_request":{"url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/80","id":104896819,"html_url":"https://github.com/eclipse/paho.mqtt.embedded-c/pull/80","diff_url":"https://github.com/eclipse/paho.mqtt.embedded-c/pull/80.diff","patch_url":"https://github.com/eclipse/paho.mqtt.embedded-c/pull/80.patch","issue_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/issues/80","number":80,"state":"closed","locked":false,"title":"Bugfix/keepalive check","user":{"login":"sshtel","id":4931557,"avatar_url":"https://avatars.githubusercontent.com/u/4931557?v=3","gravatar_id":"","url":"https://api.github.com/users/sshtel","html_url":"https://github.com/sshtel","followers_url":"https://api.github.com/users/sshtel/followers","following_url":"https://api.github.com/users/sshtel/following{/other_user}","gists_url":"https://api.github.com/users/sshtel/gists{/gist_id}","starred_url":"https://api.github.com/users/sshtel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshtel/subscriptions","organizations_url":"https://api.github.com/users/sshtel/orgs","repos_url":"https://api.github.com/users/sshtel/repos","events_url":"https://api.github.com/users/sshtel/events{/privacy}","received_events_url":"https://api.github.com/users/sshtel/received_events","type":"User","site_admin":false},"body":"In cycle() of MQTTClient.c, there is a function call to check keepalive message.\r\nAlthough keepalive time is expired, its status is not being checked and still cycle() returns SUCCESS\r\n\r\nhttps://github.com/eclipse/paho.mqtt.embedded-c/blob/master/MQTTClient-C/src/MQTTClient.c#L282","created_at":"2017-02-06T22:30:43Z","updated_at":"2017-02-06T22:33:46Z","closed_at":"2017-02-06T22:33:46Z","merged_at":null,"merge_commit_sha":"bcc4201aa8d9feeb918a7f5aa1da221eda396bc1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/80/commits","review_comments_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/80/comments","review_comment_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/issues/80/comments","statuses_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/statuses/b92465d29d19a568cf95f980deb52733479dc9fd","head":{"label":"sshtel:bugfix/keepalive-check","ref":"bugfix/keepalive-check","sha":"b92465d29d19a568cf95f980deb52733479dc9fd","user":{"login":"sshtel","id":4931557,"avatar_url":"https://avatars.githubusercontent.com/u/4931557?v=3","gravatar_id":"","url":"https://api.github.com/users/sshtel","html_url":"https://github.com/sshtel","followers_url":"https://api.github.com/users/sshtel/followers","following_url":"https://api.github.com/users/sshtel/following{/other_user}","gists_url":"https://api.github.com/users/sshtel/gists{/gist_id}","starred_url":"https://api.github.com/users/sshtel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshtel/subscriptions","organizations_url":"https://api.github.com/users/sshtel/orgs","repos_url":"https://api.github.com/users/sshtel/repos","events_url":"https://api.github.com/users/sshtel/events{/privacy}","received_events_url":"https://api.github.com/users/sshtel/received_events","type":"User","site_admin":false},"repo":{"id":74098524,"name":"paho.mqtt.embedded-c","full_name":"sshtel/paho.mqtt.embedded-c","owner":{"login":"sshtel","id":4931557,"avatar_url":"https://avatars.githubusercontent.com/u/4931557?v=3","gravatar_id":"","url":"https://api.github.com/users/sshtel","html_url":"https://github.com/sshtel","followers_url":"https://api.github.com/users/sshtel/followers","following_url":"https://api.github.com/users/sshtel/following{/other_user}","gists_url":"https://api.github.com/users/sshtel/gists{/gist_id}","starred_url":"https://api.github.com/users/sshtel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshtel/subscriptions","organizations_url":"https://api.github.com/users/sshtel/orgs","repos_url":"https://api.github.com/users/sshtel/repos","events_url":"https://api.github.com/users/sshtel/events{/privacy}","received_events_url":"https://api.github.com/users/sshtel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sshtel/paho.mqtt.embedded-c","description":"paho.mqtt.embedded-c","fork":true,"url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c","forks_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/forks","keys_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/teams","hooks_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/hooks","issue_events_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/issues/events{/number}","events_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/events","assignees_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/assignees{/user}","branches_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/branches{/branch}","tags_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/tags","blobs_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/statuses/{sha}","languages_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/languages","stargazers_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/stargazers","contributors_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/contributors","subscribers_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/subscribers","subscription_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/subscription","commits_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/contents/{+path}","compare_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/merges","archive_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/downloads","issues_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/issues{/number}","pulls_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/pulls{/number}","milestones_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/milestones{/number}","notifications_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/labels{/name}","releases_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/releases{/id}","deployments_url":"https://api.github.com/repos/sshtel/paho.mqtt.embedded-c/deployments","created_at":"2016-11-18T05:35:00Z","updated_at":"2016-11-18T05:35:02Z","pushed_at":"2017-02-06T22:29:34Z","git_url":"git://github.com/sshtel/paho.mqtt.embedded-c.git","ssh_url":"git@github.com:sshtel/paho.mqtt.embedded-c.git","clone_url":"https://github.com/sshtel/paho.mqtt.embedded-c.git","svn_url":"https://github.com/sshtel/paho.mqtt.embedded-c","homepage":null,"size":223,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"f834fae3d0bb4515c536851536cbe6b5f6f3d1ef","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":48129848,"name":"paho.mqtt.embedded-c","full_name":"eclipse/paho.mqtt.embedded-c","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/paho.mqtt.embedded-c","description":"paho.mqtt.embedded-c","fork":false,"url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c","forks_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/forks","keys_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/teams","hooks_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/hooks","issue_events_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/events","assignees_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/tags","blobs_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/languages","stargazers_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/stargazers","contributors_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/contributors","subscribers_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/subscribers","subscription_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/subscription","commits_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/merges","archive_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/downloads","issues_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/deployments","created_at":"2015-12-16T19:14:15Z","updated_at":"2017-01-26T12:33:57Z","pushed_at":"2017-02-06T22:30:44Z","git_url":"git://github.com/eclipse/paho.mqtt.embedded-c.git","ssh_url":"git@github.com:eclipse/paho.mqtt.embedded-c.git","clone_url":"https://github.com/eclipse/paho.mqtt.embedded-c.git","svn_url":"https://github.com/eclipse/paho.mqtt.embedded-c","homepage":null,"size":268,"stargazers_count":82,"watchers_count":82,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":41,"forks":69,"open_issues":41,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/80"},"html":{"href":"https://github.com/eclipse/paho.mqtt.embedded-c/pull/80"},"issue":{"href":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/issues/80"},"comments":{"href":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/paho.mqtt.embedded-c/statuses/b92465d29d19a568cf95f980deb52733479dc9fd"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":28,"deletions":14,"changed_files":6}}
{"actor":{"display_login":"sshtel"}}