{"action":"created","issue":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/5669","repository_url":"https://api.github.com/repos/bokeh/bokeh","labels_url":"https://api.github.com/repos/bokeh/bokeh/issues/5669/labels{/name}","comments_url":"https://api.github.com/repos/bokeh/bokeh/issues/5669/comments","events_url":"https://api.github.com/repos/bokeh/bokeh/issues/5669/events","html_url":"https://github.com/bokeh/bokeh/pull/5669","id":199385704,"number":5669,"title":"fix Rect rendering with log axis","user":{"login":"clairetang6","id":4241244,"avatar_url":"https://avatars.githubusercontent.com/u/4241244?v=3","gravatar_id":"","url":"https://api.github.com/users/clairetang6","html_url":"https://github.com/clairetang6","followers_url":"https://api.github.com/users/clairetang6/followers","following_url":"https://api.github.com/users/clairetang6/following{/other_user}","gists_url":"https://api.github.com/users/clairetang6/gists{/gist_id}","starred_url":"https://api.github.com/users/clairetang6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clairetang6/subscriptions","organizations_url":"https://api.github.com/users/clairetang6/orgs","repos_url":"https://api.github.com/users/clairetang6/repos","events_url":"https://api.github.com/users/clairetang6/events{/privacy}","received_events_url":"https://api.github.com/users/clairetang6/received_events","type":"User","site_admin":false},"labels":[{"id":88661915,"url":"https://api.github.com/repos/bokeh/bokeh/labels/status:%20WIP","name":"status: WIP","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-01-07T21:18:04Z","updated_at":"2017-01-12T02:27:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bokeh/bokeh/pulls/5669","html_url":"https://github.com/bokeh/bokeh/pull/5669","diff_url":"https://github.com/bokeh/bokeh/pull/5669.diff","patch_url":"https://github.com/bokeh/bokeh/pull/5669.patch"},"body":"This PR is to make the Rect glyph behave better when used with log axes. \r\n\r\nPreviously, Rect rendering relied on mapping the center point (x, y) to screen space and then rendering a rectangle with the top left corner point (sx - sw/2, sy - sh/2) and a width and height of sw and sh (mapped from w, h). This is a problem for log axis where the center point of the rectangle is not exactly in the center in screen space. \r\n\r\nThis PR fixes this by computing the top left corner point in data space, then mapping that point to screen space, and using that mapped point for rendering.\r\n\r\nI added some tests, but then realized we need a screenshot test here. Also, hit-testing is not working exactly right yet (because it also uses sw/2 and sh/2). \r\n\r\n- [x] issues: fixes #5336\r\n- [ ] tests added / passed\r\n~~- [ ] release document entry (if new feature or API change)~~\r\n- [ ] fix hit-testing for log axis\r\n"},"comment":{"url":"https://api.github.com/repos/bokeh/bokeh/issues/comments/272058527","html_url":"https://github.com/bokeh/bokeh/pull/5669#issuecomment-272058527","issue_url":"https://api.github.com/repos/bokeh/bokeh/issues/5669","id":272058527,"user":{"login":"clairetang6","id":4241244,"avatar_url":"https://avatars.githubusercontent.com/u/4241244?v=3","gravatar_id":"","url":"https://api.github.com/users/clairetang6","html_url":"https://github.com/clairetang6","followers_url":"https://api.github.com/users/clairetang6/followers","following_url":"https://api.github.com/users/clairetang6/following{/other_user}","gists_url":"https://api.github.com/users/clairetang6/gists{/gist_id}","starred_url":"https://api.github.com/users/clairetang6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clairetang6/subscriptions","organizations_url":"https://api.github.com/users/clairetang6/orgs","repos_url":"https://api.github.com/users/clairetang6/repos","events_url":"https://api.github.com/users/clairetang6/events{/privacy}","received_events_url":"https://api.github.com/users/clairetang6/received_events","type":"User","site_admin":false},"created_at":"2017-01-12T02:27:47Z","updated_at":"2017-01-12T02:27:47Z","body":"@mattpap, Thanks for the tip! That will be useful. \r\n\r\nI'm planning to add a log hit-testing test like the one I added for regular hit-testing, but the rendering test should be a screenshot test. @bryevdv, Looking at the documentation, it looks like I need SAUCELABS_USERNAME and SAUCELABS_API_KEY? I haven't ever run any screenshot tests."}}
{"actor":{"display_login":"clairetang6"}}