{"action":"created","comment":{"url":"https://api.github.com/repos/linaro-swg/linux/pulls/comments/126675956","pull_request_review_id":49177509,"id":126675956,"diff_hunk":"@@ -393,7 +459,11 @@ optee_config_shm_memremap(optee_invoke_fn *invoke_fn, void **memremaped_shm)\n \tdmabuf_info.paddr = paddr + OPTEE_SHM_NUM_PRIV_PAGES * PAGE_SIZE;\n \tdmabuf_info.size = size - OPTEE_SHM_NUM_PRIV_PAGES * PAGE_SIZE;\n \n-\tpool = tee_shm_pool_alloc_res_mem(&priv_info, &dmabuf_info);\n+\t/* If OP-TEE can work with unregistered SHM, we will use own pool */\n+\tif (sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)\n+\t\tpool = optee_shm_get_pool(&dmabuf_info);","path":"drivers/tee/optee/core.c","position":195,"original_position":195,"commit_id":"9e1e7b2fca687d51a549c46135098c86d8ff74f7","original_commit_id":"9e1e7b2fca687d51a549c46135098c86d8ff74f7","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars3.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"We don't need this new \"own pool\" just because OP-TEE can work with unregistered shared memory.\r\nI'd rather remove it from this pull request.","created_at":"2017-07-11T12:40:21Z","updated_at":"2017-07-11T12:58:35Z","html_url":"https://github.com/linaro-swg/linux/pull/29#discussion_r126675956","pull_request_url":"https://api.github.com/repos/linaro-swg/linux/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/linaro-swg/linux/pulls/comments/126675956"},"html":{"href":"https://github.com/linaro-swg/linux/pull/29#discussion_r126675956"},"pull_request":{"href":"https://api.github.com/repos/linaro-swg/linux/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/linaro-swg/linux/pulls/29","id":97816337,"html_url":"https://github.com/linaro-swg/linux/pull/29","diff_url":"https://github.com/linaro-swg/linux/pull/29.diff","patch_url":"https://github.com/linaro-swg/linux/pull/29.patch","issue_url":"https://api.github.com/repos/linaro-swg/linux/issues/29","number":29,"state":"open","locked":false,"title":"New OP-TEE SHM design.","user":{"login":"lorc","id":240174,"avatar_url":"https://avatars1.githubusercontent.com/u/240174?v=3","gravatar_id":"","url":"https://api.github.com/users/lorc","html_url":"https://github.com/lorc","followers_url":"https://api.github.com/users/lorc/followers","following_url":"https://api.github.com/users/lorc/following{/other_user}","gists_url":"https://api.github.com/users/lorc/gists{/gist_id}","starred_url":"https://api.github.com/users/lorc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorc/subscriptions","organizations_url":"https://api.github.com/users/lorc/orgs","repos_url":"https://api.github.com/users/lorc/repos","events_url":"https://api.github.com/users/lorc/events{/privacy}","received_events_url":"https://api.github.com/users/lorc/received_events","type":"User","site_admin":false},"body":"Those patches are kernel driver part of dynamic shared memory in OP-TEE (refer to https://github.com/OP-TEE/optee_os/pull/1232). Two of those patches are authored by @jenswi-linaro, I just tidied it a bit and rebased on current master.\r\n\r\nThis patches provide new ioctl to userpace along with support in tee_shm and op-tee kernel part. This ioctl allows userspace process to share own memory with OP-TEE. \r\n\r\nAnother part - is OP-TEE specific SHM pool that uses kernel memory. With this approach we don't rely on OP-TEE predefined pool.","created_at":"2016-12-13T19:16:36Z","updated_at":"2017-07-11T12:58:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd3fbb5bac05cfb5633a021693b2fa50e7ea3e4b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linaro-swg/linux/pulls/29/commits","review_comments_url":"https://api.github.com/repos/linaro-swg/linux/pulls/29/comments","review_comment_url":"https://api.github.com/repos/linaro-swg/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linaro-swg/linux/issues/29/comments","statuses_url":"https://api.github.com/repos/linaro-swg/linux/statuses/9e1e7b2fca687d51a549c46135098c86d8ff74f7","head":{"label":"lorc:new_shm_rel","ref":"new_shm_rel","sha":"9e1e7b2fca687d51a549c46135098c86d8ff74f7","user":{"login":"lorc","id":240174,"avatar_url":"https://avatars1.githubusercontent.com/u/240174?v=3","gravatar_id":"","url":"https://api.github.com/users/lorc","html_url":"https://github.com/lorc","followers_url":"https://api.github.com/users/lorc/followers","following_url":"https://api.github.com/users/lorc/following{/other_user}","gists_url":"https://api.github.com/users/lorc/gists{/gist_id}","starred_url":"https://api.github.com/users/lorc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorc/subscriptions","organizations_url":"https://api.github.com/users/lorc/orgs","repos_url":"https://api.github.com/users/lorc/repos","events_url":"https://api.github.com/users/lorc/events{/privacy}","received_events_url":"https://api.github.com/users/lorc/received_events","type":"User","site_admin":false},"repo":{"id":71925784,"name":"linux","full_name":"lorc/linux","owner":{"login":"lorc","id":240174,"avatar_url":"https://avatars1.githubusercontent.com/u/240174?v=3","gravatar_id":"","url":"https://api.github.com/users/lorc","html_url":"https://github.com/lorc","followers_url":"https://api.github.com/users/lorc/followers","following_url":"https://api.github.com/users/lorc/following{/other_user}","gists_url":"https://api.github.com/users/lorc/gists{/gist_id}","starred_url":"https://api.github.com/users/lorc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorc/subscriptions","organizations_url":"https://api.github.com/users/lorc/orgs","repos_url":"https://api.github.com/users/lorc/repos","events_url":"https://api.github.com/users/lorc/events{/privacy}","received_events_url":"https://api.github.com/users/lorc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorc/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/lorc/linux","forks_url":"https://api.github.com/repos/lorc/linux/forks","keys_url":"https://api.github.com/repos/lorc/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorc/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorc/linux/teams","hooks_url":"https://api.github.com/repos/lorc/linux/hooks","issue_events_url":"https://api.github.com/repos/lorc/linux/issues/events{/number}","events_url":"https://api.github.com/repos/lorc/linux/events","assignees_url":"https://api.github.com/repos/lorc/linux/assignees{/user}","branches_url":"https://api.github.com/repos/lorc/linux/branches{/branch}","tags_url":"https://api.github.com/repos/lorc/linux/tags","blobs_url":"https://api.github.com/repos/lorc/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorc/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorc/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorc/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorc/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/lorc/linux/languages","stargazers_url":"https://api.github.com/repos/lorc/linux/stargazers","contributors_url":"https://api.github.com/repos/lorc/linux/contributors","subscribers_url":"https://api.github.com/repos/lorc/linux/subscribers","subscription_url":"https://api.github.com/repos/lorc/linux/subscription","commits_url":"https://api.github.com/repos/lorc/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorc/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorc/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorc/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorc/linux/contents/{+path}","compare_url":"https://api.github.com/repos/lorc/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorc/linux/merges","archive_url":"https://api.github.com/repos/lorc/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorc/linux/downloads","issues_url":"https://api.github.com/repos/lorc/linux/issues{/number}","pulls_url":"https://api.github.com/repos/lorc/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/lorc/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/lorc/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorc/linux/labels{/name}","releases_url":"https://api.github.com/repos/lorc/linux/releases{/id}","deployments_url":"https://api.github.com/repos/lorc/linux/deployments","created_at":"2016-10-25T18:15:06Z","updated_at":"2016-10-25T18:21:09Z","pushed_at":"2017-07-06T13:46:08Z","git_url":"git://github.com/lorc/linux.git","ssh_url":"git@github.com:lorc/linux.git","clone_url":"https://github.com/lorc/linux.git","svn_url":"https://github.com/lorc/linux","homepage":"","size":1726984,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linaro-swg:optee","ref":"optee","sha":"2e26af92fd860371fd65a2c16306cce4508285a1","user":{"login":"linaro-swg","id":12713002,"avatar_url":"https://avatars0.githubusercontent.com/u/12713002?v=3","gravatar_id":"","url":"https://api.github.com/users/linaro-swg","html_url":"https://github.com/linaro-swg","followers_url":"https://api.github.com/users/linaro-swg/followers","following_url":"https://api.github.com/users/linaro-swg/following{/other_user}","gists_url":"https://api.github.com/users/linaro-swg/gists{/gist_id}","starred_url":"https://api.github.com/users/linaro-swg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linaro-swg/subscriptions","organizations_url":"https://api.github.com/users/linaro-swg/orgs","repos_url":"https://api.github.com/users/linaro-swg/repos","events_url":"https://api.github.com/users/linaro-swg/events{/privacy}","received_events_url":"https://api.github.com/users/linaro-swg/received_events","type":"Organization","site_admin":false},"repo":{"id":37141512,"name":"linux","full_name":"linaro-swg/linux","owner":{"login":"linaro-swg","id":12713002,"avatar_url":"https://avatars0.githubusercontent.com/u/12713002?v=3","gravatar_id":"","url":"https://api.github.com/users/linaro-swg","html_url":"https://github.com/linaro-swg","followers_url":"https://api.github.com/users/linaro-swg/followers","following_url":"https://api.github.com/users/linaro-swg/following{/other_user}","gists_url":"https://api.github.com/users/linaro-swg/gists{/gist_id}","starred_url":"https://api.github.com/users/linaro-swg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linaro-swg/subscriptions","organizations_url":"https://api.github.com/users/linaro-swg/orgs","repos_url":"https://api.github.com/users/linaro-swg/repos","events_url":"https://api.github.com/users/linaro-swg/events{/privacy}","received_events_url":"https://api.github.com/users/linaro-swg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linaro-swg/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/linaro-swg/linux","forks_url":"https://api.github.com/repos/linaro-swg/linux/forks","keys_url":"https://api.github.com/repos/linaro-swg/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linaro-swg/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linaro-swg/linux/teams","hooks_url":"https://api.github.com/repos/linaro-swg/linux/hooks","issue_events_url":"https://api.github.com/repos/linaro-swg/linux/issues/events{/number}","events_url":"https://api.github.com/repos/linaro-swg/linux/events","assignees_url":"https://api.github.com/repos/linaro-swg/linux/assignees{/user}","branches_url":"https://api.github.com/repos/linaro-swg/linux/branches{/branch}","tags_url":"https://api.github.com/repos/linaro-swg/linux/tags","blobs_url":"https://api.github.com/repos/linaro-swg/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linaro-swg/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linaro-swg/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/linaro-swg/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linaro-swg/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/linaro-swg/linux/languages","stargazers_url":"https://api.github.com/repos/linaro-swg/linux/stargazers","contributors_url":"https://api.github.com/repos/linaro-swg/linux/contributors","subscribers_url":"https://api.github.com/repos/linaro-swg/linux/subscribers","subscription_url":"https://api.github.com/repos/linaro-swg/linux/subscription","commits_url":"https://api.github.com/repos/linaro-swg/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/linaro-swg/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/linaro-swg/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/linaro-swg/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/linaro-swg/linux/contents/{+path}","compare_url":"https://api.github.com/repos/linaro-swg/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linaro-swg/linux/merges","archive_url":"https://api.github.com/repos/linaro-swg/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linaro-swg/linux/downloads","issues_url":"https://api.github.com/repos/linaro-swg/linux/issues{/number}","pulls_url":"https://api.github.com/repos/linaro-swg/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/linaro-swg/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/linaro-swg/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linaro-swg/linux/labels{/name}","releases_url":"https://api.github.com/repos/linaro-swg/linux/releases{/id}","deployments_url":"https://api.github.com/repos/linaro-swg/linux/deployments","created_at":"2015-06-09T15:41:39Z","updated_at":"2017-06-23T01:04:19Z","pushed_at":"2017-07-07T16:49:35Z","git_url":"git://github.com/linaro-swg/linux.git","ssh_url":"git@github.com:linaro-swg/linux.git","clone_url":"https://github.com/linaro-swg/linux.git","svn_url":"https://github.com/linaro-swg/linux","homepage":"","size":1760810,"stargazers_count":9,"watchers_count":9,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":3,"forks":18,"open_issues":3,"watchers":9,"default_branch":"optee"}},"_links":{"self":{"href":"https://api.github.com/repos/linaro-swg/linux/pulls/29"},"html":{"href":"https://github.com/linaro-swg/linux/pull/29"},"issue":{"href":"https://api.github.com/repos/linaro-swg/linux/issues/29"},"comments":{"href":"https://api.github.com/repos/linaro-swg/linux/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/linaro-swg/linux/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/linaro-swg/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linaro-swg/linux/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/linaro-swg/linux/statuses/9e1e7b2fca687d51a549c46135098c86d8ff74f7"}}}}
{"actor":{"display_login":"jenswi-linaro"}}