{"action":"created","issue":{"url":"https://api.github.com/repos/blainekasten/enzyme-matchers/issues/56","repository_url":"https://api.github.com/repos/blainekasten/enzyme-matchers","labels_url":"https://api.github.com/repos/blainekasten/enzyme-matchers/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/blainekasten/enzyme-matchers/issues/56/comments","events_url":"https://api.github.com/repos/blainekasten/enzyme-matchers/issues/56/events","html_url":"https://github.com/blainekasten/enzyme-matchers/pull/56","id":202157934,"number":56,"title":"Add toMatchSnapshot as an override matcher","user":{"login":"blainekasten","id":2916023,"avatar_url":"https://avatars.githubusercontent.com/u/2916023?v=3","gravatar_id":"","url":"https://api.github.com/users/blainekasten","html_url":"https://github.com/blainekasten","followers_url":"https://api.github.com/users/blainekasten/followers","following_url":"https://api.github.com/users/blainekasten/following{/other_user}","gists_url":"https://api.github.com/users/blainekasten/gists{/gist_id}","starred_url":"https://api.github.com/users/blainekasten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blainekasten/subscriptions","organizations_url":"https://api.github.com/users/blainekasten/orgs","repos_url":"https://api.github.com/users/blainekasten/repos","events_url":"https://api.github.com/users/blainekasten/events{/privacy}","received_events_url":"https://api.github.com/users/blainekasten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-20T14:48:20Z","updated_at":"2017-01-20T17:54:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/blainekasten/enzyme-matchers/pulls/56","html_url":"https://github.com/blainekasten/enzyme-matchers/pull/56","diff_url":"https://github.com/blainekasten/enzyme-matchers/pull/56.diff","patch_url":"https://github.com/blainekasten/enzyme-matchers/pull/56.patch"},"body":"Resolve #45 \r\n\r\nThe concept here is to override jests `toMatchSnapshot` matcher when an enzyme wrapper is given to it. The hope here is that Enzyme is easily compatible and stable with use of `toMatchSnapshot`. Currently people either have to pass the enzyme object to the matcher (which is terrible) or they have to use react-test-utils, which isn't ideal when someone is bought into Enzyme.\r\n\r\nThe current implementation has me a bit worried though. We're currently depending on a global state from jest that isn't publically supported. I'm also a bit worried that enzyme-to-json isn't the right solution.\r\n\r\nI would love some feedback from those who are involved with these projects what they think of this.\r\n\r\ncc @cpojer @dmitriiabramov @aweary @lelandrichardson"},"comment":{"url":"https://api.github.com/repos/blainekasten/enzyme-matchers/issues/comments/274135922","html_url":"https://github.com/blainekasten/enzyme-matchers/pull/56#issuecomment-274135922","issue_url":"https://api.github.com/repos/blainekasten/enzyme-matchers/issues/56","id":274135922,"user":{"login":"dmitriiabramov","id":940133,"avatar_url":"https://avatars.githubusercontent.com/u/940133?v=3","gravatar_id":"","url":"https://api.github.com/users/dmitriiabramov","html_url":"https://github.com/dmitriiabramov","followers_url":"https://api.github.com/users/dmitriiabramov/followers","following_url":"https://api.github.com/users/dmitriiabramov/following{/other_user}","gists_url":"https://api.github.com/users/dmitriiabramov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitriiabramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitriiabramov/subscriptions","organizations_url":"https://api.github.com/users/dmitriiabramov/orgs","repos_url":"https://api.github.com/users/dmitriiabramov/repos","events_url":"https://api.github.com/users/dmitriiabramov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitriiabramov/received_events","type":"User","site_admin":false},"created_at":"2017-01-20T17:54:19Z","updated_at":"2017-01-20T17:54:19Z","body":"i'm a little worried about overriding the matcher. would it be better to have something like `.toMatchEnzymeSnapshot()`?"}}
{"actor":{"display_login":"dmitriiabramov"}}