{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/137952704","pull_request_review_id":61687693,"id":137952704,"diff_hunk":"@@ -89,24 +95,28 @@ type Refreshable<'T> = 'T * (bool -> 'T)\n // The main entrypoints are TryGetOptionsForDocumentOrProject and TryGetOptionsForEditingDocumentOrProject.\n \n \n-[<Export(typeof<FSharpProjectOptionsManager>); Composition.Shared>]\n-type internal FSharpProjectOptionsManager \n+[<Export(typeof<ProjectInfoManager>); Composition.Shared>]\n+type internal ProjectInfoManager ","path":"vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs","position":89,"original_position":89,"commit_id":"24290481d2badb725b887dee76ed090c1e0f184a","original_commit_id":"24290481d2badb725b887dee76ed090c1e0f184a","user":{"login":"dsyme","id":7204669,"avatar_url":"https://avatars1.githubusercontent.com/u/7204669?v=4","gravatar_id":"","url":"https://api.github.com/users/dsyme","html_url":"https://github.com/dsyme","followers_url":"https://api.github.com/users/dsyme/followers","following_url":"https://api.github.com/users/dsyme/following{/other_user}","gists_url":"https://api.github.com/users/dsyme/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyme/subscriptions","organizations_url":"https://api.github.com/users/dsyme/orgs","repos_url":"https://api.github.com/users/dsyme/repos","events_url":"https://api.github.com/users/dsyme/events{/privacy}","received_events_url":"https://api.github.com/users/dsyme/received_events","type":"User","site_admin":false},"body":"You might want to undo this renaming, to make the PR really minimal.","created_at":"2017-09-10T15:44:32Z","updated_at":"2017-09-10T16:02:26Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/3564#discussion_r137952704","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/137952704"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/3564#discussion_r137952704"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564","id":140161266,"html_url":"https://github.com/Microsoft/visualfsharp/pull/3564","diff_url":"https://github.com/Microsoft/visualfsharp/pull/3564.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/3564.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/3564","number":3564,"state":"open","locked":false,"title":"Another go at --- Map workspace to iprojectsite","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars3.githubusercontent.com/u/5175830?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"body":"This supercedes: https://github.com/Microsoft/visualfsharp/pull/3425\r\n\r\nIt integrates the F# Editor with dotnet sdk project files and gets the file ordering right, correct references, defines and all of that malarkey.\r\n\r\nOnce more I fully understand, what it's like to be the stupid guy in the room.  I have spent forever on this, barely understanding what was going on.  However, the solution was a few trivial bug fixes and the realization that FCS gets it's list of references from the command line options.\r\n\r\n**Anyway ...**\r\nI'm afraid you won't be able to try it out yet, since it is dependent on a dotnet project-system change.\r\nThis change uses the design time build to get the command line options and notify a MEF import supplied by the F# editor.\r\n\r\nI think that fix will be in preview soon, and when that happens nightlies will light this up, and we can get to work on the 10 thousand or so bugs left to be discovered.\r\n\r\nI have tried not break the integration for desktop projects, I would appreciate, it if you can try and find out any breaks I introduced.\r\n\r\n@tannergooding has been working on fixing the CPS ordering issue, so now the solution explorer can render F# project source files in the correct order ... again you will have to wait for a preview.\r\n\r\nThe CPS team have fixed an ordering issue that caused them to jumble up the order of project settings when imported, @davkean is working on hooking up Tanner's work with solution explorer and the CPS in-jumbling work.\r\n\r\nEnabling all of this was about 10 times more coordination than I expected, but it is slowwwwwwwly coming together.\r\n\r\nAs you can see my changes have been surprisingly economical.   I am a very slow typist, and even slower thinker :-)\r\n\r\n@cartermp, @dsyme, @brettfo, @Pilchie \r\nCan you try this out ...\r\n- Install from \\\\cpvsbuild\\drops\\vs\\vsuml for a build after yesterday--- it has the project-system change\r\n- Then build and install the open source vsix.\r\n\r\n\r\n\r\n","created_at":"2017-09-09T08:17:32Z","updated_at":"2017-09-10T16:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4925de9dfef74b2cd8141177f3478803c353add","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/3564/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/24290481d2badb725b887dee76ed090c1e0f184a","head":{"label":"KevinRansom:editor","ref":"editor","sha":"24290481d2badb725b887dee76ed090c1e0f184a","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars3.githubusercontent.com/u/5175830?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"repo":{"id":91001706,"name":"visualfsharp","full_name":"KevinRansom/visualfsharp","owner":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars3.githubusercontent.com/u/5175830?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinRansom/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/KevinRansom/visualfsharp","forks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/forks","keys_url":"https://api.github.com/repos/KevinRansom/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinRansom/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinRansom/visualfsharp/teams","hooks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/events","assignees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/KevinRansom/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/tags","blobs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinRansom/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinRansom/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscription","commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinRansom/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/KevinRansom/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinRansom/visualfsharp/merges","archive_url":"https://api.github.com/repos/KevinRansom/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinRansom/visualfsharp/downloads","issues_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/KevinRansom/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinRansom/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinRansom/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinRansom/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/KevinRansom/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/KevinRansom/visualfsharp/deployments","created_at":"2017-05-11T16:39:18Z","updated_at":"2017-05-11T16:39:33Z","pushed_at":"2017-09-09T08:20:51Z","git_url":"git://github.com/KevinRansom/visualfsharp.git","ssh_url":"git@github.com:KevinRansom/visualfsharp.git","clone_url":"https://github.com/KevinRansom/visualfsharp.git","svn_url":"https://github.com/KevinRansom/visualfsharp","homepage":null,"size":99792,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"554237465a8cc25d9ac674efc35fefe84d93f792","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/visualfsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2017-09-09T20:20:58Z","pushed_at":"2017-09-09T08:20:52Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":99768,"stargazers_count":1122,"watchers_count":1122,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":297,"mirror_url":null,"open_issues_count":378,"forks":297,"open_issues":378,"watchers":1122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/3564"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/3564"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/3564/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/3564/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/24290481d2badb725b887dee76ed090c1e0f184a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dsyme"}}