{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/comments/155690439","pull_request_review_id":82051177,"id":155690439,"diff_hunk":"@@ -0,0 +1,90 @@\n+# -*- coding: utf-8; mode: makefile-gmake -*-\n+\n+.DEFAULT = help\n+TEST ?= .\n+\n+# python version to use\n+PY       ?=3\n+# list of python packages (folders) or modules (files) of this build\n+PYOBJECTS = tokenlib\n+# folder where the python distribution takes place\n+PYDIST   ?= dist\n+# folder where the python intermediate build files take place\n+PYBUILD  ?= build\n+\n+SYSTEMPYTHON = `which python$(PY) python | head -n 1`\n+VIRTUALENV   = virtualenv --python=$(SYSTEMPYTHON)\n+VENV_OPTS    = \"--no-site-packages\"\n+TEST_FOLDER  = ./tokenlib/tests\n+\n+ENV     = ./local/py$(PY)\n+ENV_BIN = $(ENV)/bin\n+\n+\n+PHONY += help\n+help::\n+\t@echo  'usage:'\n+\t@echo\n+\t@echo  '  build     - build virtualenv ($(ENV)) and install *developer mode*'\n+\t@echo  '  lint      - run pylint within \"build\" (developer mode)'\n+\t@echo  '  test      - run tests for all supported environments (tox)'\n+\t@echo  '  dist      - build packages in \"$(PYDIST)/\"'\n+\t@echo  '  pypi      - upload \"$(PYDIST)/*\" files to PyPi'","path":"Makefile","position":32,"original_position":32,"commit_id":"d3b8b728d8ee6bdba74e1b3045814ed8cb1d51cf","original_commit_id":"d3b8b728d8ee6bdba74e1b3045814ed8cb1d51cf","user":{"login":"rfk","id":34695,"avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"body":"nit: IIUC this is now `make publish` rather than `make pypi`.","created_at":"2017-12-08T02:08:08Z","updated_at":"2017-12-08T02:30:36Z","html_url":"https://github.com/mozilla-services/tokenlib/pull/5#discussion_r155690439","pull_request_url":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/comments/155690439"},"html":{"href":"https://github.com/mozilla-services/tokenlib/pull/5#discussion_r155690439"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5","id":156024870,"html_url":"https://github.com/mozilla-services/tokenlib/pull/5","diff_url":"https://github.com/mozilla-services/tokenlib/pull/5.diff","patch_url":"https://github.com/mozilla-services/tokenlib/pull/5.patch","issue_url":"https://api.github.com/repos/mozilla-services/tokenlib/issues/5","number":5,"state":"open","locked":false,"title":"Python 2/3 compatibility","user":{"login":"return42","id":554536,"avatar_url":"https://avatars3.githubusercontent.com/u/554536?v=4","gravatar_id":"","url":"https://api.github.com/users/return42","html_url":"https://github.com/return42","followers_url":"https://api.github.com/users/return42/followers","following_url":"https://api.github.com/users/return42/following{/other_user}","gists_url":"https://api.github.com/users/return42/gists{/gist_id}","starred_url":"https://api.github.com/users/return42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/return42/subscriptions","organizations_url":"https://api.github.com/users/return42/orgs","repos_url":"https://api.github.com/users/return42/repos","events_url":"https://api.github.com/users/return42/events{/privacy}","received_events_url":"https://api.github.com/users/return42/received_events","type":"User","site_admin":false},"body":"@rfk: Hi Ryan, here is my second PR for Python 2/3 compatibility we discussed in [1].\r\n\r\n[1] mozilla-services/syncserver#97 (comment)\r\n\r\nThanks!\r\n\r\n-- Markus --","created_at":"2017-12-02T18:24:48Z","updated_at":"2017-12-08T02:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56aa1946e45ff4dc6b8161142bacfe65d6b18663","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/tokenlib/issues/5/comments","statuses_url":"https://api.github.com/repos/mozilla-services/tokenlib/statuses/d3b8b728d8ee6bdba74e1b3045814ed8cb1d51cf","head":{"label":"return42:six","ref":"six","sha":"d3b8b728d8ee6bdba74e1b3045814ed8cb1d51cf","user":{"login":"return42","id":554536,"avatar_url":"https://avatars3.githubusercontent.com/u/554536?v=4","gravatar_id":"","url":"https://api.github.com/users/return42","html_url":"https://github.com/return42","followers_url":"https://api.github.com/users/return42/followers","following_url":"https://api.github.com/users/return42/following{/other_user}","gists_url":"https://api.github.com/users/return42/gists{/gist_id}","starred_url":"https://api.github.com/users/return42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/return42/subscriptions","organizations_url":"https://api.github.com/users/return42/orgs","repos_url":"https://api.github.com/users/return42/repos","events_url":"https://api.github.com/users/return42/events{/privacy}","received_events_url":"https://api.github.com/users/return42/received_events","type":"User","site_admin":false},"repo":{"id":79256604,"name":"tokenlib","full_name":"return42/tokenlib","owner":{"login":"return42","id":554536,"avatar_url":"https://avatars3.githubusercontent.com/u/554536?v=4","gravatar_id":"","url":"https://api.github.com/users/return42","html_url":"https://github.com/return42","followers_url":"https://api.github.com/users/return42/followers","following_url":"https://api.github.com/users/return42/following{/other_user}","gists_url":"https://api.github.com/users/return42/gists{/gist_id}","starred_url":"https://api.github.com/users/return42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/return42/subscriptions","organizations_url":"https://api.github.com/users/return42/orgs","repos_url":"https://api.github.com/users/return42/repos","events_url":"https://api.github.com/users/return42/events{/privacy}","received_events_url":"https://api.github.com/users/return42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/return42/tokenlib","description":"generic support library for signed-token-based auth schemes","fork":true,"url":"https://api.github.com/repos/return42/tokenlib","forks_url":"https://api.github.com/repos/return42/tokenlib/forks","keys_url":"https://api.github.com/repos/return42/tokenlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/return42/tokenlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/return42/tokenlib/teams","hooks_url":"https://api.github.com/repos/return42/tokenlib/hooks","issue_events_url":"https://api.github.com/repos/return42/tokenlib/issues/events{/number}","events_url":"https://api.github.com/repos/return42/tokenlib/events","assignees_url":"https://api.github.com/repos/return42/tokenlib/assignees{/user}","branches_url":"https://api.github.com/repos/return42/tokenlib/branches{/branch}","tags_url":"https://api.github.com/repos/return42/tokenlib/tags","blobs_url":"https://api.github.com/repos/return42/tokenlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/return42/tokenlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/return42/tokenlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/return42/tokenlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/return42/tokenlib/statuses/{sha}","languages_url":"https://api.github.com/repos/return42/tokenlib/languages","stargazers_url":"https://api.github.com/repos/return42/tokenlib/stargazers","contributors_url":"https://api.github.com/repos/return42/tokenlib/contributors","subscribers_url":"https://api.github.com/repos/return42/tokenlib/subscribers","subscription_url":"https://api.github.com/repos/return42/tokenlib/subscription","commits_url":"https://api.github.com/repos/return42/tokenlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/return42/tokenlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/return42/tokenlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/return42/tokenlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/return42/tokenlib/contents/{+path}","compare_url":"https://api.github.com/repos/return42/tokenlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/return42/tokenlib/merges","archive_url":"https://api.github.com/repos/return42/tokenlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/return42/tokenlib/downloads","issues_url":"https://api.github.com/repos/return42/tokenlib/issues{/number}","pulls_url":"https://api.github.com/repos/return42/tokenlib/pulls{/number}","milestones_url":"https://api.github.com/repos/return42/tokenlib/milestones{/number}","notifications_url":"https://api.github.com/repos/return42/tokenlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/return42/tokenlib/labels{/name}","releases_url":"https://api.github.com/repos/return42/tokenlib/releases{/id}","deployments_url":"https://api.github.com/repos/return42/tokenlib/deployments","created_at":"2017-01-17T18:11:48Z","updated_at":"2017-01-17T18:11:50Z","pushed_at":"2017-12-02T18:19:07Z","git_url":"git://github.com/return42/tokenlib.git","ssh_url":"git@github.com:return42/tokenlib.git","clone_url":"https://github.com/return42/tokenlib.git","svn_url":"https://github.com/return42/tokenlib","homepage":"","size":41,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"six"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"e270a029d021de8b0526a5bc85a22d782c22d136","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":3510472,"name":"tokenlib","full_name":"mozilla-services/tokenlib","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/tokenlib","description":"generic support library for signed-token-based auth schemes","fork":false,"url":"https://api.github.com/repos/mozilla-services/tokenlib","forks_url":"https://api.github.com/repos/mozilla-services/tokenlib/forks","keys_url":"https://api.github.com/repos/mozilla-services/tokenlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/tokenlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/tokenlib/teams","hooks_url":"https://api.github.com/repos/mozilla-services/tokenlib/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/tokenlib/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/tokenlib/events","assignees_url":"https://api.github.com/repos/mozilla-services/tokenlib/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/tokenlib/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/tokenlib/tags","blobs_url":"https://api.github.com/repos/mozilla-services/tokenlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/tokenlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/tokenlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/tokenlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/tokenlib/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/tokenlib/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/tokenlib/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/tokenlib/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/tokenlib/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/tokenlib/subscription","commits_url":"https://api.github.com/repos/mozilla-services/tokenlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/tokenlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/tokenlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/tokenlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/tokenlib/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/tokenlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/tokenlib/merges","archive_url":"https://api.github.com/repos/mozilla-services/tokenlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/tokenlib/downloads","issues_url":"https://api.github.com/repos/mozilla-services/tokenlib/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/tokenlib/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/tokenlib/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/tokenlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/tokenlib/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/tokenlib/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/tokenlib/deployments","created_at":"2012-02-22T01:54:24Z","updated_at":"2017-09-13T07:28:40Z","pushed_at":"2017-12-02T18:24:49Z","git_url":"git://github.com/mozilla-services/tokenlib.git","ssh_url":"git@github.com:mozilla-services/tokenlib.git","clone_url":"https://github.com/mozilla-services/tokenlib.git","svn_url":"https://github.com/mozilla-services/tokenlib","homepage":"","size":218,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":3,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5"},"html":{"href":"https://github.com/mozilla-services/tokenlib/pull/5"},"issue":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/issues/5"},"comments":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/tokenlib/statuses/d3b8b728d8ee6bdba74e1b3045814ed8cb1d51cf"}},"author_association":"NONE"}}
{"actor":{"display_login":"rfk"}}