{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/comments/134686482","pull_request_review_id":58005050,"id":134686482,"diff_hunk":"@@ -47,8 +47,8 @@ methods.initZipAlign = async function () {\n /**\n  * Retrieve the API level of the device under test.\n  *\n- * @return (string) The API level as integer number, for example 21 for\n- * Android Lollipop. The result of this method is cached, so all the further\n+ * @return {string} The API level as integer number, for example 21 for","path":"lib/tools/adb-commands.js","position":6,"original_position":6,"commit_id":"42b4df5fb017996b8559d2b0492296656fedf86c","original_commit_id":"42b4df5fb017996b8559d2b0492296656fedf86c","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"Maybe... Maybe it even makes sense to cache this value.\r\nBut due to some historical reasons unknown to me this method is implemented this way.","created_at":"2017-08-23T08:23:20Z","updated_at":"2017-08-23T08:23:20Z","html_url":"https://github.com/appium/appium-adb/pull/254#discussion_r134686482","pull_request_url":"https://api.github.com/repos/appium/appium-adb/pulls/254","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments/134686482"},"html":{"href":"https://github.com/appium/appium-adb/pull/254#discussion_r134686482"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/254","id":137069567,"html_url":"https://github.com/appium/appium-adb/pull/254","diff_url":"https://github.com/appium/appium-adb/pull/254.diff","patch_url":"https://github.com/appium/appium-adb/pull/254.patch","issue_url":"https://api.github.com/repos/appium/appium-adb/issues/254","number":254,"state":"open","locked":false,"title":"Improve existing docstrings and add missing ones.","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"Used these tutorials:\r\nhttps://stackoverflow.com/questions/28763257/jsdoc-return-object-structure\r\nhttp://usejsdoc.org/tags-type.html","created_at":"2017-08-22T20:15:38Z","updated_at":"2017-08-23T08:23:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f31744e39cf5f042f3bc43c571a2e46f9b0e8e4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"imurchie","id":2614354,"avatar_url":"https://avatars2.githubusercontent.com/u/2614354?v=4","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-adb/pulls/254/commits","review_comments_url":"https://api.github.com/repos/appium/appium-adb/pulls/254/comments","review_comment_url":"https://api.github.com/repos/appium/appium-adb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-adb/issues/254/comments","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/42b4df5fb017996b8559d2b0492296656fedf86c","head":{"label":"mykola-mokhnach:docs2","ref":"docs2","sha":"42b4df5fb017996b8559d2b0492296656fedf86c","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"repo":{"id":84554947,"name":"appium-adb","full_name":"mykola-mokhnach/appium-adb","owner":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mykola-mokhnach/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":true,"url":"https://api.github.com/repos/mykola-mokhnach/appium-adb","forks_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/forks","keys_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/teams","hooks_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/events","assignees_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/tags","blobs_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/languages","stargazers_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/subscription","commits_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/merges","archive_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/downloads","issues_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/releases{/id}","deployments_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/deployments","created_at":"2017-03-10T11:51:45Z","updated_at":"2017-03-10T11:51:47Z","pushed_at":"2017-08-22T20:12:21Z","git_url":"git://github.com/mykola-mokhnach/appium-adb.git","ssh_url":"git@github.com:mykola-mokhnach/appium-adb.git","clone_url":"https://github.com/mykola-mokhnach/appium-adb.git","svn_url":"https://github.com/mykola-mokhnach/appium-adb","homepage":null,"size":30263,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"49f66262cc092b5edfc6a76da44bb01e64213db1","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":17339088,"name":"appium-adb","full_name":"appium/appium-adb","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":false,"url":"https://api.github.com/repos/appium/appium-adb","forks_url":"https://api.github.com/repos/appium/appium-adb/forks","keys_url":"https://api.github.com/repos/appium/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-adb/teams","hooks_url":"https://api.github.com/repos/appium/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-adb/events","assignees_url":"https://api.github.com/repos/appium/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-adb/tags","blobs_url":"https://api.github.com/repos/appium/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-adb/languages","stargazers_url":"https://api.github.com/repos/appium/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-adb/subscription","commits_url":"https://api.github.com/repos/appium/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-adb/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-adb/merges","archive_url":"https://api.github.com/repos/appium/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-adb/downloads","issues_url":"https://api.github.com/repos/appium/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-adb/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-adb/deployments","created_at":"2014-03-02T14:20:10Z","updated_at":"2017-08-21T14:10:53Z","pushed_at":"2017-08-22T20:15:38Z","git_url":"git://github.com/appium/appium-adb.git","ssh_url":"git@github.com:appium/appium-adb.git","clone_url":"https://github.com/appium/appium-adb.git","svn_url":"https://github.com/appium/appium-adb","homepage":null,"size":30234,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":1,"forks":95,"open_issues":1,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/254"},"html":{"href":"https://github.com/appium/appium-adb/pull/254"},"issue":{"href":"https://api.github.com/repos/appium/appium-adb/issues/254"},"comments":{"href":"https://api.github.com/repos/appium/appium-adb/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-adb/statuses/42b4df5fb017996b8559d2b0492296656fedf86c"}}}}
{"actor":{"display_login":"mykola-mokhnach"}}