{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/127713429","pull_request_review_id":50325333,"id":127713429,"diff_hunk":"@@ -347,8 +347,7 @@ impl EmitterWriter {\n \n         // Sort the annotations by (start, end col)\n         let mut annotations = line.annotations.clone();\n-        annotations.sort();\n-        annotations.reverse();\n+        annotations.sort_by(|a,b| b.start_col.cmp(&a.start_col));","path":"src/librustc_errors/emitter.rs","position":null,"original_position":6,"commit_id":"66f3c073ae7c2cf9d3f3c55eb0a8a8aae071708c","original_commit_id":"e38877f53d050ad2feec2514ef80749c41418e47","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars4.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"> since we are only sorting by the span, the order of the elements with the same span will never change\r\n\r\nThis is because our sort is stable?","created_at":"2017-07-17T13:53:45Z","updated_at":"2017-07-17T13:53:45Z","html_url":"https://github.com/rust-lang/rust/pull/43251#discussion_r127713429","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/43251","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/127713429"},"html":{"href":"https://github.com/rust-lang/rust/pull/43251#discussion_r127713429"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43251"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/43251","id":130714856,"html_url":"https://github.com/rust-lang/rust/pull/43251","diff_url":"https://github.com/rust-lang/rust/pull/43251.diff","patch_url":"https://github.com/rust-lang/rust/pull/43251.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/43251","number":43251,"state":"open","locked":false,"title":"Reorder span suggestions to appear below main labels ","user":{"login":"gaurikholkar","id":9420877,"avatar_url":"https://avatars5.githubusercontent.com/u/9420877?v=4","gravatar_id":"","url":"https://api.github.com/users/gaurikholkar","html_url":"https://github.com/gaurikholkar","followers_url":"https://api.github.com/users/gaurikholkar/followers","following_url":"https://api.github.com/users/gaurikholkar/following{/other_user}","gists_url":"https://api.github.com/users/gaurikholkar/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurikholkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurikholkar/subscriptions","organizations_url":"https://api.github.com/users/gaurikholkar/orgs","repos_url":"https://api.github.com/users/gaurikholkar/repos","events_url":"https://api.github.com/users/gaurikholkar/events{/privacy}","received_events_url":"https://api.github.com/users/gaurikholkar/received_events","type":"User","site_admin":false},"body":"A fix to #41698 \r\n\r\nr? @nikomatsakis ","created_at":"2017-07-15T12:49:29Z","updated_at":"2017-07-17T13:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"762f0204fb4688728dc4a74c49c00f4cd128c61e","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars4.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars4.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/43251/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/43251/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/43251/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/66f3c073ae7c2cf9d3f3c55eb0a8a8aae071708c","head":{"label":"gaurikholkar:span_reorder","ref":"span_reorder","sha":"66f3c073ae7c2cf9d3f3c55eb0a8a8aae071708c","user":{"login":"gaurikholkar","id":9420877,"avatar_url":"https://avatars5.githubusercontent.com/u/9420877?v=4","gravatar_id":"","url":"https://api.github.com/users/gaurikholkar","html_url":"https://github.com/gaurikholkar","followers_url":"https://api.github.com/users/gaurikholkar/followers","following_url":"https://api.github.com/users/gaurikholkar/following{/other_user}","gists_url":"https://api.github.com/users/gaurikholkar/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurikholkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurikholkar/subscriptions","organizations_url":"https://api.github.com/users/gaurikholkar/orgs","repos_url":"https://api.github.com/users/gaurikholkar/repos","events_url":"https://api.github.com/users/gaurikholkar/events{/privacy}","received_events_url":"https://api.github.com/users/gaurikholkar/received_events","type":"User","site_admin":false},"repo":{"id":88258655,"name":"rust","full_name":"gaurikholkar/rust","owner":{"login":"gaurikholkar","id":9420877,"avatar_url":"https://avatars5.githubusercontent.com/u/9420877?v=4","gravatar_id":"","url":"https://api.github.com/users/gaurikholkar","html_url":"https://github.com/gaurikholkar","followers_url":"https://api.github.com/users/gaurikholkar/followers","following_url":"https://api.github.com/users/gaurikholkar/following{/other_user}","gists_url":"https://api.github.com/users/gaurikholkar/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurikholkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurikholkar/subscriptions","organizations_url":"https://api.github.com/users/gaurikholkar/orgs","repos_url":"https://api.github.com/users/gaurikholkar/repos","events_url":"https://api.github.com/users/gaurikholkar/events{/privacy}","received_events_url":"https://api.github.com/users/gaurikholkar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaurikholkar/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/gaurikholkar/rust","forks_url":"https://api.github.com/repos/gaurikholkar/rust/forks","keys_url":"https://api.github.com/repos/gaurikholkar/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaurikholkar/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaurikholkar/rust/teams","hooks_url":"https://api.github.com/repos/gaurikholkar/rust/hooks","issue_events_url":"https://api.github.com/repos/gaurikholkar/rust/issues/events{/number}","events_url":"https://api.github.com/repos/gaurikholkar/rust/events","assignees_url":"https://api.github.com/repos/gaurikholkar/rust/assignees{/user}","branches_url":"https://api.github.com/repos/gaurikholkar/rust/branches{/branch}","tags_url":"https://api.github.com/repos/gaurikholkar/rust/tags","blobs_url":"https://api.github.com/repos/gaurikholkar/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaurikholkar/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaurikholkar/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaurikholkar/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaurikholkar/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/gaurikholkar/rust/languages","stargazers_url":"https://api.github.com/repos/gaurikholkar/rust/stargazers","contributors_url":"https://api.github.com/repos/gaurikholkar/rust/contributors","subscribers_url":"https://api.github.com/repos/gaurikholkar/rust/subscribers","subscription_url":"https://api.github.com/repos/gaurikholkar/rust/subscription","commits_url":"https://api.github.com/repos/gaurikholkar/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaurikholkar/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaurikholkar/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaurikholkar/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaurikholkar/rust/contents/{+path}","compare_url":"https://api.github.com/repos/gaurikholkar/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaurikholkar/rust/merges","archive_url":"https://api.github.com/repos/gaurikholkar/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaurikholkar/rust/downloads","issues_url":"https://api.github.com/repos/gaurikholkar/rust/issues{/number}","pulls_url":"https://api.github.com/repos/gaurikholkar/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/gaurikholkar/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/gaurikholkar/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaurikholkar/rust/labels{/name}","releases_url":"https://api.github.com/repos/gaurikholkar/rust/releases{/id}","deployments_url":"https://api.github.com/repos/gaurikholkar/rust/deployments","created_at":"2017-04-14T10:28:56Z","updated_at":"2017-04-14T10:29:15Z","pushed_at":"2017-07-17T13:50:34Z","git_url":"git://github.com/gaurikholkar/rust.git","ssh_url":"git@github.com:gaurikholkar/rust.git","clone_url":"https://github.com/gaurikholkar/rust.git","svn_url":"https://github.com/gaurikholkar/rust","homepage":"https://www.rust-lang.org","size":316802,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"5803f99bd4c53c3f469df26513ffa2e058094c53","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars5.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars5.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-07-17T13:48:12Z","pushed_at":"2017-07-17T13:50:39Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":317042,"stargazers_count":22617,"watchers_count":22617,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4160,"mirror_url":null,"open_issues_count":2751,"forks":4160,"open_issues":2751,"watchers":22617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43251"},"html":{"href":"https://github.com/rust-lang/rust/pull/43251"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/43251"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/43251/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43251/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43251/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/66f3c073ae7c2cf9d3f3c55eb0a8a8aae071708c"}}}}
{"actor":{"display_login":"nikomatsakis"}}