{"action":"created","comment":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments/110421901","pull_request_review_id":31596909,"id":110421901,"diff_hunk":"@@ -75,6 +75,9 @@ while [[ $# -gt 0 ]] && [[ .\"$1\" = .-* ]] ; do\n \n     \"--jtreg\" | \"-j\" )\n     JTREG=true; shift;;\n+    \n+    \"--jtreg_subsets\" )\n+    JTREG=true; JTREG_TEST_SUBSETS=\"$1\"; shift;;","path":"makejdk.sh","position":6,"original_position":6,"commit_id":"f04bf2ed4293e0586b8c6db5b457db68ccec83df","original_commit_id":"608465180d48495512dc9c0f0ae96fdd8295349f","user":{"login":"Bluevisitor","id":26874628,"avatar_url":"https://avatars0.githubusercontent.com/u/26874628?v=3","gravatar_id":"","url":"https://api.github.com/users/Bluevisitor","html_url":"https://github.com/Bluevisitor","followers_url":"https://api.github.com/users/Bluevisitor/followers","following_url":"https://api.github.com/users/Bluevisitor/following{/other_user}","gists_url":"https://api.github.com/users/Bluevisitor/gists{/gist_id}","starred_url":"https://api.github.com/users/Bluevisitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bluevisitor/subscriptions","organizations_url":"https://api.github.com/users/Bluevisitor/orgs","repos_url":"https://api.github.com/users/Bluevisitor/repos","events_url":"https://api.github.com/users/Bluevisitor/events{/privacy}","received_events_url":"https://api.github.com/users/Bluevisitor/received_events","type":"User","site_admin":false},"body":"After playing with the shell script, I've determined that shifting after assigning $1 to it has the nasty side-effect of swallowing the next variable passed in on the command line.\r\n\r\nso \"./makejdk.sh --jtreg --potato\" assigns \"--potato\" to JTREG_TEST_SUBSETS, and removes --potato from the list of arguments to be processed.\r\n\r\nIf we don't want to add another \"if\", what we could do is require a value for jtreg.\r\n\r\n'./makejdk.sh --jtreg \"\" --potato' works, for example.\r\n\r\nWill make that change. Let me know what you think when you get back.","created_at":"2017-04-07T15:50:02Z","updated_at":"2017-04-07T15:50:02Z","html_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/40#discussion_r110421901","pull_request_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments/110421901"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-build/pull/40#discussion_r110421901"},"pull_request":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40","id":114802654,"html_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/40","diff_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/40.diff","patch_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/40.patch","issue_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/40","number":40,"state":"open","locked":false,"title":"Allow user to specify tests we want jtreg to run","user":{"login":"Bluevisitor","id":26874628,"avatar_url":"https://avatars0.githubusercontent.com/u/26874628?v=3","gravatar_id":"","url":"https://api.github.com/users/Bluevisitor","html_url":"https://github.com/Bluevisitor","followers_url":"https://api.github.com/users/Bluevisitor/followers","following_url":"https://api.github.com/users/Bluevisitor/following{/other_user}","gists_url":"https://api.github.com/users/Bluevisitor/gists{/gist_id}","starred_url":"https://api.github.com/users/Bluevisitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bluevisitor/subscriptions","organizations_url":"https://api.github.com/users/Bluevisitor/orgs","repos_url":"https://api.github.com/users/Bluevisitor/repos","events_url":"https://api.github.com/users/Bluevisitor/events{/privacy}","received_events_url":"https://api.github.com/users/Bluevisitor/received_events","type":"User","site_admin":false},"body":"Currently we allow the user to say \"run the default jtreg tests after the build is complete\", but we don't allow the user to specify a subset.\r\n\r\nIf we want to run less tests than the default, or more, or if we want to run focused testing (in the event that a specific module has been changed recently), we'll need this option or something like it.","created_at":"2017-04-07T12:08:45Z","updated_at":"2017-04-07T15:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aebf4ec4f05677014364aa4907ae845467f8a5f","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/milestones/2","html_url":"https://github.com/AdoptOpenJDK/openjdk-build/milestone/2","labels_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/milestones/2/labels","id":2429480,"number":2,"title":"1.0.0","description":"For release to the Adoption Group at the OpenJDK project and other specialised OpenJDK communities","creator":{"login":"karianna","id":180840,"avatar_url":"https://avatars3.githubusercontent.com/u/180840?v=3","gravatar_id":"","url":"https://api.github.com/users/karianna","html_url":"https://github.com/karianna","followers_url":"https://api.github.com/users/karianna/followers","following_url":"https://api.github.com/users/karianna/following{/other_user}","gists_url":"https://api.github.com/users/karianna/gists{/gist_id}","starred_url":"https://api.github.com/users/karianna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karianna/subscriptions","organizations_url":"https://api.github.com/users/karianna/orgs","repos_url":"https://api.github.com/users/karianna/repos","events_url":"https://api.github.com/users/karianna/events{/privacy}","received_events_url":"https://api.github.com/users/karianna/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":11,"state":"open","created_at":"2017-04-03T10:01:08Z","updated_at":"2017-04-07T12:21:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40/commits","review_comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40/comments","review_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/40/comments","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/f04bf2ed4293e0586b8c6db5b457db68ccec83df","head":{"label":"Bluevisitor:allow_user_to_specify_jtreg_test_suites","ref":"allow_user_to_specify_jtreg_test_suites","sha":"f04bf2ed4293e0586b8c6db5b457db68ccec83df","user":{"login":"Bluevisitor","id":26874628,"avatar_url":"https://avatars0.githubusercontent.com/u/26874628?v=3","gravatar_id":"","url":"https://api.github.com/users/Bluevisitor","html_url":"https://github.com/Bluevisitor","followers_url":"https://api.github.com/users/Bluevisitor/followers","following_url":"https://api.github.com/users/Bluevisitor/following{/other_user}","gists_url":"https://api.github.com/users/Bluevisitor/gists{/gist_id}","starred_url":"https://api.github.com/users/Bluevisitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bluevisitor/subscriptions","organizations_url":"https://api.github.com/users/Bluevisitor/orgs","repos_url":"https://api.github.com/users/Bluevisitor/repos","events_url":"https://api.github.com/users/Bluevisitor/events{/privacy}","received_events_url":"https://api.github.com/users/Bluevisitor/received_events","type":"User","site_admin":false},"repo":{"id":87292238,"name":"openjdk-build","full_name":"Bluevisitor/openjdk-build","owner":{"login":"Bluevisitor","id":26874628,"avatar_url":"https://avatars0.githubusercontent.com/u/26874628?v=3","gravatar_id":"","url":"https://api.github.com/users/Bluevisitor","html_url":"https://github.com/Bluevisitor","followers_url":"https://api.github.com/users/Bluevisitor/followers","following_url":"https://api.github.com/users/Bluevisitor/following{/other_user}","gists_url":"https://api.github.com/users/Bluevisitor/gists{/gist_id}","starred_url":"https://api.github.com/users/Bluevisitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bluevisitor/subscriptions","organizations_url":"https://api.github.com/users/Bluevisitor/orgs","repos_url":"https://api.github.com/users/Bluevisitor/repos","events_url":"https://api.github.com/users/Bluevisitor/events{/privacy}","received_events_url":"https://api.github.com/users/Bluevisitor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bluevisitor/openjdk-build","description":"AdoptOpenJDK community common OpenJDK build scripts","fork":true,"url":"https://api.github.com/repos/Bluevisitor/openjdk-build","forks_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/forks","keys_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/teams","hooks_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/hooks","issue_events_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/issues/events{/number}","events_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/events","assignees_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/assignees{/user}","branches_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/branches{/branch}","tags_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/tags","blobs_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/statuses/{sha}","languages_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/languages","stargazers_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/stargazers","contributors_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/contributors","subscribers_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/subscribers","subscription_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/subscription","commits_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/contents/{+path}","compare_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/merges","archive_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/downloads","issues_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/issues{/number}","pulls_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/pulls{/number}","milestones_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/milestones{/number}","notifications_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/labels{/name}","releases_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/releases{/id}","deployments_url":"https://api.github.com/repos/Bluevisitor/openjdk-build/deployments","created_at":"2017-04-05T09:37:12Z","updated_at":"2017-04-05T09:37:14Z","pushed_at":"2017-04-07T14:28:56Z","git_url":"git://github.com/Bluevisitor/openjdk-build.git","ssh_url":"git@github.com:Bluevisitor/openjdk-build.git","clone_url":"https://github.com/Bluevisitor/openjdk-build.git","svn_url":"https://github.com/Bluevisitor/openjdk-build","homepage":"","size":182,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AdoptOpenJDK:master","ref":"master","sha":"ec9c24f33e497f0e408717d78756c2d497c99e80","user":{"login":"AdoptOpenJDK","id":1673867,"avatar_url":"https://avatars3.githubusercontent.com/u/1673867?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"repo":{"id":85294562,"name":"openjdk-build","full_name":"AdoptOpenJDK/openjdk-build","owner":{"login":"AdoptOpenJDK","id":1673867,"avatar_url":"https://avatars3.githubusercontent.com/u/1673867?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AdoptOpenJDK/openjdk-build","description":"AdoptOpenJDK community common OpenJDK build scripts","fork":false,"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build","forks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/forks","keys_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/teams","hooks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/hooks","issue_events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/events{/number}","events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/events","assignees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/assignees{/user}","branches_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/branches{/branch}","tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/tags","blobs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/{sha}","languages_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/languages","stargazers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/stargazers","contributors_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/contributors","subscribers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/subscribers","subscription_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/subscription","commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/contents/{+path}","compare_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/merges","archive_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/downloads","issues_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues{/number}","pulls_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls{/number}","milestones_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/milestones{/number}","notifications_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/labels{/name}","releases_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/releases{/id}","deployments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/deployments","created_at":"2017-03-17T09:31:50Z","updated_at":"2017-03-19T15:05:46Z","pushed_at":"2017-04-07T14:28:56Z","git_url":"git://github.com/AdoptOpenJDK/openjdk-build.git","ssh_url":"git@github.com:AdoptOpenJDK/openjdk-build.git","clone_url":"https://github.com/AdoptOpenJDK/openjdk-build.git","svn_url":"https://github.com/AdoptOpenJDK/openjdk-build","homepage":"","size":180,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-build/pull/40"},"issue":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/40"},"comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/f04bf2ed4293e0586b8c6db5b457db68ccec83df"}}}}
{"actor":{"display_login":"Bluevisitor"}}