{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/108152506","pull_request_review_id":29163992,"id":108152506,"diff_hunk":"@@ -122,13 +120,11 @@ static int _gnrc_tcp_open(gnrc_tcp_tcb_t *tcb, const uint8_t *target_addr, uint1\n     else {\n         /* Copy Target Address and Port into tcb structure */\n         if (target_addr != NULL) {\n-            switch (tcb->address_family) {\n  #ifdef MODULE_GNRC_IPV6\n-                case AF_INET6:\n-                    memcpy(tcb->peer_addr, target_addr, sizeof(ipv6_addr_t));\n-                    break;\n- #endif\n+            if (tcb->address_family == AF_INET6) {","path":"sys/net/gnrc/transport_layer/tcp/gnrc_tcp.c","position":27,"original_position":27,"commit_id":"569b6df8b783a5683d46d8ed40e6a03d06bb544b","original_commit_id":"569b6df8b783a5683d46d8ed40e6a03d06bb544b","user":{"login":"smlng","id":10532675,"avatar_url":"https://avatars2.githubusercontent.com/u/10532675?v=3","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"body":"same as above, but also integrate both ifs with `&&`","created_at":"2017-03-27T12:07:37Z","updated_at":"2017-03-27T12:11:43Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/6742#discussion_r108152506","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/108152506"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/6742#discussion_r108152506"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742","id":110490362,"html_url":"https://github.com/RIOT-OS/RIOT/pull/6742","diff_url":"https://github.com/RIOT-OS/RIOT/pull/6742.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/6742.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/6742","number":6742,"state":"open","locked":false,"title":"gnrc_tcp: cleanup: minor changes","user":{"login":"brummer-simon","id":3950119,"avatar_url":"https://avatars0.githubusercontent.com/u/3950119?v=3","gravatar_id":"","url":"https://api.github.com/users/brummer-simon","html_url":"https://github.com/brummer-simon","followers_url":"https://api.github.com/users/brummer-simon/followers","following_url":"https://api.github.com/users/brummer-simon/following{/other_user}","gists_url":"https://api.github.com/users/brummer-simon/gists{/gist_id}","starred_url":"https://api.github.com/users/brummer-simon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brummer-simon/subscriptions","organizations_url":"https://api.github.com/users/brummer-simon/orgs","repos_url":"https://api.github.com/users/brummer-simon/repos","events_url":"https://api.github.com/users/brummer-simon/events{/privacy}","received_events_url":"https://api.github.com/users/brummer-simon/received_events","type":"User","site_admin":false},"body":"The next PR addressing more issues from  #6476.\r\n\r\nAddressed Items are:\r\n\r\n- examples are missing a README\r\n- client examples contain a hardcoded IP address for the communication peer, but this address is not set on the server side\r\n-  contain switch-case statements with only one case\r\n-  gnrc_tcp_tcb_init() can be significantly be shortened using memset()\r\n-  gnrc_tcp_eventloop.c allocates a message queue on the function stack\r\n- gnrc_tcp_fsm.c - why do some function have a bool pointer(!) as output parameter? An int return value offers more than enough options to indicate different states","created_at":"2017-03-13T20:26:31Z","updated_at":"2017-03-27T12:11:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0da402aae41b40929ff41744545804921b8ce944","assignee":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars3.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"assignees":[{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars3.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/6742/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/569b6df8b783a5683d46d8ed40e6a03d06bb544b","head":{"label":"brummer-simon:gnrc_tcp-cleanup-minor_changes","ref":"gnrc_tcp-cleanup-minor_changes","sha":"569b6df8b783a5683d46d8ed40e6a03d06bb544b","user":{"login":"brummer-simon","id":3950119,"avatar_url":"https://avatars0.githubusercontent.com/u/3950119?v=3","gravatar_id":"","url":"https://api.github.com/users/brummer-simon","html_url":"https://github.com/brummer-simon","followers_url":"https://api.github.com/users/brummer-simon/followers","following_url":"https://api.github.com/users/brummer-simon/following{/other_user}","gists_url":"https://api.github.com/users/brummer-simon/gists{/gist_id}","starred_url":"https://api.github.com/users/brummer-simon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brummer-simon/subscriptions","organizations_url":"https://api.github.com/users/brummer-simon/orgs","repos_url":"https://api.github.com/users/brummer-simon/repos","events_url":"https://api.github.com/users/brummer-simon/events{/privacy}","received_events_url":"https://api.github.com/users/brummer-simon/received_events","type":"User","site_admin":false},"repo":{"id":26728513,"name":"RIOT","full_name":"brummer-simon/RIOT","owner":{"login":"brummer-simon","id":3950119,"avatar_url":"https://avatars0.githubusercontent.com/u/3950119?v=3","gravatar_id":"","url":"https://api.github.com/users/brummer-simon","html_url":"https://github.com/brummer-simon","followers_url":"https://api.github.com/users/brummer-simon/followers","following_url":"https://api.github.com/users/brummer-simon/following{/other_user}","gists_url":"https://api.github.com/users/brummer-simon/gists{/gist_id}","starred_url":"https://api.github.com/users/brummer-simon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brummer-simon/subscriptions","organizations_url":"https://api.github.com/users/brummer-simon/orgs","repos_url":"https://api.github.com/users/brummer-simon/repos","events_url":"https://api.github.com/users/brummer-simon/events{/privacy}","received_events_url":"https://api.github.com/users/brummer-simon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brummer-simon/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/brummer-simon/RIOT","forks_url":"https://api.github.com/repos/brummer-simon/RIOT/forks","keys_url":"https://api.github.com/repos/brummer-simon/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brummer-simon/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brummer-simon/RIOT/teams","hooks_url":"https://api.github.com/repos/brummer-simon/RIOT/hooks","issue_events_url":"https://api.github.com/repos/brummer-simon/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/brummer-simon/RIOT/events","assignees_url":"https://api.github.com/repos/brummer-simon/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/brummer-simon/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/brummer-simon/RIOT/tags","blobs_url":"https://api.github.com/repos/brummer-simon/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brummer-simon/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brummer-simon/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/brummer-simon/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brummer-simon/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/brummer-simon/RIOT/languages","stargazers_url":"https://api.github.com/repos/brummer-simon/RIOT/stargazers","contributors_url":"https://api.github.com/repos/brummer-simon/RIOT/contributors","subscribers_url":"https://api.github.com/repos/brummer-simon/RIOT/subscribers","subscription_url":"https://api.github.com/repos/brummer-simon/RIOT/subscription","commits_url":"https://api.github.com/repos/brummer-simon/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/brummer-simon/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/brummer-simon/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/brummer-simon/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/brummer-simon/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/brummer-simon/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brummer-simon/RIOT/merges","archive_url":"https://api.github.com/repos/brummer-simon/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brummer-simon/RIOT/downloads","issues_url":"https://api.github.com/repos/brummer-simon/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/brummer-simon/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/brummer-simon/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/brummer-simon/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brummer-simon/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/brummer-simon/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/brummer-simon/RIOT/deployments","created_at":"2014-11-16T21:23:56Z","updated_at":"2016-11-18T07:24:02Z","pushed_at":"2017-03-27T11:57:30Z","git_url":"git://github.com/brummer-simon/RIOT.git","ssh_url":"git@github.com:brummer-simon/RIOT.git","clone_url":"https://github.com/brummer-simon/RIOT.git","svn_url":"https://github.com/brummer-simon/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":36160,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"4dc2028c9bd5240f99a03e2e5d822338b831762a","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars1.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars1.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2017-03-26T03:34:07Z","pushed_at":"2017-03-27T12:04:44Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":36410,"stargazers_count":1189,"watchers_count":1189,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":736,"mirror_url":null,"open_issues_count":554,"forks":736,"open_issues":554,"watchers":1189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/6742"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/6742"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/6742/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/6742/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/569b6df8b783a5683d46d8ed40e6a03d06bb544b"}}}}
{"actor":{"display_login":"smlng"}}