{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/106158953","pull_request_review_id":27066953,"id":106158953,"diff_hunk":"@@ -0,0 +1,209 @@\n+/**\n+ * Copyright 2017 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import {MDCFoundation} from '@material/base';\n+import {cssClasses, strings} from './constants';\n+\n+export default class MDCDialogFoundation extends MDCFoundation {\n+  static get cssClasses() {\n+    return cssClasses;\n+  }\n+\n+  static get strings() {\n+    return strings;\n+  }\n+\n+  static get defaultAdapter() {\n+    return {\n+      setBackgroundAriaHidden: (/* el: Element */) => {},\n+      setDialogAriaHidden: (/* el: Element */) => {},\n+      hasClass: (/* className: string */) => {},\n+      addClass: (/* className: string */) => {},\n+      removeClass: (/* className: string */) => {},\n+      addScrollLockClass: (/* className: string */) => {},\n+      removeScrollLockClass: (/* className: string */) => {},\n+      registerInteractionHandler: (/* evt: string, handler: EventListener */) => {},\n+      deregisterInteractionHandler: (/* evt: string, handler: EventListener */) => {},\n+      registerDialogInteractionHandler: (/* evt: string, handler: EventListener */) => {},","path":"packages/mdc-dialog/foundation.js","position":40,"original_position":40,"commit_id":"4ed88cedd2abc5ea85c9d2d22d2b1dd5b5e4cc61","original_commit_id":"595bdcfb37dcecc83a331f5399aed19b284d0af1","user":{"login":"amsheehan","id":1578263,"avatar_url":"https://avatars0.githubusercontent.com/u/1578263?v=3","gravatar_id":"","url":"https://api.github.com/users/amsheehan","html_url":"https://github.com/amsheehan","followers_url":"https://api.github.com/users/amsheehan/followers","following_url":"https://api.github.com/users/amsheehan/following{/other_user}","gists_url":"https://api.github.com/users/amsheehan/gists{/gist_id}","starred_url":"https://api.github.com/users/amsheehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amsheehan/subscriptions","organizations_url":"https://api.github.com/users/amsheehan/orgs","repos_url":"https://api.github.com/users/amsheehan/repos","events_url":"https://api.github.com/users/amsheehan/events{/privacy}","received_events_url":"https://api.github.com/users/amsheehan/received_events","type":"User","site_admin":false},"body":"`registerInteractionHandler` is attached to the root of the component and dismisses the dialog. `registerDialogInteractionHandler` is attached to the `dialog surface` and prevents events from propagating down to the root which would dismiss the dialog. There is a similar pattern used in `MDCTemporaryDrawer`","created_at":"2017-03-15T13:05:52Z","updated_at":"2017-03-15T13:05:52Z","html_url":"https://github.com/material-components/material-components-web/pull/395#discussion_r106158953","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/395","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/106158953"},"html":{"href":"https://github.com/material-components/material-components-web/pull/395#discussion_r106158953"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/395","id":110468160,"html_url":"https://github.com/material-components/material-components-web/pull/395","diff_url":"https://github.com/material-components/material-components-web/pull/395.diff","patch_url":"https://github.com/material-components/material-components-web/pull/395.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/395","number":395,"state":"open","locked":false,"title":"feat(dialog): Implement a dialog component","user":{"login":"amsheehan","id":1578263,"avatar_url":"https://avatars0.githubusercontent.com/u/1578263?v=3","gravatar_id":"","url":"https://api.github.com/users/amsheehan","html_url":"https://github.com/amsheehan","followers_url":"https://api.github.com/users/amsheehan/followers","following_url":"https://api.github.com/users/amsheehan/following{/other_user}","gists_url":"https://api.github.com/users/amsheehan/gists{/gist_id}","starred_url":"https://api.github.com/users/amsheehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amsheehan/subscriptions","organizations_url":"https://api.github.com/users/amsheehan/orgs","repos_url":"https://api.github.com/users/amsheehan/repos","events_url":"https://api.github.com/users/amsheehan/events{/privacy}","received_events_url":"https://api.github.com/users/amsheehan/received_events","type":"User","site_admin":false},"body":"Resolves #32 ","created_at":"2017-03-13T18:25:48Z","updated_at":"2017-03-15T13:05:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41bd568ba70fba651982d916a6b7a17003407766","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/395/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/395/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/395/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/4ed88cedd2abc5ea85c9d2d22d2b1dd5b5e4cc61","head":{"label":"material-components:mdc-web/dialog-v2","ref":"mdc-web/dialog-v2","sha":"4ed88cedd2abc5ea85c9d2d22d2b1dd5b5e4cc61","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars0.githubusercontent.com/u/19478152?v=3","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars0.githubusercontent.com/u/19478152?v=3","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2017-03-15T12:53:23Z","pushed_at":"2017-03-15T06:24:32Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":45658,"stargazers_count":2653,"watchers_count":2653,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":106,"forks":202,"open_issues":106,"watchers":2653,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"5b84e733a1707617ceb2d677c600e8fded719728","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars0.githubusercontent.com/u/19478152?v=3","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars0.githubusercontent.com/u/19478152?v=3","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2017-03-15T12:53:23Z","pushed_at":"2017-03-15T06:24:32Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":45658,"stargazers_count":2653,"watchers_count":2653,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":106,"forks":202,"open_issues":106,"watchers":2653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/395"},"html":{"href":"https://github.com/material-components/material-components-web/pull/395"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/395"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/4ed88cedd2abc5ea85c9d2d22d2b1dd5b5e4cc61"}}}}
{"actor":{"display_login":"amsheehan"}}