{"action":"created","comment":{"url":"https://api.github.com/repos/jupyterhub/binderhub/pulls/comments/150479690","pull_request_review_id":76032921,"id":150479690,"diff_hunk":"@@ -1,5 +1,7 @@\n # config file for testing with minikube-config.yaml\n \n-c.BinderHub.hub_url = 'http://192.168.99.100:30123'\n+import subprocess\n+minikube_ip = subprocess.check_output(['minikube', 'ip']).decode('utf-8').strip()\n+c.BinderHub.hub_url = 'http://{}:30123'.format(minikube_ip)","path":"testing/minikube/binderhub_config.py","position":6,"original_position":6,"commit_id":"5d4129fcde53ae5c74bb4f5ec621e52358c31cc9","original_commit_id":"5d4129fcde53ae5c74bb4f5ec621e52358c31cc9","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-11-13T09:12:26Z","updated_at":"2017-11-13T09:25:34Z","html_url":"https://github.com/jupyterhub/binderhub/pull/266#discussion_r150479690","pull_request_url":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/binderhub/pulls/comments/150479690"},"html":{"href":"https://github.com/jupyterhub/binderhub/pull/266#discussion_r150479690"},"pull_request":{"href":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266","id":152074825,"html_url":"https://github.com/jupyterhub/binderhub/pull/266","diff_url":"https://github.com/jupyterhub/binderhub/pull/266.diff","patch_url":"https://github.com/jupyterhub/binderhub/pull/266.patch","issue_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/266","number":266,"state":"open","locked":false,"title":"[WIP] Add simple support for a generic git repository support.","user":{"login":"mariusvniekerk","id":73973,"avatar_url":"https://avatars3.githubusercontent.com/u/73973?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusvniekerk","html_url":"https://github.com/mariusvniekerk","followers_url":"https://api.github.com/users/mariusvniekerk/followers","following_url":"https://api.github.com/users/mariusvniekerk/following{/other_user}","gists_url":"https://api.github.com/users/mariusvniekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusvniekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusvniekerk/subscriptions","organizations_url":"https://api.github.com/users/mariusvniekerk/orgs","repos_url":"https://api.github.com/users/mariusvniekerk/repos","events_url":"https://api.github.com/users/mariusvniekerk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusvniekerk/received_events","type":"User","site_admin":false},"body":"Design\r\n-------\r\n\r\nThis works by instead of passing a `{user}/{repo}/{branch}` spec we instead pass the \r\nfull url to a git repo with a fragment as denoting the sha we wish to build\r\n\r\nTodo\r\n-----\r\n- [ ] Add tests\r\n- [ ] Discuss spec proposal\r\n- [ ] Enfore that the spec's fragment is actually a SHA1\r\n\r\nOut of scope\r\n-------------\r\nCredential propagation.  All repos used in this way must be publicly accessible for now.\r\nUI?","created_at":"2017-11-11T21:00:52Z","updated_at":"2017-11-13T09:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eaeb1be66e1da9c640d4dfe51fe4a16eb6a2416","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266/commits","review_comments_url":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266/comments","review_comment_url":"https://api.github.com/repos/jupyterhub/binderhub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/266/comments","statuses_url":"https://api.github.com/repos/jupyterhub/binderhub/statuses/5d4129fcde53ae5c74bb4f5ec621e52358c31cc9","head":{"label":"mariusvniekerk:gitprovider","ref":"gitprovider","sha":"5d4129fcde53ae5c74bb4f5ec621e52358c31cc9","user":{"login":"mariusvniekerk","id":73973,"avatar_url":"https://avatars3.githubusercontent.com/u/73973?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusvniekerk","html_url":"https://github.com/mariusvniekerk","followers_url":"https://api.github.com/users/mariusvniekerk/followers","following_url":"https://api.github.com/users/mariusvniekerk/following{/other_user}","gists_url":"https://api.github.com/users/mariusvniekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusvniekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusvniekerk/subscriptions","organizations_url":"https://api.github.com/users/mariusvniekerk/orgs","repos_url":"https://api.github.com/users/mariusvniekerk/repos","events_url":"https://api.github.com/users/mariusvniekerk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusvniekerk/received_events","type":"User","site_admin":false},"repo":{"id":110270696,"name":"binderhub","full_name":"mariusvniekerk/binderhub","owner":{"login":"mariusvniekerk","id":73973,"avatar_url":"https://avatars3.githubusercontent.com/u/73973?v=4","gravatar_id":"","url":"https://api.github.com/users/mariusvniekerk","html_url":"https://github.com/mariusvniekerk","followers_url":"https://api.github.com/users/mariusvniekerk/followers","following_url":"https://api.github.com/users/mariusvniekerk/following{/other_user}","gists_url":"https://api.github.com/users/mariusvniekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusvniekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusvniekerk/subscriptions","organizations_url":"https://api.github.com/users/mariusvniekerk/orgs","repos_url":"https://api.github.com/users/mariusvniekerk/repos","events_url":"https://api.github.com/users/mariusvniekerk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusvniekerk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariusvniekerk/binderhub","description":"Deterministically build docker images from a git repository + commit","fork":true,"url":"https://api.github.com/repos/mariusvniekerk/binderhub","forks_url":"https://api.github.com/repos/mariusvniekerk/binderhub/forks","keys_url":"https://api.github.com/repos/mariusvniekerk/binderhub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariusvniekerk/binderhub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariusvniekerk/binderhub/teams","hooks_url":"https://api.github.com/repos/mariusvniekerk/binderhub/hooks","issue_events_url":"https://api.github.com/repos/mariusvniekerk/binderhub/issues/events{/number}","events_url":"https://api.github.com/repos/mariusvniekerk/binderhub/events","assignees_url":"https://api.github.com/repos/mariusvniekerk/binderhub/assignees{/user}","branches_url":"https://api.github.com/repos/mariusvniekerk/binderhub/branches{/branch}","tags_url":"https://api.github.com/repos/mariusvniekerk/binderhub/tags","blobs_url":"https://api.github.com/repos/mariusvniekerk/binderhub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariusvniekerk/binderhub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariusvniekerk/binderhub/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariusvniekerk/binderhub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariusvniekerk/binderhub/statuses/{sha}","languages_url":"https://api.github.com/repos/mariusvniekerk/binderhub/languages","stargazers_url":"https://api.github.com/repos/mariusvniekerk/binderhub/stargazers","contributors_url":"https://api.github.com/repos/mariusvniekerk/binderhub/contributors","subscribers_url":"https://api.github.com/repos/mariusvniekerk/binderhub/subscribers","subscription_url":"https://api.github.com/repos/mariusvniekerk/binderhub/subscription","commits_url":"https://api.github.com/repos/mariusvniekerk/binderhub/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariusvniekerk/binderhub/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariusvniekerk/binderhub/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariusvniekerk/binderhub/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariusvniekerk/binderhub/contents/{+path}","compare_url":"https://api.github.com/repos/mariusvniekerk/binderhub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariusvniekerk/binderhub/merges","archive_url":"https://api.github.com/repos/mariusvniekerk/binderhub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariusvniekerk/binderhub/downloads","issues_url":"https://api.github.com/repos/mariusvniekerk/binderhub/issues{/number}","pulls_url":"https://api.github.com/repos/mariusvniekerk/binderhub/pulls{/number}","milestones_url":"https://api.github.com/repos/mariusvniekerk/binderhub/milestones{/number}","notifications_url":"https://api.github.com/repos/mariusvniekerk/binderhub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariusvniekerk/binderhub/labels{/name}","releases_url":"https://api.github.com/repos/mariusvniekerk/binderhub/releases{/id}","deployments_url":"https://api.github.com/repos/mariusvniekerk/binderhub/deployments","created_at":"2017-11-10T16:53:50Z","updated_at":"2017-11-10T16:53:52Z","pushed_at":"2017-11-10T22:48:54Z","git_url":"git://github.com/mariusvniekerk/binderhub.git","ssh_url":"git@github.com:mariusvniekerk/binderhub.git","clone_url":"https://github.com/mariusvniekerk/binderhub.git","svn_url":"https://github.com/mariusvniekerk/binderhub","homepage":"https://binderhub.readthedocs.io","size":4583,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyterhub:master","ref":"master","sha":"7a2b134652e19eaccc209e50358607bdda2bfd9b","user":{"login":"jupyterhub","id":17927519,"avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"repo":{"id":89419368,"name":"binderhub","full_name":"jupyterhub/binderhub","owner":{"login":"jupyterhub","id":17927519,"avatar_url":"https://avatars2.githubusercontent.com/u/17927519?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyterhub/binderhub","description":"Deterministically build docker images from a git repository + commit","fork":false,"url":"https://api.github.com/repos/jupyterhub/binderhub","forks_url":"https://api.github.com/repos/jupyterhub/binderhub/forks","keys_url":"https://api.github.com/repos/jupyterhub/binderhub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterhub/binderhub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterhub/binderhub/teams","hooks_url":"https://api.github.com/repos/jupyterhub/binderhub/hooks","issue_events_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterhub/binderhub/events","assignees_url":"https://api.github.com/repos/jupyterhub/binderhub/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterhub/binderhub/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterhub/binderhub/tags","blobs_url":"https://api.github.com/repos/jupyterhub/binderhub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterhub/binderhub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterhub/binderhub/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterhub/binderhub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterhub/binderhub/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterhub/binderhub/languages","stargazers_url":"https://api.github.com/repos/jupyterhub/binderhub/stargazers","contributors_url":"https://api.github.com/repos/jupyterhub/binderhub/contributors","subscribers_url":"https://api.github.com/repos/jupyterhub/binderhub/subscribers","subscription_url":"https://api.github.com/repos/jupyterhub/binderhub/subscription","commits_url":"https://api.github.com/repos/jupyterhub/binderhub/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterhub/binderhub/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterhub/binderhub/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterhub/binderhub/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterhub/binderhub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterhub/binderhub/merges","archive_url":"https://api.github.com/repos/jupyterhub/binderhub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterhub/binderhub/downloads","issues_url":"https://api.github.com/repos/jupyterhub/binderhub/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterhub/binderhub/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterhub/binderhub/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterhub/binderhub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterhub/binderhub/labels{/name}","releases_url":"https://api.github.com/repos/jupyterhub/binderhub/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterhub/binderhub/deployments","created_at":"2017-04-26T00:28:26Z","updated_at":"2017-11-13T04:19:25Z","pushed_at":"2017-11-13T00:48:44Z","git_url":"git://github.com/jupyterhub/binderhub.git","ssh_url":"git@github.com:jupyterhub/binderhub.git","clone_url":"https://github.com/jupyterhub/binderhub.git","svn_url":"https://github.com/jupyterhub/binderhub","homepage":"https://binderhub.readthedocs.io","size":4578,"stargazers_count":119,"watchers_count":119,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":74,"forks":20,"open_issues":74,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266"},"html":{"href":"https://github.com/jupyterhub/binderhub/pull/266"},"issue":{"href":"https://api.github.com/repos/jupyterhub/binderhub/issues/266"},"comments":{"href":"https://api.github.com/repos/jupyterhub/binderhub/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyterhub/binderhub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyterhub/binderhub/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/jupyterhub/binderhub/statuses/5d4129fcde53ae5c74bb4f5ec621e52358c31cc9"}},"author_association":"NONE"}}
{"actor":{"display_login":"minrk"}}