{"action":"created","comment":{"url":"https://api.github.com/repos/behnam/rust-unic/pulls/comments/132260266","pull_request_review_id":55321937,"id":132260266,"diff_hunk":"@@ -0,0 +1,79 @@\n+// Copyright 2017 The UNIC Project Developers.\n+//\n+// See the COPYRIGHT file at the top-level directory of this distribution.\n+//\n+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or\n+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license\n+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your\n+// option. This file may not be copied, modified, or distributed\n+// except according to those terms.\n+\n+\n+//! Taxonomy and Contracts for Character Property types.\n+//!\n+//! See also the list of types of character properties defined in the UCD:\n+//! <http://unicode.org/reports/tr44/#About_Property_Table>, in [Unicode® Standard Annex #44 —\n+//! Unicode Character Database](http://unicode.org/reports/tr44/#About_Property_Table)\n+\n+\n+use std::fmt::{Debug, Display};\n+use std::hash::Hash;\n+\n+\n+/// A Character Property defined on all characters.\n+///\n+/// Examples: *Age*, *Name*, *General_Category*, *Bidi_Class*\n+pub trait CharProperty","path":"unic/utils/src/char_property.rs","position":26,"original_position":26,"commit_id":"39494f510a7cfffb5d1710cdc9e56ae9b1b3577b","original_commit_id":"39494f510a7cfffb5d1710cdc9e56ae9b1b3577b","user":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"body":"The thing about `Eq`/`Ord` and their `Partial` equivalents is that the function signature stays the same, and it's only the semantics that different.\r\n\r\nHere, we have a different signature for `of`, which we can pull of to work somehow, but I don't think it's good practice.\r\n\r\nHave you seen anything more like this case on std/3rd-party libs?","created_at":"2017-08-09T18:01:49Z","updated_at":"2017-08-09T18:01:49Z","html_url":"https://github.com/behnam/rust-unic/pull/89#discussion_r132260266","pull_request_url":"https://api.github.com/repos/behnam/rust-unic/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/comments/132260266"},"html":{"href":"https://github.com/behnam/rust-unic/pull/89#discussion_r132260266"},"pull_request":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/behnam/rust-unic/pulls/89","id":134775292,"html_url":"https://github.com/behnam/rust-unic/pull/89","diff_url":"https://github.com/behnam/rust-unic/pull/89.diff","patch_url":"https://github.com/behnam/rust-unic/pull/89.patch","issue_url":"https://api.github.com/repos/behnam/rust-unic/issues/89","number":89,"state":"open","locked":false,"title":"[char_property] Implement *CharProperty traits","user":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"body":"Character Properties are of different kinds and shapes, and as UNIC\r\ncomponents grow, we need a better way to be able to categorize them by\r\ntheir shape, and a way to make sure we have consistent, noncolliding\r\nAPI for them.\r\n\r\nThis is the first step into building a CharProperty taxonomy, with as\r\nlittle as possibly needed to provide the assurances desired.\r\n\r\nWe hope that the implementation can be improved over time with new\r\nfeatures added to the language. There's already some proposals in this\r\nfront. See these discussions for more details:\r\n\r\n* [Traits as contract, without changes to call-sites](https://users.rust-lang.org/t/traits-as-contract-without-changes-to-call-sites/11938/11)\r\n\r\n* [RFC: delegation of implementation](https://github.com/rust-lang/rfcs#1406)\r\n","created_at":"2017-08-08T22:45:23Z","updated_at":"2017-08-09T18:01:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9eaec3cfef540ebf6ed14085f7d811e31951bc35","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/behnam/rust-unic/pulls/89/commits","review_comments_url":"https://api.github.com/repos/behnam/rust-unic/pulls/89/comments","review_comment_url":"https://api.github.com/repos/behnam/rust-unic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/behnam/rust-unic/issues/89/comments","statuses_url":"https://api.github.com/repos/behnam/rust-unic/statuses/39494f510a7cfffb5d1710cdc9e56ae9b1b3577b","head":{"label":"behnam:charprop","ref":"charprop","sha":"39494f510a7cfffb5d1710cdc9e56ae9b1b3577b","user":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"repo":{"id":94862886,"name":"rust-unic","full_name":"behnam/rust-unic","owner":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behnam/rust-unic","description":"UNIC: Unicode and Internationalization Crates for Rust","fork":false,"url":"https://api.github.com/repos/behnam/rust-unic","forks_url":"https://api.github.com/repos/behnam/rust-unic/forks","keys_url":"https://api.github.com/repos/behnam/rust-unic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behnam/rust-unic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behnam/rust-unic/teams","hooks_url":"https://api.github.com/repos/behnam/rust-unic/hooks","issue_events_url":"https://api.github.com/repos/behnam/rust-unic/issues/events{/number}","events_url":"https://api.github.com/repos/behnam/rust-unic/events","assignees_url":"https://api.github.com/repos/behnam/rust-unic/assignees{/user}","branches_url":"https://api.github.com/repos/behnam/rust-unic/branches{/branch}","tags_url":"https://api.github.com/repos/behnam/rust-unic/tags","blobs_url":"https://api.github.com/repos/behnam/rust-unic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behnam/rust-unic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behnam/rust-unic/git/refs{/sha}","trees_url":"https://api.github.com/repos/behnam/rust-unic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behnam/rust-unic/statuses/{sha}","languages_url":"https://api.github.com/repos/behnam/rust-unic/languages","stargazers_url":"https://api.github.com/repos/behnam/rust-unic/stargazers","contributors_url":"https://api.github.com/repos/behnam/rust-unic/contributors","subscribers_url":"https://api.github.com/repos/behnam/rust-unic/subscribers","subscription_url":"https://api.github.com/repos/behnam/rust-unic/subscription","commits_url":"https://api.github.com/repos/behnam/rust-unic/commits{/sha}","git_commits_url":"https://api.github.com/repos/behnam/rust-unic/git/commits{/sha}","comments_url":"https://api.github.com/repos/behnam/rust-unic/comments{/number}","issue_comment_url":"https://api.github.com/repos/behnam/rust-unic/issues/comments{/number}","contents_url":"https://api.github.com/repos/behnam/rust-unic/contents/{+path}","compare_url":"https://api.github.com/repos/behnam/rust-unic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behnam/rust-unic/merges","archive_url":"https://api.github.com/repos/behnam/rust-unic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behnam/rust-unic/downloads","issues_url":"https://api.github.com/repos/behnam/rust-unic/issues{/number}","pulls_url":"https://api.github.com/repos/behnam/rust-unic/pulls{/number}","milestones_url":"https://api.github.com/repos/behnam/rust-unic/milestones{/number}","notifications_url":"https://api.github.com/repos/behnam/rust-unic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behnam/rust-unic/labels{/name}","releases_url":"https://api.github.com/repos/behnam/rust-unic/releases{/id}","deployments_url":"https://api.github.com/repos/behnam/rust-unic/deployments","created_at":"2017-06-20T07:33:45Z","updated_at":"2017-08-08T04:02:34Z","pushed_at":"2017-08-09T16:10:02Z","git_url":"git://github.com/behnam/rust-unic.git","ssh_url":"git@github.com:behnam/rust-unic.git","clone_url":"https://github.com/behnam/rust-unic.git","svn_url":"https://github.com/behnam/rust-unic","homepage":"https://crates.io/crates/unic","size":3919,"stargazers_count":32,"watchers_count":32,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":10,"forks":7,"open_issues":10,"watchers":32,"default_branch":"master"}},"base":{"label":"behnam:master","ref":"master","sha":"b6355a9fbe8cf69e174b95d9b5dd9d268f48f336","user":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"repo":{"id":94862886,"name":"rust-unic","full_name":"behnam/rust-unic","owner":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behnam/rust-unic","description":"UNIC: Unicode and Internationalization Crates for Rust","fork":false,"url":"https://api.github.com/repos/behnam/rust-unic","forks_url":"https://api.github.com/repos/behnam/rust-unic/forks","keys_url":"https://api.github.com/repos/behnam/rust-unic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behnam/rust-unic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behnam/rust-unic/teams","hooks_url":"https://api.github.com/repos/behnam/rust-unic/hooks","issue_events_url":"https://api.github.com/repos/behnam/rust-unic/issues/events{/number}","events_url":"https://api.github.com/repos/behnam/rust-unic/events","assignees_url":"https://api.github.com/repos/behnam/rust-unic/assignees{/user}","branches_url":"https://api.github.com/repos/behnam/rust-unic/branches{/branch}","tags_url":"https://api.github.com/repos/behnam/rust-unic/tags","blobs_url":"https://api.github.com/repos/behnam/rust-unic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behnam/rust-unic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behnam/rust-unic/git/refs{/sha}","trees_url":"https://api.github.com/repos/behnam/rust-unic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behnam/rust-unic/statuses/{sha}","languages_url":"https://api.github.com/repos/behnam/rust-unic/languages","stargazers_url":"https://api.github.com/repos/behnam/rust-unic/stargazers","contributors_url":"https://api.github.com/repos/behnam/rust-unic/contributors","subscribers_url":"https://api.github.com/repos/behnam/rust-unic/subscribers","subscription_url":"https://api.github.com/repos/behnam/rust-unic/subscription","commits_url":"https://api.github.com/repos/behnam/rust-unic/commits{/sha}","git_commits_url":"https://api.github.com/repos/behnam/rust-unic/git/commits{/sha}","comments_url":"https://api.github.com/repos/behnam/rust-unic/comments{/number}","issue_comment_url":"https://api.github.com/repos/behnam/rust-unic/issues/comments{/number}","contents_url":"https://api.github.com/repos/behnam/rust-unic/contents/{+path}","compare_url":"https://api.github.com/repos/behnam/rust-unic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behnam/rust-unic/merges","archive_url":"https://api.github.com/repos/behnam/rust-unic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behnam/rust-unic/downloads","issues_url":"https://api.github.com/repos/behnam/rust-unic/issues{/number}","pulls_url":"https://api.github.com/repos/behnam/rust-unic/pulls{/number}","milestones_url":"https://api.github.com/repos/behnam/rust-unic/milestones{/number}","notifications_url":"https://api.github.com/repos/behnam/rust-unic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behnam/rust-unic/labels{/name}","releases_url":"https://api.github.com/repos/behnam/rust-unic/releases{/id}","deployments_url":"https://api.github.com/repos/behnam/rust-unic/deployments","created_at":"2017-06-20T07:33:45Z","updated_at":"2017-08-08T04:02:34Z","pushed_at":"2017-08-09T16:10:02Z","git_url":"git://github.com/behnam/rust-unic.git","ssh_url":"git@github.com:behnam/rust-unic.git","clone_url":"https://github.com/behnam/rust-unic.git","svn_url":"https://github.com/behnam/rust-unic","homepage":"https://crates.io/crates/unic","size":3919,"stargazers_count":32,"watchers_count":32,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":10,"forks":7,"open_issues":10,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/89"},"html":{"href":"https://github.com/behnam/rust-unic/pull/89"},"issue":{"href":"https://api.github.com/repos/behnam/rust-unic/issues/89"},"comments":{"href":"https://api.github.com/repos/behnam/rust-unic/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/behnam/rust-unic/statuses/39494f510a7cfffb5d1710cdc9e56ae9b1b3577b"}}}}
{"actor":{"display_login":"behnam"}}