{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/android/issues/797","repository_url":"https://api.github.com/repos/nextcloud/android","labels_url":"https://api.github.com/repos/nextcloud/android/issues/797/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/android/issues/797/comments","events_url":"https://api.github.com/repos/nextcloud/android/issues/797/events","html_url":"https://github.com/nextcloud/android/pull/797","id":219041373,"number":797,"title":"Add further media types to auto upload","user":{"login":"AndyScherzinger","id":1315170,"avatar_url":"https://avatars0.githubusercontent.com/u/1315170?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyScherzinger","html_url":"https://github.com/AndyScherzinger","followers_url":"https://api.github.com/users/AndyScherzinger/followers","following_url":"https://api.github.com/users/AndyScherzinger/following{/other_user}","gists_url":"https://api.github.com/users/AndyScherzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyScherzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyScherzinger/subscriptions","organizations_url":"https://api.github.com/users/AndyScherzinger/orgs","repos_url":"https://api.github.com/users/AndyScherzinger/repos","events_url":"https://api.github.com/users/AndyScherzinger/events{/privacy}","received_events_url":"https://api.github.com/users/AndyScherzinger/received_events","type":"User","site_admin":false},"labels":[{"id":392413733,"url":"https://api.github.com/repos/nextcloud/android/labels/1.%20developing","name":"1. developing","color":"0052cc","default":false},{"id":388657201,"url":"https://api.github.com/repos/nextcloud/android/labels/design","name":"design","color":"cc317c","default":false},{"id":388626763,"url":"https://api.github.com/repos/nextcloud/android/labels/enhancement","name":"enhancement","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nextcloud/android/milestones/8","html_url":"https://github.com/nextcloud/android/milestone/8","labels_url":"https://api.github.com/repos/nextcloud/android/milestones/8/labels","id":2012363,"number":8,"title":"Nextcloud App 1.5.0","description":"","creator":{"login":"AndyScherzinger","id":1315170,"avatar_url":"https://avatars0.githubusercontent.com/u/1315170?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyScherzinger","html_url":"https://github.com/AndyScherzinger","followers_url":"https://api.github.com/users/AndyScherzinger/followers","following_url":"https://api.github.com/users/AndyScherzinger/following{/other_user}","gists_url":"https://api.github.com/users/AndyScherzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyScherzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyScherzinger/subscriptions","organizations_url":"https://api.github.com/users/AndyScherzinger/orgs","repos_url":"https://api.github.com/users/AndyScherzinger/repos","events_url":"https://api.github.com/users/AndyScherzinger/events{/privacy}","received_events_url":"https://api.github.com/users/AndyScherzinger/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":234,"state":"open","created_at":"2016-09-18T23:39:32Z","updated_at":"2017-07-10T11:20:51Z","due_on":null,"closed_at":null},"comments":73,"created_at":"2017-04-03T19:46:57Z","updated_at":"2017-07-10T12:50:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nextcloud/android/pulls/797","html_url":"https://github.com/nextcloud/android/pull/797","diff_url":"https://github.com/nextcloud/android/pull/797.diff","patch_url":"https://github.com/nextcloud/android/pull/797.patch"},"body":"as discussed in #285 and numerous other issues, this PR adds further media types to the auto upload screen, starting with videos. For now video and images are split and shown twice for folders contain both e.g. the camera folder. We could also merge them into one (if we want that which is subject to discussion).\r\n\r\nAudio is also on the agenda but I would leave it out for now until it is clear how to implement this. The reason for that is that we are querying the media store and then display all folders that contain images (and are visible to the media store, as-in indexed). So for music in case each album has it's won folder we would display all those folders which might be a lot while it does makes sense do handle it this way for video and images...\r\n\r\nhere is a screenshot of the work in progress and btw thumbnail generation and caching has been extended for video. If a format can't be read or the file is somehow corrupt we just show the standard icon:\r\n![device-2017-06-09-172344](https://user-images.githubusercontent.com/1315170/26982729-9944cc40-4d39-11e7-968f-cd22a1ca0d58.png)\r\n\r\n\r\n\r\n**OPEN ISSUES**\r\n- [x] add delete capability for custom folders (delete button on the bottom left in the folder preference dialog)\r\n- [x] hide delete for non custom folders\r\n- [x] hide delete for unpersisted custom folders\r\n- [x] block save button in preference screen as long as not all necessary data has been set (grey out \"save\" text until set)\r\n- [x] fix filter for local folder picker (upload activity re-use) to only show folders but no files\r\n- [x] make Jobs aware of the folder type and only upload all file types for custom folders, video-only for video folders and image-only for image folders\r\n- [x] make sure a job gets removed/terminated when a custom folder setup gets deactivated or deleted\r\n- [x] rewrite auto upload\r\n- [x] adapt to customer-hack-flag which hides the per-folder setting, which is needed for custom folders and also the flag needs to be ignored for custom folders since the user (IMHO) will like to have full control over this type of auto upload folder!\r\n- [ ] add check to prevent several custom folder definitions which define syncs on different levels of one file tree since this will either lead to duplicate uploads or even errors (in case delete after upload)\r\n- [x] check why successful uploads disappear from uploads view after visiting that screen a few times\r\n- [ ] store synced folder enable & disable time\r\n- [ ] lock files while uploading\r\n- [ ] Verify auto upload behaviors\r\n- [x] show only current user uploads\r\n- [x] automatically retry manual uploads\r\n- [x] remove uploads screen menu\r\n- [ ] show \"Setup custom folder\" even if no media folders are detected"},"comment":{"url":"https://api.github.com/repos/nextcloud/android/issues/comments/314095832","html_url":"https://github.com/nextcloud/android/pull/797#issuecomment-314095832","issue_url":"https://api.github.com/repos/nextcloud/android/issues/797","id":314095832,"user":{"login":"tobiasKaminsky","id":5836855,"avatar_url":"https://avatars0.githubusercontent.com/u/5836855?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasKaminsky","html_url":"https://github.com/tobiasKaminsky","followers_url":"https://api.github.com/users/tobiasKaminsky/followers","following_url":"https://api.github.com/users/tobiasKaminsky/following{/other_user}","gists_url":"https://api.github.com/users/tobiasKaminsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasKaminsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasKaminsky/subscriptions","organizations_url":"https://api.github.com/users/tobiasKaminsky/orgs","repos_url":"https://api.github.com/users/tobiasKaminsky/repos","events_url":"https://api.github.com/users/tobiasKaminsky/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasKaminsky/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T12:50:53Z","updated_at":"2017-07-10T12:50:53Z","body":"To get this PR bigger once more: we have FolderSyncActivity but all other stuff is named SyncedFolder.\r\nTo have this consistent I would like to change the name of the activity to SyncedFolderActivity?"}}
{"actor":{"display_login":"tobiasKaminsky"}}