{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/dividat/driver/pulls/21","id":112964939,"html_url":"https://github.com/dividat/driver/pull/21","diff_url":"https://github.com/dividat/driver/pull/21.diff","patch_url":"https://github.com/dividat/driver/pull/21.patch","issue_url":"https://api.github.com/repos/dividat/driver/issues/21","number":21,"state":"open","locked":false,"title":"[WIP] Code signing","user":{"login":"knuton","id":47458,"avatar_url":"https://avatars1.githubusercontent.com/u/47458?v=3","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"body":"This adds code signing steps to the package and release scripts. Code signing is done manually using a (hopefully short-lived) fork of [signcode](https://github.com/kevinsawicki/signcode) for two reasons:\r\n\r\n1. `rcedit` bundled with electron-winstaller is broken and we already set the icon after the installer has been created, hence have to sign the installer ourselves too\r\n2. Squirrel makes a hard-coded call to Microsoft's `signtool.exe`, which is bundled but does not run on Wine, so there is no out-of-the-box support for signing on non-Windows systems\r\n\r\nImplementation is feature complete yet only tested with self-signed certificate.\r\n\r\n#### Remaining\r\n\r\n- [ ] Test with real certificate","created_at":"2017-03-28T13:05:15Z","updated_at":"2017-03-28T13:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dividat/driver/pulls/21/commits","review_comments_url":"https://api.github.com/repos/dividat/driver/pulls/21/comments","review_comment_url":"https://api.github.com/repos/dividat/driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dividat/driver/issues/21/comments","statuses_url":"https://api.github.com/repos/dividat/driver/statuses/7f8738967e76448e44ecfb7427344d71dbc9391d","head":{"label":"knuton:code-signing","ref":"code-signing","sha":"7f8738967e76448e44ecfb7427344d71dbc9391d","user":{"login":"knuton","id":47458,"avatar_url":"https://avatars1.githubusercontent.com/u/47458?v=3","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"repo":{"id":82556006,"name":"driver","full_name":"knuton/driver","owner":{"login":"knuton","id":47458,"avatar_url":"https://avatars1.githubusercontent.com/u/47458?v=3","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knuton/driver","description":"Dividat drivers and hardware test suites","fork":true,"url":"https://api.github.com/repos/knuton/driver","forks_url":"https://api.github.com/repos/knuton/driver/forks","keys_url":"https://api.github.com/repos/knuton/driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knuton/driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knuton/driver/teams","hooks_url":"https://api.github.com/repos/knuton/driver/hooks","issue_events_url":"https://api.github.com/repos/knuton/driver/issues/events{/number}","events_url":"https://api.github.com/repos/knuton/driver/events","assignees_url":"https://api.github.com/repos/knuton/driver/assignees{/user}","branches_url":"https://api.github.com/repos/knuton/driver/branches{/branch}","tags_url":"https://api.github.com/repos/knuton/driver/tags","blobs_url":"https://api.github.com/repos/knuton/driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knuton/driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knuton/driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/knuton/driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knuton/driver/statuses/{sha}","languages_url":"https://api.github.com/repos/knuton/driver/languages","stargazers_url":"https://api.github.com/repos/knuton/driver/stargazers","contributors_url":"https://api.github.com/repos/knuton/driver/contributors","subscribers_url":"https://api.github.com/repos/knuton/driver/subscribers","subscription_url":"https://api.github.com/repos/knuton/driver/subscription","commits_url":"https://api.github.com/repos/knuton/driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/knuton/driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/knuton/driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/knuton/driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/knuton/driver/contents/{+path}","compare_url":"https://api.github.com/repos/knuton/driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knuton/driver/merges","archive_url":"https://api.github.com/repos/knuton/driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knuton/driver/downloads","issues_url":"https://api.github.com/repos/knuton/driver/issues{/number}","pulls_url":"https://api.github.com/repos/knuton/driver/pulls{/number}","milestones_url":"https://api.github.com/repos/knuton/driver/milestones{/number}","notifications_url":"https://api.github.com/repos/knuton/driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knuton/driver/labels{/name}","releases_url":"https://api.github.com/repos/knuton/driver/releases{/id}","deployments_url":"https://api.github.com/repos/knuton/driver/deployments","created_at":"2017-02-20T12:35:19Z","updated_at":"2017-02-20T12:35:21Z","pushed_at":"2017-03-28T12:54:54Z","git_url":"git://github.com/knuton/driver.git","ssh_url":"git@github.com:knuton/driver.git","clone_url":"https://github.com/knuton/driver.git","svn_url":"https://github.com/knuton/driver","homepage":"","size":3132,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"dividat:develop","ref":"develop","sha":"fc37058126741f0369a84f675dd99632953b7938","user":{"login":"dividat","id":17985246,"avatar_url":"https://avatars2.githubusercontent.com/u/17985246?v=3","gravatar_id":"","url":"https://api.github.com/users/dividat","html_url":"https://github.com/dividat","followers_url":"https://api.github.com/users/dividat/followers","following_url":"https://api.github.com/users/dividat/following{/other_user}","gists_url":"https://api.github.com/users/dividat/gists{/gist_id}","starred_url":"https://api.github.com/users/dividat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividat/subscriptions","organizations_url":"https://api.github.com/users/dividat/orgs","repos_url":"https://api.github.com/users/dividat/repos","events_url":"https://api.github.com/users/dividat/events{/privacy}","received_events_url":"https://api.github.com/users/dividat/received_events","type":"Organization","site_admin":false},"repo":{"id":66946468,"name":"driver","full_name":"dividat/driver","owner":{"login":"dividat","id":17985246,"avatar_url":"https://avatars2.githubusercontent.com/u/17985246?v=3","gravatar_id":"","url":"https://api.github.com/users/dividat","html_url":"https://github.com/dividat","followers_url":"https://api.github.com/users/dividat/followers","following_url":"https://api.github.com/users/dividat/following{/other_user}","gists_url":"https://api.github.com/users/dividat/gists{/gist_id}","starred_url":"https://api.github.com/users/dividat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividat/subscriptions","organizations_url":"https://api.github.com/users/dividat/orgs","repos_url":"https://api.github.com/users/dividat/repos","events_url":"https://api.github.com/users/dividat/events{/privacy}","received_events_url":"https://api.github.com/users/dividat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dividat/driver","description":"Dividat drivers and hardware test suites","fork":false,"url":"https://api.github.com/repos/dividat/driver","forks_url":"https://api.github.com/repos/dividat/driver/forks","keys_url":"https://api.github.com/repos/dividat/driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dividat/driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dividat/driver/teams","hooks_url":"https://api.github.com/repos/dividat/driver/hooks","issue_events_url":"https://api.github.com/repos/dividat/driver/issues/events{/number}","events_url":"https://api.github.com/repos/dividat/driver/events","assignees_url":"https://api.github.com/repos/dividat/driver/assignees{/user}","branches_url":"https://api.github.com/repos/dividat/driver/branches{/branch}","tags_url":"https://api.github.com/repos/dividat/driver/tags","blobs_url":"https://api.github.com/repos/dividat/driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dividat/driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dividat/driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/dividat/driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dividat/driver/statuses/{sha}","languages_url":"https://api.github.com/repos/dividat/driver/languages","stargazers_url":"https://api.github.com/repos/dividat/driver/stargazers","contributors_url":"https://api.github.com/repos/dividat/driver/contributors","subscribers_url":"https://api.github.com/repos/dividat/driver/subscribers","subscription_url":"https://api.github.com/repos/dividat/driver/subscription","commits_url":"https://api.github.com/repos/dividat/driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/dividat/driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/dividat/driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/dividat/driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/dividat/driver/contents/{+path}","compare_url":"https://api.github.com/repos/dividat/driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dividat/driver/merges","archive_url":"https://api.github.com/repos/dividat/driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dividat/driver/downloads","issues_url":"https://api.github.com/repos/dividat/driver/issues{/number}","pulls_url":"https://api.github.com/repos/dividat/driver/pulls{/number}","milestones_url":"https://api.github.com/repos/dividat/driver/milestones{/number}","notifications_url":"https://api.github.com/repos/dividat/driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dividat/driver/labels{/name}","releases_url":"https://api.github.com/repos/dividat/driver/releases{/id}","deployments_url":"https://api.github.com/repos/dividat/driver/deployments","created_at":"2016-08-30T14:08:31Z","updated_at":"2017-02-16T08:57:11Z","pushed_at":"2017-03-27T14:48:37Z","git_url":"git://github.com/dividat/driver.git","ssh_url":"git@github.com:dividat/driver.git","clone_url":"https://github.com/dividat/driver.git","svn_url":"https://github.com/dividat/driver","homepage":"","size":3153,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dividat/driver/pulls/21"},"html":{"href":"https://github.com/dividat/driver/pull/21"},"issue":{"href":"https://api.github.com/repos/dividat/driver/issues/21"},"comments":{"href":"https://api.github.com/repos/dividat/driver/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/dividat/driver/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/dividat/driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dividat/driver/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/dividat/driver/statuses/7f8738967e76448e44ecfb7427344d71dbc9391d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":93,"deletions":32,"changed_files":6}}
{"actor":{"display_login":"knuton"}}