{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/94938734","pull_request_review_id":15481493,"id":94938734,"diff_hunk":"@@ -258,7 +265,24 @@ function filterDesignTypeInFlow( flow ) {\n \n function filterFlowName( flowName ) {\n \tconst defaultFlows = [ 'main', 'website' ];\n-\t// do nothing. No flows to filter at the moment.\n+\n+\t/**\n+\t * Only run the User First Signup for logged out users.\n+\t */\n+\tif ( ! user.get() ) {\n+\t\tif ( includes( defaultFlows, flowName ) && abtest( 'userFirstSignup' ) === 'userFirst' ) {\n+\t\t\treturn 'userfirst';\n+\t\t}\n+\n+\t\t/**\n+\t\t * Users should not be able to reach `userfirst-secondary` without being logged in, since\n+\t\t * it doesn't contain the `user` step to register a user and site respectively.\n+ \t\t */\n+\t\tif ( flowName === 'userfirst-secondary' ) {\n+\t\t\treturn 'main';","path":"client/signup/config/flows.js","position":null,"original_position":41,"commit_id":"53d51fd94c51428a216e0c2600e979e47925ea2d","original_commit_id":"d7948006720beb336aa0701edcfe446214bcc60f","user":{"login":"bisko","id":184938,"avatar_url":"https://avatars.githubusercontent.com/u/184938?v=3","gravatar_id":"","url":"https://api.github.com/users/bisko","html_url":"https://github.com/bisko","followers_url":"https://api.github.com/users/bisko/followers","following_url":"https://api.github.com/users/bisko/following{/other_user}","gists_url":"https://api.github.com/users/bisko/gists{/gist_id}","starred_url":"https://api.github.com/users/bisko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisko/subscriptions","organizations_url":"https://api.github.com/users/bisko/orgs","repos_url":"https://api.github.com/users/bisko/repos","events_url":"https://api.github.com/users/bisko/events{/privacy}","received_events_url":"https://api.github.com/users/bisko/received_events","type":"User","site_admin":false},"body":"Good catch. It was a leftover from a previous version. Updated to send the user to `userfirst`.","created_at":"2017-01-06T12:23:14Z","updated_at":"2017-01-06T12:23:14Z","html_url":"https://github.com/Automattic/wp-calypso/pull/10260#discussion_r94938734","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/94938734"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/10260#discussion_r94938734"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260","id":99258216,"html_url":"https://github.com/Automattic/wp-calypso/pull/10260","diff_url":"https://github.com/Automattic/wp-calypso/pull/10260.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/10260.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/10260","number":10260,"state":"open","locked":false,"title":"Signup: User First signup AB test","user":{"login":"bisko","id":184938,"avatar_url":"https://avatars.githubusercontent.com/u/184938?v=3","gravatar_id":"","url":"https://api.github.com/users/bisko","html_url":"https://github.com/bisko","followers_url":"https://api.github.com/users/bisko/followers","following_url":"https://api.github.com/users/bisko/following{/other_user}","gists_url":"https://api.github.com/users/bisko/gists{/gist_id}","starred_url":"https://api.github.com/users/bisko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisko/subscriptions","organizations_url":"https://api.github.com/users/bisko/orgs","repos_url":"https://api.github.com/users/bisko/repos","events_url":"https://api.github.com/users/bisko/events{/privacy}","received_events_url":"https://api.github.com/users/bisko/received_events","type":"User","site_admin":false},"body":"This PR aims to enable an AB test for User First signup.\r\n\r\nWe're testing a new flow for user signup, which would put the user creation first and then continue the signup as an already logged in user. \r\n\r\nThis would allow to put new things that require users to be logged in to work, like Guided Tours, Checkout during signup, etc.\r\n\r\nTo test:\r\n\r\n1. Checkout branch or use Calypso.live link\r\n2. Start signup\r\n3. Try both AB test variations for `userFirstSignup`\r\n4. Verify Signup is working properly and you can create a site.\r\n6. Verify there are no JS errors in the console\r\n\r\ncc @meremagee ","created_at":"2016-12-23T16:05:50Z","updated_at":"2017-01-06T12:23:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4514f413d4340ecf78eafbcc9b388224a77e3538","assignee":{"login":"bisko","id":184938,"avatar_url":"https://avatars.githubusercontent.com/u/184938?v=3","gravatar_id":"","url":"https://api.github.com/users/bisko","html_url":"https://github.com/bisko","followers_url":"https://api.github.com/users/bisko/followers","following_url":"https://api.github.com/users/bisko/following{/other_user}","gists_url":"https://api.github.com/users/bisko/gists{/gist_id}","starred_url":"https://api.github.com/users/bisko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisko/subscriptions","organizations_url":"https://api.github.com/users/bisko/orgs","repos_url":"https://api.github.com/users/bisko/repos","events_url":"https://api.github.com/users/bisko/events{/privacy}","received_events_url":"https://api.github.com/users/bisko/received_events","type":"User","site_admin":false},"assignees":[{"login":"bisko","id":184938,"avatar_url":"https://avatars.githubusercontent.com/u/184938?v=3","gravatar_id":"","url":"https://api.github.com/users/bisko","html_url":"https://github.com/bisko","followers_url":"https://api.github.com/users/bisko/followers","following_url":"https://api.github.com/users/bisko/following{/other_user}","gists_url":"https://api.github.com/users/bisko/gists{/gist_id}","starred_url":"https://api.github.com/users/bisko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisko/subscriptions","organizations_url":"https://api.github.com/users/bisko/orgs","repos_url":"https://api.github.com/users/bisko/repos","events_url":"https://api.github.com/users/bisko/events{/privacy}","received_events_url":"https://api.github.com/users/bisko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/10260/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/53d51fd94c51428a216e0c2600e979e47925ea2d","head":{"label":"Automattic:try/signup-user-first-signup-ab-test","ref":"try/signup-user-first-signup-ab-test","sha":"53d51fd94c51428a216e0c2600e979e47925ea2d","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-01-06T10:23:33Z","pushed_at":"2017-01-06T12:22:52Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":38653,"stargazers_count":8288,"watchers_count":8288,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1055,"mirror_url":null,"open_issues_count":1611,"forks":1055,"open_issues":1611,"watchers":8288,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"bb4319a8ba6ea77519db161ffe14ce2785223c7a","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-01-06T10:23:33Z","pushed_at":"2017-01-06T12:22:52Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":38653,"stargazers_count":8288,"watchers_count":8288,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1055,"mirror_url":null,"open_issues_count":1611,"forks":1055,"open_issues":1611,"watchers":8288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/10260"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/10260"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/10260/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/10260/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/53d51fd94c51428a216e0c2600e979e47925ea2d"}}}}
{"actor":{"display_login":"bisko"}}