{"action":"closed","number":147,"pull_request":{"url":"https://api.github.com/repos/thrill/thrill/pulls/147","id":111787379,"html_url":"https://github.com/thrill/thrill/pull/147","diff_url":"https://github.com/thrill/thrill/pull/147.diff","patch_url":"https://github.com/thrill/thrill/pull/147.patch","issue_url":"https://api.github.com/repos/thrill/thrill/issues/147","number":147,"state":"closed","locked":false,"title":"improve join node mem usage by disposing location detection asap","user":{"login":"SDEagle","id":867049,"avatar_url":"https://avatars0.githubusercontent.com/u/867049?v=3","gravatar_id":"","url":"https://api.github.com/users/SDEagle","html_url":"https://github.com/SDEagle","followers_url":"https://api.github.com/users/SDEagle/followers","following_url":"https://api.github.com/users/SDEagle/following{/other_user}","gists_url":"https://api.github.com/users/SDEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/SDEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SDEagle/subscriptions","organizations_url":"https://api.github.com/users/SDEagle/orgs","repos_url":"https://api.github.com/users/SDEagle/repos","events_url":"https://api.github.com/users/SDEagle/events{/privacy}","received_events_url":"https://api.github.com/users/SDEagle/received_events","type":"User","site_admin":false},"body":"Previously the location detection - including it's super memory greedy hash table - would persist until end of object lifetime. This would cause problems in the PushData Phase as more memory than available was used there. I don't know if the join memory usage calculations are completely right now but in any case they are more right then before... ","created_at":"2017-03-21T14:12:48Z","updated_at":"2017-03-21T14:53:48Z","closed_at":"2017-03-21T14:53:48Z","merged_at":"2017-03-21T14:53:48Z","merge_commit_sha":"3a72c0659845ae9a8d53cecfea06cc10b7680dc8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thrill/thrill/pulls/147/commits","review_comments_url":"https://api.github.com/repos/thrill/thrill/pulls/147/comments","review_comment_url":"https://api.github.com/repos/thrill/thrill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thrill/thrill/issues/147/comments","statuses_url":"https://api.github.com/repos/thrill/thrill/statuses/8ad73330d4fef7e2138da89b42dcbe82f5a89db2","head":{"label":"SDEagle:improve_join_mem_usage","ref":"improve_join_mem_usage","sha":"8ad73330d4fef7e2138da89b42dcbe82f5a89db2","user":{"login":"SDEagle","id":867049,"avatar_url":"https://avatars0.githubusercontent.com/u/867049?v=3","gravatar_id":"","url":"https://api.github.com/users/SDEagle","html_url":"https://github.com/SDEagle","followers_url":"https://api.github.com/users/SDEagle/followers","following_url":"https://api.github.com/users/SDEagle/following{/other_user}","gists_url":"https://api.github.com/users/SDEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/SDEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SDEagle/subscriptions","organizations_url":"https://api.github.com/users/SDEagle/orgs","repos_url":"https://api.github.com/users/SDEagle/repos","events_url":"https://api.github.com/users/SDEagle/events{/privacy}","received_events_url":"https://api.github.com/users/SDEagle/received_events","type":"User","site_admin":false},"repo":{"id":74598183,"name":"thrill","full_name":"SDEagle/thrill","owner":{"login":"SDEagle","id":867049,"avatar_url":"https://avatars0.githubusercontent.com/u/867049?v=3","gravatar_id":"","url":"https://api.github.com/users/SDEagle","html_url":"https://github.com/SDEagle","followers_url":"https://api.github.com/users/SDEagle/followers","following_url":"https://api.github.com/users/SDEagle/following{/other_user}","gists_url":"https://api.github.com/users/SDEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/SDEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SDEagle/subscriptions","organizations_url":"https://api.github.com/users/SDEagle/orgs","repos_url":"https://api.github.com/users/SDEagle/repos","events_url":"https://api.github.com/users/SDEagle/events{/privacy}","received_events_url":"https://api.github.com/users/SDEagle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SDEagle/thrill","description":"Thrill - An EXPERIMENTAL Algorithmic Distributed Big Data Batch Processing Framework in C++","fork":true,"url":"https://api.github.com/repos/SDEagle/thrill","forks_url":"https://api.github.com/repos/SDEagle/thrill/forks","keys_url":"https://api.github.com/repos/SDEagle/thrill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SDEagle/thrill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SDEagle/thrill/teams","hooks_url":"https://api.github.com/repos/SDEagle/thrill/hooks","issue_events_url":"https://api.github.com/repos/SDEagle/thrill/issues/events{/number}","events_url":"https://api.github.com/repos/SDEagle/thrill/events","assignees_url":"https://api.github.com/repos/SDEagle/thrill/assignees{/user}","branches_url":"https://api.github.com/repos/SDEagle/thrill/branches{/branch}","tags_url":"https://api.github.com/repos/SDEagle/thrill/tags","blobs_url":"https://api.github.com/repos/SDEagle/thrill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SDEagle/thrill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SDEagle/thrill/git/refs{/sha}","trees_url":"https://api.github.com/repos/SDEagle/thrill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SDEagle/thrill/statuses/{sha}","languages_url":"https://api.github.com/repos/SDEagle/thrill/languages","stargazers_url":"https://api.github.com/repos/SDEagle/thrill/stargazers","contributors_url":"https://api.github.com/repos/SDEagle/thrill/contributors","subscribers_url":"https://api.github.com/repos/SDEagle/thrill/subscribers","subscription_url":"https://api.github.com/repos/SDEagle/thrill/subscription","commits_url":"https://api.github.com/repos/SDEagle/thrill/commits{/sha}","git_commits_url":"https://api.github.com/repos/SDEagle/thrill/git/commits{/sha}","comments_url":"https://api.github.com/repos/SDEagle/thrill/comments{/number}","issue_comment_url":"https://api.github.com/repos/SDEagle/thrill/issues/comments{/number}","contents_url":"https://api.github.com/repos/SDEagle/thrill/contents/{+path}","compare_url":"https://api.github.com/repos/SDEagle/thrill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SDEagle/thrill/merges","archive_url":"https://api.github.com/repos/SDEagle/thrill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SDEagle/thrill/downloads","issues_url":"https://api.github.com/repos/SDEagle/thrill/issues{/number}","pulls_url":"https://api.github.com/repos/SDEagle/thrill/pulls{/number}","milestones_url":"https://api.github.com/repos/SDEagle/thrill/milestones{/number}","notifications_url":"https://api.github.com/repos/SDEagle/thrill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SDEagle/thrill/labels{/name}","releases_url":"https://api.github.com/repos/SDEagle/thrill/releases{/id}","deployments_url":"https://api.github.com/repos/SDEagle/thrill/deployments","created_at":"2016-11-23T17:13:04Z","updated_at":"2016-11-23T17:13:06Z","pushed_at":"2017-03-21T14:18:01Z","git_url":"git://github.com/SDEagle/thrill.git","ssh_url":"git@github.com:SDEagle/thrill.git","clone_url":"https://github.com/SDEagle/thrill.git","svn_url":"https://github.com/SDEagle/thrill","homepage":"http://project-thrill.org","size":8186,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thrill:master","ref":"master","sha":"908283d7cd6d30f04db7f47373a8105f72574a7f","user":{"login":"thrill","id":9461511,"avatar_url":"https://avatars1.githubusercontent.com/u/9461511?v=3","gravatar_id":"","url":"https://api.github.com/users/thrill","html_url":"https://github.com/thrill","followers_url":"https://api.github.com/users/thrill/followers","following_url":"https://api.github.com/users/thrill/following{/other_user}","gists_url":"https://api.github.com/users/thrill/gists{/gist_id}","starred_url":"https://api.github.com/users/thrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrill/subscriptions","organizations_url":"https://api.github.com/users/thrill/orgs","repos_url":"https://api.github.com/users/thrill/repos","events_url":"https://api.github.com/users/thrill/events{/privacy}","received_events_url":"https://api.github.com/users/thrill/received_events","type":"Organization","site_admin":false},"repo":{"id":34522116,"name":"thrill","full_name":"thrill/thrill","owner":{"login":"thrill","id":9461511,"avatar_url":"https://avatars1.githubusercontent.com/u/9461511?v=3","gravatar_id":"","url":"https://api.github.com/users/thrill","html_url":"https://github.com/thrill","followers_url":"https://api.github.com/users/thrill/followers","following_url":"https://api.github.com/users/thrill/following{/other_user}","gists_url":"https://api.github.com/users/thrill/gists{/gist_id}","starred_url":"https://api.github.com/users/thrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrill/subscriptions","organizations_url":"https://api.github.com/users/thrill/orgs","repos_url":"https://api.github.com/users/thrill/repos","events_url":"https://api.github.com/users/thrill/events{/privacy}","received_events_url":"https://api.github.com/users/thrill/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thrill/thrill","description":"Thrill - An EXPERIMENTAL Algorithmic Distributed Big Data Batch Processing Framework in C++","fork":false,"url":"https://api.github.com/repos/thrill/thrill","forks_url":"https://api.github.com/repos/thrill/thrill/forks","keys_url":"https://api.github.com/repos/thrill/thrill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thrill/thrill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thrill/thrill/teams","hooks_url":"https://api.github.com/repos/thrill/thrill/hooks","issue_events_url":"https://api.github.com/repos/thrill/thrill/issues/events{/number}","events_url":"https://api.github.com/repos/thrill/thrill/events","assignees_url":"https://api.github.com/repos/thrill/thrill/assignees{/user}","branches_url":"https://api.github.com/repos/thrill/thrill/branches{/branch}","tags_url":"https://api.github.com/repos/thrill/thrill/tags","blobs_url":"https://api.github.com/repos/thrill/thrill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thrill/thrill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thrill/thrill/git/refs{/sha}","trees_url":"https://api.github.com/repos/thrill/thrill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thrill/thrill/statuses/{sha}","languages_url":"https://api.github.com/repos/thrill/thrill/languages","stargazers_url":"https://api.github.com/repos/thrill/thrill/stargazers","contributors_url":"https://api.github.com/repos/thrill/thrill/contributors","subscribers_url":"https://api.github.com/repos/thrill/thrill/subscribers","subscription_url":"https://api.github.com/repos/thrill/thrill/subscription","commits_url":"https://api.github.com/repos/thrill/thrill/commits{/sha}","git_commits_url":"https://api.github.com/repos/thrill/thrill/git/commits{/sha}","comments_url":"https://api.github.com/repos/thrill/thrill/comments{/number}","issue_comment_url":"https://api.github.com/repos/thrill/thrill/issues/comments{/number}","contents_url":"https://api.github.com/repos/thrill/thrill/contents/{+path}","compare_url":"https://api.github.com/repos/thrill/thrill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thrill/thrill/merges","archive_url":"https://api.github.com/repos/thrill/thrill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thrill/thrill/downloads","issues_url":"https://api.github.com/repos/thrill/thrill/issues{/number}","pulls_url":"https://api.github.com/repos/thrill/thrill/pulls{/number}","milestones_url":"https://api.github.com/repos/thrill/thrill/milestones{/number}","notifications_url":"https://api.github.com/repos/thrill/thrill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thrill/thrill/labels{/name}","releases_url":"https://api.github.com/repos/thrill/thrill/releases{/id}","deployments_url":"https://api.github.com/repos/thrill/thrill/deployments","created_at":"2015-04-24T14:05:14Z","updated_at":"2017-03-20T18:26:41Z","pushed_at":"2017-03-21T14:53:48Z","git_url":"git://github.com/thrill/thrill.git","ssh_url":"git@github.com:thrill/thrill.git","clone_url":"https://github.com/thrill/thrill.git","svn_url":"https://github.com/thrill/thrill","homepage":"http://project-thrill.org","size":8144,"stargazers_count":268,"watchers_count":268,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":17,"forks":36,"open_issues":17,"watchers":268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thrill/thrill/pulls/147"},"html":{"href":"https://github.com/thrill/thrill/pull/147"},"issue":{"href":"https://api.github.com/repos/thrill/thrill/issues/147"},"comments":{"href":"https://api.github.com/repos/thrill/thrill/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/thrill/thrill/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/thrill/thrill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thrill/thrill/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/thrill/thrill/statuses/8ad73330d4fef7e2138da89b42dcbe82f5a89db2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bingmann","id":2604907,"avatar_url":"https://avatars3.githubusercontent.com/u/2604907?v=3","gravatar_id":"","url":"https://api.github.com/users/bingmann","html_url":"https://github.com/bingmann","followers_url":"https://api.github.com/users/bingmann/followers","following_url":"https://api.github.com/users/bingmann/following{/other_user}","gists_url":"https://api.github.com/users/bingmann/gists{/gist_id}","starred_url":"https://api.github.com/users/bingmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingmann/subscriptions","organizations_url":"https://api.github.com/users/bingmann/orgs","repos_url":"https://api.github.com/users/bingmann/repos","events_url":"https://api.github.com/users/bingmann/events{/privacy}","received_events_url":"https://api.github.com/users/bingmann/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"bingmann"}}