{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/3094","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/3094/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/3094/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/3094/events","html_url":"https://github.com/WordPress/gutenberg/pull/3094","id":267285254,"number":3094,"title":"Made button link editor consistent with paragraph link editor","user":{"login":"jorgefilipecosta","id":11271197,"avatar_url":"https://avatars1.githubusercontent.com/u/11271197?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgefilipecosta","html_url":"https://github.com/jorgefilipecosta","followers_url":"https://api.github.com/users/jorgefilipecosta/followers","following_url":"https://api.github.com/users/jorgefilipecosta/following{/other_user}","gists_url":"https://api.github.com/users/jorgefilipecosta/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgefilipecosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgefilipecosta/subscriptions","organizations_url":"https://api.github.com/users/jorgefilipecosta/orgs","repos_url":"https://api.github.com/users/jorgefilipecosta/repos","events_url":"https://api.github.com/users/jorgefilipecosta/events{/privacy}","received_events_url":"https://api.github.com/users/jorgefilipecosta/received_events","type":"User","site_admin":false},"labels":[{"id":570263070,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Blocks","name":"Blocks","color":"fbca04","default":false},{"id":704618599,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Component]%20Inspector","name":"[Component] Inspector","color":"fbca04","default":false},{"id":587343997,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Status]%20In%20Progress","name":"[Status] In Progress","color":"0052cc","default":false},{"id":531680825,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":{"login":"jorgefilipecosta","id":11271197,"avatar_url":"https://avatars1.githubusercontent.com/u/11271197?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgefilipecosta","html_url":"https://github.com/jorgefilipecosta","followers_url":"https://api.github.com/users/jorgefilipecosta/followers","following_url":"https://api.github.com/users/jorgefilipecosta/following{/other_user}","gists_url":"https://api.github.com/users/jorgefilipecosta/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgefilipecosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgefilipecosta/subscriptions","organizations_url":"https://api.github.com/users/jorgefilipecosta/orgs","repos_url":"https://api.github.com/users/jorgefilipecosta/repos","events_url":"https://api.github.com/users/jorgefilipecosta/events{/privacy}","received_events_url":"https://api.github.com/users/jorgefilipecosta/received_events","type":"User","site_admin":false},"assignees":[{"login":"jorgefilipecosta","id":11271197,"avatar_url":"https://avatars1.githubusercontent.com/u/11271197?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgefilipecosta","html_url":"https://github.com/jorgefilipecosta","followers_url":"https://api.github.com/users/jorgefilipecosta/followers","following_url":"https://api.github.com/users/jorgefilipecosta/following{/other_user}","gists_url":"https://api.github.com/users/jorgefilipecosta/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgefilipecosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgefilipecosta/subscriptions","organizations_url":"https://api.github.com/users/jorgefilipecosta/orgs","repos_url":"https://api.github.com/users/jorgefilipecosta/repos","events_url":"https://api.github.com/users/jorgefilipecosta/events{/privacy}","received_events_url":"https://api.github.com/users/jorgefilipecosta/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-10-20T19:46:32Z","updated_at":"2017-10-20T20:00:50Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/3094","html_url":"https://github.com/WordPress/gutenberg/pull/3094","diff_url":"https://github.com/WordPress/gutenberg/pull/3094.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/3094.patch"},"body":"This PR aims to solve https://github.com/WordPress/gutenberg/issues/1670. It makes the button link editor equal to the paragraph link editor. The warnings that were being displayed also get fixed.\r\nBefore the changes to the link were applied right way and the apply button did not have noticeable effects now, changes need to be applied.\r\nA new attribute was added that allows configuring if we want to open the link in a new window or not.\r\n\r\n## How Has This Been Tested?\r\n\r\n1. Add a button. Write the link and apply it. See that it is possible to click the link text and open it.\r\n2. Press edit and see it is possible to edit the link and save changes.\r\n3. Press remove link button, see that link field becomes empty, see if you can write the link again and apply it.\r\n4. Add another button, and press show settings field, enable open in a new window.\r\n5. Save the post and view it, see that one button opens in a new page and the other don't.\r\n\r\n## Screenshots:\r\n<img width=\"388\" alt=\"screen shot 2017-10-20 at 20 24 06\" src=\"https://user-images.githubusercontent.com/11271197/31839103-92179a7c-b5d7-11e7-8ea0-2b6c21a641b9.png\">\r\n<img width=\"1084\" alt=\"screen shot 2017-10-20 at 20 24 45\" src=\"https://user-images.githubusercontent.com/11271197/31839108-94cd202a-b5d7-11e7-8709-fa980a116b9a.png\">\r\n<img width=\"1094\" alt=\"screen shot 2017-10-20 at 20 44 14\" src=\"https://user-images.githubusercontent.com/11271197/31839117-99d16004-b5d7-11e7-99ec-571b894f3f98.png\">\r\n<img width=\"342\" alt=\"screen shot 2017-10-20 at 20 47 23\" src=\"https://user-images.githubusercontent.com/11271197/31839185-f47ef016-b5d7-11e7-8157-796fe996a7cd.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/338308243","html_url":"https://github.com/WordPress/gutenberg/pull/3094#issuecomment-338308243","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/3094","id":338308243,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-10-20T20:00:50Z","updated_at":"2017-10-20T20:00:50Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=h1) Report\n> Merging [#3094](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=desc) into [master](https://codecov.io/gh/WordPress/gutenberg/commit/e869a9dcde45197feb9d1ebc1b45047c1da551a5?src=pr&el=desc) will **decrease** coverage by `0.96%`.\n> The diff coverage is `3.22%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/WordPress/gutenberg/pull/3094/graphs/tree.svg?token=4D37xiV136&height=150&src=pr&width=650)](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #3094      +/-   ##\n==========================================\n- Coverage   32.24%   31.27%   -0.97%     \n==========================================\n  Files         216      217       +1     \n  Lines        6150     6385     +235     \n  Branches     1081     1154      +73     \n==========================================\n+ Hits         1983     1997      +14     \n- Misses       3516     3665     +149     \n- Partials      651      723      +72\n```\n\n\n| [Impacted Files](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [blocks/link-editor/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-YmxvY2tzL2xpbmstZWRpdG9yL2luZGV4Lmpz) | `0% <0%> (ø)` | |\n| [blocks/library/button/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-YmxvY2tzL2xpYnJhcnkvYnV0dG9uL2luZGV4Lmpz) | `19.04% <20%> (-0.96%)` | :arrow_down: |\n| [blocks/editable/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-YmxvY2tzL2VkaXRhYmxlL2luZGV4Lmpz) | `8.63% <0%> (-1.79%)` | :arrow_down: |\n| [editor/modes/visual-editor/inserter.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-ZWRpdG9yL21vZGVzL3Zpc3VhbC1lZGl0b3IvaW5zZXJ0ZXIuanM=) | `91.66% <0%> (-1.67%)` | :arrow_down: |\n| [blocks/block-controls/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-YmxvY2tzL2Jsb2NrLWNvbnRyb2xzL2luZGV4Lmpz) | `0% <0%> (ø)` | :arrow_up: |\n| [editor/sidebar/block-inspector/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-ZWRpdG9yL3NpZGViYXIvYmxvY2staW5zcGVjdG9yL2luZGV4Lmpz) | `0% <0%> (ø)` | :arrow_up: |\n| [components/clipboard-button/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-Y29tcG9uZW50cy9jbGlwYm9hcmQtYnV0dG9uL2luZGV4Lmpz) | `0% <0%> (ø)` | :arrow_up: |\n| [editor/modes/visual-editor/sibling-inserter.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-ZWRpdG9yL21vZGVzL3Zpc3VhbC1lZGl0b3Ivc2libGluZy1pbnNlcnRlci5qcw==) | `0% <0%> (ø)` | :arrow_up: |\n| [editor/block-toolbar/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-ZWRpdG9yL2Jsb2NrLXRvb2xiYXIvaW5kZXguanM=) | `0% <0%> (ø)` | :arrow_up: |\n| [editor/post-title/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree#diff-ZWRpdG9yL3Bvc3QtdGl0bGUvaW5kZXguanM=) | `0% <0%> (ø)` | :arrow_up: |\n| ... and [2 more](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=footer). Last update [e869a9d...1484d95](https://codecov.io/gh/WordPress/gutenberg/pull/3094?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}