{"action":"created","issue":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/4084","repository_url":"https://api.github.com/repos/gitextensions/gitextensions","labels_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/4084/labels{/name}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/4084/comments","events_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/4084/events","html_url":"https://github.com/gitextensions/gitextensions/pull/4084","id":267508356,"number":4084,"title":"Various forms: limit menu options for artificial and submodule","user":{"login":"gerhardol","id":6248932,"avatar_url":"https://avatars1.githubusercontent.com/u/6248932?v=4","gravatar_id":"","url":"https://api.github.com/users/gerhardol","html_url":"https://github.com/gerhardol","followers_url":"https://api.github.com/users/gerhardol/followers","following_url":"https://api.github.com/users/gerhardol/following{/other_user}","gists_url":"https://api.github.com/users/gerhardol/gists{/gist_id}","starred_url":"https://api.github.com/users/gerhardol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerhardol/subscriptions","organizations_url":"https://api.github.com/users/gerhardol/orgs","repos_url":"https://api.github.com/users/gerhardol/repos","events_url":"https://api.github.com/users/gerhardol/events{/privacy}","received_events_url":"https://api.github.com/users/gerhardol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-10-22T23:29:57Z","updated_at":"2017-11-05T00:52:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4084","html_url":"https://github.com/gitextensions/gitextensions/pull/4084","diff_url":"https://github.com/gitextensions/gitextensions/pull/4084.diff","patch_url":"https://github.com/gitextensions/gitextensions/pull/4084.patch"},"body":"The menu options primarily for the Browse Diff has currently a lot of unusable combinations, especially for artificial commits and submodules. One example is cherry pick and blame for submodules.\r\n\r\nThis is not intended to be a final cleanup, there are some combinations with diff that is not working in this commit. There are at least some cherry-pick with FileHistory for submodules.\r\nThere are also no tests added. \r\nThere are more changes related to this coming from #4031 (where this change also origins). It is however very hard to completely separate the changes and to still have something that can be reviewed.\r\n\r\nOne option to handle this is to approve but not merge to master and keep related changes on top of this. But it will be harder to review.\r\n\r\nChanges proposed in this pull request:\r\n - Hide or disable menu options that are irrelevant for submodules and artificial commits. This primarily affects Browse, but also FileHistory and RevisionGrid (general)\r\n - Some caching of artificial commit outputs has been suppressed\r\n - FileHistory Blame tab hidden for submodules and artificial\r\n - Artificial guid is not displayed in revision grid\r\n - Browse Diff Reset did not handle Reset properly\r\n\r\nScreenshots before and after (if PR changes UI):\r\n- TBD, a few new only right now\r\n![image](https://user-images.githubusercontent.com/6248932/31867444-64175d32-b790-11e7-897b-f9fffb3647bd.png)\r\n![image](https://user-images.githubusercontent.com/6248932/31867455-8f88a002-b790-11e7-8696-68e06fabc144.png)\r\n![image](https://user-images.githubusercontent.com/6248932/31867462-a1c3b6ee-b790-11e7-9c14-0b3bf7af6d44.png)\r\n![image](https://user-images.githubusercontent.com/6248932/31867476-c9aec504-b790-11e7-9463-27b3f381dcf9.png)\r\n\r\nHow did I test this code:\r\n - Manually\r\n\r\nHas been tested on (remove any that don't apply):\r\n - GIT 2.14 - not affecting Git (should be less Git usage as options are hidden).\r\n - Windows 7 and Win10\r\n"},"comment":{"url":"https://api.github.com/repos/gitextensions/gitextensions/issues/comments/341941055","html_url":"https://github.com/gitextensions/gitextensions/pull/4084#issuecomment-341941055","issue_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/4084","id":341941055,"user":{"login":"RussKie","id":4403806,"avatar_url":"https://avatars3.githubusercontent.com/u/4403806?v=4","gravatar_id":"","url":"https://api.github.com/users/RussKie","html_url":"https://github.com/RussKie","followers_url":"https://api.github.com/users/RussKie/followers","following_url":"https://api.github.com/users/RussKie/following{/other_user}","gists_url":"https://api.github.com/users/RussKie/gists{/gist_id}","starred_url":"https://api.github.com/users/RussKie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussKie/subscriptions","organizations_url":"https://api.github.com/users/RussKie/orgs","repos_url":"https://api.github.com/users/RussKie/repos","events_url":"https://api.github.com/users/RussKie/events{/privacy}","received_events_url":"https://api.github.com/users/RussKie/received_events","type":"User","site_admin":false},"created_at":"2017-11-05T00:52:51Z","updated_at":"2017-11-05T00:52:51Z","author_association":"COLLABORATOR","body":"I'll bump it up on my todo list\r\n\r\n. . .\r\n\r\n![image](https://user-images.githubusercontent.com/6248932/31867476-c9aec504-b790-11e7-9463-27b3f381dcf9.png)\r\nDoes it make sense to show disabled items at all?"}}
{"actor":{"display_login":"RussKie"}}