{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/149153365","pull_request_review_id":74503374,"id":149153365,"diff_hunk":"@@ -75,11 +77,12 @@ class AdminClientIntegrationTest extends KafkaServerTestHarness with Logging {\n     super.tearDown()\n   }\n \n-  val brokerCount = 3\n-  lazy val serverConfig = new Properties\n+  val serverCount = 3\n+  val consumerCount = 1\n+  val producerCount = 1\n \n   override def generateConfigs = {\n-    val cfgs = TestUtils.createBrokerConfigs(brokerCount, zkConnect, interBrokerSecurityProtocol = Some(securityProtocol),\n+    val cfgs = TestUtils.createBrokerConfigs(serverCount, zkConnect, interBrokerSecurityProtocol = Some(securityProtocol),","path":"core/src/test/scala/integration/kafka/api/AdminClientIntegrationTest.scala","position":63,"original_position":52,"commit_id":"a0234c98dcbec5256a8a8690142c50d7672d39b7","original_commit_id":"4426fdb88ffc4545fc385eea3ad05e0e8bee12cc","user":{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars0.githubusercontent.com/u/10729597?v=4","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"body":"Makes sense, let's leave it here then.","created_at":"2017-11-06T17:53:01Z","updated_at":"2017-11-06T17:53:01Z","html_url":"https://github.com/apache/kafka/pull/4132#discussion_r149153365","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4132","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/149153365"},"html":{"href":"https://github.com/apache/kafka/pull/4132#discussion_r149153365"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4132"}},"in_reply_to_id":148699816},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4132","id":148630801,"html_url":"https://github.com/apache/kafka/pull/4132","diff_url":"https://github.com/apache/kafka/pull/4132.diff","patch_url":"https://github.com/apache/kafka/pull/4132.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4132","number":4132,"state":"open","locked":false,"title":"KAFKA-5925: Adding records deletion operation to the new Admin Client API","user":{"login":"ppatierno","id":5842311,"avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"body":"This is the PR related to the [KIP-204](https://cwiki.apache.org/confluence/display/KAFKA/KIP-204+%3A+Adding+records+deletion+operation+to+the+new+Admin+Client+API) in order to add the `deleteRecords` operation to the new Admin Client (it's already available in the \"legacy\" one).\r\nOther than that, unit test and integration tests are added as well (such integration tests come from the \"legacy\" integration tests in order to test the new addition in the same way as the \"legacy\" one).","created_at":"2017-10-25T10:40:51Z","updated_at":"2017-11-06T17:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0270814a64786736d8580e725b3d2759c85ee9f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4132/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4132/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4132/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/a0234c98dcbec5256a8a8690142c50d7672d39b7","head":{"label":"ppatierno:kafka-5925","ref":"kafka-5925","sha":"a0234c98dcbec5256a8a8690142c50d7672d39b7","user":{"login":"ppatierno","id":5842311,"avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"repo":{"id":93742833,"name":"kafka","full_name":"ppatierno/kafka","owner":{"login":"ppatierno","id":5842311,"avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppatierno/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/ppatierno/kafka","forks_url":"https://api.github.com/repos/ppatierno/kafka/forks","keys_url":"https://api.github.com/repos/ppatierno/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppatierno/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppatierno/kafka/teams","hooks_url":"https://api.github.com/repos/ppatierno/kafka/hooks","issue_events_url":"https://api.github.com/repos/ppatierno/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ppatierno/kafka/events","assignees_url":"https://api.github.com/repos/ppatierno/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ppatierno/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ppatierno/kafka/tags","blobs_url":"https://api.github.com/repos/ppatierno/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppatierno/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppatierno/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppatierno/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppatierno/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ppatierno/kafka/languages","stargazers_url":"https://api.github.com/repos/ppatierno/kafka/stargazers","contributors_url":"https://api.github.com/repos/ppatierno/kafka/contributors","subscribers_url":"https://api.github.com/repos/ppatierno/kafka/subscribers","subscription_url":"https://api.github.com/repos/ppatierno/kafka/subscription","commits_url":"https://api.github.com/repos/ppatierno/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppatierno/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppatierno/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppatierno/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppatierno/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ppatierno/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppatierno/kafka/merges","archive_url":"https://api.github.com/repos/ppatierno/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppatierno/kafka/downloads","issues_url":"https://api.github.com/repos/ppatierno/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ppatierno/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ppatierno/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ppatierno/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppatierno/kafka/labels{/name}","releases_url":"https://api.github.com/repos/ppatierno/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/ppatierno/kafka/deployments","created_at":"2017-06-08T11:43:02Z","updated_at":"2017-06-08T11:43:12Z","pushed_at":"2017-11-06T16:38:19Z","git_url":"git://github.com/ppatierno/kafka.git","ssh_url":"git@github.com:ppatierno/kafka.git","clone_url":"https://github.com/ppatierno/kafka.git","svn_url":"https://github.com/ppatierno/kafka","homepage":null,"size":58734,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"f88fdbd3115cdb0f1bd26817513f3d33359512b1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-11-06T16:56:22Z","pushed_at":"2017-11-06T17:28:47Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":59363,"stargazers_count":6573,"watchers_count":6573,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3995,"mirror_url":"git://git.apache.org/kafka.git","archived":false,"open_issues_count":483,"forks":3995,"open_issues":483,"watchers":6573,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4132"},"html":{"href":"https://github.com/apache/kafka/pull/4132"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4132"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4132/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4132/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4132/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/a0234c98dcbec5256a8a8690142c50d7672d39b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"guozhangwang"}}