{"action":"created","comment":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments/142591038","pull_request_review_id":66971354,"id":142591038,"diff_hunk":"@@ -16,7 +16,7 @@ export class IOSLogFilter extends iOSLogFilterBase.IOSLogFilter implements Mobil\n \n \tpublic filterData(data: string, logLevel: string, pid?: string): string {\n \t\tdata = super.filterData(data, logLevel, pid);\n-\t\tif (pid && data && data.indexOf(`[${pid}]`) === -1) {\n+\t\tif (pid && data && data.search(new RegExp(`[\\\\[\\\\s]${pid}[\\\\]\\\\s]`)) === -1) {","path":"lib/services/ios-log-filter.ts","position":5,"original_position":5,"commit_id":"d35643acb00ed9a0e961115790167ca91e8bc880","original_commit_id":"d35643acb00ed9a0e961115790167ca91e8bc880","user":{"login":"Plamen5kov","id":5918351,"avatar_url":"https://avatars3.githubusercontent.com/u/5918351?v=4","gravatar_id":"","url":"https://api.github.com/users/Plamen5kov","html_url":"https://github.com/Plamen5kov","followers_url":"https://api.github.com/users/Plamen5kov/followers","following_url":"https://api.github.com/users/Plamen5kov/following{/other_user}","gists_url":"https://api.github.com/users/Plamen5kov/gists{/gist_id}","starred_url":"https://api.github.com/users/Plamen5kov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plamen5kov/subscriptions","organizations_url":"https://api.github.com/users/Plamen5kov/orgs","repos_url":"https://api.github.com/users/Plamen5kov/repos","events_url":"https://api.github.com/users/Plamen5kov/events{/privacy}","received_events_url":"https://api.github.com/users/Plamen5kov/received_events","type":"User","site_admin":false},"body":"IMO either choose RegExp or indexOf for consistency [in the code](https://github.com/telerik/mobile-cli-lib/pull/1016/files#diff-6970fd71154619adb4a5ac4fc61de7fcR11)","created_at":"2017-10-04T06:40:50Z","updated_at":"2017-10-04T06:40:50Z","html_url":"https://github.com/NativeScript/nativescript-cli/pull/3145#discussion_r142591038","pull_request_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments/142591038"},"html":{"href":"https://github.com/NativeScript/nativescript-cli/pull/3145#discussion_r142591038"},"pull_request":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145"}}},"pull_request":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145","id":144477736,"html_url":"https://github.com/NativeScript/nativescript-cli/pull/3145","diff_url":"https://github.com/NativeScript/nativescript-cli/pull/3145.diff","patch_url":"https://github.com/NativeScript/nativescript-cli/pull/3145.patch","issue_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3145","number":3145,"state":"open","locked":false,"title":"DO NOT MERGE Fix iOS11 Simulator logs","user":{"login":"KristianDD","id":2412096,"avatar_url":"https://avatars2.githubusercontent.com/u/2412096?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianDD","html_url":"https://github.com/KristianDD","followers_url":"https://api.github.com/users/KristianDD/followers","following_url":"https://api.github.com/users/KristianDD/following{/other_user}","gists_url":"https://api.github.com/users/KristianDD/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianDD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianDD/subscriptions","organizations_url":"https://api.github.com/users/KristianDD/orgs","repos_url":"https://api.github.com/users/KristianDD/repos","events_url":"https://api.github.com/users/KristianDD/events{/privacy}","received_events_url":"https://api.github.com/users/KristianDD/received_events","type":"User","site_admin":false},"body":"Part of the fix for https://github.com/NativeScript/nativescript-cli/issues/3141#issuecomment-333449119.\r\n\r\nLog format for iOS 10.3: \"Oct  3 19:07:55 machinename cliapp[15339]: CONSOLE LOG file:///app/main-view-model.js:18:20: Test Console fix...\"\r\n\r\nLog format for iOS 11: \"2017-10-03 19:09:14.681822+0300 0x511df    Default     0x30f33             14407  cliapp: (NativeScript) CONSOLE LOG file:///app/main-view-model.js:18:20: Test Console fix..\"\r\n\r\nNeeds https://github.com/telerik/ios-sim-portable/pull/95 and https://github.com/telerik/mobile-cli-lib/pull/1016","created_at":"2017-10-03T17:10:58Z","updated_at":"2017-10-04T06:40:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6813e265df38e85908b29a96300678a1d918626","assignee":{"login":"KristianDD","id":2412096,"avatar_url":"https://avatars2.githubusercontent.com/u/2412096?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianDD","html_url":"https://github.com/KristianDD","followers_url":"https://api.github.com/users/KristianDD/followers","following_url":"https://api.github.com/users/KristianDD/following{/other_user}","gists_url":"https://api.github.com/users/KristianDD/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianDD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianDD/subscriptions","organizations_url":"https://api.github.com/users/KristianDD/orgs","repos_url":"https://api.github.com/users/KristianDD/repos","events_url":"https://api.github.com/users/KristianDD/events{/privacy}","received_events_url":"https://api.github.com/users/KristianDD/received_events","type":"User","site_admin":false},"assignees":[{"login":"KristianDD","id":2412096,"avatar_url":"https://avatars2.githubusercontent.com/u/2412096?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianDD","html_url":"https://github.com/KristianDD","followers_url":"https://api.github.com/users/KristianDD/followers","following_url":"https://api.github.com/users/KristianDD/following{/other_user}","gists_url":"https://api.github.com/users/KristianDD/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianDD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianDD/subscriptions","organizations_url":"https://api.github.com/users/KristianDD/orgs","repos_url":"https://api.github.com/users/KristianDD/repos","events_url":"https://api.github.com/users/KristianDD/events{/privacy}","received_events_url":"https://api.github.com/users/KristianDD/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145/commits","review_comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145/comments","review_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3145/comments","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/d35643acb00ed9a0e961115790167ca91e8bc880","head":{"label":"NativeScript:kddimitrov/ios-11-log","ref":"kddimitrov/ios-11-log","sha":"d35643acb00ed9a0e961115790167ca91e8bc880","user":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":21347346,"name":"nativescript-cli","full_name":"NativeScript/nativescript-cli","owner":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NativeScript/nativescript-cli","description":"Command-line interface for building NativeScript apps","fork":false,"url":"https://api.github.com/repos/NativeScript/nativescript-cli","forks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/forks","keys_url":"https://api.github.com/repos/NativeScript/nativescript-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/nativescript-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/nativescript-cli/teams","hooks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/events","assignees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/nativescript-cli/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/tags","blobs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/nativescript-cli/languages","stargazers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscription","commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/nativescript-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/nativescript-cli/merges","archive_url":"https://api.github.com/repos/NativeScript/nativescript-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/nativescript-cli/downloads","issues_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/nativescript-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/nativescript-cli/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/deployments","created_at":"2014-06-30T10:21:20Z","updated_at":"2017-10-03T03:44:31Z","pushed_at":"2017-10-03T17:10:58Z","git_url":"git://github.com/NativeScript/nativescript-cli.git","ssh_url":"git@github.com:NativeScript/nativescript-cli.git","clone_url":"https://github.com/NativeScript/nativescript-cli.git","svn_url":"https://github.com/NativeScript/nativescript-cli","homepage":"https://www.npmjs.com/package/nativescript","size":37634,"stargazers_count":578,"watchers_count":578,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":149,"forks":111,"open_issues":149,"watchers":578,"default_branch":"master"}},"base":{"label":"NativeScript:master","ref":"master","sha":"476ec6cebfb7ab639e472f861d04195e9db5fb2f","user":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":21347346,"name":"nativescript-cli","full_name":"NativeScript/nativescript-cli","owner":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NativeScript/nativescript-cli","description":"Command-line interface for building NativeScript apps","fork":false,"url":"https://api.github.com/repos/NativeScript/nativescript-cli","forks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/forks","keys_url":"https://api.github.com/repos/NativeScript/nativescript-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/nativescript-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/nativescript-cli/teams","hooks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/events","assignees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/nativescript-cli/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/tags","blobs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/nativescript-cli/languages","stargazers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscription","commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/nativescript-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/nativescript-cli/merges","archive_url":"https://api.github.com/repos/NativeScript/nativescript-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/nativescript-cli/downloads","issues_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/nativescript-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/nativescript-cli/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/deployments","created_at":"2014-06-30T10:21:20Z","updated_at":"2017-10-03T03:44:31Z","pushed_at":"2017-10-03T17:10:58Z","git_url":"git://github.com/NativeScript/nativescript-cli.git","ssh_url":"git@github.com:NativeScript/nativescript-cli.git","clone_url":"https://github.com/NativeScript/nativescript-cli.git","svn_url":"https://github.com/NativeScript/nativescript-cli","homepage":"https://www.npmjs.com/package/nativescript","size":37634,"stargazers_count":578,"watchers_count":578,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":149,"forks":111,"open_issues":149,"watchers":578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145"},"html":{"href":"https://github.com/NativeScript/nativescript-cli/pull/3145"},"issue":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3145"},"comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/3145/comments"},"review_comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145/comments"},"review_comment":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/3145/commits"},"statuses":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/d35643acb00ed9a0e961115790167ca91e8bc880"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Plamen5kov"}}