{"action":"created","issue":{"url":"https://api.github.com/repos/lxc/lxc/issues/2001","repository_url":"https://api.github.com/repos/lxc/lxc","labels_url":"https://api.github.com/repos/lxc/lxc/issues/2001/labels{/name}","comments_url":"https://api.github.com/repos/lxc/lxc/issues/2001/comments","events_url":"https://api.github.com/repos/lxc/lxc/issues/2001/events","html_url":"https://github.com/lxc/lxc/pull/2001","id":279244508,"number":2001,"title":"Moved arguments.{c,h} to tools/ and updated Makefile","user":{"login":"RicardoSanchezA","id":9454105,"avatar_url":"https://avatars1.githubusercontent.com/u/9454105?v=4","gravatar_id":"","url":"https://api.github.com/users/RicardoSanchezA","html_url":"https://github.com/RicardoSanchezA","followers_url":"https://api.github.com/users/RicardoSanchezA/followers","following_url":"https://api.github.com/users/RicardoSanchezA/following{/other_user}","gists_url":"https://api.github.com/users/RicardoSanchezA/gists{/gist_id}","starred_url":"https://api.github.com/users/RicardoSanchezA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RicardoSanchezA/subscriptions","organizations_url":"https://api.github.com/users/RicardoSanchezA/orgs","repos_url":"https://api.github.com/users/RicardoSanchezA/repos","events_url":"https://api.github.com/users/RicardoSanchezA/events{/privacy}","received_events_url":"https://api.github.com/users/RicardoSanchezA/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-05T04:45:45Z","updated_at":"2017-12-05T11:21:14Z","closed_at":"2017-12-05T11:18:37Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lxc/lxc/pulls/2001","html_url":"https://github.com/lxc/lxc/pull/2001","diff_url":"https://github.com/lxc/lxc/pull/2001.diff","patch_url":"https://github.com/lxc/lxc/pull/2001.patch"},"body":"@brauner \r\nSo, I decided to keep it simple in this pull request and will eventually make more as Yoshi and I keep removing dependencies from more tools. For now, I simply moved `arguments.{c,h}` to the `tools/` subfolder and updated `Makefile.am` to reflect this file movements (i.e. remove `arguments.{c,h}` from the liblxc sources and add it to the sources of each tool).\r\n\r\nRegarding the argument parser for `lxc_init.c`, I think I was completely misunderstanding what we are supposed to do. The argument parser for `lxc_init.c` will basically be a subset of the parser in `arguments.c` (i.e. it will only parse the arguments that are required for `lxc_init.c` to work), right? \r\nOr am I still getting it wrong? If so, please enlighten me since I would really like to contribute to this project and help you out to get rid of dependencies in the tools. :) \r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/lxc/lxc/issues/comments/349275337","html_url":"https://github.com/lxc/lxc/pull/2001#issuecomment-349275337","issue_url":"https://api.github.com/repos/lxc/lxc/issues/2001","id":349275337,"user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars0.githubusercontent.com/u/7353573?v=4","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"created_at":"2017-12-05T11:21:14Z","updated_at":"2017-12-05T11:21:14Z","author_association":"MEMBER","body":"> Regarding the argument parser for lxc_init.c, I think I was completely misunderstanding what we are supposed to do. The argument parser for lxc_init.c will basically be a subset of the parser in arguments.c \r\n(i.e. it will only parse the arguments that are required for lxc_init.c to work), right?\r\n\r\nYes, that is correct. `lxc_init.c` should be moved from `tools/` one level up, stripped of any dependency on `arguments.{c,h}` and then receive a minimal parser that just parses the arguments `lxc_init.c` currently receives."}}
{"actor":{"display_login":"brauner"}}