{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin/issues/57","repository_url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin","labels_url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin/issues/57/comments","events_url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin/issues/57/events","html_url":"https://github.com/jenkinsci/lockable-resources-plugin/pull/57","id":229161542,"number":57,"title":"LockableResourcesManager: make queueContext & unqueueContext thread safe","user":{"login":"adelcast","id":10310130,"avatar_url":"https://avatars1.githubusercontent.com/u/10310130?v=4","gravatar_id":"","url":"https://api.github.com/users/adelcast","html_url":"https://github.com/adelcast","followers_url":"https://api.github.com/users/adelcast/followers","following_url":"https://api.github.com/users/adelcast/following{/other_user}","gists_url":"https://api.github.com/users/adelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/adelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelcast/subscriptions","organizations_url":"https://api.github.com/users/adelcast/orgs","repos_url":"https://api.github.com/users/adelcast/repos","events_url":"https://api.github.com/users/adelcast/events{/privacy}","received_events_url":"https://api.github.com/users/adelcast/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-05-16T20:37:37Z","updated_at":"2017-07-25T06:52:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin/pulls/57","html_url":"https://github.com/jenkinsci/lockable-resources-plugin/pull/57","diff_url":"https://github.com/jenkinsci/lockable-resources-plugin/pull/57.diff","patch_url":"https://github.com/jenkinsci/lockable-resources-plugin/pull/57.patch"},"body":"Both methods modify queuedContexts, but are not set to be synchonized,\r\nwhich makes them vulnerable to a ConcurrentModificationException.\r\n\r\nSigned-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>"},"comment":{"url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin/issues/comments/317646718","html_url":"https://github.com/jenkinsci/lockable-resources-plugin/pull/57#issuecomment-317646718","issue_url":"https://api.github.com/repos/jenkinsci/lockable-resources-plugin/issues/57","id":317646718,"user":{"login":"dgeissl","id":5918326,"avatar_url":"https://avatars3.githubusercontent.com/u/5918326?v=4","gravatar_id":"","url":"https://api.github.com/users/dgeissl","html_url":"https://github.com/dgeissl","followers_url":"https://api.github.com/users/dgeissl/followers","following_url":"https://api.github.com/users/dgeissl/following{/other_user}","gists_url":"https://api.github.com/users/dgeissl/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeissl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeissl/subscriptions","organizations_url":"https://api.github.com/users/dgeissl/orgs","repos_url":"https://api.github.com/users/dgeissl/repos","events_url":"https://api.github.com/users/dgeissl/events{/privacy}","received_events_url":"https://api.github.com/users/dgeissl/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T06:52:35Z","updated_at":"2017-07-25T06:52:35Z","body":"I see what you mean, but this seems like a big task, isn't it? What you propose is a overhaul of the plugins internal locking concept, while the PR just wants to fix the current bugged implementation.\r\n\r\nNot saying that I the idea behind read-write-locks and narrowing down locked sections isn't great, it's just some other task beside fixing the current bug.\r\n\r\nI've had so much trouble the last weeks with our build jobs that got migrated to jenkins pipeline just because the locking randomly got stuck. I even opened some tickets about them:\r\nhttps://issues.jenkins-ci.org/browse/JENKINS-45506\r\nhttps://issues.jenkins-ci.org/browse/JENKINS-44597\r\nand there where more issues where I could not gather enough information to open a ticket for them.\r\n\r\nAfter applying the this pull request most of our problems seem to be gone, even though I never expected them to be related. That means the current version has serious bugs that will be fixed with this pull request.\r\n\r\nSo please take into consideration to fix the urgent problem with a fast merge/release and queue the rewrite in another timeline."}}
{"actor":{"display_login":"dgeissl"}}