{"action":"created","issue":{"url":"https://api.github.com/repos/slapperwan/gh4a/issues/630","repository_url":"https://api.github.com/repos/slapperwan/gh4a","labels_url":"https://api.github.com/repos/slapperwan/gh4a/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/slapperwan/gh4a/issues/630/comments","events_url":"https://api.github.com/repos/slapperwan/gh4a/issues/630/events","html_url":"https://github.com/slapperwan/gh4a/pull/630","id":235021502,"number":630,"title":"Pull request reviews","user":{"login":"Tunous","id":5156340,"avatar_url":"https://avatars0.githubusercontent.com/u/5156340?v=4","gravatar_id":"","url":"https://api.github.com/users/Tunous","html_url":"https://github.com/Tunous","followers_url":"https://api.github.com/users/Tunous/followers","following_url":"https://api.github.com/users/Tunous/following{/other_user}","gists_url":"https://api.github.com/users/Tunous/gists{/gist_id}","starred_url":"https://api.github.com/users/Tunous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tunous/subscriptions","organizations_url":"https://api.github.com/users/Tunous/orgs","repos_url":"https://api.github.com/users/Tunous/repos","events_url":"https://api.github.com/users/Tunous/events{/privacy}","received_events_url":"https://api.github.com/users/Tunous/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2017-06-10T19:12:00Z","updated_at":"2017-08-08T11:34:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/slapperwan/gh4a/pulls/630","html_url":"https://github.com/slapperwan/gh4a/pull/630","diff_url":"https://github.com/slapperwan/gh4a/pull/630.diff","patch_url":"https://github.com/slapperwan/gh4a/pull/630.patch"},"body":"Heavy work in progress. Created to make it easy for myself to list tasks and share updates.\r\n\r\n# Tasks\r\n\r\n## :white_check_mark: Step 1 - Behavior\r\n\r\n### :white_check_mark: Review Comments screen\r\n- [x] ~~Redirect to correct commit or pull request changes when clicking on diff hunk file~~\r\n  - Apparently, to display diffs for outdated comments we need to load multiple commits and combine the output. This means that support for this is not something for this pull request. The current solution is just to disable clicking on outdated files.\r\n- [x] ~~Figure out how many diff lines to display~~\r\n  - I don't really see a way how to determine this. 4 lines work nicely for now\r\n- [x] ~~Figure out when to display hunk header in diffs (@@ line)~~\r\n  - These are displayed when they are located directly above the first visible line. For now, I'm just going to not display them at all.\r\n- [x] Add option to enter file with selected comment highlighted\r\n- [x] Fix sorting issues\r\n  - Most probably the sort order is first by filename, then by line number.\r\n- [x] Toolbar actions\r\n  - [x] Share\r\n  - [x] Open in browser\r\n- [x] Make line numbers clickable for sharing\r\n- [x] Replying\r\n  - [x] Figure out when to disable reply buttons (They are not always available)\r\n    - If review comment is a reply to someone else's comment and was submitted together with other comments then it's displayed without reply button. Right now the app doesn't display it at all so I'll have to fix that. It's a bit confusing but better let's stay consistent :)\r\n  - [x] Add replying dialog\r\n  - [x] Refresh review after replying\r\n- [x] Comment actions\r\n  - [x] Edit\r\n  - [x] Delete\r\n\r\n### :white_check_mark: Reviews\r\n\r\n- [x] Add indicator showing that all comments in review are outdated\r\n- [x] Correctly load pending reviews and their comments\r\n- [x] Add options menu\r\n  - [x] ~~Edit (if has body text)~~\r\n    - Couldn't find a way to edit reviews with API\r\n  - [x] Share\r\n- [x] ~~Add view changes button (figure out how exactly it works)~~\r\n  - Similar to viewing files for outdated comments this would require loading and combining diff from multiple commits.\r\n- [x] Add quoting for reviews with body\r\n\r\n### :white_check_mark: Link handling\r\n- [x] Handle `#pullrequestreview-<id>` links\r\n- [x] Handle `#discussion_r<id>` links\r\n- [x] Handle `#discussion-diff-<id><line id>` links\r\n\r\n## Step 2 - User Interface\r\n\r\n### General\r\n- [x] Test with dark theme\r\n\r\n### Review Comments screen\r\n- [x] Make text in diff hunks selectable\r\n- [x] Improve appearance of file headers\r\n- [x] Make outdated hunks indicator easier to distinguish\r\n- [ ] Improve appearance of reply button\r\n- [x] Add spacing/dividers between hunks?\r\n- [ ] What to display in activity toolbar?\r\n\r\n## Reviews\r\n- [x] Improve show details button, should it be so big?\r\n- [x] Improve review details text (right now hard to see when if it's a body or summary)\r\n- [x] Improve indicator for all outdated comments\r\n- [x] Add correct review type icons (approved, requested changes, etc)\r\n\r\n## Step 3 - Cleanup\r\n\r\n- [x] Extract all strings\r\n- [ ] More...\r\n\r\n___\r\n\r\nThis is 1st pull request implementing reviews support. It's focused on displaying them and replying to comment. Next pull requests will deal with creating new reviews, requesting reviewers etc.\r\n\r\n#391 "},"comment":{"url":"https://api.github.com/repos/slapperwan/gh4a/issues/comments/320929400","html_url":"https://github.com/slapperwan/gh4a/pull/630#issuecomment-320929400","issue_url":"https://api.github.com/repos/slapperwan/gh4a/issues/630","id":320929400,"user":{"login":"Tunous","id":5156340,"avatar_url":"https://avatars0.githubusercontent.com/u/5156340?v=4","gravatar_id":"","url":"https://api.github.com/users/Tunous","html_url":"https://github.com/Tunous","followers_url":"https://api.github.com/users/Tunous/followers","following_url":"https://api.github.com/users/Tunous/following{/other_user}","gists_url":"https://api.github.com/users/Tunous/gists{/gist_id}","starred_url":"https://api.github.com/users/Tunous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tunous/subscriptions","organizations_url":"https://api.github.com/users/Tunous/orgs","repos_url":"https://api.github.com/users/Tunous/repos","events_url":"https://api.github.com/users/Tunous/events{/privacy}","received_events_url":"https://api.github.com/users/Tunous/received_events","type":"User","site_admin":false},"created_at":"2017-08-08T11:34:34Z","updated_at":"2017-08-08T11:34:34Z","body":"Yep it's GitHub issue based on their response:\r\n\r\n> seems like a problem on our end so I've opened an internal issue so that the team can investigate"}}
{"actor":{"display_login":"Tunous"}}