{"action":"created","comment":{"url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments/97777505","pull_request_review_id":18397314,"id":97777505,"diff_hunk":"@@ -19,23 +16,14 @@\n  */\n class MultiSelectAttributeAdder extends AbstractAttributeAdder\n {\n-    /** @var IdentifiableObjectRepositoryInterface */\n-    protected $attrOptionRepository;\n-\n     /**\n-     * @param ProductBuilderInterface               $productBuilder\n-     * @param AttributeValidatorHelper              $attrValidatorHelper\n-     * @param IdentifiableObjectRepositoryInterface $attrOptionRepository\n-     * @param array                                 $supportedTypes\n+     * @param ProductBuilderInterface $productBuilder\n+     * @param array                   $supportedTypes\n      */\n-    public function __construct(\n-        ProductBuilderInterface $productBuilder,\n-        AttributeValidatorHelper $attrValidatorHelper,\n-        IdentifiableObjectRepositoryInterface $attrOptionRepository,","path":"src/Pim/Component/Catalog/Updater/Adder/MultiSelectAttributeAdder.php","position":32,"original_position":32,"commit_id":"7fcbb6083057356e9b72fe3b4e5e65bfb138aea5","original_commit_id":"8ef6ff0d7f4bda93017e598226a9baa05221e30f","user":{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false},"body":"Added","created_at":"2017-01-25T13:32:23Z","updated_at":"2017-01-25T13:32:23Z","html_url":"https://github.com/jjanvier/pim-community-dev/pull/1#discussion_r97777505","pull_request_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments/97777505"},"html":{"href":"https://github.com/jjanvier/pim-community-dev/pull/1#discussion_r97777505"},"pull_request":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1","id":100846498,"html_url":"https://github.com/jjanvier/pim-community-dev/pull/1","diff_url":"https://github.com/jjanvier/pim-community-dev/pull/1.diff","patch_url":"https://github.com/jjanvier/pim-community-dev/pull/1.patch","issue_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/1","number":1,"state":"open","locked":false,"title":"TIP-681: introduce a way to instanciate several types of product values","user":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars.githubusercontent.com/u/3691804?v=3","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n### Context\r\n\r\nCurrently we face several problems with the product values.\r\n\r\nFirst, they are tied to the old EAV implementation. We don't know which kind a value we manipulate (metric, number, reference data...). To get this information we have to look at the attribute.\r\n\r\nAnother problem is the fact they are mutable. Even if this is a non-sense (when any element of the value changes (data, locale, scope), it is not the same product value), there is worse: we have no easy way to directly create a product value with its data, we first have to create the object and then call the method `setData`.\r\n\r\nTo tackle those problems, we could create a dedicated _ProductValue_ object per attribute type. This would also allow us to:\r\n- validate the data the product value receives\r\n- really simplify the _adder_, _copier_, _remover_ stack\r\n- push back the flexibility of the product model\r\n- not have to override the product value when integrators/customers create a new attribute type\r\n\r\nThe first step, before creating those product values objects, is to create a _ProductValue_ factory per attribute type (even if inside those factories, the current _ProductValue_ object is created). And to be able to set directly a data if we want.\r\n\r\n### Expected\r\n\r\n- one product value factory service per attribute type (several types can share the same class)\r\n- the ability to create a value with its data\r\n- simplify the _adder_, _copier_, _remover_ stack\r\n- specs green\r\n\r\n### Side note\r\n\r\nSome methods have been removed from the _ProductBuilder_. Those will be labelled as deprecated on master for 1.8.\r\n\r\n## Definition Of Done (for Core Developer only)\r\n\r\n| Q                                 | A\r\n| --------------------------------- | ---\r\n| Added Specs                       | :white_check_mark:\r\n| Added Behats                      | :negative_squared_cross_mark:\r\n| Added integration tests           | :negative_squared_cross_mark:\r\n| Changelog updated                 | :white_check_mark:\r\n| Review and 2 GTM                  | :clock1:\r\n| Micro Demo to the PO (Story only) | :negative_squared_cross_mark:\r\n| Migration script                  | :negative_squared_cross_mark:\r\n| Tech Doc                          | :negative_squared_cross_mark:","created_at":"2017-01-10T10:28:17Z","updated_at":"2017-01-25T13:32:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"519a0b43ca76345a1db3a07ce59dc191026e00b2","assignee":{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false},"assignees":[{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/1/comments","statuses_url":"https://api.github.com/repos/jjanvier/pim-community-dev/statuses/7fcbb6083057356e9b72fe3b4e5e65bfb138aea5","head":{"label":"jjanvier:TIP-681","ref":"TIP-681","sha":"7fcbb6083057356e9b72fe3b4e5e65bfb138aea5","user":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars.githubusercontent.com/u/3691804?v=3","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"repo":{"id":15071205,"name":"pim-community-dev","full_name":"jjanvier/pim-community-dev","owner":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars.githubusercontent.com/u/3691804?v=3","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjanvier/pim-community-dev","description":"PIM development repository","fork":true,"url":"https://api.github.com/repos/jjanvier/pim-community-dev","forks_url":"https://api.github.com/repos/jjanvier/pim-community-dev/forks","keys_url":"https://api.github.com/repos/jjanvier/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjanvier/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjanvier/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/jjanvier/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/jjanvier/pim-community-dev/events","assignees_url":"https://api.github.com/repos/jjanvier/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/jjanvier/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/jjanvier/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjanvier/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/jjanvier/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/jjanvier/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/jjanvier/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/jjanvier/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/jjanvier/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjanvier/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/jjanvier/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjanvier/pim-community-dev/merges","archive_url":"https://api.github.com/repos/jjanvier/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjanvier/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/jjanvier/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/jjanvier/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjanvier/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/jjanvier/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/deployments","created_at":"2013-12-10T08:27:21Z","updated_at":"2017-01-10T10:34:47Z","pushed_at":"2017-01-25T13:31:09Z","git_url":"git://github.com/jjanvier/pim-community-dev.git","ssh_url":"git@github.com:jjanvier/pim-community-dev.git","clone_url":"https://github.com/jjanvier/pim-community-dev.git","svn_url":"https://github.com/jjanvier/pim-community-dev","homepage":"http://akeneo.com","size":94885,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"TIP-613-unified"}},"base":{"label":"jjanvier:TIP-613-unified","ref":"TIP-613-unified","sha":"df841bc6d7e80ccdb196ffefe6f14e4a5c4b7966","user":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars.githubusercontent.com/u/3691804?v=3","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"repo":{"id":15071205,"name":"pim-community-dev","full_name":"jjanvier/pim-community-dev","owner":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars.githubusercontent.com/u/3691804?v=3","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjanvier/pim-community-dev","description":"PIM development repository","fork":true,"url":"https://api.github.com/repos/jjanvier/pim-community-dev","forks_url":"https://api.github.com/repos/jjanvier/pim-community-dev/forks","keys_url":"https://api.github.com/repos/jjanvier/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjanvier/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjanvier/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/jjanvier/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/jjanvier/pim-community-dev/events","assignees_url":"https://api.github.com/repos/jjanvier/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/jjanvier/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/jjanvier/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjanvier/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/jjanvier/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/jjanvier/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/jjanvier/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/jjanvier/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/jjanvier/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjanvier/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/jjanvier/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjanvier/pim-community-dev/merges","archive_url":"https://api.github.com/repos/jjanvier/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjanvier/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/jjanvier/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/jjanvier/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjanvier/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/jjanvier/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/deployments","created_at":"2013-12-10T08:27:21Z","updated_at":"2017-01-10T10:34:47Z","pushed_at":"2017-01-25T13:31:09Z","git_url":"git://github.com/jjanvier/pim-community-dev.git","ssh_url":"git@github.com:jjanvier/pim-community-dev.git","clone_url":"https://github.com/jjanvier/pim-community-dev.git","svn_url":"https://github.com/jjanvier/pim-community-dev","homepage":"http://akeneo.com","size":94885,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"TIP-613-unified"}},"_links":{"self":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1"},"html":{"href":"https://github.com/jjanvier/pim-community-dev/pull/1"},"issue":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/1"},"comments":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/statuses/7fcbb6083057356e9b72fe3b4e5e65bfb138aea5"}}}}
{"actor":{"display_login":"damien-carcel"}}