{"action":"opened","number":167,"pull_request":{"url":"https://api.github.com/repos/github/elastomer-client/pulls/167","id":155992595,"html_url":"https://github.com/github/elastomer-client/pull/167","diff_url":"https://github.com/github/elastomer-client/pull/167.diff","patch_url":"https://github.com/github/elastomer-client/pull/167.patch","issue_url":"https://api.github.com/repos/github/elastomer-client/issues/167","number":167,"state":"open","locked":false,"title":"Elireisman/es2 es5 percolator shims","user":{"login":"elireisman","id":32776521,"avatar_url":"https://avatars2.githubusercontent.com/u/32776521?v=4","gravatar_id":"","url":"https://api.github.com/users/elireisman","html_url":"https://github.com/elireisman","followers_url":"https://api.github.com/users/elireisman/followers","following_url":"https://api.github.com/users/elireisman/following{/other_user}","gists_url":"https://api.github.com/users/elireisman/gists{/gist_id}","starred_url":"https://api.github.com/users/elireisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elireisman/subscriptions","organizations_url":"https://api.github.com/users/elireisman/orgs","repos_url":"https://api.github.com/users/elireisman/repos","events_url":"https://api.github.com/users/elireisman/events{/privacy}","received_events_url":"https://api.github.com/users/elireisman/received_events","type":"User","site_admin":true},"body":"I expect this will receive a few more updated to the PR and probably a couple more test cases but thought I would put this out for everyone to have a peek in the meantime.\r\n\r\n#### Changes for 5.x tl;dr:\r\n- legacy `_percolate` and `_mpercolate` API endpoints are deprecated and set for removal but still work\r\n- legacy `/:index/.percolate/:id` for registering perc q's on an index are gone in 5.x although docs claim it can still read indices written in older ES version. types starting with `.` aren't allowed anymore in 5.x\r\n- an index that needs perc q's must register a new datatype for the queries in the index mapping, and that must have a field of type `percolator`\r\n- new API registers/indexes perc queries by writing them to this new field in this new mapped data type\r\n- we'll need to (conditionally) update the mappings at index create time in `github/github` and other uses of `elastomer-client` whenever they run on ES 5.x during the transition\r\n\r\n#### Questions:\r\n*Parameterize the new perc query data type and it's field, as end users may name them differently in their own mappings?*\r\nThe new type and it's field can have any names (we should maybe allow for optional params in `elastomer-client`?) but for this PR I chose what the docs do: `percolator` for the index data type, `query` for the field. If people get creative with those in their index mappings and we don't parameterize them in `elastomer-client`, end users will have a bad day. Let me know and I can add that plumbing here.\r\n\r\n(more coming as I think of it)","created_at":"2017-12-02T01:51:15Z","updated_at":"2017-12-02T01:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/github/elastomer-client/pulls/167/commits","review_comments_url":"https://api.github.com/repos/github/elastomer-client/pulls/167/comments","review_comment_url":"https://api.github.com/repos/github/elastomer-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/elastomer-client/issues/167/comments","statuses_url":"https://api.github.com/repos/github/elastomer-client/statuses/9b5a5c0b6513b46ac688a71b814528ce88ca8bb9","head":{"label":"github:elireisman/es2-es5-percolator-shims","ref":"elireisman/es2-es5-percolator-shims","sha":"9b5a5c0b6513b46ac688a71b814528ce88ca8bb9","user":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":6180360,"name":"elastomer-client","full_name":"github/elastomer-client","owner":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/elastomer-client","description":"A library for interacting with Elasticsearch","fork":false,"url":"https://api.github.com/repos/github/elastomer-client","forks_url":"https://api.github.com/repos/github/elastomer-client/forks","keys_url":"https://api.github.com/repos/github/elastomer-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/elastomer-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/elastomer-client/teams","hooks_url":"https://api.github.com/repos/github/elastomer-client/hooks","issue_events_url":"https://api.github.com/repos/github/elastomer-client/issues/events{/number}","events_url":"https://api.github.com/repos/github/elastomer-client/events","assignees_url":"https://api.github.com/repos/github/elastomer-client/assignees{/user}","branches_url":"https://api.github.com/repos/github/elastomer-client/branches{/branch}","tags_url":"https://api.github.com/repos/github/elastomer-client/tags","blobs_url":"https://api.github.com/repos/github/elastomer-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/elastomer-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/elastomer-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/elastomer-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/elastomer-client/statuses/{sha}","languages_url":"https://api.github.com/repos/github/elastomer-client/languages","stargazers_url":"https://api.github.com/repos/github/elastomer-client/stargazers","contributors_url":"https://api.github.com/repos/github/elastomer-client/contributors","subscribers_url":"https://api.github.com/repos/github/elastomer-client/subscribers","subscription_url":"https://api.github.com/repos/github/elastomer-client/subscription","commits_url":"https://api.github.com/repos/github/elastomer-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/elastomer-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/elastomer-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/elastomer-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/elastomer-client/contents/{+path}","compare_url":"https://api.github.com/repos/github/elastomer-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/elastomer-client/merges","archive_url":"https://api.github.com/repos/github/elastomer-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/elastomer-client/downloads","issues_url":"https://api.github.com/repos/github/elastomer-client/issues{/number}","pulls_url":"https://api.github.com/repos/github/elastomer-client/pulls{/number}","milestones_url":"https://api.github.com/repos/github/elastomer-client/milestones{/number}","notifications_url":"https://api.github.com/repos/github/elastomer-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/elastomer-client/labels{/name}","releases_url":"https://api.github.com/repos/github/elastomer-client/releases{/id}","deployments_url":"https://api.github.com/repos/github/elastomer-client/deployments","created_at":"2012-10-11T20:33:17Z","updated_at":"2017-12-01T02:48:26Z","pushed_at":"2017-12-02T00:52:30Z","git_url":"git://github.com/github/elastomer-client.git","ssh_url":"git@github.com:github/elastomer-client.git","clone_url":"https://github.com/github/elastomer-client.git","svn_url":"https://github.com/github/elastomer-client","homepage":"","size":687,"stargazers_count":97,"watchers_count":97,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":18,"watchers":97,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"603cc4494ee37f5608bc64c61a9d8428bc70f3a9","user":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":6180360,"name":"elastomer-client","full_name":"github/elastomer-client","owner":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/elastomer-client","description":"A library for interacting with Elasticsearch","fork":false,"url":"https://api.github.com/repos/github/elastomer-client","forks_url":"https://api.github.com/repos/github/elastomer-client/forks","keys_url":"https://api.github.com/repos/github/elastomer-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/elastomer-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/elastomer-client/teams","hooks_url":"https://api.github.com/repos/github/elastomer-client/hooks","issue_events_url":"https://api.github.com/repos/github/elastomer-client/issues/events{/number}","events_url":"https://api.github.com/repos/github/elastomer-client/events","assignees_url":"https://api.github.com/repos/github/elastomer-client/assignees{/user}","branches_url":"https://api.github.com/repos/github/elastomer-client/branches{/branch}","tags_url":"https://api.github.com/repos/github/elastomer-client/tags","blobs_url":"https://api.github.com/repos/github/elastomer-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/elastomer-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/elastomer-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/elastomer-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/elastomer-client/statuses/{sha}","languages_url":"https://api.github.com/repos/github/elastomer-client/languages","stargazers_url":"https://api.github.com/repos/github/elastomer-client/stargazers","contributors_url":"https://api.github.com/repos/github/elastomer-client/contributors","subscribers_url":"https://api.github.com/repos/github/elastomer-client/subscribers","subscription_url":"https://api.github.com/repos/github/elastomer-client/subscription","commits_url":"https://api.github.com/repos/github/elastomer-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/elastomer-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/elastomer-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/elastomer-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/elastomer-client/contents/{+path}","compare_url":"https://api.github.com/repos/github/elastomer-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/elastomer-client/merges","archive_url":"https://api.github.com/repos/github/elastomer-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/elastomer-client/downloads","issues_url":"https://api.github.com/repos/github/elastomer-client/issues{/number}","pulls_url":"https://api.github.com/repos/github/elastomer-client/pulls{/number}","milestones_url":"https://api.github.com/repos/github/elastomer-client/milestones{/number}","notifications_url":"https://api.github.com/repos/github/elastomer-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/elastomer-client/labels{/name}","releases_url":"https://api.github.com/repos/github/elastomer-client/releases{/id}","deployments_url":"https://api.github.com/repos/github/elastomer-client/deployments","created_at":"2012-10-11T20:33:17Z","updated_at":"2017-12-01T02:48:26Z","pushed_at":"2017-12-02T00:52:30Z","git_url":"git://github.com/github/elastomer-client.git","ssh_url":"git@github.com:github/elastomer-client.git","clone_url":"https://github.com/github/elastomer-client.git","svn_url":"https://github.com/github/elastomer-client","homepage":"","size":687,"stargazers_count":97,"watchers_count":97,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":18,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/167"},"html":{"href":"https://github.com/github/elastomer-client/pull/167"},"issue":{"href":"https://api.github.com/repos/github/elastomer-client/issues/167"},"comments":{"href":"https://api.github.com/repos/github/elastomer-client/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/github/elastomer-client/statuses/9b5a5c0b6513b46ac688a71b814528ce88ca8bb9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":41,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"elireisman"}}