{"push_id":2106597068,"size":1,"distinct_size":1,"ref":"refs/heads/train-99","head":"a9886f605f955be874988d739d385a6536f32575","before":"f7d5d1e9e8955f27ca34acf7741cb35ff966343b","commits":[{"sha":"a9886f605f955be874988d739d385a6536f32575","author":{"name":"Shane Tomlinson","email":"8249842bf0a6b6116c3bd709e5a3888cf2c918b9@mozilla.com"},"message":"fix(sms): Allow SMS sending again. (#5687) r=@vladikoff\n\nIn `_areSmsRequirementsMet`, `isInExperiment` was called\r\nw/o a `country`. The experiment itself requires a country,\r\nso it returned that the user was not a member of the experiment.\r\nBecause of this, all users were sent to /connect_another_device,\r\neven if in a country where SMS is was supported.\r\n\r\nThis fixes that by *not* calling `isInExperiment` in\r\n`_areSmsRequirementsMet` and instead depends on the\r\ncall to `getExperimentGroup` in\r\n`navigateToConnectAnotherDeviceScreen` to determine whether\r\nthe user is in an experiment group. The user's country is\r\nknown at this point and the correct answer will be returned.\r\nIf the user is not a member of the experiment, log\r\nit there instead of in `_areSmsRequirementsMet`\r\n\r\nNote, there are no functional test updates for this. We\r\nare in a bit of a pickle here because the user is not\r\nenrolled in any experiments within the functional tests\r\nunless the `forceExperiment` query parameter is specified.\r\n\r\nfixes #5685","distinct":true,"url":"https://api.github.com/repos/mozilla/fxa-content-server/commits/a9886f605f955be874988d739d385a6536f32575"}]}
{"actor":{"display_login":"vladikoff"}}