{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/145621120","pull_request_review_id":70446074,"id":145621120,"diff_hunk":"@@ -507,6 +510,208 @@ class ContextifyContext {\n \n     args.GetReturnValue().Set(ctx->sandbox()->GetPropertyNames());\n   }\n+\n+  static void IndexedPropertyGetterCallback(\n+      uint32_t index,\n+      const PropertyCallbackInfo<Value>& args) {\n+    ContextifyContext* ctx;\n+    ASSIGN_OR_RETURN_UNWRAP(&ctx, args.Data().As<Object>());\n+\n+    // Still initializing\n+    if (ctx->context_.IsEmpty())\n+      return;\n+\n+    Local<Context> context = ctx->context();\n+    v8::Isolate* isolate = context->GetIsolate();\n+    Local<Object> sandbox = ctx->sandbox();\n+    MaybeLocal<Value> maybe_rv =\n+        sandbox\n+            ->GetRealNamedProperty(context, UIntToName(isolate, index));\n+    if (maybe_rv.IsEmpty()) {\n+        maybe_rv = ctx->global_proxy()\n+            ->GetRealNamedProperty(context, UIntToName(isolate, index));\n+    }\n+\n+    Local<Value> rv;\n+    if (maybe_rv.ToLocal(&rv)) {\n+      if (rv == sandbox)\n+        rv = ctx->global_proxy();\n+\n+      args.GetReturnValue().Set(rv);\n+    }\n+  }\n+\n+\n+  static void IndexedPropertySetterCallback(\n+      uint32_t index,\n+      Local<Value> value,\n+      const PropertyCallbackInfo<Value>& args) {\n+    ContextifyContext* ctx;\n+    ASSIGN_OR_RETURN_UNWRAP(&ctx, args.Data().As<Object>());\n+\n+    // Still initializing\n+    if (ctx->context_.IsEmpty())\n+      return;\n+\n+    Local<Context> context = ctx->context();\n+    v8::Isolate* isolate = context->GetIsolate();\n+\n+    auto attributes = PropertyAttribute::None;\n+    bool is_declared =\n+        ctx->global_proxy()\n+            ->GetRealNamedPropertyAttributes(ctx->context(),\n+                 UIntToName(isolate, index))\n+        .To(&attributes);\n+    bool read_only =\n+        static_cast<int>(attributes) &\n+        static_cast<int>(PropertyAttribute::ReadOnly);\n+\n+    if (is_declared && read_only)\n+      return;\n+\n+    // true for x = 5\n+    // false for this.x = 5\n+    // false for Object.defineProperty(this, 'foo', ...)\n+    // false for vmResult.x = 5 where vmResult = vm.runInContext();\n+    bool is_contextual_store = ctx->global_proxy() != args.This();\n+\n+    // Indicator to not return before setting (undeclared) function declarations\n+    // on the sandbox in strict mode, i.e. args.ShouldThrowOnError() = true.\n+    // True for 'function f() {}', 'this.f = function() {}',\n+    // 'var f = function()'.\n+    // In effect only for 'function f() {}' because\n+    // var f = function(), is_declared = true\n+    // this.f = function() {}, is_contextual_store = false.\n+    bool is_function = value->IsFunction();\n+\n+    if (!is_declared && args.ShouldThrowOnError() && is_contextual_store &&\n+    !is_function)\n+      return;\n+\n+    ctx->sandbox()->Set(index, value);\n+  }\n+\n+\n+  static void IndexedPropertyDescriptorCallback(\n+      uint32_t index,\n+      const PropertyCallbackInfo<Value>& info) {\n+    ContextifyContext* ctx;\n+    ASSIGN_OR_RETURN_UNWRAP(&ctx, info.Data().As<Object>());\n+\n+    // Still initializing\n+    if (ctx->context_.IsEmpty())\n+      return;\n+\n+    Local<Context> context = ctx->context();\n+    v8::Isolate* isolate = context->GetIsolate();\n+    HandleScope scope(isolate);\n+\n+    Local<Object> sandbox = ctx->sandbox();\n+\n+    Maybe<bool> has = sandbox->HasOwnProperty(context, index);\n+    Local<Value> descriptor_intercepted = has.IsNothing() ?\n+        ctx->global_proxy()\n+            ->GetOwnPropertyDescriptor(context, UIntToName(isolate, index))\n+            .ToLocalChecked() :\n+        sandbox\n+            ->GetOwnPropertyDescriptor(context, UIntToName(isolate, index))\n+            .ToLocalChecked();\n+\n+    // If the index had already been defined on the sandbox or global object,\n+    // we intercept, query and return it.\n+    // Else, there is no need to intercept with first time definitions.\n+    if (!descriptor_intercepted->IsUndefined()) {\n+      info.GetReturnValue().Set(descriptor_intercepted);\n+    }\n+  }\n+\n+\n+  static void IndexedPropertyDefinerCallback(\n+      uint32_t index,\n+      const PropertyDescriptor& desc,\n+      const PropertyCallbackInfo<Value>& info) {\n+    ContextifyContext* ctx;\n+    ASSIGN_OR_RETURN_UNWRAP(&ctx, info.Data().As<Object>());\n+\n+    // Still initializing\n+    if (ctx->context_.IsEmpty())\n+      return;\n+\n+    Local<Context> context = ctx->context();\n+    v8::Isolate* isolate = context->GetIsolate();\n+    HandleScope scope(isolate);\n+\n+    auto attributes = PropertyAttribute::None;\n+    bool is_declared = ctx->global_proxy()\n+            ->GetRealNamedPropertyAttributes(ctx->context(),\n+                  UIntToName(isolate, index))\n+            .To(&attributes);\n+    bool read_only =\n+        static_cast<int>(attributes) &\n+        static_cast<int>(PropertyAttribute::ReadOnly);\n+\n+    // If the index is set on the global as read_only, don't change it on\n+    // the global or sandbox.\n+    if (is_declared && read_only)\n+      return;\n+\n+    Local<Object> sandbox = ctx->sandbox();\n+\n+    auto define_prop_on_sandbox =\n+        [&] (PropertyDescriptor* desc_for_sandbox) {\n+          if (desc.has_enumerable()) {\n+            desc_for_sandbox->set_enumerable(desc.enumerable());\n+          }\n+          if (desc.has_configurable()) {\n+            desc_for_sandbox->set_configurable(desc.configurable());\n+          }\n+          // Set the index on the sandbox.\n+          sandbox->DefineProperty(context,\n+               UIntToName(isolate, index), *desc_for_sandbox);\n+        };\n+\n+    if (desc.has_get() || desc.has_set()) {\n+      PropertyDescriptor desc_for_sandbox(\n+          desc.has_get() ? desc.get() : v8::Undefined(isolate).As<Value>(),\n+          desc.has_set() ? desc.set() : v8::Undefined(isolate).As<Value>());\n+\n+      define_prop_on_sandbox(&desc_for_sandbox);\n+    } else {\n+      Local<Value> value =\n+          desc.has_value() ? desc.value() :\n+          v8::Undefined(isolate).As<Value>();\n+\n+      if (desc.has_writable()) {\n+        PropertyDescriptor desc_for_sandbox(value, desc.writable());\n+        define_prop_on_sandbox(&desc_for_sandbox);\n+      } else {\n+        PropertyDescriptor desc_for_sandbox(value);\n+        define_prop_on_sandbox(&desc_for_sandbox);\n+      }\n+    }\n+\n+    printf(\"foo\\n\");","path":"src/node_contextify.cc","position":273,"original_position":463,"commit_id":"0ce0757a913c3814ff10a4012be7fa4b59e710d5","original_commit_id":"0ce0757a913c3814ff10a4012be7fa4b59e710d5","user":{"login":"fhinkel","id":101553,"avatar_url":"https://avatars3.githubusercontent.com/u/101553?v=4","gravatar_id":"","url":"https://api.github.com/users/fhinkel","html_url":"https://github.com/fhinkel","followers_url":"https://api.github.com/users/fhinkel/followers","following_url":"https://api.github.com/users/fhinkel/following{/other_user}","gists_url":"https://api.github.com/users/fhinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fhinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhinkel/subscriptions","organizations_url":"https://api.github.com/users/fhinkel/orgs","repos_url":"https://api.github.com/users/fhinkel/repos","events_url":"https://api.github.com/users/fhinkel/events{/privacy}","received_events_url":"https://api.github.com/users/fhinkel/received_events","type":"User","site_admin":false},"body":"It's all duplication. Let me think about how to get rid of the code duplication while maintaining readability.","created_at":"2017-10-19T07:45:31Z","updated_at":"2017-10-19T07:45:31Z","html_url":"https://github.com/nodejs/node/pull/16293#discussion_r145621120","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/16293","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/145621120"},"html":{"href":"https://github.com/nodejs/node/pull/16293#discussion_r145621120"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/16293"}},"in_reply_to_id":145474915},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16293","id":147320167,"html_url":"https://github.com/nodejs/node/pull/16293","diff_url":"https://github.com/nodejs/node/pull/16293.diff","patch_url":"https://github.com/nodejs/node/pull/16293.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/16293","number":16293,"state":"open","locked":false,"title":"src: use new V8 API in vm module","user":{"login":"fhinkel","id":101553,"avatar_url":"https://avatars3.githubusercontent.com/u/101553?v=4","gravatar_id":"","url":"https://api.github.com/users/fhinkel","html_url":"https://github.com/fhinkel","followers_url":"https://api.github.com/users/fhinkel/followers","following_url":"https://api.github.com/users/fhinkel/following{/other_user}","gists_url":"https://api.github.com/users/fhinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fhinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhinkel/subscriptions","organizations_url":"https://api.github.com/users/fhinkel/orgs","repos_url":"https://api.github.com/users/fhinkel/repos","events_url":"https://api.github.com/users/fhinkel/events{/privacy}","received_events_url":"https://api.github.com/users/fhinkel/received_events","type":"User","site_admin":false},"body":"**This PR requires a backport of [37a3a15](https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f) otherwise some tests will fail.** Cherry pick [PR](https://github.com/nodejs/node/pull/16294). \r\n\r\nThis PR removes the CopyProperties() hack in the vm module, i.e., Contextify.\r\nInstead, it uses different V8 API methods, that allow interception of\r\nDefineProperty() and do not flatten accessor descriptors to\r\nproperty descriptors.\r\n\r\nMove many known issues to test cases. Factor out the last test in\r\ntest-vm-context.js for\r\nhttps://github.com/nodejs/node/issues/10223\r\ninto its own file, test-vm-strict-assign.js.\r\n\r\nPart of this CL is taken from a stalled PR by\r\nhttps://github.com/AnnaMag\r\nhttps://github.com/nodejs/node/pull/13265\r\n\r\nRefs: https://github.com/nodejs/node/issues/6283\r\nRefs: https://github.com/nodejs/node/pull/15114\r\nRefs: https://github.com/nodejs/node/pull/13265\r\n\r\nFixes: https://github.com/nodejs/node/issues/2734\r\nFixes: https://github.com/nodejs/node/issues/10223\r\nFixes: https://github.com/nodejs/node/issues/11803\r\nFixes: https://github.com/nodejs/node/issues/11902\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nsrc","created_at":"2017-10-18T14:41:04Z","updated_at":"2017-10-19T07:45:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9803ea7b9f898b894df2f689a389d840bb802af","assignee":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"assignees":[{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/25","html_url":"https://github.com/nodejs/node/milestone/25","labels_url":"https://api.github.com/repos/nodejs/node/milestones/25/labels","id":2504910,"number":25,"title":"9.0.0","description":"","creator":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":8,"state":"open","created_at":"2017-05-07T12:05:38Z","updated_at":"2017-10-18T18:42:04Z","due_on":"2017-10-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nodejs/node/pulls/16293/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/16293/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16293/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/0ce0757a913c3814ff10a4012be7fa4b59e710d5","head":{"label":"fhinkel:Oct/defineProp","ref":"Oct/defineProp","sha":"0ce0757a913c3814ff10a4012be7fa4b59e710d5","user":{"login":"fhinkel","id":101553,"avatar_url":"https://avatars3.githubusercontent.com/u/101553?v=4","gravatar_id":"","url":"https://api.github.com/users/fhinkel","html_url":"https://github.com/fhinkel","followers_url":"https://api.github.com/users/fhinkel/followers","following_url":"https://api.github.com/users/fhinkel/following{/other_user}","gists_url":"https://api.github.com/users/fhinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fhinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhinkel/subscriptions","organizations_url":"https://api.github.com/users/fhinkel/orgs","repos_url":"https://api.github.com/users/fhinkel/repos","events_url":"https://api.github.com/users/fhinkel/events{/privacy}","received_events_url":"https://api.github.com/users/fhinkel/received_events","type":"User","site_admin":false},"repo":{"id":44396185,"name":"node","full_name":"fhinkel/node","owner":{"login":"fhinkel","id":101553,"avatar_url":"https://avatars3.githubusercontent.com/u/101553?v=4","gravatar_id":"","url":"https://api.github.com/users/fhinkel","html_url":"https://github.com/fhinkel","followers_url":"https://api.github.com/users/fhinkel/followers","following_url":"https://api.github.com/users/fhinkel/following{/other_user}","gists_url":"https://api.github.com/users/fhinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fhinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhinkel/subscriptions","organizations_url":"https://api.github.com/users/fhinkel/orgs","repos_url":"https://api.github.com/users/fhinkel/repos","events_url":"https://api.github.com/users/fhinkel/events{/privacy}","received_events_url":"https://api.github.com/users/fhinkel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhinkel/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/fhinkel/node","forks_url":"https://api.github.com/repos/fhinkel/node/forks","keys_url":"https://api.github.com/repos/fhinkel/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhinkel/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhinkel/node/teams","hooks_url":"https://api.github.com/repos/fhinkel/node/hooks","issue_events_url":"https://api.github.com/repos/fhinkel/node/issues/events{/number}","events_url":"https://api.github.com/repos/fhinkel/node/events","assignees_url":"https://api.github.com/repos/fhinkel/node/assignees{/user}","branches_url":"https://api.github.com/repos/fhinkel/node/branches{/branch}","tags_url":"https://api.github.com/repos/fhinkel/node/tags","blobs_url":"https://api.github.com/repos/fhinkel/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhinkel/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhinkel/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhinkel/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhinkel/node/statuses/{sha}","languages_url":"https://api.github.com/repos/fhinkel/node/languages","stargazers_url":"https://api.github.com/repos/fhinkel/node/stargazers","contributors_url":"https://api.github.com/repos/fhinkel/node/contributors","subscribers_url":"https://api.github.com/repos/fhinkel/node/subscribers","subscription_url":"https://api.github.com/repos/fhinkel/node/subscription","commits_url":"https://api.github.com/repos/fhinkel/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhinkel/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhinkel/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhinkel/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhinkel/node/contents/{+path}","compare_url":"https://api.github.com/repos/fhinkel/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhinkel/node/merges","archive_url":"https://api.github.com/repos/fhinkel/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhinkel/node/downloads","issues_url":"https://api.github.com/repos/fhinkel/node/issues{/number}","pulls_url":"https://api.github.com/repos/fhinkel/node/pulls{/number}","milestones_url":"https://api.github.com/repos/fhinkel/node/milestones{/number}","notifications_url":"https://api.github.com/repos/fhinkel/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhinkel/node/labels{/name}","releases_url":"https://api.github.com/repos/fhinkel/node/releases{/id}","deployments_url":"https://api.github.com/repos/fhinkel/node/deployments","created_at":"2015-10-16T16:08:10Z","updated_at":"2016-05-06T08:49:54Z","pushed_at":"2017-10-19T06:33:04Z","git_url":"git://github.com/fhinkel/node.git","ssh_url":"git@github.com:fhinkel/node.git","clone_url":"https://github.com/fhinkel/node.git","svn_url":"https://github.com/fhinkel/node","homepage":"https://nodejs.org","size":316256,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"5d99a9bf65258406c5ad0566842c62d421fab09a","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-10-19T07:44:52Z","pushed_at":"2017-10-19T07:40:03Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":326009,"stargazers_count":40922,"watchers_count":40922,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8461,"mirror_url":null,"open_issues_count":763,"forks":8461,"open_issues":763,"watchers":40922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/16293"},"html":{"href":"https://github.com/nodejs/node/pull/16293"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/16293"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/16293/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/16293/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/16293/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/0ce0757a913c3814ff10a4012be7fa4b59e710d5"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fhinkel"}}