{"action":"created","issue":{"url":"https://api.github.com/repos/solson/miri/issues/259","repository_url":"https://api.github.com/repos/solson/miri","labels_url":"https://api.github.com/repos/solson/miri/issues/259/labels{/name}","comments_url":"https://api.github.com/repos/solson/miri/issues/259/comments","events_url":"https://api.github.com/repos/solson/miri/issues/259/events","html_url":"https://github.com/solson/miri/pull/259","id":244133514,"number":259,"title":"No longer check aligment and non-NULLness on `&`","user":{"login":"RalfJung","id":330628,"avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-07-19T18:33:37Z","updated_at":"2017-07-20T05:12:19Z","closed_at":"2017-07-20T05:09:53Z","pull_request":{"url":"https://api.github.com/repos/solson/miri/pulls/259","html_url":"https://github.com/solson/miri/pull/259","diff_url":"https://github.com/solson/miri/pull/259.diff","patch_url":"https://github.com/solson/miri/pull/259.patch"},"body":"This breaks creating unaligned raw pointers via `&packed.field as *const _`, which needs to be legal.\r\nAlso it doesn't seem like LLVM still relies on this, see\r\n* https://github.com/solson/miri/issues/244#issuecomment-315563640\r\n* https://internals.rust-lang.org/t/rules-for-alignment-and-non-nullness-of-references/5430/16\r\n\r\nWe probably want to handle this invariant like the others that validation is concerned with, and only\r\ncheck it on function boundaries for now.\r\n"},"comment":{"url":"https://api.github.com/repos/solson/miri/issues/comments/316598595","html_url":"https://github.com/solson/miri/pull/259#issuecomment-316598595","issue_url":"https://api.github.com/repos/solson/miri/issues/259","id":316598595,"user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"created_at":"2017-07-20T05:12:19Z","updated_at":"2017-07-20T05:12:19Z","body":"Thanks. That check has moved around quite a bit before. We should probably review other early aborts for similar issues"}}
{"actor":{"display_login":"oli-obk"}}