{"action":"created","issue":{"url":"https://api.github.com/repos/enthought/pyface/issues/264","repository_url":"https://api.github.com/repos/enthought/pyface","labels_url":"https://api.github.com/repos/enthought/pyface/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/enthought/pyface/issues/264/comments","events_url":"https://api.github.com/repos/enthought/pyface/issues/264/events","html_url":"https://github.com/enthought/pyface/pull/264","id":213335195,"number":264,"title":"Qt5 v3","user":{"login":"corranwebster","id":600761,"avatar_url":"https://avatars0.githubusercontent.com/u/600761?v=3","gravatar_id":"","url":"https://api.github.com/users/corranwebster","html_url":"https://github.com/corranwebster","followers_url":"https://api.github.com/users/corranwebster/followers","following_url":"https://api.github.com/users/corranwebster/following{/other_user}","gists_url":"https://api.github.com/users/corranwebster/gists{/gist_id}","starred_url":"https://api.github.com/users/corranwebster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corranwebster/subscriptions","organizations_url":"https://api.github.com/users/corranwebster/orgs","repos_url":"https://api.github.com/users/corranwebster/repos","events_url":"https://api.github.com/users/corranwebster/events{/privacy}","received_events_url":"https://api.github.com/users/corranwebster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-03-10T13:01:06Z","updated_at":"2017-03-24T10:50:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/enthought/pyface/pulls/264","html_url":"https://github.com/enthought/pyface/pull/264","diff_url":"https://github.com/enthought/pyface/pull/264.diff","patch_url":"https://github.com/enthought/pyface/pull/264.patch"},"body":"This is another attempt at Qt5 compatibility.  Following #256 we should have removed all old-style signals and slots, so at the object level, we have compatibility with Qt5.  This PR takes a different approach to the previous PRs like #171 and is inspired by a comment by @pankajp there.\r\n\r\nThis PR tries to make the PyQt5 API compatible with PyQt4, so that code which depends on pyface.qt does not need to be modified.  We may, at some future point, add a pyface.qt5 module or something similar which attempts forward compatibility instead of backwards compatibility.\r\n\r\nTo do:\r\n\r\n- [x] CI integration for Qt5.  This is still a blocker for merging."},"comment":{"url":"https://api.github.com/repos/enthought/pyface/issues/comments/288990812","html_url":"https://github.com/enthought/pyface/pull/264#issuecomment-288990812","issue_url":"https://api.github.com/repos/enthought/pyface/issues/264","id":288990812,"user":{"login":"corranwebster","id":600761,"avatar_url":"https://avatars0.githubusercontent.com/u/600761?v=3","gravatar_id":"","url":"https://api.github.com/users/corranwebster","html_url":"https://github.com/corranwebster","followers_url":"https://api.github.com/users/corranwebster/followers","following_url":"https://api.github.com/users/corranwebster/following{/other_user}","gists_url":"https://api.github.com/users/corranwebster/gists{/gist_id}","starred_url":"https://api.github.com/users/corranwebster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corranwebster/subscriptions","organizations_url":"https://api.github.com/users/corranwebster/orgs","repos_url":"https://api.github.com/users/corranwebster/repos","events_url":"https://api.github.com/users/corranwebster/events{/privacy}","received_events_url":"https://api.github.com/users/corranwebster/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T10:50:00Z","updated_at":"2017-03-24T10:50:00Z","body":"@pankajp I've merged in the test fixes branch, making the Qt5 tests \"allowed failures\" for now, since we still get occasional segfaults which can't be locally reproduced.\r\n\r\nAssuming CI runs successfully, do you think this is good to merge into master?"}}
{"actor":{"display_login":"corranwebster"}}