{"action":"created","comment":{"url":"https://api.github.com/repos/p4lang/PI/pulls/comments/154240553","pull_request_review_id":80373839,"id":154240553,"diff_hunk":"@@ -319,3 +319,123 @@ should take into account the top-level message and act as follows:\n   switch only returns the counter state associated with the match given in\n   `DirectCounterEntry.TableEntry.match`, and does not populate other fields\n   within the `TableEntry` (such as `Action`).\n+\n+## Error reporting\n+\n+When the p4.Write() fails for some reason, P4 Runtime returns `grpc::Status` to\n+report errors. `grpc::Status` has top-level canonical `error_code` that\n+represents a RPC-wide error, along with `error_details` which is serialized","path":"proto/docs/p4runtime.md","position":18,"original_position":18,"commit_id":"a30e146bbf663f3cfc2990b82327f7daed69f443","original_commit_id":"a30e146bbf663f3cfc2990b82327f7daed69f443","user":{"login":"antoninbas","id":2495809,"avatar_url":"https://avatars1.githubusercontent.com/u/2495809?v=4","gravatar_id":"","url":"https://api.github.com/users/antoninbas","html_url":"https://github.com/antoninbas","followers_url":"https://api.github.com/users/antoninbas/followers","following_url":"https://api.github.com/users/antoninbas/following{/other_user}","gists_url":"https://api.github.com/users/antoninbas/gists{/gist_id}","starred_url":"https://api.github.com/users/antoninbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoninbas/subscriptions","organizations_url":"https://api.github.com/users/antoninbas/orgs","repos_url":"https://api.github.com/users/antoninbas/repos","events_url":"https://api.github.com/users/antoninbas/events{/privacy}","received_events_url":"https://api.github.com/users/antoninbas/received_events","type":"User","site_admin":false},"body":"along with an `error_details` field which is a serialized `google.rpc.Status` message that...","created_at":"2017-12-01T00:26:45Z","updated_at":"2017-12-01T00:31:11Z","html_url":"https://github.com/p4lang/PI/pull/244#discussion_r154240553","pull_request_url":"https://api.github.com/repos/p4lang/PI/pulls/244","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/p4lang/PI/pulls/comments/154240553"},"html":{"href":"https://github.com/p4lang/PI/pull/244#discussion_r154240553"},"pull_request":{"href":"https://api.github.com/repos/p4lang/PI/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/p4lang/PI/pulls/244","id":155750026,"html_url":"https://github.com/p4lang/PI/pull/244","diff_url":"https://github.com/p4lang/PI/pull/244.diff","patch_url":"https://github.com/p4lang/PI/pull/244.patch","issue_url":"https://api.github.com/repos/p4lang/PI/issues/244","number":244,"state":"open","locked":false,"title":"Updates p4runtime.proto and docs to add p4.Error message","user":{"login":"shyoo","id":1000267,"avatar_url":"https://avatars3.githubusercontent.com/u/1000267?v=4","gravatar_id":"","url":"https://api.github.com/users/shyoo","html_url":"https://github.com/shyoo","followers_url":"https://api.github.com/users/shyoo/followers","following_url":"https://api.github.com/users/shyoo/following{/other_user}","gists_url":"https://api.github.com/users/shyoo/gists{/gist_id}","starred_url":"https://api.github.com/users/shyoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyoo/subscriptions","organizations_url":"https://api.github.com/users/shyoo/orgs","repos_url":"https://api.github.com/users/shyoo/repos","events_url":"https://api.github.com/users/shyoo/events{/privacy}","received_events_url":"https://api.github.com/users/shyoo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-30T23:52:57Z","updated_at":"2017-12-01T00:31:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aabf15693a582e2cfaf179d70cb2b9f93899166d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wmohsin","id":22244866,"avatar_url":"https://avatars3.githubusercontent.com/u/22244866?v=4","gravatar_id":"","url":"https://api.github.com/users/wmohsin","html_url":"https://github.com/wmohsin","followers_url":"https://api.github.com/users/wmohsin/followers","following_url":"https://api.github.com/users/wmohsin/following{/other_user}","gists_url":"https://api.github.com/users/wmohsin/gists{/gist_id}","starred_url":"https://api.github.com/users/wmohsin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmohsin/subscriptions","organizations_url":"https://api.github.com/users/wmohsin/orgs","repos_url":"https://api.github.com/users/wmohsin/repos","events_url":"https://api.github.com/users/wmohsin/events{/privacy}","received_events_url":"https://api.github.com/users/wmohsin/received_events","type":"User","site_admin":false},{"login":"samar-abdi","id":24684223,"avatar_url":"https://avatars2.githubusercontent.com/u/24684223?v=4","gravatar_id":"","url":"https://api.github.com/users/samar-abdi","html_url":"https://github.com/samar-abdi","followers_url":"https://api.github.com/users/samar-abdi/followers","following_url":"https://api.github.com/users/samar-abdi/following{/other_user}","gists_url":"https://api.github.com/users/samar-abdi/gists{/gist_id}","starred_url":"https://api.github.com/users/samar-abdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samar-abdi/subscriptions","organizations_url":"https://api.github.com/users/samar-abdi/orgs","repos_url":"https://api.github.com/users/samar-abdi/repos","events_url":"https://api.github.com/users/samar-abdi/events{/privacy}","received_events_url":"https://api.github.com/users/samar-abdi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/p4lang/PI/pulls/244/commits","review_comments_url":"https://api.github.com/repos/p4lang/PI/pulls/244/comments","review_comment_url":"https://api.github.com/repos/p4lang/PI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p4lang/PI/issues/244/comments","statuses_url":"https://api.github.com/repos/p4lang/PI/statuses/a30e146bbf663f3cfc2990b82327f7daed69f443","head":{"label":"p4lang:p4error","ref":"p4error","sha":"a30e146bbf663f3cfc2990b82327f7daed69f443","user":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":51870280,"name":"PI","full_name":"p4lang/PI","owner":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/PI","description":"P4 Runtime - a control plane framework and tools for the P4 programming language","fork":false,"url":"https://api.github.com/repos/p4lang/PI","forks_url":"https://api.github.com/repos/p4lang/PI/forks","keys_url":"https://api.github.com/repos/p4lang/PI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/PI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/PI/teams","hooks_url":"https://api.github.com/repos/p4lang/PI/hooks","issue_events_url":"https://api.github.com/repos/p4lang/PI/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/PI/events","assignees_url":"https://api.github.com/repos/p4lang/PI/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/PI/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/PI/tags","blobs_url":"https://api.github.com/repos/p4lang/PI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/PI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/PI/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/PI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/PI/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/PI/languages","stargazers_url":"https://api.github.com/repos/p4lang/PI/stargazers","contributors_url":"https://api.github.com/repos/p4lang/PI/contributors","subscribers_url":"https://api.github.com/repos/p4lang/PI/subscribers","subscription_url":"https://api.github.com/repos/p4lang/PI/subscription","commits_url":"https://api.github.com/repos/p4lang/PI/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/PI/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/PI/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/PI/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/PI/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/PI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/PI/merges","archive_url":"https://api.github.com/repos/p4lang/PI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/PI/downloads","issues_url":"https://api.github.com/repos/p4lang/PI/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/PI/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/PI/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/PI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/PI/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/PI/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/PI/deployments","created_at":"2016-02-16T21:07:15Z","updated_at":"2017-11-27T08:52:22Z","pushed_at":"2017-11-30T23:52:57Z","git_url":"git://github.com/p4lang/PI.git","ssh_url":"git@github.com:p4lang/PI.git","clone_url":"https://github.com/p4lang/PI.git","svn_url":"https://github.com/p4lang/PI","homepage":"","size":1809,"stargazers_count":28,"watchers_count":28,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":17,"open_issues":21,"watchers":28,"default_branch":"master"}},"base":{"label":"p4lang:master","ref":"master","sha":"f51b6f91e6dc018ef784aa22df2f345b9186b20d","user":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":51870280,"name":"PI","full_name":"p4lang/PI","owner":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/PI","description":"P4 Runtime - a control plane framework and tools for the P4 programming language","fork":false,"url":"https://api.github.com/repos/p4lang/PI","forks_url":"https://api.github.com/repos/p4lang/PI/forks","keys_url":"https://api.github.com/repos/p4lang/PI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/PI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/PI/teams","hooks_url":"https://api.github.com/repos/p4lang/PI/hooks","issue_events_url":"https://api.github.com/repos/p4lang/PI/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/PI/events","assignees_url":"https://api.github.com/repos/p4lang/PI/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/PI/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/PI/tags","blobs_url":"https://api.github.com/repos/p4lang/PI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/PI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/PI/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/PI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/PI/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/PI/languages","stargazers_url":"https://api.github.com/repos/p4lang/PI/stargazers","contributors_url":"https://api.github.com/repos/p4lang/PI/contributors","subscribers_url":"https://api.github.com/repos/p4lang/PI/subscribers","subscription_url":"https://api.github.com/repos/p4lang/PI/subscription","commits_url":"https://api.github.com/repos/p4lang/PI/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/PI/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/PI/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/PI/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/PI/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/PI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/PI/merges","archive_url":"https://api.github.com/repos/p4lang/PI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/PI/downloads","issues_url":"https://api.github.com/repos/p4lang/PI/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/PI/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/PI/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/PI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/PI/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/PI/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/PI/deployments","created_at":"2016-02-16T21:07:15Z","updated_at":"2017-11-27T08:52:22Z","pushed_at":"2017-11-30T23:52:57Z","git_url":"git://github.com/p4lang/PI.git","ssh_url":"git@github.com:p4lang/PI.git","clone_url":"https://github.com/p4lang/PI.git","svn_url":"https://github.com/p4lang/PI","homepage":"","size":1809,"stargazers_count":28,"watchers_count":28,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":17,"open_issues":21,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p4lang/PI/pulls/244"},"html":{"href":"https://github.com/p4lang/PI/pull/244"},"issue":{"href":"https://api.github.com/repos/p4lang/PI/issues/244"},"comments":{"href":"https://api.github.com/repos/p4lang/PI/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/p4lang/PI/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/p4lang/PI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p4lang/PI/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/p4lang/PI/statuses/a30e146bbf663f3cfc2990b82327f7daed69f443"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"antoninbas"}}