{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments/153046198","pull_request_review_id":79002850,"id":153046198,"diff_hunk":"@@ -235,6 +241,13 @@ export default class NativeAdapter extends BaseMediaSourceAdapter {\n    */\n   _onError(reject: Function, error: FakeEvent): void {\n     NativeAdapter._logger.error(error);\n+    const message = PlayerError.createError({","path":"src/engines/html5/media-source/adapters/native-adapter.js","position":39,"original_position":39,"commit_id":"5f5b9939e136d31e0e3cbeb02542c91b6eb5a92e","original_commit_id":"5f5b9939e136d31e0e3cbeb02542c91b6eb5a92e","user":{"login":"OrenMe","id":5461862,"avatar_url":"https://avatars1.githubusercontent.com/u/5461862?v=4","gravatar_id":"","url":"https://api.github.com/users/OrenMe","html_url":"https://github.com/OrenMe","followers_url":"https://api.github.com/users/OrenMe/followers","following_url":"https://api.github.com/users/OrenMe/following{/other_user}","gists_url":"https://api.github.com/users/OrenMe/gists{/gist_id}","starred_url":"https://api.github.com/users/OrenMe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrenMe/subscriptions","organizations_url":"https://api.github.com/users/OrenMe/orgs","repos_url":"https://api.github.com/users/OrenMe/repos","events_url":"https://api.github.com/users/OrenMe/events{/privacy}","received_events_url":"https://api.github.com/users/OrenMe/received_events","type":"User","site_admin":false},"body":"better handle the error dispatching in html5, and only use this for the load promise rejecting","created_at":"2017-11-25T13:51:37Z","updated_at":"2017-11-25T14:02:42Z","html_url":"https://github.com/kaltura/playkit-js/pull/162#discussion_r153046198","pull_request_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/162","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments/153046198"},"html":{"href":"https://github.com/kaltura/playkit-js/pull/162#discussion_r153046198"},"pull_request":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/playkit-js/pulls/162","id":152848573,"html_url":"https://github.com/kaltura/playkit-js/pull/162","diff_url":"https://github.com/kaltura/playkit-js/pull/162.diff","patch_url":"https://github.com/kaltura/playkit-js/pull/162.patch","issue_url":"https://api.github.com/repos/kaltura/playkit-js/issues/162","number":162,"state":"open","locked":false,"title":"fix(FEC-7476): refactor error handling ","user":{"login":"odedhutzler","id":31587052,"avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"body":"### Description of the Changes\r\n\r\nhey guys - its still have some debugging code (like the console.log())\r\n\r\nbut have a look - let me know what you think.... i will prettify it.. :)\r\n\r\n\r\n\r\n### CheckLists\r\n\r\n- [ ] changes have been done against master branch, and PR does not conflict\r\n- [ ] new unit / functional tests have been added (whenever applicable)\r\n- [ ] test are passing in local environment \r\n- [ ] Travis tests are passing (or test results are not worse than on master branch :))\r\n- [ ] Docs have been updated\r\n","created_at":"2017-11-15T18:16:46Z","updated_at":"2017-11-25T14:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd93ad3234573c8ddba8468806dd84f5164c4b69","assignee":{"login":"odedhutzler","id":31587052,"avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"assignees":[{"login":"odedhutzler","id":31587052,"avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yairans","id":17685520,"avatar_url":"https://avatars3.githubusercontent.com/u/17685520?v=4","gravatar_id":"","url":"https://api.github.com/users/yairans","html_url":"https://github.com/yairans","followers_url":"https://api.github.com/users/yairans/followers","following_url":"https://api.github.com/users/yairans/following{/other_user}","gists_url":"https://api.github.com/users/yairans/gists{/gist_id}","starred_url":"https://api.github.com/users/yairans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairans/subscriptions","organizations_url":"https://api.github.com/users/yairans/orgs","repos_url":"https://api.github.com/users/yairans/repos","events_url":"https://api.github.com/users/yairans/events{/privacy}","received_events_url":"https://api.github.com/users/yairans/received_events","type":"User","site_admin":false},{"login":"dan-ziv","id":21081590,"avatar_url":"https://avatars2.githubusercontent.com/u/21081590?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-ziv","html_url":"https://github.com/dan-ziv","followers_url":"https://api.github.com/users/dan-ziv/followers","following_url":"https://api.github.com/users/dan-ziv/following{/other_user}","gists_url":"https://api.github.com/users/dan-ziv/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-ziv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-ziv/subscriptions","organizations_url":"https://api.github.com/users/dan-ziv/orgs","repos_url":"https://api.github.com/users/dan-ziv/repos","events_url":"https://api.github.com/users/dan-ziv/events{/privacy}","received_events_url":"https://api.github.com/users/dan-ziv/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/162/commits","review_comments_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/162/comments","review_comment_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/issues/162/comments","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/5f5b9939e136d31e0e3cbeb02542c91b6eb5a92e","head":{"label":"kaltura:error_handling_refactor","ref":"error_handling_refactor","sha":"5f5b9939e136d31e0e3cbeb02542c91b6eb5a92e","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"name":"playkit-js","full_name":"kaltura/playkit-js","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-js","description":"State of the art HTML5 player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2017-11-07T13:36:29Z","pushed_at":"2017-11-22T15:31:53Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":"","size":45424,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"f61dce4cb6f2d2f6197e3114fe2b8db64a5b4355","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"name":"playkit-js","full_name":"kaltura/playkit-js","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-js","description":"State of the art HTML5 player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2017-11-07T13:36:29Z","pushed_at":"2017-11-22T15:31:53Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":"","size":45424,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/162"},"html":{"href":"https://github.com/kaltura/playkit-js/pull/162"},"issue":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/162"},"comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/playkit-js/statuses/5f5b9939e136d31e0e3cbeb02542c91b6eb5a92e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OrenMe"}}