{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/97667189","pull_request_review_id":18280579,"id":97667189,"diff_hunk":"@@ -81,6 +81,16 @@ func unjoinFederation(f cmdutil.Factory, cmdOut, cmdErr io.Writer, config util.A\n \t\treturn nil\n \t}\n \n+\t//we need to ensure deleting the config map created in the deregistered cluster\n+\t//this configmap was created when the cluster joined this federation to aid\n+\t//the kube-dns of that cluser to aid service discovery","path":"federation/pkg/kubefed/unjoin.go","position":6,"original_position":6,"commit_id":"6a1cfe68cf4318939ac9d3ef3479639df16e1dea","original_commit_id":"6a1cfe68cf4318939ac9d3ef3479639df16e1dea","user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"body":"s/cluser/cluster/","created_at":"2017-01-24T22:28:08Z","updated_at":"2017-01-24T22:37:06Z","html_url":"https://github.com/kubernetes/kubernetes/pull/39338#discussion_r97667189","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/97667189"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/39338#discussion_r97667189"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338","id":99821264,"html_url":"https://github.com/kubernetes/kubernetes/pull/39338","diff_url":"https://github.com/kubernetes/kubernetes/pull/39338.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/39338.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/39338","number":39338,"state":"open","locked":false,"title":"[Federation] Create configmap for the cluster kube-dns when cluster joins and remove when it unjoins","user":{"login":"irfanurrehman","id":10027921,"avatar_url":"https://avatars.githubusercontent.com/u/10027921?v=3","gravatar_id":"","url":"https://api.github.com/users/irfanurrehman","html_url":"https://github.com/irfanurrehman","followers_url":"https://api.github.com/users/irfanurrehman/followers","following_url":"https://api.github.com/users/irfanurrehman/following{/other_user}","gists_url":"https://api.github.com/users/irfanurrehman/gists{/gist_id}","starred_url":"https://api.github.com/users/irfanurrehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfanurrehman/subscriptions","organizations_url":"https://api.github.com/users/irfanurrehman/orgs","repos_url":"https://api.github.com/users/irfanurrehman/repos","events_url":"https://api.github.com/users/irfanurrehman/events{/privacy}","received_events_url":"https://api.github.com/users/irfanurrehman/received_events","type":"User","site_admin":false},"body":"This PR implements the functionality as needed in https://github.com/kubernetes/kubernetes/issues/38400\r\nThis PR is done on top of https://github.com/kubernetes/kubernetes/pull/39230, which is reviewed separately. Please review only the last 2 commits of this PR.\r\n\r\ncc @kubernetes/sig-cluster-federation @nikhiljindal @madhusudancs \r\n","created_at":"2017-01-01T10:59:32Z","updated_at":"2017-01-24T22:37:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c5012759514c84449e4389c1833e6e90961b216","assignee":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"assignees":[{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/39338/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/6a1cfe68cf4318939ac9d3ef3479639df16e1dea","head":{"label":"irfanurrehman:fed-join-1","ref":"fed-join-1","sha":"6a1cfe68cf4318939ac9d3ef3479639df16e1dea","user":{"login":"irfanurrehman","id":10027921,"avatar_url":"https://avatars.githubusercontent.com/u/10027921?v=3","gravatar_id":"","url":"https://api.github.com/users/irfanurrehman","html_url":"https://github.com/irfanurrehman","followers_url":"https://api.github.com/users/irfanurrehman/followers","following_url":"https://api.github.com/users/irfanurrehman/following{/other_user}","gists_url":"https://api.github.com/users/irfanurrehman/gists{/gist_id}","starred_url":"https://api.github.com/users/irfanurrehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfanurrehman/subscriptions","organizations_url":"https://api.github.com/users/irfanurrehman/orgs","repos_url":"https://api.github.com/users/irfanurrehman/repos","events_url":"https://api.github.com/users/irfanurrehman/events{/privacy}","received_events_url":"https://api.github.com/users/irfanurrehman/received_events","type":"User","site_admin":false},"repo":{"id":64205485,"name":"kubernetes","full_name":"irfanurrehman/kubernetes","owner":{"login":"irfanurrehman","id":10027921,"avatar_url":"https://avatars.githubusercontent.com/u/10027921?v=3","gravatar_id":"","url":"https://api.github.com/users/irfanurrehman","html_url":"https://github.com/irfanurrehman","followers_url":"https://api.github.com/users/irfanurrehman/followers","following_url":"https://api.github.com/users/irfanurrehman/following{/other_user}","gists_url":"https://api.github.com/users/irfanurrehman/gists{/gist_id}","starred_url":"https://api.github.com/users/irfanurrehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfanurrehman/subscriptions","organizations_url":"https://api.github.com/users/irfanurrehman/orgs","repos_url":"https://api.github.com/users/irfanurrehman/repos","events_url":"https://api.github.com/users/irfanurrehman/events{/privacy}","received_events_url":"https://api.github.com/users/irfanurrehman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/irfanurrehman/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/irfanurrehman/kubernetes","forks_url":"https://api.github.com/repos/irfanurrehman/kubernetes/forks","keys_url":"https://api.github.com/repos/irfanurrehman/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irfanurrehman/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irfanurrehman/kubernetes/teams","hooks_url":"https://api.github.com/repos/irfanurrehman/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/irfanurrehman/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/irfanurrehman/kubernetes/events","assignees_url":"https://api.github.com/repos/irfanurrehman/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/irfanurrehman/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/irfanurrehman/kubernetes/tags","blobs_url":"https://api.github.com/repos/irfanurrehman/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irfanurrehman/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irfanurrehman/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/irfanurrehman/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irfanurrehman/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/irfanurrehman/kubernetes/languages","stargazers_url":"https://api.github.com/repos/irfanurrehman/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/irfanurrehman/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/irfanurrehman/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/irfanurrehman/kubernetes/subscription","commits_url":"https://api.github.com/repos/irfanurrehman/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/irfanurrehman/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/irfanurrehman/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/irfanurrehman/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/irfanurrehman/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/irfanurrehman/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irfanurrehman/kubernetes/merges","archive_url":"https://api.github.com/repos/irfanurrehman/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irfanurrehman/kubernetes/downloads","issues_url":"https://api.github.com/repos/irfanurrehman/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/irfanurrehman/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/irfanurrehman/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/irfanurrehman/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irfanurrehman/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/irfanurrehman/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/irfanurrehman/kubernetes/deployments","created_at":"2016-07-26T08:48:18Z","updated_at":"2016-07-26T08:48:48Z","pushed_at":"2017-01-22T07:47:15Z","git_url":"git://github.com/irfanurrehman/kubernetes.git","ssh_url":"git@github.com:irfanurrehman/kubernetes.git","clone_url":"https://github.com/irfanurrehman/kubernetes.git","svn_url":"https://github.com/irfanurrehman/kubernetes","homepage":"http://kubernetes.io","size":385513,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ba611194f7eda2257e32399cb98603c6a45998a4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-01-24T21:09:57Z","pushed_at":"2017-01-24T22:35:36Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":513520,"stargazers_count":20112,"watchers_count":20112,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6830,"mirror_url":null,"open_issues_count":5535,"forks":6830,"open_issues":5535,"watchers":20112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/39338"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/39338"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/39338/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39338/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/6a1cfe68cf4318939ac9d3ef3479639df16e1dea"}}}}
{"actor":{"display_login":"madhusudancs"}}