{"action":"created","issue":{"url":"https://api.github.com/repos/ryanisnhp/Prework-IOS/issues/1","repository_url":"https://api.github.com/repos/ryanisnhp/Prework-IOS","labels_url":"https://api.github.com/repos/ryanisnhp/Prework-IOS/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ryanisnhp/Prework-IOS/issues/1/comments","events_url":"https://api.github.com/repos/ryanisnhp/Prework-IOS/issues/1/events","html_url":"https://github.com/ryanisnhp/Prework-IOS/issues/1","id":233382178,"number":1,"title":"Prework submission review","user":{"login":"avo1","id":10482065,"avatar_url":"https://avatars2.githubusercontent.com/u/10482065?v=3","gravatar_id":"","url":"https://api.github.com/users/avo1","html_url":"https://github.com/avo1","followers_url":"https://api.github.com/users/avo1/followers","following_url":"https://api.github.com/users/avo1/following{/other_user}","gists_url":"https://api.github.com/users/avo1/gists{/gist_id}","starred_url":"https://api.github.com/users/avo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avo1/subscriptions","organizations_url":"https://api.github.com/users/avo1/orgs","repos_url":"https://api.github.com/users/avo1/repos","events_url":"https://api.github.com/users/avo1/events{/privacy}","received_events_url":"https://api.github.com/users/avo1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-03T17:07:31Z","updated_at":"2017-06-03T17:48:55Z","closed_at":null,"body":"Thanks @ryanisnhp for your submission. 👍 great work with Tip Calculator.\r\n\r\n### Quick Comments:\r\n\r\n- Your app UI looks good, and good job with auto layout :smile:  \r\n- Good job organize your files into the folders.\r\n- Good usage of `UserDefaults`. This is one of the methods to pass the data from multiple viewController. We will learn few more ways to do that. \r\n- On your Setting Page, when I change the color, nothing happen to tell me that the new color is chosen. I though the app hang.\r\n- In the TipViewController, why do you want to do a `switch` statement in the `segmentTipSelected`? Also consider to save the index of the selected segment, instead of the value.\r\n- You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros. I can also paste some text in the text field, and your app will crash. Think of a way how you can prevent it.\r\n- Your keyboard doesn't have the decimal point, how can user type something like `50.5`\r\n- I see the `;` randomly in your code. Swift doesn't use it.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ryanisnhp/Prework-IOS/issues/comments/305990692","html_url":"https://github.com/ryanisnhp/Prework-IOS/issues/1#issuecomment-305990692","issue_url":"https://api.github.com/repos/ryanisnhp/Prework-IOS/issues/1","id":305990692,"user":{"login":"ryanisnhp","id":26299033,"avatar_url":"https://avatars0.githubusercontent.com/u/26299033?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanisnhp","html_url":"https://github.com/ryanisnhp","followers_url":"https://api.github.com/users/ryanisnhp/followers","following_url":"https://api.github.com/users/ryanisnhp/following{/other_user}","gists_url":"https://api.github.com/users/ryanisnhp/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanisnhp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanisnhp/subscriptions","organizations_url":"https://api.github.com/users/ryanisnhp/orgs","repos_url":"https://api.github.com/users/ryanisnhp/repos","events_url":"https://api.github.com/users/ryanisnhp/events{/privacy}","received_events_url":"https://api.github.com/users/ryanisnhp/received_events","type":"User","site_admin":false},"created_at":"2017-06-03T17:48:55Z","updated_at":"2017-06-03T17:48:55Z","body":" Thanks a lot for your comments, but should I fix it and submit it again?\n\n2017-06-04 0:07 GMT+07:00 Dave Vo <notifications@github.com>:\n\n> Thanks @ryanisnhp <https://github.com/ryanisnhp> for your submission. 👍\n> great work with Tip Calculator.\n> Quick Comments:\n>\n>    - Your app UI looks good, and good job with auto layout 😄\n>    - Good job organize your files into the folders.\n>    - Good usage of UserDefaults. This is one of the methods to pass the\n>    data from multiple viewController. We will learn few more ways to do that.\n>    - On your Setting Page, when I change the color, nothing happen to\n>    tell me that the new color is chosen. I though the app hang.\n>    - In the TipViewController, why do you want to do a switch statement\n>    in the segmentTipSelected? Also consider to save the index of the\n>    selected segment, instead of the value.\n>    - You shouldn't let the user enter invalid number, should you? I can\n>    enter bunch of leading zeros. I can also paste some text in the text field,\n>    and your app will crash. Think of a way how you can prevent it.\n>    - Your keyboard doesn't have the decimal point, how can user type\n>    something like 50.5\n>    - I see the ; randomly in your code. Swift doesn't use it.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/ryanisnhp/Prework-IOS/issues/1>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AZFKmXj2ABOV1t51IEupC8HogY0MfOXZks5sAZLTgaJpZM4NvJFe>\n> .\n>\n"}}
{"actor":{"display_login":"ryanisnhp"}}