{"action":"created","issue":{"url":"https://api.github.com/repos/seekhealing/seekhealing.github.io/issues/41","repository_url":"https://api.github.com/repos/seekhealing/seekhealing.github.io","labels_url":"https://api.github.com/repos/seekhealing/seekhealing.github.io/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/seekhealing/seekhealing.github.io/issues/41/comments","events_url":"https://api.github.com/repos/seekhealing/seekhealing.github.io/issues/41/events","html_url":"https://github.com/seekhealing/seekhealing.github.io/pull/41","id":265131475,"number":41,"title":"Feature: Adding LinkedIn & YouTube links","user":{"login":"shredtechular","id":2396774,"avatar_url":"https://avatars3.githubusercontent.com/u/2396774?v=4","gravatar_id":"","url":"https://api.github.com/users/shredtechular","html_url":"https://github.com/shredtechular","followers_url":"https://api.github.com/users/shredtechular/followers","following_url":"https://api.github.com/users/shredtechular/following{/other_user}","gists_url":"https://api.github.com/users/shredtechular/gists{/gist_id}","starred_url":"https://api.github.com/users/shredtechular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shredtechular/subscriptions","organizations_url":"https://api.github.com/users/shredtechular/orgs","repos_url":"https://api.github.com/users/shredtechular/repos","events_url":"https://api.github.com/users/shredtechular/events{/privacy}","received_events_url":"https://api.github.com/users/shredtechular/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-13T00:21:58Z","updated_at":"2017-10-15T23:47:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/seekhealing/seekhealing.github.io/pulls/41","html_url":"https://github.com/seekhealing/seekhealing.github.io/pull/41","diff_url":"https://github.com/seekhealing/seekhealing.github.io/pull/41.diff","patch_url":"https://github.com/seekhealing/seekhealing.github.io/pull/41.patch"},"body":"This pull request fixes #34.\r\n\r\n# Description\r\nThe ask for #34 was to add LinkedIn and YouTube buttons to the site.  It seems that social media buttons currently exist in 2 places.  The footer and on the contact page.\r\n\r\n# Solution\r\nThis pull request adds the LinkedIn and YouTube buttons to both the footer and the contact page.  Currently, the way the site was coded, this required updates in 2 different html files.  One place in the `_includes/footer.html` and the other on the `contact.html` page.  Additionally, I noticed a few more responsive issues with the social media icons on the contact page so fixed those issues in this pull request as well.\r\n\r\n# Other Miscellaneous Questions & Notes that shouldn't hold up pull request but be noted\r\n- [ ] In the footer, on smaller screen widths including mobile devices, the site was coded to hide the social media icons & email address, is that intentional?  Is that what is wanted?  For now, I left as-is.\r\n- [ ] Having to update code in 2 places to simply add 2 new social media icons/links is not very efficient.  This is one of many perfect examples where Jekyll's capabilities could be utilized more fully within the site and maintenance of footer links, header links, social media links, etc. could be streamlined to purely updating a data file instead of messing with html, css, etc.  I'm following the coding practice of the current site for now, but we may want to discuss this more for a longer term solution if necessary.\r\n\r\n# Before and After Screenshots of this pull request:\r\n## Desktop display of contact page and footer\r\n### Current\r\n<kbd>\r\n<img width=\"1206\" alt=\"screen shot 2017-10-12 at 7 59 09 pm\" src=\"https://user-images.githubusercontent.com/2396774/31524960-ea6862d6-af8a-11e7-94ed-804ba6858ece.png\">\r\n</kbd>\r\n\r\n### With changes of this pull request\r\n<kbd>\r\n<img width=\"1226\" alt=\"screen shot 2017-10-12 at 7 58 53 pm\" src=\"https://user-images.githubusercontent.com/2396774/31524867-5ed5e2fc-af8a-11e7-985e-b99371d13bad.png\">\r\n</kbd>\r\n\r\n## Ipad/tablet displays of contact page and footer\r\n### Current\r\n<kbd>\r\n<img width=\"775\" alt=\"screen shot 2017-10-12 at 7 59 41 pm\" src=\"https://user-images.githubusercontent.com/2396774/31524899-98e41a5e-af8a-11e7-9d61-ae7fd523f23f.png\">\r\n</kbd>\r\n\r\n### With changes of this pull request\r\n<kbd>\r\n<img width=\"773\" alt=\"screen shot 2017-10-12 at 7 59 33 pm\" src=\"https://user-images.githubusercontent.com/2396774/31524904-9fe425d8-af8a-11e7-9736-327b4f9b7b73.png\">\r\n</kbd>\r\n\r\n## Mobile displays of contact page and footer (notice no icons in footer)\r\n### Current\r\n<kbd>\r\n<img width=\"316\" alt=\"screen shot 2017-10-12 at 8 00 16 pm\" src=\"https://user-images.githubusercontent.com/2396774/31524911-a52de02e-af8a-11e7-8f77-4beb4966db55.png\">\r\n</kbd>\r\n\r\n\r\n### With changes of this pull request\r\n<kbd>\r\n<img width=\"336\" alt=\"screen shot 2017-10-12 at 8 00 04 pm\" src=\"https://user-images.githubusercontent.com/2396774/31524914-a894d092-af8a-11e7-8c5a-607ce49150e1.png\">\r\n</kbd>\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/seekhealing/seekhealing.github.io/issues/comments/336750948","html_url":"https://github.com/seekhealing/seekhealing.github.io/pull/41#issuecomment-336750948","issue_url":"https://api.github.com/repos/seekhealing/seekhealing.github.io/issues/41","id":336750948,"user":{"login":"shredtechular","id":2396774,"avatar_url":"https://avatars3.githubusercontent.com/u/2396774?v=4","gravatar_id":"","url":"https://api.github.com/users/shredtechular","html_url":"https://github.com/shredtechular","followers_url":"https://api.github.com/users/shredtechular/followers","following_url":"https://api.github.com/users/shredtechular/following{/other_user}","gists_url":"https://api.github.com/users/shredtechular/gists{/gist_id}","starred_url":"https://api.github.com/users/shredtechular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shredtechular/subscriptions","organizations_url":"https://api.github.com/users/shredtechular/orgs","repos_url":"https://api.github.com/users/shredtechular/repos","events_url":"https://api.github.com/users/shredtechular/events{/privacy}","received_events_url":"https://api.github.com/users/shredtechular/received_events","type":"User","site_admin":false},"created_at":"2017-10-15T23:47:46Z","updated_at":"2017-10-15T23:47:46Z","author_association":"NONE","body":"@j00bar this PR is ready to be reviewed now."}}
{"actor":{"display_login":"shredtechular"}}