{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments/102216042","pull_request_review_id":22964979,"id":102216042,"diff_hunk":"@@ -0,0 +1,75 @@\n+package plan\n+\n+// DNSRecord holds information about a DNS record.\n+type DNSRecord struct {","path":"plan/plan.go","position":4,"original_position":4,"commit_id":"bd8dd3d499dba695d849b67d33e10d35230ea251","original_commit_id":"bd8dd3d499dba695d849b67d33e10d35230ea251","user":{"login":"ideahitme","id":23239537,"avatar_url":"https://avatars.githubusercontent.com/u/23239537?v=3","gravatar_id":"","url":"https://api.github.com/users/ideahitme","html_url":"https://github.com/ideahitme","followers_url":"https://api.github.com/users/ideahitme/followers","following_url":"https://api.github.com/users/ideahitme/following{/other_user}","gists_url":"https://api.github.com/users/ideahitme/gists{/gist_id}","starred_url":"https://api.github.com/users/ideahitme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideahitme/subscriptions","organizations_url":"https://api.github.com/users/ideahitme/orgs","repos_url":"https://api.github.com/users/ideahitme/repos","events_url":"https://api.github.com/users/ideahitme/events{/privacy}","received_events_url":"https://api.github.com/users/ideahitme/received_events","type":"User","site_admin":false},"body":"in the project structure proposal it is in the plan package, but it might make sense to create a separate package for this, if this is something to be shared and used by other packages. but fine with me for now :) ","created_at":"2017-02-21T14:18:01Z","updated_at":"2017-02-21T14:18:01Z","html_url":"https://github.com/kubernetes-incubator/external-dns/pull/26#discussion_r102216042","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments/102216042"},"html":{"href":"https://github.com/kubernetes-incubator/external-dns/pull/26#discussion_r102216042"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26","id":107187508,"html_url":"https://github.com/kubernetes-incubator/external-dns/pull/26","diff_url":"https://github.com/kubernetes-incubator/external-dns/pull/26.diff","patch_url":"https://github.com/kubernetes-incubator/external-dns/pull/26.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/26","number":26,"state":"open","locked":false,"title":"First implementation of Plan","user":{"login":"linki","id":36162,"avatar_url":"https://avatars.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"body":"This is an initial and very naive implementation of [Plan](https://github.com/kubernetes-incubator/external-dns/issues/13).\r\n\r\nIt can be passed a list of *current* and *desired* `DNSRecord`s and calculates from it lists which records need to be *created*, *updated* and *deleted* respectively. The plan or the resulting lists can then be passed to DNS providers which would execute the corresponding actions.\r\n\r\nFor update, it actually returns two lists with the new records and the old records at their corresponding indexes. This should probably be refined later but was easier to test for now.\r\n\r\nIt also adds an Example and Benchmark for the Calculate method.","created_at":"2017-02-21T13:26:29Z","updated_at":"2017-02-21T14:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecd6500c1aefaeec62cc08ae50a30866793863ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/26/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/statuses/bd8dd3d499dba695d849b67d33e10d35230ea251","head":{"label":"linki:plan","ref":"plan","sha":"bd8dd3d499dba695d849b67d33e10d35230ea251","user":{"login":"linki","id":36162,"avatar_url":"https://avatars.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"repo":{"id":82679323,"name":"external-dns","full_name":"linki/external-dns","owner":{"login":"linki","id":36162,"avatar_url":"https://avatars.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linki/external-dns","description":null,"fork":true,"url":"https://api.github.com/repos/linki/external-dns","forks_url":"https://api.github.com/repos/linki/external-dns/forks","keys_url":"https://api.github.com/repos/linki/external-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linki/external-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linki/external-dns/teams","hooks_url":"https://api.github.com/repos/linki/external-dns/hooks","issue_events_url":"https://api.github.com/repos/linki/external-dns/issues/events{/number}","events_url":"https://api.github.com/repos/linki/external-dns/events","assignees_url":"https://api.github.com/repos/linki/external-dns/assignees{/user}","branches_url":"https://api.github.com/repos/linki/external-dns/branches{/branch}","tags_url":"https://api.github.com/repos/linki/external-dns/tags","blobs_url":"https://api.github.com/repos/linki/external-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linki/external-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linki/external-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/linki/external-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linki/external-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/linki/external-dns/languages","stargazers_url":"https://api.github.com/repos/linki/external-dns/stargazers","contributors_url":"https://api.github.com/repos/linki/external-dns/contributors","subscribers_url":"https://api.github.com/repos/linki/external-dns/subscribers","subscription_url":"https://api.github.com/repos/linki/external-dns/subscription","commits_url":"https://api.github.com/repos/linki/external-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/linki/external-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/linki/external-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/linki/external-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/linki/external-dns/contents/{+path}","compare_url":"https://api.github.com/repos/linki/external-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linki/external-dns/merges","archive_url":"https://api.github.com/repos/linki/external-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linki/external-dns/downloads","issues_url":"https://api.github.com/repos/linki/external-dns/issues{/number}","pulls_url":"https://api.github.com/repos/linki/external-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/linki/external-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/linki/external-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linki/external-dns/labels{/name}","releases_url":"https://api.github.com/repos/linki/external-dns/releases{/id}","deployments_url":"https://api.github.com/repos/linki/external-dns/deployments","created_at":"2017-02-21T12:50:38Z","updated_at":"2017-02-18T17:00:23Z","pushed_at":"2017-02-21T13:55:54Z","git_url":"git://github.com/linki/external-dns.git","ssh_url":"git@github.com:linki/external-dns.git","clone_url":"https://github.com/linki/external-dns.git","svn_url":"https://github.com/linki/external-dns","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"786055f3b3023489170a7efb507d64697534e8e6","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":81497153,"name":"external-dns","full_name":"kubernetes-incubator/external-dns","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/external-dns","description":null,"fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/external-dns","forks_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/external-dns/deployments","created_at":"2017-02-09T21:34:27Z","updated_at":"2017-02-18T17:00:23Z","pushed_at":"2017-02-21T13:55:54Z","git_url":"git://github.com/kubernetes-incubator/external-dns.git","ssh_url":"git@github.com:kubernetes-incubator/external-dns.git","clone_url":"https://github.com/kubernetes-incubator/external-dns.git","svn_url":"https://github.com/kubernetes-incubator/external-dns","homepage":null,"size":21,"stargazers_count":18,"watchers_count":18,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26"},"html":{"href":"https://github.com/kubernetes-incubator/external-dns/pull/26"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/26"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/external-dns/statuses/bd8dd3d499dba695d849b67d33e10d35230ea251"}}}}
{"actor":{"display_login":"ideahitme"}}