{"action":"created","issue":{"url":"https://api.github.com/repos/pnpm/supi/issues/32","repository_url":"https://api.github.com/repos/pnpm/supi","labels_url":"https://api.github.com/repos/pnpm/supi/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/pnpm/supi/issues/32/comments","events_url":"https://api.github.com/repos/pnpm/supi/issues/32/events","html_url":"https://github.com/pnpm/supi/pull/32","id":285161527,"number":32,"title":"feat: add packageImportMethod option","user":{"login":"etamponi","id":578612,"avatar_url":"https://avatars0.githubusercontent.com/u/578612?v=4","gravatar_id":"","url":"https://api.github.com/users/etamponi","html_url":"https://github.com/etamponi","followers_url":"https://api.github.com/users/etamponi/followers","following_url":"https://api.github.com/users/etamponi/following{/other_user}","gists_url":"https://api.github.com/users/etamponi/gists{/gist_id}","starred_url":"https://api.github.com/users/etamponi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etamponi/subscriptions","organizations_url":"https://api.github.com/users/etamponi/orgs","repos_url":"https://api.github.com/users/etamponi/repos","events_url":"https://api.github.com/users/etamponi/events{/privacy}","received_events_url":"https://api.github.com/users/etamponi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-12-29T22:02:52Z","updated_at":"2017-12-30T20:50:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pnpm/supi/pulls/32","html_url":"https://github.com/pnpm/supi/pull/32","diff_url":"https://github.com/pnpm/supi/pull/32.diff","patch_url":"https://github.com/pnpm/supi/pull/32.patch"},"body":"I didn't want to spend too much time figuring out the right signature for the `execFilePromise` function, but everything else should be there. As for the tests, in this case, I would have some troubles as reflinks only work on some kind of filesystems.\r\n\r\nI can mock `child_process` if you want, using `mockery` or similar tools."},"comment":{"url":"https://api.github.com/repos/pnpm/supi/issues/comments/354567619","html_url":"https://github.com/pnpm/supi/pull/32#issuecomment-354567619","issue_url":"https://api.github.com/repos/pnpm/supi/issues/32","id":354567619,"user":{"login":"etamponi","id":578612,"avatar_url":"https://avatars0.githubusercontent.com/u/578612?v=4","gravatar_id":"","url":"https://api.github.com/users/etamponi","html_url":"https://github.com/etamponi","followers_url":"https://api.github.com/users/etamponi/followers","following_url":"https://api.github.com/users/etamponi/following{/other_user}","gists_url":"https://api.github.com/users/etamponi/gists{/gist_id}","starred_url":"https://api.github.com/users/etamponi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etamponi/subscriptions","organizations_url":"https://api.github.com/users/etamponi/orgs","repos_url":"https://api.github.com/users/etamponi/repos","events_url":"https://api.github.com/users/etamponi/events{/privacy}","received_events_url":"https://api.github.com/users/etamponi/received_events","type":"User","site_admin":false},"created_at":"2017-12-30T20:50:45Z","updated_at":"2017-12-30T20:50:45Z","author_association":"CONTRIBUTOR","body":"Fun: the copy test is failing. Has the copy path been tested before? This is the error:\r\n\r\n```\r\n$ node_modules/.bin/ts-node test/packageImportMethods.ts                                                                                                                   ⬡ 6.12.2 [±master-upstream ●●]\r\nTAP version 13\r\n# packageImportMethod can be set to copy\r\nok 1 create testing package 1\r\nnot ok 2 Error: ENOENT: no such file or directory, mkdir '/Users/etamponi/code/.tmp/1/project/node_modules/.localhost+4873/is-negative/2.1.0/node_modules/is-negative'\r\n  ---\r\n    operator: error\r\n    expected: |-\r\n      undefined\r\n    actual: |-\r\n      [ { [Error: ENOENT: no such file or directory, mkdir '/Users/etamponi/code/.tmp/1/project/node_modules/.localhost+4873/is-negative/2.1.0/node_modules/is-negative'] errno: -2, code: 'ENOENT', syscall: 'mkdir', path: '/Users/etamponi/code/.tmp/1/project/node_modules/.localhost+4873/is-negative/2.1.0/node_modules/is-negative' } ]\r\n    at: bound (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/onetime/2.0.1/node_modules/onetime/index.js:30:12)\r\n    stack: |-\r\n      Error: Error: ENOENT: no such file or directory, mkdir '/Users/etamponi/code/.tmp/1/project/node_modules/.localhost+4873/is-negative/2.1.0/node_modules/is-negative'\r\n          at Test.assert [as _assert] (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/tape/4.8.0/node_modules/tape/lib/test.js:212:54)\r\n          at Test.bound [as _assert] (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/tape/4.8.0/node_modules/tape/lib/test.js:64:32)\r\n          at Test.error.Test.ifError.Test.ifErr.Test.iferror (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/tape/4.8.0/node_modules/tape/lib/test.js:332:10)\r\n          at Test.bound [as ifError] (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/tape/4.8.0/node_modules/tape/lib/test.js:64:32)\r\n          at Test.end (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/tape/4.8.0/node_modules/tape/lib/test.js:137:14)\r\n          at bound (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/tape/4.8.0/node_modules/tape/lib/test.js:64:32)\r\n          at bound (/Users/etamponi/code/supi/node_modules/.registry.npmjs.org/onetime/2.0.1/node_modules/onetime/index.js:30:12)\r\n  ...\r\n```"}}
{"actor":{"display_login":"etamponi"}}