{"action":"created","issue":{"url":"https://api.github.com/repos/yarnpkg/yarn/issues/2170","repository_url":"https://api.github.com/repos/yarnpkg/yarn","labels_url":"https://api.github.com/repos/yarnpkg/yarn/issues/2170/labels{/name}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/2170/comments","events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/2170/events","html_url":"https://github.com/yarnpkg/yarn/pull/2170","id":193886659,"number":2170,"title":"Do not try to resolve optionalDependencies defined with file:<path> when --ignore-optional is set","user":{"login":"cnadeau","id":453012,"avatar_url":"https://avatars3.githubusercontent.com/u/453012?v=3","gravatar_id":"","url":"https://api.github.com/users/cnadeau","html_url":"https://github.com/cnadeau","followers_url":"https://api.github.com/users/cnadeau/followers","following_url":"https://api.github.com/users/cnadeau/following{/other_user}","gists_url":"https://api.github.com/users/cnadeau/gists{/gist_id}","starred_url":"https://api.github.com/users/cnadeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnadeau/subscriptions","organizations_url":"https://api.github.com/users/cnadeau/orgs","repos_url":"https://api.github.com/users/cnadeau/repos","events_url":"https://api.github.com/users/cnadeau/events{/privacy}","received_events_url":"https://api.github.com/users/cnadeau/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-06T21:14:44Z","updated_at":"2017-04-06T15:14:17Z","closed_at":"2017-04-06T15:14:17Z","pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/2170","html_url":"https://github.com/yarnpkg/yarn/pull/2170","diff_url":"https://github.com/yarnpkg/yarn/pull/2170.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/2170.patch"},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->\r\n\r\n**Summary**\r\nfor an optional dependency using <file:PATH>, yarn --ignore-optional is failing returning the path does not exists. It should not:\r\n\r\nhttps://github.com/yarnpkg/yarn/issues/2149\r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n\r\n**Test plan**\r\n\r\n- Ensure yarn --ignore-optional is not failing when an optionalDependency defined as __file:<path>__ path is not found\r\n- Ensure yarn --ignore-optional is not installing optionalDependency defined as __file:<path>__ path even if it's resolved found\r\n- Ensure yarn is failing when an dependency defined as __file:<path>__ path is not found\r\n- Ensure yarn is installing a dependency defined as __file:<path>__ path when it's found\r\n\r\n<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments/292206237","html_url":"https://github.com/yarnpkg/yarn/pull/2170#issuecomment-292206237","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/2170","id":292206237,"user":{"login":"bestander","id":2121048,"avatar_url":"https://avatars0.githubusercontent.com/u/2121048?v=3","gravatar_id":"","url":"https://api.github.com/users/bestander","html_url":"https://github.com/bestander","followers_url":"https://api.github.com/users/bestander/followers","following_url":"https://api.github.com/users/bestander/following{/other_user}","gists_url":"https://api.github.com/users/bestander/gists{/gist_id}","starred_url":"https://api.github.com/users/bestander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestander/subscriptions","organizations_url":"https://api.github.com/users/bestander/orgs","repos_url":"https://api.github.com/users/bestander/repos","events_url":"https://api.github.com/users/bestander/events{/privacy}","received_events_url":"https://api.github.com/users/bestander/received_events","type":"User","site_admin":false},"created_at":"2017-04-06T15:14:16Z","updated_at":"2017-04-06T15:14:16Z","body":"Seems like the PR got overlooked and abandoned.\r\nFeel free to rebase and reopen."}}
{"actor":{"display_login":"bestander"}}