{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/131315193","pull_request_review_id":54283510,"id":131315193,"diff_hunk":"@@ -91,6 +93,22 @@ unix (receive, send) type=seqpacket addr=none peer=(label=###SLOT_SECURITY_TAGS#\n deny /{dev,run,var/run}/shm/lttng-ust-* rw,\n `\n \n+const mirPermanentSlotUdev = `\n+# This file contains udev rules for mir server.\n+#\n+# Do not edit this file, it will be overwritten on updates\n+\n+KERNEL==\"tty\",       TAG+=\"%[1]s\"\n+KERNEL==\"tty[0-9]*\", TAG+=\"%[1]s\"\n+\n+# input devices\n+KERNEL==\"mice\",   NAME=\"input/%%k\", TAG+=\"%[1]s\"\n+KERNEL==\"mouse*\", NAME=\"input/%%k\", TAG+=\"%[1]s\"\n+KERNEL==\"event*\", NAME=\"input/%%k\", TAG+=\"%[1]s\"\n+KERNEL==\"js*\",    NAME=\"input/%%k\", TAG+=\"%[1]s\"\n+KERNEL==\"ts*\",    NAME=\"input/%%k\", TAG+=\"%[1]s\"","path":"interfaces/builtin/mir.go","position":31,"original_position":31,"commit_id":"083f39bfb78a9e3c4148451ea01d5f796b980bfb","original_commit_id":"083f39bfb78a9e3c4148451ea01d5f796b980bfb","user":{"login":"adglkh","id":4225923,"avatar_url":"https://avatars2.githubusercontent.com/u/4225923?v=4","gravatar_id":"","url":"https://api.github.com/users/adglkh","html_url":"https://github.com/adglkh","followers_url":"https://api.github.com/users/adglkh/followers","following_url":"https://api.github.com/users/adglkh/following{/other_user}","gists_url":"https://api.github.com/users/adglkh/gists{/gist_id}","starred_url":"https://api.github.com/users/adglkh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adglkh/subscriptions","organizations_url":"https://api.github.com/users/adglkh/orgs","repos_url":"https://api.github.com/users/adglkh/repos","events_url":"https://api.github.com/users/adglkh/events{/privacy}","received_events_url":"https://api.github.com/users/adglkh/received_events","type":"User","site_admin":false},"body":"RE: /dev/input/ts*\r\n1.https://kernel.googlesource.com/pub/scm/linux/hotplug/udev/+/127/rules/rules.d/50-udev-default.rules#27\r\n2.https://github.com/kergoth/tslib\r\nIt's a udev rule for the touchscreen device.","created_at":"2017-08-04T05:40:36Z","updated_at":"2017-08-04T05:40:36Z","html_url":"https://github.com/snapcore/snapd/pull/3617#discussion_r131315193","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/3617","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/131315193"},"html":{"href":"https://github.com/snapcore/snapd/pull/3617#discussion_r131315193"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3617"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/3617","id":132199659,"html_url":"https://github.com/snapcore/snapd/pull/3617","diff_url":"https://github.com/snapcore/snapd/pull/3617.diff","patch_url":"https://github.com/snapcore/snapd/pull/3617.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/3617","number":3617,"state":"open","locked":false,"title":"Using udev tagging for snap interfaces","user":{"login":"adglkh","id":4225923,"avatar_url":"https://avatars2.githubusercontent.com/u/4225923?v=4","gravatar_id":"","url":"https://api.github.com/users/adglkh","html_url":"https://github.com/adglkh","followers_url":"https://api.github.com/users/adglkh/followers","following_url":"https://api.github.com/users/adglkh/following{/other_user}","gists_url":"https://api.github.com/users/adglkh/gists{/gist_id}","starred_url":"https://api.github.com/users/adglkh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adglkh/subscriptions","organizations_url":"https://api.github.com/users/adglkh/orgs","repos_url":"https://api.github.com/users/adglkh/repos","events_url":"https://api.github.com/users/adglkh/events{/privacy}","received_events_url":"https://api.github.com/users/adglkh/received_events","type":"User","site_admin":false},"body":"It's a long-standing bug in snapd.\r\nhttps://bugs.launchpad.net/snapd/+bug/1675738\r\n\r\nWe have some interfaces using udev tagging, but quite a few interfaces are still without udev tagging. So when people create a snap which has a combination of udev tagging plugs and none udev tagging plugs, an issue occurs due to device access denied since snap-confine only loads udev rules and creates a device cgroup for the tagged devices, excluding untagged ones.","created_at":"2017-07-25T05:35:58Z","updated_at":"2017-08-04T05:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca61be4afcaf4d64305ff8ce543119e34eed0738","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/3617/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/3617/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/3617/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/083f39bfb78a9e3c4148451ea01d5f796b980bfb","head":{"label":"adglkh:udev_tagging","ref":"udev_tagging","sha":"083f39bfb78a9e3c4148451ea01d5f796b980bfb","user":{"login":"adglkh","id":4225923,"avatar_url":"https://avatars2.githubusercontent.com/u/4225923?v=4","gravatar_id":"","url":"https://api.github.com/users/adglkh","html_url":"https://github.com/adglkh","followers_url":"https://api.github.com/users/adglkh/followers","following_url":"https://api.github.com/users/adglkh/following{/other_user}","gists_url":"https://api.github.com/users/adglkh/gists{/gist_id}","starred_url":"https://api.github.com/users/adglkh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adglkh/subscriptions","organizations_url":"https://api.github.com/users/adglkh/orgs","repos_url":"https://api.github.com/users/adglkh/repos","events_url":"https://api.github.com/users/adglkh/events{/privacy}","received_events_url":"https://api.github.com/users/adglkh/received_events","type":"User","site_admin":false},"repo":{"id":90101575,"name":"snapd","full_name":"adglkh/snapd","owner":{"login":"adglkh","id":4225923,"avatar_url":"https://avatars2.githubusercontent.com/u/4225923?v=4","gravatar_id":"","url":"https://api.github.com/users/adglkh","html_url":"https://github.com/adglkh","followers_url":"https://api.github.com/users/adglkh/followers","following_url":"https://api.github.com/users/adglkh/following{/other_user}","gists_url":"https://api.github.com/users/adglkh/gists{/gist_id}","starred_url":"https://api.github.com/users/adglkh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adglkh/subscriptions","organizations_url":"https://api.github.com/users/adglkh/orgs","repos_url":"https://api.github.com/users/adglkh/repos","events_url":"https://api.github.com/users/adglkh/events{/privacy}","received_events_url":"https://api.github.com/users/adglkh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adglkh/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/adglkh/snapd","forks_url":"https://api.github.com/repos/adglkh/snapd/forks","keys_url":"https://api.github.com/repos/adglkh/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adglkh/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adglkh/snapd/teams","hooks_url":"https://api.github.com/repos/adglkh/snapd/hooks","issue_events_url":"https://api.github.com/repos/adglkh/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/adglkh/snapd/events","assignees_url":"https://api.github.com/repos/adglkh/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/adglkh/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/adglkh/snapd/tags","blobs_url":"https://api.github.com/repos/adglkh/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adglkh/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adglkh/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/adglkh/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adglkh/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/adglkh/snapd/languages","stargazers_url":"https://api.github.com/repos/adglkh/snapd/stargazers","contributors_url":"https://api.github.com/repos/adglkh/snapd/contributors","subscribers_url":"https://api.github.com/repos/adglkh/snapd/subscribers","subscription_url":"https://api.github.com/repos/adglkh/snapd/subscription","commits_url":"https://api.github.com/repos/adglkh/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/adglkh/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/adglkh/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/adglkh/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/adglkh/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/adglkh/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adglkh/snapd/merges","archive_url":"https://api.github.com/repos/adglkh/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adglkh/snapd/downloads","issues_url":"https://api.github.com/repos/adglkh/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/adglkh/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/adglkh/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/adglkh/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adglkh/snapd/labels{/name}","releases_url":"https://api.github.com/repos/adglkh/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/adglkh/snapd/deployments","created_at":"2017-05-03T02:55:42Z","updated_at":"2017-05-03T02:55:47Z","pushed_at":"2017-08-02T04:25:45Z","git_url":"git://github.com/adglkh/snapd.git","ssh_url":"git@github.com:adglkh/snapd.git","clone_url":"https://github.com/adglkh/snapd.git","svn_url":"https://github.com/adglkh/snapd","homepage":"","size":50495,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"4b73774a02be51a3f09e3d5f6bdb90da064f7d00","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2017-08-02T16:20:14Z","pushed_at":"2017-08-04T01:51:38Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":50498,"stargazers_count":760,"watchers_count":760,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":193,"mirror_url":null,"open_issues_count":46,"forks":193,"open_issues":46,"watchers":760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3617"},"html":{"href":"https://github.com/snapcore/snapd/pull/3617"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/3617"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/3617/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3617/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3617/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/083f39bfb78a9e3c4148451ea01d5f796b980bfb"}}}}
{"actor":{"display_login":"adglkh"}}