{"action":"created","comment":{"url":"https://api.github.com/repos/lagom/lagom/pulls/comments/122212737","pull_request_review_id":44308997,"id":122212737,"diff_hunk":"@@ -26,9 +22,7 @@\n  * {@code RegisteredService.of()}.\n  */\n @SuppressWarnings(\"all\")\n-@ParametersAreNonnullByDefault\n @Generated({\"Immutables.generator\", \"AbstractRegisteredService\"})","path":"dev/service-registry/client-javadsl/src/main/java/com/lightbend/lagom/internal/javadsl/registry/RegisteredService.java","position":16,"original_position":16,"commit_id":"4ba3b683fd3f9faa1195ce8d48e78709abd9cee1","original_commit_id":"4ba3b683fd3f9faa1195ce8d48e78709abd9cee1","user":{"login":"rcavalcanti","id":502982,"avatar_url":"https://avatars3.githubusercontent.com/u/502982?v=3","gravatar_id":"","url":"https://api.github.com/users/rcavalcanti","html_url":"https://github.com/rcavalcanti","followers_url":"https://api.github.com/users/rcavalcanti/followers","following_url":"https://api.github.com/users/rcavalcanti/following{/other_user}","gists_url":"https://api.github.com/users/rcavalcanti/gists{/gist_id}","starred_url":"https://api.github.com/users/rcavalcanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcavalcanti/subscriptions","organizations_url":"https://api.github.com/users/rcavalcanti/orgs","repos_url":"https://api.github.com/users/rcavalcanti/repos","events_url":"https://api.github.com/users/rcavalcanti/events{/privacy}","received_events_url":"https://api.github.com/users/rcavalcanti/received_events","type":"User","site_admin":false},"body":"See discussion in PR #688 \r\nhttps://github.com/lagom/lagom/pull/688/files/86244a9188dad011402ec4eb63a2f34167e80322#r112859236","created_at":"2017-06-15T14:12:53Z","updated_at":"2017-06-15T14:12:53Z","html_url":"https://github.com/lagom/lagom/pull/808#discussion_r122212737","pull_request_url":"https://api.github.com/repos/lagom/lagom/pulls/808","_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments/122212737"},"html":{"href":"https://github.com/lagom/lagom/pull/808#discussion_r122212737"},"pull_request":{"href":"https://api.github.com/repos/lagom/lagom/pulls/808"}}},"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/808","id":125827827,"html_url":"https://github.com/lagom/lagom/pull/808","diff_url":"https://github.com/lagom/lagom/pull/808.diff","patch_url":"https://github.com/lagom/lagom/pull/808.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/808","number":808,"state":"open","locked":false,"title":"[WIP] Upgraded to Play 2.6 and Akka 2.5","user":{"login":"rcavalcanti","id":502982,"avatar_url":"https://avatars3.githubusercontent.com/u/502982?v=3","gravatar_id":"","url":"https://api.github.com/users/rcavalcanti","html_url":"https://github.com/rcavalcanti","followers_url":"https://api.github.com/users/rcavalcanti/followers","following_url":"https://api.github.com/users/rcavalcanti/following{/other_user}","gists_url":"https://api.github.com/users/rcavalcanti/gists{/gist_id}","starred_url":"https://api.github.com/users/rcavalcanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcavalcanti/subscriptions","organizations_url":"https://api.github.com/users/rcavalcanti/orgs","repos_url":"https://api.github.com/users/rcavalcanti/repos","events_url":"https://api.github.com/users/rcavalcanti/events{/privacy}","received_events_url":"https://api.github.com/users/rcavalcanti/received_events","type":"User","site_admin":false},"body":"This PR is based on a PR sent by @jroper (#688).\r\n\r\nUnfortunately we can't copy all the comments and discussion to this PR. So it's important to keep them linked.","created_at":"2017-06-15T13:57:43Z","updated_at":"2017-06-15T14:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbd1fd36bff895bfb030728e789ca7c0717d336a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/808/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/808/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/808/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/4ba3b683fd3f9faa1195ce8d48e78709abd9cee1","head":{"label":"lagom:play-2.6-akka-2.5","ref":"play-2.6-akka-2.5","sha":"4ba3b683fd3f9faa1195ce8d48e78709abd9cee1","user":{"login":"lagom","id":17168851,"avatar_url":"https://avatars2.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"avatar_url":"https://avatars2.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2017-06-15T13:12:47Z","pushed_at":"2017-06-15T13:57:43Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":6040,"stargazers_count":1360,"watchers_count":1360,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":159,"forks":265,"open_issues":159,"watchers":1360,"default_branch":"master"}},"base":{"label":"lagom:master","ref":"master","sha":"1494523e9045f336215f08116e3e7495d5e10be1","user":{"login":"lagom","id":17168851,"avatar_url":"https://avatars2.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"avatar_url":"https://avatars2.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2017-06-15T13:12:47Z","pushed_at":"2017-06-15T13:57:43Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":6040,"stargazers_count":1360,"watchers_count":1360,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":159,"forks":265,"open_issues":159,"watchers":1360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/808"},"html":{"href":"https://github.com/lagom/lagom/pull/808"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/808"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/808/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/808/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/808/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/4ba3b683fd3f9faa1195ce8d48e78709abd9cee1"}}}}
{"actor":{"display_login":"rcavalcanti"}}