{"action":"created","comment":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/comments/115010420","pull_request_review_id":36151500,"id":115010420,"diff_hunk":"@@ -205,9 +205,13 @@ def _read_config_grids_v2(self, name, compset, atmnlev, lndnlev):\n             if model_grid[component_gridname] is not None:\n                 lname += model_grid[component_gridname]\n                 if component_gridname == 'atm' and atmnlev is not None:\n-                    lname += \"z\" + atmnlev\n+                    if re.search(r\"a%null\", lname) is None:\n+                        lname += \"z\" + atmnlev\n+\n                 elif component_gridname == 'lnd' and lndnlev is not None:\n-                    lname += \"z\" + lndnlev\n+                    if re.search(r\"l%null\", lname) is None:","path":"scripts/lib/CIME/XML/grids.py","position":null,"original_position":19,"commit_id":"fa86c6ed2e4499be6e08e262ea8f587ba1628763","original_commit_id":"fa86c6ed2e4499be6e08e262ea8f587ba1628763","user":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars0.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"body":"same here, don't use regex if you don't need to ","created_at":"2017-05-05T14:33:10Z","updated_at":"2017-05-05T14:34:38Z","html_url":"https://github.com/ESMCI/cime/pull/1469#discussion_r115010420","pull_request_url":"https://api.github.com/repos/ESMCI/cime/pulls/1469","_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments/115010420"},"html":{"href":"https://github.com/ESMCI/cime/pull/1469#discussion_r115010420"},"pull_request":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/1469"}}},"pull_request":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/1469","id":118799320,"html_url":"https://github.com/ESMCI/cime/pull/1469","diff_url":"https://github.com/ESMCI/cime/pull/1469.diff","patch_url":"https://github.com/ESMCI/cime/pull/1469.patch","issue_url":"https://api.github.com/repos/ESMCI/cime/issues/1469","number":1469,"state":"open","locked":false,"title":"Fixes for zlev problem in #1459","user":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars0.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"body":"The level specifier for atm and lnd grids was being ignored.\r\nTest suite: scripts_regression_tests.py, SMS.ne30z60_ne30.F1850\r\nTest baseline: \r\nTest namelist changes: \r\nTest status: bit for bit\r\nFixes #1459\r\n\r\nUser interface changes?: \r\n\r\nCode review: \r\n","created_at":"2017-05-03T16:13:16Z","updated_at":"2017-05-05T14:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2414db657ea9b75e53bbc186929c17923e85ffee","assignee":{"login":"gold2718","id":1588651,"avatar_url":"https://avatars0.githubusercontent.com/u/1588651?v=3","gravatar_id":"","url":"https://api.github.com/users/gold2718","html_url":"https://github.com/gold2718","followers_url":"https://api.github.com/users/gold2718/followers","following_url":"https://api.github.com/users/gold2718/following{/other_user}","gists_url":"https://api.github.com/users/gold2718/gists{/gist_id}","starred_url":"https://api.github.com/users/gold2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gold2718/subscriptions","organizations_url":"https://api.github.com/users/gold2718/orgs","repos_url":"https://api.github.com/users/gold2718/repos","events_url":"https://api.github.com/users/gold2718/events{/privacy}","received_events_url":"https://api.github.com/users/gold2718/received_events","type":"User","site_admin":false},"assignees":[{"login":"gold2718","id":1588651,"avatar_url":"https://avatars0.githubusercontent.com/u/1588651?v=3","gravatar_id":"","url":"https://api.github.com/users/gold2718","html_url":"https://github.com/gold2718","followers_url":"https://api.github.com/users/gold2718/followers","following_url":"https://api.github.com/users/gold2718/following{/other_user}","gists_url":"https://api.github.com/users/gold2718/gists{/gist_id}","starred_url":"https://api.github.com/users/gold2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gold2718/subscriptions","organizations_url":"https://api.github.com/users/gold2718/orgs","repos_url":"https://api.github.com/users/gold2718/repos","events_url":"https://api.github.com/users/gold2718/events{/privacy}","received_events_url":"https://api.github.com/users/gold2718/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ESMCI/cime/pulls/1469/commits","review_comments_url":"https://api.github.com/repos/ESMCI/cime/pulls/1469/comments","review_comment_url":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ESMCI/cime/issues/1469/comments","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/fa86c6ed2e4499be6e08e262ea8f587ba1628763","head":{"label":"ESMCI:mvertens/fixzlev","ref":"mvertens/fixzlev","sha":"fa86c6ed2e4499be6e08e262ea8f587ba1628763","user":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars3.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"repo":{"id":31605662,"name":"cime","full_name":"ESMCI/cime","owner":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars3.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESMCI/cime","description":"Common Infrastructure for Modeling the Earth","fork":false,"url":"https://api.github.com/repos/ESMCI/cime","forks_url":"https://api.github.com/repos/ESMCI/cime/forks","keys_url":"https://api.github.com/repos/ESMCI/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESMCI/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESMCI/cime/teams","hooks_url":"https://api.github.com/repos/ESMCI/cime/hooks","issue_events_url":"https://api.github.com/repos/ESMCI/cime/issues/events{/number}","events_url":"https://api.github.com/repos/ESMCI/cime/events","assignees_url":"https://api.github.com/repos/ESMCI/cime/assignees{/user}","branches_url":"https://api.github.com/repos/ESMCI/cime/branches{/branch}","tags_url":"https://api.github.com/repos/ESMCI/cime/tags","blobs_url":"https://api.github.com/repos/ESMCI/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESMCI/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESMCI/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESMCI/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/ESMCI/cime/languages","stargazers_url":"https://api.github.com/repos/ESMCI/cime/stargazers","contributors_url":"https://api.github.com/repos/ESMCI/cime/contributors","subscribers_url":"https://api.github.com/repos/ESMCI/cime/subscribers","subscription_url":"https://api.github.com/repos/ESMCI/cime/subscription","commits_url":"https://api.github.com/repos/ESMCI/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESMCI/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESMCI/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESMCI/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESMCI/cime/contents/{+path}","compare_url":"https://api.github.com/repos/ESMCI/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESMCI/cime/merges","archive_url":"https://api.github.com/repos/ESMCI/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESMCI/cime/downloads","issues_url":"https://api.github.com/repos/ESMCI/cime/issues{/number}","pulls_url":"https://api.github.com/repos/ESMCI/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/ESMCI/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/ESMCI/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESMCI/cime/labels{/name}","releases_url":"https://api.github.com/repos/ESMCI/cime/releases{/id}","deployments_url":"https://api.github.com/repos/ESMCI/cime/deployments","created_at":"2015-03-03T15:33:00Z","updated_at":"2017-04-11T04:47:41Z","pushed_at":"2017-05-05T04:50:39Z","git_url":"git://github.com/ESMCI/cime.git","ssh_url":"git@github.com:ESMCI/cime.git","clone_url":"https://github.com/ESMCI/cime.git","svn_url":"https://github.com/ESMCI/cime","homepage":"","size":28926,"stargazers_count":10,"watchers_count":10,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":168,"forks":36,"open_issues":168,"watchers":10,"default_branch":"master"}},"base":{"label":"ESMCI:master","ref":"master","sha":"7043e293535ca2ad9c30ab4612875817cbc2c410","user":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars3.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"repo":{"id":31605662,"name":"cime","full_name":"ESMCI/cime","owner":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars3.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESMCI/cime","description":"Common Infrastructure for Modeling the Earth","fork":false,"url":"https://api.github.com/repos/ESMCI/cime","forks_url":"https://api.github.com/repos/ESMCI/cime/forks","keys_url":"https://api.github.com/repos/ESMCI/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESMCI/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESMCI/cime/teams","hooks_url":"https://api.github.com/repos/ESMCI/cime/hooks","issue_events_url":"https://api.github.com/repos/ESMCI/cime/issues/events{/number}","events_url":"https://api.github.com/repos/ESMCI/cime/events","assignees_url":"https://api.github.com/repos/ESMCI/cime/assignees{/user}","branches_url":"https://api.github.com/repos/ESMCI/cime/branches{/branch}","tags_url":"https://api.github.com/repos/ESMCI/cime/tags","blobs_url":"https://api.github.com/repos/ESMCI/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESMCI/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESMCI/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESMCI/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/ESMCI/cime/languages","stargazers_url":"https://api.github.com/repos/ESMCI/cime/stargazers","contributors_url":"https://api.github.com/repos/ESMCI/cime/contributors","subscribers_url":"https://api.github.com/repos/ESMCI/cime/subscribers","subscription_url":"https://api.github.com/repos/ESMCI/cime/subscription","commits_url":"https://api.github.com/repos/ESMCI/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESMCI/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESMCI/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESMCI/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESMCI/cime/contents/{+path}","compare_url":"https://api.github.com/repos/ESMCI/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESMCI/cime/merges","archive_url":"https://api.github.com/repos/ESMCI/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESMCI/cime/downloads","issues_url":"https://api.github.com/repos/ESMCI/cime/issues{/number}","pulls_url":"https://api.github.com/repos/ESMCI/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/ESMCI/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/ESMCI/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESMCI/cime/labels{/name}","releases_url":"https://api.github.com/repos/ESMCI/cime/releases{/id}","deployments_url":"https://api.github.com/repos/ESMCI/cime/deployments","created_at":"2015-03-03T15:33:00Z","updated_at":"2017-04-11T04:47:41Z","pushed_at":"2017-05-05T04:50:39Z","git_url":"git://github.com/ESMCI/cime.git","ssh_url":"git@github.com:ESMCI/cime.git","clone_url":"https://github.com/ESMCI/cime.git","svn_url":"https://github.com/ESMCI/cime","homepage":"","size":28926,"stargazers_count":10,"watchers_count":10,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":168,"forks":36,"open_issues":168,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/1469"},"html":{"href":"https://github.com/ESMCI/cime/pull/1469"},"issue":{"href":"https://api.github.com/repos/ESMCI/cime/issues/1469"},"comments":{"href":"https://api.github.com/repos/ESMCI/cime/issues/1469/comments"},"review_comments":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/1469/comments"},"review_comment":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/1469/commits"},"statuses":{"href":"https://api.github.com/repos/ESMCI/cime/statuses/fa86c6ed2e4499be6e08e262ea8f587ba1628763"}}}}
{"actor":{"display_login":"jedwards4b"}}