{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments/151635118","pull_request_review_id":77374876,"id":151635118,"diff_hunk":"@@ -91,6 +91,17 @@\n     @Element(description = \"SDK Generation Language Configurations\")\n     private SdkLanguageConfigurations sdkLanguageConfigurations = new SdkLanguageConfigurations();\n \n+    @Element(description = \"SDK Generation Language Configurations\")","path":"components/apimgt/org.wso2.carbon.apimgt.core/src/main/java/org/wso2/carbon/apimgt/core/configuration/models/APIMConfigurations.java","position":13,"original_position":13,"commit_id":"02a385db223c077661cc2dbc65cd35bb03187b12","original_commit_id":"02a385db223c077661cc2dbc65cd35bb03187b12","user":{"login":"vlgunarathne","id":16064696,"avatar_url":"https://avatars2.githubusercontent.com/u/16064696?v=4","gravatar_id":"","url":"https://api.github.com/users/vlgunarathne","html_url":"https://github.com/vlgunarathne","followers_url":"https://api.github.com/users/vlgunarathne/followers","following_url":"https://api.github.com/users/vlgunarathne/following{/other_user}","gists_url":"https://api.github.com/users/vlgunarathne/gists{/gist_id}","starred_url":"https://api.github.com/users/vlgunarathne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlgunarathne/subscriptions","organizations_url":"https://api.github.com/users/vlgunarathne/orgs","repos_url":"https://api.github.com/users/vlgunarathne/repos","events_url":"https://api.github.com/users/vlgunarathne/events{/privacy}","received_events_url":"https://api.github.com/users/vlgunarathne/received_events","type":"User","site_admin":false},"body":"The description here is a mistake. Shall we change it?","created_at":"2017-11-17T09:17:17Z","updated_at":"2017-11-17T09:17:17Z","html_url":"https://github.com/wso2/carbon-apimgt/pull/4725#discussion_r151635118","pull_request_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments/151635118"},"html":{"href":"https://github.com/wso2/carbon-apimgt/pull/4725#discussion_r151635118"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725","id":153246331,"html_url":"https://github.com/wso2/carbon-apimgt/pull/4725","diff_url":"https://github.com/wso2/carbon-apimgt/pull/4725.diff","patch_url":"https://github.com/wso2/carbon-apimgt/pull/4725.patch","issue_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/4725","number":4725,"state":"open","locked":false,"title":"Service Discovery at APIM Publisher feature","user":{"login":"SuKSW","id":17605554,"avatar_url":"https://avatars3.githubusercontent.com/u/17605554?v=4","gravatar_id":"","url":"https://api.github.com/users/SuKSW","html_url":"https://github.com/SuKSW","followers_url":"https://api.github.com/users/SuKSW/followers","following_url":"https://api.github.com/users/SuKSW/following{/other_user}","gists_url":"https://api.github.com/users/SuKSW/gists{/gist_id}","starred_url":"https://api.github.com/users/SuKSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuKSW/subscriptions","organizations_url":"https://api.github.com/users/SuKSW/orgs","repos_url":"https://api.github.com/users/SuKSW/repos","events_url":"https://api.github.com/users/SuKSW/events{/privacy}","received_events_url":"https://api.github.com/users/SuKSW/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\nThis feature enables the user to discover service endpoints from one or more systems and directly add them as global endpoints without having to enter them manually. Currently this supports both Kubernetes and Openshift as the system which the services exist.\r\n\r\n[Link to the implementation details document](https://docs.google.com/a/wso2.com/document/d/1AYyh0GLMkqIp_ioXoUZoCJmLt_NjyUy5yymmEiPG4Qo/edit?usp=sharing)\r\n[Link to the documentation](https://docs.google.com/a/wso2.com/document/d/183q1nV0WBBHvKms5d_--4PIEVdvXvAfdffo52IsJqbU/edit?usp=sharing)\r\n\r\n### When should this PR be merged\r\n\r\n### Follow up actions\r\n\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [ ] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [ ] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n","created_at":"2017-11-17T09:06:48Z","updated_at":"2017-11-17T09:17:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5fe6500e39fb860ac06c3f801f031fb134dc5e7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/4725/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-apimgt/statuses/02a385db223c077661cc2dbc65cd35bb03187b12","head":{"label":"SuKSW:master","ref":"master","sha":"02a385db223c077661cc2dbc65cd35bb03187b12","user":{"login":"SuKSW","id":17605554,"avatar_url":"https://avatars3.githubusercontent.com/u/17605554?v=4","gravatar_id":"","url":"https://api.github.com/users/SuKSW","html_url":"https://github.com/SuKSW","followers_url":"https://api.github.com/users/SuKSW/followers","following_url":"https://api.github.com/users/SuKSW/following{/other_user}","gists_url":"https://api.github.com/users/SuKSW/gists{/gist_id}","starred_url":"https://api.github.com/users/SuKSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuKSW/subscriptions","organizations_url":"https://api.github.com/users/SuKSW/orgs","repos_url":"https://api.github.com/users/SuKSW/repos","events_url":"https://api.github.com/users/SuKSW/events{/privacy}","received_events_url":"https://api.github.com/users/SuKSW/received_events","type":"User","site_admin":false},"repo":{"id":111066807,"name":"carbon-apimgt","full_name":"SuKSW/carbon-apimgt","owner":{"login":"SuKSW","id":17605554,"avatar_url":"https://avatars3.githubusercontent.com/u/17605554?v=4","gravatar_id":"","url":"https://api.github.com/users/SuKSW","html_url":"https://github.com/SuKSW","followers_url":"https://api.github.com/users/SuKSW/followers","following_url":"https://api.github.com/users/SuKSW/following{/other_user}","gists_url":"https://api.github.com/users/SuKSW/gists{/gist_id}","starred_url":"https://api.github.com/users/SuKSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuKSW/subscriptions","organizations_url":"https://api.github.com/users/SuKSW/orgs","repos_url":"https://api.github.com/users/SuKSW/repos","events_url":"https://api.github.com/users/SuKSW/events{/privacy}","received_events_url":"https://api.github.com/users/SuKSW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SuKSW/carbon-apimgt","description":null,"fork":true,"url":"https://api.github.com/repos/SuKSW/carbon-apimgt","forks_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/forks","keys_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/teams","hooks_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/hooks","issue_events_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/issues/events{/number}","events_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/events","assignees_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/assignees{/user}","branches_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/branches{/branch}","tags_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/tags","blobs_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/statuses/{sha}","languages_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/languages","stargazers_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/stargazers","contributors_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/contributors","subscribers_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/subscribers","subscription_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/subscription","commits_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/contents/{+path}","compare_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/merges","archive_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/downloads","issues_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/issues{/number}","pulls_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/pulls{/number}","milestones_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/milestones{/number}","notifications_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/labels{/name}","releases_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/releases{/id}","deployments_url":"https://api.github.com/repos/SuKSW/carbon-apimgt/deployments","created_at":"2017-11-17T06:29:58Z","updated_at":"2017-11-17T06:30:06Z","pushed_at":"2017-11-17T08:55:22Z","git_url":"git://github.com/SuKSW/carbon-apimgt.git","ssh_url":"git@github.com:SuKSW/carbon-apimgt.git","clone_url":"https://github.com/SuKSW/carbon-apimgt.git","svn_url":"https://github.com/SuKSW/carbon-apimgt","homepage":null,"size":208388,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"34b6244402fae75d27409595c284e3e735559c62","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":17201744,"name":"carbon-apimgt","full_name":"wso2/carbon-apimgt","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-apimgt","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-apimgt","forks_url":"https://api.github.com/repos/wso2/carbon-apimgt/forks","keys_url":"https://api.github.com/repos/wso2/carbon-apimgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-apimgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-apimgt/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-apimgt/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-apimgt/events","assignees_url":"https://api.github.com/repos/wso2/carbon-apimgt/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-apimgt/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-apimgt/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-apimgt/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-apimgt/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-apimgt/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-apimgt/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-apimgt/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-apimgt/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-apimgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-apimgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-apimgt/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-apimgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-apimgt/merges","archive_url":"https://api.github.com/repos/wso2/carbon-apimgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-apimgt/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-apimgt/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-apimgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-apimgt/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-apimgt/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-apimgt/deployments","created_at":"2014-02-26T06:46:48Z","updated_at":"2017-11-08T06:30:12Z","pushed_at":"2017-11-17T09:06:49Z","git_url":"git://github.com/wso2/carbon-apimgt.git","ssh_url":"git@github.com:wso2/carbon-apimgt.git","clone_url":"https://github.com/wso2/carbon-apimgt.git","svn_url":"https://github.com/wso2/carbon-apimgt","homepage":null,"size":208496,"stargazers_count":37,"watchers_count":37,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":277,"mirror_url":null,"archived":false,"open_issues_count":64,"forks":277,"open_issues":64,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725"},"html":{"href":"https://github.com/wso2/carbon-apimgt/pull/4725"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/issues/4725"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/issues/4725/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/4725/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/statuses/02a385db223c077661cc2dbc65cd35bb03187b12"}},"author_association":"NONE"}}
{"actor":{"display_login":"vlgunarathne"}}