{"action":"created","issue":{"url":"https://api.github.com/repos/dmlc/xgboost/issues/1726","repository_url":"https://api.github.com/repos/dmlc/xgboost","labels_url":"https://api.github.com/repos/dmlc/xgboost/issues/1726/labels{/name}","comments_url":"https://api.github.com/repos/dmlc/xgboost/issues/1726/comments","events_url":"https://api.github.com/repos/dmlc/xgboost/issues/1726/events","html_url":"https://github.com/dmlc/xgboost/pull/1726","id":186505866,"number":1726,"title":"Add dump_format=json option","user":{"login":"AbdealiJK","id":2200743,"avatar_url":"https://avatars0.githubusercontent.com/u/2200743?v=3","gravatar_id":"","url":"https://api.github.com/users/AbdealiJK","html_url":"https://github.com/AbdealiJK","followers_url":"https://api.github.com/users/AbdealiJK/followers","following_url":"https://api.github.com/users/AbdealiJK/following{/other_user}","gists_url":"https://api.github.com/users/AbdealiJK/gists{/gist_id}","starred_url":"https://api.github.com/users/AbdealiJK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbdealiJK/subscriptions","organizations_url":"https://api.github.com/users/AbdealiJK/orgs","repos_url":"https://api.github.com/users/AbdealiJK/repos","events_url":"https://api.github.com/users/AbdealiJK/events{/privacy}","received_events_url":"https://api.github.com/users/AbdealiJK/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-11-01T10:48:21Z","updated_at":"2017-06-16T07:49:38Z","closed_at":"2016-11-04T16:55:26Z","pull_request":{"url":"https://api.github.com/repos/dmlc/xgboost/pulls/1726","html_url":"https://github.com/dmlc/xgboost/pull/1726","diff_url":"https://github.com/dmlc/xgboost/pull/1726.diff","patch_url":"https://github.com/dmlc/xgboost/pull/1726.patch"},"body":"This adds the option to dump as JSON.\r\nThe bindings for python, R, and java have hardcoded the format as \"text\" to retain the earlier usage.\r\n\r\nRelated issue is at https://github.com/dmlc/xgboost/issues/1722"},"comment":{"url":"https://api.github.com/repos/dmlc/xgboost/issues/comments/308958608","html_url":"https://github.com/dmlc/xgboost/pull/1726#issuecomment-308958608","issue_url":"https://api.github.com/repos/dmlc/xgboost/issues/1726","id":308958608,"user":{"login":"antoinecarme","id":16481992,"avatar_url":"https://avatars0.githubusercontent.com/u/16481992?v=3","gravatar_id":"","url":"https://api.github.com/users/antoinecarme","html_url":"https://github.com/antoinecarme","followers_url":"https://api.github.com/users/antoinecarme/followers","following_url":"https://api.github.com/users/antoinecarme/following{/other_user}","gists_url":"https://api.github.com/users/antoinecarme/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinecarme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinecarme/subscriptions","organizations_url":"https://api.github.com/users/antoinecarme/orgs","repos_url":"https://api.github.com/users/antoinecarme/repos","events_url":"https://api.github.com/users/antoinecarme/events{/privacy}","received_events_url":"https://api.github.com/users/antoinecarme/received_events","type":"User","site_admin":false},"created_at":"2017-06-16T07:49:38Z","updated_at":"2017-06-16T07:49:38Z","body":"@khotilov\r\n\r\nThis hack is what I did locally. I am developping a tool tha translates xgboost models in SQL code by working on the dump result. The hack cannot however be distrivbuted without a merge ;). I can not ask all users to change xgboost this way !!!\r\n\r\nThanks for pointing all these issues.\r\n\r\n1. Score (prediction) calculated by xgboost does not match what is expected from tree model generated by xgboost ==> #1204\r\n2. xgb.dump needs argument for number of digits ===> #1750\r\n3. Dumpmodel has insufficient precision for dumping floats ==> #2077\r\n4. Refactor passing of parameters to DumpModel ==> #2268\r\n\r\nThe most generic and useful ones to implement are IMHO, the #2268 and #1750\r\n\r\nThere is a need for a higher-level decision (@tqchen ?) to define the priorities here. \r\n"}}
{"actor":{"display_login":"antoinecarme"}}