{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/113272601","pull_request_review_id":34646784,"id":113272601,"diff_hunk":"@@ -28,58 +28,59 @@ def parse_cmd_line():\n     parser.add_argument('--library', dest=\"library\",\n                         help=\"SCVMM Library Destination\", default=None)\n     parser.add_argument('--provider', dest=\"provider\",\n-                        help=\"Specify a vCenter connection\", default=None)","path":"scripts/template_upload_scvmm.py","position":4,"original_position":4,"commit_id":"43c6dbd7e0cd89b7f827d55790b9226425a7ab11","original_commit_id":"295b9f2be9f8f1fa2a85307d36faea97990eefb1","user":{"login":"jteehan","id":13650298,"avatar_url":"https://avatars1.githubusercontent.com/u/13650298?v=3","gravatar_id":"","url":"https://api.github.com/users/jteehan","html_url":"https://github.com/jteehan","followers_url":"https://api.github.com/users/jteehan/followers","following_url":"https://api.github.com/users/jteehan/following{/other_user}","gists_url":"https://api.github.com/users/jteehan/gists{/gist_id}","starred_url":"https://api.github.com/users/jteehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jteehan/subscriptions","organizations_url":"https://api.github.com/users/jteehan/orgs","repos_url":"https://api.github.com/users/jteehan/repos","events_url":"https://api.github.com/users/jteehan/events{/privacy}","received_events_url":"https://api.github.com/users/jteehan/received_events","type":"User","site_admin":false},"body":"I already had all that queued up.","created_at":"2017-04-25T18:22:01Z","updated_at":"2017-04-25T18:22:01Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/4571#discussion_r113272601","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/113272601"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/4571#discussion_r113272601"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571","id":116816296,"html_url":"https://github.com/ManageIQ/integration_tests/pull/4571","diff_url":"https://github.com/ManageIQ/integration_tests/pull/4571.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/4571.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/4571","number":4571,"state":"open","locked":false,"title":"[WIPTEST]Refactored unreadable upload script and removed hardcoded references","user":{"login":"jteehan","id":13650298,"avatar_url":"https://avatars1.githubusercontent.com/u/13650298?v=3","gravatar_id":"","url":"https://api.github.com/users/jteehan","html_url":"https://github.com/jteehan","followers_url":"https://api.github.com/users/jteehan/followers","following_url":"https://api.github.com/users/jteehan/following{/other_user}","gists_url":"https://api.github.com/users/jteehan/gists{/gist_id}","starred_url":"https://api.github.com/users/jteehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jteehan/subscriptions","organizations_url":"https://api.github.com/users/jteehan/orgs","repos_url":"https://api.github.com/users/jteehan/repos","events_url":"https://api.github.com/users/jteehan/events{/privacy}","received_events_url":"https://api.github.com/users/jteehan/received_events","type":"User","site_admin":false},"body":"I've been hating this script for quite some time.  Finally had enough.\r\n\r\nAnyway, I cleaned up all the script calls, removed unnecessary methods, removed hard-coded values.  Performed more aggressive testing including error injection.\r\nReplaced all print statements with proper logging.\r\nAdded proper text formatting.","created_at":"2017-04-20T16:45:31Z","updated_at":"2017-04-25T18:22:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"516154b8876bdc0f96cb9fa9fd327783fc4df7a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/4571/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/43c6dbd7e0cd89b7f827d55790b9226425a7ab11","head":{"label":"jteehan:templateupload418","ref":"templateupload418","sha":"43c6dbd7e0cd89b7f827d55790b9226425a7ab11","user":{"login":"jteehan","id":13650298,"avatar_url":"https://avatars1.githubusercontent.com/u/13650298?v=3","gravatar_id":"","url":"https://api.github.com/users/jteehan","html_url":"https://github.com/jteehan","followers_url":"https://api.github.com/users/jteehan/followers","following_url":"https://api.github.com/users/jteehan/following{/other_user}","gists_url":"https://api.github.com/users/jteehan/gists{/gist_id}","starred_url":"https://api.github.com/users/jteehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jteehan/subscriptions","organizations_url":"https://api.github.com/users/jteehan/orgs","repos_url":"https://api.github.com/users/jteehan/repos","events_url":"https://api.github.com/users/jteehan/events{/privacy}","received_events_url":"https://api.github.com/users/jteehan/received_events","type":"User","site_admin":false},"repo":{"id":40617124,"name":"cfme_tests","full_name":"jteehan/cfme_tests","owner":{"login":"jteehan","id":13650298,"avatar_url":"https://avatars1.githubusercontent.com/u/13650298?v=3","gravatar_id":"","url":"https://api.github.com/users/jteehan","html_url":"https://github.com/jteehan","followers_url":"https://api.github.com/users/jteehan/followers","following_url":"https://api.github.com/users/jteehan/following{/other_user}","gists_url":"https://api.github.com/users/jteehan/gists{/gist_id}","starred_url":"https://api.github.com/users/jteehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jteehan/subscriptions","organizations_url":"https://api.github.com/users/jteehan/orgs","repos_url":"https://api.github.com/users/jteehan/repos","events_url":"https://api.github.com/users/jteehan/events{/privacy}","received_events_url":"https://api.github.com/users/jteehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jteehan/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/jteehan/cfme_tests","forks_url":"https://api.github.com/repos/jteehan/cfme_tests/forks","keys_url":"https://api.github.com/repos/jteehan/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jteehan/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jteehan/cfme_tests/teams","hooks_url":"https://api.github.com/repos/jteehan/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/jteehan/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/jteehan/cfme_tests/events","assignees_url":"https://api.github.com/repos/jteehan/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/jteehan/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/jteehan/cfme_tests/tags","blobs_url":"https://api.github.com/repos/jteehan/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jteehan/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jteehan/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/jteehan/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jteehan/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/jteehan/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/jteehan/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/jteehan/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/jteehan/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/jteehan/cfme_tests/subscription","commits_url":"https://api.github.com/repos/jteehan/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/jteehan/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/jteehan/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/jteehan/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/jteehan/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/jteehan/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jteehan/cfme_tests/merges","archive_url":"https://api.github.com/repos/jteehan/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jteehan/cfme_tests/downloads","issues_url":"https://api.github.com/repos/jteehan/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/jteehan/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/jteehan/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/jteehan/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jteehan/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/jteehan/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/jteehan/cfme_tests/deployments","created_at":"2015-08-12T18:23:35Z","updated_at":"2016-06-10T01:35:16Z","pushed_at":"2017-04-25T18:19:58Z","git_url":"git://github.com/jteehan/cfme_tests.git","ssh_url":"git@github.com:jteehan/cfme_tests.git","clone_url":"https://github.com/jteehan/cfme_tests.git","svn_url":"https://github.com/jteehan/cfme_tests","homepage":"","size":14435,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2be2fc265085d150ac84eea14743749b5fbecb8f","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2017-04-20T04:25:32Z","pushed_at":"2017-04-25T18:19:43Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":14671,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":102,"forks":81,"open_issues":102,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/4571"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/4571"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/4571/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/4571/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/43c6dbd7e0cd89b7f827d55790b9226425a7ab11"}}}}
{"actor":{"display_login":"jteehan"}}