{"action":"created","comment":{"url":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/comments/120804065","pull_request_review_id":42796279,"id":120804065,"diff_hunk":"@@ -224,5 +224,6 @@\n     end\r\n     showprogress(i/length(compounds));\r\n end\r\n-\r\n-ExchangeRxnMatrix.mets = ExchangeRxnMatrix.mets';\r\n+%Currently we are likely to have a largely blown up S matrix.\r\n+ExchangeRxnMatrix.S = ExchangeRxnMatrix.S(1:numel(ExchangeRxnMatrix.mets),1:numel(ExchangeRxnMatrix.rxns));\r","path":"src/reconstruction/fastGapFill/AuxillaryFiles/createXMatrix2.m","position":null,"original_position":7,"commit_id":"7d2b2a8a6eb8503294f996067d9edd7a756973a3","original_commit_id":"5f509d1c2d1de06173a45b231d42d07736ee691b","user":{"login":"laurentheirendt","id":20812112,"avatar_url":"https://avatars3.githubusercontent.com/u/20812112?v=3","gravatar_id":"","url":"https://api.github.com/users/laurentheirendt","html_url":"https://github.com/laurentheirendt","followers_url":"https://api.github.com/users/laurentheirendt/followers","following_url":"https://api.github.com/users/laurentheirendt/following{/other_user}","gists_url":"https://api.github.com/users/laurentheirendt/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentheirendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentheirendt/subscriptions","organizations_url":"https://api.github.com/users/laurentheirendt/orgs","repos_url":"https://api.github.com/users/laurentheirendt/repos","events_url":"https://api.github.com/users/laurentheirendt/events{/privacy}","received_events_url":"https://api.github.com/users/laurentheirendt/received_events","type":"User","site_admin":false},"body":"Is there actually a pre-allocation memory check done as well? Or is the code running until the memory is full?","created_at":"2017-06-08T05:47:06Z","updated_at":"2017-06-08T05:47:06Z","html_url":"https://github.com/opencobra/cobratoolbox/pull/520#discussion_r120804065","pull_request_url":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520","_links":{"self":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/comments/120804065"},"html":{"href":"https://github.com/opencobra/cobratoolbox/pull/520#discussion_r120804065"},"pull_request":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520"}}},"pull_request":{"url":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520","id":124397169,"html_url":"https://github.com/opencobra/cobratoolbox/pull/520","diff_url":"https://github.com/opencobra/cobratoolbox/pull/520.diff","patch_url":"https://github.com/opencobra/cobratoolbox/pull/520.patch","issue_url":"https://api.github.com/repos/opencobra/cobratoolbox/issues/520","number":520,"state":"open","locked":false,"title":"Update to functions modifying field sizes","user":{"login":"tpfau","id":9972778,"avatar_url":"https://avatars0.githubusercontent.com/u/9972778?v=3","gravatar_id":"","url":"https://api.github.com/users/tpfau","html_url":"https://github.com/tpfau","followers_url":"https://api.github.com/users/tpfau/followers","following_url":"https://api.github.com/users/tpfau/following{/other_user}","gists_url":"https://api.github.com/users/tpfau/gists{/gist_id}","starred_url":"https://api.github.com/users/tpfau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpfau/subscriptions","organizations_url":"https://api.github.com/users/tpfau/orgs","repos_url":"https://api.github.com/users/tpfau/repos","events_url":"https://api.github.com/users/tpfau/events{/privacy}","received_events_url":"https://api.github.com/users/tpfau/received_events","type":"User","site_admin":false},"body":"This is an update to functions modifying field sizes. Associated field sizes are now updated automatically (if they fit to some rules, either same siz, or if multiple base fields with the same size exist, fitting to e.g. rxnXYZ for rxns, or being defined in the modelFields).\r\nThis is addressing issue #343\r\n**I hereby confirm that I have:**\r\n\r\n- [X] Tested my code on my own machine\r\n- [X] Followed the guidelines in the [Contributing Guide](https://opencobra.github.io/cobratoolbox/docs/contributing.html)\r\n- [X] Selected `develop` as a target branch (top left drop-down menu)\r\n\r\n*(Note: You may replace [ ] with [X] to check the box)*\r\n","created_at":"2017-06-07T11:28:55Z","updated_at":"2017-06-08T05:47:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b616b925ccd7acb5251e55522c62140354698094","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520/commits","review_comments_url":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520/comments","review_comment_url":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencobra/cobratoolbox/issues/520/comments","statuses_url":"https://api.github.com/repos/opencobra/cobratoolbox/statuses/7d2b2a8a6eb8503294f996067d9edd7a756973a3","head":{"label":"tpfau:GetAllModelFields","ref":"GetAllModelFields","sha":"7d2b2a8a6eb8503294f996067d9edd7a756973a3","user":{"login":"tpfau","id":9972778,"avatar_url":"https://avatars0.githubusercontent.com/u/9972778?v=3","gravatar_id":"","url":"https://api.github.com/users/tpfau","html_url":"https://github.com/tpfau","followers_url":"https://api.github.com/users/tpfau/followers","following_url":"https://api.github.com/users/tpfau/following{/other_user}","gists_url":"https://api.github.com/users/tpfau/gists{/gist_id}","starred_url":"https://api.github.com/users/tpfau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpfau/subscriptions","organizations_url":"https://api.github.com/users/tpfau/orgs","repos_url":"https://api.github.com/users/tpfau/repos","events_url":"https://api.github.com/users/tpfau/events{/privacy}","received_events_url":"https://api.github.com/users/tpfau/received_events","type":"User","site_admin":false},"repo":{"id":28035499,"name":"cobratoolbox","full_name":"tpfau/cobratoolbox","owner":{"login":"tpfau","id":9972778,"avatar_url":"https://avatars0.githubusercontent.com/u/9972778?v=3","gravatar_id":"","url":"https://api.github.com/users/tpfau","html_url":"https://github.com/tpfau","followers_url":"https://api.github.com/users/tpfau/followers","following_url":"https://api.github.com/users/tpfau/following{/other_user}","gists_url":"https://api.github.com/users/tpfau/gists{/gist_id}","starred_url":"https://api.github.com/users/tpfau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpfau/subscriptions","organizations_url":"https://api.github.com/users/tpfau/orgs","repos_url":"https://api.github.com/users/tpfau/repos","events_url":"https://api.github.com/users/tpfau/events{/privacy}","received_events_url":"https://api.github.com/users/tpfau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpfau/cobratoolbox","description":"COnstraints Based Reconstruction and Analysis toolbox for MATLAB","fork":true,"url":"https://api.github.com/repos/tpfau/cobratoolbox","forks_url":"https://api.github.com/repos/tpfau/cobratoolbox/forks","keys_url":"https://api.github.com/repos/tpfau/cobratoolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpfau/cobratoolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpfau/cobratoolbox/teams","hooks_url":"https://api.github.com/repos/tpfau/cobratoolbox/hooks","issue_events_url":"https://api.github.com/repos/tpfau/cobratoolbox/issues/events{/number}","events_url":"https://api.github.com/repos/tpfau/cobratoolbox/events","assignees_url":"https://api.github.com/repos/tpfau/cobratoolbox/assignees{/user}","branches_url":"https://api.github.com/repos/tpfau/cobratoolbox/branches{/branch}","tags_url":"https://api.github.com/repos/tpfau/cobratoolbox/tags","blobs_url":"https://api.github.com/repos/tpfau/cobratoolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpfau/cobratoolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpfau/cobratoolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpfau/cobratoolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpfau/cobratoolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/tpfau/cobratoolbox/languages","stargazers_url":"https://api.github.com/repos/tpfau/cobratoolbox/stargazers","contributors_url":"https://api.github.com/repos/tpfau/cobratoolbox/contributors","subscribers_url":"https://api.github.com/repos/tpfau/cobratoolbox/subscribers","subscription_url":"https://api.github.com/repos/tpfau/cobratoolbox/subscription","commits_url":"https://api.github.com/repos/tpfau/cobratoolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpfau/cobratoolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpfau/cobratoolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpfau/cobratoolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpfau/cobratoolbox/contents/{+path}","compare_url":"https://api.github.com/repos/tpfau/cobratoolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpfau/cobratoolbox/merges","archive_url":"https://api.github.com/repos/tpfau/cobratoolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpfau/cobratoolbox/downloads","issues_url":"https://api.github.com/repos/tpfau/cobratoolbox/issues{/number}","pulls_url":"https://api.github.com/repos/tpfau/cobratoolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/tpfau/cobratoolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/tpfau/cobratoolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpfau/cobratoolbox/labels{/name}","releases_url":"https://api.github.com/repos/tpfau/cobratoolbox/releases{/id}","deployments_url":"https://api.github.com/repos/tpfau/cobratoolbox/deployments","created_at":"2014-12-15T12:21:43Z","updated_at":"2016-01-21T06:29:15Z","pushed_at":"2017-06-08T04:44:10Z","git_url":"git://github.com/tpfau/cobratoolbox.git","ssh_url":"git@github.com:tpfau/cobratoolbox.git","clone_url":"https://github.com/tpfau/cobratoolbox.git","svn_url":"https://github.com/tpfau/cobratoolbox","homepage":"","size":437717,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencobra:develop","ref":"develop","sha":"a269e31ec039c293d052373fb6aed1f4f4c152a4","user":{"login":"opencobra","id":2708410,"avatar_url":"https://avatars3.githubusercontent.com/u/2708410?v=3","gravatar_id":"","url":"https://api.github.com/users/opencobra","html_url":"https://github.com/opencobra","followers_url":"https://api.github.com/users/opencobra/followers","following_url":"https://api.github.com/users/opencobra/following{/other_user}","gists_url":"https://api.github.com/users/opencobra/gists{/gist_id}","starred_url":"https://api.github.com/users/opencobra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencobra/subscriptions","organizations_url":"https://api.github.com/users/opencobra/orgs","repos_url":"https://api.github.com/users/opencobra/repos","events_url":"https://api.github.com/users/opencobra/events{/privacy}","received_events_url":"https://api.github.com/users/opencobra/received_events","type":"Organization","site_admin":false},"repo":{"id":6512296,"name":"cobratoolbox","full_name":"opencobra/cobratoolbox","owner":{"login":"opencobra","id":2708410,"avatar_url":"https://avatars3.githubusercontent.com/u/2708410?v=3","gravatar_id":"","url":"https://api.github.com/users/opencobra","html_url":"https://github.com/opencobra","followers_url":"https://api.github.com/users/opencobra/followers","following_url":"https://api.github.com/users/opencobra/following{/other_user}","gists_url":"https://api.github.com/users/opencobra/gists{/gist_id}","starred_url":"https://api.github.com/users/opencobra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencobra/subscriptions","organizations_url":"https://api.github.com/users/opencobra/orgs","repos_url":"https://api.github.com/users/opencobra/repos","events_url":"https://api.github.com/users/opencobra/events{/privacy}","received_events_url":"https://api.github.com/users/opencobra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencobra/cobratoolbox","description":"The COnstraint-Based Reconstruction and Analysis Toolbox","fork":false,"url":"https://api.github.com/repos/opencobra/cobratoolbox","forks_url":"https://api.github.com/repos/opencobra/cobratoolbox/forks","keys_url":"https://api.github.com/repos/opencobra/cobratoolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencobra/cobratoolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencobra/cobratoolbox/teams","hooks_url":"https://api.github.com/repos/opencobra/cobratoolbox/hooks","issue_events_url":"https://api.github.com/repos/opencobra/cobratoolbox/issues/events{/number}","events_url":"https://api.github.com/repos/opencobra/cobratoolbox/events","assignees_url":"https://api.github.com/repos/opencobra/cobratoolbox/assignees{/user}","branches_url":"https://api.github.com/repos/opencobra/cobratoolbox/branches{/branch}","tags_url":"https://api.github.com/repos/opencobra/cobratoolbox/tags","blobs_url":"https://api.github.com/repos/opencobra/cobratoolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencobra/cobratoolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencobra/cobratoolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencobra/cobratoolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencobra/cobratoolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/opencobra/cobratoolbox/languages","stargazers_url":"https://api.github.com/repos/opencobra/cobratoolbox/stargazers","contributors_url":"https://api.github.com/repos/opencobra/cobratoolbox/contributors","subscribers_url":"https://api.github.com/repos/opencobra/cobratoolbox/subscribers","subscription_url":"https://api.github.com/repos/opencobra/cobratoolbox/subscription","commits_url":"https://api.github.com/repos/opencobra/cobratoolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencobra/cobratoolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencobra/cobratoolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencobra/cobratoolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencobra/cobratoolbox/contents/{+path}","compare_url":"https://api.github.com/repos/opencobra/cobratoolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencobra/cobratoolbox/merges","archive_url":"https://api.github.com/repos/opencobra/cobratoolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencobra/cobratoolbox/downloads","issues_url":"https://api.github.com/repos/opencobra/cobratoolbox/issues{/number}","pulls_url":"https://api.github.com/repos/opencobra/cobratoolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/opencobra/cobratoolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/opencobra/cobratoolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencobra/cobratoolbox/labels{/name}","releases_url":"https://api.github.com/repos/opencobra/cobratoolbox/releases{/id}","deployments_url":"https://api.github.com/repos/opencobra/cobratoolbox/deployments","created_at":"2012-11-02T20:38:05Z","updated_at":"2017-06-04T07:48:09Z","pushed_at":"2017-06-08T04:44:12Z","git_url":"git://github.com/opencobra/cobratoolbox.git","ssh_url":"git@github.com:opencobra/cobratoolbox.git","clone_url":"https://github.com/opencobra/cobratoolbox.git","svn_url":"https://github.com/opencobra/cobratoolbox","homepage":"https://opencobra.github.io/cobratoolbox","size":457897,"stargazers_count":48,"watchers_count":48,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":17,"forks":104,"open_issues":17,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520"},"html":{"href":"https://github.com/opencobra/cobratoolbox/pull/520"},"issue":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/issues/520"},"comments":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/opencobra/cobratoolbox/statuses/7d2b2a8a6eb8503294f996067d9edd7a756973a3"}}}}
{"actor":{"display_login":"laurentheirendt"}}