{"action":"created","issue":{"url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/1108","repository_url":"https://api.github.com/repos/sparkle-project/Sparkle","labels_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/1108/labels{/name}","comments_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/1108/comments","events_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/1108/events","html_url":"https://github.com/sparkle-project/Sparkle/issues/1108","id":245599349,"number":1108,"title":"Unnecessary request for admin privileges","user":{"login":"lapcat","id":56086,"avatar_url":"https://avatars3.githubusercontent.com/u/56086?v=4","gravatar_id":"","url":"https://api.github.com/users/lapcat","html_url":"https://github.com/lapcat","followers_url":"https://api.github.com/users/lapcat/followers","following_url":"https://api.github.com/users/lapcat/following{/other_user}","gists_url":"https://api.github.com/users/lapcat/gists{/gist_id}","starred_url":"https://api.github.com/users/lapcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lapcat/subscriptions","organizations_url":"https://api.github.com/users/lapcat/orgs","repos_url":"https://api.github.com/users/lapcat/repos","events_url":"https://api.github.com/users/lapcat/events{/privacy}","received_events_url":"https://api.github.com/users/lapcat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-26T03:56:21Z","updated_at":"2017-10-06T13:21:29Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"At SUFileManager.m:736, Sparkle compares the group id of the source and target, and if the group id doesn't match, Sparkle requests admin privileges to change it. This is unnecessary, however, if the owner is the user but the group is wheel (group id 0). It's rarely necessary to worry about the group as long as the owner is the same.\r\n\r\nThis problem was introduced in commit 984c3dc0e17a897d78e4c9bf2160521353520f22\r\n\r\nI've been seeing admin requests for SourceTree updates, because the app happens to have wheel group on my Mac. I also see this with the Sparkle test app on my system, because my source file directories also have wheel group."},"comment":{"url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/comments/334752767","html_url":"https://github.com/sparkle-project/Sparkle/issues/1108#issuecomment-334752767","issue_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/1108","id":334752767,"user":{"login":"bdb","id":130739,"avatar_url":"https://avatars1.githubusercontent.com/u/130739?v=4","gravatar_id":"","url":"https://api.github.com/users/bdb","html_url":"https://github.com/bdb","followers_url":"https://api.github.com/users/bdb/followers","following_url":"https://api.github.com/users/bdb/following{/other_user}","gists_url":"https://api.github.com/users/bdb/gists{/gist_id}","starred_url":"https://api.github.com/users/bdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdb/subscriptions","organizations_url":"https://api.github.com/users/bdb/orgs","repos_url":"https://api.github.com/users/bdb/repos","events_url":"https://api.github.com/users/bdb/events{/privacy}","received_events_url":"https://api.github.com/users/bdb/received_events","type":"User","site_admin":false},"created_at":"2017-10-06T13:21:29Z","updated_at":"2017-10-06T13:21:29Z","author_association":"NONE","body":"OK, so to me this doesn't sound unnecessary than. Sparkle is prompting for admin privileges because it must to make sure the permissions of the original version are set on the new version."}}
{"actor":{"display_login":"bdb"}}