{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/comments/149916928","pull_request_review_id":75385443,"id":149916928,"diff_hunk":"@@ -14,266 +14,41 @@ end\n     eps_cbrt * max(one(T), abs(x))\n end\n \n-@inline function compute_epsilon_factor(fdtype::DataType, ::Type{T}) where T<:Real\n+@inline function compute_epsilon_factor(fdtype::DataType, ::Type{T}) where T<:Number\n     if fdtype==Val{:forward}\n         return sqrt(eps(T))\n     elseif fdtype==Val{:central}\n         return cbrt(eps(T))\n     else\n         error(\"Unrecognized fdtype: must be Val{:forward} or Val{:central}.\")\n     end\n+    nothing","path":"src/finitediff.jl","position":13,"original_position":13,"commit_id":"f788176fd0f393d9ffdd9ac403306223b735e3c7","original_commit_id":"f788176fd0f393d9ffdd9ac403306223b735e3c7","user":{"login":"dextorious","id":526018,"avatar_url":"https://avatars2.githubusercontent.com/u/526018?v=4","gravatar_id":"","url":"https://api.github.com/users/dextorious","html_url":"https://github.com/dextorious","followers_url":"https://api.github.com/users/dextorious/followers","following_url":"https://api.github.com/users/dextorious/following{/other_user}","gists_url":"https://api.github.com/users/dextorious/gists{/gist_id}","starred_url":"https://api.github.com/users/dextorious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dextorious/subscriptions","organizations_url":"https://api.github.com/users/dextorious/orgs","repos_url":"https://api.github.com/users/dextorious/repos","events_url":"https://api.github.com/users/dextorious/events{/privacy}","received_events_url":"https://api.github.com/users/dextorious/received_events","type":"User","site_admin":false},"body":"The `nothing` is redundant there, it will never do anything, but it won't prevent the error. I probably just wrote it by reflex.","created_at":"2017-11-09T10:16:16Z","updated_at":"2017-11-09T10:16:16Z","html_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/pull/17#discussion_r149916928","pull_request_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/comments/149916928"},"html":{"href":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/pull/17#discussion_r149916928"},"pull_request":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17"}},"in_reply_to_id":149854666},"pull_request":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17","id":151257315,"html_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/pull/17","diff_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/pull/17.diff","patch_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/pull/17.patch","issue_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/17","number":17,"state":"open","locked":false,"title":"Support for derivatives and Jacobians of complex-valued callables","user":{"login":"dextorious","id":526018,"avatar_url":"https://avatars2.githubusercontent.com/u/526018?v=4","gravatar_id":"","url":"https://api.github.com/users/dextorious","html_url":"https://github.com/dextorious","followers_url":"https://api.github.com/users/dextorious/followers","following_url":"https://api.github.com/users/dextorious/following{/other_user}","gists_url":"https://api.github.com/users/dextorious/gists{/gist_id}","starred_url":"https://api.github.com/users/dextorious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dextorious/subscriptions","organizations_url":"https://api.github.com/users/dextorious/orgs","repos_url":"https://api.github.com/users/dextorious/repos","events_url":"https://api.github.com/users/dextorious/events{/privacy}","received_events_url":"https://api.github.com/users/dextorious/received_events","type":"User","site_admin":false},"body":"This is far from perfect and requires major refactoring in the future (particularly when the constant propagation issues are resolved), but the new features generally work, the tests pass and there shouldn't be any regressions.","created_at":"2017-11-07T23:37:12Z","updated_at":"2017-11-09T10:16:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfdf1935daf0b411dc74f0487737bfe28ae24e0a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17/commits","review_comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17/comments","review_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/17/comments","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/statuses/f788176fd0f393d9ffdd9ac403306223b735e3c7","head":{"label":"JuliaDiffEq:complexdiff","ref":"complexdiff","sha":"f788176fd0f393d9ffdd9ac403306223b735e3c7","user":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"repo":{"id":78674234,"name":"DiffEqDiffTools.jl","full_name":"JuliaDiffEq/DiffEqDiffTools.jl","owner":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl","description":"Differentiation tools using the performance overloads and traits for the DiffEq common interface","fork":false,"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl","forks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/deployments","created_at":"2017-01-11T19:55:48Z","updated_at":"2017-08-20T20:00:34Z","pushed_at":"2017-11-08T22:41:20Z","git_url":"git://github.com/JuliaDiffEq/DiffEqDiffTools.jl.git","ssh_url":"git@github.com:JuliaDiffEq/DiffEqDiffTools.jl.git","clone_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl.git","svn_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl","homepage":null,"size":27,"stargazers_count":3,"watchers_count":3,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"JuliaDiffEq:master","ref":"master","sha":"ff050f49d2f1cc787847d48115ea571ffedd415f","user":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"repo":{"id":78674234,"name":"DiffEqDiffTools.jl","full_name":"JuliaDiffEq/DiffEqDiffTools.jl","owner":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars3.githubusercontent.com/u/21238080?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl","description":"Differentiation tools using the performance overloads and traits for the DiffEq common interface","fork":false,"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl","forks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/deployments","created_at":"2017-01-11T19:55:48Z","updated_at":"2017-08-20T20:00:34Z","pushed_at":"2017-11-08T22:41:20Z","git_url":"git://github.com/JuliaDiffEq/DiffEqDiffTools.jl.git","ssh_url":"git@github.com:JuliaDiffEq/DiffEqDiffTools.jl.git","clone_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl.git","svn_url":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl","homepage":null,"size":27,"stargazers_count":3,"watchers_count":3,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17"},"html":{"href":"https://github.com/JuliaDiffEq/DiffEqDiffTools.jl/pull/17"},"issue":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/17"},"comments":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqDiffTools.jl/statuses/f788176fd0f393d9ffdd9ac403306223b735e3c7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dextorious"}}