{"action":"created","comment":{"url":"https://api.github.com/repos/Teradata/presto/pulls/comments/133469533","pull_request_review_id":56649953,"id":133469533,"diff_hunk":"@@ -44,6 +44,25 @@ memory intensive queries. It is still possible that the query runner will fail\n to divide intermediate data into chunks small enough that every chunk fits into\n memory, leading to `Out of memory` errors while loading the data from disk.\n \n+Disk usage\n+----------\n+\n+Spilling intermediate results to disk and retrieving it back is expensive\n+in terms of IO operations. Thus, queries that use spill likely become\n+throttled by disk. To increase query performance it is recommended to\n+provide multiple paths on separate local devices for spill (property\n+``spiller-spill-path`` in :ref:`tuning-spilling`). It may be also\n+beneficial to store spill data on HDFS provided that it is run\n+alongside presto cluster on the same machines.\n+\n+It is recommended to monitor disk saturation of spill paths manually.","path":"presto-docs/src/main/sphinx/spill/overview.rst","position":15,"original_position":15,"commit_id":"ffb059167d21d5cf213cc912bd9eaf02ae6ab9cc","original_commit_id":"ffb059167d21d5cf213cc912bd9eaf02ae6ab9cc","user":{"login":"findepi","id":144328,"avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false},"body":"\"manually\" doesn't sound good. Can this word be skipped somehow?","created_at":"2017-08-16T14:40:44Z","updated_at":"2017-08-16T14:43:26Z","html_url":"https://github.com/Teradata/presto/pull/683#discussion_r133469533","pull_request_url":"https://api.github.com/repos/Teradata/presto/pulls/683","_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments/133469533"},"html":{"href":"https://github.com/Teradata/presto/pull/683#discussion_r133469533"},"pull_request":{"href":"https://api.github.com/repos/Teradata/presto/pulls/683"}}},"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/683","id":136023639,"html_url":"https://github.com/Teradata/presto/pull/683","diff_url":"https://github.com/Teradata/presto/pull/683.diff","patch_url":"https://github.com/Teradata/presto/pull/683.patch","issue_url":"https://api.github.com/repos/Teradata/presto/issues/683","number":683,"state":"open","locked":false,"title":"Add note about disk usage in spill docs","user":{"login":"szymonm","id":5087912,"avatar_url":"https://avatars2.githubusercontent.com/u/5087912?v=4","gravatar_id":"","url":"https://api.github.com/users/szymonm","html_url":"https://github.com/szymonm","followers_url":"https://api.github.com/users/szymonm/followers","following_url":"https://api.github.com/users/szymonm/following{/other_user}","gists_url":"https://api.github.com/users/szymonm/gists{/gist_id}","starred_url":"https://api.github.com/users/szymonm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szymonm/subscriptions","organizations_url":"https://api.github.com/users/szymonm/orgs","repos_url":"https://api.github.com/users/szymonm/repos","events_url":"https://api.github.com/users/szymonm/events{/privacy}","received_events_url":"https://api.github.com/users/szymonm/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-16T13:25:56Z","updated_at":"2017-08-16T14:43:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f8939c69a899873775fc501ba152d54abd20ea7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Teradata/presto/pulls/683/commits","review_comments_url":"https://api.github.com/repos/Teradata/presto/pulls/683/comments","review_comment_url":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/683/comments","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/ffb059167d21d5cf213cc912bd9eaf02ae6ab9cc","head":{"label":"Teradata:spill-join/docs2","ref":"spill-join/docs2","sha":"ffb059167d21d5cf213cc912bd9eaf02ae6ab9cc","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata Distribution of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2017-06-27T21:21:21Z","pushed_at":"2017-08-16T14:36:40Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"git@github.com:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":197148,"stargazers_count":74,"watchers_count":74,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":31,"forks":19,"open_issues":31,"watchers":74,"default_branch":"master"}},"base":{"label":"Teradata:findepi/pr/spill-join","ref":"findepi/pr/spill-join","sha":"e3f4fcea2ccf0a950819a47a8efa17bc30595d64","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata Distribution of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2017-06-27T21:21:21Z","pushed_at":"2017-08-16T14:36:40Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"git@github.com:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":197148,"stargazers_count":74,"watchers_count":74,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":31,"forks":19,"open_issues":31,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/683"},"html":{"href":"https://github.com/Teradata/presto/pull/683"},"issue":{"href":"https://api.github.com/repos/Teradata/presto/issues/683"},"comments":{"href":"https://api.github.com/repos/Teradata/presto/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/Teradata/presto/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teradata/presto/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/Teradata/presto/statuses/ffb059167d21d5cf213cc912bd9eaf02ae6ab9cc"}}}}
{"actor":{"display_login":"findepi"}}