{"action":"created","issue":{"url":"https://api.github.com/repos/postcss/postcss-loader/issues/234","repository_url":"https://api.github.com/repos/postcss/postcss-loader","labels_url":"https://api.github.com/repos/postcss/postcss-loader/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/postcss/postcss-loader/issues/234/comments","events_url":"https://api.github.com/repos/postcss/postcss-loader/issues/234/events","html_url":"https://github.com/postcss/postcss-loader/pull/234","id":229052711,"number":234,"title":"refactor: improved loading algorithm of options and configs","user":{"login":"evilebottnawi","id":4567934,"avatar_url":"https://avatars0.githubusercontent.com/u/4567934?v=3","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"labels":[{"id":595927631,"url":"https://api.github.com/repos/postcss/postcss-loader/labels/ci:%20ok","name":"ci: ok","color":"0e8a16","default":false},{"id":595928083,"url":"https://api.github.com/repos/postcss/postcss-loader/labels/priority:%20medium","name":"priority: medium","color":"fbca04","default":false},{"id":586325503,"url":"https://api.github.com/repos/postcss/postcss-loader/labels/semver:%20patch","name":"semver: patch","color":"1d76db","default":false},{"id":570751147,"url":"https://api.github.com/repos/postcss/postcss-loader/labels/status:%20review","name":"status: review","color":"c2e0c6","default":false},{"id":570750332,"url":"https://api.github.com/repos/postcss/postcss-loader/labels/type:%20refactor","name":"type: refactor","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/postcss/postcss-loader/milestones/3","html_url":"https://github.com/postcss/postcss-loader/milestone/3","labels_url":"https://api.github.com/repos/postcss/postcss-loader/milestones/3/labels","id":2475209,"number":3,"title":"2.0.6","description":"Bugfix Release (:label: Patch)","creator":{"login":"michael-ciniawsky","id":5419992,"avatar_url":"https://avatars3.githubusercontent.com/u/5419992?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-ciniawsky","html_url":"https://github.com/michael-ciniawsky","followers_url":"https://api.github.com/users/michael-ciniawsky/followers","following_url":"https://api.github.com/users/michael-ciniawsky/following{/other_user}","gists_url":"https://api.github.com/users/michael-ciniawsky/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-ciniawsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-ciniawsky/subscriptions","organizations_url":"https://api.github.com/users/michael-ciniawsky/orgs","repos_url":"https://api.github.com/users/michael-ciniawsky/repos","events_url":"https://api.github.com/users/michael-ciniawsky/events{/privacy}","received_events_url":"https://api.github.com/users/michael-ciniawsky/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2017-04-24T00:19:33Z","updated_at":"2017-05-17T20:08:10Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-05-16T14:25:31Z","updated_at":"2017-05-18T21:35:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/postcss/postcss-loader/pulls/234","html_url":"https://github.com/postcss/postcss-loader/pull/234","diff_url":"https://github.com/postcss/postcss-loader/pull/234.diff","patch_url":"https://github.com/postcss/postcss-loader/pull/234.patch"},"body":"Why?\r\n1. No todo :smile:\r\n2. Always load config if your pass `config.path`, now it is not working as expected if i pass `config.path` and `sourceMap: false` my config file not loading -> `options.config && !sourceMap && length > 1` (i want to load config and set `sourceMap` use loader options ), also sometimes i want setup some option from options loader.\r\n3. Some perf (we don't create `rc` object because it is not necessary if i use only `options` without `options.config`)\r\n4. Allow to passing options to `postcss` throw `loader.options`, now it is possibly only using `postcss` config."},"comment":{"url":"https://api.github.com/repos/postcss/postcss-loader/issues/comments/302548345","html_url":"https://github.com/postcss/postcss-loader/pull/234#issuecomment-302548345","issue_url":"https://api.github.com/repos/postcss/postcss-loader/issues/234","id":302548345,"user":{"login":"evilebottnawi","id":4567934,"avatar_url":"https://avatars0.githubusercontent.com/u/4567934?v=3","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"created_at":"2017-05-18T21:35:21Z","updated_at":"2017-05-18T21:35:21Z","body":"@michael-ciniawsky we should finish and merge this PR asap, i spend about 5 hours for migrate to new postcss loader in most of my projects, in half the configuration is not loaded or source maps not working, current loading algorithm is misleading and incorrect.\r\n\r\nMy solution:\r\n1. By default `config` is false and don't load postcss config.\r\n2. If your have `config: true` or `config: { ctx : {...options}}` we loading config (also working good for nested config). Now `config: true` is disable by schema, but we can fix this.\r\n3. If your have `config: { path: '/path/to/config' }` we loading config (absolutly).\r\n\r\nThis may seem small breaking changed, but it is bugfix, because now postcss config don't load in most use case."}}
{"actor":{"display_login":"evilebottnawi"}}