{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/139330441","pull_request_review_id":63247008,"id":139330441,"diff_hunk":"@@ -7,49 +7,51 @@\n // #define START_IND(a,b,c) a * c / b\n // #define END_IND(a,b,c)  (a + 1) * c / b + ((a + 1) * c % b > 0)?1:0\n \n+// 4d tensor B x D x H x W\n+\n static void THNN_(SpatialAdaptiveAveragePooling_updateOutput_frame)(\n           real *input_p,\n           real *output_p,\n-          long nslices,\n-          long iwidth,\n-          long iheight,","path":"torch/lib/THNN/generic/SpatialAdaptiveAveragePooling.c","position":11,"original_position":11,"commit_id":"3581957a7bbc5c917c1eccf2f6f8bec7af6ed40b","original_commit_id":"3581957a7bbc5c917c1eccf2f6f8bec7af6ed40b","user":{"login":"gchanan","id":3768583,"avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false},"body":"same thing, why did these change?","created_at":"2017-09-18T02:35:37Z","updated_at":"2017-09-18T02:50:59Z","html_url":"https://github.com/pytorch/pytorch/pull/2728#discussion_r139330441","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/2728","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/139330441"},"html":{"href":"https://github.com/pytorch/pytorch/pull/2728#discussion_r139330441"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2728"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/2728","id":140941215,"html_url":"https://github.com/pytorch/pytorch/pull/2728","diff_url":"https://github.com/pytorch/pytorch/pull/2728.diff","patch_url":"https://github.com/pytorch/pytorch/pull/2728.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/2728","number":2728,"state":"open","locked":false,"title":"Adaptive average pooling 3d","user":{"login":"SsnL","id":5674597,"avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"body":"Adding AdaptiveAvgPool3d as per request in #1988 .\r\n\r\nTest plan:\r\n./run_test.sh","created_at":"2017-09-13T22:06:53Z","updated_at":"2017-09-18T02:50:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6edd2f26b4487fd3ec7a3684c8ba32acfbe6764e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/2728/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/2728/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/2728/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/3581957a7bbc5c917c1eccf2f6f8bec7af6ed40b","head":{"label":"SsnL:adaptive_avg_pool_3d","ref":"adaptive_avg_pool_3d","sha":"3581957a7bbc5c917c1eccf2f6f8bec7af6ed40b","user":{"login":"SsnL","id":5674597,"avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"repo":{"id":103305558,"name":"pytorch","full_name":"SsnL/pytorch","owner":{"login":"SsnL","id":5674597,"avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SsnL/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/SsnL/pytorch","forks_url":"https://api.github.com/repos/SsnL/pytorch/forks","keys_url":"https://api.github.com/repos/SsnL/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SsnL/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SsnL/pytorch/teams","hooks_url":"https://api.github.com/repos/SsnL/pytorch/hooks","issue_events_url":"https://api.github.com/repos/SsnL/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/SsnL/pytorch/events","assignees_url":"https://api.github.com/repos/SsnL/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/SsnL/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/SsnL/pytorch/tags","blobs_url":"https://api.github.com/repos/SsnL/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SsnL/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SsnL/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/SsnL/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SsnL/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/SsnL/pytorch/languages","stargazers_url":"https://api.github.com/repos/SsnL/pytorch/stargazers","contributors_url":"https://api.github.com/repos/SsnL/pytorch/contributors","subscribers_url":"https://api.github.com/repos/SsnL/pytorch/subscribers","subscription_url":"https://api.github.com/repos/SsnL/pytorch/subscription","commits_url":"https://api.github.com/repos/SsnL/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/SsnL/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/SsnL/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/SsnL/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/SsnL/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/SsnL/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SsnL/pytorch/merges","archive_url":"https://api.github.com/repos/SsnL/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SsnL/pytorch/downloads","issues_url":"https://api.github.com/repos/SsnL/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/SsnL/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/SsnL/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/SsnL/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SsnL/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/SsnL/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/SsnL/pytorch/deployments","created_at":"2017-09-12T18:13:43Z","updated_at":"2017-09-12T18:13:49Z","pushed_at":"2017-09-14T20:48:27Z","git_url":"git://github.com/SsnL/pytorch.git","ssh_url":"git@github.com:SsnL/pytorch.git","clone_url":"https://github.com/SsnL/pytorch.git","svn_url":"https://github.com/SsnL/pytorch","homepage":"http://pytorch.org","size":14845,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"0a9f93e43c3939040b2b3ce8f30482e094f9f56f","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2017-09-18T02:18:28Z","pushed_at":"2017-09-18T02:27:53Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":15070,"stargazers_count":7416,"watchers_count":7416,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1481,"mirror_url":null,"open_issues_count":396,"forks":1481,"open_issues":396,"watchers":7416,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2728"},"html":{"href":"https://github.com/pytorch/pytorch/pull/2728"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/2728"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/2728/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2728/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2728/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/3581957a7bbc5c917c1eccf2f6f8bec7af6ed40b"}},"author_association":"NONE"}}
{"actor":{"display_login":"gchanan"}}