{"action":"created","comment":{"url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/comments/135145002","pull_request_review_id":58526434,"id":135145002,"diff_hunk":"@@ -61,6 +64,35 @@ function saveTemplates (templateJSON, callback, responseData = null) {\n     });\n }\n \n+function getDomains (callback) {\n+    var domainArray = {};\n+    // Get the default domains\n+    var domainArray2 = $.map(DefaultDomainList, function (domain, index) {\n+        domain.default = true;\n+        return domain;\n+    });\n+    // sort the default domains\n+    domainArray2 = utils.sortArrayByProperty(domainArray2, 'name');\n+    // Get the custom domains\n+    chrome.storage.sync.get(StorageID, function (data) {\n+        if (data[StorageID]) {\n+            var domains = data[StorageID].options.domains;\n+            domainArray = $.map(domains, function (domain, index) {\n+                domain.default = false;","path":"src/jti_background.js","position":31,"original_position":31,"commit_id":"2c98b76cade94281fbbd6765551e7a991613cf61","original_commit_id":"2c98b76cade94281fbbd6765551e7a991613cf61","user":{"login":"KevinMitchellREDBRICK","id":24922962,"avatar_url":"https://avatars2.githubusercontent.com/u/24922962?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinMitchellREDBRICK","html_url":"https://github.com/KevinMitchellREDBRICK","followers_url":"https://api.github.com/users/KevinMitchellREDBRICK/followers","following_url":"https://api.github.com/users/KevinMitchellREDBRICK/following{/other_user}","gists_url":"https://api.github.com/users/KevinMitchellREDBRICK/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinMitchellREDBRICK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinMitchellREDBRICK/subscriptions","organizations_url":"https://api.github.com/users/KevinMitchellREDBRICK/orgs","repos_url":"https://api.github.com/users/KevinMitchellREDBRICK/repos","events_url":"https://api.github.com/users/KevinMitchellREDBRICK/events{/privacy}","received_events_url":"https://api.github.com/users/KevinMitchellREDBRICK/received_events","type":"User","site_admin":false},"body":"It is an option that would work, and I could do it. However, I personally prefer explicit over implicit coding. I also think I'll still have to do the mapping anyway (mapping the domain object to the array), so I don't see a drawback to leaving this back.","created_at":"2017-08-24T22:17:41Z","updated_at":"2017-08-24T22:17:41Z","html_url":"https://github.com/rdbrck/jira-template-injector/pull/36#discussion_r135145002","pull_request_url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/comments/135145002"},"html":{"href":"https://github.com/rdbrck/jira-template-injector/pull/36#discussion_r135145002"},"pull_request":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36","id":136862796,"html_url":"https://github.com/rdbrck/jira-template-injector/pull/36","diff_url":"https://github.com/rdbrck/jira-template-injector/pull/36.diff","patch_url":"https://github.com/rdbrck/jira-template-injector/pull/36.patch","issue_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/36","number":36,"state":"open","locked":false,"title":"Initial commit for EXT-946, adding custom domains.","user":{"login":"KevinMitchellREDBRICK","id":24922962,"avatar_url":"https://avatars2.githubusercontent.com/u/24922962?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinMitchellREDBRICK","html_url":"https://github.com/KevinMitchellREDBRICK","followers_url":"https://api.github.com/users/KevinMitchellREDBRICK/followers","following_url":"https://api.github.com/users/KevinMitchellREDBRICK/following{/other_user}","gists_url":"https://api.github.com/users/KevinMitchellREDBRICK/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinMitchellREDBRICK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinMitchellREDBRICK/subscriptions","organizations_url":"https://api.github.com/users/KevinMitchellREDBRICK/orgs","repos_url":"https://api.github.com/users/KevinMitchellREDBRICK/repos","events_url":"https://api.github.com/users/KevinMitchellREDBRICK/events{/privacy}","received_events_url":"https://api.github.com/users/KevinMitchellREDBRICK/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-21T23:24:45Z","updated_at":"2017-08-24T22:17:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"744a44c05334ace3ecb7eee9e70d361d65d26bfb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"genevieveluyt","id":11131143,"avatar_url":"https://avatars0.githubusercontent.com/u/11131143?v=4","gravatar_id":"","url":"https://api.github.com/users/genevieveluyt","html_url":"https://github.com/genevieveluyt","followers_url":"https://api.github.com/users/genevieveluyt/followers","following_url":"https://api.github.com/users/genevieveluyt/following{/other_user}","gists_url":"https://api.github.com/users/genevieveluyt/gists{/gist_id}","starred_url":"https://api.github.com/users/genevieveluyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genevieveluyt/subscriptions","organizations_url":"https://api.github.com/users/genevieveluyt/orgs","repos_url":"https://api.github.com/users/genevieveluyt/repos","events_url":"https://api.github.com/users/genevieveluyt/events{/privacy}","received_events_url":"https://api.github.com/users/genevieveluyt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36/commits","review_comments_url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36/comments","review_comment_url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/36/comments","statuses_url":"https://api.github.com/repos/rdbrck/jira-template-injector/statuses/2c98b76cade94281fbbd6765551e7a991613cf61","head":{"label":"rdbrck:EXT-946_DynamicPagePermissions","ref":"EXT-946_DynamicPagePermissions","sha":"2c98b76cade94281fbbd6765551e7a991613cf61","user":{"login":"rdbrck","id":18216196,"avatar_url":"https://avatars3.githubusercontent.com/u/18216196?v=4","gravatar_id":"","url":"https://api.github.com/users/rdbrck","html_url":"https://github.com/rdbrck","followers_url":"https://api.github.com/users/rdbrck/followers","following_url":"https://api.github.com/users/rdbrck/following{/other_user}","gists_url":"https://api.github.com/users/rdbrck/gists{/gist_id}","starred_url":"https://api.github.com/users/rdbrck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdbrck/subscriptions","organizations_url":"https://api.github.com/users/rdbrck/orgs","repos_url":"https://api.github.com/users/rdbrck/repos","events_url":"https://api.github.com/users/rdbrck/events{/privacy}","received_events_url":"https://api.github.com/users/rdbrck/received_events","type":"Organization","site_admin":false},"repo":{"id":55248936,"name":"jira-template-injector","full_name":"rdbrck/jira-template-injector","owner":{"login":"rdbrck","id":18216196,"avatar_url":"https://avatars3.githubusercontent.com/u/18216196?v=4","gravatar_id":"","url":"https://api.github.com/users/rdbrck","html_url":"https://github.com/rdbrck","followers_url":"https://api.github.com/users/rdbrck/followers","following_url":"https://api.github.com/users/rdbrck/following{/other_user}","gists_url":"https://api.github.com/users/rdbrck/gists{/gist_id}","starred_url":"https://api.github.com/users/rdbrck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdbrck/subscriptions","organizations_url":"https://api.github.com/users/rdbrck/orgs","repos_url":"https://api.github.com/users/rdbrck/repos","events_url":"https://api.github.com/users/rdbrck/events{/privacy}","received_events_url":"https://api.github.com/users/rdbrck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rdbrck/jira-template-injector","description":null,"fork":false,"url":"https://api.github.com/repos/rdbrck/jira-template-injector","forks_url":"https://api.github.com/repos/rdbrck/jira-template-injector/forks","keys_url":"https://api.github.com/repos/rdbrck/jira-template-injector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdbrck/jira-template-injector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdbrck/jira-template-injector/teams","hooks_url":"https://api.github.com/repos/rdbrck/jira-template-injector/hooks","issue_events_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/events{/number}","events_url":"https://api.github.com/repos/rdbrck/jira-template-injector/events","assignees_url":"https://api.github.com/repos/rdbrck/jira-template-injector/assignees{/user}","branches_url":"https://api.github.com/repos/rdbrck/jira-template-injector/branches{/branch}","tags_url":"https://api.github.com/repos/rdbrck/jira-template-injector/tags","blobs_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdbrck/jira-template-injector/statuses/{sha}","languages_url":"https://api.github.com/repos/rdbrck/jira-template-injector/languages","stargazers_url":"https://api.github.com/repos/rdbrck/jira-template-injector/stargazers","contributors_url":"https://api.github.com/repos/rdbrck/jira-template-injector/contributors","subscribers_url":"https://api.github.com/repos/rdbrck/jira-template-injector/subscribers","subscription_url":"https://api.github.com/repos/rdbrck/jira-template-injector/subscription","commits_url":"https://api.github.com/repos/rdbrck/jira-template-injector/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdbrck/jira-template-injector/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdbrck/jira-template-injector/contents/{+path}","compare_url":"https://api.github.com/repos/rdbrck/jira-template-injector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdbrck/jira-template-injector/merges","archive_url":"https://api.github.com/repos/rdbrck/jira-template-injector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdbrck/jira-template-injector/downloads","issues_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues{/number}","pulls_url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls{/number}","milestones_url":"https://api.github.com/repos/rdbrck/jira-template-injector/milestones{/number}","notifications_url":"https://api.github.com/repos/rdbrck/jira-template-injector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdbrck/jira-template-injector/labels{/name}","releases_url":"https://api.github.com/repos/rdbrck/jira-template-injector/releases{/id}","deployments_url":"https://api.github.com/repos/rdbrck/jira-template-injector/deployments","created_at":"2016-04-01T17:06:45Z","updated_at":"2017-07-12T07:36:28Z","pushed_at":"2017-08-22T16:24:37Z","git_url":"git://github.com/rdbrck/jira-template-injector.git","ssh_url":"git@github.com:rdbrck/jira-template-injector.git","clone_url":"https://github.com/rdbrck/jira-template-injector.git","svn_url":"https://github.com/rdbrck/jira-template-injector","homepage":null,"size":2064,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"rdbrck:master","ref":"master","sha":"ab88faa351413744c22e51142d06e4e829fecca6","user":{"login":"rdbrck","id":18216196,"avatar_url":"https://avatars3.githubusercontent.com/u/18216196?v=4","gravatar_id":"","url":"https://api.github.com/users/rdbrck","html_url":"https://github.com/rdbrck","followers_url":"https://api.github.com/users/rdbrck/followers","following_url":"https://api.github.com/users/rdbrck/following{/other_user}","gists_url":"https://api.github.com/users/rdbrck/gists{/gist_id}","starred_url":"https://api.github.com/users/rdbrck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdbrck/subscriptions","organizations_url":"https://api.github.com/users/rdbrck/orgs","repos_url":"https://api.github.com/users/rdbrck/repos","events_url":"https://api.github.com/users/rdbrck/events{/privacy}","received_events_url":"https://api.github.com/users/rdbrck/received_events","type":"Organization","site_admin":false},"repo":{"id":55248936,"name":"jira-template-injector","full_name":"rdbrck/jira-template-injector","owner":{"login":"rdbrck","id":18216196,"avatar_url":"https://avatars3.githubusercontent.com/u/18216196?v=4","gravatar_id":"","url":"https://api.github.com/users/rdbrck","html_url":"https://github.com/rdbrck","followers_url":"https://api.github.com/users/rdbrck/followers","following_url":"https://api.github.com/users/rdbrck/following{/other_user}","gists_url":"https://api.github.com/users/rdbrck/gists{/gist_id}","starred_url":"https://api.github.com/users/rdbrck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdbrck/subscriptions","organizations_url":"https://api.github.com/users/rdbrck/orgs","repos_url":"https://api.github.com/users/rdbrck/repos","events_url":"https://api.github.com/users/rdbrck/events{/privacy}","received_events_url":"https://api.github.com/users/rdbrck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rdbrck/jira-template-injector","description":null,"fork":false,"url":"https://api.github.com/repos/rdbrck/jira-template-injector","forks_url":"https://api.github.com/repos/rdbrck/jira-template-injector/forks","keys_url":"https://api.github.com/repos/rdbrck/jira-template-injector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdbrck/jira-template-injector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdbrck/jira-template-injector/teams","hooks_url":"https://api.github.com/repos/rdbrck/jira-template-injector/hooks","issue_events_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/events{/number}","events_url":"https://api.github.com/repos/rdbrck/jira-template-injector/events","assignees_url":"https://api.github.com/repos/rdbrck/jira-template-injector/assignees{/user}","branches_url":"https://api.github.com/repos/rdbrck/jira-template-injector/branches{/branch}","tags_url":"https://api.github.com/repos/rdbrck/jira-template-injector/tags","blobs_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdbrck/jira-template-injector/statuses/{sha}","languages_url":"https://api.github.com/repos/rdbrck/jira-template-injector/languages","stargazers_url":"https://api.github.com/repos/rdbrck/jira-template-injector/stargazers","contributors_url":"https://api.github.com/repos/rdbrck/jira-template-injector/contributors","subscribers_url":"https://api.github.com/repos/rdbrck/jira-template-injector/subscribers","subscription_url":"https://api.github.com/repos/rdbrck/jira-template-injector/subscription","commits_url":"https://api.github.com/repos/rdbrck/jira-template-injector/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdbrck/jira-template-injector/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdbrck/jira-template-injector/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdbrck/jira-template-injector/contents/{+path}","compare_url":"https://api.github.com/repos/rdbrck/jira-template-injector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdbrck/jira-template-injector/merges","archive_url":"https://api.github.com/repos/rdbrck/jira-template-injector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdbrck/jira-template-injector/downloads","issues_url":"https://api.github.com/repos/rdbrck/jira-template-injector/issues{/number}","pulls_url":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls{/number}","milestones_url":"https://api.github.com/repos/rdbrck/jira-template-injector/milestones{/number}","notifications_url":"https://api.github.com/repos/rdbrck/jira-template-injector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdbrck/jira-template-injector/labels{/name}","releases_url":"https://api.github.com/repos/rdbrck/jira-template-injector/releases{/id}","deployments_url":"https://api.github.com/repos/rdbrck/jira-template-injector/deployments","created_at":"2016-04-01T17:06:45Z","updated_at":"2017-07-12T07:36:28Z","pushed_at":"2017-08-22T16:24:37Z","git_url":"git://github.com/rdbrck/jira-template-injector.git","ssh_url":"git@github.com:rdbrck/jira-template-injector.git","clone_url":"https://github.com/rdbrck/jira-template-injector.git","svn_url":"https://github.com/rdbrck/jira-template-injector","homepage":null,"size":2064,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36"},"html":{"href":"https://github.com/rdbrck/jira-template-injector/pull/36"},"issue":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/36"},"comments":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/rdbrck/jira-template-injector/statuses/2c98b76cade94281fbbd6765551e7a991613cf61"}}}}
{"actor":{"display_login":"KevinMitchellREDBRICK"}}