{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/137878059","pull_request_review_id":61608918,"id":137878059,"diff_hunk":"@@ -31,6 +31,9 @@ tags: {  # <amp-list>\n   tag_name: \"AMP-LIST\"\n   requires_extension: \"amp-list\"\n   attrs: { name: \"credentials\" }\n+  attrs: { name: \"items\" }\n+  attrs: { name: \"max-length\" }","path":"extensions/amp-list/validator-amp-list.protoascii","position":5,"original_position":5,"commit_id":"9f30b07736d3b5a07e727cdf929e665bf8c70239","original_commit_id":"9f30b07736d3b5a07e727cdf929e665bf8c70239","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"as discussed, let's do `max-items`","created_at":"2017-09-08T20:02:16Z","updated_at":"2017-09-08T20:03:15Z","html_url":"https://github.com/ampproject/amphtml/pull/11236#discussion_r137878059","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/11236","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/137878059"},"html":{"href":"https://github.com/ampproject/amphtml/pull/11236#discussion_r137878059"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11236"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/11236","id":140098528,"html_url":"https://github.com/ampproject/amphtml/pull/11236","diff_url":"https://github.com/ampproject/amphtml/pull/11236.diff","patch_url":"https://github.com/ampproject/amphtml/pull/11236.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/11236","number":11236,"state":"open","locked":false,"title":"Add support for `single-result` and `max-length` fixes #9687","user":{"login":"jpettitt","id":524856,"avatar_url":"https://avatars3.githubusercontent.com/u/524856?v=4","gravatar_id":"","url":"https://api.github.com/users/jpettitt","html_url":"https://github.com/jpettitt","followers_url":"https://api.github.com/users/jpettitt/followers","following_url":"https://api.github.com/users/jpettitt/following{/other_user}","gists_url":"https://api.github.com/users/jpettitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jpettitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpettitt/subscriptions","organizations_url":"https://api.github.com/users/jpettitt/orgs","repos_url":"https://api.github.com/users/jpettitt/repos","events_url":"https://api.github.com/users/jpettitt/events{/privacy}","received_events_url":"https://api.github.com/users/jpettitt/received_events","type":"User","site_admin":false},"body":"Adds a `single-result` attribute to allow `amp-list` to render from json endpoints that return non-array values.\r\n\r\nAdds a `max-length` attribute to tell `amp-list` to render at most `max-length` entries.\r\n","created_at":"2017-09-08T18:28:28Z","updated_at":"2017-09-08T20:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e3e77bf1bc5f91d5083908d13686be8e7c69de4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/11236/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/11236/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/11236/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/9f30b07736d3b5a07e727cdf929e665bf8c70239","head":{"label":"jpettitt:lamp-list-array-fix","ref":"lamp-list-array-fix","sha":"9f30b07736d3b5a07e727cdf929e665bf8c70239","user":{"login":"jpettitt","id":524856,"avatar_url":"https://avatars3.githubusercontent.com/u/524856?v=4","gravatar_id":"","url":"https://api.github.com/users/jpettitt","html_url":"https://github.com/jpettitt","followers_url":"https://api.github.com/users/jpettitt/followers","following_url":"https://api.github.com/users/jpettitt/following{/other_user}","gists_url":"https://api.github.com/users/jpettitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jpettitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpettitt/subscriptions","organizations_url":"https://api.github.com/users/jpettitt/orgs","repos_url":"https://api.github.com/users/jpettitt/repos","events_url":"https://api.github.com/users/jpettitt/events{/privacy}","received_events_url":"https://api.github.com/users/jpettitt/received_events","type":"User","site_admin":false},"repo":{"id":50604625,"name":"amphtml","full_name":"jpettitt/amphtml","owner":{"login":"jpettitt","id":524856,"avatar_url":"https://avatars3.githubusercontent.com/u/524856?v=4","gravatar_id":"","url":"https://api.github.com/users/jpettitt","html_url":"https://github.com/jpettitt","followers_url":"https://api.github.com/users/jpettitt/followers","following_url":"https://api.github.com/users/jpettitt/following{/other_user}","gists_url":"https://api.github.com/users/jpettitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jpettitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpettitt/subscriptions","organizations_url":"https://api.github.com/users/jpettitt/orgs","repos_url":"https://api.github.com/users/jpettitt/repos","events_url":"https://api.github.com/users/jpettitt/events{/privacy}","received_events_url":"https://api.github.com/users/jpettitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpettitt/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/jpettitt/amphtml","forks_url":"https://api.github.com/repos/jpettitt/amphtml/forks","keys_url":"https://api.github.com/repos/jpettitt/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpettitt/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpettitt/amphtml/teams","hooks_url":"https://api.github.com/repos/jpettitt/amphtml/hooks","issue_events_url":"https://api.github.com/repos/jpettitt/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/jpettitt/amphtml/events","assignees_url":"https://api.github.com/repos/jpettitt/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/jpettitt/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/jpettitt/amphtml/tags","blobs_url":"https://api.github.com/repos/jpettitt/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpettitt/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpettitt/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpettitt/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpettitt/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/jpettitt/amphtml/languages","stargazers_url":"https://api.github.com/repos/jpettitt/amphtml/stargazers","contributors_url":"https://api.github.com/repos/jpettitt/amphtml/contributors","subscribers_url":"https://api.github.com/repos/jpettitt/amphtml/subscribers","subscription_url":"https://api.github.com/repos/jpettitt/amphtml/subscription","commits_url":"https://api.github.com/repos/jpettitt/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpettitt/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpettitt/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpettitt/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpettitt/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/jpettitt/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpettitt/amphtml/merges","archive_url":"https://api.github.com/repos/jpettitt/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpettitt/amphtml/downloads","issues_url":"https://api.github.com/repos/jpettitt/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/jpettitt/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/jpettitt/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/jpettitt/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpettitt/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/jpettitt/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/jpettitt/amphtml/deployments","created_at":"2016-01-28T18:42:39Z","updated_at":"2016-01-28T18:42:41Z","pushed_at":"2017-09-08T19:31:54Z","git_url":"git://github.com/jpettitt/amphtml.git","ssh_url":"git@github.com:jpettitt/amphtml.git","clone_url":"https://github.com/jpettitt/amphtml.git","svn_url":"https://github.com/jpettitt/amphtml","homepage":"https://ampproject.org","size":244192,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"dabd010ac86809b56dd7df00b74ca473c7d5b364","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-09-08T16:01:43Z","pushed_at":"2017-09-08T20:00:20Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":244393,"stargazers_count":10432,"watchers_count":10432,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1909,"mirror_url":null,"open_issues_count":923,"forks":1909,"open_issues":923,"watchers":10432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11236"},"html":{"href":"https://github.com/ampproject/amphtml/pull/11236"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/11236"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/11236/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11236/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/11236/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/9f30b07736d3b5a07e727cdf929e665bf8c70239"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aghassemi"}}