{"action":"created","comment":{"url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/comments/113662077","pull_request_review_id":35068681,"id":113662077,"diff_hunk":"@@ -113,17 +113,16 @@ extern int position_profile_generate(int step);\n  *\n  * @return no. of steps for quick stop profile : range [1 - steps]\n  */\n-extern int init_quick_stop_position_profile(int actual_velocity, int actual_position, int max_deceleration) ;\n+extern int init_quick_stop_position_profile(int actual_velocity, int actual_position, int deceleration) ;","path":"module_profiles/include/profile.h","position":5,"original_position":5,"commit_id":"49e0e03c957e9c16628236a2c1a7234a2d3af3b5","original_commit_id":"49e0e03c957e9c16628236a2c1a7234a2d3af3b5","user":{"login":"vtretyakov","id":6347921,"avatar_url":"https://avatars1.githubusercontent.com/u/6347921?v=3","gravatar_id":"","url":"https://api.github.com/users/vtretyakov","html_url":"https://github.com/vtretyakov","followers_url":"https://api.github.com/users/vtretyakov/followers","following_url":"https://api.github.com/users/vtretyakov/following{/other_user}","gists_url":"https://api.github.com/users/vtretyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/vtretyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtretyakov/subscriptions","organizations_url":"https://api.github.com/users/vtretyakov/orgs","repos_url":"https://api.github.com/users/vtretyakov/repos","events_url":"https://api.github.com/users/vtretyakov/events{/privacy}","received_events_url":"https://api.github.com/users/vtretyakov/received_events","type":"User","site_admin":false},"body":"since it is a quick stop function, we need to use a proper naming for deceleration not to be confused with profile decelerations - quick_stop_deceleration","created_at":"2017-04-27T10:18:18Z","updated_at":"2017-04-27T10:18:18Z","html_url":"https://github.com/synapticon/sc_sncn_motorcontrol/pull/3#discussion_r113662077","pull_request_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/comments/113662077"},"html":{"href":"https://github.com/synapticon/sc_sncn_motorcontrol/pull/3#discussion_r113662077"},"pull_request":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3","id":117888677,"html_url":"https://github.com/synapticon/sc_sncn_motorcontrol/pull/3","diff_url":"https://github.com/synapticon/sc_sncn_motorcontrol/pull/3.diff","patch_url":"https://github.com/synapticon/sc_sncn_motorcontrol/pull/3.patch","issue_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/3","number":3,"state":"open","locked":false,"title":"Feature fix quickstop","user":{"login":"romu4ld","id":15051135,"avatar_url":"https://avatars1.githubusercontent.com/u/15051135?v=3","gravatar_id":"","url":"https://api.github.com/users/romu4ld","html_url":"https://github.com/romu4ld","followers_url":"https://api.github.com/users/romu4ld/followers","following_url":"https://api.github.com/users/romu4ld/following{/other_user}","gists_url":"https://api.github.com/users/romu4ld/gists{/gist_id}","starred_url":"https://api.github.com/users/romu4ld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romu4ld/subscriptions","organizations_url":"https://api.github.com/users/romu4ld/orgs","repos_url":"https://api.github.com/users/romu4ld/repos","events_url":"https://api.github.com/users/romu4ld/events{/privacy}","received_events_url":"https://api.github.com/users/romu4ld/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-27T08:50:46Z","updated_at":"2017-04-27T10:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"501b67b21113ab2de54acc083066e960ebaad74a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3/commits","review_comments_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3/comments","review_comment_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/3/comments","statuses_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/statuses/49e0e03c957e9c16628236a2c1a7234a2d3af3b5","head":{"label":"synapticon:feature_fix_quickstop","ref":"feature_fix_quickstop","sha":"49e0e03c957e9c16628236a2c1a7234a2d3af3b5","user":{"login":"synapticon","id":2077585,"avatar_url":"https://avatars3.githubusercontent.com/u/2077585?v=3","gravatar_id":"","url":"https://api.github.com/users/synapticon","html_url":"https://github.com/synapticon","followers_url":"https://api.github.com/users/synapticon/followers","following_url":"https://api.github.com/users/synapticon/following{/other_user}","gists_url":"https://api.github.com/users/synapticon/gists{/gist_id}","starred_url":"https://api.github.com/users/synapticon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapticon/subscriptions","organizations_url":"https://api.github.com/users/synapticon/orgs","repos_url":"https://api.github.com/users/synapticon/repos","events_url":"https://api.github.com/users/synapticon/events{/privacy}","received_events_url":"https://api.github.com/users/synapticon/received_events","type":"Organization","site_admin":false},"repo":{"id":15744503,"name":"sc_sncn_motorcontrol","full_name":"synapticon/sc_sncn_motorcontrol","owner":{"login":"synapticon","id":2077585,"avatar_url":"https://avatars3.githubusercontent.com/u/2077585?v=3","gravatar_id":"","url":"https://api.github.com/users/synapticon","html_url":"https://github.com/synapticon","followers_url":"https://api.github.com/users/synapticon/followers","following_url":"https://api.github.com/users/synapticon/following{/other_user}","gists_url":"https://api.github.com/users/synapticon/gists{/gist_id}","starred_url":"https://api.github.com/users/synapticon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapticon/subscriptions","organizations_url":"https://api.github.com/users/synapticon/orgs","repos_url":"https://api.github.com/users/synapticon/repos","events_url":"https://api.github.com/users/synapticon/events{/privacy}","received_events_url":"https://api.github.com/users/synapticon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/synapticon/sc_sncn_motorcontrol","description":"Synapticon SOMANET Motor Control for BLDC and BDC drives. Features Position, Velocity and Torque Control","fork":false,"url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol","forks_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/forks","keys_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/teams","hooks_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/hooks","issue_events_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/events","assignees_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/tags","blobs_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/languages","stargazers_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/stargazers","contributors_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/contributors","subscribers_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/subscribers","subscription_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/subscription","commits_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/merges","archive_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/downloads","issues_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/labels{/name}","releases_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/deployments","created_at":"2014-01-08T18:43:07Z","updated_at":"2017-04-21T14:33:19Z","pushed_at":"2017-04-27T08:50:46Z","git_url":"git://github.com/synapticon/sc_sncn_motorcontrol.git","ssh_url":"git@github.com:synapticon/sc_sncn_motorcontrol.git","clone_url":"https://github.com/synapticon/sc_sncn_motorcontrol.git","svn_url":"https://github.com/synapticon/sc_sncn_motorcontrol","homepage":"","size":28882,"stargazers_count":3,"watchers_count":3,"language":"XC","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"synapticon:release","ref":"release","sha":"9169bc3ae287b9ae88f7942f4679685fe6a55968","user":{"login":"synapticon","id":2077585,"avatar_url":"https://avatars3.githubusercontent.com/u/2077585?v=3","gravatar_id":"","url":"https://api.github.com/users/synapticon","html_url":"https://github.com/synapticon","followers_url":"https://api.github.com/users/synapticon/followers","following_url":"https://api.github.com/users/synapticon/following{/other_user}","gists_url":"https://api.github.com/users/synapticon/gists{/gist_id}","starred_url":"https://api.github.com/users/synapticon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapticon/subscriptions","organizations_url":"https://api.github.com/users/synapticon/orgs","repos_url":"https://api.github.com/users/synapticon/repos","events_url":"https://api.github.com/users/synapticon/events{/privacy}","received_events_url":"https://api.github.com/users/synapticon/received_events","type":"Organization","site_admin":false},"repo":{"id":15744503,"name":"sc_sncn_motorcontrol","full_name":"synapticon/sc_sncn_motorcontrol","owner":{"login":"synapticon","id":2077585,"avatar_url":"https://avatars3.githubusercontent.com/u/2077585?v=3","gravatar_id":"","url":"https://api.github.com/users/synapticon","html_url":"https://github.com/synapticon","followers_url":"https://api.github.com/users/synapticon/followers","following_url":"https://api.github.com/users/synapticon/following{/other_user}","gists_url":"https://api.github.com/users/synapticon/gists{/gist_id}","starred_url":"https://api.github.com/users/synapticon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapticon/subscriptions","organizations_url":"https://api.github.com/users/synapticon/orgs","repos_url":"https://api.github.com/users/synapticon/repos","events_url":"https://api.github.com/users/synapticon/events{/privacy}","received_events_url":"https://api.github.com/users/synapticon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/synapticon/sc_sncn_motorcontrol","description":"Synapticon SOMANET Motor Control for BLDC and BDC drives. Features Position, Velocity and Torque Control","fork":false,"url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol","forks_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/forks","keys_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/teams","hooks_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/hooks","issue_events_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/events","assignees_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/tags","blobs_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/languages","stargazers_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/stargazers","contributors_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/contributors","subscribers_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/subscribers","subscription_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/subscription","commits_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/merges","archive_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/downloads","issues_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/labels{/name}","releases_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/deployments","created_at":"2014-01-08T18:43:07Z","updated_at":"2017-04-21T14:33:19Z","pushed_at":"2017-04-27T08:50:46Z","git_url":"git://github.com/synapticon/sc_sncn_motorcontrol.git","ssh_url":"git@github.com:synapticon/sc_sncn_motorcontrol.git","clone_url":"https://github.com/synapticon/sc_sncn_motorcontrol.git","svn_url":"https://github.com/synapticon/sc_sncn_motorcontrol","homepage":"","size":28882,"stargazers_count":3,"watchers_count":3,"language":"XC","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3"},"html":{"href":"https://github.com/synapticon/sc_sncn_motorcontrol/pull/3"},"issue":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/3"},"comments":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/synapticon/sc_sncn_motorcontrol/statuses/49e0e03c957e9c16628236a2c1a7234a2d3af3b5"}}}}
{"actor":{"display_login":"vtretyakov"}}