{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/128712216","pull_request_review_id":51417391,"id":128712216,"diff_hunk":"@@ -14,7 +14,17 @@ function getClass( elem ) {\n \n jQuery.fn.extend( {\n \taddClass: function( value ) {\n-\t\tvar classes, elem, cur, curValue, clazz, j, finalValue,\n+\t\tvar classes = [];\n+\t\tvar proceed = false;","path":"src/attributes/classes.js","position":6,"original_position":6,"commit_id":"7293a99fe41ea570684d1820447fbacae1a33846","original_commit_id":"7293a99fe41ea570684d1820447fbacae1a33846","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"body":"The `= false` part is not necessary. The same in other methods.","created_at":"2017-07-21T08:43:02Z","updated_at":"2017-07-21T08:46:10Z","html_url":"https://github.com/jquery/jquery/pull/3727#discussion_r128712216","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/3727","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/128712216"},"html":{"href":"https://github.com/jquery/jquery/pull/3727#discussion_r128712216"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3727"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/3727","id":131002468,"html_url":"https://github.com/jquery/jquery/pull/3727","diff_url":"https://github.com/jquery/jquery/pull/3727.diff","patch_url":"https://github.com/jquery/jquery/pull/3727.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/3727","number":3727,"state":"open","locked":false,"title":"added array feature to addClass, removeClass and toggleClass","user":{"login":"faisaliyk","id":12737310,"avatar_url":"https://avatars3.githubusercontent.com/u/12737310?v=4","gravatar_id":"","url":"https://api.github.com/users/faisaliyk","html_url":"https://github.com/faisaliyk","followers_url":"https://api.github.com/users/faisaliyk/followers","following_url":"https://api.github.com/users/faisaliyk/following{/other_user}","gists_url":"https://api.github.com/users/faisaliyk/gists{/gist_id}","starred_url":"https://api.github.com/users/faisaliyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faisaliyk/subscriptions","organizations_url":"https://api.github.com/users/faisaliyk/orgs","repos_url":"https://api.github.com/users/faisaliyk/repos","events_url":"https://api.github.com/users/faisaliyk/events{/privacy}","received_events_url":"https://api.github.com/users/faisaliyk/received_events","type":"User","site_admin":false},"body":"### Summary ###\r\n<!--\r\nDescribe what this PR does. All but trivial changes (e.g. typos)\r\nshould start with an issue. Mention the issue number here.\r\n-->\r\n#3532 \r\n#addClass, removeClass & toggleClass now accepts an array of class names as well as being backward compatible and accepting space separated class names in a single string argument.\r\n\r\n\r\n### Checklist ###\r\n<!--\r\nMark an `[x]` for completed items, if you're not sure leave them unchecked and we can assist.\r\n-->\r\n\r\n* [x] All authors have signed the CLA at https://cla.js.foundation/jquery/jquery\r\n* [x] New tests have been added to show the fix or feature works\r\n* [x] Grunt build and unit tests pass locally with these changes\r\n* [x] If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com\r\n\r\n<!--\r\nThanks! Bots and humans will be around shortly to check it out.\r\n-->\r\n","created_at":"2017-07-18T04:54:42Z","updated_at":"2017-07-21T08:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7a8786528eac3121df1edaf5153605068de6be8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/3727/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/3727/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/3727/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/7293a99fe41ea570684d1820447fbacae1a33846","head":{"label":"faisaliyk:master","ref":"master","sha":"7293a99fe41ea570684d1820447fbacae1a33846","user":{"login":"faisaliyk","id":12737310,"avatar_url":"https://avatars3.githubusercontent.com/u/12737310?v=4","gravatar_id":"","url":"https://api.github.com/users/faisaliyk","html_url":"https://github.com/faisaliyk","followers_url":"https://api.github.com/users/faisaliyk/followers","following_url":"https://api.github.com/users/faisaliyk/following{/other_user}","gists_url":"https://api.github.com/users/faisaliyk/gists{/gist_id}","starred_url":"https://api.github.com/users/faisaliyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faisaliyk/subscriptions","organizations_url":"https://api.github.com/users/faisaliyk/orgs","repos_url":"https://api.github.com/users/faisaliyk/repos","events_url":"https://api.github.com/users/faisaliyk/events{/privacy}","received_events_url":"https://api.github.com/users/faisaliyk/received_events","type":"User","site_admin":false},"repo":{"id":97407852,"name":"jquery","full_name":"faisaliyk/jquery","owner":{"login":"faisaliyk","id":12737310,"avatar_url":"https://avatars3.githubusercontent.com/u/12737310?v=4","gravatar_id":"","url":"https://api.github.com/users/faisaliyk","html_url":"https://github.com/faisaliyk","followers_url":"https://api.github.com/users/faisaliyk/followers","following_url":"https://api.github.com/users/faisaliyk/following{/other_user}","gists_url":"https://api.github.com/users/faisaliyk/gists{/gist_id}","starred_url":"https://api.github.com/users/faisaliyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faisaliyk/subscriptions","organizations_url":"https://api.github.com/users/faisaliyk/orgs","repos_url":"https://api.github.com/users/faisaliyk/repos","events_url":"https://api.github.com/users/faisaliyk/events{/privacy}","received_events_url":"https://api.github.com/users/faisaliyk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faisaliyk/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/faisaliyk/jquery","forks_url":"https://api.github.com/repos/faisaliyk/jquery/forks","keys_url":"https://api.github.com/repos/faisaliyk/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faisaliyk/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faisaliyk/jquery/teams","hooks_url":"https://api.github.com/repos/faisaliyk/jquery/hooks","issue_events_url":"https://api.github.com/repos/faisaliyk/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/faisaliyk/jquery/events","assignees_url":"https://api.github.com/repos/faisaliyk/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/faisaliyk/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/faisaliyk/jquery/tags","blobs_url":"https://api.github.com/repos/faisaliyk/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faisaliyk/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faisaliyk/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/faisaliyk/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faisaliyk/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/faisaliyk/jquery/languages","stargazers_url":"https://api.github.com/repos/faisaliyk/jquery/stargazers","contributors_url":"https://api.github.com/repos/faisaliyk/jquery/contributors","subscribers_url":"https://api.github.com/repos/faisaliyk/jquery/subscribers","subscription_url":"https://api.github.com/repos/faisaliyk/jquery/subscription","commits_url":"https://api.github.com/repos/faisaliyk/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/faisaliyk/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/faisaliyk/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/faisaliyk/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/faisaliyk/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/faisaliyk/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faisaliyk/jquery/merges","archive_url":"https://api.github.com/repos/faisaliyk/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faisaliyk/jquery/downloads","issues_url":"https://api.github.com/repos/faisaliyk/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/faisaliyk/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/faisaliyk/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/faisaliyk/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faisaliyk/jquery/labels{/name}","releases_url":"https://api.github.com/repos/faisaliyk/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/faisaliyk/jquery/deployments","created_at":"2017-07-16T20:01:30Z","updated_at":"2017-07-16T20:01:48Z","pushed_at":"2017-07-20T22:25:04Z","git_url":"git://github.com/faisaliyk/jquery.git","ssh_url":"git@github.com:faisaliyk/jquery.git","clone_url":"https://github.com/faisaliyk/jquery.git","svn_url":"https://github.com/faisaliyk/jquery","homepage":"https://jquery.com/","size":27359,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"3fcddd6e72e7e318c0b062e391d60867732318ae","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars1.githubusercontent.com/u/70142?v=4","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars1.githubusercontent.com/u/70142?v=4","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/jquery/jquery/deployments","created_at":"2009-04-03T15:20:14Z","updated_at":"2017-07-21T08:39:16Z","pushed_at":"2017-07-20T22:25:09Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"https://jquery.com/","size":27438,"stargazers_count":45691,"watchers_count":45691,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":13027,"mirror_url":null,"open_issues_count":85,"forks":13027,"open_issues":85,"watchers":45691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3727"},"html":{"href":"https://github.com/jquery/jquery/pull/3727"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/3727"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/3727/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3727/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3727/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/7293a99fe41ea570684d1820447fbacae1a33846"}}}}
{"actor":{"display_login":"mgol"}}