{"action":"created","issue":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/1970","repository_url":"https://api.github.com/repos/statsmodels/statsmodels","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/1970/labels{/name}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/1970/comments","events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/1970/events","html_url":"https://github.com/statsmodels/statsmodels/issues/1970","id":43295407,"number":1970,"title":"FAQ-D/SUMM: required attributes of models and results","user":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"labels":[{"id":142970,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/comp-base","name":"comp-base","color":"ededed","default":false},{"id":143344,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/design","name":"design","color":"99ffcc","default":false},{"id":84073496,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/FAQ","name":"FAQ","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2014-09-20T00:52:03Z","updated_at":"2017-10-15T17:42:30Z","closed_at":null,"author_association":"OWNER","body":"We don't have a list of what attributes models and results need to define to be able to use generic methods.\r\n\r\nThe requirements are increasing from version to version. These requirements are usually inherited when we go through the regular data handling procedure, but might be left out if a new model follows a different pattern.\r\n\r\neg. we need extra attributes for wald_test (f_test, t_test)\r\n\r\nk_constant\r\nexog_names  (which are params_names in general)\r\ndf_resid, df_model\r\n#632\r\n#436\r\n\r\n**edit** we should collect a checklist\r\n\r\n- recreating a model init_keys, e.g. for llnull, example #3888\r\n- score_obs for sandwiches"},"comment":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments/336728051","html_url":"https://github.com/statsmodels/statsmodels/issues/1970#issuecomment-336728051","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/1970","id":336728051,"user":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"created_at":"2017-10-15T17:42:30Z","updated_at":"2017-10-15T17:42:30Z","author_association":"OWNER","body":"I don't like enforcing things that reduce flexibility.\r\nAlmost every rule is broken by some models, at least during development when the focus is on getting just the minimial functionality implemented correctly.\r\nAlso this is asymmetric, there should be a common subset of attributes, but individual models still need to be able to use model specific attributes.\r\n\r\nThe main question still is about what **should** be in this set of common, required attributes. For which parts are they required and where do we check it. And, do we have defaults that avoid that a developer has to specify everything immediately when getting started.\r\n\r\nNevertheless, we have to see what else goes into the required set, and clean up the code for consistency in what is already in there like df_resid, and whatever aliases for param_names we have.\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"josef-pkt"}}