{"action":"created","comment":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments/121247628","pull_request_review_id":43288380,"id":121247628,"diff_hunk":"@@ -811,9 +811,15 @@ export async function applyTagToAuthor(thisAuthorObj: HTMLAnchorElement, noEdit:\n \t\t);\n \t}\n \n+\tlet tagElement;\n+\tif (module.options.showTaggingIcon.value) {\n+\t\ttagElement = addAuthorTag(thisAuthorObj, noEdit, thisAuthor);\n+\t}\n+\n \tconst tagObject = await getTagBatched(thisAuthor);\n \n-\tif (module.options.showTaggingIcon.value || !_.isEmpty(tagObject)) {\n+\tif (!_.isEmpty(tagObject)) {\n+\t\tif (tagElement && tagElement.parentElement) tagElement.parentElement.removeChild(tagElement);","path":"lib/modules/userTagger.js","position":13,"original_position":13,"commit_id":"1cae139ff7d3dec562c16e62706ddd1bf4d5696b","original_commit_id":"1cae139ff7d3dec562c16e62706ddd1bf4d5696b","user":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars0.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"body":"`if (tagElement) tagElement.remove();`","created_at":"2017-06-10T02:27:03Z","updated_at":"2017-06-10T02:27:03Z","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/4295#discussion_r121247628","pull_request_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295","_links":{"self":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments/121247628"},"html":{"href":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/4295#discussion_r121247628"},"pull_request":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295"}}},"pull_request":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295","id":124973892,"html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/4295","diff_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/4295.diff","patch_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/4295.patch","issue_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/4295","number":4295,"state":"open","locked":false,"title":"Slight change to help speedup user tag loading","user":{"login":"corylulu","id":510057,"avatar_url":"https://avatars0.githubusercontent.com/u/510057?v=3","gravatar_id":"","url":"https://api.github.com/users/corylulu","html_url":"https://github.com/corylulu","followers_url":"https://api.github.com/users/corylulu/followers","following_url":"https://api.github.com/users/corylulu/following{/other_user}","gists_url":"https://api.github.com/users/corylulu/gists{/gist_id}","starred_url":"https://api.github.com/users/corylulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corylulu/subscriptions","organizations_url":"https://api.github.com/users/corylulu/orgs","repos_url":"https://api.github.com/users/corylulu/repos","events_url":"https://api.github.com/users/corylulu/events{/privacy}","received_events_url":"https://api.github.com/users/corylulu/received_events","type":"User","site_admin":false},"body":"The async operation is long and yields empty results far more often than not, so it makes more sense to load the user tag icon by default since adding them in often shifts around the whole page layout, then swapping it out for a tag if it exists.\r\n\r\nThe user tag icon appears anywhere between 500ms - 1500ms faster doing it this way from my tests. Makes the page feel fully loaded much more quickly.\r\n\r\nTested in Chrome 60","created_at":"2017-06-10T01:47:59Z","updated_at":"2017-06-10T02:27:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"456c4a20a79821a4ee72aaba5d87c3be2762d0fa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295/commits","review_comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295/comments","review_comment_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/4295/comments","statuses_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/1cae139ff7d3dec562c16e62706ddd1bf4d5696b","head":{"label":"corylulu:patch-20","ref":"patch-20","sha":"1cae139ff7d3dec562c16e62706ddd1bf4d5696b","user":{"login":"corylulu","id":510057,"avatar_url":"https://avatars0.githubusercontent.com/u/510057?v=3","gravatar_id":"","url":"https://api.github.com/users/corylulu","html_url":"https://github.com/corylulu","followers_url":"https://api.github.com/users/corylulu/followers","following_url":"https://api.github.com/users/corylulu/following{/other_user}","gists_url":"https://api.github.com/users/corylulu/gists{/gist_id}","starred_url":"https://api.github.com/users/corylulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corylulu/subscriptions","organizations_url":"https://api.github.com/users/corylulu/orgs","repos_url":"https://api.github.com/users/corylulu/repos","events_url":"https://api.github.com/users/corylulu/events{/privacy}","received_events_url":"https://api.github.com/users/corylulu/received_events","type":"User","site_admin":false},"repo":{"id":47363784,"name":"Reddit-Enhancement-Suite","full_name":"corylulu/Reddit-Enhancement-Suite","owner":{"login":"corylulu","id":510057,"avatar_url":"https://avatars0.githubusercontent.com/u/510057?v=3","gravatar_id":"","url":"https://api.github.com/users/corylulu","html_url":"https://github.com/corylulu","followers_url":"https://api.github.com/users/corylulu/followers","following_url":"https://api.github.com/users/corylulu/following{/other_user}","gists_url":"https://api.github.com/users/corylulu/gists{/gist_id}","starred_url":"https://api.github.com/users/corylulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corylulu/subscriptions","organizations_url":"https://api.github.com/users/corylulu/orgs","repos_url":"https://api.github.com/users/corylulu/repos","events_url":"https://api.github.com/users/corylulu/events{/privacy}","received_events_url":"https://api.github.com/users/corylulu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/corylulu/Reddit-Enhancement-Suite","description":"Reddit Enhancement Suite","fork":true,"url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite","forks_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/forks","keys_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/teams","hooks_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/hooks","issue_events_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/issues/events{/number}","events_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/events","assignees_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/assignees{/user}","branches_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/branches{/branch}","tags_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/tags","blobs_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/statuses/{sha}","languages_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/languages","stargazers_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/stargazers","contributors_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/contributors","subscribers_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/subscribers","subscription_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/subscription","commits_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/contents/{+path}","compare_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/merges","archive_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/downloads","issues_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/issues{/number}","pulls_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/pulls{/number}","milestones_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/milestones{/number}","notifications_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/labels{/name}","releases_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/releases{/id}","deployments_url":"https://api.github.com/repos/corylulu/Reddit-Enhancement-Suite/deployments","created_at":"2015-12-03T22:06:21Z","updated_at":"2017-01-20T03:19:48Z","pushed_at":"2017-06-10T02:04:33Z","git_url":"git://github.com/corylulu/Reddit-Enhancement-Suite.git","ssh_url":"git@github.com:corylulu/Reddit-Enhancement-Suite.git","clone_url":"https://github.com/corylulu/Reddit-Enhancement-Suite.git","svn_url":"https://github.com/corylulu/Reddit-Enhancement-Suite","homepage":"http://redditenhancementsuite.com","size":28035,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"honestbleeps:master","ref":"master","sha":"159e4e08c32f649e66f252d56df973ab71bfdd11","user":{"login":"honestbleeps","id":323763,"avatar_url":"https://avatars1.githubusercontent.com/u/323763?v=3","gravatar_id":"","url":"https://api.github.com/users/honestbleeps","html_url":"https://github.com/honestbleeps","followers_url":"https://api.github.com/users/honestbleeps/followers","following_url":"https://api.github.com/users/honestbleeps/following{/other_user}","gists_url":"https://api.github.com/users/honestbleeps/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbleeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbleeps/subscriptions","organizations_url":"https://api.github.com/users/honestbleeps/orgs","repos_url":"https://api.github.com/users/honestbleeps/repos","events_url":"https://api.github.com/users/honestbleeps/events{/privacy}","received_events_url":"https://api.github.com/users/honestbleeps/received_events","type":"User","site_admin":false},"repo":{"id":2688907,"name":"Reddit-Enhancement-Suite","full_name":"honestbleeps/Reddit-Enhancement-Suite","owner":{"login":"honestbleeps","id":323763,"avatar_url":"https://avatars1.githubusercontent.com/u/323763?v=3","gravatar_id":"","url":"https://api.github.com/users/honestbleeps","html_url":"https://github.com/honestbleeps","followers_url":"https://api.github.com/users/honestbleeps/followers","following_url":"https://api.github.com/users/honestbleeps/following{/other_user}","gists_url":"https://api.github.com/users/honestbleeps/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbleeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbleeps/subscriptions","organizations_url":"https://api.github.com/users/honestbleeps/orgs","repos_url":"https://api.github.com/users/honestbleeps/repos","events_url":"https://api.github.com/users/honestbleeps/events{/privacy}","received_events_url":"https://api.github.com/users/honestbleeps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite","description":"Reddit Enhancement Suite","fork":false,"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite","forks_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/forks","keys_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/teams","hooks_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/hooks","issue_events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/events{/number}","events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/events","assignees_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/assignees{/user}","branches_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/branches{/branch}","tags_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/tags","blobs_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/{sha}","languages_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/languages","stargazers_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/stargazers","contributors_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/contributors","subscribers_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/subscribers","subscription_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/subscription","commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/contents/{+path}","compare_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/merges","archive_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/downloads","issues_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues{/number}","pulls_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls{/number}","milestones_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/milestones{/number}","notifications_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/labels{/name}","releases_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/releases{/id}","deployments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/deployments","created_at":"2011-11-01T16:31:51Z","updated_at":"2017-06-09T02:30:30Z","pushed_at":"2017-06-10T02:04:34Z","git_url":"git://github.com/honestbleeps/Reddit-Enhancement-Suite.git","ssh_url":"git@github.com:honestbleeps/Reddit-Enhancement-Suite.git","clone_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite.git","svn_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite","homepage":"http://redditenhancementsuite.com","size":28567,"stargazers_count":1830,"watchers_count":1830,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":607,"mirror_url":null,"open_issues_count":520,"forks":607,"open_issues":520,"watchers":1830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295"},"html":{"href":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/4295"},"issue":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/4295"},"comments":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/4295/comments"},"review_comments":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295/comments"},"review_comment":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/4295/commits"},"statuses":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/1cae139ff7d3dec562c16e62706ddd1bf4d5696b"}}}}
{"actor":{"display_login":"erikdesjardins"}}