{"action":"created","issue":{"url":"https://api.github.com/repos/zotero/translators/issues/1225","repository_url":"https://api.github.com/repos/zotero/translators","labels_url":"https://api.github.com/repos/zotero/translators/issues/1225/labels{/name}","comments_url":"https://api.github.com/repos/zotero/translators/issues/1225/comments","events_url":"https://api.github.com/repos/zotero/translators/issues/1225/events","html_url":"https://github.com/zotero/translators/pull/1225","id":200827512,"number":1225,"title":"Travis (completely rewrite with help by @kba)","user":{"login":"zuphilip","id":5199995,"avatar_url":"https://avatars.githubusercontent.com/u/5199995?v=3","gravatar_id":"","url":"https://api.github.com/users/zuphilip","html_url":"https://github.com/zuphilip","followers_url":"https://api.github.com/users/zuphilip/followers","following_url":"https://api.github.com/users/zuphilip/following{/other_user}","gists_url":"https://api.github.com/users/zuphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/zuphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuphilip/subscriptions","organizations_url":"https://api.github.com/users/zuphilip/orgs","repos_url":"https://api.github.com/users/zuphilip/repos","events_url":"https://api.github.com/users/zuphilip/events{/privacy}","received_events_url":"https://api.github.com/users/zuphilip/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-14T20:27:00Z","updated_at":"2017-01-14T21:53:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zotero/translators/pulls/1225","html_url":"https://github.com/zotero/translators/pull/1225","diff_url":"https://github.com/zotero/translators/pull/1225.diff","patch_url":"https://github.com/zotero/translators/pull/1225.patch"},"body":"I got some help by @kba who improved the script greatly and the whole code organization. I think the improvements and reorganizations by @kba are phantastic and I am very grateful! 🙇  \r\n\r\nAll tests should work fine and they can also be used locally, see [README.md](https://github.com/zuphilip/translators/blob/ad7a087af3b8f2b14d2b78179e1690a545376926/.ci/README.md):\r\n\r\n![test-locally](https://cloud.githubusercontent.com/assets/5199995/21957610/5246a03c-da9a-11e6-9e75-e5848177bf28.png)\r\n\r\nTravis test result of this PR where everything is okay: https://travis-ci.org/zuphilip/translators/builds/191975484 \r\n\r\nTravis test result for a PR with some errors: https://travis-ci.org/zuphilip/translators/builds/191976661 \r\n\r\nThis skips any tests for deleted files, but hopefully we can add something for them later (in another PR).\r\n\r\n(This is a continuation of #1156.)"},"comment":{"url":"https://api.github.com/repos/zotero/translators/issues/comments/272656001","html_url":"https://github.com/zotero/translators/pull/1225#issuecomment-272656001","issue_url":"https://api.github.com/repos/zotero/translators/issues/1225","id":272656001,"user":{"login":"zuphilip","id":5199995,"avatar_url":"https://avatars.githubusercontent.com/u/5199995?v=3","gravatar_id":"","url":"https://api.github.com/users/zuphilip","html_url":"https://github.com/zuphilip","followers_url":"https://api.github.com/users/zuphilip/followers","following_url":"https://api.github.com/users/zuphilip/following{/other_user}","gists_url":"https://api.github.com/users/zuphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/zuphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuphilip/subscriptions","organizations_url":"https://api.github.com/users/zuphilip/orgs","repos_url":"https://api.github.com/users/zuphilip/repos","events_url":"https://api.github.com/users/zuphilip/events{/privacy}","received_events_url":"https://api.github.com/users/zuphilip/received_events","type":"User","site_admin":false},"created_at":"2017-01-14T21:53:51Z","updated_at":"2017-01-14T21:53:51Z","body":"> Are we able to turn off some of the JSHint warnings?\r\n\r\nJSHint warnings are already off for `npm test` and the travis tests. It is also possible to turn them off by setting `export SKIP_WARN=true` before running the script manually:\r\n\r\n![test-locally-wo](https://cloud.githubusercontent.com/assets/5199995/21958320/0f8f1442-daac-11e6-93f2-f61a88a8c0f6.png)\r\n\r\nMoreover, there is also a large amount of options of JSHint we can try out: http://jshint.com/docs/options/ . I haven't looked at these options so far."}}
{"actor":{"display_login":"zuphilip"}}