{"action":"created","comment":{"url":"https://api.github.com/repos/evernym/plenum/pulls/comments/111853579","pull_request_review_id":33124268,"id":111853579,"diff_hunk":"@@ -1252,60 +1275,122 @@ def postToClientInBox(self, msg, frm):\n             except InvalidClientMessageException as ex:\n                 self.handleInvalidClientMsg(ex, m)\n \n-    def postPoolLedgerCaughtUp(self):\n+    def postPoolLedgerCaughtUp(self, **kwargs):\n         self.mode = Mode.discovered\n-        self.ledgerManager.setLedgerCanSync(1, True)\n+        self.ledgerManager.setLedgerCanSync(DOMAIN_LEDGER_ID, True)\n         # Node has discovered other nodes now sync up domain ledger\n         for nm in self.nodestack.connecteds:\n             self.sendDomainLedgerStatus(nm)\n-        self.ledgerManager.processStashedLedgerStatuses(1)\n+        self.ledgerManager.processStashedLedgerStatuses(DOMAIN_LEDGER_ID)\n         if isinstance(self.poolManager, TxnPoolManager):\n             self.checkInstances()\n         # Initialising node id in case where node's information was not present\n         # in pool ledger at the time of starting, happens when a non-genesis\n         # node starts\n         self.id\n \n-    def postDomainLedgerCaughtUp(self):\n+    def postDomainLedgerCaughtUp(self, **kwargs):\n         \"\"\"\n         Process any stashed ordered requests and set the mode to\n         `participating`\n         :return:\n         \"\"\"\n-        self.processStashedOrderedReqs()","path":"plenum/server/node.py","position":555,"original_position":555,"commit_id":"55d15ce41ea41689067ef7c7f0c5f4bcfe5d41f2","original_commit_id":"55d15ce41ea41689067ef7c7f0c5f4bcfe5d41f2","user":{"login":"ashcherbakov","id":21102430,"avatar_url":"https://avatars2.githubusercontent.com/u/21102430?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcherbakov","html_url":"https://github.com/ashcherbakov","followers_url":"https://api.github.com/users/ashcherbakov/followers","following_url":"https://api.github.com/users/ashcherbakov/following{/other_user}","gists_url":"https://api.github.com/users/ashcherbakov/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcherbakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcherbakov/subscriptions","organizations_url":"https://api.github.com/users/ashcherbakov/orgs","repos_url":"https://api.github.com/users/ashcherbakov/repos","events_url":"https://api.github.com/users/ashcherbakov/events{/privacy}","received_events_url":"https://api.github.com/users/ashcherbakov/received_events","type":"User","site_admin":false},"body":"Why did we remove this?","created_at":"2017-04-18T01:07:19Z","updated_at":"2017-04-18T01:07:19Z","html_url":"https://github.com/evernym/plenum/pull/125#discussion_r111853579","pull_request_url":"https://api.github.com/repos/evernym/plenum/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/evernym/plenum/pulls/comments/111853579"},"html":{"href":"https://github.com/evernym/plenum/pull/125#discussion_r111853579"},"pull_request":{"href":"https://api.github.com/repos/evernym/plenum/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/evernym/plenum/pulls/125","id":115988738,"html_url":"https://github.com/evernym/plenum/pull/125","diff_url":"https://github.com/evernym/plenum/pull/125.diff","patch_url":"https://github.com/evernym/plenum/pull/125.patch","issue_url":"https://api.github.com/repos/evernym/plenum/issues/125","number":125,"state":"open","locked":false,"title":"3pc batch","user":{"login":"lovesh","id":3115401,"avatar_url":"https://avatars3.githubusercontent.com/u/3115401?v=3","gravatar_id":"","url":"https://api.github.com/users/lovesh","html_url":"https://github.com/lovesh","followers_url":"https://api.github.com/users/lovesh/followers","following_url":"https://api.github.com/users/lovesh/following{/other_user}","gists_url":"https://api.github.com/users/lovesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lovesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovesh/subscriptions","organizations_url":"https://api.github.com/users/lovesh/orgs","repos_url":"https://api.github.com/users/lovesh/repos","events_url":"https://api.github.com/users/lovesh/events{/privacy}","received_events_url":"https://api.github.com/users/lovesh/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-14T20:57:56Z","updated_at":"2017-04-18T01:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5431413acd27b5d23d4221789b85609a5d0bb63e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/evernym/plenum/pulls/125/commits","review_comments_url":"https://api.github.com/repos/evernym/plenum/pulls/125/comments","review_comment_url":"https://api.github.com/repos/evernym/plenum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evernym/plenum/issues/125/comments","statuses_url":"https://api.github.com/repos/evernym/plenum/statuses/55d15ce41ea41689067ef7c7f0c5f4bcfe5d41f2","head":{"label":"evernym:3pc-batch","ref":"3pc-batch","sha":"55d15ce41ea41689067ef7c7f0c5f4bcfe5d41f2","user":{"login":"evernym","id":10112210,"avatar_url":"https://avatars0.githubusercontent.com/u/10112210?v=3","gravatar_id":"","url":"https://api.github.com/users/evernym","html_url":"https://github.com/evernym","followers_url":"https://api.github.com/users/evernym/followers","following_url":"https://api.github.com/users/evernym/following{/other_user}","gists_url":"https://api.github.com/users/evernym/gists{/gist_id}","starred_url":"https://api.github.com/users/evernym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evernym/subscriptions","organizations_url":"https://api.github.com/users/evernym/orgs","repos_url":"https://api.github.com/users/evernym/repos","events_url":"https://api.github.com/users/evernym/events{/privacy}","received_events_url":"https://api.github.com/users/evernym/received_events","type":"Organization","site_admin":false},"repo":{"id":51585028,"name":"plenum","full_name":"evernym/plenum","owner":{"login":"evernym","id":10112210,"avatar_url":"https://avatars0.githubusercontent.com/u/10112210?v=3","gravatar_id":"","url":"https://api.github.com/users/evernym","html_url":"https://github.com/evernym","followers_url":"https://api.github.com/users/evernym/followers","following_url":"https://api.github.com/users/evernym/following{/other_user}","gists_url":"https://api.github.com/users/evernym/gists{/gist_id}","starred_url":"https://api.github.com/users/evernym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evernym/subscriptions","organizations_url":"https://api.github.com/users/evernym/orgs","repos_url":"https://api.github.com/users/evernym/repos","events_url":"https://api.github.com/users/evernym/events{/privacy}","received_events_url":"https://api.github.com/users/evernym/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evernym/plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":false,"url":"https://api.github.com/repos/evernym/plenum","forks_url":"https://api.github.com/repos/evernym/plenum/forks","keys_url":"https://api.github.com/repos/evernym/plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evernym/plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evernym/plenum/teams","hooks_url":"https://api.github.com/repos/evernym/plenum/hooks","issue_events_url":"https://api.github.com/repos/evernym/plenum/issues/events{/number}","events_url":"https://api.github.com/repos/evernym/plenum/events","assignees_url":"https://api.github.com/repos/evernym/plenum/assignees{/user}","branches_url":"https://api.github.com/repos/evernym/plenum/branches{/branch}","tags_url":"https://api.github.com/repos/evernym/plenum/tags","blobs_url":"https://api.github.com/repos/evernym/plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evernym/plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evernym/plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/evernym/plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evernym/plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/evernym/plenum/languages","stargazers_url":"https://api.github.com/repos/evernym/plenum/stargazers","contributors_url":"https://api.github.com/repos/evernym/plenum/contributors","subscribers_url":"https://api.github.com/repos/evernym/plenum/subscribers","subscription_url":"https://api.github.com/repos/evernym/plenum/subscription","commits_url":"https://api.github.com/repos/evernym/plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/evernym/plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/evernym/plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/evernym/plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/evernym/plenum/contents/{+path}","compare_url":"https://api.github.com/repos/evernym/plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evernym/plenum/merges","archive_url":"https://api.github.com/repos/evernym/plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evernym/plenum/downloads","issues_url":"https://api.github.com/repos/evernym/plenum/issues{/number}","pulls_url":"https://api.github.com/repos/evernym/plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/evernym/plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/evernym/plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evernym/plenum/labels{/name}","releases_url":"https://api.github.com/repos/evernym/plenum/releases{/id}","deployments_url":"https://api.github.com/repos/evernym/plenum/deployments","created_at":"2016-02-12T12:03:16Z","updated_at":"2017-02-16T11:45:18Z","pushed_at":"2017-04-17T22:54:40Z","git_url":"git://github.com/evernym/plenum.git","ssh_url":"git@github.com:evernym/plenum.git","clone_url":"https://github.com/evernym/plenum.git","svn_url":"https://github.com/evernym/plenum","homepage":"","size":3397,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":4,"forks":28,"open_issues":4,"watchers":53,"default_branch":"master"}},"base":{"label":"evernym:master","ref":"master","sha":"fbf7402d274f4d8fe65e45d0c7971dcd314539cb","user":{"login":"evernym","id":10112210,"avatar_url":"https://avatars0.githubusercontent.com/u/10112210?v=3","gravatar_id":"","url":"https://api.github.com/users/evernym","html_url":"https://github.com/evernym","followers_url":"https://api.github.com/users/evernym/followers","following_url":"https://api.github.com/users/evernym/following{/other_user}","gists_url":"https://api.github.com/users/evernym/gists{/gist_id}","starred_url":"https://api.github.com/users/evernym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evernym/subscriptions","organizations_url":"https://api.github.com/users/evernym/orgs","repos_url":"https://api.github.com/users/evernym/repos","events_url":"https://api.github.com/users/evernym/events{/privacy}","received_events_url":"https://api.github.com/users/evernym/received_events","type":"Organization","site_admin":false},"repo":{"id":51585028,"name":"plenum","full_name":"evernym/plenum","owner":{"login":"evernym","id":10112210,"avatar_url":"https://avatars0.githubusercontent.com/u/10112210?v=3","gravatar_id":"","url":"https://api.github.com/users/evernym","html_url":"https://github.com/evernym","followers_url":"https://api.github.com/users/evernym/followers","following_url":"https://api.github.com/users/evernym/following{/other_user}","gists_url":"https://api.github.com/users/evernym/gists{/gist_id}","starred_url":"https://api.github.com/users/evernym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evernym/subscriptions","organizations_url":"https://api.github.com/users/evernym/orgs","repos_url":"https://api.github.com/users/evernym/repos","events_url":"https://api.github.com/users/evernym/events{/privacy}","received_events_url":"https://api.github.com/users/evernym/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evernym/plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":false,"url":"https://api.github.com/repos/evernym/plenum","forks_url":"https://api.github.com/repos/evernym/plenum/forks","keys_url":"https://api.github.com/repos/evernym/plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evernym/plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evernym/plenum/teams","hooks_url":"https://api.github.com/repos/evernym/plenum/hooks","issue_events_url":"https://api.github.com/repos/evernym/plenum/issues/events{/number}","events_url":"https://api.github.com/repos/evernym/plenum/events","assignees_url":"https://api.github.com/repos/evernym/plenum/assignees{/user}","branches_url":"https://api.github.com/repos/evernym/plenum/branches{/branch}","tags_url":"https://api.github.com/repos/evernym/plenum/tags","blobs_url":"https://api.github.com/repos/evernym/plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evernym/plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evernym/plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/evernym/plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evernym/plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/evernym/plenum/languages","stargazers_url":"https://api.github.com/repos/evernym/plenum/stargazers","contributors_url":"https://api.github.com/repos/evernym/plenum/contributors","subscribers_url":"https://api.github.com/repos/evernym/plenum/subscribers","subscription_url":"https://api.github.com/repos/evernym/plenum/subscription","commits_url":"https://api.github.com/repos/evernym/plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/evernym/plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/evernym/plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/evernym/plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/evernym/plenum/contents/{+path}","compare_url":"https://api.github.com/repos/evernym/plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evernym/plenum/merges","archive_url":"https://api.github.com/repos/evernym/plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evernym/plenum/downloads","issues_url":"https://api.github.com/repos/evernym/plenum/issues{/number}","pulls_url":"https://api.github.com/repos/evernym/plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/evernym/plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/evernym/plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evernym/plenum/labels{/name}","releases_url":"https://api.github.com/repos/evernym/plenum/releases{/id}","deployments_url":"https://api.github.com/repos/evernym/plenum/deployments","created_at":"2016-02-12T12:03:16Z","updated_at":"2017-02-16T11:45:18Z","pushed_at":"2017-04-17T22:54:40Z","git_url":"git://github.com/evernym/plenum.git","ssh_url":"git@github.com:evernym/plenum.git","clone_url":"https://github.com/evernym/plenum.git","svn_url":"https://github.com/evernym/plenum","homepage":"","size":3397,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":4,"forks":28,"open_issues":4,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evernym/plenum/pulls/125"},"html":{"href":"https://github.com/evernym/plenum/pull/125"},"issue":{"href":"https://api.github.com/repos/evernym/plenum/issues/125"},"comments":{"href":"https://api.github.com/repos/evernym/plenum/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/evernym/plenum/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/evernym/plenum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evernym/plenum/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/evernym/plenum/statuses/55d15ce41ea41689067ef7c7f0c5f4bcfe5d41f2"}}}}
{"actor":{"display_login":"ashcherbakov"}}