{"action":"created","comment":{"url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/comments/115018298","pull_request_review_id":36530585,"id":115018298,"diff_hunk":"@@ -4,7 +4,26 @@\n   'use strict'\n \n   // Constructor\n-  function MenuButton (button) {\n+  function MenuButton (button, userSettings) {\n+    // Error if the userSettings argument isn't an object\n+    if (userSettings !== undefined && typeof userSettings !== 'object') {\n+      throw new Error('MenuButton\\'s second argument is expected as an object or undefined')","path":"inclusive-menu-button.js","position":8,"original_position":8,"commit_id":"28b73037903ed96c25114e271b8156af0a0d8586","original_commit_id":"28b73037903ed96c25114e271b8156af0a0d8586","user":{"login":"HugoGiraudel","id":1889710,"avatar_url":"https://avatars0.githubusercontent.com/u/1889710?v=3","gravatar_id":"","url":"https://api.github.com/users/HugoGiraudel","html_url":"https://github.com/HugoGiraudel","followers_url":"https://api.github.com/users/HugoGiraudel/followers","following_url":"https://api.github.com/users/HugoGiraudel/following{/other_user}","gists_url":"https://api.github.com/users/HugoGiraudel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoGiraudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoGiraudel/subscriptions","organizations_url":"https://api.github.com/users/HugoGiraudel/orgs","repos_url":"https://api.github.com/users/HugoGiraudel/repos","events_url":"https://api.github.com/users/HugoGiraudel/events{/privacy}","received_events_url":"https://api.github.com/users/HugoGiraudel/received_events","type":"User","site_admin":false},"body":"You could (should?) use a curly quote to avoid handing to escape.","created_at":"2017-05-05T15:04:18Z","updated_at":"2017-05-05T15:10:44Z","html_url":"https://github.com/Heydon/inclusive-menu-button/pull/36#discussion_r115018298","pull_request_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/comments/115018298"},"html":{"href":"https://github.com/Heydon/inclusive-menu-button/pull/36#discussion_r115018298"},"pull_request":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36","id":119193145,"html_url":"https://github.com/Heydon/inclusive-menu-button/pull/36","diff_url":"https://github.com/Heydon/inclusive-menu-button/pull/36.diff","patch_url":"https://github.com/Heydon/inclusive-menu-button/pull/36.patch","issue_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/36","number":36,"state":"open","locked":false,"title":"Settings object for menuitemradio mode","user":{"login":"Heydon","id":683558,"avatar_url":"https://avatars1.githubusercontent.com/u/683558?v=3","gravatar_id":"","url":"https://api.github.com/users/Heydon","html_url":"https://github.com/Heydon","followers_url":"https://api.github.com/users/Heydon/followers","following_url":"https://api.github.com/users/Heydon/following{/other_user}","gists_url":"https://api.github.com/users/Heydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Heydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heydon/subscriptions","organizations_url":"https://api.github.com/users/Heydon/orgs","repos_url":"https://api.github.com/users/Heydon/repos","events_url":"https://api.github.com/users/Heydon/events{/privacy}","received_events_url":"https://api.github.com/users/Heydon/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-05T14:53:17Z","updated_at":"2017-05-05T15:10:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48d6df590d60864ffacca992d3f3194e9aadb61d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36/commits","review_comments_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36/comments","review_comment_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/36/comments","statuses_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/statuses/28b73037903ed96c25114e271b8156af0a0d8586","head":{"label":"Heydon:radio-items","ref":"radio-items","sha":"28b73037903ed96c25114e271b8156af0a0d8586","user":{"login":"Heydon","id":683558,"avatar_url":"https://avatars1.githubusercontent.com/u/683558?v=3","gravatar_id":"","url":"https://api.github.com/users/Heydon","html_url":"https://github.com/Heydon","followers_url":"https://api.github.com/users/Heydon/followers","following_url":"https://api.github.com/users/Heydon/following{/other_user}","gists_url":"https://api.github.com/users/Heydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Heydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heydon/subscriptions","organizations_url":"https://api.github.com/users/Heydon/orgs","repos_url":"https://api.github.com/users/Heydon/repos","events_url":"https://api.github.com/users/Heydon/events{/privacy}","received_events_url":"https://api.github.com/users/Heydon/received_events","type":"User","site_admin":false},"repo":{"id":89137524,"name":"inclusive-menu-button","full_name":"Heydon/inclusive-menu-button","owner":{"login":"Heydon","id":683558,"avatar_url":"https://avatars1.githubusercontent.com/u/683558?v=3","gravatar_id":"","url":"https://api.github.com/users/Heydon","html_url":"https://github.com/Heydon","followers_url":"https://api.github.com/users/Heydon/followers","following_url":"https://api.github.com/users/Heydon/following{/other_user}","gists_url":"https://api.github.com/users/Heydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Heydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heydon/subscriptions","organizations_url":"https://api.github.com/users/Heydon/orgs","repos_url":"https://api.github.com/users/Heydon/repos","events_url":"https://api.github.com/users/Heydon/events{/privacy}","received_events_url":"https://api.github.com/users/Heydon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Heydon/inclusive-menu-button","description":"A keyboard and screen reader accessible ARIA menu button implementation.","fork":false,"url":"https://api.github.com/repos/Heydon/inclusive-menu-button","forks_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/forks","keys_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/teams","hooks_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/hooks","issue_events_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/events{/number}","events_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/events","assignees_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/assignees{/user}","branches_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/branches{/branch}","tags_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/tags","blobs_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/statuses/{sha}","languages_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/languages","stargazers_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/stargazers","contributors_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/contributors","subscribers_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/subscribers","subscription_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/subscription","commits_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/comments{/number}","contents_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/contents/{+path}","compare_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/merges","archive_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/downloads","issues_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues{/number}","pulls_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls{/number}","milestones_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/milestones{/number}","notifications_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/labels{/name}","releases_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/releases{/id}","deployments_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/deployments","created_at":"2017-04-23T11:41:09Z","updated_at":"2017-05-03T01:33:04Z","pushed_at":"2017-05-05T14:53:18Z","git_url":"git://github.com/Heydon/inclusive-menu-button.git","ssh_url":"git@github.com:Heydon/inclusive-menu-button.git","clone_url":"https://github.com/Heydon/inclusive-menu-button.git","svn_url":"https://github.com/Heydon/inclusive-menu-button","homepage":null,"size":39,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":23,"default_branch":"master"}},"base":{"label":"Heydon:master","ref":"master","sha":"98832d4bcc38253449d72f8ec1a865f577be0303","user":{"login":"Heydon","id":683558,"avatar_url":"https://avatars1.githubusercontent.com/u/683558?v=3","gravatar_id":"","url":"https://api.github.com/users/Heydon","html_url":"https://github.com/Heydon","followers_url":"https://api.github.com/users/Heydon/followers","following_url":"https://api.github.com/users/Heydon/following{/other_user}","gists_url":"https://api.github.com/users/Heydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Heydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heydon/subscriptions","organizations_url":"https://api.github.com/users/Heydon/orgs","repos_url":"https://api.github.com/users/Heydon/repos","events_url":"https://api.github.com/users/Heydon/events{/privacy}","received_events_url":"https://api.github.com/users/Heydon/received_events","type":"User","site_admin":false},"repo":{"id":89137524,"name":"inclusive-menu-button","full_name":"Heydon/inclusive-menu-button","owner":{"login":"Heydon","id":683558,"avatar_url":"https://avatars1.githubusercontent.com/u/683558?v=3","gravatar_id":"","url":"https://api.github.com/users/Heydon","html_url":"https://github.com/Heydon","followers_url":"https://api.github.com/users/Heydon/followers","following_url":"https://api.github.com/users/Heydon/following{/other_user}","gists_url":"https://api.github.com/users/Heydon/gists{/gist_id}","starred_url":"https://api.github.com/users/Heydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heydon/subscriptions","organizations_url":"https://api.github.com/users/Heydon/orgs","repos_url":"https://api.github.com/users/Heydon/repos","events_url":"https://api.github.com/users/Heydon/events{/privacy}","received_events_url":"https://api.github.com/users/Heydon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Heydon/inclusive-menu-button","description":"A keyboard and screen reader accessible ARIA menu button implementation.","fork":false,"url":"https://api.github.com/repos/Heydon/inclusive-menu-button","forks_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/forks","keys_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/teams","hooks_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/hooks","issue_events_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/events{/number}","events_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/events","assignees_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/assignees{/user}","branches_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/branches{/branch}","tags_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/tags","blobs_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/statuses/{sha}","languages_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/languages","stargazers_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/stargazers","contributors_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/contributors","subscribers_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/subscribers","subscription_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/subscription","commits_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/comments{/number}","contents_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/contents/{+path}","compare_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/merges","archive_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/downloads","issues_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues{/number}","pulls_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls{/number}","milestones_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/milestones{/number}","notifications_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/labels{/name}","releases_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/releases{/id}","deployments_url":"https://api.github.com/repos/Heydon/inclusive-menu-button/deployments","created_at":"2017-04-23T11:41:09Z","updated_at":"2017-05-03T01:33:04Z","pushed_at":"2017-05-05T14:53:18Z","git_url":"git://github.com/Heydon/inclusive-menu-button.git","ssh_url":"git@github.com:Heydon/inclusive-menu-button.git","clone_url":"https://github.com/Heydon/inclusive-menu-button.git","svn_url":"https://github.com/Heydon/inclusive-menu-button","homepage":null,"size":39,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36"},"html":{"href":"https://github.com/Heydon/inclusive-menu-button/pull/36"},"issue":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/36"},"comments":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/Heydon/inclusive-menu-button/statuses/28b73037903ed96c25114e271b8156af0a0d8586"}}}}
{"actor":{"display_login":"HugoGiraudel"}}