{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/125004638","pull_request_review_id":47351573,"id":125004638,"diff_hunk":"@@ -70,6 +74,8 @@ func NewFraktiManager(\n \tstreamingServer streaming.Server,\n \tprivilegedRuntimeService runtime.RuntimeService,\n \tprivilegedImageService runtime.ImageService,\n+\tunikernelRuntimeService runtime.RuntimeService,\n+\tunikernelImageService runtime.ImageService,","path":"pkg/manager/manager.go","position":23,"original_position":23,"commit_id":"17d39db51926c40d46d9e154241b24f4693062f2","original_commit_id":"17d39db51926c40d46d9e154241b24f4693062f2","user":{"login":"Crazykev","id":7436779,"avatar_url":"https://avatars0.githubusercontent.com/u/7436779?v=3","gravatar_id":"","url":"https://api.github.com/users/Crazykev","html_url":"https://github.com/Crazykev","followers_url":"https://api.github.com/users/Crazykev/followers","following_url":"https://api.github.com/users/Crazykev/following{/other_user}","gists_url":"https://api.github.com/users/Crazykev/gists{/gist_id}","starred_url":"https://api.github.com/users/Crazykev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crazykev/subscriptions","organizations_url":"https://api.github.com/users/Crazykev/orgs","repos_url":"https://api.github.com/users/Crazykev/repos","events_url":"https://api.github.com/users/Crazykev/events{/privacy}","received_events_url":"https://api.github.com/users/Crazykev/received_events","type":"User","site_admin":false},"body":"em...That looks better if we add more runtime. How can we decide which is unikernelRuntime or other extra runtimes and assign to corresponding field in `FraktiManager`?","created_at":"2017-06-30T09:55:45Z","updated_at":"2017-06-30T09:55:45Z","html_url":"https://github.com/kubernetes/frakti/pull/180#discussion_r125004638","pull_request_url":"https://api.github.com/repos/kubernetes/frakti/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/125004638"},"html":{"href":"https://github.com/kubernetes/frakti/pull/180#discussion_r125004638"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/180","id":127628335,"html_url":"https://github.com/kubernetes/frakti/pull/180","diff_url":"https://github.com/kubernetes/frakti/pull/180.diff","patch_url":"https://github.com/kubernetes/frakti/pull/180.patch","issue_url":"https://api.github.com/repos/kubernetes/frakti/issues/180","number":180,"state":"open","locked":false,"title":"Add basic skeleton of unikernel runtime","user":{"login":"Crazykev","id":7436779,"avatar_url":"https://avatars0.githubusercontent.com/u/7436779?v=3","gravatar_id":"","url":"https://api.github.com/users/Crazykev","html_url":"https://github.com/Crazykev","followers_url":"https://api.github.com/users/Crazykev/followers","following_url":"https://api.github.com/users/Crazykev/following{/other_user}","gists_url":"https://api.github.com/users/Crazykev/gists{/gist_id}","starred_url":"https://api.github.com/users/Crazykev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crazykev/subscriptions","organizations_url":"https://api.github.com/users/Crazykev/orgs","repos_url":"https://api.github.com/users/Crazykev/repos","events_url":"https://api.github.com/users/Crazykev/events{/privacy}","received_events_url":"https://api.github.com/users/Crazykev/received_events","type":"User","site_admin":false},"body":"relay on #178 , ref #181 ","created_at":"2017-06-27T07:31:35Z","updated_at":"2017-06-30T09:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e9dd73f4257c980235e0792f92c7d7f223b72a0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/frakti/pulls/180/commits","review_comments_url":"https://api.github.com/repos/kubernetes/frakti/pulls/180/comments","review_comment_url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/frakti/issues/180/comments","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/17d39db51926c40d46d9e154241b24f4693062f2","head":{"label":"Crazykev:unikshim-1","ref":"unikshim-1","sha":"17d39db51926c40d46d9e154241b24f4693062f2","user":{"login":"Crazykev","id":7436779,"avatar_url":"https://avatars0.githubusercontent.com/u/7436779?v=3","gravatar_id":"","url":"https://api.github.com/users/Crazykev","html_url":"https://github.com/Crazykev","followers_url":"https://api.github.com/users/Crazykev/followers","following_url":"https://api.github.com/users/Crazykev/following{/other_user}","gists_url":"https://api.github.com/users/Crazykev/gists{/gist_id}","starred_url":"https://api.github.com/users/Crazykev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crazykev/subscriptions","organizations_url":"https://api.github.com/users/Crazykev/orgs","repos_url":"https://api.github.com/users/Crazykev/repos","events_url":"https://api.github.com/users/Crazykev/events{/privacy}","received_events_url":"https://api.github.com/users/Crazykev/received_events","type":"User","site_admin":false},"repo":{"id":66491571,"name":"frakti","full_name":"Crazykev/frakti","owner":{"login":"Crazykev","id":7436779,"avatar_url":"https://avatars0.githubusercontent.com/u/7436779?v=3","gravatar_id":"","url":"https://api.github.com/users/Crazykev","html_url":"https://github.com/Crazykev","followers_url":"https://api.github.com/users/Crazykev/followers","following_url":"https://api.github.com/users/Crazykev/following{/other_user}","gists_url":"https://api.github.com/users/Crazykev/gists{/gist_id}","starred_url":"https://api.github.com/users/Crazykev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crazykev/subscriptions","organizations_url":"https://api.github.com/users/Crazykev/orgs","repos_url":"https://api.github.com/users/Crazykev/repos","events_url":"https://api.github.com/users/Crazykev/events{/privacy}","received_events_url":"https://api.github.com/users/Crazykev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crazykev/frakti","description":"The hypervisor-based container runtime for Kubernetes.","fork":true,"url":"https://api.github.com/repos/Crazykev/frakti","forks_url":"https://api.github.com/repos/Crazykev/frakti/forks","keys_url":"https://api.github.com/repos/Crazykev/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crazykev/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crazykev/frakti/teams","hooks_url":"https://api.github.com/repos/Crazykev/frakti/hooks","issue_events_url":"https://api.github.com/repos/Crazykev/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/Crazykev/frakti/events","assignees_url":"https://api.github.com/repos/Crazykev/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/Crazykev/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/Crazykev/frakti/tags","blobs_url":"https://api.github.com/repos/Crazykev/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crazykev/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crazykev/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crazykev/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crazykev/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/Crazykev/frakti/languages","stargazers_url":"https://api.github.com/repos/Crazykev/frakti/stargazers","contributors_url":"https://api.github.com/repos/Crazykev/frakti/contributors","subscribers_url":"https://api.github.com/repos/Crazykev/frakti/subscribers","subscription_url":"https://api.github.com/repos/Crazykev/frakti/subscription","commits_url":"https://api.github.com/repos/Crazykev/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crazykev/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crazykev/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crazykev/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crazykev/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/Crazykev/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crazykev/frakti/merges","archive_url":"https://api.github.com/repos/Crazykev/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crazykev/frakti/downloads","issues_url":"https://api.github.com/repos/Crazykev/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/Crazykev/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/Crazykev/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/Crazykev/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crazykev/frakti/labels{/name}","releases_url":"https://api.github.com/repos/Crazykev/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/Crazykev/frakti/deployments","created_at":"2016-08-24T19:02:15Z","updated_at":"2016-08-24T19:02:18Z","pushed_at":"2017-06-30T07:38:02Z","git_url":"git://github.com/Crazykev/frakti.git","ssh_url":"git@github.com:Crazykev/frakti.git","clone_url":"https://github.com/Crazykev/frakti.git","svn_url":"https://github.com/Crazykev/frakti","homepage":"","size":9125,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"28a14a389304d3097c00d54b8705fa12312fb2cc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62069434,"name":"frakti","full_name":"kubernetes/frakti","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/frakti","description":"The hypervisor-based container runtime for Kubernetes.","fork":false,"url":"https://api.github.com/repos/kubernetes/frakti","forks_url":"https://api.github.com/repos/kubernetes/frakti/forks","keys_url":"https://api.github.com/repos/kubernetes/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/frakti/teams","hooks_url":"https://api.github.com/repos/kubernetes/frakti/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/frakti/events","assignees_url":"https://api.github.com/repos/kubernetes/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/frakti/tags","blobs_url":"https://api.github.com/repos/kubernetes/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/frakti/languages","stargazers_url":"https://api.github.com/repos/kubernetes/frakti/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/frakti/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/frakti/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/frakti/subscription","commits_url":"https://api.github.com/repos/kubernetes/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/frakti/merges","archive_url":"https://api.github.com/repos/kubernetes/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/frakti/downloads","issues_url":"https://api.github.com/repos/kubernetes/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/frakti/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/frakti/deployments","created_at":"2016-06-27T16:04:23Z","updated_at":"2017-06-29T15:02:38Z","pushed_at":"2017-06-30T07:38:08Z","git_url":"git://github.com/kubernetes/frakti.git","ssh_url":"git@github.com:kubernetes/frakti.git","clone_url":"https://github.com/kubernetes/frakti.git","svn_url":"https://github.com/kubernetes/frakti","homepage":"","size":9197,"stargazers_count":132,"watchers_count":132,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":7,"forks":23,"open_issues":7,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/180"},"html":{"href":"https://github.com/kubernetes/frakti/pull/180"},"issue":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/180"},"comments":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/frakti/statuses/17d39db51926c40d46d9e154241b24f4693062f2"}}}}
{"actor":{"display_login":"Crazykev"}}