{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments/98068001","pull_request_review_id":18699145,"id":98068001,"diff_hunk":"@@ -263,45 +263,154 @@ let Artifact = Entity.configure({\n     name:           Entity.types.String,\n     storageType:    Entity.types.String,\n     contentType:    Entity.types.String,\n+    details:        Entity.types.JSON,\n+    expires:        Entity.types.Date,\n+  },\n+  context: [\n+    'blobStore',\n+    'privateBucket',\n+    'publicBucket',\n+    'monitor',\n+  ],\n+});\n+\n+/** Entity for tracking artifacts.\n+ * Version 2 adds 'present' field */\n+let Artifact = Entity.configure({","path":"src/data.js","position":26,"original_position":26,"commit_id":"9e69bc5f8f8a2328b1f5c37c668678ef78899d17","original_commit_id":"9e69bc5f8f8a2328b1f5c37c668678ef78899d17","user":{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false},"body":"You can do `Artifact = Artifact.configure({version: 2`, but just use the format we had before...\r\n\r\nAlso you can't do `let Artifact` twice :)","created_at":"2017-01-26T19:11:31Z","updated_at":"2017-01-26T19:11:31Z","html_url":"https://github.com/taskcluster/taskcluster-queue/pull/144#discussion_r98068001","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments/98068001"},"html":{"href":"https://github.com/taskcluster/taskcluster-queue/pull/144#discussion_r98068001"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144","id":103347567,"html_url":"https://github.com/taskcluster/taskcluster-queue/pull/144","diff_url":"https://github.com/taskcluster/taskcluster-queue/pull/144.diff","patch_url":"https://github.com/taskcluster/taskcluster-queue/pull/144.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/144","number":144,"state":"open","locked":false,"title":"initial work on blob storage type","user":{"login":"jhford","id":607353,"avatar_url":"https://avatars.githubusercontent.com/u/607353?v=3","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"body":"Just a quick review, feel free to ignore.  I'd like to do a more iterative approach to this project than a lot of other bigger projects which we do.","created_at":"2017-01-26T17:05:47Z","updated_at":"2017-01-26T19:11:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46f4a72a25e595dfbe473f8e7128765315f642de","assignee":{"login":"jhford","id":607353,"avatar_url":"https://avatars.githubusercontent.com/u/607353?v=3","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhford","id":607353,"avatar_url":"https://avatars.githubusercontent.com/u/607353?v=3","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/144/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/9e69bc5f8f8a2328b1f5c37c668678ef78899d17","head":{"label":"taskcluster:blob-artifact-wip","ref":"blob-artifact-wip","sha":"9e69bc5f8f8a2328b1f5c37c668678ef78899d17","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":16423616,"name":"taskcluster-queue","full_name":"taskcluster/taskcluster-queue","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-queue","description":"This is the central queue coordinating execution of tasks in the TaskCluster setup.","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-queue","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/deployments","created_at":"2014-01-31T23:12:31Z","updated_at":"2016-10-25T18:42:35Z","pushed_at":"2017-01-26T17:05:48Z","git_url":"git://github.com/taskcluster/taskcluster-queue.git","ssh_url":"git@github.com:taskcluster/taskcluster-queue.git","clone_url":"https://github.com/taskcluster/taskcluster-queue.git","svn_url":"https://github.com/taskcluster/taskcluster-queue","homepage":"","size":16666,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":4,"forks":14,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"taskcluster:blob-artifact","ref":"blob-artifact","sha":"4821e69dccc4d58b02a57794bb36c6aa5039aea5","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":16423616,"name":"taskcluster-queue","full_name":"taskcluster/taskcluster-queue","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-queue","description":"This is the central queue coordinating execution of tasks in the TaskCluster setup.","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-queue","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/deployments","created_at":"2014-01-31T23:12:31Z","updated_at":"2016-10-25T18:42:35Z","pushed_at":"2017-01-26T17:05:48Z","git_url":"git://github.com/taskcluster/taskcluster-queue.git","ssh_url":"git@github.com:taskcluster/taskcluster-queue.git","clone_url":"https://github.com/taskcluster/taskcluster-queue.git","svn_url":"https://github.com/taskcluster/taskcluster-queue","homepage":"","size":16666,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":4,"forks":14,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144"},"html":{"href":"https://github.com/taskcluster/taskcluster-queue/pull/144"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/144"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/9e69bc5f8f8a2328b1f5c37c668678ef78899d17"}}}}
{"actor":{"display_login":"jonasfj"}}