{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/14380","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/14380/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14380/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/14380/events","html_url":"https://github.com/nodejs/node/pull/14380","id":244256782,"number":14380,"title":"test: fix flaky http(s)-set-server-timeout tests","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"labels":[{"id":637807400,"url":"https://api.github.com/repos/nodejs/node/labels/CI%20/%20flaky%20test","name":"CI / flaky test","color":"ffff00","default":false},{"id":155267422,"url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8","default":false},{"id":155267437,"url":"https://api.github.com/repos/nodejs/node/labels/https","name":"https","color":"0052cc","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-20T06:21:29Z","updated_at":"2017-07-20T16:09:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14380","html_url":"https://github.com/nodejs/node/pull/14380","diff_url":"https://github.com/nodejs/node/pull/14380.diff","patch_url":"https://github.com/nodejs/node/pull/14380.patch"},"body":"The tests include a callback that might not be invoked but is wrapped in\r\ncommon.mustCall(). Remove the common.mustCall() wrapper and add a\r\ncomment explaining that it should not be added.\r\n\r\nFixes: https://github.com/nodejs/node/issues/11768\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest http https"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/316752412","html_url":"https://github.com/nodejs/node/pull/14380#issuecomment-316752412","issue_url":"https://api.github.com/repos/nodejs/node/issues/14380","id":316752412,"user":{"login":"refack","id":96947,"avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2017-07-20T16:09:59Z","updated_at":"2017-07-20T16:09:59Z","body":"Aren't we excluding an important step in the test?\r\nIMHO a possible alternative solution will be to call `server.close(); cb();` only after both `server.setTimeout` and the `connection` handlers have both run. And using `common.platformTimeout(100)`"}}
{"actor":{"display_login":"refack"}}