{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/comments/116831925","pull_request_review_id":38484901,"id":116831925,"diff_hunk":"@@ -30,16 +30,3 @@ class CKThreadLocalComponentScope {\n   std::stack<CKComponentScopeFramePair> stack;\n   std::stack<std::vector<id<NSObject>>> keys;\n };\n-\n-/**\n- Temporarily overrides the current thread's component scope.\n- Use for testing and advanced integration purposes only.\n- */\n-class CKThreadLocalComponentScopeOverride {\n-public:\n-  CKThreadLocalComponentScopeOverride(CKThreadLocalComponentScope *scope) noexcept;\n-  ~CKThreadLocalComponentScopeOverride();\n-\n-private:\n-  CKThreadLocalComponentScope *const previousScope;","path":"ComponentKit/Core/Scope/CKThreadLocalComponentScope.h","position":15,"original_position":15,"commit_id":"07f7bc01a16679d7420d8cb6b60ab0ab54f116f3","original_commit_id":"07f7bc01a16679d7420d8cb6b60ab0ab54f116f3","user":{"login":"ocrickard","id":857665,"avatar_url":"https://avatars1.githubusercontent.com/u/857665?v=3","gravatar_id":"","url":"https://api.github.com/users/ocrickard","html_url":"https://github.com/ocrickard","followers_url":"https://api.github.com/users/ocrickard/followers","following_url":"https://api.github.com/users/ocrickard/following{/other_user}","gists_url":"https://api.github.com/users/ocrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/ocrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocrickard/subscriptions","organizations_url":"https://api.github.com/users/ocrickard/orgs","repos_url":"https://api.github.com/users/ocrickard/repos","events_url":"https://api.github.com/users/ocrickard/events{/privacy}","received_events_url":"https://api.github.com/users/ocrickard/received_events","type":"User","site_admin":false},"body":"Yeah, why not just do this?","created_at":"2017-05-16T19:12:44Z","updated_at":"2017-05-16T19:12:44Z","html_url":"https://github.com/facebook/componentkit/pull/815#discussion_r116831925","pull_request_url":"https://api.github.com/repos/facebook/componentkit/pulls/815","_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments/116831925"},"html":{"href":"https://github.com/facebook/componentkit/pull/815#discussion_r116831925"},"pull_request":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/815"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/815","id":120890099,"html_url":"https://github.com/facebook/componentkit/pull/815","diff_url":"https://github.com/facebook/componentkit/pull/815.diff","patch_url":"https://github.com/facebook/componentkit/pull/815.patch","issue_url":"https://api.github.com/repos/facebook/componentkit/issues/815","number":815,"state":"open","locked":false,"title":"Introduce concept of nested thread local scopes.","user":{"login":"dshahidehpour","id":3373291,"avatar_url":"https://avatars1.githubusercontent.com/u/3373291?v=3","gravatar_id":"","url":"https://api.github.com/users/dshahidehpour","html_url":"https://github.com/dshahidehpour","followers_url":"https://api.github.com/users/dshahidehpour/followers","following_url":"https://api.github.com/users/dshahidehpour/following{/other_user}","gists_url":"https://api.github.com/users/dshahidehpour/gists{/gist_id}","starred_url":"https://api.github.com/users/dshahidehpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshahidehpour/subscriptions","organizations_url":"https://api.github.com/users/dshahidehpour/orgs","repos_url":"https://api.github.com/users/dshahidehpour/repos","events_url":"https://api.github.com/users/dshahidehpour/events{/privacy}","received_events_url":"https://api.github.com/users/dshahidehpour/received_events","type":"User","site_admin":false},"body":"If another `CKThreadLocalComponentScope` is created while another is in scope, it is overridden. This changes behavior so that the newly created scope takes precedence as `currentScope` for the duration of its' lifecycle. When it is destructed, the previous `currentScope` is restored.","created_at":"2017-05-16T18:04:14Z","updated_at":"2017-05-16T19:12:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b960f277716093df6048073ae3070f587d808fa8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/componentkit/pulls/815/commits","review_comments_url":"https://api.github.com/repos/facebook/componentkit/pulls/815/comments","review_comment_url":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/componentkit/issues/815/comments","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/07f7bc01a16679d7420d8cb6b60ab0ab54f116f3","head":{"label":"dshahidehpour:nested_thread","ref":"nested_thread","sha":"07f7bc01a16679d7420d8cb6b60ab0ab54f116f3","user":{"login":"dshahidehpour","id":3373291,"avatar_url":"https://avatars1.githubusercontent.com/u/3373291?v=3","gravatar_id":"","url":"https://api.github.com/users/dshahidehpour","html_url":"https://github.com/dshahidehpour","followers_url":"https://api.github.com/users/dshahidehpour/followers","following_url":"https://api.github.com/users/dshahidehpour/following{/other_user}","gists_url":"https://api.github.com/users/dshahidehpour/gists{/gist_id}","starred_url":"https://api.github.com/users/dshahidehpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshahidehpour/subscriptions","organizations_url":"https://api.github.com/users/dshahidehpour/orgs","repos_url":"https://api.github.com/users/dshahidehpour/repos","events_url":"https://api.github.com/users/dshahidehpour/events{/privacy}","received_events_url":"https://api.github.com/users/dshahidehpour/received_events","type":"User","site_admin":false},"repo":{"id":85124240,"name":"componentkit","full_name":"dshahidehpour/componentkit","owner":{"login":"dshahidehpour","id":3373291,"avatar_url":"https://avatars1.githubusercontent.com/u/3373291?v=3","gravatar_id":"","url":"https://api.github.com/users/dshahidehpour","html_url":"https://github.com/dshahidehpour","followers_url":"https://api.github.com/users/dshahidehpour/followers","following_url":"https://api.github.com/users/dshahidehpour/following{/other_user}","gists_url":"https://api.github.com/users/dshahidehpour/gists{/gist_id}","starred_url":"https://api.github.com/users/dshahidehpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshahidehpour/subscriptions","organizations_url":"https://api.github.com/users/dshahidehpour/orgs","repos_url":"https://api.github.com/users/dshahidehpour/repos","events_url":"https://api.github.com/users/dshahidehpour/events{/privacy}","received_events_url":"https://api.github.com/users/dshahidehpour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dshahidehpour/componentkit","description":"A React-inspired view framework for iOS.","fork":true,"url":"https://api.github.com/repos/dshahidehpour/componentkit","forks_url":"https://api.github.com/repos/dshahidehpour/componentkit/forks","keys_url":"https://api.github.com/repos/dshahidehpour/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dshahidehpour/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dshahidehpour/componentkit/teams","hooks_url":"https://api.github.com/repos/dshahidehpour/componentkit/hooks","issue_events_url":"https://api.github.com/repos/dshahidehpour/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/dshahidehpour/componentkit/events","assignees_url":"https://api.github.com/repos/dshahidehpour/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/dshahidehpour/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/dshahidehpour/componentkit/tags","blobs_url":"https://api.github.com/repos/dshahidehpour/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dshahidehpour/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dshahidehpour/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dshahidehpour/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dshahidehpour/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/dshahidehpour/componentkit/languages","stargazers_url":"https://api.github.com/repos/dshahidehpour/componentkit/stargazers","contributors_url":"https://api.github.com/repos/dshahidehpour/componentkit/contributors","subscribers_url":"https://api.github.com/repos/dshahidehpour/componentkit/subscribers","subscription_url":"https://api.github.com/repos/dshahidehpour/componentkit/subscription","commits_url":"https://api.github.com/repos/dshahidehpour/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dshahidehpour/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dshahidehpour/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dshahidehpour/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dshahidehpour/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/dshahidehpour/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dshahidehpour/componentkit/merges","archive_url":"https://api.github.com/repos/dshahidehpour/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dshahidehpour/componentkit/downloads","issues_url":"https://api.github.com/repos/dshahidehpour/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/dshahidehpour/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/dshahidehpour/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/dshahidehpour/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dshahidehpour/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/dshahidehpour/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/dshahidehpour/componentkit/deployments","created_at":"2017-03-15T21:50:20Z","updated_at":"2017-03-15T21:50:23Z","pushed_at":"2017-05-16T18:02:34Z","git_url":"git://github.com/dshahidehpour/componentkit.git","ssh_url":"git@github.com:dshahidehpour/componentkit.git","clone_url":"https://github.com/dshahidehpour/componentkit.git","svn_url":"https://github.com/dshahidehpour/componentkit","homepage":"http://www.componentkit.org/","size":9166,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"943da58c55daf84c4367a3724930207fbde58dcc","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":32600951,"name":"componentkit","full_name":"facebook/componentkit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/componentkit","description":"A React-inspired view framework for iOS.","fork":false,"url":"https://api.github.com/repos/facebook/componentkit","forks_url":"https://api.github.com/repos/facebook/componentkit/forks","keys_url":"https://api.github.com/repos/facebook/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/componentkit/teams","hooks_url":"https://api.github.com/repos/facebook/componentkit/hooks","issue_events_url":"https://api.github.com/repos/facebook/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/componentkit/events","assignees_url":"https://api.github.com/repos/facebook/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/componentkit/tags","blobs_url":"https://api.github.com/repos/facebook/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/componentkit/languages","stargazers_url":"https://api.github.com/repos/facebook/componentkit/stargazers","contributors_url":"https://api.github.com/repos/facebook/componentkit/contributors","subscribers_url":"https://api.github.com/repos/facebook/componentkit/subscribers","subscription_url":"https://api.github.com/repos/facebook/componentkit/subscription","commits_url":"https://api.github.com/repos/facebook/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/componentkit/merges","archive_url":"https://api.github.com/repos/facebook/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/componentkit/downloads","issues_url":"https://api.github.com/repos/facebook/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/componentkit/deployments","created_at":"2015-03-20T18:42:47Z","updated_at":"2017-05-16T10:28:48Z","pushed_at":"2017-05-16T18:04:14Z","git_url":"git://github.com/facebook/componentkit.git","ssh_url":"git@github.com:facebook/componentkit.git","clone_url":"https://github.com/facebook/componentkit.git","svn_url":"https://github.com/facebook/componentkit","homepage":"http://www.componentkit.org/","size":9142,"stargazers_count":3874,"watchers_count":3874,"language":"Objective-C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":440,"mirror_url":null,"open_issues_count":23,"forks":440,"open_issues":23,"watchers":3874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/815"},"html":{"href":"https://github.com/facebook/componentkit/pull/815"},"issue":{"href":"https://api.github.com/repos/facebook/componentkit/issues/815"},"comments":{"href":"https://api.github.com/repos/facebook/componentkit/issues/815/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/815/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/815/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/componentkit/statuses/07f7bc01a16679d7420d8cb6b60ab0ab54f116f3"}}}}
{"actor":{"display_login":"ocrickard"}}