{"action":"created","comment":{"url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/comments/99465059","pull_request_review_id":20146819,"id":99465059,"diff_hunk":"@@ -955,11 +955,11 @@ int main_cmdline(int argc, char **argv) {\n \n     if ( -1 == faccessat(0, blacklist_file_dir, F_OK | X_OK | W_OK, AT_EACCESS)) {\n         if (ENOENT == errno) {//black file dir is not exit.\n-            g_warning(\"%s(%s): dir of %s don't exit ,the blacklist file dir should exit, otherwise save blacklist should be fail.\", G_STRLOC, __func__, blacklist_file);\n+            g_log_dbproxy(g_warning, \"dir of %s don't exit ,the blacklist file dir should exit, otherwise save blacklist should be fail.\", blacklist_file);\n \n         }\n         else if (EACCES == errno) {//black file dir don't have correct privilges.\n-            g_warning(\"%s(%s): %s don't have correct privilege for the user %s set in the blacklist file, blacklist file dir should have execute and write privilege, otherwise save blacklist should be fail.\", G_STRLOC, __func__, blacklist_file, srv->user);\n+            g_log_dbproxy(g_warning, \"%s don't have correct privilege for the user %s set in the blacklist file, blacklist file dir should have execute and write privilege, otherwise save blacklist should be fail.\", blacklist_file, srv->user);","path":"src/mysql-proxy-cli.c","position":389,"original_position":389,"commit_id":"39a0911f3cf385af368381efc15609870b0d1a0c","original_commit_id":"39a0911f3cf385af368381efc15609870b0d1a0c","user":{"login":"tsthght","id":13314548,"avatar_url":"https://avatars.githubusercontent.com/u/13314548?v=3","gravatar_id":"","url":"https://api.github.com/users/tsthght","html_url":"https://github.com/tsthght","followers_url":"https://api.github.com/users/tsthght/followers","following_url":"https://api.github.com/users/tsthght/following{/other_user}","gists_url":"https://api.github.com/users/tsthght/gists{/gist_id}","starred_url":"https://api.github.com/users/tsthght/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsthght/subscriptions","organizations_url":"https://api.github.com/users/tsthght/orgs","repos_url":"https://api.github.com/users/tsthght/repos","events_url":"https://api.github.com/users/tsthght/events{/privacy}","received_events_url":"https://api.github.com/users/tsthght/received_events","type":"User","site_admin":false},"body":"绝大多数日志尾部没有标点.\r\n","created_at":"2017-02-04T11:27:07Z","updated_at":"2017-02-04T11:27:07Z","html_url":"https://github.com/Meituan-Dianping/DBProxy/pull/55#discussion_r99465059","pull_request_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/comments/99465059"},"html":{"href":"https://github.com/Meituan-Dianping/DBProxy/pull/55#discussion_r99465059"},"pull_request":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55","id":102866528,"html_url":"https://github.com/Meituan-Dianping/DBProxy/pull/55","diff_url":"https://github.com/Meituan-Dianping/DBProxy/pull/55.diff","patch_url":"https://github.com/Meituan-Dianping/DBProxy/pull/55.patch","issue_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/issues/55","number":55,"state":"open","locked":false,"title":"DBProxy日志优化：日志格式标准化，包含打日志的文件名称、行数、函数名称、原因；日志等级优化，根据内容优化日志等级","user":{"login":"wengninglong","id":25032814,"avatar_url":"https://avatars.githubusercontent.com/u/25032814?v=3","gravatar_id":"","url":"https://api.github.com/users/wengninglong","html_url":"https://github.com/wengninglong","followers_url":"https://api.github.com/users/wengninglong/followers","following_url":"https://api.github.com/users/wengninglong/following{/other_user}","gists_url":"https://api.github.com/users/wengninglong/gists{/gist_id}","starred_url":"https://api.github.com/users/wengninglong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wengninglong/subscriptions","organizations_url":"https://api.github.com/users/wengninglong/orgs","repos_url":"https://api.github.com/users/wengninglong/repos","events_url":"https://api.github.com/users/wengninglong/events{/privacy}","received_events_url":"https://api.github.com/users/wengninglong/received_events","type":"User","site_admin":false},"body":"DBProxy日志优化：日志格式标准化，包含打日志的文件名称、行数、函数名称、原因；日志等级优化，根据内容优化日志等级","created_at":"2017-01-24T07:32:59Z","updated_at":"2017-02-04T11:27:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"161a07aedca5aa3a5fc9c825a8fdd7811c4907a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55/commits","review_comments_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55/comments","review_comment_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/issues/55/comments","statuses_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/statuses/39a0911f3cf385af368381efc15609870b0d1a0c","head":{"label":"wengninglong:master","ref":"master","sha":"39a0911f3cf385af368381efc15609870b0d1a0c","user":{"login":"wengninglong","id":25032814,"avatar_url":"https://avatars.githubusercontent.com/u/25032814?v=3","gravatar_id":"","url":"https://api.github.com/users/wengninglong","html_url":"https://github.com/wengninglong","followers_url":"https://api.github.com/users/wengninglong/followers","following_url":"https://api.github.com/users/wengninglong/following{/other_user}","gists_url":"https://api.github.com/users/wengninglong/gists{/gist_id}","starred_url":"https://api.github.com/users/wengninglong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wengninglong/subscriptions","organizations_url":"https://api.github.com/users/wengninglong/orgs","repos_url":"https://api.github.com/users/wengninglong/repos","events_url":"https://api.github.com/users/wengninglong/events{/privacy}","received_events_url":"https://api.github.com/users/wengninglong/received_events","type":"User","site_admin":false},"repo":{"id":79885995,"name":"DBProxy","full_name":"wengninglong/DBProxy","owner":{"login":"wengninglong","id":25032814,"avatar_url":"https://avatars.githubusercontent.com/u/25032814?v=3","gravatar_id":"","url":"https://api.github.com/users/wengninglong","html_url":"https://github.com/wengninglong","followers_url":"https://api.github.com/users/wengninglong/followers","following_url":"https://api.github.com/users/wengninglong/following{/other_user}","gists_url":"https://api.github.com/users/wengninglong/gists{/gist_id}","starred_url":"https://api.github.com/users/wengninglong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wengninglong/subscriptions","organizations_url":"https://api.github.com/users/wengninglong/orgs","repos_url":"https://api.github.com/users/wengninglong/repos","events_url":"https://api.github.com/users/wengninglong/events{/privacy}","received_events_url":"https://api.github.com/users/wengninglong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wengninglong/DBProxy","description":null,"fork":true,"url":"https://api.github.com/repos/wengninglong/DBProxy","forks_url":"https://api.github.com/repos/wengninglong/DBProxy/forks","keys_url":"https://api.github.com/repos/wengninglong/DBProxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wengninglong/DBProxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wengninglong/DBProxy/teams","hooks_url":"https://api.github.com/repos/wengninglong/DBProxy/hooks","issue_events_url":"https://api.github.com/repos/wengninglong/DBProxy/issues/events{/number}","events_url":"https://api.github.com/repos/wengninglong/DBProxy/events","assignees_url":"https://api.github.com/repos/wengninglong/DBProxy/assignees{/user}","branches_url":"https://api.github.com/repos/wengninglong/DBProxy/branches{/branch}","tags_url":"https://api.github.com/repos/wengninglong/DBProxy/tags","blobs_url":"https://api.github.com/repos/wengninglong/DBProxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wengninglong/DBProxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wengninglong/DBProxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/wengninglong/DBProxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wengninglong/DBProxy/statuses/{sha}","languages_url":"https://api.github.com/repos/wengninglong/DBProxy/languages","stargazers_url":"https://api.github.com/repos/wengninglong/DBProxy/stargazers","contributors_url":"https://api.github.com/repos/wengninglong/DBProxy/contributors","subscribers_url":"https://api.github.com/repos/wengninglong/DBProxy/subscribers","subscription_url":"https://api.github.com/repos/wengninglong/DBProxy/subscription","commits_url":"https://api.github.com/repos/wengninglong/DBProxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/wengninglong/DBProxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/wengninglong/DBProxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/wengninglong/DBProxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/wengninglong/DBProxy/contents/{+path}","compare_url":"https://api.github.com/repos/wengninglong/DBProxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wengninglong/DBProxy/merges","archive_url":"https://api.github.com/repos/wengninglong/DBProxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wengninglong/DBProxy/downloads","issues_url":"https://api.github.com/repos/wengninglong/DBProxy/issues{/number}","pulls_url":"https://api.github.com/repos/wengninglong/DBProxy/pulls{/number}","milestones_url":"https://api.github.com/repos/wengninglong/DBProxy/milestones{/number}","notifications_url":"https://api.github.com/repos/wengninglong/DBProxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wengninglong/DBProxy/labels{/name}","releases_url":"https://api.github.com/repos/wengninglong/DBProxy/releases{/id}","deployments_url":"https://api.github.com/repos/wengninglong/DBProxy/deployments","created_at":"2017-01-24T06:42:08Z","updated_at":"2017-01-24T06:42:20Z","pushed_at":"2017-01-24T07:29:17Z","git_url":"git://github.com/wengninglong/DBProxy.git","ssh_url":"git@github.com:wengninglong/DBProxy.git","clone_url":"https://github.com/wengninglong/DBProxy.git","svn_url":"https://github.com/wengninglong/DBProxy","homepage":null,"size":15808,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Meituan-Dianping:master","ref":"master","sha":"2bbf2c770f0a965236b5666626a8fb010124c48e","user":{"login":"Meituan-Dianping","id":20238146,"avatar_url":"https://avatars.githubusercontent.com/u/20238146?v=3","gravatar_id":"","url":"https://api.github.com/users/Meituan-Dianping","html_url":"https://github.com/Meituan-Dianping","followers_url":"https://api.github.com/users/Meituan-Dianping/followers","following_url":"https://api.github.com/users/Meituan-Dianping/following{/other_user}","gists_url":"https://api.github.com/users/Meituan-Dianping/gists{/gist_id}","starred_url":"https://api.github.com/users/Meituan-Dianping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meituan-Dianping/subscriptions","organizations_url":"https://api.github.com/users/Meituan-Dianping/orgs","repos_url":"https://api.github.com/users/Meituan-Dianping/repos","events_url":"https://api.github.com/users/Meituan-Dianping/events{/privacy}","received_events_url":"https://api.github.com/users/Meituan-Dianping/received_events","type":"Organization","site_admin":false},"repo":{"id":77523707,"name":"DBProxy","full_name":"Meituan-Dianping/DBProxy","owner":{"login":"Meituan-Dianping","id":20238146,"avatar_url":"https://avatars.githubusercontent.com/u/20238146?v=3","gravatar_id":"","url":"https://api.github.com/users/Meituan-Dianping","html_url":"https://github.com/Meituan-Dianping","followers_url":"https://api.github.com/users/Meituan-Dianping/followers","following_url":"https://api.github.com/users/Meituan-Dianping/following{/other_user}","gists_url":"https://api.github.com/users/Meituan-Dianping/gists{/gist_id}","starred_url":"https://api.github.com/users/Meituan-Dianping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meituan-Dianping/subscriptions","organizations_url":"https://api.github.com/users/Meituan-Dianping/orgs","repos_url":"https://api.github.com/users/Meituan-Dianping/repos","events_url":"https://api.github.com/users/Meituan-Dianping/events{/privacy}","received_events_url":"https://api.github.com/users/Meituan-Dianping/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Meituan-Dianping/DBProxy","description":null,"fork":false,"url":"https://api.github.com/repos/Meituan-Dianping/DBProxy","forks_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/forks","keys_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/teams","hooks_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/hooks","issue_events_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/issues/events{/number}","events_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/events","assignees_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/assignees{/user}","branches_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/branches{/branch}","tags_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/tags","blobs_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/statuses/{sha}","languages_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/languages","stargazers_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/stargazers","contributors_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/contributors","subscribers_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/subscribers","subscription_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/subscription","commits_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/contents/{+path}","compare_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/merges","archive_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/downloads","issues_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/issues{/number}","pulls_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls{/number}","milestones_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/milestones{/number}","notifications_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/labels{/name}","releases_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/releases{/id}","deployments_url":"https://api.github.com/repos/Meituan-Dianping/DBProxy/deployments","created_at":"2016-12-28T10:13:12Z","updated_at":"2017-02-04T09:55:06Z","pushed_at":"2017-01-24T07:32:59Z","git_url":"git://github.com/Meituan-Dianping/DBProxy.git","ssh_url":"git@github.com:Meituan-Dianping/DBProxy.git","clone_url":"https://github.com/Meituan-Dianping/DBProxy.git","svn_url":"https://github.com/Meituan-Dianping/DBProxy","homepage":null,"size":15802,"stargazers_count":669,"watchers_count":669,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":29,"forks":158,"open_issues":29,"watchers":669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55"},"html":{"href":"https://github.com/Meituan-Dianping/DBProxy/pull/55"},"issue":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/issues/55"},"comments":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/Meituan-Dianping/DBProxy/statuses/39a0911f3cf385af368381efc15609870b0d1a0c"}}}}
{"actor":{"display_login":"tsthght"}}