{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/17131","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/17131/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/17131/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/17131/events","html_url":"https://github.com/nodejs/node/pull/17131","id":275155251,"number":17131,"title":"module: Fix for #17130 CJS dependency shared with loader","user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"labels":[{"id":690799345,"url":"https://api.github.com/repos/nodejs/node/labels/ES%20Modules","name":"ES Modules","color":"0052cc","default":false},{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/ready","name":"ready","color":"1eca26","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-11-19T12:34:30Z","updated_at":"2017-11-23T17:02:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/17131","html_url":"https://github.com/nodejs/node/pull/17131","diff_url":"https://github.com/nodejs/node/pull/17131.diff","patch_url":"https://github.com/nodejs/node/pull/17131.patch"},"body":"This fixes the issue of a CJS dependency loaded by the loader then not being defined when imported.\r\n\r\nThe reason for this is that CJS modules define themselves early into the loader on execution, instead of as a result of being imported by the loader. But this defining only happens the first time they are loaded. Because we use a different loader for the loader itself, the modules weren't being redefined, which has been fixed here.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\nesmodules\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/346666752","html_url":"https://github.com/nodejs/node/pull/17131#issuecomment-346666752","issue_url":"https://api.github.com/repos/nodejs/node/issues/17131","id":346666752,"user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"created_at":"2017-11-23T17:02:05Z","updated_at":"2017-11-23T17:02:05Z","author_association":"CONTRIBUTOR","body":"Ah right, so it's as simple as a Windows failure. Thanks, will get the local test going here."}}
{"actor":{"display_login":"guybedford"}}