{"action":"created","comment":{"url":"https://api.github.com/repos/gosu/gosu/pulls/comments/153060266","pull_request_review_id":79016973,"id":153060266,"diff_hunk":"@@ -45,6 +45,11 @@ def eql?(other)\n   end\n end\n \n+module Gosu\n+  # Backwards compatibility: Channel was called SampleInstance before Gosu 0.13.0.\n+  SampleInstance = Channel","path":"lib/gosu/patches.rb","position":6,"original_position":6,"commit_id":"caa1b60b8ddba2fb34337e705cf0fac36866b746","original_commit_id":"caa1b60b8ddba2fb34337e705cf0fac36866b746","user":{"login":"jlnr","id":70772,"avatar_url":"https://avatars1.githubusercontent.com/u/70772?v=4","gravatar_id":"","url":"https://api.github.com/users/jlnr","html_url":"https://github.com/jlnr","followers_url":"https://api.github.com/users/jlnr/followers","following_url":"https://api.github.com/users/jlnr/following{/other_user}","gists_url":"https://api.github.com/users/jlnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jlnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlnr/subscriptions","organizations_url":"https://api.github.com/users/jlnr/orgs","repos_url":"https://api.github.com/users/jlnr/repos","events_url":"https://api.github.com/users/jlnr/events{/privacy}","received_events_url":"https://api.github.com/users/jlnr/received_events","type":"User","site_admin":false},"body":"Oh wow, you are right. Thanks for pointing that out! Will fix it ASAP.","created_at":"2017-11-26T04:57:44Z","updated_at":"2017-11-26T04:57:44Z","html_url":"https://github.com/gosu/gosu/pull/421#discussion_r153060266","pull_request_url":"https://api.github.com/repos/gosu/gosu/pulls/421","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gosu/gosu/pulls/comments/153060266"},"html":{"href":"https://github.com/gosu/gosu/pull/421#discussion_r153060266"},"pull_request":{"href":"https://api.github.com/repos/gosu/gosu/pulls/421"}},"in_reply_to_id":153054462},"pull_request":{"url":"https://api.github.com/repos/gosu/gosu/pulls/421","id":153619608,"html_url":"https://github.com/gosu/gosu/pull/421","diff_url":"https://github.com/gosu/gosu/pull/421.diff","patch_url":"https://github.com/gosu/gosu/pull/421.patch","issue_url":"https://api.github.com/repos/gosu/gosu/issues/421","number":421,"state":"closed","locked":false,"title":"Audio Refactoring","user":{"login":"jlnr","id":70772,"avatar_url":"https://avatars1.githubusercontent.com/u/70772?v=4","gravatar_id":"","url":"https://api.github.com/users/jlnr","html_url":"https://github.com/jlnr","followers_url":"https://api.github.com/users/jlnr/followers","following_url":"https://api.github.com/users/jlnr/following{/other_user}","gists_url":"https://api.github.com/users/jlnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jlnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlnr/subscriptions","organizations_url":"https://api.github.com/users/jlnr/orgs","repos_url":"https://api.github.com/users/jlnr/repos","events_url":"https://api.github.com/users/jlnr/events{/privacy}","received_events_url":"https://api.github.com/users/jlnr/received_events","type":"User","site_admin":false},"body":"The massive Audio.cpp file was a bit of an embarrassment, and got into the way of me understanding the two existing audio refactoring branches. So I've started a third branch! (Sorry @Kjarrigan 😅)\r\n\r\nThis branch aims to:\r\n* Rename `SampleInstance` to `Channel`\r\n* Add default constructors to `Sample`, but only in C++, like `Image`. `Song` does not receive a default constructor because it is non-copyable (not sure if this logic is sound)\r\n* Refactor the awkward ALChannelManagement class into an encapsulated little thing\r\n* Improve everything I could find on the way\r\n\r\nIt should not:\r\n* Break Ruby backward compatibility\r\n* Make anything thread-safe that wasn't thread-safe before (it's quite tempting!)\r\n* Merge Song and Sample (I'll look into this after merging this PR)\r\n\r\nMore ideas:\r\n* [x] `ChannelManagement.{hpp,cpp}` should probably be called `AudioImpl.{hpp,cpp}` to be more consistent with `GraphicsImpl.hpp`\r\n* [x] Fix Travis on this branch, where I can comfortably force-push, and then cherry-pick this onto the fix before merging.","created_at":"2017-11-20T12:42:29Z","updated_at":"2017-11-26T04:57:44Z","closed_at":"2017-11-25T06:53:00Z","merged_at":"2017-11-25T06:53:00Z","merge_commit_sha":"eae3e338f866a665eaea7d55a4ba0db7c747cfba","assignee":{"login":"jlnr","id":70772,"avatar_url":"https://avatars1.githubusercontent.com/u/70772?v=4","gravatar_id":"","url":"https://api.github.com/users/jlnr","html_url":"https://github.com/jlnr","followers_url":"https://api.github.com/users/jlnr/followers","following_url":"https://api.github.com/users/jlnr/following{/other_user}","gists_url":"https://api.github.com/users/jlnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jlnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlnr/subscriptions","organizations_url":"https://api.github.com/users/jlnr/orgs","repos_url":"https://api.github.com/users/jlnr/repos","events_url":"https://api.github.com/users/jlnr/events{/privacy}","received_events_url":"https://api.github.com/users/jlnr/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlnr","id":70772,"avatar_url":"https://avatars1.githubusercontent.com/u/70772?v=4","gravatar_id":"","url":"https://api.github.com/users/jlnr","html_url":"https://github.com/jlnr","followers_url":"https://api.github.com/users/jlnr/followers","following_url":"https://api.github.com/users/jlnr/following{/other_user}","gists_url":"https://api.github.com/users/jlnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jlnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlnr/subscriptions","organizations_url":"https://api.github.com/users/jlnr/orgs","repos_url":"https://api.github.com/users/jlnr/repos","events_url":"https://api.github.com/users/jlnr/events{/privacy}","received_events_url":"https://api.github.com/users/jlnr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gosu/gosu/pulls/421/commits","review_comments_url":"https://api.github.com/repos/gosu/gosu/pulls/421/comments","review_comment_url":"https://api.github.com/repos/gosu/gosu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gosu/gosu/issues/421/comments","statuses_url":"https://api.github.com/repos/gosu/gosu/statuses/caa1b60b8ddba2fb34337e705cf0fac36866b746","head":{"label":"gosu:audio-refactoring","ref":"audio-refactoring","sha":"caa1b60b8ddba2fb34337e705cf0fac36866b746","user":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"repo":{"id":193464,"name":"gosu","full_name":"gosu/gosu","owner":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gosu/gosu","description":"2D game development library for Ruby and C++","fork":false,"url":"https://api.github.com/repos/gosu/gosu","forks_url":"https://api.github.com/repos/gosu/gosu/forks","keys_url":"https://api.github.com/repos/gosu/gosu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gosu/gosu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gosu/gosu/teams","hooks_url":"https://api.github.com/repos/gosu/gosu/hooks","issue_events_url":"https://api.github.com/repos/gosu/gosu/issues/events{/number}","events_url":"https://api.github.com/repos/gosu/gosu/events","assignees_url":"https://api.github.com/repos/gosu/gosu/assignees{/user}","branches_url":"https://api.github.com/repos/gosu/gosu/branches{/branch}","tags_url":"https://api.github.com/repos/gosu/gosu/tags","blobs_url":"https://api.github.com/repos/gosu/gosu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gosu/gosu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gosu/gosu/git/refs{/sha}","trees_url":"https://api.github.com/repos/gosu/gosu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gosu/gosu/statuses/{sha}","languages_url":"https://api.github.com/repos/gosu/gosu/languages","stargazers_url":"https://api.github.com/repos/gosu/gosu/stargazers","contributors_url":"https://api.github.com/repos/gosu/gosu/contributors","subscribers_url":"https://api.github.com/repos/gosu/gosu/subscribers","subscription_url":"https://api.github.com/repos/gosu/gosu/subscription","commits_url":"https://api.github.com/repos/gosu/gosu/commits{/sha}","git_commits_url":"https://api.github.com/repos/gosu/gosu/git/commits{/sha}","comments_url":"https://api.github.com/repos/gosu/gosu/comments{/number}","issue_comment_url":"https://api.github.com/repos/gosu/gosu/issues/comments{/number}","contents_url":"https://api.github.com/repos/gosu/gosu/contents/{+path}","compare_url":"https://api.github.com/repos/gosu/gosu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gosu/gosu/merges","archive_url":"https://api.github.com/repos/gosu/gosu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gosu/gosu/downloads","issues_url":"https://api.github.com/repos/gosu/gosu/issues{/number}","pulls_url":"https://api.github.com/repos/gosu/gosu/pulls{/number}","milestones_url":"https://api.github.com/repos/gosu/gosu/milestones{/number}","notifications_url":"https://api.github.com/repos/gosu/gosu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gosu/gosu/labels{/name}","releases_url":"https://api.github.com/repos/gosu/gosu/releases{/id}","deployments_url":"https://api.github.com/repos/gosu/gosu/deployments","created_at":"2009-05-05T22:35:44Z","updated_at":"2017-11-21T16:39:51Z","pushed_at":"2017-11-25T11:09:46Z","git_url":"git://github.com/gosu/gosu.git","ssh_url":"git@github.com:gosu/gosu.git","clone_url":"https://github.com/gosu/gosu.git","svn_url":"https://github.com/gosu/gosu","homepage":"https://www.libgosu.org/","size":47999,"stargazers_count":1347,"watchers_count":1347,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":81,"forks":152,"open_issues":81,"watchers":1347,"default_branch":"master"}},"base":{"label":"gosu:master","ref":"master","sha":"7f0b12a9aed2663534d3df25cdc01a0d6b88e6d7","user":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"repo":{"id":193464,"name":"gosu","full_name":"gosu/gosu","owner":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gosu/gosu","description":"2D game development library for Ruby and C++","fork":false,"url":"https://api.github.com/repos/gosu/gosu","forks_url":"https://api.github.com/repos/gosu/gosu/forks","keys_url":"https://api.github.com/repos/gosu/gosu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gosu/gosu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gosu/gosu/teams","hooks_url":"https://api.github.com/repos/gosu/gosu/hooks","issue_events_url":"https://api.github.com/repos/gosu/gosu/issues/events{/number}","events_url":"https://api.github.com/repos/gosu/gosu/events","assignees_url":"https://api.github.com/repos/gosu/gosu/assignees{/user}","branches_url":"https://api.github.com/repos/gosu/gosu/branches{/branch}","tags_url":"https://api.github.com/repos/gosu/gosu/tags","blobs_url":"https://api.github.com/repos/gosu/gosu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gosu/gosu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gosu/gosu/git/refs{/sha}","trees_url":"https://api.github.com/repos/gosu/gosu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gosu/gosu/statuses/{sha}","languages_url":"https://api.github.com/repos/gosu/gosu/languages","stargazers_url":"https://api.github.com/repos/gosu/gosu/stargazers","contributors_url":"https://api.github.com/repos/gosu/gosu/contributors","subscribers_url":"https://api.github.com/repos/gosu/gosu/subscribers","subscription_url":"https://api.github.com/repos/gosu/gosu/subscription","commits_url":"https://api.github.com/repos/gosu/gosu/commits{/sha}","git_commits_url":"https://api.github.com/repos/gosu/gosu/git/commits{/sha}","comments_url":"https://api.github.com/repos/gosu/gosu/comments{/number}","issue_comment_url":"https://api.github.com/repos/gosu/gosu/issues/comments{/number}","contents_url":"https://api.github.com/repos/gosu/gosu/contents/{+path}","compare_url":"https://api.github.com/repos/gosu/gosu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gosu/gosu/merges","archive_url":"https://api.github.com/repos/gosu/gosu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gosu/gosu/downloads","issues_url":"https://api.github.com/repos/gosu/gosu/issues{/number}","pulls_url":"https://api.github.com/repos/gosu/gosu/pulls{/number}","milestones_url":"https://api.github.com/repos/gosu/gosu/milestones{/number}","notifications_url":"https://api.github.com/repos/gosu/gosu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gosu/gosu/labels{/name}","releases_url":"https://api.github.com/repos/gosu/gosu/releases{/id}","deployments_url":"https://api.github.com/repos/gosu/gosu/deployments","created_at":"2009-05-05T22:35:44Z","updated_at":"2017-11-21T16:39:51Z","pushed_at":"2017-11-25T11:09:46Z","git_url":"git://github.com/gosu/gosu.git","ssh_url":"git@github.com:gosu/gosu.git","clone_url":"https://github.com/gosu/gosu.git","svn_url":"https://github.com/gosu/gosu","homepage":"https://www.libgosu.org/","size":47999,"stargazers_count":1347,"watchers_count":1347,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":81,"forks":152,"open_issues":81,"watchers":1347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gosu/gosu/pulls/421"},"html":{"href":"https://github.com/gosu/gosu/pull/421"},"issue":{"href":"https://api.github.com/repos/gosu/gosu/issues/421"},"comments":{"href":"https://api.github.com/repos/gosu/gosu/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/gosu/gosu/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/gosu/gosu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gosu/gosu/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/gosu/gosu/statuses/caa1b60b8ddba2fb34337e705cf0fac36866b746"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jlnr"}}