{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/15503","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/15503/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/15503/comments","events_url":"https://api.github.com/repos/servo/servo/issues/15503/events","html_url":"https://github.com/servo/servo/pull/15503","id":206950397,"number":15503,"title":"[WIP] 15270 Parameterize DOM Node Traversal Methods","user":{"login":"DominoTree","id":5438118,"avatar_url":"https://avatars0.githubusercontent.com/u/5438118?v=3","gravatar_id":"","url":"https://api.github.com/users/DominoTree","html_url":"https://github.com/DominoTree","followers_url":"https://api.github.com/users/DominoTree/followers","following_url":"https://api.github.com/users/DominoTree/following{/other_user}","gists_url":"https://api.github.com/users/DominoTree/gists{/gist_id}","starred_url":"https://api.github.com/users/DominoTree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominoTree/subscriptions","organizations_url":"https://api.github.com/users/DominoTree/orgs","repos_url":"https://api.github.com/users/DominoTree/repos","events_url":"https://api.github.com/users/DominoTree/events{/privacy}","received_events_url":"https://api.github.com/users/DominoTree/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"nox","id":123095,"avatar_url":"https://avatars3.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"assignees":[{"login":"nox","id":123095,"avatar_url":"https://avatars3.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2017-02-11T02:23:08Z","updated_at":"2017-03-01T15:05:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/15503","html_url":"https://github.com/servo/servo/pull/15503","diff_url":"https://github.com/servo/servo/pull/15503.diff","patch_url":"https://github.com/servo/servo/pull/15503.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nThink this is getting pretty close now.\r\n\r\nMade some ugly edits to try and ensure exact functionality is preserved with iterators.  Once I identify the issue I'm seeing, I'll clean them up.\r\n\r\nI've also temporarily made all of the places calling iterators with the new type parameters only use `Node` or `Element` - this way they should have identical functionality as they did before, which should make debugging the iterators themselves easier.\r\n\r\nOnce the iterators are done, we can clean up where they're being called from as well.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #15270 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/15503)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/283364913","html_url":"https://github.com/servo/servo/pull/15503#issuecomment-283364913","issue_url":"https://api.github.com/repos/servo/servo/issues/15503","id":283364913,"user":{"login":"DominoTree","id":5438118,"avatar_url":"https://avatars0.githubusercontent.com/u/5438118?v=3","gravatar_id":"","url":"https://api.github.com/users/DominoTree","html_url":"https://github.com/DominoTree","followers_url":"https://api.github.com/users/DominoTree/followers","following_url":"https://api.github.com/users/DominoTree/following{/other_user}","gists_url":"https://api.github.com/users/DominoTree/gists{/gist_id}","starred_url":"https://api.github.com/users/DominoTree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominoTree/subscriptions","organizations_url":"https://api.github.com/users/DominoTree/orgs","repos_url":"https://api.github.com/users/DominoTree/repos","events_url":"https://api.github.com/users/DominoTree/events{/privacy}","received_events_url":"https://api.github.com/users/DominoTree/received_events","type":"User","site_admin":false},"created_at":"2017-03-01T15:05:48Z","updated_at":"2017-03-01T15:05:48Z","body":"Sorry, in the first commit, if you look at the `impl`s for `SiblingIterator` `ReverseSiblingIterator` and `FollowingIterator`, they use `while` loops to continue over subsequent elements if they fail to cast the first element they encounter.  I believe all of the iterators should probably behave this way."}}
{"actor":{"display_login":"DominoTree"}}