{"action":"closed","number":342,"pull_request":{"url":"https://api.github.com/repos/acquia/lightning/pulls/342","id":116336790,"html_url":"https://github.com/acquia/lightning/pull/342","diff_url":"https://github.com/acquia/lightning/pull/342.diff","patch_url":"https://github.com/acquia/lightning/pull/342.patch","issue_url":"https://api.github.com/repos/acquia/lightning/issues/342","number":342,"state":"closed","locked":false,"title":"ModerationAwareEntityFormTrait is not very smart","user":{"login":"phenaproxima","id":4504530,"avatar_url":"https://avatars1.githubusercontent.com/u/4504530?v=3","gravatar_id":"","url":"https://api.github.com/users/phenaproxima","html_url":"https://github.com/phenaproxima","followers_url":"https://api.github.com/users/phenaproxima/followers","following_url":"https://api.github.com/users/phenaproxima/following{/other_user}","gists_url":"https://api.github.com/users/phenaproxima/gists{/gist_id}","starred_url":"https://api.github.com/users/phenaproxima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenaproxima/subscriptions","organizations_url":"https://api.github.com/users/phenaproxima/orgs","repos_url":"https://api.github.com/users/phenaproxima/repos","events_url":"https://api.github.com/users/phenaproxima/events{/privacy}","received_events_url":"https://api.github.com/users/phenaproxima/received_events","type":"User","site_admin":false},"body":"This PR addresses https://www.drupal.org/node/2867465.\r\n\r\nIn a nutshell, the problem is that our NodeForm::actions() method doesn't bother to check if the entity being worked on is, in fact, moderatable. So it goes and mucks with the buttons even if it shouldn't. This adds a check to prevent that, plus a regression test.","created_at":"2017-04-18T14:11:15Z","updated_at":"2017-04-18T14:38:44Z","closed_at":"2017-04-18T14:38:44Z","merged_at":null,"merge_commit_sha":"1eab53cacd377c4d9c60f36d125ae2fcb51e65c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/acquia/lightning/pulls/342/commits","review_comments_url":"https://api.github.com/repos/acquia/lightning/pulls/342/comments","review_comment_url":"https://api.github.com/repos/acquia/lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquia/lightning/issues/342/comments","statuses_url":"https://api.github.com/repos/acquia/lightning/statuses/0dcd5eea298184748b46f3e1dd949634b67a8abc","head":{"label":"phenaproxima:moderation-form","ref":"moderation-form","sha":"0dcd5eea298184748b46f3e1dd949634b67a8abc","user":{"login":"phenaproxima","id":4504530,"avatar_url":"https://avatars1.githubusercontent.com/u/4504530?v=3","gravatar_id":"","url":"https://api.github.com/users/phenaproxima","html_url":"https://github.com/phenaproxima","followers_url":"https://api.github.com/users/phenaproxima/followers","following_url":"https://api.github.com/users/phenaproxima/following{/other_user}","gists_url":"https://api.github.com/users/phenaproxima/gists{/gist_id}","starred_url":"https://api.github.com/users/phenaproxima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenaproxima/subscriptions","organizations_url":"https://api.github.com/users/phenaproxima/orgs","repos_url":"https://api.github.com/users/phenaproxima/repos","events_url":"https://api.github.com/users/phenaproxima/events{/privacy}","received_events_url":"https://api.github.com/users/phenaproxima/received_events","type":"User","site_admin":false},"repo":{"id":84952547,"name":"lightning","full_name":"phenaproxima/lightning","owner":{"login":"phenaproxima","id":4504530,"avatar_url":"https://avatars1.githubusercontent.com/u/4504530?v=3","gravatar_id":"","url":"https://api.github.com/users/phenaproxima","html_url":"https://github.com/phenaproxima","followers_url":"https://api.github.com/users/phenaproxima/followers","following_url":"https://api.github.com/users/phenaproxima/following{/other_user}","gists_url":"https://api.github.com/users/phenaproxima/gists{/gist_id}","starred_url":"https://api.github.com/users/phenaproxima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phenaproxima/subscriptions","organizations_url":"https://api.github.com/users/phenaproxima/orgs","repos_url":"https://api.github.com/users/phenaproxima/repos","events_url":"https://api.github.com/users/phenaproxima/events{/privacy}","received_events_url":"https://api.github.com/users/phenaproxima/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phenaproxima/lightning","description":"Lightning is a base distribution for fast and feature-rich Drupal. Mirror of","fork":true,"url":"https://api.github.com/repos/phenaproxima/lightning","forks_url":"https://api.github.com/repos/phenaproxima/lightning/forks","keys_url":"https://api.github.com/repos/phenaproxima/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phenaproxima/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phenaproxima/lightning/teams","hooks_url":"https://api.github.com/repos/phenaproxima/lightning/hooks","issue_events_url":"https://api.github.com/repos/phenaproxima/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/phenaproxima/lightning/events","assignees_url":"https://api.github.com/repos/phenaproxima/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/phenaproxima/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/phenaproxima/lightning/tags","blobs_url":"https://api.github.com/repos/phenaproxima/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phenaproxima/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phenaproxima/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/phenaproxima/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phenaproxima/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/phenaproxima/lightning/languages","stargazers_url":"https://api.github.com/repos/phenaproxima/lightning/stargazers","contributors_url":"https://api.github.com/repos/phenaproxima/lightning/contributors","subscribers_url":"https://api.github.com/repos/phenaproxima/lightning/subscribers","subscription_url":"https://api.github.com/repos/phenaproxima/lightning/subscription","commits_url":"https://api.github.com/repos/phenaproxima/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/phenaproxima/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/phenaproxima/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/phenaproxima/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/phenaproxima/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/phenaproxima/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phenaproxima/lightning/merges","archive_url":"https://api.github.com/repos/phenaproxima/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phenaproxima/lightning/downloads","issues_url":"https://api.github.com/repos/phenaproxima/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/phenaproxima/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/phenaproxima/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/phenaproxima/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phenaproxima/lightning/labels{/name}","releases_url":"https://api.github.com/repos/phenaproxima/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/phenaproxima/lightning/deployments","created_at":"2017-03-14T13:31:39Z","updated_at":"2017-03-14T13:31:42Z","pushed_at":"2017-04-18T13:52:44Z","git_url":"git://github.com/phenaproxima/lightning.git","ssh_url":"git@github.com:phenaproxima/lightning.git","clone_url":"https://github.com/phenaproxima/lightning.git","svn_url":"https://github.com/phenaproxima/lightning","homepage":"http://www.drupal.org/project/lightning","size":13369,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-2.x"}},"base":{"label":"acquia:8.x-2.x","ref":"8.x-2.x","sha":"5bda81af95224dbaac4095880c1553867651a099","user":{"login":"acquia","id":514789,"avatar_url":"https://avatars3.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":24332667,"name":"lightning","full_name":"acquia/lightning","owner":{"login":"acquia","id":514789,"avatar_url":"https://avatars3.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquia/lightning","description":"Lightning is a base distribution for fast and feature-rich Drupal. Mirror of","fork":false,"url":"https://api.github.com/repos/acquia/lightning","forks_url":"https://api.github.com/repos/acquia/lightning/forks","keys_url":"https://api.github.com/repos/acquia/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/lightning/teams","hooks_url":"https://api.github.com/repos/acquia/lightning/hooks","issue_events_url":"https://api.github.com/repos/acquia/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/lightning/events","assignees_url":"https://api.github.com/repos/acquia/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/lightning/tags","blobs_url":"https://api.github.com/repos/acquia/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/lightning/languages","stargazers_url":"https://api.github.com/repos/acquia/lightning/stargazers","contributors_url":"https://api.github.com/repos/acquia/lightning/contributors","subscribers_url":"https://api.github.com/repos/acquia/lightning/subscribers","subscription_url":"https://api.github.com/repos/acquia/lightning/subscription","commits_url":"https://api.github.com/repos/acquia/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/lightning/merges","archive_url":"https://api.github.com/repos/acquia/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/lightning/downloads","issues_url":"https://api.github.com/repos/acquia/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/lightning/labels{/name}","releases_url":"https://api.github.com/repos/acquia/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/acquia/lightning/deployments","created_at":"2014-09-22T14:49:49Z","updated_at":"2017-04-06T15:28:53Z","pushed_at":"2017-04-18T14:37:49Z","git_url":"git://github.com/acquia/lightning.git","ssh_url":"git@github.com:acquia/lightning.git","clone_url":"https://github.com/acquia/lightning.git","svn_url":"https://github.com/acquia/lightning","homepage":"http://www.drupal.org/project/lightning","size":13080,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":38,"forks":52,"open_issues":38,"watchers":77,"default_branch":"8.x-2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/acquia/lightning/pulls/342"},"html":{"href":"https://github.com/acquia/lightning/pull/342"},"issue":{"href":"https://api.github.com/repos/acquia/lightning/issues/342"},"comments":{"href":"https://api.github.com/repos/acquia/lightning/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/acquia/lightning/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/acquia/lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquia/lightning/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/acquia/lightning/statuses/0dcd5eea298184748b46f3e1dd949634b67a8abc"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"balsama"}}