{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/138339263","pull_request_review_id":62120131,"id":138339263,"diff_hunk":"@@ -30,9 +30,9 @@ namespace livre\n struct Workers::Impl\n {\n     Impl(const std::string& name, Workers& workers, const size_t nThreads,\n-         const ConstGLContextPtr& glContext)\n+         const GLContext& glContext)\n         : _workers(workers)\n-        , _glContext(glContext)\n+        , _glContext(glContext.clone())","path":"livre/core/pipeline/Workers.cpp","position":8,"original_position":8,"commit_id":"03d43b4229c6d6f50e72d69a2095d94e3421dd41","original_commit_id":"03d43b4229c6d6f50e72d69a2095d94e3421dd41","user":{"login":"eile","id":354947,"avatar_url":"https://avatars0.githubusercontent.com/u/354947?v=4","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":"This whole code needs rewriting.\r\n\r\nIt needs to be cloned, since if it's done later in the worker thread, the cloned context cannot be current (otherwise Windows says no-no). This code is not ideal, but what can you do...\r\n","created_at":"2017-09-12T12:59:32Z","updated_at":"2017-09-12T12:59:32Z","html_url":"https://github.com/BlueBrain/Livre/pull/403#discussion_r138339263","pull_request_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/403","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/138339263"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/403#discussion_r138339263"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/403"}},"in_reply_to_id":138326760},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/403","id":139323632,"html_url":"https://github.com/BlueBrain/Livre/pull/403","diff_url":"https://github.com/BlueBrain/Livre/pull/403.diff","patch_url":"https://github.com/BlueBrain/Livre/pull/403.patch","issue_url":"https://api.github.com/repos/BlueBrain/Livre/issues/403","number":403,"state":"open","locked":false,"title":"Cleanups","user":{"login":"eile","id":354947,"avatar_url":"https://avatars0.githubusercontent.com/u/354947?v=4","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-09-05T13:28:17Z","updated_at":"2017-09-12T12:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c23fe6a61b7a2760c0cde8e3ef727b366c27f11","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars3.githubusercontent.com/u/701401?v=4","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/403/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/403/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/issues/403/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/03d43b4229c6d6f50e72d69a2095d94e3421dd41","head":{"label":"eile:master","ref":"master","sha":"03d43b4229c6d6f50e72d69a2095d94e3421dd41","user":{"login":"eile","id":354947,"avatar_url":"https://avatars0.githubusercontent.com/u/354947?v=4","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"repo":{"id":10643206,"name":"Livre","full_name":"eile/Livre","owner":{"login":"eile","id":354947,"avatar_url":"https://avatars0.githubusercontent.com/u/354947?v=4","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eile/Livre","description":"LOD-based Interactive Volume Rendering Engine","fork":true,"url":"https://api.github.com/repos/eile/Livre","forks_url":"https://api.github.com/repos/eile/Livre/forks","keys_url":"https://api.github.com/repos/eile/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eile/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eile/Livre/teams","hooks_url":"https://api.github.com/repos/eile/Livre/hooks","issue_events_url":"https://api.github.com/repos/eile/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/eile/Livre/events","assignees_url":"https://api.github.com/repos/eile/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/eile/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/eile/Livre/tags","blobs_url":"https://api.github.com/repos/eile/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eile/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eile/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/eile/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eile/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/eile/Livre/languages","stargazers_url":"https://api.github.com/repos/eile/Livre/stargazers","contributors_url":"https://api.github.com/repos/eile/Livre/contributors","subscribers_url":"https://api.github.com/repos/eile/Livre/subscribers","subscription_url":"https://api.github.com/repos/eile/Livre/subscription","commits_url":"https://api.github.com/repos/eile/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/eile/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/eile/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/eile/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/eile/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/eile/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eile/Livre/merges","archive_url":"https://api.github.com/repos/eile/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eile/Livre/downloads","issues_url":"https://api.github.com/repos/eile/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/eile/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/eile/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/eile/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eile/Livre/labels{/name}","releases_url":"https://api.github.com/repos/eile/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/eile/Livre/deployments","created_at":"2013-06-12T13:19:17Z","updated_at":"2015-05-05T08:02:29Z","pushed_at":"2017-09-11T13:06:43Z","git_url":"git://github.com/eile/Livre.git","ssh_url":"git@github.com:eile/Livre.git","clone_url":"https://github.com/eile/Livre.git","svn_url":"https://github.com/eile/Livre","homepage":null,"size":9027,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"857ed21906a8e8d12cb6767856dfa3e42487b97d","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":10625435,"name":"Livre","full_name":"BlueBrain/Livre","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Livre","description":"Large-scale Interactive Volume Rendering Engine","fork":false,"url":"https://api.github.com/repos/BlueBrain/Livre","forks_url":"https://api.github.com/repos/BlueBrain/Livre/forks","keys_url":"https://api.github.com/repos/BlueBrain/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Livre/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Livre/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Livre/events","assignees_url":"https://api.github.com/repos/BlueBrain/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Livre/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Livre/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Livre/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Livre/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Livre/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Livre/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Livre/merges","archive_url":"https://api.github.com/repos/BlueBrain/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Livre/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Livre/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Livre/deployments","created_at":"2013-06-11T16:13:56Z","updated_at":"2017-06-26T08:56:07Z","pushed_at":"2017-09-11T13:06:44Z","git_url":"git://github.com/BlueBrain/Livre.git","ssh_url":"git@github.com:BlueBrain/Livre.git","clone_url":"https://github.com/BlueBrain/Livre.git","svn_url":"https://github.com/BlueBrain/Livre","homepage":"https://bluebrain.github.io","size":8947,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":25,"forks":17,"open_issues":25,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/403"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/403"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/403"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Livre/statuses/03d43b4229c6d6f50e72d69a2095d94e3421dd41"}},"author_association":"OWNER"}}
{"actor":{"display_login":"eile"}}