{"action":"opened","number":720,"pull_request":{"url":"https://api.github.com/repos/mxcl/PromiseKit/pulls/720","id":145615315,"html_url":"https://github.com/mxcl/PromiseKit/pull/720","diff_url":"https://github.com/mxcl/PromiseKit/pull/720.diff","patch_url":"https://github.com/mxcl/PromiseKit/pull/720.patch","issue_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/720","number":720,"state":"open","locked":false,"title":"Fix potential error in sample code of Getting Started","user":{"login":"juli1quere","id":231661,"avatar_url":"https://avatars2.githubusercontent.com/u/231661?v=4","gravatar_id":"","url":"https://api.github.com/users/juli1quere","html_url":"https://github.com/juli1quere","followers_url":"https://api.github.com/users/juli1quere/followers","following_url":"https://api.github.com/users/juli1quere/following{/other_user}","gists_url":"https://api.github.com/users/juli1quere/gists{/gist_id}","starred_url":"https://api.github.com/users/juli1quere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juli1quere/subscriptions","organizations_url":"https://api.github.com/users/juli1quere/orgs","repos_url":"https://api.github.com/users/juli1quere/repos","events_url":"https://api.github.com/users/juli1quere/events{/privacy}","received_events_url":"https://api.github.com/users/juli1quere/received_events","type":"User","site_admin":false},"body":"Hello, \r\n\r\nI’m discovering PromiseKit (it’s been on my todolist for a long time). So I’m reading the « Getting started », and I think there is a typo in the code to create our own Promise. Indeed, in the case of an error, the sample code call `fulfill(error)`. But I think it should be `reject(error)`. \r\n\r\nIt may be the result of a misunderstanding from me. If it is: I’m sorry ! \r\n\r\nThanks for your good work ! ","created_at":"2017-10-10T07:17:11Z","updated_at":"2017-10-10T07:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mxcl/PromiseKit/pulls/720/commits","review_comments_url":"https://api.github.com/repos/mxcl/PromiseKit/pulls/720/comments","review_comment_url":"https://api.github.com/repos/mxcl/PromiseKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/720/comments","statuses_url":"https://api.github.com/repos/mxcl/PromiseKit/statuses/d85f621cf3a778e452d62a83e38509657035ca34","head":{"label":"juli1quere:patch-1","ref":"patch-1","sha":"d85f621cf3a778e452d62a83e38509657035ca34","user":{"login":"juli1quere","id":231661,"avatar_url":"https://avatars2.githubusercontent.com/u/231661?v=4","gravatar_id":"","url":"https://api.github.com/users/juli1quere","html_url":"https://github.com/juli1quere","followers_url":"https://api.github.com/users/juli1quere/followers","following_url":"https://api.github.com/users/juli1quere/following{/other_user}","gists_url":"https://api.github.com/users/juli1quere/gists{/gist_id}","starred_url":"https://api.github.com/users/juli1quere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juli1quere/subscriptions","organizations_url":"https://api.github.com/users/juli1quere/orgs","repos_url":"https://api.github.com/users/juli1quere/repos","events_url":"https://api.github.com/users/juli1quere/events{/privacy}","received_events_url":"https://api.github.com/users/juli1quere/received_events","type":"User","site_admin":false},"repo":{"id":106381325,"name":"PromiseKit","full_name":"juli1quere/PromiseKit","owner":{"login":"juli1quere","id":231661,"avatar_url":"https://avatars2.githubusercontent.com/u/231661?v=4","gravatar_id":"","url":"https://api.github.com/users/juli1quere","html_url":"https://github.com/juli1quere","followers_url":"https://api.github.com/users/juli1quere/followers","following_url":"https://api.github.com/users/juli1quere/following{/other_user}","gists_url":"https://api.github.com/users/juli1quere/gists{/gist_id}","starred_url":"https://api.github.com/users/juli1quere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juli1quere/subscriptions","organizations_url":"https://api.github.com/users/juli1quere/orgs","repos_url":"https://api.github.com/users/juli1quere/repos","events_url":"https://api.github.com/users/juli1quere/events{/privacy}","received_events_url":"https://api.github.com/users/juli1quere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juli1quere/PromiseKit","description":"Promises for Swift & ObjC","fork":true,"url":"https://api.github.com/repos/juli1quere/PromiseKit","forks_url":"https://api.github.com/repos/juli1quere/PromiseKit/forks","keys_url":"https://api.github.com/repos/juli1quere/PromiseKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juli1quere/PromiseKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juli1quere/PromiseKit/teams","hooks_url":"https://api.github.com/repos/juli1quere/PromiseKit/hooks","issue_events_url":"https://api.github.com/repos/juli1quere/PromiseKit/issues/events{/number}","events_url":"https://api.github.com/repos/juli1quere/PromiseKit/events","assignees_url":"https://api.github.com/repos/juli1quere/PromiseKit/assignees{/user}","branches_url":"https://api.github.com/repos/juli1quere/PromiseKit/branches{/branch}","tags_url":"https://api.github.com/repos/juli1quere/PromiseKit/tags","blobs_url":"https://api.github.com/repos/juli1quere/PromiseKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juli1quere/PromiseKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juli1quere/PromiseKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/juli1quere/PromiseKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juli1quere/PromiseKit/statuses/{sha}","languages_url":"https://api.github.com/repos/juli1quere/PromiseKit/languages","stargazers_url":"https://api.github.com/repos/juli1quere/PromiseKit/stargazers","contributors_url":"https://api.github.com/repos/juli1quere/PromiseKit/contributors","subscribers_url":"https://api.github.com/repos/juli1quere/PromiseKit/subscribers","subscription_url":"https://api.github.com/repos/juli1quere/PromiseKit/subscription","commits_url":"https://api.github.com/repos/juli1quere/PromiseKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/juli1quere/PromiseKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/juli1quere/PromiseKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/juli1quere/PromiseKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/juli1quere/PromiseKit/contents/{+path}","compare_url":"https://api.github.com/repos/juli1quere/PromiseKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juli1quere/PromiseKit/merges","archive_url":"https://api.github.com/repos/juli1quere/PromiseKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juli1quere/PromiseKit/downloads","issues_url":"https://api.github.com/repos/juli1quere/PromiseKit/issues{/number}","pulls_url":"https://api.github.com/repos/juli1quere/PromiseKit/pulls{/number}","milestones_url":"https://api.github.com/repos/juli1quere/PromiseKit/milestones{/number}","notifications_url":"https://api.github.com/repos/juli1quere/PromiseKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juli1quere/PromiseKit/labels{/name}","releases_url":"https://api.github.com/repos/juli1quere/PromiseKit/releases{/id}","deployments_url":"https://api.github.com/repos/juli1quere/PromiseKit/deployments","created_at":"2017-10-10T07:10:50Z","updated_at":"2017-10-10T07:10:52Z","pushed_at":"2017-10-10T07:13:19Z","git_url":"git://github.com/juli1quere/PromiseKit.git","ssh_url":"git@github.com:juli1quere/PromiseKit.git","clone_url":"https://github.com/juli1quere/PromiseKit.git","svn_url":"https://github.com/juli1quere/PromiseKit","homepage":"http://promisekit.org","size":2581,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mxcl:master","ref":"master","sha":"58f77597b0be61a51bcfb5683d0cfc20e66fc53b","user":{"login":"mxcl","id":58962,"avatar_url":"https://avatars2.githubusercontent.com/u/58962?v=4","gravatar_id":"","url":"https://api.github.com/users/mxcl","html_url":"https://github.com/mxcl","followers_url":"https://api.github.com/users/mxcl/followers","following_url":"https://api.github.com/users/mxcl/following{/other_user}","gists_url":"https://api.github.com/users/mxcl/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcl/subscriptions","organizations_url":"https://api.github.com/users/mxcl/orgs","repos_url":"https://api.github.com/users/mxcl/repos","events_url":"https://api.github.com/users/mxcl/events{/privacy}","received_events_url":"https://api.github.com/users/mxcl/received_events","type":"User","site_admin":false},"repo":{"id":18440563,"name":"PromiseKit","full_name":"mxcl/PromiseKit","owner":{"login":"mxcl","id":58962,"avatar_url":"https://avatars2.githubusercontent.com/u/58962?v=4","gravatar_id":"","url":"https://api.github.com/users/mxcl","html_url":"https://github.com/mxcl","followers_url":"https://api.github.com/users/mxcl/followers","following_url":"https://api.github.com/users/mxcl/following{/other_user}","gists_url":"https://api.github.com/users/mxcl/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcl/subscriptions","organizations_url":"https://api.github.com/users/mxcl/orgs","repos_url":"https://api.github.com/users/mxcl/repos","events_url":"https://api.github.com/users/mxcl/events{/privacy}","received_events_url":"https://api.github.com/users/mxcl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxcl/PromiseKit","description":"Promises for Swift & ObjC","fork":false,"url":"https://api.github.com/repos/mxcl/PromiseKit","forks_url":"https://api.github.com/repos/mxcl/PromiseKit/forks","keys_url":"https://api.github.com/repos/mxcl/PromiseKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxcl/PromiseKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxcl/PromiseKit/teams","hooks_url":"https://api.github.com/repos/mxcl/PromiseKit/hooks","issue_events_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/events{/number}","events_url":"https://api.github.com/repos/mxcl/PromiseKit/events","assignees_url":"https://api.github.com/repos/mxcl/PromiseKit/assignees{/user}","branches_url":"https://api.github.com/repos/mxcl/PromiseKit/branches{/branch}","tags_url":"https://api.github.com/repos/mxcl/PromiseKit/tags","blobs_url":"https://api.github.com/repos/mxcl/PromiseKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxcl/PromiseKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxcl/PromiseKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxcl/PromiseKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxcl/PromiseKit/statuses/{sha}","languages_url":"https://api.github.com/repos/mxcl/PromiseKit/languages","stargazers_url":"https://api.github.com/repos/mxcl/PromiseKit/stargazers","contributors_url":"https://api.github.com/repos/mxcl/PromiseKit/contributors","subscribers_url":"https://api.github.com/repos/mxcl/PromiseKit/subscribers","subscription_url":"https://api.github.com/repos/mxcl/PromiseKit/subscription","commits_url":"https://api.github.com/repos/mxcl/PromiseKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxcl/PromiseKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxcl/PromiseKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxcl/PromiseKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxcl/PromiseKit/contents/{+path}","compare_url":"https://api.github.com/repos/mxcl/PromiseKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxcl/PromiseKit/merges","archive_url":"https://api.github.com/repos/mxcl/PromiseKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxcl/PromiseKit/downloads","issues_url":"https://api.github.com/repos/mxcl/PromiseKit/issues{/number}","pulls_url":"https://api.github.com/repos/mxcl/PromiseKit/pulls{/number}","milestones_url":"https://api.github.com/repos/mxcl/PromiseKit/milestones{/number}","notifications_url":"https://api.github.com/repos/mxcl/PromiseKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxcl/PromiseKit/labels{/name}","releases_url":"https://api.github.com/repos/mxcl/PromiseKit/releases{/id}","deployments_url":"https://api.github.com/repos/mxcl/PromiseKit/deployments","created_at":"2014-04-04T13:54:37Z","updated_at":"2017-10-09T22:03:33Z","pushed_at":"2017-10-08T18:54:22Z","git_url":"git://github.com/mxcl/PromiseKit.git","ssh_url":"git@github.com:mxcl/PromiseKit.git","clone_url":"https://github.com/mxcl/PromiseKit.git","svn_url":"https://github.com/mxcl/PromiseKit","homepage":"http://promisekit.org","size":2581,"stargazers_count":8310,"watchers_count":8310,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":754,"mirror_url":null,"open_issues_count":29,"forks":754,"open_issues":29,"watchers":8310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxcl/PromiseKit/pulls/720"},"html":{"href":"https://github.com/mxcl/PromiseKit/pull/720"},"issue":{"href":"https://api.github.com/repos/mxcl/PromiseKit/issues/720"},"comments":{"href":"https://api.github.com/repos/mxcl/PromiseKit/issues/720/comments"},"review_comments":{"href":"https://api.github.com/repos/mxcl/PromiseKit/pulls/720/comments"},"review_comment":{"href":"https://api.github.com/repos/mxcl/PromiseKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxcl/PromiseKit/pulls/720/commits"},"statuses":{"href":"https://api.github.com/repos/mxcl/PromiseKit/statuses/d85f621cf3a778e452d62a83e38509657035ca34"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"juli1quere"}}