{"action":"closed","number":754,"pull_request":{"url":"https://api.github.com/repos/celery/kombu/pulls/754","id":126109624,"html_url":"https://github.com/celery/kombu/pull/754","diff_url":"https://github.com/celery/kombu/pull/754.diff","patch_url":"https://github.com/celery/kombu/pull/754.patch","issue_url":"https://api.github.com/repos/celery/kombu/issues/754","number":754,"state":"closed","locked":false,"title":"Fix SQS requests and response handling","user":{"login":"alukach","id":897290,"avatar_url":"https://avatars4.githubusercontent.com/u/897290?v=4","gravatar_id":"","url":"https://api.github.com/users/alukach","html_url":"https://github.com/alukach","followers_url":"https://api.github.com/users/alukach/followers","following_url":"https://api.github.com/users/alukach/following{/other_user}","gists_url":"https://api.github.com/users/alukach/gists{/gist_id}","starred_url":"https://api.github.com/users/alukach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alukach/subscriptions","organizations_url":"https://api.github.com/users/alukach/orgs","repos_url":"https://api.github.com/users/alukach/repos","events_url":"https://api.github.com/users/alukach/events{/privacy}","received_events_url":"https://api.github.com/users/alukach/received_events","type":"User","site_admin":false},"body":"This PR contains three bugfixes for the SQS transport:\r\n\r\n* The `_get_bulk` and `_get` methods should take advantage of long-polling.\r\n* I was running into an error where `resp['Messages']` would throw a `KeyError`. Admittedly, I don't recall exactly what situation this occurred during, I believe that it was when using a Kombu Consumer to read off of a queue with non-celery messages.  Nonetheless, I believe using `resp.get('Messages')` should have no negative effect to current operation but grant more flexibility to SQS message format.  If someone feels like this flexibility is a bad idea, let me know and I can attempt to recreate how I was running into the `KeyError`.\r\n* The `_get` method fails as `receive_message` on the `Boto3` session expects only keyword arguments.","created_at":"2017-06-16T20:31:46Z","updated_at":"2017-07-17T15:22:41Z","closed_at":"2017-07-17T15:22:41Z","merged_at":"2017-07-17T15:22:41Z","merge_commit_sha":"b1e6fa5bb196a3b4b3847827dc96f39adfac6605","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/celery/kombu/pulls/754/commits","review_comments_url":"https://api.github.com/repos/celery/kombu/pulls/754/comments","review_comment_url":"https://api.github.com/repos/celery/kombu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/celery/kombu/issues/754/comments","statuses_url":"https://api.github.com/repos/celery/kombu/statuses/c71fb831265948cb526aad31b754c3332f1dd161","head":{"label":"alukach:patch-4","ref":"patch-4","sha":"c71fb831265948cb526aad31b754c3332f1dd161","user":{"login":"alukach","id":897290,"avatar_url":"https://avatars4.githubusercontent.com/u/897290?v=4","gravatar_id":"","url":"https://api.github.com/users/alukach","html_url":"https://github.com/alukach","followers_url":"https://api.github.com/users/alukach/followers","following_url":"https://api.github.com/users/alukach/following{/other_user}","gists_url":"https://api.github.com/users/alukach/gists{/gist_id}","starred_url":"https://api.github.com/users/alukach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alukach/subscriptions","organizations_url":"https://api.github.com/users/alukach/orgs","repos_url":"https://api.github.com/users/alukach/repos","events_url":"https://api.github.com/users/alukach/events{/privacy}","received_events_url":"https://api.github.com/users/alukach/received_events","type":"User","site_admin":false},"repo":{"id":88240814,"name":"kombu","full_name":"alukach/kombu","owner":{"login":"alukach","id":897290,"avatar_url":"https://avatars4.githubusercontent.com/u/897290?v=4","gravatar_id":"","url":"https://api.github.com/users/alukach","html_url":"https://github.com/alukach","followers_url":"https://api.github.com/users/alukach/followers","following_url":"https://api.github.com/users/alukach/following{/other_user}","gists_url":"https://api.github.com/users/alukach/gists{/gist_id}","starred_url":"https://api.github.com/users/alukach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alukach/subscriptions","organizations_url":"https://api.github.com/users/alukach/orgs","repos_url":"https://api.github.com/users/alukach/repos","events_url":"https://api.github.com/users/alukach/events{/privacy}","received_events_url":"https://api.github.com/users/alukach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alukach/kombu","description":"Messaging library for Python.","fork":true,"url":"https://api.github.com/repos/alukach/kombu","forks_url":"https://api.github.com/repos/alukach/kombu/forks","keys_url":"https://api.github.com/repos/alukach/kombu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alukach/kombu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alukach/kombu/teams","hooks_url":"https://api.github.com/repos/alukach/kombu/hooks","issue_events_url":"https://api.github.com/repos/alukach/kombu/issues/events{/number}","events_url":"https://api.github.com/repos/alukach/kombu/events","assignees_url":"https://api.github.com/repos/alukach/kombu/assignees{/user}","branches_url":"https://api.github.com/repos/alukach/kombu/branches{/branch}","tags_url":"https://api.github.com/repos/alukach/kombu/tags","blobs_url":"https://api.github.com/repos/alukach/kombu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alukach/kombu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alukach/kombu/git/refs{/sha}","trees_url":"https://api.github.com/repos/alukach/kombu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alukach/kombu/statuses/{sha}","languages_url":"https://api.github.com/repos/alukach/kombu/languages","stargazers_url":"https://api.github.com/repos/alukach/kombu/stargazers","contributors_url":"https://api.github.com/repos/alukach/kombu/contributors","subscribers_url":"https://api.github.com/repos/alukach/kombu/subscribers","subscription_url":"https://api.github.com/repos/alukach/kombu/subscription","commits_url":"https://api.github.com/repos/alukach/kombu/commits{/sha}","git_commits_url":"https://api.github.com/repos/alukach/kombu/git/commits{/sha}","comments_url":"https://api.github.com/repos/alukach/kombu/comments{/number}","issue_comment_url":"https://api.github.com/repos/alukach/kombu/issues/comments{/number}","contents_url":"https://api.github.com/repos/alukach/kombu/contents/{+path}","compare_url":"https://api.github.com/repos/alukach/kombu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alukach/kombu/merges","archive_url":"https://api.github.com/repos/alukach/kombu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alukach/kombu/downloads","issues_url":"https://api.github.com/repos/alukach/kombu/issues{/number}","pulls_url":"https://api.github.com/repos/alukach/kombu/pulls{/number}","milestones_url":"https://api.github.com/repos/alukach/kombu/milestones{/number}","notifications_url":"https://api.github.com/repos/alukach/kombu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alukach/kombu/labels{/name}","releases_url":"https://api.github.com/repos/alukach/kombu/releases{/id}","deployments_url":"https://api.github.com/repos/alukach/kombu/deployments","created_at":"2017-04-14T06:43:15Z","updated_at":"2017-04-14T06:43:18Z","pushed_at":"2017-06-24T23:52:18Z","git_url":"git://github.com/alukach/kombu.git","ssh_url":"git@github.com:alukach/kombu.git","clone_url":"https://github.com/alukach/kombu.git","svn_url":"https://github.com/alukach/kombu","homepage":"http://kombu.readthedocs.org/","size":6895,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"celery:master","ref":"master","sha":"09bd23bbd83344b09cbf38b7257107e560db9f25","user":{"login":"celery","id":319983,"avatar_url":"https://avatars6.githubusercontent.com/u/319983?v=4","gravatar_id":"","url":"https://api.github.com/users/celery","html_url":"https://github.com/celery","followers_url":"https://api.github.com/users/celery/followers","following_url":"https://api.github.com/users/celery/following{/other_user}","gists_url":"https://api.github.com/users/celery/gists{/gist_id}","starred_url":"https://api.github.com/users/celery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celery/subscriptions","organizations_url":"https://api.github.com/users/celery/orgs","repos_url":"https://api.github.com/users/celery/repos","events_url":"https://api.github.com/users/celery/events{/privacy}","received_events_url":"https://api.github.com/users/celery/received_events","type":"Organization","site_admin":false},"repo":{"id":735498,"name":"kombu","full_name":"celery/kombu","owner":{"login":"celery","id":319983,"avatar_url":"https://avatars6.githubusercontent.com/u/319983?v=4","gravatar_id":"","url":"https://api.github.com/users/celery","html_url":"https://github.com/celery","followers_url":"https://api.github.com/users/celery/followers","following_url":"https://api.github.com/users/celery/following{/other_user}","gists_url":"https://api.github.com/users/celery/gists{/gist_id}","starred_url":"https://api.github.com/users/celery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celery/subscriptions","organizations_url":"https://api.github.com/users/celery/orgs","repos_url":"https://api.github.com/users/celery/repos","events_url":"https://api.github.com/users/celery/events{/privacy}","received_events_url":"https://api.github.com/users/celery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/celery/kombu","description":"Messaging library for Python.","fork":false,"url":"https://api.github.com/repos/celery/kombu","forks_url":"https://api.github.com/repos/celery/kombu/forks","keys_url":"https://api.github.com/repos/celery/kombu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/celery/kombu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/celery/kombu/teams","hooks_url":"https://api.github.com/repos/celery/kombu/hooks","issue_events_url":"https://api.github.com/repos/celery/kombu/issues/events{/number}","events_url":"https://api.github.com/repos/celery/kombu/events","assignees_url":"https://api.github.com/repos/celery/kombu/assignees{/user}","branches_url":"https://api.github.com/repos/celery/kombu/branches{/branch}","tags_url":"https://api.github.com/repos/celery/kombu/tags","blobs_url":"https://api.github.com/repos/celery/kombu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/celery/kombu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/celery/kombu/git/refs{/sha}","trees_url":"https://api.github.com/repos/celery/kombu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/celery/kombu/statuses/{sha}","languages_url":"https://api.github.com/repos/celery/kombu/languages","stargazers_url":"https://api.github.com/repos/celery/kombu/stargazers","contributors_url":"https://api.github.com/repos/celery/kombu/contributors","subscribers_url":"https://api.github.com/repos/celery/kombu/subscribers","subscription_url":"https://api.github.com/repos/celery/kombu/subscription","commits_url":"https://api.github.com/repos/celery/kombu/commits{/sha}","git_commits_url":"https://api.github.com/repos/celery/kombu/git/commits{/sha}","comments_url":"https://api.github.com/repos/celery/kombu/comments{/number}","issue_comment_url":"https://api.github.com/repos/celery/kombu/issues/comments{/number}","contents_url":"https://api.github.com/repos/celery/kombu/contents/{+path}","compare_url":"https://api.github.com/repos/celery/kombu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/celery/kombu/merges","archive_url":"https://api.github.com/repos/celery/kombu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/celery/kombu/downloads","issues_url":"https://api.github.com/repos/celery/kombu/issues{/number}","pulls_url":"https://api.github.com/repos/celery/kombu/pulls{/number}","milestones_url":"https://api.github.com/repos/celery/kombu/milestones{/number}","notifications_url":"https://api.github.com/repos/celery/kombu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/celery/kombu/labels{/name}","releases_url":"https://api.github.com/repos/celery/kombu/releases{/id}","deployments_url":"https://api.github.com/repos/celery/kombu/deployments","created_at":"2010-06-23T10:10:24Z","updated_at":"2017-07-17T05:45:16Z","pushed_at":"2017-07-17T15:22:41Z","git_url":"git://github.com/celery/kombu.git","ssh_url":"git@github.com:celery/kombu.git","clone_url":"https://github.com/celery/kombu.git","svn_url":"https://github.com/celery/kombu","homepage":"http://kombu.readthedocs.org/","size":6890,"stargazers_count":1031,"watchers_count":1031,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":452,"mirror_url":null,"open_issues_count":112,"forks":452,"open_issues":112,"watchers":1031,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/celery/kombu/pulls/754"},"html":{"href":"https://github.com/celery/kombu/pull/754"},"issue":{"href":"https://api.github.com/repos/celery/kombu/issues/754"},"comments":{"href":"https://api.github.com/repos/celery/kombu/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/celery/kombu/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/celery/kombu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/celery/kombu/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/celery/kombu/statuses/c71fb831265948cb526aad31b754c3332f1dd161"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"thedrow","id":48936,"avatar_url":"https://avatars6.githubusercontent.com/u/48936?v=4","gravatar_id":"","url":"https://api.github.com/users/thedrow","html_url":"https://github.com/thedrow","followers_url":"https://api.github.com/users/thedrow/followers","following_url":"https://api.github.com/users/thedrow/following{/other_user}","gists_url":"https://api.github.com/users/thedrow/gists{/gist_id}","starred_url":"https://api.github.com/users/thedrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedrow/subscriptions","organizations_url":"https://api.github.com/users/thedrow/orgs","repos_url":"https://api.github.com/users/thedrow/repos","events_url":"https://api.github.com/users/thedrow/events{/privacy}","received_events_url":"https://api.github.com/users/thedrow/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":10,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"thedrow"}}