{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/1","id":117292727,"html_url":"https://github.com/Chingu-cohorts/devgaido/pull/1","diff_url":"https://github.com/Chingu-cohorts/devgaido/pull/1.diff","patch_url":"https://github.com/Chingu-cohorts/devgaido/pull/1.patch","issue_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/1","number":1,"state":"closed","locked":false,"title":"Server side rendering","user":{"login":"kimkwanka","id":13664983,"avatar_url":"https://avatars0.githubusercontent.com/u/13664983?v=3","gravatar_id":"","url":"https://api.github.com/users/kimkwanka","html_url":"https://github.com/kimkwanka","followers_url":"https://api.github.com/users/kimkwanka/followers","following_url":"https://api.github.com/users/kimkwanka/following{/other_user}","gists_url":"https://api.github.com/users/kimkwanka/gists{/gist_id}","starred_url":"https://api.github.com/users/kimkwanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimkwanka/subscriptions","organizations_url":"https://api.github.com/users/kimkwanka/orgs","repos_url":"https://api.github.com/users/kimkwanka/repos","events_url":"https://api.github.com/users/kimkwanka/events{/privacy}","received_events_url":"https://api.github.com/users/kimkwanka/received_events","type":"User","site_admin":false},"body":"The first steps to make server side rendering work.\r\n\r\nChanges:\r\n+ Removed index.html and html-webpack-plugin since index.html is now created dynamically (to allow for server side rendering later on)\r\n+ Index.html is now served by Express and no longer by webpack-dev-server. Express listens on port 8080 and webpack-dev-server on 8081. The dynamically created index page takes this into account and makes sure to load the client bundle on port 8081 instead of 8080 when in development mode. (see server.js)\r\n+ Changed the \"yarn dev\" command and added npm-run-all to be able to run webpack-dev-server and the express server simultaneously with one command\r\n+ Rewrote App.jsx to use routes imported from routes.js. With the upgrade to React-Router V4 .match() is no longer available on server side - we have to use matchPath() now. Unlike its predecessor it requires the routes to be in a new format which led to App.jsx to be rewritten so that client and server could share the same routes file.\r\n+Hot Module Replacement added/fixed. Before this change, the whole page would reload on changes to the code, now it correctly handles the replacement while running.\r\n\r\nTODO:\r\n+Rewrite server code to use ES6 and add React Server Side Rendering. (Only placeholder atm)\r\n+Make it so that the server gets translated into a bundle as well so that babel can transpile all that code into something node can understand.\r\n+Check if Tree Shaking is working\r\n","created_at":"2017-04-24T15:27:52Z","updated_at":"2017-04-24T21:54:45Z","closed_at":"2017-04-24T21:54:45Z","merged_at":"2017-04-24T21:54:45Z","merge_commit_sha":"33d6776a789a393c51d08bb9bd896fd5c6bccc26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/1/comments","statuses_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/statuses/97aa10a71ee724b83feff5b3da451d3ff0fc1a35","head":{"label":"Chingu-cohorts:server-side-rendering","ref":"server-side-rendering","sha":"97aa10a71ee724b83feff5b3da451d3ff0fc1a35","user":{"login":"Chingu-cohorts","id":26086677,"avatar_url":"https://avatars2.githubusercontent.com/u/26086677?v=3","gravatar_id":"","url":"https://api.github.com/users/Chingu-cohorts","html_url":"https://github.com/Chingu-cohorts","followers_url":"https://api.github.com/users/Chingu-cohorts/followers","following_url":"https://api.github.com/users/Chingu-cohorts/following{/other_user}","gists_url":"https://api.github.com/users/Chingu-cohorts/gists{/gist_id}","starred_url":"https://api.github.com/users/Chingu-cohorts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chingu-cohorts/subscriptions","organizations_url":"https://api.github.com/users/Chingu-cohorts/orgs","repos_url":"https://api.github.com/users/Chingu-cohorts/repos","events_url":"https://api.github.com/users/Chingu-cohorts/events{/privacy}","received_events_url":"https://api.github.com/users/Chingu-cohorts/received_events","type":"Organization","site_admin":false},"repo":{"id":89068585,"name":"devgaido","full_name":"Chingu-cohorts/devgaido","owner":{"login":"Chingu-cohorts","id":26086677,"avatar_url":"https://avatars2.githubusercontent.com/u/26086677?v=3","gravatar_id":"","url":"https://api.github.com/users/Chingu-cohorts","html_url":"https://github.com/Chingu-cohorts","followers_url":"https://api.github.com/users/Chingu-cohorts/followers","following_url":"https://api.github.com/users/Chingu-cohorts/following{/other_user}","gists_url":"https://api.github.com/users/Chingu-cohorts/gists{/gist_id}","starred_url":"https://api.github.com/users/Chingu-cohorts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chingu-cohorts/subscriptions","organizations_url":"https://api.github.com/users/Chingu-cohorts/orgs","repos_url":"https://api.github.com/users/Chingu-cohorts/repos","events_url":"https://api.github.com/users/Chingu-cohorts/events{/privacy}","received_events_url":"https://api.github.com/users/Chingu-cohorts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chingu-cohorts/devgaido","description":"Chingu Learning Path application ","fork":false,"url":"https://api.github.com/repos/Chingu-cohorts/devgaido","forks_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/forks","keys_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/teams","hooks_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/hooks","issue_events_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/events{/number}","events_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/events","assignees_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/assignees{/user}","branches_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/branches{/branch}","tags_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/tags","blobs_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/statuses/{sha}","languages_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/languages","stargazers_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/stargazers","contributors_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/contributors","subscribers_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/subscribers","subscription_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/subscription","commits_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/contents/{+path}","compare_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/merges","archive_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/downloads","issues_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues{/number}","pulls_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls{/number}","milestones_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/milestones{/number}","notifications_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/labels{/name}","releases_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/releases{/id}","deployments_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/deployments","created_at":"2017-04-22T12:38:38Z","updated_at":"2017-04-24T12:38:17Z","pushed_at":"2017-04-24T21:54:45Z","git_url":"git://github.com/Chingu-cohorts/devgaido.git","ssh_url":"git@github.com:Chingu-cohorts/devgaido.git","clone_url":"https://github.com/Chingu-cohorts/devgaido.git","svn_url":"https://github.com/Chingu-cohorts/devgaido","homepage":null,"size":163,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"Chingu-cohorts:development","ref":"development","sha":"72f371c6c6f03eaf6c4f9e65aa5da84379c29177","user":{"login":"Chingu-cohorts","id":26086677,"avatar_url":"https://avatars2.githubusercontent.com/u/26086677?v=3","gravatar_id":"","url":"https://api.github.com/users/Chingu-cohorts","html_url":"https://github.com/Chingu-cohorts","followers_url":"https://api.github.com/users/Chingu-cohorts/followers","following_url":"https://api.github.com/users/Chingu-cohorts/following{/other_user}","gists_url":"https://api.github.com/users/Chingu-cohorts/gists{/gist_id}","starred_url":"https://api.github.com/users/Chingu-cohorts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chingu-cohorts/subscriptions","organizations_url":"https://api.github.com/users/Chingu-cohorts/orgs","repos_url":"https://api.github.com/users/Chingu-cohorts/repos","events_url":"https://api.github.com/users/Chingu-cohorts/events{/privacy}","received_events_url":"https://api.github.com/users/Chingu-cohorts/received_events","type":"Organization","site_admin":false},"repo":{"id":89068585,"name":"devgaido","full_name":"Chingu-cohorts/devgaido","owner":{"login":"Chingu-cohorts","id":26086677,"avatar_url":"https://avatars2.githubusercontent.com/u/26086677?v=3","gravatar_id":"","url":"https://api.github.com/users/Chingu-cohorts","html_url":"https://github.com/Chingu-cohorts","followers_url":"https://api.github.com/users/Chingu-cohorts/followers","following_url":"https://api.github.com/users/Chingu-cohorts/following{/other_user}","gists_url":"https://api.github.com/users/Chingu-cohorts/gists{/gist_id}","starred_url":"https://api.github.com/users/Chingu-cohorts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chingu-cohorts/subscriptions","organizations_url":"https://api.github.com/users/Chingu-cohorts/orgs","repos_url":"https://api.github.com/users/Chingu-cohorts/repos","events_url":"https://api.github.com/users/Chingu-cohorts/events{/privacy}","received_events_url":"https://api.github.com/users/Chingu-cohorts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chingu-cohorts/devgaido","description":"Chingu Learning Path application ","fork":false,"url":"https://api.github.com/repos/Chingu-cohorts/devgaido","forks_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/forks","keys_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/teams","hooks_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/hooks","issue_events_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/events{/number}","events_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/events","assignees_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/assignees{/user}","branches_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/branches{/branch}","tags_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/tags","blobs_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/statuses/{sha}","languages_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/languages","stargazers_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/stargazers","contributors_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/contributors","subscribers_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/subscribers","subscription_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/subscription","commits_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/contents/{+path}","compare_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/merges","archive_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/downloads","issues_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues{/number}","pulls_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls{/number}","milestones_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/milestones{/number}","notifications_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/labels{/name}","releases_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/releases{/id}","deployments_url":"https://api.github.com/repos/Chingu-cohorts/devgaido/deployments","created_at":"2017-04-22T12:38:38Z","updated_at":"2017-04-24T12:38:17Z","pushed_at":"2017-04-24T21:54:45Z","git_url":"git://github.com/Chingu-cohorts/devgaido.git","ssh_url":"git@github.com:Chingu-cohorts/devgaido.git","clone_url":"https://github.com/Chingu-cohorts/devgaido.git","svn_url":"https://github.com/Chingu-cohorts/devgaido","homepage":null,"size":163,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/1"},"html":{"href":"https://github.com/Chingu-cohorts/devgaido/pull/1"},"issue":{"href":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/1"},"comments":{"href":"https://api.github.com/repos/Chingu-cohorts/devgaido/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chingu-cohorts/devgaido/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Chingu-cohorts/devgaido/statuses/97aa10a71ee724b83feff5b3da451d3ff0fc1a35"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kimkwanka","id":13664983,"avatar_url":"https://avatars0.githubusercontent.com/u/13664983?v=3","gravatar_id":"","url":"https://api.github.com/users/kimkwanka","html_url":"https://github.com/kimkwanka","followers_url":"https://api.github.com/users/kimkwanka/followers","following_url":"https://api.github.com/users/kimkwanka/following{/other_user}","gists_url":"https://api.github.com/users/kimkwanka/gists{/gist_id}","starred_url":"https://api.github.com/users/kimkwanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimkwanka/subscriptions","organizations_url":"https://api.github.com/users/kimkwanka/orgs","repos_url":"https://api.github.com/users/kimkwanka/repos","events_url":"https://api.github.com/users/kimkwanka/events{/privacy}","received_events_url":"https://api.github.com/users/kimkwanka/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":395,"deletions":257,"changed_files":13}}
{"actor":{"display_login":"kimkwanka"}}