{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-scroll/issues/172","repository_url":"https://api.github.com/repos/angular-ui/ui-scroll","labels_url":"https://api.github.com/repos/angular-ui/ui-scroll/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-scroll/issues/172/comments","events_url":"https://api.github.com/repos/angular-ui/ui-scroll/issues/172/events","html_url":"https://github.com/angular-ui/ui-scroll/issues/172","id":243693239,"number":172,"title":"cause of jumping when reaching the top and having a lower limit","user":{"login":"tylkomat","id":815915,"avatar_url":"https://avatars2.githubusercontent.com/u/815915?v=4","gravatar_id":"","url":"https://api.github.com/users/tylkomat","html_url":"https://github.com/tylkomat","followers_url":"https://api.github.com/users/tylkomat/followers","following_url":"https://api.github.com/users/tylkomat/following{/other_user}","gists_url":"https://api.github.com/users/tylkomat/gists{/gist_id}","starred_url":"https://api.github.com/users/tylkomat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylkomat/subscriptions","organizations_url":"https://api.github.com/users/tylkomat/orgs","repos_url":"https://api.github.com/users/tylkomat/repos","events_url":"https://api.github.com/users/tylkomat/events{/privacy}","received_events_url":"https://api.github.com/users/tylkomat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-07-18T12:05:30Z","updated_at":"2017-08-21T16:57:41Z","closed_at":null,"body":"The Line 166 in [src/modules/viewport.js](https://github.com/angular-ui/ui-scroll/blob/master/src/modules/viewport.js#L166) causes the jumping.\r\n\r\nWhen having a limit of index 1 as the top then the mentioned line forces a padding to be `added` to `viewport.scrollTop`, since `paddingHeight` is negative. This scrolls the viewport down again, while the user scrolls up, which causes the jumping.\r\n\r\nWhen this line is removed everything works as expected when having a lower limit. On the other hand without a lower limit, `ui-scroll` will fetch new items indefinitely.\r\n\r\nThere should be a check which only executes that line when the beginning (`buffer.bof === false`) was not reached."},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-scroll/issues/comments/323798267","html_url":"https://github.com/angular-ui/ui-scroll/issues/172#issuecomment-323798267","issue_url":"https://api.github.com/repos/angular-ui/ui-scroll/issues/172","id":323798267,"user":{"login":"mamacasc","id":22358207,"avatar_url":"https://avatars2.githubusercontent.com/u/22358207?v=4","gravatar_id":"","url":"https://api.github.com/users/mamacasc","html_url":"https://github.com/mamacasc","followers_url":"https://api.github.com/users/mamacasc/followers","following_url":"https://api.github.com/users/mamacasc/following{/other_user}","gists_url":"https://api.github.com/users/mamacasc/gists{/gist_id}","starred_url":"https://api.github.com/users/mamacasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamacasc/subscriptions","organizations_url":"https://api.github.com/users/mamacasc/orgs","repos_url":"https://api.github.com/users/mamacasc/repos","events_url":"https://api.github.com/users/mamacasc/events{/privacy}","received_events_url":"https://api.github.com/users/mamacasc/received_events","type":"User","site_admin":false},"created_at":"2017-08-21T16:57:41Z","updated_at":"2017-08-21T16:57:41Z","body":"Well that certainly helped with the Plunker – it is definitely our friend.  But I have a problem with my real app because height is not set in pixels – it is set in percentages (e.g. 100%) or relative units (vh).  Is ui-scroll going to work if height is defined that way?  My results have to display in the lowest of a set of nested views and I’ve tried moving the viewport to each view with no luck.  Is there a way to make that work?\r\n\r\nFrom: Denis Alexanov [mailto:notifications@github.com]\r\nSent: August 18, 2017 5:06 PM\r\nTo: angular-ui/ui-scroll <ui-scroll@noreply.github.com>\r\nCc: Casciato, Julie <Julie.Casciato@sunquestinfo.com>; Mention <mention@noreply.github.com>\r\nSubject: Re: [angular-ui/ui-scroll] cause of jumping when reaching the top and having a lower limit (#172)\r\n\r\n\r\n@mamacasc<https://github.com/mamacasc> Plunker is great, it saves our time! I forked it and made a short fix: https://plnkr.co/edit/EUznlF0ynxJK1ptkAZEG?p=preview. You had a problem with the viewport's height, which must be constrained according to the documentation.\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://github.com/angular-ui/ui-scroll/issues/172#issuecomment-323485874>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVUov3dderZfSHnXlP4w0GrlJxNm_Ge2ks5sZicBgaJpZM4ObP3X>.\r\n\r\n________________________________\r\n\r\nPlease consider the environment before printing this e-mail.\r\n\r\nThe information contained in this communication is confidential and is intended only for the use of the addressee. Furthermore, employees of Sunquest are expressly required not to make defamatory statements and not to infringe or authorize any infringement of copyright or any other legal right by email communications. Any such communication is contrary to Company policy and outside the scope of the employment of the individual concerned. The Company will not accept any liability in respect of such communication, and the employee responsible will be personally liable for any damages or other liability arising. Employees who receive such an email must notify their manager immediately.\r\n"}}
{"actor":{"display_login":"mamacasc"}}