{"action":"created","comment":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/142065091","pull_request_review_id":66373225,"id":142065091,"diff_hunk":"@@ -184,7 +184,7 @@\n print '<tr class=\"oddeven\"><td>'.$langs->trans(\"LDAPFieldFirstName\").'</td><td>';\n print '<input size=\"25\" type=\"text\" name=\"fieldfirstname\" value=\"'.$conf->global->LDAP_FIELD_FIRSTNAME.'\">';\n print '</td><td>'.$langs->trans(\"LDAPFieldFirstNameExample\").'</td>';\n-print '<td align=\"right\"><input type=\"radio\" name=\"key\" value=\"LDAP_FIELD_FIRSTNAME\"'.(($conf->global->LDAP_KEY_USERS && $conf->global->LDAP_KEY_USERS==$conf->global->LDAP_FIELD_FIRSTNAME)?' checked':'').\"></td>\";\n+print '<td align=\"right\">&nbsp;</td>';","path":"htdocs/admin/ldap_users.php","position":null,"original_position":5,"commit_id":"c1b6f59c1bf1370258acb82ab92d93c18ccf8796","original_commit_id":"cb9d627f025d17c866ec1d6a34ae604fdb999284","user":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"body":"@eldy \r\nDo we agree that the ldap key is used to create the DN of the record? In general it is often the \"first name / name\", \"uid\", \"email\" ... I have restored some fields. I will also test later the function \"ldap_rename\" which is compatible only with version 3 of the protocol and which would not lose the password.\r\n\r\nhttp://www.commentcamarche.net/contents/635-ldap-le-modele-de-nommage\r\n\r\nhttp://php.net/manual/fr/function.ldap-rename.php","created_at":"2017-10-02T06:49:26Z","updated_at":"2017-10-02T06:49:26Z","html_url":"https://github.com/Dolibarr/dolibarr/pull/7520#discussion_r142065091","pull_request_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/142065091"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/7520#discussion_r142065091"},"pull_request":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520"}},"in_reply_to_id":142042281},"pull_request":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520","id":143695498,"html_url":"https://github.com/Dolibarr/dolibarr/pull/7520","diff_url":"https://github.com/Dolibarr/dolibarr/pull/7520.diff","patch_url":"https://github.com/Dolibarr/dolibarr/pull/7520.patch","issue_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7520","number":7520,"state":"open","locked":false,"title":"Fix: Set LDAP password when LDAP key changed","user":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"body":"Fix: avoid ldap error when firstname and lastname is empty\r\nNEW add ldap field company name for member","created_at":"2017-09-28T16:24:30Z","updated_at":"2017-10-02T06:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99bde0654e2e4690896d2d850e4a80228d9e1326","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520/commits","review_comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520/comments","review_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7520/comments","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/c1b6f59c1bf1370258acb82ab92d93c18ccf8796","head":{"label":"hregis:develop_ldap","ref":"develop_ldap","sha":"c1b6f59c1bf1370258acb82ab92d93c18ccf8796","user":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"repo":{"id":2254163,"name":"dolibarr","full_name":"hregis/dolibarr","owner":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hregis/dolibarr","description":"Dolibarr ERP/CRM is a modern software to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's an opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":true,"url":"https://api.github.com/repos/hregis/dolibarr","forks_url":"https://api.github.com/repos/hregis/dolibarr/forks","keys_url":"https://api.github.com/repos/hregis/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hregis/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hregis/dolibarr/teams","hooks_url":"https://api.github.com/repos/hregis/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/hregis/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/hregis/dolibarr/events","assignees_url":"https://api.github.com/repos/hregis/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/hregis/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/hregis/dolibarr/tags","blobs_url":"https://api.github.com/repos/hregis/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hregis/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hregis/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/hregis/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hregis/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/hregis/dolibarr/languages","stargazers_url":"https://api.github.com/repos/hregis/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/hregis/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/hregis/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/hregis/dolibarr/subscription","commits_url":"https://api.github.com/repos/hregis/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/hregis/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/hregis/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/hregis/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/hregis/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/hregis/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hregis/dolibarr/merges","archive_url":"https://api.github.com/repos/hregis/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hregis/dolibarr/downloads","issues_url":"https://api.github.com/repos/hregis/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/hregis/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/hregis/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/hregis/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hregis/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/hregis/dolibarr/releases{/id}","deployments_url":"https://api.github.com/repos/hregis/dolibarr/deployments","created_at":"2011-08-23T09:21:05Z","updated_at":"2015-05-07T10:08:32Z","pushed_at":"2017-10-02T06:44:28Z","git_url":"git://github.com/hregis/dolibarr.git","ssh_url":"git@github.com:hregis/dolibarr.git","clone_url":"https://github.com/hregis/dolibarr.git","svn_url":"https://github.com/hregis/dolibarr","homepage":"http://www.dolibarr.org","size":411901,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"Dolibarr:develop","ref":"develop","sha":"0e15aef44f15c07a9800993916c487e9c1b34ac0","user":{"login":"Dolibarr","id":877491,"avatar_url":"https://avatars0.githubusercontent.com/u/877491?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"repo":{"id":1957456,"name":"dolibarr","full_name":"Dolibarr/dolibarr","owner":{"login":"Dolibarr","id":877491,"avatar_url":"https://avatars0.githubusercontent.com/u/877491?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Dolibarr/dolibarr","description":"Dolibarr ERP CRM is a modern software package to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":false,"url":"https://api.github.com/repos/Dolibarr/dolibarr","forks_url":"https://api.github.com/repos/Dolibarr/dolibarr/forks","keys_url":"https://api.github.com/repos/Dolibarr/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dolibarr/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dolibarr/dolibarr/teams","hooks_url":"https://api.github.com/repos/Dolibarr/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/Dolibarr/dolibarr/events","assignees_url":"https://api.github.com/repos/Dolibarr/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/Dolibarr/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/tags","blobs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/Dolibarr/dolibarr/languages","stargazers_url":"https://api.github.com/repos/Dolibarr/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/Dolibarr/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscription","commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dolibarr/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/Dolibarr/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dolibarr/dolibarr/merges","archive_url":"https://api.github.com/repos/Dolibarr/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dolibarr/dolibarr/downloads","issues_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/Dolibarr/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/Dolibarr/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dolibarr/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/Dolibarr/dolibarr/releases{/id}","deployments_url":"https://api.github.com/repos/Dolibarr/dolibarr/deployments","created_at":"2011-06-26T21:55:03Z","updated_at":"2017-10-01T00:56:42Z","pushed_at":"2017-10-02T06:44:31Z","git_url":"git://github.com/Dolibarr/dolibarr.git","ssh_url":"git@github.com:Dolibarr/dolibarr.git","clone_url":"https://github.com/Dolibarr/dolibarr.git","svn_url":"https://github.com/Dolibarr/dolibarr","homepage":"https://www.dolibarr.org","size":410951,"stargazers_count":803,"watchers_count":803,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":667,"mirror_url":null,"open_issues_count":753,"forks":667,"open_issues":753,"watchers":803,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/7520"},"issue":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7520"},"comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7520/comments"},"review_comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520/comments"},"review_comment":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7520/commits"},"statuses":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/c1b6f59c1bf1370258acb82ab92d93c18ccf8796"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hregis"}}