{"action":"created","comment":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/157483851","pull_request_review_id":84126465,"id":157483851,"diff_hunk":"@@ -34,26 +34,39 @@ const cartographer::common::Duration kPopTimeout =\n }  // namespace\n \n MapBuilderServer::MapBuilderContext::MapBuilderContext(\n-    cartographer::mapping::MapBuilder* map_builder,\n-    cartographer::common::BlockingQueue<std::unique_ptr<SensorData>>*\n-        sensor_data_queue)\n-    : map_builder_(map_builder), sensor_data_queue_(sensor_data_queue) {}\n+    MapBuilderServer* map_builder_server)\n+    : map_builder_server_(map_builder_server) {}\n \n cartographer::mapping::MapBuilder&\n MapBuilderServer::MapBuilderContext::map_builder() {\n-  return *map_builder_;\n+  return map_builder_server_->map_builder_;\n }\n \n cartographer::common::BlockingQueue<\n     std::unique_ptr<MapBuilderServer::SensorData>>&\n MapBuilderServer::MapBuilderContext::sensor_data_queue() {\n-  return *sensor_data_queue_;\n+  return map_builder_server_->sensor_data_queue_;\n+}\n+\n+cartographer::mapping::TrajectoryBuilderInterface::LocalSlamResultCallback\n+MapBuilderServer::MapBuilderContext::local_slam_result_callback() {\n+  MapBuilderServer* map_builder_server = map_builder_server_;","path":"cartographer_grpc/map_builder_server.cc","position":26,"original_position":26,"commit_id":"0288633b3e9e0a5d70003cbf86cfb13a9a5f0aaa","original_commit_id":"0288633b3e9e0a5d70003cbf86cfb13a9a5f0aaa","user":{"login":"gaschler","id":339437,"avatar_url":"https://avatars3.githubusercontent.com/u/339437?v=4","gravatar_id":"","url":"https://api.github.com/users/gaschler","html_url":"https://github.com/gaschler","followers_url":"https://api.github.com/users/gaschler/followers","following_url":"https://api.github.com/users/gaschler/following{/other_user}","gists_url":"https://api.github.com/users/gaschler/gists{/gist_id}","starred_url":"https://api.github.com/users/gaschler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaschler/subscriptions","organizations_url":"https://api.github.com/users/gaschler/orgs","repos_url":"https://api.github.com/users/gaschler/repos","events_url":"https://api.github.com/users/gaschler/events{/privacy}","received_events_url":"https://api.github.com/users/gaschler/received_events","type":"User","site_admin":false},"body":"I think [map_builder_server_] would already capture by copy as desired.\r\nSo this line can be omitted unless you find this more readable.","created_at":"2017-12-18T13:30:43Z","updated_at":"2017-12-18T13:54:46Z","html_url":"https://github.com/googlecartographer/cartographer/pull/766#discussion_r157483851","pull_request_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/157483851"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/766#discussion_r157483851"},"pull_request":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766"}}},"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766","id":158905724,"html_url":"https://github.com/googlecartographer/cartographer/pull/766","diff_url":"https://github.com/googlecartographer/cartographer/pull/766.diff","patch_url":"https://github.com/googlecartographer/cartographer/pull/766.patch","issue_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/766","number":766,"state":"open","locked":false,"title":"Local slam subscriptions","user":{"login":"cschuet","id":25035505,"avatar_url":"https://avatars3.githubusercontent.com/u/25035505?v=4","gravatar_id":"","url":"https://api.github.com/users/cschuet","html_url":"https://github.com/cschuet","followers_url":"https://api.github.com/users/cschuet/followers","following_url":"https://api.github.com/users/cschuet/following{/other_user}","gists_url":"https://api.github.com/users/cschuet/gists{/gist_id}","starred_url":"https://api.github.com/users/cschuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschuet/subscriptions","organizations_url":"https://api.github.com/users/cschuet/orgs","repos_url":"https://api.github.com/users/cschuet/repos","events_url":"https://api.github.com/users/cschuet/events{/privacy}","received_events_url":"https://api.github.com/users/cschuet/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-18T12:48:48Z","updated_at":"2017-12-18T13:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c60c061a1a79e29c79a5947e5ab57ba27975e3fa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/766/comments","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/0288633b3e9e0a5d70003cbf86cfb13a9a5f0aaa","head":{"label":"cschuet:local_slam_subscriptions","ref":"local_slam_subscriptions","sha":"0288633b3e9e0a5d70003cbf86cfb13a9a5f0aaa","user":{"login":"cschuet","id":25035505,"avatar_url":"https://avatars3.githubusercontent.com/u/25035505?v=4","gravatar_id":"","url":"https://api.github.com/users/cschuet","html_url":"https://github.com/cschuet","followers_url":"https://api.github.com/users/cschuet/followers","following_url":"https://api.github.com/users/cschuet/following{/other_user}","gists_url":"https://api.github.com/users/cschuet/gists{/gist_id}","starred_url":"https://api.github.com/users/cschuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschuet/subscriptions","organizations_url":"https://api.github.com/users/cschuet/orgs","repos_url":"https://api.github.com/users/cschuet/repos","events_url":"https://api.github.com/users/cschuet/events{/privacy}","received_events_url":"https://api.github.com/users/cschuet/received_events","type":"User","site_admin":false},"repo":{"id":101299121,"name":"cartographer","full_name":"cschuet/cartographer","owner":{"login":"cschuet","id":25035505,"avatar_url":"https://avatars3.githubusercontent.com/u/25035505?v=4","gravatar_id":"","url":"https://api.github.com/users/cschuet","html_url":"https://github.com/cschuet","followers_url":"https://api.github.com/users/cschuet/followers","following_url":"https://api.github.com/users/cschuet/following{/other_user}","gists_url":"https://api.github.com/users/cschuet/gists{/gist_id}","starred_url":"https://api.github.com/users/cschuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschuet/subscriptions","organizations_url":"https://api.github.com/users/cschuet/orgs","repos_url":"https://api.github.com/users/cschuet/repos","events_url":"https://api.github.com/users/cschuet/events{/privacy}","received_events_url":"https://api.github.com/users/cschuet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cschuet/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":true,"url":"https://api.github.com/repos/cschuet/cartographer","forks_url":"https://api.github.com/repos/cschuet/cartographer/forks","keys_url":"https://api.github.com/repos/cschuet/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cschuet/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cschuet/cartographer/teams","hooks_url":"https://api.github.com/repos/cschuet/cartographer/hooks","issue_events_url":"https://api.github.com/repos/cschuet/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/cschuet/cartographer/events","assignees_url":"https://api.github.com/repos/cschuet/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/cschuet/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/cschuet/cartographer/tags","blobs_url":"https://api.github.com/repos/cschuet/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cschuet/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cschuet/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cschuet/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cschuet/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/cschuet/cartographer/languages","stargazers_url":"https://api.github.com/repos/cschuet/cartographer/stargazers","contributors_url":"https://api.github.com/repos/cschuet/cartographer/contributors","subscribers_url":"https://api.github.com/repos/cschuet/cartographer/subscribers","subscription_url":"https://api.github.com/repos/cschuet/cartographer/subscription","commits_url":"https://api.github.com/repos/cschuet/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cschuet/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cschuet/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cschuet/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cschuet/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/cschuet/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cschuet/cartographer/merges","archive_url":"https://api.github.com/repos/cschuet/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cschuet/cartographer/downloads","issues_url":"https://api.github.com/repos/cschuet/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/cschuet/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/cschuet/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/cschuet/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cschuet/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/cschuet/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/cschuet/cartographer/deployments","created_at":"2017-08-24T13:41:15Z","updated_at":"2017-08-24T13:41:18Z","pushed_at":"2017-12-18T13:38:38Z","git_url":"git://github.com/cschuet/cartographer.git","ssh_url":"git@github.com:cschuet/cartographer.git","clone_url":"https://github.com/cschuet/cartographer.git","svn_url":"https://github.com/cschuet/cartographer","homepage":"","size":3008,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"ba7d375a25cf825edbd100436acf6bd7d24c575f","user":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":64732358,"name":"cartographer","full_name":"googlecartographer/cartographer","owner":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlecartographer/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":false,"url":"https://api.github.com/repos/googlecartographer/cartographer","forks_url":"https://api.github.com/repos/googlecartographer/cartographer/forks","keys_url":"https://api.github.com/repos/googlecartographer/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/cartographer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/cartographer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/cartographer/events","assignees_url":"https://api.github.com/repos/googlecartographer/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/cartographer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/cartographer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/cartographer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/cartographer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/cartographer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/cartographer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/cartographer/merges","archive_url":"https://api.github.com/repos/googlecartographer/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/cartographer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/cartographer/deployments","created_at":"2016-08-02T06:55:43Z","updated_at":"2017-12-17T11:14:25Z","pushed_at":"2017-12-18T13:39:01Z","git_url":"git://github.com/googlecartographer/cartographer.git","ssh_url":"git@github.com:googlecartographer/cartographer.git","clone_url":"https://github.com/googlecartographer/cartographer.git","svn_url":"https://github.com/googlecartographer/cartographer","homepage":"","size":2807,"stargazers_count":3051,"watchers_count":3051,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":943,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":943,"open_issues":22,"watchers":3051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/766"},"issue":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/766"},"comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/cartographer/statuses/0288633b3e9e0a5d70003cbf86cfb13a9a5f0aaa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gaschler"}}