{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/veneur/issues/232","repository_url":"https://api.github.com/repos/stripe/veneur","labels_url":"https://api.github.com/repos/stripe/veneur/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/stripe/veneur/issues/232/comments","events_url":"https://api.github.com/repos/stripe/veneur/issues/232/events","html_url":"https://github.com/stripe/veneur/pull/232","id":252315742,"number":232,"title":"Update deps","user":{"login":"cory-stripe","id":23101296,"avatar_url":"https://avatars3.githubusercontent.com/u/23101296?v=4","gravatar_id":"","url":"https://api.github.com/users/cory-stripe","html_url":"https://github.com/cory-stripe","followers_url":"https://api.github.com/users/cory-stripe/followers","following_url":"https://api.github.com/users/cory-stripe/following{/other_user}","gists_url":"https://api.github.com/users/cory-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/cory-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cory-stripe/subscriptions","organizations_url":"https://api.github.com/users/cory-stripe/orgs","repos_url":"https://api.github.com/users/cory-stripe/repos","events_url":"https://api.github.com/users/cory-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/cory-stripe/received_events","type":"User","site_admin":false},"labels":[{"id":674985878,"url":"https://api.github.com/repos/stripe/veneur/labels/release-1.6","name":"release-1.6","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-23T15:03:54Z","updated_at":"2017-08-23T16:59:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stripe/veneur/pulls/232","html_url":"https://github.com/stripe/veneur/pull/232","diff_url":"https://github.com/stripe/veneur/pull/232.diff","patch_url":"https://github.com/stripe/veneur/pull/232.patch"},"body":"#### Summary\r\nUpdates some dependencies.\r\n\r\n\r\n#### Motivation\r\n* Logrus [merged Aditya's PR fixing the race](https://github.com/sirupsen/logrus/pull/612) so we can stop working off a fork.\r\n* LightStep has updated their client to a newer version of grpc and should no longer blog our spans.\r\n\r\n#### Test plan\r\nTBD\r\n\r\n#### Rollout/monitoring/revert plan\r\nTBD\r\n"},"comment":{"url":"https://api.github.com/repos/stripe/veneur/issues/comments/324398442","html_url":"https://github.com/stripe/veneur/pull/232#issuecomment-324398442","issue_url":"https://api.github.com/repos/stripe/veneur/issues/232","id":324398442,"user":{"login":"ChimeraCoder","id":376414,"avatar_url":"https://avatars0.githubusercontent.com/u/376414?v=4","gravatar_id":"","url":"https://api.github.com/users/ChimeraCoder","html_url":"https://github.com/ChimeraCoder","followers_url":"https://api.github.com/users/ChimeraCoder/followers","following_url":"https://api.github.com/users/ChimeraCoder/following{/other_user}","gists_url":"https://api.github.com/users/ChimeraCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ChimeraCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChimeraCoder/subscriptions","organizations_url":"https://api.github.com/users/ChimeraCoder/orgs","repos_url":"https://api.github.com/users/ChimeraCoder/repos","events_url":"https://api.github.com/users/ChimeraCoder/events{/privacy}","received_events_url":"https://api.github.com/users/ChimeraCoder/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T16:59:55Z","updated_at":"2017-08-23T16:59:55Z","body":"We shouldn't exclude vendored source from gofmt - those need to be formatted too! If they're not, that's a bug. And we have no way of separating out formatting-only changes from changes that affect semantics, so we couldn't do that even if we wanted to without introducing the risk of a potential bug down the line.\r\n\r\nI'm a little confused why you're running into issues. I still have 1.8.3 locally, and when I gofmt this branch, I get errors on the files which contain 1.9+ syntax (which is expected), but no other changes. So it's unlikely to be a version issue. (`gofmt` sometimes behaves slightly differently between major releases).\r\n\r\n\r\nI suspect that the versions of the dependencies you have checked out locally on your laptop were just not goformatted. I can't verify this easily on my own laptop since I have different versions, but see if that's the case on yours - does running `gofmt` on the repos from  your GOPATH yield a non-empty diff?"}}
{"actor":{"display_login":"ChimeraCoder"}}