{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments/109235663","pull_request_review_id":30330141,"id":109235663,"diff_hunk":"@@ -67,7 +67,12 @@ For the media type(s) that this document is compatible with, see the [matrix][ma\n \n     - **`features`** *array of strings*\n \n-        This OPTIONAL property specifies an array of strings, each specifying a mandatory CPU feature (for example `sse4` or `aes`).\n+        This OPTIONAL property specifies an array of strings, each specifying a mandatory CPU feature.\n+\n+        When `architecture` is 386 or amd64 Image indexes SHOULD use, and implementations SHOULD understand, values [supported by Linux][cpufeatures.h] with the `X86_FEATURE_` prefix removed and the remainder lowercased (e.g. `fpu` for `X86_FEATURE_FPU` and `vme` for `X86_FEATURE_VME`).\n+        On Linux, the features supported by host CPUs can be found in the `flags` entries in the `cpuinfo` file provided by the [proc filesystem][proc.5].","path":"image-index.md","position":null,"original_position":8,"commit_id":"dc5e4a09c077096214fd9223b688f709781e0e9c","original_commit_id":"ee92880d0f4eaf7185416e26e0e5fa556b110c9c","user":{"login":"wking","id":209920,"avatar_url":"https://avatars2.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"Done with ee92880 → dc5e4a0.","created_at":"2017-03-31T19:39:58Z","updated_at":"2017-03-31T19:39:58Z","html_url":"https://github.com/opencontainers/image-spec/pull/631#discussion_r109235663","pull_request_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/631","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments/109235663"},"html":{"href":"https://github.com/opencontainers/image-spec/pull/631#discussion_r109235663"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/631"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/image-spec/pulls/631","id":113573495,"html_url":"https://github.com/opencontainers/image-spec/pull/631","diff_url":"https://github.com/opencontainers/image-spec/pull/631.diff","patch_url":"https://github.com/opencontainers/image-spec/pull/631.patch","issue_url":"https://api.github.com/repos/opencontainers/image-spec/issues/631","number":631,"state":"open","locked":false,"title":"image-index: Document Linux cpuinfo flags (on x86) for platform.features","user":{"login":"wking","id":209920,"avatar_url":"https://avatars2.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"Based on @AkihiroSuda's [proposal][1] and the subsequent discussion (#622).\n\nUsing the Linux kernel to define the values is very convenient on Linux, but will likely be a pain for folks on other OSes.  If a comprehensive, OS-agnostic list is found, we could use that instead, but would want to provide a mapping from that list of values to the Linux cpuinfo slugs for convenience.  Providing a mapping from the OS-agnostic list to the cpuinfo analog on non-Linux OSes would also be convenient.  Until then, folks wondering what a given feature slug means but unwilling to dig through the Linux source may find [this Stack Overflow post][2] useful.\n\nThis definition is not only Linux-centric, it is x86-centric.  The x86 Linux implementation writes `flags` out [here][3], but [arm uses `Features`][4].  While we could suggest values for other architectures, this commit restricts itself to the x86 family (using their [`GOARCH` names][5], as the [runtime spec recommends][6]), because that's the scope @stevvooe [is currently claiming][7].  Extending the field to other architectures can happen in follow-up work.\n\n[1]: https://github.com/opencontainers/image-spec/issues/622#issue-215629652\n[2]: http://unix.stackexchange.com/questions/43539/what-do-the-flags-in-proc-cpuinfo-mean\n[3]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/kernel/cpu/proc.c?id=refs/tags/v4.10.4#n96\n[4]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/arm/kernel/setup.c?id=refs/tags/v4.10.4#n1234\n[5]: https://golang.org/doc/install/source#environment\n[6]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0-rc5/config.md#platform\n[7]: https://github.com/opencontainers/image-spec/issues/622#issuecomment-290521269","created_at":"2017-03-31T04:38:33Z","updated_at":"2017-03-31T19:39:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aba760e24f25ec872137650945d3e9c112668f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/631/commits","review_comments_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/631/comments","review_comment_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/image-spec/issues/631/comments","statuses_url":"https://api.github.com/repos/opencontainers/image-spec/statuses/dc5e4a09c077096214fd9223b688f709781e0e9c","head":{"label":"wking:some-platform.features-docs","ref":"some-platform.features-docs","sha":"dc5e4a09c077096214fd9223b688f709781e0e9c","user":{"login":"wking","id":209920,"avatar_url":"https://avatars2.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":57418788,"name":"image-spec","full_name":"wking/image-spec","owner":{"login":"wking","id":209920,"avatar_url":"https://avatars2.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wking/image-spec","description":"OCI Image Format","fork":true,"url":"https://api.github.com/repos/wking/image-spec","forks_url":"https://api.github.com/repos/wking/image-spec/forks","keys_url":"https://api.github.com/repos/wking/image-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/image-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/image-spec/teams","hooks_url":"https://api.github.com/repos/wking/image-spec/hooks","issue_events_url":"https://api.github.com/repos/wking/image-spec/issues/events{/number}","events_url":"https://api.github.com/repos/wking/image-spec/events","assignees_url":"https://api.github.com/repos/wking/image-spec/assignees{/user}","branches_url":"https://api.github.com/repos/wking/image-spec/branches{/branch}","tags_url":"https://api.github.com/repos/wking/image-spec/tags","blobs_url":"https://api.github.com/repos/wking/image-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/image-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/image-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/image-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/image-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/image-spec/languages","stargazers_url":"https://api.github.com/repos/wking/image-spec/stargazers","contributors_url":"https://api.github.com/repos/wking/image-spec/contributors","subscribers_url":"https://api.github.com/repos/wking/image-spec/subscribers","subscription_url":"https://api.github.com/repos/wking/image-spec/subscription","commits_url":"https://api.github.com/repos/wking/image-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/image-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/image-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/image-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/image-spec/contents/{+path}","compare_url":"https://api.github.com/repos/wking/image-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/image-spec/merges","archive_url":"https://api.github.com/repos/wking/image-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/image-spec/downloads","issues_url":"https://api.github.com/repos/wking/image-spec/issues{/number}","pulls_url":"https://api.github.com/repos/wking/image-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/image-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/image-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/image-spec/labels{/name}","releases_url":"https://api.github.com/repos/wking/image-spec/releases{/id}","deployments_url":"https://api.github.com/repos/wking/image-spec/deployments","created_at":"2016-04-29T23:32:32Z","updated_at":"2016-04-29T23:32:32Z","pushed_at":"2017-03-31T19:39:46Z","git_url":"git://github.com/wking/image-spec.git","ssh_url":"git@github.com:wking/image-spec.git","clone_url":"https://github.com/wking/image-spec.git","svn_url":"https://github.com/wking/image-spec","homepage":"https://www.opencontainers.org/","size":4752,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"76af9f504c94c76f4277f415ac285c310a6abae6","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars2.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":54503347,"name":"image-spec","full_name":"opencontainers/image-spec","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars2.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/image-spec","description":"OCI Image Format","fork":false,"url":"https://api.github.com/repos/opencontainers/image-spec","forks_url":"https://api.github.com/repos/opencontainers/image-spec/forks","keys_url":"https://api.github.com/repos/opencontainers/image-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/image-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/image-spec/teams","hooks_url":"https://api.github.com/repos/opencontainers/image-spec/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/image-spec/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/image-spec/events","assignees_url":"https://api.github.com/repos/opencontainers/image-spec/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/image-spec/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/image-spec/tags","blobs_url":"https://api.github.com/repos/opencontainers/image-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/image-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/image-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/image-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/image-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/image-spec/languages","stargazers_url":"https://api.github.com/repos/opencontainers/image-spec/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/image-spec/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/image-spec/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/image-spec/subscription","commits_url":"https://api.github.com/repos/opencontainers/image-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/image-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/image-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/image-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/image-spec/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/image-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/image-spec/merges","archive_url":"https://api.github.com/repos/opencontainers/image-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/image-spec/downloads","issues_url":"https://api.github.com/repos/opencontainers/image-spec/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/image-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/image-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/image-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/image-spec/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/image-spec/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/image-spec/deployments","created_at":"2016-03-22T19:34:41Z","updated_at":"2017-03-31T09:13:41Z","pushed_at":"2017-03-31T19:39:48Z","git_url":"git://github.com/opencontainers/image-spec.git","ssh_url":"git@github.com:opencontainers/image-spec.git","clone_url":"https://github.com/opencontainers/image-spec.git","svn_url":"https://github.com/opencontainers/image-spec","homepage":"https://www.opencontainers.org/","size":4631,"stargazers_count":224,"watchers_count":224,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":50,"forks":62,"open_issues":50,"watchers":224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/631"},"html":{"href":"https://github.com/opencontainers/image-spec/pull/631"},"issue":{"href":"https://api.github.com/repos/opencontainers/image-spec/issues/631"},"comments":{"href":"https://api.github.com/repos/opencontainers/image-spec/issues/631/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/631/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/631/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/image-spec/statuses/dc5e4a09c077096214fd9223b688f709781e0e9c"}}}}
{"actor":{"display_login":"wking"}}