{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/comments/136476938","pull_request_review_id":60022526,"id":136476938,"diff_hunk":"@@ -732,30 +733,34 @@ size_t TypeSupport<MembersType>::calculateMaxSerializedSize(\n         case ::rosidl_typesupport_introspection_cpp::ROS_TYPE_UINT8:\n         case ::rosidl_typesupport_introspection_cpp::ROS_TYPE_CHAR:\n         case ::rosidl_typesupport_introspection_cpp::ROS_TYPE_INT8:\n-          current_alignment += 1;\n+          current_alignment += sizeof(int8_t);","path":"rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/TypeSupport_impl.hpp","position":25,"original_position":15,"commit_id":"27e85f21a0b6f48e423a9c6a2f1957d33351736d","original_commit_id":"05ac4f3c0797d359240d19ba7f5f723844b18218","user":{"login":"mikaelarguedas","id":6644208,"avatar_url":"https://avatars1.githubusercontent.com/u/6644208?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaelarguedas","html_url":"https://github.com/mikaelarguedas","followers_url":"https://api.github.com/users/mikaelarguedas/followers","following_url":"https://api.github.com/users/mikaelarguedas/following{/other_user}","gists_url":"https://api.github.com/users/mikaelarguedas/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelarguedas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelarguedas/subscriptions","organizations_url":"https://api.github.com/users/mikaelarguedas/orgs","repos_url":"https://api.github.com/users/mikaelarguedas/repos","events_url":"https://api.github.com/users/mikaelarguedas/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelarguedas/received_events","type":"User","site_admin":false},"body":"I didnt look at the spec. If you checked both specifications (DDS and RTPS) and that nothing specifies the padding I'm fine with merging this as is","created_at":"2017-09-01T00:14:29Z","updated_at":"2017-09-01T00:14:29Z","html_url":"https://github.com/ros2/rmw_fastrtps/pull/140#discussion_r136476938","pull_request_url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/comments/136476938"},"html":{"href":"https://github.com/ros2/rmw_fastrtps/pull/140#discussion_r136476938"},"pull_request":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140"}},"in_reply_to_id":132535322},"pull_request":{"url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140","id":135191185,"html_url":"https://github.com/ros2/rmw_fastrtps/pull/140","diff_url":"https://github.com/ros2/rmw_fastrtps/pull/140.diff","patch_url":"https://github.com/ros2/rmw_fastrtps/pull/140.patch","issue_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/140","number":140,"state":"open","locked":false,"title":"Clean up Magic Numbers","user":{"login":"allenh1","id":2013091,"avatar_url":"https://avatars2.githubusercontent.com/u/2013091?v=4","gravatar_id":"","url":"https://api.github.com/users/allenh1","html_url":"https://github.com/allenh1","followers_url":"https://api.github.com/users/allenh1/followers","following_url":"https://api.github.com/users/allenh1/following{/other_user}","gists_url":"https://api.github.com/users/allenh1/gists{/gist_id}","starred_url":"https://api.github.com/users/allenh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenh1/subscriptions","organizations_url":"https://api.github.com/users/allenh1/orgs","repos_url":"https://api.github.com/users/allenh1/repos","events_url":"https://api.github.com/users/allenh1/events{/privacy}","received_events_url":"https://api.github.com/users/allenh1/received_events","type":"User","site_admin":false},"body":"This is still in progress, but opening this for visibility.\r\n\r\nconnects to #72 ","created_at":"2017-08-10T18:26:23Z","updated_at":"2017-09-01T00:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"845195eb35f727f41a30b38abb40e7d139a38bbf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140/commits","review_comments_url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140/comments","review_comment_url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/140/comments","statuses_url":"https://api.github.com/repos/ros2/rmw_fastrtps/statuses/27e85f21a0b6f48e423a9c6a2f1957d33351736d","head":{"label":"ros2:remove-magic-numbers-72","ref":"remove-magic-numbers-72","sha":"27e85f21a0b6f48e423a9c6a2f1957d33351736d","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":35552300,"name":"rmw_fastrtps","full_name":"ros2/rmw_fastrtps","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw_fastrtps","description":"Implementation of the ROS Middleware (rmw) Interface using eProsima's Fast RTPS.","fork":false,"url":"https://api.github.com/repos/ros2/rmw_fastrtps","forks_url":"https://api.github.com/repos/ros2/rmw_fastrtps/forks","keys_url":"https://api.github.com/repos/ros2/rmw_fastrtps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw_fastrtps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw_fastrtps/teams","hooks_url":"https://api.github.com/repos/ros2/rmw_fastrtps/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw_fastrtps/events","assignees_url":"https://api.github.com/repos/ros2/rmw_fastrtps/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw_fastrtps/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw_fastrtps/tags","blobs_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw_fastrtps/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw_fastrtps/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw_fastrtps/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw_fastrtps/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw_fastrtps/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw_fastrtps/subscription","commits_url":"https://api.github.com/repos/ros2/rmw_fastrtps/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw_fastrtps/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw_fastrtps/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw_fastrtps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw_fastrtps/merges","archive_url":"https://api.github.com/repos/ros2/rmw_fastrtps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw_fastrtps/downloads","issues_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw_fastrtps/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw_fastrtps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw_fastrtps/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw_fastrtps/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rmw_fastrtps/deployments","created_at":"2015-05-13T14:00:18Z","updated_at":"2017-07-08T03:51:26Z","pushed_at":"2017-08-31T20:14:26Z","git_url":"git://github.com/ros2/rmw_fastrtps.git","ssh_url":"git@github.com:ros2/rmw_fastrtps.git","clone_url":"https://github.com/ros2/rmw_fastrtps.git","svn_url":"https://github.com/ros2/rmw_fastrtps","homepage":"","size":422,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":11,"forks":16,"open_issues":11,"watchers":11,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"107b92d76399d26ea1a8a103b3a7f9728e89118e","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":35552300,"name":"rmw_fastrtps","full_name":"ros2/rmw_fastrtps","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw_fastrtps","description":"Implementation of the ROS Middleware (rmw) Interface using eProsima's Fast RTPS.","fork":false,"url":"https://api.github.com/repos/ros2/rmw_fastrtps","forks_url":"https://api.github.com/repos/ros2/rmw_fastrtps/forks","keys_url":"https://api.github.com/repos/ros2/rmw_fastrtps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw_fastrtps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw_fastrtps/teams","hooks_url":"https://api.github.com/repos/ros2/rmw_fastrtps/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw_fastrtps/events","assignees_url":"https://api.github.com/repos/ros2/rmw_fastrtps/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw_fastrtps/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw_fastrtps/tags","blobs_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw_fastrtps/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw_fastrtps/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw_fastrtps/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw_fastrtps/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw_fastrtps/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw_fastrtps/subscription","commits_url":"https://api.github.com/repos/ros2/rmw_fastrtps/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw_fastrtps/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw_fastrtps/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw_fastrtps/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw_fastrtps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw_fastrtps/merges","archive_url":"https://api.github.com/repos/ros2/rmw_fastrtps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw_fastrtps/downloads","issues_url":"https://api.github.com/repos/ros2/rmw_fastrtps/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw_fastrtps/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw_fastrtps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw_fastrtps/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw_fastrtps/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rmw_fastrtps/deployments","created_at":"2015-05-13T14:00:18Z","updated_at":"2017-07-08T03:51:26Z","pushed_at":"2017-08-31T20:14:26Z","git_url":"git://github.com/ros2/rmw_fastrtps.git","ssh_url":"git@github.com:ros2/rmw_fastrtps.git","clone_url":"https://github.com/ros2/rmw_fastrtps.git","svn_url":"https://github.com/ros2/rmw_fastrtps","homepage":"","size":422,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":11,"forks":16,"open_issues":11,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140"},"html":{"href":"https://github.com/ros2/rmw_fastrtps/pull/140"},"issue":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/140"},"comments":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rmw_fastrtps/statuses/27e85f21a0b6f48e423a9c6a2f1957d33351736d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikaelarguedas"}}