{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/43399","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/43399/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/43399/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/43399/events","html_url":"https://github.com/rust-lang/rust/pull/43399","id":244807097,"number":43399,"title":"default binding modes: add pat_binding_modes","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars1.githubusercontent.com/u/5076964?v=4","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"labels":[{"id":583436937,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-author","name":"S-waiting-on-author","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2017-07-21T23:41:24Z","updated_at":"2017-07-31T15:14:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/43399","html_url":"https://github.com/rust-lang/rust/pull/43399","diff_url":"https://github.com/rust-lang/rust/pull/43399.diff","patch_url":"https://github.com/rust-lang/rust/pull/43399.patch"},"body":"This PR kicks off the implementation of the [default binding modes RFC][1] by\r\nintroducing the `pat_binding_modes` typeck table mentioned in the [mentoring\r\ninstructions][2].\r\n\r\nIt is a WIP because I wasn't able to avoid all uses of the binding modes as\r\nnot all call sites are close enough to the typeck tables. I added marker\r\ncomments to any line matching `BindByRef|BindByValue` so that reviewers\r\nare aware of all of them.\r\n\r\nI will look into changing the HIR (as suggested in [2]) to not carry a\r\n`BindingMode` unless one was explicitly specified, but this PR is good for\r\na first round of comments.\r\n\r\nThe actual changes are quite small and CI will fail due to overlong lines\r\ncaused by the marker comments.\r\n\r\nSee #42640.\r\n\r\ncc @nikomatsakis\r\n\r\n[1]: https://github.com/rust-lang/rfcs/pull/2005\r\n[2]: https://github.com/rust-lang/rust/issues/42640#issuecomment-313535089"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/319098175","html_url":"https://github.com/rust-lang/rust/pull/43399#issuecomment-319098175","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/43399","id":319098175,"user":{"login":"bors","id":3372342,"avatar_url":"https://avatars2.githubusercontent.com/u/3372342?v=4","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T15:14:23Z","updated_at":"2017-07-31T15:14:23Z","body":":pushpin: Commit 8f67f1e has been approved by `nikomatsakis`\n\n<!-- @bors r=nikomatsakis 8f67f1efaf792a0c3ef629e1e62e53eba7365a1c -->"}}
{"actor":{"display_login":"bors"}}