{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/129378016","pull_request_review_id":52144996,"id":129378016,"diff_hunk":"@@ -376,6 +397,23 @@ private ByteBuffer readBlob(ReadableStreamChannel postContent) throws Interrupte\n     }\n     return ByteBuffer.wrap(blobDataStream.toByteArray());\n   }\n+\n+  /**\n+   * Choose a random {@link PartitionId} for putting the current chunk and return it. This code is copied from\n+   * {@code PutOperation#getPartitionForPut}.\n+   * @param partitionIdsToExclude the list of {@link PartitionId}s that should be excluded from consideration.\n+   * @return the chosen {@link PartitionId}\n+   * @throws RouterException\n+   */\n+  private PartitionId getPartitionForPut(List<PartitionId> partitionIdsToExclude) throws RouterException {","path":"ambry-router/src/test/java/com.github.ambry.router/InMemoryRouter.java","position":168,"original_position":168,"commit_id":"dbee5d76bbbc37625c2d8bba2ac687dab770b522","original_commit_id":"dbee5d76bbbc37625c2d8bba2ac687dab770b522","user":{"login":"xiahome","id":8271368,"avatar_url":"https://avatars1.githubusercontent.com/u/8271368?v=4","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false},"body":"removed.","created_at":"2017-07-25T17:53:45Z","updated_at":"2017-07-25T17:53:45Z","html_url":"https://github.com/linkedin/ambry/pull/695#discussion_r129378016","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/695","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/129378016"},"html":{"href":"https://github.com/linkedin/ambry/pull/695#discussion_r129378016"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/695"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/695","id":132296277,"html_url":"https://github.com/linkedin/ambry/pull/695","diff_url":"https://github.com/linkedin/ambry/pull/695.diff","patch_url":"https://github.com/linkedin/ambry/pull/695.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/695","number":695,"state":"open","locked":false,"title":"Generates meaningful blob ids in InMemory router","user":{"login":"xiahome","id":8271368,"avatar_url":"https://avatars1.githubusercontent.com/u/8271368?v=4","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false},"body":"The InMemory router previously generates uuid as blob ids, which could\r\nnot be parsed for flag, dc id, account/container id, etc. This patch\r\nmakes the InMemory router to generate real blob ids.\r\n\r\nThis change is used for testing purpose so that ids can be\r\nget/head/delete later.\r\n\r\nTest:\r\n./gradlew clean && ./gradlew build","created_at":"2017-07-25T14:30:18Z","updated_at":"2017-07-25T17:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95a20403a4a7b3a20223f008a1c4730f17ac559f","assignee":{"login":"xiahome","id":8271368,"avatar_url":"https://avatars1.githubusercontent.com/u/8271368?v=4","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false},"assignees":[{"login":"xiahome","id":8271368,"avatar_url":"https://avatars1.githubusercontent.com/u/8271368?v=4","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/695/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/695/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/695/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/dbee5d76bbbc37625c2d8bba2ac687dab770b522","head":{"label":"xiahome:generateMeaningfulBlobIdInInMemoryRouter","ref":"generateMeaningfulBlobIdInInMemoryRouter","sha":"dbee5d76bbbc37625c2d8bba2ac687dab770b522","user":{"login":"xiahome","id":8271368,"avatar_url":"https://avatars1.githubusercontent.com/u/8271368?v=4","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false},"repo":{"id":45135213,"name":"ambry","full_name":"xiahome/ambry","owner":{"login":"xiahome","id":8271368,"avatar_url":"https://avatars1.githubusercontent.com/u/8271368?v=4","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiahome/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/xiahome/ambry","forks_url":"https://api.github.com/repos/xiahome/ambry/forks","keys_url":"https://api.github.com/repos/xiahome/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiahome/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiahome/ambry/teams","hooks_url":"https://api.github.com/repos/xiahome/ambry/hooks","issue_events_url":"https://api.github.com/repos/xiahome/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/xiahome/ambry/events","assignees_url":"https://api.github.com/repos/xiahome/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/xiahome/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/xiahome/ambry/tags","blobs_url":"https://api.github.com/repos/xiahome/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiahome/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiahome/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiahome/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiahome/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/xiahome/ambry/languages","stargazers_url":"https://api.github.com/repos/xiahome/ambry/stargazers","contributors_url":"https://api.github.com/repos/xiahome/ambry/contributors","subscribers_url":"https://api.github.com/repos/xiahome/ambry/subscribers","subscription_url":"https://api.github.com/repos/xiahome/ambry/subscription","commits_url":"https://api.github.com/repos/xiahome/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiahome/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiahome/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiahome/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiahome/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/xiahome/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiahome/ambry/merges","archive_url":"https://api.github.com/repos/xiahome/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiahome/ambry/downloads","issues_url":"https://api.github.com/repos/xiahome/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/xiahome/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/xiahome/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/xiahome/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiahome/ambry/labels{/name}","releases_url":"https://api.github.com/repos/xiahome/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/xiahome/ambry/deployments","created_at":"2015-10-28T18:58:26Z","updated_at":"2016-11-15T23:14:20Z","pushed_at":"2017-07-25T14:27:14Z","git_url":"git://github.com/xiahome/ambry.git","ssh_url":"git@github.com:xiahome/ambry.git","clone_url":"https://github.com/xiahome/ambry.git","svn_url":"https://github.com/xiahome/ambry","homepage":null,"size":10320,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"203a5e94d48345681d5b92a4708c350e67f5cbc9","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2017-07-24T14:07:33Z","pushed_at":"2017-07-25T14:30:19Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":9994,"stargazers_count":913,"watchers_count":913,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":57,"forks":160,"open_issues":57,"watchers":913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/695"},"html":{"href":"https://github.com/linkedin/ambry/pull/695"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/695"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/dbee5d76bbbc37625c2d8bba2ac687dab770b522"}}}}
{"actor":{"display_login":"xiahome"}}