{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/18691","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/18691/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/18691/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/18691/events","html_url":"https://github.com/Automattic/wp-calypso/pull/18691","id":264201862,"number":18691,"title":"Resolve auth promise","user":{"login":"nosolosw","id":583546,"avatar_url":"https://avatars1.githubusercontent.com/u/583546?v=4","gravatar_id":"","url":"https://api.github.com/users/nosolosw","html_url":"https://github.com/nosolosw","followers_url":"https://api.github.com/users/nosolosw/followers","following_url":"https://api.github.com/users/nosolosw/following{/other_user}","gists_url":"https://api.github.com/users/nosolosw/gists{/gist_id}","starred_url":"https://api.github.com/users/nosolosw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nosolosw/subscriptions","organizations_url":"https://api.github.com/users/nosolosw/orgs","repos_url":"https://api.github.com/users/nosolosw/repos","events_url":"https://api.github.com/users/nosolosw/events{/privacy}","received_events_url":"https://api.github.com/users/nosolosw/received_events","type":"User","site_admin":false},"labels":[{"id":435044973,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Happychat","name":"Happychat","color":"006b75","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"nosolosw","id":583546,"avatar_url":"https://avatars1.githubusercontent.com/u/583546?v=4","gravatar_id":"","url":"https://api.github.com/users/nosolosw","html_url":"https://github.com/nosolosw","followers_url":"https://api.github.com/users/nosolosw/followers","following_url":"https://api.github.com/users/nosolosw/following{/other_user}","gists_url":"https://api.github.com/users/nosolosw/gists{/gist_id}","starred_url":"https://api.github.com/users/nosolosw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nosolosw/subscriptions","organizations_url":"https://api.github.com/users/nosolosw/orgs","repos_url":"https://api.github.com/users/nosolosw/repos","events_url":"https://api.github.com/users/nosolosw/events{/privacy}","received_events_url":"https://api.github.com/users/nosolosw/received_events","type":"User","site_admin":false},"assignees":[{"login":"nosolosw","id":583546,"avatar_url":"https://avatars1.githubusercontent.com/u/583546?v=4","gravatar_id":"","url":"https://api.github.com/users/nosolosw","html_url":"https://github.com/nosolosw","followers_url":"https://api.github.com/users/nosolosw/followers","following_url":"https://api.github.com/users/nosolosw/following{/other_user}","gists_url":"https://api.github.com/users/nosolosw/gists{/gist_id}","starred_url":"https://api.github.com/users/nosolosw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nosolosw/subscriptions","organizations_url":"https://api.github.com/users/nosolosw/orgs","repos_url":"https://api.github.com/users/nosolosw/repos","events_url":"https://api.github.com/users/nosolosw/events{/privacy}","received_events_url":"https://api.github.com/users/nosolosw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-10-10T12:02:52Z","updated_at":"2017-10-18T16:13:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/18691","html_url":"https://github.com/Automattic/wp-calypso/pull/18691","diff_url":"https://github.com/Automattic/wp-calypso/pull/18691.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/18691.patch"},"body":"Master issue: https://github.com/Automattic/wp-calypso/issues/18670\r\n\r\nCurrent SocketIO authentication doesn't reject the auth promise. If the authentication mechanism fails, the user won't be able to reconnect the socket until Calypso is reloaded (which forces the creation of a new connection).\r\n\r\n### Testing\r\n\r\nWould love to have specific steps. Unfortunately, I'm still not sure about this one: what would be the conditions under which the authentication fails for a user and then it works? Perhaps a dotcom server failure that prevents any of the HTTP requests from working? SocketIO server fails during auth mechanism?\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/337644654","html_url":"https://github.com/Automattic/wp-calypso/pull/18691#issuecomment-337644654","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/18691","id":337644654,"user":{"login":"nosolosw","id":583546,"avatar_url":"https://avatars1.githubusercontent.com/u/583546?v=4","gravatar_id":"","url":"https://api.github.com/users/nosolosw","html_url":"https://github.com/nosolosw","followers_url":"https://api.github.com/users/nosolosw/followers","following_url":"https://api.github.com/users/nosolosw/following{/other_user}","gists_url":"https://api.github.com/users/nosolosw/gists{/gist_id}","starred_url":"https://api.github.com/users/nosolosw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nosolosw/subscriptions","organizations_url":"https://api.github.com/users/nosolosw/orgs","repos_url":"https://api.github.com/users/nosolosw/repos","events_url":"https://api.github.com/users/nosolosw/events{/privacy}","received_events_url":"https://api.github.com/users/nosolosw/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T16:13:47Z","updated_at":"2017-10-18T16:13:47Z","author_association":"MEMBER","body":"@matt Nope, it doesn't intend to address the auth mechanism. Still, I think is a good idea to reject it to reflect the auth failing, so we can relay the error messages introduced https://github.com/Automattic/wp-calypso/pull/18817 (and hopefully do something about that UI-wise). \r\n\r\nWould you think this would need more work or can be integrated as it is?"}}
{"actor":{"display_login":"nosolosw"}}