{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-android/pulls/comments/102037395","pull_request_review_id":22780625,"id":102037395,"diff_hunk":"@@ -694,7 +696,13 @@ protected void hideCompoundIntentCalloutButton() {\n         activity.findViewById(R.id.multiple_intent_dispatch_button).setVisibility(View.GONE);\n     }\n \n-    protected void updateFormRelevancies() {\n+    protected synchronized void updateFormRelevancies() {\n+        if (formRelevanciesUpdateInProgress) {","path":"app/src/org/commcare/activities/FormEntryActivityUIController.java","position":15,"original_position":15,"commit_id":"fdea78160dfd5b5b622c50644e1cdd5385a3214f","original_commit_id":"fdea78160dfd5b5b622c50644e1cdd5385a3214f","user":{"login":"amstone326","id":3723143,"avatar_url":"https://avatars.githubusercontent.com/u/3723143?v=3","gravatar_id":"","url":"https://api.github.com/users/amstone326","html_url":"https://github.com/amstone326","followers_url":"https://api.github.com/users/amstone326/followers","following_url":"https://api.github.com/users/amstone326/following{/other_user}","gists_url":"https://api.github.com/users/amstone326/gists{/gist_id}","starred_url":"https://api.github.com/users/amstone326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amstone326/subscriptions","organizations_url":"https://api.github.com/users/amstone326/orgs","repos_url":"https://api.github.com/users/amstone326/repos","events_url":"https://api.github.com/users/amstone326/events{/privacy}","received_events_url":"https://api.github.com/users/amstone326/received_events","type":"User","site_admin":false},"body":"Hey, really glad you caught that, the `synchronized` keyword shouldn't be there anymore. That was leftover from debugging attempts when I thought that the duplicate calls might have been coming from another thread, which turned out not to be the case. Removing it now!","created_at":"2017-02-20T15:09:12Z","updated_at":"2017-02-20T15:09:12Z","html_url":"https://github.com/dimagi/commcare-android/pull/1639#discussion_r102037395","pull_request_url":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/comments/102037395"},"html":{"href":"https://github.com/dimagi/commcare-android/pull/1639#discussion_r102037395"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639","id":106805822,"html_url":"https://github.com/dimagi/commcare-android/pull/1639","diff_url":"https://github.com/dimagi/commcare-android/pull/1639.diff","patch_url":"https://github.com/dimagi/commcare-android/pull/1639.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-android/issues/1639","number":1639,"state":"open","locked":false,"title":"Prevent updateFormRelevancies() from calling itself downstream","user":{"login":"amstone326","id":3723143,"avatar_url":"https://avatars.githubusercontent.com/u/3723143?v=3","gravatar_id":"","url":"https://api.github.com/users/amstone326","html_url":"https://github.com/amstone326","followers_url":"https://api.github.com/users/amstone326/followers","following_url":"https://api.github.com/users/amstone326/following{/other_user}","gists_url":"https://api.github.com/users/amstone326/gists{/gist_id}","starred_url":"https://api.github.com/users/amstone326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amstone326/subscriptions","organizations_url":"https://api.github.com/users/amstone326/orgs","repos_url":"https://api.github.com/users/amstone326/repos","events_url":"https://api.github.com/users/amstone326/events{/privacy}","received_events_url":"https://api.github.com/users/amstone326/received_events","type":"User","site_admin":false},"body":"Fix for http://manage.dimagi.com/default.asp?247841. \r\n\r\nThis was a fun one. The root of this ended up being the fact that `ComboboxWidget` calls `widgetEntryChanged()` when it loses focus: https://github.com/dimagi/commcare-android/blob/master/app/src/org/commcare/views/widgets/ComboboxWidget.java#L95. `QuestionWidget.widgetEntryChanged()` triggers `FormEntryActivity.updateFormRelevancies()` downstream, which in turn calls `questionsView.removeQuestionsFromIndex()`. In this case, `removeQuestionsFromIndex()` rightfully removes the `ComboboxWidget` for district choice (it will then get added back later in the method), but removing the widget triggers its `onFocusChangedListener` and thus results in `updateFormRelevancies()` effectively recursing in the middle of its first execution. The method is definitely not designed to handle that, because when it returns from the recursion, the `promptsLeftInView` list that has been built up in the first call is now stale and inaccurate, but it proceeds with using it anyway. Thus, even though the 2 combobox widgets have already been added back to the view once by the recursive call, they get added a second time.\r\n\r\n`ComboboxWidget` is the only widget we have which calls `widgetEntryChanged()` from a place like this, which is why this has never come up before. \r\n\r\n@czue I'm assuming this needs a hotfix, let me know if that's not necessarily true.","created_at":"2017-02-17T20:25:06Z","updated_at":"2017-02-20T15:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3669789e67f5ee80dcbe8077a5a752a8bbb24423","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dimagi/commcare-android/milestones/15","html_url":"https://github.com/dimagi/commcare-android/milestone/15","labels_url":"https://api.github.com/repos/dimagi/commcare-android/milestones/15/labels","id":2250048,"number":15,"title":"commcare_2.34","description":null,"creator":{"login":"amstone326","id":3723143,"avatar_url":"https://avatars.githubusercontent.com/u/3723143?v=3","gravatar_id":"","url":"https://api.github.com/users/amstone326","html_url":"https://github.com/amstone326","followers_url":"https://api.github.com/users/amstone326/followers","following_url":"https://api.github.com/users/amstone326/following{/other_user}","gists_url":"https://api.github.com/users/amstone326/gists{/gist_id}","starred_url":"https://api.github.com/users/amstone326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amstone326/subscriptions","organizations_url":"https://api.github.com/users/amstone326/orgs","repos_url":"https://api.github.com/users/amstone326/repos","events_url":"https://api.github.com/users/amstone326/events{/privacy}","received_events_url":"https://api.github.com/users/amstone326/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":5,"state":"open","created_at":"2017-01-13T15:02:08Z","updated_at":"2017-02-20T13:35:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-android/issues/1639/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-android/statuses/fdea78160dfd5b5b622c50644e1cdd5385a3214f","head":{"label":"dimagi:prevent-incidental-recursion","ref":"prevent-incidental-recursion","sha":"fdea78160dfd5b5b622c50644e1cdd5385a3214f","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20939877,"name":"commcare-android","full_name":"dimagi/commcare-android","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-android","description":"The best open source form management tool in town","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-android","forks_url":"https://api.github.com/repos/dimagi/commcare-android/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-android/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-android/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-android/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-android/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-android/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-android/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-android/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-android/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-android/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-android/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-android/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-android/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-android/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-android/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-android/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-android/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-android/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-android/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-android/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-android/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-android/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-android/deployments","created_at":"2014-06-17T21:17:26Z","updated_at":"2016-10-25T16:05:56Z","pushed_at":"2017-02-20T13:35:48Z","git_url":"git://github.com/dimagi/commcare-android.git","ssh_url":"git@github.com:dimagi/commcare-android.git","clone_url":"https://github.com/dimagi/commcare-android.git","svn_url":"https://github.com/dimagi/commcare-android","homepage":"https://play.google.com/store/apps/details?id=org.commcare.dalvik&hl=en","size":152370,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":12,"forks":14,"open_issues":12,"watchers":9,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"7cc0e1459d3775654784645711e753adcd417f74","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20939877,"name":"commcare-android","full_name":"dimagi/commcare-android","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-android","description":"The best open source form management tool in town","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-android","forks_url":"https://api.github.com/repos/dimagi/commcare-android/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-android/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-android/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-android/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-android/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-android/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-android/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-android/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-android/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-android/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-android/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-android/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-android/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-android/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-android/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-android/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-android/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-android/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-android/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-android/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-android/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-android/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-android/deployments","created_at":"2014-06-17T21:17:26Z","updated_at":"2016-10-25T16:05:56Z","pushed_at":"2017-02-20T13:35:48Z","git_url":"git://github.com/dimagi/commcare-android.git","ssh_url":"git@github.com:dimagi/commcare-android.git","clone_url":"https://github.com/dimagi/commcare-android.git","svn_url":"https://github.com/dimagi/commcare-android","homepage":"https://play.google.com/store/apps/details?id=org.commcare.dalvik&hl=en","size":152370,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":12,"forks":14,"open_issues":12,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639"},"html":{"href":"https://github.com/dimagi/commcare-android/pull/1639"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-android/issues/1639"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-android/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-android/statuses/fdea78160dfd5b5b622c50644e1cdd5385a3214f"}}}}
{"actor":{"display_login":"amstone326"}}