{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/styx/issues/341","repository_url":"https://api.github.com/repos/spotify/styx","labels_url":"https://api.github.com/repos/spotify/styx/issues/341/labels{/name}","comments_url":"https://api.github.com/repos/spotify/styx/issues/341/comments","events_url":"https://api.github.com/repos/spotify/styx/issues/341/events","html_url":"https://github.com/spotify/styx/pull/341","id":281068986,"number":341,"title":"Command \"styx retry\" do not bypass resources check","user":{"login":"fabriziodemaria","id":7601824,"avatar_url":"https://avatars1.githubusercontent.com/u/7601824?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziodemaria","html_url":"https://github.com/fabriziodemaria","followers_url":"https://api.github.com/users/fabriziodemaria/followers","following_url":"https://api.github.com/users/fabriziodemaria/following{/other_user}","gists_url":"https://api.github.com/users/fabriziodemaria/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziodemaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziodemaria/subscriptions","organizations_url":"https://api.github.com/users/fabriziodemaria/orgs","repos_url":"https://api.github.com/users/fabriziodemaria/repos","events_url":"https://api.github.com/users/fabriziodemaria/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziodemaria/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-11T15:58:00Z","updated_at":"2017-12-13T09:10:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spotify/styx/pulls/341","html_url":"https://github.com/spotify/styx/pull/341","diff_url":"https://github.com/spotify/styx/pull/341.diff","patch_url":"https://github.com/spotify/styx/pull/341.patch"},"body":"That's done by sending `retryAfter` event that sets the delay to 0, instead of the `dequeue` event. A check is also added for the `/events` API endpoint to translate `dequeue` events into `retryAfter` events.\r\n\r\nThis PR also includes a refactoring of `RunState` that allows to have a `transition` method and a `backwardsCompatibleTransition` method, so that backwards compatible transitions can be allowed only where they actually make sense (mostly events' replying).\r\nThe reason the afore-mentioned refactoring is introduced as part of this PR is to be able to have `/events` API endpoint to refuse events that would cause old transitions; more specifically, sending a `retry` or a `submit` events to a Workflow Instance that is in QUEUED state is now not allowed. "},"comment":{"url":"https://api.github.com/repos/spotify/styx/issues/comments/351329179","html_url":"https://github.com/spotify/styx/pull/341#issuecomment-351329179","issue_url":"https://api.github.com/repos/spotify/styx/issues/341","id":351329179,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-12-13T09:10:59Z","updated_at":"2017-12-13T09:10:59Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/spotify/styx/pull/341?src=pr&el=h1) Report\n> Merging [#341](https://codecov.io/gh/spotify/styx/pull/341?src=pr&el=desc) into [master](https://codecov.io/gh/spotify/styx/commit/e028bcd64feb23c5b82167505e24994bdea014d2?src=pr&el=desc) will **increase** coverage by `0.04%`.\n> The diff coverage is `90%`.\n\n\n```diff\n@@             Coverage Diff              @@\n##             master     #341      +/-   ##\n============================================\n+ Coverage     65.74%   65.78%   +0.04%     \n- Complexity      966      968       +2     \n============================================\n  Files           111      111              \n  Lines          4475     4481       +6     \n  Branches        267      268       +1     \n============================================\n+ Hits           2942     2948       +6     \n  Misses         1441     1441              \n  Partials         92       92\n```\n"}}
{"actor":{"display_login":"codecov-io"}}