{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/102987527","pull_request_review_id":23764406,"id":102987527,"diff_hunk":"@@ -0,0 +1,39 @@\n+{ stdenv, fetchFromGitHub, libtool }:\n+\n+stdenv.mkDerivation  rec {\n+  pname = \"sha1collisiondetection\";\n+  version = \"2017-02-21\";\n+  name = \"${pname}-unstable-${version}\";\n+\n+  src = fetchFromGitHub {\n+    owner = \"cr-marcstevens\";\n+    repo = \"${pname}\";\n+    rev = \"40ccf5e3537ff6b2e5ceac5747f376a2ef430bec\";\n+    sha256 = \"1k2qjarcx88ndc4yl8xnr1l3j74w1qacvyrhv4ms9hndy8lrsm0l\";\n+  };\n+\n+  patchPhase = ''substituteInPlace Makefile --replace \"shell arch\" \"uname -m\"'';\n+\n+  buildInputs = [ libtool ];\n+\n+  installPhase = ''\n+    mkdir -p $out/bin $out/lib\n+    cp bin/sha1dcsum bin/sha1dcsum_partialcoll $out/bin\n+    cp bin/libdetectcoll.la $out/lib/\n+    '';\n+\n+  meta = with stdenv.lib; {\n+    description = \"Library and command line tool to detect SHA-1 collision\";\n+    longDescription = ''\n+      This library and command line tool were designed as near drop-in\n+      replacements for common SHA-1 libraries and sha1sum. They will\n+      compute the SHA-1 hash of any given file and additionally will\n+      detect cryptanalytic collision attacks against SHA-1 present in\n+      each file. It is very fast and takes less than twice the amount","path":"pkgs/tools/security/sha1collisiondetection/default.nix","position":32,"original_position":32,"commit_id":"b6fc45048f7890e6dba4ec22700879831a41d41b","original_commit_id":"b6fc45048f7890e6dba4ec22700879831a41d41b","user":{"login":"edolstra","id":1148549,"avatar_url":"https://avatars.githubusercontent.com/u/1148549?v=3","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false},"body":"What does this mean? What are \"collision attacks present in each file\"?","created_at":"2017-02-24T17:14:51Z","updated_at":"2017-02-24T17:14:51Z","html_url":"https://github.com/NixOS/nixpkgs/pull/23114#discussion_r102987527","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/102987527"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/23114#discussion_r102987527"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114","id":107672506,"html_url":"https://github.com/NixOS/nixpkgs/pull/23114","diff_url":"https://github.com/NixOS/nixpkgs/pull/23114.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/23114.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/23114","number":23114,"state":"open","locked":false,"title":"sha1collisiondetection: init -> unstable-2017-02-21","user":{"login":"leenaars","id":4158274,"avatar_url":"https://avatars.githubusercontent.com/u/4158274?v=3","gravatar_id":"","url":"https://api.github.com/users/leenaars","html_url":"https://github.com/leenaars","followers_url":"https://api.github.com/users/leenaars/followers","following_url":"https://api.github.com/users/leenaars/following{/other_user}","gists_url":"https://api.github.com/users/leenaars/gists{/gist_id}","starred_url":"https://api.github.com/users/leenaars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leenaars/subscriptions","organizations_url":"https://api.github.com/users/leenaars/orgs","repos_url":"https://api.github.com/users/leenaars/repos","events_url":"https://api.github.com/users/leenaars/events{/privacy}","received_events_url":"https://api.github.com/users/leenaars/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nThis creates a drop-in replacement for sha1sum, which can be used to detect collision attacks on SHA1.\r\n\r\n(see:\r\nhttp://www.cwi.nl/news/2017/cwi-and-google-announce-first-collision-industry-security-standard-sha-1)\r\n\r\nThere are currently over 8000 sha1 hashes still in use in nixpkgs itself.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [x] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-02-23T17:25:46Z","updated_at":"2017-02-24T17:14:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41c9d614a9e0fe774d64d66ddaf1f00d6e8e76d4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/23114/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b6fc45048f7890e6dba4ec22700879831a41d41b","head":{"label":"leenaars:sha1collisiondetection","ref":"sha1collisiondetection","sha":"b6fc45048f7890e6dba4ec22700879831a41d41b","user":{"login":"leenaars","id":4158274,"avatar_url":"https://avatars.githubusercontent.com/u/4158274?v=3","gravatar_id":"","url":"https://api.github.com/users/leenaars","html_url":"https://github.com/leenaars","followers_url":"https://api.github.com/users/leenaars/followers","following_url":"https://api.github.com/users/leenaars/following{/other_user}","gists_url":"https://api.github.com/users/leenaars/gists{/gist_id}","starred_url":"https://api.github.com/users/leenaars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leenaars/subscriptions","organizations_url":"https://api.github.com/users/leenaars/orgs","repos_url":"https://api.github.com/users/leenaars/repos","events_url":"https://api.github.com/users/leenaars/events{/privacy}","received_events_url":"https://api.github.com/users/leenaars/received_events","type":"User","site_admin":false},"repo":{"id":45281546,"name":"nixpkgs","full_name":"leenaars/nixpkgs","owner":{"login":"leenaars","id":4158274,"avatar_url":"https://avatars.githubusercontent.com/u/4158274?v=3","gravatar_id":"","url":"https://api.github.com/users/leenaars","html_url":"https://github.com/leenaars","followers_url":"https://api.github.com/users/leenaars/followers","following_url":"https://api.github.com/users/leenaars/following{/other_user}","gists_url":"https://api.github.com/users/leenaars/gists{/gist_id}","starred_url":"https://api.github.com/users/leenaars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leenaars/subscriptions","organizations_url":"https://api.github.com/users/leenaars/orgs","repos_url":"https://api.github.com/users/leenaars/repos","events_url":"https://api.github.com/users/leenaars/events{/privacy}","received_events_url":"https://api.github.com/users/leenaars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leenaars/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/leenaars/nixpkgs","forks_url":"https://api.github.com/repos/leenaars/nixpkgs/forks","keys_url":"https://api.github.com/repos/leenaars/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leenaars/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leenaars/nixpkgs/teams","hooks_url":"https://api.github.com/repos/leenaars/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/leenaars/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/leenaars/nixpkgs/events","assignees_url":"https://api.github.com/repos/leenaars/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/leenaars/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/leenaars/nixpkgs/tags","blobs_url":"https://api.github.com/repos/leenaars/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leenaars/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leenaars/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/leenaars/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leenaars/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/leenaars/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/leenaars/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/leenaars/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/leenaars/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/leenaars/nixpkgs/subscription","commits_url":"https://api.github.com/repos/leenaars/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/leenaars/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/leenaars/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/leenaars/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/leenaars/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/leenaars/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leenaars/nixpkgs/merges","archive_url":"https://api.github.com/repos/leenaars/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leenaars/nixpkgs/downloads","issues_url":"https://api.github.com/repos/leenaars/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/leenaars/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/leenaars/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/leenaars/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leenaars/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/leenaars/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/leenaars/nixpkgs/deployments","created_at":"2015-10-30T23:29:58Z","updated_at":"2016-01-13T19:28:51Z","pushed_at":"2017-02-24T16:04:02Z","git_url":"git://github.com/leenaars/nixpkgs.git","ssh_url":"git@github.com:leenaars/nixpkgs.git","clone_url":"https://github.com/leenaars/nixpkgs.git","svn_url":"https://github.com/leenaars/nixpkgs","homepage":null,"size":393410,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"3af06724fa35655809df53b76c4449ef839a8498","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-02-24T00:38:11Z","pushed_at":"2017-02-24T16:57:52Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":409792,"stargazers_count":1526,"watchers_count":1526,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1891,"mirror_url":null,"open_issues_count":1778,"forks":1891,"open_issues":1778,"watchers":1526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/23114"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/23114"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/23114/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23114/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b6fc45048f7890e6dba4ec22700879831a41d41b"}}}}
{"actor":{"display_login":"edolstra"}}