{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/test262/pulls/comments/143834352","pull_request_review_id":68405383,"id":143834352,"diff_hunk":"@@ -239,15 +241,15 @@ var p = new Promise(function () { /* some test code */ });\n \n p.then(function checkAssertions(arg) {\n   if (!expected_condition) {\n-    $ERROR(\"failure message\");\n+    throw new Test262Error(\"failure message\");","path":"CONTRIBUTING.md","position":128,"original_position":128,"commit_id":"7d764d0295f9ecb912f3d9e582519382872ca9c6","original_commit_id":"7d764d0295f9ecb912f3d9e582519382872ca9c6","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars3.githubusercontent.com/u/301201?v=4","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"body":"`assert(expected_condition, \"assertion message\");` is even better than the whole if case.","created_at":"2017-10-10T19:52:55Z","updated_at":"2017-10-10T19:52:55Z","html_url":"https://github.com/tc39/test262/pull/1267#discussion_r143834352","pull_request_url":"https://api.github.com/repos/tc39/test262/pulls/1267","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/143834352"},"html":{"href":"https://github.com/tc39/test262/pull/1267#discussion_r143834352"},"pull_request":{"href":"https://api.github.com/repos/tc39/test262/pulls/1267"}}},"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/1267","id":145776443,"html_url":"https://github.com/tc39/test262/pull/1267","diff_url":"https://github.com/tc39/test262/pull/1267.diff","patch_url":"https://github.com/tc39/test262/pull/1267.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/1267","number":1267,"state":"open","locked":false,"title":"WIP CONTRIBUTING.md updates","user":{"login":"spectranaut","id":583831,"avatar_url":"https://avatars1.githubusercontent.com/u/583831?v=4","gravatar_id":"","url":"https://api.github.com/users/spectranaut","html_url":"https://github.com/spectranaut","followers_url":"https://api.github.com/users/spectranaut/followers","following_url":"https://api.github.com/users/spectranaut/following{/other_user}","gists_url":"https://api.github.com/users/spectranaut/gists{/gist_id}","starred_url":"https://api.github.com/users/spectranaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spectranaut/subscriptions","organizations_url":"https://api.github.com/users/spectranaut/orgs","repos_url":"https://api.github.com/users/spectranaut/repos","events_url":"https://api.github.com/users/spectranaut/events{/privacy}","received_events_url":"https://api.github.com/users/spectranaut/received_events","type":"User","site_admin":false},"body":"for @rwaldron and @leobalter and @jugglinmike !\r\n\r\nI tried to update the contributing file a few places to reflect the advice I've gotten from all of you. After these edits I think the file is up-to-date, but it might be worth it for you all to take a quick read through the whole file.\r\n\r\nOne section I think is lacking is the \"features\" front matter tag. We should have some concrete recommendations about what necessitates the creation of a new feature (probably, for example, a new feature proposal to ECMA script will necessitate the creation of a new feature tag -- to be used in all the new tests for the new feature). ","created_at":"2017-10-10T19:10:33Z","updated_at":"2017-10-10T19:52:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e37b9162bac2ac31f4a4c86cad538b0383faf77","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/1267/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/1267/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/1267/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/7d764d0295f9ecb912f3d9e582519382872ca9c6","head":{"label":"bocoup:contributing","ref":"contributing","sha":"7d764d0295f9ecb912f3d9e582519382872ca9c6","user":{"login":"bocoup","id":497466,"avatar_url":"https://avatars1.githubusercontent.com/u/497466?v=4","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"repo":{"id":30556261,"name":"test262","full_name":"bocoup/test262","owner":{"login":"bocoup","id":497466,"avatar_url":"https://avatars1.githubusercontent.com/u/497466?v=4","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bocoup/test262","description":null,"fork":true,"url":"https://api.github.com/repos/bocoup/test262","forks_url":"https://api.github.com/repos/bocoup/test262/forks","keys_url":"https://api.github.com/repos/bocoup/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bocoup/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bocoup/test262/teams","hooks_url":"https://api.github.com/repos/bocoup/test262/hooks","issue_events_url":"https://api.github.com/repos/bocoup/test262/issues/events{/number}","events_url":"https://api.github.com/repos/bocoup/test262/events","assignees_url":"https://api.github.com/repos/bocoup/test262/assignees{/user}","branches_url":"https://api.github.com/repos/bocoup/test262/branches{/branch}","tags_url":"https://api.github.com/repos/bocoup/test262/tags","blobs_url":"https://api.github.com/repos/bocoup/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bocoup/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bocoup/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/bocoup/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bocoup/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/bocoup/test262/languages","stargazers_url":"https://api.github.com/repos/bocoup/test262/stargazers","contributors_url":"https://api.github.com/repos/bocoup/test262/contributors","subscribers_url":"https://api.github.com/repos/bocoup/test262/subscribers","subscription_url":"https://api.github.com/repos/bocoup/test262/subscription","commits_url":"https://api.github.com/repos/bocoup/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/bocoup/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/bocoup/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/bocoup/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/bocoup/test262/contents/{+path}","compare_url":"https://api.github.com/repos/bocoup/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bocoup/test262/merges","archive_url":"https://api.github.com/repos/bocoup/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bocoup/test262/downloads","issues_url":"https://api.github.com/repos/bocoup/test262/issues{/number}","pulls_url":"https://api.github.com/repos/bocoup/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/bocoup/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/bocoup/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bocoup/test262/labels{/name}","releases_url":"https://api.github.com/repos/bocoup/test262/releases{/id}","deployments_url":"https://api.github.com/repos/bocoup/test262/deployments","created_at":"2015-02-09T20:17:23Z","updated_at":"2017-01-30T17:03:19Z","pushed_at":"2017-10-10T19:03:19Z","git_url":"git://github.com/bocoup/test262.git","ssh_url":"git@github.com:bocoup/test262.git","clone_url":"https://github.com/bocoup/test262.git","svn_url":"https://github.com/bocoup/test262","homepage":"http://test262.ecmascript.org","size":62661,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"1afb7c74fd8752072397259a3ddf6ab85afdf785","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/test262/deployments","created_at":"2014-01-22T18:20:05Z","updated_at":"2017-10-09T02:20:02Z","pushed_at":"2017-10-10T19:10:34Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"","size":61336,"stargazers_count":615,"watchers_count":615,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":99,"forks":181,"open_issues":99,"watchers":615,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/1267"},"html":{"href":"https://github.com/tc39/test262/pull/1267"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/1267"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/1267/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/1267/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/1267/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/7d764d0295f9ecb912f3d9e582519382872ca9c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leobalter"}}