{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/154742688","pull_request_review_id":80950427,"id":154742688,"diff_hunk":"@@ -1416,7 +1507,59 @@ firebase.auth.Auth.prototype.signInAndRetrieveDataWithCredential = function(\n firebase.auth.Auth.prototype.signInWithCustomToken = function(token) {};\n \n /**\n- * Asynchronously signs in using an email and password.\n+ * Asynchronously signs in using an email and password and returns any additional\n+ * user info data or credentials.\n+ *\n+ * Fails with an error if the email address and password do not match.\n+ *\n+ * Note: The user's password is NOT the password used to access the user's email\n+ * account. The email address serves as a unique identifier for the user, and\n+ * the password is used to access the user's account in your Firebase project.\n+ *\n+ * See also:\n+ * {@link firebase.auth.Auth#createUserAndRetrieveDataWithEmailAndPassword}.\n+ *\n+ * <h4>Error Codes</h4>\n+ * <dl>\n+ * <dt>auth/invalid-email</dt>\n+ * <dd>Thrown if the email address is not valid.</dd>\n+ * <dt>auth/user-disabled</dt>\n+ * <dd>Thrown if the user corresponding to the given email has been\n+ *     disabled.</dd>\n+ * <dt>auth/user-not-found</dt>\n+ * <dd>Thrown if there is no user corresponding to the given email.</dd>\n+ * <dt>auth/wrong-password</dt>\n+ * <dd>Thrown if the password is invalid for the given email, or the account\n+ *     corresponding to the email does not have a password set.</dd>\n+ * </dl>\n+ *\n+ * @example\n+ * firebase.auth().signInAndRetrieveDataWithEmailAndPassword(email, password)\n+ *     .catch(function(error) {\n+ *       // Handle Errors here.\n+ *       var errorCode = error.code;\n+ *       var errorMessage = error.message;\n+ *       if (errorCode === 'auth/wrong-password') {\n+ *         alert('Wrong password.');\n+ *       } else {\n+ *         alert(errorMessage);\n+ *       }\n+ *       console.log(error);\n+ *     });\n+ *\n+ * @param {string} email The users email address.\n+ * @param {string} password The users password.\n+ * @return {!firebase.Promise<!firebase.auth.UserCredential>}\n+ */\n+firebase.auth.Auth.prototype.signInAndRetrieveDataWithEmailAndPassword = function(\n+  email,\n+  password\n+) {};\n+\n+/**\n+ * Asynchronously signs in using an email and password. Will be depercated,","path":"packages/firebase/externs/firebase-auth-externs.js","position":164,"original_position":164,"commit_id":"62e528aacc3ecb44b20293dc652d8fb3eca1f55d","original_commit_id":"4958a454ab11f979bc6f105757f63407e4ec7aaa","user":{"login":"bojeil-google","id":13474811,"avatar_url":"https://avatars1.githubusercontent.com/u/13474811?v=4","gravatar_id":"","url":"https://api.github.com/users/bojeil-google","html_url":"https://github.com/bojeil-google","followers_url":"https://api.github.com/users/bojeil-google/followers","following_url":"https://api.github.com/users/bojeil-google/following{/other_user}","gists_url":"https://api.github.com/users/bojeil-google/gists{/gist_id}","starred_url":"https://api.github.com/users/bojeil-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bojeil-google/subscriptions","organizations_url":"https://api.github.com/users/bojeil-google/orgs","repos_url":"https://api.github.com/users/bojeil-google/repos","events_url":"https://api.github.com/users/bojeil-google/events{/privacy}","received_events_url":"https://api.github.com/users/bojeil-google/received_events","type":"User","site_admin":false},"body":"This method will be deprecated and will be updated to resolve with a `firebase.auth.UserCredential` as is returned in {@link firebase.auth.Auth#signInAndRetrieveDataWithEmailAndPassword}.","created_at":"2017-12-04T18:59:35Z","updated_at":"2017-12-04T19:02:59Z","html_url":"https://github.com/firebase/firebase-js-sdk/pull/344#discussion_r154742688","pull_request_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/154742688"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/344#discussion_r154742688"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344"}}},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344","id":155777738,"html_url":"https://github.com/firebase/firebase-js-sdk/pull/344","diff_url":"https://github.com/firebase/firebase-js-sdk/pull/344.diff","patch_url":"https://github.com/firebase/firebase-js-sdk/pull/344.patch","issue_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/344","number":344,"state":"open","locked":false,"title":"Merged first part of revamp_sign_in_methods","user":{"login":"wti806","id":32399754,"avatar_url":"https://avatars3.githubusercontent.com/u/32399754?v=4","gravatar_id":"","url":"https://api.github.com/users/wti806","html_url":"https://github.com/wti806","followers_url":"https://api.github.com/users/wti806/followers","following_url":"https://api.github.com/users/wti806/following{/other_user}","gists_url":"https://api.github.com/users/wti806/gists{/gist_id}","starred_url":"https://api.github.com/users/wti806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wti806/subscriptions","organizations_url":"https://api.github.com/users/wti806/orgs","repos_url":"https://api.github.com/users/wti806/repos","events_url":"https://api.github.com/users/wti806/events{/privacy}","received_events_url":"https://api.github.com/users/wti806/received_events","type":"User","site_admin":false},"body":"Hey there! So you want to contribute to a Firebase SDK? \r\nBefore you file this pull request, please read these guidelines:\r\n\r\n### Discussion\r\n\r\n  * Read the contribution guidelines (CONTRIBUTING.md).\r\n  * If this has been discussed in an issue, make sure to link to the issue here. \r\n    If not, go file an issue about this **before creating a pull request** to discuss.\r\n\r\n### Testing\r\n\r\n  * Make sure all existing tests in the repository pass after your change.\r\n  * If you fixed a bug or added a feature, add a new test to cover your code.\r\n\r\n### API Changes\r\n\r\n  * At this time we cannot accept changes that affect the public API.  If you'd like to help \r\n    us make Firebase APIs better, please propose your change in an issue so that we \r\n    can discuss it together.\r\n","created_at":"2017-12-01T03:55:30Z","updated_at":"2017-12-04T19:02:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"545bfe04ac5e6e4a92e1b4aba4b62d6ea73c0ed2","assignee":{"login":"wti806","id":32399754,"avatar_url":"https://avatars3.githubusercontent.com/u/32399754?v=4","gravatar_id":"","url":"https://api.github.com/users/wti806","html_url":"https://github.com/wti806","followers_url":"https://api.github.com/users/wti806/followers","following_url":"https://api.github.com/users/wti806/following{/other_user}","gists_url":"https://api.github.com/users/wti806/gists{/gist_id}","starred_url":"https://api.github.com/users/wti806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wti806/subscriptions","organizations_url":"https://api.github.com/users/wti806/orgs","repos_url":"https://api.github.com/users/wti806/repos","events_url":"https://api.github.com/users/wti806/events{/privacy}","received_events_url":"https://api.github.com/users/wti806/received_events","type":"User","site_admin":false},"assignees":[{"login":"wti806","id":32399754,"avatar_url":"https://avatars3.githubusercontent.com/u/32399754?v=4","gravatar_id":"","url":"https://api.github.com/users/wti806","html_url":"https://github.com/wti806","followers_url":"https://api.github.com/users/wti806/followers","following_url":"https://api.github.com/users/wti806/following{/other_user}","gists_url":"https://api.github.com/users/wti806/gists{/gist_id}","starred_url":"https://api.github.com/users/wti806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wti806/subscriptions","organizations_url":"https://api.github.com/users/wti806/orgs","repos_url":"https://api.github.com/users/wti806/repos","events_url":"https://api.github.com/users/wti806/events{/privacy}","received_events_url":"https://api.github.com/users/wti806/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"TMSCH","id":2036827,"avatar_url":"https://avatars0.githubusercontent.com/u/2036827?v=4","gravatar_id":"","url":"https://api.github.com/users/TMSCH","html_url":"https://github.com/TMSCH","followers_url":"https://api.github.com/users/TMSCH/followers","following_url":"https://api.github.com/users/TMSCH/following{/other_user}","gists_url":"https://api.github.com/users/TMSCH/gists{/gist_id}","starred_url":"https://api.github.com/users/TMSCH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TMSCH/subscriptions","organizations_url":"https://api.github.com/users/TMSCH/orgs","repos_url":"https://api.github.com/users/TMSCH/repos","events_url":"https://api.github.com/users/TMSCH/events{/privacy}","received_events_url":"https://api.github.com/users/TMSCH/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/344/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/62e528aacc3ecb44b20293dc652d8fb3eca1f55d","head":{"label":"wti806:revamp_sign_in_methods","ref":"revamp_sign_in_methods","sha":"62e528aacc3ecb44b20293dc652d8fb3eca1f55d","user":{"login":"wti806","id":32399754,"avatar_url":"https://avatars3.githubusercontent.com/u/32399754?v=4","gravatar_id":"","url":"https://api.github.com/users/wti806","html_url":"https://github.com/wti806","followers_url":"https://api.github.com/users/wti806/followers","following_url":"https://api.github.com/users/wti806/following{/other_user}","gists_url":"https://api.github.com/users/wti806/gists{/gist_id}","starred_url":"https://api.github.com/users/wti806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wti806/subscriptions","organizations_url":"https://api.github.com/users/wti806/orgs","repos_url":"https://api.github.com/users/wti806/repos","events_url":"https://api.github.com/users/wti806/events{/privacy}","received_events_url":"https://api.github.com/users/wti806/received_events","type":"User","site_admin":false},"repo":{"id":112677067,"name":"firebase-js-sdk","full_name":"wti806/firebase-js-sdk","owner":{"login":"wti806","id":32399754,"avatar_url":"https://avatars3.githubusercontent.com/u/32399754?v=4","gravatar_id":"","url":"https://api.github.com/users/wti806","html_url":"https://github.com/wti806","followers_url":"https://api.github.com/users/wti806/followers","following_url":"https://api.github.com/users/wti806/following{/other_user}","gists_url":"https://api.github.com/users/wti806/gists{/gist_id}","starred_url":"https://api.github.com/users/wti806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wti806/subscriptions","organizations_url":"https://api.github.com/users/wti806/orgs","repos_url":"https://api.github.com/users/wti806/repos","events_url":"https://api.github.com/users/wti806/events{/privacy}","received_events_url":"https://api.github.com/users/wti806/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wti806/firebase-js-sdk","description":"Firebase Javascript SDK","fork":true,"url":"https://api.github.com/repos/wti806/firebase-js-sdk","forks_url":"https://api.github.com/repos/wti806/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/wti806/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wti806/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wti806/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/wti806/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/wti806/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/wti806/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/wti806/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/wti806/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/wti806/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/wti806/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wti806/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wti806/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/wti806/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wti806/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/wti806/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/wti806/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/wti806/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/wti806/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/wti806/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/wti806/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/wti806/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/wti806/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/wti806/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/wti806/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/wti806/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wti806/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/wti806/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wti806/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/wti806/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/wti806/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/wti806/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/wti806/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wti806/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/wti806/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/wti806/firebase-js-sdk/deployments","created_at":"2017-12-01T00:46:06Z","updated_at":"2017-12-01T00:46:09Z","pushed_at":"2017-12-04T17:50:04Z","git_url":"git://github.com/wti806/firebase-js-sdk.git","ssh_url":"git@github.com:wti806/firebase-js-sdk.git","clone_url":"https://github.com/wti806/firebase-js-sdk.git","svn_url":"https://github.com/wti806/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":13224,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"b70a30960fce937c0b625de762fa184a55002117","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2017-12-04T13:50:56Z","pushed_at":"2017-12-04T18:32:39Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":13217,"stargazers_count":732,"watchers_count":732,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":82,"open_issues":67,"watchers":732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/344"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/344"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/62e528aacc3ecb44b20293dc652d8fb3eca1f55d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bojeil-google"}}