{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/5","id":124476325,"html_url":"https://github.com/muhammadansariqbal/aTGCsAnalysis/pull/5","diff_url":"https://github.com/muhammadansariqbal/aTGCsAnalysis/pull/5.diff","patch_url":"https://github.com/muhammadansariqbal/aTGCsAnalysis/pull/5.patch","issue_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/issues/5","number":5,"state":"open","locked":false,"title":"Overhaul of JEC application, JER smearing, and JEC uncertainty","user":{"login":"raggleton","id":3728382,"avatar_url":"https://avatars3.githubusercontent.com/u/3728382?v=3","gravatar_id":"","url":"https://api.github.com/users/raggleton","html_url":"https://github.com/raggleton","followers_url":"https://api.github.com/users/raggleton/followers","following_url":"https://api.github.com/users/raggleton/following{/other_user}","gists_url":"https://api.github.com/users/raggleton/gists{/gist_id}","starred_url":"https://api.github.com/users/raggleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raggleton/subscriptions","organizations_url":"https://api.github.com/users/raggleton/orgs","repos_url":"https://api.github.com/users/raggleton/repos","events_url":"https://api.github.com/users/raggleton/events{/privacy}","received_events_url":"https://api.github.com/users/raggleton/received_events","type":"User","site_admin":false},"body":"This PR overhauls how JEC & JER smearing is done, by getting the corrections from the GlobalTag, instead of from text files. This is the recommended way to do it, and allows the corrections etc to be done **before** any other selection cuts, etc. \r\n\r\nBrief rundown:\r\n\r\n- JEC are now applied to **both** the ak8 and ak4 PF+CHS jet collections using the official modules (see `goodJets_cff.py`) - previously wasn't done for ak4, or for ak8 jet pt/energy in MC. I have kept the same levels of JEC as before (i.e. no L1FastJet)\r\n\r\n- The correct JEC are now applied for the various run IOVs automatically (BCD vs EF vs G vs H) (and I checked the GT we use have the latest & greatest JEC)\r\n\r\n- The JER smearing has been updated to the Spring16 sets (previously Fall15)\r\n\r\n- Fixed the JEC uncertainty implementation\r\n\r\nNBs/todos:\r\n\r\n- The JER up/down variation is broken - it applies it on top of the already smeared Jets\r\n\r\n- The JEC **have not** yet been propagated through to MET \r\n\r\nReferences:\r\n\r\nhttps://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookJetEnergyCorrections\r\nhttps://github.com/cms-jet/JMEReferenceTable (example code for JEC+JER modules)\r\nhttps://twiki.cern.ch/twiki/bin/view/CMS/JECDataMC\r\nhttps://github.com/cms-jet/JRDatabase\r\n\r\n","created_at":"2017-06-07T17:30:40Z","updated_at":"2017-06-07T17:30:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/5/commits","review_comments_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/5/comments","review_comment_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/issues/5/comments","statuses_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/statuses/702e73d813185c97a9835435dbd4005429eec57f","head":{"label":"raggleton:UpdateJECModules","ref":"UpdateJECModules","sha":"702e73d813185c97a9835435dbd4005429eec57f","user":{"login":"raggleton","id":3728382,"avatar_url":"https://avatars3.githubusercontent.com/u/3728382?v=3","gravatar_id":"","url":"https://api.github.com/users/raggleton","html_url":"https://github.com/raggleton","followers_url":"https://api.github.com/users/raggleton/followers","following_url":"https://api.github.com/users/raggleton/following{/other_user}","gists_url":"https://api.github.com/users/raggleton/gists{/gist_id}","starred_url":"https://api.github.com/users/raggleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raggleton/subscriptions","organizations_url":"https://api.github.com/users/raggleton/orgs","repos_url":"https://api.github.com/users/raggleton/repos","events_url":"https://api.github.com/users/raggleton/events{/privacy}","received_events_url":"https://api.github.com/users/raggleton/received_events","type":"User","site_admin":false},"repo":{"id":91315400,"name":"aTGCsAnalysis","full_name":"raggleton/aTGCsAnalysis","owner":{"login":"raggleton","id":3728382,"avatar_url":"https://avatars3.githubusercontent.com/u/3728382?v=3","gravatar_id":"","url":"https://api.github.com/users/raggleton","html_url":"https://github.com/raggleton","followers_url":"https://api.github.com/users/raggleton/followers","following_url":"https://api.github.com/users/raggleton/following{/other_user}","gists_url":"https://api.github.com/users/raggleton/gists{/gist_id}","starred_url":"https://api.github.com/users/raggleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raggleton/subscriptions","organizations_url":"https://api.github.com/users/raggleton/orgs","repos_url":"https://api.github.com/users/raggleton/repos","events_url":"https://api.github.com/users/raggleton/events{/privacy}","received_events_url":"https://api.github.com/users/raggleton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raggleton/aTGCsAnalysis","description":"CMSSW Project for Anomalous Triple Gauge Couplings Analysis","fork":true,"url":"https://api.github.com/repos/raggleton/aTGCsAnalysis","forks_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/forks","keys_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/teams","hooks_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/hooks","issue_events_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/issues/events{/number}","events_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/events","assignees_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/assignees{/user}","branches_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/branches{/branch}","tags_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/tags","blobs_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/languages","stargazers_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/stargazers","contributors_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/contributors","subscribers_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/subscribers","subscription_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/subscription","commits_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/contents/{+path}","compare_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/merges","archive_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/downloads","issues_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/issues{/number}","pulls_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/labels{/name}","releases_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/releases{/id}","deployments_url":"https://api.github.com/repos/raggleton/aTGCsAnalysis/deployments","created_at":"2017-05-15T08:47:41Z","updated_at":"2017-05-15T08:47:43Z","pushed_at":"2017-06-07T17:12:47Z","git_url":"git://github.com/raggleton/aTGCsAnalysis.git","ssh_url":"git@github.com:raggleton/aTGCsAnalysis.git","clone_url":"https://github.com/raggleton/aTGCsAnalysis.git","svn_url":"https://github.com/raggleton/aTGCsAnalysis","homepage":null,"size":1783,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"80X"}},"base":{"label":"muhammadansariqbal:80X","ref":"80X","sha":"f9289857ccc973356a351980395b3e709e5acead","user":{"login":"muhammadansariqbal","id":10369384,"avatar_url":"https://avatars2.githubusercontent.com/u/10369384?v=3","gravatar_id":"","url":"https://api.github.com/users/muhammadansariqbal","html_url":"https://github.com/muhammadansariqbal","followers_url":"https://api.github.com/users/muhammadansariqbal/followers","following_url":"https://api.github.com/users/muhammadansariqbal/following{/other_user}","gists_url":"https://api.github.com/users/muhammadansariqbal/gists{/gist_id}","starred_url":"https://api.github.com/users/muhammadansariqbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhammadansariqbal/subscriptions","organizations_url":"https://api.github.com/users/muhammadansariqbal/orgs","repos_url":"https://api.github.com/users/muhammadansariqbal/repos","events_url":"https://api.github.com/users/muhammadansariqbal/events{/privacy}","received_events_url":"https://api.github.com/users/muhammadansariqbal/received_events","type":"User","site_admin":false},"repo":{"id":88993633,"name":"aTGCsAnalysis","full_name":"muhammadansariqbal/aTGCsAnalysis","owner":{"login":"muhammadansariqbal","id":10369384,"avatar_url":"https://avatars2.githubusercontent.com/u/10369384?v=3","gravatar_id":"","url":"https://api.github.com/users/muhammadansariqbal","html_url":"https://github.com/muhammadansariqbal","followers_url":"https://api.github.com/users/muhammadansariqbal/followers","following_url":"https://api.github.com/users/muhammadansariqbal/following{/other_user}","gists_url":"https://api.github.com/users/muhammadansariqbal/gists{/gist_id}","starred_url":"https://api.github.com/users/muhammadansariqbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhammadansariqbal/subscriptions","organizations_url":"https://api.github.com/users/muhammadansariqbal/orgs","repos_url":"https://api.github.com/users/muhammadansariqbal/repos","events_url":"https://api.github.com/users/muhammadansariqbal/events{/privacy}","received_events_url":"https://api.github.com/users/muhammadansariqbal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muhammadansariqbal/aTGCsAnalysis","description":"CMSSW Project for Anomalous Triple Gauge Couplings Analysis","fork":false,"url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis","forks_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/forks","keys_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/teams","hooks_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/hooks","issue_events_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/issues/events{/number}","events_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/events","assignees_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/assignees{/user}","branches_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/branches{/branch}","tags_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/tags","blobs_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/languages","stargazers_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/stargazers","contributors_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/contributors","subscribers_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/subscribers","subscription_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/subscription","commits_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/contents/{+path}","compare_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/merges","archive_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/downloads","issues_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/issues{/number}","pulls_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/labels{/name}","releases_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/releases{/id}","deployments_url":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/deployments","created_at":"2017-04-21T14:42:36Z","updated_at":"2017-05-15T08:47:30Z","pushed_at":"2017-06-07T12:25:26Z","git_url":"git://github.com/muhammadansariqbal/aTGCsAnalysis.git","ssh_url":"git@github.com:muhammadansariqbal/aTGCsAnalysis.git","clone_url":"https://github.com/muhammadansariqbal/aTGCsAnalysis.git","svn_url":"https://github.com/muhammadansariqbal/aTGCsAnalysis","homepage":null,"size":1167,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"80X"}},"_links":{"self":{"href":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/5"},"html":{"href":"https://github.com/muhammadansariqbal/aTGCsAnalysis/pull/5"},"issue":{"href":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/issues/5"},"comments":{"href":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/muhammadansariqbal/aTGCsAnalysis/statuses/702e73d813185c97a9835435dbd4005429eec57f"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":8,"additions":3446,"deletions":6747,"changed_files":87}}
{"actor":{"display_login":"raggleton"}}