{"action":"created","issue":{"url":"https://api.github.com/repos/gjedeer/celery-php/issues/104","repository_url":"https://api.github.com/repos/gjedeer/celery-php","labels_url":"https://api.github.com/repos/gjedeer/celery-php/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/gjedeer/celery-php/issues/104/comments","events_url":"https://api.github.com/repos/gjedeer/celery-php/issues/104/events","html_url":"https://github.com/gjedeer/celery-php/pull/104","id":225955607,"number":104,"title":"Allow Celery class to connect to different broker and backend","user":{"login":"jdufresne","id":347634,"avatar_url":"https://avatars2.githubusercontent.com/u/347634?v=3","gravatar_id":"","url":"https://api.github.com/users/jdufresne","html_url":"https://github.com/jdufresne","followers_url":"https://api.github.com/users/jdufresne/followers","following_url":"https://api.github.com/users/jdufresne/following{/other_user}","gists_url":"https://api.github.com/users/jdufresne/gists{/gist_id}","starred_url":"https://api.github.com/users/jdufresne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdufresne/subscriptions","organizations_url":"https://api.github.com/users/jdufresne/orgs","repos_url":"https://api.github.com/users/jdufresne/repos","events_url":"https://api.github.com/users/jdufresne/events{/privacy}","received_events_url":"https://api.github.com/users/jdufresne/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-05-03T11:29:26Z","updated_at":"2017-05-03T16:45:52Z","closed_at":"2017-05-03T15:52:57Z","pull_request":{"url":"https://api.github.com/repos/gjedeer/celery-php/pulls/104","html_url":"https://github.com/gjedeer/celery-php/pull/104","diff_url":"https://github.com/gjedeer/celery-php/pull/104.diff","patch_url":"https://github.com/gjedeer/celery-php/pull/104.patch"},"body":"Constructor accepts two connection arrays.\r\n\r\nFlattens class hierarchy. Remove CeleryAbstract and CeleryAdvanced. Now\r\nCelery is full featured. Remove hierarchy as it provided no additional\r\nuseful abstraction or reuse."},"comment":{"url":"https://api.github.com/repos/gjedeer/celery-php/issues/comments/298968296","html_url":"https://github.com/gjedeer/celery-php/pull/104#issuecomment-298968296","issue_url":"https://api.github.com/repos/gjedeer/celery-php/issues/104","id":298968296,"user":{"login":"gjedeer","id":315648,"avatar_url":"https://avatars1.githubusercontent.com/u/315648?v=3","gravatar_id":"","url":"https://api.github.com/users/gjedeer","html_url":"https://github.com/gjedeer","followers_url":"https://api.github.com/users/gjedeer/followers","following_url":"https://api.github.com/users/gjedeer/following{/other_user}","gists_url":"https://api.github.com/users/gjedeer/gists{/gist_id}","starred_url":"https://api.github.com/users/gjedeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjedeer/subscriptions","organizations_url":"https://api.github.com/users/gjedeer/orgs","repos_url":"https://api.github.com/users/gjedeer/repos","events_url":"https://api.github.com/users/gjedeer/events{/privacy}","received_events_url":"https://api.github.com/users/gjedeer/received_events","type":"User","site_admin":false},"created_at":"2017-05-03T16:45:52Z","updated_at":"2017-05-03T16:45:52Z","body":"Yeah, you changed the tests so of course they pass. The reason why they exist is to ensure API stability.\n\nI won't stop you from merging that but it breaks the primary goal of this project. There was a reason why a second constructor was introduced instead of changing the Celery class, it was not a choice based on ignorance but on a promise given to the users.\n\nOn 3 May 2017 18:27:39 CEST, Jon Dufresne <notifications@github.com> wrote:\n>Unit tests do pass, see the Travis CI status. I bumped the semantic\n>version to handle the change in API.\n>\n>-- \n>You are receiving this because you modified the open/close state.\n>Reply to this email directly or view it on GitHub:\n>https://github.com/gjedeer/celery-php/pull/104#issuecomment-298963392\n\n-- \nSent from my Android device with K-9 Mail. Please excuse my brevity."}}
{"actor":{"display_login":"gjedeer"}}