{"action":"created","issue":{"url":"https://api.github.com/repos/bhodorog/pytest-vts/issues/2","repository_url":"https://api.github.com/repos/bhodorog/pytest-vts","labels_url":"https://api.github.com/repos/bhodorog/pytest-vts/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/bhodorog/pytest-vts/issues/2/comments","events_url":"https://api.github.com/repos/bhodorog/pytest-vts/issues/2/events","html_url":"https://github.com/bhodorog/pytest-vts/issues/2","id":191848848,"number":2,"title":"use of globals","user":{"login":"markfink","id":33456,"avatar_url":"https://avatars.githubusercontent.com/u/33456?v=3","gravatar_id":"","url":"https://api.github.com/users/markfink","html_url":"https://github.com/markfink","followers_url":"https://api.github.com/users/markfink/followers","following_url":"https://api.github.com/users/markfink/following{/other_user}","gists_url":"https://api.github.com/users/markfink/gists{/gist_id}","starred_url":"https://api.github.com/users/markfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfink/subscriptions","organizations_url":"https://api.github.com/users/markfink/orgs","repos_url":"https://api.github.com/users/markfink/repos","events_url":"https://api.github.com/users/markfink/events{/privacy}","received_events_url":"https://api.github.com/users/markfink/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-27T08:20:42Z","updated_at":"2017-02-01T03:42:57Z","closed_at":"2017-02-01T03:42:57Z","body":"good work. thank you!\r\n\r\nif I am not mistaken this is not used anywhere (from vts/\\_\\_init__.py):\r\n```Python\r\n    recorder = None\r\n    ...\r\n    global recorder\r\n    recorder = vts_recorder\r\n```\r\ninstead you use fixtures like you should but it makes your code look weak"},"comment":{"url":"https://api.github.com/repos/bhodorog/pytest-vts/issues/comments/276565004","html_url":"https://github.com/bhodorog/pytest-vts/issues/2#issuecomment-276565004","issue_url":"https://api.github.com/repos/bhodorog/pytest-vts/issues/2","id":276565004,"user":{"login":"bhodorog","id":1888580,"avatar_url":"https://avatars.githubusercontent.com/u/1888580?v=3","gravatar_id":"","url":"https://api.github.com/users/bhodorog","html_url":"https://github.com/bhodorog","followers_url":"https://api.github.com/users/bhodorog/followers","following_url":"https://api.github.com/users/bhodorog/following{/other_user}","gists_url":"https://api.github.com/users/bhodorog/gists{/gist_id}","starred_url":"https://api.github.com/users/bhodorog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhodorog/subscriptions","organizations_url":"https://api.github.com/users/bhodorog/orgs","repos_url":"https://api.github.com/users/bhodorog/repos","events_url":"https://api.github.com/users/bhodorog/events{/privacy}","received_events_url":"https://api.github.com/users/bhodorog/received_events","type":"User","site_admin":false},"created_at":"2017-02-01T03:42:57Z","updated_at":"2017-02-01T03:42:57Z","body":"P.S. recently I've been investigating vts behaviour in a greenlet-ed environment. Having access to the global  recorder object proved a blis, since the alternative of navigating the stack become even more cumbersome.\r\n\r\nAs a result I'll stick with my initial decision for now and I'll close this issue until further feedback."}}
{"actor":{"display_login":"bhodorog"}}