{"action":"created","issue":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2994","repository_url":"https://api.github.com/repos/salesagility/SuiteCRM","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2994/labels{/name}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2994/comments","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2994/events","html_url":"https://github.com/salesagility/SuiteCRM/pull/2994","id":203618025,"number":2994,"title":"Rebrand the Search Filter in Modules","user":{"login":"kdjmonaghan","id":3587120,"avatar_url":"https://avatars.githubusercontent.com/u/3587120?v=3","gravatar_id":"","url":"https://api.github.com/users/kdjmonaghan","html_url":"https://github.com/kdjmonaghan","followers_url":"https://api.github.com/users/kdjmonaghan/followers","following_url":"https://api.github.com/users/kdjmonaghan/following{/other_user}","gists_url":"https://api.github.com/users/kdjmonaghan/gists{/gist_id}","starred_url":"https://api.github.com/users/kdjmonaghan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdjmonaghan/subscriptions","organizations_url":"https://api.github.com/users/kdjmonaghan/orgs","repos_url":"https://api.github.com/users/kdjmonaghan/repos","events_url":"https://api.github.com/users/kdjmonaghan/events{/privacy}","received_events_url":"https://api.github.com/users/kdjmonaghan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-01-27T11:54:54Z","updated_at":"2017-01-29T10:00:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/2994","html_url":"https://github.com/salesagility/SuiteCRM/pull/2994","diff_url":"https://github.com/salesagility/SuiteCRM/pull/2994.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/2994.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nSCRM-205 - Replace occurrences of \"Search\" with \"Filter\" where the user could see them, especially in studio.\r\nSCRM-204 - Remove \"Search\" from listview header.\r\nRemove duplicated deceleration of 'LBL_ADVANCED_SEARCH' in en_us.lang.php\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nChanging labels for \"Search\" to \"Filter\".\r\nRemoving \"Search\" from List View headers.\r\nRemove duplicate deceleration of 'LBL_ADVANCED_SEARCH' (Issue #2979)\r\n\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nOccurrences of \"Search\" had to be replaced with \"Filter\" for the next release.\r\n\"Search\"  had to be removed from the List View headers.\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\nBrowse to locations \"Search\" was located previously such as Studio.\r\nView any list view page and see if \"Search\" is included in the header.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://suitecrm.com/wiki/index.php/Coding_Standards).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://suitecrm.com/wiki/index.php/Contributing_to_SuiteCRM) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->"},"comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments/275904260","html_url":"https://github.com/salesagility/SuiteCRM/pull/2994#issuecomment-275904260","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/2994","id":275904260,"user":{"login":"samus-aran","id":4041275,"avatar_url":"https://avatars.githubusercontent.com/u/4041275?v=3","gravatar_id":"","url":"https://api.github.com/users/samus-aran","html_url":"https://github.com/samus-aran","followers_url":"https://api.github.com/users/samus-aran/followers","following_url":"https://api.github.com/users/samus-aran/following{/other_user}","gists_url":"https://api.github.com/users/samus-aran/gists{/gist_id}","starred_url":"https://api.github.com/users/samus-aran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samus-aran/subscriptions","organizations_url":"https://api.github.com/users/samus-aran/orgs","repos_url":"https://api.github.com/users/samus-aran/repos","events_url":"https://api.github.com/users/samus-aran/events{/privacy}","received_events_url":"https://api.github.com/users/samus-aran/received_events","type":"User","site_admin":false},"created_at":"2017-01-29T10:00:11Z","updated_at":"2017-01-29T10:00:11Z","body":"The decision to still maintain both the labels LBL_BASIC_SEARCH and LBL_ADVANCED_SEARCH currently is due to the extensiveness that these words play through the core including names of views and actions.  The next goal is to refactor those views and actions aswell, but will require thorough testing.  So the merge will only include KEYs which have minor impact on the system and the above action will be scheduled as a high TO DO to not increase technical debt."}}
{"actor":{"display_login":"samus-aran"}}