{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/136909415","pull_request_review_id":60511347,"id":136909415,"diff_hunk":"@@ -63,19 +63,10 @@\n ENV['CFLAGS'] = '-DGPR_BACKWARDS_COMPATIBILITY_MODE'\n \n output_dir = File.expand_path(RbConfig::CONFIG['topdir'])\n-grpc_lib_dir = File.join(output_dir, 'libs', grpc_config)\n ENV['BUILDDIR'] = output_dir\n \n-unless windows","path":"src/ruby/ext/grpc/extconf.rb","position":7,"original_position":7,"commit_id":"3d6c38e1b6360117b8bd96301641b9c21a5eb507","original_commit_id":"3d6c38e1b6360117b8bd96301641b9c21a5eb507","user":{"login":"timwr","id":684924,"avatar_url":"https://avatars2.githubusercontent.com/u/684924?v=4","gravatar_id":"","url":"https://api.github.com/users/timwr","html_url":"https://github.com/timwr","followers_url":"https://api.github.com/users/timwr/followers","following_url":"https://api.github.com/users/timwr/following{/other_user}","gists_url":"https://api.github.com/users/timwr/gists{/gist_id}","starred_url":"https://api.github.com/users/timwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timwr/subscriptions","organizations_url":"https://api.github.com/users/timwr/orgs","repos_url":"https://api.github.com/users/timwr/repos","events_url":"https://api.github.com/users/timwr/events{/privacy}","received_events_url":"https://api.github.com/users/timwr/received_events","type":"User","site_admin":false},"body":"are we sure it's OK to remove this?\r\nhow about\r\n```\r\nif termux #check an env variable perhaps?\r\n  grpc_lib_dir = ENV['PREFIX'] + '/lib'\r\nelse if not windows\r\n  ...\r\nend\r\n```","created_at":"2017-09-05T07:12:01Z","updated_at":"2017-09-05T07:12:01Z","html_url":"https://github.com/grpc/grpc/pull/12385#discussion_r136909415","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/12385","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/136909415"},"html":{"href":"https://github.com/grpc/grpc/pull/12385#discussion_r136909415"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12385"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/12385","id":139249971,"html_url":"https://github.com/grpc/grpc/pull/12385","diff_url":"https://github.com/grpc/grpc/pull/12385.diff","patch_url":"https://github.com/grpc/grpc/pull/12385.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/12385","number":12385,"state":"open","locked":false,"title":"Updated extconf for termux installation fix","user":{"login":"Auxilus","id":23075789,"avatar_url":"https://avatars1.githubusercontent.com/u/23075789?v=4","gravatar_id":"","url":"https://api.github.com/users/Auxilus","html_url":"https://github.com/Auxilus","followers_url":"https://api.github.com/users/Auxilus/followers","following_url":"https://api.github.com/users/Auxilus/following{/other_user}","gists_url":"https://api.github.com/users/Auxilus/gists{/gist_id}","starred_url":"https://api.github.com/users/Auxilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Auxilus/subscriptions","organizations_url":"https://api.github.com/users/Auxilus/orgs","repos_url":"https://api.github.com/users/Auxilus/repos","events_url":"https://api.github.com/users/Auxilus/events{/privacy}","received_events_url":"https://api.github.com/users/Auxilus/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-05T07:01:03Z","updated_at":"2017-09-05T07:12:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff5b43f8af2a3734e0151ad6326b8a02bea4e852","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/12385/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/12385/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/12385/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/3d6c38e1b6360117b8bd96301641b9c21a5eb507","head":{"label":"Auxilus:patch-1","ref":"patch-1","sha":"3d6c38e1b6360117b8bd96301641b9c21a5eb507","user":{"login":"Auxilus","id":23075789,"avatar_url":"https://avatars1.githubusercontent.com/u/23075789?v=4","gravatar_id":"","url":"https://api.github.com/users/Auxilus","html_url":"https://github.com/Auxilus","followers_url":"https://api.github.com/users/Auxilus/followers","following_url":"https://api.github.com/users/Auxilus/following{/other_user}","gists_url":"https://api.github.com/users/Auxilus/gists{/gist_id}","starred_url":"https://api.github.com/users/Auxilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Auxilus/subscriptions","organizations_url":"https://api.github.com/users/Auxilus/orgs","repos_url":"https://api.github.com/users/Auxilus/repos","events_url":"https://api.github.com/users/Auxilus/events{/privacy}","received_events_url":"https://api.github.com/users/Auxilus/received_events","type":"User","site_admin":false},"repo":{"id":102444836,"name":"grpc","full_name":"Auxilus/grpc","owner":{"login":"Auxilus","id":23075789,"avatar_url":"https://avatars1.githubusercontent.com/u/23075789?v=4","gravatar_id":"","url":"https://api.github.com/users/Auxilus","html_url":"https://github.com/Auxilus","followers_url":"https://api.github.com/users/Auxilus/followers","following_url":"https://api.github.com/users/Auxilus/following{/other_user}","gists_url":"https://api.github.com/users/Auxilus/gists{/gist_id}","starred_url":"https://api.github.com/users/Auxilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Auxilus/subscriptions","organizations_url":"https://api.github.com/users/Auxilus/orgs","repos_url":"https://api.github.com/users/Auxilus/repos","events_url":"https://api.github.com/users/Auxilus/events{/privacy}","received_events_url":"https://api.github.com/users/Auxilus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Auxilus/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/Auxilus/grpc","forks_url":"https://api.github.com/repos/Auxilus/grpc/forks","keys_url":"https://api.github.com/repos/Auxilus/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Auxilus/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Auxilus/grpc/teams","hooks_url":"https://api.github.com/repos/Auxilus/grpc/hooks","issue_events_url":"https://api.github.com/repos/Auxilus/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/Auxilus/grpc/events","assignees_url":"https://api.github.com/repos/Auxilus/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/Auxilus/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/Auxilus/grpc/tags","blobs_url":"https://api.github.com/repos/Auxilus/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Auxilus/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Auxilus/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Auxilus/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Auxilus/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/Auxilus/grpc/languages","stargazers_url":"https://api.github.com/repos/Auxilus/grpc/stargazers","contributors_url":"https://api.github.com/repos/Auxilus/grpc/contributors","subscribers_url":"https://api.github.com/repos/Auxilus/grpc/subscribers","subscription_url":"https://api.github.com/repos/Auxilus/grpc/subscription","commits_url":"https://api.github.com/repos/Auxilus/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Auxilus/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Auxilus/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Auxilus/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Auxilus/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/Auxilus/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Auxilus/grpc/merges","archive_url":"https://api.github.com/repos/Auxilus/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Auxilus/grpc/downloads","issues_url":"https://api.github.com/repos/Auxilus/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/Auxilus/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/Auxilus/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/Auxilus/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Auxilus/grpc/labels{/name}","releases_url":"https://api.github.com/repos/Auxilus/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/Auxilus/grpc/deployments","created_at":"2017-09-05T06:48:42Z","updated_at":"2017-09-05T06:48:55Z","pushed_at":"2017-09-05T06:55:46Z","git_url":"git://github.com/Auxilus/grpc.git","ssh_url":"git@github.com:Auxilus/grpc.git","clone_url":"https://github.com/Auxilus/grpc.git","svn_url":"https://github.com/Auxilus/grpc","homepage":"","size":134215,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"89e68acb5044ed3b6e19e0e41874abb24cfb1f49","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2017-09-05T06:08:36Z","pushed_at":"2017-09-05T07:01:04Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":134215,"stargazers_count":11186,"watchers_count":11186,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2353,"mirror_url":null,"open_issues_count":1381,"forks":2353,"open_issues":1381,"watchers":11186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12385"},"html":{"href":"https://github.com/grpc/grpc/pull/12385"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/12385"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/12385/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12385/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12385/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/3d6c38e1b6360117b8bd96301641b9c21a5eb507"}},"author_association":"NONE"}}
{"actor":{"display_login":"timwr"}}