{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/comments/148512742","pull_request_review_id":73765463,"id":148512742,"diff_hunk":"@@ -41,3 +50,8 @@ services:\n         class: EzSystems\\PlatformHttpCacheBundle\\ResponseTagger\\Value\\LocationTagger\n         tags:\n             - {name: ezplatform.cache_response_tagger}\n+\n+    ezplatform.view_cache.response_tagger.restlocationbc:\n+        class: EzSystems\\PlatformHttpCacheBundle\\ResponseTagger\\Value\\RestLocationBCTagger\n+        tags:\n+            - {name: ezplatform.cache_response_tagger}","path":"src/Resources/config/view_cache.yml","position":31,"original_position":31,"commit_id":"0fd42c6ae9592eb4a0409b54e855707c43edf8e5","original_commit_id":"0fd42c6ae9592eb4a0409b54e855707c43edf8e5","user":{"login":"vidarl","id":289778,"avatar_url":"https://avatars2.githubusercontent.com/u/289778?v=4","gravatar_id":"","url":"https://api.github.com/users/vidarl","html_url":"https://github.com/vidarl","followers_url":"https://api.github.com/users/vidarl/followers","following_url":"https://api.github.com/users/vidarl/following{/other_user}","gists_url":"https://api.github.com/users/vidarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vidarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidarl/subscriptions","organizations_url":"https://api.github.com/users/vidarl/orgs","repos_url":"https://api.github.com/users/vidarl/repos","events_url":"https://api.github.com/users/vidarl/events{/privacy}","received_events_url":"https://api.github.com/users/vidarl/received_events","type":"User","site_admin":false},"body":"I really don't get the reasoning behind splitting the response taggers in delegators and values. It just creates overhead? Also, given that we keep this split, why does also the value tagges have the `ezplatform.cache_response_tagger` tag? It means they are both invoked by the dispatcher directly, and by their delicator","created_at":"2017-11-02T12:07:38Z","updated_at":"2017-11-02T12:07:38Z","html_url":"https://github.com/ezsystems/ezplatform-http-cache/pull/19#discussion_r148512742","pull_request_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/comments/148512742"},"html":{"href":"https://github.com/ezsystems/ezplatform-http-cache/pull/19#discussion_r148512742"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19","id":150271997,"html_url":"https://github.com/ezsystems/ezplatform-http-cache/pull/19","diff_url":"https://github.com/ezsystems/ezplatform-http-cache/pull/19.diff","patch_url":"https://github.com/ezsystems/ezplatform-http-cache/pull/19.patch","issue_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/issues/19","number":19,"state":"open","locked":false,"title":"Plugin support","user":{"login":"vidarl","id":289778,"avatar_url":"https://avatars2.githubusercontent.com/u/289778?v=4","gravatar_id":"","url":"https://api.github.com/users/vidarl","html_url":"https://github.com/vidarl","followers_url":"https://api.github.com/users/vidarl/followers","following_url":"https://api.github.com/users/vidarl/following{/other_user}","gists_url":"https://api.github.com/users/vidarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vidarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidarl/subscriptions","organizations_url":"https://api.github.com/users/vidarl/orgs","repos_url":"https://api.github.com/users/vidarl/repos","events_url":"https://api.github.com/users/vidarl/events{/privacy}","received_events_url":"https://api.github.com/users/vidarl/received_events","type":"User","site_admin":false},"body":"This PR makes it possible to extend http cache in 3rd party bundles\r\n\r\ntodo:\r\n - Add PR to EzPublishCore bundle\r\n - Add doc\r\n","created_at":"2017-11-02T11:58:34Z","updated_at":"2017-11-02T12:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae903a3982ad9d07684d76afa6d2002ffdc20b01","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/issues/19/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/statuses/0fd42c6ae9592eb4a0409b54e855707c43edf8e5","head":{"label":"vidarl:plugin_support","ref":"plugin_support","sha":"0fd42c6ae9592eb4a0409b54e855707c43edf8e5","user":{"login":"vidarl","id":289778,"avatar_url":"https://avatars2.githubusercontent.com/u/289778?v=4","gravatar_id":"","url":"https://api.github.com/users/vidarl","html_url":"https://github.com/vidarl","followers_url":"https://api.github.com/users/vidarl/followers","following_url":"https://api.github.com/users/vidarl/following{/other_user}","gists_url":"https://api.github.com/users/vidarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vidarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidarl/subscriptions","organizations_url":"https://api.github.com/users/vidarl/orgs","repos_url":"https://api.github.com/users/vidarl/repos","events_url":"https://api.github.com/users/vidarl/events{/privacy}","received_events_url":"https://api.github.com/users/vidarl/received_events","type":"User","site_admin":false},"repo":{"id":106692657,"name":"ezplatform-http-cache","full_name":"vidarl/ezplatform-http-cache","owner":{"login":"vidarl","id":289778,"avatar_url":"https://avatars2.githubusercontent.com/u/289778?v=4","gravatar_id":"","url":"https://api.github.com/users/vidarl","html_url":"https://github.com/vidarl","followers_url":"https://api.github.com/users/vidarl/followers","following_url":"https://api.github.com/users/vidarl/following{/other_user}","gists_url":"https://api.github.com/users/vidarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vidarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidarl/subscriptions","organizations_url":"https://api.github.com/users/vidarl/orgs","repos_url":"https://api.github.com/users/vidarl/repos","events_url":"https://api.github.com/users/vidarl/events{/privacy}","received_events_url":"https://api.github.com/users/vidarl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vidarl/ezplatform-http-cache","description":"HTTP cache handling for eZ Platform, using multi tagging (incl Varnish xkey)","fork":true,"url":"https://api.github.com/repos/vidarl/ezplatform-http-cache","forks_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/forks","keys_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/teams","hooks_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/hooks","issue_events_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/issues/events{/number}","events_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/events","assignees_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/assignees{/user}","branches_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/branches{/branch}","tags_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/tags","blobs_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/languages","stargazers_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/stargazers","contributors_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/contributors","subscribers_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/subscribers","subscription_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/subscription","commits_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/contents/{+path}","compare_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/merges","archive_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/downloads","issues_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/issues{/number}","pulls_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/labels{/name}","releases_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/releases{/id}","deployments_url":"https://api.github.com/repos/vidarl/ezplatform-http-cache/deployments","created_at":"2017-10-12T12:54:31Z","updated_at":"2017-10-12T12:54:32Z","pushed_at":"2017-11-02T11:56:49Z","git_url":"git://github.com/vidarl/ezplatform-http-cache.git","ssh_url":"git@github.com:vidarl/ezplatform-http-cache.git","clone_url":"https://github.com/vidarl/ezplatform-http-cache.git","svn_url":"https://github.com/vidarl/ezplatform-http-cache","homepage":"","size":76,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"65cf537126864e32ed389cae9b478a7694a9fdef","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":81233280,"name":"ezplatform-http-cache","full_name":"ezsystems/ezplatform-http-cache","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezplatform-http-cache","description":"HTTP cache handling for eZ Platform, using multi tagging (incl Varnish xkey)","fork":false,"url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache","forks_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/forks","keys_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/events","assignees_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/merges","archive_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/deployments","created_at":"2017-02-07T17:11:30Z","updated_at":"2017-09-06T14:46:33Z","pushed_at":"2017-11-02T11:58:35Z","git_url":"git://github.com/ezsystems/ezplatform-http-cache.git","ssh_url":"git@github.com:ezsystems/ezplatform-http-cache.git","clone_url":"https://github.com/ezsystems/ezplatform-http-cache.git","svn_url":"https://github.com/ezsystems/ezplatform-http-cache","homepage":"","size":76,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19"},"html":{"href":"https://github.com/ezsystems/ezplatform-http-cache/pull/19"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/issues/19"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezplatform-http-cache/statuses/0fd42c6ae9592eb4a0409b54e855707c43edf8e5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vidarl"}}