{"action":"created","comment":{"url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments/105865047","pull_request_review_id":26762444,"id":105865047,"diff_hunk":"@@ -1704,15 +1706,18 @@ void SourceBuffer::sourceBufferPrivateDidReceiveSample(SourceBufferPrivate*, Med\n         if (m_shouldGenerateTimestamps)\n             m_timestampOffset = frameEndTimestamp;\n \n+        if (trackBuffer.fudgeRoom.isInvalid() || trackBuffer.fudgeRoom < frameDuration)\n+            trackBuffer.fudgeRoom = frameDuration;","path":"Source/WebCore/Modules/mediasource/SourceBuffer.cpp","position":21,"original_position":21,"commit_id":"dcadd156f334cdad562f8d84d61257a0c38705d2","original_commit_id":"dcadd156f334cdad562f8d84d61257a0c38705d2","user":{"login":"eocanha","id":6864279,"avatar_url":"https://avatars3.githubusercontent.com/u/6864279?v=3","gravatar_id":"","url":"https://api.github.com/users/eocanha","html_url":"https://github.com/eocanha","followers_url":"https://api.github.com/users/eocanha/followers","following_url":"https://api.github.com/users/eocanha/following{/other_user}","gists_url":"https://api.github.com/users/eocanha/gists{/gist_id}","starred_url":"https://api.github.com/users/eocanha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eocanha/subscriptions","organizations_url":"https://api.github.com/users/eocanha/orgs","repos_url":"https://api.github.com/users/eocanha/repos","events_url":"https://api.github.com/users/eocanha/events{/privacy}","received_events_url":"https://api.github.com/users/eocanha/received_events","type":"User","site_admin":false},"body":"I pushed a fix for this issue in the yttv-2016-45-fixed branch some months ago, but I don't know if it still applies to current master: https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/d049232274ac042613fbb334002300a4f1b809a1\r\n\r\nHowever, it never became integrated in master because we preferred not to touch WebCore code in order to keep the differences with upstream WebKit as small as possible.\r\n\r\nWhen I coded it, I found this comment in the code suggesting that the fudgeFactor value was related to video frame duration. I thought that assumption wouldn't fit well for audio frames.","created_at":"2017-03-14T09:55:38Z","updated_at":"2017-03-14T09:55:38Z","html_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/240#discussion_r105865047","pull_request_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments/105865047"},"html":{"href":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/240#discussion_r105865047"},"pull_request":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240","id":110418116,"html_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/240","diff_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/240.diff","patch_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/240.patch","issue_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/240","number":240,"state":"closed","locked":false,"title":"Fixed fudge factor to be related to min frameDuration","user":{"login":"valbok","id":1194376,"avatar_url":"https://avatars2.githubusercontent.com/u/1194376?v=3","gravatar_id":"","url":"https://api.github.com/users/valbok","html_url":"https://github.com/valbok","followers_url":"https://api.github.com/users/valbok/followers","following_url":"https://api.github.com/users/valbok/following{/other_user}","gists_url":"https://api.github.com/users/valbok/gists{/gist_id}","starred_url":"https://api.github.com/users/valbok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valbok/subscriptions","organizations_url":"https://api.github.com/users/valbok/orgs","repos_url":"https://api.github.com/users/valbok/repos","events_url":"https://api.github.com/users/valbok/events{/privacy}","received_events_url":"https://api.github.com/users/valbok/received_events","type":"User","site_admin":false},"body":"https://bugs.webkit.org/show_bug.cgi?id=159813\r\nIncreased the SourceBuffer \"fudge factor\"\r\nintroduced failing the test:\r\n\r\nhttp://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html?enablewebm=off&timestamp=1484256932414\r\n45. AudioWithLargeGap\r\n","created_at":"2017-03-13T14:39:04Z","updated_at":"2017-03-14T09:55:38Z","closed_at":"2017-03-14T07:13:08Z","merged_at":null,"merge_commit_sha":"62ee616ceaa5968e2d4bad55d4a8af5bb8fb6b10","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240/commits","review_comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240/comments","review_comment_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/240/comments","statuses_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/statuses/dcadd156f334cdad562f8d84d61257a0c38705d2","head":{"label":"valbok:master_gap","ref":"master_gap","sha":"dcadd156f334cdad562f8d84d61257a0c38705d2","user":{"login":"valbok","id":1194376,"avatar_url":"https://avatars2.githubusercontent.com/u/1194376?v=3","gravatar_id":"","url":"https://api.github.com/users/valbok","html_url":"https://github.com/valbok","followers_url":"https://api.github.com/users/valbok/followers","following_url":"https://api.github.com/users/valbok/following{/other_user}","gists_url":"https://api.github.com/users/valbok/gists{/gist_id}","starred_url":"https://api.github.com/users/valbok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valbok/subscriptions","organizations_url":"https://api.github.com/users/valbok/orgs","repos_url":"https://api.github.com/users/valbok/repos","events_url":"https://api.github.com/users/valbok/events{/privacy}","received_events_url":"https://api.github.com/users/valbok/received_events","type":"User","site_admin":false},"repo":{"id":48234086,"name":"WebKitForWayland","full_name":"valbok/WebKitForWayland","owner":{"login":"valbok","id":1194376,"avatar_url":"https://avatars2.githubusercontent.com/u/1194376?v=3","gravatar_id":"","url":"https://api.github.com/users/valbok","html_url":"https://github.com/valbok","followers_url":"https://api.github.com/users/valbok/followers","following_url":"https://api.github.com/users/valbok/following{/other_user}","gists_url":"https://api.github.com/users/valbok/gists{/gist_id}","starred_url":"https://api.github.com/users/valbok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valbok/subscriptions","organizations_url":"https://api.github.com/users/valbok/orgs","repos_url":"https://api.github.com/users/valbok/repos","events_url":"https://api.github.com/users/valbok/events{/privacy}","received_events_url":"https://api.github.com/users/valbok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/valbok/WebKitForWayland","description":"Unofficial mirror of the WebKit SVN repository","fork":true,"url":"https://api.github.com/repos/valbok/WebKitForWayland","forks_url":"https://api.github.com/repos/valbok/WebKitForWayland/forks","keys_url":"https://api.github.com/repos/valbok/WebKitForWayland/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valbok/WebKitForWayland/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valbok/WebKitForWayland/teams","hooks_url":"https://api.github.com/repos/valbok/WebKitForWayland/hooks","issue_events_url":"https://api.github.com/repos/valbok/WebKitForWayland/issues/events{/number}","events_url":"https://api.github.com/repos/valbok/WebKitForWayland/events","assignees_url":"https://api.github.com/repos/valbok/WebKitForWayland/assignees{/user}","branches_url":"https://api.github.com/repos/valbok/WebKitForWayland/branches{/branch}","tags_url":"https://api.github.com/repos/valbok/WebKitForWayland/tags","blobs_url":"https://api.github.com/repos/valbok/WebKitForWayland/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valbok/WebKitForWayland/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valbok/WebKitForWayland/git/refs{/sha}","trees_url":"https://api.github.com/repos/valbok/WebKitForWayland/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valbok/WebKitForWayland/statuses/{sha}","languages_url":"https://api.github.com/repos/valbok/WebKitForWayland/languages","stargazers_url":"https://api.github.com/repos/valbok/WebKitForWayland/stargazers","contributors_url":"https://api.github.com/repos/valbok/WebKitForWayland/contributors","subscribers_url":"https://api.github.com/repos/valbok/WebKitForWayland/subscribers","subscription_url":"https://api.github.com/repos/valbok/WebKitForWayland/subscription","commits_url":"https://api.github.com/repos/valbok/WebKitForWayland/commits{/sha}","git_commits_url":"https://api.github.com/repos/valbok/WebKitForWayland/git/commits{/sha}","comments_url":"https://api.github.com/repos/valbok/WebKitForWayland/comments{/number}","issue_comment_url":"https://api.github.com/repos/valbok/WebKitForWayland/issues/comments{/number}","contents_url":"https://api.github.com/repos/valbok/WebKitForWayland/contents/{+path}","compare_url":"https://api.github.com/repos/valbok/WebKitForWayland/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valbok/WebKitForWayland/merges","archive_url":"https://api.github.com/repos/valbok/WebKitForWayland/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valbok/WebKitForWayland/downloads","issues_url":"https://api.github.com/repos/valbok/WebKitForWayland/issues{/number}","pulls_url":"https://api.github.com/repos/valbok/WebKitForWayland/pulls{/number}","milestones_url":"https://api.github.com/repos/valbok/WebKitForWayland/milestones{/number}","notifications_url":"https://api.github.com/repos/valbok/WebKitForWayland/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valbok/WebKitForWayland/labels{/name}","releases_url":"https://api.github.com/repos/valbok/WebKitForWayland/releases{/id}","deployments_url":"https://api.github.com/repos/valbok/WebKitForWayland/deployments","created_at":"2015-12-18T12:25:33Z","updated_at":"2016-01-11T10:56:10Z","pushed_at":"2017-03-13T14:38:28Z","git_url":"git://github.com/valbok/WebKitForWayland.git","ssh_url":"git@github.com:valbok/WebKitForWayland.git","clone_url":"https://github.com/valbok/WebKitForWayland.git","svn_url":"https://github.com/valbok/WebKitForWayland","homepage":"http://www.webkit.org/","size":7050498,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WebPlatformForEmbedded:master","ref":"master","sha":"e6d2b246e6ace815bb7169d2fcd8b2dbd1c08bc0","user":{"login":"WebPlatformForEmbedded","id":26092996,"avatar_url":"https://avatars2.githubusercontent.com/u/26092996?v=3","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"repo":{"id":28195272,"name":"WPEWebKit","full_name":"WebPlatformForEmbedded/WPEWebKit","owner":{"login":"WebPlatformForEmbedded","id":26092996,"avatar_url":"https://avatars2.githubusercontent.com/u/26092996?v=3","gravatar_id":"","url":"https://api.github.com/users/WebPlatformForEmbedded","html_url":"https://github.com/WebPlatformForEmbedded","followers_url":"https://api.github.com/users/WebPlatformForEmbedded/followers","following_url":"https://api.github.com/users/WebPlatformForEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/WebPlatformForEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/WebPlatformForEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebPlatformForEmbedded/subscriptions","organizations_url":"https://api.github.com/users/WebPlatformForEmbedded/orgs","repos_url":"https://api.github.com/users/WebPlatformForEmbedded/repos","events_url":"https://api.github.com/users/WebPlatformForEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/WebPlatformForEmbedded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit","description":"WPE WebKit port (downstream)","fork":true,"url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit","forks_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/forks","keys_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/teams","hooks_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/hooks","issue_events_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/events{/number}","events_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/events","assignees_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/assignees{/user}","branches_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/branches{/branch}","tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/tags","blobs_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/statuses/{sha}","languages_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/languages","stargazers_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/stargazers","contributors_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/contributors","subscribers_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/subscribers","subscription_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/subscription","commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/contents/{+path}","compare_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/merges","archive_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/downloads","issues_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues{/number}","pulls_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls{/number}","milestones_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/milestones{/number}","notifications_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/labels{/name}","releases_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/releases{/id}","deployments_url":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/deployments","created_at":"2014-12-18T18:08:02Z","updated_at":"2017-03-08T14:30:41Z","pushed_at":"2017-03-14T09:30:17Z","git_url":"git://github.com/WebPlatformForEmbedded/WPEWebKit.git","ssh_url":"git@github.com:WebPlatformForEmbedded/WPEWebKit.git","clone_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit.git","svn_url":"https://github.com/WebPlatformForEmbedded/WPEWebKit","homepage":"","size":7181177,"stargazers_count":27,"watchers_count":27,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":31,"forks":27,"open_issues":31,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240"},"html":{"href":"https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/240"},"issue":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/240"},"comments":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/WebPlatformForEmbedded/WPEWebKit/statuses/dcadd156f334cdad562f8d84d61257a0c38705d2"}}}}
{"actor":{"display_login":"eocanha"}}