{"action":"created","issue":{"url":"https://api.github.com/repos/HackerExperience/HEBorn/issues/335","repository_url":"https://api.github.com/repos/HackerExperience/HEBorn","labels_url":"https://api.github.com/repos/HackerExperience/HEBorn/issues/335/labels{/name}","comments_url":"https://api.github.com/repos/HackerExperience/HEBorn/issues/335/comments","events_url":"https://api.github.com/repos/HackerExperience/HEBorn/issues/335/events","html_url":"https://github.com/HackerExperience/HEBorn/pull/335","id":278342547,"number":335,"title":"Hardware reimplementation","user":{"login":"kress95","id":2013206,"avatar_url":"https://avatars3.githubusercontent.com/u/2013206?v=4","gravatar_id":"","url":"https://api.github.com/users/kress95","html_url":"https://github.com/kress95","followers_url":"https://api.github.com/users/kress95/followers","following_url":"https://api.github.com/users/kress95/following{/other_user}","gists_url":"https://api.github.com/users/kress95/gists{/gist_id}","starred_url":"https://api.github.com/users/kress95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kress95/subscriptions","organizations_url":"https://api.github.com/users/kress95/orgs","repos_url":"https://api.github.com/users/kress95/repos","events_url":"https://api.github.com/users/kress95/events{/privacy}","received_events_url":"https://api.github.com/users/kress95/received_events","type":"User","site_admin":false},"labels":[{"id":571300703,"url":"https://api.github.com/repos/HackerExperience/HEBorn/labels/Kind:Enhancement","name":"Kind:Enhancement","color":"128A0C","default":false},{"id":571300705,"url":"https://api.github.com/repos/HackerExperience/HEBorn/labels/Priority:High","name":"Priority:High","color":"e99695","default":false},{"id":717202670,"url":"https://api.github.com/repos/HackerExperience/HEBorn/labels/Work%20In%20Progress","name":"Work In Progress","color":"444444","default":false}],"state":"open","locked":false,"assignee":{"login":"kress95","id":2013206,"avatar_url":"https://avatars3.githubusercontent.com/u/2013206?v=4","gravatar_id":"","url":"https://api.github.com/users/kress95","html_url":"https://github.com/kress95","followers_url":"https://api.github.com/users/kress95/followers","following_url":"https://api.github.com/users/kress95/following{/other_user}","gists_url":"https://api.github.com/users/kress95/gists{/gist_id}","starred_url":"https://api.github.com/users/kress95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kress95/subscriptions","organizations_url":"https://api.github.com/users/kress95/orgs","repos_url":"https://api.github.com/users/kress95/repos","events_url":"https://api.github.com/users/kress95/events{/privacy}","received_events_url":"https://api.github.com/users/kress95/received_events","type":"User","site_admin":false},"assignees":[{"login":"kress95","id":2013206,"avatar_url":"https://avatars3.githubusercontent.com/u/2013206?v=4","gravatar_id":"","url":"https://api.github.com/users/kress95","html_url":"https://github.com/kress95","followers_url":"https://api.github.com/users/kress95/followers","following_url":"https://api.github.com/users/kress95/following{/other_user}","gists_url":"https://api.github.com/users/kress95/gists{/gist_id}","starred_url":"https://api.github.com/users/kress95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kress95/subscriptions","organizations_url":"https://api.github.com/users/kress95/orgs","repos_url":"https://api.github.com/users/kress95/repos","events_url":"https://api.github.com/users/kress95/events{/privacy}","received_events_url":"https://api.github.com/users/kress95/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-12-01T02:59:45Z","updated_at":"2017-12-14T01:29:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/HackerExperience/HEBorn/pulls/335","html_url":"https://github.com/HackerExperience/HEBorn/pull/335","diff_url":"https://github.com/HackerExperience/HEBorn/pull/335.diff","patch_url":"https://github.com/HackerExperience/HEBorn/pull/335.patch"},"body":"### TODO\r\n\r\n- [x] Properly react to motherboard attach/dettach.\r\n- [x] Properly react to component link/unlink at hardware.\r\n- [x] Properly react to component link/unlink at inventory.\r\n- [x] Spec decoders.\r\n- [ ] Store the specs somehow\r\n- [x] Finish Server Gears view.\r\n- [x] Motherboard setup / update requests\r\n- [x] Remove link/unlink and dispatch from hardware to inventory.\r\n- [x] Tests\r\n\r\nWow 2215 lines PR Õ_Õ\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/hackerexperience/heborn/335)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/HackerExperience/HEBorn/issues/comments/351580141","html_url":"https://github.com/HackerExperience/HEBorn/pull/335#issuecomment-351580141","issue_url":"https://api.github.com/repos/HackerExperience/HEBorn/issues/335","id":351580141,"user":{"login":"kress95","id":2013206,"avatar_url":"https://avatars3.githubusercontent.com/u/2013206?v=4","gravatar_id":"","url":"https://api.github.com/users/kress95","html_url":"https://github.com/kress95","followers_url":"https://api.github.com/users/kress95/followers","following_url":"https://api.github.com/users/kress95/following{/other_user}","gists_url":"https://api.github.com/users/kress95/gists{/gist_id}","starred_url":"https://api.github.com/users/kress95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kress95/subscriptions","organizations_url":"https://api.github.com/users/kress95/orgs","repos_url":"https://api.github.com/users/kress95/repos","events_url":"https://api.github.com/users/kress95/events{/privacy}","received_events_url":"https://api.github.com/users/kress95/received_events","type":"User","site_admin":false},"created_at":"2017-12-14T01:29:20Z","updated_at":"2017-12-14T01:29:20Z","author_association":"MEMBER","body":"\n\n\n\nReview status: all files reviewed at latest revision, 9 unresolved discussions, some commit checks broke.\n\n---\n\n*[src/Apps/ServersGears/Models.elm, line 31 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0Hm9-PB-g47atUYemr:-L0HZrzkkw_kyDJELL_q:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Apps/ServersGears/Models.elm#L31)):*\n> ```Elm\n> \n> type Selection\n>     = SelectingSlot Motherboard.Id\n> ```\n\nDone.\n\n---\n\n*[src/Decoders/Hardware.elm, line 7 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0HqnSF9lXHxFqBI_30:-L0H_k_jviXs73FxL0AF:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Decoders/Hardware.elm#L7)):*\n> ```Elm\n>     exposing\n>         ( Decoder\n>         , succeed\n> ```\n\nDone.\n\n---\n\n*[src/Decoders/Hardware.elm, line 8 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0HqoQkENmxYRgDXBok:-L0H_lu4HjXzTPvuUTBZ:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Decoders/Hardware.elm#L8)):*\n> ```Elm\n>         ( Decoder\n>         , succeed\n>         , fail\n> ```\n\nDone.\n\n---\n\n*[src/Decoders/Hardware.elm, line 9 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0HqhnBrCbSeDCdW5YM:-L0H_mcUlpT9qtlGeSM7:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Decoders/Hardware.elm#L9)):*\n> ```Elm\n>         , succeed\n>         , fail\n>         , bool\n> ```\n\nDone.\n\n---\n\n*[src/Decoders/Hardware.elm, line 10 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0HqaCe657VTjXGnWRc:-L0H_omDJ4BZs8uuzszn:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Decoders/Hardware.elm#L10)):*\n> ```Elm\n>         , fail\n>         , bool\n>         , float\n> ```\n\nDone.\n\n---\n\n*[src/Decoders/Hardware.elm, line 13 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0HqxC4Uto2lF4-DLID:-L0H_pRw65CgUcXrBHph:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Decoders/Hardware.elm#L13)):*\n> ```Elm\n>         , string\n>         , dict\n>         , field\n> ```\n\nDone.\n\n---\n\n*[src/Decoders/Hardware.elm, line 16 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0Hr1jKz4M3N45uJyva:-L0H_qCdQ2izUk9KNJD9:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Decoders/Hardware.elm#L16)):*\n> ```Elm\n>         , maybe\n>         , map\n>         , andThen\n> ```\n\nDone.\n\n---\n\n*[src/Game/Meta/Types/Network/Connections.elm, line 12 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0Hty2eQ8yLMKZ37W_G:-L0H_8QodXoAUA9kWp81:b-896fix) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Game/Meta/Types/Network/Connections.elm#L12)):*\n<details><summary><i>Previously, kress95 (Christian Ferraz Lemos de Sousa) wrote…</i></summary><blockquote>\n\nMy bad, it should really be Id :joy:\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/Game/Servers/Hardware/Requests/UpdateMotherboard.elm, line 5 at r3](https://reviewable.io:443/reviews/hackerexperience/heborn/335#-L0Huj1IfG5YTxOcJc7F:-L0H_LRAShXn04T3kVmY:b7wi2wj) ([raw file](https://github.com/hackerexperience/heborn/blob/79c5a78752d06350b94caddcd7ecf83368548ca3/src/Game/Servers/Hardware/Requests/UpdateMotherboard.elm#L5)):*\n<details><summary><i>Previously, kress95 (Christian Ferraz Lemos de Sousa) wrote…</i></summary><blockquote>\n\nhow can a module declaration be unsused?\n</blockquote></details>\n\nDone. Found other things to remove here.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/hackerexperience/heborn/335)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"kress95"}}