{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/comments/126045243","pull_request_review_id":48494707,"id":126045243,"diff_hunk":"@@ -2,13 +2,13 @@\n <Project ToolsVersion=\"14.0\" DefaultTargets=\"Build\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n   <PropertyGroup>\n     <PackageConfigurations>\n+      uap-Windows_NT;\n       netstandard-Windows_NT;\n       netstandard-Unix;\n     </PackageConfigurations>\n     <BuildConfigurations>\n       $(PackageConfigurations);\n       netstandard;\n-      uap-Windows_NT;","path":"src/System.Private.ServiceModel/src/Configurations.props","position":11,"original_position":11,"commit_id":"f3862c7690b0bca659512dc215f70da078fadbd8","original_commit_id":"f3862c7690b0bca659512dc215f70da078fadbd8","user":{"login":"shmao","id":12262109,"avatar_url":"https://avatars2.githubusercontent.com/u/12262109?v=3","gravatar_id":"","url":"https://api.github.com/users/shmao","html_url":"https://github.com/shmao","followers_url":"https://api.github.com/users/shmao/followers","following_url":"https://api.github.com/users/shmao/following{/other_user}","gists_url":"https://api.github.com/users/shmao/gists{/gist_id}","starred_url":"https://api.github.com/users/shmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmao/subscriptions","organizations_url":"https://api.github.com/users/shmao/orgs","repos_url":"https://api.github.com/users/shmao/repos","events_url":"https://api.github.com/users/shmao/events{/privacy}","received_events_url":"https://api.github.com/users/shmao/received_events","type":"User","site_admin":false},"body":"Just question: why don't we need `uap` in BuildConfigurations?","created_at":"2017-07-07T00:04:56Z","updated_at":"2017-07-07T00:04:56Z","html_url":"https://github.com/dotnet/wcf/pull/2044#discussion_r126045243","pull_request_url":"https://api.github.com/repos/dotnet/wcf/pulls/2044","_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments/126045243"},"html":{"href":"https://github.com/dotnet/wcf/pull/2044#discussion_r126045243"},"pull_request":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/2044"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/2044","id":129305354,"html_url":"https://github.com/dotnet/wcf/pull/2044","diff_url":"https://github.com/dotnet/wcf/pull/2044.diff","patch_url":"https://github.com/dotnet/wcf/pull/2044.patch","issue_url":"https://api.github.com/repos/dotnet/wcf/issues/2044","number":2044,"state":"open","locked":false,"title":"Fixing System.Private.ServiceModel package for uap consumption with the right asset","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars0.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"cc: @dagood @StephenBonikowsky @zhenlan \r\n\r\nOk so this addresses several issues for the System.Private.ServiceModel package:\r\n\r\n- References for uap10.0.15138 TFM were wrong, includding things it shouldn't\r\n- We used to have an asset for unix/uap10.0.15138, which should never be the  case, so I removed it.\r\n- We were basically copying the asset from netstandard2.0 into uap, which is wrong, as uap has it's own implementation\r\n\r\nWith these fixes in, I believe we now should be good to go to consume WCF from core-setup and produce the UWP metapackage.\r\n","created_at":"2017-07-07T00:00:33Z","updated_at":"2017-07-07T00:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa27e3793d3be1b90c4d882b7853e324e3d750b6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/wcf/pulls/2044/commits","review_comments_url":"https://api.github.com/repos/dotnet/wcf/pulls/2044/comments","review_comment_url":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/wcf/issues/2044/comments","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/f3862c7690b0bca659512dc215f70da078fadbd8","head":{"label":"joperezr:uapPackage","ref":"uapPackage","sha":"f3862c7690b0bca659512dc215f70da078fadbd8","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars0.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"repo":{"id":56888830,"name":"wcf","full_name":"joperezr/wcf","owner":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars0.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joperezr/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":true,"url":"https://api.github.com/repos/joperezr/wcf","forks_url":"https://api.github.com/repos/joperezr/wcf/forks","keys_url":"https://api.github.com/repos/joperezr/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joperezr/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joperezr/wcf/teams","hooks_url":"https://api.github.com/repos/joperezr/wcf/hooks","issue_events_url":"https://api.github.com/repos/joperezr/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/joperezr/wcf/events","assignees_url":"https://api.github.com/repos/joperezr/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/joperezr/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/joperezr/wcf/tags","blobs_url":"https://api.github.com/repos/joperezr/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joperezr/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joperezr/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/joperezr/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joperezr/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/joperezr/wcf/languages","stargazers_url":"https://api.github.com/repos/joperezr/wcf/stargazers","contributors_url":"https://api.github.com/repos/joperezr/wcf/contributors","subscribers_url":"https://api.github.com/repos/joperezr/wcf/subscribers","subscription_url":"https://api.github.com/repos/joperezr/wcf/subscription","commits_url":"https://api.github.com/repos/joperezr/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/joperezr/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/joperezr/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/joperezr/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/joperezr/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/joperezr/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joperezr/wcf/merges","archive_url":"https://api.github.com/repos/joperezr/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joperezr/wcf/downloads","issues_url":"https://api.github.com/repos/joperezr/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/joperezr/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/joperezr/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/joperezr/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joperezr/wcf/labels{/name}","releases_url":"https://api.github.com/repos/joperezr/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/joperezr/wcf/deployments","created_at":"2016-04-22T22:31:04Z","updated_at":"2016-04-22T22:31:07Z","pushed_at":"2017-07-06T23:57:39Z","git_url":"git://github.com/joperezr/wcf.git","ssh_url":"git@github.com:joperezr/wcf.git","clone_url":"https://github.com/joperezr/wcf.git","svn_url":"https://github.com/joperezr/wcf","homepage":"","size":7649,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"086f62ec58194b06f7884102488bf21e796d41ef","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35562993,"name":"wcf","full_name":"dotnet/wcf","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":false,"url":"https://api.github.com/repos/dotnet/wcf","forks_url":"https://api.github.com/repos/dotnet/wcf/forks","keys_url":"https://api.github.com/repos/dotnet/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/wcf/teams","hooks_url":"https://api.github.com/repos/dotnet/wcf/hooks","issue_events_url":"https://api.github.com/repos/dotnet/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/wcf/events","assignees_url":"https://api.github.com/repos/dotnet/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/wcf/tags","blobs_url":"https://api.github.com/repos/dotnet/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/wcf/languages","stargazers_url":"https://api.github.com/repos/dotnet/wcf/stargazers","contributors_url":"https://api.github.com/repos/dotnet/wcf/contributors","subscribers_url":"https://api.github.com/repos/dotnet/wcf/subscribers","subscription_url":"https://api.github.com/repos/dotnet/wcf/subscription","commits_url":"https://api.github.com/repos/dotnet/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/wcf/merges","archive_url":"https://api.github.com/repos/dotnet/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/wcf/downloads","issues_url":"https://api.github.com/repos/dotnet/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/wcf/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/wcf/deployments","created_at":"2015-05-13T17:17:03Z","updated_at":"2017-07-05T11:09:59Z","pushed_at":"2017-07-07T00:04:36Z","git_url":"git://github.com/dotnet/wcf.git","ssh_url":"git@github.com:dotnet/wcf.git","clone_url":"https://github.com/dotnet/wcf.git","svn_url":"https://github.com/dotnet/wcf","homepage":"","size":8070,"stargazers_count":825,"watchers_count":825,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"open_issues_count":151,"forks":287,"open_issues":151,"watchers":825,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/2044"},"html":{"href":"https://github.com/dotnet/wcf/pull/2044"},"issue":{"href":"https://api.github.com/repos/dotnet/wcf/issues/2044"},"comments":{"href":"https://api.github.com/repos/dotnet/wcf/issues/2044/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/2044/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/2044/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/wcf/statuses/f3862c7690b0bca659512dc215f70da078fadbd8"}}}}
{"actor":{"display_login":"shmao"}}