{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/comments/149749799","pull_request_review_id":75193762,"id":149749799,"diff_hunk":"@@ -132,18 +134,25 @@ public function getDefaultOptions()\n      */\n     public function getRenderSettings()\n     {\n-        $name = 'sonata_type_filter_date';\n+        $types = [\n+            'sonata_type_filter_date' => DateType::class,\n+            'sonata_type_filter_datetime' => DateTimeType::class,\n+            'sonata_type_filter_date_range' => DateRangeType::class,\n+            'sonata_type_filter_datetime_range' => DateTimeRangeType::class,\n+        ];\n+\n+        $type = 'sonata_type_filter_date';","path":"Filter/AbstractDateFilter.php","position":21,"original_position":21,"commit_id":"f0d37607eb45e15af6bafa918c7a1f38ecf2d8d5","original_commit_id":"f0d37607eb45e15af6bafa918c7a1f38ecf2d8d5","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"🤔 the `sonata_type_filter` is useless now, and a bit confusing","created_at":"2017-11-08T18:05:39Z","updated_at":"2017-11-08T18:05:39Z","html_url":"https://github.com/sonata-project/SonataAdminSearchBundle/pull/95#discussion_r149749799","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/comments/149749799"},"html":{"href":"https://github.com/sonata-project/SonataAdminSearchBundle/pull/95#discussion_r149749799"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95","id":151446413,"html_url":"https://github.com/sonata-project/SonataAdminSearchBundle/pull/95","diff_url":"https://github.com/sonata-project/SonataAdminSearchBundle/pull/95.diff","patch_url":"https://github.com/sonata-project/SonataAdminSearchBundle/pull/95.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/issues/95","number":95,"state":"open","locked":false,"title":"remove deprecated strings for form types","user":{"login":"codebach","id":10575905,"avatar_url":"https://avatars1.githubusercontent.com/u/10575905?v=4","gravatar_id":"","url":"https://api.github.com/users/codebach","html_url":"https://github.com/codebach","followers_url":"https://api.github.com/users/codebach/followers","following_url":"https://api.github.com/users/codebach/following{/other_user}","gists_url":"https://api.github.com/users/codebach/gists{/gist_id}","starred_url":"https://api.github.com/users/codebach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebach/subscriptions","organizations_url":"https://api.github.com/users/codebach/orgs","repos_url":"https://api.github.com/users/codebach/repos","events_url":"https://api.github.com/users/codebach/events{/privacy}","received_events_url":"https://api.github.com/users/codebach/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 1.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataAdminSearchBundle/blob/1.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targeting this branch, because of the Symfony form deprecations.\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\nCloses #94\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Fixed\r\n- Deprecated strings type class names usage.\r\n```\r\n","created_at":"2017-11-08T17:29:17Z","updated_at":"2017-11-08T18:05:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d73872f644244af6022ceb7ca393bc66db06b344","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/issues/95/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/statuses/f0d37607eb45e15af6bafa918c7a1f38ecf2d8d5","head":{"label":"codebach:update-deprecated-form-types","ref":"update-deprecated-form-types","sha":"f0d37607eb45e15af6bafa918c7a1f38ecf2d8d5","user":{"login":"codebach","id":10575905,"avatar_url":"https://avatars1.githubusercontent.com/u/10575905?v=4","gravatar_id":"","url":"https://api.github.com/users/codebach","html_url":"https://github.com/codebach","followers_url":"https://api.github.com/users/codebach/followers","following_url":"https://api.github.com/users/codebach/following{/other_user}","gists_url":"https://api.github.com/users/codebach/gists{/gist_id}","starred_url":"https://api.github.com/users/codebach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebach/subscriptions","organizations_url":"https://api.github.com/users/codebach/orgs","repos_url":"https://api.github.com/users/codebach/repos","events_url":"https://api.github.com/users/codebach/events{/privacy}","received_events_url":"https://api.github.com/users/codebach/received_events","type":"User","site_admin":false},"repo":{"id":110001449,"name":"SonataAdminSearchBundle","full_name":"codebach/SonataAdminSearchBundle","owner":{"login":"codebach","id":10575905,"avatar_url":"https://avatars1.githubusercontent.com/u/10575905?v=4","gravatar_id":"","url":"https://api.github.com/users/codebach","html_url":"https://github.com/codebach","followers_url":"https://api.github.com/users/codebach/followers","following_url":"https://api.github.com/users/codebach/following{/other_user}","gists_url":"https://api.github.com/users/codebach/gists{/gist_id}","starred_url":"https://api.github.com/users/codebach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebach/subscriptions","organizations_url":"https://api.github.com/users/codebach/orgs","repos_url":"https://api.github.com/users/codebach/repos","events_url":"https://api.github.com/users/codebach/events{/privacy}","received_events_url":"https://api.github.com/users/codebach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codebach/SonataAdminSearchBundle","description":"POC - Implement Search Engine (ElasticSearch) inside Sonata Admin","fork":true,"url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle","forks_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/forks","keys_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/teams","hooks_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/hooks","issue_events_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/issues/events{/number}","events_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/events","assignees_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/assignees{/user}","branches_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/branches{/branch}","tags_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/tags","blobs_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/languages","stargazers_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/stargazers","contributors_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/contributors","subscribers_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/subscribers","subscription_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/subscription","commits_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/contents/{+path}","compare_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/merges","archive_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/downloads","issues_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/issues{/number}","pulls_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/labels{/name}","releases_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/releases{/id}","deployments_url":"https://api.github.com/repos/codebach/SonataAdminSearchBundle/deployments","created_at":"2017-11-08T16:31:01Z","updated_at":"2017-11-08T16:31:03Z","pushed_at":"2017-11-08T17:26:00Z","git_url":"git://github.com/codebach/SonataAdminSearchBundle.git","ssh_url":"git@github.com:codebach/SonataAdminSearchBundle.git","clone_url":"https://github.com/codebach/SonataAdminSearchBundle.git","svn_url":"https://github.com/codebach/SonataAdminSearchBundle","homepage":"https://sonata-project.org/","size":200,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x"}},"base":{"label":"sonata-project:1.x","ref":"1.x","sha":"2dec7d60bf58539bb2b3b5f6e75632874cb7bfa6","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":27479344,"name":"SonataAdminSearchBundle","full_name":"sonata-project/SonataAdminSearchBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminSearchBundle","description":"POC - Implement Search Engine (ElasticSearch) inside Sonata Admin","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/deployments","created_at":"2014-12-03T09:26:15Z","updated_at":"2017-10-25T09:50:26Z","pushed_at":"2017-11-08T17:29:17Z","git_url":"git://github.com/sonata-project/SonataAdminSearchBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminSearchBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminSearchBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminSearchBundle","homepage":"https://sonata-project.org/","size":200,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":14,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95"},"html":{"href":"https://github.com/sonata-project/SonataAdminSearchBundle/pull/95"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/issues/95"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminSearchBundle/statuses/f0d37607eb45e15af6bafa918c7a1f38ecf2d8d5"}},"author_association":"NONE"}}
{"actor":{"display_login":"greg0ire"}}