{"action":"created","issue":{"url":"https://api.github.com/repos/randombit/botan/issues/1239","repository_url":"https://api.github.com/repos/randombit/botan","labels_url":"https://api.github.com/repos/randombit/botan/issues/1239/labels{/name}","comments_url":"https://api.github.com/repos/randombit/botan/issues/1239/comments","events_url":"https://api.github.com/repos/randombit/botan/issues/1239/events","html_url":"https://github.com/randombit/botan/pull/1239","id":263635983,"number":1239,"title":"ed25519 signing and verification using a Curve25519 key-pair","user":{"login":"rafalsk","id":9338163,"avatar_url":"https://avatars0.githubusercontent.com/u/9338163?v=4","gravatar_id":"","url":"https://api.github.com/users/rafalsk","html_url":"https://github.com/rafalsk","followers_url":"https://api.github.com/users/rafalsk/followers","following_url":"https://api.github.com/users/rafalsk/following{/other_user}","gists_url":"https://api.github.com/users/rafalsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalsk/subscriptions","organizations_url":"https://api.github.com/users/rafalsk/orgs","repos_url":"https://api.github.com/users/rafalsk/repos","events_url":"https://api.github.com/users/rafalsk/events{/privacy}","received_events_url":"https://api.github.com/users/rafalsk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-07T11:43:11Z","updated_at":"2017-10-08T01:50:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/randombit/botan/pulls/1239","html_url":"https://github.com/randombit/botan/pull/1239","diff_url":"https://github.com/randombit/botan/pull/1239.diff","patch_url":"https://github.com/randombit/botan/pull/1239.patch"},"body":"Implemented functionallity which allows to perform ed25519 signing and verification using a Curve25519 key-pair.\r\n\r\nUsage:\r\n`\t\r\n       //sign\r\n        Botan::PK_Signer signer(prevPrivKey25519, rng, \"Pure\");\r\n\tsigner.update(msgv);\r\n\tstd::vector<uint8_t> signature2 = signer.signature(rng);\r\n\r\n\t//verify\r\n\tBotan::PK_Verifier verifier(pubKey25519, \"Pure\");\r\n\tverifier.update(msgv);\r\n\tbool valid = verifier.check_signature(signature2);`"},"comment":{"url":"https://api.github.com/repos/randombit/botan/issues/comments/334977233","html_url":"https://github.com/randombit/botan/pull/1239#issuecomment-334977233","issue_url":"https://api.github.com/repos/randombit/botan/issues/1239","id":334977233,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-10-08T01:50:48Z","updated_at":"2017-10-08T01:50:48Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=h1) Report\n> Merging [#1239](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=desc) into [master](https://codecov.io/gh/randombit/botan/commit/95185297aa91edf34c68fd56f7f095df16a7197f?src=pr&el=desc) will **increase** coverage by `0.17%`.\n> The diff coverage is `32.51%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/randombit/botan/pull/1239/graphs/tree.svg?height=150&width=650&token=VR6iYmSPH8&src=pr)](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1239      +/-   ##\n==========================================\n+ Coverage   91.79%   91.97%   +0.17%     \n==========================================\n  Files         752      752              \n  Lines       45021    45131     +110     \n  Branches     5204     5217      +13     \n==========================================\n+ Hits        41329    41510     +181     \n+ Misses       3658     3587      -71     \n  Partials       34       34\n```\n\n\n| [Impacted Files](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/lib/pubkey/curve25519/curve25519.h](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi9wdWJrZXkvY3VydmUyNTUxOS9jdXJ2ZTI1NTE5Lmg=) | `100% <ø> (ø)` | :arrow_up: |\n| [src/lib/pubkey/curve25519/curve25519.cpp](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi9wdWJrZXkvY3VydmUyNTUxOS9jdXJ2ZTI1NTE5LmNwcA==) | `31.67% <0%> (-54.77%)` | :arrow_down: |\n| [src/lib/pubkey/ed25519/ed25519\\_fe.h](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi9wdWJrZXkvZWQyNTUxOS9lZDI1NTE5X2ZlLmg=) | `88.37% <0%> (-9.07%)` | :arrow_down: |\n| [src/lib/pubkey/ed25519/ed25519\\_internal.h](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi9wdWJrZXkvZWQyNTUxOS9lZDI1NTE5X2ludGVybmFsLmg=) | `100% <100%> (ø)` | :arrow_up: |\n| [src/lib/pubkey/ed25519/ge.cpp](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi9wdWJrZXkvZWQyNTUxOS9nZS5jcHA=) | `99.69% <100%> (-0.01%)` | :arrow_down: |\n| [src/lib/tls/msg\\_certificate.cpp](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi90bHMvbXNnX2NlcnRpZmljYXRlLmNwcA==) | `97.05% <0%> (-2.95%)` | :arrow_down: |\n| [src/tests/unit\\_tls.cpp](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL3Rlc3RzL3VuaXRfdGxzLmNwcA==) | `90.88% <0%> (-0.64%)` | :arrow_down: |\n| [src/lib/tls/tls\\_handshake\\_state.cpp](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi90bHMvdGxzX2hhbmRzaGFrZV9zdGF0ZS5jcHA=) | `83.18% <0%> (-0.46%)` | :arrow_down: |\n| [src/lib/tls/tls\\_channel.cpp](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi90bHMvdGxzX2NoYW5uZWwuY3Bw) | `79.1% <0%> (-0.35%)` | :arrow_down: |\n| [src/lib/tls/tls\\_client.cpp](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree#diff-c3JjL2xpYi90bHMvdGxzX2NsaWVudC5jcHA=) | `85.4% <0%> (ø)` | :arrow_up: |\n| ... and [12 more](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=footer). Last update [9518529...b40de80](https://codecov.io/gh/randombit/botan/pull/1239?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}