{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/144200268","pull_request_review_id":68823024,"id":144200268,"diff_hunk":"@@ -188,6 +188,7 @@ def __init__(self, con):\n         cur = Cursor(con)\n         with self.assertRaises(sqlite.ProgrammingError):\n             cur.execute(\"select 4+5\").fetchall()\n+        self.assertRaises(sqlite.ProgrammingError, cur.close)","path":"Lib/sqlite3/test/regression.py","position":4,"original_position":4,"commit_id":"c07d198b2c2144265822b5e3bbd0b0bcc8aece49","original_commit_id":"c07d198b2c2144265822b5e3bbd0b0bcc8aece49","user":{"login":"orenmn","id":10146804,"avatar_url":"https://avatars1.githubusercontent.com/u/10146804?v=4","gravatar_id":"","url":"https://api.github.com/users/orenmn","html_url":"https://github.com/orenmn","followers_url":"https://api.github.com/users/orenmn/followers","following_url":"https://api.github.com/users/orenmn/following{/other_user}","gists_url":"https://api.github.com/users/orenmn/gists{/gist_id}","starred_url":"https://api.github.com/users/orenmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenmn/subscriptions","organizations_url":"https://api.github.com/users/orenmn/orgs","repos_url":"https://api.github.com/users/orenmn/repos","events_url":"https://api.github.com/users/orenmn/events{/privacy}","received_events_url":"https://api.github.com/users/orenmn/received_events","type":"User","site_admin":false},"body":"All right. Should i also change the `assertRaises()` that was already in `CheckCursorConstructorCallCheck()`?","created_at":"2017-10-12T06:01:54Z","updated_at":"2017-10-12T06:01:54Z","html_url":"https://github.com/python/cpython/pull/3958#discussion_r144200268","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/3958","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/144200268"},"html":{"href":"https://github.com/python/cpython/pull/3958#discussion_r144200268"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/3958"}},"in_reply_to_id":144199047},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/3958","id":146043253,"html_url":"https://github.com/python/cpython/pull/3958","diff_url":"https://github.com/python/cpython/pull/3958.diff","patch_url":"https://github.com/python/cpython/pull/3958.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/3958","number":3958,"state":"open","locked":false,"title":"bpo-31764: Prevent a crash in sqlite3.Cursor.close() in case the Cursor object is uninitialized","user":{"login":"orenmn","id":10146804,"avatar_url":"https://avatars1.githubusercontent.com/u/10146804?v=4","gravatar_id":"","url":"https://api.github.com/users/orenmn","html_url":"https://github.com/orenmn","followers_url":"https://api.github.com/users/orenmn/followers","following_url":"https://api.github.com/users/orenmn/following{/other_user}","gists_url":"https://api.github.com/users/orenmn/gists{/gist_id}","starred_url":"https://api.github.com/users/orenmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenmn/subscriptions","organizations_url":"https://api.github.com/users/orenmn/orgs","repos_url":"https://api.github.com/users/orenmn/repos","events_url":"https://api.github.com/users/orenmn/events{/privacy}","received_events_url":"https://api.github.com/users/orenmn/received_events","type":"User","site_admin":false},"body":"In addition, add a test to `test_sqlite` to make sure that the crash is no more.\n\n<!-- issue-number: bpo-31764 -->\nhttps://bugs.python.org/issue31764\n<!-- /issue-number -->\n","created_at":"2017-10-11T19:41:53Z","updated_at":"2017-10-12T06:01:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7b26de3ce6d29eb6ca8844c7580cbe0b5d3bb35","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/3958/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/3958/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/3958/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/c07d198b2c2144265822b5e3bbd0b0bcc8aece49","head":{"label":"orenmn:bpo31764-fix-crash","ref":"bpo31764-fix-crash","sha":"c07d198b2c2144265822b5e3bbd0b0bcc8aece49","user":{"login":"orenmn","id":10146804,"avatar_url":"https://avatars1.githubusercontent.com/u/10146804?v=4","gravatar_id":"","url":"https://api.github.com/users/orenmn","html_url":"https://github.com/orenmn","followers_url":"https://api.github.com/users/orenmn/followers","following_url":"https://api.github.com/users/orenmn/following{/other_user}","gists_url":"https://api.github.com/users/orenmn/gists{/gist_id}","starred_url":"https://api.github.com/users/orenmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenmn/subscriptions","organizations_url":"https://api.github.com/users/orenmn/orgs","repos_url":"https://api.github.com/users/orenmn/repos","events_url":"https://api.github.com/users/orenmn/events{/privacy}","received_events_url":"https://api.github.com/users/orenmn/received_events","type":"User","site_admin":false},"repo":{"id":83612280,"name":"cpython","full_name":"orenmn/cpython","owner":{"login":"orenmn","id":10146804,"avatar_url":"https://avatars1.githubusercontent.com/u/10146804?v=4","gravatar_id":"","url":"https://api.github.com/users/orenmn","html_url":"https://github.com/orenmn","followers_url":"https://api.github.com/users/orenmn/followers","following_url":"https://api.github.com/users/orenmn/following{/other_user}","gists_url":"https://api.github.com/users/orenmn/gists{/gist_id}","starred_url":"https://api.github.com/users/orenmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenmn/subscriptions","organizations_url":"https://api.github.com/users/orenmn/orgs","repos_url":"https://api.github.com/users/orenmn/repos","events_url":"https://api.github.com/users/orenmn/events{/privacy}","received_events_url":"https://api.github.com/users/orenmn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orenmn/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/orenmn/cpython","forks_url":"https://api.github.com/repos/orenmn/cpython/forks","keys_url":"https://api.github.com/repos/orenmn/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orenmn/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orenmn/cpython/teams","hooks_url":"https://api.github.com/repos/orenmn/cpython/hooks","issue_events_url":"https://api.github.com/repos/orenmn/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/orenmn/cpython/events","assignees_url":"https://api.github.com/repos/orenmn/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/orenmn/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/orenmn/cpython/tags","blobs_url":"https://api.github.com/repos/orenmn/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orenmn/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orenmn/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/orenmn/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orenmn/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/orenmn/cpython/languages","stargazers_url":"https://api.github.com/repos/orenmn/cpython/stargazers","contributors_url":"https://api.github.com/repos/orenmn/cpython/contributors","subscribers_url":"https://api.github.com/repos/orenmn/cpython/subscribers","subscription_url":"https://api.github.com/repos/orenmn/cpython/subscription","commits_url":"https://api.github.com/repos/orenmn/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/orenmn/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/orenmn/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/orenmn/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/orenmn/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/orenmn/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orenmn/cpython/merges","archive_url":"https://api.github.com/repos/orenmn/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orenmn/cpython/downloads","issues_url":"https://api.github.com/repos/orenmn/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/orenmn/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/orenmn/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/orenmn/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orenmn/cpython/labels{/name}","releases_url":"https://api.github.com/repos/orenmn/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/orenmn/cpython/deployments","created_at":"2017-03-01T23:30:51Z","updated_at":"2017-03-01T23:39:08Z","pushed_at":"2017-10-11T19:29:45Z","git_url":"git://github.com/orenmn/cpython.git","ssh_url":"git@github.com:orenmn/cpython.git","clone_url":"https://github.com/orenmn/cpython.git","svn_url":"https://github.com/orenmn/cpython","homepage":"https://www.python.org/","size":214680,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"277c84067ff5dfa271725ee9da1a9d75a7c0bcd8","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2017-10-12T05:04:49Z","pushed_at":"2017-10-12T05:58:57Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":217921,"stargazers_count":13519,"watchers_count":13519,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2823,"mirror_url":null,"open_issues_count":466,"forks":2823,"open_issues":466,"watchers":13519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/3958"},"html":{"href":"https://github.com/python/cpython/pull/3958"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/3958"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/3958/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/3958/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/3958/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/c07d198b2c2144265822b5e3bbd0b0bcc8aece49"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"orenmn"}}