{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/105534097","pull_request_review_id":26423310,"id":105534097,"diff_hunk":"@@ -67,21 +70,24 @@ class VtkMappedMeshSource final : public vtkUnstructuredGridAlgorithm\n     VtkMappedMeshSource(const VtkMappedMeshSource &); // Not implemented.\n     void operator=(const VtkMappedMeshSource &);      // Not implemented.\n \n-    /// Adds a zero-copy array (MeshLib::VtkMappedPropertyVectorTemplate) as\n-    /// either point or cell data to the mesh.\n+    /// Adds a zero-copy vtk array wrapper.\n     /// \\param properties MeshLib::Properties object\n-    /// \\param prop_name The name of the property vector to be mapped from\n-    /// vtk-mesh to ogs-mesh\n+    /// \\param prop_name The name of the property vector to be mapped\n     template <typename T>\n     bool addProperty(MeshLib::Properties const& properties,\n                      std::string const& prop_name) const\n     {\n         if (!properties.existsPropertyVector<T>(prop_name))\n             return false;\n-        auto* const propertyVector = properties.getPropertyVector<T>(prop_name);\n+        // TODO: Hack removing const\n+        auto* propertyVector = const_cast<MeshLib::PropertyVector<T> *>(\n+            properties.getPropertyVector<T>(prop_name));\n+        if(!propertyVector)\n+            return false;\n \n-        vtkNew<VtkMappedPropertyVectorTemplate<T> > dataArray;\n-        dataArray->SetPropertyVector(const_cast<MeshLib::PropertyVector<T> &>(*propertyVector));\n+        vtkNew<vtkAOSDataArrayTemplate<T> > dataArray;\n+        dataArray->SetArray(propertyVector->data(),\n+            static_cast<vtkIdType>(propertyVector->size()), 1);","path":"MeshLib/Vtk/VtkMappedMeshSource.h","position":50,"original_position":50,"commit_id":"4e4aa98c584cfc9670a946322a1e31ed87fffdd7","original_commit_id":"4e4aa98c584cfc9670a946322a1e31ed87fffdd7","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars1.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"body":"I've tried to fix the failing ctests; for now I've only a hint.\r\nThe failing tests all have a multi-component variable (like displacement) which are not correctly written (with only one component) in the output, so vtkdiff is correct there.\r\nThe `addProperty` function is entered with correct arguments and the `properties` do hold a \"displacement\" array with 2 components. I suspect that the new `dataArray` has default value of 1 for the tuple size.","created_at":"2017-03-11T14:15:08Z","updated_at":"2017-03-11T14:15:09Z","html_url":"https://github.com/ufz/ogs/pull/1744#discussion_r105534097","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1744","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/105534097"},"html":{"href":"https://github.com/ufz/ogs/pull/1744#discussion_r105534097"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1744"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1744","id":109984584,"html_url":"https://github.com/ufz/ogs/pull/1744","diff_url":"https://github.com/ufz/ogs/pull/1744.diff","patch_url":"https://github.com/ufz/ogs/pull/1744.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1744","number":1744,"state":"open","locked":false,"title":"Insitu visualization with ParaView Catalyst","user":{"login":"bilke","id":149656,"avatar_url":"https://avatars0.githubusercontent.com/u/149656?v=3","gravatar_id":"","url":"https://api.github.com/users/bilke","html_url":"https://github.com/bilke","followers_url":"https://api.github.com/users/bilke/followers","following_url":"https://api.github.com/users/bilke/following{/other_user}","gists_url":"https://api.github.com/users/bilke/gists{/gist_id}","starred_url":"https://api.github.com/users/bilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilke/subscriptions","organizations_url":"https://api.github.com/users/bilke/orgs","repos_url":"https://api.github.com/users/bilke/repos","events_url":"https://api.github.com/users/bilke/events{/privacy}","received_events_url":"https://api.github.com/users/bilke/received_events","type":"User","site_admin":false},"body":"🎉 Finally! 🎉 \r\n\r\n## Capabilities\r\n\r\n- Run VTK filter pipeline at post-timestep to write out\r\n  - Reduced / analysed data sets\r\n  - Rendered images of visualizations (not tested yet)\r\n- Connect with ParaView to a running simulation over network (not tested yet)\r\n  - E.g. monitor long-running simulation on envinf1 / eve?\r\n  - Modify visualization parameter\r\n\r\n## How to use\r\n\r\n###### Requirements\r\n- ogs-binary build with `OGS_INSITU=ON`\r\n- exemplary result data set (e.g. the first timestep output)\r\n- ParaView with CoProcessing-plugin enabled\r\n\r\n###### Usage\r\n\r\n- Load example data set in ParaView, setup filter pipeline, add (paralllel) writers \r\n- Export current pipeline as Python script\r\n- Add exported script to OGS simulation project file under `insitu/scripts/script`\r\n- Run simulation\r\n\r\nSee this [example usage](https://github.com/ufz/ogs-data/commit/8913ed9a12d0c82848308851cba3a828ff1f7170).\r\n\r\n## Technical requirements\r\n\r\n- VTK dependency is substituted by a special subset of ParaView (*Catalyst edition*)\r\n  - To reduce binary size\r\n  - Contains just a subset of filter (e.g. threshold, contour, clip, cut, glyph, transform, warp)\r\n  - Some additions to the official editions (`scripts/catalyst/Editions/ogs`)\r\n\r\n## Technical implementation\r\n\r\n- Defined in `Applications/InSituLib`\r\n- `CoProcess()` is called in `ProcessLib::Output::doOutputAlways()`\r\n- Adapter is `MeshLib::VtkMappedMeshSource`; providing zero-copy / -overhead access from VTK to OGS mesh data structures\r\n- VTK 7.1 now required; even for `OGS_INSITU=OFF`\r\n\r\n## Links\r\n\r\n- [www.paraview.org/in-situ/](http://www.paraview.org/in-situ/)\r\n- [www.paraview.org/files/catalyst/docs/ParaViewCatalystUsersGuide_v2.pdf](http://www.paraview.org/files/catalyst/docs/ParaViewCatalystUsersGuide_v2.pdf)","created_at":"2017-03-09T19:12:47Z","updated_at":"2017-03-11T14:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032fe016ad736a38944aa1c696798ae0e4539edb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1744/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1744/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1744/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/4e4aa98c584cfc9670a946322a1e31ed87fffdd7","head":{"label":"bilke:catalyst","ref":"catalyst","sha":"4e4aa98c584cfc9670a946322a1e31ed87fffdd7","user":{"login":"bilke","id":149656,"avatar_url":"https://avatars0.githubusercontent.com/u/149656?v=3","gravatar_id":"","url":"https://api.github.com/users/bilke","html_url":"https://github.com/bilke","followers_url":"https://api.github.com/users/bilke/followers","following_url":"https://api.github.com/users/bilke/following{/other_user}","gists_url":"https://api.github.com/users/bilke/gists{/gist_id}","starred_url":"https://api.github.com/users/bilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilke/subscriptions","organizations_url":"https://api.github.com/users/bilke/orgs","repos_url":"https://api.github.com/users/bilke/repos","events_url":"https://api.github.com/users/bilke/events{/privacy}","received_events_url":"https://api.github.com/users/bilke/received_events","type":"User","site_admin":false},"repo":{"id":5700383,"name":"ogs","full_name":"bilke/ogs","owner":{"login":"bilke","id":149656,"avatar_url":"https://avatars0.githubusercontent.com/u/149656?v=3","gravatar_id":"","url":"https://api.github.com/users/bilke","html_url":"https://github.com/bilke","followers_url":"https://api.github.com/users/bilke/followers","following_url":"https://api.github.com/users/bilke/following{/other_user}","gists_url":"https://api.github.com/users/bilke/gists{/gist_id}","starred_url":"https://api.github.com/users/bilke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilke/subscriptions","organizations_url":"https://api.github.com/users/bilke/orgs","repos_url":"https://api.github.com/users/bilke/repos","events_url":"https://api.github.com/users/bilke/events{/privacy}","received_events_url":"https://api.github.com/users/bilke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bilke/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/bilke/ogs","forks_url":"https://api.github.com/repos/bilke/ogs/forks","keys_url":"https://api.github.com/repos/bilke/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bilke/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bilke/ogs/teams","hooks_url":"https://api.github.com/repos/bilke/ogs/hooks","issue_events_url":"https://api.github.com/repos/bilke/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/bilke/ogs/events","assignees_url":"https://api.github.com/repos/bilke/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/bilke/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/bilke/ogs/tags","blobs_url":"https://api.github.com/repos/bilke/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bilke/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bilke/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bilke/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bilke/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/bilke/ogs/languages","stargazers_url":"https://api.github.com/repos/bilke/ogs/stargazers","contributors_url":"https://api.github.com/repos/bilke/ogs/contributors","subscribers_url":"https://api.github.com/repos/bilke/ogs/subscribers","subscription_url":"https://api.github.com/repos/bilke/ogs/subscription","commits_url":"https://api.github.com/repos/bilke/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bilke/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bilke/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bilke/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bilke/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/bilke/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bilke/ogs/merges","archive_url":"https://api.github.com/repos/bilke/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bilke/ogs/downloads","issues_url":"https://api.github.com/repos/bilke/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/bilke/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/bilke/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/bilke/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bilke/ogs/labels{/name}","releases_url":"https://api.github.com/repos/bilke/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/bilke/ogs/deployments","created_at":"2012-09-06T09:57:29Z","updated_at":"2014-07-16T10:11:25Z","pushed_at":"2017-03-10T07:54:34Z","git_url":"git://github.com/bilke/ogs.git","ssh_url":"git@github.com:bilke/ogs.git","clone_url":"https://github.com/bilke/ogs.git","svn_url":"https://github.com/bilke/ogs","homepage":"www.opengeosys.net","size":17595,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"3ca062c2ff264b56e74966a7d3026441fb79e437","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars0.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars0.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2017-02-24T10:45:51Z","pushed_at":"2017-03-10T13:05:59Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":17556,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":99,"forks":64,"open_issues":99,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1744"},"html":{"href":"https://github.com/ufz/ogs/pull/1744"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1744"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1744/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1744/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1744/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/4e4aa98c584cfc9670a946322a1e31ed87fffdd7"}}}}
{"actor":{"display_login":"endJunction"}}