{"action":"created","comment":{"url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/comments/135520695","pull_request_review_id":58934856,"id":135520695,"diff_hunk":"@@ -400,104 +415,83 @@ h1 {\n     font-size: 14px;\n     margin-top: 28px;\n   }\n-}\n \n-#donate-process-thank-you {\n-  p {\n-    font-size: 22px;\n-    line-height: 46px;\n+  input[type=checkbox],\n+  input[type=radio   ] {\n+    width   : 16px;\n+    margin  : 0;\n+    padding : 0;\n+    appearance:none;\n+    -moz-appearance:none; /* Firefox */\n+    -webkit-appearance:none; /* Safari and Chrome */\n   }\n-}\n \n-.certificate-example-box {\n-  padding: 30px 0;\n-  margin: 0 40px;\n-\n-  img {\n-    outline: $gray-color6 solid 2px;\n+  input[type=checkbox] + label,\n+  input[type=radio   ] + label {\n+    display      : inline-block;\n+    margin-left  : -20px;\n+    padding-left : 28px;\n+    line-height  : 16px;\n+    height: 34px;\n   }\n-}\n-\n-/*****************/\n-/* Form Elements */\n-/*****************/\n \n-input[type=checkbox],\n-input[type=radio   ] {\n-  width   : 16px;\n-  margin  : 0;\n-  padding : 0;\n-  appearance:none;\n-  -moz-appearance:none; /* Firefox */\n-  -webkit-appearance:none; /* Safari and Chrome */\n-}\n+  input[type=radio   ] + label {\n+    @include image(\"general/radio.svg\", 16px);\n \n-input[type=checkbox] + label,\n-input[type=radio   ] + label {\n-  display      : inline-block;\n-  margin-left  : -20px;\n-  padding-left : 28px;\n-  line-height  : 16px;\n-  height: 34px;\n-}\n-\n-input[type=radio   ] + label {\n-  @include image(\"general/radio.svg\", 16px);\n+    .other & {\n+      background-position: left center;\n+    }\n \n-  .other & {\n-    background-position: left center;\n+    &:hover {\n+      background-image: url(\"../images/general/radio-hover.svg\");\n+    }\n   }\n \n-  &:hover {\n-    background-image: url(\"../images/general/radio-hover.svg\");\n+  input[type=radio   ]:checked  + label {\n+    background-image: url(\"../images/general/radio-checked.svg\");\n   }\n-}\n-\n-input[type=radio   ]:checked  + label {\n-  background-image: url(\"../images/general/radio-checked.svg\");\n-}\n \n-input[type=checkbox] + label {\n-  @include image(\"general/checkbox.svg\", 16px);\n+  input[type=checkbox] + label {\n+    @include image(\"general/checkbox.svg\", 16px);\n \n-  &:hover {\n-    @include image(\"general/checkbox-hover.svg\", 16px);\n+    &:hover {\n+      @include image(\"general/checkbox-hover.svg\", 16px);\n+    }\n   }\n-}\n \n-input[type=checkbox]:checked + label {\n-  @include image(\"general/checkbox-checked.svg\", 16px);\n-}\n+  input[type=checkbox]:checked + label {\n+    @include image(\"general/checkbox-checked.svg\", 16px);\n+  }\n \n \n-.btn {\n-  border-radius: 0;\n-  border: none;\n-  text-align: center;\n-  color: $white;\n-  width: auto;\n-  font-size: 30px;\n-  height: 50px;\n-  line-height: 50px;\n-  padding: 0 10%;\n+  .btn {\n+    border-radius: 0;\n+    border: none;\n+    text-align: center;\n+    color: $white;\n+    width: auto;\n+    font-size: 30px;\n+    height: 50px;\n+    line-height: 50px;\n+    padding: 0 10%;\n+  }\n }\n \n-.icount-iframe {\n-  height: 620px;\n+#donate-process-thank-you {\n+  p {\n+    font-size: 22px;\n+    line-height: 46px;\n+  }\n }\n \n /**************/\n /* responsive */\n /**************/\n \n-@import \"responsive\";\n-\n-@media (max-width: 1199px) {\n-\n-}\n+// @import \"responsive\";","path":"wp-content/themes/bh/scss/donate.scss","position":null,"original_position":184,"commit_id":"d64586a156703f6898454fa20f28247dc8a4122f","original_commit_id":"d64586a156703f6898454fa20f28247dc8a4122f","user":{"login":"nirgoldberg","id":17052336,"avatar_url":"https://avatars1.githubusercontent.com/u/17052336?v=4","gravatar_id":"","url":"https://api.github.com/users/nirgoldberg","html_url":"https://github.com/nirgoldberg","followers_url":"https://api.github.com/users/nirgoldberg/followers","following_url":"https://api.github.com/users/nirgoldberg/following{/other_user}","gists_url":"https://api.github.com/users/nirgoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/nirgoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirgoldberg/subscriptions","organizations_url":"https://api.github.com/users/nirgoldberg/orgs","repos_url":"https://api.github.com/users/nirgoldberg/repos","events_url":"https://api.github.com/users/nirgoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/nirgoldberg/received_events","type":"User","site_admin":false},"body":"Something doesn't seem OK here: although you moved all responsive data to _responsive.scss, you still don't access _responsive.scss as you commented this line.\r\nIn addition, please remove all commented definitions below this line.","created_at":"2017-08-28T13:14:09Z","updated_at":"2017-08-28T13:22:43Z","html_url":"https://github.com/Beit-Hatfutsot/wp-bh/pull/36#discussion_r135520695","pull_request_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/comments/135520695"},"html":{"href":"https://github.com/Beit-Hatfutsot/wp-bh/pull/36#discussion_r135520695"},"pull_request":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36","id":133430211,"html_url":"https://github.com/Beit-Hatfutsot/wp-bh/pull/36","diff_url":"https://github.com/Beit-Hatfutsot/wp-bh/pull/36.diff","patch_url":"https://github.com/Beit-Hatfutsot/wp-bh/pull/36.patch","issue_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/issues/36","number":36,"state":"open","locked":false,"title":"Donations Module","user":{"login":"ibanner","id":4220832,"avatar_url":"https://avatars3.githubusercontent.com/u/4220832?v=4","gravatar_id":"","url":"https://api.github.com/users/ibanner","html_url":"https://github.com/ibanner","followers_url":"https://api.github.com/users/ibanner/followers","following_url":"https://api.github.com/users/ibanner/following{/other_user}","gists_url":"https://api.github.com/users/ibanner/gists{/gist_id}","starred_url":"https://api.github.com/users/ibanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibanner/subscriptions","organizations_url":"https://api.github.com/users/ibanner/orgs","repos_url":"https://api.github.com/users/ibanner/repos","events_url":"https://api.github.com/users/ibanner/events{/privacy}","received_events_url":"https://api.github.com/users/ibanner/received_events","type":"User","site_admin":false},"body":"Following recent correspondence, this pull request now includes:\r\n\r\n- RTL style\r\n- Hebrew strings (.po/.mo)\r\n- Responsive styling\r\n- Placeholder function for subscribing donors via ActiveTrail API (see below).\r\n\r\n## INSTALLATION\r\nThe module relies on creating a few pages, and setting them up with the right page templates. Given the scope of the project I saw no reason to perform this setup programmaticly. \r\n\r\nI guess it would be best if you could pull this into your test environment and I'll take care of the necessary setup. If you prefer, I can document the necessary setup procedure for you guys to perform. There's also a dedicated options sub-page that needs to be setup.\r\n\r\n## NOTES\r\n### Donor Newsletter Subscription\r\nThe code in `newsletter-api.php` appears to be using a stale version of the API. I wrote the function based on the [Current API](http://webapi.mymarketing.co.il/api/docs) but actual API credentials & settings should be added.\r\n\r\n### iCount Integration\r\nI've set up 2 billing forms under BH's iCount new donations account. One is for one-time donations and the other for recurring ones. The module includes a `README.MD` file that includes the custom CSS I've used to style the forms in order to fit info our iframes. \r\n\r\nThere are still some loose ends to be picked up in this integration:\r\n@nuritgazit / @Netush - \r\n- [ ] Choose the template for the receipt sent to the donor\r\n- [ ] Design and create the template of the email containing the receipt. \r\n\r\n@TheGrandVizier  - \r\n- [ ] Once we're ready for launch, we need to ask iCount to set our billing form to live mode\r\n\r\n### PDF Certificates\r\nThis is not supported at the moment, as the tests I made produced a low quality results. I have an idea on how we achieve better results (TBD) but I thought best to create the pull request now, and work on this while you review the bulk of the module.","created_at":"2017-08-01T09:42:53Z","updated_at":"2017-08-28T13:22:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2c2ba8e61c659f3a57870893bc501331cb397dd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36/commits","review_comments_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36/comments","review_comment_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/issues/36/comments","statuses_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/statuses/d64586a156703f6898454fa20f28247dc8a4122f","head":{"label":"ibanner:donations_itay","ref":"donations_itay","sha":"d64586a156703f6898454fa20f28247dc8a4122f","user":{"login":"ibanner","id":4220832,"avatar_url":"https://avatars3.githubusercontent.com/u/4220832?v=4","gravatar_id":"","url":"https://api.github.com/users/ibanner","html_url":"https://github.com/ibanner","followers_url":"https://api.github.com/users/ibanner/followers","following_url":"https://api.github.com/users/ibanner/following{/other_user}","gists_url":"https://api.github.com/users/ibanner/gists{/gist_id}","starred_url":"https://api.github.com/users/ibanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibanner/subscriptions","organizations_url":"https://api.github.com/users/ibanner/orgs","repos_url":"https://api.github.com/users/ibanner/repos","events_url":"https://api.github.com/users/ibanner/events{/privacy}","received_events_url":"https://api.github.com/users/ibanner/received_events","type":"User","site_admin":false},"repo":{"id":85561487,"name":"wp-bh","full_name":"ibanner/wp-bh","owner":{"login":"ibanner","id":4220832,"avatar_url":"https://avatars3.githubusercontent.com/u/4220832?v=4","gravatar_id":"","url":"https://api.github.com/users/ibanner","html_url":"https://github.com/ibanner","followers_url":"https://api.github.com/users/ibanner/followers","following_url":"https://api.github.com/users/ibanner/following{/other_user}","gists_url":"https://api.github.com/users/ibanner/gists{/gist_id}","starred_url":"https://api.github.com/users/ibanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibanner/subscriptions","organizations_url":"https://api.github.com/users/ibanner/orgs","repos_url":"https://api.github.com/users/ibanner/repos","events_url":"https://api.github.com/users/ibanner/events{/privacy}","received_events_url":"https://api.github.com/users/ibanner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibanner/wp-bh","description":"BH Main Site","fork":true,"url":"https://api.github.com/repos/ibanner/wp-bh","forks_url":"https://api.github.com/repos/ibanner/wp-bh/forks","keys_url":"https://api.github.com/repos/ibanner/wp-bh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibanner/wp-bh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibanner/wp-bh/teams","hooks_url":"https://api.github.com/repos/ibanner/wp-bh/hooks","issue_events_url":"https://api.github.com/repos/ibanner/wp-bh/issues/events{/number}","events_url":"https://api.github.com/repos/ibanner/wp-bh/events","assignees_url":"https://api.github.com/repos/ibanner/wp-bh/assignees{/user}","branches_url":"https://api.github.com/repos/ibanner/wp-bh/branches{/branch}","tags_url":"https://api.github.com/repos/ibanner/wp-bh/tags","blobs_url":"https://api.github.com/repos/ibanner/wp-bh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibanner/wp-bh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibanner/wp-bh/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibanner/wp-bh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibanner/wp-bh/statuses/{sha}","languages_url":"https://api.github.com/repos/ibanner/wp-bh/languages","stargazers_url":"https://api.github.com/repos/ibanner/wp-bh/stargazers","contributors_url":"https://api.github.com/repos/ibanner/wp-bh/contributors","subscribers_url":"https://api.github.com/repos/ibanner/wp-bh/subscribers","subscription_url":"https://api.github.com/repos/ibanner/wp-bh/subscription","commits_url":"https://api.github.com/repos/ibanner/wp-bh/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibanner/wp-bh/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibanner/wp-bh/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibanner/wp-bh/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibanner/wp-bh/contents/{+path}","compare_url":"https://api.github.com/repos/ibanner/wp-bh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibanner/wp-bh/merges","archive_url":"https://api.github.com/repos/ibanner/wp-bh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibanner/wp-bh/downloads","issues_url":"https://api.github.com/repos/ibanner/wp-bh/issues{/number}","pulls_url":"https://api.github.com/repos/ibanner/wp-bh/pulls{/number}","milestones_url":"https://api.github.com/repos/ibanner/wp-bh/milestones{/number}","notifications_url":"https://api.github.com/repos/ibanner/wp-bh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibanner/wp-bh/labels{/name}","releases_url":"https://api.github.com/repos/ibanner/wp-bh/releases{/id}","deployments_url":"https://api.github.com/repos/ibanner/wp-bh/deployments","created_at":"2017-03-20T10:02:50Z","updated_at":"2017-03-20T10:03:14Z","pushed_at":"2017-08-23T17:53:09Z","git_url":"git://github.com/ibanner/wp-bh.git","ssh_url":"git@github.com:ibanner/wp-bh.git","clone_url":"https://github.com/ibanner/wp-bh.git","svn_url":"https://github.com/ibanner/wp-bh","homepage":null,"size":262185,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Beit-Hatfutsot:master","ref":"master","sha":"8709c6f0c9a890ed9feaf8581102c332c225de29","user":{"login":"Beit-Hatfutsot","id":15228676,"avatar_url":"https://avatars1.githubusercontent.com/u/15228676?v=4","gravatar_id":"","url":"https://api.github.com/users/Beit-Hatfutsot","html_url":"https://github.com/Beit-Hatfutsot","followers_url":"https://api.github.com/users/Beit-Hatfutsot/followers","following_url":"https://api.github.com/users/Beit-Hatfutsot/following{/other_user}","gists_url":"https://api.github.com/users/Beit-Hatfutsot/gists{/gist_id}","starred_url":"https://api.github.com/users/Beit-Hatfutsot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beit-Hatfutsot/subscriptions","organizations_url":"https://api.github.com/users/Beit-Hatfutsot/orgs","repos_url":"https://api.github.com/users/Beit-Hatfutsot/repos","events_url":"https://api.github.com/users/Beit-Hatfutsot/events{/privacy}","received_events_url":"https://api.github.com/users/Beit-Hatfutsot/received_events","type":"Organization","site_admin":false},"repo":{"id":71898676,"name":"wp-bh","full_name":"Beit-Hatfutsot/wp-bh","owner":{"login":"Beit-Hatfutsot","id":15228676,"avatar_url":"https://avatars1.githubusercontent.com/u/15228676?v=4","gravatar_id":"","url":"https://api.github.com/users/Beit-Hatfutsot","html_url":"https://github.com/Beit-Hatfutsot","followers_url":"https://api.github.com/users/Beit-Hatfutsot/followers","following_url":"https://api.github.com/users/Beit-Hatfutsot/following{/other_user}","gists_url":"https://api.github.com/users/Beit-Hatfutsot/gists{/gist_id}","starred_url":"https://api.github.com/users/Beit-Hatfutsot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beit-Hatfutsot/subscriptions","organizations_url":"https://api.github.com/users/Beit-Hatfutsot/orgs","repos_url":"https://api.github.com/users/Beit-Hatfutsot/repos","events_url":"https://api.github.com/users/Beit-Hatfutsot/events{/privacy}","received_events_url":"https://api.github.com/users/Beit-Hatfutsot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Beit-Hatfutsot/wp-bh","description":"BH Main Site","fork":false,"url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh","forks_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/forks","keys_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/teams","hooks_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/hooks","issue_events_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/issues/events{/number}","events_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/events","assignees_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/assignees{/user}","branches_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/branches{/branch}","tags_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/tags","blobs_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/statuses/{sha}","languages_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/languages","stargazers_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/stargazers","contributors_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/contributors","subscribers_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/subscribers","subscription_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/subscription","commits_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/contents/{+path}","compare_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/merges","archive_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/downloads","issues_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/issues{/number}","pulls_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls{/number}","milestones_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/milestones{/number}","notifications_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/labels{/name}","releases_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/releases{/id}","deployments_url":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/deployments","created_at":"2016-10-25T13:16:13Z","updated_at":"2016-10-26T06:36:10Z","pushed_at":"2017-08-23T17:53:11Z","git_url":"git://github.com/Beit-Hatfutsot/wp-bh.git","ssh_url":"git@github.com:Beit-Hatfutsot/wp-bh.git","clone_url":"https://github.com/Beit-Hatfutsot/wp-bh.git","svn_url":"https://github.com/Beit-Hatfutsot/wp-bh","homepage":null,"size":260001,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":21,"forks":1,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36"},"html":{"href":"https://github.com/Beit-Hatfutsot/wp-bh/pull/36"},"issue":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/issues/36"},"comments":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/Beit-Hatfutsot/wp-bh/statuses/d64586a156703f6898454fa20f28247dc8a4122f"}}}}
{"actor":{"display_login":"nirgoldberg"}}