{"action":"created","comment":{"url":"https://api.github.com/repos/dvvrd/VSharp/pulls/comments/157958325","pull_request_review_id":84686977,"id":157958325,"diff_hunk":"@@ -37,21 +27,13 @@ module public List =\n \n     let public append3 xs ys zs = List.append xs (List.append ys zs)\n \n-    let rec public filterMap mapper = function\n-        | [] -> []\n-        | x::xs ->\n-            match mapper x with\n-            | Some y -> y::(filterMap mapper xs)\n-            | None -> (filterMap mapper xs)\n-\n-    let rec public filterMap2 mapper xs ys =\n-        match xs, ys with\n-        | [], [] -> []\n-        | x::xs, y::ys ->\n-            match mapper x y with\n-            | Some z -> z::(filterMap2 mapper xs ys)\n-            | None -> (filterMap2 mapper xs ys)\n-        | _ -> internalfail \"filterMap2 expects lists of equal lengths\"\n+    let public filterMap2 mapper xs ys = List.choose ((<||) mapper) <| List.zip xs ys","path":"VSharp.Utils/Collections.fs","position":38,"original_position":38,"commit_id":"55fa0a3f57b85c160bb99d03e85a8181d267abe6","original_commit_id":"55fa0a3f57b85c160bb99d03e85a8181d267abe6","user":{"login":"dvvrd","id":734254,"avatar_url":"https://avatars3.githubusercontent.com/u/734254?v=4","gravatar_id":"","url":"https://api.github.com/users/dvvrd","html_url":"https://github.com/dvvrd","followers_url":"https://api.github.com/users/dvvrd/followers","following_url":"https://api.github.com/users/dvvrd/following{/other_user}","gists_url":"https://api.github.com/users/dvvrd/gists{/gist_id}","starred_url":"https://api.github.com/users/dvvrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvvrd/subscriptions","organizations_url":"https://api.github.com/users/dvvrd/orgs","repos_url":"https://api.github.com/users/dvvrd/repos","events_url":"https://api.github.com/users/dvvrd/events{/privacy}","received_events_url":"https://api.github.com/users/dvvrd/received_events","type":"User","site_admin":false},"body":"List.zip конструирует лишний промежуточный список, старый вариант лучше в [11 раз](https://gist.github.com/dvvrd/d2ad7361846cb1441847a11eb144727d).","created_at":"2017-12-20T08:09:35Z","updated_at":"2017-12-20T08:50:32Z","html_url":"https://github.com/dvvrd/VSharp/pull/56#discussion_r157958325","pull_request_url":"https://api.github.com/repos/dvvrd/VSharp/pulls/56","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dvvrd/VSharp/pulls/comments/157958325"},"html":{"href":"https://github.com/dvvrd/VSharp/pull/56#discussion_r157958325"},"pull_request":{"href":"https://api.github.com/repos/dvvrd/VSharp/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/dvvrd/VSharp/pulls/56","id":159283009,"html_url":"https://github.com/dvvrd/VSharp/pull/56","diff_url":"https://github.com/dvvrd/VSharp/pull/56.diff","patch_url":"https://github.com/dvvrd/VSharp/pull/56.patch","issue_url":"https://api.github.com/repos/dvvrd/VSharp/issues/56","number":56,"state":"open","locked":false,"title":"Style fixes","user":{"login":"Columpio","id":4246598,"avatar_url":"https://avatars1.githubusercontent.com/u/4246598?v=4","gravatar_id":"","url":"https://api.github.com/users/Columpio","html_url":"https://github.com/Columpio","followers_url":"https://api.github.com/users/Columpio/followers","following_url":"https://api.github.com/users/Columpio/following{/other_user}","gists_url":"https://api.github.com/users/Columpio/gists{/gist_id}","starred_url":"https://api.github.com/users/Columpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Columpio/subscriptions","organizations_url":"https://api.github.com/users/Columpio/orgs","repos_url":"https://api.github.com/users/Columpio/repos","events_url":"https://api.github.com/users/Columpio/events{/privacy}","received_events_url":"https://api.github.com/users/Columpio/received_events","type":"User","site_admin":false},"body":"- Improved Collections\r\n- Changed `changeLast` due to [comment](https://github.com/dvvrd/VSharp/pull/51#discussion_r155917070) in @miha2733 pull request","created_at":"2017-12-19T22:03:32Z","updated_at":"2017-12-20T08:50:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085a606b9b2ae2b1f4609d41f0f11593989d4f9a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvvrd/VSharp/pulls/56/commits","review_comments_url":"https://api.github.com/repos/dvvrd/VSharp/pulls/56/comments","review_comment_url":"https://api.github.com/repos/dvvrd/VSharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvvrd/VSharp/issues/56/comments","statuses_url":"https://api.github.com/repos/dvvrd/VSharp/statuses/55fa0a3f57b85c160bb99d03e85a8181d267abe6","head":{"label":"Columpio:unsafe","ref":"unsafe","sha":"55fa0a3f57b85c160bb99d03e85a8181d267abe6","user":{"login":"Columpio","id":4246598,"avatar_url":"https://avatars1.githubusercontent.com/u/4246598?v=4","gravatar_id":"","url":"https://api.github.com/users/Columpio","html_url":"https://github.com/Columpio","followers_url":"https://api.github.com/users/Columpio/followers","following_url":"https://api.github.com/users/Columpio/following{/other_user}","gists_url":"https://api.github.com/users/Columpio/gists{/gist_id}","starred_url":"https://api.github.com/users/Columpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Columpio/subscriptions","organizations_url":"https://api.github.com/users/Columpio/orgs","repos_url":"https://api.github.com/users/Columpio/repos","events_url":"https://api.github.com/users/Columpio/events{/privacy}","received_events_url":"https://api.github.com/users/Columpio/received_events","type":"User","site_admin":false},"repo":{"id":103151988,"name":"VSharp","full_name":"Columpio/VSharp","owner":{"login":"Columpio","id":4246598,"avatar_url":"https://avatars1.githubusercontent.com/u/4246598?v=4","gravatar_id":"","url":"https://api.github.com/users/Columpio","html_url":"https://github.com/Columpio","followers_url":"https://api.github.com/users/Columpio/followers","following_url":"https://api.github.com/users/Columpio/following{/other_user}","gists_url":"https://api.github.com/users/Columpio/gists{/gist_id}","starred_url":"https://api.github.com/users/Columpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Columpio/subscriptions","organizations_url":"https://api.github.com/users/Columpio/orgs","repos_url":"https://api.github.com/users/Columpio/repos","events_url":"https://api.github.com/users/Columpio/events{/privacy}","received_events_url":"https://api.github.com/users/Columpio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Columpio/VSharp","description":null,"fork":true,"url":"https://api.github.com/repos/Columpio/VSharp","forks_url":"https://api.github.com/repos/Columpio/VSharp/forks","keys_url":"https://api.github.com/repos/Columpio/VSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Columpio/VSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Columpio/VSharp/teams","hooks_url":"https://api.github.com/repos/Columpio/VSharp/hooks","issue_events_url":"https://api.github.com/repos/Columpio/VSharp/issues/events{/number}","events_url":"https://api.github.com/repos/Columpio/VSharp/events","assignees_url":"https://api.github.com/repos/Columpio/VSharp/assignees{/user}","branches_url":"https://api.github.com/repos/Columpio/VSharp/branches{/branch}","tags_url":"https://api.github.com/repos/Columpio/VSharp/tags","blobs_url":"https://api.github.com/repos/Columpio/VSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Columpio/VSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Columpio/VSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Columpio/VSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Columpio/VSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Columpio/VSharp/languages","stargazers_url":"https://api.github.com/repos/Columpio/VSharp/stargazers","contributors_url":"https://api.github.com/repos/Columpio/VSharp/contributors","subscribers_url":"https://api.github.com/repos/Columpio/VSharp/subscribers","subscription_url":"https://api.github.com/repos/Columpio/VSharp/subscription","commits_url":"https://api.github.com/repos/Columpio/VSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Columpio/VSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Columpio/VSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Columpio/VSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Columpio/VSharp/contents/{+path}","compare_url":"https://api.github.com/repos/Columpio/VSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Columpio/VSharp/merges","archive_url":"https://api.github.com/repos/Columpio/VSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Columpio/VSharp/downloads","issues_url":"https://api.github.com/repos/Columpio/VSharp/issues{/number}","pulls_url":"https://api.github.com/repos/Columpio/VSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Columpio/VSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Columpio/VSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Columpio/VSharp/labels{/name}","releases_url":"https://api.github.com/repos/Columpio/VSharp/releases{/id}","deployments_url":"https://api.github.com/repos/Columpio/VSharp/deployments","created_at":"2017-09-11T15:17:06Z","updated_at":"2017-09-11T15:17:07Z","pushed_at":"2017-12-19T22:44:38Z","git_url":"git://github.com/Columpio/VSharp.git","ssh_url":"git@github.com:Columpio/VSharp.git","clone_url":"https://github.com/Columpio/VSharp.git","svn_url":"https://github.com/Columpio/VSharp","homepage":null,"size":4586,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dvvrd:master","ref":"master","sha":"f97e7a945d7f4fc0f23aab5401830274732b5d15","user":{"login":"dvvrd","id":734254,"avatar_url":"https://avatars3.githubusercontent.com/u/734254?v=4","gravatar_id":"","url":"https://api.github.com/users/dvvrd","html_url":"https://github.com/dvvrd","followers_url":"https://api.github.com/users/dvvrd/followers","following_url":"https://api.github.com/users/dvvrd/following{/other_user}","gists_url":"https://api.github.com/users/dvvrd/gists{/gist_id}","starred_url":"https://api.github.com/users/dvvrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvvrd/subscriptions","organizations_url":"https://api.github.com/users/dvvrd/orgs","repos_url":"https://api.github.com/users/dvvrd/repos","events_url":"https://api.github.com/users/dvvrd/events{/privacy}","received_events_url":"https://api.github.com/users/dvvrd/received_events","type":"User","site_admin":false},"repo":{"id":63795846,"name":"VSharp","full_name":"dvvrd/VSharp","owner":{"login":"dvvrd","id":734254,"avatar_url":"https://avatars3.githubusercontent.com/u/734254?v=4","gravatar_id":"","url":"https://api.github.com/users/dvvrd","html_url":"https://github.com/dvvrd","followers_url":"https://api.github.com/users/dvvrd/followers","following_url":"https://api.github.com/users/dvvrd/following{/other_user}","gists_url":"https://api.github.com/users/dvvrd/gists{/gist_id}","starred_url":"https://api.github.com/users/dvvrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvvrd/subscriptions","organizations_url":"https://api.github.com/users/dvvrd/orgs","repos_url":"https://api.github.com/users/dvvrd/repos","events_url":"https://api.github.com/users/dvvrd/events{/privacy}","received_events_url":"https://api.github.com/users/dvvrd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dvvrd/VSharp","description":null,"fork":false,"url":"https://api.github.com/repos/dvvrd/VSharp","forks_url":"https://api.github.com/repos/dvvrd/VSharp/forks","keys_url":"https://api.github.com/repos/dvvrd/VSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvvrd/VSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvvrd/VSharp/teams","hooks_url":"https://api.github.com/repos/dvvrd/VSharp/hooks","issue_events_url":"https://api.github.com/repos/dvvrd/VSharp/issues/events{/number}","events_url":"https://api.github.com/repos/dvvrd/VSharp/events","assignees_url":"https://api.github.com/repos/dvvrd/VSharp/assignees{/user}","branches_url":"https://api.github.com/repos/dvvrd/VSharp/branches{/branch}","tags_url":"https://api.github.com/repos/dvvrd/VSharp/tags","blobs_url":"https://api.github.com/repos/dvvrd/VSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvvrd/VSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvvrd/VSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvvrd/VSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvvrd/VSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/dvvrd/VSharp/languages","stargazers_url":"https://api.github.com/repos/dvvrd/VSharp/stargazers","contributors_url":"https://api.github.com/repos/dvvrd/VSharp/contributors","subscribers_url":"https://api.github.com/repos/dvvrd/VSharp/subscribers","subscription_url":"https://api.github.com/repos/dvvrd/VSharp/subscription","commits_url":"https://api.github.com/repos/dvvrd/VSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvvrd/VSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvvrd/VSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvvrd/VSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvvrd/VSharp/contents/{+path}","compare_url":"https://api.github.com/repos/dvvrd/VSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvvrd/VSharp/merges","archive_url":"https://api.github.com/repos/dvvrd/VSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvvrd/VSharp/downloads","issues_url":"https://api.github.com/repos/dvvrd/VSharp/issues{/number}","pulls_url":"https://api.github.com/repos/dvvrd/VSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/dvvrd/VSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/dvvrd/VSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvvrd/VSharp/labels{/name}","releases_url":"https://api.github.com/repos/dvvrd/VSharp/releases{/id}","deployments_url":"https://api.github.com/repos/dvvrd/VSharp/deployments","created_at":"2016-07-20T16:12:02Z","updated_at":"2017-09-12T21:08:48Z","pushed_at":"2017-12-19T22:03:33Z","git_url":"git://github.com/dvvrd/VSharp.git","ssh_url":"git@github.com:dvvrd/VSharp.git","clone_url":"https://github.com/dvvrd/VSharp.git","svn_url":"https://github.com/dvvrd/VSharp","homepage":null,"size":13413,"stargazers_count":2,"watchers_count":2,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":5,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dvvrd/VSharp/pulls/56"},"html":{"href":"https://github.com/dvvrd/VSharp/pull/56"},"issue":{"href":"https://api.github.com/repos/dvvrd/VSharp/issues/56"},"comments":{"href":"https://api.github.com/repos/dvvrd/VSharp/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/dvvrd/VSharp/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/dvvrd/VSharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvvrd/VSharp/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/dvvrd/VSharp/statuses/55fa0a3f57b85c160bb99d03e85a8181d267abe6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dvvrd"}}