{"action":"created","comment":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/100666535","pull_request_review_id":21385039,"id":100666535,"diff_hunk":"@@ -177,87 +178,107 @@ def test_install(self):\n         trans = self.solver._group_install(grp.id, dnf.comps.MANDATORY, ['right'])\n         self.assertLength(trans.install, 2)\n         p_grp = self.persistor.group('base')\n-        self.assertCountEqual(p_grp.full_list, ['pepper', 'tour'])\n-        self.assertCountEqual(p_grp.pkg_exclude, ['right'])\n+        self.assertCountEqual(p_grp.get_full_list(), ['pepper', 'tour'])\n+        self.assertCountEqual(p_grp.get_exclude(), ['right'])\n         self.assertEqual(p_grp.pkg_types, dnf.comps.MANDATORY)\n \n     def test_removable_pkg(self):\n-        p_grp1 = self.persistor.group('base')\n-        p_grp2 = self.persistor.group('tune')\n-        p_grp1.full_list.extend(('pepper', 'tour', 'right'))\n-        p_grp2.full_list.append('tour')\n-        self.assertTrue(self.solver._removable_pkg('pepper'))\n+        self.base.history.reset_db()\n+        grp = self.comps.group_by_pattern('base')\n+        trans = self.solver._group_install(grp.id, dnf.comps.MANDATORY, [])","path":"tests/test_comps.py","position":28,"original_position":28,"commit_id":"ef6b74666ecd1aeb0c9f765cac3fdfca16a5635d","original_commit_id":"ef6b74666ecd1aeb0c9f765cac3fdfca16a5635d","user":{"login":"dnf-bot","id":10563235,"avatar_url":"https://avatars.githubusercontent.com/u/10563235?v=3","gravatar_id":"","url":"https://api.github.com/users/dnf-bot","html_url":"https://github.com/dnf-bot","followers_url":"https://api.github.com/users/dnf-bot/followers","following_url":"https://api.github.com/users/dnf-bot/following{/other_user}","gists_url":"https://api.github.com/users/dnf-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dnf-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnf-bot/subscriptions","organizations_url":"https://api.github.com/users/dnf-bot/orgs","repos_url":"https://api.github.com/users/dnf-bot/repos","events_url":"https://api.github.com/users/dnf-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dnf-bot/received_events","type":"User","site_admin":false},"body":"__[flake8]__\n* [F841] local variable 'trans' is assigned to but never used\n\n<!-- Comment by [SideCI](https://sideci.com) -->","created_at":"2017-02-11T12:23:12Z","updated_at":"2017-02-11T12:23:12Z","html_url":"https://github.com/rpm-software-management/dnf/pull/630#discussion_r100666535","pull_request_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630","_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/100666535"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/630#discussion_r100666535"},"pull_request":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630"}}},"pull_request":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630","id":88065455,"html_url":"https://github.com/rpm-software-management/dnf/pull/630","diff_url":"https://github.com/rpm-software-management/dnf/pull/630.diff","patch_url":"https://github.com/rpm-software-management/dnf/pull/630.patch","issue_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/630","number":630,"state":"open","locked":false,"title":"WIP: SWDB preview","user":{"login":"edynox","id":18234754,"avatar_url":"https://avatars.githubusercontent.com/u/18234754?v=3","gravatar_id":"","url":"https://api.github.com/users/edynox","html_url":"https://github.com/edynox","followers_url":"https://api.github.com/users/edynox/followers","following_url":"https://api.github.com/users/edynox/following{/other_user}","gists_url":"https://api.github.com/users/edynox/gists{/gist_id}","starred_url":"https://api.github.com/users/edynox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edynox/subscriptions","organizations_url":"https://api.github.com/users/edynox/orgs","repos_url":"https://api.github.com/users/edynox/repos","events_url":"https://api.github.com/users/edynox/events{/privacy}","received_events_url":"https://api.github.com/users/edynox/received_events","type":"User","site_admin":false},"body":"Hi, this is preview for SWDB integration in DNF.\nMost of functions should be working now, old databases are not used anymore.\nIt would be fine to have separate branch for that...\n\nIt requires dnf-swdb libhif module, see [https://github.com/edynox/libhif](https://github.com/edynox/libhif)\n\n[demo.pdf](https://github.com/rpm-software-management/dnf/files/511065/demo.pdf)\n","created_at":"2016-10-05T12:09:46Z","updated_at":"2017-02-11T12:23:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2771108b68b44f3aaa45418df987e2ea14d26e43","assignee":{"login":"ignatenkobrain","id":2866862,"avatar_url":"https://avatars.githubusercontent.com/u/2866862?v=3","gravatar_id":"","url":"https://api.github.com/users/ignatenkobrain","html_url":"https://github.com/ignatenkobrain","followers_url":"https://api.github.com/users/ignatenkobrain/followers","following_url":"https://api.github.com/users/ignatenkobrain/following{/other_user}","gists_url":"https://api.github.com/users/ignatenkobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatenkobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatenkobrain/subscriptions","organizations_url":"https://api.github.com/users/ignatenkobrain/orgs","repos_url":"https://api.github.com/users/ignatenkobrain/repos","events_url":"https://api.github.com/users/ignatenkobrain/events{/privacy}","received_events_url":"https://api.github.com/users/ignatenkobrain/received_events","type":"User","site_admin":false},"assignees":[{"login":"ignatenkobrain","id":2866862,"avatar_url":"https://avatars.githubusercontent.com/u/2866862?v=3","gravatar_id":"","url":"https://api.github.com/users/ignatenkobrain","html_url":"https://github.com/ignatenkobrain","followers_url":"https://api.github.com/users/ignatenkobrain/followers","following_url":"https://api.github.com/users/ignatenkobrain/following{/other_user}","gists_url":"https://api.github.com/users/ignatenkobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatenkobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatenkobrain/subscriptions","organizations_url":"https://api.github.com/users/ignatenkobrain/orgs","repos_url":"https://api.github.com/users/ignatenkobrain/repos","events_url":"https://api.github.com/users/ignatenkobrain/events{/privacy}","received_events_url":"https://api.github.com/users/ignatenkobrain/received_events","type":"User","site_admin":false},{"login":"jsilhan","id":5243763,"avatar_url":"https://avatars.githubusercontent.com/u/5243763?v=3","gravatar_id":"","url":"https://api.github.com/users/jsilhan","html_url":"https://github.com/jsilhan","followers_url":"https://api.github.com/users/jsilhan/followers","following_url":"https://api.github.com/users/jsilhan/following{/other_user}","gists_url":"https://api.github.com/users/jsilhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilhan/subscriptions","organizations_url":"https://api.github.com/users/jsilhan/orgs","repos_url":"https://api.github.com/users/jsilhan/repos","events_url":"https://api.github.com/users/jsilhan/events{/privacy}","received_events_url":"https://api.github.com/users/jsilhan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/rpm-software-management/dnf/milestones/2","html_url":"https://github.com/rpm-software-management/dnf/milestone/2","labels_url":"https://api.github.com/repos/rpm-software-management/dnf/milestones/2/labels","id":2186248,"number":2,"title":"future","description":"","creator":{"login":"ignatenkobrain","id":2866862,"avatar_url":"https://avatars.githubusercontent.com/u/2866862?v=3","gravatar_id":"","url":"https://api.github.com/users/ignatenkobrain","html_url":"https://github.com/ignatenkobrain","followers_url":"https://api.github.com/users/ignatenkobrain/followers","following_url":"https://api.github.com/users/ignatenkobrain/following{/other_user}","gists_url":"https://api.github.com/users/ignatenkobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatenkobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatenkobrain/subscriptions","organizations_url":"https://api.github.com/users/ignatenkobrain/orgs","repos_url":"https://api.github.com/users/ignatenkobrain/repos","events_url":"https://api.github.com/users/ignatenkobrain/events{/privacy}","received_events_url":"https://api.github.com/users/ignatenkobrain/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2016-12-09T09:53:32Z","updated_at":"2016-12-19T11:45:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630/commits","review_comments_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630/comments","review_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/630/comments","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/ef6b74666ecd1aeb0c9f765cac3fdfca16a5635d","head":{"label":"edynox:hif-swdb","ref":"hif-swdb","sha":"ef6b74666ecd1aeb0c9f765cac3fdfca16a5635d","user":{"login":"edynox","id":18234754,"avatar_url":"https://avatars.githubusercontent.com/u/18234754?v=3","gravatar_id":"","url":"https://api.github.com/users/edynox","html_url":"https://github.com/edynox","followers_url":"https://api.github.com/users/edynox/followers","following_url":"https://api.github.com/users/edynox/following{/other_user}","gists_url":"https://api.github.com/users/edynox/gists{/gist_id}","starred_url":"https://api.github.com/users/edynox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edynox/subscriptions","organizations_url":"https://api.github.com/users/edynox/orgs","repos_url":"https://api.github.com/users/edynox/repos","events_url":"https://api.github.com/users/edynox/events{/privacy}","received_events_url":"https://api.github.com/users/edynox/received_events","type":"User","site_admin":false},"repo":{"id":64313545,"name":"dnf","full_name":"edynox/dnf","owner":{"login":"edynox","id":18234754,"avatar_url":"https://avatars.githubusercontent.com/u/18234754?v=3","gravatar_id":"","url":"https://api.github.com/users/edynox","html_url":"https://github.com/edynox","followers_url":"https://api.github.com/users/edynox/followers","following_url":"https://api.github.com/users/edynox/following{/other_user}","gists_url":"https://api.github.com/users/edynox/gists{/gist_id}","starred_url":"https://api.github.com/users/edynox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edynox/subscriptions","organizations_url":"https://api.github.com/users/edynox/orgs","repos_url":"https://api.github.com/users/edynox/repos","events_url":"https://api.github.com/users/edynox/events{/privacy}","received_events_url":"https://api.github.com/users/edynox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edynox/dnf","description":"dnf is a package manager based on yum and libsolv","fork":true,"url":"https://api.github.com/repos/edynox/dnf","forks_url":"https://api.github.com/repos/edynox/dnf/forks","keys_url":"https://api.github.com/repos/edynox/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edynox/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edynox/dnf/teams","hooks_url":"https://api.github.com/repos/edynox/dnf/hooks","issue_events_url":"https://api.github.com/repos/edynox/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/edynox/dnf/events","assignees_url":"https://api.github.com/repos/edynox/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/edynox/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/edynox/dnf/tags","blobs_url":"https://api.github.com/repos/edynox/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edynox/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edynox/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/edynox/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edynox/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/edynox/dnf/languages","stargazers_url":"https://api.github.com/repos/edynox/dnf/stargazers","contributors_url":"https://api.github.com/repos/edynox/dnf/contributors","subscribers_url":"https://api.github.com/repos/edynox/dnf/subscribers","subscription_url":"https://api.github.com/repos/edynox/dnf/subscription","commits_url":"https://api.github.com/repos/edynox/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/edynox/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/edynox/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/edynox/dnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/edynox/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/edynox/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edynox/dnf/merges","archive_url":"https://api.github.com/repos/edynox/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edynox/dnf/downloads","issues_url":"https://api.github.com/repos/edynox/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/edynox/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/edynox/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/edynox/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edynox/dnf/labels{/name}","releases_url":"https://api.github.com/repos/edynox/dnf/releases{/id}","deployments_url":"https://api.github.com/repos/edynox/dnf/deployments","created_at":"2016-07-27T14:05:57Z","updated_at":"2016-10-22T11:06:13Z","pushed_at":"2017-02-11T12:20:57Z","git_url":"git://github.com/edynox/dnf.git","ssh_url":"git@github.com:edynox/dnf.git","clone_url":"https://github.com/edynox/dnf.git","svn_url":"https://github.com/edynox/dnf","homepage":"","size":37076,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"hif-swdb"}},"base":{"label":"rpm-software-management:master","ref":"master","sha":"9de161daecb13079e950529767337d92b241ed50","user":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"repo":{"id":3671909,"name":"dnf","full_name":"rpm-software-management/dnf","owner":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpm-software-management/dnf","description":"dnf is a package manager based on yum and libsolv","fork":false,"url":"https://api.github.com/repos/rpm-software-management/dnf","forks_url":"https://api.github.com/repos/rpm-software-management/dnf/forks","keys_url":"https://api.github.com/repos/rpm-software-management/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpm-software-management/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpm-software-management/dnf/teams","hooks_url":"https://api.github.com/repos/rpm-software-management/dnf/hooks","issue_events_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/rpm-software-management/dnf/events","assignees_url":"https://api.github.com/repos/rpm-software-management/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/rpm-software-management/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/rpm-software-management/dnf/tags","blobs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpm-software-management/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpm-software-management/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/rpm-software-management/dnf/languages","stargazers_url":"https://api.github.com/repos/rpm-software-management/dnf/stargazers","contributors_url":"https://api.github.com/repos/rpm-software-management/dnf/contributors","subscribers_url":"https://api.github.com/repos/rpm-software-management/dnf/subscribers","subscription_url":"https://api.github.com/repos/rpm-software-management/dnf/subscription","commits_url":"https://api.github.com/repos/rpm-software-management/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpm-software-management/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpm-software-management/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/rpm-software-management/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpm-software-management/dnf/merges","archive_url":"https://api.github.com/repos/rpm-software-management/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpm-software-management/dnf/downloads","issues_url":"https://api.github.com/repos/rpm-software-management/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/rpm-software-management/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/rpm-software-management/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpm-software-management/dnf/labels{/name}","releases_url":"https://api.github.com/repos/rpm-software-management/dnf/releases{/id}","deployments_url":"https://api.github.com/repos/rpm-software-management/dnf/deployments","created_at":"2012-03-09T15:31:09Z","updated_at":"2017-02-09T21:06:52Z","pushed_at":"2017-02-11T12:21:00Z","git_url":"git://github.com/rpm-software-management/dnf.git","ssh_url":"git@github.com:rpm-software-management/dnf.git","clone_url":"https://github.com/rpm-software-management/dnf.git","svn_url":"https://github.com/rpm-software-management/dnf","homepage":"","size":39255,"stargazers_count":381,"watchers_count":381,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":143,"mirror_url":null,"open_issues_count":17,"forks":143,"open_issues":17,"watchers":381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/630"},"issue":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/630"},"comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/rpm-software-management/dnf/statuses/ef6b74666ecd1aeb0c9f765cac3fdfca16a5635d"}}}}
{"actor":{"display_login":"dnf-bot"}}