{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/reps/issues/128","repository_url":"https://api.github.com/repos/devtools-html/reps","labels_url":"https://api.github.com/repos/devtools-html/reps/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/reps/issues/128/comments","events_url":"https://api.github.com/repos/devtools-html/reps/issues/128/events","html_url":"https://github.com/devtools-html/reps/pull/128","id":221820189,"number":128,"title":"Use preview.isConnected on node to check if it is in DOM tree.","user":{"login":"nchevobbe","id":578107,"avatar_url":"https://avatars0.githubusercontent.com/u/578107?v=3","gravatar_id":"","url":"https://api.github.com/users/nchevobbe","html_url":"https://github.com/nchevobbe","followers_url":"https://api.github.com/users/nchevobbe/followers","following_url":"https://api.github.com/users/nchevobbe/following{/other_user}","gists_url":"https://api.github.com/users/nchevobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/nchevobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nchevobbe/subscriptions","organizations_url":"https://api.github.com/users/nchevobbe/orgs","repos_url":"https://api.github.com/users/nchevobbe/repos","events_url":"https://api.github.com/users/nchevobbe/events{/privacy}","received_events_url":"https://api.github.com/users/nchevobbe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-14T14:30:42Z","updated_at":"2017-04-18T09:08:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/devtools-html/reps/pulls/128","html_url":"https://github.com/devtools-html/reps/pull/128","diff_url":"https://github.com/devtools-html/reps/pull/128.diff","patch_url":"https://github.com/devtools-html/reps/pull/128.patch"},"body":"Fixes #115\r\n\r\nWith https://bugzilla.mozilla.org/show_bug.cgi\\?id\\=1347490 we added a property to the\r\nNode ObjectActor which states if the node is in the DOM tree or not.\r\nThis we can simplify our code and get rid of the attachedActorIds thing we were using\r\npreviously.\r\nNow consumer would only have to pass an onInspectIconClick to handle the icon."},"comment":{"url":"https://api.github.com/repos/devtools-html/reps/issues/comments/294738987","html_url":"https://github.com/devtools-html/reps/pull/128#issuecomment-294738987","issue_url":"https://api.github.com/repos/devtools-html/reps/issues/128","id":294738987,"user":{"login":"nchevobbe","id":578107,"avatar_url":"https://avatars0.githubusercontent.com/u/578107?v=3","gravatar_id":"","url":"https://api.github.com/users/nchevobbe","html_url":"https://github.com/nchevobbe","followers_url":"https://api.github.com/users/nchevobbe/followers","following_url":"https://api.github.com/users/nchevobbe/following{/other_user}","gists_url":"https://api.github.com/users/nchevobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/nchevobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nchevobbe/subscriptions","organizations_url":"https://api.github.com/users/nchevobbe/orgs","repos_url":"https://api.github.com/users/nchevobbe/repos","events_url":"https://api.github.com/users/nchevobbe/events{/privacy}","received_events_url":"https://api.github.com/users/nchevobbe/received_events","type":"User","site_admin":false},"created_at":"2017-04-18T09:08:24Z","updated_at":"2017-04-18T09:08:24Z","body":"Thanks for checking and filing bugs :) \r\nI forgot that there were a front to grip conversion on the inspector.\r\n\r\n> FYI there is still an old reference to attached nodes in src/launchpad/components/Result.js (although it's \"attachedNodeFrontsByActor\" so I guess it comes from an even earlier iteration of this :) )\r\n\r\nOops, I'll remove it, thanks !"}}
{"actor":{"display_login":"nchevobbe"}}