{"action":"closed","issue":{"url":"https://api.github.com/repos/facebook/react/issues/9876","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/9876/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/9876/comments","events_url":"https://api.github.com/repos/facebook/react/issues/9876/events","html_url":"https://github.com/facebook/react/issues/9876","id":234085850,"number":9876,"title":"Order of linting and prettier in contributing docs","user":{"login":"wdhorton","id":13503072,"avatar_url":"https://avatars2.githubusercontent.com/u/13503072?v=3","gravatar_id":"","url":"https://api.github.com/users/wdhorton","html_url":"https://github.com/wdhorton","followers_url":"https://api.github.com/users/wdhorton/followers","following_url":"https://api.github.com/users/wdhorton/following{/other_user}","gists_url":"https://api.github.com/users/wdhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/wdhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdhorton/subscriptions","organizations_url":"https://api.github.com/users/wdhorton/orgs","repos_url":"https://api.github.com/users/wdhorton/repos","events_url":"https://api.github.com/users/wdhorton/events{/privacy}","received_events_url":"https://api.github.com/users/wdhorton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-06-07T03:56:35Z","updated_at":"2017-07-11T12:07:54Z","closed_at":"2017-07-11T12:07:54Z","body":"**Do you want to request a *feature* or report a *bug*?**\r\nThis is more of a documentation discussion\r\n\r\n**What is the current behavior?**\r\nCurrently, the contributing guide lists the lint step before running prettier. For example, `.github/PULL_REQUEST_TEMPLATE.md` says:\r\n```\r\n5. Make sure your code lints (`npm run lint`).\r\n6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).\r\n```\r\n\r\n**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).**\r\n\r\n**What is the expected behavior?**\r\nI think it would make more sense to run prettier first, since it can automatically get rid of certain lint errors (like single-quotes or comma-dangle). A first-time contributor following the steps in order might waste time fixing things manually at the lint step before proceeding to the formatting step.\r\n\r\n**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**\r\nN/A"}}
{"actor":{"display_login":"gaearon"}}