{"action":"created","comment":{"url":"https://api.github.com/repos/alimanfoo/zarr/pulls/comments/153376741","pull_request_review_id":79371977,"id":153376741,"diff_hunk":"@@ -798,7 +799,7 @@ class TestDBMStoreNDBM(TestDBMStore):\n \n             def create_store(self):\n                 path = tempfile.mktemp(suffix='.ndbm')\n-                atexit.register(os.remove, path)\n+                atexit_rmglob(path + '*')","path":"zarr/tests/test_storage.py","position":28,"original_position":28,"commit_id":"79374af4e3288230bd9e913cf50d998f90e9daa3","original_commit_id":"79374af4e3288230bd9e913cf50d998f90e9daa3","user":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"body":"Yes, that happens within atexit_rmglob.","created_at":"2017-11-28T01:57:29Z","updated_at":"2017-11-28T01:57:29Z","html_url":"https://github.com/alimanfoo/zarr/pull/207#discussion_r153376741","pull_request_url":"https://api.github.com/repos/alimanfoo/zarr/pulls/207","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/alimanfoo/zarr/pulls/comments/153376741"},"html":{"href":"https://github.com/alimanfoo/zarr/pull/207#discussion_r153376741"},"pull_request":{"href":"https://api.github.com/repos/alimanfoo/zarr/pulls/207"}},"in_reply_to_id":153372493},"pull_request":{"url":"https://api.github.com/repos/alimanfoo/zarr/pulls/207","id":154949245,"html_url":"https://github.com/alimanfoo/zarr/pull/207","diff_url":"https://github.com/alimanfoo/zarr/pull/207.diff","patch_url":"https://github.com/alimanfoo/zarr/pull/207.patch","issue_url":"https://api.github.com/repos/alimanfoo/zarr/issues/207","number":207,"state":"closed","locked":false,"title":"Clean up dbm files properly","user":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"body":"Resolves #205","created_at":"2017-11-28T00:14:19Z","updated_at":"2017-11-28T01:57:29Z","closed_at":"2017-11-28T00:47:42Z","merged_at":"2017-11-28T00:47:42Z","merge_commit_sha":"43523a4d508f533795f46ea352fc44e3ef1e2c96","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/alimanfoo/zarr/milestones/5","html_url":"https://github.com/alimanfoo/zarr/milestone/5","labels_url":"https://api.github.com/repos/alimanfoo/zarr/milestones/5/labels","id":2199042,"number":5,"title":"v2.2","description":"","creator":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":77,"state":"open","created_at":"2016-12-15T15:55:54Z","updated_at":"2017-11-28T01:53:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/alimanfoo/zarr/pulls/207/commits","review_comments_url":"https://api.github.com/repos/alimanfoo/zarr/pulls/207/comments","review_comment_url":"https://api.github.com/repos/alimanfoo/zarr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alimanfoo/zarr/issues/207/comments","statuses_url":"https://api.github.com/repos/alimanfoo/zarr/statuses/79374af4e3288230bd9e913cf50d998f90e9daa3","head":{"label":"alimanfoo:dbm-test-cleanup","ref":"dbm-test-cleanup","sha":"79374af4e3288230bd9e913cf50d998f90e9daa3","user":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"repo":{"id":48049137,"name":"zarr","full_name":"alimanfoo/zarr","owner":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alimanfoo/zarr","description":"An implementation of chunked, compressed, N-dimensional arrays for Python.","fork":false,"url":"https://api.github.com/repos/alimanfoo/zarr","forks_url":"https://api.github.com/repos/alimanfoo/zarr/forks","keys_url":"https://api.github.com/repos/alimanfoo/zarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alimanfoo/zarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alimanfoo/zarr/teams","hooks_url":"https://api.github.com/repos/alimanfoo/zarr/hooks","issue_events_url":"https://api.github.com/repos/alimanfoo/zarr/issues/events{/number}","events_url":"https://api.github.com/repos/alimanfoo/zarr/events","assignees_url":"https://api.github.com/repos/alimanfoo/zarr/assignees{/user}","branches_url":"https://api.github.com/repos/alimanfoo/zarr/branches{/branch}","tags_url":"https://api.github.com/repos/alimanfoo/zarr/tags","blobs_url":"https://api.github.com/repos/alimanfoo/zarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alimanfoo/zarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alimanfoo/zarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/alimanfoo/zarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alimanfoo/zarr/statuses/{sha}","languages_url":"https://api.github.com/repos/alimanfoo/zarr/languages","stargazers_url":"https://api.github.com/repos/alimanfoo/zarr/stargazers","contributors_url":"https://api.github.com/repos/alimanfoo/zarr/contributors","subscribers_url":"https://api.github.com/repos/alimanfoo/zarr/subscribers","subscription_url":"https://api.github.com/repos/alimanfoo/zarr/subscription","commits_url":"https://api.github.com/repos/alimanfoo/zarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/alimanfoo/zarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/alimanfoo/zarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/alimanfoo/zarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/alimanfoo/zarr/contents/{+path}","compare_url":"https://api.github.com/repos/alimanfoo/zarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alimanfoo/zarr/merges","archive_url":"https://api.github.com/repos/alimanfoo/zarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alimanfoo/zarr/downloads","issues_url":"https://api.github.com/repos/alimanfoo/zarr/issues{/number}","pulls_url":"https://api.github.com/repos/alimanfoo/zarr/pulls{/number}","milestones_url":"https://api.github.com/repos/alimanfoo/zarr/milestones{/number}","notifications_url":"https://api.github.com/repos/alimanfoo/zarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alimanfoo/zarr/labels{/name}","releases_url":"https://api.github.com/repos/alimanfoo/zarr/releases{/id}","deployments_url":"https://api.github.com/repos/alimanfoo/zarr/deployments","created_at":"2015-12-15T14:49:40Z","updated_at":"2017-11-27T16:03:45Z","pushed_at":"2017-11-28T00:47:47Z","git_url":"git://github.com/alimanfoo/zarr.git","ssh_url":"git@github.com:alimanfoo/zarr.git","clone_url":"https://github.com/alimanfoo/zarr.git","svn_url":"https://github.com/alimanfoo/zarr","homepage":"","size":12028,"stargazers_count":114,"watchers_count":114,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":36,"forks":22,"open_issues":36,"watchers":114,"default_branch":"master"}},"base":{"label":"alimanfoo:master","ref":"master","sha":"11fc028a9a9c19c0a57b5d9f8d2daedbd61707cb","user":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"repo":{"id":48049137,"name":"zarr","full_name":"alimanfoo/zarr","owner":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alimanfoo/zarr","description":"An implementation of chunked, compressed, N-dimensional arrays for Python.","fork":false,"url":"https://api.github.com/repos/alimanfoo/zarr","forks_url":"https://api.github.com/repos/alimanfoo/zarr/forks","keys_url":"https://api.github.com/repos/alimanfoo/zarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alimanfoo/zarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alimanfoo/zarr/teams","hooks_url":"https://api.github.com/repos/alimanfoo/zarr/hooks","issue_events_url":"https://api.github.com/repos/alimanfoo/zarr/issues/events{/number}","events_url":"https://api.github.com/repos/alimanfoo/zarr/events","assignees_url":"https://api.github.com/repos/alimanfoo/zarr/assignees{/user}","branches_url":"https://api.github.com/repos/alimanfoo/zarr/branches{/branch}","tags_url":"https://api.github.com/repos/alimanfoo/zarr/tags","blobs_url":"https://api.github.com/repos/alimanfoo/zarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alimanfoo/zarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alimanfoo/zarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/alimanfoo/zarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alimanfoo/zarr/statuses/{sha}","languages_url":"https://api.github.com/repos/alimanfoo/zarr/languages","stargazers_url":"https://api.github.com/repos/alimanfoo/zarr/stargazers","contributors_url":"https://api.github.com/repos/alimanfoo/zarr/contributors","subscribers_url":"https://api.github.com/repos/alimanfoo/zarr/subscribers","subscription_url":"https://api.github.com/repos/alimanfoo/zarr/subscription","commits_url":"https://api.github.com/repos/alimanfoo/zarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/alimanfoo/zarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/alimanfoo/zarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/alimanfoo/zarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/alimanfoo/zarr/contents/{+path}","compare_url":"https://api.github.com/repos/alimanfoo/zarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alimanfoo/zarr/merges","archive_url":"https://api.github.com/repos/alimanfoo/zarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alimanfoo/zarr/downloads","issues_url":"https://api.github.com/repos/alimanfoo/zarr/issues{/number}","pulls_url":"https://api.github.com/repos/alimanfoo/zarr/pulls{/number}","milestones_url":"https://api.github.com/repos/alimanfoo/zarr/milestones{/number}","notifications_url":"https://api.github.com/repos/alimanfoo/zarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alimanfoo/zarr/labels{/name}","releases_url":"https://api.github.com/repos/alimanfoo/zarr/releases{/id}","deployments_url":"https://api.github.com/repos/alimanfoo/zarr/deployments","created_at":"2015-12-15T14:49:40Z","updated_at":"2017-11-27T16:03:45Z","pushed_at":"2017-11-28T00:47:47Z","git_url":"git://github.com/alimanfoo/zarr.git","ssh_url":"git@github.com:alimanfoo/zarr.git","clone_url":"https://github.com/alimanfoo/zarr.git","svn_url":"https://github.com/alimanfoo/zarr","homepage":"","size":12028,"stargazers_count":114,"watchers_count":114,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":36,"forks":22,"open_issues":36,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alimanfoo/zarr/pulls/207"},"html":{"href":"https://github.com/alimanfoo/zarr/pull/207"},"issue":{"href":"https://api.github.com/repos/alimanfoo/zarr/issues/207"},"comments":{"href":"https://api.github.com/repos/alimanfoo/zarr/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/alimanfoo/zarr/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/alimanfoo/zarr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alimanfoo/zarr/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/alimanfoo/zarr/statuses/79374af4e3288230bd9e913cf50d998f90e9daa3"}},"author_association":"OWNER"}}
{"actor":{"display_login":"alimanfoo"}}