{"action":"created","issue":{"url":"https://api.github.com/repos/Riverside-Software/sonar-openedge/issues/365","repository_url":"https://api.github.com/repos/Riverside-Software/sonar-openedge","labels_url":"https://api.github.com/repos/Riverside-Software/sonar-openedge/issues/365/labels{/name}","comments_url":"https://api.github.com/repos/Riverside-Software/sonar-openedge/issues/365/comments","events_url":"https://api.github.com/repos/Riverside-Software/sonar-openedge/issues/365/events","html_url":"https://github.com/Riverside-Software/sonar-openedge/issues/365","id":255925094,"number":365,"title":"FP on NO-UNDO not specified in temp-table declaration","user":{"login":"stefandrissen","id":5297464,"avatar_url":"https://avatars0.githubusercontent.com/u/5297464?v=4","gravatar_id":"","url":"https://api.github.com/users/stefandrissen","html_url":"https://github.com/stefandrissen","followers_url":"https://api.github.com/users/stefandrissen/followers","following_url":"https://api.github.com/users/stefandrissen/following{/other_user}","gists_url":"https://api.github.com/users/stefandrissen/gists{/gist_id}","starred_url":"https://api.github.com/users/stefandrissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefandrissen/subscriptions","organizations_url":"https://api.github.com/users/stefandrissen/orgs","repos_url":"https://api.github.com/users/stefandrissen/repos","events_url":"https://api.github.com/users/stefandrissen/events{/privacy}","received_events_url":"https://api.github.com/users/stefandrissen/received_events","type":"User","site_admin":false},"labels":[{"id":313462585,"url":"https://api.github.com/repos/Riverside-Software/sonar-openedge/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-09-07T12:47:56Z","updated_at":"2017-09-13T20:16:24Z","closed_at":null,"author_association":"NONE","body":"When a temp-table is defined LIKE a NO-UNDO temp-table it is also NO-UNDO.\r\n````\r\ndefine temp-table ttone no-undo field cc as char.\r\n\r\ndefine temp-table tttwo like ttone.\r\n\r\ndefine temp-table ttthree undo like ttone.\r\n\r\n\r\nmessage \r\n   temp-table tttwo:handle:undo skip\r\n   temp-table ttthree:handle:undo    \r\nview-as alert-box.\r\n````"},"comment":{"url":"https://api.github.com/repos/Riverside-Software/sonar-openedge/issues/comments/329284222","html_url":"https://github.com/Riverside-Software/sonar-openedge/issues/365#issuecomment-329284222","issue_url":"https://api.github.com/repos/Riverside-Software/sonar-openedge/issues/365","id":329284222,"user":{"login":"stefandrissen","id":5297464,"avatar_url":"https://avatars0.githubusercontent.com/u/5297464?v=4","gravatar_id":"","url":"https://api.github.com/users/stefandrissen","html_url":"https://github.com/stefandrissen","followers_url":"https://api.github.com/users/stefandrissen/followers","following_url":"https://api.github.com/users/stefandrissen/following{/other_user}","gists_url":"https://api.github.com/users/stefandrissen/gists{/gist_id}","starred_url":"https://api.github.com/users/stefandrissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefandrissen/subscriptions","organizations_url":"https://api.github.com/users/stefandrissen/orgs","repos_url":"https://api.github.com/users/stefandrissen/repos","events_url":"https://api.github.com/users/stefandrissen/events{/privacy}","received_events_url":"https://api.github.com/users/stefandrissen/received_events","type":"User","site_admin":false},"created_at":"2017-09-13T20:16:24Z","updated_at":"2017-09-13T20:16:24Z","author_association":"NONE","body":"A temp-table that is defined like another inherits that ones undo status. That parent temp-table will already have flagged an undo warning (unless overridden).  \r\n\r\nRelying on defaults is part of knowing your language. I just cringe when I see statements like:\r\n\r\nDEFINE VARIABLE lok AS LOGICAL NO-UNDO INITIAL FALSE.\r\n\r\nIf I were to exaggerate, then I could say this should also be:\r\n\r\nDEFINE VARIABLE lok AS LOGICAL NO-UNDO INITIAL FALSE FORMAT \"yes/no\" COLUMN-LABEL \"lok\" LABEL \"lok\" HELP-TEXT ? VALIDATE-TEXT ? etc\r\n\r\nAdding all these defaults only, imho, adds noise to the code so that you miss the tree in the woods.\r\n\r\nBut an option is fine (as long as it defaults to sensible behavior ;-))"}}
{"actor":{"display_login":"stefandrissen"}}