{"action":"created","comment":{"url":"https://api.github.com/repos/go-gitea/git/pulls/comments/110513935","pull_request_review_id":31697308,"id":110513935,"diff_hunk":"@@ -70,7 +70,11 @@ func (c *Command) RunInDirTimeoutPipeline(timeout time.Duration, dir string, std\n \t\treturn err\n \t}\n \n-\treturn cmd.Wait()\n+\tif err := cmd.Wait(); err == nil {\n+\t\treturn nil\n+\t}\n+\n+\treturn ctx.Err()","path":"command.go","position":9,"original_position":9,"commit_id":"199484c748a0a41b5c0a3d126fa68849edb5cf40","original_commit_id":"199484c748a0a41b5c0a3d126fa68849edb5cf40","user":{"login":"typeless","id":2606021,"avatar_url":"https://avatars2.githubusercontent.com/u/2606021?v=3","gravatar_id":"","url":"https://api.github.com/users/typeless","html_url":"https://github.com/typeless","followers_url":"https://api.github.com/users/typeless/followers","following_url":"https://api.github.com/users/typeless/following{/other_user}","gists_url":"https://api.github.com/users/typeless/gists{/gist_id}","starred_url":"https://api.github.com/users/typeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typeless/subscriptions","organizations_url":"https://api.github.com/users/typeless/orgs","repos_url":"https://api.github.com/users/typeless/repos","events_url":"https://api.github.com/users/typeless/events{/privacy}","received_events_url":"https://api.github.com/users/typeless/received_events","type":"User","site_admin":false},"body":"Do you mean logging the error of Wait and return the error of ctx.Err() or something else?","created_at":"2017-04-08T09:03:36Z","updated_at":"2017-04-08T09:03:36Z","html_url":"https://github.com/go-gitea/git/pull/44#discussion_r110513935","pull_request_url":"https://api.github.com/repos/go-gitea/git/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/go-gitea/git/pulls/comments/110513935"},"html":{"href":"https://github.com/go-gitea/git/pull/44#discussion_r110513935"},"pull_request":{"href":"https://api.github.com/repos/go-gitea/git/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/go-gitea/git/pulls/44","id":114935313,"html_url":"https://github.com/go-gitea/git/pull/44","diff_url":"https://github.com/go-gitea/git/pull/44.diff","patch_url":"https://github.com/go-gitea/git/pull/44.patch","issue_url":"https://api.github.com/repos/go-gitea/git/issues/44","number":44,"state":"open","locked":false,"title":"Rectify error handling","user":{"login":"typeless","id":2606021,"avatar_url":"https://avatars2.githubusercontent.com/u/2606021?v=3","gravatar_id":"","url":"https://api.github.com/users/typeless","html_url":"https://github.com/typeless","followers_url":"https://api.github.com/users/typeless/followers","following_url":"https://api.github.com/users/typeless/following{/other_user}","gists_url":"https://api.github.com/users/typeless/gists{/gist_id}","starred_url":"https://api.github.com/users/typeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typeless/subscriptions","organizations_url":"https://api.github.com/users/typeless/orgs","repos_url":"https://api.github.com/users/typeless/repos","events_url":"https://api.github.com/users/typeless/events{/privacy}","received_events_url":"https://api.github.com/users/typeless/received_events","type":"User","site_admin":false},"body":"For #42 and #41 \r\n\r\nSanitizing the error handling a little bit, now it looks nicer.","created_at":"2017-04-08T07:13:31Z","updated_at":"2017-04-08T09:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8209bcf81a7aa83fb576b74421c6d95c67821b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-gitea/git/pulls/44/commits","review_comments_url":"https://api.github.com/repos/go-gitea/git/pulls/44/comments","review_comment_url":"https://api.github.com/repos/go-gitea/git/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-gitea/git/issues/44/comments","statuses_url":"https://api.github.com/repos/go-gitea/git/statuses/199484c748a0a41b5c0a3d126fa68849edb5cf40","head":{"label":"typeless:rectify-error-handling","ref":"rectify-error-handling","sha":"199484c748a0a41b5c0a3d126fa68849edb5cf40","user":{"login":"typeless","id":2606021,"avatar_url":"https://avatars2.githubusercontent.com/u/2606021?v=3","gravatar_id":"","url":"https://api.github.com/users/typeless","html_url":"https://github.com/typeless","followers_url":"https://api.github.com/users/typeless/followers","following_url":"https://api.github.com/users/typeless/following{/other_user}","gists_url":"https://api.github.com/users/typeless/gists{/gist_id}","starred_url":"https://api.github.com/users/typeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typeless/subscriptions","organizations_url":"https://api.github.com/users/typeless/orgs","repos_url":"https://api.github.com/users/typeless/repos","events_url":"https://api.github.com/users/typeless/events{/privacy}","received_events_url":"https://api.github.com/users/typeless/received_events","type":"User","site_admin":false},"repo":{"id":87519293,"name":"git","full_name":"typeless/git","owner":{"login":"typeless","id":2606021,"avatar_url":"https://avatars2.githubusercontent.com/u/2606021?v=3","gravatar_id":"","url":"https://api.github.com/users/typeless","html_url":"https://github.com/typeless","followers_url":"https://api.github.com/users/typeless/followers","following_url":"https://api.github.com/users/typeless/following{/other_user}","gists_url":"https://api.github.com/users/typeless/gists{/gist_id}","starred_url":"https://api.github.com/users/typeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typeless/subscriptions","organizations_url":"https://api.github.com/users/typeless/orgs","repos_url":"https://api.github.com/users/typeless/repos","events_url":"https://api.github.com/users/typeless/events{/privacy}","received_events_url":"https://api.github.com/users/typeless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/typeless/git","description":"A Go module for Git access through shell","fork":true,"url":"https://api.github.com/repos/typeless/git","forks_url":"https://api.github.com/repos/typeless/git/forks","keys_url":"https://api.github.com/repos/typeless/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typeless/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typeless/git/teams","hooks_url":"https://api.github.com/repos/typeless/git/hooks","issue_events_url":"https://api.github.com/repos/typeless/git/issues/events{/number}","events_url":"https://api.github.com/repos/typeless/git/events","assignees_url":"https://api.github.com/repos/typeless/git/assignees{/user}","branches_url":"https://api.github.com/repos/typeless/git/branches{/branch}","tags_url":"https://api.github.com/repos/typeless/git/tags","blobs_url":"https://api.github.com/repos/typeless/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typeless/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typeless/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/typeless/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typeless/git/statuses/{sha}","languages_url":"https://api.github.com/repos/typeless/git/languages","stargazers_url":"https://api.github.com/repos/typeless/git/stargazers","contributors_url":"https://api.github.com/repos/typeless/git/contributors","subscribers_url":"https://api.github.com/repos/typeless/git/subscribers","subscription_url":"https://api.github.com/repos/typeless/git/subscription","commits_url":"https://api.github.com/repos/typeless/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/typeless/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/typeless/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/typeless/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/typeless/git/contents/{+path}","compare_url":"https://api.github.com/repos/typeless/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typeless/git/merges","archive_url":"https://api.github.com/repos/typeless/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typeless/git/downloads","issues_url":"https://api.github.com/repos/typeless/git/issues{/number}","pulls_url":"https://api.github.com/repos/typeless/git/pulls{/number}","milestones_url":"https://api.github.com/repos/typeless/git/milestones{/number}","notifications_url":"https://api.github.com/repos/typeless/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typeless/git/labels{/name}","releases_url":"https://api.github.com/repos/typeless/git/releases{/id}","deployments_url":"https://api.github.com/repos/typeless/git/deployments","created_at":"2017-04-07T07:44:49Z","updated_at":"2017-04-07T07:44:51Z","pushed_at":"2017-04-08T07:11:49Z","git_url":"git://github.com/typeless/git.git","ssh_url":"git@github.com:typeless/git.git","clone_url":"https://github.com/typeless/git.git","svn_url":"https://github.com/typeless/git","homepage":"http://gitea.io","size":270,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-gitea:master","ref":"master","sha":"d5e562cdbca86b8d149b91d617ead2edce7dbd09","user":{"login":"go-gitea","id":12724356,"avatar_url":"https://avatars2.githubusercontent.com/u/12724356?v=3","gravatar_id":"","url":"https://api.github.com/users/go-gitea","html_url":"https://github.com/go-gitea","followers_url":"https://api.github.com/users/go-gitea/followers","following_url":"https://api.github.com/users/go-gitea/following{/other_user}","gists_url":"https://api.github.com/users/go-gitea/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gitea/subscriptions","organizations_url":"https://api.github.com/users/go-gitea/orgs","repos_url":"https://api.github.com/users/go-gitea/repos","events_url":"https://api.github.com/users/go-gitea/events{/privacy}","received_events_url":"https://api.github.com/users/go-gitea/received_events","type":"Organization","site_admin":false},"repo":{"id":72980210,"name":"git","full_name":"go-gitea/git","owner":{"login":"go-gitea","id":12724356,"avatar_url":"https://avatars2.githubusercontent.com/u/12724356?v=3","gravatar_id":"","url":"https://api.github.com/users/go-gitea","html_url":"https://github.com/go-gitea","followers_url":"https://api.github.com/users/go-gitea/followers","following_url":"https://api.github.com/users/go-gitea/following{/other_user}","gists_url":"https://api.github.com/users/go-gitea/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gitea/subscriptions","organizations_url":"https://api.github.com/users/go-gitea/orgs","repos_url":"https://api.github.com/users/go-gitea/repos","events_url":"https://api.github.com/users/go-gitea/events{/privacy}","received_events_url":"https://api.github.com/users/go-gitea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-gitea/git","description":"A Go module for Git access through shell","fork":true,"url":"https://api.github.com/repos/go-gitea/git","forks_url":"https://api.github.com/repos/go-gitea/git/forks","keys_url":"https://api.github.com/repos/go-gitea/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-gitea/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-gitea/git/teams","hooks_url":"https://api.github.com/repos/go-gitea/git/hooks","issue_events_url":"https://api.github.com/repos/go-gitea/git/issues/events{/number}","events_url":"https://api.github.com/repos/go-gitea/git/events","assignees_url":"https://api.github.com/repos/go-gitea/git/assignees{/user}","branches_url":"https://api.github.com/repos/go-gitea/git/branches{/branch}","tags_url":"https://api.github.com/repos/go-gitea/git/tags","blobs_url":"https://api.github.com/repos/go-gitea/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-gitea/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-gitea/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-gitea/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-gitea/git/statuses/{sha}","languages_url":"https://api.github.com/repos/go-gitea/git/languages","stargazers_url":"https://api.github.com/repos/go-gitea/git/stargazers","contributors_url":"https://api.github.com/repos/go-gitea/git/contributors","subscribers_url":"https://api.github.com/repos/go-gitea/git/subscribers","subscription_url":"https://api.github.com/repos/go-gitea/git/subscription","commits_url":"https://api.github.com/repos/go-gitea/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-gitea/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-gitea/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-gitea/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-gitea/git/contents/{+path}","compare_url":"https://api.github.com/repos/go-gitea/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-gitea/git/merges","archive_url":"https://api.github.com/repos/go-gitea/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-gitea/git/downloads","issues_url":"https://api.github.com/repos/go-gitea/git/issues{/number}","pulls_url":"https://api.github.com/repos/go-gitea/git/pulls{/number}","milestones_url":"https://api.github.com/repos/go-gitea/git/milestones{/number}","notifications_url":"https://api.github.com/repos/go-gitea/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-gitea/git/labels{/name}","releases_url":"https://api.github.com/repos/go-gitea/git/releases{/id}","deployments_url":"https://api.github.com/repos/go-gitea/git/deployments","created_at":"2016-11-06T09:10:38Z","updated_at":"2017-04-04T07:33:12Z","pushed_at":"2017-04-08T07:13:32Z","git_url":"git://github.com/go-gitea/git.git","ssh_url":"git@github.com:go-gitea/git.git","clone_url":"https://github.com/go-gitea/git.git","svn_url":"https://github.com/go-gitea/git","homepage":"http://gitea.io","size":264,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-gitea/git/pulls/44"},"html":{"href":"https://github.com/go-gitea/git/pull/44"},"issue":{"href":"https://api.github.com/repos/go-gitea/git/issues/44"},"comments":{"href":"https://api.github.com/repos/go-gitea/git/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/go-gitea/git/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/go-gitea/git/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-gitea/git/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/go-gitea/git/statuses/199484c748a0a41b5c0a3d126fa68849edb5cf40"}}}}
{"actor":{"display_login":"typeless"}}