{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-ios-driver/pulls/comments/148527551","pull_request_review_id":73781511,"id":148527551,"diff_hunk":"@@ -27,7 +27,11 @@ commands.getDeviceTime = async function () {\n       stdout = stdout.trim();\n       try {\n         let date = new Date(stdout);\n-        return date.toString();\n+        let dateStr = date.toString();\n+        if (dateStr === 'Invalid Date') {\n+          throw new Error('Unable to parse idevicedate output');","path":"lib/commands/general.js","position":7,"original_position":7,"commit_id":"e2f329fea666d3fe383809d7fd0dbf62d0e70252","original_commit_id":"e2f329fea666d3fe383809d7fd0dbf62d0e70252","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"should we also print the actual output in the error message?","created_at":"2017-11-02T13:12:34Z","updated_at":"2017-11-02T13:12:34Z","html_url":"https://github.com/appium/appium-ios-driver/pull/254#discussion_r148527551","pull_request_url":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-ios-driver/pulls/comments/148527551"},"html":{"href":"https://github.com/appium/appium-ios-driver/pull/254#discussion_r148527551"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254","id":150286415,"html_url":"https://github.com/appium/appium-ios-driver/pull/254","diff_url":"https://github.com/appium/appium-ios-driver/pull/254.diff","patch_url":"https://github.com/appium/appium-ios-driver/pull/254.patch","issue_url":"https://api.github.com/repos/appium/appium-ios-driver/issues/254","number":254,"state":"open","locked":false,"title":"Make sure we return something useful from getting the date","user":{"login":"imurchie","id":2614354,"avatar_url":"https://avatars2.githubusercontent.com/u/2614354?v=4","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false},"body":"If we can't parse the date string from `idevicedate`, return something useful (i.e., the output itself).\r\n\r\nSee https://github.com/appium/appium/issues/7835","created_at":"2017-11-02T13:10:24Z","updated_at":"2017-11-02T13:12:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf210416a03d00cae64f6bab0430c3ed6214c83","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254/commits","review_comments_url":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254/comments","review_comment_url":"https://api.github.com/repos/appium/appium-ios-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-ios-driver/issues/254/comments","statuses_url":"https://api.github.com/repos/appium/appium-ios-driver/statuses/e2f329fea666d3fe383809d7fd0dbf62d0e70252","head":{"label":"appium:isaac-date","ref":"isaac-date","sha":"e2f329fea666d3fe383809d7fd0dbf62d0e70252","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":39789366,"name":"appium-ios-driver","full_name":"appium/appium-ios-driver","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-ios-driver","description":"The iOS driver for the new appium.","fork":false,"url":"https://api.github.com/repos/appium/appium-ios-driver","forks_url":"https://api.github.com/repos/appium/appium-ios-driver/forks","keys_url":"https://api.github.com/repos/appium/appium-ios-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-ios-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-ios-driver/teams","hooks_url":"https://api.github.com/repos/appium/appium-ios-driver/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-ios-driver/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-ios-driver/events","assignees_url":"https://api.github.com/repos/appium/appium-ios-driver/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-ios-driver/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-ios-driver/tags","blobs_url":"https://api.github.com/repos/appium/appium-ios-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-ios-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-ios-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-ios-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-ios-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-ios-driver/languages","stargazers_url":"https://api.github.com/repos/appium/appium-ios-driver/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-ios-driver/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-ios-driver/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-ios-driver/subscription","commits_url":"https://api.github.com/repos/appium/appium-ios-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-ios-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-ios-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-ios-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-ios-driver/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-ios-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-ios-driver/merges","archive_url":"https://api.github.com/repos/appium/appium-ios-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-ios-driver/downloads","issues_url":"https://api.github.com/repos/appium/appium-ios-driver/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-ios-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-ios-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-ios-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-ios-driver/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-ios-driver/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-ios-driver/deployments","created_at":"2015-07-27T17:54:32Z","updated_at":"2017-11-01T08:20:07Z","pushed_at":"2017-11-02T13:10:25Z","git_url":"git://github.com/appium/appium-ios-driver.git","ssh_url":"git@github.com:appium/appium-ios-driver.git","clone_url":"https://github.com/appium/appium-ios-driver.git","svn_url":"https://github.com/appium/appium-ios-driver","homepage":null,"size":29661,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":58,"open_issues":2,"watchers":51,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"e7d38ab5f02a1082fa0000ed4600fcd8976e9b6b","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":39789366,"name":"appium-ios-driver","full_name":"appium/appium-ios-driver","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-ios-driver","description":"The iOS driver for the new appium.","fork":false,"url":"https://api.github.com/repos/appium/appium-ios-driver","forks_url":"https://api.github.com/repos/appium/appium-ios-driver/forks","keys_url":"https://api.github.com/repos/appium/appium-ios-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-ios-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-ios-driver/teams","hooks_url":"https://api.github.com/repos/appium/appium-ios-driver/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-ios-driver/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-ios-driver/events","assignees_url":"https://api.github.com/repos/appium/appium-ios-driver/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-ios-driver/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-ios-driver/tags","blobs_url":"https://api.github.com/repos/appium/appium-ios-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-ios-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-ios-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-ios-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-ios-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-ios-driver/languages","stargazers_url":"https://api.github.com/repos/appium/appium-ios-driver/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-ios-driver/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-ios-driver/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-ios-driver/subscription","commits_url":"https://api.github.com/repos/appium/appium-ios-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-ios-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-ios-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-ios-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-ios-driver/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-ios-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-ios-driver/merges","archive_url":"https://api.github.com/repos/appium/appium-ios-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-ios-driver/downloads","issues_url":"https://api.github.com/repos/appium/appium-ios-driver/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-ios-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-ios-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-ios-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-ios-driver/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-ios-driver/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-ios-driver/deployments","created_at":"2015-07-27T17:54:32Z","updated_at":"2017-11-01T08:20:07Z","pushed_at":"2017-11-02T13:10:25Z","git_url":"git://github.com/appium/appium-ios-driver.git","ssh_url":"git@github.com:appium/appium-ios-driver.git","clone_url":"https://github.com/appium/appium-ios-driver.git","svn_url":"https://github.com/appium/appium-ios-driver","homepage":null,"size":29661,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":58,"open_issues":2,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254"},"html":{"href":"https://github.com/appium/appium-ios-driver/pull/254"},"issue":{"href":"https://api.github.com/repos/appium/appium-ios-driver/issues/254"},"comments":{"href":"https://api.github.com/repos/appium/appium-ios-driver/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-ios-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-ios-driver/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-ios-driver/statuses/e2f329fea666d3fe383809d7fd0dbf62d0e70252"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mykola-mokhnach"}}