{"action":"created","issue":{"url":"https://api.github.com/repos/dlang/dmd/issues/7315","repository_url":"https://api.github.com/repos/dlang/dmd","labels_url":"https://api.github.com/repos/dlang/dmd/issues/7315/labels{/name}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/7315/comments","events_url":"https://api.github.com/repos/dlang/dmd/issues/7315/events","html_url":"https://github.com/dlang/dmd/pull/7315","id":273769677,"number":7315,"title":"Fix Issue 17371 -  [REG 2.074.0] di generation broken for anonymous classes","user":{"login":"RazvanN7","id":22907766,"avatar_url":"https://avatars2.githubusercontent.com/u/22907766?v=4","gravatar_id":"","url":"https://api.github.com/users/RazvanN7","html_url":"https://github.com/RazvanN7","followers_url":"https://api.github.com/users/RazvanN7/followers","following_url":"https://api.github.com/users/RazvanN7/following{/other_user}","gists_url":"https://api.github.com/users/RazvanN7/gists{/gist_id}","starred_url":"https://api.github.com/users/RazvanN7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RazvanN7/subscriptions","organizations_url":"https://api.github.com/users/RazvanN7/orgs","repos_url":"https://api.github.com/users/RazvanN7/repos","events_url":"https://api.github.com/users/RazvanN7/events{/privacy}","received_events_url":"https://api.github.com/users/RazvanN7/received_events","type":"User","site_admin":false},"labels":[{"id":537492633,"url":"https://api.github.com/repos/dlang/dmd/labels/Bug%20Fix","name":"Bug Fix","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-11-14T12:09:04Z","updated_at":"2017-11-21T14:26:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/7315","html_url":"https://github.com/dlang/dmd/pull/7315","diff_url":"https://github.com/dlang/dmd/pull/7315.diff","patch_url":"https://github.com/dlang/dmd/pull/7315.patch"},"body":"The header generation takes into account if a class is anonymous by invoking the final method Dsymbol.isAnonymous. The specified method verifies if a symbol is anonymous by checking if the id is null, but when a class is instantiated with a null id, it generates one [1] making isAnonymous to report a wrong answer. The easiest way to fix this is to declare a new bool field (isanon) which is set to true when a null id is passed to the instantiation of a class declaration and the header generation can check for that field instead of the wrong isAnonymous method.\r\n\r\n[1] https://github.com/dlang/dmd/pull/5565/files#diff-ddbaa5e9ca3d5c90a425a9dfafaf1734R225"},"comment":{"url":"https://api.github.com/repos/dlang/dmd/issues/comments/346042121","html_url":"https://github.com/dlang/dmd/pull/7315#issuecomment-346042121","issue_url":"https://api.github.com/repos/dlang/dmd/issues/7315","id":346042121,"user":{"login":"andralex","id":566679,"avatar_url":"https://avatars1.githubusercontent.com/u/566679?v=4","gravatar_id":"","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false},"created_at":"2017-11-21T14:26:02Z","updated_at":"2017-11-21T14:26:02Z","author_association":"OWNER","body":"Putting mutually exclusive flags in an enum sounds like a good thing to do. \r\n\r\n> I also don't think we should touch inuse in this PR, it's unrelated to what's actually changed in this PR.\r\n\r\nWe have been erring on the side of bureaucracy lately. Clearly doing swaths of unrelated changes in one PR is unacceptable but I'll take a good small unrelated improvement with a PR. I don't want to police people into ultimately doing less work.\r\n\r\nIn this particular case, creating a new PR takes actually just a bit longer than asking said PR should be created. https://github.com/dlang/dmd/pull/7349"}}
{"actor":{"display_login":"andralex"}}