{"action":"created","comment":{"url":"https://api.github.com/repos/cuappdev/tcat.js/pulls/comments/137334447","pull_request_review_id":60987688,"id":137334447,"diff_hunk":"@@ -91,6 +92,37 @@ class GetRouteRouter extends AppDevRouter {\n       }\n     }\n \n+     const stopSummary = [];\n+     for (let i = 0; i <result.length; i++) {\n+       const r = result[i];\n+       const obj = {};\n+      if (i == 0 && r.startStop.name == \"START_WALKING\") {\n+        obj.name = \"Current Location\";\n+        obj.type = \"currentLocation\";\n+        obj.nextDirection = \"walk\";\n+        obj.busNumber = r.busNum;\n+      } else {\n+        obj.name = r.startStop.name;\n+        obj.busNumber = r.busNum;\n+      }\n+      if ((i + 1 < result.length) && (obj.nextDirection == null)) {\n+        if ((r.busNum != -1) && (r.busNum != null)) {","path":"src/routers/GetRouteRouter.js","position":26,"original_position":26,"commit_id":"abd93ba17fed8765e8ad5e9e51c986fa78e08af1","original_commit_id":"abd93ba17fed8765e8ad5e9e51c986fa78e08af1","user":{"login":"Jma353","id":10677768,"avatar_url":"https://avatars2.githubusercontent.com/u/10677768?v=4","gravatar_id":"","url":"https://api.github.com/users/Jma353","html_url":"https://github.com/Jma353","followers_url":"https://api.github.com/users/Jma353/followers","following_url":"https://api.github.com/users/Jma353/following{/other_user}","gists_url":"https://api.github.com/users/Jma353/gists{/gist_id}","starred_url":"https://api.github.com/users/Jma353/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jma353/subscriptions","organizations_url":"https://api.github.com/users/Jma353/orgs","repos_url":"https://api.github.com/users/Jma353/repos","events_url":"https://api.github.com/users/Jma353/events{/privacy}","received_events_url":"https://api.github.com/users/Jma353/received_events","type":"User","site_admin":false},"body":"`if (r.busNum && r.busNum !== -1) { ... }`","created_at":"2017-09-06T17:23:17Z","updated_at":"2017-09-06T17:23:17Z","html_url":"https://github.com/cuappdev/tcat.js/pull/11#discussion_r137334447","pull_request_url":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cuappdev/tcat.js/pulls/comments/137334447"},"html":{"href":"https://github.com/cuappdev/tcat.js/pull/11#discussion_r137334447"},"pull_request":{"href":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11","id":139616583,"html_url":"https://github.com/cuappdev/tcat.js/pull/11","diff_url":"https://github.com/cuappdev/tcat.js/pull/11.diff","patch_url":"https://github.com/cuappdev/tcat.js/pull/11.patch","issue_url":"https://api.github.com/repos/cuappdev/tcat.js/issues/11","number":11,"state":"open","locked":false,"title":"Sanjana/endpoints","user":{"login":"skaundinya15","id":20484936,"avatar_url":"https://avatars2.githubusercontent.com/u/20484936?v=4","gravatar_id":"","url":"https://api.github.com/users/skaundinya15","html_url":"https://github.com/skaundinya15","followers_url":"https://api.github.com/users/skaundinya15/followers","following_url":"https://api.github.com/users/skaundinya15/following{/other_user}","gists_url":"https://api.github.com/users/skaundinya15/gists{/gist_id}","starred_url":"https://api.github.com/users/skaundinya15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaundinya15/subscriptions","organizations_url":"https://api.github.com/users/skaundinya15/orgs","repos_url":"https://api.github.com/users/skaundinya15/repos","events_url":"https://api.github.com/users/skaundinya15/events{/privacy}","received_events_url":"https://api.github.com/users/skaundinya15/received_events","type":"User","site_admin":false},"body":"<img width=\"1274\" alt=\"sample endpoint\" src=\"https://user-images.githubusercontent.com/20484936/30124663-da650518-9303-11e7-9189-eb03a77fdd93.png\">\r\n\r\nI've attached the sample endpoint that I tested it with from the git issue. The way I constructed this as @Jma353 talked about on Sunday was that each route is bound by walking. So from the current location, the user walks, and from the end location the user walks. Further more, I thought it might be useful to redefine how the type place is used. So in my changes I made it such that the end destination is always going to be a place, even if the end destination is just a bus stop. I figured this might be easier to understand as otherwise it would be hard to distinguish if a user wants their end location to be a stop. As in the example endpoint in the git issue, the end location is a bus stop, but in my implementation I've treated it as a place so that it's indicative that the route has ended.","created_at":"2017-09-06T17:08:15Z","updated_at":"2017-09-06T17:23:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7473d4f80e84c7f9dd15e04b4c7fe28e14793e9a","assignee":{"login":"skaundinya15","id":20484936,"avatar_url":"https://avatars2.githubusercontent.com/u/20484936?v=4","gravatar_id":"","url":"https://api.github.com/users/skaundinya15","html_url":"https://github.com/skaundinya15","followers_url":"https://api.github.com/users/skaundinya15/followers","following_url":"https://api.github.com/users/skaundinya15/following{/other_user}","gists_url":"https://api.github.com/users/skaundinya15/gists{/gist_id}","starred_url":"https://api.github.com/users/skaundinya15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaundinya15/subscriptions","organizations_url":"https://api.github.com/users/skaundinya15/orgs","repos_url":"https://api.github.com/users/skaundinya15/repos","events_url":"https://api.github.com/users/skaundinya15/events{/privacy}","received_events_url":"https://api.github.com/users/skaundinya15/received_events","type":"User","site_admin":false},"assignees":[{"login":"skaundinya15","id":20484936,"avatar_url":"https://avatars2.githubusercontent.com/u/20484936?v=4","gravatar_id":"","url":"https://api.github.com/users/skaundinya15","html_url":"https://github.com/skaundinya15","followers_url":"https://api.github.com/users/skaundinya15/followers","following_url":"https://api.github.com/users/skaundinya15/following{/other_user}","gists_url":"https://api.github.com/users/skaundinya15/gists{/gist_id}","starred_url":"https://api.github.com/users/skaundinya15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaundinya15/subscriptions","organizations_url":"https://api.github.com/users/skaundinya15/orgs","repos_url":"https://api.github.com/users/skaundinya15/repos","events_url":"https://api.github.com/users/skaundinya15/events{/privacy}","received_events_url":"https://api.github.com/users/skaundinya15/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11/commits","review_comments_url":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11/comments","review_comment_url":"https://api.github.com/repos/cuappdev/tcat.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuappdev/tcat.js/issues/11/comments","statuses_url":"https://api.github.com/repos/cuappdev/tcat.js/statuses/abd93ba17fed8765e8ad5e9e51c986fa78e08af1","head":{"label":"cuappdev:sanjana/endpoints","ref":"sanjana/endpoints","sha":"abd93ba17fed8765e8ad5e9e51c986fa78e08af1","user":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":98824629,"name":"tcat.js","full_name":"cuappdev/tcat.js","owner":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuappdev/tcat.js","description":"TCAT JavaScript API","fork":false,"url":"https://api.github.com/repos/cuappdev/tcat.js","forks_url":"https://api.github.com/repos/cuappdev/tcat.js/forks","keys_url":"https://api.github.com/repos/cuappdev/tcat.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/tcat.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/tcat.js/teams","hooks_url":"https://api.github.com/repos/cuappdev/tcat.js/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/tcat.js/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/tcat.js/events","assignees_url":"https://api.github.com/repos/cuappdev/tcat.js/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/tcat.js/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/tcat.js/tags","blobs_url":"https://api.github.com/repos/cuappdev/tcat.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/tcat.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/tcat.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/tcat.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/tcat.js/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/tcat.js/languages","stargazers_url":"https://api.github.com/repos/cuappdev/tcat.js/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/tcat.js/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/tcat.js/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/tcat.js/subscription","commits_url":"https://api.github.com/repos/cuappdev/tcat.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/tcat.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/tcat.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/tcat.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/tcat.js/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/tcat.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/tcat.js/merges","archive_url":"https://api.github.com/repos/cuappdev/tcat.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/tcat.js/downloads","issues_url":"https://api.github.com/repos/cuappdev/tcat.js/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/tcat.js/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/tcat.js/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/tcat.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/tcat.js/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/tcat.js/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/tcat.js/deployments","created_at":"2017-07-30T21:02:08Z","updated_at":"2017-07-30T21:04:55Z","pushed_at":"2017-09-06T17:08:16Z","git_url":"git://github.com/cuappdev/tcat.js.git","ssh_url":"git@github.com:cuappdev/tcat.js.git","clone_url":"https://github.com/cuappdev/tcat.js.git","svn_url":"https://github.com/cuappdev/tcat.js","homepage":null,"size":1351,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"cuappdev:master","ref":"master","sha":"d0d179593aaa4c12c43faa3606d9a31209a2c732","user":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":98824629,"name":"tcat.js","full_name":"cuappdev/tcat.js","owner":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars0.githubusercontent.com/u/17533691?v=4","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuappdev/tcat.js","description":"TCAT JavaScript API","fork":false,"url":"https://api.github.com/repos/cuappdev/tcat.js","forks_url":"https://api.github.com/repos/cuappdev/tcat.js/forks","keys_url":"https://api.github.com/repos/cuappdev/tcat.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/tcat.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/tcat.js/teams","hooks_url":"https://api.github.com/repos/cuappdev/tcat.js/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/tcat.js/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/tcat.js/events","assignees_url":"https://api.github.com/repos/cuappdev/tcat.js/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/tcat.js/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/tcat.js/tags","blobs_url":"https://api.github.com/repos/cuappdev/tcat.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/tcat.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/tcat.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/tcat.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/tcat.js/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/tcat.js/languages","stargazers_url":"https://api.github.com/repos/cuappdev/tcat.js/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/tcat.js/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/tcat.js/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/tcat.js/subscription","commits_url":"https://api.github.com/repos/cuappdev/tcat.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/tcat.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/tcat.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/tcat.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/tcat.js/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/tcat.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/tcat.js/merges","archive_url":"https://api.github.com/repos/cuappdev/tcat.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/tcat.js/downloads","issues_url":"https://api.github.com/repos/cuappdev/tcat.js/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/tcat.js/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/tcat.js/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/tcat.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/tcat.js/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/tcat.js/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/tcat.js/deployments","created_at":"2017-07-30T21:02:08Z","updated_at":"2017-07-30T21:04:55Z","pushed_at":"2017-09-06T17:08:16Z","git_url":"git://github.com/cuappdev/tcat.js.git","ssh_url":"git@github.com:cuappdev/tcat.js.git","clone_url":"https://github.com/cuappdev/tcat.js.git","svn_url":"https://github.com/cuappdev/tcat.js","homepage":null,"size":1351,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11"},"html":{"href":"https://github.com/cuappdev/tcat.js/pull/11"},"issue":{"href":"https://api.github.com/repos/cuappdev/tcat.js/issues/11"},"comments":{"href":"https://api.github.com/repos/cuappdev/tcat.js/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/cuappdev/tcat.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuappdev/tcat.js/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/cuappdev/tcat.js/statuses/abd93ba17fed8765e8ad5e9e51c986fa78e08af1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Jma353"}}