{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/37729","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/37729/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/37729/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/37729/events","html_url":"https://github.com/rust-lang/rust/pull/37729","id":188898820,"number":37729,"title":"Less unused argument spew","user":{"login":"DanielKeep","id":77238,"avatar_url":"https://avatars.githubusercontent.com/u/77238?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielKeep","html_url":"https://github.com/DanielKeep","followers_url":"https://api.github.com/users/DanielKeep/followers","following_url":"https://api.github.com/users/DanielKeep/following{/other_user}","gists_url":"https://api.github.com/users/DanielKeep/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielKeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielKeep/subscriptions","organizations_url":"https://api.github.com/users/DanielKeep/orgs","repos_url":"https://api.github.com/users/DanielKeep/repos","events_url":"https://api.github.com/users/DanielKeep/events{/privacy}","received_events_url":"https://api.github.com/users/DanielKeep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"assignees":[{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-11-12T07:45:45Z","updated_at":"2017-02-04T21:51:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/37729","html_url":"https://github.com/rust-lang/rust/pull/37729","diff_url":"https://github.com/rust-lang/rust/pull/37729.diff","patch_url":"https://github.com/rust-lang/rust/pull/37729.patch"},"body":"Unused arguments are attached to the main error as labels.  This drops\r\nthe traditional named/positional message split (except in the case of a\r\n*single* unused argument) for \"unused\" in interest of terseness.\r\n\r\nCloses rust-lang/rust#37718.\r\n\r\n---\r\n\r\nI tried using `MultiSpan` with `struct_err_span`, but *none* of the spans were emitted.  This was *also* the case with trying to attach a `MultiSpan` to the `Diagnostic` as a note.  `span_label` was the only seemingly relevant method I found that would actually display.\r\n\r\nIt feels a bit ugly, but *works.*\r\n\r\nI also chose to merge the two branches for how to display the error for the sake of simplifying and unifying the diagnostic construction a little."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/277480578","html_url":"https://github.com/rust-lang/rust/pull/37729#issuecomment-277480578","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/37729","id":277480578,"user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"created_at":"2017-02-04T21:51:00Z","updated_at":"2017-02-04T21:51:00Z","body":"Sorry for the delay here @DanielKeep! It looks like the UI test may be failing on Travis though? If you want to rebase, fix tests, and ping me I'll r+"}}
{"actor":{"display_login":"alexcrichton"}}