{"action":"created","comment":{"url":"https://api.github.com/repos/shanhuio/smlvm/pulls/comments/96494648","pull_request_review_id":17077869,"id":96494648,"diff_hunk":"@@ -10,25 +10,43 @@ func isLetter(r rune) bool {\n \n func lexNumber(x *lexing.Lexer) *lexing.Token {\n \t// TODO: lex floating point as well\n-\n+\tisFloat := false\n \tstart := x.Rune()\n \tif !lexing.IsDigit(start) {\n \t\tpanic(\"not starting with a number\")\n \t}\n \n \tx.Next()\n-\n \tr := x.Rune()\n \tif start == '0' && r == 'x' {\n \t\tx.Next()\n-\n \t\tfor lexing.IsHexDigit(x.Rune()) {\n \t\t\tx.Next()\n \t\t}\n \t} else {\n \t\tfor lexing.IsDigit(x.Rune()) {\n \t\t\tx.Next()\n \t\t}\n+\t\tif x.Rune() == '.' {\n+\t\t\tisFloat = true\n+\t\t\tx.Next()\n+\t\t\tfor lexing.IsDigit(x.Rune()) {\n+\t\t\t\tx.Next()\n+\t\t\t}\n+\t\t}\n+\t\tif x.Rune() == 'e' || x.Rune() == 'E' {\n+\t\t\tisFloat = true\n+\t\t\tx.Next()\n+\t\t\tif lexing.IsDigit(x.Rune()) || x.Rune() == '-' {\n+\t\t\t\tx.Next()\n+\t\t\t}\n+\t\t\tfor lexing.IsDigit(x.Rune()) {","path":"pl/parse/lex_ident.go","position":37,"original_position":37,"commit_id":"eb4ef78682dab80aed5540f99aa0dc1da7b5597b","original_commit_id":"eb4ef78682dab80aed5540f99aa0dc1da7b5597b","user":{"login":"yumuzi234","id":16619983,"avatar_url":"https://avatars.githubusercontent.com/u/16619983?v=3","gravatar_id":"","url":"https://api.github.com/users/yumuzi234","html_url":"https://github.com/yumuzi234","followers_url":"https://api.github.com/users/yumuzi234/followers","following_url":"https://api.github.com/users/yumuzi234/following{/other_user}","gists_url":"https://api.github.com/users/yumuzi234/gists{/gist_id}","starred_url":"https://api.github.com/users/yumuzi234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumuzi234/subscriptions","organizations_url":"https://api.github.com/users/yumuzi234/orgs","repos_url":"https://api.github.com/users/yumuzi234/repos","events_url":"https://api.github.com/users/yumuzi234/events{/privacy}","received_events_url":"https://api.github.com/users/yumuzi234/received_events","type":"User","site_admin":false},"body":"it accept, like it will accept 1e, but there will be an error in buildFloat","created_at":"2017-01-17T19:47:46Z","updated_at":"2017-01-17T19:47:46Z","html_url":"https://github.com/shanhuio/smlvm/pull/62#discussion_r96494648","pull_request_url":"https://api.github.com/repos/shanhuio/smlvm/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/shanhuio/smlvm/pulls/comments/96494648"},"html":{"href":"https://github.com/shanhuio/smlvm/pull/62#discussion_r96494648"},"pull_request":{"href":"https://api.github.com/repos/shanhuio/smlvm/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/shanhuio/smlvm/pulls/62","id":101793944,"html_url":"https://github.com/shanhuio/smlvm/pull/62","diff_url":"https://github.com/shanhuio/smlvm/pull/62.diff","patch_url":"https://github.com/shanhuio/smlvm/pull/62.patch","issue_url":"https://api.github.com/repos/shanhuio/smlvm/issues/62","number":62,"state":"open","locked":false,"title":"scientific notations added","user":{"login":"yumuzi234","id":16619983,"avatar_url":"https://avatars.githubusercontent.com/u/16619983?v=3","gravatar_id":"","url":"https://api.github.com/users/yumuzi234","html_url":"https://github.com/yumuzi234","followers_url":"https://api.github.com/users/yumuzi234/followers","following_url":"https://api.github.com/users/yumuzi234/following{/other_user}","gists_url":"https://api.github.com/users/yumuzi234/gists{/gist_id}","starred_url":"https://api.github.com/users/yumuzi234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumuzi234/subscriptions","organizations_url":"https://api.github.com/users/yumuzi234/orgs","repos_url":"https://api.github.com/users/yumuzi234/repos","events_url":"https://api.github.com/users/yumuzi234/events{/privacy}","received_events_url":"https://api.github.com/users/yumuzi234/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-17T04:00:32Z","updated_at":"2017-01-17T19:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23db11b0811896a3f58b9d9e3e9d8154d18b8bd2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shanhuio/smlvm/pulls/62/commits","review_comments_url":"https://api.github.com/repos/shanhuio/smlvm/pulls/62/comments","review_comment_url":"https://api.github.com/repos/shanhuio/smlvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shanhuio/smlvm/issues/62/comments","statuses_url":"https://api.github.com/repos/shanhuio/smlvm/statuses/eb4ef78682dab80aed5540f99aa0dc1da7b5597b","head":{"label":"yumuzi234:readyToPull","ref":"readyToPull","sha":"eb4ef78682dab80aed5540f99aa0dc1da7b5597b","user":{"login":"yumuzi234","id":16619983,"avatar_url":"https://avatars.githubusercontent.com/u/16619983?v=3","gravatar_id":"","url":"https://api.github.com/users/yumuzi234","html_url":"https://github.com/yumuzi234","followers_url":"https://api.github.com/users/yumuzi234/followers","following_url":"https://api.github.com/users/yumuzi234/following{/other_user}","gists_url":"https://api.github.com/users/yumuzi234/gists{/gist_id}","starred_url":"https://api.github.com/users/yumuzi234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumuzi234/subscriptions","organizations_url":"https://api.github.com/users/yumuzi234/orgs","repos_url":"https://api.github.com/users/yumuzi234/repos","events_url":"https://api.github.com/users/yumuzi234/events{/privacy}","received_events_url":"https://api.github.com/users/yumuzi234/received_events","type":"User","site_admin":false},"repo":{"id":59507820,"name":"smlvm","full_name":"yumuzi234/smlvm","owner":{"login":"yumuzi234","id":16619983,"avatar_url":"https://avatars.githubusercontent.com/u/16619983?v=3","gravatar_id":"","url":"https://api.github.com/users/yumuzi234","html_url":"https://github.com/yumuzi234","followers_url":"https://api.github.com/users/yumuzi234/followers","following_url":"https://api.github.com/users/yumuzi234/following{/other_user}","gists_url":"https://api.github.com/users/yumuzi234/gists{/gist_id}","starred_url":"https://api.github.com/users/yumuzi234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumuzi234/subscriptions","organizations_url":"https://api.github.com/users/yumuzi234/orgs","repos_url":"https://api.github.com/users/yumuzi234/repos","events_url":"https://api.github.com/users/yumuzi234/events{/privacy}","received_events_url":"https://api.github.com/users/yumuzi234/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yumuzi234/smlvm","description":"Emul8ed Virtual Machine","fork":true,"url":"https://api.github.com/repos/yumuzi234/smlvm","forks_url":"https://api.github.com/repos/yumuzi234/smlvm/forks","keys_url":"https://api.github.com/repos/yumuzi234/smlvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yumuzi234/smlvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yumuzi234/smlvm/teams","hooks_url":"https://api.github.com/repos/yumuzi234/smlvm/hooks","issue_events_url":"https://api.github.com/repos/yumuzi234/smlvm/issues/events{/number}","events_url":"https://api.github.com/repos/yumuzi234/smlvm/events","assignees_url":"https://api.github.com/repos/yumuzi234/smlvm/assignees{/user}","branches_url":"https://api.github.com/repos/yumuzi234/smlvm/branches{/branch}","tags_url":"https://api.github.com/repos/yumuzi234/smlvm/tags","blobs_url":"https://api.github.com/repos/yumuzi234/smlvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yumuzi234/smlvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yumuzi234/smlvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/yumuzi234/smlvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yumuzi234/smlvm/statuses/{sha}","languages_url":"https://api.github.com/repos/yumuzi234/smlvm/languages","stargazers_url":"https://api.github.com/repos/yumuzi234/smlvm/stargazers","contributors_url":"https://api.github.com/repos/yumuzi234/smlvm/contributors","subscribers_url":"https://api.github.com/repos/yumuzi234/smlvm/subscribers","subscription_url":"https://api.github.com/repos/yumuzi234/smlvm/subscription","commits_url":"https://api.github.com/repos/yumuzi234/smlvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/yumuzi234/smlvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/yumuzi234/smlvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/yumuzi234/smlvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/yumuzi234/smlvm/contents/{+path}","compare_url":"https://api.github.com/repos/yumuzi234/smlvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yumuzi234/smlvm/merges","archive_url":"https://api.github.com/repos/yumuzi234/smlvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yumuzi234/smlvm/downloads","issues_url":"https://api.github.com/repos/yumuzi234/smlvm/issues{/number}","pulls_url":"https://api.github.com/repos/yumuzi234/smlvm/pulls{/number}","milestones_url":"https://api.github.com/repos/yumuzi234/smlvm/milestones{/number}","notifications_url":"https://api.github.com/repos/yumuzi234/smlvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yumuzi234/smlvm/labels{/name}","releases_url":"https://api.github.com/repos/yumuzi234/smlvm/releases{/id}","deployments_url":"https://api.github.com/repos/yumuzi234/smlvm/deployments","created_at":"2016-05-23T18:21:30Z","updated_at":"2016-12-24T03:27:47Z","pushed_at":"2017-01-17T03:59:07Z","git_url":"git://github.com/yumuzi234/smlvm.git","ssh_url":"git@github.com:yumuzi234/smlvm.git","clone_url":"https://github.com/yumuzi234/smlvm.git","svn_url":"https://github.com/yumuzi234/smlvm","homepage":"https://e8vm.io/e8vm","size":1454,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shanhuio:master","ref":"master","sha":"1f36bfb821eee8e1d9719b8c68a662d0c6dba3d9","user":{"login":"shanhuio","id":21085999,"avatar_url":"https://avatars.githubusercontent.com/u/21085999?v=3","gravatar_id":"","url":"https://api.github.com/users/shanhuio","html_url":"https://github.com/shanhuio","followers_url":"https://api.github.com/users/shanhuio/followers","following_url":"https://api.github.com/users/shanhuio/following{/other_user}","gists_url":"https://api.github.com/users/shanhuio/gists{/gist_id}","starred_url":"https://api.github.com/users/shanhuio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanhuio/subscriptions","organizations_url":"https://api.github.com/users/shanhuio/orgs","repos_url":"https://api.github.com/users/shanhuio/repos","events_url":"https://api.github.com/users/shanhuio/events{/privacy}","received_events_url":"https://api.github.com/users/shanhuio/received_events","type":"Organization","site_admin":false},"repo":{"id":26937672,"name":"smlvm","full_name":"shanhuio/smlvm","owner":{"login":"shanhuio","id":21085999,"avatar_url":"https://avatars.githubusercontent.com/u/21085999?v=3","gravatar_id":"","url":"https://api.github.com/users/shanhuio","html_url":"https://github.com/shanhuio","followers_url":"https://api.github.com/users/shanhuio/followers","following_url":"https://api.github.com/users/shanhuio/following{/other_user}","gists_url":"https://api.github.com/users/shanhuio/gists{/gist_id}","starred_url":"https://api.github.com/users/shanhuio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanhuio/subscriptions","organizations_url":"https://api.github.com/users/shanhuio/orgs","repos_url":"https://api.github.com/users/shanhuio/repos","events_url":"https://api.github.com/users/shanhuio/events{/privacy}","received_events_url":"https://api.github.com/users/shanhuio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shanhuio/smlvm","description":"Smallrepo Virtual Machine","fork":false,"url":"https://api.github.com/repos/shanhuio/smlvm","forks_url":"https://api.github.com/repos/shanhuio/smlvm/forks","keys_url":"https://api.github.com/repos/shanhuio/smlvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shanhuio/smlvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shanhuio/smlvm/teams","hooks_url":"https://api.github.com/repos/shanhuio/smlvm/hooks","issue_events_url":"https://api.github.com/repos/shanhuio/smlvm/issues/events{/number}","events_url":"https://api.github.com/repos/shanhuio/smlvm/events","assignees_url":"https://api.github.com/repos/shanhuio/smlvm/assignees{/user}","branches_url":"https://api.github.com/repos/shanhuio/smlvm/branches{/branch}","tags_url":"https://api.github.com/repos/shanhuio/smlvm/tags","blobs_url":"https://api.github.com/repos/shanhuio/smlvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shanhuio/smlvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shanhuio/smlvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/shanhuio/smlvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shanhuio/smlvm/statuses/{sha}","languages_url":"https://api.github.com/repos/shanhuio/smlvm/languages","stargazers_url":"https://api.github.com/repos/shanhuio/smlvm/stargazers","contributors_url":"https://api.github.com/repos/shanhuio/smlvm/contributors","subscribers_url":"https://api.github.com/repos/shanhuio/smlvm/subscribers","subscription_url":"https://api.github.com/repos/shanhuio/smlvm/subscription","commits_url":"https://api.github.com/repos/shanhuio/smlvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/shanhuio/smlvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/shanhuio/smlvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/shanhuio/smlvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/shanhuio/smlvm/contents/{+path}","compare_url":"https://api.github.com/repos/shanhuio/smlvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shanhuio/smlvm/merges","archive_url":"https://api.github.com/repos/shanhuio/smlvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shanhuio/smlvm/downloads","issues_url":"https://api.github.com/repos/shanhuio/smlvm/issues{/number}","pulls_url":"https://api.github.com/repos/shanhuio/smlvm/pulls{/number}","milestones_url":"https://api.github.com/repos/shanhuio/smlvm/milestones{/number}","notifications_url":"https://api.github.com/repos/shanhuio/smlvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shanhuio/smlvm/labels{/name}","releases_url":"https://api.github.com/repos/shanhuio/smlvm/releases{/id}","deployments_url":"https://api.github.com/repos/shanhuio/smlvm/deployments","created_at":"2014-11-20T23:58:49Z","updated_at":"2017-01-15T05:49:22Z","pushed_at":"2017-01-17T04:00:33Z","git_url":"git://github.com/shanhuio/smlvm.git","ssh_url":"git@github.com:shanhuio/smlvm.git","clone_url":"https://github.com/shanhuio/smlvm.git","svn_url":"https://github.com/shanhuio/smlvm","homepage":"https://shanhu.io/smlvm","size":1428,"stargazers_count":175,"watchers_count":175,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":13,"forks":25,"open_issues":13,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shanhuio/smlvm/pulls/62"},"html":{"href":"https://github.com/shanhuio/smlvm/pull/62"},"issue":{"href":"https://api.github.com/repos/shanhuio/smlvm/issues/62"},"comments":{"href":"https://api.github.com/repos/shanhuio/smlvm/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/shanhuio/smlvm/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/shanhuio/smlvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shanhuio/smlvm/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/shanhuio/smlvm/statuses/eb4ef78682dab80aed5540f99aa0dc1da7b5597b"}}}}
{"actor":{"display_login":"yumuzi234"}}