{"action":"created","issue":{"url":"https://api.github.com/repos/jan-molak/serenity-js/issues/89","repository_url":"https://api.github.com/repos/jan-molak/serenity-js","labels_url":"https://api.github.com/repos/jan-molak/serenity-js/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/jan-molak/serenity-js/issues/89/comments","events_url":"https://api.github.com/repos/jan-molak/serenity-js/issues/89/events","html_url":"https://github.com/jan-molak/serenity-js/issues/89","id":253565161,"number":89,"title":"Unable to get clean build from master","user":{"login":"nbarrett","id":626941,"avatar_url":"https://avatars0.githubusercontent.com/u/626941?v=4","gravatar_id":"","url":"https://api.github.com/users/nbarrett","html_url":"https://github.com/nbarrett","followers_url":"https://api.github.com/users/nbarrett/followers","following_url":"https://api.github.com/users/nbarrett/following{/other_user}","gists_url":"https://api.github.com/users/nbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/nbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbarrett/subscriptions","organizations_url":"https://api.github.com/users/nbarrett/orgs","repos_url":"https://api.github.com/users/nbarrett/repos","events_url":"https://api.github.com/users/nbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/nbarrett/received_events","type":"User","site_admin":false},"labels":[{"id":513323931,"url":"https://api.github.com/repos/jan-molak/serenity-js/labels/documentation","name":"documentation","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-29T08:17:45Z","updated_at":"2017-10-22T18:38:48Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi @jan-molak - I have an open PR #73 which I'm struggling to make progress on, but realise that much of my problem is not being able to get a clean build and/or understand the test failures (even on master). In an attempt to initialise my environment cleanly I tried this:\r\n```\r\nnpm run lerna clean\r\nrm -rf node_modules\r\nnpm install\r\nnpm run verify\r\n```\r\n\r\nHowever, even with the above,  I can never get a build to pass on my machine and get these kinds of errors:\r\n\r\n```\r\nlerna ERR! execute \r\nlerna ERR! execute   45 passing (2m)\r\nlerna ERR! execute   5 failing\r\nlerna ERR! execute \r\nlerna ERR! execute   1) When waiting for things to happen, a test scenario using Active Wait (setTimeout) to determine if an element is not present in the DOM will pass if the condition is met within the timeout:\r\nlerna ERR! execute      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\nlerna ERR! execute   \r\nlerna ERR! execute \r\nlerna ERR! execute   2) When waiting for things to happen, a test scenario using Passive Wait ($timeout) will fail if the timeout is too short:\r\nlerna ERR! execute      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\nlerna ERR! execute   \r\nlerna ERR! execute \r\nlerna ERR! execute   3) When waiting for things to happen, a test scenario using Active Wait ($timeout) to determine if an element is not present in the DOM will pass if the condition is met within the timeout:\r\nlerna ERR! execute      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\nlerna ERR! execute   \r\nlerna ERR! execute \r\nlerna ERR! execute   4) When waiting for things to happen, a test scenario using Passive Wait ($interval) will pass if the timeout is long enough:\r\nlerna ERR! execute      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\nlerna ERR! execute   \r\nlerna ERR! execute \r\nlerna ERR! execute   5) When waiting for things to happen, a test scenario \"before each\" hook: ret for \"can rely on a default timeout provided by Wait.until(..) to be sensibly long enough\":\r\nlerna ERR! execute      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\nlerna ERR! execute   \r\nlerna ERR! execute \r\n```\r\n\r\nI did also have some problems with the version of node until I downgraded from 7.10.0\r\n to v6.9.5, but the documentation and engines section of package.json states  `\"node\": \">= 6.9.x\"` which could be misleading to a new starter that might have a newer version of node installed. When node was 7.10.0 `npm run verify`, seemed to fail catastrophically 😭 \r\n\r\nIf you can provide some assistance with the following this would be really helpful please to those people that wish to submit PRs:\r\n- How a clean build environment for the serenity-js project can be initialised, ready for the creation of PRs.\r\n- How to generate/find a report that shows the failing serenity-js tests. The output sent to the command line is overwhelmingly verbose, so pinpointing the error is very hard. Given that the tests being run are serenity specs, is there an html report I can produce so that I can look at the failures? When I run `npm run report` I get the following which is a coverage report I think, which is not what I want:\r\n```\r\n> serenity-js@0.0.1 report /Users/nick/dev/git-personal/serenity-js\r\n> npm run coverage:merge && npm run coverage:report\r\n\r\n\r\n> serenity-js@0.0.1 coverage:merge /Users/nick/dev/git-personal/serenity-js\r\n> istanbul-merge --out=./target/coverage/coverage-final.json ./target/coverage/**/coverage-final.json\r\n\r\n\r\n> serenity-js@0.0.1 coverage:report /Users/nick/dev/git-personal/serenity-js\r\n> nyc report --reporter=html --reporter=lcov --temp-directory=./target/coverage --report-dir=./target/coverage\r\n```\r\n- If the above could be put on the serenity-js documentation, this would be very helpful as don't think this exists yet. If it does, then I can't find it!\r\n\r\nThanks a lot Jan in advance. I'm happy to do the documentation btw, I just don't know what to put in it yet 😢 "},"comment":{"url":"https://api.github.com/repos/jan-molak/serenity-js/issues/comments/338499250","html_url":"https://github.com/jan-molak/serenity-js/issues/89#issuecomment-338499250","issue_url":"https://api.github.com/repos/jan-molak/serenity-js/issues/89","id":338499250,"user":{"login":"nbarrett","id":626941,"avatar_url":"https://avatars0.githubusercontent.com/u/626941?v=4","gravatar_id":"","url":"https://api.github.com/users/nbarrett","html_url":"https://github.com/nbarrett","followers_url":"https://api.github.com/users/nbarrett/followers","following_url":"https://api.github.com/users/nbarrett/following{/other_user}","gists_url":"https://api.github.com/users/nbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/nbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbarrett/subscriptions","organizations_url":"https://api.github.com/users/nbarrett/orgs","repos_url":"https://api.github.com/users/nbarrett/repos","events_url":"https://api.github.com/users/nbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/nbarrett/received_events","type":"User","site_admin":false},"created_at":"2017-10-22T18:38:48Z","updated_at":"2017-10-22T18:38:48Z","author_association":"CONTRIBUTOR","body":"Hi Jan, yes I think it is - putting aside the situation that I can rarely get a clean run of all tests,  I think there are still some gaps in the serenity-js documentation that explain how to build and run the tests and to also generate the serenity reports for the specs in the base product. See above note about that ⬆️ "}}
{"actor":{"display_login":"nbarrett"}}