{"action":"opened","number":2186,"pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2186","id":132597360,"html_url":"https://github.com/jwplayer/jwplayer/pull/2186","diff_url":"https://github.com/jwplayer/jwplayer/pull/2186.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/2186.patch","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2186","number":2186,"state":"open","locked":false,"title":"Replace 'define' with 'import'","user":{"login":"hghazzi","id":584053,"avatar_url":"https://avatars2.githubusercontent.com/u/584053?v=4","gravatar_id":"","url":"https://api.github.com/users/hghazzi","html_url":"https://github.com/hghazzi","followers_url":"https://api.github.com/users/hghazzi/followers","following_url":"https://api.github.com/users/hghazzi/following{/other_user}","gists_url":"https://api.github.com/users/hghazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/hghazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hghazzi/subscriptions","organizations_url":"https://api.github.com/users/hghazzi/orgs","repos_url":"https://api.github.com/users/hghazzi/repos","events_url":"https://api.github.com/users/hghazzi/events{/privacy}","received_events_url":"https://api.github.com/users/hghazzi/received_events","type":"User","site_admin":false},"body":"### This PR will...\r\n\r\nUpdate unit tests to no longer use `define`. Replaced with `import` syntax\r\n\r\n### Why is this Pull Request needed?\r\n\r\nTo migrate away from AMD\r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\n\r\nAppend PR url with `?w=1` to view without the whitespace changes\r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\n\r\nBranched off of https://github.com/jwplayer/jwplayer/pull/2184\r\n\r\n#### Addresses Issue(s):\r\n\r\nJW8-111\r\n\r\n### This PR will...\r\n\r\n### Why is this Pull Request needed?\r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\n\r\n#### Addresses Issue(s):\r\n\r\nJW8-###\r\n\r\n","created_at":"2017-07-26T19:41:18Z","updated_at":"2017-07-26T19:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"assignees":[{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},{"login":"egreaves","id":4603952,"avatar_url":"https://avatars1.githubusercontent.com/u/4603952?v=4","gravatar_id":"","url":"https://api.github.com/users/egreaves","html_url":"https://github.com/egreaves","followers_url":"https://api.github.com/users/egreaves/followers","following_url":"https://api.github.com/users/egreaves/following{/other_user}","gists_url":"https://api.github.com/users/egreaves/gists{/gist_id}","starred_url":"https://api.github.com/users/egreaves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egreaves/subscriptions","organizations_url":"https://api.github.com/users/egreaves/orgs","repos_url":"https://api.github.com/users/egreaves/repos","events_url":"https://api.github.com/users/egreaves/events{/privacy}","received_events_url":"https://api.github.com/users/egreaves/received_events","type":"User","site_admin":false},{"login":"johnBartos","id":5042276,"avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},{"login":"karimJWP","id":12138319,"avatar_url":"https://avatars1.githubusercontent.com/u/12138319?v=4","gravatar_id":"","url":"https://api.github.com/users/karimJWP","html_url":"https://github.com/karimJWP","followers_url":"https://api.github.com/users/karimJWP/followers","following_url":"https://api.github.com/users/karimJWP/following{/other_user}","gists_url":"https://api.github.com/users/karimJWP/gists{/gist_id}","starred_url":"https://api.github.com/users/karimJWP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karimJWP/subscriptions","organizations_url":"https://api.github.com/users/karimJWP/orgs","repos_url":"https://api.github.com/users/karimJWP/repos","events_url":"https://api.github.com/users/karimJWP/events{/privacy}","received_events_url":"https://api.github.com/users/karimJWP/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/53","html_url":"https://github.com/jwplayer/jwplayer/milestone/53","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/53/labels","id":2588142,"number":53,"title":"v8.0.0","description":null,"creator":{"login":"hghazzi","id":584053,"avatar_url":"https://avatars2.githubusercontent.com/u/584053?v=4","gravatar_id":"","url":"https://api.github.com/users/hghazzi","html_url":"https://github.com/hghazzi","followers_url":"https://api.github.com/users/hghazzi/followers","following_url":"https://api.github.com/users/hghazzi/following{/other_user}","gists_url":"https://api.github.com/users/hghazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/hghazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hghazzi/subscriptions","organizations_url":"https://api.github.com/users/hghazzi/orgs","repos_url":"https://api.github.com/users/hghazzi/repos","events_url":"https://api.github.com/users/hghazzi/events{/privacy}","received_events_url":"https://api.github.com/users/hghazzi/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":18,"state":"open","created_at":"2017-06-16T20:32:59Z","updated_at":"2017-07-26T19:41:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2186/commits","review_comments_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2186/comments","review_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2186/comments","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/c74368115b7e8084919194e980cb4879af4e3895","head":{"label":"jwplayer:feature/embed-unit-tests","ref":"feature/embed-unit-tests","sha":"c74368115b7e8084919194e980cb4879af4e3895","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2017-07-26T13:32:19Z","pushed_at":"2017-07-26T19:36:12Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":82723,"stargazers_count":1323,"watchers_count":1323,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":574,"mirror_url":null,"open_issues_count":61,"forks":574,"open_issues":61,"watchers":1323,"default_branch":"master"}},"base":{"label":"jwplayer:feature/embed-bundle-loader","ref":"feature/embed-bundle-loader","sha":"7b69ac1386e8c316881b3193f53c2e38f83bb2a3","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2017-07-26T13:32:19Z","pushed_at":"2017-07-26T19:36:12Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":82723,"stargazers_count":1323,"watchers_count":1323,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":574,"mirror_url":null,"open_issues_count":61,"forks":574,"open_issues":61,"watchers":1323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2186"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/2186"},"issue":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2186"},"comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2186/comments"},"review_comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2186/comments"},"review_comment":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2186/commits"},"statuses":{"href":"https://api.github.com/repos/jwplayer/jwplayer/statuses/c74368115b7e8084919194e980cb4879af4e3895"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2297,"deletions":2445,"changed_files":34}}
{"actor":{"display_login":"hghazzi"}}