{"action":"created","comment":{"url":"https://api.github.com/repos/B3n30/tunnler/pulls/comments/107097488","pull_request_review_id":27906607,"id":107097488,"diff_hunk":"@@ -0,0 +1,210 @@\n+// Copyright 2017 Tunnler Project\n+// Licensed under GPLv2 or any later version\n+// Refer to the license.txt file included.\n+\n+#include <thread>\n+#include <mutex>\n+\n+#include \"tunnler/tunnler.h\"\n+#include \"tunnler/room.h\"\n+#include \"tunnler/room_member.h\"\n+#include \"tunnler/room_message_types.h\"\n+\n+#include \"tunnler/assert.h\"\n+\n+#include \"BitStream.h\"\n+#include \"RakNetTypes.h\"\n+\n+RoomMember::RoomMember() {\n+    peer = RakNet::RakPeerInterface::GetInstance();\n+}\n+\n+RoomMember::~RoomMember() {\n+    ASSERT_MSG(!IsConnected(), \"RoomMember is being destroyed while connected\");","path":"src/room_member.cpp","position":23,"original_position":23,"commit_id":"236f4c02a0edad34ea31f7501ca91ac635843d87","original_commit_id":"236f4c02a0edad34ea31f7501ca91ac635843d87","user":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars3.githubusercontent.com/u/26032316?v=3","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"body":"Why not just call Leave? Since this destructor my be called even if I'm connected (for example just closing citra while connected)","created_at":"2017-03-21T08:35:28Z","updated_at":"2017-03-21T08:46:57Z","html_url":"https://github.com/B3n30/tunnler/pull/6#discussion_r107097488","pull_request_url":"https://api.github.com/repos/B3n30/tunnler/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/B3n30/tunnler/pulls/comments/107097488"},"html":{"href":"https://github.com/B3n30/tunnler/pull/6#discussion_r107097488"},"pull_request":{"href":"https://api.github.com/repos/B3n30/tunnler/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/B3n30/tunnler/pulls/6","id":111602233,"html_url":"https://github.com/B3n30/tunnler/pull/6","diff_url":"https://github.com/B3n30/tunnler/pull/6.diff","patch_url":"https://github.com/B3n30/tunnler/pull/6.patch","issue_url":"https://api.github.com/repos/B3n30/tunnler/issues/6","number":6,"state":"open","locked":false,"title":"Implemented connecting to the rooms.","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars1.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"Nicknames and MAC addresses are not yet negotiated.\r\nOnly wifi beacon frames are retransmitted for the moment.\r\n\r\nMoved the header files to a tunnler/ subdirectory.\r\n\r\nThere are still some concurrency issues that i'd like help with, namely in RoomMember.","created_at":"2017-03-20T17:05:25Z","updated_at":"2017-03-21T08:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18a7b44c8706d2c536585b05c230e653290f006b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/B3n30/tunnler/pulls/6/commits","review_comments_url":"https://api.github.com/repos/B3n30/tunnler/pulls/6/comments","review_comment_url":"https://api.github.com/repos/B3n30/tunnler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/B3n30/tunnler/issues/6/comments","statuses_url":"https://api.github.com/repos/B3n30/tunnler/statuses/236f4c02a0edad34ea31f7501ca91ac635843d87","head":{"label":"B3n30:prototype_1","ref":"prototype_1","sha":"236f4c02a0edad34ea31f7501ca91ac635843d87","user":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars3.githubusercontent.com/u/26032316?v=3","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"repo":{"id":85343759,"name":"tunnler","full_name":"B3n30/tunnler","owner":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars3.githubusercontent.com/u/26032316?v=3","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/B3n30/tunnler","description":null,"fork":false,"url":"https://api.github.com/repos/B3n30/tunnler","forks_url":"https://api.github.com/repos/B3n30/tunnler/forks","keys_url":"https://api.github.com/repos/B3n30/tunnler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/B3n30/tunnler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/B3n30/tunnler/teams","hooks_url":"https://api.github.com/repos/B3n30/tunnler/hooks","issue_events_url":"https://api.github.com/repos/B3n30/tunnler/issues/events{/number}","events_url":"https://api.github.com/repos/B3n30/tunnler/events","assignees_url":"https://api.github.com/repos/B3n30/tunnler/assignees{/user}","branches_url":"https://api.github.com/repos/B3n30/tunnler/branches{/branch}","tags_url":"https://api.github.com/repos/B3n30/tunnler/tags","blobs_url":"https://api.github.com/repos/B3n30/tunnler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/B3n30/tunnler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/B3n30/tunnler/git/refs{/sha}","trees_url":"https://api.github.com/repos/B3n30/tunnler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/B3n30/tunnler/statuses/{sha}","languages_url":"https://api.github.com/repos/B3n30/tunnler/languages","stargazers_url":"https://api.github.com/repos/B3n30/tunnler/stargazers","contributors_url":"https://api.github.com/repos/B3n30/tunnler/contributors","subscribers_url":"https://api.github.com/repos/B3n30/tunnler/subscribers","subscription_url":"https://api.github.com/repos/B3n30/tunnler/subscription","commits_url":"https://api.github.com/repos/B3n30/tunnler/commits{/sha}","git_commits_url":"https://api.github.com/repos/B3n30/tunnler/git/commits{/sha}","comments_url":"https://api.github.com/repos/B3n30/tunnler/comments{/number}","issue_comment_url":"https://api.github.com/repos/B3n30/tunnler/issues/comments{/number}","contents_url":"https://api.github.com/repos/B3n30/tunnler/contents/{+path}","compare_url":"https://api.github.com/repos/B3n30/tunnler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/B3n30/tunnler/merges","archive_url":"https://api.github.com/repos/B3n30/tunnler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/B3n30/tunnler/downloads","issues_url":"https://api.github.com/repos/B3n30/tunnler/issues{/number}","pulls_url":"https://api.github.com/repos/B3n30/tunnler/pulls{/number}","milestones_url":"https://api.github.com/repos/B3n30/tunnler/milestones{/number}","notifications_url":"https://api.github.com/repos/B3n30/tunnler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/B3n30/tunnler/labels{/name}","releases_url":"https://api.github.com/repos/B3n30/tunnler/releases{/id}","deployments_url":"https://api.github.com/repos/B3n30/tunnler/deployments","created_at":"2017-03-17T18:37:20Z","updated_at":"2017-03-20T15:12:37Z","pushed_at":"2017-03-20T19:48:42Z","git_url":"git://github.com/B3n30/tunnler.git","ssh_url":"git@github.com:B3n30/tunnler.git","clone_url":"https://github.com/B3n30/tunnler.git","svn_url":"https://github.com/B3n30/tunnler","homepage":null,"size":165,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"B3n30:master","ref":"master","sha":"dc9e6f13ec3aae85801f37a0249801e140272833","user":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars3.githubusercontent.com/u/26032316?v=3","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"repo":{"id":85343759,"name":"tunnler","full_name":"B3n30/tunnler","owner":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars3.githubusercontent.com/u/26032316?v=3","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/B3n30/tunnler","description":null,"fork":false,"url":"https://api.github.com/repos/B3n30/tunnler","forks_url":"https://api.github.com/repos/B3n30/tunnler/forks","keys_url":"https://api.github.com/repos/B3n30/tunnler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/B3n30/tunnler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/B3n30/tunnler/teams","hooks_url":"https://api.github.com/repos/B3n30/tunnler/hooks","issue_events_url":"https://api.github.com/repos/B3n30/tunnler/issues/events{/number}","events_url":"https://api.github.com/repos/B3n30/tunnler/events","assignees_url":"https://api.github.com/repos/B3n30/tunnler/assignees{/user}","branches_url":"https://api.github.com/repos/B3n30/tunnler/branches{/branch}","tags_url":"https://api.github.com/repos/B3n30/tunnler/tags","blobs_url":"https://api.github.com/repos/B3n30/tunnler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/B3n30/tunnler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/B3n30/tunnler/git/refs{/sha}","trees_url":"https://api.github.com/repos/B3n30/tunnler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/B3n30/tunnler/statuses/{sha}","languages_url":"https://api.github.com/repos/B3n30/tunnler/languages","stargazers_url":"https://api.github.com/repos/B3n30/tunnler/stargazers","contributors_url":"https://api.github.com/repos/B3n30/tunnler/contributors","subscribers_url":"https://api.github.com/repos/B3n30/tunnler/subscribers","subscription_url":"https://api.github.com/repos/B3n30/tunnler/subscription","commits_url":"https://api.github.com/repos/B3n30/tunnler/commits{/sha}","git_commits_url":"https://api.github.com/repos/B3n30/tunnler/git/commits{/sha}","comments_url":"https://api.github.com/repos/B3n30/tunnler/comments{/number}","issue_comment_url":"https://api.github.com/repos/B3n30/tunnler/issues/comments{/number}","contents_url":"https://api.github.com/repos/B3n30/tunnler/contents/{+path}","compare_url":"https://api.github.com/repos/B3n30/tunnler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/B3n30/tunnler/merges","archive_url":"https://api.github.com/repos/B3n30/tunnler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/B3n30/tunnler/downloads","issues_url":"https://api.github.com/repos/B3n30/tunnler/issues{/number}","pulls_url":"https://api.github.com/repos/B3n30/tunnler/pulls{/number}","milestones_url":"https://api.github.com/repos/B3n30/tunnler/milestones{/number}","notifications_url":"https://api.github.com/repos/B3n30/tunnler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/B3n30/tunnler/labels{/name}","releases_url":"https://api.github.com/repos/B3n30/tunnler/releases{/id}","deployments_url":"https://api.github.com/repos/B3n30/tunnler/deployments","created_at":"2017-03-17T18:37:20Z","updated_at":"2017-03-20T15:12:37Z","pushed_at":"2017-03-20T19:48:42Z","git_url":"git://github.com/B3n30/tunnler.git","ssh_url":"git@github.com:B3n30/tunnler.git","clone_url":"https://github.com/B3n30/tunnler.git","svn_url":"https://github.com/B3n30/tunnler","homepage":null,"size":165,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/B3n30/tunnler/pulls/6"},"html":{"href":"https://github.com/B3n30/tunnler/pull/6"},"issue":{"href":"https://api.github.com/repos/B3n30/tunnler/issues/6"},"comments":{"href":"https://api.github.com/repos/B3n30/tunnler/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/B3n30/tunnler/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/B3n30/tunnler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/B3n30/tunnler/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/B3n30/tunnler/statuses/236f4c02a0edad34ea31f7501ca91ac635843d87"}}}}
{"actor":{"display_login":"B3n30"}}