{"action":"created","issue":{"url":"https://api.github.com/repos/patternfly/patternfly/issues/648","repository_url":"https://api.github.com/repos/patternfly/patternfly","labels_url":"https://api.github.com/repos/patternfly/patternfly/issues/648/labels{/name}","comments_url":"https://api.github.com/repos/patternfly/patternfly/issues/648/comments","events_url":"https://api.github.com/repos/patternfly/patternfly/issues/648/events","html_url":"https://github.com/patternfly/patternfly/issues/648","id":229388417,"number":648,"title":"Application Launcher's List View display issues","user":{"login":"dtaylor113","id":12733153,"avatar_url":"https://avatars1.githubusercontent.com/u/12733153?v=3","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cshinn","id":3300756,"avatar_url":"https://avatars3.githubusercontent.com/u/3300756?v=3","gravatar_id":"","url":"https://api.github.com/users/cshinn","html_url":"https://github.com/cshinn","followers_url":"https://api.github.com/users/cshinn/followers","following_url":"https://api.github.com/users/cshinn/following{/other_user}","gists_url":"https://api.github.com/users/cshinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cshinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshinn/subscriptions","organizations_url":"https://api.github.com/users/cshinn/orgs","repos_url":"https://api.github.com/users/cshinn/repos","events_url":"https://api.github.com/users/cshinn/events{/privacy}","received_events_url":"https://api.github.com/users/cshinn/received_events","type":"User","site_admin":false},"assignees":[{"login":"cshinn","id":3300756,"avatar_url":"https://avatars3.githubusercontent.com/u/3300756?v=3","gravatar_id":"","url":"https://api.github.com/users/cshinn","html_url":"https://github.com/cshinn","followers_url":"https://api.github.com/users/cshinn/followers","following_url":"https://api.github.com/users/cshinn/following{/other_user}","gists_url":"https://api.github.com/users/cshinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cshinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshinn/subscriptions","organizations_url":"https://api.github.com/users/cshinn/orgs","repos_url":"https://api.github.com/users/cshinn/repos","events_url":"https://api.github.com/users/cshinn/events{/privacy}","received_events_url":"https://api.github.com/users/cshinn/received_events","type":"User","site_admin":false},{"login":"cdcabrera","id":3761375,"avatar_url":"https://avatars1.githubusercontent.com/u/3761375?v=3","gravatar_id":"","url":"https://api.github.com/users/cdcabrera","html_url":"https://github.com/cdcabrera","followers_url":"https://api.github.com/users/cdcabrera/followers","following_url":"https://api.github.com/users/cdcabrera/following{/other_user}","gists_url":"https://api.github.com/users/cdcabrera/gists{/gist_id}","starred_url":"https://api.github.com/users/cdcabrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdcabrera/subscriptions","organizations_url":"https://api.github.com/users/cdcabrera/orgs","repos_url":"https://api.github.com/users/cdcabrera/repos","events_url":"https://api.github.com/users/cdcabrera/events{/privacy}","received_events_url":"https://api.github.com/users/cdcabrera/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-05-17T15:14:52Z","updated_at":"2017-05-25T13:12:53Z","closed_at":null,"body":"In list view:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/12733153/26160558/9156c800-3aef-11e7-878a-2824d4cf01e8.png)\r\n\r\n- Please add some padding between the icon and label.\r\n```\r\n.applauncher-pf-link-icon {\r\n      @media (min-width: @screen-sm-min) {\r\n        padding-right: 10px;\r\n      }\r\n    }\r\n```\r\n- Please align all labels regardless of size/width of icons, or if there some apps which do not have icons defined.  (Image below has padding-right applied)\r\n![image](https://cloud.githubusercontent.com/assets/12733153/26161057/d7cbbf7e-3af0-11e7-8d7f-4502f5458019.png)\r\n\r\nSimilar to using 'fa-fw'  http://fontawesome.io/examples/  \"Fixed Width Icons\".  https://github.com/FortAwesome/Font-Awesome/blob/v4.7.0/less/fixed-width.less \r\n"},"comment":{"url":"https://api.github.com/repos/patternfly/patternfly/issues/comments/304006753","html_url":"https://github.com/patternfly/patternfly/issues/648#issuecomment-304006753","issue_url":"https://api.github.com/repos/patternfly/patternfly/issues/648","id":304006753,"user":{"login":"cshinn","id":3300756,"avatar_url":"https://avatars3.githubusercontent.com/u/3300756?v=3","gravatar_id":"","url":"https://api.github.com/users/cshinn","html_url":"https://github.com/cshinn","followers_url":"https://api.github.com/users/cshinn/followers","following_url":"https://api.github.com/users/cshinn/following{/other_user}","gists_url":"https://api.github.com/users/cshinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cshinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshinn/subscriptions","organizations_url":"https://api.github.com/users/cshinn/orgs","repos_url":"https://api.github.com/users/cshinn/repos","events_url":"https://api.github.com/users/cshinn/events{/privacy}","received_events_url":"https://api.github.com/users/cshinn/received_events","type":"User","site_admin":false},"created_at":"2017-05-25T13:12:53Z","updated_at":"2017-05-25T13:12:53Z","body":"If we put in a rule that adds padding for items without icons, we end up with a situation where they're all indented even if none of them have icons\r\n![screen shot 2017-05-25 at 9 09 38 am](https://cloud.githubusercontent.com/assets/3300756/26451393/e922e7ae-4129-11e7-995e-2e192a714bda.png)\r\n\r\nWe can achieve the desired effect by including a placeholder div\r\n![screen shot 2017-05-25 at 8 55 20 am](https://cloud.githubusercontent.com/assets/3300756/26451396/eb9f472a-4129-11e7-8dbf-b22ec9bb8bdb.png)\r\n\r\nor we could come up with some kind of crazy selector that would do it, but would be very fragile.\r\n\r\n@andresgalante @dtaylor113 @cdcabrera Which do you think is the right approach?"}}
{"actor":{"display_login":"cshinn"}}