{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/13691","repository_url":"https://api.github.com/repos/atom/atom","labels_url":"https://api.github.com/repos/atom/atom/issues/13691/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/13691/comments","events_url":"https://api.github.com/repos/atom/atom/issues/13691/events","html_url":"https://github.com/atom/atom/pull/13691","id":202985930,"number":13691,"title":"Allow building on Node 7+","user":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=3","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-25T01:03:50Z","updated_at":"2017-01-25T04:55:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/13691","html_url":"https://github.com/atom/atom/pull/13691","diff_url":"https://github.com/atom/atom/pull/13691.diff","patch_url":"https://github.com/atom/atom/pull/13691.patch"},"body":"### Requirements\r\n\r\n* Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.\r\n* All new code requires tests to ensure against regressions\r\n\r\n### Description of the Change\r\n\r\nRemoves a restriction that prevented people from trying to build Atom using Node 7+.  Now that apm has been updated this should work again.\r\nIn addition, I fixed a potential bug where `stdout` was being declared as a constant but then being reassigned.  I'm not sure this would work; even if it did, it's best that it's rewritten to be a `let` instead.\r\n\r\n### Alternate Designs\r\n\r\nNone.\r\n\r\n### Why Should This Be In Core?\r\n\r\nAlready in core.\r\n\r\n### Benefits\r\n\r\nMore supported Node versions when building.\r\n\r\n### Possible Drawbacks\r\n\r\nNone.\r\n\r\n### Applicable Issues\r\n\r\nNone.\r\n\r\nIf CI is green, I will revert the CI changes and :boat:."},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/275019174","html_url":"https://github.com/atom/atom/pull/13691#issuecomment-275019174","issue_url":"https://api.github.com/repos/atom/atom/issues/13691","id":275019174,"user":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=3","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"created_at":"2017-01-25T04:55:22Z","updated_at":"2017-01-25T04:55:22Z","body":"Turns out that the linting script doesn't lint the `script` folder!  There were a bunch of warnings in there, some of which become full-blown errors when running under Node 7 and improved ES6 support.  So I've added that to the list of files to lint, and will lint all those files as a part of this PR.\r\n\r\nI also noticed that specs written in JavaScript aren't being linted, but in the interest of keeping this PR small, I'll be opening a different PR for that."}}
{"actor":{"display_login":"50Wliu"}}