{"action":"created","comment":{"url":"https://api.github.com/repos/angelozerr/typescript.java/pulls/comments/107672483","pull_request_review_id":28657773,"id":107672483,"diff_hunk":"@@ -134,13 +150,20 @@ public final ITypeScriptServiceClient getClient() throws TypeScriptException {\n \t\t\t\t\tthis.client = createServiceClient(getProjectDir());\r\n \t\t\t\t\tcopyListeners();\r\n \t\t\t\t\tonCreateClient(client);\r\n+\t\t\t\t\t// determine root files and project name\r\n+\t\t\t\t\tString projectName = projectDir.getCanonicalPath();\r\n+\t\t\t\t\tList<String> rootFiles = new ArrayList<>();\r\n+\t\t\t\t\tfor (String tsconfigFilePath : getTsconfigFilePaths()) {\r\n+\t\t\t\t\t\trootFiles.add(new File(projectDir, tsconfigFilePath).getCanonicalPath());\r","path":"core/ts.core/src/ts/resources/TypeScriptProject.java","position":43,"original_position":43,"commit_id":"3db814191f2d42b827ac1f4d5ab8ff740c71213c","original_commit_id":"3db814191f2d42b827ac1f4d5ab8ff740c71213c","user":{"login":"angelozerr","id":1932211,"avatar_url":"https://avatars2.githubusercontent.com/u/1932211?v=3","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"body":"Please use FileUtils.getPath(new File(projectDir, tsconfigFilePath)) to normalize path.","created_at":"2017-03-23T13:51:58Z","updated_at":"2017-03-23T13:51:59Z","html_url":"https://github.com/angelozerr/typescript.java/pull/160#discussion_r107672483","pull_request_url":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/angelozerr/typescript.java/pulls/comments/107672483"},"html":{"href":"https://github.com/angelozerr/typescript.java/pull/160#discussion_r107672483"},"pull_request":{"href":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160","id":112235242,"html_url":"https://github.com/angelozerr/typescript.java/pull/160","diff_url":"https://github.com/angelozerr/typescript.java/pull/160.diff","patch_url":"https://github.com/angelozerr/typescript.java/pull/160.patch","issue_url":"https://api.github.com/repos/angelozerr/typescript.java/issues/160","number":160,"state":"open","locked":false,"title":"Keep projects open on tsserver via OpenExternalProject","user":{"login":"lorenzodallavecchia","id":15628014,"avatar_url":"https://avatars3.githubusercontent.com/u/15628014?v=3","gravatar_id":"","url":"https://api.github.com/users/lorenzodallavecchia","html_url":"https://github.com/lorenzodallavecchia","followers_url":"https://api.github.com/users/lorenzodallavecchia/followers","following_url":"https://api.github.com/users/lorenzodallavecchia/following{/other_user}","gists_url":"https://api.github.com/users/lorenzodallavecchia/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzodallavecchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzodallavecchia/subscriptions","organizations_url":"https://api.github.com/users/lorenzodallavecchia/orgs","repos_url":"https://api.github.com/users/lorenzodallavecchia/repos","events_url":"https://api.github.com/users/lorenzodallavecchia/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzodallavecchia/received_events","type":"User","site_admin":false},"body":"This change makes tsserver aware of existing Eclipse projects, so that it does not forget about project state when all files are closed.\r\nCloses #142.","created_at":"2017-03-23T13:18:23Z","updated_at":"2017-03-23T13:51:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7109da35f83bf6c5f6d2b10fd332725f0cb8c5fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160/commits","review_comments_url":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160/comments","review_comment_url":"https://api.github.com/repos/angelozerr/typescript.java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angelozerr/typescript.java/issues/160/comments","statuses_url":"https://api.github.com/repos/angelozerr/typescript.java/statuses/3db814191f2d42b827ac1f4d5ab8ff740c71213c","head":{"label":"webratio:pr/keep-open-project","ref":"pr/keep-open-project","sha":"3db814191f2d42b827ac1f4d5ab8ff740c71213c","user":{"login":"webratio","id":4921056,"avatar_url":"https://avatars3.githubusercontent.com/u/4921056?v=3","gravatar_id":"","url":"https://api.github.com/users/webratio","html_url":"https://github.com/webratio","followers_url":"https://api.github.com/users/webratio/followers","following_url":"https://api.github.com/users/webratio/following{/other_user}","gists_url":"https://api.github.com/users/webratio/gists{/gist_id}","starred_url":"https://api.github.com/users/webratio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webratio/subscriptions","organizations_url":"https://api.github.com/users/webratio/orgs","repos_url":"https://api.github.com/users/webratio/repos","events_url":"https://api.github.com/users/webratio/events{/privacy}","received_events_url":"https://api.github.com/users/webratio/received_events","type":"Organization","site_admin":false},"repo":{"id":79210145,"name":"typescript.java","full_name":"webratio/typescript.java","owner":{"login":"webratio","id":4921056,"avatar_url":"https://avatars3.githubusercontent.com/u/4921056?v=3","gravatar_id":"","url":"https://api.github.com/users/webratio","html_url":"https://github.com/webratio","followers_url":"https://api.github.com/users/webratio/followers","following_url":"https://api.github.com/users/webratio/following{/other_user}","gists_url":"https://api.github.com/users/webratio/gists{/gist_id}","starred_url":"https://api.github.com/users/webratio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webratio/subscriptions","organizations_url":"https://api.github.com/users/webratio/orgs","repos_url":"https://api.github.com/users/webratio/repos","events_url":"https://api.github.com/users/webratio/events{/privacy}","received_events_url":"https://api.github.com/users/webratio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webratio/typescript.java","description":"TypeScript IDE for Eclipse with JSDT & tsserver","fork":true,"url":"https://api.github.com/repos/webratio/typescript.java","forks_url":"https://api.github.com/repos/webratio/typescript.java/forks","keys_url":"https://api.github.com/repos/webratio/typescript.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webratio/typescript.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webratio/typescript.java/teams","hooks_url":"https://api.github.com/repos/webratio/typescript.java/hooks","issue_events_url":"https://api.github.com/repos/webratio/typescript.java/issues/events{/number}","events_url":"https://api.github.com/repos/webratio/typescript.java/events","assignees_url":"https://api.github.com/repos/webratio/typescript.java/assignees{/user}","branches_url":"https://api.github.com/repos/webratio/typescript.java/branches{/branch}","tags_url":"https://api.github.com/repos/webratio/typescript.java/tags","blobs_url":"https://api.github.com/repos/webratio/typescript.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webratio/typescript.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webratio/typescript.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/webratio/typescript.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webratio/typescript.java/statuses/{sha}","languages_url":"https://api.github.com/repos/webratio/typescript.java/languages","stargazers_url":"https://api.github.com/repos/webratio/typescript.java/stargazers","contributors_url":"https://api.github.com/repos/webratio/typescript.java/contributors","subscribers_url":"https://api.github.com/repos/webratio/typescript.java/subscribers","subscription_url":"https://api.github.com/repos/webratio/typescript.java/subscription","commits_url":"https://api.github.com/repos/webratio/typescript.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/webratio/typescript.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/webratio/typescript.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/webratio/typescript.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/webratio/typescript.java/contents/{+path}","compare_url":"https://api.github.com/repos/webratio/typescript.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webratio/typescript.java/merges","archive_url":"https://api.github.com/repos/webratio/typescript.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webratio/typescript.java/downloads","issues_url":"https://api.github.com/repos/webratio/typescript.java/issues{/number}","pulls_url":"https://api.github.com/repos/webratio/typescript.java/pulls{/number}","milestones_url":"https://api.github.com/repos/webratio/typescript.java/milestones{/number}","notifications_url":"https://api.github.com/repos/webratio/typescript.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webratio/typescript.java/labels{/name}","releases_url":"https://api.github.com/repos/webratio/typescript.java/releases{/id}","deployments_url":"https://api.github.com/repos/webratio/typescript.java/deployments","created_at":"2017-01-17T09:19:27Z","updated_at":"2017-01-23T09:06:03Z","pushed_at":"2017-03-23T13:16:11Z","git_url":"git://github.com/webratio/typescript.java.git","ssh_url":"git@github.com:webratio/typescript.java.git","clone_url":"https://github.com/webratio/typescript.java.git","svn_url":"https://github.com/webratio/typescript.java","homepage":"https://github.com/Microsoft/TypeScript","size":115568,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angelozerr:master","ref":"master","sha":"c85b895beec14a0c6a9546a05af84b21c977f670","user":{"login":"angelozerr","id":1932211,"avatar_url":"https://avatars2.githubusercontent.com/u/1932211?v=3","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"repo":{"id":46073518,"name":"typescript.java","full_name":"angelozerr/typescript.java","owner":{"login":"angelozerr","id":1932211,"avatar_url":"https://avatars2.githubusercontent.com/u/1932211?v=3","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/angelozerr/typescript.java","description":"TypeScript IDE for Eclipse with JSDT & tsserver","fork":false,"url":"https://api.github.com/repos/angelozerr/typescript.java","forks_url":"https://api.github.com/repos/angelozerr/typescript.java/forks","keys_url":"https://api.github.com/repos/angelozerr/typescript.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angelozerr/typescript.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angelozerr/typescript.java/teams","hooks_url":"https://api.github.com/repos/angelozerr/typescript.java/hooks","issue_events_url":"https://api.github.com/repos/angelozerr/typescript.java/issues/events{/number}","events_url":"https://api.github.com/repos/angelozerr/typescript.java/events","assignees_url":"https://api.github.com/repos/angelozerr/typescript.java/assignees{/user}","branches_url":"https://api.github.com/repos/angelozerr/typescript.java/branches{/branch}","tags_url":"https://api.github.com/repos/angelozerr/typescript.java/tags","blobs_url":"https://api.github.com/repos/angelozerr/typescript.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angelozerr/typescript.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angelozerr/typescript.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/angelozerr/typescript.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angelozerr/typescript.java/statuses/{sha}","languages_url":"https://api.github.com/repos/angelozerr/typescript.java/languages","stargazers_url":"https://api.github.com/repos/angelozerr/typescript.java/stargazers","contributors_url":"https://api.github.com/repos/angelozerr/typescript.java/contributors","subscribers_url":"https://api.github.com/repos/angelozerr/typescript.java/subscribers","subscription_url":"https://api.github.com/repos/angelozerr/typescript.java/subscription","commits_url":"https://api.github.com/repos/angelozerr/typescript.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/angelozerr/typescript.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/angelozerr/typescript.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/angelozerr/typescript.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/angelozerr/typescript.java/contents/{+path}","compare_url":"https://api.github.com/repos/angelozerr/typescript.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angelozerr/typescript.java/merges","archive_url":"https://api.github.com/repos/angelozerr/typescript.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angelozerr/typescript.java/downloads","issues_url":"https://api.github.com/repos/angelozerr/typescript.java/issues{/number}","pulls_url":"https://api.github.com/repos/angelozerr/typescript.java/pulls{/number}","milestones_url":"https://api.github.com/repos/angelozerr/typescript.java/milestones{/number}","notifications_url":"https://api.github.com/repos/angelozerr/typescript.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angelozerr/typescript.java/labels{/name}","releases_url":"https://api.github.com/repos/angelozerr/typescript.java/releases{/id}","deployments_url":"https://api.github.com/repos/angelozerr/typescript.java/deployments","created_at":"2015-11-12T18:51:13Z","updated_at":"2017-02-27T08:00:23Z","pushed_at":"2017-03-23T13:18:24Z","git_url":"git://github.com/angelozerr/typescript.java.git","ssh_url":"git@github.com:angelozerr/typescript.java.git","clone_url":"https://github.com/angelozerr/typescript.java.git","svn_url":"https://github.com/angelozerr/typescript.java","homepage":"https://github.com/Microsoft/TypeScript","size":115498,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":36,"forks":5,"open_issues":36,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160"},"html":{"href":"https://github.com/angelozerr/typescript.java/pull/160"},"issue":{"href":"https://api.github.com/repos/angelozerr/typescript.java/issues/160"},"comments":{"href":"https://api.github.com/repos/angelozerr/typescript.java/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/angelozerr/typescript.java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angelozerr/typescript.java/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/angelozerr/typescript.java/statuses/3db814191f2d42b827ac1f4d5ab8ff740c71213c"}}}}
{"actor":{"display_login":"angelozerr"}}