{"action":"closed","number":972,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/972","id":108038093,"html_url":"https://github.com/Azure/azure-rest-api-specs/pull/972","diff_url":"https://github.com/Azure/azure-rest-api-specs/pull/972.diff","patch_url":"https://github.com/Azure/azure-rest-api-specs/pull/972.patch","issue_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/972","number":972,"state":"closed","locked":false,"title":"PowerBI Embedded: fixing a bug in the Swagger","user":{"login":"tombuildsstuff","id":666005,"avatar_url":"https://avatars2.githubusercontent.com/u/666005?v=3","gravatar_id":"","url":"https://api.github.com/users/tombuildsstuff","html_url":"https://github.com/tombuildsstuff","followers_url":"https://api.github.com/users/tombuildsstuff/followers","following_url":"https://api.github.com/users/tombuildsstuff/following{/other_user}","gists_url":"https://api.github.com/users/tombuildsstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuildsstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuildsstuff/subscriptions","organizations_url":"https://api.github.com/users/tombuildsstuff/orgs","repos_url":"https://api.github.com/users/tombuildsstuff/repos","events_url":"https://api.github.com/users/tombuildsstuff/events{/privacy}","received_events_url":"https://api.github.com/users/tombuildsstuff/received_events","type":"User","site_admin":false},"body":"Context: I've encountered a bug when deleting a PowerBI Embedded instance via the Go SDK - that I've managed to track down to a couple of Swagger issues:\r\n 1) Delete doesn't appear to be (both in the docs / by using the portal/API) a long-running operation\r\n 2) Defining the unused Response object causes the Go SDK to fail on deletion.\r\n\r\n(in order to generate the Go SDK locally I've had to update some of the method names to remove the Generation Errors too)\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process. \r\n\r\n### PR information\r\n- [x] The title of the PR is clear and informative.\r\n- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n- [x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.\r\n- [x] If applicable, the PR references the bug/issue that it fixes.\r\n- [x] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).\r\n\r\n### Quality of Swagger\r\n- [x] I have read the [contribution guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).\r\n- [x] My spec meets the review criteria:\r\n  - [x] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).\r\n  - [x] Validation errors from the [Linter extension for VS Code](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/linter.md) have all been fixed for this spec. (**Note:** for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them). <-- I've done this using the Atom linter\r\n  - [x] The spec follows the patterns described in the [Swagger good patterns](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-good-patterns.md) document unless the service API makes this impossible.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/azure/azure-rest-api-specs/972)\n<!-- Reviewable:end -->\n","created_at":"2017-02-27T02:43:00Z","updated_at":"2017-06-21T18:25:35Z","closed_at":"2017-06-21T18:25:35Z","merged_at":null,"merge_commit_sha":"395ec715d803ea0d2d40affd32b7d277101ba409","assignee":{"login":"veronicagg","id":17714137,"avatar_url":"https://avatars1.githubusercontent.com/u/17714137?v=3","gravatar_id":"","url":"https://api.github.com/users/veronicagg","html_url":"https://github.com/veronicagg","followers_url":"https://api.github.com/users/veronicagg/followers","following_url":"https://api.github.com/users/veronicagg/following{/other_user}","gists_url":"https://api.github.com/users/veronicagg/gists{/gist_id}","starred_url":"https://api.github.com/users/veronicagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veronicagg/subscriptions","organizations_url":"https://api.github.com/users/veronicagg/orgs","repos_url":"https://api.github.com/users/veronicagg/repos","events_url":"https://api.github.com/users/veronicagg/events{/privacy}","received_events_url":"https://api.github.com/users/veronicagg/received_events","type":"User","site_admin":false},"assignees":[{"login":"veronicagg","id":17714137,"avatar_url":"https://avatars1.githubusercontent.com/u/17714137?v=3","gravatar_id":"","url":"https://api.github.com/users/veronicagg","html_url":"https://github.com/veronicagg","followers_url":"https://api.github.com/users/veronicagg/followers","following_url":"https://api.github.com/users/veronicagg/following{/other_user}","gists_url":"https://api.github.com/users/veronicagg/gists{/gist_id}","starred_url":"https://api.github.com/users/veronicagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veronicagg/subscriptions","organizations_url":"https://api.github.com/users/veronicagg/orgs","repos_url":"https://api.github.com/users/veronicagg/repos","events_url":"https://api.github.com/users/veronicagg/events{/privacy}","received_events_url":"https://api.github.com/users/veronicagg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/972/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/972/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/972/comments","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/e566780d6e55b90d7638571392bb0ea8dade5a3a","head":{"label":"tombuildsstuff:powerbi-bug","ref":"powerbi-bug","sha":"e566780d6e55b90d7638571392bb0ea8dade5a3a","user":{"login":"tombuildsstuff","id":666005,"avatar_url":"https://avatars2.githubusercontent.com/u/666005?v=3","gravatar_id":"","url":"https://api.github.com/users/tombuildsstuff","html_url":"https://github.com/tombuildsstuff","followers_url":"https://api.github.com/users/tombuildsstuff/followers","following_url":"https://api.github.com/users/tombuildsstuff/following{/other_user}","gists_url":"https://api.github.com/users/tombuildsstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuildsstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuildsstuff/subscriptions","organizations_url":"https://api.github.com/users/tombuildsstuff/orgs","repos_url":"https://api.github.com/users/tombuildsstuff/repos","events_url":"https://api.github.com/users/tombuildsstuff/events{/privacy}","received_events_url":"https://api.github.com/users/tombuildsstuff/received_events","type":"User","site_admin":false},"repo":{"id":74544720,"name":"azure-rest-api-specs","full_name":"tombuildsstuff/azure-rest-api-specs","owner":{"login":"tombuildsstuff","id":666005,"avatar_url":"https://avatars2.githubusercontent.com/u/666005?v=3","gravatar_id":"","url":"https://api.github.com/users/tombuildsstuff","html_url":"https://github.com/tombuildsstuff","followers_url":"https://api.github.com/users/tombuildsstuff/followers","following_url":"https://api.github.com/users/tombuildsstuff/following{/other_user}","gists_url":"https://api.github.com/users/tombuildsstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuildsstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuildsstuff/subscriptions","organizations_url":"https://api.github.com/users/tombuildsstuff/orgs","repos_url":"https://api.github.com/users/tombuildsstuff/repos","events_url":"https://api.github.com/users/tombuildsstuff/events{/privacy}","received_events_url":"https://api.github.com/users/tombuildsstuff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tombuildsstuff/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":true,"url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs","forks_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/tombuildsstuff/azure-rest-api-specs/deployments","created_at":"2016-11-23T05:49:44Z","updated_at":"2016-11-23T05:49:46Z","pushed_at":"2017-05-10T05:18:56Z","git_url":"git://github.com/tombuildsstuff/azure-rest-api-specs.git","ssh_url":"git@github.com:tombuildsstuff/azure-rest-api-specs.git","clone_url":"https://github.com/tombuildsstuff/azure-rest-api-specs.git","svn_url":"https://github.com/tombuildsstuff/azure-rest-api-specs","homepage":"","size":6718,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"84cf0b641e5fdc7dc88c209d79f60056a1dc863a","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":39093389,"name":"azure-rest-api-specs","full_name":"Azure/azure-rest-api-specs","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-rest-api-specs","forks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/deployments","created_at":"2015-07-14T18:37:13Z","updated_at":"2017-06-15T18:06:09Z","pushed_at":"2017-06-21T17:39:46Z","git_url":"git://github.com/Azure/azure-rest-api-specs.git","ssh_url":"git@github.com:Azure/azure-rest-api-specs.git","clone_url":"https://github.com/Azure/azure-rest-api-specs.git","svn_url":"https://github.com/Azure/azure-rest-api-specs","homepage":"","size":10596,"stargazers_count":157,"watchers_count":157,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"open_issues_count":168,"forks":355,"open_issues":168,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/972"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/972"},"issue":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/972"},"comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/972/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/972/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/972/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/e566780d6e55b90d7638571392bb0ea8dade5a3a"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":30,"review_comments":14,"maintainer_can_modify":false,"commits":5,"additions":2,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"veronicagg"}}