{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/eui/pulls/comments/158172181","pull_request_review_id":84939819,"id":158172181,"diff_hunk":"@@ -6,16 +17,10 @@\n   border-radius: $euiBorderRadius;\n   flex-grow: 1;\n \n-  &.euiPanel--paddingSmall {\n-    padding: $euiSizeS;\n-  }\n-\n-  &.euiPanel--paddingMedium {\n-    padding: $euiSize;\n-  }\n-\n-  &.euiPanel--paddingLarge {\n-    padding: $euiSizeL;\n+  @each $modifier, $amount in $euiPanelPaddingModifiers {\n+    &.euiPanel#{$modifier} {","path":"src/components/panel/_panel.scss","position":30,"original_position":30,"commit_id":"21b5568093faf888ace88053c54cbff39ec2f1f4","original_commit_id":"21b5568093faf888ace88053c54cbff39ec2f1f4","user":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars2.githubusercontent.com/u/1238659?v=4","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"body":"I think I see your point. Could we make one last change and put the `--` here instead of in the map? This will be inline with how we're structuring this kind of pattern elsewhere.","created_at":"2017-12-21T00:39:32Z","updated_at":"2017-12-21T00:45:44Z","html_url":"https://github.com/elastic/eui/pull/229#discussion_r158172181","pull_request_url":"https://api.github.com/repos/elastic/eui/pulls/229","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/eui/pulls/comments/158172181"},"html":{"href":"https://github.com/elastic/eui/pull/229#discussion_r158172181"},"pull_request":{"href":"https://api.github.com/repos/elastic/eui/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/eui/pulls/229","id":159459667,"html_url":"https://github.com/elastic/eui/pull/229","diff_url":"https://github.com/elastic/eui/pull/229.diff","patch_url":"https://github.com/elastic/eui/pull/229.patch","issue_url":"https://api.github.com/repos/elastic/eui/issues/229","number":229,"state":"open","locked":false,"title":"Updating Popovers to use Panel Padding vars","user":{"login":"cchaos","id":549577,"avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"body":"## Takeaway ##\r\nPopovers with titles no longer require padding to be manually added to the popover's child that follows the title.\r\n\r\n## Solution ##\r\nThe panel's padding is still applied to the entire popover. Based on the panel padding class applied to the popover, ie `.euiPanel--paddingMedium`, the title has negative margins to expand  to cover that padding amount.\r\n\r\nThe popover's title also adjusts the horizontal padding to match so that the content and the title align horizontally.\r\n\r\nThe popover's title always has some padding and only the content's padding is affected by the \"none\" padding property on the panel.\r\n\r\n## Design ##\r\nI, personally, feel that borders around shading are duplicative and noisy, so I also removed the bottom border from the title. I can easily change back if others disagree.\r\n\r\n## Screenshots ##\r\n<img width=\"376\" alt=\"screen shot 2017-12-20 at 19 25 37 pm\" src=\"https://user-images.githubusercontent.com/549577/34234843-b9eb09b2-e5bb-11e7-8e0d-d6f658074aea.png\">\r\n<img width=\"377\" alt=\"screen shot 2017-12-20 at 19 25 43 pm\" src=\"https://user-images.githubusercontent.com/549577/34234844-b9f2cf8a-e5bb-11e7-9ed6-396dcd6456e0.png\">\r\n<img width=\"379\" alt=\"screen shot 2017-12-20 at 19 25 47 pm\" src=\"https://user-images.githubusercontent.com/549577/34234845-b9f9fa76-e5bb-11e7-8f3e-da3d7bffc351.png\">\r\n<img width=\"346\" alt=\"screen shot 2017-12-20 at 19 25 51 pm\" src=\"https://user-images.githubusercontent.com/549577/34234846-ba01f1fe-e5bb-11e7-9f92-3a9f215ccf93.png\">\r\n\r\n","created_at":"2017-12-20T16:24:07Z","updated_at":"2017-12-21T00:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"703d47728d518f6a086917c26890fbb207987b57","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/eui/pulls/229/commits","review_comments_url":"https://api.github.com/repos/elastic/eui/pulls/229/comments","review_comment_url":"https://api.github.com/repos/elastic/eui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/eui/issues/229/comments","statuses_url":"https://api.github.com/repos/elastic/eui/statuses/21b5568093faf888ace88053c54cbff39ec2f1f4","head":{"label":"cchaos:popovers","ref":"popovers","sha":"21b5568093faf888ace88053c54cbff39ec2f1f4","user":{"login":"cchaos","id":549577,"avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"repo":{"id":113351911,"name":"eui","full_name":"cchaos/eui","owner":{"login":"cchaos","id":549577,"avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cchaos/eui","description":"Elastic UI Framework 🙌","fork":true,"url":"https://api.github.com/repos/cchaos/eui","forks_url":"https://api.github.com/repos/cchaos/eui/forks","keys_url":"https://api.github.com/repos/cchaos/eui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cchaos/eui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cchaos/eui/teams","hooks_url":"https://api.github.com/repos/cchaos/eui/hooks","issue_events_url":"https://api.github.com/repos/cchaos/eui/issues/events{/number}","events_url":"https://api.github.com/repos/cchaos/eui/events","assignees_url":"https://api.github.com/repos/cchaos/eui/assignees{/user}","branches_url":"https://api.github.com/repos/cchaos/eui/branches{/branch}","tags_url":"https://api.github.com/repos/cchaos/eui/tags","blobs_url":"https://api.github.com/repos/cchaos/eui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cchaos/eui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cchaos/eui/git/refs{/sha}","trees_url":"https://api.github.com/repos/cchaos/eui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cchaos/eui/statuses/{sha}","languages_url":"https://api.github.com/repos/cchaos/eui/languages","stargazers_url":"https://api.github.com/repos/cchaos/eui/stargazers","contributors_url":"https://api.github.com/repos/cchaos/eui/contributors","subscribers_url":"https://api.github.com/repos/cchaos/eui/subscribers","subscription_url":"https://api.github.com/repos/cchaos/eui/subscription","commits_url":"https://api.github.com/repos/cchaos/eui/commits{/sha}","git_commits_url":"https://api.github.com/repos/cchaos/eui/git/commits{/sha}","comments_url":"https://api.github.com/repos/cchaos/eui/comments{/number}","issue_comment_url":"https://api.github.com/repos/cchaos/eui/issues/comments{/number}","contents_url":"https://api.github.com/repos/cchaos/eui/contents/{+path}","compare_url":"https://api.github.com/repos/cchaos/eui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cchaos/eui/merges","archive_url":"https://api.github.com/repos/cchaos/eui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cchaos/eui/downloads","issues_url":"https://api.github.com/repos/cchaos/eui/issues{/number}","pulls_url":"https://api.github.com/repos/cchaos/eui/pulls{/number}","milestones_url":"https://api.github.com/repos/cchaos/eui/milestones{/number}","notifications_url":"https://api.github.com/repos/cchaos/eui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cchaos/eui/labels{/name}","releases_url":"https://api.github.com/repos/cchaos/eui/releases{/id}","deployments_url":"https://api.github.com/repos/cchaos/eui/deployments","created_at":"2017-12-06T18:19:26Z","updated_at":"2017-12-06T18:19:28Z","pushed_at":"2017-12-21T00:29:33Z","git_url":"git://github.com/cchaos/eui.git","ssh_url":"git@github.com:cchaos/eui.git","clone_url":"https://github.com/cchaos/eui.git","svn_url":"https://github.com/cchaos/eui","homepage":"https://elastic.github.io/eui/","size":8703,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"76714086246da120e37280cff9d016b7d9f09e83","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":107422373,"name":"eui","full_name":"elastic/eui","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/eui","description":"Elastic UI Framework 🙌","fork":false,"url":"https://api.github.com/repos/elastic/eui","forks_url":"https://api.github.com/repos/elastic/eui/forks","keys_url":"https://api.github.com/repos/elastic/eui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/eui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/eui/teams","hooks_url":"https://api.github.com/repos/elastic/eui/hooks","issue_events_url":"https://api.github.com/repos/elastic/eui/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/eui/events","assignees_url":"https://api.github.com/repos/elastic/eui/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/eui/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/eui/tags","blobs_url":"https://api.github.com/repos/elastic/eui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/eui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/eui/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/eui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/eui/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/eui/languages","stargazers_url":"https://api.github.com/repos/elastic/eui/stargazers","contributors_url":"https://api.github.com/repos/elastic/eui/contributors","subscribers_url":"https://api.github.com/repos/elastic/eui/subscribers","subscription_url":"https://api.github.com/repos/elastic/eui/subscription","commits_url":"https://api.github.com/repos/elastic/eui/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/eui/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/eui/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/eui/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/eui/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/eui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/eui/merges","archive_url":"https://api.github.com/repos/elastic/eui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/eui/downloads","issues_url":"https://api.github.com/repos/elastic/eui/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/eui/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/eui/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/eui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/eui/labels{/name}","releases_url":"https://api.github.com/repos/elastic/eui/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/eui/deployments","created_at":"2017-10-18T14:49:20Z","updated_at":"2017-12-20T10:57:31Z","pushed_at":"2017-12-21T00:35:35Z","git_url":"git://github.com/elastic/eui.git","ssh_url":"git@github.com:elastic/eui.git","clone_url":"https://github.com/elastic/eui.git","svn_url":"https://github.com/elastic/eui","homepage":"https://elastic.github.io/eui/","size":8786,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":48,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/eui/pulls/229"},"html":{"href":"https://github.com/elastic/eui/pull/229"},"issue":{"href":"https://api.github.com/repos/elastic/eui/issues/229"},"comments":{"href":"https://api.github.com/repos/elastic/eui/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/eui/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/eui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/eui/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/eui/statuses/21b5568093faf888ace88053c54cbff39ec2f1f4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cjcenizal"}}