{"action":"created","comment":{"url":"https://api.github.com/repos/typelevel/squants/pulls/comments/132164096","pull_request_review_id":55213539,"id":132164096,"diff_hunk":"@@ -55,8 +55,32 @@ trait Dimension[A <: Quantity[A]] {\n    * @param value the source string (ie, \"10 kW\") or tuple (ie, (10, \"kW\"))\n    * @return Try[A]\n    */\n-  protected def parse(value: Any) = value match {\n-    case s: String              => parseString(s)\n+  protected def parse(value: Any): Try[A] = value match {","path":"shared/src/main/scala/squants/Dimension.scala","position":6,"original_position":6,"commit_id":"ff5ad8265f42ad43e11d0bd5a00d6947f3cc5b04","original_commit_id":"ff5ad8265f42ad43e11d0bd5a00d6947f3cc5b04","user":{"login":"derekmorr","id":6717579,"avatar_url":"https://avatars1.githubusercontent.com/u/6717579?v=4","gravatar_id":"","url":"https://api.github.com/users/derekmorr","html_url":"https://github.com/derekmorr","followers_url":"https://api.github.com/users/derekmorr/followers","following_url":"https://api.github.com/users/derekmorr/following{/other_user}","gists_url":"https://api.github.com/users/derekmorr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekmorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekmorr/subscriptions","organizations_url":"https://api.github.com/users/derekmorr/orgs","repos_url":"https://api.github.com/users/derekmorr/repos","events_url":"https://api.github.com/users/derekmorr/events{/privacy}","received_events_url":"https://api.github.com/users/derekmorr/received_events","type":"User","site_admin":false},"body":"Why was this change necessary?","created_at":"2017-08-09T12:05:23Z","updated_at":"2017-08-09T12:05:23Z","html_url":"https://github.com/typelevel/squants/pull/282#discussion_r132164096","pull_request_url":"https://api.github.com/repos/typelevel/squants/pulls/282","_links":{"self":{"href":"https://api.github.com/repos/typelevel/squants/pulls/comments/132164096"},"html":{"href":"https://github.com/typelevel/squants/pull/282#discussion_r132164096"},"pull_request":{"href":"https://api.github.com/repos/typelevel/squants/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/typelevel/squants/pulls/282","id":134805348,"html_url":"https://github.com/typelevel/squants/pull/282","diff_url":"https://github.com/typelevel/squants/pull/282.diff","patch_url":"https://github.com/typelevel/squants/pull/282.patch","issue_url":"https://api.github.com/repos/typelevel/squants/issues/282","number":282,"state":"open","locked":false,"title":"Bump version to Scala Native 0.3.2 and make all unit tests pass","user":{"login":"shadaj","id":543055,"avatar_url":"https://avatars3.githubusercontent.com/u/543055?v=4","gravatar_id":"","url":"https://api.github.com/users/shadaj","html_url":"https://github.com/shadaj","followers_url":"https://api.github.com/users/shadaj/followers","following_url":"https://api.github.com/users/shadaj/following{/other_user}","gists_url":"https://api.github.com/users/shadaj/gists{/gist_id}","starred_url":"https://api.github.com/users/shadaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadaj/subscriptions","organizations_url":"https://api.github.com/users/shadaj/orgs","repos_url":"https://api.github.com/users/shadaj/repos","events_url":"https://api.github.com/users/shadaj/events{/privacy}","received_events_url":"https://api.github.com/users/shadaj/received_events","type":"User","site_admin":false},"body":"With the PR at https://github.com/scalatest/scalatest/pull/1185, all unit tests now pass in Scala Native!","created_at":"2017-08-09T03:59:39Z","updated_at":"2017-08-09T12:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09685ca5d1f1544c2609142b562b723a59b403c0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/typelevel/squants/pulls/282/commits","review_comments_url":"https://api.github.com/repos/typelevel/squants/pulls/282/comments","review_comment_url":"https://api.github.com/repos/typelevel/squants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typelevel/squants/issues/282/comments","statuses_url":"https://api.github.com/repos/typelevel/squants/statuses/ff5ad8265f42ad43e11d0bd5a00d6947f3cc5b04","head":{"label":"Team846:scala-native-0.3.2","ref":"scala-native-0.3.2","sha":"ff5ad8265f42ad43e11d0bd5a00d6947f3cc5b04","user":{"login":"Team846","id":12131787,"avatar_url":"https://avatars0.githubusercontent.com/u/12131787?v=4","gravatar_id":"","url":"https://api.github.com/users/Team846","html_url":"https://github.com/Team846","followers_url":"https://api.github.com/users/Team846/followers","following_url":"https://api.github.com/users/Team846/following{/other_user}","gists_url":"https://api.github.com/users/Team846/gists{/gist_id}","starred_url":"https://api.github.com/users/Team846/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team846/subscriptions","organizations_url":"https://api.github.com/users/Team846/orgs","repos_url":"https://api.github.com/users/Team846/repos","events_url":"https://api.github.com/users/Team846/events{/privacy}","received_events_url":"https://api.github.com/users/Team846/received_events","type":"Organization","site_admin":false},"repo":{"id":79877804,"name":"squants","full_name":"Team846/squants","owner":{"login":"Team846","id":12131787,"avatar_url":"https://avatars0.githubusercontent.com/u/12131787?v=4","gravatar_id":"","url":"https://api.github.com/users/Team846","html_url":"https://github.com/Team846","followers_url":"https://api.github.com/users/Team846/followers","following_url":"https://api.github.com/users/Team846/following{/other_user}","gists_url":"https://api.github.com/users/Team846/gists{/gist_id}","starred_url":"https://api.github.com/users/Team846/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team846/subscriptions","organizations_url":"https://api.github.com/users/Team846/orgs","repos_url":"https://api.github.com/users/Team846/repos","events_url":"https://api.github.com/users/Team846/events{/privacy}","received_events_url":"https://api.github.com/users/Team846/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Team846/squants","description":"The Scala API for Quantities, Units of Measure and Dimensional Analysis","fork":true,"url":"https://api.github.com/repos/Team846/squants","forks_url":"https://api.github.com/repos/Team846/squants/forks","keys_url":"https://api.github.com/repos/Team846/squants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Team846/squants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Team846/squants/teams","hooks_url":"https://api.github.com/repos/Team846/squants/hooks","issue_events_url":"https://api.github.com/repos/Team846/squants/issues/events{/number}","events_url":"https://api.github.com/repos/Team846/squants/events","assignees_url":"https://api.github.com/repos/Team846/squants/assignees{/user}","branches_url":"https://api.github.com/repos/Team846/squants/branches{/branch}","tags_url":"https://api.github.com/repos/Team846/squants/tags","blobs_url":"https://api.github.com/repos/Team846/squants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Team846/squants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Team846/squants/git/refs{/sha}","trees_url":"https://api.github.com/repos/Team846/squants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Team846/squants/statuses/{sha}","languages_url":"https://api.github.com/repos/Team846/squants/languages","stargazers_url":"https://api.github.com/repos/Team846/squants/stargazers","contributors_url":"https://api.github.com/repos/Team846/squants/contributors","subscribers_url":"https://api.github.com/repos/Team846/squants/subscribers","subscription_url":"https://api.github.com/repos/Team846/squants/subscription","commits_url":"https://api.github.com/repos/Team846/squants/commits{/sha}","git_commits_url":"https://api.github.com/repos/Team846/squants/git/commits{/sha}","comments_url":"https://api.github.com/repos/Team846/squants/comments{/number}","issue_comment_url":"https://api.github.com/repos/Team846/squants/issues/comments{/number}","contents_url":"https://api.github.com/repos/Team846/squants/contents/{+path}","compare_url":"https://api.github.com/repos/Team846/squants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Team846/squants/merges","archive_url":"https://api.github.com/repos/Team846/squants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Team846/squants/downloads","issues_url":"https://api.github.com/repos/Team846/squants/issues{/number}","pulls_url":"https://api.github.com/repos/Team846/squants/pulls{/number}","milestones_url":"https://api.github.com/repos/Team846/squants/milestones{/number}","notifications_url":"https://api.github.com/repos/Team846/squants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Team846/squants/labels{/name}","releases_url":"https://api.github.com/repos/Team846/squants/releases{/id}","deployments_url":"https://api.github.com/repos/Team846/squants/deployments","created_at":"2017-01-24T04:18:53Z","updated_at":"2017-01-24T04:18:57Z","pushed_at":"2017-08-09T12:02:13Z","git_url":"git://github.com/Team846/squants.git","ssh_url":"git@github.com:Team846/squants.git","clone_url":"https://github.com/Team846/squants.git","svn_url":"https://github.com/Team846/squants","homepage":"http://www.squants.com","size":4481,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typelevel:master","ref":"master","sha":"879aa397f15866b0b77c4110c6295f187f117ab4","user":{"login":"typelevel","id":3731824,"avatar_url":"https://avatars0.githubusercontent.com/u/3731824?v=4","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"repo":{"id":17484323,"name":"squants","full_name":"typelevel/squants","owner":{"login":"typelevel","id":3731824,"avatar_url":"https://avatars0.githubusercontent.com/u/3731824?v=4","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typelevel/squants","description":"The Scala API for Quantities, Units of Measure and Dimensional Analysis","fork":false,"url":"https://api.github.com/repos/typelevel/squants","forks_url":"https://api.github.com/repos/typelevel/squants/forks","keys_url":"https://api.github.com/repos/typelevel/squants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typelevel/squants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typelevel/squants/teams","hooks_url":"https://api.github.com/repos/typelevel/squants/hooks","issue_events_url":"https://api.github.com/repos/typelevel/squants/issues/events{/number}","events_url":"https://api.github.com/repos/typelevel/squants/events","assignees_url":"https://api.github.com/repos/typelevel/squants/assignees{/user}","branches_url":"https://api.github.com/repos/typelevel/squants/branches{/branch}","tags_url":"https://api.github.com/repos/typelevel/squants/tags","blobs_url":"https://api.github.com/repos/typelevel/squants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typelevel/squants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typelevel/squants/git/refs{/sha}","trees_url":"https://api.github.com/repos/typelevel/squants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typelevel/squants/statuses/{sha}","languages_url":"https://api.github.com/repos/typelevel/squants/languages","stargazers_url":"https://api.github.com/repos/typelevel/squants/stargazers","contributors_url":"https://api.github.com/repos/typelevel/squants/contributors","subscribers_url":"https://api.github.com/repos/typelevel/squants/subscribers","subscription_url":"https://api.github.com/repos/typelevel/squants/subscription","commits_url":"https://api.github.com/repos/typelevel/squants/commits{/sha}","git_commits_url":"https://api.github.com/repos/typelevel/squants/git/commits{/sha}","comments_url":"https://api.github.com/repos/typelevel/squants/comments{/number}","issue_comment_url":"https://api.github.com/repos/typelevel/squants/issues/comments{/number}","contents_url":"https://api.github.com/repos/typelevel/squants/contents/{+path}","compare_url":"https://api.github.com/repos/typelevel/squants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typelevel/squants/merges","archive_url":"https://api.github.com/repos/typelevel/squants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typelevel/squants/downloads","issues_url":"https://api.github.com/repos/typelevel/squants/issues{/number}","pulls_url":"https://api.github.com/repos/typelevel/squants/pulls{/number}","milestones_url":"https://api.github.com/repos/typelevel/squants/milestones{/number}","notifications_url":"https://api.github.com/repos/typelevel/squants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typelevel/squants/labels{/name}","releases_url":"https://api.github.com/repos/typelevel/squants/releases{/id}","deployments_url":"https://api.github.com/repos/typelevel/squants/deployments","created_at":"2014-03-06T16:28:32Z","updated_at":"2017-08-03T15:03:19Z","pushed_at":"2017-08-09T12:02:14Z","git_url":"git://github.com/typelevel/squants.git","ssh_url":"git@github.com:typelevel/squants.git","clone_url":"https://github.com/typelevel/squants.git","svn_url":"https://github.com/typelevel/squants","homepage":"http://www.squants.com","size":4498,"stargazers_count":429,"watchers_count":429,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":23,"forks":57,"open_issues":23,"watchers":429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typelevel/squants/pulls/282"},"html":{"href":"https://github.com/typelevel/squants/pull/282"},"issue":{"href":"https://api.github.com/repos/typelevel/squants/issues/282"},"comments":{"href":"https://api.github.com/repos/typelevel/squants/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/typelevel/squants/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/typelevel/squants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typelevel/squants/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/typelevel/squants/statuses/ff5ad8265f42ad43e11d0bd5a00d6947f3cc5b04"}}}}
{"actor":{"display_login":"derekmorr"}}