{"action":"created","comment":{"url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/comments/131645588","pull_request_review_id":54644131,"id":131645588,"diff_hunk":"@@ -31,3 +31,16 @@ services:\n       - '../../web-service/src/main/php:/srv/www/web-service/src/main/php:ro'\n       - '../../web-service/src/webapp:/srv/www/web-service/src/webapp:ro'\n \n+  # lb (linkerd) for MS and user profiling\n+  # for testing we are putting it in front iof the nginx\n+  l5d:\n+    image: buoyantio/linkerd:1.1.2\n+    links:\n+      - web-server\n+    ports:\n+      - \"4140:4140\" # Later 8080?\n+      - \"9990:9990\"\n+    volumes:\n+      - '../linkerd/linkerd.yaml:/usr/local/etc/linkerd/linkerd.yaml:ro'\n+    command: >\n+      /usr/local/etc/linkerd/linkerd.yaml","path":"config/docker/compose-dev.yml","position":16,"original_position":16,"commit_id":"407a4ae947344b011a4db7794694ae386de45bae","original_commit_id":"407a4ae947344b011a4db7794694ae386de45bae","user":{"login":"cwasser","id":7888714,"avatar_url":"https://avatars2.githubusercontent.com/u/7888714?v=4","gravatar_id":"","url":"https://api.github.com/users/cwasser","html_url":"https://github.com/cwasser","followers_url":"https://api.github.com/users/cwasser/followers","following_url":"https://api.github.com/users/cwasser/following{/other_user}","gists_url":"https://api.github.com/users/cwasser/gists{/gist_id}","starred_url":"https://api.github.com/users/cwasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwasser/subscriptions","organizations_url":"https://api.github.com/users/cwasser/orgs","repos_url":"https://api.github.com/users/cwasser/repos","events_url":"https://api.github.com/users/cwasser/events{/privacy}","received_events_url":"https://api.github.com/users/cwasser/received_events","type":"User","site_admin":false},"body":"Nope, we are passing it to the docker command used for building the container like :  ... `$ docker run --name linkerd -v `pwd`/config.yaml:/config.yaml buoyantio/linkerd:1.1.2 /config.yaml` ( https://linkerd.io/getting-started/docker/ )","created_at":"2017-08-07T12:51:27Z","updated_at":"2017-08-07T12:51:27Z","html_url":"https://github.com/Fleshgrinder/circleci-testing/pull/2#discussion_r131645588","pull_request_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/comments/131645588"},"html":{"href":"https://github.com/Fleshgrinder/circleci-testing/pull/2#discussion_r131645588"},"pull_request":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2","id":133944137,"html_url":"https://github.com/Fleshgrinder/circleci-testing/pull/2","diff_url":"https://github.com/Fleshgrinder/circleci-testing/pull/2.diff","patch_url":"https://github.com/Fleshgrinder/circleci-testing/pull/2.patch","issue_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/issues/2","number":2,"state":"open","locked":false,"title":"Add LinkerD config","user":{"login":"cwasser","id":7888714,"avatar_url":"https://avatars2.githubusercontent.com/u/7888714?v=4","gravatar_id":"","url":"https://api.github.com/users/cwasser","html_url":"https://github.com/cwasser","followers_url":"https://api.github.com/users/cwasser/followers","following_url":"https://api.github.com/users/cwasser/following{/other_user}","gists_url":"https://api.github.com/users/cwasser/gists{/gist_id}","starred_url":"https://api.github.com/users/cwasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwasser/subscriptions","organizations_url":"https://api.github.com/users/cwasser/orgs","repos_url":"https://api.github.com/users/cwasser/repos","events_url":"https://api.github.com/users/cwasser/events{/privacy}","received_events_url":"https://api.github.com/users/cwasser/received_events","type":"User","site_admin":false},"body":"Initial commit for setting up the linkerd container for the prod and dev server","created_at":"2017-08-03T13:27:33Z","updated_at":"2017-08-07T12:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"603ae7ce7ac1ad4a52835f1a62abbedbbf69c901","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/issues/2/comments","statuses_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/statuses/407a4ae947344b011a4db7794694ae386de45bae","head":{"label":"cwasser:master","ref":"master","sha":"407a4ae947344b011a4db7794694ae386de45bae","user":{"login":"cwasser","id":7888714,"avatar_url":"https://avatars2.githubusercontent.com/u/7888714?v=4","gravatar_id":"","url":"https://api.github.com/users/cwasser","html_url":"https://github.com/cwasser","followers_url":"https://api.github.com/users/cwasser/followers","following_url":"https://api.github.com/users/cwasser/following{/other_user}","gists_url":"https://api.github.com/users/cwasser/gists{/gist_id}","starred_url":"https://api.github.com/users/cwasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwasser/subscriptions","organizations_url":"https://api.github.com/users/cwasser/orgs","repos_url":"https://api.github.com/users/cwasser/repos","events_url":"https://api.github.com/users/cwasser/events{/privacy}","received_events_url":"https://api.github.com/users/cwasser/received_events","type":"User","site_admin":false},"repo":{"id":99235093,"name":"circleci-testing","full_name":"cwasser/circleci-testing","owner":{"login":"cwasser","id":7888714,"avatar_url":"https://avatars2.githubusercontent.com/u/7888714?v=4","gravatar_id":"","url":"https://api.github.com/users/cwasser","html_url":"https://github.com/cwasser","followers_url":"https://api.github.com/users/cwasser/followers","following_url":"https://api.github.com/users/cwasser/following{/other_user}","gists_url":"https://api.github.com/users/cwasser/gists{/gist_id}","starred_url":"https://api.github.com/users/cwasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwasser/subscriptions","organizations_url":"https://api.github.com/users/cwasser/orgs","repos_url":"https://api.github.com/users/cwasser/repos","events_url":"https://api.github.com/users/cwasser/events{/privacy}","received_events_url":"https://api.github.com/users/cwasser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwasser/circleci-testing","description":"A repository to test CircleCI 2.0 because the documentation is just not cutting it.","fork":true,"url":"https://api.github.com/repos/cwasser/circleci-testing","forks_url":"https://api.github.com/repos/cwasser/circleci-testing/forks","keys_url":"https://api.github.com/repos/cwasser/circleci-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwasser/circleci-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwasser/circleci-testing/teams","hooks_url":"https://api.github.com/repos/cwasser/circleci-testing/hooks","issue_events_url":"https://api.github.com/repos/cwasser/circleci-testing/issues/events{/number}","events_url":"https://api.github.com/repos/cwasser/circleci-testing/events","assignees_url":"https://api.github.com/repos/cwasser/circleci-testing/assignees{/user}","branches_url":"https://api.github.com/repos/cwasser/circleci-testing/branches{/branch}","tags_url":"https://api.github.com/repos/cwasser/circleci-testing/tags","blobs_url":"https://api.github.com/repos/cwasser/circleci-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwasser/circleci-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwasser/circleci-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwasser/circleci-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwasser/circleci-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/cwasser/circleci-testing/languages","stargazers_url":"https://api.github.com/repos/cwasser/circleci-testing/stargazers","contributors_url":"https://api.github.com/repos/cwasser/circleci-testing/contributors","subscribers_url":"https://api.github.com/repos/cwasser/circleci-testing/subscribers","subscription_url":"https://api.github.com/repos/cwasser/circleci-testing/subscription","commits_url":"https://api.github.com/repos/cwasser/circleci-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwasser/circleci-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwasser/circleci-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwasser/circleci-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwasser/circleci-testing/contents/{+path}","compare_url":"https://api.github.com/repos/cwasser/circleci-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwasser/circleci-testing/merges","archive_url":"https://api.github.com/repos/cwasser/circleci-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwasser/circleci-testing/downloads","issues_url":"https://api.github.com/repos/cwasser/circleci-testing/issues{/number}","pulls_url":"https://api.github.com/repos/cwasser/circleci-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/cwasser/circleci-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/cwasser/circleci-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwasser/circleci-testing/labels{/name}","releases_url":"https://api.github.com/repos/cwasser/circleci-testing/releases{/id}","deployments_url":"https://api.github.com/repos/cwasser/circleci-testing/deployments","created_at":"2017-08-03T13:23:48Z","updated_at":"2017-08-03T13:23:49Z","pushed_at":"2017-08-03T13:25:30Z","git_url":"git://github.com/cwasser/circleci-testing.git","ssh_url":"git@github.com:cwasser/circleci-testing.git","clone_url":"https://github.com/cwasser/circleci-testing.git","svn_url":"https://github.com/cwasser/circleci-testing","homepage":null,"size":767,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Fleshgrinder:master","ref":"master","sha":"54b66e443e7bbe5fb67af7ba6e34bae06abd8fdd","user":{"login":"Fleshgrinder","id":1059453,"avatar_url":"https://avatars3.githubusercontent.com/u/1059453?v=4","gravatar_id":"","url":"https://api.github.com/users/Fleshgrinder","html_url":"https://github.com/Fleshgrinder","followers_url":"https://api.github.com/users/Fleshgrinder/followers","following_url":"https://api.github.com/users/Fleshgrinder/following{/other_user}","gists_url":"https://api.github.com/users/Fleshgrinder/gists{/gist_id}","starred_url":"https://api.github.com/users/Fleshgrinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fleshgrinder/subscriptions","organizations_url":"https://api.github.com/users/Fleshgrinder/orgs","repos_url":"https://api.github.com/users/Fleshgrinder/repos","events_url":"https://api.github.com/users/Fleshgrinder/events{/privacy}","received_events_url":"https://api.github.com/users/Fleshgrinder/received_events","type":"User","site_admin":false},"repo":{"id":96561338,"name":"circleci-testing","full_name":"Fleshgrinder/circleci-testing","owner":{"login":"Fleshgrinder","id":1059453,"avatar_url":"https://avatars3.githubusercontent.com/u/1059453?v=4","gravatar_id":"","url":"https://api.github.com/users/Fleshgrinder","html_url":"https://github.com/Fleshgrinder","followers_url":"https://api.github.com/users/Fleshgrinder/followers","following_url":"https://api.github.com/users/Fleshgrinder/following{/other_user}","gists_url":"https://api.github.com/users/Fleshgrinder/gists{/gist_id}","starred_url":"https://api.github.com/users/Fleshgrinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fleshgrinder/subscriptions","organizations_url":"https://api.github.com/users/Fleshgrinder/orgs","repos_url":"https://api.github.com/users/Fleshgrinder/repos","events_url":"https://api.github.com/users/Fleshgrinder/events{/privacy}","received_events_url":"https://api.github.com/users/Fleshgrinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fleshgrinder/circleci-testing","description":"A repository to test CircleCI 2.0 because the documentation is just not cutting it.","fork":false,"url":"https://api.github.com/repos/Fleshgrinder/circleci-testing","forks_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/forks","keys_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/teams","hooks_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/hooks","issue_events_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/issues/events{/number}","events_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/events","assignees_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/assignees{/user}","branches_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/branches{/branch}","tags_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/tags","blobs_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/languages","stargazers_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/stargazers","contributors_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/contributors","subscribers_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/subscribers","subscription_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/subscription","commits_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/contents/{+path}","compare_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/merges","archive_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/downloads","issues_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/issues{/number}","pulls_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/labels{/name}","releases_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/releases{/id}","deployments_url":"https://api.github.com/repos/Fleshgrinder/circleci-testing/deployments","created_at":"2017-07-07T17:33:44Z","updated_at":"2017-07-14T08:03:37Z","pushed_at":"2017-08-07T09:50:03Z","git_url":"git://github.com/Fleshgrinder/circleci-testing.git","ssh_url":"git@github.com:Fleshgrinder/circleci-testing.git","clone_url":"https://github.com/Fleshgrinder/circleci-testing.git","svn_url":"https://github.com/Fleshgrinder/circleci-testing","homepage":null,"size":791,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2"},"html":{"href":"https://github.com/Fleshgrinder/circleci-testing/pull/2"},"issue":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/issues/2"},"comments":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Fleshgrinder/circleci-testing/statuses/407a4ae947344b011a4db7794694ae386de45bae"}}}}
{"actor":{"display_login":"cwasser"}}