{"action":"created","issue":{"url":"https://api.github.com/repos/servo/webrender/issues/1908","repository_url":"https://api.github.com/repos/servo/webrender","labels_url":"https://api.github.com/repos/servo/webrender/issues/1908/labels{/name}","comments_url":"https://api.github.com/repos/servo/webrender/issues/1908/comments","events_url":"https://api.github.com/repos/servo/webrender/issues/1908/events","html_url":"https://github.com/servo/webrender/pull/1908","id":267608636,"number":1908,"title":"Fix premultiplied problem for box shadow.","user":{"login":"demo99","id":9673799,"avatar_url":"https://avatars0.githubusercontent.com/u/9673799?v=4","gravatar_id":"","url":"https://api.github.com/users/demo99","html_url":"https://github.com/demo99","followers_url":"https://api.github.com/users/demo99/followers","following_url":"https://api.github.com/users/demo99/following{/other_user}","gists_url":"https://api.github.com/users/demo99/gists{/gist_id}","starred_url":"https://api.github.com/users/demo99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demo99/subscriptions","organizations_url":"https://api.github.com/users/demo99/orgs","repos_url":"https://api.github.com/users/demo99/repos","events_url":"https://api.github.com/users/demo99/events{/privacy}","received_events_url":"https://api.github.com/users/demo99/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-23T09:59:08Z","updated_at":"2017-10-23T19:57:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/servo/webrender/pulls/1908","html_url":"https://github.com/servo/webrender/pull/1908","diff_url":"https://github.com/servo/webrender/pull/1908.diff","patch_url":"https://github.com/servo/webrender/pull/1908.patch"},"body":"There is a gecko[ bug 1410305](https://bugzilla.mozilla.org/show_bug.cgi?id=1410305) about the wrong rendering result of the box-shadow. It should be premultiplied alpha problem. We take the picture's blend mode as PremultipliedAlpha[1]. So I multiply the color's alpha when applying the blur texture. I'm not sure if it's a good place to do this.\r\n\r\n[1]https://github.com/servo/webrender/blob/d741f472dd3d6c3441646f7bf4e714c71bea39b7/webrender/src/tiling.rs#L70\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/webrender/1908)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/webrender/issues/comments/338778207","html_url":"https://github.com/servo/webrender/pull/1908#issuecomment-338778207","issue_url":"https://api.github.com/repos/servo/webrender/issues/1908","id":338778207,"user":{"login":"glennw","id":2350882,"avatar_url":"https://avatars0.githubusercontent.com/u/2350882?v=4","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"created_at":"2017-10-23T19:57:53Z","updated_at":"2017-10-23T19:57:53Z","author_association":"MEMBER","body":"A wrench reftest would also be good to have, so we don't regress this.\r\n"}}
{"actor":{"display_login":"glennw"}}