{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/flow/pulls/comments/156864017","pull_request_review_id":83408441,"id":156864017,"diff_hunk":"@@ -0,0 +1,81 @@\n+/*\n+ * Copyright 2000-2017 Vaadin Ltd.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package com.vaadin.ui.renderers;\n+\n+import java.util.concurrent.atomic.AtomicInteger;\n+\n+import com.vaadin.function.ValueProvider;\n+\n+/**\n+ * \n+ * Abstract template renderer used as the base implementation for renderers that\n+ * outputs a simple value in the UI, such as {@link NumberRenderer} and\n+ * {@link LocalDateRenderer}.\n+ * <p>\n+ * It extends {@link TemplateRenderer}, so it expects the components to be\n+ * stamped in a {@code <template>} element.\n+ * \n+ * @author Vaadin Ltd.\n+ *\n+ * @param <SOURCE>\n+ *            the type of the item used inside the renderer\n+ * @param <TARGET>\n+ *            the type of the output object, such as Number or LocalDate\n+ */\n+public abstract class SimpleValueTemplateRenderer<SOURCE, TARGET>\n+        extends TemplateRenderer<SOURCE> {\n+\n+    private static AtomicInteger RENDERER_ID_GENERATOR = new AtomicInteger();","path":"flow-server/src/main/java/com/vaadin/ui/renderers/SimpleValueTemplateRenderer.java","position":41,"original_position":41,"commit_id":"ea158d73542e8542eaeb020feb3fa01efc64bfee","original_commit_id":"ea158d73542e8542eaeb020feb3fa01efc64bfee","user":{"login":"vaadin-bot","id":20280877,"avatar_url":"https://avatars1.githubusercontent.com/u/20280877?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin-bot","html_url":"https://github.com/vaadin-bot","followers_url":"https://api.github.com/users/vaadin-bot/followers","following_url":"https://api.github.com/users/vaadin-bot/following{/other_user}","gists_url":"https://api.github.com/users/vaadin-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin-bot/subscriptions","organizations_url":"https://api.github.com/users/vaadin-bot/orgs","repos_url":"https://api.github.com/users/vaadin-bot/repos","events_url":"https://api.github.com/users/vaadin-bot/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin-bot/received_events","type":"User","site_admin":false},"body":"![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Rename this field \"RENDERER_ID_GENERATOR\" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS3008)\n","created_at":"2017-12-14T06:34:20Z","updated_at":"2017-12-14T06:34:20Z","html_url":"https://github.com/vaadin/flow/pull/3144#discussion_r156864017","pull_request_url":"https://api.github.com/repos/vaadin/flow/pulls/3144","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vaadin/flow/pulls/comments/156864017"},"html":{"href":"https://github.com/vaadin/flow/pull/3144#discussion_r156864017"},"pull_request":{"href":"https://api.github.com/repos/vaadin/flow/pulls/3144"}}},"pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/3144","id":158027029,"html_url":"https://github.com/vaadin/flow/pull/3144","diff_url":"https://github.com/vaadin/flow/pull/3144.diff","patch_url":"https://github.com/vaadin/flow/pull/3144.patch","issue_url":"https://api.github.com/repos/vaadin/flow/issues/3144","number":3144,"state":"open","locked":false,"title":"Add basic template renderers.","user":{"login":"gilberto-torrezan","id":7464735,"avatar_url":"https://avatars2.githubusercontent.com/u/7464735?v=4","gravatar_id":"","url":"https://api.github.com/users/gilberto-torrezan","html_url":"https://github.com/gilberto-torrezan","followers_url":"https://api.github.com/users/gilberto-torrezan/followers","following_url":"https://api.github.com/users/gilberto-torrezan/following{/other_user}","gists_url":"https://api.github.com/users/gilberto-torrezan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilberto-torrezan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilberto-torrezan/subscriptions","organizations_url":"https://api.github.com/users/gilberto-torrezan/orgs","repos_url":"https://api.github.com/users/gilberto-torrezan/repos","events_url":"https://api.github.com/users/gilberto-torrezan/events{/privacy}","received_events_url":"https://api.github.com/users/gilberto-torrezan/received_events","type":"User","site_admin":false},"body":"A demo with all the renderers will be pushed to `vaadin-grid-flow`.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/3144)\n<!-- Reviewable:end -->\n","created_at":"2017-12-13T08:08:57Z","updated_at":"2017-12-14T06:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28a62424dabece4694b393b9a06b2fd0fbde861f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ahie","id":6600210,"avatar_url":"https://avatars3.githubusercontent.com/u/6600210?v=4","gravatar_id":"","url":"https://api.github.com/users/ahie","html_url":"https://github.com/ahie","followers_url":"https://api.github.com/users/ahie/followers","following_url":"https://api.github.com/users/ahie/following{/other_user}","gists_url":"https://api.github.com/users/ahie/gists{/gist_id}","starred_url":"https://api.github.com/users/ahie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahie/subscriptions","organizations_url":"https://api.github.com/users/ahie/orgs","repos_url":"https://api.github.com/users/ahie/repos","events_url":"https://api.github.com/users/ahie/events{/privacy}","received_events_url":"https://api.github.com/users/ahie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/flow/pulls/3144/commits","review_comments_url":"https://api.github.com/repos/vaadin/flow/pulls/3144/comments","review_comment_url":"https://api.github.com/repos/vaadin/flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/3144/comments","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/ea158d73542e8542eaeb020feb3fa01efc64bfee","head":{"label":"vaadin:gilberto/basic_renderers","ref":"gilberto/basic_renderers","sha":"ea158d73542e8542eaeb020feb3fa01efc64bfee","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":34809191,"name":"flow","full_name":"vaadin/flow","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/flow","description":"Flow is a Java framework for building modern web sites that look great and perform well.","fork":false,"url":"https://api.github.com/repos/vaadin/flow","forks_url":"https://api.github.com/repos/vaadin/flow/forks","keys_url":"https://api.github.com/repos/vaadin/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/flow/teams","hooks_url":"https://api.github.com/repos/vaadin/flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/flow/events","assignees_url":"https://api.github.com/repos/vaadin/flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/flow/tags","blobs_url":"https://api.github.com/repos/vaadin/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/flow/subscription","commits_url":"https://api.github.com/repos/vaadin/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/flow/merges","archive_url":"https://api.github.com/repos/vaadin/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/flow/downloads","issues_url":"https://api.github.com/repos/vaadin/flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/flow/deployments","created_at":"2015-04-29T17:54:35Z","updated_at":"2017-12-13T09:03:52Z","pushed_at":"2017-12-14T06:19:21Z","git_url":"git://github.com/vaadin/flow.git","ssh_url":"git@github.com:vaadin/flow.git","clone_url":"https://github.com/vaadin/flow.git","svn_url":"https://github.com/vaadin/flow","homepage":"","size":104202,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":370,"watchers":46,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"b41ee24f06b2f95ac8cdf46c25c45f77ddf16aea","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":34809191,"name":"flow","full_name":"vaadin/flow","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/flow","description":"Flow is a Java framework for building modern web sites that look great and perform well.","fork":false,"url":"https://api.github.com/repos/vaadin/flow","forks_url":"https://api.github.com/repos/vaadin/flow/forks","keys_url":"https://api.github.com/repos/vaadin/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/flow/teams","hooks_url":"https://api.github.com/repos/vaadin/flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/flow/events","assignees_url":"https://api.github.com/repos/vaadin/flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/flow/tags","blobs_url":"https://api.github.com/repos/vaadin/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/flow/subscription","commits_url":"https://api.github.com/repos/vaadin/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/flow/merges","archive_url":"https://api.github.com/repos/vaadin/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/flow/downloads","issues_url":"https://api.github.com/repos/vaadin/flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/flow/deployments","created_at":"2015-04-29T17:54:35Z","updated_at":"2017-12-13T09:03:52Z","pushed_at":"2017-12-14T06:19:21Z","git_url":"git://github.com/vaadin/flow.git","ssh_url":"git@github.com:vaadin/flow.git","clone_url":"https://github.com/vaadin/flow.git","svn_url":"https://github.com/vaadin/flow","homepage":"","size":104202,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":370,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/flow/pulls/3144"},"html":{"href":"https://github.com/vaadin/flow/pull/3144"},"issue":{"href":"https://api.github.com/repos/vaadin/flow/issues/3144"},"comments":{"href":"https://api.github.com/repos/vaadin/flow/issues/3144/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/flow/pulls/3144/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/flow/pulls/3144/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/flow/statuses/ea158d73542e8542eaeb020feb3fa01efc64bfee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vaadin-bot"}}