{"action":"created","issue":{"url":"https://api.github.com/repos/google/conscrypt/issues/65","repository_url":"https://api.github.com/repos/google/conscrypt","labels_url":"https://api.github.com/repos/google/conscrypt/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/google/conscrypt/issues/65/comments","events_url":"https://api.github.com/repos/google/conscrypt/issues/65/events","html_url":"https://github.com/google/conscrypt/issues/65","id":203259510,"number":65,"title":"Replace socket with new engine-based version","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"labels":[{"id":499393977,"url":"https://api.github.com/repos/google/conscrypt/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"flooey","id":215991,"avatar_url":"https://avatars2.githubusercontent.com/u/215991?v=4","gravatar_id":"","url":"https://api.github.com/users/flooey","html_url":"https://github.com/flooey","followers_url":"https://api.github.com/users/flooey/followers","following_url":"https://api.github.com/users/flooey/following{/other_user}","gists_url":"https://api.github.com/users/flooey/gists{/gist_id}","starred_url":"https://api.github.com/users/flooey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flooey/subscriptions","organizations_url":"https://api.github.com/users/flooey/orgs","repos_url":"https://api.github.com/users/flooey/repos","events_url":"https://api.github.com/users/flooey/events{/privacy}","received_events_url":"https://api.github.com/users/flooey/received_events","type":"User","site_admin":false},"assignees":[{"login":"flooey","id":215991,"avatar_url":"https://avatars2.githubusercontent.com/u/215991?v=4","gravatar_id":"","url":"https://api.github.com/users/flooey","html_url":"https://github.com/flooey","followers_url":"https://api.github.com/users/flooey/followers","following_url":"https://api.github.com/users/flooey/following{/other_user}","gists_url":"https://api.github.com/users/flooey/gists{/gist_id}","starred_url":"https://api.github.com/users/flooey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flooey/subscriptions","organizations_url":"https://api.github.com/users/flooey/orgs","repos_url":"https://api.github.com/users/flooey/repos","events_url":"https://api.github.com/users/flooey/events{/privacy}","received_events_url":"https://api.github.com/users/flooey/received_events","type":"User","site_admin":false},{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/conscrypt/milestones/2","html_url":"https://github.com/google/conscrypt/milestone/2","labels_url":"https://api.github.com/repos/google/conscrypt/milestones/2/labels","id":2351504,"number":2,"title":"1.0.1","description":"Patch release for 1.0.x","creator":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":5,"state":"open","created_at":"2017-02-27T21:42:59Z","updated_at":"2017-08-18T17:15:48Z","due_on":"2017-08-31T07:00:00Z","closed_at":null},"comments":12,"created_at":"2017-01-26T00:04:59Z","updated_at":"2017-08-22T15:26:32Z","closed_at":null,"body":"In order to do this, we need to verify correctness and performance of the new socket.\r\n\r\n@kruton  I'll assign this to both of us since I suspect this will require some work."},"comment":{"url":"https://api.github.com/repos/google/conscrypt/issues/comments/324062090","html_url":"https://github.com/google/conscrypt/issues/65#issuecomment-324062090","issue_url":"https://api.github.com/repos/google/conscrypt/issues/65","id":324062090,"user":{"login":"dave-r12","id":1520761,"avatar_url":"https://avatars2.githubusercontent.com/u/1520761?v=4","gravatar_id":"","url":"https://api.github.com/users/dave-r12","html_url":"https://github.com/dave-r12","followers_url":"https://api.github.com/users/dave-r12/followers","following_url":"https://api.github.com/users/dave-r12/following{/other_user}","gists_url":"https://api.github.com/users/dave-r12/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-r12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-r12/subscriptions","organizations_url":"https://api.github.com/users/dave-r12/orgs","repos_url":"https://api.github.com/users/dave-r12/repos","events_url":"https://api.github.com/users/dave-r12/events{/privacy}","received_events_url":"https://api.github.com/users/dave-r12/received_events","type":"User","site_admin":false},"created_at":"2017-08-22T15:26:32Z","updated_at":"2017-08-22T15:26:32Z","body":"> The engine-based socket currently uses the underlying socket's streams directly.\r\n\r\nGotcha, thanks. I believe that answers my question (assuming you don't change the implementation.)\r\n\r\n> I'm assuming that you are currently using the FD-based socket? What is your byte-counting strategy for that?\r\n\r\nI'm stuck 'cause it's making JNI calls. The only other idea I had was to use an `SSLEngine` and do everything manually. I'm nervous though, I don't want to screw up security! And I've read it wasn't given much love in earlier versions of Android."}}
{"actor":{"display_login":"dave-r12"}}