{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/3","id":107887745,"html_url":"https://github.com/matthewepler/mqtt_docker_challenge/pull/3","diff_url":"https://github.com/matthewepler/mqtt_docker_challenge/pull/3.diff","patch_url":"https://github.com/matthewepler/mqtt_docker_challenge/pull/3.patch","issue_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/issues/3","number":3,"state":"closed","locked":false,"title":"pushing the work we did together and a few fixes","user":{"login":"mansona","id":594890,"avatar_url":"https://avatars.githubusercontent.com/u/594890?v=3","gravatar_id":"","url":"https://api.github.com/users/mansona","html_url":"https://github.com/mansona","followers_url":"https://api.github.com/users/mansona/followers","following_url":"https://api.github.com/users/mansona/following{/other_user}","gists_url":"https://api.github.com/users/mansona/gists{/gist_id}","starred_url":"https://api.github.com/users/mansona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansona/subscriptions","organizations_url":"https://api.github.com/users/mansona/orgs","repos_url":"https://api.github.com/users/mansona/repos","events_url":"https://api.github.com/users/mansona/events{/privacy}","received_events_url":"https://api.github.com/users/mansona/received_events","type":"User","site_admin":false},"body":"A few things to note:\r\n\r\n* this is not strictly working at the moment in the \"non mocha\" running case. It doesn't seem to be building but I would imagine this is because you've removed a lot of the webpack config\r\n* this now working including sending messages in the mocha franken-environment. There is a strange webpack thing that is building the index.js into the test \"bundle\" but again I don't know enough about webpack to debug this\r\n* I have stopped tracking client/test/bundle.js because you shouldn't really commit compiled code. Was there a default webpack .gitignore file that you had when you started this?","created_at":"2017-02-24T18:57:03Z","updated_at":"2017-02-24T21:23:30Z","closed_at":"2017-02-24T21:23:30Z","merged_at":"2017-02-24T21:23:30Z","merge_commit_sha":"de85dfe59738a5b35c7710fc5513997f2f45301f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/3/commits","review_comments_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/3/comments","review_comment_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/issues/3/comments","statuses_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/statuses/7d87352718add2f4514982a24778c65ca3c2967c","head":{"label":"stonecircle:feature/codeMentorWork","ref":"feature/codeMentorWork","sha":"7d87352718add2f4514982a24778c65ca3c2967c","user":{"login":"stonecircle","id":15382417,"avatar_url":"https://avatars.githubusercontent.com/u/15382417?v=3","gravatar_id":"","url":"https://api.github.com/users/stonecircle","html_url":"https://github.com/stonecircle","followers_url":"https://api.github.com/users/stonecircle/followers","following_url":"https://api.github.com/users/stonecircle/following{/other_user}","gists_url":"https://api.github.com/users/stonecircle/gists{/gist_id}","starred_url":"https://api.github.com/users/stonecircle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonecircle/subscriptions","organizations_url":"https://api.github.com/users/stonecircle/orgs","repos_url":"https://api.github.com/users/stonecircle/repos","events_url":"https://api.github.com/users/stonecircle/events{/privacy}","received_events_url":"https://api.github.com/users/stonecircle/received_events","type":"Organization","site_admin":false},"repo":{"id":83073044,"name":"mqtt_docker_challenge","full_name":"stonecircle/mqtt_docker_challenge","owner":{"login":"stonecircle","id":15382417,"avatar_url":"https://avatars.githubusercontent.com/u/15382417?v=3","gravatar_id":"","url":"https://api.github.com/users/stonecircle","html_url":"https://github.com/stonecircle","followers_url":"https://api.github.com/users/stonecircle/followers","following_url":"https://api.github.com/users/stonecircle/following{/other_user}","gists_url":"https://api.github.com/users/stonecircle/gists{/gist_id}","starred_url":"https://api.github.com/users/stonecircle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonecircle/subscriptions","organizations_url":"https://api.github.com/users/stonecircle/orgs","repos_url":"https://api.github.com/users/stonecircle/repos","events_url":"https://api.github.com/users/stonecircle/events{/privacy}","received_events_url":"https://api.github.com/users/stonecircle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stonecircle/mqtt_docker_challenge","description":"A challenge from a senior dev to build an mqtt broker/client chat application using docker containers.","fork":true,"url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge","forks_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/forks","keys_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/teams","hooks_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/hooks","issue_events_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/issues/events{/number}","events_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/events","assignees_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/assignees{/user}","branches_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/branches{/branch}","tags_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/tags","blobs_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/languages","stargazers_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/stargazers","contributors_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/contributors","subscribers_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/subscribers","subscription_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/subscription","commits_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/contents/{+path}","compare_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/merges","archive_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/downloads","issues_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/issues{/number}","pulls_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/labels{/name}","releases_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/releases{/id}","deployments_url":"https://api.github.com/repos/stonecircle/mqtt_docker_challenge/deployments","created_at":"2017-02-24T18:56:01Z","updated_at":"2017-02-24T18:56:03Z","pushed_at":"2017-02-24T18:56:46Z","git_url":"git://github.com/stonecircle/mqtt_docker_challenge.git","ssh_url":"git@github.com:stonecircle/mqtt_docker_challenge.git","clone_url":"https://github.com/stonecircle/mqtt_docker_challenge.git","svn_url":"https://github.com/stonecircle/mqtt_docker_challenge","homepage":null,"size":384,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matthewepler:dev","ref":"dev","sha":"27769008546726933077e9018c663507096f98f2","user":{"login":"matthewepler","id":1224277,"avatar_url":"https://avatars.githubusercontent.com/u/1224277?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewepler","html_url":"https://github.com/matthewepler","followers_url":"https://api.github.com/users/matthewepler/followers","following_url":"https://api.github.com/users/matthewepler/following{/other_user}","gists_url":"https://api.github.com/users/matthewepler/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewepler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewepler/subscriptions","organizations_url":"https://api.github.com/users/matthewepler/orgs","repos_url":"https://api.github.com/users/matthewepler/repos","events_url":"https://api.github.com/users/matthewepler/events{/privacy}","received_events_url":"https://api.github.com/users/matthewepler/received_events","type":"User","site_admin":false},"repo":{"id":81140165,"name":"mqtt_docker_challenge","full_name":"matthewepler/mqtt_docker_challenge","owner":{"login":"matthewepler","id":1224277,"avatar_url":"https://avatars.githubusercontent.com/u/1224277?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewepler","html_url":"https://github.com/matthewepler","followers_url":"https://api.github.com/users/matthewepler/followers","following_url":"https://api.github.com/users/matthewepler/following{/other_user}","gists_url":"https://api.github.com/users/matthewepler/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewepler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewepler/subscriptions","organizations_url":"https://api.github.com/users/matthewepler/orgs","repos_url":"https://api.github.com/users/matthewepler/repos","events_url":"https://api.github.com/users/matthewepler/events{/privacy}","received_events_url":"https://api.github.com/users/matthewepler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewepler/mqtt_docker_challenge","description":"A challenge from a senior dev to build an mqtt broker/client chat application using docker containers.","fork":false,"url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge","forks_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/forks","keys_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/teams","hooks_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/hooks","issue_events_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/issues/events{/number}","events_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/events","assignees_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/assignees{/user}","branches_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/branches{/branch}","tags_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/tags","blobs_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/languages","stargazers_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/stargazers","contributors_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/contributors","subscribers_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/subscribers","subscription_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/subscription","commits_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/contents/{+path}","compare_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/merges","archive_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/downloads","issues_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/issues{/number}","pulls_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/labels{/name}","releases_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/releases{/id}","deployments_url":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/deployments","created_at":"2017-02-06T22:27:42Z","updated_at":"2017-02-06T22:29:37Z","pushed_at":"2017-02-24T21:23:30Z","git_url":"git://github.com/matthewepler/mqtt_docker_challenge.git","ssh_url":"git@github.com:matthewepler/mqtt_docker_challenge.git","clone_url":"https://github.com/matthewepler/mqtt_docker_challenge.git","svn_url":"https://github.com/matthewepler/mqtt_docker_challenge","homepage":null,"size":381,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/3"},"html":{"href":"https://github.com/matthewepler/mqtt_docker_challenge/pull/3"},"issue":{"href":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/issues/3"},"comments":{"href":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/matthewepler/mqtt_docker_challenge/statuses/7d87352718add2f4514982a24778c65ca3c2967c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matthewepler","id":1224277,"avatar_url":"https://avatars.githubusercontent.com/u/1224277?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewepler","html_url":"https://github.com/matthewepler","followers_url":"https://api.github.com/users/matthewepler/followers","following_url":"https://api.github.com/users/matthewepler/following{/other_user}","gists_url":"https://api.github.com/users/matthewepler/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewepler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewepler/subscriptions","organizations_url":"https://api.github.com/users/matthewepler/orgs","repos_url":"https://api.github.com/users/matthewepler/repos","events_url":"https://api.github.com/users/matthewepler/events{/privacy}","received_events_url":"https://api.github.com/users/matthewepler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":199,"deletions":11721,"changed_files":7}}
{"actor":{"display_login":"matthewepler"}}