{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/132042321","pull_request_review_id":55082383,"id":132042321,"diff_hunk":"@@ -1,483 +1,505 @@\n #include <iostream>\n-#include <vector>\n #include <memory>\n+#include <vector>\n \n // Framework\n #include \"FWCore/MessageLogger/interface/MessageLogger.h\"\n #include \"FWCore/Utilities/interface/Exception.h\"\n \n #include \"CommonTools/Utils/interface/StringToEnumValue.h\"\n \n-#include \"Geometry/Records/interface/CaloGeometryRecord.h\"\n+#include \"Geometry/CaloEventSetup/interface/CaloTopologyRecord.h\"\n #include \"Geometry/CaloGeometry/interface/CaloSubdetectorGeometry.h\"\n #include \"Geometry/CaloTopology/interface/CaloTopology.h\"\n-#include \"Geometry/CaloEventSetup/interface/CaloTopologyRecord.h\"\n-\n+#include \"Geometry/Records/interface/CaloGeometryRecord.h\"\n \n-#include \"DataFormats/VertexReco/interface/Vertex.h\"\n-#include \"DataFormats/VertexReco/interface/VertexFwd.h\"\n-#include \"DataFormats/EgammaReco/interface/ClusterShape.h\"\n-#include \"DataFormats/EgammaCandidates/interface/PhotonCore.h\"\n+#include \"DataFormats/EgammaCandidates/interface/Conversion.h\"\n #include \"DataFormats/EgammaCandidates/interface/Photon.h\"\n+#include \"DataFormats/EgammaCandidates/interface/PhotonCore.h\"\n #include \"DataFormats/EgammaCandidates/interface/PhotonFwd.h\"\n-#include \"DataFormats/EgammaCandidates/interface/Conversion.h\"\n+#include \"DataFormats/EgammaReco/interface/ClusterShape.h\"\n+#include \"DataFormats/VertexReco/interface/Vertex.h\"\n+#include \"DataFormats/VertexReco/interface/VertexFwd.h\"","path":"RecoEgamma/EgammaPhotonProducers/src/PhotonProducer.cc","position":31,"original_position":31,"commit_id":"42f7ee48a46c221d6ee180a57d95ff7e4d38c432","original_commit_id":"42f7ee48a46c221d6ee180a57d95ff7e4d38c432","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars0.githubusercontent.com/u/4672808?v=4","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"body":"I think that's due to use of clang-format (alphabetical)","created_at":"2017-08-08T21:49:25Z","updated_at":"2017-08-08T21:49:25Z","html_url":"https://github.com/cms-sw/cmssw/pull/20045#discussion_r132042321","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/132042321"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/20045#discussion_r132042321"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045","id":133960757,"html_url":"https://github.com/cms-sw/cmssw/pull/20045","diff_url":"https://github.com/cms-sw/cmssw/pull/20045.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/20045.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20045","number":20045,"state":"open","locked":false,"title":"Add MultiCluster derived electrons and photons","user":{"login":"rovere","id":1169991,"avatar_url":"https://avatars3.githubusercontent.com/u/1169991?v=4","gravatar_id":"","url":"https://api.github.com/users/rovere","html_url":"https://github.com/rovere","followers_url":"https://api.github.com/users/rovere/followers","following_url":"https://api.github.com/users/rovere/following{/other_user}","gists_url":"https://api.github.com/users/rovere/gists{/gist_id}","starred_url":"https://api.github.com/users/rovere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovere/subscriptions","organizations_url":"https://api.github.com/users/rovere/orgs","repos_url":"https://api.github.com/users/rovere/repos","events_url":"https://api.github.com/users/rovere/events{/privacy}","received_events_url":"https://api.github.com/users/rovere/received_events","type":"User","site_admin":false},"body":"This PR will introduce new collections for electrons and photons derived from HGCal multiclusters.\r\n\r\nMore details could be fetched from here: [link](https://indico.cern.ch/event/657291/contributions/2678274/attachments/1502772/2341217/20170802_HGCal_TDR_FromMultiCl_UPSG_MR.pdf)\r\n\r\nI expect no regression at all. The affected workflows are the ones using HGCal-PhaseII era.\r\n\r\nI also profited from the existing EGamma-POG DQM to monitor the newly created collections. Yet, minimal changes had to be introduced also there, but the final output for regular (i.e. non-upgrade) workflows should be identical.\r\n\r\n@felicepantaleo @malgeri @cseez @kpedro88 ","created_at":"2017-08-03T14:35:24Z","updated_at":"2017-08-08T21:49:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"420ced8390729f2630a9e409b1401ede6e991a89","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69","html_url":"https://github.com/cms-sw/cmssw/milestone/69","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69/labels","id":2604328,"number":69,"title":"CMSSW_9_3_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":429,"state":"open","created_at":"2017-06-26T12:15:20Z","updated_at":"2017-08-08T20:54:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20045/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/42f7ee48a46c221d6ee180a57d95ff7e4d38c432","head":{"label":"rovere:HGCal_TDR","ref":"HGCal_TDR","sha":"42f7ee48a46c221d6ee180a57d95ff7e4d38c432","user":{"login":"rovere","id":1169991,"avatar_url":"https://avatars3.githubusercontent.com/u/1169991?v=4","gravatar_id":"","url":"https://api.github.com/users/rovere","html_url":"https://github.com/rovere","followers_url":"https://api.github.com/users/rovere/followers","following_url":"https://api.github.com/users/rovere/following{/other_user}","gists_url":"https://api.github.com/users/rovere/gists{/gist_id}","starred_url":"https://api.github.com/users/rovere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovere/subscriptions","organizations_url":"https://api.github.com/users/rovere/orgs","repos_url":"https://api.github.com/users/rovere/repos","events_url":"https://api.github.com/users/rovere/events{/privacy}","received_events_url":"https://api.github.com/users/rovere/received_events","type":"User","site_admin":false},"repo":{"id":11121322,"name":"cmssw","full_name":"rovere/cmssw","owner":{"login":"rovere","id":1169991,"avatar_url":"https://avatars3.githubusercontent.com/u/1169991?v=4","gravatar_id":"","url":"https://api.github.com/users/rovere","html_url":"https://github.com/rovere","followers_url":"https://api.github.com/users/rovere/followers","following_url":"https://api.github.com/users/rovere/following{/other_user}","gists_url":"https://api.github.com/users/rovere/gists{/gist_id}","starred_url":"https://api.github.com/users/rovere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovere/subscriptions","organizations_url":"https://api.github.com/users/rovere/orgs","repos_url":"https://api.github.com/users/rovere/repos","events_url":"https://api.github.com/users/rovere/events{/privacy}","received_events_url":"https://api.github.com/users/rovere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rovere/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/rovere/cmssw","forks_url":"https://api.github.com/repos/rovere/cmssw/forks","keys_url":"https://api.github.com/repos/rovere/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rovere/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rovere/cmssw/teams","hooks_url":"https://api.github.com/repos/rovere/cmssw/hooks","issue_events_url":"https://api.github.com/repos/rovere/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/rovere/cmssw/events","assignees_url":"https://api.github.com/repos/rovere/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/rovere/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/rovere/cmssw/tags","blobs_url":"https://api.github.com/repos/rovere/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rovere/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rovere/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/rovere/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rovere/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/rovere/cmssw/languages","stargazers_url":"https://api.github.com/repos/rovere/cmssw/stargazers","contributors_url":"https://api.github.com/repos/rovere/cmssw/contributors","subscribers_url":"https://api.github.com/repos/rovere/cmssw/subscribers","subscription_url":"https://api.github.com/repos/rovere/cmssw/subscription","commits_url":"https://api.github.com/repos/rovere/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/rovere/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/rovere/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/rovere/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/rovere/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/rovere/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rovere/cmssw/merges","archive_url":"https://api.github.com/repos/rovere/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rovere/cmssw/downloads","issues_url":"https://api.github.com/repos/rovere/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/rovere/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/rovere/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/rovere/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rovere/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/rovere/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/rovere/cmssw/deployments","created_at":"2013-07-02T09:19:27Z","updated_at":"2014-06-04T19:39:16Z","pushed_at":"2017-08-07T07:27:51Z","git_url":"git://github.com/rovere/cmssw.git","ssh_url":"git@github.com:rovere/cmssw.git","clone_url":"https://github.com/rovere/cmssw.git","svn_url":"https://github.com/rovere/cmssw","homepage":"cms-sw.github.io/cmssw","size":897595,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"d01cee8891c03829b5a8d7c852cb648f2ff8b4f3","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-08-06T21:30:55Z","pushed_at":"2017-08-08T21:09:20Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":961346,"stargazers_count":430,"watchers_count":430,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2288,"mirror_url":null,"open_issues_count":410,"forks":2288,"open_issues":410,"watchers":430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/20045"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/20045"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/20045/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20045/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/42f7ee48a46c221d6ee180a57d95ff7e4d38c432"}}}}
{"actor":{"display_login":"kpedro88"}}