{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/bond/pulls/comments/130755881","pull_request_review_id":53666617,"id":130755881,"diff_hunk":"@@ -1828,10 +1956,8 @@ public final void serialize(\n             FloatBondType.serializePrimitiveSomethingField(context, value, this);\n         }\n \n-        public final SomethingFloat deserialize(\n-                TaggedDeserializationContext context, boolean wasAlreadyDeserialized) throws IOException {\n-            this.verifyFieldWasNotYetDeserialized(wasAlreadyDeserialized);\n-            return FloatBondType.deserializePrimitiveSomethingField(context, this);","path":"java/core/src/main/java/com/microsoft/bond/StructBondType.java","position":323,"original_position":323,"commit_id":"f4a9ff2c6f1c1f271b6a57c1c27ccb524890db62","original_commit_id":"f4a9ff2c6f1c1f271b6a57c1c27ccb524890db62","user":{"login":"sigansky","id":15965376,"avatar_url":"https://avatars0.githubusercontent.com/u/15965376?v=4","gravatar_id":"","url":"https://api.github.com/users/sigansky","html_url":"https://github.com/sigansky","followers_url":"https://api.github.com/users/sigansky/followers","following_url":"https://api.github.com/users/sigansky/following{/other_user}","gists_url":"https://api.github.com/users/sigansky/gists{/gist_id}","starred_url":"https://api.github.com/users/sigansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigansky/subscriptions","organizations_url":"https://api.github.com/users/sigansky/orgs","repos_url":"https://api.github.com/users/sigansky/repos","events_url":"https://api.github.com/users/sigansky/events{/privacy}","received_events_url":"https://api.github.com/users/sigansky/received_events","type":"User","site_admin":false},"body":"Looks like a method was accidentally removed.","created_at":"2017-08-01T23:41:23Z","updated_at":"2017-08-01T23:41:23Z","html_url":"https://github.com/Microsoft/bond/pull/542#discussion_r130755881","pull_request_url":"https://api.github.com/repos/Microsoft/bond/pulls/542","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/comments/130755881"},"html":{"href":"https://github.com/Microsoft/bond/pull/542#discussion_r130755881"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/542"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/bond/pulls/542","id":133585812,"html_url":"https://github.com/Microsoft/bond/pull/542","diff_url":"https://github.com/Microsoft/bond/pull/542.diff","patch_url":"https://github.com/Microsoft/bond/pull/542.patch","issue_url":"https://api.github.com/repos/Microsoft/bond/issues/542","number":542,"state":"open","locked":false,"title":"java: untagged and simple binary","user":{"login":"tstein","id":221157,"avatar_url":"https://avatars1.githubusercontent.com/u/221157?v=4","gravatar_id":"","url":"https://api.github.com/users/tstein","html_url":"https://github.com/tstein","followers_url":"https://api.github.com/users/tstein/followers","following_url":"https://api.github.com/users/tstein/following{/other_user}","gists_url":"https://api.github.com/users/tstein/gists{/gist_id}","starred_url":"https://api.github.com/users/tstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstein/subscriptions","organizations_url":"https://api.github.com/users/tstein/orgs","repos_url":"https://api.github.com/users/tstein/repos","events_url":"https://api.github.com/users/tstein/events{/privacy}","received_events_url":"https://api.github.com/users/tstein/received_events","type":"User","site_admin":false},"body":"Still working on tests, but there's already a lot to review. Strongly recommend doing it one commit at a time.","created_at":"2017-08-01T22:25:39Z","updated_at":"2017-08-01T23:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f948fa98955a3da91ec9da89697b47a0e1b2c924","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/bond/pulls/542/commits","review_comments_url":"https://api.github.com/repos/Microsoft/bond/pulls/542/comments","review_comment_url":"https://api.github.com/repos/Microsoft/bond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/bond/issues/542/comments","statuses_url":"https://api.github.com/repos/Microsoft/bond/statuses/f4a9ff2c6f1c1f271b6a57c1c27ccb524890db62","head":{"label":"tstein:simple_binary","ref":"simple_binary","sha":"f4a9ff2c6f1c1f271b6a57c1c27ccb524890db62","user":{"login":"tstein","id":221157,"avatar_url":"https://avatars1.githubusercontent.com/u/221157?v=4","gravatar_id":"","url":"https://api.github.com/users/tstein","html_url":"https://github.com/tstein","followers_url":"https://api.github.com/users/tstein/followers","following_url":"https://api.github.com/users/tstein/following{/other_user}","gists_url":"https://api.github.com/users/tstein/gists{/gist_id}","starred_url":"https://api.github.com/users/tstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstein/subscriptions","organizations_url":"https://api.github.com/users/tstein/orgs","repos_url":"https://api.github.com/users/tstein/repos","events_url":"https://api.github.com/users/tstein/events{/privacy}","received_events_url":"https://api.github.com/users/tstein/received_events","type":"User","site_admin":false},"repo":{"id":60382842,"name":"bond","full_name":"tstein/bond","owner":{"login":"tstein","id":221157,"avatar_url":"https://avatars1.githubusercontent.com/u/221157?v=4","gravatar_id":"","url":"https://api.github.com/users/tstein","html_url":"https://github.com/tstein","followers_url":"https://api.github.com/users/tstein/followers","following_url":"https://api.github.com/users/tstein/following{/other_user}","gists_url":"https://api.github.com/users/tstein/gists{/gist_id}","starred_url":"https://api.github.com/users/tstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstein/subscriptions","organizations_url":"https://api.github.com/users/tstein/orgs","repos_url":"https://api.github.com/users/tstein/repos","events_url":"https://api.github.com/users/tstein/events{/privacy}","received_events_url":"https://api.github.com/users/tstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tstein/bond","description":"Bond is a cross-platform framework for working with schematized data. It supports cross-language de/serialization and powerful generic mechanisms for efficiently manipulating data. Bond is broadly used at Microsoft in high scale services. ","fork":true,"url":"https://api.github.com/repos/tstein/bond","forks_url":"https://api.github.com/repos/tstein/bond/forks","keys_url":"https://api.github.com/repos/tstein/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tstein/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tstein/bond/teams","hooks_url":"https://api.github.com/repos/tstein/bond/hooks","issue_events_url":"https://api.github.com/repos/tstein/bond/issues/events{/number}","events_url":"https://api.github.com/repos/tstein/bond/events","assignees_url":"https://api.github.com/repos/tstein/bond/assignees{/user}","branches_url":"https://api.github.com/repos/tstein/bond/branches{/branch}","tags_url":"https://api.github.com/repos/tstein/bond/tags","blobs_url":"https://api.github.com/repos/tstein/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tstein/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tstein/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/tstein/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tstein/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/tstein/bond/languages","stargazers_url":"https://api.github.com/repos/tstein/bond/stargazers","contributors_url":"https://api.github.com/repos/tstein/bond/contributors","subscribers_url":"https://api.github.com/repos/tstein/bond/subscribers","subscription_url":"https://api.github.com/repos/tstein/bond/subscription","commits_url":"https://api.github.com/repos/tstein/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/tstein/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/tstein/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/tstein/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/tstein/bond/contents/{+path}","compare_url":"https://api.github.com/repos/tstein/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tstein/bond/merges","archive_url":"https://api.github.com/repos/tstein/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tstein/bond/downloads","issues_url":"https://api.github.com/repos/tstein/bond/issues{/number}","pulls_url":"https://api.github.com/repos/tstein/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/tstein/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/tstein/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tstein/bond/labels{/name}","releases_url":"https://api.github.com/repos/tstein/bond/releases{/id}","deployments_url":"https://api.github.com/repos/tstein/bond/deployments","created_at":"2016-06-03T23:09:46Z","updated_at":"2016-10-31T22:47:36Z","pushed_at":"2017-08-01T22:30:42Z","git_url":"git://github.com/tstein/bond.git","ssh_url":"git@github.com:tstein/bond.git","clone_url":"https://github.com/tstein/bond.git","svn_url":"https://github.com/tstein/bond","homepage":null,"size":7142,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:jvm","ref":"jvm","sha":"ebc1301c4df4c118a39aa78e4724008b037925a7","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":28014525,"name":"bond","full_name":"Microsoft/bond","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/bond","description":"Bond is a cross-platform framework for working with schematized data. It supports cross-language de/serialization and powerful generic mechanisms for efficiently manipulating data. Bond is broadly used at Microsoft in high scale services. ","fork":false,"url":"https://api.github.com/repos/Microsoft/bond","forks_url":"https://api.github.com/repos/Microsoft/bond/forks","keys_url":"https://api.github.com/repos/Microsoft/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/bond/teams","hooks_url":"https://api.github.com/repos/Microsoft/bond/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/bond/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/bond/events","assignees_url":"https://api.github.com/repos/Microsoft/bond/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/bond/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/bond/tags","blobs_url":"https://api.github.com/repos/Microsoft/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/bond/languages","stargazers_url":"https://api.github.com/repos/Microsoft/bond/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/bond/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/bond/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/bond/subscription","commits_url":"https://api.github.com/repos/Microsoft/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/bond/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/bond/merges","archive_url":"https://api.github.com/repos/Microsoft/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/bond/downloads","issues_url":"https://api.github.com/repos/Microsoft/bond/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/bond/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/bond/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/bond/deployments","created_at":"2014-12-15T01:05:31Z","updated_at":"2017-07-31T11:18:31Z","pushed_at":"2017-08-01T23:39:01Z","git_url":"git://github.com/Microsoft/bond.git","ssh_url":"git@github.com:Microsoft/bond.git","clone_url":"https://github.com/Microsoft/bond.git","svn_url":"https://github.com/Microsoft/bond","homepage":null,"size":9297,"stargazers_count":1589,"watchers_count":1589,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":215,"mirror_url":null,"open_issues_count":101,"forks":215,"open_issues":101,"watchers":1589,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/542"},"html":{"href":"https://github.com/Microsoft/bond/pull/542"},"issue":{"href":"https://api.github.com/repos/Microsoft/bond/issues/542"},"comments":{"href":"https://api.github.com/repos/Microsoft/bond/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/bond/statuses/f4a9ff2c6f1c1f271b6a57c1c27ccb524890db62"}}}}
{"actor":{"display_login":"sigansky"}}