{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/95419345","pull_request_review_id":15973233,"id":95419345,"diff_hunk":"@@ -64,6 +64,9 @@ int RGWCivetWebFrontend::run()\n     conf_map[\"run_as_user\"] = std::move(uid_string);\n   }\n \n+  /* Set authentication domains, this is needed for handling absolute uris in\n+     requests */\n+  conf_map[\"authentication_domain\"] = g_conf->rgw_dns_name;","path":"src/rgw/rgw_civetweb_frontend.cc","position":6,"original_position":6,"commit_id":"8afc3c49205e1c2dafd913d432d37f7b158b2181","original_commit_id":"8afc3c49205e1c2dafd913d432d37f7b158b2181","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars.githubusercontent.com/u/1433152?v=3","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"body":"@yehudasa this is the current behaviour of civetweb (with the proposed cherry-pick) https://github.com/civetweb/civetweb/issues/197#issuecomment-255186417","created_at":"2017-01-10T17:51:24Z","updated_at":"2017-01-10T17:51:24Z","html_url":"https://github.com/ceph/ceph/pull/12861#discussion_r95419345","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/12861","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/95419345"},"html":{"href":"https://github.com/ceph/ceph/pull/12861#discussion_r95419345"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12861"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/12861","id":100865712,"html_url":"https://github.com/ceph/ceph/pull/12861","diff_url":"https://github.com/ceph/ceph/pull/12861.diff","patch_url":"https://github.com/ceph/ceph/pull/12861.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/12861","number":12861,"state":"open","locked":false,"title":"rgw: pass authentication domain to civetweb","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars.githubusercontent.com/u/1433152?v=3","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"body":"This is needed to support absolute uris, as civetweb further cross\r\nchecks whether the request is made to the same domain or not, otherwise\r\ncivetweb ends up sending NULL response back to the client. Also set the\r\nREQUEST_URI to the full request uri, since the old uri parameter is\r\ndeprecated.\r\n\r\nThis needs https://github.com/ceph/civetweb/pull/16 also merged for full support of subdomain style requests\r\n\r\nFixes: http://tracker.ceph.com/issues/17657\r\nSigned-off-by: Abhishek Lekshmanan <abhishek@suse.com>","created_at":"2017-01-10T12:39:30Z","updated_at":"2017-01-10T17:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0aa4c95a7964c0e6787541e7eb0cd09792371af9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/12861/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/12861/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/12861/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/8afc3c49205e1c2dafd913d432d37f7b158b2181","head":{"label":"theanalyst:wip-absolute-urls","ref":"wip-absolute-urls","sha":"8afc3c49205e1c2dafd913d432d37f7b158b2181","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars.githubusercontent.com/u/1433152?v=3","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"repo":{"id":21639729,"name":"ceph","full_name":"theanalyst/ceph","owner":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars.githubusercontent.com/u/1433152?v=3","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theanalyst/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/theanalyst/ceph","forks_url":"https://api.github.com/repos/theanalyst/ceph/forks","keys_url":"https://api.github.com/repos/theanalyst/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theanalyst/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theanalyst/ceph/teams","hooks_url":"https://api.github.com/repos/theanalyst/ceph/hooks","issue_events_url":"https://api.github.com/repos/theanalyst/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/theanalyst/ceph/events","assignees_url":"https://api.github.com/repos/theanalyst/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/theanalyst/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/theanalyst/ceph/tags","blobs_url":"https://api.github.com/repos/theanalyst/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theanalyst/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theanalyst/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/theanalyst/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theanalyst/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/theanalyst/ceph/languages","stargazers_url":"https://api.github.com/repos/theanalyst/ceph/stargazers","contributors_url":"https://api.github.com/repos/theanalyst/ceph/contributors","subscribers_url":"https://api.github.com/repos/theanalyst/ceph/subscribers","subscription_url":"https://api.github.com/repos/theanalyst/ceph/subscription","commits_url":"https://api.github.com/repos/theanalyst/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/theanalyst/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/theanalyst/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/theanalyst/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/theanalyst/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/theanalyst/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theanalyst/ceph/merges","archive_url":"https://api.github.com/repos/theanalyst/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theanalyst/ceph/downloads","issues_url":"https://api.github.com/repos/theanalyst/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/theanalyst/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/theanalyst/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/theanalyst/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theanalyst/ceph/labels{/name}","releases_url":"https://api.github.com/repos/theanalyst/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/theanalyst/ceph/deployments","created_at":"2014-07-09T04:45:38Z","updated_at":"2016-01-19T13:53:44Z","pushed_at":"2017-01-10T12:14:15Z","git_url":"git://github.com/theanalyst/ceph.git","ssh_url":"git@github.com:theanalyst/ceph.git","clone_url":"https://github.com/theanalyst/ceph.git","svn_url":"https://github.com/theanalyst/ceph","homepage":"http://ceph.com","size":187236,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"fbad77c7275a94e746365764dfb7db3fcfb6642c","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-01-10T16:33:18Z","pushed_at":"2017-01-10T17:48:48Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":187504,"stargazers_count":2783,"watchers_count":2783,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1636,"mirror_url":null,"open_issues_count":433,"forks":1636,"open_issues":433,"watchers":2783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12861"},"html":{"href":"https://github.com/ceph/ceph/pull/12861"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/12861"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/12861/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12861/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12861/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/8afc3c49205e1c2dafd913d432d37f7b158b2181"}}}}
{"actor":{"display_login":"theanalyst"}}