{"action":"created","comment":{"url":"https://api.github.com/repos/rawrtc/rawrtc/pulls/comments/154673825","pull_request_review_id":80869435,"id":154673825,"diff_hunk":"@@ -1434,14 +1437,14 @@ static enum rawrtc_code add_candidate(\n  * TODO: https://tools.ietf.org/html/draft-ietf-rtcweb-ip-handling-01\n   */\n static bool interface_handler(\n-        char const* interface, // not checked\n+        char const* iface, // not checked","path":"src/librawrtc/ice_gatherer.c","position":21,"original_position":21,"commit_id":"58a400cd2a8e0d194260fe1de1e9c01a82d6b800","original_commit_id":"58a400cd2a8e0d194260fe1de1e9c01a82d6b800","user":{"login":"lgrahl","id":1793755,"avatar_url":"https://avatars3.githubusercontent.com/u/1793755?v=4","gravatar_id":"","url":"https://api.github.com/users/lgrahl","html_url":"https://github.com/lgrahl","followers_url":"https://api.github.com/users/lgrahl/followers","following_url":"https://api.github.com/users/lgrahl/following{/other_user}","gists_url":"https://api.github.com/users/lgrahl/gists{/gist_id}","starred_url":"https://api.github.com/users/lgrahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgrahl/subscriptions","organizations_url":"https://api.github.com/users/lgrahl/orgs","repos_url":"https://api.github.com/users/lgrahl/repos","events_url":"https://api.github.com/users/lgrahl/events{/privacy}","received_events_url":"https://api.github.com/users/lgrahl/received_events","type":"User","site_admin":false},"body":"I'd prefer `interface_` to avoid a name clash. Also, please add a comment somewhere in that code section that `interface` clashes and with what it clashes.","created_at":"2017-12-04T15:07:17Z","updated_at":"2017-12-04T15:22:08Z","html_url":"https://github.com/rawrtc/rawrtc/pull/77#discussion_r154673825","pull_request_url":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rawrtc/rawrtc/pulls/comments/154673825"},"html":{"href":"https://github.com/rawrtc/rawrtc/pull/77#discussion_r154673825"},"pull_request":{"href":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77","id":156062768,"html_url":"https://github.com/rawrtc/rawrtc/pull/77","diff_url":"https://github.com/rawrtc/rawrtc/pull/77.diff","patch_url":"https://github.com/rawrtc/rawrtc/pull/77.patch","issue_url":"https://api.github.com/repos/rawrtc/rawrtc/issues/77","number":77,"state":"open","locked":false,"title":"Fix compilation errors on Windows","user":{"login":"ftk","id":984218,"avatar_url":"https://avatars2.githubusercontent.com/u/984218?v=4","gravatar_id":"","url":"https://api.github.com/users/ftk","html_url":"https://github.com/ftk","followers_url":"https://api.github.com/users/ftk/followers","following_url":"https://api.github.com/users/ftk/following{/other_user}","gists_url":"https://api.github.com/users/ftk/gists{/gist_id}","starred_url":"https://api.github.com/users/ftk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftk/subscriptions","organizations_url":"https://api.github.com/users/ftk/orgs","repos_url":"https://api.github.com/users/ftk/repos","events_url":"https://api.github.com/users/ftk/events{/privacy}","received_events_url":"https://api.github.com/users/ftk/received_events","type":"User","site_admin":false},"body":"Now it is somewhat compilable with MinGW on Windows.\r\n- Some headers were missing on windows\r\n- X509_NAME was redefined somewhere, had to change include order\r\n- \"interface\" was redefined\r\n- 0.0.0.0 is not a valid address, should be ignored\r\n","created_at":"2017-12-03T14:26:05Z","updated_at":"2017-12-04T15:22:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1256b0a84d92d3b79512d5579d313d7e2a33e6e1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77/commits","review_comments_url":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77/comments","review_comment_url":"https://api.github.com/repos/rawrtc/rawrtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rawrtc/rawrtc/issues/77/comments","statuses_url":"https://api.github.com/repos/rawrtc/rawrtc/statuses/58a400cd2a8e0d194260fe1de1e9c01a82d6b800","head":{"label":"ftk:master","ref":"master","sha":"58a400cd2a8e0d194260fe1de1e9c01a82d6b800","user":{"login":"ftk","id":984218,"avatar_url":"https://avatars2.githubusercontent.com/u/984218?v=4","gravatar_id":"","url":"https://api.github.com/users/ftk","html_url":"https://github.com/ftk","followers_url":"https://api.github.com/users/ftk/followers","following_url":"https://api.github.com/users/ftk/following{/other_user}","gists_url":"https://api.github.com/users/ftk/gists{/gist_id}","starred_url":"https://api.github.com/users/ftk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftk/subscriptions","organizations_url":"https://api.github.com/users/ftk/orgs","repos_url":"https://api.github.com/users/ftk/repos","events_url":"https://api.github.com/users/ftk/events{/privacy}","received_events_url":"https://api.github.com/users/ftk/received_events","type":"User","site_admin":false},"repo":{"id":112205473,"name":"rawrtc","full_name":"ftk/rawrtc","owner":{"login":"ftk","id":984218,"avatar_url":"https://avatars2.githubusercontent.com/u/984218?v=4","gravatar_id":"","url":"https://api.github.com/users/ftk","html_url":"https://github.com/ftk","followers_url":"https://api.github.com/users/ftk/followers","following_url":"https://api.github.com/users/ftk/following{/other_user}","gists_url":"https://api.github.com/users/ftk/gists{/gist_id}","starred_url":"https://api.github.com/users/ftk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftk/subscriptions","organizations_url":"https://api.github.com/users/ftk/orgs","repos_url":"https://api.github.com/users/ftk/repos","events_url":"https://api.github.com/users/ftk/events{/privacy}","received_events_url":"https://api.github.com/users/ftk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ftk/rawrtc","description":"WebRTC and ORTC with a little bit of RAWR!","fork":true,"url":"https://api.github.com/repos/ftk/rawrtc","forks_url":"https://api.github.com/repos/ftk/rawrtc/forks","keys_url":"https://api.github.com/repos/ftk/rawrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ftk/rawrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ftk/rawrtc/teams","hooks_url":"https://api.github.com/repos/ftk/rawrtc/hooks","issue_events_url":"https://api.github.com/repos/ftk/rawrtc/issues/events{/number}","events_url":"https://api.github.com/repos/ftk/rawrtc/events","assignees_url":"https://api.github.com/repos/ftk/rawrtc/assignees{/user}","branches_url":"https://api.github.com/repos/ftk/rawrtc/branches{/branch}","tags_url":"https://api.github.com/repos/ftk/rawrtc/tags","blobs_url":"https://api.github.com/repos/ftk/rawrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ftk/rawrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ftk/rawrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ftk/rawrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ftk/rawrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/ftk/rawrtc/languages","stargazers_url":"https://api.github.com/repos/ftk/rawrtc/stargazers","contributors_url":"https://api.github.com/repos/ftk/rawrtc/contributors","subscribers_url":"https://api.github.com/repos/ftk/rawrtc/subscribers","subscription_url":"https://api.github.com/repos/ftk/rawrtc/subscription","commits_url":"https://api.github.com/repos/ftk/rawrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ftk/rawrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ftk/rawrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ftk/rawrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ftk/rawrtc/contents/{+path}","compare_url":"https://api.github.com/repos/ftk/rawrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ftk/rawrtc/merges","archive_url":"https://api.github.com/repos/ftk/rawrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ftk/rawrtc/downloads","issues_url":"https://api.github.com/repos/ftk/rawrtc/issues{/number}","pulls_url":"https://api.github.com/repos/ftk/rawrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/ftk/rawrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/ftk/rawrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ftk/rawrtc/labels{/name}","releases_url":"https://api.github.com/repos/ftk/rawrtc/releases{/id}","deployments_url":"https://api.github.com/repos/ftk/rawrtc/deployments","created_at":"2017-11-27T14:21:32Z","updated_at":"2017-11-27T14:21:34Z","pushed_at":"2017-12-02T17:48:37Z","git_url":"git://github.com/ftk/rawrtc.git","ssh_url":"git@github.com:ftk/rawrtc.git","clone_url":"https://github.com/ftk/rawrtc.git","svn_url":"https://github.com/ftk/rawrtc","homepage":null,"size":797,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"mingw64"}},"base":{"label":"rawrtc:master","ref":"master","sha":"f5e9b10e0b79d7f8faa7379b7361d437e004fe80","user":{"login":"rawrtc","id":24740849,"avatar_url":"https://avatars0.githubusercontent.com/u/24740849?v=4","gravatar_id":"","url":"https://api.github.com/users/rawrtc","html_url":"https://github.com/rawrtc","followers_url":"https://api.github.com/users/rawrtc/followers","following_url":"https://api.github.com/users/rawrtc/following{/other_user}","gists_url":"https://api.github.com/users/rawrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/rawrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawrtc/subscriptions","organizations_url":"https://api.github.com/users/rawrtc/orgs","repos_url":"https://api.github.com/users/rawrtc/repos","events_url":"https://api.github.com/users/rawrtc/events{/privacy}","received_events_url":"https://api.github.com/users/rawrtc/received_events","type":"Organization","site_admin":false},"repo":{"id":80470566,"name":"rawrtc","full_name":"rawrtc/rawrtc","owner":{"login":"rawrtc","id":24740849,"avatar_url":"https://avatars0.githubusercontent.com/u/24740849?v=4","gravatar_id":"","url":"https://api.github.com/users/rawrtc","html_url":"https://github.com/rawrtc","followers_url":"https://api.github.com/users/rawrtc/followers","following_url":"https://api.github.com/users/rawrtc/following{/other_user}","gists_url":"https://api.github.com/users/rawrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/rawrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawrtc/subscriptions","organizations_url":"https://api.github.com/users/rawrtc/orgs","repos_url":"https://api.github.com/users/rawrtc/repos","events_url":"https://api.github.com/users/rawrtc/events{/privacy}","received_events_url":"https://api.github.com/users/rawrtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rawrtc/rawrtc","description":"WebRTC and ORTC with a little bit of RAWR!","fork":false,"url":"https://api.github.com/repos/rawrtc/rawrtc","forks_url":"https://api.github.com/repos/rawrtc/rawrtc/forks","keys_url":"https://api.github.com/repos/rawrtc/rawrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rawrtc/rawrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rawrtc/rawrtc/teams","hooks_url":"https://api.github.com/repos/rawrtc/rawrtc/hooks","issue_events_url":"https://api.github.com/repos/rawrtc/rawrtc/issues/events{/number}","events_url":"https://api.github.com/repos/rawrtc/rawrtc/events","assignees_url":"https://api.github.com/repos/rawrtc/rawrtc/assignees{/user}","branches_url":"https://api.github.com/repos/rawrtc/rawrtc/branches{/branch}","tags_url":"https://api.github.com/repos/rawrtc/rawrtc/tags","blobs_url":"https://api.github.com/repos/rawrtc/rawrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rawrtc/rawrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rawrtc/rawrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/rawrtc/rawrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rawrtc/rawrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/rawrtc/rawrtc/languages","stargazers_url":"https://api.github.com/repos/rawrtc/rawrtc/stargazers","contributors_url":"https://api.github.com/repos/rawrtc/rawrtc/contributors","subscribers_url":"https://api.github.com/repos/rawrtc/rawrtc/subscribers","subscription_url":"https://api.github.com/repos/rawrtc/rawrtc/subscription","commits_url":"https://api.github.com/repos/rawrtc/rawrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/rawrtc/rawrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/rawrtc/rawrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/rawrtc/rawrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/rawrtc/rawrtc/contents/{+path}","compare_url":"https://api.github.com/repos/rawrtc/rawrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rawrtc/rawrtc/merges","archive_url":"https://api.github.com/repos/rawrtc/rawrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rawrtc/rawrtc/downloads","issues_url":"https://api.github.com/repos/rawrtc/rawrtc/issues{/number}","pulls_url":"https://api.github.com/repos/rawrtc/rawrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/rawrtc/rawrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/rawrtc/rawrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rawrtc/rawrtc/labels{/name}","releases_url":"https://api.github.com/repos/rawrtc/rawrtc/releases{/id}","deployments_url":"https://api.github.com/repos/rawrtc/rawrtc/deployments","created_at":"2017-01-30T22:32:38Z","updated_at":"2017-11-30T22:12:35Z","pushed_at":"2017-12-03T14:26:06Z","git_url":"git://github.com/rawrtc/rawrtc.git","ssh_url":"git@github.com:rawrtc/rawrtc.git","clone_url":"https://github.com/rawrtc/rawrtc.git","svn_url":"https://github.com/rawrtc/rawrtc","homepage":null,"size":764,"stargazers_count":117,"watchers_count":117,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"bsd-2-clause","name":"BSD 2-clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":7,"open_issues":56,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77"},"html":{"href":"https://github.com/rawrtc/rawrtc/pull/77"},"issue":{"href":"https://api.github.com/repos/rawrtc/rawrtc/issues/77"},"comments":{"href":"https://api.github.com/repos/rawrtc/rawrtc/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/rawrtc/rawrtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rawrtc/rawrtc/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/rawrtc/rawrtc/statuses/58a400cd2a8e0d194260fe1de1e9c01a82d6b800"}},"author_association":"NONE"}}
{"actor":{"display_login":"lgrahl"}}