{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/111590635","pull_request_review_id":32848110,"id":111590635,"diff_hunk":"@@ -1927,7 +1929,17 @@ def detach_volume(volume_id, instance_id=None, device=None, force=False,\n     '''\n     conn = _get_conn(region=region, key=key, keyid=keyid, profile=profile)\n     try:\n-        return conn.detach_volume(volume_id, instance_id, device, force)\n+        ret = conn.detach_volume(volume_id, instance_id, device, force)\n+        if wait_to_finish is not None:\n+            wait = 0\n+            while True:","path":"salt/modules/boto_ec2.py","position":26,"original_position":26,"commit_id":"fae7c9af0ba46d6e178000681357538d7d694033","original_commit_id":"fae7c9af0ba46d6e178000681357538d7d694033","user":{"login":"ryan-lane","id":1538354,"avatar_url":"https://avatars2.githubusercontent.com/u/1538354?v=3","gravatar_id":"","url":"https://api.github.com/users/ryan-lane","html_url":"https://github.com/ryan-lane","followers_url":"https://api.github.com/users/ryan-lane/followers","following_url":"https://api.github.com/users/ryan-lane/following{/other_user}","gists_url":"https://api.github.com/users/ryan-lane/gists{/gist_id}","starred_url":"https://api.github.com/users/ryan-lane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryan-lane/subscriptions","organizations_url":"https://api.github.com/users/ryan-lane/orgs","repos_url":"https://api.github.com/users/ryan-lane/repos","events_url":"https://api.github.com/users/ryan-lane/events{/privacy}","received_events_url":"https://api.github.com/users/ryan-lane/received_events","type":"User","site_admin":false},"body":"Though, if this is going to be changed to be consistent with other modules using wait_for_sync, then this should probably stay while True","created_at":"2017-04-14T15:37:56Z","updated_at":"2017-04-14T15:37:56Z","html_url":"https://github.com/saltstack/salt/pull/40694#discussion_r111590635","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/40694","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/111590635"},"html":{"href":"https://github.com/saltstack/salt/pull/40694#discussion_r111590635"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40694"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/40694","id":115865421,"html_url":"https://github.com/saltstack/salt/pull/40694","diff_url":"https://github.com/saltstack/salt/pull/40694.diff","patch_url":"https://github.com/saltstack/salt/pull/40694.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/40694","number":40694,"state":"open","locked":false,"title":"Boto ec2 volume present","user":{"login":"x-lhan","id":8022688,"avatar_url":"https://avatars0.githubusercontent.com/u/8022688?v=3","gravatar_id":"","url":"https://api.github.com/users/x-lhan","html_url":"https://github.com/x-lhan","followers_url":"https://api.github.com/users/x-lhan/followers","following_url":"https://api.github.com/users/x-lhan/following{/other_user}","gists_url":"https://api.github.com/users/x-lhan/gists{/gist_id}","starred_url":"https://api.github.com/users/x-lhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x-lhan/subscriptions","organizations_url":"https://api.github.com/users/x-lhan/orgs","repos_url":"https://api.github.com/users/x-lhan/repos","events_url":"https://api.github.com/users/x-lhan/events{/privacy}","received_events_url":"https://api.github.com/users/x-lhan/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nImplement #38938 feature request\r\n\r\n### What issues does this PR fix or reference?\r\n#38938\r\n\r\n### New Behavior\r\nAdded new `boto_ec2.volume_present` state. To support this state two new module functions where added `boto_ec2.create_volume` and `boto_ec2.attach_volume`. \r\nAdded a new parameter `wait_to_finish` in `boto_ec2.detach_volume` module function to indicate the time to wait for detaching volume complete, in second. This is necessary for `boto_ec2.volume_present` state to re-attach volume properly. \r\n\r\nThe new boto_ec2.volume_present state performs the following:\r\n1. Creates a volume, if one with the specified tag does not exist, using the supplied parameters.\r\n2. Ensures that the volume is attached to the instance specified, attempting to detach it if necessary.\r\n\r\n### Tests written?\r\nNo\r\n\r\n### Note\r\n`versionadded` comment keyword did not added\r\n","created_at":"2017-04-14T00:06:05Z","updated_at":"2017-04-14T15:37:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5a58b50bc743bf128972abadab7a605b420adab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/40694/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/40694/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/40694/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/fae7c9af0ba46d6e178000681357538d7d694033","head":{"label":"xetus-oss:boto_ec2_volume_present","ref":"boto_ec2_volume_present","sha":"fae7c9af0ba46d6e178000681357538d7d694033","user":{"login":"xetus-oss","id":8021653,"avatar_url":"https://avatars0.githubusercontent.com/u/8021653?v=3","gravatar_id":"","url":"https://api.github.com/users/xetus-oss","html_url":"https://github.com/xetus-oss","followers_url":"https://api.github.com/users/xetus-oss/followers","following_url":"https://api.github.com/users/xetus-oss/following{/other_user}","gists_url":"https://api.github.com/users/xetus-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/xetus-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xetus-oss/subscriptions","organizations_url":"https://api.github.com/users/xetus-oss/orgs","repos_url":"https://api.github.com/users/xetus-oss/repos","events_url":"https://api.github.com/users/xetus-oss/events{/privacy}","received_events_url":"https://api.github.com/users/xetus-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":52030417,"name":"salt","full_name":"xetus-oss/salt","owner":{"login":"xetus-oss","id":8021653,"avatar_url":"https://avatars0.githubusercontent.com/u/8021653?v=3","gravatar_id":"","url":"https://api.github.com/users/xetus-oss","html_url":"https://github.com/xetus-oss","followers_url":"https://api.github.com/users/xetus-oss/followers","following_url":"https://api.github.com/users/xetus-oss/following{/other_user}","gists_url":"https://api.github.com/users/xetus-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/xetus-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xetus-oss/subscriptions","organizations_url":"https://api.github.com/users/xetus-oss/orgs","repos_url":"https://api.github.com/users/xetus-oss/repos","events_url":"https://api.github.com/users/xetus-oss/events{/privacy}","received_events_url":"https://api.github.com/users/xetus-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xetus-oss/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":true,"url":"https://api.github.com/repos/xetus-oss/salt","forks_url":"https://api.github.com/repos/xetus-oss/salt/forks","keys_url":"https://api.github.com/repos/xetus-oss/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xetus-oss/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xetus-oss/salt/teams","hooks_url":"https://api.github.com/repos/xetus-oss/salt/hooks","issue_events_url":"https://api.github.com/repos/xetus-oss/salt/issues/events{/number}","events_url":"https://api.github.com/repos/xetus-oss/salt/events","assignees_url":"https://api.github.com/repos/xetus-oss/salt/assignees{/user}","branches_url":"https://api.github.com/repos/xetus-oss/salt/branches{/branch}","tags_url":"https://api.github.com/repos/xetus-oss/salt/tags","blobs_url":"https://api.github.com/repos/xetus-oss/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xetus-oss/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xetus-oss/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/xetus-oss/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xetus-oss/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/xetus-oss/salt/languages","stargazers_url":"https://api.github.com/repos/xetus-oss/salt/stargazers","contributors_url":"https://api.github.com/repos/xetus-oss/salt/contributors","subscribers_url":"https://api.github.com/repos/xetus-oss/salt/subscribers","subscription_url":"https://api.github.com/repos/xetus-oss/salt/subscription","commits_url":"https://api.github.com/repos/xetus-oss/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/xetus-oss/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/xetus-oss/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/xetus-oss/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/xetus-oss/salt/contents/{+path}","compare_url":"https://api.github.com/repos/xetus-oss/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xetus-oss/salt/merges","archive_url":"https://api.github.com/repos/xetus-oss/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xetus-oss/salt/downloads","issues_url":"https://api.github.com/repos/xetus-oss/salt/issues{/number}","pulls_url":"https://api.github.com/repos/xetus-oss/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/xetus-oss/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/xetus-oss/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xetus-oss/salt/labels{/name}","releases_url":"https://api.github.com/repos/xetus-oss/salt/releases{/id}","deployments_url":"https://api.github.com/repos/xetus-oss/salt/deployments","created_at":"2016-02-18T18:52:12Z","updated_at":"2016-02-18T18:52:24Z","pushed_at":"2017-04-14T10:12:34Z","git_url":"git://github.com/xetus-oss/salt.git","ssh_url":"git@github.com:xetus-oss/salt.git","clone_url":"https://github.com/xetus-oss/salt.git","svn_url":"https://github.com/xetus-oss/salt","homepage":"https://repo.saltstack.com/","size":163424,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"10f60c274278841eccce14ba7bfbeca65c4acca3","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2017-04-14T03:15:04Z","pushed_at":"2017-04-14T15:26:00Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":163853,"stargazers_count":7580,"watchers_count":7580,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3509,"mirror_url":null,"open_issues_count":4425,"forks":3509,"open_issues":4425,"watchers":7580,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40694"},"html":{"href":"https://github.com/saltstack/salt/pull/40694"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/40694"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/40694/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40694/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40694/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/fae7c9af0ba46d6e178000681357538d7d694033"}}}}
{"actor":{"display_login":"ryan-lane"}}