{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/155049158","pull_request_review_id":81303924,"id":155049158,"diff_hunk":"@@ -0,0 +1,136 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.beam.sdk.nexmark.model.sql;\n+\n+import com.google.common.collect.ImmutableMap;\n+\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.io.OutputStream;\n+import java.sql.Types;\n+import java.util.Map;\n+\n+import org.apache.beam.sdk.coders.Coder;\n+import org.apache.beam.sdk.coders.CoderException;\n+import org.apache.beam.sdk.coders.CustomCoder;\n+import org.apache.beam.sdk.coders.VarLongCoder;\n+import org.apache.beam.sdk.extensions.sql.BeamRecordSqlType;\n+import org.apache.beam.sdk.nexmark.model.KnownSize;\n+import org.apache.beam.sdk.transforms.DoFn;\n+import org.apache.beam.sdk.transforms.ParDo;\n+import org.apache.beam.sdk.values.BeamRecord;\n+\n+/**\n+ * KnownSize implementation to estimate the size of a BeamRecord, similar to Java model.","path":"sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/model/sql/BeamRecordSize.java","position":null,"original_position":40,"commit_id":"fec1cc0b7e14661b4b88ff04585396c1594e1747","original_commit_id":"dab81baf15038727942d0f963bd402793a80ec30","user":{"login":"akedin","id":33067037,"avatar_url":"https://avatars0.githubusercontent.com/u/33067037?v=4","gravatar_id":"","url":"https://api.github.com/users/akedin","html_url":"https://github.com/akedin","followers_url":"https://api.github.com/users/akedin/followers","following_url":"https://api.github.com/users/akedin/following{/other_user}","gists_url":"https://api.github.com/users/akedin/gists{/gist_id}","starred_url":"https://api.github.com/users/akedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akedin/subscriptions","organizations_url":"https://api.github.com/users/akedin/orgs","repos_url":"https://api.github.com/users/akedin/repos","events_url":"https://api.github.com/users/akedin/events{/privacy}","received_events_url":"https://api.github.com/users/akedin/received_events","type":"User","site_admin":false},"body":"<!--thread_id:cc_154870922_t; commit:dab81baf15038727942d0f963bd402793a80ec30; resolved:1-->\n<!--section:context-quote-->\n> **kennknowles** wrote:\n> Nit: Could use {@link Knownsize} and {@link BeamRecord}.\n\n<!--section:body-->\ndone","created_at":"2017-12-05T19:18:26Z","updated_at":"2017-12-05T19:18:26Z","html_url":"https://github.com/apache/beam/pull/4128#discussion_r155049158","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/4128","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/155049158"},"html":{"href":"https://github.com/apache/beam/pull/4128#discussion_r155049158"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/4128"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/4128","id":152426192,"html_url":"https://github.com/apache/beam/pull/4128","diff_url":"https://github.com/apache/beam/pull/4128.diff","patch_url":"https://github.com/apache/beam/pull/4128.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/4128","number":4128,"state":"open","locked":false,"title":"[BEAM-3181][Nexmark][SQL] Implement query0","user":{"login":"akedin","id":33067037,"avatar_url":"https://avatars0.githubusercontent.com/u/33067037?v=4","gravatar_id":"","url":"https://api.github.com/users/akedin","html_url":"https://github.com/akedin","followers_url":"https://api.github.com/users/akedin/followers","following_url":"https://api.github.com/users/akedin/following{/other_user}","gists_url":"https://api.github.com/users/akedin/gists{/gist_id}","starred_url":"https://api.github.com/users/akedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akedin/subscriptions","organizations_url":"https://api.github.com/users/akedin/orgs","repos_url":"https://api.github.com/users/akedin/repos","events_url":"https://api.github.com/users/akedin/events{/privacy}","received_events_url":"https://api.github.com/users/akedin/received_events","type":"User","site_admin":false},"body":"This implements a basic pass-through query0. \r\n\r\nThis PR does not depend on the refactoring PRs and can be merged independently while the other ones are being worked on.\r\n\r\nThis sets up a basic scaffolding which will help implementing other queries.\r\n\r\n[BEAM-3181](https://issues.apache.org/jira/browse/BEAM-3181) is a subtask of [BEAM-3147](https://issues.apache.org/jira/browse/BEAM-3147)\r\n\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.\r\n - [x] Each commit in the pull request should have a meaningful subject line and body.\r\n - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.\r\n - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.\r\n - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.\r\n - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\n---\r\n","created_at":"2017-11-14T06:55:10Z","updated_at":"2017-12-05T19:18:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fbaacc07900e4178f6361806e2fa7b6bdf7d110","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/4128/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/4128/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/4128/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/fec1cc0b7e14661b4b88ff04585396c1594e1747","head":{"label":"akedin:nexmark-sql-query0","ref":"nexmark-sql-query0","sha":"fec1cc0b7e14661b4b88ff04585396c1594e1747","user":{"login":"akedin","id":33067037,"avatar_url":"https://avatars0.githubusercontent.com/u/33067037?v=4","gravatar_id":"","url":"https://api.github.com/users/akedin","html_url":"https://github.com/akedin","followers_url":"https://api.github.com/users/akedin/followers","following_url":"https://api.github.com/users/akedin/following{/other_user}","gists_url":"https://api.github.com/users/akedin/gists{/gist_id}","starred_url":"https://api.github.com/users/akedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akedin/subscriptions","organizations_url":"https://api.github.com/users/akedin/orgs","repos_url":"https://api.github.com/users/akedin/repos","events_url":"https://api.github.com/users/akedin/events{/privacy}","received_events_url":"https://api.github.com/users/akedin/received_events","type":"User","site_admin":false},"repo":{"id":108159679,"name":"beam","full_name":"akedin/beam","owner":{"login":"akedin","id":33067037,"avatar_url":"https://avatars0.githubusercontent.com/u/33067037?v=4","gravatar_id":"","url":"https://api.github.com/users/akedin","html_url":"https://github.com/akedin","followers_url":"https://api.github.com/users/akedin/followers","following_url":"https://api.github.com/users/akedin/following{/other_user}","gists_url":"https://api.github.com/users/akedin/gists{/gist_id}","starred_url":"https://api.github.com/users/akedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akedin/subscriptions","organizations_url":"https://api.github.com/users/akedin/orgs","repos_url":"https://api.github.com/users/akedin/repos","events_url":"https://api.github.com/users/akedin/events{/privacy}","received_events_url":"https://api.github.com/users/akedin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akedin/beam","description":"Mirror of Apache Beam","fork":true,"url":"https://api.github.com/repos/akedin/beam","forks_url":"https://api.github.com/repos/akedin/beam/forks","keys_url":"https://api.github.com/repos/akedin/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akedin/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akedin/beam/teams","hooks_url":"https://api.github.com/repos/akedin/beam/hooks","issue_events_url":"https://api.github.com/repos/akedin/beam/issues/events{/number}","events_url":"https://api.github.com/repos/akedin/beam/events","assignees_url":"https://api.github.com/repos/akedin/beam/assignees{/user}","branches_url":"https://api.github.com/repos/akedin/beam/branches{/branch}","tags_url":"https://api.github.com/repos/akedin/beam/tags","blobs_url":"https://api.github.com/repos/akedin/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akedin/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akedin/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/akedin/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akedin/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/akedin/beam/languages","stargazers_url":"https://api.github.com/repos/akedin/beam/stargazers","contributors_url":"https://api.github.com/repos/akedin/beam/contributors","subscribers_url":"https://api.github.com/repos/akedin/beam/subscribers","subscription_url":"https://api.github.com/repos/akedin/beam/subscription","commits_url":"https://api.github.com/repos/akedin/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/akedin/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/akedin/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/akedin/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/akedin/beam/contents/{+path}","compare_url":"https://api.github.com/repos/akedin/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akedin/beam/merges","archive_url":"https://api.github.com/repos/akedin/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akedin/beam/downloads","issues_url":"https://api.github.com/repos/akedin/beam/issues{/number}","pulls_url":"https://api.github.com/repos/akedin/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/akedin/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/akedin/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akedin/beam/labels{/name}","releases_url":"https://api.github.com/repos/akedin/beam/releases{/id}","deployments_url":"https://api.github.com/repos/akedin/beam/deployments","created_at":"2017-10-24T17:18:33Z","updated_at":"2017-10-24T17:18:45Z","pushed_at":"2017-12-05T19:17:36Z","git_url":"git://github.com/akedin/beam.git","ssh_url":"git@github.com:akedin/beam.git","clone_url":"https://github.com/akedin/beam.git","svn_url":"https://github.com/akedin/beam","homepage":"","size":46625,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6474616ff1a2078f35cce60c9e6cd6991b95b3dd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2017-12-05T16:58:10Z","pushed_at":"2017-12-05T19:17:38Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":48723,"stargazers_count":1536,"watchers_count":1536,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":917,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":917,"open_issues":113,"watchers":1536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/4128"},"html":{"href":"https://github.com/apache/beam/pull/4128"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/4128"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/4128/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/4128/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/4128/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/fec1cc0b7e14661b4b88ff04585396c1594e1747"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akedin"}}