{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/3","id":112607809,"html_url":"https://github.com/Yelp/puppet-package_purging/pull/3","diff_url":"https://github.com/Yelp/puppet-package_purging/pull/3.diff","patch_url":"https://github.com/Yelp/puppet-package_purging/pull/3.patch","issue_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/3","number":3,"state":"closed","locked":false,"title":"Fix package holding and aptitude issues","user":{"login":"giuliano108","id":615907,"avatar_url":"https://avatars3.githubusercontent.com/u/615907?v=3","gravatar_id":"","url":"https://api.github.com/users/giuliano108","html_url":"https://github.com/giuliano108","followers_url":"https://api.github.com/users/giuliano108/followers","following_url":"https://api.github.com/users/giuliano108/following{/other_user}","gists_url":"https://api.github.com/users/giuliano108/gists{/gist_id}","starred_url":"https://api.github.com/users/giuliano108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuliano108/subscriptions","organizations_url":"https://api.github.com/users/giuliano108/orgs","repos_url":"https://api.github.com/users/giuliano108/repos","events_url":"https://api.github.com/users/giuliano108/events{/privacy}","received_events_url":"https://api.github.com/users/giuliano108/received_events","type":"User","site_admin":false},"body":"When holding is enabled and packages are installed via \"`provider => 'aptitude'`\", the catalog never converges:\r\n\r\n```\r\nNotice: /Stage[main]/Main/Package[dummypkg]/ensure: ensure changed 'held' to '0.0.3'\r\n```\r\n\r\nI was able to work around the issue by adding an `held_aptitude` provider, copy/pasted from the `held_apt` one. What they both do is take over handling of the \"held\" state (as natively understood by Puppet, see [here](https://github.com/puppetlabs/puppet/blob/ebd96213cab43bb2a8071b7ac0206c3ed0be8e58/lib/puppet/provider/package/dpkg.rb#L8)) respectively from `aptitude` and `apt`, allowing `aptly_purge` to do its job. `held_apt` is set as the default provider for packages on Debian systems: it works automatically without special provisions in the manifest. `held_aptitude` cannot use the same strategy, we'll have to search and replace \"`provider => 'aptitude'`\" with \"`provider => 'held_aptitude'`\" in our Puppet codebase. :( That's a bit of a bummer but I can't think of any other way (please advise!). Luckily, none of the vendor modules seem to depend on aptitude.\r\n\r\nTests output [here](https://i.fluffy.cc/5tqG3BzdLrq0jh3GLPxsRTsPFTSpQv29.log) (2.5MB).\r\n\r\nI plan to use the `.deb`s added in this branch to do some upgrade/downgrade tests at some point.\r\n\r\n/cc @hashbrowncipher","created_at":"2017-03-25T23:49:26Z","updated_at":"2017-03-29T11:53:01Z","closed_at":"2017-03-29T11:53:01Z","merged_at":"2017-03-29T11:53:01Z","merge_commit_sha":"a37acdda4204ba87b7f411b44462bfffd27a2093","assignee":{"login":"giuliano108","id":615907,"avatar_url":"https://avatars3.githubusercontent.com/u/615907?v=3","gravatar_id":"","url":"https://api.github.com/users/giuliano108","html_url":"https://github.com/giuliano108","followers_url":"https://api.github.com/users/giuliano108/followers","following_url":"https://api.github.com/users/giuliano108/following{/other_user}","gists_url":"https://api.github.com/users/giuliano108/gists{/gist_id}","starred_url":"https://api.github.com/users/giuliano108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuliano108/subscriptions","organizations_url":"https://api.github.com/users/giuliano108/orgs","repos_url":"https://api.github.com/users/giuliano108/repos","events_url":"https://api.github.com/users/giuliano108/events{/privacy}","received_events_url":"https://api.github.com/users/giuliano108/received_events","type":"User","site_admin":false},"assignees":[{"login":"giuliano108","id":615907,"avatar_url":"https://avatars3.githubusercontent.com/u/615907?v=3","gravatar_id":"","url":"https://api.github.com/users/giuliano108","html_url":"https://github.com/giuliano108","followers_url":"https://api.github.com/users/giuliano108/followers","following_url":"https://api.github.com/users/giuliano108/following{/other_user}","gists_url":"https://api.github.com/users/giuliano108/gists{/gist_id}","starred_url":"https://api.github.com/users/giuliano108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuliano108/subscriptions","organizations_url":"https://api.github.com/users/giuliano108/orgs","repos_url":"https://api.github.com/users/giuliano108/repos","events_url":"https://api.github.com/users/giuliano108/events{/privacy}","received_events_url":"https://api.github.com/users/giuliano108/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/3/comments","statuses_url":"https://api.github.com/repos/Yelp/puppet-package_purging/statuses/a37acdda4204ba87b7f411b44462bfffd27a2093","head":{"label":"Yelp:aptitude","ref":"aptitude","sha":"a37acdda4204ba87b7f411b44462bfffd27a2093","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars2.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":77673634,"name":"puppet-package_purging","full_name":"Yelp/puppet-package_purging","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars2.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/puppet-package_purging","description":"Puppet types to purge unneeded system packages","fork":true,"url":"https://api.github.com/repos/Yelp/puppet-package_purging","forks_url":"https://api.github.com/repos/Yelp/puppet-package_purging/forks","keys_url":"https://api.github.com/repos/Yelp/puppet-package_purging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/puppet-package_purging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/puppet-package_purging/teams","hooks_url":"https://api.github.com/repos/Yelp/puppet-package_purging/hooks","issue_events_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/puppet-package_purging/events","assignees_url":"https://api.github.com/repos/Yelp/puppet-package_purging/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/puppet-package_purging/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/puppet-package_purging/tags","blobs_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/puppet-package_purging/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/puppet-package_purging/languages","stargazers_url":"https://api.github.com/repos/Yelp/puppet-package_purging/stargazers","contributors_url":"https://api.github.com/repos/Yelp/puppet-package_purging/contributors","subscribers_url":"https://api.github.com/repos/Yelp/puppet-package_purging/subscribers","subscription_url":"https://api.github.com/repos/Yelp/puppet-package_purging/subscription","commits_url":"https://api.github.com/repos/Yelp/puppet-package_purging/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/puppet-package_purging/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/puppet-package_purging/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/puppet-package_purging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/puppet-package_purging/merges","archive_url":"https://api.github.com/repos/Yelp/puppet-package_purging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/puppet-package_purging/downloads","issues_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/puppet-package_purging/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/puppet-package_purging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/puppet-package_purging/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/puppet-package_purging/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/puppet-package_purging/deployments","created_at":"2016-12-30T08:42:01Z","updated_at":"2016-12-30T08:42:03Z","pushed_at":"2017-03-29T11:53:00Z","git_url":"git://github.com/Yelp/puppet-package_purging.git","ssh_url":"git@github.com:Yelp/puppet-package_purging.git","clone_url":"https://github.com/Yelp/puppet-package_purging.git","svn_url":"https://github.com/Yelp/puppet-package_purging","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"7b0ac682044d1e6f922d1734e8acf8e799664d2b","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars2.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":77673634,"name":"puppet-package_purging","full_name":"Yelp/puppet-package_purging","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars2.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/puppet-package_purging","description":"Puppet types to purge unneeded system packages","fork":true,"url":"https://api.github.com/repos/Yelp/puppet-package_purging","forks_url":"https://api.github.com/repos/Yelp/puppet-package_purging/forks","keys_url":"https://api.github.com/repos/Yelp/puppet-package_purging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/puppet-package_purging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/puppet-package_purging/teams","hooks_url":"https://api.github.com/repos/Yelp/puppet-package_purging/hooks","issue_events_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/puppet-package_purging/events","assignees_url":"https://api.github.com/repos/Yelp/puppet-package_purging/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/puppet-package_purging/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/puppet-package_purging/tags","blobs_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/puppet-package_purging/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/puppet-package_purging/languages","stargazers_url":"https://api.github.com/repos/Yelp/puppet-package_purging/stargazers","contributors_url":"https://api.github.com/repos/Yelp/puppet-package_purging/contributors","subscribers_url":"https://api.github.com/repos/Yelp/puppet-package_purging/subscribers","subscription_url":"https://api.github.com/repos/Yelp/puppet-package_purging/subscription","commits_url":"https://api.github.com/repos/Yelp/puppet-package_purging/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/puppet-package_purging/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/puppet-package_purging/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/puppet-package_purging/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/puppet-package_purging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/puppet-package_purging/merges","archive_url":"https://api.github.com/repos/Yelp/puppet-package_purging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/puppet-package_purging/downloads","issues_url":"https://api.github.com/repos/Yelp/puppet-package_purging/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/puppet-package_purging/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/puppet-package_purging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/puppet-package_purging/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/puppet-package_purging/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/puppet-package_purging/deployments","created_at":"2016-12-30T08:42:01Z","updated_at":"2016-12-30T08:42:03Z","pushed_at":"2017-03-29T11:53:00Z","git_url":"git://github.com/Yelp/puppet-package_purging.git","ssh_url":"git@github.com:Yelp/puppet-package_purging.git","clone_url":"https://github.com/Yelp/puppet-package_purging.git","svn_url":"https://github.com/Yelp/puppet-package_purging","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/3"},"html":{"href":"https://github.com/Yelp/puppet-package_purging/pull/3"},"issue":{"href":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/3"},"comments":{"href":"https://api.github.com/repos/Yelp/puppet-package_purging/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/puppet-package_purging/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/puppet-package_purging/statuses/a37acdda4204ba87b7f411b44462bfffd27a2093"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"giuliano108","id":615907,"avatar_url":"https://avatars3.githubusercontent.com/u/615907?v=3","gravatar_id":"","url":"https://api.github.com/users/giuliano108","html_url":"https://github.com/giuliano108","followers_url":"https://api.github.com/users/giuliano108/followers","following_url":"https://api.github.com/users/giuliano108/following{/other_user}","gists_url":"https://api.github.com/users/giuliano108/gists{/gist_id}","starred_url":"https://api.github.com/users/giuliano108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuliano108/subscriptions","organizations_url":"https://api.github.com/users/giuliano108/orgs","repos_url":"https://api.github.com/users/giuliano108/repos","events_url":"https://api.github.com/users/giuliano108/events{/privacy}","received_events_url":"https://api.github.com/users/giuliano108/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":211,"deletions":0,"changed_files":7}}
{"actor":{"display_login":"giuliano108"}}