{"action":"created","comment":{"url":"https://api.github.com/repos/angular/clutz/pulls/comments/157078830","pull_request_review_id":83663451,"id":157078830,"diff_hunk":"@@ -49,10 +80,11 @@ private static boolean isGoogRequireAssignment(Node statement) {\n \n     return rightHandSide != null\n         && rightHandSide.isCall()\n-        && rightHandSide.getFirstChild().matchesQualifiedName(\"goog.require\");\n+        && (rightHandSide.getFirstChild().matchesQualifiedName(\"goog.require\")","path":"src/main/java/com/google/javascript/clutz/ImportRenameMapBuilder.java","position":95,"original_position":91,"commit_id":"b3c978ddf364fa80d8f872de6bf47356df9a0745","original_commit_id":"b32243f9e9d5384b864a63c0774109fbbbc382a8","user":{"login":"LucasSloan","id":102313,"avatar_url":"https://avatars0.githubusercontent.com/u/102313?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasSloan","html_url":"https://github.com/LucasSloan","followers_url":"https://api.github.com/users/LucasSloan/followers","following_url":"https://api.github.com/users/LucasSloan/following{/other_user}","gists_url":"https://api.github.com/users/LucasSloan/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasSloan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasSloan/subscriptions","organizations_url":"https://api.github.com/users/LucasSloan/orgs","repos_url":"https://api.github.com/users/LucasSloan/repos","events_url":"https://api.github.com/users/LucasSloan/events{/privacy}","received_events_url":"https://api.github.com/users/LucasSloan/received_events","type":"User","site_admin":false},"body":"This method matches either a `goog.require` or a `goog.module.get`.  Which it will find depends on whether a goog.module body was passed to `build` or a goog.scope body.  I've added comments.","created_at":"2017-12-14T22:23:54Z","updated_at":"2017-12-14T22:26:36Z","html_url":"https://github.com/angular/clutz/pull/621#discussion_r157078830","pull_request_url":"https://api.github.com/repos/angular/clutz/pulls/621","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/clutz/pulls/comments/157078830"},"html":{"href":"https://github.com/angular/clutz/pull/621#discussion_r157078830"},"pull_request":{"href":"https://api.github.com/repos/angular/clutz/pulls/621"}},"in_reply_to_id":157046161},"pull_request":{"url":"https://api.github.com/repos/angular/clutz/pulls/621","id":158437218,"html_url":"https://github.com/angular/clutz/pull/621","diff_url":"https://github.com/angular/clutz/pull/621.diff","patch_url":"https://github.com/angular/clutz/pull/621.patch","issue_url":"https://api.github.com/repos/angular/clutz/issues/621","number":621,"state":"open","locked":false,"title":"Rename missing imported symbols in goog.scope.","user":{"login":"LucasSloan","id":102313,"avatar_url":"https://avatars0.githubusercontent.com/u/102313?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasSloan","html_url":"https://github.com/LucasSloan","followers_url":"https://api.github.com/users/LucasSloan/followers","following_url":"https://api.github.com/users/LucasSloan/following{/other_user}","gists_url":"https://api.github.com/users/LucasSloan/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasSloan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasSloan/subscriptions","organizations_url":"https://api.github.com/users/LucasSloan/orgs","repos_url":"https://api.github.com/users/LucasSloan/repos","events_url":"https://api.github.com/users/LucasSloan/events{/privacy}","received_events_url":"https://api.github.com/users/LucasSloan/received_events","type":"User","site_admin":false},"body":"Similar to having to rename symbols that are imported in goog.modules(), closure doesn't get the right name for symbols imported inside a goog.scope block.  This PR modifies ImportRenameMapBuilder to collect the rename mappings inside goog.scope blocks, in addition to the existing goog.modules.","created_at":"2017-12-14T19:02:42Z","updated_at":"2017-12-14T22:26:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3ee8507c8bef8616e34ce63fbd9dfaa6a110bcd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/clutz/pulls/621/commits","review_comments_url":"https://api.github.com/repos/angular/clutz/pulls/621/comments","review_comment_url":"https://api.github.com/repos/angular/clutz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/clutz/issues/621/comments","statuses_url":"https://api.github.com/repos/angular/clutz/statuses/b3c978ddf364fa80d8f872de6bf47356df9a0745","head":{"label":"angular:goog-scope-var-rename","ref":"goog-scope-var-rename","sha":"b3c978ddf364fa80d8f872de6bf47356df9a0745","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":31076984,"name":"clutz","full_name":"angular/clutz","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/clutz","description":"Closure to TypeScript `.d.ts` generator","fork":false,"url":"https://api.github.com/repos/angular/clutz","forks_url":"https://api.github.com/repos/angular/clutz/forks","keys_url":"https://api.github.com/repos/angular/clutz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/clutz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/clutz/teams","hooks_url":"https://api.github.com/repos/angular/clutz/hooks","issue_events_url":"https://api.github.com/repos/angular/clutz/issues/events{/number}","events_url":"https://api.github.com/repos/angular/clutz/events","assignees_url":"https://api.github.com/repos/angular/clutz/assignees{/user}","branches_url":"https://api.github.com/repos/angular/clutz/branches{/branch}","tags_url":"https://api.github.com/repos/angular/clutz/tags","blobs_url":"https://api.github.com/repos/angular/clutz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/clutz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/clutz/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/clutz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/clutz/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/clutz/languages","stargazers_url":"https://api.github.com/repos/angular/clutz/stargazers","contributors_url":"https://api.github.com/repos/angular/clutz/contributors","subscribers_url":"https://api.github.com/repos/angular/clutz/subscribers","subscription_url":"https://api.github.com/repos/angular/clutz/subscription","commits_url":"https://api.github.com/repos/angular/clutz/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/clutz/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/clutz/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/clutz/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/clutz/contents/{+path}","compare_url":"https://api.github.com/repos/angular/clutz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/clutz/merges","archive_url":"https://api.github.com/repos/angular/clutz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/clutz/downloads","issues_url":"https://api.github.com/repos/angular/clutz/issues{/number}","pulls_url":"https://api.github.com/repos/angular/clutz/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/clutz/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/clutz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/clutz/labels{/name}","releases_url":"https://api.github.com/repos/angular/clutz/releases{/id}","deployments_url":"https://api.github.com/repos/angular/clutz/deployments","created_at":"2015-02-20T17:52:24Z","updated_at":"2017-12-10T08:17:20Z","pushed_at":"2017-12-14T22:26:36Z","git_url":"git://github.com/angular/clutz.git","ssh_url":"git@github.com:angular/clutz.git","clone_url":"https://github.com/angular/clutz.git","svn_url":"https://github.com/angular/clutz","homepage":"","size":1650,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":34,"open_issues":63,"watchers":67,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1d0fbd46398f55393fd6c891728e3702b0468fa0","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":31076984,"name":"clutz","full_name":"angular/clutz","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/clutz","description":"Closure to TypeScript `.d.ts` generator","fork":false,"url":"https://api.github.com/repos/angular/clutz","forks_url":"https://api.github.com/repos/angular/clutz/forks","keys_url":"https://api.github.com/repos/angular/clutz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/clutz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/clutz/teams","hooks_url":"https://api.github.com/repos/angular/clutz/hooks","issue_events_url":"https://api.github.com/repos/angular/clutz/issues/events{/number}","events_url":"https://api.github.com/repos/angular/clutz/events","assignees_url":"https://api.github.com/repos/angular/clutz/assignees{/user}","branches_url":"https://api.github.com/repos/angular/clutz/branches{/branch}","tags_url":"https://api.github.com/repos/angular/clutz/tags","blobs_url":"https://api.github.com/repos/angular/clutz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/clutz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/clutz/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/clutz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/clutz/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/clutz/languages","stargazers_url":"https://api.github.com/repos/angular/clutz/stargazers","contributors_url":"https://api.github.com/repos/angular/clutz/contributors","subscribers_url":"https://api.github.com/repos/angular/clutz/subscribers","subscription_url":"https://api.github.com/repos/angular/clutz/subscription","commits_url":"https://api.github.com/repos/angular/clutz/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/clutz/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/clutz/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/clutz/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/clutz/contents/{+path}","compare_url":"https://api.github.com/repos/angular/clutz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/clutz/merges","archive_url":"https://api.github.com/repos/angular/clutz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/clutz/downloads","issues_url":"https://api.github.com/repos/angular/clutz/issues{/number}","pulls_url":"https://api.github.com/repos/angular/clutz/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/clutz/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/clutz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/clutz/labels{/name}","releases_url":"https://api.github.com/repos/angular/clutz/releases{/id}","deployments_url":"https://api.github.com/repos/angular/clutz/deployments","created_at":"2015-02-20T17:52:24Z","updated_at":"2017-12-10T08:17:20Z","pushed_at":"2017-12-14T22:26:36Z","git_url":"git://github.com/angular/clutz.git","ssh_url":"git@github.com:angular/clutz.git","clone_url":"https://github.com/angular/clutz.git","svn_url":"https://github.com/angular/clutz","homepage":"","size":1650,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":34,"open_issues":63,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/clutz/pulls/621"},"html":{"href":"https://github.com/angular/clutz/pull/621"},"issue":{"href":"https://api.github.com/repos/angular/clutz/issues/621"},"comments":{"href":"https://api.github.com/repos/angular/clutz/issues/621/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/clutz/pulls/621/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/clutz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/clutz/pulls/621/commits"},"statuses":{"href":"https://api.github.com/repos/angular/clutz/statuses/b3c978ddf364fa80d8f872de6bf47356df9a0745"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LucasSloan"}}