{"action":"created","comment":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/comments/132639696","pull_request_review_id":55742075,"id":132639696,"diff_hunk":"@@ -155,8 +155,8 @@ export class PetService {\n     }\n \n     /**\n-     * Update an existing pet\n      * \n+     * @summary Update an existing pet","path":"samples/client/petstore/typescript-angular2/npm/api/pet.service.ts","position":56,"original_position":56,"commit_id":"9a85ecd48a79730105412f98585d8acdd11f3b9c","original_commit_id":"9a85ecd48a79730105412f98585d8acdd11f3b9c","user":{"login":"bobvanderlinden","id":6375609,"avatar_url":"https://avatars1.githubusercontent.com/u/6375609?v=4","gravatar_id":"","url":"https://api.github.com/users/bobvanderlinden","html_url":"https://github.com/bobvanderlinden","followers_url":"https://api.github.com/users/bobvanderlinden/followers","following_url":"https://api.github.com/users/bobvanderlinden/following{/other_user}","gists_url":"https://api.github.com/users/bobvanderlinden/gists{/gist_id}","starred_url":"https://api.github.com/users/bobvanderlinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobvanderlinden/subscriptions","organizations_url":"https://api.github.com/users/bobvanderlinden/orgs","repos_url":"https://api.github.com/users/bobvanderlinden/repos","events_url":"https://api.github.com/users/bobvanderlinden/events{/privacy}","received_events_url":"https://api.github.com/users/bobvanderlinden/received_events","type":"User","site_admin":false},"body":"This change seems unrelated.","created_at":"2017-08-11T08:44:45Z","updated_at":"2017-08-11T08:47:36Z","html_url":"https://github.com/swagger-api/swagger-codegen/pull/6233#discussion_r132639696","pull_request_url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233","_links":{"self":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/comments/132639696"},"html":{"href":"https://github.com/swagger-api/swagger-codegen/pull/6233#discussion_r132639696"},"pull_request":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233"}}},"pull_request":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233","id":134053497,"html_url":"https://github.com/swagger-api/swagger-codegen/pull/6233","diff_url":"https://github.com/swagger-api/swagger-codegen/pull/6233.diff","patch_url":"https://github.com/swagger-api/swagger-codegen/pull/6233.patch","issue_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6233","number":6233,"state":"open","locked":false,"title":"represent swagger enums as union of literal types","user":{"login":"bedag-moo","id":13641660,"avatar_url":"https://avatars0.githubusercontent.com/u/13641660?v=4","gravatar_id":"","url":"https://api.github.com/users/bedag-moo","html_url":"https://github.com/bedag-moo","followers_url":"https://api.github.com/users/bedag-moo/followers","following_url":"https://api.github.com/users/bedag-moo/following{/other_user}","gists_url":"https://api.github.com/users/bedag-moo/gists{/gist_id}","starred_url":"https://api.github.com/users/bedag-moo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedag-moo/subscriptions","organizations_url":"https://api.github.com/users/bedag-moo/orgs","repos_url":"https://api.github.com/users/bedag-moo/repos","events_url":"https://api.github.com/users/bedag-moo/events{/privacy}","received_events_url":"https://api.github.com/users/bedag-moo/received_events","type":"User","site_admin":false},"body":"### PR checklist\r\n\r\n- [x] Read the [contribution guidelines](https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md).\r\n- [x] Ran the shell script under `./bin/` to update Petstore sample so that CIs can verify the change. (For instance, only need to run `./bin/{LANG}-petstore.sh` and `./bin/security/{LANG}-petstore.sh` if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in `.\\bin\\windows\\`.\r\n- [x] Filed the PR against the correct branch: master for non-breaking changes and `3.0.0` branch for breaking (non-backward compatible) changes.\r\n\r\n### Description of the PR\r\n\r\nThis PR changes the angular-typescript generator to emit a union of literals for swagger enums, e.g.:\r\n\r\n    export type StatusEnum = 'open' | 'inProgress' | 'resolved' | 'closed';\r\n\r\nor\r\n    \r\n    export type ResponseCode = 200 | 404;\r\n\r\nenabling their easy use in angular templates, structural subtyping\r\namong enums (in particular, different instances of the same enum\r\nare now mutually assignable), improving type safety by preventing\r\nincorrect widening, and permitting numeric enum values\r\n(albeit without descriptive names)\r\n\r\nFixes #6206, #5146, #3500","created_at":"2017-08-03T22:14:28Z","updated_at":"2017-08-11T08:47:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d32e767320b83ad903c14bfdc3ae7ff3cbc702","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233/commits","review_comments_url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233/comments","review_comment_url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6233/comments","statuses_url":"https://api.github.com/repos/swagger-api/swagger-codegen/statuses/9a85ecd48a79730105412f98585d8acdd11f3b9c","head":{"label":"bedag:2.3.0","ref":"2.3.0","sha":"9a85ecd48a79730105412f98585d8acdd11f3b9c","user":{"login":"bedag","id":11767306,"avatar_url":"https://avatars0.githubusercontent.com/u/11767306?v=4","gravatar_id":"","url":"https://api.github.com/users/bedag","html_url":"https://github.com/bedag","followers_url":"https://api.github.com/users/bedag/followers","following_url":"https://api.github.com/users/bedag/following{/other_user}","gists_url":"https://api.github.com/users/bedag/gists{/gist_id}","starred_url":"https://api.github.com/users/bedag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedag/subscriptions","organizations_url":"https://api.github.com/users/bedag/orgs","repos_url":"https://api.github.com/users/bedag/repos","events_url":"https://api.github.com/users/bedag/events{/privacy}","received_events_url":"https://api.github.com/users/bedag/received_events","type":"Organization","site_admin":false},"repo":{"id":99277022,"name":"swagger-codegen","full_name":"bedag/swagger-codegen","owner":{"login":"bedag","id":11767306,"avatar_url":"https://avatars0.githubusercontent.com/u/11767306?v=4","gravatar_id":"","url":"https://api.github.com/users/bedag","html_url":"https://github.com/bedag","followers_url":"https://api.github.com/users/bedag/followers","following_url":"https://api.github.com/users/bedag/following{/other_user}","gists_url":"https://api.github.com/users/bedag/gists{/gist_id}","starred_url":"https://api.github.com/users/bedag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedag/subscriptions","organizations_url":"https://api.github.com/users/bedag/orgs","repos_url":"https://api.github.com/users/bedag/repos","events_url":"https://api.github.com/users/bedag/events{/privacy}","received_events_url":"https://api.github.com/users/bedag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bedag/swagger-codegen","description":"swagger-codegen contains a template-driven engine to generate documentation, API clients and server stubs in different languages by parsing your OpenAPI / Swagger definition.","fork":true,"url":"https://api.github.com/repos/bedag/swagger-codegen","forks_url":"https://api.github.com/repos/bedag/swagger-codegen/forks","keys_url":"https://api.github.com/repos/bedag/swagger-codegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bedag/swagger-codegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bedag/swagger-codegen/teams","hooks_url":"https://api.github.com/repos/bedag/swagger-codegen/hooks","issue_events_url":"https://api.github.com/repos/bedag/swagger-codegen/issues/events{/number}","events_url":"https://api.github.com/repos/bedag/swagger-codegen/events","assignees_url":"https://api.github.com/repos/bedag/swagger-codegen/assignees{/user}","branches_url":"https://api.github.com/repos/bedag/swagger-codegen/branches{/branch}","tags_url":"https://api.github.com/repos/bedag/swagger-codegen/tags","blobs_url":"https://api.github.com/repos/bedag/swagger-codegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bedag/swagger-codegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bedag/swagger-codegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/bedag/swagger-codegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bedag/swagger-codegen/statuses/{sha}","languages_url":"https://api.github.com/repos/bedag/swagger-codegen/languages","stargazers_url":"https://api.github.com/repos/bedag/swagger-codegen/stargazers","contributors_url":"https://api.github.com/repos/bedag/swagger-codegen/contributors","subscribers_url":"https://api.github.com/repos/bedag/swagger-codegen/subscribers","subscription_url":"https://api.github.com/repos/bedag/swagger-codegen/subscription","commits_url":"https://api.github.com/repos/bedag/swagger-codegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/bedag/swagger-codegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/bedag/swagger-codegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/bedag/swagger-codegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/bedag/swagger-codegen/contents/{+path}","compare_url":"https://api.github.com/repos/bedag/swagger-codegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bedag/swagger-codegen/merges","archive_url":"https://api.github.com/repos/bedag/swagger-codegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bedag/swagger-codegen/downloads","issues_url":"https://api.github.com/repos/bedag/swagger-codegen/issues{/number}","pulls_url":"https://api.github.com/repos/bedag/swagger-codegen/pulls{/number}","milestones_url":"https://api.github.com/repos/bedag/swagger-codegen/milestones{/number}","notifications_url":"https://api.github.com/repos/bedag/swagger-codegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bedag/swagger-codegen/labels{/name}","releases_url":"https://api.github.com/repos/bedag/swagger-codegen/releases{/id}","deployments_url":"https://api.github.com/repos/bedag/swagger-codegen/deployments","created_at":"2017-08-03T21:37:25Z","updated_at":"2017-08-03T21:37:35Z","pushed_at":"2017-08-03T22:14:59Z","git_url":"git://github.com/bedag/swagger-codegen.git","ssh_url":"git@github.com:bedag/swagger-codegen.git","clone_url":"https://github.com/bedag/swagger-codegen.git","svn_url":"https://github.com/bedag/swagger-codegen","homepage":"http://swagger.io","size":52769,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swagger-api:2.3.0","ref":"2.3.0","sha":"5219b9c26f3d459b56710277022f36ba73a00e01","user":{"login":"swagger-api","id":7658037,"avatar_url":"https://avatars3.githubusercontent.com/u/7658037?v=4","gravatar_id":"","url":"https://api.github.com/users/swagger-api","html_url":"https://github.com/swagger-api","followers_url":"https://api.github.com/users/swagger-api/followers","following_url":"https://api.github.com/users/swagger-api/following{/other_user}","gists_url":"https://api.github.com/users/swagger-api/gists{/gist_id}","starred_url":"https://api.github.com/users/swagger-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swagger-api/subscriptions","organizations_url":"https://api.github.com/users/swagger-api/orgs","repos_url":"https://api.github.com/users/swagger-api/repos","events_url":"https://api.github.com/users/swagger-api/events{/privacy}","received_events_url":"https://api.github.com/users/swagger-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2006876,"name":"swagger-codegen","full_name":"swagger-api/swagger-codegen","owner":{"login":"swagger-api","id":7658037,"avatar_url":"https://avatars3.githubusercontent.com/u/7658037?v=4","gravatar_id":"","url":"https://api.github.com/users/swagger-api","html_url":"https://github.com/swagger-api","followers_url":"https://api.github.com/users/swagger-api/followers","following_url":"https://api.github.com/users/swagger-api/following{/other_user}","gists_url":"https://api.github.com/users/swagger-api/gists{/gist_id}","starred_url":"https://api.github.com/users/swagger-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swagger-api/subscriptions","organizations_url":"https://api.github.com/users/swagger-api/orgs","repos_url":"https://api.github.com/users/swagger-api/repos","events_url":"https://api.github.com/users/swagger-api/events{/privacy}","received_events_url":"https://api.github.com/users/swagger-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swagger-api/swagger-codegen","description":"swagger-codegen contains a template-driven engine to generate documentation, API clients and server stubs in different languages by parsing your OpenAPI / Swagger definition.","fork":false,"url":"https://api.github.com/repos/swagger-api/swagger-codegen","forks_url":"https://api.github.com/repos/swagger-api/swagger-codegen/forks","keys_url":"https://api.github.com/repos/swagger-api/swagger-codegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swagger-api/swagger-codegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swagger-api/swagger-codegen/teams","hooks_url":"https://api.github.com/repos/swagger-api/swagger-codegen/hooks","issue_events_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/events{/number}","events_url":"https://api.github.com/repos/swagger-api/swagger-codegen/events","assignees_url":"https://api.github.com/repos/swagger-api/swagger-codegen/assignees{/user}","branches_url":"https://api.github.com/repos/swagger-api/swagger-codegen/branches{/branch}","tags_url":"https://api.github.com/repos/swagger-api/swagger-codegen/tags","blobs_url":"https://api.github.com/repos/swagger-api/swagger-codegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swagger-api/swagger-codegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swagger-api/swagger-codegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/swagger-api/swagger-codegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swagger-api/swagger-codegen/statuses/{sha}","languages_url":"https://api.github.com/repos/swagger-api/swagger-codegen/languages","stargazers_url":"https://api.github.com/repos/swagger-api/swagger-codegen/stargazers","contributors_url":"https://api.github.com/repos/swagger-api/swagger-codegen/contributors","subscribers_url":"https://api.github.com/repos/swagger-api/swagger-codegen/subscribers","subscription_url":"https://api.github.com/repos/swagger-api/swagger-codegen/subscription","commits_url":"https://api.github.com/repos/swagger-api/swagger-codegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/swagger-api/swagger-codegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/swagger-api/swagger-codegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/swagger-api/swagger-codegen/contents/{+path}","compare_url":"https://api.github.com/repos/swagger-api/swagger-codegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swagger-api/swagger-codegen/merges","archive_url":"https://api.github.com/repos/swagger-api/swagger-codegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swagger-api/swagger-codegen/downloads","issues_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues{/number}","pulls_url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls{/number}","milestones_url":"https://api.github.com/repos/swagger-api/swagger-codegen/milestones{/number}","notifications_url":"https://api.github.com/repos/swagger-api/swagger-codegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swagger-api/swagger-codegen/labels{/name}","releases_url":"https://api.github.com/repos/swagger-api/swagger-codegen/releases{/id}","deployments_url":"https://api.github.com/repos/swagger-api/swagger-codegen/deployments","created_at":"2011-07-06T14:26:48Z","updated_at":"2017-08-11T08:31:40Z","pushed_at":"2017-08-11T08:26:17Z","git_url":"git://github.com/swagger-api/swagger-codegen.git","ssh_url":"git@github.com:swagger-api/swagger-codegen.git","clone_url":"https://github.com/swagger-api/swagger-codegen.git","svn_url":"https://github.com/swagger-api/swagger-codegen","homepage":"http://swagger.io","size":53028,"stargazers_count":4779,"watchers_count":4779,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2645,"mirror_url":null,"open_issues_count":913,"forks":2645,"open_issues":913,"watchers":4779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233"},"html":{"href":"https://github.com/swagger-api/swagger-codegen/pull/6233"},"issue":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6233"},"comments":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6233/comments"},"review_comments":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233/comments"},"review_comment":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6233/commits"},"statuses":{"href":"https://api.github.com/repos/swagger-api/swagger-codegen/statuses/9a85ecd48a79730105412f98585d8acdd11f3b9c"}}}}
{"actor":{"display_login":"bobvanderlinden"}}