{"action":"created","issue":{"url":"https://api.github.com/repos/scottwainstock/pbm/issues/668","repository_url":"https://api.github.com/repos/scottwainstock/pbm","labels_url":"https://api.github.com/repos/scottwainstock/pbm/issues/668/labels{/name}","comments_url":"https://api.github.com/repos/scottwainstock/pbm/issues/668/comments","events_url":"https://api.github.com/repos/scottwainstock/pbm/issues/668/events","html_url":"https://github.com/scottwainstock/pbm/pull/668","id":221919771,"number":668,"title":"Search results follow","user":{"login":"RyanTG","id":632682,"avatar_url":"https://avatars0.githubusercontent.com/u/632682?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanTG","html_url":"https://github.com/RyanTG","followers_url":"https://api.github.com/users/RyanTG/followers","following_url":"https://api.github.com/users/RyanTG/following{/other_user}","gists_url":"https://api.github.com/users/RyanTG/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanTG/subscriptions","organizations_url":"https://api.github.com/users/RyanTG/orgs","repos_url":"https://api.github.com/users/RyanTG/repos","events_url":"https://api.github.com/users/RyanTG/events{/privacy}","received_events_url":"https://api.github.com/users/RyanTG/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-15T01:54:45Z","updated_at":"2017-04-15T20:30:46Z","closed_at":"2017-04-15T19:54:03Z","pull_request":{"url":"https://api.github.com/repos/scottwainstock/pbm/pulls/668","html_url":"https://github.com/scottwainstock/pbm/pull/668","diff_url":"https://github.com/scottwainstock/pbm/pull/668.diff","patch_url":"https://github.com/scottwainstock/pbm/pull/668.patch"},"body":"Ok, I think this is aight."},"comment":{"url":"https://api.github.com/repos/scottwainstock/pbm/issues/comments/294316214","html_url":"https://github.com/scottwainstock/pbm/pull/668#issuecomment-294316214","issue_url":"https://api.github.com/repos/scottwainstock/pbm/issues/668","id":294316214,"user":{"login":"RyanTG","id":632682,"avatar_url":"https://avatars0.githubusercontent.com/u/632682?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanTG","html_url":"https://github.com/RyanTG","followers_url":"https://api.github.com/users/RyanTG/followers","following_url":"https://api.github.com/users/RyanTG/following{/other_user}","gists_url":"https://api.github.com/users/RyanTG/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanTG/subscriptions","organizations_url":"https://api.github.com/users/RyanTG/orgs","repos_url":"https://api.github.com/users/RyanTG/repos","events_url":"https://api.github.com/users/RyanTG/events{/privacy}","received_events_url":"https://api.github.com/users/RyanTG/received_events","type":"User","site_admin":false},"created_at":"2017-04-15T20:30:46Z","updated_at":"2017-04-15T20:30:46Z","body":"I merged master into it, but didn't rebase. Guess that was the wrong thing to do...\n\nOn April 15, 2017 1:12:06 PM PDT, Scott Wainstock <notifications@github.com> wrote:\n>@RyanTG I rebased a clean master branch against this and I see a lot of\n>test failures...\n>\n>Was your branch rebased against master?\n>\n>```\n>rspec ./spec/features/location_machine_xrefs_controller_spec.rb:30 #\n>LocationMachineXrefsController add machines Should add by id\n>rspec ./spec/features/location_machine_xrefs_controller_spec.rb:207 #\n>LocationMachineXrefsController machine descriptions should let me add a\n>new machine description\n>rspec ./spec/features/locations_controller_spec.rb:19 #\n>LocationsController confirm location lets you click a button to update\n>the date_last_updated\n>rspec ./spec/features/locations_controller_spec.rb:30 #\n>LocationsController confirm location displays no username when it was\n>last updated by a non-user\n>rspec ./spec/features/locations_controller_spec.rb:79 #\n>LocationsController remove machine removes a machine from a location\n>rspec ./spec/features/locations_controller_spec.rb:166 #\n>LocationsController initial search by passed in param\n>by_machine_group_id\n>rspec ./spec/features/locations_controller_spec.rb:241 #\n>LocationsController initial search by passed in param by_machine_id\n>rspec ./spec/features/locations_controller_spec.rb:269 #\n>LocationsController update_metadata does not save data if any formats\n>are invalid - website and phone\n>rspec ./spec/features/locations_controller_spec.rb:336 #\n>LocationsController update_metadata allows users to update a location\n>metadata - stubbed out spam detection\n>rspec ./spec/features/locations_controller_spec.rb:358 #\n>LocationsController update_metadata allows users to update a location\n>metadata - TWICE\n>rspec ./spec/features/locations_controller_spec.rb:393 #\n>LocationsController update_desc does not save spam\n>rspec ./spec/features/locations_controller_spec.rb:465 #\n>LocationsController update_desc allows users to update a location\n>description - skips validation\n>rspec ./spec/models/region_spec.rb:32 #\n>Region#generate_daily_digest_comments_email_body should generate a\n>string containing all machine comments from the day\n>rspec ./spec/models/region_spec.rb:52 #\n>Region#generate_daily_digest_removals_email_body should generate a\n>string containing all machine removals from the day\n>```\n>\n>-- \n>You are receiving this because you were mentioned.\n>Reply to this email directly or view it on GitHub:\n>https://github.com/scottwainstock/pbm/pull/668#issuecomment-294315331\n\n-- \nSent while mobile."}}
{"actor":{"display_login":"RyanTG"}}