{"action":"closed","number":265,"pull_request":{"url":"https://api.github.com/repos/cisco/libsrtp/pulls/265","id":109195879,"html_url":"https://github.com/cisco/libsrtp/pull/265","diff_url":"https://github.com/cisco/libsrtp/pull/265.diff","patch_url":"https://github.com/cisco/libsrtp/pull/265.patch","issue_url":"https://api.github.com/repos/cisco/libsrtp/issues/265","number":265,"state":"closed","locked":false,"title":"Suggestion for unit tests framework","user":{"login":"thisisG","id":5999908,"avatar_url":"https://avatars2.githubusercontent.com/u/5999908?v=3","gravatar_id":"","url":"https://api.github.com/users/thisisG","html_url":"https://github.com/thisisG","followers_url":"https://api.github.com/users/thisisG/followers","following_url":"https://api.github.com/users/thisisG/following{/other_user}","gists_url":"https://api.github.com/users/thisisG/gists{/gist_id}","starred_url":"https://api.github.com/users/thisisG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisisG/subscriptions","organizations_url":"https://api.github.com/users/thisisG/orgs","repos_url":"https://api.github.com/users/thisisG/repos","events_url":"https://api.github.com/users/thisisG/events{/privacy}","received_events_url":"https://api.github.com/users/thisisG/received_events","type":"User","site_admin":false},"body":"This is a very simple header only framework without bells and whistles. See commit introducing the framework for more information.\r\n\r\nThis is in response to requests for more tests in #259. A commented out test is included which depends on #262 to ensure we get an error if we exceed a sequence number of `0x7FFFFFFF` in `srtp_calc_aead_iv_srtcp()`.\r\n\r\nNo work has been done to start moving tests from test drivers. The reasons are:\r\n\r\n  1) Want to ensure we settle on a framework before porting any tests.\r\n  2) One could argue the test drivers are integration/module tests which can be seen as orthogonal to unit tests.\r\n","created_at":"2017-03-06T06:13:30Z","updated_at":"2017-03-10T12:52:59Z","closed_at":"2017-03-10T12:52:59Z","merged_at":"2017-03-10T12:52:59Z","merge_commit_sha":"12d46f5ee64a75d821b82c24f83370a63cb57967","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cisco/libsrtp/pulls/265/commits","review_comments_url":"https://api.github.com/repos/cisco/libsrtp/pulls/265/comments","review_comment_url":"https://api.github.com/repos/cisco/libsrtp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/libsrtp/issues/265/comments","statuses_url":"https://api.github.com/repos/cisco/libsrtp/statuses/66a3c718568e78412750dab333751933282a249f","head":{"label":"thisisG:unit_tests","ref":"unit_tests","sha":"66a3c718568e78412750dab333751933282a249f","user":{"login":"thisisG","id":5999908,"avatar_url":"https://avatars2.githubusercontent.com/u/5999908?v=3","gravatar_id":"","url":"https://api.github.com/users/thisisG","html_url":"https://github.com/thisisG","followers_url":"https://api.github.com/users/thisisG/followers","following_url":"https://api.github.com/users/thisisG/following{/other_user}","gists_url":"https://api.github.com/users/thisisG/gists{/gist_id}","starred_url":"https://api.github.com/users/thisisG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisisG/subscriptions","organizations_url":"https://api.github.com/users/thisisG/orgs","repos_url":"https://api.github.com/users/thisisG/repos","events_url":"https://api.github.com/users/thisisG/events{/privacy}","received_events_url":"https://api.github.com/users/thisisG/received_events","type":"User","site_admin":false},"repo":{"id":79783514,"name":"libsrtp","full_name":"thisisG/libsrtp","owner":{"login":"thisisG","id":5999908,"avatar_url":"https://avatars2.githubusercontent.com/u/5999908?v=3","gravatar_id":"","url":"https://api.github.com/users/thisisG","html_url":"https://github.com/thisisG","followers_url":"https://api.github.com/users/thisisG/followers","following_url":"https://api.github.com/users/thisisG/following{/other_user}","gists_url":"https://api.github.com/users/thisisG/gists{/gist_id}","starred_url":"https://api.github.com/users/thisisG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisisG/subscriptions","organizations_url":"https://api.github.com/users/thisisG/orgs","repos_url":"https://api.github.com/users/thisisG/repos","events_url":"https://api.github.com/users/thisisG/events{/privacy}","received_events_url":"https://api.github.com/users/thisisG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thisisG/libsrtp","description":"Library for SRTP (Secure Realtime Transport Protocol) ","fork":true,"url":"https://api.github.com/repos/thisisG/libsrtp","forks_url":"https://api.github.com/repos/thisisG/libsrtp/forks","keys_url":"https://api.github.com/repos/thisisG/libsrtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thisisG/libsrtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thisisG/libsrtp/teams","hooks_url":"https://api.github.com/repos/thisisG/libsrtp/hooks","issue_events_url":"https://api.github.com/repos/thisisG/libsrtp/issues/events{/number}","events_url":"https://api.github.com/repos/thisisG/libsrtp/events","assignees_url":"https://api.github.com/repos/thisisG/libsrtp/assignees{/user}","branches_url":"https://api.github.com/repos/thisisG/libsrtp/branches{/branch}","tags_url":"https://api.github.com/repos/thisisG/libsrtp/tags","blobs_url":"https://api.github.com/repos/thisisG/libsrtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thisisG/libsrtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thisisG/libsrtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/thisisG/libsrtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thisisG/libsrtp/statuses/{sha}","languages_url":"https://api.github.com/repos/thisisG/libsrtp/languages","stargazers_url":"https://api.github.com/repos/thisisG/libsrtp/stargazers","contributors_url":"https://api.github.com/repos/thisisG/libsrtp/contributors","subscribers_url":"https://api.github.com/repos/thisisG/libsrtp/subscribers","subscription_url":"https://api.github.com/repos/thisisG/libsrtp/subscription","commits_url":"https://api.github.com/repos/thisisG/libsrtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/thisisG/libsrtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/thisisG/libsrtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/thisisG/libsrtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/thisisG/libsrtp/contents/{+path}","compare_url":"https://api.github.com/repos/thisisG/libsrtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thisisG/libsrtp/merges","archive_url":"https://api.github.com/repos/thisisG/libsrtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thisisG/libsrtp/downloads","issues_url":"https://api.github.com/repos/thisisG/libsrtp/issues{/number}","pulls_url":"https://api.github.com/repos/thisisG/libsrtp/pulls{/number}","milestones_url":"https://api.github.com/repos/thisisG/libsrtp/milestones{/number}","notifications_url":"https://api.github.com/repos/thisisG/libsrtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thisisG/libsrtp/labels{/name}","releases_url":"https://api.github.com/repos/thisisG/libsrtp/releases{/id}","deployments_url":"https://api.github.com/repos/thisisG/libsrtp/deployments","created_at":"2017-01-23T08:08:50Z","updated_at":"2017-01-23T08:08:53Z","pushed_at":"2017-03-08T18:20:50Z","git_url":"git://github.com/thisisG/libsrtp.git","ssh_url":"git@github.com:thisisG/libsrtp.git","clone_url":"https://github.com/thisisG/libsrtp.git","svn_url":"https://github.com/thisisG/libsrtp","homepage":null,"size":4930,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cisco:master","ref":"master","sha":"d1ef7694a0b7dafbb48380239b9f66389ef89f9f","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars3.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":9087423,"name":"libsrtp","full_name":"cisco/libsrtp","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars3.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/libsrtp","description":"Library for SRTP (Secure Realtime Transport Protocol) ","fork":false,"url":"https://api.github.com/repos/cisco/libsrtp","forks_url":"https://api.github.com/repos/cisco/libsrtp/forks","keys_url":"https://api.github.com/repos/cisco/libsrtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/libsrtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/libsrtp/teams","hooks_url":"https://api.github.com/repos/cisco/libsrtp/hooks","issue_events_url":"https://api.github.com/repos/cisco/libsrtp/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/libsrtp/events","assignees_url":"https://api.github.com/repos/cisco/libsrtp/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/libsrtp/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/libsrtp/tags","blobs_url":"https://api.github.com/repos/cisco/libsrtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/libsrtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/libsrtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/libsrtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/libsrtp/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/libsrtp/languages","stargazers_url":"https://api.github.com/repos/cisco/libsrtp/stargazers","contributors_url":"https://api.github.com/repos/cisco/libsrtp/contributors","subscribers_url":"https://api.github.com/repos/cisco/libsrtp/subscribers","subscription_url":"https://api.github.com/repos/cisco/libsrtp/subscription","commits_url":"https://api.github.com/repos/cisco/libsrtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/libsrtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/libsrtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/libsrtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/libsrtp/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/libsrtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/libsrtp/merges","archive_url":"https://api.github.com/repos/cisco/libsrtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/libsrtp/downloads","issues_url":"https://api.github.com/repos/cisco/libsrtp/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/libsrtp/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/libsrtp/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/libsrtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/libsrtp/labels{/name}","releases_url":"https://api.github.com/repos/cisco/libsrtp/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/libsrtp/deployments","created_at":"2013-03-28T22:08:25Z","updated_at":"2017-03-09T03:54:30Z","pushed_at":"2017-03-10T12:52:59Z","git_url":"git://github.com/cisco/libsrtp.git","ssh_url":"git@github.com:cisco/libsrtp.git","clone_url":"https://github.com/cisco/libsrtp.git","svn_url":"https://github.com/cisco/libsrtp","homepage":null,"size":4917,"stargazers_count":282,"watchers_count":282,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":15,"forks":152,"open_issues":15,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/265"},"html":{"href":"https://github.com/cisco/libsrtp/pull/265"},"issue":{"href":"https://api.github.com/repos/cisco/libsrtp/issues/265"},"comments":{"href":"https://api.github.com/repos/cisco/libsrtp/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/libsrtp/statuses/66a3c718568e78412750dab333751933282a249f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thisisG","id":5999908,"avatar_url":"https://avatars2.githubusercontent.com/u/5999908?v=3","gravatar_id":"","url":"https://api.github.com/users/thisisG","html_url":"https://github.com/thisisG","followers_url":"https://api.github.com/users/thisisG/followers","following_url":"https://api.github.com/users/thisisG/following{/other_user}","gists_url":"https://api.github.com/users/thisisG/gists{/gist_id}","starred_url":"https://api.github.com/users/thisisG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisisG/subscriptions","organizations_url":"https://api.github.com/users/thisisG/orgs","repos_url":"https://api.github.com/users/thisisG/repos","events_url":"https://api.github.com/users/thisisG/events{/privacy}","received_events_url":"https://api.github.com/users/thisisG/received_events","type":"User","site_admin":false},"comments":4,"review_comments":5,"maintainer_can_modify":false,"commits":10,"additions":786,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"thisisG"}}