{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/110793478","pull_request_review_id":31991345,"id":110793478,"diff_hunk":"@@ -1162,20 +1162,42 @@ NESTED_END ResolveWorkerChainLookupAsmStub, _TEXT\n NESTED_ENTRY BackPatchWorkerAsmStub, _TEXT, NoHandler\n     PROLOG_BEG\n     PROLOG_PUSH eax // it may contain siteAddrForRegisterIndirect\n+    PROLOG_PUSH ebx\n     PROLOG_PUSH ecx\n     PROLOG_PUSH edx\n     PROLOG_END\n \n-    sub     esp, 4     //  for 16 bytes align\n-    push    eax        //  push any indirect call address as the second arg to BackPatchWorker\n-    push    [ebp+8]    //  and push return address as the first arg to BackPatchWorker\n+    // Call BackPatchWorkerStaticStub\n+    //\n+    // Here is expected stack layout at this point:\n+    //  | saved edx |\n+    //  | saved ecx |\n+    //  | saved ebx |\n+    //  | saved eax |\n+    //  +-----------+ <- ebp\n+    //  | saved ebp |\n+    //  | saved eip |\n+    //  +-----------+ <- CFA of BackPatchWorkerAsmStub\n+    //  | saved eip |\n+    //  +-----------+ <- CFA of ResolveStub (16-byte aligned)\n+    // (Please refer to ResolveStub in vm/i386/virtualcallstubcpu.hpp for details)\n+    //\n+    #define STACK_ALIGN_PADDING 12\n+    sub     esp, STACK_ALIGN_PADDING  //  16-bytes align padding","path":"src/vm/i386/asmhelpers.S","position":28,"original_position":28,"commit_id":"90f0160666d8f931ffe5d0273254802afff04a06","original_commit_id":"90f0160666d8f931ffe5d0273254802afff04a06","user":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars0.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"Shouldn't this be just 4? in the layout diagram above, there are five pushes and two calls, that makes total of 7 * 4 = 28 bytes. ","created_at":"2017-04-11T00:31:47Z","updated_at":"2017-04-11T00:31:47Z","html_url":"https://github.com/dotnet/coreclr/pull/10759#discussion_r110793478","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10759","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/110793478"},"html":{"href":"https://github.com/dotnet/coreclr/pull/10759#discussion_r110793478"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10759"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/10759","id":114514871,"html_url":"https://github.com/dotnet/coreclr/pull/10759","diff_url":"https://github.com/dotnet/coreclr/pull/10759.diff","patch_url":"https://github.com/dotnet/coreclr/pull/10759.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/10759","number":10759,"state":"open","locked":false,"title":"[WIP][x86/Linux] 16-byte aligned BackPatchWorkerAsmStub","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars3.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"body":"Unaligned stack frame are emitted while running JIT.Performance.CodeQuality.Linq (discovered while testing Checked CLR build). \r\n\r\nThis commit enforces stack alignment before call BackPatchWorkerStaticStub.","created_at":"2017-04-06T03:20:44Z","updated_at":"2017-04-11T00:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4855d1d19493e31f5c945982113261613881a2c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10759/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10759/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/10759/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/90f0160666d8f931ffe5d0273254802afff04a06","head":{"label":"parjong:fix/x86_aligned_BackPatchWorkerAsmStub","ref":"fix/x86_aligned_BackPatchWorkerAsmStub","sha":"90f0160666d8f931ffe5d0273254802afff04a06","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars3.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"repo":{"id":55585145,"name":"coreclr","full_name":"parjong/coreclr","owner":{"login":"parjong","id":14926045,"avatar_url":"https://avatars3.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parjong/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/parjong/coreclr","forks_url":"https://api.github.com/repos/parjong/coreclr/forks","keys_url":"https://api.github.com/repos/parjong/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parjong/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parjong/coreclr/teams","hooks_url":"https://api.github.com/repos/parjong/coreclr/hooks","issue_events_url":"https://api.github.com/repos/parjong/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/parjong/coreclr/events","assignees_url":"https://api.github.com/repos/parjong/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/parjong/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/parjong/coreclr/tags","blobs_url":"https://api.github.com/repos/parjong/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parjong/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parjong/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/parjong/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parjong/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/parjong/coreclr/languages","stargazers_url":"https://api.github.com/repos/parjong/coreclr/stargazers","contributors_url":"https://api.github.com/repos/parjong/coreclr/contributors","subscribers_url":"https://api.github.com/repos/parjong/coreclr/subscribers","subscription_url":"https://api.github.com/repos/parjong/coreclr/subscription","commits_url":"https://api.github.com/repos/parjong/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/parjong/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/parjong/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/parjong/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/parjong/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/parjong/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parjong/coreclr/merges","archive_url":"https://api.github.com/repos/parjong/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parjong/coreclr/downloads","issues_url":"https://api.github.com/repos/parjong/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/parjong/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/parjong/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/parjong/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parjong/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/parjong/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/parjong/coreclr/deployments","created_at":"2016-04-06T07:32:51Z","updated_at":"2016-10-23T22:20:56Z","pushed_at":"2017-04-11T00:24:23Z","git_url":"git://github.com/parjong/coreclr.git","ssh_url":"git@github.com:parjong/coreclr.git","clone_url":"https://github.com/parjong/coreclr.git","svn_url":"https://github.com/parjong/coreclr","homepage":"http://dotnet.github.io/","size":149979,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"87ae15c547eebf82185b5eb5b5315bd7b57f9f6d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-04-10T21:38:26Z","pushed_at":"2017-04-11T00:24:25Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":150797,"stargazers_count":7621,"watchers_count":7621,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1907,"mirror_url":null,"open_issues_count":1192,"forks":1907,"open_issues":1192,"watchers":7621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10759"},"html":{"href":"https://github.com/dotnet/coreclr/pull/10759"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/10759"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/10759/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10759/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10759/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/90f0160666d8f931ffe5d0273254802afff04a06"}}}}
{"actor":{"display_login":"janvorli"}}