{"action":"created","comment":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/146099091","pull_request_review_id":71001339,"id":146099091,"diff_hunk":"@@ -53,38 +54,55 @@\n             Class<? extends Tuple> tupleClass = (Class<? extends Tuple>) erasedType;\n             Array<Tuple2<Type, Integer>> tupleTypes = Array.of(tupleClass.getTypeParameters())\n                     .map(tp -> resolveType(tp, type))\n-                    .zipWithIndex();\n+                    .zipWithIndex((t, i) -> Tuple.of(t, i + 1));\n+\n+            Array<Tuple3<Type, Integer, Option<String>>> withConfiguredColumnName =\n+                    tupleTypes.map(t -> Tuple.of(t._1, t._2, getConfiguredColumnName(t._2, config)));\n+\n+            boolean anyColumnSet = withConfiguredColumnName.map(t -> t._3).exists(Option::isDefined);\n+            if (anyColumnSet) {\n+                Array<Optional<RowMapper<?>>> mappers = withConfiguredColumnName\n+                        .map(t -> t._3.isDefined() ?\n+                                getColumnMapperForDefinedColumn(t._1, t._3.get(), config) :\n+                                getRowMapper(t._1, t._2, config));\n+\n+                boolean mappableWithConfigured = mappers.forAll(Optional::isPresent);\n+                if (mappableWithConfigured) {\n+                    return buildMapper(tupleClass, mappers);\n+                }","path":"vavr/src/main/java/org/jdbi/v3/vavr/VavrTupleRowMapperFactory.java","position":72,"original_position":28,"commit_id":"3c39ffc432216e5e9f01bbb67cbf332be052a958","original_commit_id":"3c39ffc432216e5e9f01bbb67cbf332be052a958","user":{"login":"alwins0n","id":7060280,"avatar_url":"https://avatars2.githubusercontent.com/u/7060280?v=4","gravatar_id":"","url":"https://api.github.com/users/alwins0n","html_url":"https://github.com/alwins0n","followers_url":"https://api.github.com/users/alwins0n/followers","following_url":"https://api.github.com/users/alwins0n/following{/other_user}","gists_url":"https://api.github.com/users/alwins0n/gists{/gist_id}","starred_url":"https://api.github.com/users/alwins0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alwins0n/subscriptions","organizations_url":"https://api.github.com/users/alwins0n/orgs","repos_url":"https://api.github.com/users/alwins0n/repos","events_url":"https://api.github.com/users/alwins0n/events{/privacy}","received_events_url":"https://api.github.com/users/alwins0n/received_events","type":"User","site_admin":false},"body":"Since there is no way to find out whether the user missed a column configuration or forgot a RowMapper configuration I will opt for a more generic error message that should give enough feedback","created_at":"2017-10-21T07:28:05Z","updated_at":"2017-10-21T07:28:05Z","html_url":"https://github.com/jdbi/jdbi/pull/890#discussion_r146099091","pull_request_url":"https://api.github.com/repos/jdbi/jdbi/pulls/890","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/146099091"},"html":{"href":"https://github.com/jdbi/jdbi/pull/890#discussion_r146099091"},"pull_request":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/890"}},"in_reply_to_id":146028263},"pull_request":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/890","id":142747374,"html_url":"https://github.com/jdbi/jdbi/pull/890","diff_url":"https://github.com/jdbi/jdbi/pull/890.diff","patch_url":"https://github.com/jdbi/jdbi/pull/890.patch","issue_url":"https://api.github.com/repos/jdbi/jdbi/issues/890","number":890,"state":"open","locked":false,"title":"Jdbi vavr","user":{"login":"alwins0n","id":7060280,"avatar_url":"https://avatars2.githubusercontent.com/u/7060280?v=4","gravatar_id":"","url":"https://api.github.com/users/alwins0n","html_url":"https://github.com/alwins0n","followers_url":"https://api.github.com/users/alwins0n/followers","following_url":"https://api.github.com/users/alwins0n/following{/other_user}","gists_url":"https://api.github.com/users/alwins0n/gists{/gist_id}","starred_url":"https://api.github.com/users/alwins0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alwins0n/subscriptions","organizations_url":"https://api.github.com/users/alwins0n/orgs","repos_url":"https://api.github.com/users/alwins0n/repos","events_url":"https://api.github.com/users/alwins0n/events{/privacy}","received_events_url":"https://api.github.com/users/alwins0n/received_events","type":"User","site_admin":false},"body":"I think Vavr offers great additions for Jdbi, thats why I  created this little plugin. I hope I adhered to JDBI contributing standards - this is my first PR.","created_at":"2017-09-24T09:46:26Z","updated_at":"2017-10-21T07:28:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96614c62a06cb6e007bf1e8d0b48522370feba45","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/jdbi/jdbi/milestones/2","html_url":"https://github.com/jdbi/jdbi/milestone/2","labels_url":"https://api.github.com/repos/jdbi/jdbi/milestones/2/labels","id":382959,"number":2,"title":"JDBI 3 Release blocker","description":"Bucket for issues that should be in JDBI 3","creator":{"login":"stevenschlansker","id":129097,"avatar_url":"https://avatars0.githubusercontent.com/u/129097?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenschlansker","html_url":"https://github.com/stevenschlansker","followers_url":"https://api.github.com/users/stevenschlansker/followers","following_url":"https://api.github.com/users/stevenschlansker/following{/other_user}","gists_url":"https://api.github.com/users/stevenschlansker/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenschlansker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenschlansker/subscriptions","organizations_url":"https://api.github.com/users/stevenschlansker/orgs","repos_url":"https://api.github.com/users/stevenschlansker/repos","events_url":"https://api.github.com/users/stevenschlansker/events{/privacy}","received_events_url":"https://api.github.com/users/stevenschlansker/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":268,"state":"open","created_at":"2013-07-20T23:48:16Z","updated_at":"2017-10-17T21:45:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jdbi/jdbi/pulls/890/commits","review_comments_url":"https://api.github.com/repos/jdbi/jdbi/pulls/890/comments","review_comment_url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdbi/jdbi/issues/890/comments","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/3c39ffc432216e5e9f01bbb67cbf332be052a958","head":{"label":"alwins0n:jdbi-vavr","ref":"jdbi-vavr","sha":"3c39ffc432216e5e9f01bbb67cbf332be052a958","user":{"login":"alwins0n","id":7060280,"avatar_url":"https://avatars2.githubusercontent.com/u/7060280?v=4","gravatar_id":"","url":"https://api.github.com/users/alwins0n","html_url":"https://github.com/alwins0n","followers_url":"https://api.github.com/users/alwins0n/followers","following_url":"https://api.github.com/users/alwins0n/following{/other_user}","gists_url":"https://api.github.com/users/alwins0n/gists{/gist_id}","starred_url":"https://api.github.com/users/alwins0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alwins0n/subscriptions","organizations_url":"https://api.github.com/users/alwins0n/orgs","repos_url":"https://api.github.com/users/alwins0n/repos","events_url":"https://api.github.com/users/alwins0n/events{/privacy}","received_events_url":"https://api.github.com/users/alwins0n/received_events","type":"User","site_admin":false},"repo":{"id":102024844,"name":"jdbi","full_name":"alwins0n/jdbi","owner":{"login":"alwins0n","id":7060280,"avatar_url":"https://avatars2.githubusercontent.com/u/7060280?v=4","gravatar_id":"","url":"https://api.github.com/users/alwins0n","html_url":"https://github.com/alwins0n","followers_url":"https://api.github.com/users/alwins0n/followers","following_url":"https://api.github.com/users/alwins0n/following{/other_user}","gists_url":"https://api.github.com/users/alwins0n/gists{/gist_id}","starred_url":"https://api.github.com/users/alwins0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alwins0n/subscriptions","organizations_url":"https://api.github.com/users/alwins0n/orgs","repos_url":"https://api.github.com/users/alwins0n/repos","events_url":"https://api.github.com/users/alwins0n/events{/privacy}","received_events_url":"https://api.github.com/users/alwins0n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alwins0n/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":true,"url":"https://api.github.com/repos/alwins0n/jdbi","forks_url":"https://api.github.com/repos/alwins0n/jdbi/forks","keys_url":"https://api.github.com/repos/alwins0n/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alwins0n/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alwins0n/jdbi/teams","hooks_url":"https://api.github.com/repos/alwins0n/jdbi/hooks","issue_events_url":"https://api.github.com/repos/alwins0n/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/alwins0n/jdbi/events","assignees_url":"https://api.github.com/repos/alwins0n/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/alwins0n/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/alwins0n/jdbi/tags","blobs_url":"https://api.github.com/repos/alwins0n/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alwins0n/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alwins0n/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/alwins0n/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alwins0n/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/alwins0n/jdbi/languages","stargazers_url":"https://api.github.com/repos/alwins0n/jdbi/stargazers","contributors_url":"https://api.github.com/repos/alwins0n/jdbi/contributors","subscribers_url":"https://api.github.com/repos/alwins0n/jdbi/subscribers","subscription_url":"https://api.github.com/repos/alwins0n/jdbi/subscription","commits_url":"https://api.github.com/repos/alwins0n/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/alwins0n/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/alwins0n/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/alwins0n/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/alwins0n/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/alwins0n/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alwins0n/jdbi/merges","archive_url":"https://api.github.com/repos/alwins0n/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alwins0n/jdbi/downloads","issues_url":"https://api.github.com/repos/alwins0n/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/alwins0n/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/alwins0n/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/alwins0n/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alwins0n/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/alwins0n/jdbi/releases{/id}","deployments_url":"https://api.github.com/repos/alwins0n/jdbi/deployments","created_at":"2017-08-31T17:07:01Z","updated_at":"2017-08-31T17:07:04Z","pushed_at":"2017-10-19T20:10:12Z","git_url":"git://github.com/alwins0n/jdbi.git","ssh_url":"git@github.com:alwins0n/jdbi.git","clone_url":"https://github.com/alwins0n/jdbi.git","svn_url":"https://github.com/alwins0n/jdbi","homepage":"http://jdbi.org/","size":16098,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdbi:master","ref":"master","sha":"59b782c611d9eb93d6db84384d956f95facb7bbe","user":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars0.githubusercontent.com/u/9668860?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"repo":{"id":229738,"name":"jdbi","full_name":"jdbi/jdbi","owner":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars0.githubusercontent.com/u/9668860?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jdbi/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":false,"url":"https://api.github.com/repos/jdbi/jdbi","forks_url":"https://api.github.com/repos/jdbi/jdbi/forks","keys_url":"https://api.github.com/repos/jdbi/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdbi/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdbi/jdbi/teams","hooks_url":"https://api.github.com/repos/jdbi/jdbi/hooks","issue_events_url":"https://api.github.com/repos/jdbi/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/jdbi/jdbi/events","assignees_url":"https://api.github.com/repos/jdbi/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/jdbi/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/jdbi/jdbi/tags","blobs_url":"https://api.github.com/repos/jdbi/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdbi/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdbi/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdbi/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/jdbi/jdbi/languages","stargazers_url":"https://api.github.com/repos/jdbi/jdbi/stargazers","contributors_url":"https://api.github.com/repos/jdbi/jdbi/contributors","subscribers_url":"https://api.github.com/repos/jdbi/jdbi/subscribers","subscription_url":"https://api.github.com/repos/jdbi/jdbi/subscription","commits_url":"https://api.github.com/repos/jdbi/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdbi/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdbi/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdbi/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdbi/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/jdbi/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdbi/jdbi/merges","archive_url":"https://api.github.com/repos/jdbi/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdbi/jdbi/downloads","issues_url":"https://api.github.com/repos/jdbi/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/jdbi/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/jdbi/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/jdbi/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdbi/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/jdbi/jdbi/releases{/id}","deployments_url":"https://api.github.com/repos/jdbi/jdbi/deployments","created_at":"2009-06-17T16:36:36Z","updated_at":"2017-10-20T13:32:40Z","pushed_at":"2017-10-19T20:10:14Z","git_url":"git://github.com/jdbi/jdbi.git","ssh_url":"git@github.com:jdbi/jdbi.git","clone_url":"https://github.com/jdbi/jdbi.git","svn_url":"https://github.com/jdbi/jdbi","homepage":"http://jdbi.org/","size":16102,"stargazers_count":879,"watchers_count":879,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":57,"forks":194,"open_issues":57,"watchers":879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/890"},"html":{"href":"https://github.com/jdbi/jdbi/pull/890"},"issue":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/890"},"comments":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/890/comments"},"review_comments":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/890/comments"},"review_comment":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/890/commits"},"statuses":{"href":"https://api.github.com/repos/jdbi/jdbi/statuses/3c39ffc432216e5e9f01bbb67cbf332be052a958"}},"author_association":"NONE"}}
{"actor":{"display_login":"alwins0n"}}