{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/135782447","pull_request_review_id":59232225,"id":135782447,"diff_hunk":"@@ -132,6 +132,13 @@ function mergeBranches( batch, startPos, endPos ) {\n \t\t// To then become:\n \t\t// <a><b>xy</b>[]</a><c>{}</c>\n \t\tbatch.merge( startPos );\n+\n+\t\t// We need to check and strip disallowed attributes in direct children because after merge\n+\t\t// some attributes could end up in a parent where are disallowed.\n+\t\t//\n+\t\t// e.g. bold is disallowed for <H1>\n+\t\t// <h1>Fo{o</h1><p>b}a<b>r</b><p> -> <h1>Fo{}a<b>r</b><h1> -> <h1>Fo{}ar<h1>.\n+\t\tremoveDisallowedAttributes( batch, Array.from( startParent.getChildren() ), [ startParent ] );","path":"src/controller/deletecontent.js","position":10,"original_position":10,"commit_id":"b54c43bb1e5ffa1bfea8955cc5a0827e42322420","original_commit_id":"b54c43bb1e5ffa1bfea8955cc5a0827e42322420","user":{"login":"scofalik","id":1502228,"avatar_url":"https://avatars1.githubusercontent.com/u/1502228?v=4","gravatar_id":"","url":"https://api.github.com/users/scofalik","html_url":"https://github.com/scofalik","followers_url":"https://api.github.com/users/scofalik/followers","following_url":"https://api.github.com/users/scofalik/following{/other_user}","gists_url":"https://api.github.com/users/scofalik/gists{/gist_id}","starred_url":"https://api.github.com/users/scofalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scofalik/subscriptions","organizations_url":"https://api.github.com/users/scofalik/orgs","repos_url":"https://api.github.com/users/scofalik/repos","events_url":"https://api.github.com/users/scofalik/events{/privacy}","received_events_url":"https://api.github.com/users/scofalik/received_events","type":"User","site_admin":false},"body":"Those also apply to the other `removeDisallowedAttributes` function.","created_at":"2017-08-29T13:04:03Z","updated_at":"2017-08-29T13:04:03Z","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1104#discussion_r135782447","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/135782447"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1104#discussion_r135782447"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104"}},"in_reply_to_id":135775662},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104","id":137464239,"html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1104","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1104.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1104.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1104","number":1104,"state":"open","locked":false,"title":"(insert|delete)Content strips disallowed attributes from nodes","user":{"login":"oskarwrobel","id":1057056,"avatar_url":"https://avatars2.githubusercontent.com/u/1057056?v=4","gravatar_id":"","url":"https://api.github.com/users/oskarwrobel","html_url":"https://github.com/oskarwrobel","followers_url":"https://api.github.com/users/oskarwrobel/followers","following_url":"https://api.github.com/users/oskarwrobel/following{/other_user}","gists_url":"https://api.github.com/users/oskarwrobel/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarwrobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarwrobel/subscriptions","organizations_url":"https://api.github.com/users/oskarwrobel/orgs","repos_url":"https://api.github.com/users/oskarwrobel/repos","events_url":"https://api.github.com/users/oskarwrobel/events{/privacy}","received_events_url":"https://api.github.com/users/oskarwrobel/received_events","type":"User","site_admin":false},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nFix: `DataController#insertContent` and `DataController#deleteContent` strips disallowed attributes from Nodes. Closes #1088.\r\n\r\n---\r\n","created_at":"2017-08-24T14:12:11Z","updated_at":"2017-08-29T13:04:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4de0c42d6ea03786676dd5979d4b959680989c5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pjasiun","id":1166967,"avatar_url":"https://avatars2.githubusercontent.com/u/1166967?v=4","gravatar_id":"","url":"https://api.github.com/users/pjasiun","html_url":"https://github.com/pjasiun","followers_url":"https://api.github.com/users/pjasiun/followers","following_url":"https://api.github.com/users/pjasiun/following{/other_user}","gists_url":"https://api.github.com/users/pjasiun/gists{/gist_id}","starred_url":"https://api.github.com/users/pjasiun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjasiun/subscriptions","organizations_url":"https://api.github.com/users/pjasiun/orgs","repos_url":"https://api.github.com/users/pjasiun/repos","events_url":"https://api.github.com/users/pjasiun/events{/privacy}","received_events_url":"https://api.github.com/users/pjasiun/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1104/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/b54c43bb1e5ffa1bfea8955cc5a0827e42322420","head":{"label":"ckeditor:t/1088","ref":"t/1088","sha":"b54c43bb1e5ffa1bfea8955cc5a0827e42322420","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2017-08-11T22:40:01Z","pushed_at":"2017-08-29T12:22:59Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor5.github.io","size":6494,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":198,"forks":16,"open_issues":198,"watchers":38,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"6502bbb9ad6c049600180846a9a926ecdf87177d","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2017-08-11T22:40:01Z","pushed_at":"2017-08-29T12:22:59Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor5.github.io","size":6494,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":198,"forks":16,"open_issues":198,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1104"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1104"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1104/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1104/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/b54c43bb1e5ffa1bfea8955cc5a0827e42322420"}}}}
{"actor":{"display_login":"scofalik"}}