{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/130805159","pull_request_review_id":53719432,"id":130805159,"diff_hunk":"@@ -28,8 +30,12 @@\n public class RetryingHttpClientBuilder extends RetryingClientBuilder<\n         RetryingHttpClientBuilder, RetryingHttpClient, HttpRequest, HttpResponse> {\n \n+    private static final int DEFAULT_CONTENT_PREVIEW_LENGTH = 1024 * 1024; // 1 MiB","path":"core/src/main/java/com/linecorp/armeria/client/retry/RetryingHttpClientBuilder.java","position":13,"original_position":13,"commit_id":"c646d0a485ee9e0aae95e961ff34e708b4a4a0ad","original_commit_id":"c646d0a485ee9e0aae95e961ff34e708b4a4a0ad","user":{"login":"minwoox","id":25103250,"avatar_url":"https://avatars2.githubusercontent.com/u/25103250?v=4","gravatar_id":"","url":"https://api.github.com/users/minwoox","html_url":"https://github.com/minwoox","followers_url":"https://api.github.com/users/minwoox/followers","following_url":"https://api.github.com/users/minwoox/following{/other_user}","gists_url":"https://api.github.com/users/minwoox/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoox/subscriptions","organizations_url":"https://api.github.com/users/minwoox/orgs","repos_url":"https://api.github.com/users/minwoox/repos","events_url":"https://api.github.com/users/minwoox/events{/privacy}","received_events_url":"https://api.github.com/users/minwoox/received_events","type":"User","site_admin":false},"body":"I was just afraid of having too much variables in `Flags`, and I though that I don't have to move this into `Flags`. How about moving it later when I'm going to be sure that it need to be moved?","created_at":"2017-08-02T07:35:22Z","updated_at":"2017-08-02T07:35:22Z","html_url":"https://github.com/line/armeria/pull/701#discussion_r130805159","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/701","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/130805159"},"html":{"href":"https://github.com/line/armeria/pull/701#discussion_r130805159"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/701"}}},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/701","id":132429852,"html_url":"https://github.com/line/armeria/pull/701","diff_url":"https://github.com/line/armeria/pull/701.diff","patch_url":"https://github.com/line/armeria/pull/701.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/701","number":701,"state":"open","locked":false,"title":"Add a function that removes inside caches when the last subscriber st…","user":{"login":"minwoox","id":25103250,"avatar_url":"https://avatars2.githubusercontent.com/u/25103250?v=4","gravatar_id":"","url":"https://api.github.com/users/minwoox","html_url":"https://github.com/minwoox","followers_url":"https://api.github.com/users/minwoox/followers","following_url":"https://api.github.com/users/minwoox/following{/other_user}","gists_url":"https://api.github.com/users/minwoox/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoox/subscriptions","organizations_url":"https://api.github.com/users/minwoox/orgs","repos_url":"https://api.github.com/users/minwoox/repos","events_url":"https://api.github.com/users/minwoox/events{/privacy}","received_events_url":"https://api.github.com/users/minwoox/received_events","type":"User","site_admin":false},"body":"…arts to subscribe to StreamMessageDuplicator\r\n\r\nMotivation:\r\n\r\nStreamMessageDuplicator were keeping the signals before the `close()` is invoked due to it's own characteristic. It doesn't, however, have to keep all the signals when it knows that there's no more subscription. Therefore, it's needed to remove already published caches so that it prevents the internal cache growing largely.\r\n\r\nModifications:\r\n\r\n- Add `duplicateStream(bool)` to set the last stream\r\n- Replace internal list containing caches to a CircularQueue\r\n- RetryingClient blocks the stream only configured amount of bytes to decide to retry\r\n\r\nResult:\r\n\r\n- Internal caches doesn't grow largely after the last subscriber starts to subscribes\r\n- Close #622","created_at":"2017-07-26T04:44:53Z","updated_at":"2017-08-02T07:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6113fddd163e46e0f6e5ce6fa198a9db7237018e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/line/armeria/pulls/701/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/701/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/701/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/c646d0a485ee9e0aae95e961ff34e708b4a4a0ad","head":{"label":"minwoox:duplicator-laststream","ref":"duplicator-laststream","sha":"c646d0a485ee9e0aae95e961ff34e708b4a4a0ad","user":{"login":"minwoox","id":25103250,"avatar_url":"https://avatars2.githubusercontent.com/u/25103250?v=4","gravatar_id":"","url":"https://api.github.com/users/minwoox","html_url":"https://github.com/minwoox","followers_url":"https://api.github.com/users/minwoox/followers","following_url":"https://api.github.com/users/minwoox/following{/other_user}","gists_url":"https://api.github.com/users/minwoox/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoox/subscriptions","organizations_url":"https://api.github.com/users/minwoox/orgs","repos_url":"https://api.github.com/users/minwoox/repos","events_url":"https://api.github.com/users/minwoox/events{/privacy}","received_events_url":"https://api.github.com/users/minwoox/received_events","type":"User","site_admin":false},"repo":{"id":87771657,"name":"armeria","full_name":"minwoox/armeria","owner":{"login":"minwoox","id":25103250,"avatar_url":"https://avatars2.githubusercontent.com/u/25103250?v=4","gravatar_id":"","url":"https://api.github.com/users/minwoox","html_url":"https://github.com/minwoox","followers_url":"https://api.github.com/users/minwoox/followers","following_url":"https://api.github.com/users/minwoox/following{/other_user}","gists_url":"https://api.github.com/users/minwoox/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoox/subscriptions","organizations_url":"https://api.github.com/users/minwoox/orgs","repos_url":"https://api.github.com/users/minwoox/repos","events_url":"https://api.github.com/users/minwoox/events{/privacy}","received_events_url":"https://api.github.com/users/minwoox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minwoox/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/minwoox/armeria","forks_url":"https://api.github.com/repos/minwoox/armeria/forks","keys_url":"https://api.github.com/repos/minwoox/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minwoox/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minwoox/armeria/teams","hooks_url":"https://api.github.com/repos/minwoox/armeria/hooks","issue_events_url":"https://api.github.com/repos/minwoox/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/minwoox/armeria/events","assignees_url":"https://api.github.com/repos/minwoox/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/minwoox/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/minwoox/armeria/tags","blobs_url":"https://api.github.com/repos/minwoox/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minwoox/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minwoox/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/minwoox/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minwoox/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/minwoox/armeria/languages","stargazers_url":"https://api.github.com/repos/minwoox/armeria/stargazers","contributors_url":"https://api.github.com/repos/minwoox/armeria/contributors","subscribers_url":"https://api.github.com/repos/minwoox/armeria/subscribers","subscription_url":"https://api.github.com/repos/minwoox/armeria/subscription","commits_url":"https://api.github.com/repos/minwoox/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/minwoox/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/minwoox/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/minwoox/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/minwoox/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/minwoox/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minwoox/armeria/merges","archive_url":"https://api.github.com/repos/minwoox/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minwoox/armeria/downloads","issues_url":"https://api.github.com/repos/minwoox/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/minwoox/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/minwoox/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/minwoox/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minwoox/armeria/labels{/name}","releases_url":"https://api.github.com/repos/minwoox/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/minwoox/armeria/deployments","created_at":"2017-04-10T05:52:56Z","updated_at":"2017-04-10T05:53:00Z","pushed_at":"2017-08-02T03:00:04Z","git_url":"git://github.com/minwoox/armeria.git","ssh_url":"git@github.com:minwoox/armeria.git","clone_url":"https://github.com/minwoox/armeria.git","svn_url":"https://github.com/minwoox/armeria","homepage":"http://line.github.io/armeria/","size":23878,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"c0a3fe12c0f5b72f96da9632ac376b7f08794687","user":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty, HTTP/2, Thrift and gRPC","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2017-08-01T22:32:13Z","pushed_at":"2017-08-02T06:46:01Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"http://line.github.io/armeria/","size":24742,"stargazers_count":840,"watchers_count":840,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":217,"mirror_url":null,"open_issues_count":63,"forks":217,"open_issues":63,"watchers":840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/701"},"html":{"href":"https://github.com/line/armeria/pull/701"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/701"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/701/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/701/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/701/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/c646d0a485ee9e0aae95e961ff34e708b4a4a0ad"}}}}
{"actor":{"display_login":"minwoox"}}