{"action":"created","issue":{"url":"https://api.github.com/repos/vim/vim/issues/1819","repository_url":"https://api.github.com/repos/vim/vim","labels_url":"https://api.github.com/repos/vim/vim/issues/1819/labels{/name}","comments_url":"https://api.github.com/repos/vim/vim/issues/1819/comments","events_url":"https://api.github.com/repos/vim/vim/issues/1819/events","html_url":"https://github.com/vim/vim/pull/1819","id":240486634,"number":1819,"title":"test_sha256 and test_utf8_comparisons not executed","user":{"login":"dpelle","id":2261629,"avatar_url":"https://avatars0.githubusercontent.com/u/2261629?v=3","gravatar_id":"","url":"https://api.github.com/users/dpelle","html_url":"https://github.com/dpelle","followers_url":"https://api.github.com/users/dpelle/followers","following_url":"https://api.github.com/users/dpelle/following{/other_user}","gists_url":"https://api.github.com/users/dpelle/gists{/gist_id}","starred_url":"https://api.github.com/users/dpelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpelle/subscriptions","organizations_url":"https://api.github.com/users/dpelle/orgs","repos_url":"https://api.github.com/users/dpelle/repos","events_url":"https://api.github.com/users/dpelle/events{/privacy}","received_events_url":"https://api.github.com/users/dpelle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-04T19:27:58Z","updated_at":"2017-07-04T19:45:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vim/vim/pulls/1819","html_url":"https://github.com/vim/vim/pull/1819","diff_url":"https://github.com/vim/vim/pull/1819.diff","patch_url":"https://github.com/vim/vim/pull/1819.patch"},"body":"Recent patch 8.0.0684 added test_sha256.vim and test_utf8_comparisons.vim,\r\nbut they are not executed.  We can see in codecov that function f_sha256()\r\nfor example is currently not covered with tests:\r\n\r\nhttps://codecov.io/gh/vim/vim/src/master/src/evalfunc.c#L10448\r\n\r\nThis PR fixes it."},"comment":{"url":"https://api.github.com/repos/vim/vim/issues/comments/312940092","html_url":"https://github.com/vim/vim/pull/1819#issuecomment-312940092","issue_url":"https://api.github.com/repos/vim/vim/issues/1819","id":312940092,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars3.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-07-04T19:45:35Z","updated_at":"2017-07-04T19:45:35Z","body":"# [Codecov](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=h1) Report\n> Merging [#1819](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=desc) into [master](https://codecov.io/gh/vim/vim/commit/da5116da4586fc714434411d2cccb066caa3723e?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/vim/vim/pull/1819/graphs/tree.svg?src=pr&token=k28urTrWwL&height=150&width=650)](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1819      +/-   ##\n==========================================\n+ Coverage   75.14%   75.17%   +0.02%     \n==========================================\n  Files          76       76              \n  Lines      125213   125212       -1     \n==========================================\n+ Hits        94095    94124      +29     \n+ Misses      31118    31088      -30\n```\n\n\n| [Impacted Files](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/gui\\_beval.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2d1aV9iZXZhbC5j) | `43.96% <0%> (-0.93%)` | :arrow_down: |\n| [src/if\\_xcmdsrv.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2lmX3hjbWRzcnYuYw==) | `85.18% <0%> (-0.19%)` | :arrow_down: |\n| [src/channel.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2NoYW5uZWwuYw==) | `83.71% <0%> (-0.19%)` | :arrow_down: |\n| [src/os\\_unix.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL29zX3VuaXguYw==) | `58.62% <0%> (-0.15%)` | :arrow_down: |\n| [src/gui\\_gtk\\_x11.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2d1aV9ndGtfeDExLmM=) | `47.44% <0%> (-0.11%)` | :arrow_down: |\n| [src/ex\\_cmds2.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2V4X2NtZHMyLmM=) | `79.71% <0%> (-0.11%)` | :arrow_down: |\n| [src/if\\_py\\_both.h](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2lmX3B5X2JvdGguaA==) | `76.01% <0%> (-0.01%)` | :arrow_down: |\n| [src/eval.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2V2YWwuYw==) | `80.82% <0%> (+0.07%)` | :arrow_up: |\n| [src/evalfunc.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL2V2YWxmdW5jLmM=) | `82.01% <0%> (+0.1%)` | :arrow_up: |\n| [src/message.c](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `68.72% <0%> (+0.45%)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=footer). Last update [da5116d...7bbfb5f](https://codecov.io/gh/vim/vim/pull/1819?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}