{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/133877166","pull_request_review_id":57108535,"id":133877166,"diff_hunk":"@@ -108,7 +112,9 @@ def send_login_request(user, password)\n     end\n \n     # rubocop:disable Metrics/PerceivedComplexity\n-    def handle_itc_response(raw)\n+    # If the response is coming from a flaky api, set flaky_api_call to true so we retry a little.","path":"spaceship/lib/spaceship/tunes/tunes_client.rb","position":16,"original_position":16,"commit_id":"30f9210d83dc6c13cd48d98e31cd13285ed7f002","original_commit_id":"30f9210d83dc6c13cd48d98e31cd13285ed7f002","user":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars2.githubusercontent.com/u/869950?v=4","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"body":"Should we add that to more areas in the code base?","created_at":"2017-08-18T04:21:16Z","updated_at":"2017-08-18T04:21:30Z","html_url":"https://github.com/fastlane/fastlane/pull/10083#discussion_r133877166","pull_request_url":"https://api.github.com/repos/fastlane/fastlane/pulls/10083","_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/133877166"},"html":{"href":"https://github.com/fastlane/fastlane/pull/10083#discussion_r133877166"},"pull_request":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/10083"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/10083","id":136391429,"html_url":"https://github.com/fastlane/fastlane/pull/10083","diff_url":"https://github.com/fastlane/fastlane/pull/10083.diff","patch_url":"https://github.com/fastlane/fastlane/pull/10083.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/10083","number":10083,"state":"open","locked":false,"title":"Add retry logic for new exception: ITunesConnectPotentialServerError","user":{"login":"taquitos","id":1304821,"avatar_url":"https://avatars2.githubusercontent.com/u/1304821?v=4","gravatar_id":"","url":"https://api.github.com/users/taquitos","html_url":"https://github.com/taquitos","followers_url":"https://api.github.com/users/taquitos/followers","following_url":"https://api.github.com/users/taquitos/following{/other_user}","gists_url":"https://api.github.com/users/taquitos/gists{/gist_id}","starred_url":"https://api.github.com/users/taquitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taquitos/subscriptions","organizations_url":"https://api.github.com/users/taquitos/orgs","repos_url":"https://api.github.com/users/taquitos/repos","events_url":"https://api.github.com/users/taquitos/events{/privacy}","received_events_url":"https://api.github.com/users/taquitos/received_events","type":"User","site_admin":false},"body":"Sometimes you get a bad response from whatever API you're calling and it's not your fault. If you use `handle_itc_response` from `TunesClient` you can now pass `flaky_api_call: true` and it will auto-retry 3 times, with 10 second waits in-between. \r\n\r\nThis motivation came after reading #9859, I thought \"gee whiz, this sure looks like flaky API if all you have to do is retry your upload script\" So, let's do it 😜\r\n\r\n### Checklist\r\n- [x] I've run `bundle exec rspec` from the root directory to see all new and existing tests pass\r\n- [x] I've followed the _fastlane_ code style and run `bundle exec rubocop -a` to ensure the code style is valid\r\n(https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n","created_at":"2017-08-18T02:39:37Z","updated_at":"2017-08-18T04:21:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e73b9b4efdeb483d8c1ced7f466dfaa0497ebd4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/10083/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/10083/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/10083/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/30f9210d83dc6c13cd48d98e31cd13285ed7f002","head":{"label":"fastlane:flaky_api_retry","ref":"flaky_api_retry","sha":"30f9210d83dc6c13cd48d98e31cd13285ed7f002","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2017-08-18T04:16:56Z","pushed_at":"2017-08-18T03:41:37Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":57670,"stargazers_count":17570,"watchers_count":17570,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2713,"mirror_url":null,"open_issues_count":335,"forks":2713,"open_issues":335,"watchers":17570,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"65dac95e54da508ab4edc08b37ecfc97a0b0fc79","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2017-08-18T04:16:56Z","pushed_at":"2017-08-18T03:41:37Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":57670,"stargazers_count":17570,"watchers_count":17570,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2713,"mirror_url":null,"open_issues_count":335,"forks":2713,"open_issues":335,"watchers":17570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/10083"},"html":{"href":"https://github.com/fastlane/fastlane/pull/10083"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/10083"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/10083/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/10083/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/10083/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/30f9210d83dc6c13cd48d98e31cd13285ed7f002"}}}}
{"actor":{"display_login":"KrauseFx"}}