{"action":"closed","number":865,"pull_request":{"url":"https://api.github.com/repos/leapmotion/UnityModules/pulls/865","id":141196337,"html_url":"https://github.com/leapmotion/UnityModules/pull/865","diff_url":"https://github.com/leapmotion/UnityModules/pull/865.diff","patch_url":"https://github.com/leapmotion/UnityModules/pull/865.patch","issue_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/865","number":865,"state":"closed","locked":false,"title":"Add physics extrapolation","user":{"login":"Amarcolina","id":5723312,"avatar_url":"https://avatars1.githubusercontent.com/u/5723312?v=4","gravatar_id":"","url":"https://api.github.com/users/Amarcolina","html_url":"https://github.com/Amarcolina","followers_url":"https://api.github.com/users/Amarcolina/followers","following_url":"https://api.github.com/users/Amarcolina/following{/other_user}","gists_url":"https://api.github.com/users/Amarcolina/gists{/gist_id}","starred_url":"https://api.github.com/users/Amarcolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amarcolina/subscriptions","organizations_url":"https://api.github.com/users/Amarcolina/orgs","repos_url":"https://api.github.com/users/Amarcolina/repos","events_url":"https://api.github.com/users/Amarcolina/events{/privacy}","received_events_url":"https://api.github.com/users/Amarcolina/received_events","type":"User","site_admin":false},"body":"This PR adds in the ability to extrapolate the physics frames that come out the service provider.  This compensates for the latency introduced by interpolated rigidbodies, which should always been used when your physics framerate is lower than your render framerate.  There are quite a bit of possible configurations, not all of which are desired, and so some extra effort is needed to make sure it is obvious how to configure things.  There is already a ticket open for documentation, but it would be good to brainstorm in-asset solutions as well.\r\n\r\nOn the service provider there is not a dropdown to select the type of extrapolation to use.  Auto simply extrapolates forward by a time equal to the physics delta time, which should correct accommodate for all interpolation.  None simply doesn't extrapolate at all.  Manual allows the user to specify the amount of time (in seconds) to extrapolate forwards in time.\r\n\r\nTests should be run in similar settings as #849, but in addition to smooth motion, there should also be little to zero visible latency!\r\n - [x] Example scenes still look fine and work\r\n - [x] Example scenes show no obvious signs of latency\r\n\r\nNEW UPDATE:  Since unity has an interpolation bug we are falling back and NOT supporting framerates that are different from render rate.  Interpolation has been turned off on all scenes as a consequence.","created_at":"2017-09-14T23:04:28Z","updated_at":"2017-10-10T17:01:08Z","closed_at":"2017-10-10T17:01:05Z","merged_at":"2017-10-10T17:01:05Z","merge_commit_sha":"b20f06e621bfb508ce41b8ece85ad03a6bd585ad","assignee":{"login":"Amarcolina","id":5723312,"avatar_url":"https://avatars1.githubusercontent.com/u/5723312?v=4","gravatar_id":"","url":"https://api.github.com/users/Amarcolina","html_url":"https://github.com/Amarcolina","followers_url":"https://api.github.com/users/Amarcolina/followers","following_url":"https://api.github.com/users/Amarcolina/following{/other_user}","gists_url":"https://api.github.com/users/Amarcolina/gists{/gist_id}","starred_url":"https://api.github.com/users/Amarcolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amarcolina/subscriptions","organizations_url":"https://api.github.com/users/Amarcolina/orgs","repos_url":"https://api.github.com/users/Amarcolina/repos","events_url":"https://api.github.com/users/Amarcolina/events{/privacy}","received_events_url":"https://api.github.com/users/Amarcolina/received_events","type":"User","site_admin":false},"assignees":[{"login":"Amarcolina","id":5723312,"avatar_url":"https://avatars1.githubusercontent.com/u/5723312?v=4","gravatar_id":"","url":"https://api.github.com/users/Amarcolina","html_url":"https://github.com/Amarcolina","followers_url":"https://api.github.com/users/Amarcolina/followers","following_url":"https://api.github.com/users/Amarcolina/following{/other_user}","gists_url":"https://api.github.com/users/Amarcolina/gists{/gist_id}","starred_url":"https://api.github.com/users/Amarcolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amarcolina/subscriptions","organizations_url":"https://api.github.com/users/Amarcolina/orgs","repos_url":"https://api.github.com/users/Amarcolina/repos","events_url":"https://api.github.com/users/Amarcolina/events{/privacy}","received_events_url":"https://api.github.com/users/Amarcolina/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"testmasterbright","id":6034882,"avatar_url":"https://avatars1.githubusercontent.com/u/6034882?v=4","gravatar_id":"","url":"https://api.github.com/users/testmasterbright","html_url":"https://github.com/testmasterbright","followers_url":"https://api.github.com/users/testmasterbright/followers","following_url":"https://api.github.com/users/testmasterbright/following{/other_user}","gists_url":"https://api.github.com/users/testmasterbright/gists{/gist_id}","starred_url":"https://api.github.com/users/testmasterbright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testmasterbright/subscriptions","organizations_url":"https://api.github.com/users/testmasterbright/orgs","repos_url":"https://api.github.com/users/testmasterbright/repos","events_url":"https://api.github.com/users/testmasterbright/events{/privacy}","received_events_url":"https://api.github.com/users/testmasterbright/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/leapmotion/UnityModules/pulls/865/commits","review_comments_url":"https://api.github.com/repos/leapmotion/UnityModules/pulls/865/comments","review_comment_url":"https://api.github.com/repos/leapmotion/UnityModules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/865/comments","statuses_url":"https://api.github.com/repos/leapmotion/UnityModules/statuses/a8df7077e236ebaeb64474fd6ead863becab76fb","head":{"label":"leapmotion:add-physics-extrapolation","ref":"add-physics-extrapolation","sha":"a8df7077e236ebaeb64474fd6ead863becab76fb","user":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars1.githubusercontent.com/u/2242710?v=4","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"repo":{"id":52047290,"name":"UnityModules","full_name":"leapmotion/UnityModules","owner":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars1.githubusercontent.com/u/2242710?v=4","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapmotion/UnityModules","description":"Repository containing all Leap Motion asset packages","fork":false,"url":"https://api.github.com/repos/leapmotion/UnityModules","forks_url":"https://api.github.com/repos/leapmotion/UnityModules/forks","keys_url":"https://api.github.com/repos/leapmotion/UnityModules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapmotion/UnityModules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapmotion/UnityModules/teams","hooks_url":"https://api.github.com/repos/leapmotion/UnityModules/hooks","issue_events_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/events{/number}","events_url":"https://api.github.com/repos/leapmotion/UnityModules/events","assignees_url":"https://api.github.com/repos/leapmotion/UnityModules/assignees{/user}","branches_url":"https://api.github.com/repos/leapmotion/UnityModules/branches{/branch}","tags_url":"https://api.github.com/repos/leapmotion/UnityModules/tags","blobs_url":"https://api.github.com/repos/leapmotion/UnityModules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapmotion/UnityModules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapmotion/UnityModules/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapmotion/UnityModules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapmotion/UnityModules/statuses/{sha}","languages_url":"https://api.github.com/repos/leapmotion/UnityModules/languages","stargazers_url":"https://api.github.com/repos/leapmotion/UnityModules/stargazers","contributors_url":"https://api.github.com/repos/leapmotion/UnityModules/contributors","subscribers_url":"https://api.github.com/repos/leapmotion/UnityModules/subscribers","subscription_url":"https://api.github.com/repos/leapmotion/UnityModules/subscription","commits_url":"https://api.github.com/repos/leapmotion/UnityModules/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapmotion/UnityModules/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapmotion/UnityModules/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapmotion/UnityModules/contents/{+path}","compare_url":"https://api.github.com/repos/leapmotion/UnityModules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapmotion/UnityModules/merges","archive_url":"https://api.github.com/repos/leapmotion/UnityModules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapmotion/UnityModules/downloads","issues_url":"https://api.github.com/repos/leapmotion/UnityModules/issues{/number}","pulls_url":"https://api.github.com/repos/leapmotion/UnityModules/pulls{/number}","milestones_url":"https://api.github.com/repos/leapmotion/UnityModules/milestones{/number}","notifications_url":"https://api.github.com/repos/leapmotion/UnityModules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapmotion/UnityModules/labels{/name}","releases_url":"https://api.github.com/repos/leapmotion/UnityModules/releases{/id}","deployments_url":"https://api.github.com/repos/leapmotion/UnityModules/deployments","created_at":"2016-02-18T23:42:29Z","updated_at":"2017-10-08T00:41:02Z","pushed_at":"2017-10-10T17:01:08Z","git_url":"git://github.com/leapmotion/UnityModules.git","ssh_url":"git@github.com:leapmotion/UnityModules.git","clone_url":"https://github.com/leapmotion/UnityModules.git","svn_url":"https://github.com/leapmotion/UnityModules","homepage":null,"size":275094,"stargazers_count":93,"watchers_count":93,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":63,"forks":44,"open_issues":63,"watchers":93,"default_branch":"master"}},"base":{"label":"leapmotion:develop","ref":"develop","sha":"d27c3bb847106bde5fe1b33d2ad0066f193d773e","user":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars1.githubusercontent.com/u/2242710?v=4","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"repo":{"id":52047290,"name":"UnityModules","full_name":"leapmotion/UnityModules","owner":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars1.githubusercontent.com/u/2242710?v=4","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapmotion/UnityModules","description":"Repository containing all Leap Motion asset packages","fork":false,"url":"https://api.github.com/repos/leapmotion/UnityModules","forks_url":"https://api.github.com/repos/leapmotion/UnityModules/forks","keys_url":"https://api.github.com/repos/leapmotion/UnityModules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapmotion/UnityModules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapmotion/UnityModules/teams","hooks_url":"https://api.github.com/repos/leapmotion/UnityModules/hooks","issue_events_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/events{/number}","events_url":"https://api.github.com/repos/leapmotion/UnityModules/events","assignees_url":"https://api.github.com/repos/leapmotion/UnityModules/assignees{/user}","branches_url":"https://api.github.com/repos/leapmotion/UnityModules/branches{/branch}","tags_url":"https://api.github.com/repos/leapmotion/UnityModules/tags","blobs_url":"https://api.github.com/repos/leapmotion/UnityModules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapmotion/UnityModules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapmotion/UnityModules/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapmotion/UnityModules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapmotion/UnityModules/statuses/{sha}","languages_url":"https://api.github.com/repos/leapmotion/UnityModules/languages","stargazers_url":"https://api.github.com/repos/leapmotion/UnityModules/stargazers","contributors_url":"https://api.github.com/repos/leapmotion/UnityModules/contributors","subscribers_url":"https://api.github.com/repos/leapmotion/UnityModules/subscribers","subscription_url":"https://api.github.com/repos/leapmotion/UnityModules/subscription","commits_url":"https://api.github.com/repos/leapmotion/UnityModules/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapmotion/UnityModules/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapmotion/UnityModules/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapmotion/UnityModules/contents/{+path}","compare_url":"https://api.github.com/repos/leapmotion/UnityModules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapmotion/UnityModules/merges","archive_url":"https://api.github.com/repos/leapmotion/UnityModules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapmotion/UnityModules/downloads","issues_url":"https://api.github.com/repos/leapmotion/UnityModules/issues{/number}","pulls_url":"https://api.github.com/repos/leapmotion/UnityModules/pulls{/number}","milestones_url":"https://api.github.com/repos/leapmotion/UnityModules/milestones{/number}","notifications_url":"https://api.github.com/repos/leapmotion/UnityModules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapmotion/UnityModules/labels{/name}","releases_url":"https://api.github.com/repos/leapmotion/UnityModules/releases{/id}","deployments_url":"https://api.github.com/repos/leapmotion/UnityModules/deployments","created_at":"2016-02-18T23:42:29Z","updated_at":"2017-10-08T00:41:02Z","pushed_at":"2017-10-10T17:01:08Z","git_url":"git://github.com/leapmotion/UnityModules.git","ssh_url":"git@github.com:leapmotion/UnityModules.git","clone_url":"https://github.com/leapmotion/UnityModules.git","svn_url":"https://github.com/leapmotion/UnityModules","homepage":null,"size":275094,"stargazers_count":93,"watchers_count":93,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":63,"forks":44,"open_issues":63,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leapmotion/UnityModules/pulls/865"},"html":{"href":"https://github.com/leapmotion/UnityModules/pull/865"},"issue":{"href":"https://api.github.com/repos/leapmotion/UnityModules/issues/865"},"comments":{"href":"https://api.github.com/repos/leapmotion/UnityModules/issues/865/comments"},"review_comments":{"href":"https://api.github.com/repos/leapmotion/UnityModules/pulls/865/comments"},"review_comment":{"href":"https://api.github.com/repos/leapmotion/UnityModules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leapmotion/UnityModules/pulls/865/commits"},"statuses":{"href":"https://api.github.com/repos/leapmotion/UnityModules/statuses/a8df7077e236ebaeb64474fd6ead863becab76fb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Amarcolina","id":5723312,"avatar_url":"https://avatars1.githubusercontent.com/u/5723312?v=4","gravatar_id":"","url":"https://api.github.com/users/Amarcolina","html_url":"https://github.com/Amarcolina","followers_url":"https://api.github.com/users/Amarcolina/followers","following_url":"https://api.github.com/users/Amarcolina/following{/other_user}","gists_url":"https://api.github.com/users/Amarcolina/gists{/gist_id}","starred_url":"https://api.github.com/users/Amarcolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amarcolina/subscriptions","organizations_url":"https://api.github.com/users/Amarcolina/orgs","repos_url":"https://api.github.com/users/Amarcolina/repos","events_url":"https://api.github.com/users/Amarcolina/events{/privacy}","received_events_url":"https://api.github.com/users/Amarcolina/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":12,"additions":675,"deletions":179,"changed_files":9}}
{"actor":{"display_login":"Amarcolina"}}