{"action":"created","comment":{"url":"https://api.github.com/repos/erikos/flatpak/pulls/comments/108737781","pull_request_review_id":29786777,"id":108737781,"diff_hunk":"@@ -234,6 +236,17 @@ get_download_location (BuilderSourceArchive *self,\n       return FALSE;\n     }\n \n+  sources_dirs = builder_context_get_sources_dirs (context);\n+  for (i = 0; i < sources_dirs->len; i++)\n+    {\n+      GFile* sources_root = g_ptr_array_index (sources_dirs, i);\n+      g_autoptr(GFile) download_dir = g_file_get_child (sources_root, \"downloads\");\n+      g_autoptr(GFile) sha256_dir = g_file_get_child (download_dir, self->sha256);\n+      g_autoptr(GFile) file = g_file_get_child (sha256_dir, base_name);","path":"builder/builder-source-archive.c","position":19,"original_position":19,"commit_id":"175ec993fd9985d813d265570a50594836e74679","original_commit_id":"175ec993fd9985d813d265570a50594836e74679","user":{"login":"cosimoc","id":13906,"avatar_url":"https://avatars2.githubusercontent.com/u/13906?v=3","gravatar_id":"","url":"https://api.github.com/users/cosimoc","html_url":"https://github.com/cosimoc","followers_url":"https://api.github.com/users/cosimoc/followers","following_url":"https://api.github.com/users/cosimoc/following{/other_user}","gists_url":"https://api.github.com/users/cosimoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cosimoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosimoc/subscriptions","organizations_url":"https://api.github.com/users/cosimoc/orgs","repos_url":"https://api.github.com/users/cosimoc/repos","events_url":"https://api.github.com/users/cosimoc/events{/privacy}","received_events_url":"https://api.github.com/users/cosimoc/received_events","type":"User","site_admin":false},"body":"You should re-use the existing variables with the same name, instead of shadowing their definition.","created_at":"2017-03-29T17:30:30Z","updated_at":"2017-03-29T17:32:22Z","html_url":"https://github.com/erikos/flatpak/pull/1#discussion_r108737781","pull_request_url":"https://api.github.com/repos/erikos/flatpak/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/erikos/flatpak/pulls/comments/108737781"},"html":{"href":"https://github.com/erikos/flatpak/pull/1#discussion_r108737781"},"pull_request":{"href":"https://api.github.com/repos/erikos/flatpak/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/erikos/flatpak/pulls/1","id":113167715,"html_url":"https://github.com/erikos/flatpak/pull/1","diff_url":"https://github.com/erikos/flatpak/pull/1.diff","patch_url":"https://github.com/erikos/flatpak/pull/1.patch","issue_url":"https://api.github.com/repos/erikos/flatpak/issues/1","number":1,"state":"open","locked":false,"title":"Wip prebundle sources","user":{"login":"erikos","id":3714785,"avatar_url":"https://avatars2.githubusercontent.com/u/3714785?v=3","gravatar_id":"","url":"https://api.github.com/users/erikos","html_url":"https://github.com/erikos","followers_url":"https://api.github.com/users/erikos/followers","following_url":"https://api.github.com/users/erikos/following{/other_user}","gists_url":"https://api.github.com/users/erikos/gists{/gist_id}","starred_url":"https://api.github.com/users/erikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikos/subscriptions","organizations_url":"https://api.github.com/users/erikos/orgs","repos_url":"https://api.github.com/users/erikos/repos","events_url":"https://api.github.com/users/erikos/events{/privacy}","received_events_url":"https://api.github.com/users/erikos/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-29T10:40:31Z","updated_at":"2017-03-29T17:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea191f5feeb3a08d36a4402411ccb30d4ca59395","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/erikos/flatpak/pulls/1/commits","review_comments_url":"https://api.github.com/repos/erikos/flatpak/pulls/1/comments","review_comment_url":"https://api.github.com/repos/erikos/flatpak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erikos/flatpak/issues/1/comments","statuses_url":"https://api.github.com/repos/erikos/flatpak/statuses/175ec993fd9985d813d265570a50594836e74679","head":{"label":"erikos:wip-prebundle-sources","ref":"wip-prebundle-sources","sha":"175ec993fd9985d813d265570a50594836e74679","user":{"login":"erikos","id":3714785,"avatar_url":"https://avatars2.githubusercontent.com/u/3714785?v=3","gravatar_id":"","url":"https://api.github.com/users/erikos","html_url":"https://github.com/erikos","followers_url":"https://api.github.com/users/erikos/followers","following_url":"https://api.github.com/users/erikos/following{/other_user}","gists_url":"https://api.github.com/users/erikos/gists{/gist_id}","starred_url":"https://api.github.com/users/erikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikos/subscriptions","organizations_url":"https://api.github.com/users/erikos/orgs","repos_url":"https://api.github.com/users/erikos/repos","events_url":"https://api.github.com/users/erikos/events{/privacy}","received_events_url":"https://api.github.com/users/erikos/received_events","type":"User","site_admin":false},"repo":{"id":85186233,"name":"flatpak","full_name":"erikos/flatpak","owner":{"login":"erikos","id":3714785,"avatar_url":"https://avatars2.githubusercontent.com/u/3714785?v=3","gravatar_id":"","url":"https://api.github.com/users/erikos","html_url":"https://github.com/erikos","followers_url":"https://api.github.com/users/erikos/followers","following_url":"https://api.github.com/users/erikos/following{/other_user}","gists_url":"https://api.github.com/users/erikos/gists{/gist_id}","starred_url":"https://api.github.com/users/erikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikos/subscriptions","organizations_url":"https://api.github.com/users/erikos/orgs","repos_url":"https://api.github.com/users/erikos/repos","events_url":"https://api.github.com/users/erikos/events{/privacy}","received_events_url":"https://api.github.com/users/erikos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikos/flatpak","description":"Linux application sandboxing and distribution framework (formerly xdg-app)","fork":true,"url":"https://api.github.com/repos/erikos/flatpak","forks_url":"https://api.github.com/repos/erikos/flatpak/forks","keys_url":"https://api.github.com/repos/erikos/flatpak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikos/flatpak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikos/flatpak/teams","hooks_url":"https://api.github.com/repos/erikos/flatpak/hooks","issue_events_url":"https://api.github.com/repos/erikos/flatpak/issues/events{/number}","events_url":"https://api.github.com/repos/erikos/flatpak/events","assignees_url":"https://api.github.com/repos/erikos/flatpak/assignees{/user}","branches_url":"https://api.github.com/repos/erikos/flatpak/branches{/branch}","tags_url":"https://api.github.com/repos/erikos/flatpak/tags","blobs_url":"https://api.github.com/repos/erikos/flatpak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikos/flatpak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikos/flatpak/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikos/flatpak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikos/flatpak/statuses/{sha}","languages_url":"https://api.github.com/repos/erikos/flatpak/languages","stargazers_url":"https://api.github.com/repos/erikos/flatpak/stargazers","contributors_url":"https://api.github.com/repos/erikos/flatpak/contributors","subscribers_url":"https://api.github.com/repos/erikos/flatpak/subscribers","subscription_url":"https://api.github.com/repos/erikos/flatpak/subscription","commits_url":"https://api.github.com/repos/erikos/flatpak/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikos/flatpak/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikos/flatpak/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikos/flatpak/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikos/flatpak/contents/{+path}","compare_url":"https://api.github.com/repos/erikos/flatpak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikos/flatpak/merges","archive_url":"https://api.github.com/repos/erikos/flatpak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikos/flatpak/downloads","issues_url":"https://api.github.com/repos/erikos/flatpak/issues{/number}","pulls_url":"https://api.github.com/repos/erikos/flatpak/pulls{/number}","milestones_url":"https://api.github.com/repos/erikos/flatpak/milestones{/number}","notifications_url":"https://api.github.com/repos/erikos/flatpak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikos/flatpak/labels{/name}","releases_url":"https://api.github.com/repos/erikos/flatpak/releases{/id}","deployments_url":"https://api.github.com/repos/erikos/flatpak/deployments","created_at":"2017-03-16T11:02:08Z","updated_at":"2017-03-16T11:02:11Z","pushed_at":"2017-03-29T10:40:31Z","git_url":"git://github.com/erikos/flatpak.git","ssh_url":"git@github.com:erikos/flatpak.git","clone_url":"https://github.com/erikos/flatpak.git","svn_url":"https://github.com/erikos/flatpak","homepage":"http://flatpak.org","size":5686,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"erikos:master","ref":"master","sha":"696775687721748ba779dfb58f29ab47ed1fd6ae","user":{"login":"erikos","id":3714785,"avatar_url":"https://avatars2.githubusercontent.com/u/3714785?v=3","gravatar_id":"","url":"https://api.github.com/users/erikos","html_url":"https://github.com/erikos","followers_url":"https://api.github.com/users/erikos/followers","following_url":"https://api.github.com/users/erikos/following{/other_user}","gists_url":"https://api.github.com/users/erikos/gists{/gist_id}","starred_url":"https://api.github.com/users/erikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikos/subscriptions","organizations_url":"https://api.github.com/users/erikos/orgs","repos_url":"https://api.github.com/users/erikos/repos","events_url":"https://api.github.com/users/erikos/events{/privacy}","received_events_url":"https://api.github.com/users/erikos/received_events","type":"User","site_admin":false},"repo":{"id":85186233,"name":"flatpak","full_name":"erikos/flatpak","owner":{"login":"erikos","id":3714785,"avatar_url":"https://avatars2.githubusercontent.com/u/3714785?v=3","gravatar_id":"","url":"https://api.github.com/users/erikos","html_url":"https://github.com/erikos","followers_url":"https://api.github.com/users/erikos/followers","following_url":"https://api.github.com/users/erikos/following{/other_user}","gists_url":"https://api.github.com/users/erikos/gists{/gist_id}","starred_url":"https://api.github.com/users/erikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikos/subscriptions","organizations_url":"https://api.github.com/users/erikos/orgs","repos_url":"https://api.github.com/users/erikos/repos","events_url":"https://api.github.com/users/erikos/events{/privacy}","received_events_url":"https://api.github.com/users/erikos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikos/flatpak","description":"Linux application sandboxing and distribution framework (formerly xdg-app)","fork":true,"url":"https://api.github.com/repos/erikos/flatpak","forks_url":"https://api.github.com/repos/erikos/flatpak/forks","keys_url":"https://api.github.com/repos/erikos/flatpak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikos/flatpak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikos/flatpak/teams","hooks_url":"https://api.github.com/repos/erikos/flatpak/hooks","issue_events_url":"https://api.github.com/repos/erikos/flatpak/issues/events{/number}","events_url":"https://api.github.com/repos/erikos/flatpak/events","assignees_url":"https://api.github.com/repos/erikos/flatpak/assignees{/user}","branches_url":"https://api.github.com/repos/erikos/flatpak/branches{/branch}","tags_url":"https://api.github.com/repos/erikos/flatpak/tags","blobs_url":"https://api.github.com/repos/erikos/flatpak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikos/flatpak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikos/flatpak/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikos/flatpak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikos/flatpak/statuses/{sha}","languages_url":"https://api.github.com/repos/erikos/flatpak/languages","stargazers_url":"https://api.github.com/repos/erikos/flatpak/stargazers","contributors_url":"https://api.github.com/repos/erikos/flatpak/contributors","subscribers_url":"https://api.github.com/repos/erikos/flatpak/subscribers","subscription_url":"https://api.github.com/repos/erikos/flatpak/subscription","commits_url":"https://api.github.com/repos/erikos/flatpak/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikos/flatpak/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikos/flatpak/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikos/flatpak/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikos/flatpak/contents/{+path}","compare_url":"https://api.github.com/repos/erikos/flatpak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikos/flatpak/merges","archive_url":"https://api.github.com/repos/erikos/flatpak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikos/flatpak/downloads","issues_url":"https://api.github.com/repos/erikos/flatpak/issues{/number}","pulls_url":"https://api.github.com/repos/erikos/flatpak/pulls{/number}","milestones_url":"https://api.github.com/repos/erikos/flatpak/milestones{/number}","notifications_url":"https://api.github.com/repos/erikos/flatpak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikos/flatpak/labels{/name}","releases_url":"https://api.github.com/repos/erikos/flatpak/releases{/id}","deployments_url":"https://api.github.com/repos/erikos/flatpak/deployments","created_at":"2017-03-16T11:02:08Z","updated_at":"2017-03-16T11:02:11Z","pushed_at":"2017-03-29T10:40:31Z","git_url":"git://github.com/erikos/flatpak.git","ssh_url":"git@github.com:erikos/flatpak.git","clone_url":"https://github.com/erikos/flatpak.git","svn_url":"https://github.com/erikos/flatpak","homepage":"http://flatpak.org","size":5686,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erikos/flatpak/pulls/1"},"html":{"href":"https://github.com/erikos/flatpak/pull/1"},"issue":{"href":"https://api.github.com/repos/erikos/flatpak/issues/1"},"comments":{"href":"https://api.github.com/repos/erikos/flatpak/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/erikos/flatpak/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/erikos/flatpak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erikos/flatpak/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/erikos/flatpak/statuses/175ec993fd9985d813d265570a50594836e74679"}}}}
{"actor":{"display_login":"cosimoc"}}