{"action":"created","comment":{"url":"https://api.github.com/repos/skillz/yojimbo/pulls/comments/142209322","pull_request_review_id":66535327,"id":142209322,"diff_hunk":"@@ -113,7 +113,7 @@ int SoakMain()\n \n \t\t\t\t\tif ( rand() % 25 )\n \t\t\t\t\t{\n-\t\t\t\t\t\tTestMessage * message = (TestMessage*) client.CreateMessage( TEST_MESSAGE );\n+                        SkillzMessage * message = (SkillzMessage*) client.CreateMessage( SKILLZ_MESSAGE );","path":"soak.cpp","position":14,"original_position":14,"commit_id":"56e3e97c6547d612cfd9df34e4b11e19673651f5","original_commit_id":"56e3e97c6547d612cfd9df34e4b11e19673651f5","user":{"login":"mpope9","id":10855578,"avatar_url":"https://avatars2.githubusercontent.com/u/10855578?v=4","gravatar_id":"","url":"https://api.github.com/users/mpope9","html_url":"https://github.com/mpope9","followers_url":"https://api.github.com/users/mpope9/followers","following_url":"https://api.github.com/users/mpope9/following{/other_user}","gists_url":"https://api.github.com/users/mpope9/gists{/gist_id}","starred_url":"https://api.github.com/users/mpope9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpope9/subscriptions","organizations_url":"https://api.github.com/users/mpope9/orgs","repos_url":"https://api.github.com/users/mpope9/repos","events_url":"https://api.github.com/users/mpope9/events{/privacy}","received_events_url":"https://api.github.com/users/mpope9/received_events","type":"User","site_admin":false},"body":"Nit tab","created_at":"2017-10-02T17:54:23Z","updated_at":"2017-10-02T17:56:20Z","html_url":"https://github.com/skillz/yojimbo/pull/3#discussion_r142209322","pull_request_url":"https://api.github.com/repos/skillz/yojimbo/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/skillz/yojimbo/pulls/comments/142209322"},"html":{"href":"https://github.com/skillz/yojimbo/pull/3#discussion_r142209322"},"pull_request":{"href":"https://api.github.com/repos/skillz/yojimbo/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/skillz/yojimbo/pulls/3","id":144241561,"html_url":"https://github.com/skillz/yojimbo/pull/3","diff_url":"https://github.com/skillz/yojimbo/pull/3.diff","patch_url":"https://github.com/skillz/yojimbo/pull/3.patch","issue_url":"https://api.github.com/repos/skillz/yojimbo/issues/3","number":3,"state":"open","locked":false,"title":"[#151572737] Test Environment Setup in Yojimbo","user":{"login":"cchung89","id":9207926,"avatar_url":"https://avatars2.githubusercontent.com/u/9207926?v=4","gravatar_id":"","url":"https://api.github.com/users/cchung89","html_url":"https://github.com/cchung89","followers_url":"https://api.github.com/users/cchung89/followers","following_url":"https://api.github.com/users/cchung89/following{/other_user}","gists_url":"https://api.github.com/users/cchung89/gists{/gist_id}","starred_url":"https://api.github.com/users/cchung89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchung89/subscriptions","organizations_url":"https://api.github.com/users/cchung89/orgs","repos_url":"https://api.github.com/users/cchung89/repos","events_url":"https://api.github.com/users/cchung89/events{/privacy}","received_events_url":"https://api.github.com/users/cchung89/received_events","type":"User","site_admin":false},"body":"Setting up the Skillz version test environment for Game Sync. Changed all the unit test, server, and client files to use the Skillz messages instead. Modified the object type for message to Skillz messages in files that use the original test messages. Modified the `premake5.lua` to make build project with our messages header file `message.h`.\r\nRun all the projects with the new setup with premake5 commands and they all are successfully built. Run cppcheck and scan-build to make sure no extra issues occur. Run the unit tests and they all pass with the Skillz messages. Run soak and messages are successfully send from the server to client and from client to server. Run the server and client and see they are successfully start up and the client is able to connect to the server without problem. Multiple clients are able to connect to the the server at once successfully. The valgrind shows no leaks. All the premake5 commands can be run successfully with the new changes.\r\n\r\n@mpope9 First Round\r\n@kkaminski Second Round","created_at":"2017-10-02T17:42:21Z","updated_at":"2017-10-02T17:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43d8b76439ca235a80d4e1bd36ae4f0737da18fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/skillz/yojimbo/pulls/3/commits","review_comments_url":"https://api.github.com/repos/skillz/yojimbo/pulls/3/comments","review_comment_url":"https://api.github.com/repos/skillz/yojimbo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skillz/yojimbo/issues/3/comments","statuses_url":"https://api.github.com/repos/skillz/yojimbo/statuses/56e3e97c6547d612cfd9df34e4b11e19673651f5","head":{"label":"skillz:feature-test-environment-setup","ref":"feature-test-environment-setup","sha":"56e3e97c6547d612cfd9df34e4b11e19673651f5","user":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"repo":{"id":104514500,"name":"yojimbo","full_name":"skillz/yojimbo","owner":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skillz/yojimbo","description":"A network library for client/server games with dedicated servers","fork":true,"url":"https://api.github.com/repos/skillz/yojimbo","forks_url":"https://api.github.com/repos/skillz/yojimbo/forks","keys_url":"https://api.github.com/repos/skillz/yojimbo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skillz/yojimbo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skillz/yojimbo/teams","hooks_url":"https://api.github.com/repos/skillz/yojimbo/hooks","issue_events_url":"https://api.github.com/repos/skillz/yojimbo/issues/events{/number}","events_url":"https://api.github.com/repos/skillz/yojimbo/events","assignees_url":"https://api.github.com/repos/skillz/yojimbo/assignees{/user}","branches_url":"https://api.github.com/repos/skillz/yojimbo/branches{/branch}","tags_url":"https://api.github.com/repos/skillz/yojimbo/tags","blobs_url":"https://api.github.com/repos/skillz/yojimbo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skillz/yojimbo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skillz/yojimbo/git/refs{/sha}","trees_url":"https://api.github.com/repos/skillz/yojimbo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skillz/yojimbo/statuses/{sha}","languages_url":"https://api.github.com/repos/skillz/yojimbo/languages","stargazers_url":"https://api.github.com/repos/skillz/yojimbo/stargazers","contributors_url":"https://api.github.com/repos/skillz/yojimbo/contributors","subscribers_url":"https://api.github.com/repos/skillz/yojimbo/subscribers","subscription_url":"https://api.github.com/repos/skillz/yojimbo/subscription","commits_url":"https://api.github.com/repos/skillz/yojimbo/commits{/sha}","git_commits_url":"https://api.github.com/repos/skillz/yojimbo/git/commits{/sha}","comments_url":"https://api.github.com/repos/skillz/yojimbo/comments{/number}","issue_comment_url":"https://api.github.com/repos/skillz/yojimbo/issues/comments{/number}","contents_url":"https://api.github.com/repos/skillz/yojimbo/contents/{+path}","compare_url":"https://api.github.com/repos/skillz/yojimbo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skillz/yojimbo/merges","archive_url":"https://api.github.com/repos/skillz/yojimbo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skillz/yojimbo/downloads","issues_url":"https://api.github.com/repos/skillz/yojimbo/issues{/number}","pulls_url":"https://api.github.com/repos/skillz/yojimbo/pulls{/number}","milestones_url":"https://api.github.com/repos/skillz/yojimbo/milestones{/number}","notifications_url":"https://api.github.com/repos/skillz/yojimbo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skillz/yojimbo/labels{/name}","releases_url":"https://api.github.com/repos/skillz/yojimbo/releases{/id}","deployments_url":"https://api.github.com/repos/skillz/yojimbo/deployments","created_at":"2017-09-22T20:08:11Z","updated_at":"2017-09-22T20:08:14Z","pushed_at":"2017-10-02T17:42:22Z","git_url":"git://github.com/skillz/yojimbo.git","ssh_url":"git@github.com:skillz/yojimbo.git","clone_url":"https://github.com/skillz/yojimbo.git","svn_url":"https://github.com/skillz/yojimbo","homepage":"","size":8205,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"skillz:development","ref":"development","sha":"a562e1b78437b20bca26e01bb5708edb361f05fb","user":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"repo":{"id":104514500,"name":"yojimbo","full_name":"skillz/yojimbo","owner":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skillz/yojimbo","description":"A network library for client/server games with dedicated servers","fork":true,"url":"https://api.github.com/repos/skillz/yojimbo","forks_url":"https://api.github.com/repos/skillz/yojimbo/forks","keys_url":"https://api.github.com/repos/skillz/yojimbo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skillz/yojimbo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skillz/yojimbo/teams","hooks_url":"https://api.github.com/repos/skillz/yojimbo/hooks","issue_events_url":"https://api.github.com/repos/skillz/yojimbo/issues/events{/number}","events_url":"https://api.github.com/repos/skillz/yojimbo/events","assignees_url":"https://api.github.com/repos/skillz/yojimbo/assignees{/user}","branches_url":"https://api.github.com/repos/skillz/yojimbo/branches{/branch}","tags_url":"https://api.github.com/repos/skillz/yojimbo/tags","blobs_url":"https://api.github.com/repos/skillz/yojimbo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skillz/yojimbo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skillz/yojimbo/git/refs{/sha}","trees_url":"https://api.github.com/repos/skillz/yojimbo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skillz/yojimbo/statuses/{sha}","languages_url":"https://api.github.com/repos/skillz/yojimbo/languages","stargazers_url":"https://api.github.com/repos/skillz/yojimbo/stargazers","contributors_url":"https://api.github.com/repos/skillz/yojimbo/contributors","subscribers_url":"https://api.github.com/repos/skillz/yojimbo/subscribers","subscription_url":"https://api.github.com/repos/skillz/yojimbo/subscription","commits_url":"https://api.github.com/repos/skillz/yojimbo/commits{/sha}","git_commits_url":"https://api.github.com/repos/skillz/yojimbo/git/commits{/sha}","comments_url":"https://api.github.com/repos/skillz/yojimbo/comments{/number}","issue_comment_url":"https://api.github.com/repos/skillz/yojimbo/issues/comments{/number}","contents_url":"https://api.github.com/repos/skillz/yojimbo/contents/{+path}","compare_url":"https://api.github.com/repos/skillz/yojimbo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skillz/yojimbo/merges","archive_url":"https://api.github.com/repos/skillz/yojimbo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skillz/yojimbo/downloads","issues_url":"https://api.github.com/repos/skillz/yojimbo/issues{/number}","pulls_url":"https://api.github.com/repos/skillz/yojimbo/pulls{/number}","milestones_url":"https://api.github.com/repos/skillz/yojimbo/milestones{/number}","notifications_url":"https://api.github.com/repos/skillz/yojimbo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skillz/yojimbo/labels{/name}","releases_url":"https://api.github.com/repos/skillz/yojimbo/releases{/id}","deployments_url":"https://api.github.com/repos/skillz/yojimbo/deployments","created_at":"2017-09-22T20:08:11Z","updated_at":"2017-09-22T20:08:14Z","pushed_at":"2017-10-02T17:42:22Z","git_url":"git://github.com/skillz/yojimbo.git","ssh_url":"git@github.com:skillz/yojimbo.git","clone_url":"https://github.com/skillz/yojimbo.git","svn_url":"https://github.com/skillz/yojimbo","homepage":"","size":8205,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skillz/yojimbo/pulls/3"},"html":{"href":"https://github.com/skillz/yojimbo/pull/3"},"issue":{"href":"https://api.github.com/repos/skillz/yojimbo/issues/3"},"comments":{"href":"https://api.github.com/repos/skillz/yojimbo/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/skillz/yojimbo/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/skillz/yojimbo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skillz/yojimbo/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/skillz/yojimbo/statuses/56e3e97c6547d612cfd9df34e4b11e19673651f5"}},"author_association":"NONE"}}
{"actor":{"display_login":"mpope9"}}