{"action":"created","comment":{"url":"https://api.github.com/repos/trayio/threadneedle/pulls/comments/96465699","pull_request_review_id":17048319,"id":96465699,"diff_hunk":"@@ -9,13 +9,14 @@ var substitute = require('../substitute');\n \n module.exports = function (key, config, params) {\n \n-  var subbedGlobalObject = substitute(this._globalOptions[key], params || {});\n-  var subbedObject       = substitute(config[key] || {}, params || {});\n+    params = params || {};\n \n-  if (config.globals === false || !_.isObject(subbedObject)) {\n-  \treturn subbedObject;\n-  } else {\n-  \treturn _.defaultsDeep(subbedObject, subbedGlobalObject);\n-  }\n+    var subbedGlobalObject = substitute(this._globalOptions[key], params);\n+    var subbedObject       = substitute(config[key] || {}, params);\n+\n+    if (config.globals === false)","path":"lib/addMethod/globalize/object.js","position":null,"original_position":16,"commit_id":"c717d8c5b3dfe86287b4d0bdae0de872e0a1e058","original_commit_id":"f3386e7f8d8d948b738e2e509aa85c70ce134380","user":{"login":"Johnbastian","id":6200705,"avatar_url":"https://avatars.githubusercontent.com/u/6200705?v=3","gravatar_id":"","url":"https://api.github.com/users/Johnbastian","html_url":"https://github.com/Johnbastian","followers_url":"https://api.github.com/users/Johnbastian/followers","following_url":"https://api.github.com/users/Johnbastian/following{/other_user}","gists_url":"https://api.github.com/users/Johnbastian/gists{/gist_id}","starred_url":"https://api.github.com/users/Johnbastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johnbastian/subscriptions","organizations_url":"https://api.github.com/users/Johnbastian/orgs","repos_url":"https://api.github.com/users/Johnbastian/repos","events_url":"https://api.github.com/users/Johnbastian/events{/privacy}","received_events_url":"https://api.github.com/users/Johnbastian/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-01-17T17:34:32Z","updated_at":"2017-01-17T17:34:32Z","html_url":"https://github.com/trayio/threadneedle/pull/29#discussion_r96465699","pull_request_url":"https://api.github.com/repos/trayio/threadneedle/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/trayio/threadneedle/pulls/comments/96465699"},"html":{"href":"https://github.com/trayio/threadneedle/pull/29#discussion_r96465699"},"pull_request":{"href":"https://api.github.com/repos/trayio/threadneedle/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/trayio/threadneedle/pulls/29","id":101908636,"html_url":"https://github.com/trayio/threadneedle/pull/29","diff_url":"https://github.com/trayio/threadneedle/pull/29.diff","patch_url":"https://github.com/trayio/threadneedle/pull/29.patch","issue_url":"https://api.github.com/repos/trayio/threadneedle/issues/29","number":29,"state":"open","locked":false,"title":"Added server code messages, and resolve issues #8, #21, and #28","user":{"login":"Johnbastian","id":6200705,"avatar_url":"https://avatars.githubusercontent.com/u/6200705?v=3","gravatar_id":"","url":"https://api.github.com/users/Johnbastian","html_url":"https://github.com/Johnbastian","followers_url":"https://api.github.com/users/Johnbastian/followers","following_url":"https://api.github.com/users/Johnbastian/following{/other_user}","gists_url":"https://api.github.com/users/Johnbastian/gists{/gist_id}","starred_url":"https://api.github.com/users/Johnbastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johnbastian/subscriptions","organizations_url":"https://api.github.com/users/Johnbastian/orgs","repos_url":"https://api.github.com/users/Johnbastian/repos","events_url":"https://api.github.com/users/Johnbastian/events{/privacy}","received_events_url":"https://api.github.com/users/Johnbastian/received_events","type":"User","site_admin":false},"body":"- Added server code messages.\n- Added support for ‘20x’ and ‘2xx’, both shorthand and `expects.statusCode`.\n- Fixed issue where arrays were not properly being processed during substitution.\n- Removed odd logic in `globalise.object` module.","created_at":"2017-01-17T17:22:11Z","updated_at":"2017-01-17T17:34:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9315cc21b493cf8e8cba4798745cce72b3bd62d8","assignee":{"login":"alirussell","id":643153,"avatar_url":"https://avatars.githubusercontent.com/u/643153?v=3","gravatar_id":"","url":"https://api.github.com/users/alirussell","html_url":"https://github.com/alirussell","followers_url":"https://api.github.com/users/alirussell/followers","following_url":"https://api.github.com/users/alirussell/following{/other_user}","gists_url":"https://api.github.com/users/alirussell/gists{/gist_id}","starred_url":"https://api.github.com/users/alirussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alirussell/subscriptions","organizations_url":"https://api.github.com/users/alirussell/orgs","repos_url":"https://api.github.com/users/alirussell/repos","events_url":"https://api.github.com/users/alirussell/events{/privacy}","received_events_url":"https://api.github.com/users/alirussell/received_events","type":"User","site_admin":false},"assignees":[{"login":"alirussell","id":643153,"avatar_url":"https://avatars.githubusercontent.com/u/643153?v=3","gravatar_id":"","url":"https://api.github.com/users/alirussell","html_url":"https://github.com/alirussell","followers_url":"https://api.github.com/users/alirussell/followers","following_url":"https://api.github.com/users/alirussell/following{/other_user}","gists_url":"https://api.github.com/users/alirussell/gists{/gist_id}","starred_url":"https://api.github.com/users/alirussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alirussell/subscriptions","organizations_url":"https://api.github.com/users/alirussell/orgs","repos_url":"https://api.github.com/users/alirussell/repos","events_url":"https://api.github.com/users/alirussell/events{/privacy}","received_events_url":"https://api.github.com/users/alirussell/received_events","type":"User","site_admin":false},{"login":"chrisjhoughton","id":2671525,"avatar_url":"https://avatars.githubusercontent.com/u/2671525?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisjhoughton","html_url":"https://github.com/chrisjhoughton","followers_url":"https://api.github.com/users/chrisjhoughton/followers","following_url":"https://api.github.com/users/chrisjhoughton/following{/other_user}","gists_url":"https://api.github.com/users/chrisjhoughton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisjhoughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisjhoughton/subscriptions","organizations_url":"https://api.github.com/users/chrisjhoughton/orgs","repos_url":"https://api.github.com/users/chrisjhoughton/repos","events_url":"https://api.github.com/users/chrisjhoughton/events{/privacy}","received_events_url":"https://api.github.com/users/chrisjhoughton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/trayio/threadneedle/pulls/29/commits","review_comments_url":"https://api.github.com/repos/trayio/threadneedle/pulls/29/comments","review_comment_url":"https://api.github.com/repos/trayio/threadneedle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trayio/threadneedle/issues/29/comments","statuses_url":"https://api.github.com/repos/trayio/threadneedle/statuses/c717d8c5b3dfe86287b4d0bdae0de872e0a1e058","head":{"label":"trayio:f/updates","ref":"f/updates","sha":"c717d8c5b3dfe86287b4d0bdae0de872e0a1e058","user":{"login":"trayio","id":4904633,"avatar_url":"https://avatars.githubusercontent.com/u/4904633?v=3","gravatar_id":"","url":"https://api.github.com/users/trayio","html_url":"https://github.com/trayio","followers_url":"https://api.github.com/users/trayio/followers","following_url":"https://api.github.com/users/trayio/following{/other_user}","gists_url":"https://api.github.com/users/trayio/gists{/gist_id}","starred_url":"https://api.github.com/users/trayio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trayio/subscriptions","organizations_url":"https://api.github.com/users/trayio/orgs","repos_url":"https://api.github.com/users/trayio/repos","events_url":"https://api.github.com/users/trayio/events{/privacy}","received_events_url":"https://api.github.com/users/trayio/received_events","type":"Organization","site_admin":false},"repo":{"id":49774166,"name":"threadneedle","full_name":"trayio/threadneedle","owner":{"login":"trayio","id":4904633,"avatar_url":"https://avatars.githubusercontent.com/u/4904633?v=3","gravatar_id":"","url":"https://api.github.com/users/trayio","html_url":"https://github.com/trayio","followers_url":"https://api.github.com/users/trayio/followers","following_url":"https://api.github.com/users/trayio/following{/other_user}","gists_url":"https://api.github.com/users/trayio/gists{/gist_id}","starred_url":"https://api.github.com/users/trayio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trayio/subscriptions","organizations_url":"https://api.github.com/users/trayio/orgs","repos_url":"https://api.github.com/users/trayio/repos","events_url":"https://api.github.com/users/trayio/events{/privacy}","received_events_url":"https://api.github.com/users/trayio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trayio/threadneedle","description":"An ORM-style abstraction layer for interacting with third party HTTP-based APIs.","fork":false,"url":"https://api.github.com/repos/trayio/threadneedle","forks_url":"https://api.github.com/repos/trayio/threadneedle/forks","keys_url":"https://api.github.com/repos/trayio/threadneedle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trayio/threadneedle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trayio/threadneedle/teams","hooks_url":"https://api.github.com/repos/trayio/threadneedle/hooks","issue_events_url":"https://api.github.com/repos/trayio/threadneedle/issues/events{/number}","events_url":"https://api.github.com/repos/trayio/threadneedle/events","assignees_url":"https://api.github.com/repos/trayio/threadneedle/assignees{/user}","branches_url":"https://api.github.com/repos/trayio/threadneedle/branches{/branch}","tags_url":"https://api.github.com/repos/trayio/threadneedle/tags","blobs_url":"https://api.github.com/repos/trayio/threadneedle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trayio/threadneedle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trayio/threadneedle/git/refs{/sha}","trees_url":"https://api.github.com/repos/trayio/threadneedle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trayio/threadneedle/statuses/{sha}","languages_url":"https://api.github.com/repos/trayio/threadneedle/languages","stargazers_url":"https://api.github.com/repos/trayio/threadneedle/stargazers","contributors_url":"https://api.github.com/repos/trayio/threadneedle/contributors","subscribers_url":"https://api.github.com/repos/trayio/threadneedle/subscribers","subscription_url":"https://api.github.com/repos/trayio/threadneedle/subscription","commits_url":"https://api.github.com/repos/trayio/threadneedle/commits{/sha}","git_commits_url":"https://api.github.com/repos/trayio/threadneedle/git/commits{/sha}","comments_url":"https://api.github.com/repos/trayio/threadneedle/comments{/number}","issue_comment_url":"https://api.github.com/repos/trayio/threadneedle/issues/comments{/number}","contents_url":"https://api.github.com/repos/trayio/threadneedle/contents/{+path}","compare_url":"https://api.github.com/repos/trayio/threadneedle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trayio/threadneedle/merges","archive_url":"https://api.github.com/repos/trayio/threadneedle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trayio/threadneedle/downloads","issues_url":"https://api.github.com/repos/trayio/threadneedle/issues{/number}","pulls_url":"https://api.github.com/repos/trayio/threadneedle/pulls{/number}","milestones_url":"https://api.github.com/repos/trayio/threadneedle/milestones{/number}","notifications_url":"https://api.github.com/repos/trayio/threadneedle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trayio/threadneedle/labels{/name}","releases_url":"https://api.github.com/repos/trayio/threadneedle/releases{/id}","deployments_url":"https://api.github.com/repos/trayio/threadneedle/deployments","created_at":"2016-01-16T13:20:45Z","updated_at":"2016-10-28T11:14:32Z","pushed_at":"2017-01-17T17:34:11Z","git_url":"git://github.com/trayio/threadneedle.git","ssh_url":"git@github.com:trayio/threadneedle.git","clone_url":"https://github.com/trayio/threadneedle.git","svn_url":"https://github.com/trayio/threadneedle","homepage":"","size":112,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":6,"default_branch":"master"}},"base":{"label":"trayio:master","ref":"master","sha":"a2006cc8d611e77073d5e4d88bcb3d473300cf48","user":{"login":"trayio","id":4904633,"avatar_url":"https://avatars.githubusercontent.com/u/4904633?v=3","gravatar_id":"","url":"https://api.github.com/users/trayio","html_url":"https://github.com/trayio","followers_url":"https://api.github.com/users/trayio/followers","following_url":"https://api.github.com/users/trayio/following{/other_user}","gists_url":"https://api.github.com/users/trayio/gists{/gist_id}","starred_url":"https://api.github.com/users/trayio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trayio/subscriptions","organizations_url":"https://api.github.com/users/trayio/orgs","repos_url":"https://api.github.com/users/trayio/repos","events_url":"https://api.github.com/users/trayio/events{/privacy}","received_events_url":"https://api.github.com/users/trayio/received_events","type":"Organization","site_admin":false},"repo":{"id":49774166,"name":"threadneedle","full_name":"trayio/threadneedle","owner":{"login":"trayio","id":4904633,"avatar_url":"https://avatars.githubusercontent.com/u/4904633?v=3","gravatar_id":"","url":"https://api.github.com/users/trayio","html_url":"https://github.com/trayio","followers_url":"https://api.github.com/users/trayio/followers","following_url":"https://api.github.com/users/trayio/following{/other_user}","gists_url":"https://api.github.com/users/trayio/gists{/gist_id}","starred_url":"https://api.github.com/users/trayio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trayio/subscriptions","organizations_url":"https://api.github.com/users/trayio/orgs","repos_url":"https://api.github.com/users/trayio/repos","events_url":"https://api.github.com/users/trayio/events{/privacy}","received_events_url":"https://api.github.com/users/trayio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trayio/threadneedle","description":"An ORM-style abstraction layer for interacting with third party HTTP-based APIs.","fork":false,"url":"https://api.github.com/repos/trayio/threadneedle","forks_url":"https://api.github.com/repos/trayio/threadneedle/forks","keys_url":"https://api.github.com/repos/trayio/threadneedle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trayio/threadneedle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trayio/threadneedle/teams","hooks_url":"https://api.github.com/repos/trayio/threadneedle/hooks","issue_events_url":"https://api.github.com/repos/trayio/threadneedle/issues/events{/number}","events_url":"https://api.github.com/repos/trayio/threadneedle/events","assignees_url":"https://api.github.com/repos/trayio/threadneedle/assignees{/user}","branches_url":"https://api.github.com/repos/trayio/threadneedle/branches{/branch}","tags_url":"https://api.github.com/repos/trayio/threadneedle/tags","blobs_url":"https://api.github.com/repos/trayio/threadneedle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trayio/threadneedle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trayio/threadneedle/git/refs{/sha}","trees_url":"https://api.github.com/repos/trayio/threadneedle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trayio/threadneedle/statuses/{sha}","languages_url":"https://api.github.com/repos/trayio/threadneedle/languages","stargazers_url":"https://api.github.com/repos/trayio/threadneedle/stargazers","contributors_url":"https://api.github.com/repos/trayio/threadneedle/contributors","subscribers_url":"https://api.github.com/repos/trayio/threadneedle/subscribers","subscription_url":"https://api.github.com/repos/trayio/threadneedle/subscription","commits_url":"https://api.github.com/repos/trayio/threadneedle/commits{/sha}","git_commits_url":"https://api.github.com/repos/trayio/threadneedle/git/commits{/sha}","comments_url":"https://api.github.com/repos/trayio/threadneedle/comments{/number}","issue_comment_url":"https://api.github.com/repos/trayio/threadneedle/issues/comments{/number}","contents_url":"https://api.github.com/repos/trayio/threadneedle/contents/{+path}","compare_url":"https://api.github.com/repos/trayio/threadneedle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trayio/threadneedle/merges","archive_url":"https://api.github.com/repos/trayio/threadneedle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trayio/threadneedle/downloads","issues_url":"https://api.github.com/repos/trayio/threadneedle/issues{/number}","pulls_url":"https://api.github.com/repos/trayio/threadneedle/pulls{/number}","milestones_url":"https://api.github.com/repos/trayio/threadneedle/milestones{/number}","notifications_url":"https://api.github.com/repos/trayio/threadneedle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trayio/threadneedle/labels{/name}","releases_url":"https://api.github.com/repos/trayio/threadneedle/releases{/id}","deployments_url":"https://api.github.com/repos/trayio/threadneedle/deployments","created_at":"2016-01-16T13:20:45Z","updated_at":"2016-10-28T11:14:32Z","pushed_at":"2017-01-17T17:34:11Z","git_url":"git://github.com/trayio/threadneedle.git","ssh_url":"git@github.com:trayio/threadneedle.git","clone_url":"https://github.com/trayio/threadneedle.git","svn_url":"https://github.com/trayio/threadneedle","homepage":"","size":112,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trayio/threadneedle/pulls/29"},"html":{"href":"https://github.com/trayio/threadneedle/pull/29"},"issue":{"href":"https://api.github.com/repos/trayio/threadneedle/issues/29"},"comments":{"href":"https://api.github.com/repos/trayio/threadneedle/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/trayio/threadneedle/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/trayio/threadneedle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trayio/threadneedle/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/trayio/threadneedle/statuses/c717d8c5b3dfe86287b4d0bdae0de872e0a1e058"}}}}
{"actor":{"display_login":"Johnbastian"}}