{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2298","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2298/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2298/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2298/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2298","id":228137855,"number":2298,"title":"Vision Partial Veneer","user":{"login":"lukesneeringer","id":4346,"avatar_url":"https://avatars4.githubusercontent.com/u/4346?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesneeringer","html_url":"https://github.com/lukesneeringer","followers_url":"https://api.github.com/users/lukesneeringer/followers","following_url":"https://api.github.com/users/lukesneeringer/following{/other_user}","gists_url":"https://api.github.com/users/lukesneeringer/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesneeringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesneeringer/subscriptions","organizations_url":"https://api.github.com/users/lukesneeringer/orgs","repos_url":"https://api.github.com/users/lukesneeringer/repos","events_url":"https://api.github.com/users/lukesneeringer/events{/privacy}","received_events_url":"https://api.github.com/users/lukesneeringer/received_events","type":"User","site_admin":false},"labels":[{"id":335691981,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/labels/api:%20vision","name":"api: vision","color":"cd7f32","default":false},{"id":107867250,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/labels/cla:%20no","name":"cla: no","color":"e11d21","default":false},{"id":544179613,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/labels/priority:%20p1","name":"priority: p1","color":"ffa03e","default":false},{"id":172811921,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/labels/status:%20do%20not%20merge","name":"status: do not merge","color":"ffee58","default":false}],"state":"open","locked":false,"assignee":{"login":"lukesneeringer","id":4346,"avatar_url":"https://avatars4.githubusercontent.com/u/4346?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesneeringer","html_url":"https://github.com/lukesneeringer","followers_url":"https://api.github.com/users/lukesneeringer/followers","following_url":"https://api.github.com/users/lukesneeringer/following{/other_user}","gists_url":"https://api.github.com/users/lukesneeringer/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesneeringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesneeringer/subscriptions","organizations_url":"https://api.github.com/users/lukesneeringer/orgs","repos_url":"https://api.github.com/users/lukesneeringer/repos","events_url":"https://api.github.com/users/lukesneeringer/events{/privacy}","received_events_url":"https://api.github.com/users/lukesneeringer/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukesneeringer","id":4346,"avatar_url":"https://avatars4.githubusercontent.com/u/4346?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesneeringer","html_url":"https://github.com/lukesneeringer","followers_url":"https://api.github.com/users/lukesneeringer/followers","following_url":"https://api.github.com/users/lukesneeringer/following{/other_user}","gists_url":"https://api.github.com/users/lukesneeringer/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesneeringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesneeringer/subscriptions","organizations_url":"https://api.github.com/users/lukesneeringer/orgs","repos_url":"https://api.github.com/users/lukesneeringer/repos","events_url":"https://api.github.com/users/lukesneeringer/events{/privacy}","received_events_url":"https://api.github.com/users/lukesneeringer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2017-05-11T22:21:16Z","updated_at":"2017-07-14T23:38:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/pulls/2298","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2298","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2298.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2298.patch"},"body":"This is the new surface with breaking changes.\r\n\r\nThis is an initial pass at the implementation of a \"partial Veneer\" for Vision.\r\n\r\nIt:\r\n\r\n  * deprecates the entire manual layer\r\n  * makes the GAPIC, with helpers, available at `require('@google-cloud/vision').v1()`.\r\n  * provides the `annotateImage` and single-feature methods\r\n  * has 100% test coverage on manual code\r\n\r\nIt does *not*:\r\n\r\n  * ~provide a default partial Veneer on the versionless entry point (because it is taken by the deprecated manual layer)~ have backwards compatibility, at all, even remotely a little\r\n  * [x] handle specifying a file handler for an image (needs to be done)\r\n  * [x] provide documentation for the partial Veneer (needs to be done)\r\n  * [x] have 100% test coverage on automated code (needs to be done)\r\n\r\nNotes:\r\n\r\n  * This introduces the use of ES6 syntax supported by Node 4.\r\n  * This uses power-assert ~sinon and chai, which are not currently being used by other packages~"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/comments/315491421","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2298#issuecomment-315491421","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-node/issues/2298","id":315491421,"user":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars4.githubusercontent.com/u/723048?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"created_at":"2017-07-14T23:38:01Z","updated_at":"2017-07-14T23:38:01Z","body":"@lukesneeringer close this, since this is going in #2421?"}}
{"actor":{"display_login":"stephenplusplus"}}