{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/116135940","pull_request_review_id":37735135,"id":116135940,"diff_hunk":"@@ -61,6 +73,13 @@ export class TocService {\n     return this.domSanitizer.bypassSecurityTrustHtml(a.innerHTML.trim());\n   }\n \n+  private findTocHeadings(docElement: Element): HTMLHeadingElement[] {\n+    const headings = docElement.querySelectorAll('h2,h3');\n+    const skipNoTocHeadings = (heading: HTMLHeadingElement) => !/(?:no-toc|notoc)/i.test(heading.className);\n+\n+    return Array.prototype.filter.call(headings, skipNoTocHeadings);","path":"aio/src/app/shared/toc.service.ts","position":85,"original_position":85,"commit_id":"30f99dc8aa9422d3a26a29dbe367b920c1afe055","original_commit_id":"30f99dc8aa9422d3a26a29dbe367b920c1afe055","user":{"login":"wardbell","id":129061,"avatar_url":"https://avatars2.githubusercontent.com/u/129061?v=3","gravatar_id":"","url":"https://api.github.com/users/wardbell","html_url":"https://github.com/wardbell","followers_url":"https://api.github.com/users/wardbell/followers","following_url":"https://api.github.com/users/wardbell/following{/other_user}","gists_url":"https://api.github.com/users/wardbell/gists{/gist_id}","starred_url":"https://api.github.com/users/wardbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wardbell/subscriptions","organizations_url":"https://api.github.com/users/wardbell/orgs","repos_url":"https://api.github.com/users/wardbell/repos","events_url":"https://api.github.com/users/wardbell/events{/privacy}","received_events_url":"https://api.github.com/users/wardbell/received_events","type":"User","site_admin":false},"body":"I don't really mind a for loop but I see you do ;-)","created_at":"2017-05-12T01:15:03Z","updated_at":"2017-05-12T01:20:37Z","html_url":"https://github.com/angular/angular/pull/16703#discussion_r116135940","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/16703","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/116135940"},"html":{"href":"https://github.com/angular/angular/pull/16703#discussion_r116135940"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/16703"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/16703","id":119937785,"html_url":"https://github.com/angular/angular/pull/16703","diff_url":"https://github.com/angular/angular/pull/16703.diff","patch_url":"https://github.com/angular/angular/pull/16703.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/16703","number":16703,"state":"open","locked":false,"title":"WIP feat(aio): implement ScrollSpy service (to highlight currently viewed section)","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars1.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"Seems to work nicely, but no tests yet 😳\r\nIt turned out way more complicated than I wanted t to be. Alternative ideas or suggestions welcome 😕 ","created_at":"2017-05-10T17:29:31Z","updated_at":"2017-05-12T01:20:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1da27a926d9c709a47160654242490ae1ad2eaf9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/16703/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/16703/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/16703/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/30f99dc8aa9422d3a26a29dbe367b920c1afe055","head":{"label":"gkalpak:feat-aio-scroll-spy","ref":"feat-aio-scroll-spy","sha":"30f99dc8aa9422d3a26a29dbe367b920c1afe055","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars1.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"repo":{"id":42242550,"name":"angular","full_name":"gkalpak/angular","owner":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars1.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkalpak/angular","description":null,"fork":true,"url":"https://api.github.com/repos/gkalpak/angular","forks_url":"https://api.github.com/repos/gkalpak/angular/forks","keys_url":"https://api.github.com/repos/gkalpak/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkalpak/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkalpak/angular/teams","hooks_url":"https://api.github.com/repos/gkalpak/angular/hooks","issue_events_url":"https://api.github.com/repos/gkalpak/angular/issues/events{/number}","events_url":"https://api.github.com/repos/gkalpak/angular/events","assignees_url":"https://api.github.com/repos/gkalpak/angular/assignees{/user}","branches_url":"https://api.github.com/repos/gkalpak/angular/branches{/branch}","tags_url":"https://api.github.com/repos/gkalpak/angular/tags","blobs_url":"https://api.github.com/repos/gkalpak/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkalpak/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkalpak/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkalpak/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkalpak/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/gkalpak/angular/languages","stargazers_url":"https://api.github.com/repos/gkalpak/angular/stargazers","contributors_url":"https://api.github.com/repos/gkalpak/angular/contributors","subscribers_url":"https://api.github.com/repos/gkalpak/angular/subscribers","subscription_url":"https://api.github.com/repos/gkalpak/angular/subscription","commits_url":"https://api.github.com/repos/gkalpak/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkalpak/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkalpak/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkalpak/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkalpak/angular/contents/{+path}","compare_url":"https://api.github.com/repos/gkalpak/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkalpak/angular/merges","archive_url":"https://api.github.com/repos/gkalpak/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkalpak/angular/downloads","issues_url":"https://api.github.com/repos/gkalpak/angular/issues{/number}","pulls_url":"https://api.github.com/repos/gkalpak/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/gkalpak/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/gkalpak/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkalpak/angular/labels{/name}","releases_url":"https://api.github.com/repos/gkalpak/angular/releases{/id}","deployments_url":"https://api.github.com/repos/gkalpak/angular/deployments","created_at":"2015-09-10T12:16:17Z","updated_at":"2016-03-11T07:37:55Z","pushed_at":"2017-05-11T22:58:32Z","git_url":"git://github.com/gkalpak/angular.git","ssh_url":"git@github.com:gkalpak/angular.git","clone_url":"https://github.com/gkalpak/angular.git","svn_url":"https://github.com/gkalpak/angular","homepage":"https://angular.io","size":55061,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"e242e20ca301eacfc24e3d12847a35d1d183b11c","user":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-05-12T00:08:36Z","pushed_at":"2017-05-12T00:44:49Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":56391,"stargazers_count":23945,"watchers_count":23945,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6078,"mirror_url":null,"open_issues_count":1435,"forks":6078,"open_issues":1435,"watchers":23945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/16703"},"html":{"href":"https://github.com/angular/angular/pull/16703"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/16703"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/16703/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/16703/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/16703/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/30f99dc8aa9422d3a26a29dbe367b920c1afe055"}}}}
{"actor":{"display_login":"wardbell"}}