{"action":"created","issue":{"url":"https://api.github.com/repos/mapsme/omim/issues/6917","repository_url":"https://api.github.com/repos/mapsme/omim","labels_url":"https://api.github.com/repos/mapsme/omim/issues/6917/labels{/name}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/6917/comments","events_url":"https://api.github.com/repos/mapsme/omim/issues/6917/events","html_url":"https://github.com/mapsme/omim/pull/6917","id":250661006,"number":6917,"title":"MAPSME-5367 fix route tests: allow empty m_subrouteAttrs for routes without intermediate points","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-16T15:06:22Z","updated_at":"2017-08-16T15:07:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/6917","html_url":"https://github.com/mapsme/omim/pull/6917","diff_url":"https://github.com/mapsme/omim/pull/6917.diff","patch_url":"https://github.com/mapsme/omim/pull/6917.patch"},"body":"MAPSME-5367\r\nhttp://angola.mapsme.mail.msk:8080/job/GitHubWatchdog/BUILD_MODE=release,label=WD_Mac/lastCompletedBuild/testReport/(root)/routing_tests/route_tests_cpp_DistanceToCurrentTurnTest/\r\n\r\nсломала, когда делала роутинг с промежуточными точками.\r\nСуть поломки -- был добавлен ASSERT, который проверяет, что в Route `m_subrouteAttrs.size() > m_currentSubrouteIdx`.\r\nНо сейчас объекты Route могут и не удовлетворять этому условию -- в сконструированном по умолчанию объекте `m_subrouteAttrs.size() ==0` и `m_currentSubrouteIdx == 0` и нет данных чтобы их корректно проинициализировать.\r\n\r\nСейчас методы, которые могут работать с саброутами, вызываются при не установленной информации о саброутах только в тестах. Но в целом интерфейс класса Route позволяет при отсутствии промежуточных точек не вызывать метод `SetSubroteAttrs` и при этом корректно работать. Поэтому разрешила в `SetGeometry` иметь пустой вектор `m_subrouteAttrs`."},"comment":{"url":"https://api.github.com/repos/mapsme/omim/issues/comments/322802628","html_url":"https://github.com/mapsme/omim/pull/6917#issuecomment-322802628","issue_url":"https://api.github.com/repos/mapsme/omim/issues/6917","id":322802628,"user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"created_at":"2017-08-16T15:07:42Z","updated_at":"2017-08-16T15:07:42Z","body":"DUDE JTTP"}}
{"actor":{"display_login":"tatiana-kondakova"}}