{"action":"created","issue":{"url":"https://api.github.com/repos/moby/moby/issues/34855","repository_url":"https://api.github.com/repos/moby/moby","labels_url":"https://api.github.com/repos/moby/moby/issues/34855/labels{/name}","comments_url":"https://api.github.com/repos/moby/moby/issues/34855/comments","events_url":"https://api.github.com/repos/moby/moby/issues/34855/events","html_url":"https://github.com/moby/moby/issues/34855","id":257807558,"number":34855,"title":"Make the log lines splitting configurable","user":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"labels":[{"id":70404987,"url":"https://api.github.com/repos/moby/moby/labels/area/logging","name":"area/logging","color":"fbca04","default":false},{"id":179237356,"url":"https://api.github.com/repos/moby/moby/labels/kind/enhancement","name":"kind/enhancement","color":"E8CAAF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-09-14T18:05:11Z","updated_at":"2017-10-16T19:21:59Z","closed_at":null,"author_association":"NONE","body":"Follow-up of https://github.com/moby/moby/issues/34620\r\n\r\nAs mentioned in the original bug, [logging change introduced in 1.13](https://github.com/moby/moby/pull/22982) is not compatible with the existing tools for collecting logs. There are several scenarios when this change severely breaks logs collection. Example: if a message is a JSON object longer than 16KB and the logs collector is not prepared, parsing will be broken.\r\n\r\nThis feature is a breaking change that should have been made configurable in the first place. Right now 16KB is [_constant in the code_](https://github.com/nalind/docker/blob/master/daemon/logger/copier.go#L13) picked for better [_artificial benchmark results_](https://github.com/moby/moby/pull/22982#issuecomment-224042594). Moreover, this breaking change was described in the release notes as `Improve logging of long log lines` which tells _nothing_ about the change.\r\n\r\nThis functionality has to be configurable: it should be possible to change the limit and/or turn the feature off completely. Please also backport this to all affected releases.\r\n\r\n/cc @piosz @fgrzadkowski @thockin @igorpeshansky"},"comment":{"url":"https://api.github.com/repos/moby/moby/issues/comments/337005199","html_url":"https://github.com/moby/moby/issues/34855#issuecomment-337005199","issue_url":"https://api.github.com/repos/moby/moby/issues/34855","id":337005199,"user":{"login":"atpet","id":28293884,"avatar_url":"https://avatars1.githubusercontent.com/u/28293884?v=4","gravatar_id":"","url":"https://api.github.com/users/atpet","html_url":"https://github.com/atpet","followers_url":"https://api.github.com/users/atpet/followers","following_url":"https://api.github.com/users/atpet/following{/other_user}","gists_url":"https://api.github.com/users/atpet/gists{/gist_id}","starred_url":"https://api.github.com/users/atpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atpet/subscriptions","organizations_url":"https://api.github.com/users/atpet/orgs","repos_url":"https://api.github.com/users/atpet/repos","events_url":"https://api.github.com/users/atpet/events{/privacy}","received_events_url":"https://api.github.com/users/atpet/received_events","type":"User","site_admin":false},"created_at":"2017-10-16T19:21:59Z","updated_at":"2017-10-16T19:21:59Z","author_association":"NONE","body":"I can second this.. I ran into a nasty issue today while collecting docker container logs using the splunk logging driver. The application outputs log messages as json payload to stdout. Everything is fine if the length of a message stays below limit. Long messages are split and the data that ends up in Splunk is garbage as the parts are not valid json and the initial log message cannot be re-constructed.\r\nThis is a real production issue for my environment where operational readiness monitoring partially relies on logs. I guess I'm not alone with this."}}
{"actor":{"display_login":"atpet"}}