{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20651","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20651/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20651/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20651/events","html_url":"https://github.com/TrinityCore/TrinityCore/issues/20651","id":266488756,"number":20651,"title":"UNIT_STATE_CASTING removed before resetting swing timer","user":{"login":"robinsch","id":8017650,"avatar_url":"https://avatars1.githubusercontent.com/u/8017650?v=4","gravatar_id":"","url":"https://api.github.com/users/robinsch","html_url":"https://github.com/robinsch","followers_url":"https://api.github.com/users/robinsch/followers","following_url":"https://api.github.com/users/robinsch/following{/other_user}","gists_url":"https://api.github.com/users/robinsch/gists{/gist_id}","starred_url":"https://api.github.com/users/robinsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinsch/subscriptions","organizations_url":"https://api.github.com/users/robinsch/orgs","repos_url":"https://api.github.com/users/robinsch/repos","events_url":"https://api.github.com/users/robinsch/events{/privacy}","received_events_url":"https://api.github.com/users/robinsch/received_events","type":"User","site_admin":false},"labels":[{"id":26232644,"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-18T13:15:51Z","updated_at":"2017-10-28T08:38:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!--- (**********************************)\r\n      (** Fill in the following fields **)\r\n      (**********************************) --->\r\n\r\n**Description:**\r\n\r\nUNIT_STATE_CASTING is removed in https://github.com/TrinityCore/TrinityCore/blob/master/src/server/game/Spells/Spell.cpp#L3360\r\nIs this duplicate since it's removed in ::finish anyway?\r\n\r\nAlso in ::finish it is called before resetAttackTimer which is causing auto attack code to run in between casts.\r\n\r\n**Steps to reproduce the problem:**\r\nhttps://github.com/dalaranwow/dalaran-wow/issues/4679\r\n\r\n**Branch(es):**\r\n\r\nboth\r\n\r\n**TC rev. hash/commit:** \r\n\r\ncd3feb00d547124f8df6e03feebd5af00c2c899e\r\n\r\nNo idea if this will break something (https://gist.github.com/robinsch/184f58dc58bd3d90974981094f25c598)"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/340159986","html_url":"https://github.com/TrinityCore/TrinityCore/issues/20651#issuecomment-340159986","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20651","id":340159986,"user":{"login":"Jildor","id":521036,"avatar_url":"https://avatars1.githubusercontent.com/u/521036?v=4","gravatar_id":"","url":"https://api.github.com/users/Jildor","html_url":"https://github.com/Jildor","followers_url":"https://api.github.com/users/Jildor/followers","following_url":"https://api.github.com/users/Jildor/following{/other_user}","gists_url":"https://api.github.com/users/Jildor/gists{/gist_id}","starred_url":"https://api.github.com/users/Jildor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jildor/subscriptions","organizations_url":"https://api.github.com/users/Jildor/orgs","repos_url":"https://api.github.com/users/Jildor/repos","events_url":"https://api.github.com/users/Jildor/events{/privacy}","received_events_url":"https://api.github.com/users/Jildor/received_events","type":"User","site_admin":false},"created_at":"2017-10-28T08:38:25Z","updated_at":"2017-10-28T08:38:25Z","author_association":"CONTRIBUTOR","body":"@robinsch if you test it and works fine, try to make a Pull request"}}
{"actor":{"display_login":"Jildor"}}