{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/149092330","pull_request_review_id":74432165,"id":149092330,"diff_hunk":"@@ -28,8 +29,16 @@ class Registry\n      */\n     public function add(Workflow $workflow, $supportStrategy)\n     {\n-        if (!$supportStrategy instanceof SupportStrategyInterface) {\n-            throw new \\InvalidArgumentException('The \"supportStrategy\" is not an instance of SupportStrategyInterface.');\n+        @trigger_error(sprintf('%s is deprecated since Symfony 4.0. Use addWorkflow instead.', __METHOD__), E_USER_DEPRECATED);\n+        $this->addWorkflow($workflow, $supportStrategy);\n+    }\n+\n+    public function addWorkflow(WorkflowInterface $workflow, $supportStrategy)\n+    {\n+        if ($supportStrategy instanceof SupportStrategyInterface) {\n+            @trigger_error(sprintf('Passing a \"%s\" in \"%s\" is deprecated since 4.0. Use \"%s\" instead.', SupportStrategyInterface::class, __METHOD__, SupportStrategyWorkflowInterface::class), E_USER_DEPRECATED);","path":"src/Symfony/Component/Workflow/Registry.php","position":21,"original_position":21,"commit_id":"f4d35b6827ab3f85365c004f373323ccbca06034","original_commit_id":"f4d35b6827ab3f85365c004f373323ccbca06034","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars0.githubusercontent.com/u/1957048?v=4","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"4.1","created_at":"2017-11-06T14:29:25Z","updated_at":"2017-11-06T14:29:25Z","html_url":"https://github.com/symfony/symfony/pull/24751#discussion_r149092330","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/24751","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/149092330"},"html":{"href":"https://github.com/symfony/symfony/pull/24751#discussion_r149092330"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24751"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/24751","id":149444795,"html_url":"https://github.com/symfony/symfony/pull/24751","diff_url":"https://github.com/symfony/symfony/pull/24751.diff","patch_url":"https://github.com/symfony/symfony/pull/24751.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/24751","number":24751,"state":"open","locked":false,"title":"[Workflow] Introduce a Workflow interface","user":{"login":"Simperfit","id":3451634,"avatar_url":"https://avatars1.githubusercontent.com/u/3451634?v=4","gravatar_id":"","url":"https://api.github.com/users/Simperfit","html_url":"https://github.com/Simperfit","followers_url":"https://api.github.com/users/Simperfit/followers","following_url":"https://api.github.com/users/Simperfit/following{/other_user}","gists_url":"https://api.github.com/users/Simperfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Simperfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simperfit/subscriptions","organizations_url":"https://api.github.com/users/Simperfit/orgs","repos_url":"https://api.github.com/users/Simperfit/repos","events_url":"https://api.github.com/users/Simperfit/events{/privacy}","received_events_url":"https://api.github.com/users/Simperfit/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes \r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | #23910 \r\n| License       | MIT\r\n| Doc PR        | todo\r\n\r\n@chalasr I think all the points you made in 23910 has been done. Needs to update the docs too.\r\n","created_at":"2017-10-30T06:27:34Z","updated_at":"2017-11-06T14:29:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c85edf692f24e235e95d7d22eda2b0e558ecee72","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/17","html_url":"https://github.com/symfony/symfony/milestone/17","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/17/labels","id":2795131,"number":17,"title":"4.1","description":"https://symfony.com/roadmap?version=4.1#checker","creator":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":113,"closed_issues":11,"state":"open","created_at":"2017-09-26T15:40:00Z","updated_at":"2017-11-05T16:15:57Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/24751/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/24751/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/24751/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/f4d35b6827ab3f85365c004f373323ccbca06034","head":{"label":"Simperfit:feature/introduce-an-interface-for-the-workflow-component","ref":"feature/introduce-an-interface-for-the-workflow-component","sha":"f4d35b6827ab3f85365c004f373323ccbca06034","user":{"login":"Simperfit","id":3451634,"avatar_url":"https://avatars1.githubusercontent.com/u/3451634?v=4","gravatar_id":"","url":"https://api.github.com/users/Simperfit","html_url":"https://github.com/Simperfit","followers_url":"https://api.github.com/users/Simperfit/followers","following_url":"https://api.github.com/users/Simperfit/following{/other_user}","gists_url":"https://api.github.com/users/Simperfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Simperfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simperfit/subscriptions","organizations_url":"https://api.github.com/users/Simperfit/orgs","repos_url":"https://api.github.com/users/Simperfit/repos","events_url":"https://api.github.com/users/Simperfit/events{/privacy}","received_events_url":"https://api.github.com/users/Simperfit/received_events","type":"User","site_admin":false},"repo":{"id":53192551,"name":"symfony","full_name":"Simperfit/symfony","owner":{"login":"Simperfit","id":3451634,"avatar_url":"https://avatars1.githubusercontent.com/u/3451634?v=4","gravatar_id":"","url":"https://api.github.com/users/Simperfit","html_url":"https://github.com/Simperfit","followers_url":"https://api.github.com/users/Simperfit/followers","following_url":"https://api.github.com/users/Simperfit/following{/other_user}","gists_url":"https://api.github.com/users/Simperfit/gists{/gist_id}","starred_url":"https://api.github.com/users/Simperfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simperfit/subscriptions","organizations_url":"https://api.github.com/users/Simperfit/orgs","repos_url":"https://api.github.com/users/Simperfit/repos","events_url":"https://api.github.com/users/Simperfit/events{/privacy}","received_events_url":"https://api.github.com/users/Simperfit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Simperfit/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/Simperfit/symfony","forks_url":"https://api.github.com/repos/Simperfit/symfony/forks","keys_url":"https://api.github.com/repos/Simperfit/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Simperfit/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Simperfit/symfony/teams","hooks_url":"https://api.github.com/repos/Simperfit/symfony/hooks","issue_events_url":"https://api.github.com/repos/Simperfit/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Simperfit/symfony/events","assignees_url":"https://api.github.com/repos/Simperfit/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Simperfit/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Simperfit/symfony/tags","blobs_url":"https://api.github.com/repos/Simperfit/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Simperfit/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Simperfit/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Simperfit/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Simperfit/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Simperfit/symfony/languages","stargazers_url":"https://api.github.com/repos/Simperfit/symfony/stargazers","contributors_url":"https://api.github.com/repos/Simperfit/symfony/contributors","subscribers_url":"https://api.github.com/repos/Simperfit/symfony/subscribers","subscription_url":"https://api.github.com/repos/Simperfit/symfony/subscription","commits_url":"https://api.github.com/repos/Simperfit/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Simperfit/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Simperfit/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Simperfit/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Simperfit/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Simperfit/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Simperfit/symfony/merges","archive_url":"https://api.github.com/repos/Simperfit/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Simperfit/symfony/downloads","issues_url":"https://api.github.com/repos/Simperfit/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Simperfit/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Simperfit/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Simperfit/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Simperfit/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Simperfit/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/Simperfit/symfony/deployments","created_at":"2016-03-05T08:55:40Z","updated_at":"2016-03-05T08:55:55Z","pushed_at":"2017-11-06T07:10:19Z","git_url":"git://github.com/Simperfit/symfony.git","ssh_url":"git@github.com:Simperfit/symfony.git","clone_url":"https://github.com/Simperfit/symfony.git","svn_url":"https://github.com/Simperfit/symfony","homepage":"symfony.com","size":101809,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"a522e04255f5055fe41338f752101305d020a986","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-11-06T12:56:44Z","pushed_at":"2017-11-06T14:07:44Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":106010,"stargazers_count":15503,"watchers_count":15503,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5790,"mirror_url":null,"archived":false,"open_issues_count":813,"forks":5790,"open_issues":813,"watchers":15503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24751"},"html":{"href":"https://github.com/symfony/symfony/pull/24751"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/24751"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/24751/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24751/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/24751/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/f4d35b6827ab3f85365c004f373323ccbca06034"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xabbuh"}}