{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/19272","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/19272/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/19272/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/19272/events","html_url":"https://github.com/mantidproject/mantid/pull/19272","id":218268914,"number":19272,"title":"LoadFITS Improved Memory usage and removed LoadAsRectangle property","user":{"login":"DimitarTasev","id":9135965,"avatar_url":"https://avatars0.githubusercontent.com/u/9135965?v=3","gravatar_id":"","url":"https://api.github.com/users/DimitarTasev","html_url":"https://github.com/DimitarTasev","followers_url":"https://api.github.com/users/DimitarTasev/followers","following_url":"https://api.github.com/users/DimitarTasev/following{/other_user}","gists_url":"https://api.github.com/users/DimitarTasev/gists{/gist_id}","starred_url":"https://api.github.com/users/DimitarTasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimitarTasev/subscriptions","organizations_url":"https://api.github.com/users/DimitarTasev/orgs","repos_url":"https://api.github.com/users/DimitarTasev/repos","events_url":"https://api.github.com/users/DimitarTasev/events{/privacy}","received_events_url":"https://api.github.com/users/DimitarTasev/received_events","type":"User","site_admin":false},"labels":[{"id":177607615,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800","default":false},{"id":40046083,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"AnthonyLim23","id":25006392,"avatar_url":"https://avatars0.githubusercontent.com/u/25006392?v=3","gravatar_id":"","url":"https://api.github.com/users/AnthonyLim23","html_url":"https://github.com/AnthonyLim23","followers_url":"https://api.github.com/users/AnthonyLim23/followers","following_url":"https://api.github.com/users/AnthonyLim23/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyLim23/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyLim23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyLim23/subscriptions","organizations_url":"https://api.github.com/users/AnthonyLim23/orgs","repos_url":"https://api.github.com/users/AnthonyLim23/repos","events_url":"https://api.github.com/users/AnthonyLim23/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyLim23/received_events","type":"User","site_admin":false},"assignees":[{"login":"AnthonyLim23","id":25006392,"avatar_url":"https://avatars0.githubusercontent.com/u/25006392?v=3","gravatar_id":"","url":"https://api.github.com/users/AnthonyLim23","html_url":"https://github.com/AnthonyLim23","followers_url":"https://api.github.com/users/AnthonyLim23/followers","following_url":"https://api.github.com/users/AnthonyLim23/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyLim23/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyLim23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyLim23/subscriptions","organizations_url":"https://api.github.com/users/AnthonyLim23/orgs","repos_url":"https://api.github.com/users/AnthonyLim23/repos","events_url":"https://api.github.com/users/AnthonyLim23/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyLim23/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/61","html_url":"https://github.com/mantidproject/mantid/milestone/61","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/61/labels","id":2064897,"number":61,"title":"Release 3.10","description":"","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars2.githubusercontent.com/u/1017173?v=3","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":242,"closed_issues":489,"state":"open","created_at":"2016-10-12T13:14:59Z","updated_at":"2017-04-10T10:06:35Z","due_on":"2017-06-12T07:00:00Z","closed_at":null},"comments":0,"created_at":"2017-03-30T17:23:21Z","updated_at":"2017-04-10T10:29:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/19272","html_url":"https://github.com/mantidproject/mantid/pull/19272","diff_url":"https://github.com/mantidproject/mantid/pull/19272.diff","patch_url":"https://github.com/mantidproject/mantid/pull/19272.patch"},"body":"Description of work.\r\nThis makes `LoadFITS` use the `sharedX` and `sharedE` HistogramData functionality to greatly reduce the memory consumption.\r\n\r\nAdditionally this PR hides the property for `LoadAsRectangle` because a single 16MB image was loaded into a 7GB workspace. No fix was added for that as `LoadFITS` might be deprecated and removed soon.\r\n![16mb_image_2minutes_7gigs](https://cloud.githubusercontent.com/assets/9135965/24514456/46d8fb16-156c-11e7-969c-19752b4b537e.jpg)\r\n \r\n\r\n**To test:**\r\n- Run LoadFITS test\r\n- Try loading a Fits image, here are a few: https://drive.google.com/open?id=0B2Mj8e56Z8xTNTZRV1NuSWs5QVU\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #18242.\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/292911280","html_url":"https://github.com/mantidproject/mantid/pull/19272#issuecomment-292911280","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/19272","id":292911280,"user":{"login":"AnthonyLim23","id":25006392,"avatar_url":"https://avatars0.githubusercontent.com/u/25006392?v=3","gravatar_id":"","url":"https://api.github.com/users/AnthonyLim23","html_url":"https://github.com/AnthonyLim23","followers_url":"https://api.github.com/users/AnthonyLim23/followers","following_url":"https://api.github.com/users/AnthonyLim23/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyLim23/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyLim23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyLim23/subscriptions","organizations_url":"https://api.github.com/users/AnthonyLim23/orgs","repos_url":"https://api.github.com/users/AnthonyLim23/repos","events_url":"https://api.github.com/users/AnthonyLim23/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyLim23/received_events","type":"User","site_admin":false},"created_at":"2017-04-10T10:29:35Z","updated_at":"2017-04-10T10:29:35Z","body":"I have used the loadFITS algorithm and had no problems loading the data provided. However, the performance test fails (unhandled exception) "}}
{"actor":{"display_login":"AnthonyLim23"}}