{"action":"closed","number":14455,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14455","id":120014591,"html_url":"https://github.com/ethereum/go-ethereum/pull/14455","diff_url":"https://github.com/ethereum/go-ethereum/pull/14455.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/14455.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/14455","number":14455,"state":"closed","locked":false,"title":"core: fix golint nits","user":{"login":"tooooolong","id":1023347,"avatar_url":"https://avatars2.githubusercontent.com/u/1023347?v=3","gravatar_id":"","url":"https://api.github.com/users/tooooolong","html_url":"https://github.com/tooooolong","followers_url":"https://api.github.com/users/tooooolong/followers","following_url":"https://api.github.com/users/tooooolong/following{/other_user}","gists_url":"https://api.github.com/users/tooooolong/gists{/gist_id}","starred_url":"https://api.github.com/users/tooooolong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tooooolong/subscriptions","organizations_url":"https://api.github.com/users/tooooolong/orgs","repos_url":"https://api.github.com/users/tooooolong/repos","events_url":"https://api.github.com/users/tooooolong/events{/privacy}","received_events_url":"https://api.github.com/users/tooooolong/received_events","type":"User","site_admin":false},"body":"Hi guys:\r\n\r\nI'm learning the code of go-ethereum.\r\nAnd I use `golint` to lint the code, then found some mistakes.\r\n\r\n### What changes\r\n\r\n1. fix typos\r\n2. methods recevier of struct should be same and should not use `self` keywords\r\n3. comments improve\r\n\r\nThere are many warning of comments, can you guys help to improve the comments.\r\n\r\nmost of warning is like this\r\n```\r\ncore/state/state_object.go:33:6: exported type Code should have comment or be unexported\r\ncore/state/state_object.go:35:1: receiver name should be a reflection of its identity; don't use generic names such as \"this\" or \"self\"\r\n```\r\n\r\n### How to represent\r\n```\r\ngolint ./... | grep -v vendor\r\n```\r\n\r\n\r\n\r\n\r\n","created_at":"2017-05-11T02:19:42Z","updated_at":"2017-05-25T14:25:17Z","closed_at":"2017-05-25T14:25:16Z","merged_at":null,"merge_commit_sha":"71712bff945fbc4f2ce721872d81a971ff2d045b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fjl","id":6915,"avatar_url":"https://avatars3.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/49","html_url":"https://github.com/ethereum/go-ethereum/milestone/49","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/49/labels","id":2499578,"number":49,"title":"1.6.2","description":"","creator":{"login":"karalabe","id":129561,"avatar_url":"https://avatars1.githubusercontent.com/u/129561?v=3","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":27,"state":"open","created_at":"2017-05-04T10:41:43Z","updated_at":"2017-05-25T14:25:16Z","due_on":"2017-05-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14455/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14455/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/14455/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/7b6f14158f4bebf8cbd0b1c81c2ada10754a8674","head":{"label":"tooooolong:master","ref":"master","sha":"7b6f14158f4bebf8cbd0b1c81c2ada10754a8674","user":{"login":"tooooolong","id":1023347,"avatar_url":"https://avatars2.githubusercontent.com/u/1023347?v=3","gravatar_id":"","url":"https://api.github.com/users/tooooolong","html_url":"https://github.com/tooooolong","followers_url":"https://api.github.com/users/tooooolong/followers","following_url":"https://api.github.com/users/tooooolong/following{/other_user}","gists_url":"https://api.github.com/users/tooooolong/gists{/gist_id}","starred_url":"https://api.github.com/users/tooooolong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tooooolong/subscriptions","organizations_url":"https://api.github.com/users/tooooolong/orgs","repos_url":"https://api.github.com/users/tooooolong/repos","events_url":"https://api.github.com/users/tooooolong/events{/privacy}","received_events_url":"https://api.github.com/users/tooooolong/received_events","type":"User","site_admin":false},"repo":{"id":90851339,"name":"go-ethereum","full_name":"tooooolong/go-ethereum","owner":{"login":"tooooolong","id":1023347,"avatar_url":"https://avatars2.githubusercontent.com/u/1023347?v=3","gravatar_id":"","url":"https://api.github.com/users/tooooolong","html_url":"https://github.com/tooooolong","followers_url":"https://api.github.com/users/tooooolong/followers","following_url":"https://api.github.com/users/tooooolong/following{/other_user}","gists_url":"https://api.github.com/users/tooooolong/gists{/gist_id}","starred_url":"https://api.github.com/users/tooooolong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tooooolong/subscriptions","organizations_url":"https://api.github.com/users/tooooolong/orgs","repos_url":"https://api.github.com/users/tooooolong/repos","events_url":"https://api.github.com/users/tooooolong/events{/privacy}","received_events_url":"https://api.github.com/users/tooooolong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tooooolong/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/tooooolong/go-ethereum","forks_url":"https://api.github.com/repos/tooooolong/go-ethereum/forks","keys_url":"https://api.github.com/repos/tooooolong/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tooooolong/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tooooolong/go-ethereum/teams","hooks_url":"https://api.github.com/repos/tooooolong/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/tooooolong/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/tooooolong/go-ethereum/events","assignees_url":"https://api.github.com/repos/tooooolong/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/tooooolong/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/tooooolong/go-ethereum/tags","blobs_url":"https://api.github.com/repos/tooooolong/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tooooolong/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tooooolong/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/tooooolong/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tooooolong/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/tooooolong/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/tooooolong/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/tooooolong/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/tooooolong/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/tooooolong/go-ethereum/subscription","commits_url":"https://api.github.com/repos/tooooolong/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/tooooolong/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/tooooolong/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/tooooolong/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/tooooolong/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/tooooolong/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tooooolong/go-ethereum/merges","archive_url":"https://api.github.com/repos/tooooolong/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tooooolong/go-ethereum/downloads","issues_url":"https://api.github.com/repos/tooooolong/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/tooooolong/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/tooooolong/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/tooooolong/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tooooolong/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/tooooolong/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/tooooolong/go-ethereum/deployments","created_at":"2017-05-10T10:20:01Z","updated_at":"2017-05-10T10:20:10Z","pushed_at":"2017-05-22T07:00:47Z","git_url":"git://github.com/tooooolong/go-ethereum.git","ssh_url":"git@github.com:tooooolong/go-ethereum.git","clone_url":"https://github.com/tooooolong/go-ethereum.git","svn_url":"https://github.com/tooooolong/go-ethereum","homepage":"https://geth.ethereum.org","size":86130,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"2a41e76b39f8279400e42f3e0dc45f55457e2cff","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2017-05-25T14:17:14Z","pushed_at":"2017-05-25T14:24:00Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":86222,"stargazers_count":4179,"watchers_count":4179,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1399,"mirror_url":null,"open_issues_count":342,"forks":1399,"open_issues":342,"watchers":4179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14455"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/14455"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/14455"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/14455/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14455/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14455/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/7b6f14158f4bebf8cbd0b1c81c2ada10754a8674"}},"merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":5,"maintainer_can_modify":false,"commits":2,"additions":324,"deletions":323,"changed_files":11}}
{"actor":{"display_login":"karalabe"}}