{"action":"created","comment":{"url":"https://api.github.com/repos/windingtree/LifToken/pulls/comments/137795683","pull_request_review_id":61511927,"id":137795683,"diff_hunk":"@@ -255,9 +255,10 @@ contract LifCrowdsale is Ownable, Pausable {\n \n       // TODO: create the market maker with a start block that equals one month after crowdsale ends\n       LifMarketMaker newMarketMaker = new LifMarketMaker(\n-        address(token), block.number.add(10), 20, marketMakerPeriods, foundationWallet\n+        address(token), block.timestamp.add(10), 30 days, marketMakerPeriods, foundationWallet\n       );\n       newMarketMaker.fund.value(mmFundBalance)();\n+      newMarketMaker.transferOwnership(foundationWallet);","path":"contracts/LifCrowdsale.sol","position":8,"original_position":8,"commit_id":"78a85bcedf7469d43bf01040679f4aa59f8d82fb","original_commit_id":"b2530598b3b56e056ac4ce058409842dc03ae5a1","user":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"body":"https://github.com/windingtree/LifToken/pull/170/commits/6009468216dc50346998a680bcb8bd27df6ea87b here  is the commit, but you are right, the assert is missing.","created_at":"2017-09-08T13:52:25Z","updated_at":"2017-09-08T13:52:25Z","html_url":"https://github.com/windingtree/LifToken/pull/170#discussion_r137795683","pull_request_url":"https://api.github.com/repos/windingtree/LifToken/pulls/170","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/comments/137795683"},"html":{"href":"https://github.com/windingtree/LifToken/pull/170#discussion_r137795683"},"pull_request":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/170"}},"in_reply_to_id":137541842},"pull_request":{"url":"https://api.github.com/repos/windingtree/LifToken/pulls/170","id":139803061,"html_url":"https://github.com/windingtree/LifToken/pull/170","diff_url":"https://github.com/windingtree/LifToken/pull/170.diff","patch_url":"https://github.com/windingtree/LifToken/pull/170.patch","issue_url":"https://api.github.com/repos/windingtree/LifToken/issues/170","number":170,"state":"open","locked":false,"title":"WIP Using timestamps on MarketMaker","user":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"body":"Changing the use of blocks for timestamps on Market maker and his tests, also testing the market maker after being created by a successful crowdsale.","created_at":"2017-09-07T13:20:04Z","updated_at":"2017-09-08T13:52:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"164846030c76e58bdc51fbe7ba81f79a30199413","assignee":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"assignees":[{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/windingtree/LifToken/pulls/170/commits","review_comments_url":"https://api.github.com/repos/windingtree/LifToken/pulls/170/comments","review_comment_url":"https://api.github.com/repos/windingtree/LifToken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windingtree/LifToken/issues/170/comments","statuses_url":"https://api.github.com/repos/windingtree/LifToken/statuses/78a85bcedf7469d43bf01040679f4aa59f8d82fb","head":{"label":"AugustoL:timestamps-marketmaker","ref":"timestamps-marketmaker","sha":"78a85bcedf7469d43bf01040679f4aa59f8d82fb","user":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"repo":{"id":76576781,"name":"LifToken","full_name":"AugustoL/LifToken","owner":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AugustoL/LifToken","description":"Líf is the token for the Winding Tree platform","fork":true,"url":"https://api.github.com/repos/AugustoL/LifToken","forks_url":"https://api.github.com/repos/AugustoL/LifToken/forks","keys_url":"https://api.github.com/repos/AugustoL/LifToken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugustoL/LifToken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugustoL/LifToken/teams","hooks_url":"https://api.github.com/repos/AugustoL/LifToken/hooks","issue_events_url":"https://api.github.com/repos/AugustoL/LifToken/issues/events{/number}","events_url":"https://api.github.com/repos/AugustoL/LifToken/events","assignees_url":"https://api.github.com/repos/AugustoL/LifToken/assignees{/user}","branches_url":"https://api.github.com/repos/AugustoL/LifToken/branches{/branch}","tags_url":"https://api.github.com/repos/AugustoL/LifToken/tags","blobs_url":"https://api.github.com/repos/AugustoL/LifToken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugustoL/LifToken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugustoL/LifToken/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugustoL/LifToken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugustoL/LifToken/statuses/{sha}","languages_url":"https://api.github.com/repos/AugustoL/LifToken/languages","stargazers_url":"https://api.github.com/repos/AugustoL/LifToken/stargazers","contributors_url":"https://api.github.com/repos/AugustoL/LifToken/contributors","subscribers_url":"https://api.github.com/repos/AugustoL/LifToken/subscribers","subscription_url":"https://api.github.com/repos/AugustoL/LifToken/subscription","commits_url":"https://api.github.com/repos/AugustoL/LifToken/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugustoL/LifToken/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugustoL/LifToken/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugustoL/LifToken/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugustoL/LifToken/contents/{+path}","compare_url":"https://api.github.com/repos/AugustoL/LifToken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugustoL/LifToken/merges","archive_url":"https://api.github.com/repos/AugustoL/LifToken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugustoL/LifToken/downloads","issues_url":"https://api.github.com/repos/AugustoL/LifToken/issues{/number}","pulls_url":"https://api.github.com/repos/AugustoL/LifToken/pulls{/number}","milestones_url":"https://api.github.com/repos/AugustoL/LifToken/milestones{/number}","notifications_url":"https://api.github.com/repos/AugustoL/LifToken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugustoL/LifToken/labels{/name}","releases_url":"https://api.github.com/repos/AugustoL/LifToken/releases{/id}","deployments_url":"https://api.github.com/repos/AugustoL/LifToken/deployments","created_at":"2016-12-15T16:31:35Z","updated_at":"2016-12-15T16:31:37Z","pushed_at":"2017-09-08T12:39:45Z","git_url":"git://github.com/AugustoL/LifToken.git","ssh_url":"git@github.com:AugustoL/LifToken.git","clone_url":"https://github.com/AugustoL/LifToken.git","svn_url":"https://github.com/AugustoL/LifToken","homepage":"","size":567,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windingtree:master","ref":"master","sha":"2f91eabb2a59de2cd1479bda2050f3ec04d13a26","user":{"login":"windingtree","id":22484548,"avatar_url":"https://avatars2.githubusercontent.com/u/22484548?v=4","gravatar_id":"","url":"https://api.github.com/users/windingtree","html_url":"https://github.com/windingtree","followers_url":"https://api.github.com/users/windingtree/followers","following_url":"https://api.github.com/users/windingtree/following{/other_user}","gists_url":"https://api.github.com/users/windingtree/gists{/gist_id}","starred_url":"https://api.github.com/users/windingtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windingtree/subscriptions","organizations_url":"https://api.github.com/users/windingtree/orgs","repos_url":"https://api.github.com/users/windingtree/repos","events_url":"https://api.github.com/users/windingtree/events{/privacy}","received_events_url":"https://api.github.com/users/windingtree/received_events","type":"Organization","site_admin":false},"repo":{"id":75439674,"name":"LifToken","full_name":"windingtree/LifToken","owner":{"login":"windingtree","id":22484548,"avatar_url":"https://avatars2.githubusercontent.com/u/22484548?v=4","gravatar_id":"","url":"https://api.github.com/users/windingtree","html_url":"https://github.com/windingtree","followers_url":"https://api.github.com/users/windingtree/followers","following_url":"https://api.github.com/users/windingtree/following{/other_user}","gists_url":"https://api.github.com/users/windingtree/gists{/gist_id}","starred_url":"https://api.github.com/users/windingtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windingtree/subscriptions","organizations_url":"https://api.github.com/users/windingtree/orgs","repos_url":"https://api.github.com/users/windingtree/repos","events_url":"https://api.github.com/users/windingtree/events{/privacy}","received_events_url":"https://api.github.com/users/windingtree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windingtree/LifToken","description":"Líf is the token for the Winding Tree platform","fork":false,"url":"https://api.github.com/repos/windingtree/LifToken","forks_url":"https://api.github.com/repos/windingtree/LifToken/forks","keys_url":"https://api.github.com/repos/windingtree/LifToken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windingtree/LifToken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windingtree/LifToken/teams","hooks_url":"https://api.github.com/repos/windingtree/LifToken/hooks","issue_events_url":"https://api.github.com/repos/windingtree/LifToken/issues/events{/number}","events_url":"https://api.github.com/repos/windingtree/LifToken/events","assignees_url":"https://api.github.com/repos/windingtree/LifToken/assignees{/user}","branches_url":"https://api.github.com/repos/windingtree/LifToken/branches{/branch}","tags_url":"https://api.github.com/repos/windingtree/LifToken/tags","blobs_url":"https://api.github.com/repos/windingtree/LifToken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windingtree/LifToken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windingtree/LifToken/git/refs{/sha}","trees_url":"https://api.github.com/repos/windingtree/LifToken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windingtree/LifToken/statuses/{sha}","languages_url":"https://api.github.com/repos/windingtree/LifToken/languages","stargazers_url":"https://api.github.com/repos/windingtree/LifToken/stargazers","contributors_url":"https://api.github.com/repos/windingtree/LifToken/contributors","subscribers_url":"https://api.github.com/repos/windingtree/LifToken/subscribers","subscription_url":"https://api.github.com/repos/windingtree/LifToken/subscription","commits_url":"https://api.github.com/repos/windingtree/LifToken/commits{/sha}","git_commits_url":"https://api.github.com/repos/windingtree/LifToken/git/commits{/sha}","comments_url":"https://api.github.com/repos/windingtree/LifToken/comments{/number}","issue_comment_url":"https://api.github.com/repos/windingtree/LifToken/issues/comments{/number}","contents_url":"https://api.github.com/repos/windingtree/LifToken/contents/{+path}","compare_url":"https://api.github.com/repos/windingtree/LifToken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windingtree/LifToken/merges","archive_url":"https://api.github.com/repos/windingtree/LifToken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windingtree/LifToken/downloads","issues_url":"https://api.github.com/repos/windingtree/LifToken/issues{/number}","pulls_url":"https://api.github.com/repos/windingtree/LifToken/pulls{/number}","milestones_url":"https://api.github.com/repos/windingtree/LifToken/milestones{/number}","notifications_url":"https://api.github.com/repos/windingtree/LifToken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windingtree/LifToken/labels{/name}","releases_url":"https://api.github.com/repos/windingtree/LifToken/releases{/id}","deployments_url":"https://api.github.com/repos/windingtree/LifToken/deployments","created_at":"2016-12-02T23:41:12Z","updated_at":"2017-09-05T17:56:58Z","pushed_at":"2017-09-08T13:47:30Z","git_url":"git://github.com/windingtree/LifToken.git","ssh_url":"git@github.com:windingtree/LifToken.git","clone_url":"https://github.com/windingtree/LifToken.git","svn_url":"https://github.com/windingtree/LifToken","homepage":"","size":515,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":11,"forks":5,"open_issues":11,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/170"},"html":{"href":"https://github.com/windingtree/LifToken/pull/170"},"issue":{"href":"https://api.github.com/repos/windingtree/LifToken/issues/170"},"comments":{"href":"https://api.github.com/repos/windingtree/LifToken/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/windingtree/LifToken/statuses/78a85bcedf7469d43bf01040679f4aa59f8d82fb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"AugustoL"}}