{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/111990676","pull_request_review_id":33271572,"id":111990676,"diff_hunk":"@@ -386,23 +388,17 @@ private function isCodeUpgrade() {\n \t * @throws \\Exception\n \t */\n \tprivate function upgradeAppStoreApps(array $disabledApps) {\n-\n-\t\t//\n-\t\t// TODO: integrate market app in here\n-\t\t//\n-\n-//\t\tforeach($disabledApps as $app) {\n-//\t\t\ttry {\n-//\t\t\t\tif (Installer::isUpdateAvailable($app)) {\n-//\t\t\t\t\t$ocsId = \\OC::$server->getConfig()->getAppValue($app, 'ocsid', '');\n-//\n-//\t\t\t\t\t$this->emit('\\OC\\Updater', 'upgradeAppStoreApp', [$app]);","path":"lib/private/Updater.php","position":24,"original_position":24,"commit_id":"f29ba56ea846df7ce7e77e7deb5e9aca11784313","original_commit_id":"f29ba56ea846df7ce7e77e7deb5e9aca11784313","user":{"login":"VicDeo","id":991300,"avatar_url":"https://avatars2.githubusercontent.com/u/991300?v=3","gravatar_id":"","url":"https://api.github.com/users/VicDeo","html_url":"https://github.com/VicDeo","followers_url":"https://api.github.com/users/VicDeo/followers","following_url":"https://api.github.com/users/VicDeo/following{/other_user}","gists_url":"https://api.github.com/users/VicDeo/gists{/gist_id}","starred_url":"https://api.github.com/users/VicDeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VicDeo/subscriptions","organizations_url":"https://api.github.com/users/VicDeo/orgs","repos_url":"https://api.github.com/users/VicDeo/repos","events_url":"https://api.github.com/users/VicDeo/events{/privacy}","received_events_url":"https://api.github.com/users/VicDeo/received_events","type":"User","site_admin":false},"body":"@PVince81 it was not me, who commented that out. IIRC it was commented when app management part was stripped from core\r\n","created_at":"2017-04-18T15:48:13Z","updated_at":"2017-04-18T15:48:13Z","html_url":"https://github.com/owncloud/core/pull/27648#discussion_r111990676","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/27648","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/111990676"},"html":{"href":"https://github.com/owncloud/core/pull/27648#discussion_r111990676"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/27648"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/27648","id":116213649,"html_url":"https://github.com/owncloud/core/pull/27648","diff_url":"https://github.com/owncloud/core/pull/27648.diff","patch_url":"https://github.com/owncloud/core/pull/27648.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/27648","number":27648,"state":"open","locked":false,"title":"[WIP] Dispatch upgradeAppStoreApps event","user":{"login":"VicDeo","id":991300,"avatar_url":"https://avatars2.githubusercontent.com/u/991300?v=3","gravatar_id":"","url":"https://api.github.com/users/VicDeo","html_url":"https://github.com/VicDeo","followers_url":"https://api.github.com/users/VicDeo/followers","following_url":"https://api.github.com/users/VicDeo/following{/other_user}","gists_url":"https://api.github.com/users/VicDeo/gists{/gist_id}","starred_url":"https://api.github.com/users/VicDeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VicDeo/subscriptions","organizations_url":"https://api.github.com/users/VicDeo/orgs","repos_url":"https://api.github.com/users/VicDeo/repos","events_url":"https://api.github.com/users/VicDeo/events{/privacy}","received_events_url":"https://api.github.com/users/VicDeo/received_events","type":"User","site_admin":false},"body":"\r\n\r\n","created_at":"2017-04-17T22:11:40Z","updated_at":"2017-04-18T15:48:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8895f444fe6f3d40dd1c7887dc0ecd460741c2d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/27648/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/27648/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/27648/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/f29ba56ea846df7ce7e77e7deb5e9aca11784313","head":{"label":"owncloud:update-from-market","ref":"update-from-market","sha":"f29ba56ea846df7ce7e77e7deb5e9aca11784313","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars0.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars0.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2017-04-18T09:17:15Z","pushed_at":"2017-04-18T15:11:51Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":222072,"stargazers_count":5216,"watchers_count":5216,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1681,"mirror_url":null,"open_issues_count":1615,"forks":1681,"open_issues":1615,"watchers":5216,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"58808cbd09cc250dae3e16a1f8d4a000c3b2b88b","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars0.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars0.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2017-04-18T09:17:15Z","pushed_at":"2017-04-18T15:11:51Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":222072,"stargazers_count":5216,"watchers_count":5216,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1681,"mirror_url":null,"open_issues_count":1615,"forks":1681,"open_issues":1615,"watchers":5216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/27648"},"html":{"href":"https://github.com/owncloud/core/pull/27648"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/27648"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/27648/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/27648/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/27648/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/f29ba56ea846df7ce7e77e7deb5e9aca11784313"}}}}
{"actor":{"display_login":"VicDeo"}}