{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/105450714","pull_request_review_id":26336085,"id":105450714,"diff_hunk":"@@ -916,9 +918,9 @@ namespace Microsoft.FSharp.Text.StructuredFormat\n             match c with ","path":"src/utils/sformat.fs","position":21,"original_position":21,"commit_id":"3afb2f8f19c95daed55710141b5825e0bac25163","original_commit_id":"3afb2f8f19c95daed55710141b5825e0bac25163","user":{"login":"saul","id":64654,"avatar_url":"https://avatars0.githubusercontent.com/u/64654?v=3","gravatar_id":"","url":"https://api.github.com/users/saul","html_url":"https://github.com/saul","followers_url":"https://api.github.com/users/saul/followers","following_url":"https://api.github.com/users/saul/following{/other_user}","gists_url":"https://api.github.com/users/saul/gists{/gist_id}","starred_url":"https://api.github.com/users/saul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saul/subscriptions","organizations_url":"https://api.github.com/users/saul/orgs","repos_url":"https://api.github.com/users/saul/repos","events_url":"https://api.github.com/users/saul/events{/privacy}","received_events_url":"https://api.github.com/users/saul/received_events","type":"User","site_admin":false},"body":"Am I right in saying that F# files are parsed as UTF-8? In which case I don't think we need to escape anything else other than what's there already.","created_at":"2017-03-10T17:51:08Z","updated_at":"2017-03-10T17:51:08Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/2558#discussion_r105450714","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/105450714"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/2558#discussion_r105450714"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558","id":109794936,"html_url":"https://github.com/Microsoft/visualfsharp/pull/2558","diff_url":"https://github.com/Microsoft/visualfsharp/pull/2558.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/2558.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2558","number":2558,"state":"open","locked":false,"title":"[WIP] Add flag to the %A printf specifier that escapes control characters","user":{"login":"saul","id":64654,"avatar_url":"https://avatars0.githubusercontent.com/u/64654?v=3","gravatar_id":"","url":"https://api.github.com/users/saul","html_url":"https://github.com/saul","followers_url":"https://api.github.com/users/saul/followers","following_url":"https://api.github.com/users/saul/following{/other_user}","gists_url":"https://api.github.com/users/saul/gists{/gist_id}","starred_url":"https://api.github.com/users/saul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saul/subscriptions","organizations_url":"https://api.github.com/users/saul/orgs","repos_url":"https://api.github.com/users/saul/repos","events_url":"https://api.github.com/users/saul/events{/privacy}","received_events_url":"https://api.github.com/users/saul/received_events","type":"User","site_admin":false},"body":"This PR adds a flag to the %A format specifier: @. This flag escapes control characters and other characters that need to be escaped in F# source code string literals.\r\n\r\n### Before\r\n\r\n![image](https://cloud.githubusercontent.com/assets/64654/23726130/11c62926-044b-11e7-9be6-e259e1f54e4f.png)\r\n\r\n### After\r\n\r\n![image](https://cloud.githubusercontent.com/assets/64654/23773464/37b97e90-0517-11e7-8239-4ce6a4c4eff3.png)\r\n\r\n---\r\n\r\nThis allows us to directly copy strings that have been formatted with %@A straight into code - and they'll 'just work'.\r\n\r\n### Remaining work:\r\n\r\n- [ ] Print strings with %@A as verbatim strings if they are 'path like' (i.e only contain backslashes as their escaped characters)\r\n- [ ] Fix current tests\r\n- [ ] Write test showing that %A throws with any flags other than %+A and %@A (and a combination of the two)\r\n- [ ] Write test showing that FSI outputs the 'it' variable as %@A by default","created_at":"2017-03-08T22:05:01Z","updated_at":"2017-03-10T17:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fd892bab55f1671a1afbfaa3d17ced2a72350f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2558/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/3afb2f8f19c95daed55710141b5825e0bac25163","head":{"label":"saul:escape-percent-a-strings","ref":"escape-percent-a-strings","sha":"3afb2f8f19c95daed55710141b5825e0bac25163","user":{"login":"saul","id":64654,"avatar_url":"https://avatars0.githubusercontent.com/u/64654?v=3","gravatar_id":"","url":"https://api.github.com/users/saul","html_url":"https://github.com/saul","followers_url":"https://api.github.com/users/saul/followers","following_url":"https://api.github.com/users/saul/following{/other_user}","gists_url":"https://api.github.com/users/saul/gists{/gist_id}","starred_url":"https://api.github.com/users/saul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saul/subscriptions","organizations_url":"https://api.github.com/users/saul/orgs","repos_url":"https://api.github.com/users/saul/repos","events_url":"https://api.github.com/users/saul/events{/privacy}","received_events_url":"https://api.github.com/users/saul/received_events","type":"User","site_admin":false},"repo":{"id":76793436,"name":"visualfsharp","full_name":"saul/visualfsharp","owner":{"login":"saul","id":64654,"avatar_url":"https://avatars0.githubusercontent.com/u/64654?v=3","gravatar_id":"","url":"https://api.github.com/users/saul","html_url":"https://github.com/saul","followers_url":"https://api.github.com/users/saul/followers","following_url":"https://api.github.com/users/saul/following{/other_user}","gists_url":"https://api.github.com/users/saul/gists{/gist_id}","starred_url":"https://api.github.com/users/saul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saul/subscriptions","organizations_url":"https://api.github.com/users/saul/orgs","repos_url":"https://api.github.com/users/saul/repos","events_url":"https://api.github.com/users/saul/events{/privacy}","received_events_url":"https://api.github.com/users/saul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saul/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/saul/visualfsharp","forks_url":"https://api.github.com/repos/saul/visualfsharp/forks","keys_url":"https://api.github.com/repos/saul/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saul/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saul/visualfsharp/teams","hooks_url":"https://api.github.com/repos/saul/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/saul/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/saul/visualfsharp/events","assignees_url":"https://api.github.com/repos/saul/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/saul/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/saul/visualfsharp/tags","blobs_url":"https://api.github.com/repos/saul/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saul/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saul/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/saul/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saul/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/saul/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/saul/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/saul/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/saul/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/saul/visualfsharp/subscription","commits_url":"https://api.github.com/repos/saul/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/saul/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/saul/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/saul/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/saul/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/saul/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saul/visualfsharp/merges","archive_url":"https://api.github.com/repos/saul/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saul/visualfsharp/downloads","issues_url":"https://api.github.com/repos/saul/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/saul/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/saul/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/saul/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saul/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/saul/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/saul/visualfsharp/deployments","created_at":"2016-12-18T16:21:08Z","updated_at":"2016-12-30T19:41:14Z","pushed_at":"2017-03-09T22:33:03Z","git_url":"git://github.com/saul/visualfsharp.git","ssh_url":"git@github.com:saul/visualfsharp.git","clone_url":"https://github.com/saul/visualfsharp.git","svn_url":"https://github.com/saul/visualfsharp","homepage":null,"size":83713,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"66123c8c162c058c4cf63c6e5ade2b7fabc88bce","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/visualfsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2017-03-10T16:36:16Z","pushed_at":"2017-03-10T17:34:14Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":85307,"stargazers_count":949,"watchers_count":949,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"open_issues_count":380,"forks":241,"open_issues":380,"watchers":949,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/2558"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2558"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2558/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2558/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/3afb2f8f19c95daed55710141b5825e0bac25163"}}}}
{"actor":{"display_login":"saul"}}