{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/comments/118836834","pull_request_review_id":40668044,"id":118836834,"diff_hunk":"@@ -81,7 +83,7 @@\n  * \n  * @author Kohsuke Kawaguchi\n  */\n-@Mojo(name=\"run\")\n+@Mojo(name=\"run\", requiresDependencyResolution=ResolutionScope.TEST)","path":"src/main/java/org/jenkinsci/maven/plugins/hpi/RunMojo.java","position":21,"original_position":21,"commit_id":"b24720608dd0e1253b5af57bd31331a27a07a5ce","original_commit_id":"55a05a6d514d8a0d96972be452601935da43cf0c","user":{"login":"stephenc","id":209336,"avatar_url":"https://avatars1.githubusercontent.com/u/209336?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenc","html_url":"https://github.com/stephenc","followers_url":"https://api.github.com/users/stephenc/followers","following_url":"https://api.github.com/users/stephenc/following{/other_user}","gists_url":"https://api.github.com/users/stephenc/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenc/subscriptions","organizations_url":"https://api.github.com/users/stephenc/orgs","repos_url":"https://api.github.com/users/stephenc/repos","events_url":"https://api.github.com/users/stephenc/events{/privacy}","received_events_url":"https://api.github.com/users/stephenc/received_events","type":"User","site_admin":false},"body":"I think *something* is attaching artifacts to the reactor and then they get wiped by clean and the re-attach is appending to the list, not replacing... does it happen with Maven 3.2.x?","created_at":"2017-05-28T09:21:27Z","updated_at":"2017-05-28T09:21:28Z","html_url":"https://github.com/jenkinsci/maven-hpi-plugin/pull/63#discussion_r118836834","pull_request_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/comments/118836834"},"html":{"href":"https://github.com/jenkinsci/maven-hpi-plugin/pull/63#discussion_r118836834"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63","id":122024839,"html_url":"https://github.com/jenkinsci/maven-hpi-plugin/pull/63","diff_url":"https://github.com/jenkinsci/maven-hpi-plugin/pull/63.diff","patch_url":"https://github.com/jenkinsci/maven-hpi-plugin/pull/63.patch","issue_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/issues/63","number":63,"state":"open","locked":false,"title":"Fix some exceptions breaking `mvn clean hpi:run`","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars2.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Observed in `workflow-job-plugin@master`, using 2.29 parent, that `mvn clean hpi:run` (with no `package` in between, for example) would fail with\r\n\r\n```\r\njava.lang.NullPointerException\r\n\tat org.jenkinsci.maven.plugins.hpi.MavenArtifact.getActualArtifactId(MavenArtifact.java:146)\r\n\tat org.jenkinsci.maven.plugins.hpi.RunMojo.execute(RunMojo.java:333)\r\n\tat org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)\r\n```\r\n\r\nFixed that and then got another exception:\r\n\r\n```\r\njava.lang.NullPointerException\r\n\tat org.jenkinsci.maven.plugins.hpi.RunMojo.configureWebApplication(RunMojo.java:460)\r\n\tat org.jenkinsci.maven.plugins.hpi.AbstractJettyMojo.startJetty(AbstractJettyMojo.java:502)\r\n```\r\n\r\nThe second fix makes it work. Perhaps there is a simpler solution.\r\n\r\n@reviewbybees","created_at":"2017-05-23T15:16:42Z","updated_at":"2017-05-28T09:21:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55463cfc756ab9055147739b7d5ed1853a70d227","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stephenc","id":209336,"avatar_url":"https://avatars1.githubusercontent.com/u/209336?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenc","html_url":"https://github.com/stephenc","followers_url":"https://api.github.com/users/stephenc/followers","following_url":"https://api.github.com/users/stephenc/following{/other_user}","gists_url":"https://api.github.com/users/stephenc/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenc/subscriptions","organizations_url":"https://api.github.com/users/stephenc/orgs","repos_url":"https://api.github.com/users/stephenc/repos","events_url":"https://api.github.com/users/stephenc/events{/privacy}","received_events_url":"https://api.github.com/users/stephenc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/issues/63/comments","statuses_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/statuses/b24720608dd0e1253b5af57bd31331a27a07a5ce","head":{"label":"jglick:NPE","ref":"NPE","sha":"b24720608dd0e1253b5af57bd31331a27a07a5ce","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars2.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":13629555,"name":"maven-hpi-plugin","full_name":"jglick/maven-hpi-plugin","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars2.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/maven-hpi-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/jglick/maven-hpi-plugin","forks_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/forks","keys_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/teams","hooks_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/hooks","issue_events_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/events","assignees_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/tags","blobs_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/languages","stargazers_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/stargazers","contributors_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/contributors","subscribers_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/subscribers","subscription_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/subscription","commits_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/merges","archive_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/downloads","issues_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jglick/maven-hpi-plugin/deployments","created_at":"2013-10-16T19:52:21Z","updated_at":"2013-10-16T19:52:36Z","pushed_at":"2017-05-25T13:56:04Z","git_url":"git://github.com/jglick/maven-hpi-plugin.git","ssh_url":"git@github.com:jglick/maven-hpi-plugin.git","clone_url":"https://github.com/jglick/maven-hpi-plugin.git","svn_url":"https://github.com/jglick/maven-hpi-plugin","homepage":"http://jenkins-ci.org/","size":799,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"c50d4966ae281918ee97e0b64392f291f6409dce","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1159471,"name":"maven-hpi-plugin","full_name":"jenkinsci/maven-hpi-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/maven-hpi-plugin","description":"Maven plugin for building Jenkins plugins","fork":false,"url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin","forks_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/deployments","created_at":"2010-12-11T20:09:28Z","updated_at":"2017-05-01T17:48:48Z","pushed_at":"2017-05-27T16:52:50Z","git_url":"git://github.com/jenkinsci/maven-hpi-plugin.git","ssh_url":"git@github.com:jenkinsci/maven-hpi-plugin.git","clone_url":"https://github.com/jenkinsci/maven-hpi-plugin.git","svn_url":"https://github.com/jenkinsci/maven-hpi-plugin","homepage":"http://jenkins-ci.org/maven-hpi-plugin","size":1633,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":51,"mirror_url":null,"open_issues_count":11,"forks":51,"open_issues":11,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63"},"html":{"href":"https://github.com/jenkinsci/maven-hpi-plugin/pull/63"},"issue":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/issues/63"},"comments":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/maven-hpi-plugin/statuses/b24720608dd0e1253b5af57bd31331a27a07a5ce"}}}}
{"actor":{"display_login":"stephenc"}}