{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/15425","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/15425/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/15425/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/15425/events","html_url":"https://github.com/nodejs/node/issues/15425","id":258000729,"number":15425,"title":"Add `#ifdef O_DSYNC`","user":{"login":"jorangreef","id":413206,"avatar_url":"https://avatars0.githubusercontent.com/u/413206?v=4","gravatar_id":"","url":"https://api.github.com/users/jorangreef","html_url":"https://github.com/jorangreef","followers_url":"https://api.github.com/users/jorangreef/followers","following_url":"https://api.github.com/users/jorangreef/following{/other_user}","gists_url":"https://api.github.com/users/jorangreef/gists{/gist_id}","starred_url":"https://api.github.com/users/jorangreef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorangreef/subscriptions","organizations_url":"https://api.github.com/users/jorangreef/orgs","repos_url":"https://api.github.com/users/jorangreef/repos","events_url":"https://api.github.com/users/jorangreef/events{/privacy}","received_events_url":"https://api.github.com/users/jorangreef/received_events","type":"User","site_admin":false},"labels":[{"id":207445406,"url":"https://api.github.com/repos/nodejs/node/labels/feature%20request","name":"feature request","color":"0D7BDE","default":false},{"id":155435785,"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":202120392,"url":"https://api.github.com/repos/nodejs/node/labels/good%20first%20contribution","name":"good first contribution","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-15T10:49:43Z","updated_at":"2017-09-16T09:29:15Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"`node_constants.cc` exports `O_SYNC` on Linux, but `O_DSYNC` should probably be added."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/329957437","html_url":"https://github.com/nodejs/node/issues/15425#issuecomment-329957437","issue_url":"https://api.github.com/repos/nodejs/node/issues/15425","id":329957437,"user":{"login":"jrasanen","id":13303,"avatar_url":"https://avatars3.githubusercontent.com/u/13303?v=4","gravatar_id":"","url":"https://api.github.com/users/jrasanen","html_url":"https://github.com/jrasanen","followers_url":"https://api.github.com/users/jrasanen/followers","following_url":"https://api.github.com/users/jrasanen/following{/other_user}","gists_url":"https://api.github.com/users/jrasanen/gists{/gist_id}","starred_url":"https://api.github.com/users/jrasanen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrasanen/subscriptions","organizations_url":"https://api.github.com/users/jrasanen/orgs","repos_url":"https://api.github.com/users/jrasanen/repos","events_url":"https://api.github.com/users/jrasanen/events{/privacy}","received_events_url":"https://api.github.com/users/jrasanen/received_events","type":"User","site_admin":false},"created_at":"2017-09-16T09:29:15Z","updated_at":"2017-09-16T09:29:15Z","author_association":"NONE","body":"How would one write a test cast for O_DSYNC being on?\r\n\r\nI made the changes and verified the code using strace,\r\n\r\n```bash\r\n$ sudo strace -e trace=open -f ./node write_cats_to_tmp.js\r\n[pid  9226] open(\"/vagrant/node/write_cats_to_tmp.js\", O_RDONLY|O_CLOEXEC) = 12\r\nWrote to /tmp/cats.tmp\r\n[pid  9232] open(\"/tmp/cats.tmp\", O_WRONLY|O_CREAT|O_TRUNC|O_DSYNC|O_CLOEXEC, 0666) = 12\r\nWriting to file\r\nWrote 9 bytes\r\n```"}}
{"actor":{"display_login":"jrasanen"}}