{"action":"created","issue":{"url":"https://api.github.com/repos/neos/flow-development-collection/issues/926","repository_url":"https://api.github.com/repos/neos/flow-development-collection","labels_url":"https://api.github.com/repos/neos/flow-development-collection/issues/926/labels{/name}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/926/comments","events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/926/events","html_url":"https://github.com/neos/flow-development-collection/pull/926","id":218984177,"number":926,"title":"BUGFIX: PersistenceManager correctly checks and reattempts lost connections","user":{"login":"albe","id":4259532,"avatar_url":"https://avatars2.githubusercontent.com/u/4259532?v=3","gravatar_id":"","url":"https://api.github.com/users/albe","html_url":"https://github.com/albe","followers_url":"https://api.github.com/users/albe/followers","following_url":"https://api.github.com/users/albe/following{/other_user}","gists_url":"https://api.github.com/users/albe/gists{/gist_id}","starred_url":"https://api.github.com/users/albe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albe/subscriptions","organizations_url":"https://api.github.com/users/albe/orgs","repos_url":"https://api.github.com/users/albe/repos","events_url":"https://api.github.com/users/albe/events{/privacy}","received_events_url":"https://api.github.com/users/albe/received_events","type":"User","site_admin":false},"labels":[{"id":274949220,"url":"https://api.github.com/repos/neos/flow-development-collection/labels/P:%20Flow","name":"P: Flow","color":"0052cc","default":false},{"id":274949018,"url":"https://api.github.com/repos/neos/flow-development-collection/labels/T:%20Database","name":"T: Database","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-03T16:09:23Z","updated_at":"2017-04-13T07:00:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/926","html_url":"https://github.com/neos/flow-development-collection/pull/926","diff_url":"https://github.com/neos/flow-development-collection/pull/926.diff","patch_url":"https://github.com/neos/flow-development-collection/pull/926.patch"},"body":"This change replaces the previously put in place try/catch attempt at handling lost connections\r\nwith a proper explicit call to the doctrine connection's `ping()` method.\r\nAs a side-effect, this will no longer trigger the `AllObjectsPersisted` signal if flushing fails, however\r\nthis is not really breaking, since in those circumstances, the application is supposed to not do any\r\nfurther work anyway.\r\n\r\nFixes #870\r\n\r\nThis is a follow-up to #921 - see discussion there.\r\n\r\nTODO:\r\n- [ ] adjust tests"},"comment":{"url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments/293809123","html_url":"https://github.com/neos/flow-development-collection/pull/926#issuecomment-293809123","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/926","id":293809123,"user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars1.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"created_at":"2017-04-13T07:00:08Z","updated_at":"2017-04-13T07:00:08Z","body":"It _does_ make more sense, at least \"at first sight\". The reason why we added the `try/catch` is to prevent nasty to debug errors due to timeouts in long-running processes, if I remember correctly.\r\n\r\nThe change that originally introduced this is: https://github.com/jasinai/flow-development-collection/commit/93b458812493f23c89d6ef8815acbe4d57b53256 - so maybe we should check back with Martin whether the new version still works with him - or check with the Doctrine folks what they would recommend"}}
{"actor":{"display_login":"bwaidelich"}}