{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17990","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17990/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17990/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17990/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17990","id":242490087,"number":17990,"title":"update react-native so styles can be arrays","user":{"login":"dannycochran","id":1217178,"avatar_url":"https://avatars2.githubusercontent.com/u/1217178?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycochran","html_url":"https://github.com/dannycochran","followers_url":"https://api.github.com/users/dannycochran/followers","following_url":"https://api.github.com/users/dannycochran/following{/other_user}","gists_url":"https://api.github.com/users/dannycochran/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycochran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycochran/subscriptions","organizations_url":"https://api.github.com/users/dannycochran/orgs","repos_url":"https://api.github.com/users/dannycochran/repos","events_url":"https://api.github.com/users/dannycochran/events{/privacy}","received_events_url":"https://api.github.com/users/dannycochran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-12T19:31:50Z","updated_at":"2017-07-12T20:35:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/17990","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17990","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17990.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17990.patch"},"body":"1) apply the ViewStyleProp to all components\r\n2) abstract a TextStyle prop and use it wherever appropriate\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [ ] The package does not provide its own types, and you can not add them.\r\n- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [ ] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [ ] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, and `strictNullChecks` set to `true`.\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://facebook.github.io/react-native/docs/view.html#style\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nIf removing a declaration:\r\n- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)\r\n- [ ] Delete the package's directory.\r\n- [ ] Add it to `notNeededPackages.json`.\r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/314888808","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17990#issuecomment-314888808","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/17990","id":314888808,"user":{"login":"iRoachie","id":5962998,"avatar_url":"https://avatars1.githubusercontent.com/u/5962998?v=3","gravatar_id":"","url":"https://api.github.com/users/iRoachie","html_url":"https://github.com/iRoachie","followers_url":"https://api.github.com/users/iRoachie/followers","following_url":"https://api.github.com/users/iRoachie/following{/other_user}","gists_url":"https://api.github.com/users/iRoachie/gists{/gist_id}","starred_url":"https://api.github.com/users/iRoachie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iRoachie/subscriptions","organizations_url":"https://api.github.com/users/iRoachie/orgs","repos_url":"https://api.github.com/users/iRoachie/repos","events_url":"https://api.github.com/users/iRoachie/events{/privacy}","received_events_url":"https://api.github.com/users/iRoachie/received_events","type":"User","site_admin":false},"created_at":"2017-07-12T20:35:27Z","updated_at":"2017-07-12T20:35:27Z","body":"I really don't like that implementation, it's very redundant, Why not just make a generic?\r\n\r\n`type StyleProp<T> = T | Array<T> | undefined`\r\n\r\nThen just pass in whatever.\r\n\r\n`style: StyleProp<TextStyle>`\r\n"}}
{"actor":{"display_login":"iRoachie"}}