{"action":"opened","number":5583,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/5583","id":115760448,"html_url":"https://github.com/minetest/minetest/pull/5583","diff_url":"https://github.com/minetest/minetest/pull/5583.diff","patch_url":"https://github.com/minetest/minetest/pull/5583.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/5583","number":5583,"state":"open","locked":false,"title":"Sort box corners correctly","user":{"login":"Thomas--S","id":7414098,"avatar_url":"https://avatars1.githubusercontent.com/u/7414098?v=3","gravatar_id":"","url":"https://api.github.com/users/Thomas--S","html_url":"https://github.com/Thomas--S","followers_url":"https://api.github.com/users/Thomas--S/followers","following_url":"https://api.github.com/users/Thomas--S/following{/other_user}","gists_url":"https://api.github.com/users/Thomas--S/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas--S/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas--S/subscriptions","organizations_url":"https://api.github.com/users/Thomas--S/orgs","repos_url":"https://api.github.com/users/Thomas--S/repos","events_url":"https://api.github.com/users/Thomas--S/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas--S/received_events","type":"User","site_admin":false},"body":"Replaces #5574\r\n\r\nI have tested this briefly and it seems to work.\r\n\r\nHowever, this needs a good review by someone who is familiar with C++ and the minetest code.\r\n\r\nThanks to @SmallJoker for pointing out where this change should happen.","created_at":"2017-04-13T13:47:40Z","updated_at":"2017-04-13T13:47:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/5583/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/5583/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/5583/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/f4681918681c2a1496179272fb9dc8f5a130715a","head":{"label":"Thomas--S:box_sorting","ref":"box_sorting","sha":"f4681918681c2a1496179272fb9dc8f5a130715a","user":{"login":"Thomas--S","id":7414098,"avatar_url":"https://avatars1.githubusercontent.com/u/7414098?v=3","gravatar_id":"","url":"https://api.github.com/users/Thomas--S","html_url":"https://github.com/Thomas--S","followers_url":"https://api.github.com/users/Thomas--S/followers","following_url":"https://api.github.com/users/Thomas--S/following{/other_user}","gists_url":"https://api.github.com/users/Thomas--S/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas--S/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas--S/subscriptions","organizations_url":"https://api.github.com/users/Thomas--S/orgs","repos_url":"https://api.github.com/users/Thomas--S/repos","events_url":"https://api.github.com/users/Thomas--S/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas--S/received_events","type":"User","site_admin":false},"repo":{"id":62458031,"name":"minetest","full_name":"Thomas--S/minetest","owner":{"login":"Thomas--S","id":7414098,"avatar_url":"https://avatars1.githubusercontent.com/u/7414098?v=3","gravatar_id":"","url":"https://api.github.com/users/Thomas--S","html_url":"https://github.com/Thomas--S","followers_url":"https://api.github.com/users/Thomas--S/followers","following_url":"https://api.github.com/users/Thomas--S/following{/other_user}","gists_url":"https://api.github.com/users/Thomas--S/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas--S/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas--S/subscriptions","organizations_url":"https://api.github.com/users/Thomas--S/orgs","repos_url":"https://api.github.com/users/Thomas--S/repos","events_url":"https://api.github.com/users/Thomas--S/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas--S/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thomas--S/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/Thomas--S/minetest","forks_url":"https://api.github.com/repos/Thomas--S/minetest/forks","keys_url":"https://api.github.com/repos/Thomas--S/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thomas--S/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thomas--S/minetest/teams","hooks_url":"https://api.github.com/repos/Thomas--S/minetest/hooks","issue_events_url":"https://api.github.com/repos/Thomas--S/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/Thomas--S/minetest/events","assignees_url":"https://api.github.com/repos/Thomas--S/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/Thomas--S/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/Thomas--S/minetest/tags","blobs_url":"https://api.github.com/repos/Thomas--S/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thomas--S/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thomas--S/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thomas--S/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thomas--S/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/Thomas--S/minetest/languages","stargazers_url":"https://api.github.com/repos/Thomas--S/minetest/stargazers","contributors_url":"https://api.github.com/repos/Thomas--S/minetest/contributors","subscribers_url":"https://api.github.com/repos/Thomas--S/minetest/subscribers","subscription_url":"https://api.github.com/repos/Thomas--S/minetest/subscription","commits_url":"https://api.github.com/repos/Thomas--S/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thomas--S/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thomas--S/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thomas--S/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thomas--S/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/Thomas--S/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thomas--S/minetest/merges","archive_url":"https://api.github.com/repos/Thomas--S/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thomas--S/minetest/downloads","issues_url":"https://api.github.com/repos/Thomas--S/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/Thomas--S/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/Thomas--S/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/Thomas--S/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thomas--S/minetest/labels{/name}","releases_url":"https://api.github.com/repos/Thomas--S/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/Thomas--S/minetest/deployments","created_at":"2016-07-02T15:44:28Z","updated_at":"2016-07-02T15:44:32Z","pushed_at":"2017-04-13T13:45:24Z","git_url":"git://github.com/Thomas--S/minetest.git","ssh_url":"git@github.com:Thomas--S/minetest.git","clone_url":"https://github.com/Thomas--S/minetest.git","svn_url":"https://github.com/Thomas--S/minetest","homepage":"http://minetest.net/","size":47325,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"021e667511658fdafcece72315f0f71bb26c6c68","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars2.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars2.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2017-04-13T06:02:06Z","pushed_at":"2017-04-13T12:04:20Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":47174,"stargazers_count":2492,"watchers_count":2492,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":760,"mirror_url":null,"open_issues_count":1040,"forks":760,"open_issues":1040,"watchers":2492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/5583"},"html":{"href":"https://github.com/minetest/minetest/pull/5583"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/5583"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/5583/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/5583/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/5583/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/f4681918681c2a1496179272fb9dc8f5a130715a"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Thomas--S"}}