{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments/137646741","pull_request_review_id":61340758,"id":137646741,"diff_hunk":"@@ -0,0 +1,104 @@\n+// Copyright 2017 The etcd-operator Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package backupstorage\n+\n+import (\n+\t\"path\"\n+\n+\tbackupabs \"github.com/coreos/etcd-operator/pkg/backup/abs\"\n+\t\"github.com/coreos/etcd-operator/pkg/backup/abs/absconfig\"\n+\t\"github.com/coreos/etcd-operator/pkg/spec\"\n+\n+\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+\t\"k8s.io/client-go/kubernetes\"\n+)\n+\n+type abs struct {\n+\tabsconfig.ABSContext","path":"pkg/cluster/backupstorage/abs.go","position":29,"original_position":29,"commit_id":"3d45d08285101f508ea27120271d7c1f68866a49","original_commit_id":"3d45d08285101f508ea27120271d7c1f68866a49","user":{"login":"fanminshi","id":4983345,"avatar_url":"https://avatars3.githubusercontent.com/u/4983345?v=4","gravatar_id":"","url":"https://api.github.com/users/fanminshi","html_url":"https://github.com/fanminshi","followers_url":"https://api.github.com/users/fanminshi/followers","following_url":"https://api.github.com/users/fanminshi/following{/other_user}","gists_url":"https://api.github.com/users/fanminshi/gists{/gist_id}","starred_url":"https://api.github.com/users/fanminshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanminshi/subscriptions","organizations_url":"https://api.github.com/users/fanminshi/orgs","repos_url":"https://api.github.com/users/fanminshi/repos","events_url":"https://api.github.com/users/fanminshi/events{/privacy}","received_events_url":"https://api.github.com/users/fanminshi/received_events","type":"User","site_admin":false},"body":"I don't think `absconfig.ABSContext` is needed.","created_at":"2017-09-07T20:27:06Z","updated_at":"2017-09-07T20:30:44Z","html_url":"https://github.com/coreos/etcd-operator/pull/1376#discussion_r137646741","pull_request_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments/137646741"},"html":{"href":"https://github.com/coreos/etcd-operator/pull/1376#discussion_r137646741"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376","id":138555466,"html_url":"https://github.com/coreos/etcd-operator/pull/1376","diff_url":"https://github.com/coreos/etcd-operator/pull/1376.diff","patch_url":"https://github.com/coreos/etcd-operator/pull/1376.patch","issue_url":"https://api.github.com/repos/coreos/etcd-operator/issues/1376","number":1376,"state":"open","locked":false,"title":"feat(abs): add operator logic","user":{"login":"vdice","id":9322017,"avatar_url":"https://avatars3.githubusercontent.com/u/9322017?v=4","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"body":"(Re-issue of https://github.com/coreos/etcd-operator/pull/1369)\r\n\r\nTODO:\r\n - [x] Revise approach on passing storage credentials to pod (currently uses non-thread-safe `os.Setenv()`)","created_at":"2017-08-31T00:10:23Z","updated_at":"2017-09-07T20:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"004fe1c84c7c19f184a3647ba62bf3254f8f2e6a","assignee":{"login":"fanminshi","id":4983345,"avatar_url":"https://avatars3.githubusercontent.com/u/4983345?v=4","gravatar_id":"","url":"https://api.github.com/users/fanminshi","html_url":"https://github.com/fanminshi","followers_url":"https://api.github.com/users/fanminshi/followers","following_url":"https://api.github.com/users/fanminshi/following{/other_user}","gists_url":"https://api.github.com/users/fanminshi/gists{/gist_id}","starred_url":"https://api.github.com/users/fanminshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanminshi/subscriptions","organizations_url":"https://api.github.com/users/fanminshi/orgs","repos_url":"https://api.github.com/users/fanminshi/repos","events_url":"https://api.github.com/users/fanminshi/events{/privacy}","received_events_url":"https://api.github.com/users/fanminshi/received_events","type":"User","site_admin":false},"assignees":[{"login":"fanminshi","id":4983345,"avatar_url":"https://avatars3.githubusercontent.com/u/4983345?v=4","gravatar_id":"","url":"https://api.github.com/users/fanminshi","html_url":"https://github.com/fanminshi","followers_url":"https://api.github.com/users/fanminshi/followers","following_url":"https://api.github.com/users/fanminshi/following{/other_user}","gists_url":"https://api.github.com/users/fanminshi/gists{/gist_id}","starred_url":"https://api.github.com/users/fanminshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanminshi/subscriptions","organizations_url":"https://api.github.com/users/fanminshi/orgs","repos_url":"https://api.github.com/users/fanminshi/repos","events_url":"https://api.github.com/users/fanminshi/events{/privacy}","received_events_url":"https://api.github.com/users/fanminshi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd-operator/issues/1376/comments","statuses_url":"https://api.github.com/repos/coreos/etcd-operator/statuses/3d45d08285101f508ea27120271d7c1f68866a49","head":{"label":"vdice:feat/abs/operator-logic","ref":"feat/abs/operator-logic","sha":"3d45d08285101f508ea27120271d7c1f68866a49","user":{"login":"vdice","id":9322017,"avatar_url":"https://avatars3.githubusercontent.com/u/9322017?v=4","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"repo":{"id":95467737,"name":"etcd-operator","full_name":"vdice/etcd-operator","owner":{"login":"vdice","id":9322017,"avatar_url":"https://avatars3.githubusercontent.com/u/9322017?v=4","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdice/etcd-operator","description":"etcd operator creates/configures/manages etcd clusters atop Kubernetes","fork":true,"url":"https://api.github.com/repos/vdice/etcd-operator","forks_url":"https://api.github.com/repos/vdice/etcd-operator/forks","keys_url":"https://api.github.com/repos/vdice/etcd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdice/etcd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdice/etcd-operator/teams","hooks_url":"https://api.github.com/repos/vdice/etcd-operator/hooks","issue_events_url":"https://api.github.com/repos/vdice/etcd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/vdice/etcd-operator/events","assignees_url":"https://api.github.com/repos/vdice/etcd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/vdice/etcd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/vdice/etcd-operator/tags","blobs_url":"https://api.github.com/repos/vdice/etcd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdice/etcd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdice/etcd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdice/etcd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdice/etcd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/vdice/etcd-operator/languages","stargazers_url":"https://api.github.com/repos/vdice/etcd-operator/stargazers","contributors_url":"https://api.github.com/repos/vdice/etcd-operator/contributors","subscribers_url":"https://api.github.com/repos/vdice/etcd-operator/subscribers","subscription_url":"https://api.github.com/repos/vdice/etcd-operator/subscription","commits_url":"https://api.github.com/repos/vdice/etcd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdice/etcd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdice/etcd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdice/etcd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdice/etcd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/vdice/etcd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdice/etcd-operator/merges","archive_url":"https://api.github.com/repos/vdice/etcd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdice/etcd-operator/downloads","issues_url":"https://api.github.com/repos/vdice/etcd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/vdice/etcd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/vdice/etcd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/vdice/etcd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdice/etcd-operator/labels{/name}","releases_url":"https://api.github.com/repos/vdice/etcd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/vdice/etcd-operator/deployments","created_at":"2017-06-26T16:40:58Z","updated_at":"2017-06-26T16:41:00Z","pushed_at":"2017-09-06T22:08:05Z","git_url":"git://github.com/vdice/etcd-operator.git","ssh_url":"git@github.com:vdice/etcd-operator.git","clone_url":"https://github.com/vdice/etcd-operator.git","svn_url":"https://github.com/vdice/etcd-operator","homepage":"https://coreos.com/blog/introducing-the-etcd-operator.html","size":2240,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"409350bb716023ea19f14813c56126c6b37927e1","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":64974719,"name":"etcd-operator","full_name":"coreos/etcd-operator","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd-operator","description":"etcd operator creates/configures/manages etcd clusters atop Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/etcd-operator","forks_url":"https://api.github.com/repos/coreos/etcd-operator/forks","keys_url":"https://api.github.com/repos/coreos/etcd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd-operator/teams","hooks_url":"https://api.github.com/repos/coreos/etcd-operator/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd-operator/events","assignees_url":"https://api.github.com/repos/coreos/etcd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd-operator/tags","blobs_url":"https://api.github.com/repos/coreos/etcd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd-operator/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd-operator/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd-operator/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd-operator/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd-operator/subscription","commits_url":"https://api.github.com/repos/coreos/etcd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd-operator/merges","archive_url":"https://api.github.com/repos/coreos/etcd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd-operator/downloads","issues_url":"https://api.github.com/repos/coreos/etcd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd-operator/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd-operator/deployments","created_at":"2016-08-04T23:54:58Z","updated_at":"2017-09-07T11:45:14Z","pushed_at":"2017-09-07T20:08:08Z","git_url":"git://github.com/coreos/etcd-operator.git","ssh_url":"git@github.com:coreos/etcd-operator.git","clone_url":"https://github.com/coreos/etcd-operator.git","svn_url":"https://github.com/coreos/etcd-operator","homepage":"https://coreos.com/blog/introducing-the-etcd-operator.html","size":2211,"stargazers_count":382,"watchers_count":382,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":84,"forks":104,"open_issues":84,"watchers":382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376"},"html":{"href":"https://github.com/coreos/etcd-operator/pull/1376"},"issue":{"href":"https://api.github.com/repos/coreos/etcd-operator/issues/1376"},"comments":{"href":"https://api.github.com/repos/coreos/etcd-operator/issues/1376/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1376/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd-operator/statuses/3d45d08285101f508ea27120271d7c1f68866a49"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fanminshi"}}