{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/1601","repository_url":"https://api.github.com/repos/dotnet/roslyn-project-system","labels_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/1601/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/1601/comments","events_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/1601/events","html_url":"https://github.com/dotnet/roslyn-project-system/pull/1601","id":209631984,"number":1601,"title":"Ensure that the LangaugeServiceHost is initialized when attempting to…","user":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars.githubusercontent.com/u/10605811?v=3","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"labels":[{"id":370752484,"url":"https://api.github.com/repos/dotnet/roslyn-project-system/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-23T01:10:11Z","updated_at":"2017-02-24T00:26:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/1601","html_url":"https://github.com/dotnet/roslyn-project-system/pull/1601","diff_url":"https://github.com/dotnet/roslyn-project-system/pull/1601.diff","patch_url":"https://github.com/dotnet/roslyn-project-system/pull/1601.patch"},"body":"… fetch the contained langauge factory for a venus file.\r\n\r\n**Customer scenario**\r\n\r\nUser opens a cshtml file while the project is still loading and this causes broken intellisense/language service for the project.\r\n\r\n**Bugs this fixes:**\r\n\r\nFixes #1617\r\n\r\n**Workarounds, if any**\r\n\r\nUsers need to close and re-open the solution.\r\n\r\n**Risk**\r\n\r\nLow risk.\r\nThis is a race condition where we are attempting to get the contained language factory before our language service host has been initialized. The fix is to ensure that we explicitly await langauge service host initialization at the beginning of GetContainedLanguageFactoryForFile.\r\n\r\n**Performance impact**\r\n\r\nLow\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nYes. Seems like this race condition has been exposed by some of our recent changes, though the race has existed in the code base since the initial implementation\r\n\r\n**Root cause analysis:**\r\n\r\nNoted above.\r\n\r\n**How was the bug found?**\r\n\r\nAutomated tests."},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/comments/282166187","html_url":"https://github.com/dotnet/roslyn-project-system/pull/1601#issuecomment-282166187","issue_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/1601","id":282166187,"user":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars.githubusercontent.com/u/10605811?v=3","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"created_at":"2017-02-24T00:26:52Z","updated_at":"2017-02-24T00:26:52Z","body":"Tagging @Pilchie @srivatsn to take to the Dev15 shiproom. Kevin, I will forward you the email thread with informal approval from Joc."}}
{"actor":{"display_login":"mavasani"}}