{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/drud/build-tools/pulls/21","id":118322072,"html_url":"https://github.com/drud/build-tools/pull/21","diff_url":"https://github.com/drud/build-tools/pull/21.diff","patch_url":"https://github.com/drud/build-tools/pull/21.patch","issue_url":"https://api.github.com/repos/drud/build-tools/issues/21","number":21,"state":"closed","locked":false,"title":"Add buildinfo date/context to standard build","user":{"login":"rfay","id":112444,"avatar_url":"https://avatars1.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"body":"## The Problem:\r\n\r\nIt would be nice to know explicit information about *commit* and *build date/time/context* from an actual executable.  \r\n\r\nNote that currently version.VERSION *can* be the commit, but it's overridden by $(VERSION), which makes things a bit untraceable when you use `make VERSION=something`, so this makes the commit explicit.\r\n\r\n## The Fix:\r\n\r\nAdd these items to build-tools.\r\n\r\n## The Test:\r\n\r\nTesting is added to TestBuild for these\r\n\r\n## Automation Overview:\r\n<!-- Please provide an overview of tests introduced by this PR, or an explanation for why no tests are needed. -->\r\n\r\n## Related Issue Link(s):\r\n\r\n## Release/Deployment notes:\r\nDoes this affect anything else, or are there ramifications for other code? Does anything have to be done on deployment?\r\n\r\n* If the `make test` target is overridden in build-tools, it may need to have double-quotes changed to single-quotes around the LDFLAGS, as in the Makefile in tests here. For example:  `go test -v -installsuffix \"static\" -ldflags '$(LDFLAGS)' $(SRC_AND_UNDER) $(TESTARGS)`\r\n* To make use of version.BUILDINFO and version.COMMIT, those variables must be added to the pkg/version/version.go in the target executable.\r\n","created_at":"2017-04-30T18:41:10Z","updated_at":"2017-05-01T15:18:41Z","closed_at":"2017-05-01T15:18:41Z","merged_at":"2017-05-01T15:18:40Z","merge_commit_sha":"8e7d62f28eb4b2f3257a96e82aabb1c04e9f6c86","assignee":{"login":"rfay","id":112444,"avatar_url":"https://avatars1.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"assignees":[{"login":"rfay","id":112444,"avatar_url":"https://avatars1.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/drud/build-tools/pulls/21/commits","review_comments_url":"https://api.github.com/repos/drud/build-tools/pulls/21/comments","review_comment_url":"https://api.github.com/repos/drud/build-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drud/build-tools/issues/21/comments","statuses_url":"https://api.github.com/repos/drud/build-tools/statuses/e454173a078ba5c97a1c93d94404fd1d31a4fc92","head":{"label":"rfay:20170430_add_compile_info","ref":"20170430_add_compile_info","sha":"e454173a078ba5c97a1c93d94404fd1d31a4fc92","user":{"login":"rfay","id":112444,"avatar_url":"https://avatars1.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"repo":{"id":80379594,"name":"build-tools","full_name":"rfay/build-tools","owner":{"login":"rfay","id":112444,"avatar_url":"https://avatars1.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfay/build-tools","description":"Build tools added via subtree merge to other projects for standard approach to building","fork":true,"url":"https://api.github.com/repos/rfay/build-tools","forks_url":"https://api.github.com/repos/rfay/build-tools/forks","keys_url":"https://api.github.com/repos/rfay/build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfay/build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfay/build-tools/teams","hooks_url":"https://api.github.com/repos/rfay/build-tools/hooks","issue_events_url":"https://api.github.com/repos/rfay/build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/rfay/build-tools/events","assignees_url":"https://api.github.com/repos/rfay/build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/rfay/build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/rfay/build-tools/tags","blobs_url":"https://api.github.com/repos/rfay/build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfay/build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfay/build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfay/build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfay/build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/rfay/build-tools/languages","stargazers_url":"https://api.github.com/repos/rfay/build-tools/stargazers","contributors_url":"https://api.github.com/repos/rfay/build-tools/contributors","subscribers_url":"https://api.github.com/repos/rfay/build-tools/subscribers","subscription_url":"https://api.github.com/repos/rfay/build-tools/subscription","commits_url":"https://api.github.com/repos/rfay/build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfay/build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfay/build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfay/build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfay/build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/rfay/build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfay/build-tools/merges","archive_url":"https://api.github.com/repos/rfay/build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfay/build-tools/downloads","issues_url":"https://api.github.com/repos/rfay/build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/rfay/build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/rfay/build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/rfay/build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfay/build-tools/labels{/name}","releases_url":"https://api.github.com/repos/rfay/build-tools/releases{/id}","deployments_url":"https://api.github.com/repos/rfay/build-tools/deployments","created_at":"2017-01-29T23:13:40Z","updated_at":"2017-01-29T23:13:41Z","pushed_at":"2017-05-01T15:18:18Z","git_url":"git://github.com/rfay/build-tools.git","ssh_url":"git@github.com:rfay/build-tools.git","clone_url":"https://github.com/rfay/build-tools.git","svn_url":"https://github.com/rfay/build-tools","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drud:master","ref":"master","sha":"febaea74b01b7c789ba78bf3f1318e1c3492876f","user":{"login":"drud","id":8115114,"avatar_url":"https://avatars1.githubusercontent.com/u/8115114?v=3","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"repo":{"id":80360973,"name":"build-tools","full_name":"drud/build-tools","owner":{"login":"drud","id":8115114,"avatar_url":"https://avatars1.githubusercontent.com/u/8115114?v=3","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drud/build-tools","description":"Build tools added via subtree merge to other projects for standard approach to building","fork":false,"url":"https://api.github.com/repos/drud/build-tools","forks_url":"https://api.github.com/repos/drud/build-tools/forks","keys_url":"https://api.github.com/repos/drud/build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drud/build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drud/build-tools/teams","hooks_url":"https://api.github.com/repos/drud/build-tools/hooks","issue_events_url":"https://api.github.com/repos/drud/build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/drud/build-tools/events","assignees_url":"https://api.github.com/repos/drud/build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/drud/build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/drud/build-tools/tags","blobs_url":"https://api.github.com/repos/drud/build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drud/build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drud/build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/drud/build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drud/build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/drud/build-tools/languages","stargazers_url":"https://api.github.com/repos/drud/build-tools/stargazers","contributors_url":"https://api.github.com/repos/drud/build-tools/contributors","subscribers_url":"https://api.github.com/repos/drud/build-tools/subscribers","subscription_url":"https://api.github.com/repos/drud/build-tools/subscription","commits_url":"https://api.github.com/repos/drud/build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/drud/build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/drud/build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/drud/build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/drud/build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/drud/build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drud/build-tools/merges","archive_url":"https://api.github.com/repos/drud/build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drud/build-tools/downloads","issues_url":"https://api.github.com/repos/drud/build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/drud/build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/drud/build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/drud/build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drud/build-tools/labels{/name}","releases_url":"https://api.github.com/repos/drud/build-tools/releases{/id}","deployments_url":"https://api.github.com/repos/drud/build-tools/deployments","created_at":"2017-01-29T17:42:56Z","updated_at":"2017-01-31T19:52:03Z","pushed_at":"2017-05-01T15:18:40Z","git_url":"git://github.com/drud/build-tools.git","ssh_url":"git@github.com:drud/build-tools.git","clone_url":"https://github.com/drud/build-tools.git","svn_url":"https://github.com/drud/build-tools","homepage":null,"size":105,"stargazers_count":1,"watchers_count":1,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drud/build-tools/pulls/21"},"html":{"href":"https://github.com/drud/build-tools/pull/21"},"issue":{"href":"https://api.github.com/repos/drud/build-tools/issues/21"},"comments":{"href":"https://api.github.com/repos/drud/build-tools/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/drud/build-tools/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/drud/build-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drud/build-tools/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/drud/build-tools/statuses/e454173a078ba5c97a1c93d94404fd1d31a4fc92"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rfay","id":112444,"avatar_url":"https://avatars1.githubusercontent.com/u/112444?v=3","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":13,"changed_files":6}}
{"actor":{"display_login":"rfay"}}