{"action":"created","comment":{"url":"https://api.github.com/repos/Lickability/PinpointKit/pulls/comments/99413430","pull_request_review_id":20093933,"id":99413430,"diff_hunk":"@@ -47,15 +47,21 @@ final class FeedbackTableViewDataSource: NSObject, UITableViewDataSource {\n     // MARK: - FeedbackTableViewDataSource\n     \n     private static func sectionsFromConfiguration(_ interfaceCustomization: InterfaceCustomization, screenshot: UIImage, logSupporting: LogSupporting, userEnabledLogCollection: Bool) -> [Section] {\n-        guard logSupporting.logCollector != nil else { return [] }\n+        var sections = [Section]()","path":"PinpointKit/PinpointKit/Sources/Core/FeedbackTableViewDataSource.swift","position":5,"original_position":5,"commit_id":"dae538aa6bd5fd0801e7ecad93fb702b31f4ac2a","original_commit_id":"dae538aa6bd5fd0801e7ecad93fb702b31f4ac2a","user":{"login":"mattbischoff","id":14093,"avatar_url":"https://avatars.githubusercontent.com/u/14093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbischoff","html_url":"https://github.com/mattbischoff","followers_url":"https://api.github.com/users/mattbischoff/followers","following_url":"https://api.github.com/users/mattbischoff/following{/other_user}","gists_url":"https://api.github.com/users/mattbischoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbischoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbischoff/subscriptions","organizations_url":"https://api.github.com/users/mattbischoff/orgs","repos_url":"https://api.github.com/users/mattbischoff/repos","events_url":"https://api.github.com/users/mattbischoff/events{/privacy}","received_events_url":"https://api.github.com/users/mattbischoff/received_events","type":"User","site_admin":false},"body":"For some reason I prefer `var sections: [Section] = []` but that might just be me.","created_at":"2017-02-03T20:09:54Z","updated_at":"2017-02-03T20:10:24Z","html_url":"https://github.com/Lickability/PinpointKit/pull/206#discussion_r99413430","pull_request_url":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/Lickability/PinpointKit/pulls/comments/99413430"},"html":{"href":"https://github.com/Lickability/PinpointKit/pull/206#discussion_r99413430"},"pull_request":{"href":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206","id":104602791,"html_url":"https://github.com/Lickability/PinpointKit/pull/206","diff_url":"https://github.com/Lickability/PinpointKit/pull/206.diff","patch_url":"https://github.com/Lickability/PinpointKit/pull/206.patch","issue_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/206","number":206,"state":"open","locked":false,"title":"Hides Default Logging Capabilities on iOS 10+","user":{"login":"mliberatore","id":7883805,"avatar_url":"https://avatars.githubusercontent.com/u/7883805?v=3","gravatar_id":"","url":"https://api.github.com/users/mliberatore","html_url":"https://github.com/mliberatore","followers_url":"https://api.github.com/users/mliberatore/followers","following_url":"https://api.github.com/users/mliberatore/following{/other_user}","gists_url":"https://api.github.com/users/mliberatore/gists{/gist_id}","starred_url":"https://api.github.com/users/mliberatore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mliberatore/subscriptions","organizations_url":"https://api.github.com/users/mliberatore/orgs","repos_url":"https://api.github.com/users/mliberatore/repos","events_url":"https://api.github.com/users/mliberatore/events{/privacy}","received_events_url":"https://api.github.com/users/mliberatore/received_events","type":"User","site_admin":false},"body":"Closes #205.\r\n\r\n## What it Does\r\n\r\nSee description of issue at #205, and the `- warning:` on the initializer in code. This prevents the logging section/cell from displaying on devices that can’t use ASL.\r\n\r\nThe rest of the code to support logging is in place, and if a 3rd-party logging system were used, it could be made to conform to `LogCollector` and replace `SystemLogCollector` via customization.\r\n\r\n## How to Test\r\n\r\n1. Run the Example project on an iOS 9.x device\r\n1. Ensure the logging cell is there, and tapping the accessory button takes you to the log view controller with the test log present.\r\nEnsure that logs.txt is attached to an email when sending feedback.\r\n1. Run the Example project on an iOS 10.0 device\r\n1. Ensure the log cell is not present at all, and no logs.txt i","created_at":"2017-02-03T20:08:45Z","updated_at":"2017-02-03T20:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35a5770f247c69e26fb767553c72a7271d73c775","assignee":{"login":"mattbischoff","id":14093,"avatar_url":"https://avatars.githubusercontent.com/u/14093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbischoff","html_url":"https://github.com/mattbischoff","followers_url":"https://api.github.com/users/mattbischoff/followers","following_url":"https://api.github.com/users/mattbischoff/following{/other_user}","gists_url":"https://api.github.com/users/mattbischoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbischoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbischoff/subscriptions","organizations_url":"https://api.github.com/users/mattbischoff/orgs","repos_url":"https://api.github.com/users/mattbischoff/repos","events_url":"https://api.github.com/users/mattbischoff/events{/privacy}","received_events_url":"https://api.github.com/users/mattbischoff/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattbischoff","id":14093,"avatar_url":"https://avatars.githubusercontent.com/u/14093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbischoff","html_url":"https://github.com/mattbischoff","followers_url":"https://api.github.com/users/mattbischoff/followers","following_url":"https://api.github.com/users/mattbischoff/following{/other_user}","gists_url":"https://api.github.com/users/mattbischoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbischoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbischoff/subscriptions","organizations_url":"https://api.github.com/users/mattbischoff/orgs","repos_url":"https://api.github.com/users/mattbischoff/repos","events_url":"https://api.github.com/users/mattbischoff/events{/privacy}","received_events_url":"https://api.github.com/users/mattbischoff/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206/commits","review_comments_url":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206/comments","review_comment_url":"https://api.github.com/repos/Lickability/PinpointKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/206/comments","statuses_url":"https://api.github.com/repos/Lickability/PinpointKit/statuses/dae538aa6bd5fd0801e7ecad93fb702b31f4ac2a","head":{"label":"Lickability:hides-logging","ref":"hides-logging","sha":"dae538aa6bd5fd0801e7ecad93fb702b31f4ac2a","user":{"login":"Lickability","id":603785,"avatar_url":"https://avatars.githubusercontent.com/u/603785?v=3","gravatar_id":"","url":"https://api.github.com/users/Lickability","html_url":"https://github.com/Lickability","followers_url":"https://api.github.com/users/Lickability/followers","following_url":"https://api.github.com/users/Lickability/following{/other_user}","gists_url":"https://api.github.com/users/Lickability/gists{/gist_id}","starred_url":"https://api.github.com/users/Lickability/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lickability/subscriptions","organizations_url":"https://api.github.com/users/Lickability/orgs","repos_url":"https://api.github.com/users/Lickability/repos","events_url":"https://api.github.com/users/Lickability/events{/privacy}","received_events_url":"https://api.github.com/users/Lickability/received_events","type":"Organization","site_admin":false},"repo":{"id":49381249,"name":"PinpointKit","full_name":"Lickability/PinpointKit","owner":{"login":"Lickability","id":603785,"avatar_url":"https://avatars.githubusercontent.com/u/603785?v=3","gravatar_id":"","url":"https://api.github.com/users/Lickability","html_url":"https://github.com/Lickability","followers_url":"https://api.github.com/users/Lickability/followers","following_url":"https://api.github.com/users/Lickability/following{/other_user}","gists_url":"https://api.github.com/users/Lickability/gists{/gist_id}","starred_url":"https://api.github.com/users/Lickability/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lickability/subscriptions","organizations_url":"https://api.github.com/users/Lickability/orgs","repos_url":"https://api.github.com/users/Lickability/repos","events_url":"https://api.github.com/users/Lickability/events{/privacy}","received_events_url":"https://api.github.com/users/Lickability/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lickability/PinpointKit","description":"Send better feedback","fork":false,"url":"https://api.github.com/repos/Lickability/PinpointKit","forks_url":"https://api.github.com/repos/Lickability/PinpointKit/forks","keys_url":"https://api.github.com/repos/Lickability/PinpointKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lickability/PinpointKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lickability/PinpointKit/teams","hooks_url":"https://api.github.com/repos/Lickability/PinpointKit/hooks","issue_events_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/events{/number}","events_url":"https://api.github.com/repos/Lickability/PinpointKit/events","assignees_url":"https://api.github.com/repos/Lickability/PinpointKit/assignees{/user}","branches_url":"https://api.github.com/repos/Lickability/PinpointKit/branches{/branch}","tags_url":"https://api.github.com/repos/Lickability/PinpointKit/tags","blobs_url":"https://api.github.com/repos/Lickability/PinpointKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lickability/PinpointKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lickability/PinpointKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lickability/PinpointKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lickability/PinpointKit/statuses/{sha}","languages_url":"https://api.github.com/repos/Lickability/PinpointKit/languages","stargazers_url":"https://api.github.com/repos/Lickability/PinpointKit/stargazers","contributors_url":"https://api.github.com/repos/Lickability/PinpointKit/contributors","subscribers_url":"https://api.github.com/repos/Lickability/PinpointKit/subscribers","subscription_url":"https://api.github.com/repos/Lickability/PinpointKit/subscription","commits_url":"https://api.github.com/repos/Lickability/PinpointKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lickability/PinpointKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lickability/PinpointKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lickability/PinpointKit/contents/{+path}","compare_url":"https://api.github.com/repos/Lickability/PinpointKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lickability/PinpointKit/merges","archive_url":"https://api.github.com/repos/Lickability/PinpointKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lickability/PinpointKit/downloads","issues_url":"https://api.github.com/repos/Lickability/PinpointKit/issues{/number}","pulls_url":"https://api.github.com/repos/Lickability/PinpointKit/pulls{/number}","milestones_url":"https://api.github.com/repos/Lickability/PinpointKit/milestones{/number}","notifications_url":"https://api.github.com/repos/Lickability/PinpointKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lickability/PinpointKit/labels{/name}","releases_url":"https://api.github.com/repos/Lickability/PinpointKit/releases{/id}","deployments_url":"https://api.github.com/repos/Lickability/PinpointKit/deployments","created_at":"2016-01-10T19:14:36Z","updated_at":"2017-02-01T17:00:10Z","pushed_at":"2017-02-03T20:08:46Z","git_url":"git://github.com/Lickability/PinpointKit.git","ssh_url":"git@github.com:Lickability/PinpointKit.git","clone_url":"https://github.com/Lickability/PinpointKit.git","svn_url":"https://github.com/Lickability/PinpointKit","homepage":"","size":7124,"stargazers_count":821,"watchers_count":821,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":6,"forks":44,"open_issues":6,"watchers":821,"default_branch":"master"}},"base":{"label":"Lickability:develop","ref":"develop","sha":"5b75e178122886b7bb650c7b9845e40a57f78f1d","user":{"login":"Lickability","id":603785,"avatar_url":"https://avatars.githubusercontent.com/u/603785?v=3","gravatar_id":"","url":"https://api.github.com/users/Lickability","html_url":"https://github.com/Lickability","followers_url":"https://api.github.com/users/Lickability/followers","following_url":"https://api.github.com/users/Lickability/following{/other_user}","gists_url":"https://api.github.com/users/Lickability/gists{/gist_id}","starred_url":"https://api.github.com/users/Lickability/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lickability/subscriptions","organizations_url":"https://api.github.com/users/Lickability/orgs","repos_url":"https://api.github.com/users/Lickability/repos","events_url":"https://api.github.com/users/Lickability/events{/privacy}","received_events_url":"https://api.github.com/users/Lickability/received_events","type":"Organization","site_admin":false},"repo":{"id":49381249,"name":"PinpointKit","full_name":"Lickability/PinpointKit","owner":{"login":"Lickability","id":603785,"avatar_url":"https://avatars.githubusercontent.com/u/603785?v=3","gravatar_id":"","url":"https://api.github.com/users/Lickability","html_url":"https://github.com/Lickability","followers_url":"https://api.github.com/users/Lickability/followers","following_url":"https://api.github.com/users/Lickability/following{/other_user}","gists_url":"https://api.github.com/users/Lickability/gists{/gist_id}","starred_url":"https://api.github.com/users/Lickability/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lickability/subscriptions","organizations_url":"https://api.github.com/users/Lickability/orgs","repos_url":"https://api.github.com/users/Lickability/repos","events_url":"https://api.github.com/users/Lickability/events{/privacy}","received_events_url":"https://api.github.com/users/Lickability/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lickability/PinpointKit","description":"Send better feedback","fork":false,"url":"https://api.github.com/repos/Lickability/PinpointKit","forks_url":"https://api.github.com/repos/Lickability/PinpointKit/forks","keys_url":"https://api.github.com/repos/Lickability/PinpointKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lickability/PinpointKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lickability/PinpointKit/teams","hooks_url":"https://api.github.com/repos/Lickability/PinpointKit/hooks","issue_events_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/events{/number}","events_url":"https://api.github.com/repos/Lickability/PinpointKit/events","assignees_url":"https://api.github.com/repos/Lickability/PinpointKit/assignees{/user}","branches_url":"https://api.github.com/repos/Lickability/PinpointKit/branches{/branch}","tags_url":"https://api.github.com/repos/Lickability/PinpointKit/tags","blobs_url":"https://api.github.com/repos/Lickability/PinpointKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lickability/PinpointKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lickability/PinpointKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lickability/PinpointKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lickability/PinpointKit/statuses/{sha}","languages_url":"https://api.github.com/repos/Lickability/PinpointKit/languages","stargazers_url":"https://api.github.com/repos/Lickability/PinpointKit/stargazers","contributors_url":"https://api.github.com/repos/Lickability/PinpointKit/contributors","subscribers_url":"https://api.github.com/repos/Lickability/PinpointKit/subscribers","subscription_url":"https://api.github.com/repos/Lickability/PinpointKit/subscription","commits_url":"https://api.github.com/repos/Lickability/PinpointKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lickability/PinpointKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lickability/PinpointKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lickability/PinpointKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lickability/PinpointKit/contents/{+path}","compare_url":"https://api.github.com/repos/Lickability/PinpointKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lickability/PinpointKit/merges","archive_url":"https://api.github.com/repos/Lickability/PinpointKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lickability/PinpointKit/downloads","issues_url":"https://api.github.com/repos/Lickability/PinpointKit/issues{/number}","pulls_url":"https://api.github.com/repos/Lickability/PinpointKit/pulls{/number}","milestones_url":"https://api.github.com/repos/Lickability/PinpointKit/milestones{/number}","notifications_url":"https://api.github.com/repos/Lickability/PinpointKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lickability/PinpointKit/labels{/name}","releases_url":"https://api.github.com/repos/Lickability/PinpointKit/releases{/id}","deployments_url":"https://api.github.com/repos/Lickability/PinpointKit/deployments","created_at":"2016-01-10T19:14:36Z","updated_at":"2017-02-01T17:00:10Z","pushed_at":"2017-02-03T20:08:46Z","git_url":"git://github.com/Lickability/PinpointKit.git","ssh_url":"git@github.com:Lickability/PinpointKit.git","clone_url":"https://github.com/Lickability/PinpointKit.git","svn_url":"https://github.com/Lickability/PinpointKit","homepage":"","size":7124,"stargazers_count":821,"watchers_count":821,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":6,"forks":44,"open_issues":6,"watchers":821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206"},"html":{"href":"https://github.com/Lickability/PinpointKit/pull/206"},"issue":{"href":"https://api.github.com/repos/Lickability/PinpointKit/issues/206"},"comments":{"href":"https://api.github.com/repos/Lickability/PinpointKit/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/Lickability/PinpointKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lickability/PinpointKit/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/Lickability/PinpointKit/statuses/dae538aa6bd5fd0801e7ecad93fb702b31f4ac2a"}}}}
{"actor":{"display_login":"mattbischoff"}}