{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/comments/127627256","pull_request_review_id":50230923,"id":127627256,"diff_hunk":"@@ -108,4 +108,19 @@ def filter_allowed_hosts(all_hosts)\n     ovirt_services = ManageIQ::Providers::Redhat::InfraManager::OvirtServices::Builder.new(ems).build(:use_highest_supported_version => true).new(:ems => ems)\n     ovirt_services.filter_allowed_hosts(self, all_hosts)\n   end\n+\n+  def validate_memory_limit(_field, values, dlg, fld, _value)\n+    limited = get_value(values[:memory_limit])\n+    return nil unless limited\n+\n+    ems_version = source_ems.api_version[/\\d+\\.\\d+/x]","path":"app/models/manageiq/providers/redhat/infra_manager/provision_workflow.rb","position":9,"original_position":9,"commit_id":"f99581aed844c3af291787e389c68094824c9b51","original_commit_id":"f99581aed844c3af291787e389c68094824c9b51","user":{"login":"borod108","id":3274731,"avatar_url":"https://avatars4.githubusercontent.com/u/3274731?v=4","gravatar_id":"","url":"https://api.github.com/users/borod108","html_url":"https://github.com/borod108","followers_url":"https://api.github.com/users/borod108/followers","following_url":"https://api.github.com/users/borod108/following{/other_user}","gists_url":"https://api.github.com/users/borod108/gists{/gist_id}","starred_url":"https://api.github.com/users/borod108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borod108/subscriptions","organizations_url":"https://api.github.com/users/borod108/orgs","repos_url":"https://api.github.com/users/borod108/repos","events_url":"https://api.github.com/users/borod108/events{/privacy}","received_events_url":"https://api.github.com/users/borod108/received_events","type":"User","site_admin":false},"body":"I think this and the next line should be in a method, like \"supported_in_version?\" or something like that.","created_at":"2017-07-17T03:05:04Z","updated_at":"2017-07-17T03:05:04Z","html_url":"https://github.com/ManageIQ/manageiq-providers-ovirt/pull/61#discussion_r127627256","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/comments/127627256"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-ovirt/pull/61#discussion_r127627256"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61","id":130760713,"html_url":"https://github.com/ManageIQ/manageiq-providers-ovirt/pull/61","diff_url":"https://github.com/ManageIQ/manageiq-providers-ovirt/pull/61.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-ovirt/pull/61.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/issues/61","number":61,"state":"open","locked":false,"title":"Support memory limit","user":{"login":"masayag","id":316242,"avatar_url":"https://avatars7.githubusercontent.com/u/316242?v=4","gravatar_id":"","url":"https://api.github.com/users/masayag","html_url":"https://github.com/masayag","followers_url":"https://api.github.com/users/masayag/followers","following_url":"https://api.github.com/users/masayag/following{/other_user}","gists_url":"https://api.github.com/users/masayag/gists{/gist_id}","starred_url":"https://api.github.com/users/masayag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masayag/subscriptions","organizations_url":"https://api.github.com/users/masayag/orgs","repos_url":"https://api.github.com/users/masayag/repos","events_url":"https://api.github.com/users/masayag/events{/privacy}","received_events_url":"https://api.github.com/users/masayag/received_events","type":"User","site_admin":false},"body":"Memory limit feature was introduced in RHV 4.1.\r\nIt is already supported by manageiq as part of the vm provision process.\r\nThe patch adds support for total memory for providers of version 4.1 and\r\nabove, both for VM provision and for the VM refresh process.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1461560","created_at":"2017-07-16T18:21:28Z","updated_at":"2017-07-17T03:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a48bfd9d609ad69fb3d423e1cc5bac9b61790fcb","assignee":{"login":"borod108","id":3274731,"avatar_url":"https://avatars4.githubusercontent.com/u/3274731?v=4","gravatar_id":"","url":"https://api.github.com/users/borod108","html_url":"https://github.com/borod108","followers_url":"https://api.github.com/users/borod108/followers","following_url":"https://api.github.com/users/borod108/following{/other_user}","gists_url":"https://api.github.com/users/borod108/gists{/gist_id}","starred_url":"https://api.github.com/users/borod108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borod108/subscriptions","organizations_url":"https://api.github.com/users/borod108/orgs","repos_url":"https://api.github.com/users/borod108/repos","events_url":"https://api.github.com/users/borod108/events{/privacy}","received_events_url":"https://api.github.com/users/borod108/received_events","type":"User","site_admin":false},"assignees":[{"login":"borod108","id":3274731,"avatar_url":"https://avatars4.githubusercontent.com/u/3274731?v=4","gravatar_id":"","url":"https://api.github.com/users/borod108","html_url":"https://github.com/borod108","followers_url":"https://api.github.com/users/borod108/followers","following_url":"https://api.github.com/users/borod108/following{/other_user}","gists_url":"https://api.github.com/users/borod108/gists{/gist_id}","starred_url":"https://api.github.com/users/borod108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borod108/subscriptions","organizations_url":"https://api.github.com/users/borod108/orgs","repos_url":"https://api.github.com/users/borod108/repos","events_url":"https://api.github.com/users/borod108/events{/privacy}","received_events_url":"https://api.github.com/users/borod108/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/issues/61/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/statuses/f99581aed844c3af291787e389c68094824c9b51","head":{"label":"masayag:set_max_vm_memory","ref":"set_max_vm_memory","sha":"f99581aed844c3af291787e389c68094824c9b51","user":{"login":"masayag","id":316242,"avatar_url":"https://avatars7.githubusercontent.com/u/316242?v=4","gravatar_id":"","url":"https://api.github.com/users/masayag","html_url":"https://github.com/masayag","followers_url":"https://api.github.com/users/masayag/followers","following_url":"https://api.github.com/users/masayag/following{/other_user}","gists_url":"https://api.github.com/users/masayag/gists{/gist_id}","starred_url":"https://api.github.com/users/masayag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masayag/subscriptions","organizations_url":"https://api.github.com/users/masayag/orgs","repos_url":"https://api.github.com/users/masayag/repos","events_url":"https://api.github.com/users/masayag/events{/privacy}","received_events_url":"https://api.github.com/users/masayag/received_events","type":"User","site_admin":false},"repo":{"id":87636015,"name":"manageiq-providers-ovirt","full_name":"masayag/manageiq-providers-ovirt","owner":{"login":"masayag","id":316242,"avatar_url":"https://avatars7.githubusercontent.com/u/316242?v=4","gravatar_id":"","url":"https://api.github.com/users/masayag","html_url":"https://github.com/masayag","followers_url":"https://api.github.com/users/masayag/followers","following_url":"https://api.github.com/users/masayag/following{/other_user}","gists_url":"https://api.github.com/users/masayag/gists{/gist_id}","starred_url":"https://api.github.com/users/masayag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masayag/subscriptions","organizations_url":"https://api.github.com/users/masayag/orgs","repos_url":"https://api.github.com/users/masayag/repos","events_url":"https://api.github.com/users/masayag/events{/privacy}","received_events_url":"https://api.github.com/users/masayag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/masayag/manageiq-providers-ovirt","description":"ManageIQ plugin for the oVirt provider","fork":true,"url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt","forks_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/forks","keys_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/teams","hooks_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/hooks","issue_events_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/issues/events{/number}","events_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/events","assignees_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/assignees{/user}","branches_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/branches{/branch}","tags_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/tags","blobs_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/statuses/{sha}","languages_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/languages","stargazers_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/stargazers","contributors_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/contributors","subscribers_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/subscribers","subscription_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/subscription","commits_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/contents/{+path}","compare_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/merges","archive_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/downloads","issues_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/issues{/number}","pulls_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/pulls{/number}","milestones_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/milestones{/number}","notifications_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/labels{/name}","releases_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/releases{/id}","deployments_url":"https://api.github.com/repos/masayag/manageiq-providers-ovirt/deployments","created_at":"2017-04-08T13:32:34Z","updated_at":"2017-04-08T13:32:36Z","pushed_at":"2017-07-16T18:27:35Z","git_url":"git://github.com/masayag/manageiq-providers-ovirt.git","ssh_url":"git@github.com:masayag/manageiq-providers-ovirt.git","clone_url":"https://github.com/masayag/manageiq-providers-ovirt.git","svn_url":"https://github.com/masayag/manageiq-providers-ovirt","homepage":null,"size":950,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"985ded1b1db8ffd8cbe47a81b48315f2aa081cbf","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars4.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":87439236,"name":"manageiq-providers-ovirt","full_name":"ManageIQ/manageiq-providers-ovirt","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars4.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-providers-ovirt","description":"ManageIQ plugin for the oVirt provider","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/deployments","created_at":"2017-04-06T14:33:28Z","updated_at":"2017-04-06T21:16:57Z","pushed_at":"2017-07-16T18:27:36Z","git_url":"git://github.com/ManageIQ/manageiq-providers-ovirt.git","ssh_url":"git@github.com:ManageIQ/manageiq-providers-ovirt.git","clone_url":"https://github.com/ManageIQ/manageiq-providers-ovirt.git","svn_url":"https://github.com/ManageIQ/manageiq-providers-ovirt","homepage":null,"size":947,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":7,"forks":15,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-ovirt/pull/61"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/issues/61"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-ovirt/statuses/f99581aed844c3af291787e389c68094824c9b51"}}}}
{"actor":{"display_login":"borod108"}}