{"action":"created","comment":{"url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/comments/141091472","pull_request_review_id":65255893,"id":141091472,"diff_hunk":"@@ -27,11 +26,11 @@ func connection_handler(id int, host string, port int, wg *sync.WaitGroup) {\n \t\t\tfmt.Println(str)\n \t\t}\n \t\tif err!= nil {\n-\t\t\tbreak\n+\t\t\twg.Done()\n+\t\t\treturn err\n \t\t}\n \t}\n-\tfmt.Println(\"\\t runner \"+strconv.Itoa(id)+\" got its connection closed\")\n-\twg.Done()\n+\t// fmt.Println(\"\\t runner \"+strconv.Itoa(id)+\" got its connection closed\")","path":"tcpmaxconn/tcpmaxconn.go","position":34,"original_position":34,"commit_id":"0c84ecd7be50adeedf6b505459add2d6f08d58d1","original_commit_id":"0c84ecd7be50adeedf6b505459add2d6f08d58d1","user":{"login":"dcaba","id":15898942,"avatar_url":"https://avatars2.githubusercontent.com/u/15898942?v=4","gravatar_id":"","url":"https://api.github.com/users/dcaba","html_url":"https://github.com/dcaba","followers_url":"https://api.github.com/users/dcaba/followers","following_url":"https://api.github.com/users/dcaba/following{/other_user}","gists_url":"https://api.github.com/users/dcaba/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaba/subscriptions","organizations_url":"https://api.github.com/users/dcaba/orgs","repos_url":"https://api.github.com/users/dcaba/repos","events_url":"https://api.github.com/users/dcaba/events{/privacy}","received_events_url":"https://api.github.com/users/dcaba/received_events","type":"User","site_admin":false},"body":"I'd move this line to the \"if err\" block rather than commenting it","created_at":"2017-09-26T15:23:39Z","updated_at":"2017-09-26T15:23:39Z","html_url":"https://github.com/dachad/check-max-tcp-connections/pull/6#discussion_r141091472","pull_request_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/comments/141091472"},"html":{"href":"https://github.com/dachad/check-max-tcp-connections/pull/6#discussion_r141091472"},"pull_request":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6","id":138736094,"html_url":"https://github.com/dachad/check-max-tcp-connections/pull/6","diff_url":"https://github.com/dachad/check-max-tcp-connections/pull/6.diff","patch_url":"https://github.com/dachad/check-max-tcp-connections/pull/6.patch","issue_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/6","number":6,"state":"open","locked":false,"title":"Basic Unit/Functional Testing and Continuos Integration","user":{"login":"chadell","id":15998111,"avatar_url":"https://avatars0.githubusercontent.com/u/15998111?v=4","gravatar_id":"","url":"https://api.github.com/users/chadell","html_url":"https://github.com/chadell","followers_url":"https://api.github.com/users/chadell/followers","following_url":"https://api.github.com/users/chadell/following{/other_user}","gists_url":"https://api.github.com/users/chadell/gists{/gist_id}","starred_url":"https://api.github.com/users/chadell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadell/subscriptions","organizations_url":"https://api.github.com/users/chadell/orgs","repos_url":"https://api.github.com/users/chadell/repos","events_url":"https://api.github.com/users/chadell/events{/privacy}","received_events_url":"https://api.github.com/users/chadell/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-31T18:30:46Z","updated_at":"2017-09-26T15:23:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63ec7bcf42d40cf7326b2a485317bf29cd1e4451","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6/commits","review_comments_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6/comments","review_comment_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/6/comments","statuses_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/statuses/0c84ecd7be50adeedf6b505459add2d6f08d58d1","head":{"label":"dachad:ci","ref":"ci","sha":"0c84ecd7be50adeedf6b505459add2d6f08d58d1","user":{"login":"dachad","id":31482210,"avatar_url":"https://avatars3.githubusercontent.com/u/31482210?v=4","gravatar_id":"","url":"https://api.github.com/users/dachad","html_url":"https://github.com/dachad","followers_url":"https://api.github.com/users/dachad/followers","following_url":"https://api.github.com/users/dachad/following{/other_user}","gists_url":"https://api.github.com/users/dachad/gists{/gist_id}","starred_url":"https://api.github.com/users/dachad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachad/subscriptions","organizations_url":"https://api.github.com/users/dachad/orgs","repos_url":"https://api.github.com/users/dachad/repos","events_url":"https://api.github.com/users/dachad/events{/privacy}","received_events_url":"https://api.github.com/users/dachad/received_events","type":"Organization","site_admin":false},"repo":{"id":70433476,"name":"check-max-tcp-connections","full_name":"dachad/check-max-tcp-connections","owner":{"login":"dachad","id":31482210,"avatar_url":"https://avatars3.githubusercontent.com/u/31482210?v=4","gravatar_id":"","url":"https://api.github.com/users/dachad","html_url":"https://github.com/dachad","followers_url":"https://api.github.com/users/dachad/followers","following_url":"https://api.github.com/users/dachad/following{/other_user}","gists_url":"https://api.github.com/users/dachad/gists{/gist_id}","starred_url":"https://api.github.com/users/dachad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachad/subscriptions","organizations_url":"https://api.github.com/users/dachad/orgs","repos_url":"https://api.github.com/users/dachad/repos","events_url":"https://api.github.com/users/dachad/events{/privacy}","received_events_url":"https://api.github.com/users/dachad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dachad/check-max-tcp-connections","description":null,"fork":false,"url":"https://api.github.com/repos/dachad/check-max-tcp-connections","forks_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/forks","keys_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/teams","hooks_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/hooks","issue_events_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/events{/number}","events_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/events","assignees_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/assignees{/user}","branches_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/branches{/branch}","tags_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/tags","blobs_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/refs{/sha}","trees_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/statuses/{sha}","languages_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/languages","stargazers_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/stargazers","contributors_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/contributors","subscribers_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/subscribers","subscription_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/subscription","commits_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/commits{/sha}","git_commits_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/commits{/sha}","comments_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/comments{/number}","issue_comment_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/comments{/number}","contents_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/contents/{+path}","compare_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/merges","archive_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/downloads","issues_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues{/number}","pulls_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls{/number}","milestones_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/milestones{/number}","notifications_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/labels{/name}","releases_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/releases{/id}","deployments_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/deployments","created_at":"2016-10-09T22:13:05Z","updated_at":"2017-09-01T09:04:06Z","pushed_at":"2017-09-25T13:47:57Z","git_url":"git://github.com/dachad/check-max-tcp-connections.git","ssh_url":"git@github.com:dachad/check-max-tcp-connections.git","clone_url":"https://github.com/dachad/check-max-tcp-connections.git","svn_url":"https://github.com/dachad/check-max-tcp-connections","homepage":null,"size":998,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"dachad:master","ref":"master","sha":"a602ac68dab3e90cd7902974ddd985ee89f150ab","user":{"login":"dachad","id":31482210,"avatar_url":"https://avatars3.githubusercontent.com/u/31482210?v=4","gravatar_id":"","url":"https://api.github.com/users/dachad","html_url":"https://github.com/dachad","followers_url":"https://api.github.com/users/dachad/followers","following_url":"https://api.github.com/users/dachad/following{/other_user}","gists_url":"https://api.github.com/users/dachad/gists{/gist_id}","starred_url":"https://api.github.com/users/dachad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachad/subscriptions","organizations_url":"https://api.github.com/users/dachad/orgs","repos_url":"https://api.github.com/users/dachad/repos","events_url":"https://api.github.com/users/dachad/events{/privacy}","received_events_url":"https://api.github.com/users/dachad/received_events","type":"Organization","site_admin":false},"repo":{"id":70433476,"name":"check-max-tcp-connections","full_name":"dachad/check-max-tcp-connections","owner":{"login":"dachad","id":31482210,"avatar_url":"https://avatars3.githubusercontent.com/u/31482210?v=4","gravatar_id":"","url":"https://api.github.com/users/dachad","html_url":"https://github.com/dachad","followers_url":"https://api.github.com/users/dachad/followers","following_url":"https://api.github.com/users/dachad/following{/other_user}","gists_url":"https://api.github.com/users/dachad/gists{/gist_id}","starred_url":"https://api.github.com/users/dachad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachad/subscriptions","organizations_url":"https://api.github.com/users/dachad/orgs","repos_url":"https://api.github.com/users/dachad/repos","events_url":"https://api.github.com/users/dachad/events{/privacy}","received_events_url":"https://api.github.com/users/dachad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dachad/check-max-tcp-connections","description":null,"fork":false,"url":"https://api.github.com/repos/dachad/check-max-tcp-connections","forks_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/forks","keys_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/teams","hooks_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/hooks","issue_events_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/events{/number}","events_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/events","assignees_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/assignees{/user}","branches_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/branches{/branch}","tags_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/tags","blobs_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/refs{/sha}","trees_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/statuses/{sha}","languages_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/languages","stargazers_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/stargazers","contributors_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/contributors","subscribers_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/subscribers","subscription_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/subscription","commits_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/commits{/sha}","git_commits_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/git/commits{/sha}","comments_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/comments{/number}","issue_comment_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/comments{/number}","contents_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/contents/{+path}","compare_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/merges","archive_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/downloads","issues_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues{/number}","pulls_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls{/number}","milestones_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/milestones{/number}","notifications_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/labels{/name}","releases_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/releases{/id}","deployments_url":"https://api.github.com/repos/dachad/check-max-tcp-connections/deployments","created_at":"2016-10-09T22:13:05Z","updated_at":"2017-09-01T09:04:06Z","pushed_at":"2017-09-25T13:47:57Z","git_url":"git://github.com/dachad/check-max-tcp-connections.git","ssh_url":"git@github.com:dachad/check-max-tcp-connections.git","clone_url":"https://github.com/dachad/check-max-tcp-connections.git","svn_url":"https://github.com/dachad/check-max-tcp-connections","homepage":null,"size":998,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6"},"html":{"href":"https://github.com/dachad/check-max-tcp-connections/pull/6"},"issue":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/6"},"comments":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/dachad/check-max-tcp-connections/statuses/0c84ecd7be50adeedf6b505459add2d6f08d58d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dcaba"}}