{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/151514306","pull_request_review_id":77235669,"id":151514306,"diff_hunk":"@@ -127,6 +131,11 @@ REG_XMM_ARG(4, XMM4)\n REG_XMM_ARG(5, XMM5)\n REG_XMM_ARG(6, XMM6)\n REG_XMM_ARG(7, XMM7)\n+\n+#ifndef INT_ARG_REG_COUNT\n+#define INT_ARG_REG_COUNT 4\n+#endif\n+\n #endif  // !_WIN32","path":"lib/Backend/amd64/RegList.h","position":20,"original_position":20,"commit_id":"c40b5bfc5c6765e488ccc46b652cdfb457efcf1d","original_commit_id":"c40b5bfc5c6765e488ccc46b652cdfb457efcf1d","user":{"login":"Penguinwizzard","id":69503,"avatar_url":"https://avatars0.githubusercontent.com/u/69503?v=4","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"body":"The reason I have it twice here is that the number _really_ should be 6 on System V, since the calling convention there is to have 6 ints/pointers passed in regsiters. I wasn't sure about how this would interact with the machinery that is currently used on xplat for their custom calling convention machinery, so I changed it back to 4 to keep the current behavior. @Jianchun, any thoughts?","created_at":"2017-11-16T19:29:32Z","updated_at":"2017-11-16T19:29:32Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/4250#discussion_r151514306","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/151514306"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4250#discussion_r151514306"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250"}},"in_reply_to_id":151510965},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250","id":152929953,"html_url":"https://github.com/Microsoft/ChakraCore/pull/4250","diff_url":"https://github.com/Microsoft/ChakraCore/pull/4250.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/4250.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4250","number":4250,"state":"open","locked":false,"title":"ARM64: Properly home registers for apply on arguments","user":{"login":"Penguinwizzard","id":69503,"avatar_url":"https://avatars0.githubusercontent.com/u/69503?v=4","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"body":"We need to place arguments into x0-x7 before we start to put them on\nthe stack; this code achieves that.\n","created_at":"2017-11-16T01:32:57Z","updated_at":"2017-11-16T19:29:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d7f7644571b6a2d2213d35d62a839369ca85323","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sigatrev","id":5722242,"avatar_url":"https://avatars0.githubusercontent.com/u/5722242?v=4","gravatar_id":"","url":"https://api.github.com/users/sigatrev","html_url":"https://github.com/sigatrev","followers_url":"https://api.github.com/users/sigatrev/followers","following_url":"https://api.github.com/users/sigatrev/following{/other_user}","gists_url":"https://api.github.com/users/sigatrev/gists{/gist_id}","starred_url":"https://api.github.com/users/sigatrev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigatrev/subscriptions","organizations_url":"https://api.github.com/users/sigatrev/orgs","repos_url":"https://api.github.com/users/sigatrev/repos","events_url":"https://api.github.com/users/sigatrev/events{/privacy}","received_events_url":"https://api.github.com/users/sigatrev/received_events","type":"User","site_admin":false},{"login":"jianchun","id":11861955,"avatar_url":"https://avatars3.githubusercontent.com/u/11861955?v=4","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},{"login":"agarwal-sandeep","id":12059066,"avatar_url":"https://avatars3.githubusercontent.com/u/12059066?v=4","gravatar_id":"","url":"https://api.github.com/users/agarwal-sandeep","html_url":"https://github.com/agarwal-sandeep","followers_url":"https://api.github.com/users/agarwal-sandeep/followers","following_url":"https://api.github.com/users/agarwal-sandeep/following{/other_user}","gists_url":"https://api.github.com/users/agarwal-sandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/agarwal-sandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarwal-sandeep/subscriptions","organizations_url":"https://api.github.com/users/agarwal-sandeep/orgs","repos_url":"https://api.github.com/users/agarwal-sandeep/repos","events_url":"https://api.github.com/users/agarwal-sandeep/events{/privacy}","received_events_url":"https://api.github.com/users/agarwal-sandeep/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4250/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/c40b5bfc5c6765e488ccc46b652cdfb457efcf1d","head":{"label":"Penguinwizzard:arm64_homeregsforapplyargs","ref":"arm64_homeregsforapplyargs","sha":"c40b5bfc5c6765e488ccc46b652cdfb457efcf1d","user":{"login":"Penguinwizzard","id":69503,"avatar_url":"https://avatars0.githubusercontent.com/u/69503?v=4","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"repo":{"id":68159295,"name":"ChakraCore","full_name":"Penguinwizzard/ChakraCore","owner":{"login":"Penguinwizzard","id":69503,"avatar_url":"https://avatars0.githubusercontent.com/u/69503?v=4","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Penguinwizzard/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/Penguinwizzard/ChakraCore","forks_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/forks","keys_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/events","assignees_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/merges","archive_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/deployments","created_at":"2016-09-14T00:39:02Z","updated_at":"2016-09-14T00:39:23Z","pushed_at":"2017-11-16T01:42:31Z","git_url":"git://github.com/Penguinwizzard/ChakraCore.git","ssh_url":"git@github.com:Penguinwizzard/ChakraCore.git","clone_url":"https://github.com/Penguinwizzard/ChakraCore.git","svn_url":"https://github.com/Penguinwizzard/ChakraCore","homepage":null,"size":133862,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:release/1.8","ref":"release/1.8","sha":"14fd280abd921a74dace5f3d83fae4037cfc3104","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2017-11-16T19:20:47Z","pushed_at":"2017-11-16T19:22:28Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":93499,"stargazers_count":6534,"watchers_count":6534,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":826,"mirror_url":null,"archived":false,"open_issues_count":407,"forks":826,"open_issues":407,"watchers":6534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4250"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4250"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4250/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4250/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/c40b5bfc5c6765e488ccc46b652cdfb457efcf1d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Penguinwizzard"}}