{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/128348075","pull_request_review_id":51020183,"id":128348075,"diff_hunk":"@@ -0,0 +1 @@\n+types/","path":"packages/kbn-types/.gitignore","position":null,"original_position":1,"commit_id":"f63f81c8a5e4a71bcf2271438efd5dd7a76975eb","original_commit_id":"f0a185e3f20ebc132fbe4a5c13f1a09ca610aef7","user":{"login":"kjbekkelund","id":5259,"avatar_url":"https://avatars2.githubusercontent.com/u/5259?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbekkelund","html_url":"https://github.com/kjbekkelund","followers_url":"https://api.github.com/users/kjbekkelund/followers","following_url":"https://api.github.com/users/kjbekkelund/following{/other_user}","gists_url":"https://api.github.com/users/kjbekkelund/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbekkelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbekkelund/subscriptions","organizations_url":"https://api.github.com/users/kjbekkelund/orgs","repos_url":"https://api.github.com/users/kjbekkelund/repos","events_url":"https://api.github.com/users/kjbekkelund/events{/privacy}","received_events_url":"https://api.github.com/users/kjbekkelund/received_events","type":"User","site_admin":false},"body":"Moved it to `@elastic`. We'll likely never push anything that's not under `@elastic`, so don't really see the point of that folder, but it's something we can solve later","created_at":"2017-07-19T19:48:07Z","updated_at":"2017-07-19T19:48:07Z","html_url":"https://github.com/elastic/kibana/pull/12857#discussion_r128348075","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/12857","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/128348075"},"html":{"href":"https://github.com/elastic/kibana/pull/12857#discussion_r128348075"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12857"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/12857","id":130566722,"html_url":"https://github.com/elastic/kibana/pull/12857","diff_url":"https://github.com/elastic/kibana/pull/12857.diff","patch_url":"https://github.com/elastic/kibana/pull/12857.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/12857","number":12857,"state":"open","locked":false,"title":"Typed plugins in new platform","user":{"login":"kjbekkelund","id":5259,"avatar_url":"https://avatars2.githubusercontent.com/u/5259?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbekkelund","html_url":"https://github.com/kjbekkelund","followers_url":"https://api.github.com/users/kjbekkelund/followers","following_url":"https://api.github.com/users/kjbekkelund/following{/other_user}","gists_url":"https://api.github.com/users/kjbekkelund/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbekkelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbekkelund/subscriptions","organizations_url":"https://api.github.com/users/kjbekkelund/orgs","repos_url":"https://api.github.com/users/kjbekkelund/repos","events_url":"https://api.github.com/users/kjbekkelund/events{/privacy}","received_events_url":"https://api.github.com/users/kjbekkelund/received_events","type":"User","site_admin":false},"body":"I _think_ this is the simplest way to build external plugins with types. Added a `kbn-types` package that contains a file that exports whatever we want to export from core, then use TS to build declaration files. See the readme in the `kbn-types` package for more info.\r\n\r\nI'll create issues for some follow-ups. One is having CI build the package and make sure the error code is 0, as we otherwise have broken external types. Not really sure how to otherwise test this, e.g. making sure the right things are available etc. Another follow-up is exploring if we should commit the types, e.g. to make \"breaking changes\" to the types more obvious.\r\n\r\nI've got a feeling it should be possible to further minimise the exposed types, but if this _works_, I think this is probably a good enough start, then we can learn as we start trying to make core plugins truly \"independent\" (separate package.json etc).","created_at":"2017-07-14T11:10:18Z","updated_at":"2017-07-19T19:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42a7a1ab4af0a17a24dda14c4aa7154b3dd98e2d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/12857/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/12857/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/12857/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/f63f81c8a5e4a71bcf2271438efd5dd7a76975eb","head":{"label":"kjbekkelund:plugin-types","ref":"plugin-types","sha":"f63f81c8a5e4a71bcf2271438efd5dd7a76975eb","user":{"login":"kjbekkelund","id":5259,"avatar_url":"https://avatars2.githubusercontent.com/u/5259?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbekkelund","html_url":"https://github.com/kjbekkelund","followers_url":"https://api.github.com/users/kjbekkelund/followers","following_url":"https://api.github.com/users/kjbekkelund/following{/other_user}","gists_url":"https://api.github.com/users/kjbekkelund/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbekkelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbekkelund/subscriptions","organizations_url":"https://api.github.com/users/kjbekkelund/orgs","repos_url":"https://api.github.com/users/kjbekkelund/repos","events_url":"https://api.github.com/users/kjbekkelund/events{/privacy}","received_events_url":"https://api.github.com/users/kjbekkelund/received_events","type":"User","site_admin":false},"repo":{"id":45115123,"name":"kibana","full_name":"kjbekkelund/kibana","owner":{"login":"kjbekkelund","id":5259,"avatar_url":"https://avatars2.githubusercontent.com/u/5259?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbekkelund","html_url":"https://github.com/kjbekkelund","followers_url":"https://api.github.com/users/kjbekkelund/followers","following_url":"https://api.github.com/users/kjbekkelund/following{/other_user}","gists_url":"https://api.github.com/users/kjbekkelund/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbekkelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbekkelund/subscriptions","organizations_url":"https://api.github.com/users/kjbekkelund/orgs","repos_url":"https://api.github.com/users/kjbekkelund/repos","events_url":"https://api.github.com/users/kjbekkelund/events{/privacy}","received_events_url":"https://api.github.com/users/kjbekkelund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjbekkelund/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/kjbekkelund/kibana","forks_url":"https://api.github.com/repos/kjbekkelund/kibana/forks","keys_url":"https://api.github.com/repos/kjbekkelund/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjbekkelund/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjbekkelund/kibana/teams","hooks_url":"https://api.github.com/repos/kjbekkelund/kibana/hooks","issue_events_url":"https://api.github.com/repos/kjbekkelund/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/kjbekkelund/kibana/events","assignees_url":"https://api.github.com/repos/kjbekkelund/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/kjbekkelund/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/kjbekkelund/kibana/tags","blobs_url":"https://api.github.com/repos/kjbekkelund/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjbekkelund/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjbekkelund/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjbekkelund/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjbekkelund/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/kjbekkelund/kibana/languages","stargazers_url":"https://api.github.com/repos/kjbekkelund/kibana/stargazers","contributors_url":"https://api.github.com/repos/kjbekkelund/kibana/contributors","subscribers_url":"https://api.github.com/repos/kjbekkelund/kibana/subscribers","subscription_url":"https://api.github.com/repos/kjbekkelund/kibana/subscription","commits_url":"https://api.github.com/repos/kjbekkelund/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjbekkelund/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjbekkelund/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjbekkelund/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjbekkelund/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/kjbekkelund/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjbekkelund/kibana/merges","archive_url":"https://api.github.com/repos/kjbekkelund/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjbekkelund/kibana/downloads","issues_url":"https://api.github.com/repos/kjbekkelund/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/kjbekkelund/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/kjbekkelund/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/kjbekkelund/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjbekkelund/kibana/labels{/name}","releases_url":"https://api.github.com/repos/kjbekkelund/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/kjbekkelund/kibana/deployments","created_at":"2015-10-28T13:45:10Z","updated_at":"2016-02-11T18:53:14Z","pushed_at":"2017-07-19T19:46:33Z","git_url":"git://github.com/kjbekkelund/kibana.git","ssh_url":"git@github.com:kjbekkelund/kibana.git","clone_url":"https://github.com/kjbekkelund/kibana.git","svn_url":"https://github.com/kjbekkelund/kibana","homepage":"https://www.elastic.co/products/kibana","size":257483,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:new-platform","ref":"new-platform","sha":"fe56c888869d9cfdd68671b56ef7e756a38053aa","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-07-19T13:27:13Z","pushed_at":"2017-07-19T19:46:35Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":261115,"stargazers_count":7668,"watchers_count":7668,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2951,"mirror_url":null,"open_issues_count":1894,"forks":2951,"open_issues":1894,"watchers":7668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12857"},"html":{"href":"https://github.com/elastic/kibana/pull/12857"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/12857"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/12857/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12857/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12857/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/f63f81c8a5e4a71bcf2271438efd5dd7a76975eb"}}}}
{"actor":{"display_login":"kjbekkelund"}}