{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/Kore/issues/453","repository_url":"https://api.github.com/repos/xbmc/Kore","labels_url":"https://api.github.com/repos/xbmc/Kore/issues/453/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/Kore/issues/453/comments","events_url":"https://api.github.com/repos/xbmc/Kore/issues/453/events","html_url":"https://github.com/xbmc/Kore/pull/453","id":259265649,"number":453,"title":"Use hardware volume keys from anywhere inside Kore","user":{"login":"Calebzor","id":3092675,"avatar_url":"https://avatars2.githubusercontent.com/u/3092675?v=4","gravatar_id":"","url":"https://api.github.com/users/Calebzor","html_url":"https://github.com/Calebzor","followers_url":"https://api.github.com/users/Calebzor/followers","following_url":"https://api.github.com/users/Calebzor/following{/other_user}","gists_url":"https://api.github.com/users/Calebzor/gists{/gist_id}","starred_url":"https://api.github.com/users/Calebzor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calebzor/subscriptions","organizations_url":"https://api.github.com/users/Calebzor/orgs","repos_url":"https://api.github.com/users/Calebzor/repos","events_url":"https://api.github.com/users/Calebzor/events{/privacy}","received_events_url":"https://api.github.com/users/Calebzor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-09-20T18:53:10Z","updated_at":"2017-09-26T06:30:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xbmc/Kore/pulls/453","html_url":"https://github.com/xbmc/Kore/pull/453","diff_url":"https://github.com/xbmc/Kore/pull/453.diff","patch_url":"https://github.com/xbmc/Kore/pull/453.patch"},"body":"* Move dispatchKeyEvent callback for volume control to the BaseActivity to allow all activities to receive hardware button events\r\n\r\nresolves xbmc/Kore#235"},"comment":{"url":"https://api.github.com/repos/xbmc/Kore/issues/comments/332099710","html_url":"https://github.com/xbmc/Kore/pull/453#issuecomment-332099710","issue_url":"https://api.github.com/repos/xbmc/Kore/issues/453","id":332099710,"user":{"login":"poisdeux","id":4527626,"avatar_url":"https://avatars3.githubusercontent.com/u/4527626?v=4","gravatar_id":"","url":"https://api.github.com/users/poisdeux","html_url":"https://github.com/poisdeux","followers_url":"https://api.github.com/users/poisdeux/followers","following_url":"https://api.github.com/users/poisdeux/following{/other_user}","gists_url":"https://api.github.com/users/poisdeux/gists{/gist_id}","starred_url":"https://api.github.com/users/poisdeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poisdeux/subscriptions","organizations_url":"https://api.github.com/users/poisdeux/orgs","repos_url":"https://api.github.com/users/poisdeux/repos","events_url":"https://api.github.com/users/poisdeux/events{/privacy}","received_events_url":"https://api.github.com/users/poisdeux/received_events","type":"User","site_admin":false},"created_at":"2017-09-26T06:30:44Z","updated_at":"2017-09-26T06:30:44Z","author_association":"CONTRIBUTOR","body":"I like that you used the NowPlayingPanel (not because I'm a fan of the panel) as it doesn't require another view that pops in, which doesn't really feel to be a part of Kore.\r\n\r\nJust had a quick test and I've found a few issues with the current setup.\r\n\r\n1. It's not consistent. There is no feedback on the remote screen. Although this is the current behaviour, as we are now changing it for other activities this is (IMO) bad UX-design. \r\n2. If nothing is playing on Kodi the NowPlayingPanel appears and also shows the play buttons, progress bar,  etc. which only have meaning if something is playing. We should disable these if nothing is playing.\r\n3. The panel doesn't disappear when volume was changed. It just stays collapsed.\r\n4. From a UI design perspective it doesn't look nice when nothing is playing. A possible solution for might be making the height of the collapsed view 0dp when nothing is playing. \r\n\r\n![screenshot_1506405925](https://user-images.githubusercontent.com/4527626/30845106-27167e08-a292-11e7-9fa7-e14251f3ccbf.png)\r\n\r\nI think that for now we should go with the Toast/Dialog at least on the remote screen and if above issues can be fixed use the NowPlayingPanel for the other screens. @SyncedSynapse what do you think?"}}
{"actor":{"display_login":"poisdeux"}}