{"action":"created","comment":{"url":"https://api.github.com/repos/GSA/catalog-deploy/pulls/comments/96540719","pull_request_review_id":17125147,"id":96540719,"diff_hunk":"@@ -15,15 +15,20 @@ variable \"branch\" {}\n \n variable \"security_context\" { default = \"dev\" }\n \n-variable \"aws_region\" { default = \"us-east-1\" }\n-variable \"ami_type\" { default = \"hardened\" }\n+variable \"network\" { \n+    type = \"map\"\n+    default = {\n+        region = \"us-east-1\" \n+    }\n+}\n+variable \"ami_type\" { default = \"not-hardened\" }\n variable \"bastion_subnet_id\" {}\n variable \"bastion_security_group_id\" {}\n-variable \"bastion_instance_type\" {}\n+variable \"bastion_instance_type\" { default = \"m3.medium\" }","path":"terraform/pilot/main.tf","position":16,"original_position":16,"commit_id":"7e541857e96906ebaea9b1c25bc92dd14286a168","original_commit_id":"7e541857e96906ebaea9b1c25bc92dd14286a168","user":{"login":"JJediny","id":6350035,"avatar_url":"https://avatars.githubusercontent.com/u/6350035?v=3","gravatar_id":"","url":"https://api.github.com/users/JJediny","html_url":"https://github.com/JJediny","followers_url":"https://api.github.com/users/JJediny/followers","following_url":"https://api.github.com/users/JJediny/following{/other_user}","gists_url":"https://api.github.com/users/JJediny/gists{/gist_id}","starred_url":"https://api.github.com/users/JJediny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JJediny/subscriptions","organizations_url":"https://api.github.com/users/JJediny/orgs","repos_url":"https://api.github.com/users/JJediny/repos","events_url":"https://api.github.com/users/JJediny/events{/privacy}","received_events_url":"https://api.github.com/users/JJediny/received_events","type":"User","site_admin":false},"body":"generally speaking for our compute heavy applications c4.xlarge or c4.2xlarge for mem heavy m4.xlarge/m4.2xlarge for prod loads for demo/dev **c4.large and m4.large**","created_at":"2017-01-18T00:00:08Z","updated_at":"2017-01-18T00:00:08Z","html_url":"https://github.com/GSA/catalog-deploy/pull/93#discussion_r96540719","pull_request_url":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/GSA/catalog-deploy/pulls/comments/96540719"},"html":{"href":"https://github.com/GSA/catalog-deploy/pull/93#discussion_r96540719"},"pull_request":{"href":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93","id":101323894,"html_url":"https://github.com/GSA/catalog-deploy/pull/93","diff_url":"https://github.com/GSA/catalog-deploy/pull/93.diff","patch_url":"https://github.com/GSA/catalog-deploy/pull/93.patch","issue_url":"https://api.github.com/repos/GSA/catalog-deploy/issues/93","number":93,"state":"closed","locked":false,"title":"79 terraform ansible","user":{"login":"aquilent-robproper","id":12972186,"avatar_url":"https://avatars.githubusercontent.com/u/12972186?v=3","gravatar_id":"","url":"https://api.github.com/users/aquilent-robproper","html_url":"https://github.com/aquilent-robproper","followers_url":"https://api.github.com/users/aquilent-robproper/followers","following_url":"https://api.github.com/users/aquilent-robproper/following{/other_user}","gists_url":"https://api.github.com/users/aquilent-robproper/gists{/gist_id}","starred_url":"https://api.github.com/users/aquilent-robproper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquilent-robproper/subscriptions","organizations_url":"https://api.github.com/users/aquilent-robproper/orgs","repos_url":"https://api.github.com/users/aquilent-robproper/repos","events_url":"https://api.github.com/users/aquilent-robproper/events{/privacy}","received_events_url":"https://api.github.com/users/aquilent-robproper/received_events","type":"User","site_admin":false},"body":"Added the following changes:\r\n\r\n1. The ability to invoke Ansible playbooks from the pipeline\r\n\r\n2. The ability to specify for a terraform \"stack\" to wait for resources to complete\r\n    Create a file name stack.yml in root module source directory of the stack, using the following template:\r\n\r\n```\r\nstack:\r\n       wait:\r\n             conditions:\r\n                  <resource name>:   aws-healthcheck\r\n             delay: 10\r\n             max-iterations: 60\r\n```\r\n\r\nwhere:\r\n\r\n- `conditions` is a map of all resources to wait for\r\n- `<resource name>`  is the value of the Resource tag created in the Terraform script.\r\n- `aws-healthcheck` indicates to wait for the ec2-instance to pass both health checks\r\n(other checks can be added later, e.g. to wait for response to HTTP requests on a specific port could be represented as `http 80 /path`)\r\n- `delay` is the waiting period in seconds in between checks. The default is `10`.\r\n- `max-iterations` is the maximum number of iteration over all resources. The default is `720`, which equals 2 hours.\r\n\r\n4. Added `stack.yml` files for both the infrastructure stack (to wait for NAT to pass health checks) and \r\n   the pilot stack (to wait for the bastion and wordpress-web instances to pass health checks).\r\n\r\n3. Added Ansible playbook invocations of jumpbox.yml and datagov-web.yml playbooks against the \r\n    bastion resp. wordpress-web resources created by the pilot stack. Not using dynamic inventory yet.\r\n\r\n\r\n\r\n\r\n","created_at":"2017-01-12T19:27:30Z","updated_at":"2017-01-18T00:00:08Z","closed_at":"2017-01-17T21:57:05Z","merged_at":"2017-01-17T21:57:05Z","merge_commit_sha":"883ea5eb832d09f556615579dcfce7468e34691b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93/commits","review_comments_url":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93/comments","review_comment_url":"https://api.github.com/repos/GSA/catalog-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GSA/catalog-deploy/issues/93/comments","statuses_url":"https://api.github.com/repos/GSA/catalog-deploy/statuses/7e541857e96906ebaea9b1c25bc92dd14286a168","head":{"label":"GSA:79-terraform-ansible","ref":"79-terraform-ansible","sha":"7e541857e96906ebaea9b1c25bc92dd14286a168","user":{"login":"GSA","id":643070,"avatar_url":"https://avatars.githubusercontent.com/u/643070?v=3","gravatar_id":"","url":"https://api.github.com/users/GSA","html_url":"https://github.com/GSA","followers_url":"https://api.github.com/users/GSA/followers","following_url":"https://api.github.com/users/GSA/following{/other_user}","gists_url":"https://api.github.com/users/GSA/gists{/gist_id}","starred_url":"https://api.github.com/users/GSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GSA/subscriptions","organizations_url":"https://api.github.com/users/GSA/orgs","repos_url":"https://api.github.com/users/GSA/repos","events_url":"https://api.github.com/users/GSA/events{/privacy}","received_events_url":"https://api.github.com/users/GSA/received_events","type":"Organization","site_admin":false},"repo":{"id":42135842,"name":"catalog-deploy","full_name":"GSA/catalog-deploy","owner":{"login":"GSA","id":643070,"avatar_url":"https://avatars.githubusercontent.com/u/643070?v=3","gravatar_id":"","url":"https://api.github.com/users/GSA","html_url":"https://github.com/GSA","followers_url":"https://api.github.com/users/GSA/followers","following_url":"https://api.github.com/users/GSA/following{/other_user}","gists_url":"https://api.github.com/users/GSA/gists{/gist_id}","starred_url":"https://api.github.com/users/GSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GSA/subscriptions","organizations_url":"https://api.github.com/users/GSA/orgs","repos_url":"https://api.github.com/users/GSA/repos","events_url":"https://api.github.com/users/GSA/events{/privacy}","received_events_url":"https://api.github.com/users/GSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GSA/catalog-deploy","description":"Main repository for Data.gov's stack deployment","fork":false,"url":"https://api.github.com/repos/GSA/catalog-deploy","forks_url":"https://api.github.com/repos/GSA/catalog-deploy/forks","keys_url":"https://api.github.com/repos/GSA/catalog-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GSA/catalog-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GSA/catalog-deploy/teams","hooks_url":"https://api.github.com/repos/GSA/catalog-deploy/hooks","issue_events_url":"https://api.github.com/repos/GSA/catalog-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/GSA/catalog-deploy/events","assignees_url":"https://api.github.com/repos/GSA/catalog-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/GSA/catalog-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/GSA/catalog-deploy/tags","blobs_url":"https://api.github.com/repos/GSA/catalog-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GSA/catalog-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GSA/catalog-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/GSA/catalog-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GSA/catalog-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/GSA/catalog-deploy/languages","stargazers_url":"https://api.github.com/repos/GSA/catalog-deploy/stargazers","contributors_url":"https://api.github.com/repos/GSA/catalog-deploy/contributors","subscribers_url":"https://api.github.com/repos/GSA/catalog-deploy/subscribers","subscription_url":"https://api.github.com/repos/GSA/catalog-deploy/subscription","commits_url":"https://api.github.com/repos/GSA/catalog-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/GSA/catalog-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/GSA/catalog-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/GSA/catalog-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/GSA/catalog-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/GSA/catalog-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GSA/catalog-deploy/merges","archive_url":"https://api.github.com/repos/GSA/catalog-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GSA/catalog-deploy/downloads","issues_url":"https://api.github.com/repos/GSA/catalog-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/GSA/catalog-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/GSA/catalog-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/GSA/catalog-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GSA/catalog-deploy/labels{/name}","releases_url":"https://api.github.com/repos/GSA/catalog-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/GSA/catalog-deploy/deployments","created_at":"2015-09-08T19:59:04Z","updated_at":"2017-01-11T18:58:16Z","pushed_at":"2017-01-17T21:57:30Z","git_url":"git://github.com/GSA/catalog-deploy.git","ssh_url":"git@github.com:GSA/catalog-deploy.git","clone_url":"https://github.com/GSA/catalog-deploy.git","svn_url":"https://github.com/GSA/catalog-deploy","homepage":"https://github.com/GSA/catalog-deploy/projects/1","size":23886,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":46,"forks":2,"open_issues":46,"watchers":6,"default_branch":"master"}},"base":{"label":"GSA:master-demo","ref":"master-demo","sha":"4179f1abe33a7c7bd966c5d2c350125347b38519","user":{"login":"GSA","id":643070,"avatar_url":"https://avatars.githubusercontent.com/u/643070?v=3","gravatar_id":"","url":"https://api.github.com/users/GSA","html_url":"https://github.com/GSA","followers_url":"https://api.github.com/users/GSA/followers","following_url":"https://api.github.com/users/GSA/following{/other_user}","gists_url":"https://api.github.com/users/GSA/gists{/gist_id}","starred_url":"https://api.github.com/users/GSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GSA/subscriptions","organizations_url":"https://api.github.com/users/GSA/orgs","repos_url":"https://api.github.com/users/GSA/repos","events_url":"https://api.github.com/users/GSA/events{/privacy}","received_events_url":"https://api.github.com/users/GSA/received_events","type":"Organization","site_admin":false},"repo":{"id":42135842,"name":"catalog-deploy","full_name":"GSA/catalog-deploy","owner":{"login":"GSA","id":643070,"avatar_url":"https://avatars.githubusercontent.com/u/643070?v=3","gravatar_id":"","url":"https://api.github.com/users/GSA","html_url":"https://github.com/GSA","followers_url":"https://api.github.com/users/GSA/followers","following_url":"https://api.github.com/users/GSA/following{/other_user}","gists_url":"https://api.github.com/users/GSA/gists{/gist_id}","starred_url":"https://api.github.com/users/GSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GSA/subscriptions","organizations_url":"https://api.github.com/users/GSA/orgs","repos_url":"https://api.github.com/users/GSA/repos","events_url":"https://api.github.com/users/GSA/events{/privacy}","received_events_url":"https://api.github.com/users/GSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GSA/catalog-deploy","description":"Main repository for Data.gov's stack deployment","fork":false,"url":"https://api.github.com/repos/GSA/catalog-deploy","forks_url":"https://api.github.com/repos/GSA/catalog-deploy/forks","keys_url":"https://api.github.com/repos/GSA/catalog-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GSA/catalog-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GSA/catalog-deploy/teams","hooks_url":"https://api.github.com/repos/GSA/catalog-deploy/hooks","issue_events_url":"https://api.github.com/repos/GSA/catalog-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/GSA/catalog-deploy/events","assignees_url":"https://api.github.com/repos/GSA/catalog-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/GSA/catalog-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/GSA/catalog-deploy/tags","blobs_url":"https://api.github.com/repos/GSA/catalog-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GSA/catalog-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GSA/catalog-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/GSA/catalog-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GSA/catalog-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/GSA/catalog-deploy/languages","stargazers_url":"https://api.github.com/repos/GSA/catalog-deploy/stargazers","contributors_url":"https://api.github.com/repos/GSA/catalog-deploy/contributors","subscribers_url":"https://api.github.com/repos/GSA/catalog-deploy/subscribers","subscription_url":"https://api.github.com/repos/GSA/catalog-deploy/subscription","commits_url":"https://api.github.com/repos/GSA/catalog-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/GSA/catalog-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/GSA/catalog-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/GSA/catalog-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/GSA/catalog-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/GSA/catalog-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GSA/catalog-deploy/merges","archive_url":"https://api.github.com/repos/GSA/catalog-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GSA/catalog-deploy/downloads","issues_url":"https://api.github.com/repos/GSA/catalog-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/GSA/catalog-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/GSA/catalog-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/GSA/catalog-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GSA/catalog-deploy/labels{/name}","releases_url":"https://api.github.com/repos/GSA/catalog-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/GSA/catalog-deploy/deployments","created_at":"2015-09-08T19:59:04Z","updated_at":"2017-01-11T18:58:16Z","pushed_at":"2017-01-17T21:57:30Z","git_url":"git://github.com/GSA/catalog-deploy.git","ssh_url":"git@github.com:GSA/catalog-deploy.git","clone_url":"https://github.com/GSA/catalog-deploy.git","svn_url":"https://github.com/GSA/catalog-deploy","homepage":"https://github.com/GSA/catalog-deploy/projects/1","size":23886,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":46,"forks":2,"open_issues":46,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93"},"html":{"href":"https://github.com/GSA/catalog-deploy/pull/93"},"issue":{"href":"https://api.github.com/repos/GSA/catalog-deploy/issues/93"},"comments":{"href":"https://api.github.com/repos/GSA/catalog-deploy/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/GSA/catalog-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GSA/catalog-deploy/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/GSA/catalog-deploy/statuses/7e541857e96906ebaea9b1c25bc92dd14286a168"}}}}
{"actor":{"display_login":"JJediny"}}