{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/984","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/984/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/984/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/984/events","html_url":"https://github.com/eclipse/omr/pull/984","id":219968005,"number":984,"title":"Prevent gotoElim from skipping asynccheck in OSR","user":{"login":"ncough","id":24916905,"avatar_url":"https://avatars3.githubusercontent.com/u/24916905?v=3","gravatar_id":"","url":"https://api.github.com/users/ncough","html_url":"https://github.com/ncough","followers_url":"https://api.github.com/users/ncough/followers","following_url":"https://api.github.com/users/ncough/following{/other_user}","gists_url":"https://api.github.com/users/ncough/gists{/gist_id}","starred_url":"https://api.github.com/users/ncough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncough/subscriptions","organizations_url":"https://api.github.com/users/ncough/orgs","repos_url":"https://api.github.com/users/ncough/repos","events_url":"https://api.github.com/users/ncough/events{/privacy}","received_events_url":"https://api.github.com/users/ncough/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-06T17:10:48Z","updated_at":"2017-04-06T17:24:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/984","html_url":"https://github.com/eclipse/omr/pull/984","diff_url":"https://github.com/eclipse/omr/pull/984.diff","patch_url":"https://github.com/eclipse/omr/pull/984.patch"},"body":"Goto elimination will attempt to remove blocks that contain\r\na series of asyncchecks followed by a goto. To ensure the asynccheck\r\nis still present, it is currently moved to all of its predecessors.\r\nHowever, the asynccheck may have an OSR guard in the goto's\r\ndestination block in postExecution OSR. To correct this, the asynccheck\r\nis shifted to the start of the goto's destination block."},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/292246403","html_url":"https://github.com/eclipse/omr/pull/984#issuecomment-292246403","issue_url":"https://api.github.com/repos/eclipse/omr/issues/984","id":292246403,"user":{"login":"andrewcraik","id":5400312,"avatar_url":"https://avatars0.githubusercontent.com/u/5400312?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewcraik","html_url":"https://github.com/andrewcraik","followers_url":"https://api.github.com/users/andrewcraik/followers","following_url":"https://api.github.com/users/andrewcraik/following{/other_user}","gists_url":"https://api.github.com/users/andrewcraik/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewcraik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewcraik/subscriptions","organizations_url":"https://api.github.com/users/andrewcraik/orgs","repos_url":"https://api.github.com/users/andrewcraik/repos","events_url":"https://api.github.com/users/andrewcraik/events{/privacy}","received_events_url":"https://api.github.com/users/andrewcraik/received_events","type":"User","site_admin":false},"created_at":"2017-04-06T17:24:18Z","updated_at":"2017-04-06T17:24:18Z","body":"The bigger issue here is that the shift to the predecessor could place the asynccheck above a branch allowing a yield to occur where we may not have accounted for it. Moving to the successor prevents this problem... If you agree with that perhaps you can clarify the PR comment to reflect this."}}
{"actor":{"display_login":"andrewcraik"}}