{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/107232257","pull_request_review_id":28192400,"id":107232257,"diff_hunk":"@@ -30,10 +30,10 @@ def get_args_from_env():\n \n     return {\n         'dcos_url': os.environ['DCOS_DNS_ADDRESS'],\n-        'masters': os.environ['MASTER_HOSTS'].split(','),\n-        'public_masters': os.environ['PUBLIC_MASTER_HOSTS'].split(','),\n-        'slaves': os.environ['SLAVE_HOSTS'].split(','),\n-        'public_slaves': os.environ['PUBLIC_SLAVE_HOSTS'].split(','),\n+        'masters': list(filter(None, os.environ['MASTER_HOSTS'].split(','))),\n+        'public_masters': list(filter(None, os.environ['PUBLIC_MASTER_HOSTS'].split(','))),\n+        'slaves': list(filter(None, os.environ['SLAVE_HOSTS'].split(','))),","path":"test_util/dcos_api_session.py","position":10,"original_position":10,"commit_id":"05627be2b02fb3d9ebd1f26bd44f2ebd9da76ee3","original_commit_id":"05627be2b02fb3d9ebd1f26bd44f2ebd9da76ee3","user":{"login":"tillt","id":592445,"avatar_url":"https://avatars3.githubusercontent.com/u/592445?v=3","gravatar_id":"","url":"https://api.github.com/users/tillt","html_url":"https://github.com/tillt","followers_url":"https://api.github.com/users/tillt/followers","following_url":"https://api.github.com/users/tillt/following{/other_user}","gists_url":"https://api.github.com/users/tillt/gists{/gist_id}","starred_url":"https://api.github.com/users/tillt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillt/subscriptions","organizations_url":"https://api.github.com/users/tillt/orgs","repos_url":"https://api.github.com/users/tillt/repos","events_url":"https://api.github.com/users/tillt/events{/privacy}","received_events_url":"https://api.github.com/users/tillt/received_events","type":"User","site_admin":false},"body":"see above","created_at":"2017-03-21T18:07:04Z","updated_at":"2017-03-21T18:07:04Z","html_url":"https://github.com/dcos/dcos/pull/1236#discussion_r107232257","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/1236","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/107232257"},"html":{"href":"https://github.com/dcos/dcos/pull/1236#discussion_r107232257"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1236"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/1236","id":106016876,"html_url":"https://github.com/dcos/dcos/pull/1236","diff_url":"https://github.com/dcos/dcos/pull/1236.diff","patch_url":"https://github.com/dcos/dcos/pull/1236.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/1236","number":1236,"state":"open","locked":false,"title":"Integration Tests: Updated environment variable list explosion.","user":{"login":"tillt","id":592445,"avatar_url":"https://avatars3.githubusercontent.com/u/592445?v=3","gravatar_id":"","url":"https://api.github.com/users/tillt","html_url":"https://github.com/tillt","followers_url":"https://api.github.com/users/tillt/followers","following_url":"https://api.github.com/users/tillt/following{/other_user}","gists_url":"https://api.github.com/users/tillt/gists{/gist_id}","starred_url":"https://api.github.com/users/tillt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillt/subscriptions","organizations_url":"https://api.github.com/users/tillt/orgs","repos_url":"https://api.github.com/users/tillt/repos","events_url":"https://api.github.com/users/tillt/events{/privacy}","received_events_url":"https://api.github.com/users/tillt/received_events","type":"User","site_admin":false},"body":"## High Level Description\r\n\r\nFixes a nit in the integration test utilities;\r\n\r\n```python\r\nslaves = os.environ['SLAVE_HOSTS'].split(',')\r\n```\r\ninto\r\n```python\r\nslaves = list(filter(None, os.environ['SLAVE_HOSTS'].split(',')))\r\n```\r\nThis is meant to prevent the creation of arrays with one empty element if the source string was empty.\r\n\r\nConsider a cluster with one master and one single agent (which is public). Without this patch, the integration tests won't ever finish initializing:\r\n- SLAVE_HOSTS is empty -> renders a list of a single empty element\r\n- PUBLIC_SLAVE_HOSTS contains one IP -> renders a list of that IP\r\n- `all_slaves` is calculated from `slaves + public_slaves` -> renders a list of two elements `[ , IP]` \r\n\r\n= Number of slaves registered remains smaller than `all_slaves` and hence the integration tests basic cluster checkup will not ever finish waiting for that \"missing\" slave.\r\n\r\n## Related Issues\r\n\r\n  - [DCOS-<number>](https://dcosjira.atlassian.net/browse/DCOS-<number>) Foo the Bar so it stops Bazzing.\r\n  - [DCOS-<number>](https://mesosphere.atlassian.net/browse/DCOS-<number) TRACKING: dcosjira-123 Foo the Bar\r\n\r\n## Checklist for all PR's\r\n\r\n  - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n  - [ ] Test Results: [link to CI job test results for component]\r\n  - [ ] Code Coverage (if available): [link to code coverage report]\r\n___\r\n**PLEASE FILL IN THE TEMPLATE ABOVE** / **DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE**\r\n\r\n## Instructions and Review Process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require 2 approvals using github's [pull request reviews](https://help.github.com/articles/about-pull-request-reviews/).\r\n\r\nReviewers should be:\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has **2 ship-it's**, **no red reviews**, and **all tests are green** it will be included in the [next train](https://github.com/dcos/dcos/blob/master/contributing.md).\r\n","created_at":"2017-02-14T01:35:01Z","updated_at":"2017-03-21T18:07:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84527c234946678d60832038e08a4e65a7c614b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/1236/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/1236/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/1236/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/05627be2b02fb3d9ebd1f26bd44f2ebd9da76ee3","head":{"label":"mesosphere:till/fix-list-explode","ref":"till/fix-list-explode","sha":"05627be2b02fb3d9ebd1f26bd44f2ebd9da76ee3","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":62745648,"name":"dcos","full_name":"mesosphere/dcos","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars3.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/mesosphere/dcos","forks_url":"https://api.github.com/repos/mesosphere/dcos/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos/deployments","created_at":"2016-07-06T18:52:22Z","updated_at":"2017-03-13T09:18:45Z","pushed_at":"2017-03-21T17:19:33Z","git_url":"git://github.com/mesosphere/dcos.git","ssh_url":"git@github.com:mesosphere/dcos.git","clone_url":"https://github.com/mesosphere/dcos.git","svn_url":"https://github.com/mesosphere/dcos","homepage":"https://dcos.io","size":3778,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":12,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"45e8c469a5f0d1477266bc2597aff0adc3a4f817","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2017-03-21T09:45:01Z","pushed_at":"2017-03-21T17:31:28Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":3504,"stargazers_count":1439,"watchers_count":1439,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":67,"forks":252,"open_issues":67,"watchers":1439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1236"},"html":{"href":"https://github.com/dcos/dcos/pull/1236"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/1236"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/1236/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1236/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1236/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/05627be2b02fb3d9ebd1f26bd44f2ebd9da76ee3"}}}}
{"actor":{"display_login":"tillt"}}