{"action":"closed","number":1545,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1545","id":139906381,"html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1545","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1545.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1545.patch","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1545","number":1545,"state":"closed","locked":false,"title":"Provide more specific information in error/warning messages","user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"body":"This pull request is an attempt to provide more information about which element of a non-scalar policy parameter is being discussed in an error or warning message.  There are three kinds of non-scalar parameters: some are indexed by MARS, others are indexed by EIC, and a few are indexed by itemized-deduction-type.  The need for more information in the messages was pointed out by @hdoupe in the discussion of [TaxBrain pull request 641](https://github.com/OpenSourcePolicyCenter/webapp-public/pull/641#issuecomment-327893352).\r\n\r\nUsing the revised code in this pull request, the error and warning messages look like this:\r\n```\r\ntax-calculator$ cat ref.json\r\n{\"policy\": {\r\n    \"_II_rt2\": {\"2020\": [0.0]},\r\n    \"_II_brk2\": {\"2020\": [[10000, 10000, 10000, 10000, 10000]]},\r\n    \"_STD_Dep\": {\"2020\": [200]}\r\n}}\r\n\r\ntax-calculator$ tc cps.csv 2020 --reform ref.json\r\nERROR: 2020 _II_brk2_1 value 10000.0 < min value 19954.96 for _II_brk1_1\r\nERROR: 2020 _II_brk2_3 value 10000.0 < min value 14284.11 for _II_brk1_3\r\nERROR: 2020 _II_brk2_4 value 10000.0 < min value 19954.96 for _II_brk1_4\r\nERROR: 2021 _II_brk2_1 value 10233.0 < min value 20419.91 for _II_brk1_1\r\nERROR: 2021 _II_brk2_3 value 10233.0 < min value 14616.93 for _II_brk1_3\r\nERROR: 2021 _II_brk2_4 value 10233.0 < min value 20419.91 for _II_brk1_4\r\nERROR: 2022 _II_brk2_1 value 10470.41 < min value 20893.65 for _II_brk1_1\r\nERROR: 2022 _II_brk2_3 value 10470.41 < min value 14956.04 for _II_brk1_3\r\nERROR: 2022 _II_brk2_4 value 10470.41 < min value 20893.65 for _II_brk1_4\r\nERROR: 2023 _II_brk2_1 value 10714.37 < min value 21380.47 for _II_brk1_1\r\nERROR: 2023 _II_brk2_3 value 10714.37 < min value 15304.52 for _II_brk1_3\r\nERROR: 2023 _II_brk2_4 value 10714.37 < min value 21380.47 for _II_brk1_4\r\nERROR: 2024 _II_brk2_1 value 10964.01 < min value 21878.63 for _II_brk1_1\r\nERROR: 2024 _II_brk2_3 value 10964.01 < min value 15661.12 for _II_brk1_3\r\nERROR: 2024 _II_brk2_4 value 10964.01 < min value 21878.63 for _II_brk1_4\r\nERROR: 2025 _II_brk2_1 value 11220.57 < min value 22390.59 for _II_brk1_1\r\nERROR: 2025 _II_brk2_3 value 11220.57 < min value 16027.59 for _II_brk1_3\r\nERROR: 2025 _II_brk2_4 value 11220.57 < min value 22390.59 for _II_brk1_4\r\nERROR: 2026 _II_brk2_1 value 11484.25 < min value 22916.77 for _II_brk1_1\r\nERROR: 2026 _II_brk2_3 value 11484.25 < min value 16404.24 for _II_brk1_3\r\nERROR: 2026 _II_brk2_4 value 11484.25 < min value 22916.77 for _II_brk1_4\r\nWARNING: 2020 _STD_Dep value 200.0 < min value 1123.47\r\nWARNING: 2021 _STD_Dep value 204.66 < min value 1149.65\r\nWARNING: 2022 _STD_Dep value 209.41 < min value 1176.32\r\nWARNING: 2023 _STD_Dep value 214.29 < min value 1203.73\r\nWARNING: 2024 _STD_Dep value 219.28 < min value 1231.78\r\nWARNING: 2025 _STD_Dep value 224.41 < min value 1260.6\r\nWARNING: 2026 _STD_Dep value 229.68 < min value 1290.22\r\nUSAGE: tc --help\r\n```\r\n","created_at":"2017-09-07T21:13:35Z","updated_at":"2017-09-07T22:28:24Z","closed_at":"2017-09-07T22:28:24Z","merged_at":null,"merge_commit_sha":"ff6b1c6d34349f0cd94ff806cc9160e431e081f9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1545/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1545/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1545/comments","statuses_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/9ece17797a1fd580289567791b0c5b7c1f008e00","head":{"label":"martinholmer:fix-error-warning-messages","ref":"fix-error-warning-messages","sha":"9ece17797a1fd580289567791b0c5b7c1f008e00","user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"repo":{"id":39093370,"name":"Tax-Calculator","full_name":"martinholmer/Tax-Calculator","owner":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinholmer/Tax-Calculator","description":"Federal Individual Income Tax Microsimulation Model","fork":true,"url":"https://api.github.com/repos/martinholmer/Tax-Calculator","forks_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/forks","keys_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/teams","hooks_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/hooks","issue_events_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/events","assignees_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/tags","blobs_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/languages","stargazers_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/stargazers","contributors_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/contributors","subscribers_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/subscribers","subscription_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/subscription","commits_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/merges","archive_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/downloads","issues_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/deployments","created_at":"2015-07-14T18:36:41Z","updated_at":"2016-01-14T22:47:16Z","pushed_at":"2017-09-07T22:26:21Z","git_url":"git://github.com/martinholmer/Tax-Calculator.git","ssh_url":"git@github.com:martinholmer/Tax-Calculator.git","clone_url":"https://github.com/martinholmer/Tax-Calculator.git","svn_url":"https://github.com/martinholmer/Tax-Calculator","homepage":"","size":433401,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-source-economics:master","ref":"master","sha":"d0497151dae048e5941d8d478987617be4f41469","user":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":22389485,"name":"Tax-Calculator","full_name":"open-source-economics/Tax-Calculator","owner":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-source-economics/Tax-Calculator","description":"Federal Individual Income Tax Microsimulation Model","fork":false,"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator","forks_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/forks","keys_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/teams","hooks_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/events","assignees_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/tags","blobs_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/subscription","commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/merges","archive_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/downloads","issues_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/deployments","created_at":"2014-07-29T17:49:09Z","updated_at":"2017-08-12T15:56:16Z","pushed_at":"2017-09-07T22:26:22Z","git_url":"git://github.com/open-source-economics/Tax-Calculator.git","ssh_url":"git@github.com:open-source-economics/Tax-Calculator.git","clone_url":"https://github.com/open-source-economics/Tax-Calculator.git","svn_url":"https://github.com/open-source-economics/Tax-Calculator","homepage":"","size":433398,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":23,"forks":58,"open_issues":23,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1545"},"html":{"href":"https://github.com/open-source-economics/Tax-Calculator/pull/1545"},"issue":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1545"},"comments":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1545/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1545/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1545/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/9ece17797a1fd580289567791b0c5b7c1f008e00"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":16,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"martinholmer"}}