{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/137986851","pull_request_review_id":61723540,"id":137986851,"diff_hunk":"@@ -159,15 +184,19 @@ void AlphaAOVAccumulator::flush(ShadingResult& result)\n // AOVAccumulatorContainer class implementation.\n //\n \n-AOVAccumulatorContainer::AOVAccumulatorContainer(const AOVContainer& aovs)\n+AOVAccumulatorContainer::AOVAccumulatorContainer()\n   : m_size(0)\n {\n     memset(m_accumulators, 0, MaxAovAccumulators * sizeof(AOVAccumulator*));\n \n     // Create beauty and alpha accumulators.\n     insert(auto_release_ptr<AOVAccumulator>(new BeautyAOVAccumulator()));\n     insert(auto_release_ptr<AOVAccumulator>(new AlphaAOVAccumulator()));\n+}\n \n+AOVAccumulatorContainer::AOVAccumulatorContainer(const AOVContainer& aovs)\n+  : AOVAccumulatorContainer()","path":"src/appleseed/renderer/kernel/aov/aovaccumulator.cpp","position":48,"original_position":48,"commit_id":"5867744ac5ce690973bd2f3dabf29bd87c534828","original_commit_id":"5867744ac5ce690973bd2f3dabf29bd87c534828","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"I'm not questioning the usefulness of this constructor, but rather the usefulness of explicit calling the default constructor. What I hadn't realized though is that you're using C++11's constructor delegation? Still, the question holds.","created_at":"2017-09-11T06:15:43Z","updated_at":"2017-09-11T06:15:43Z","html_url":"https://github.com/appleseedhq/appleseed/pull/1613#discussion_r137986851","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/137986851"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1613#discussion_r137986851"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613"}},"in_reply_to_id":137957193},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613","id":139099067,"html_url":"https://github.com/appleseedhq/appleseed/pull/1613","diff_url":"https://github.com/appleseedhq/appleseed/pull/1613.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/1613.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1613","number":1613,"state":"open","locked":false,"title":"AOVs work","user":{"login":"est77","id":409013,"avatar_url":"https://avatars3.githubusercontent.com/u/409013?v=4","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"body":"- Removed shade alpha cutouts. Does not make sense after unpremultiplied rendering was removed.\r\n- Use only the beauty and alpha accumulators for progressive rendering.\r\n- Added direct and indirect diffuse and glossy AOVs.\r\n- AOV related classes refactors.\r\n","created_at":"2017-09-04T07:43:44Z","updated_at":"2017-09-11T06:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e517afc36c424f9c65a6e1680baacb2a856bebf4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1613/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/5867744ac5ce690973bd2f3dabf29bd87c534828","head":{"label":"est77:est_aov_work","ref":"est_aov_work","sha":"5867744ac5ce690973bd2f3dabf29bd87c534828","user":{"login":"est77","id":409013,"avatar_url":"https://avatars3.githubusercontent.com/u/409013?v=4","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"repo":{"id":10621343,"name":"appleseed","full_name":"est77/appleseed","owner":{"login":"est77","id":409013,"avatar_url":"https://avatars3.githubusercontent.com/u/409013?v=4","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/est77/appleseed","description":"appleseed is a modern, physically-based production renderer.","fork":true,"url":"https://api.github.com/repos/est77/appleseed","forks_url":"https://api.github.com/repos/est77/appleseed/forks","keys_url":"https://api.github.com/repos/est77/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/est77/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/est77/appleseed/teams","hooks_url":"https://api.github.com/repos/est77/appleseed/hooks","issue_events_url":"https://api.github.com/repos/est77/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/est77/appleseed/events","assignees_url":"https://api.github.com/repos/est77/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/est77/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/est77/appleseed/tags","blobs_url":"https://api.github.com/repos/est77/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/est77/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/est77/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/est77/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/est77/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/est77/appleseed/languages","stargazers_url":"https://api.github.com/repos/est77/appleseed/stargazers","contributors_url":"https://api.github.com/repos/est77/appleseed/contributors","subscribers_url":"https://api.github.com/repos/est77/appleseed/subscribers","subscription_url":"https://api.github.com/repos/est77/appleseed/subscription","commits_url":"https://api.github.com/repos/est77/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/est77/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/est77/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/est77/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/est77/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/est77/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/est77/appleseed/merges","archive_url":"https://api.github.com/repos/est77/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/est77/appleseed/downloads","issues_url":"https://api.github.com/repos/est77/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/est77/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/est77/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/est77/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/est77/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/est77/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/est77/appleseed/deployments","created_at":"2013-06-11T12:49:35Z","updated_at":"2015-04-30T17:28:14Z","pushed_at":"2017-09-10T13:44:43Z","git_url":"git://github.com/est77/appleseed.git","ssh_url":"git@github.com:est77/appleseed.git","clone_url":"https://github.com/est77/appleseed.git","svn_url":"https://github.com/est77/appleseed","homepage":"http://appleseedhq.net/","size":1038348,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"88d5f316069a69675094a3fb9080cbb3ee2ad95b","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2017-09-06T02:31:04Z","pushed_at":"2017-09-11T02:33:55Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"http://appleseedhq.net/","size":1106854,"stargazers_count":784,"watchers_count":784,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":272,"forks":143,"open_issues":272,"watchers":784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1613"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1613"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1613/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1613/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/5867744ac5ce690973bd2f3dabf29bd87c534828"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dictoon"}}