{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments/124410630","pull_request_review_id":46696427,"id":124410630,"diff_hunk":"@@ -1,13 +1,14 @@\n Gem::Specification.new do |s|\n   s.name          = 'logstash-input-tcp'\n-  s.version         = '4.1.2'\n+  s.version       = ::File.read('version').split(\"\\n\").first","path":"logstash-input-tcp.gemspec","position":4,"original_position":4,"commit_id":"56e0b7dc9661414bd1c50fd4dbbda5e5ad1780bd","original_commit_id":"4820342d258abd4d82d5a06e07baee2ecf9f7d37","user":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars2.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"body":"I've seen this pattern used in beats, dissect and others as well. https://github.com/logstash-plugins/logstash-input-beats/blob/master/logstash-input-beats.gemspec#L1\r\n\r\nJust a side note that we'll need to consolidate these approaches at some point...","created_at":"2017-06-27T22:16:12Z","updated_at":"2017-06-27T22:16:13Z","html_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/71#discussion_r124410630","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments/124410630"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-tcp/pull/71#discussion_r124410630"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71","id":127258220,"html_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/71","diff_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/71.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/71.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/71","number":71,"state":"open","locked":false,"title":"#7 Nio Plain Socket Server","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars3.githubusercontent.com/u/6490959?v=3","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"For #7 \r\n\r\n* Nonblocking Java NIO implementation of the event read-loop\r\n* Had to adjust 2 tests slightly to use an actual `write` instead of `puts` on the socket. `puts` triggers two subsequent writes and hence in some cases packets. In combination with non-blocking reads and no backchannel communication, this means that the pattern of `puts`, `flush`, `close` may actually drop some packets if the close comes too quickly\r\n* Put some effort into drying things up between ssl blocking and plain nio reads, but admittedly there is still room for improvement :)","created_at":"2017-06-23T17:57:22Z","updated_at":"2017-06-27T22:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"076a923003cd98177376ed9fabc4428730e28143","assignee":{"login":"jakelandis","id":976291,"avatar_url":"https://avatars1.githubusercontent.com/u/976291?v=3","gravatar_id":"","url":"https://api.github.com/users/jakelandis","html_url":"https://github.com/jakelandis","followers_url":"https://api.github.com/users/jakelandis/followers","following_url":"https://api.github.com/users/jakelandis/following{/other_user}","gists_url":"https://api.github.com/users/jakelandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelandis/subscriptions","organizations_url":"https://api.github.com/users/jakelandis/orgs","repos_url":"https://api.github.com/users/jakelandis/repos","events_url":"https://api.github.com/users/jakelandis/events{/privacy}","received_events_url":"https://api.github.com/users/jakelandis/received_events","type":"User","site_admin":false},"assignees":[{"login":"jakelandis","id":976291,"avatar_url":"https://avatars1.githubusercontent.com/u/976291?v=3","gravatar_id":"","url":"https://api.github.com/users/jakelandis","html_url":"https://github.com/jakelandis","followers_url":"https://api.github.com/users/jakelandis/followers","following_url":"https://api.github.com/users/jakelandis/following{/other_user}","gists_url":"https://api.github.com/users/jakelandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelandis/subscriptions","organizations_url":"https://api.github.com/users/jakelandis/orgs","repos_url":"https://api.github.com/users/jakelandis/repos","events_url":"https://api.github.com/users/jakelandis/events{/privacy}","received_events_url":"https://api.github.com/users/jakelandis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/71/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/statuses/56e0b7dc9661414bd1c50fd4dbbda5e5ad1780bd","head":{"label":"original-brownbear:nio","ref":"nio","sha":"56e0b7dc9661414bd1c50fd4dbbda5e5ad1780bd","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars3.githubusercontent.com/u/6490959?v=3","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"repo":{"id":94833579,"name":"logstash-input-tcp","full_name":"original-brownbear/logstash-input-tcp","owner":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars3.githubusercontent.com/u/6490959?v=3","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/original-brownbear/logstash-input-tcp","description":null,"fork":true,"url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp","forks_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/forks","keys_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/teams","hooks_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/hooks","issue_events_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/issues/events{/number}","events_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/events","assignees_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/assignees{/user}","branches_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/branches{/branch}","tags_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/tags","blobs_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/statuses/{sha}","languages_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/languages","stargazers_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/stargazers","contributors_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/contributors","subscribers_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/subscribers","subscription_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/subscription","commits_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/contents/{+path}","compare_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/merges","archive_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/downloads","issues_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/issues{/number}","pulls_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/pulls{/number}","milestones_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/milestones{/number}","notifications_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/labels{/name}","releases_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/releases{/id}","deployments_url":"https://api.github.com/repos/original-brownbear/logstash-input-tcp/deployments","created_at":"2017-06-20T00:48:39Z","updated_at":"2017-06-20T00:48:40Z","pushed_at":"2017-06-27T22:13:57Z","git_url":"git://github.com/original-brownbear/logstash-input-tcp.git","ssh_url":"git@github.com:original-brownbear/logstash-input-tcp.git","clone_url":"https://github.com/original-brownbear/logstash-input-tcp.git","svn_url":"https://github.com/original-brownbear/logstash-input-tcp","homepage":null,"size":160,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"bb233fe4e742b15fb9db118d8e7f7826afb27f99","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars2.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25312507,"name":"logstash-input-tcp","full_name":"logstash-plugins/logstash-input-tcp","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars2.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-tcp","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/deployments","created_at":"2014-10-16T17:03:48Z","updated_at":"2017-06-06T19:50:10Z","pushed_at":"2017-06-27T22:13:59Z","git_url":"git://github.com/logstash-plugins/logstash-input-tcp.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-tcp.git","clone_url":"https://github.com/logstash-plugins/logstash-input-tcp.git","svn_url":"https://github.com/logstash-plugins/logstash-input-tcp","homepage":null,"size":100,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":25,"forks":21,"open_issues":25,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-tcp/pull/71"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/71"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/statuses/56e0b7dc9661414bd1c50fd4dbbda5e5ad1780bd"}}}}
{"actor":{"display_login":"suyograo"}}