{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/110534000","pull_request_review_id":31716805,"id":110534000,"diff_hunk":"@@ -783,27 +783,27 @@ void OSDMap::Incremental::dump(Formatter *f) const\n   f->close_section();\n \n   f->open_array_section(\"osd_state_xor\");\n-  for (const auto &elemm : new_state) {\n+  for (const auto &ns : new_state) {\n     f->open_object_section(\"osd\");\n-    f->dump_int(\"osd\", elemm.first);\n+    f->dump_int(\"osd\", ns.first);\n     set<string> st;\n-    calc_state_set(new_state.find(elemm.first)->second, st);\n+    calc_state_set(new_state.find(ns.first)->second, st);\n     f->open_array_section(\"state_xor\");\n-    for (auto &elems : st)\n-      f->dump_string(\"state\", elems);\n+    for (auto &elemst : st)","path":"src/osd/OSDMap.cc","position":null,"original_position":152,"commit_id":"4a17e91d34a7b9b4281fce084ea762ff73e94d45","original_commit_id":"4a17e91d34a7b9b4281fce084ea762ff73e94d45","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars1.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"s/elemst/state/","created_at":"2017-04-09T06:30:04Z","updated_at":"2017-04-09T06:44:40Z","html_url":"https://github.com/ceph/ceph/pull/14381#discussion_r110534000","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/14381","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/110534000"},"html":{"href":"https://github.com/ceph/ceph/pull/14381#discussion_r110534000"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/14381"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/14381","id":114744685,"html_url":"https://github.com/ceph/ceph/pull/14381","diff_url":"https://github.com/ceph/ceph/pull/14381.diff","patch_url":"https://github.com/ceph/ceph/pull/14381.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/14381","number":14381,"state":"open","locked":false,"title":"osd: Cleanup-Updated OSDMap.cc with C++11 style range-for loops","user":{"login":"joscollin","id":23738514,"avatar_url":"https://avatars2.githubusercontent.com/u/23738514?v=3","gravatar_id":"","url":"https://api.github.com/users/joscollin","html_url":"https://github.com/joscollin","followers_url":"https://api.github.com/users/joscollin/followers","following_url":"https://api.github.com/users/joscollin/following{/other_user}","gists_url":"https://api.github.com/users/joscollin/gists{/gist_id}","starred_url":"https://api.github.com/users/joscollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscollin/subscriptions","organizations_url":"https://api.github.com/users/joscollin/orgs","repos_url":"https://api.github.com/users/joscollin/repos","events_url":"https://api.github.com/users/joscollin/events{/privacy}","received_events_url":"https://api.github.com/users/joscollin/received_events","type":"User","site_admin":false},"body":"Updated OSDMap.cc with C++11 style range-for loops in template iterations for better\nreadability. Also replaced some iterator types with auto, which stores the return value of find().\n\nSigned-off-by: Jos Collin <jcollin@redhat.com>","created_at":"2017-04-07T05:09:20Z","updated_at":"2017-04-09T06:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff90e19a2024f5513b824f695e3c3a338f9043af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/14381/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/14381/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/14381/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/4a17e91d34a7b9b4281fce084ea762ff73e94d45","head":{"label":"joscollin:wip-cleanup-osdmap-rangefor","ref":"wip-cleanup-osdmap-rangefor","sha":"4a17e91d34a7b9b4281fce084ea762ff73e94d45","user":{"login":"joscollin","id":23738514,"avatar_url":"https://avatars2.githubusercontent.com/u/23738514?v=3","gravatar_id":"","url":"https://api.github.com/users/joscollin","html_url":"https://github.com/joscollin","followers_url":"https://api.github.com/users/joscollin/followers","following_url":"https://api.github.com/users/joscollin/following{/other_user}","gists_url":"https://api.github.com/users/joscollin/gists{/gist_id}","starred_url":"https://api.github.com/users/joscollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscollin/subscriptions","organizations_url":"https://api.github.com/users/joscollin/orgs","repos_url":"https://api.github.com/users/joscollin/repos","events_url":"https://api.github.com/users/joscollin/events{/privacy}","received_events_url":"https://api.github.com/users/joscollin/received_events","type":"User","site_admin":false},"repo":{"id":82140012,"name":"ceph","full_name":"joscollin/ceph","owner":{"login":"joscollin","id":23738514,"avatar_url":"https://avatars2.githubusercontent.com/u/23738514?v=3","gravatar_id":"","url":"https://api.github.com/users/joscollin","html_url":"https://github.com/joscollin","followers_url":"https://api.github.com/users/joscollin/followers","following_url":"https://api.github.com/users/joscollin/following{/other_user}","gists_url":"https://api.github.com/users/joscollin/gists{/gist_id}","starred_url":"https://api.github.com/users/joscollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscollin/subscriptions","organizations_url":"https://api.github.com/users/joscollin/orgs","repos_url":"https://api.github.com/users/joscollin/repos","events_url":"https://api.github.com/users/joscollin/events{/privacy}","received_events_url":"https://api.github.com/users/joscollin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joscollin/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/joscollin/ceph","forks_url":"https://api.github.com/repos/joscollin/ceph/forks","keys_url":"https://api.github.com/repos/joscollin/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joscollin/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joscollin/ceph/teams","hooks_url":"https://api.github.com/repos/joscollin/ceph/hooks","issue_events_url":"https://api.github.com/repos/joscollin/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/joscollin/ceph/events","assignees_url":"https://api.github.com/repos/joscollin/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/joscollin/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/joscollin/ceph/tags","blobs_url":"https://api.github.com/repos/joscollin/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joscollin/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joscollin/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/joscollin/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joscollin/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/joscollin/ceph/languages","stargazers_url":"https://api.github.com/repos/joscollin/ceph/stargazers","contributors_url":"https://api.github.com/repos/joscollin/ceph/contributors","subscribers_url":"https://api.github.com/repos/joscollin/ceph/subscribers","subscription_url":"https://api.github.com/repos/joscollin/ceph/subscription","commits_url":"https://api.github.com/repos/joscollin/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/joscollin/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/joscollin/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/joscollin/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/joscollin/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/joscollin/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joscollin/ceph/merges","archive_url":"https://api.github.com/repos/joscollin/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joscollin/ceph/downloads","issues_url":"https://api.github.com/repos/joscollin/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/joscollin/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/joscollin/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/joscollin/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joscollin/ceph/labels{/name}","releases_url":"https://api.github.com/repos/joscollin/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/joscollin/ceph/deployments","created_at":"2017-02-16T04:43:17Z","updated_at":"2017-02-16T04:43:41Z","pushed_at":"2017-04-09T06:11:08Z","git_url":"git://github.com/joscollin/ceph.git","ssh_url":"git@github.com:joscollin/ceph.git","clone_url":"https://github.com/joscollin/ceph.git","svn_url":"https://github.com/joscollin/ceph","homepage":"http://ceph.com","size":200547,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"2950ad91d25d0d6e2e3fb6842d5bbc36353ba2a5","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars0.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars0.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-04-08T19:11:03Z","pushed_at":"2017-04-09T06:11:11Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":201558,"stargazers_count":3090,"watchers_count":3090,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1823,"mirror_url":null,"open_issues_count":536,"forks":1823,"open_issues":536,"watchers":3090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/14381"},"html":{"href":"https://github.com/ceph/ceph/pull/14381"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/14381"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/14381/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/14381/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/14381/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/4a17e91d34a7b9b4281fce084ea762ff73e94d45"}}}}
{"actor":{"display_login":"tchaikov"}}