{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker-ce/pulls/comments/149214530","pull_request_review_id":74574758,"id":149214530,"diff_hunk":"@@ -70,6 +71,10 @@ const (\n // of docker.\n const defaultOwner = \"docker\"\n \n+func (c *client) Version(ctx context.Context) (containerd.Version, error) {\n+\treturn containerd.Version{}, errors.New(\"not implemented on Windows\")","path":"components/engine/libcontainerd/client_local_windows.go","position":13,"original_position":13,"commit_id":"90d2a2e2749899f06db5546412726bc35fd862cf","original_commit_id":"90d2a2e2749899f06db5546412726bc35fd862cf","user":{"login":"andrewhsu","id":57640,"avatar_url":"https://avatars0.githubusercontent.com/u/57640?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhsu","html_url":"https://github.com/andrewhsu","followers_url":"https://api.github.com/users/andrewhsu/followers","following_url":"https://api.github.com/users/andrewhsu/following{/other_user}","gists_url":"https://api.github.com/users/andrewhsu/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhsu/subscriptions","organizations_url":"https://api.github.com/users/andrewhsu/orgs","repos_url":"https://api.github.com/users/andrewhsu/repos","events_url":"https://api.github.com/users/andrewhsu/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhsu/received_events","type":"User","site_admin":false},"body":"this will not be a problem on docker for windows, will it? @johnstep @gtardif ","created_at":"2017-11-06T21:52:30Z","updated_at":"2017-11-06T21:52:30Z","html_url":"https://github.com/docker/docker-ce/pull/292#discussion_r149214530","pull_request_url":"https://api.github.com/repos/docker/docker-ce/pulls/292","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/comments/149214530"},"html":{"href":"https://github.com/docker/docker-ce/pull/292#discussion_r149214530"},"pull_request":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker-ce/pulls/292","id":150847970,"html_url":"https://github.com/docker/docker-ce/pull/292","diff_url":"https://github.com/docker/docker-ce/pull/292.diff","patch_url":"https://github.com/docker/docker-ce/pull/292.patch","issue_url":"https://api.github.com/repos/docker/docker-ce/issues/292","number":292,"state":"open","locked":false,"title":"[17.11] Use containerd API to get version","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Backport of https://github.com/moby/moby/pull/35389 for 17.11\r\n\r\n    git cherry-pick -s -S -x -Xsubtree=components/engine fec2b144feaaa18998ec2ed34c9bc843c4c29abd\r\n\r\nThe `docker info` code was shelling out to obtain the version of containerd (using the `--version` flag).\r\n\r\nParsing the output of this version string is error-prone, and not needed, as the containerd API can return the version.\r\n\r\nThis patch adds a `Version()` method to the containerd Client interface, and uses this to get the containerd version.\r\n\r\n(cherry picked from commit fec2b144feaaa18998ec2ed34c9bc843c4c29abd)\r\n\r\nping @mlaventure @gtardif PTAL","created_at":"2017-11-06T13:07:31Z","updated_at":"2017-11-06T21:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"093002e562fc009dc503f31a2b29a727b0484a83","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gtardif","id":437958,"avatar_url":"https://avatars0.githubusercontent.com/u/437958?v=4","gravatar_id":"","url":"https://api.github.com/users/gtardif","html_url":"https://github.com/gtardif","followers_url":"https://api.github.com/users/gtardif/followers","following_url":"https://api.github.com/users/gtardif/following{/other_user}","gists_url":"https://api.github.com/users/gtardif/gists{/gist_id}","starred_url":"https://api.github.com/users/gtardif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtardif/subscriptions","organizations_url":"https://api.github.com/users/gtardif/orgs","repos_url":"https://api.github.com/users/gtardif/repos","events_url":"https://api.github.com/users/gtardif/events{/privacy}","received_events_url":"https://api.github.com/users/gtardif/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/docker/docker-ce/milestones/10","html_url":"https://github.com/docker/docker-ce/milestone/10","labels_url":"https://api.github.com/repos/docker/docker-ce/milestones/10/labels","id":2875592,"number":10,"title":"17.11.0","description":"","creator":{"login":"andrewhsu","id":57640,"avatar_url":"https://avatars0.githubusercontent.com/u/57640?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhsu","html_url":"https://github.com/andrewhsu","followers_url":"https://api.github.com/users/andrewhsu/followers","following_url":"https://api.github.com/users/andrewhsu/following{/other_user}","gists_url":"https://api.github.com/users/andrewhsu/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhsu/subscriptions","organizations_url":"https://api.github.com/users/andrewhsu/orgs","repos_url":"https://api.github.com/users/andrewhsu/repos","events_url":"https://api.github.com/users/andrewhsu/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhsu/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":11,"state":"open","created_at":"2017-10-30T18:10:51Z","updated_at":"2017-11-06T21:33:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker-ce/pulls/292/commits","review_comments_url":"https://api.github.com/repos/docker/docker-ce/pulls/292/comments","review_comment_url":"https://api.github.com/repos/docker/docker-ce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker-ce/issues/292/comments","statuses_url":"https://api.github.com/repos/docker/docker-ce/statuses/90d2a2e2749899f06db5546412726bc35fd862cf","head":{"label":"thaJeztah:17.11-backport-improve-containerd-version-parsing","ref":"17.11-backport-improve-containerd-version-parsing","sha":"90d2a2e2749899f06db5546412726bc35fd862cf","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"repo":{"id":95494102,"name":"docker-ce","full_name":"thaJeztah/docker-ce","owner":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thaJeztah/docker-ce","description":"Docker CE","fork":true,"url":"https://api.github.com/repos/thaJeztah/docker-ce","forks_url":"https://api.github.com/repos/thaJeztah/docker-ce/forks","keys_url":"https://api.github.com/repos/thaJeztah/docker-ce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thaJeztah/docker-ce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thaJeztah/docker-ce/teams","hooks_url":"https://api.github.com/repos/thaJeztah/docker-ce/hooks","issue_events_url":"https://api.github.com/repos/thaJeztah/docker-ce/issues/events{/number}","events_url":"https://api.github.com/repos/thaJeztah/docker-ce/events","assignees_url":"https://api.github.com/repos/thaJeztah/docker-ce/assignees{/user}","branches_url":"https://api.github.com/repos/thaJeztah/docker-ce/branches{/branch}","tags_url":"https://api.github.com/repos/thaJeztah/docker-ce/tags","blobs_url":"https://api.github.com/repos/thaJeztah/docker-ce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thaJeztah/docker-ce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thaJeztah/docker-ce/git/refs{/sha}","trees_url":"https://api.github.com/repos/thaJeztah/docker-ce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thaJeztah/docker-ce/statuses/{sha}","languages_url":"https://api.github.com/repos/thaJeztah/docker-ce/languages","stargazers_url":"https://api.github.com/repos/thaJeztah/docker-ce/stargazers","contributors_url":"https://api.github.com/repos/thaJeztah/docker-ce/contributors","subscribers_url":"https://api.github.com/repos/thaJeztah/docker-ce/subscribers","subscription_url":"https://api.github.com/repos/thaJeztah/docker-ce/subscription","commits_url":"https://api.github.com/repos/thaJeztah/docker-ce/commits{/sha}","git_commits_url":"https://api.github.com/repos/thaJeztah/docker-ce/git/commits{/sha}","comments_url":"https://api.github.com/repos/thaJeztah/docker-ce/comments{/number}","issue_comment_url":"https://api.github.com/repos/thaJeztah/docker-ce/issues/comments{/number}","contents_url":"https://api.github.com/repos/thaJeztah/docker-ce/contents/{+path}","compare_url":"https://api.github.com/repos/thaJeztah/docker-ce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thaJeztah/docker-ce/merges","archive_url":"https://api.github.com/repos/thaJeztah/docker-ce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thaJeztah/docker-ce/downloads","issues_url":"https://api.github.com/repos/thaJeztah/docker-ce/issues{/number}","pulls_url":"https://api.github.com/repos/thaJeztah/docker-ce/pulls{/number}","milestones_url":"https://api.github.com/repos/thaJeztah/docker-ce/milestones{/number}","notifications_url":"https://api.github.com/repos/thaJeztah/docker-ce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thaJeztah/docker-ce/labels{/name}","releases_url":"https://api.github.com/repos/thaJeztah/docker-ce/releases{/id}","deployments_url":"https://api.github.com/repos/thaJeztah/docker-ce/deployments","created_at":"2017-06-26T22:16:37Z","updated_at":"2017-06-26T22:16:46Z","pushed_at":"2017-11-06T13:12:24Z","git_url":"git://github.com/thaJeztah/docker-ce.git","ssh_url":"git@github.com:thaJeztah/docker-ce.git","clone_url":"https://github.com/thaJeztah/docker-ce.git","svn_url":"https://github.com/thaJeztah/docker-ce","homepage":"https://www.docker.com/community-edition","size":132370,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:17.11","ref":"17.11","sha":"d7062e5443166bb01b04d999347d22d742fdf848","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":91851756,"name":"docker-ce","full_name":"docker/docker-ce","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker-ce","description":"Docker CE","fork":false,"url":"https://api.github.com/repos/docker/docker-ce","forks_url":"https://api.github.com/repos/docker/docker-ce/forks","keys_url":"https://api.github.com/repos/docker/docker-ce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker-ce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker-ce/teams","hooks_url":"https://api.github.com/repos/docker/docker-ce/hooks","issue_events_url":"https://api.github.com/repos/docker/docker-ce/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker-ce/events","assignees_url":"https://api.github.com/repos/docker/docker-ce/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker-ce/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker-ce/tags","blobs_url":"https://api.github.com/repos/docker/docker-ce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker-ce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker-ce/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker-ce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker-ce/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker-ce/languages","stargazers_url":"https://api.github.com/repos/docker/docker-ce/stargazers","contributors_url":"https://api.github.com/repos/docker/docker-ce/contributors","subscribers_url":"https://api.github.com/repos/docker/docker-ce/subscribers","subscription_url":"https://api.github.com/repos/docker/docker-ce/subscription","commits_url":"https://api.github.com/repos/docker/docker-ce/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker-ce/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker-ce/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker-ce/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker-ce/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker-ce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker-ce/merges","archive_url":"https://api.github.com/repos/docker/docker-ce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker-ce/downloads","issues_url":"https://api.github.com/repos/docker/docker-ce/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker-ce/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker-ce/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker-ce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker-ce/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker-ce/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker-ce/deployments","created_at":"2017-05-19T23:09:47Z","updated_at":"2017-11-06T18:33:09Z","pushed_at":"2017-11-06T21:33:58Z","git_url":"git://github.com/docker/docker-ce.git","ssh_url":"git@github.com:docker/docker-ce.git","clone_url":"https://github.com/docker/docker-ce.git","svn_url":"https://github.com/docker/docker-ce","homepage":"https://www.docker.com/community-edition","size":132584,"stargazers_count":449,"watchers_count":449,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"archived":false,"open_issues_count":24,"forks":140,"open_issues":24,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/292"},"html":{"href":"https://github.com/docker/docker-ce/pull/292"},"issue":{"href":"https://api.github.com/repos/docker/docker-ce/issues/292"},"comments":{"href":"https://api.github.com/repos/docker/docker-ce/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker-ce/statuses/90d2a2e2749899f06db5546412726bc35fd862cf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andrewhsu"}}