{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/5855","repository_url":"https://api.github.com/repos/puppetlabs/puppet","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5855/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5855/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5855/events","html_url":"https://github.com/puppetlabs/puppet/pull/5855","id":227878908,"number":5855,"title":"(PUP-7519) Enabling rubocop securitycop scans","user":{"login":"jsane","id":25072698,"avatar_url":"https://avatars1.githubusercontent.com/u/25072698?v=3","gravatar_id":"","url":"https://api.github.com/users/jsane","html_url":"https://github.com/jsane","followers_url":"https://api.github.com/users/jsane/followers","following_url":"https://api.github.com/users/jsane/following{/other_user}","gists_url":"https://api.github.com/users/jsane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsane/subscriptions","organizations_url":"https://api.github.com/users/jsane/orgs","repos_url":"https://api.github.com/users/jsane/repos","events_url":"https://api.github.com/users/jsane/events{/privacy}","received_events_url":"https://api.github.com/users/jsane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-11T05:03:34Z","updated_at":"2017-05-11T05:45:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5855","html_url":"https://github.com/puppetlabs/puppet/pull/5855","diff_url":"https://github.com/puppetlabs/puppet/pull/5855.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5855.patch"},"body":"Background: Rubocop scans were not running as the various cops in .rubocop.yml were not kept uptodate with the latest definitions. This will enable only SecurityCop/YAMLLoad as a start to revive the scans in an effort to flag any inadvertent usages.  Additional security or other cop rules can/would be added in future.   \r\nRubocop do not have support for flagging YAML.load_file which would have been desirable. Likewise it is not necessary to mark the known instance of Yaml.load_file in Puppet::Util::Yaml to be ignored.\r\n\r\nNote that there are a couple of other YAML.load instances elsewhere so this may generate violations. If that is not desired this PR be merged after all these have been resolved/changed appropriately. "},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/300688606","html_url":"https://github.com/puppetlabs/puppet/pull/5855#issuecomment-300688606","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5855","id":300688606,"user":{"login":"jsane","id":25072698,"avatar_url":"https://avatars1.githubusercontent.com/u/25072698?v=3","gravatar_id":"","url":"https://api.github.com/users/jsane","html_url":"https://github.com/jsane","followers_url":"https://api.github.com/users/jsane/followers","following_url":"https://api.github.com/users/jsane/following{/other_user}","gists_url":"https://api.github.com/users/jsane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsane/subscriptions","organizations_url":"https://api.github.com/users/jsane/orgs","repos_url":"https://api.github.com/users/jsane/repos","events_url":"https://api.github.com/users/jsane/events{/privacy}","received_events_url":"https://api.github.com/users/jsane/received_events","type":"User","site_admin":false},"created_at":"2017-05-11T05:45:56Z","updated_at":"2017-05-11T05:45:56Z","body":"Huh! looks like the rubocop version used in Travis does not recognize Security/YAMLLoad(?). Will figure and push the needed changes again."}}
{"actor":{"display_login":"jsane"}}