{"action":"created","issue":{"url":"https://api.github.com/repos/bioinf-jku/coulomb_gan/issues/1","repository_url":"https://api.github.com/repos/bioinf-jku/coulomb_gan","labels_url":"https://api.github.com/repos/bioinf-jku/coulomb_gan/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/bioinf-jku/coulomb_gan/issues/1/comments","events_url":"https://api.github.com/repos/bioinf-jku/coulomb_gan/issues/1/events","html_url":"https://github.com/bioinf-jku/coulomb_gan/issues/1","id":259360266,"number":1,"title":"Why does not stop gradient for a?","user":{"login":"khanrc","id":3657248,"avatar_url":"https://avatars1.githubusercontent.com/u/3657248?v=4","gravatar_id":"","url":"https://api.github.com/users/khanrc","html_url":"https://github.com/khanrc","followers_url":"https://api.github.com/users/khanrc/followers","following_url":"https://api.github.com/users/khanrc/following{/other_user}","gists_url":"https://api.github.com/users/khanrc/gists{/gist_id}","starred_url":"https://api.github.com/users/khanrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khanrc/subscriptions","organizations_url":"https://api.github.com/users/khanrc/orgs","repos_url":"https://api.github.com/users/khanrc/repos","events_url":"https://api.github.com/users/khanrc/events{/privacy}","received_events_url":"https://api.github.com/users/khanrc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-21T02:52:11Z","updated_at":"2017-09-21T09:24:47Z","closed_at":null,"author_association":"NONE","body":"Hi, thanks for this interesting work. I recently implemented CoulombGAN in my project (https://github.com/khanrc/tf.gans-comparison) and I had two questions.\r\n\r\nWhen calculating the potential, stop the gradients only for x and y. I think we should stop gradients for a too, isn't it?\r\n\r\nAlso, is there no convergence measure? I expected that the potential of fake samples serve as a convergence measure, but it did not."},"comment":{"url":"https://api.github.com/repos/bioinf-jku/coulomb_gan/issues/comments/331102247","html_url":"https://github.com/bioinf-jku/coulomb_gan/issues/1#issuecomment-331102247","issue_url":"https://api.github.com/repos/bioinf-jku/coulomb_gan/issues/1","id":331102247,"user":{"login":"untom","id":3627551,"avatar_url":"https://avatars2.githubusercontent.com/u/3627551?v=4","gravatar_id":"","url":"https://api.github.com/users/untom","html_url":"https://github.com/untom","followers_url":"https://api.github.com/users/untom/followers","following_url":"https://api.github.com/users/untom/following{/other_user}","gists_url":"https://api.github.com/users/untom/gists{/gist_id}","starred_url":"https://api.github.com/users/untom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untom/subscriptions","organizations_url":"https://api.github.com/users/untom/orgs","repos_url":"https://api.github.com/users/untom/repos","events_url":"https://api.github.com/users/untom/events{/privacy}","received_events_url":"https://api.github.com/users/untom/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T09:24:47Z","updated_at":"2017-09-21T09:24:47Z","author_association":"OWNER","body":"You are right, they aren't needed the way everything is set up, but e.g. if one would forget to filter out which variables to update when learning the discriminator (see [here](https://github.com/bioinf-jku/coulomb_gan/blob/master/train.py#L101)) one could end up updating the generator with the discriminator loss by mistake. So I thought better be safe than sorry ;)"}}
{"actor":{"display_login":"untom"}}