{"action":"created","issue":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary-site/issues/40","repository_url":"https://api.github.com/repos/sanctuary-js/sanctuary-site","labels_url":"https://api.github.com/repos/sanctuary-js/sanctuary-site/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-site/issues/40/comments","events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-site/issues/40/events","html_url":"https://github.com/sanctuary-js/sanctuary-site/pull/40","id":264578641,"number":40,"title":"behaviour: improve discoverability of editable snippets","user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars2.githubusercontent.com/u/210406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-11T13:04:32Z","updated_at":"2017-11-28T15:37:28Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary-site/pulls/40","html_url":"https://github.com/sanctuary-js/sanctuary-site/pull/40","diff_url":"https://github.com/sanctuary-js/sanctuary-site/pull/40.diff","patch_url":"https://github.com/sanctuary-js/sanctuary-site/pull/40.patch"},"body":"Closes #38\r\n\r\nIf you'd like to review this pull request, I suggest trying it before looking at the code.\r\n\r\nRun the following commands to view the website locally:\r\n\r\n    $ git clone git@github.com:sanctuary-js/sanctuary-site.git\r\n    $ cd sanctuary-site\r\n    $ git checkout davidchambers/editable\r\n    $ open index.html\r\n\r\nI look forward to your feedback. :)\r\n\r\n/cc @foxdonut, @laduke\r\n"},"comment":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary-site/issues/comments/347562486","html_url":"https://github.com/sanctuary-js/sanctuary-site/pull/40#issuecomment-347562486","issue_url":"https://api.github.com/repos/sanctuary-js/sanctuary-site/issues/40","id":347562486,"user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars2.githubusercontent.com/u/210406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"created_at":"2017-11-28T15:37:28Z","updated_at":"2017-11-28T15:37:28Z","author_association":"OWNER","body":"@JAForbes provided excellent feedback privately via Gitter. I intend to explore his suggestions, but more than a month has passed and I am yet to do so. I will merge this pull request as is. I hope to address James's concerns in a future pull request. For future reference, here is James's feedback:\r\n\r\n> I think you need some blind user testing to confirm this, but I think you'll still have discoverability issues, that border transition is pretty subtle, and if they miss that sequence (say they load the page at an anchor 1/2 way down the page when searching google, or they scroll too quickly) that could be unfortunate.\r\n>\r\n> I'd be a little bit more bold, keep the existing transition and all the other subtle touches you've done, but on desktop add some opacity and scale.\r\n>\r\n> A default opacity that is almost annoying to read (0.5/0.7) will encourage them to interact with it (at least in my experience making games). And then on hover, transition to 1 and scale up a tiny but noticeable amount, that communicates: hey user, you're onto something, keep exploring!\r\n>\r\n> Then I think the flashing cursor and the context will give you a very high hit rate in testing, maybe 80%-90%, I think right now, it'd be ~60%\r\n>\r\n> I'd only do this on desktop, I think it'd be hit and miss on mobile.\r\n>\r\n> I tried it out locally and thought it wasn't too garish.\r\n>\r\n> But! I think its good as is, I just worry its a bit too subtle and that amazing text animation is easy to miss. So if you are happy to release this I think that's a good call too!\r\n"}}
{"actor":{"display_login":"davidchambers"}}