{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/97863756","pull_request_review_id":18487039,"id":97863756,"diff_hunk":"@@ -251,7 +255,13 @@ class ArchetypeBuilder {\n                             RequirementSource Source);\n \n   /// \\brief Add all of a generic signature's parameters and requirements.\n-  void addGenericSignature(GenericSignature *sig);\n+  ///\n+  /// \\param protocolRequirementSig If true, computes the protocol requirement\n+  /// signature (generic signature containing exactly the requirements\n+  /// introduced by a protocol) of \\c sig, which is expected to be the generic\n+  /// signature of a protocol, i.e. \\c <Self where Self : Protocol>.\n+  void addGenericSignature(GenericSignature *sig,","path":"include/swift/AST/ArchetypeBuilder.h","position":21,"original_position":21,"commit_id":"28d22342594d15cc4b15970b304771d0ffee670c","original_commit_id":"b07e0c104d2c917d2e17d630e76d85de1e43d5d2","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"That sounds like it will be much better.","created_at":"2017-01-25T19:49:46Z","updated_at":"2017-01-25T19:49:46Z","html_url":"https://github.com/apple/swift/pull/7029#discussion_r97863756","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/7029","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/97863756"},"html":{"href":"https://github.com/apple/swift/pull/7029#discussion_r97863756"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/7029"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/7029","id":103179628,"html_url":"https://github.com/apple/swift/pull/7029","diff_url":"https://github.com/apple/swift/pull/7029.diff","patch_url":"https://github.com/apple/swift/pull/7029.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/7029","number":7029,"state":"open","locked":false,"title":"[AST] Introduce the notion of a protocol requirement signature.","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"This is a generic signature that stores exactly the requirements that a\r\nprotocol decl introduces, not letting them be implied by the Self :\r\nProtocol requirement, nor storing any requirements introduced by the\r\nprotocols requirements.\r\n\r\nSpecifically, suppose we have\r\n\r\n    protocol Foo {}\r\n    protocol Bar {}\r\n\r\n    protocol Baz {\r\n        associatedtype X : Foo\r\n    }\r\n    protocol Qux: Baz {\r\n        associatedtype X : Bar\r\n    }\r\n\r\nThe normal generic signature and (canonical) protocol requirement\r\nsignature of `Baz` will be, respectively\r\n\r\n    <Self where Self : Baz>\r\n    <Self where Self : Baz, Self.X : Foo>\r\n\r\nAnd for `Qux`, they will be:\r\n\r\n    <Self where Self : Qux>\r\n    <Self where Self : Qux, Self : Baz, Self.X : Bar>\r\n\r\nNote that the `Self.X : Foo` requirement is not listed.\r\n\r\nFor the moment, this is unused except for `-debug-generic-signatures`.","created_at":"2017-01-25T18:49:30Z","updated_at":"2017-01-25T19:49:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"052020659a8408598e8293453fd5c05f4d3a117d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/7029/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/7029/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/7029/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/28d22342594d15cc4b15970b304771d0ffee670c","head":{"label":"huonw:protocol-self-signature","ref":"protocol-self-signature","sha":"28d22342594d15cc4b15970b304771d0ffee670c","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"repo":{"id":67061123,"name":"swift","full_name":"huonw/swift","owner":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huonw/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/huonw/swift","forks_url":"https://api.github.com/repos/huonw/swift/forks","keys_url":"https://api.github.com/repos/huonw/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huonw/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huonw/swift/teams","hooks_url":"https://api.github.com/repos/huonw/swift/hooks","issue_events_url":"https://api.github.com/repos/huonw/swift/issues/events{/number}","events_url":"https://api.github.com/repos/huonw/swift/events","assignees_url":"https://api.github.com/repos/huonw/swift/assignees{/user}","branches_url":"https://api.github.com/repos/huonw/swift/branches{/branch}","tags_url":"https://api.github.com/repos/huonw/swift/tags","blobs_url":"https://api.github.com/repos/huonw/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huonw/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huonw/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/huonw/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huonw/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/huonw/swift/languages","stargazers_url":"https://api.github.com/repos/huonw/swift/stargazers","contributors_url":"https://api.github.com/repos/huonw/swift/contributors","subscribers_url":"https://api.github.com/repos/huonw/swift/subscribers","subscription_url":"https://api.github.com/repos/huonw/swift/subscription","commits_url":"https://api.github.com/repos/huonw/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/huonw/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/huonw/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/huonw/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/huonw/swift/contents/{+path}","compare_url":"https://api.github.com/repos/huonw/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huonw/swift/merges","archive_url":"https://api.github.com/repos/huonw/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huonw/swift/downloads","issues_url":"https://api.github.com/repos/huonw/swift/issues{/number}","pulls_url":"https://api.github.com/repos/huonw/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/huonw/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/huonw/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huonw/swift/labels{/name}","releases_url":"https://api.github.com/repos/huonw/swift/releases{/id}","deployments_url":"https://api.github.com/repos/huonw/swift/deployments","created_at":"2016-08-31T18:00:30Z","updated_at":"2016-08-31T18:00:55Z","pushed_at":"2017-01-25T19:43:37Z","git_url":"git://github.com/huonw/swift.git","ssh_url":"git@github.com:huonw/swift.git","clone_url":"https://github.com/huonw/swift.git","svn_url":"https://github.com/huonw/swift","homepage":"https://swift.org/","size":155096,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"6267f47959ae5a578299a33f94022ff9399c179b","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-01-25T19:45:42Z","pushed_at":"2017-01-25T19:43:40Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":157578,"stargazers_count":36344,"watchers_count":36344,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5295,"mirror_url":null,"open_issues_count":119,"forks":5295,"open_issues":119,"watchers":36344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/7029"},"html":{"href":"https://github.com/apple/swift/pull/7029"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/7029"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/7029/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/7029/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/7029/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/28d22342594d15cc4b15970b304771d0ffee670c"}}}}
{"actor":{"display_login":"huonw"}}