{"action":"closed","number":20034,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/20034","id":130347306,"html_url":"https://github.com/laravel/framework/pull/20034","diff_url":"https://github.com/laravel/framework/pull/20034.diff","patch_url":"https://github.com/laravel/framework/pull/20034.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/20034","number":20034,"state":"closed","locked":false,"title":"[5.5] Cache: allows DateInterface and DateInterval","user":{"login":"lucasmichot","id":513603,"avatar_url":"https://avatars2.githubusercontent.com/u/513603?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmichot","html_url":"https://github.com/lucasmichot","followers_url":"https://api.github.com/users/lucasmichot/followers","following_url":"https://api.github.com/users/lucasmichot/following{/other_user}","gists_url":"https://api.github.com/users/lucasmichot/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmichot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmichot/subscriptions","organizations_url":"https://api.github.com/users/lucasmichot/orgs","repos_url":"https://api.github.com/users/lucasmichot/repos","events_url":"https://api.github.com/users/lucasmichot/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmichot/received_events","type":"User","site_admin":false},"body":"At the moment when using the Cache repository, we can only pass an instance of `\\DateTime` or an integer for the duration.\r\n\r\n---\r\n\r\nThis is therefore impossible to use `\\DateTimeImmutable` for example.\r\nAlso we sometimes wish to use a `\\DateInterval`.\r\n\r\n---\r\n\r\nThis PR allows to use any kind of `\\DateInterface`, `\\DateInterval` and integers","created_at":"2017-07-13T11:27:18Z","updated_at":"2017-07-13T13:10:53Z","closed_at":"2017-07-13T13:10:53Z","merged_at":"2017-07-13T13:10:53Z","merge_commit_sha":"11df2df400f944f05873933f6aea7739a717f184","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/20034/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/20034/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/20034/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/27ad53b829aef3239aae510cd5ff9e35b7694ebc","head":{"label":"lucasmichot:feature/master/cache","ref":"feature/master/cache","sha":"27ad53b829aef3239aae510cd5ff9e35b7694ebc","user":{"login":"lucasmichot","id":513603,"avatar_url":"https://avatars2.githubusercontent.com/u/513603?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmichot","html_url":"https://github.com/lucasmichot","followers_url":"https://api.github.com/users/lucasmichot/followers","following_url":"https://api.github.com/users/lucasmichot/following{/other_user}","gists_url":"https://api.github.com/users/lucasmichot/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmichot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmichot/subscriptions","organizations_url":"https://api.github.com/users/lucasmichot/orgs","repos_url":"https://api.github.com/users/lucasmichot/repos","events_url":"https://api.github.com/users/lucasmichot/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmichot/received_events","type":"User","site_admin":false},"repo":{"id":14317321,"name":"framework","full_name":"lucasmichot/framework","owner":{"login":"lucasmichot","id":513603,"avatar_url":"https://avatars2.githubusercontent.com/u/513603?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasmichot","html_url":"https://github.com/lucasmichot","followers_url":"https://api.github.com/users/lucasmichot/followers","following_url":"https://api.github.com/users/lucasmichot/following{/other_user}","gists_url":"https://api.github.com/users/lucasmichot/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasmichot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasmichot/subscriptions","organizations_url":"https://api.github.com/users/lucasmichot/orgs","repos_url":"https://api.github.com/users/lucasmichot/repos","events_url":"https://api.github.com/users/lucasmichot/events{/privacy}","received_events_url":"https://api.github.com/users/lucasmichot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasmichot/framework","description":null,"fork":true,"url":"https://api.github.com/repos/lucasmichot/framework","forks_url":"https://api.github.com/repos/lucasmichot/framework/forks","keys_url":"https://api.github.com/repos/lucasmichot/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasmichot/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasmichot/framework/teams","hooks_url":"https://api.github.com/repos/lucasmichot/framework/hooks","issue_events_url":"https://api.github.com/repos/lucasmichot/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lucasmichot/framework/events","assignees_url":"https://api.github.com/repos/lucasmichot/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lucasmichot/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lucasmichot/framework/tags","blobs_url":"https://api.github.com/repos/lucasmichot/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasmichot/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasmichot/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasmichot/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasmichot/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasmichot/framework/languages","stargazers_url":"https://api.github.com/repos/lucasmichot/framework/stargazers","contributors_url":"https://api.github.com/repos/lucasmichot/framework/contributors","subscribers_url":"https://api.github.com/repos/lucasmichot/framework/subscribers","subscription_url":"https://api.github.com/repos/lucasmichot/framework/subscription","commits_url":"https://api.github.com/repos/lucasmichot/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasmichot/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasmichot/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasmichot/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasmichot/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lucasmichot/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasmichot/framework/merges","archive_url":"https://api.github.com/repos/lucasmichot/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasmichot/framework/downloads","issues_url":"https://api.github.com/repos/lucasmichot/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lucasmichot/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasmichot/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasmichot/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasmichot/framework/labels{/name}","releases_url":"https://api.github.com/repos/lucasmichot/framework/releases{/id}","deployments_url":"https://api.github.com/repos/lucasmichot/framework/deployments","created_at":"2013-11-12T00:01:33Z","updated_at":"2017-01-20T17:42:27Z","pushed_at":"2017-07-13T11:21:26Z","git_url":"git://github.com/lucasmichot/framework.git","ssh_url":"git@github.com:lucasmichot/framework.git","clone_url":"https://github.com/lucasmichot/framework.git","svn_url":"https://github.com/lucasmichot/framework","homepage":"http://laravel.com","size":29788,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laravel:master","ref":"master","sha":"ac9f29da4785c8b942ced8c4ab308214d618a22b","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars0.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars0.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2017-07-13T11:42:44Z","pushed_at":"2017-07-13T13:10:53Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":29616,"stargazers_count":7579,"watchers_count":7579,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4474,"mirror_url":null,"open_issues_count":113,"forks":4474,"open_issues":113,"watchers":7579,"default_branch":"5.4"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/20034"},"html":{"href":"https://github.com/laravel/framework/pull/20034"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/20034"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/20034/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/20034/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/20034/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/27ad53b829aef3239aae510cd5ff9e35b7694ebc"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars0.githubusercontent.com/u/463230?v=3","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":45,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"taylorotwell"}}