{"action":"created","issue":{"url":"https://api.github.com/repos/codecov/codecov-exe/issues/17","repository_url":"https://api.github.com/repos/codecov/codecov-exe","labels_url":"https://api.github.com/repos/codecov/codecov-exe/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/codecov/codecov-exe/issues/17/comments","events_url":"https://api.github.com/repos/codecov/codecov-exe/issues/17/events","html_url":"https://github.com/codecov/codecov-exe/issues/17","id":233381231,"number":17,"title":"Program returns error code 1 when -required argument is used and no failure occurred","user":{"login":"AdmiringWorm","id":1474648,"avatar_url":"https://avatars0.githubusercontent.com/u/1474648?v=3","gravatar_id":"","url":"https://api.github.com/users/AdmiringWorm","html_url":"https://github.com/AdmiringWorm","followers_url":"https://api.github.com/users/AdmiringWorm/followers","following_url":"https://api.github.com/users/AdmiringWorm/following{/other_user}","gists_url":"https://api.github.com/users/AdmiringWorm/gists{/gist_id}","starred_url":"https://api.github.com/users/AdmiringWorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdmiringWorm/subscriptions","organizations_url":"https://api.github.com/users/AdmiringWorm/orgs","repos_url":"https://api.github.com/users/AdmiringWorm/repos","events_url":"https://api.github.com/users/AdmiringWorm/events{/privacy}","received_events_url":"https://api.github.com/users/AdmiringWorm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-06-03T16:51:28Z","updated_at":"2017-06-03T17:14:53Z","closed_at":"2017-06-03T17:09:24Z","body":"When calling codecov-exe and the `-required` argument have been used, the program returns an error code of 1 even if the upload actually succeeded.\r\n\r\nThis looks like it occurs because of the following line in the `Run.cs` file:\r\nhttps://github.com/codecov/codecov-exe/blob/31f9a9bcc81367a0be19a13f05c7ce401b15b367/Source/Codecov/Program/Run.cs#L20\r\n\r\nI'm willing to open a PR if interested\r\n\r\n/cc @stevepeak @larzw "},"comment":{"url":"https://api.github.com/repos/codecov/codecov-exe/issues/comments/305988689","html_url":"https://github.com/codecov/codecov-exe/issues/17#issuecomment-305988689","issue_url":"https://api.github.com/repos/codecov/codecov-exe/issues/17","id":305988689,"user":{"login":"AdmiringWorm","id":1474648,"avatar_url":"https://avatars0.githubusercontent.com/u/1474648?v=3","gravatar_id":"","url":"https://api.github.com/users/AdmiringWorm","html_url":"https://github.com/AdmiringWorm","followers_url":"https://api.github.com/users/AdmiringWorm/followers","following_url":"https://api.github.com/users/AdmiringWorm/following{/other_user}","gists_url":"https://api.github.com/users/AdmiringWorm/gists{/gist_id}","starred_url":"https://api.github.com/users/AdmiringWorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdmiringWorm/subscriptions","organizations_url":"https://api.github.com/users/AdmiringWorm/orgs","repos_url":"https://api.github.com/users/AdmiringWorm/repos","events_url":"https://api.github.com/users/AdmiringWorm/events{/privacy}","received_events_url":"https://api.github.com/users/AdmiringWorm/received_events","type":"User","site_admin":false},"created_at":"2017-06-03T17:14:53Z","updated_at":"2017-06-03T17:14:53Z","body":"@larzw just had a quick look at the chocolatey nuspec and powershell files, and the first things that popped out was that the software should be embedded (in this case, the powershell could be removed, but a VERIFICATION.txt and LICENSE.txt file would need to be added, the former because the mods and users need a way to verify it comes from an official distribution point).\r\nAnother point is that it's missing the `bugTrackerUrl` (or I didn't see it anyhow).\r\n\r\nBut in all, it's quite good TBH."}}
{"actor":{"display_login":"AdmiringWorm"}}