{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/129378277","pull_request_review_id":52145072,"id":129378277,"diff_hunk":"@@ -23,33 +23,59 @@\n # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA\n ##############################################################################\n from spack import *\n-import os\n \n \n-class Lulesh(Package):\n-    \"\"\"Livermore Unstructured Lagrangian Explicit Shock Hydrodynamics (LULESH)\n+class Lulesh(MakefilePackage):\n+    \"\"\"LULESH is a highly simplified application, hard-coded to only\n+    style typical in scientific C or C++ based applications. Hard\n+    code to only solve a Sedov blast problem with analytic answer \n     \"\"\"\n-\n+    tags = ['proxy-app']\n     homepage = \"https://codesign.llnl.gov/lulesh.php\"\n     url      = \"https://codesign.llnl.gov/lulesh/lulesh2.0.3.tgz\"\n \n-    version(\"2.0.3\", \"336644a8750f71c7c6b9d2960976e7aa\")\n+    version('2.0.3', '336644a8750f71c7c6b9d2960976e7aa')\n+    variant('mpi', default=True, description='Build with MPI support')\n+    variant('openmp', default=True, description='Build with OpenMP support')\n+    variant('visual', default=False,\n+        description='Build with Visualization support (Silo, hdf5)')\n \n-    patch(\"remove_defaults.patch\")\n+    depends_on('mpi', when='+mpi')\n+    depends_on('silo', when='+visual')\n+    depends_on('hdf5', when='+visual')\n \n-    variant('mpip', default=False)\n+    @property\n+    def build_targets(self):\n+        targets = []\n+        cxxflag = ' -g -O3 -I. -Wall '\n+        ldflags = ' -g -O3 '\n \n-    depends_on(\"mpi\", type=\"build\")\n-    depends_on(\"mpip\", when=\"+mpip\")\n+        targets.append('CXX = {0}'.format(spack_cxx, ' -DUSE_MPI=0 '))","path":"var/spack/repos/builtin/packages/lulesh/package.py","position":40,"original_position":40,"commit_id":"f6b0fa507bf2ddb1d4252e7ac898ab440b19ea99","original_commit_id":"f6b0fa507bf2ddb1d4252e7ac898ab440b19ea99","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars2.githubusercontent.com/u/12021217?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"I don't think the string at the end is used in any way.","created_at":"2017-07-25T17:54:42Z","updated_at":"2017-07-25T17:56:05Z","html_url":"https://github.com/LLNL/spack/pull/4897#discussion_r129378277","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/4897","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/129378277"},"html":{"href":"https://github.com/LLNL/spack/pull/4897#discussion_r129378277"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4897"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/4897","id":132322477,"html_url":"https://github.com/LLNL/spack/pull/4897","diff_url":"https://github.com/LLNL/spack/pull/4897.diff","patch_url":"https://github.com/LLNL/spack/pull/4897.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/4897","number":4897,"state":"open","locked":false,"title":" Variants Serial MPI openmp","user":{"login":"akhilpatlolla","id":5015908,"avatar_url":"https://avatars0.githubusercontent.com/u/5015908?v=4","gravatar_id":"","url":"https://api.github.com/users/akhilpatlolla","html_url":"https://github.com/akhilpatlolla","followers_url":"https://api.github.com/users/akhilpatlolla/followers","following_url":"https://api.github.com/users/akhilpatlolla/following{/other_user}","gists_url":"https://api.github.com/users/akhilpatlolla/gists{/gist_id}","starred_url":"https://api.github.com/users/akhilpatlolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhilpatlolla/subscriptions","organizations_url":"https://api.github.com/users/akhilpatlolla/orgs","repos_url":"https://api.github.com/users/akhilpatlolla/repos","events_url":"https://api.github.com/users/akhilpatlolla/events{/privacy}","received_events_url":"https://api.github.com/users/akhilpatlolla/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-25T16:15:52Z","updated_at":"2017-07-25T17:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0064025e196750c97f746f86825d56257f9174c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/4897/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/4897/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/4897/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/f6b0fa507bf2ddb1d4252e7ac898ab440b19ea99","head":{"label":"akhilpatlolla:package/lulesh","ref":"package/lulesh","sha":"f6b0fa507bf2ddb1d4252e7ac898ab440b19ea99","user":{"login":"akhilpatlolla","id":5015908,"avatar_url":"https://avatars0.githubusercontent.com/u/5015908?v=4","gravatar_id":"","url":"https://api.github.com/users/akhilpatlolla","html_url":"https://github.com/akhilpatlolla","followers_url":"https://api.github.com/users/akhilpatlolla/followers","following_url":"https://api.github.com/users/akhilpatlolla/following{/other_user}","gists_url":"https://api.github.com/users/akhilpatlolla/gists{/gist_id}","starred_url":"https://api.github.com/users/akhilpatlolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhilpatlolla/subscriptions","organizations_url":"https://api.github.com/users/akhilpatlolla/orgs","repos_url":"https://api.github.com/users/akhilpatlolla/repos","events_url":"https://api.github.com/users/akhilpatlolla/events{/privacy}","received_events_url":"https://api.github.com/users/akhilpatlolla/received_events","type":"User","site_admin":false},"repo":{"id":96931710,"name":"spack","full_name":"akhilpatlolla/spack","owner":{"login":"akhilpatlolla","id":5015908,"avatar_url":"https://avatars0.githubusercontent.com/u/5015908?v=4","gravatar_id":"","url":"https://api.github.com/users/akhilpatlolla","html_url":"https://github.com/akhilpatlolla","followers_url":"https://api.github.com/users/akhilpatlolla/followers","following_url":"https://api.github.com/users/akhilpatlolla/following{/other_user}","gists_url":"https://api.github.com/users/akhilpatlolla/gists{/gist_id}","starred_url":"https://api.github.com/users/akhilpatlolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhilpatlolla/subscriptions","organizations_url":"https://api.github.com/users/akhilpatlolla/orgs","repos_url":"https://api.github.com/users/akhilpatlolla/repos","events_url":"https://api.github.com/users/akhilpatlolla/events{/privacy}","received_events_url":"https://api.github.com/users/akhilpatlolla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akhilpatlolla/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/akhilpatlolla/spack","forks_url":"https://api.github.com/repos/akhilpatlolla/spack/forks","keys_url":"https://api.github.com/repos/akhilpatlolla/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akhilpatlolla/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akhilpatlolla/spack/teams","hooks_url":"https://api.github.com/repos/akhilpatlolla/spack/hooks","issue_events_url":"https://api.github.com/repos/akhilpatlolla/spack/issues/events{/number}","events_url":"https://api.github.com/repos/akhilpatlolla/spack/events","assignees_url":"https://api.github.com/repos/akhilpatlolla/spack/assignees{/user}","branches_url":"https://api.github.com/repos/akhilpatlolla/spack/branches{/branch}","tags_url":"https://api.github.com/repos/akhilpatlolla/spack/tags","blobs_url":"https://api.github.com/repos/akhilpatlolla/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akhilpatlolla/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akhilpatlolla/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/akhilpatlolla/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akhilpatlolla/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/akhilpatlolla/spack/languages","stargazers_url":"https://api.github.com/repos/akhilpatlolla/spack/stargazers","contributors_url":"https://api.github.com/repos/akhilpatlolla/spack/contributors","subscribers_url":"https://api.github.com/repos/akhilpatlolla/spack/subscribers","subscription_url":"https://api.github.com/repos/akhilpatlolla/spack/subscription","commits_url":"https://api.github.com/repos/akhilpatlolla/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/akhilpatlolla/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/akhilpatlolla/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/akhilpatlolla/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/akhilpatlolla/spack/contents/{+path}","compare_url":"https://api.github.com/repos/akhilpatlolla/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akhilpatlolla/spack/merges","archive_url":"https://api.github.com/repos/akhilpatlolla/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akhilpatlolla/spack/downloads","issues_url":"https://api.github.com/repos/akhilpatlolla/spack/issues{/number}","pulls_url":"https://api.github.com/repos/akhilpatlolla/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/akhilpatlolla/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/akhilpatlolla/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akhilpatlolla/spack/labels{/name}","releases_url":"https://api.github.com/repos/akhilpatlolla/spack/releases{/id}","deployments_url":"https://api.github.com/repos/akhilpatlolla/spack/deployments","created_at":"2017-07-11T19:55:20Z","updated_at":"2017-07-11T19:55:26Z","pushed_at":"2017-07-25T16:15:12Z","git_url":"git://github.com/akhilpatlolla/spack.git","ssh_url":"git@github.com:akhilpatlolla/spack.git","clone_url":"https://github.com/akhilpatlolla/spack.git","svn_url":"https://github.com/akhilpatlolla/spack","homepage":"https://spack.io","size":26320,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"5184dda309412685bf990483eeac85a6c1822463","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2017-07-25T03:26:02Z","pushed_at":"2017-07-25T17:46:52Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"https://spack.io","size":26755,"stargazers_count":321,"watchers_count":321,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":263,"mirror_url":null,"open_issues_count":719,"forks":263,"open_issues":719,"watchers":321,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4897"},"html":{"href":"https://github.com/LLNL/spack/pull/4897"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/4897"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/4897/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4897/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4897/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/f6b0fa507bf2ddb1d4252e7ac898ab440b19ea99"}}}}
{"actor":{"display_login":"adamjstewart"}}