{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/132633827","pull_request_review_id":55735687,"id":132633827,"diff_hunk":"@@ -0,0 +1,169 @@\n+// Copyright 2017 Dolphin Emulator Project\n+// Licensed under GPLv2+\n+// Refer to the license.txt file included.\n+\n+#ifdef USE_UPNP\n+\n+#include \"Common/UPnP.h\"\n+\n+#include \"Common/Logging/Log.h\"\n+\n+#include <array>\n+#include <cstdlib>\n+#include <cstring>\n+#include <miniupnpc.h>\n+#include <miniwget.h>\n+#include <string>\n+#include <thread>\n+#include <upnpcommands.h>\n+#include <vector>\n+\n+static struct UPNPUrls s_urls;","path":"Source/Core/Common/UPnP.cpp","position":21,"original_position":21,"commit_id":"33682acf7822b5fab04ceaeae716f595c577f963","original_commit_id":"33682acf7822b5fab04ceaeae716f595c577f963","user":{"login":"leoetlino","id":4209061,"avatar_url":"https://avatars2.githubusercontent.com/u/4209061?v=4","gravatar_id":"","url":"https://api.github.com/users/leoetlino","html_url":"https://github.com/leoetlino","followers_url":"https://api.github.com/users/leoetlino/followers","following_url":"https://api.github.com/users/leoetlino/following{/other_user}","gists_url":"https://api.github.com/users/leoetlino/gists{/gist_id}","starred_url":"https://api.github.com/users/leoetlino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoetlino/subscriptions","organizations_url":"https://api.github.com/users/leoetlino/orgs","repos_url":"https://api.github.com/users/leoetlino/repos","events_url":"https://api.github.com/users/leoetlino/events{/privacy}","received_events_url":"https://api.github.com/users/leoetlino/received_events","type":"User","site_admin":false},"body":"Since you're cleaning up stuff, would you also mind removing `struct` here? It shouldn't be needed here and below","created_at":"2017-08-11T08:07:59Z","updated_at":"2017-08-11T08:07:59Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/5898#discussion_r132633827","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/132633827"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5898#discussion_r132633827"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898","id":134377428,"html_url":"https://github.com/dolphin-emu/dolphin/pull/5898","diff_url":"https://github.com/dolphin-emu/dolphin/pull/5898.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/5898.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5898","number":5898,"state":"open","locked":false,"title":"Common: extract UPnP namespace from NetPlayServer","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"body":"The code is already basically completely separate, so there's no need for it to live inside NetPlayServer instances. This PR:\r\n\r\n- Extracts UPnP-related code from Core/NetPlayServer.{cpp,h} to Common/UPnP.{cpp,h}\r\n- Does some light cleanup on the UPnP code (mostly naming)\r\n- Moves the call to `TryPortmapping` into the NetPlayServer constructor. This made more sense because the call to `StopPortmapping` happens in the destructor, and there was no actual logic remaining in a standalone NetPlayServer method.","created_at":"2017-08-07T07:32:03Z","updated_at":"2017-08-11T08:07:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ea5c623d5609b1b55ab083d7bb006e9ebe3e732","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5898/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/33682acf7822b5fab04ceaeae716f595c577f963","head":{"label":"ligfx:extractupnp","ref":"extractupnp","sha":"33682acf7822b5fab04ceaeae716f595c577f963","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"repo":{"id":65220721,"name":"dolphin","full_name":"ligfx/dolphin","owner":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ligfx/dolphin","description":"Personal development branch of dolphin-emu/dolphin.","fork":true,"url":"https://api.github.com/repos/ligfx/dolphin","forks_url":"https://api.github.com/repos/ligfx/dolphin/forks","keys_url":"https://api.github.com/repos/ligfx/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligfx/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligfx/dolphin/teams","hooks_url":"https://api.github.com/repos/ligfx/dolphin/hooks","issue_events_url":"https://api.github.com/repos/ligfx/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/ligfx/dolphin/events","assignees_url":"https://api.github.com/repos/ligfx/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/ligfx/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/ligfx/dolphin/tags","blobs_url":"https://api.github.com/repos/ligfx/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligfx/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligfx/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligfx/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligfx/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/ligfx/dolphin/languages","stargazers_url":"https://api.github.com/repos/ligfx/dolphin/stargazers","contributors_url":"https://api.github.com/repos/ligfx/dolphin/contributors","subscribers_url":"https://api.github.com/repos/ligfx/dolphin/subscribers","subscription_url":"https://api.github.com/repos/ligfx/dolphin/subscription","commits_url":"https://api.github.com/repos/ligfx/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligfx/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligfx/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligfx/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligfx/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/ligfx/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligfx/dolphin/merges","archive_url":"https://api.github.com/repos/ligfx/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligfx/dolphin/downloads","issues_url":"https://api.github.com/repos/ligfx/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/ligfx/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/ligfx/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/ligfx/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligfx/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/ligfx/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/ligfx/dolphin/deployments","created_at":"2016-08-08T16:31:32Z","updated_at":"2017-05-17T22:06:54Z","pushed_at":"2017-08-10T20:22:39Z","git_url":"git://github.com/ligfx/dolphin.git","ssh_url":"git@github.com:ligfx/dolphin.git","clone_url":"https://github.com/ligfx/dolphin.git","svn_url":"https://github.com/ligfx/dolphin","homepage":"https://github.com/dolphin-emu/dolphin","size":308201,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ligfx"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"f2a9ad0089dc051d020e57af843c44c6562590cd","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-08-11T02:15:29Z","pushed_at":"2017-08-11T07:58:43Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":345586,"stargazers_count":3597,"watchers_count":3597,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":918,"mirror_url":null,"open_issues_count":139,"forks":918,"open_issues":139,"watchers":3597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5898"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5898"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5898/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5898/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/33682acf7822b5fab04ceaeae716f595c577f963"}}}}
{"actor":{"display_login":"leoetlino"}}