{"action":"created","comment":{"url":"https://api.github.com/repos/Marri/glowfic/pulls/comments/117631153","pull_request_review_id":39354876,"id":117631153,"diff_hunk":"@@ -22,10 +22,10 @@\n     %meta{name: \"application-name\", content: \"Glowfic Constellation\"}\n     %meta{name: \"msapplication-config\", content: asset_path('favicons/browserconfig.xml')}\n     %meta{name: \"theme-color\", content: \"#ffffff\"}\n-    = favicon_link_tag asset_path('favicons/favicon.ico')\n-    = favicon_link_tag asset_path('favicons/favicon-32x32.png'), type: 'image/png', rel: 'icon', sizes: '32x32'\n-    = favicon_link_tag asset_path('favicons/favicon-16x16.png'), type: 'image/png', rel: 'icon', sizes: '16x16'\n-    = favicon_link_tag asset_path('favicons/apple-touch-icon.png'), type: 'image/png', rel: 'apple-touch-icon', sizes: '180x180'\n+    = favicon_link_tag 'favicons/favicon.ico'","path":"app/views/layouts/application.haml","position":8,"original_position":8,"commit_id":"87ccbaf69077391c54a2b707d94e00b9a8976b81","original_commit_id":"87ccbaf69077391c54a2b707d94e00b9a8976b81","user":{"login":"Throne3d","id":577128,"avatar_url":"https://avatars2.githubusercontent.com/u/577128?v=3","gravatar_id":"","url":"https://api.github.com/users/Throne3d","html_url":"https://github.com/Throne3d","followers_url":"https://api.github.com/users/Throne3d/followers","following_url":"https://api.github.com/users/Throne3d/following{/other_user}","gists_url":"https://api.github.com/users/Throne3d/gists{/gist_id}","starred_url":"https://api.github.com/users/Throne3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Throne3d/subscriptions","organizations_url":"https://api.github.com/users/Throne3d/orgs","repos_url":"https://api.github.com/users/Throne3d/repos","events_url":"https://api.github.com/users/Throne3d/events{/privacy}","received_events_url":"https://api.github.com/users/Throne3d/received_events","type":"User","site_admin":false},"body":"[Here](http://guides.rubyonrails.org/v4.1/asset_pipeline.html#coding-links-to-assets) seems to not expect `asset_path` to be used despite sprockets being involved.","created_at":"2017-05-21T12:07:18Z","updated_at":"2017-05-21T12:07:18Z","html_url":"https://github.com/Marri/glowfic/pull/237#discussion_r117631153","pull_request_url":"https://api.github.com/repos/Marri/glowfic/pulls/237","_links":{"self":{"href":"https://api.github.com/repos/Marri/glowfic/pulls/comments/117631153"},"html":{"href":"https://github.com/Marri/glowfic/pull/237#discussion_r117631153"},"pull_request":{"href":"https://api.github.com/repos/Marri/glowfic/pulls/237"}}},"pull_request":{"url":"https://api.github.com/repos/Marri/glowfic/pulls/237","id":121632685,"html_url":"https://github.com/Marri/glowfic/pull/237","diff_url":"https://github.com/Marri/glowfic/pull/237.diff","patch_url":"https://github.com/Marri/glowfic/pull/237.patch","issue_url":"https://api.github.com/repos/Marri/glowfic/issues/237","number":237,"state":"open","locked":false,"title":"Upgrade to Rails 4.0","user":{"login":"Throne3d","id":577128,"avatar_url":"https://avatars2.githubusercontent.com/u/577128?v=3","gravatar_id":"","url":"https://api.github.com/users/Throne3d","html_url":"https://github.com/Throne3d","followers_url":"https://api.github.com/users/Throne3d/followers","following_url":"https://api.github.com/users/Throne3d/following{/other_user}","gists_url":"https://api.github.com/users/Throne3d/gists{/gist_id}","starred_url":"https://api.github.com/users/Throne3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Throne3d/subscriptions","organizations_url":"https://api.github.com/users/Throne3d/orgs","repos_url":"https://api.github.com/users/Throne3d/repos","events_url":"https://api.github.com/users/Throne3d/events{/privacy}","received_events_url":"https://api.github.com/users/Throne3d/received_events","type":"User","site_admin":false},"body":"So all tests now pass but I need to clean up the commit history and also check that I haven't left out params (and maybe consistently use strong params instead of the weird `attr_accessible` thing I'm doing currently).","created_at":"2017-05-20T18:10:06Z","updated_at":"2017-05-21T12:07:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c6b44b18cc99b6edbea529e3198380fd3ca9c4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Marri/glowfic/pulls/237/commits","review_comments_url":"https://api.github.com/repos/Marri/glowfic/pulls/237/comments","review_comment_url":"https://api.github.com/repos/Marri/glowfic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Marri/glowfic/issues/237/comments","statuses_url":"https://api.github.com/repos/Marri/glowfic/statuses/87ccbaf69077391c54a2b707d94e00b9a8976b81","head":{"label":"Marri:upgrade/rails-4","ref":"upgrade/rails-4","sha":"87ccbaf69077391c54a2b707d94e00b9a8976b81","user":{"login":"Marri","id":735954,"avatar_url":"https://avatars0.githubusercontent.com/u/735954?v=3","gravatar_id":"","url":"https://api.github.com/users/Marri","html_url":"https://github.com/Marri","followers_url":"https://api.github.com/users/Marri/followers","following_url":"https://api.github.com/users/Marri/following{/other_user}","gists_url":"https://api.github.com/users/Marri/gists{/gist_id}","starred_url":"https://api.github.com/users/Marri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marri/subscriptions","organizations_url":"https://api.github.com/users/Marri/orgs","repos_url":"https://api.github.com/users/Marri/repos","events_url":"https://api.github.com/users/Marri/events{/privacy}","received_events_url":"https://api.github.com/users/Marri/received_events","type":"User","site_admin":false},"repo":{"id":80946864,"name":"glowfic","full_name":"Marri/glowfic","owner":{"login":"Marri","id":735954,"avatar_url":"https://avatars0.githubusercontent.com/u/735954?v=3","gravatar_id":"","url":"https://api.github.com/users/Marri","html_url":"https://github.com/Marri","followers_url":"https://api.github.com/users/Marri/followers","following_url":"https://api.github.com/users/Marri/following{/other_user}","gists_url":"https://api.github.com/users/Marri/gists{/gist_id}","starred_url":"https://api.github.com/users/Marri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marri/subscriptions","organizations_url":"https://api.github.com/users/Marri/orgs","repos_url":"https://api.github.com/users/Marri/repos","events_url":"https://api.github.com/users/Marri/events{/privacy}","received_events_url":"https://api.github.com/users/Marri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Marri/glowfic","description":"The Glowfic Constellation","fork":false,"url":"https://api.github.com/repos/Marri/glowfic","forks_url":"https://api.github.com/repos/Marri/glowfic/forks","keys_url":"https://api.github.com/repos/Marri/glowfic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Marri/glowfic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Marri/glowfic/teams","hooks_url":"https://api.github.com/repos/Marri/glowfic/hooks","issue_events_url":"https://api.github.com/repos/Marri/glowfic/issues/events{/number}","events_url":"https://api.github.com/repos/Marri/glowfic/events","assignees_url":"https://api.github.com/repos/Marri/glowfic/assignees{/user}","branches_url":"https://api.github.com/repos/Marri/glowfic/branches{/branch}","tags_url":"https://api.github.com/repos/Marri/glowfic/tags","blobs_url":"https://api.github.com/repos/Marri/glowfic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Marri/glowfic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Marri/glowfic/git/refs{/sha}","trees_url":"https://api.github.com/repos/Marri/glowfic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Marri/glowfic/statuses/{sha}","languages_url":"https://api.github.com/repos/Marri/glowfic/languages","stargazers_url":"https://api.github.com/repos/Marri/glowfic/stargazers","contributors_url":"https://api.github.com/repos/Marri/glowfic/contributors","subscribers_url":"https://api.github.com/repos/Marri/glowfic/subscribers","subscription_url":"https://api.github.com/repos/Marri/glowfic/subscription","commits_url":"https://api.github.com/repos/Marri/glowfic/commits{/sha}","git_commits_url":"https://api.github.com/repos/Marri/glowfic/git/commits{/sha}","comments_url":"https://api.github.com/repos/Marri/glowfic/comments{/number}","issue_comment_url":"https://api.github.com/repos/Marri/glowfic/issues/comments{/number}","contents_url":"https://api.github.com/repos/Marri/glowfic/contents/{+path}","compare_url":"https://api.github.com/repos/Marri/glowfic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Marri/glowfic/merges","archive_url":"https://api.github.com/repos/Marri/glowfic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Marri/glowfic/downloads","issues_url":"https://api.github.com/repos/Marri/glowfic/issues{/number}","pulls_url":"https://api.github.com/repos/Marri/glowfic/pulls{/number}","milestones_url":"https://api.github.com/repos/Marri/glowfic/milestones{/number}","notifications_url":"https://api.github.com/repos/Marri/glowfic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Marri/glowfic/labels{/name}","releases_url":"https://api.github.com/repos/Marri/glowfic/releases{/id}","deployments_url":"https://api.github.com/repos/Marri/glowfic/deployments","created_at":"2017-02-04T20:37:13Z","updated_at":"2017-03-15T01:02:55Z","pushed_at":"2017-05-20T20:45:39Z","git_url":"git://github.com/Marri/glowfic.git","ssh_url":"git@github.com:Marri/glowfic.git","clone_url":"https://github.com/Marri/glowfic.git","svn_url":"https://github.com/Marri/glowfic","homepage":null,"size":3659,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":133,"forks":2,"open_issues":133,"watchers":3,"default_branch":"master"}},"base":{"label":"Marri:master","ref":"master","sha":"f35d8d61656f35ccef15788f5b726088e02f974c","user":{"login":"Marri","id":735954,"avatar_url":"https://avatars0.githubusercontent.com/u/735954?v=3","gravatar_id":"","url":"https://api.github.com/users/Marri","html_url":"https://github.com/Marri","followers_url":"https://api.github.com/users/Marri/followers","following_url":"https://api.github.com/users/Marri/following{/other_user}","gists_url":"https://api.github.com/users/Marri/gists{/gist_id}","starred_url":"https://api.github.com/users/Marri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marri/subscriptions","organizations_url":"https://api.github.com/users/Marri/orgs","repos_url":"https://api.github.com/users/Marri/repos","events_url":"https://api.github.com/users/Marri/events{/privacy}","received_events_url":"https://api.github.com/users/Marri/received_events","type":"User","site_admin":false},"repo":{"id":80946864,"name":"glowfic","full_name":"Marri/glowfic","owner":{"login":"Marri","id":735954,"avatar_url":"https://avatars0.githubusercontent.com/u/735954?v=3","gravatar_id":"","url":"https://api.github.com/users/Marri","html_url":"https://github.com/Marri","followers_url":"https://api.github.com/users/Marri/followers","following_url":"https://api.github.com/users/Marri/following{/other_user}","gists_url":"https://api.github.com/users/Marri/gists{/gist_id}","starred_url":"https://api.github.com/users/Marri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marri/subscriptions","organizations_url":"https://api.github.com/users/Marri/orgs","repos_url":"https://api.github.com/users/Marri/repos","events_url":"https://api.github.com/users/Marri/events{/privacy}","received_events_url":"https://api.github.com/users/Marri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Marri/glowfic","description":"The Glowfic Constellation","fork":false,"url":"https://api.github.com/repos/Marri/glowfic","forks_url":"https://api.github.com/repos/Marri/glowfic/forks","keys_url":"https://api.github.com/repos/Marri/glowfic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Marri/glowfic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Marri/glowfic/teams","hooks_url":"https://api.github.com/repos/Marri/glowfic/hooks","issue_events_url":"https://api.github.com/repos/Marri/glowfic/issues/events{/number}","events_url":"https://api.github.com/repos/Marri/glowfic/events","assignees_url":"https://api.github.com/repos/Marri/glowfic/assignees{/user}","branches_url":"https://api.github.com/repos/Marri/glowfic/branches{/branch}","tags_url":"https://api.github.com/repos/Marri/glowfic/tags","blobs_url":"https://api.github.com/repos/Marri/glowfic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Marri/glowfic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Marri/glowfic/git/refs{/sha}","trees_url":"https://api.github.com/repos/Marri/glowfic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Marri/glowfic/statuses/{sha}","languages_url":"https://api.github.com/repos/Marri/glowfic/languages","stargazers_url":"https://api.github.com/repos/Marri/glowfic/stargazers","contributors_url":"https://api.github.com/repos/Marri/glowfic/contributors","subscribers_url":"https://api.github.com/repos/Marri/glowfic/subscribers","subscription_url":"https://api.github.com/repos/Marri/glowfic/subscription","commits_url":"https://api.github.com/repos/Marri/glowfic/commits{/sha}","git_commits_url":"https://api.github.com/repos/Marri/glowfic/git/commits{/sha}","comments_url":"https://api.github.com/repos/Marri/glowfic/comments{/number}","issue_comment_url":"https://api.github.com/repos/Marri/glowfic/issues/comments{/number}","contents_url":"https://api.github.com/repos/Marri/glowfic/contents/{+path}","compare_url":"https://api.github.com/repos/Marri/glowfic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Marri/glowfic/merges","archive_url":"https://api.github.com/repos/Marri/glowfic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Marri/glowfic/downloads","issues_url":"https://api.github.com/repos/Marri/glowfic/issues{/number}","pulls_url":"https://api.github.com/repos/Marri/glowfic/pulls{/number}","milestones_url":"https://api.github.com/repos/Marri/glowfic/milestones{/number}","notifications_url":"https://api.github.com/repos/Marri/glowfic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Marri/glowfic/labels{/name}","releases_url":"https://api.github.com/repos/Marri/glowfic/releases{/id}","deployments_url":"https://api.github.com/repos/Marri/glowfic/deployments","created_at":"2017-02-04T20:37:13Z","updated_at":"2017-03-15T01:02:55Z","pushed_at":"2017-05-20T20:45:39Z","git_url":"git://github.com/Marri/glowfic.git","ssh_url":"git@github.com:Marri/glowfic.git","clone_url":"https://github.com/Marri/glowfic.git","svn_url":"https://github.com/Marri/glowfic","homepage":null,"size":3659,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":133,"forks":2,"open_issues":133,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Marri/glowfic/pulls/237"},"html":{"href":"https://github.com/Marri/glowfic/pull/237"},"issue":{"href":"https://api.github.com/repos/Marri/glowfic/issues/237"},"comments":{"href":"https://api.github.com/repos/Marri/glowfic/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/Marri/glowfic/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/Marri/glowfic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Marri/glowfic/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/Marri/glowfic/statuses/87ccbaf69077391c54a2b707d94e00b9a8976b81"}}}}
{"actor":{"display_login":"Throne3d"}}