{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/156551593","pull_request_review_id":83046898,"id":156551593,"diff_hunk":"@@ -59,6 +65,9 @@ class MPGStats : public PaxosServiceMessage {\n     ::decode(pg_stat, p);\n     ::decode(epoch, p);\n     ::decode(had_map_for, p);\n+    // conditionally decode flock metadata\n+    if (header.version >= 1)","path":"src/messages/MPGStats.h","position":37,"original_position":37,"commit_id":"ca34206eef52f7306b2e21b916aa00d4096bf840","original_commit_id":"a06802530edbf36b70501dc74d9c2007cbd7c509","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"2","created_at":"2017-12-13T02:35:34Z","updated_at":"2017-12-13T02:40:39Z","html_url":"https://github.com/ceph/ceph/pull/19454#discussion_r156551593","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/19454","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/156551593"},"html":{"href":"https://github.com/ceph/ceph/pull/19454#discussion_r156551593"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/19454"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/19454","id":157858547,"html_url":"https://github.com/ceph/ceph/pull/19454","diff_url":"https://github.com/ceph/ceph/pull/19454.diff","patch_url":"https://github.com/ceph/ceph/pull/19454.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/19454","number":19454,"state":"open","locked":false,"title":"DNM: [RFC] POC to implement per-pool based approach for OSD fine-grained statistics collection.","user":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars2.githubusercontent.com/u/7138176?v=4","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"body":"This patch is partially functional but the code at PGMap.cc is far from the readiness. Nevertheless comments (especially for OSD/OS layers) are highly appreciated...","created_at":"2017-12-12T15:29:30Z","updated_at":"2017-12-13T02:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cbf11185ed7e29806bb2d605ba43e64a6fb598b","assignee":{"login":"liewegas","id":433031,"avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"assignees":[{"login":"liewegas","id":433031,"avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/19454/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/19454/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/19454/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/ca34206eef52f7306b2e21b916aa00d4096bf840","head":{"label":"ifed01:wip-ifed-pool-sizes","ref":"wip-ifed-pool-sizes","sha":"ca34206eef52f7306b2e21b916aa00d4096bf840","user":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars2.githubusercontent.com/u/7138176?v=4","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"repo":{"id":42860525,"name":"ceph","full_name":"ifed01/ceph","owner":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars2.githubusercontent.com/u/7138176?v=4","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifed01/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/ifed01/ceph","forks_url":"https://api.github.com/repos/ifed01/ceph/forks","keys_url":"https://api.github.com/repos/ifed01/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifed01/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifed01/ceph/teams","hooks_url":"https://api.github.com/repos/ifed01/ceph/hooks","issue_events_url":"https://api.github.com/repos/ifed01/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ifed01/ceph/events","assignees_url":"https://api.github.com/repos/ifed01/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ifed01/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ifed01/ceph/tags","blobs_url":"https://api.github.com/repos/ifed01/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifed01/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifed01/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifed01/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifed01/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ifed01/ceph/languages","stargazers_url":"https://api.github.com/repos/ifed01/ceph/stargazers","contributors_url":"https://api.github.com/repos/ifed01/ceph/contributors","subscribers_url":"https://api.github.com/repos/ifed01/ceph/subscribers","subscription_url":"https://api.github.com/repos/ifed01/ceph/subscription","commits_url":"https://api.github.com/repos/ifed01/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifed01/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifed01/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifed01/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifed01/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ifed01/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifed01/ceph/merges","archive_url":"https://api.github.com/repos/ifed01/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifed01/ceph/downloads","issues_url":"https://api.github.com/repos/ifed01/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ifed01/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ifed01/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ifed01/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifed01/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ifed01/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ifed01/ceph/deployments","created_at":"2015-09-21T10:49:23Z","updated_at":"2016-01-12T23:28:29Z","pushed_at":"2017-12-12T19:52:34Z","git_url":"git://github.com/ifed01/ceph.git","ssh_url":"git@github.com:ifed01/ceph.git","clone_url":"https://github.com/ifed01/ceph.git","svn_url":"https://github.com/ifed01/ceph","homepage":"http://ceph.com","size":254077,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"f760313f948168c8da9c40f48f7faf85d3e769ae","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-12-13T01:32:33Z","pushed_at":"2017-12-13T01:39:23Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":257791,"stargazers_count":3906,"watchers_count":3906,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2223,"mirror_url":null,"archived":false,"open_issues_count":696,"license":null,"forks":2223,"open_issues":696,"watchers":3906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/19454"},"html":{"href":"https://github.com/ceph/ceph/pull/19454"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/19454"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/19454/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/19454/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/19454/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/ca34206eef52f7306b2e21b916aa00d4096bf840"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liewegas"}}