{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/profiles/pulls/comments/156990331","pull_request_review_id":83559079,"id":156990331,"diff_hunk":"@@ -164,6 +164,17 @@ def orcid_tokens() -> SQLAlchemyOrcidTokens:\n     return SQLAlchemyOrcidTokens(db)\n \n \n+@fixture\n+def registered_handler_names():","path":"test/conftest.py","position":14,"original_position":14,"commit_id":"463ba9fe9eff169ca12e8772fb6d2dbe0f773b83","original_commit_id":"94f93d999f69888d4b4b033b4a0a86d7cc740107","user":{"login":"thewilkybarkid","id":1784740,"avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"(Do separate PRs in the future though, keeps unrelated changes separate and is clearer.)","created_at":"2017-12-14T16:19:35Z","updated_at":"2017-12-14T16:19:35Z","html_url":"https://github.com/elifesciences/profiles/pull/64#discussion_r156990331","pull_request_url":"https://api.github.com/repos/elifesciences/profiles/pulls/64","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/profiles/pulls/comments/156990331"},"html":{"href":"https://github.com/elifesciences/profiles/pull/64#discussion_r156990331"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/profiles/pulls/64"}},"in_reply_to_id":156982896},"pull_request":{"url":"https://api.github.com/repos/elifesciences/profiles/pulls/64","id":158302757,"html_url":"https://github.com/elifesciences/profiles/pull/64","diff_url":"https://github.com/elifesciences/profiles/pull/64.diff","patch_url":"https://github.com/elifesciences/profiles/pull/64.patch","issue_url":"https://api.github.com/repos/elifesciences/profiles/issues/64","number":64,"state":"open","locked":false,"title":"Catch any exception raised by an event handler","user":{"login":"thewilkybarkid","id":1784740,"avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"Bad things seem to happen if an event handler raises any exception, it gets disconnected and the database transaction doesn't complete, requiring a restart.","created_at":"2017-12-14T09:12:55Z","updated_at":"2017-12-14T16:19:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af7cfc1098e949b4d29e7a789b1b022df09bf458","assignee":null,"assignees":[],"requested_reviewers":[{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/profiles/pulls/64/commits","review_comments_url":"https://api.github.com/repos/elifesciences/profiles/pulls/64/comments","review_comment_url":"https://api.github.com/repos/elifesciences/profiles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/profiles/issues/64/comments","statuses_url":"https://api.github.com/repos/elifesciences/profiles/statuses/463ba9fe9eff169ca12e8772fb6d2dbe0f773b83","head":{"label":"elifesciences:event-exceptions","ref":"event-exceptions","sha":"463ba9fe9eff169ca12e8772fb6d2dbe0f773b83","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":94993646,"name":"profiles","full_name":"elifesciences/profiles","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/profiles","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/profiles","forks_url":"https://api.github.com/repos/elifesciences/profiles/forks","keys_url":"https://api.github.com/repos/elifesciences/profiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/profiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/profiles/teams","hooks_url":"https://api.github.com/repos/elifesciences/profiles/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/profiles/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/profiles/events","assignees_url":"https://api.github.com/repos/elifesciences/profiles/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/profiles/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/profiles/tags","blobs_url":"https://api.github.com/repos/elifesciences/profiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/profiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/profiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/profiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/profiles/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/profiles/languages","stargazers_url":"https://api.github.com/repos/elifesciences/profiles/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/profiles/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/profiles/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/profiles/subscription","commits_url":"https://api.github.com/repos/elifesciences/profiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/profiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/profiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/profiles/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/profiles/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/profiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/profiles/merges","archive_url":"https://api.github.com/repos/elifesciences/profiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/profiles/downloads","issues_url":"https://api.github.com/repos/elifesciences/profiles/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/profiles/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/profiles/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/profiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/profiles/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/profiles/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/profiles/deployments","created_at":"2017-06-21T10:43:52Z","updated_at":"2017-08-30T10:33:48Z","pushed_at":"2017-12-14T16:14:38Z","git_url":"git://github.com/elifesciences/profiles.git","ssh_url":"git@github.com:elifesciences/profiles.git","clone_url":"https://github.com/elifesciences/profiles.git","svn_url":"https://github.com/elifesciences/profiles","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"049e42a44198224d1ae04b17ca4e3673df649f99","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":94993646,"name":"profiles","full_name":"elifesciences/profiles","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/profiles","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/profiles","forks_url":"https://api.github.com/repos/elifesciences/profiles/forks","keys_url":"https://api.github.com/repos/elifesciences/profiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/profiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/profiles/teams","hooks_url":"https://api.github.com/repos/elifesciences/profiles/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/profiles/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/profiles/events","assignees_url":"https://api.github.com/repos/elifesciences/profiles/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/profiles/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/profiles/tags","blobs_url":"https://api.github.com/repos/elifesciences/profiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/profiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/profiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/profiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/profiles/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/profiles/languages","stargazers_url":"https://api.github.com/repos/elifesciences/profiles/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/profiles/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/profiles/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/profiles/subscription","commits_url":"https://api.github.com/repos/elifesciences/profiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/profiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/profiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/profiles/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/profiles/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/profiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/profiles/merges","archive_url":"https://api.github.com/repos/elifesciences/profiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/profiles/downloads","issues_url":"https://api.github.com/repos/elifesciences/profiles/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/profiles/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/profiles/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/profiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/profiles/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/profiles/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/profiles/deployments","created_at":"2017-06-21T10:43:52Z","updated_at":"2017-08-30T10:33:48Z","pushed_at":"2017-12-14T16:14:38Z","git_url":"git://github.com/elifesciences/profiles.git","ssh_url":"git@github.com:elifesciences/profiles.git","clone_url":"https://github.com/elifesciences/profiles.git","svn_url":"https://github.com/elifesciences/profiles","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/profiles/pulls/64"},"html":{"href":"https://github.com/elifesciences/profiles/pull/64"},"issue":{"href":"https://api.github.com/repos/elifesciences/profiles/issues/64"},"comments":{"href":"https://api.github.com/repos/elifesciences/profiles/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/profiles/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/profiles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/profiles/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/profiles/statuses/463ba9fe9eff169ca12e8772fb6d2dbe0f773b83"}},"author_association":"OWNER"}}
{"actor":{"display_login":"thewilkybarkid"}}