{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/comments/119023399","pull_request_review_id":40864656,"id":119023399,"diff_hunk":"@@ -44,10 +44,12 @@ public void sendNotification(final String organisationIdentification, final Stri\n             final String result, final String correlationUid, final String message, final Object notificationType) {\n \n         final String notifyUrl = this.notificationUrl(correlationUid);\n-        final SendNotificationRequest notificationRequest = this.notificationRequest(organisationIdentification,\n-                deviceIdentification, result, correlationUid, message, notificationType);\n-        this.doSendNotification(this.webServiceTemplateFactory, organisationIdentification, this.notificationUsername,\n-                notifyUrl, notificationRequest);\n+        if (notifyUrl != null && !notifyUrl.isEmpty() && !\"\\\"\\\"\".equals(notifyUrl)) {","path":"osgp-adapter-ws-smartmetering/src/main/java/com/alliander/osgp/adapter/ws/smartmetering/application/services/NotificationServiceWs.java","position":8,"original_position":8,"commit_id":"149c341927b917299d96daffdac97615ee82296c","original_commit_id":"149c341927b917299d96daffdac97615ee82296c","user":{"login":"robinbakkeruscgi","id":18286805,"avatar_url":"https://avatars0.githubusercontent.com/u/18286805?v=3","gravatar_id":"","url":"https://api.github.com/users/robinbakkeruscgi","html_url":"https://github.com/robinbakkeruscgi","followers_url":"https://api.github.com/users/robinbakkeruscgi/followers","following_url":"https://api.github.com/users/robinbakkeruscgi/following{/other_user}","gists_url":"https://api.github.com/users/robinbakkeruscgi/gists{/gist_id}","starred_url":"https://api.github.com/users/robinbakkeruscgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinbakkeruscgi/subscriptions","organizations_url":"https://api.github.com/users/robinbakkeruscgi/orgs","repos_url":"https://api.github.com/users/robinbakkeruscgi/repos","events_url":"https://api.github.com/users/robinbakkeruscgi/events{/privacy}","received_events_url":"https://api.github.com/users/robinbakkeruscgi/received_events","type":"User","site_admin":false},"body":"Yes, then you always get annoying error stack","created_at":"2017-05-30T06:58:38Z","updated_at":"2017-05-30T06:58:38Z","html_url":"https://github.com/OSGP/Platform/pull/607#discussion_r119023399","pull_request_url":"https://api.github.com/repos/OSGP/Platform/pulls/607","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments/119023399"},"html":{"href":"https://github.com/OSGP/Platform/pull/607#discussion_r119023399"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/607"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/607","id":121998909,"html_url":"https://github.com/OSGP/Platform/pull/607","diff_url":"https://github.com/OSGP/Platform/pull/607.diff","patch_url":"https://github.com/OSGP/Platform/pull/607.patch","issue_url":"https://api.github.com/repos/OSGP/Platform/issues/607","number":607,"state":"open","locked":false,"title":"Slim 975 modify couple mbus device for properly installed gasmeters","user":{"login":"robinbakkeruscgi","id":18286805,"avatar_url":"https://avatars0.githubusercontent.com/u/18286805?v=3","gravatar_id":"","url":"https://api.github.com/users/robinbakkeruscgi","html_url":"https://github.com/robinbakkeruscgi","followers_url":"https://api.github.com/users/robinbakkeruscgi/followers","following_url":"https://api.github.com/users/robinbakkeruscgi/following{/other_user}","gists_url":"https://api.github.com/users/robinbakkeruscgi/gists{/gist_id}","starred_url":"https://api.github.com/users/robinbakkeruscgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinbakkeruscgi/subscriptions","organizations_url":"https://api.github.com/users/robinbakkeruscgi/orgs","repos_url":"https://api.github.com/users/robinbakkeruscgi/repos","events_url":"https://api.github.com/users/robinbakkeruscgi/events{/privacy}","received_events_url":"https://api.github.com/users/robinbakkeruscgi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-23T13:32:47Z","updated_at":"2017-05-30T06:58:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9b9ba9dfc6c32289f30b5b1904bae64d8d16f15","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Platform/pulls/607/commits","review_comments_url":"https://api.github.com/repos/OSGP/Platform/pulls/607/comments","review_comment_url":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Platform/issues/607/comments","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/149c341927b917299d96daffdac97615ee82296c","head":{"label":"OSGP:SLIM-975-Modify_CoupleMbusDevice_for_properly_installed_gasmeters","ref":"SLIM-975-Modify_CoupleMbusDevice_for_properly_installed_gasmeters","sha":"149c341927b917299d96daffdac97615ee82296c","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2017-05-18T21:40:21Z","pushed_at":"2017-05-29T20:46:12Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":"http://www.opensmartgridplatform.org/","size":29548,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":21,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"9b7b8f134ad07e8424b08f088e3df13220dbcf19","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Platform/deployments","created_at":"2015-03-23T15:05:40Z","updated_at":"2017-05-18T21:40:21Z","pushed_at":"2017-05-29T20:46:12Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":"http://www.opensmartgridplatform.org/","size":29548,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":21,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/607"},"html":{"href":"https://github.com/OSGP/Platform/pull/607"},"issue":{"href":"https://api.github.com/repos/OSGP/Platform/issues/607"},"comments":{"href":"https://api.github.com/repos/OSGP/Platform/issues/607/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/607/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/607/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Platform/statuses/149c341927b917299d96daffdac97615ee82296c"}}}}
{"actor":{"display_login":"robinbakkeruscgi"}}