{"action":"created","comment":{"url":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/comments/131343096","pull_request_review_id":54313896,"id":131343096,"diff_hunk":"@@ -1817,6 +1829,61 @@ fluid_sample_in_rom(fluid_sample_t* sample)\n /*\n  * fluid_sample_import_sfont\n  */\n+#if LIBSNDFILE_SUPPORT\n+// virtual file access rountines to allow for handling\n+// samples as virtual files in memory\n+static sf_count_t\n+sfvio_get_filelen(void* user_data)\n+{\n+  fluid_sample_t *sample = (fluid_sample_t *)user_data;\n+\n+  return (sf_count_t)(sample->end + 1 - sample->start);\n+}\n+\n+static sf_count_t\n+sfvio_seek(sf_count_t offset, int whence, void* user_data)\n+{\n+  fluid_sample_t *sample = (fluid_sample_t *)user_data;\n+\n+  switch (whence)\n+  {\n+    case SEEK_SET:\n+      sample->userdata = (void *)offset;\n+      break;\n+    case SEEK_CUR:\n+      sample->userdata = (void *)((intptr_t)sample->userdata + offset);","path":"fluidsynth/src/sfloader/fluid_defsfont.c","position":52,"original_position":52,"commit_id":"8cac137c26760cd86d57123e4078b4278bfc84db","original_commit_id":"8cac137c26760cd86d57123e4078b4278bfc84db","user":{"login":"derselbst","id":8152480,"avatar_url":"https://avatars0.githubusercontent.com/u/8152480?v=4","gravatar_id":"","url":"https://api.github.com/users/derselbst","html_url":"https://github.com/derselbst","followers_url":"https://api.github.com/users/derselbst/followers","following_url":"https://api.github.com/users/derselbst/following{/other_user}","gists_url":"https://api.github.com/users/derselbst/gists{/gist_id}","starred_url":"https://api.github.com/users/derselbst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derselbst/subscriptions","organizations_url":"https://api.github.com/users/derselbst/orgs","repos_url":"https://api.github.com/users/derselbst/repos","events_url":"https://api.github.com/users/derselbst/events{/privacy}","received_events_url":"https://api.github.com/users/derselbst/received_events","type":"User","site_admin":false},"body":"But it confuses as you're not mangling with pointers, only with `sf_count_t`. So I'd prefer `sf_count_t`.","created_at":"2017-08-04T08:54:49Z","updated_at":"2017-08-04T08:54:50Z","html_url":"https://github.com/FluidSynth/fluidsynth/pull/183#discussion_r131343096","pull_request_url":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183","_links":{"self":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/comments/131343096"},"html":{"href":"https://github.com/FluidSynth/fluidsynth/pull/183#discussion_r131343096"},"pull_request":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183"}}},"pull_request":{"url":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183","id":133779262,"html_url":"https://github.com/FluidSynth/fluidsynth/pull/183","diff_url":"https://github.com/FluidSynth/fluidsynth/pull/183.diff","patch_url":"https://github.com/FluidSynth/fluidsynth/pull/183.patch","issue_url":"https://api.github.com/repos/FluidSynth/fluidsynth/issues/183","number":183,"state":"open","locked":false,"title":"Add support for sound fonts in SF3 format that contain Ogg Vorbis compressed samples","user":{"login":"fabiangreffrath","id":6449237,"avatar_url":"https://avatars2.githubusercontent.com/u/6449237?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiangreffrath","html_url":"https://github.com/fabiangreffrath","followers_url":"https://api.github.com/users/fabiangreffrath/followers","following_url":"https://api.github.com/users/fabiangreffrath/following{/other_user}","gists_url":"https://api.github.com/users/fabiangreffrath/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiangreffrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiangreffrath/subscriptions","organizations_url":"https://api.github.com/users/fabiangreffrath/orgs","repos_url":"https://api.github.com/users/fabiangreffrath/repos","events_url":"https://api.github.com/users/fabiangreffrath/events{/privacy}","received_events_url":"https://api.github.com/users/fabiangreffrath/received_events","type":"User","site_admin":false},"body":"Author: Fabian Greffrath <fabian@debian.org>\r\nBug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740710\r\nForwarded: https://sourceforge.net/p/fluidsynth/tickets/142/\r\nLast-Update: 2015-11-26\r\n\r\nFixes https://github.com/FluidSynth/fluidsynth/issues/140","created_at":"2017-08-02T18:38:44Z","updated_at":"2017-08-04T08:54:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58f934daa89cc8a648cadec6b9ce5e5a41952b59","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183/commits","review_comments_url":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183/comments","review_comment_url":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FluidSynth/fluidsynth/issues/183/comments","statuses_url":"https://api.github.com/repos/FluidSynth/fluidsynth/statuses/8cac137c26760cd86d57123e4078b4278bfc84db","head":{"label":"fabiangreffrath:sf3-fonts","ref":"sf3-fonts","sha":"8cac137c26760cd86d57123e4078b4278bfc84db","user":{"login":"fabiangreffrath","id":6449237,"avatar_url":"https://avatars2.githubusercontent.com/u/6449237?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiangreffrath","html_url":"https://github.com/fabiangreffrath","followers_url":"https://api.github.com/users/fabiangreffrath/followers","following_url":"https://api.github.com/users/fabiangreffrath/following{/other_user}","gists_url":"https://api.github.com/users/fabiangreffrath/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiangreffrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiangreffrath/subscriptions","organizations_url":"https://api.github.com/users/fabiangreffrath/orgs","repos_url":"https://api.github.com/users/fabiangreffrath/repos","events_url":"https://api.github.com/users/fabiangreffrath/events{/privacy}","received_events_url":"https://api.github.com/users/fabiangreffrath/received_events","type":"User","site_admin":false},"repo":{"id":99149262,"name":"fluidsynth","full_name":"fabiangreffrath/fluidsynth","owner":{"login":"fabiangreffrath","id":6449237,"avatar_url":"https://avatars2.githubusercontent.com/u/6449237?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiangreffrath","html_url":"https://github.com/fabiangreffrath","followers_url":"https://api.github.com/users/fabiangreffrath/followers","following_url":"https://api.github.com/users/fabiangreffrath/following{/other_user}","gists_url":"https://api.github.com/users/fabiangreffrath/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiangreffrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiangreffrath/subscriptions","organizations_url":"https://api.github.com/users/fabiangreffrath/orgs","repos_url":"https://api.github.com/users/fabiangreffrath/repos","events_url":"https://api.github.com/users/fabiangreffrath/events{/privacy}","received_events_url":"https://api.github.com/users/fabiangreffrath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabiangreffrath/fluidsynth","description":"Software synthesizer based on the SoundFont 2 specifications","fork":true,"url":"https://api.github.com/repos/fabiangreffrath/fluidsynth","forks_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/forks","keys_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/teams","hooks_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/hooks","issue_events_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/issues/events{/number}","events_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/events","assignees_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/assignees{/user}","branches_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/branches{/branch}","tags_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/tags","blobs_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/statuses/{sha}","languages_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/languages","stargazers_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/stargazers","contributors_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/contributors","subscribers_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/subscribers","subscription_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/subscription","commits_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/contents/{+path}","compare_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/merges","archive_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/downloads","issues_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/issues{/number}","pulls_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/pulls{/number}","milestones_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/milestones{/number}","notifications_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/labels{/name}","releases_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/releases{/id}","deployments_url":"https://api.github.com/repos/fabiangreffrath/fluidsynth/deployments","created_at":"2017-08-02T18:33:58Z","updated_at":"2017-08-02T18:34:01Z","pushed_at":"2017-08-03T21:48:55Z","git_url":"git://github.com/fabiangreffrath/fluidsynth.git","ssh_url":"git@github.com:fabiangreffrath/fluidsynth.git","clone_url":"https://github.com/fabiangreffrath/fluidsynth.git","svn_url":"https://github.com/fabiangreffrath/fluidsynth","homepage":"http://www.fluidsynth.org","size":2010,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FluidSynth:master","ref":"master","sha":"25e7eb0c6ba7d25ab661f1613c25f1e297bfc327","user":{"login":"FluidSynth","id":29670198,"avatar_url":"https://avatars1.githubusercontent.com/u/29670198?v=4","gravatar_id":"","url":"https://api.github.com/users/FluidSynth","html_url":"https://github.com/FluidSynth","followers_url":"https://api.github.com/users/FluidSynth/followers","following_url":"https://api.github.com/users/FluidSynth/following{/other_user}","gists_url":"https://api.github.com/users/FluidSynth/gists{/gist_id}","starred_url":"https://api.github.com/users/FluidSynth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluidSynth/subscriptions","organizations_url":"https://api.github.com/users/FluidSynth/orgs","repos_url":"https://api.github.com/users/FluidSynth/repos","events_url":"https://api.github.com/users/FluidSynth/events{/privacy}","received_events_url":"https://api.github.com/users/FluidSynth/received_events","type":"Organization","site_admin":false},"repo":{"id":95304991,"name":"fluidsynth","full_name":"FluidSynth/fluidsynth","owner":{"login":"FluidSynth","id":29670198,"avatar_url":"https://avatars1.githubusercontent.com/u/29670198?v=4","gravatar_id":"","url":"https://api.github.com/users/FluidSynth","html_url":"https://github.com/FluidSynth","followers_url":"https://api.github.com/users/FluidSynth/followers","following_url":"https://api.github.com/users/FluidSynth/following{/other_user}","gists_url":"https://api.github.com/users/FluidSynth/gists{/gist_id}","starred_url":"https://api.github.com/users/FluidSynth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluidSynth/subscriptions","organizations_url":"https://api.github.com/users/FluidSynth/orgs","repos_url":"https://api.github.com/users/FluidSynth/repos","events_url":"https://api.github.com/users/FluidSynth/events{/privacy}","received_events_url":"https://api.github.com/users/FluidSynth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FluidSynth/fluidsynth","description":"Software synthesizer based on the SoundFont 2 specifications","fork":false,"url":"https://api.github.com/repos/FluidSynth/fluidsynth","forks_url":"https://api.github.com/repos/FluidSynth/fluidsynth/forks","keys_url":"https://api.github.com/repos/FluidSynth/fluidsynth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluidSynth/fluidsynth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluidSynth/fluidsynth/teams","hooks_url":"https://api.github.com/repos/FluidSynth/fluidsynth/hooks","issue_events_url":"https://api.github.com/repos/FluidSynth/fluidsynth/issues/events{/number}","events_url":"https://api.github.com/repos/FluidSynth/fluidsynth/events","assignees_url":"https://api.github.com/repos/FluidSynth/fluidsynth/assignees{/user}","branches_url":"https://api.github.com/repos/FluidSynth/fluidsynth/branches{/branch}","tags_url":"https://api.github.com/repos/FluidSynth/fluidsynth/tags","blobs_url":"https://api.github.com/repos/FluidSynth/fluidsynth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluidSynth/fluidsynth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluidSynth/fluidsynth/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluidSynth/fluidsynth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluidSynth/fluidsynth/statuses/{sha}","languages_url":"https://api.github.com/repos/FluidSynth/fluidsynth/languages","stargazers_url":"https://api.github.com/repos/FluidSynth/fluidsynth/stargazers","contributors_url":"https://api.github.com/repos/FluidSynth/fluidsynth/contributors","subscribers_url":"https://api.github.com/repos/FluidSynth/fluidsynth/subscribers","subscription_url":"https://api.github.com/repos/FluidSynth/fluidsynth/subscription","commits_url":"https://api.github.com/repos/FluidSynth/fluidsynth/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluidSynth/fluidsynth/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluidSynth/fluidsynth/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluidSynth/fluidsynth/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluidSynth/fluidsynth/contents/{+path}","compare_url":"https://api.github.com/repos/FluidSynth/fluidsynth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluidSynth/fluidsynth/merges","archive_url":"https://api.github.com/repos/FluidSynth/fluidsynth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluidSynth/fluidsynth/downloads","issues_url":"https://api.github.com/repos/FluidSynth/fluidsynth/issues{/number}","pulls_url":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls{/number}","milestones_url":"https://api.github.com/repos/FluidSynth/fluidsynth/milestones{/number}","notifications_url":"https://api.github.com/repos/FluidSynth/fluidsynth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluidSynth/fluidsynth/labels{/name}","releases_url":"https://api.github.com/repos/FluidSynth/fluidsynth/releases{/id}","deployments_url":"https://api.github.com/repos/FluidSynth/fluidsynth/deployments","created_at":"2017-06-24T15:09:55Z","updated_at":"2017-08-04T03:37:34Z","pushed_at":"2017-08-03T21:48:57Z","git_url":"git://github.com/FluidSynth/fluidsynth.git","ssh_url":"git@github.com:FluidSynth/fluidsynth.git","clone_url":"https://github.com/FluidSynth/fluidsynth.git","svn_url":"https://github.com/FluidSynth/fluidsynth","homepage":"http://www.fluidsynth.org","size":2137,"stargazers_count":20,"watchers_count":20,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":58,"forks":7,"open_issues":58,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183"},"html":{"href":"https://github.com/FluidSynth/fluidsynth/pull/183"},"issue":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/issues/183"},"comments":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/FluidSynth/fluidsynth/statuses/8cac137c26760cd86d57123e4078b4278bfc84db"}}}}
{"actor":{"display_login":"derselbst"}}