{"action":"created","comment":{"url":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/comments/104412599","pull_request_review_id":25248157,"id":104412599,"diff_hunk":"@@ -0,0 +1,58 @@\n+/*\n+ * Copyright 2015-2017 EMBL - European Bioinformatics Institute\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package uk.ac.ebi.eva.test.utils;\n+\n+import com.mongodb.BasicDBObject;\n+import com.mongodb.DBCollection;\n+\n+import static org.junit.Assert.assertEquals;\n+import static uk.ac.ebi.eva.commons.models.converters.data.VariantToDBObjectConverter.FILES_FIELD;\n+import static uk.ac.ebi.eva.commons.models.converters.data.VariantToDBObjectConverter.STATS_FIELD;\n+import static uk.ac.ebi.eva.commons.models.data.VariantSourceEntity.STUDYID_FIELD;\n+\n+public class DropStudyJobTestUtils {","path":"src/test/java/uk/ac/ebi/eva/test/utils/DropStudyJobTestUtils.java","position":27,"original_position":27,"commit_id":"4d08a6a086cbe693b9194d3f76e671f302f17d7d","original_commit_id":"4d08a6a086cbe693b9194d3f76e671f302f17d7d","user":{"login":"cyenyxe","id":1433407,"avatar_url":"https://avatars3.githubusercontent.com/u/1433407?v=3","gravatar_id":"","url":"https://api.github.com/users/cyenyxe","html_url":"https://github.com/cyenyxe","followers_url":"https://api.github.com/users/cyenyxe/followers","following_url":"https://api.github.com/users/cyenyxe/following{/other_user}","gists_url":"https://api.github.com/users/cyenyxe/gists{/gist_id}","starred_url":"https://api.github.com/users/cyenyxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyenyxe/subscriptions","organizations_url":"https://api.github.com/users/cyenyxe/orgs","repos_url":"https://api.github.com/users/cyenyxe/repos","events_url":"https://api.github.com/users/cyenyxe/events{/privacy}","received_events_url":"https://api.github.com/users/cyenyxe/received_events","type":"User","site_admin":false},"body":"Fine then. Could they be accessed in a consistent way? `PullFilesAndStatisticsByStudyStepTest` uses a regular import but `DropStudyJobTest` uses static imports.","created_at":"2017-03-06T13:28:22Z","updated_at":"2017-03-06T13:28:22Z","html_url":"https://github.com/EBIvariation/eva-pipeline/pull/103#discussion_r104412599","pull_request_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/comments/104412599"},"html":{"href":"https://github.com/EBIvariation/eva-pipeline/pull/103#discussion_r104412599"},"pull_request":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103","id":109231753,"html_url":"https://github.com/EBIvariation/eva-pipeline/pull/103","diff_url":"https://github.com/EBIvariation/eva-pipeline/pull/103.diff","patch_url":"https://github.com/EBIvariation/eva-pipeline/pull/103.patch","issue_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/issues/103","number":103,"state":"open","locked":false,"title":"EVA-680 Job to drop study from Mongo","user":{"login":"jmmut","id":4750555,"avatar_url":"https://avatars0.githubusercontent.com/u/4750555?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmut","html_url":"https://github.com/jmmut","followers_url":"https://api.github.com/users/jmmut/followers","following_url":"https://api.github.com/users/jmmut/following{/other_user}","gists_url":"https://api.github.com/users/jmmut/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmut/subscriptions","organizations_url":"https://api.github.com/users/jmmut/orgs","repos_url":"https://api.github.com/users/jmmut/repos","events_url":"https://api.github.com/users/jmmut/events{/privacy}","received_events_url":"https://api.github.com/users/jmmut/received_events","type":"User","site_admin":false},"body":"- job wiring up the three steps (dropSingleStudyVariantsStep, dropVariantsAndStatisticsByStudyStep, dropVariantsAndStatisticsByStudyStep)\r\n- job test\r\n- parameters validator for the job (and validator test)\r\n- parameters validators for the three steps (and validator tests)\r\n- some general improvements (extracting common methods and improving logs)","created_at":"2017-03-06T10:45:21Z","updated_at":"2017-03-06T13:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdad7d64a351542f76cb26e1a59b2e9d0d90bd91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103/commits","review_comments_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103/comments","review_comment_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/issues/103/comments","statuses_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/statuses/4d08a6a086cbe693b9194d3f76e671f302f17d7d","head":{"label":"jmmut:feature/drop-study-job","ref":"feature/drop-study-job","sha":"4d08a6a086cbe693b9194d3f76e671f302f17d7d","user":{"login":"jmmut","id":4750555,"avatar_url":"https://avatars0.githubusercontent.com/u/4750555?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmut","html_url":"https://github.com/jmmut","followers_url":"https://api.github.com/users/jmmut/followers","following_url":"https://api.github.com/users/jmmut/following{/other_user}","gists_url":"https://api.github.com/users/jmmut/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmut/subscriptions","organizations_url":"https://api.github.com/users/jmmut/orgs","repos_url":"https://api.github.com/users/jmmut/repos","events_url":"https://api.github.com/users/jmmut/events{/privacy}","received_events_url":"https://api.github.com/users/jmmut/received_events","type":"User","site_admin":false},"repo":{"id":34727847,"name":"eva-pipeline","full_name":"jmmut/eva-pipeline","owner":{"login":"jmmut","id":4750555,"avatar_url":"https://avatars0.githubusercontent.com/u/4750555?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmut","html_url":"https://github.com/jmmut","followers_url":"https://api.github.com/users/jmmut/followers","following_url":"https://api.github.com/users/jmmut/following{/other_user}","gists_url":"https://api.github.com/users/jmmut/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmut/subscriptions","organizations_url":"https://api.github.com/users/jmmut/orgs","repos_url":"https://api.github.com/users/jmmut/repos","events_url":"https://api.github.com/users/jmmut/events{/privacy}","received_events_url":"https://api.github.com/users/jmmut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmut/eva-pipeline","description":"Pipeline for the European Variation Archive, implemented using Luigi from Spotify (https://github.com/spotify/luigi)","fork":true,"url":"https://api.github.com/repos/jmmut/eva-pipeline","forks_url":"https://api.github.com/repos/jmmut/eva-pipeline/forks","keys_url":"https://api.github.com/repos/jmmut/eva-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmut/eva-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmut/eva-pipeline/teams","hooks_url":"https://api.github.com/repos/jmmut/eva-pipeline/hooks","issue_events_url":"https://api.github.com/repos/jmmut/eva-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/jmmut/eva-pipeline/events","assignees_url":"https://api.github.com/repos/jmmut/eva-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/jmmut/eva-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/jmmut/eva-pipeline/tags","blobs_url":"https://api.github.com/repos/jmmut/eva-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmut/eva-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmut/eva-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmut/eva-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmut/eva-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmut/eva-pipeline/languages","stargazers_url":"https://api.github.com/repos/jmmut/eva-pipeline/stargazers","contributors_url":"https://api.github.com/repos/jmmut/eva-pipeline/contributors","subscribers_url":"https://api.github.com/repos/jmmut/eva-pipeline/subscribers","subscription_url":"https://api.github.com/repos/jmmut/eva-pipeline/subscription","commits_url":"https://api.github.com/repos/jmmut/eva-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmut/eva-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmut/eva-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmut/eva-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmut/eva-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/jmmut/eva-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmut/eva-pipeline/merges","archive_url":"https://api.github.com/repos/jmmut/eva-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmut/eva-pipeline/downloads","issues_url":"https://api.github.com/repos/jmmut/eva-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/jmmut/eva-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmut/eva-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmut/eva-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmut/eva-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/jmmut/eva-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/jmmut/eva-pipeline/deployments","created_at":"2015-04-28T11:58:24Z","updated_at":"2016-09-12T15:46:43Z","pushed_at":"2017-03-06T11:03:59Z","git_url":"git://github.com/jmmut/eva-pipeline.git","ssh_url":"git@github.com:jmmut/eva-pipeline.git","clone_url":"https://github.com/jmmut/eva-pipeline.git","svn_url":"https://github.com/jmmut/eva-pipeline","homepage":null,"size":2686,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"EBIvariation:develop","ref":"develop","sha":"064959d01713569f0fc1439b520cf8a175695238","user":{"login":"EBIvariation","id":6419333,"avatar_url":"https://avatars2.githubusercontent.com/u/6419333?v=3","gravatar_id":"","url":"https://api.github.com/users/EBIvariation","html_url":"https://github.com/EBIvariation","followers_url":"https://api.github.com/users/EBIvariation/followers","following_url":"https://api.github.com/users/EBIvariation/following{/other_user}","gists_url":"https://api.github.com/users/EBIvariation/gists{/gist_id}","starred_url":"https://api.github.com/users/EBIvariation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EBIvariation/subscriptions","organizations_url":"https://api.github.com/users/EBIvariation/orgs","repos_url":"https://api.github.com/users/EBIvariation/repos","events_url":"https://api.github.com/users/EBIvariation/events{/privacy}","received_events_url":"https://api.github.com/users/EBIvariation/received_events","type":"Organization","site_admin":false},"repo":{"id":29298780,"name":"eva-pipeline","full_name":"EBIvariation/eva-pipeline","owner":{"login":"EBIvariation","id":6419333,"avatar_url":"https://avatars2.githubusercontent.com/u/6419333?v=3","gravatar_id":"","url":"https://api.github.com/users/EBIvariation","html_url":"https://github.com/EBIvariation","followers_url":"https://api.github.com/users/EBIvariation/followers","following_url":"https://api.github.com/users/EBIvariation/following{/other_user}","gists_url":"https://api.github.com/users/EBIvariation/gists{/gist_id}","starred_url":"https://api.github.com/users/EBIvariation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EBIvariation/subscriptions","organizations_url":"https://api.github.com/users/EBIvariation/orgs","repos_url":"https://api.github.com/users/EBIvariation/repos","events_url":"https://api.github.com/users/EBIvariation/events{/privacy}","received_events_url":"https://api.github.com/users/EBIvariation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EBIvariation/eva-pipeline","description":"Genomic variation pipeline for the European Variation Archive, implemented using Spring Batch","fork":false,"url":"https://api.github.com/repos/EBIvariation/eva-pipeline","forks_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/forks","keys_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/teams","hooks_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/hooks","issue_events_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/events","assignees_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/tags","blobs_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/languages","stargazers_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/stargazers","contributors_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/contributors","subscribers_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/subscribers","subscription_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/subscription","commits_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/merges","archive_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/downloads","issues_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/EBIvariation/eva-pipeline/deployments","created_at":"2015-01-15T13:34:10Z","updated_at":"2016-12-02T17:08:49Z","pushed_at":"2017-03-06T11:04:01Z","git_url":"git://github.com/EBIvariation/eva-pipeline.git","ssh_url":"git@github.com:EBIvariation/eva-pipeline.git","clone_url":"https://github.com/EBIvariation/eva-pipeline.git","svn_url":"https://github.com/EBIvariation/eva-pipeline","homepage":"http://www.ebi.ac.uk/eva","size":2649,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103"},"html":{"href":"https://github.com/EBIvariation/eva-pipeline/pull/103"},"issue":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/issues/103"},"comments":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/EBIvariation/eva-pipeline/statuses/4d08a6a086cbe693b9194d3f76e671f302f17d7d"}}}}
{"actor":{"display_login":"cyenyxe"}}