{"action":"closed","number":83,"pull_request":{"url":"https://api.github.com/repos/Giselelasserre/casual/pulls/83","id":138680959,"html_url":"https://github.com/Giselelasserre/casual/pull/83","diff_url":"https://github.com/Giselelasserre/casual/pull/83.diff","patch_url":"https://github.com/Giselelasserre/casual/pull/83.patch","issue_url":"https://api.github.com/repos/Giselelasserre/casual/issues/83","number":83,"state":"closed","locked":false,"title":"fix-sign-up","user":{"login":"fhbmelloz6","id":13971527,"avatar_url":"https://avatars3.githubusercontent.com/u/13971527?v=4","gravatar_id":"","url":"https://api.github.com/users/fhbmelloz6","html_url":"https://github.com/fhbmelloz6","followers_url":"https://api.github.com/users/fhbmelloz6/followers","following_url":"https://api.github.com/users/fhbmelloz6/following{/other_user}","gists_url":"https://api.github.com/users/fhbmelloz6/gists{/gist_id}","starred_url":"https://api.github.com/users/fhbmelloz6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhbmelloz6/subscriptions","organizations_url":"https://api.github.com/users/fhbmelloz6/orgs","repos_url":"https://api.github.com/users/fhbmelloz6/repos","events_url":"https://api.github.com/users/fhbmelloz6/events{/privacy}","received_events_url":"https://api.github.com/users/fhbmelloz6/received_events","type":"User","site_admin":false},"body":"This change includes parameters besides the devise default e-mail, password and FB avatar picture  which are available when on uses FB sign in.\r\nIn the case of e-mail sign in we included first_name, last_name and avatar.\r\navatar was especially tricky as it requires lots of attention in the s at the end of avatar and attachments as there is just one avatar for any users, everything should be in singular.\r\nVery important, also, was to include an if structure at the _navbar.html.erb in order to check if the current_user.facebook_picture_url is available, and will be used, otherwise, for e-mail sign in, avatar_url = cl_image_path(current_user.avatar.path will be used, else the default \"avatar_demo.jpg\" is used.\r\n","created_at":"2017-08-31T14:25:41Z","updated_at":"2017-08-31T14:56:49Z","closed_at":"2017-08-31T14:56:48Z","merged_at":"2017-08-31T14:56:48Z","merge_commit_sha":"a654f1b07295d42d41886df329609a101ad94a51","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Giselelasserre/casual/pulls/83/commits","review_comments_url":"https://api.github.com/repos/Giselelasserre/casual/pulls/83/comments","review_comment_url":"https://api.github.com/repos/Giselelasserre/casual/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Giselelasserre/casual/issues/83/comments","statuses_url":"https://api.github.com/repos/Giselelasserre/casual/statuses/d0c72c97e72ee80db53ef8ebc530d5de88b575cb","head":{"label":"Giselelasserre:fix-sign-up","ref":"fix-sign-up","sha":"d0c72c97e72ee80db53ef8ebc530d5de88b575cb","user":{"login":"Giselelasserre","id":26511507,"avatar_url":"https://avatars2.githubusercontent.com/u/26511507?v=4","gravatar_id":"","url":"https://api.github.com/users/Giselelasserre","html_url":"https://github.com/Giselelasserre","followers_url":"https://api.github.com/users/Giselelasserre/followers","following_url":"https://api.github.com/users/Giselelasserre/following{/other_user}","gists_url":"https://api.github.com/users/Giselelasserre/gists{/gist_id}","starred_url":"https://api.github.com/users/Giselelasserre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Giselelasserre/subscriptions","organizations_url":"https://api.github.com/users/Giselelasserre/orgs","repos_url":"https://api.github.com/users/Giselelasserre/repos","events_url":"https://api.github.com/users/Giselelasserre/events{/privacy}","received_events_url":"https://api.github.com/users/Giselelasserre/received_events","type":"User","site_admin":false},"repo":{"id":100974953,"name":"casual","full_name":"Giselelasserre/casual","owner":{"login":"Giselelasserre","id":26511507,"avatar_url":"https://avatars2.githubusercontent.com/u/26511507?v=4","gravatar_id":"","url":"https://api.github.com/users/Giselelasserre","html_url":"https://github.com/Giselelasserre","followers_url":"https://api.github.com/users/Giselelasserre/followers","following_url":"https://api.github.com/users/Giselelasserre/following{/other_user}","gists_url":"https://api.github.com/users/Giselelasserre/gists{/gist_id}","starred_url":"https://api.github.com/users/Giselelasserre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Giselelasserre/subscriptions","organizations_url":"https://api.github.com/users/Giselelasserre/orgs","repos_url":"https://api.github.com/users/Giselelasserre/repos","events_url":"https://api.github.com/users/Giselelasserre/events{/privacy}","received_events_url":"https://api.github.com/users/Giselelasserre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Giselelasserre/casual","description":"Final Project Le Wagon","fork":false,"url":"https://api.github.com/repos/Giselelasserre/casual","forks_url":"https://api.github.com/repos/Giselelasserre/casual/forks","keys_url":"https://api.github.com/repos/Giselelasserre/casual/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Giselelasserre/casual/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Giselelasserre/casual/teams","hooks_url":"https://api.github.com/repos/Giselelasserre/casual/hooks","issue_events_url":"https://api.github.com/repos/Giselelasserre/casual/issues/events{/number}","events_url":"https://api.github.com/repos/Giselelasserre/casual/events","assignees_url":"https://api.github.com/repos/Giselelasserre/casual/assignees{/user}","branches_url":"https://api.github.com/repos/Giselelasserre/casual/branches{/branch}","tags_url":"https://api.github.com/repos/Giselelasserre/casual/tags","blobs_url":"https://api.github.com/repos/Giselelasserre/casual/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Giselelasserre/casual/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Giselelasserre/casual/git/refs{/sha}","trees_url":"https://api.github.com/repos/Giselelasserre/casual/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Giselelasserre/casual/statuses/{sha}","languages_url":"https://api.github.com/repos/Giselelasserre/casual/languages","stargazers_url":"https://api.github.com/repos/Giselelasserre/casual/stargazers","contributors_url":"https://api.github.com/repos/Giselelasserre/casual/contributors","subscribers_url":"https://api.github.com/repos/Giselelasserre/casual/subscribers","subscription_url":"https://api.github.com/repos/Giselelasserre/casual/subscription","commits_url":"https://api.github.com/repos/Giselelasserre/casual/commits{/sha}","git_commits_url":"https://api.github.com/repos/Giselelasserre/casual/git/commits{/sha}","comments_url":"https://api.github.com/repos/Giselelasserre/casual/comments{/number}","issue_comment_url":"https://api.github.com/repos/Giselelasserre/casual/issues/comments{/number}","contents_url":"https://api.github.com/repos/Giselelasserre/casual/contents/{+path}","compare_url":"https://api.github.com/repos/Giselelasserre/casual/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Giselelasserre/casual/merges","archive_url":"https://api.github.com/repos/Giselelasserre/casual/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Giselelasserre/casual/downloads","issues_url":"https://api.github.com/repos/Giselelasserre/casual/issues{/number}","pulls_url":"https://api.github.com/repos/Giselelasserre/casual/pulls{/number}","milestones_url":"https://api.github.com/repos/Giselelasserre/casual/milestones{/number}","notifications_url":"https://api.github.com/repos/Giselelasserre/casual/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Giselelasserre/casual/labels{/name}","releases_url":"https://api.github.com/repos/Giselelasserre/casual/releases{/id}","deployments_url":"https://api.github.com/repos/Giselelasserre/casual/deployments","created_at":"2017-08-21T17:06:46Z","updated_at":"2017-08-30T19:18:35Z","pushed_at":"2017-08-31T14:56:48Z","git_url":"git://github.com/Giselelasserre/casual.git","ssh_url":"git@github.com:Giselelasserre/casual.git","clone_url":"https://github.com/Giselelasserre/casual.git","svn_url":"https://github.com/Giselelasserre/casual","homepage":null,"size":5677,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"base":{"label":"Giselelasserre:master","ref":"master","sha":"3101d074c606b32b94af1972367def21df347643","user":{"login":"Giselelasserre","id":26511507,"avatar_url":"https://avatars2.githubusercontent.com/u/26511507?v=4","gravatar_id":"","url":"https://api.github.com/users/Giselelasserre","html_url":"https://github.com/Giselelasserre","followers_url":"https://api.github.com/users/Giselelasserre/followers","following_url":"https://api.github.com/users/Giselelasserre/following{/other_user}","gists_url":"https://api.github.com/users/Giselelasserre/gists{/gist_id}","starred_url":"https://api.github.com/users/Giselelasserre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Giselelasserre/subscriptions","organizations_url":"https://api.github.com/users/Giselelasserre/orgs","repos_url":"https://api.github.com/users/Giselelasserre/repos","events_url":"https://api.github.com/users/Giselelasserre/events{/privacy}","received_events_url":"https://api.github.com/users/Giselelasserre/received_events","type":"User","site_admin":false},"repo":{"id":100974953,"name":"casual","full_name":"Giselelasserre/casual","owner":{"login":"Giselelasserre","id":26511507,"avatar_url":"https://avatars2.githubusercontent.com/u/26511507?v=4","gravatar_id":"","url":"https://api.github.com/users/Giselelasserre","html_url":"https://github.com/Giselelasserre","followers_url":"https://api.github.com/users/Giselelasserre/followers","following_url":"https://api.github.com/users/Giselelasserre/following{/other_user}","gists_url":"https://api.github.com/users/Giselelasserre/gists{/gist_id}","starred_url":"https://api.github.com/users/Giselelasserre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Giselelasserre/subscriptions","organizations_url":"https://api.github.com/users/Giselelasserre/orgs","repos_url":"https://api.github.com/users/Giselelasserre/repos","events_url":"https://api.github.com/users/Giselelasserre/events{/privacy}","received_events_url":"https://api.github.com/users/Giselelasserre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Giselelasserre/casual","description":"Final Project Le Wagon","fork":false,"url":"https://api.github.com/repos/Giselelasserre/casual","forks_url":"https://api.github.com/repos/Giselelasserre/casual/forks","keys_url":"https://api.github.com/repos/Giselelasserre/casual/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Giselelasserre/casual/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Giselelasserre/casual/teams","hooks_url":"https://api.github.com/repos/Giselelasserre/casual/hooks","issue_events_url":"https://api.github.com/repos/Giselelasserre/casual/issues/events{/number}","events_url":"https://api.github.com/repos/Giselelasserre/casual/events","assignees_url":"https://api.github.com/repos/Giselelasserre/casual/assignees{/user}","branches_url":"https://api.github.com/repos/Giselelasserre/casual/branches{/branch}","tags_url":"https://api.github.com/repos/Giselelasserre/casual/tags","blobs_url":"https://api.github.com/repos/Giselelasserre/casual/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Giselelasserre/casual/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Giselelasserre/casual/git/refs{/sha}","trees_url":"https://api.github.com/repos/Giselelasserre/casual/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Giselelasserre/casual/statuses/{sha}","languages_url":"https://api.github.com/repos/Giselelasserre/casual/languages","stargazers_url":"https://api.github.com/repos/Giselelasserre/casual/stargazers","contributors_url":"https://api.github.com/repos/Giselelasserre/casual/contributors","subscribers_url":"https://api.github.com/repos/Giselelasserre/casual/subscribers","subscription_url":"https://api.github.com/repos/Giselelasserre/casual/subscription","commits_url":"https://api.github.com/repos/Giselelasserre/casual/commits{/sha}","git_commits_url":"https://api.github.com/repos/Giselelasserre/casual/git/commits{/sha}","comments_url":"https://api.github.com/repos/Giselelasserre/casual/comments{/number}","issue_comment_url":"https://api.github.com/repos/Giselelasserre/casual/issues/comments{/number}","contents_url":"https://api.github.com/repos/Giselelasserre/casual/contents/{+path}","compare_url":"https://api.github.com/repos/Giselelasserre/casual/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Giselelasserre/casual/merges","archive_url":"https://api.github.com/repos/Giselelasserre/casual/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Giselelasserre/casual/downloads","issues_url":"https://api.github.com/repos/Giselelasserre/casual/issues{/number}","pulls_url":"https://api.github.com/repos/Giselelasserre/casual/pulls{/number}","milestones_url":"https://api.github.com/repos/Giselelasserre/casual/milestones{/number}","notifications_url":"https://api.github.com/repos/Giselelasserre/casual/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Giselelasserre/casual/labels{/name}","releases_url":"https://api.github.com/repos/Giselelasserre/casual/releases{/id}","deployments_url":"https://api.github.com/repos/Giselelasserre/casual/deployments","created_at":"2017-08-21T17:06:46Z","updated_at":"2017-08-30T19:18:35Z","pushed_at":"2017-08-31T14:56:48Z","git_url":"git://github.com/Giselelasserre/casual.git","ssh_url":"git@github.com:Giselelasserre/casual.git","clone_url":"https://github.com/Giselelasserre/casual.git","svn_url":"https://github.com/Giselelasserre/casual","homepage":null,"size":5677,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Giselelasserre/casual/pulls/83"},"html":{"href":"https://github.com/Giselelasserre/casual/pull/83"},"issue":{"href":"https://api.github.com/repos/Giselelasserre/casual/issues/83"},"comments":{"href":"https://api.github.com/repos/Giselelasserre/casual/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/Giselelasserre/casual/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/Giselelasserre/casual/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Giselelasserre/casual/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/Giselelasserre/casual/statuses/d0c72c97e72ee80db53ef8ebc530d5de88b575cb"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Giselelasserre","id":26511507,"avatar_url":"https://avatars2.githubusercontent.com/u/26511507?v=4","gravatar_id":"","url":"https://api.github.com/users/Giselelasserre","html_url":"https://github.com/Giselelasserre","followers_url":"https://api.github.com/users/Giselelasserre/followers","following_url":"https://api.github.com/users/Giselelasserre/following{/other_user}","gists_url":"https://api.github.com/users/Giselelasserre/gists{/gist_id}","starred_url":"https://api.github.com/users/Giselelasserre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Giselelasserre/subscriptions","organizations_url":"https://api.github.com/users/Giselelasserre/orgs","repos_url":"https://api.github.com/users/Giselelasserre/repos","events_url":"https://api.github.com/users/Giselelasserre/events{/privacy}","received_events_url":"https://api.github.com/users/Giselelasserre/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"Giselelasserre"}}