{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/2236","repository_url":"https://api.github.com/repos/nunit/nunit","labels_url":"https://api.github.com/repos/nunit/nunit/issues/2236/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/2236/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/2236/events","html_url":"https://github.com/nunit/nunit/pull/2236","id":234859021,"number":2236,"title":"Simplified event queue for discussion relating to #2217","user":{"login":"appel1","id":973314,"avatar_url":"https://avatars0.githubusercontent.com/u/973314?v=3","gravatar_id":"","url":"https://api.github.com/users/appel1","html_url":"https://github.com/appel1","followers_url":"https://api.github.com/users/appel1/followers","following_url":"https://api.github.com/users/appel1/following{/other_user}","gists_url":"https://api.github.com/users/appel1/gists{/gist_id}","starred_url":"https://api.github.com/users/appel1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appel1/subscriptions","organizations_url":"https://api.github.com/users/appel1/orgs","repos_url":"https://api.github.com/users/appel1/repos","events_url":"https://api.github.com/users/appel1/events{/privacy}","received_events_url":"https://api.github.com/users/appel1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2017-06-09T15:17:52Z","updated_at":"2017-06-26T11:19:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/2236","html_url":"https://github.com/nunit/nunit/pull/2236","diff_url":"https://github.com/nunit/nunit/pull/2236.diff","patch_url":"https://github.com/nunit/nunit/pull/2236.patch"},"body":"I believe this fixes the regression described in #2217. \r\n\r\nAs I wrote in the issue I don't think this breaks anything but the comments and logs doesn't make it clear to me why the Dequeue implementation was so complex so it is very possible I've missed testing such situations. \r\n\r\nFixes #2217"},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/311031551","html_url":"https://github.com/nunit/nunit/pull/2236#issuecomment-311031551","issue_url":"https://api.github.com/repos/nunit/nunit/issues/2236","id":311031551,"user":{"login":"oznetmaster","id":5798625,"avatar_url":"https://avatars0.githubusercontent.com/u/5798625?v=3","gravatar_id":"","url":"https://api.github.com/users/oznetmaster","html_url":"https://github.com/oznetmaster","followers_url":"https://api.github.com/users/oznetmaster/followers","following_url":"https://api.github.com/users/oznetmaster/following{/other_user}","gists_url":"https://api.github.com/users/oznetmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/oznetmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oznetmaster/subscriptions","organizations_url":"https://api.github.com/users/oznetmaster/orgs","repos_url":"https://api.github.com/users/oznetmaster/repos","events_url":"https://api.github.com/users/oznetmaster/events{/privacy}","received_events_url":"https://api.github.com/users/oznetmaster/received_events","type":"User","site_admin":false},"created_at":"2017-06-26T11:19:15Z","updated_at":"2017-06-26T11:19:15Z","body":"A far better way (and the correct way) to handle this would be to get rid of the sleep entirely, and to use a ManualResetEventSlim which is set when an even is queued, and is reset when the event pump removes any event from the queue (does not have to be the same event).\r\n\r\n"}}
{"actor":{"display_login":"oznetmaster"}}