{"action":"created","issue":{"url":"https://api.github.com/repos/andreypopp/react-textarea-autosize/issues/155","repository_url":"https://api.github.com/repos/andreypopp/react-textarea-autosize","labels_url":"https://api.github.com/repos/andreypopp/react-textarea-autosize/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/andreypopp/react-textarea-autosize/issues/155/comments","events_url":"https://api.github.com/repos/andreypopp/react-textarea-autosize/issues/155/events","html_url":"https://github.com/andreypopp/react-textarea-autosize/issues/155","id":231408903,"number":155,"title":"Hidden textarea attached to body not cleaned up on `componentWillUnmount`","user":{"login":"bcliffor","id":1386573,"avatar_url":"https://avatars3.githubusercontent.com/u/1386573?v=3","gravatar_id":"","url":"https://api.github.com/users/bcliffor","html_url":"https://github.com/bcliffor","followers_url":"https://api.github.com/users/bcliffor/followers","following_url":"https://api.github.com/users/bcliffor/following{/other_user}","gists_url":"https://api.github.com/users/bcliffor/gists{/gist_id}","starred_url":"https://api.github.com/users/bcliffor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcliffor/subscriptions","organizations_url":"https://api.github.com/users/bcliffor/orgs","repos_url":"https://api.github.com/users/bcliffor/repos","events_url":"https://api.github.com/users/bcliffor/events{/privacy}","received_events_url":"https://api.github.com/users/bcliffor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-25T17:45:10Z","updated_at":"2017-05-25T18:52:06Z","closed_at":null,"body":"The component should clean up the hidden textarea when it is unmounted. Right now it pollutes the DOM with every instance."},"comment":{"url":"https://api.github.com/repos/andreypopp/react-textarea-autosize/issues/comments/304092653","html_url":"https://github.com/andreypopp/react-textarea-autosize/issues/155#issuecomment-304092653","issue_url":"https://api.github.com/repos/andreypopp/react-textarea-autosize/issues/155","id":304092653,"user":{"login":"bcliffor","id":1386573,"avatar_url":"https://avatars3.githubusercontent.com/u/1386573?v=3","gravatar_id":"","url":"https://api.github.com/users/bcliffor","html_url":"https://github.com/bcliffor","followers_url":"https://api.github.com/users/bcliffor/followers","following_url":"https://api.github.com/users/bcliffor/following{/other_user}","gists_url":"https://api.github.com/users/bcliffor/gists{/gist_id}","starred_url":"https://api.github.com/users/bcliffor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcliffor/subscriptions","organizations_url":"https://api.github.com/users/bcliffor/orgs","repos_url":"https://api.github.com/users/bcliffor/repos","events_url":"https://api.github.com/users/bcliffor/events{/privacy}","received_events_url":"https://api.github.com/users/bcliffor/received_events","type":"User","site_admin":false},"created_at":"2017-05-25T18:52:06Z","updated_at":"2017-05-25T18:52:06Z","body":"Thanks for the reply and pointing out that hidden DOM elements do not grow with usage.\r\n\r\nI still think that the component should hold onto a reference to its own hidden DOM element per instance, and then clean that up on removal. It threw off some tests of mine with the DOM pollution, but I do think its a good practice in general.\r\n\r\nI would be happy to submit a PR with a fix if you think the idea has merit. "}}
{"actor":{"display_login":"bcliffor"}}