{"action":"created","issue":{"url":"https://api.github.com/repos/numixproject/numix-core/issues/3920","repository_url":"https://api.github.com/repos/numixproject/numix-core","labels_url":"https://api.github.com/repos/numixproject/numix-core/issues/3920/labels{/name}","comments_url":"https://api.github.com/repos/numixproject/numix-core/issues/3920/comments","events_url":"https://api.github.com/repos/numixproject/numix-core/issues/3920/events","html_url":"https://github.com/numixproject/numix-core/pull/3920","id":258075632,"number":3920,"title":"add scour optimizations tests","user":{"login":"bil-elmoussaoui","id":7660997,"avatar_url":"https://avatars2.githubusercontent.com/u/7660997?v=4","gravatar_id":"","url":"https://api.github.com/users/bil-elmoussaoui","html_url":"https://github.com/bil-elmoussaoui","followers_url":"https://api.github.com/users/bil-elmoussaoui/followers","following_url":"https://api.github.com/users/bil-elmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bil-elmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bil-elmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bil-elmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bil-elmoussaoui/orgs","repos_url":"https://api.github.com/users/bil-elmoussaoui/repos","events_url":"https://api.github.com/users/bil-elmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bil-elmoussaoui/received_events","type":"User","site_admin":false},"labels":[{"id":96341803,"url":"https://api.github.com/repos/numixproject/numix-core/labels/merge","name":"merge","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-15T15:17:30Z","updated_at":"2017-09-15T15:52:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/numixproject/numix-core/pulls/3920","html_url":"https://github.com/numixproject/numix-core/pull/3920","diff_url":"https://github.com/numixproject/numix-core/pull/3920.diff","patch_url":"https://github.com/numixproject/numix-core/pull/3920.patch"},"body":"This PR introduces a new test. The files now must be optimized using scour with those options : \r\n\r\n```shell\r\nscour -i input.svg -o output.svg --disable-style-to-xml --create-groups --renderer-workaround --strip-xml-prolog --enable-comment-stripping --remove-descriptive-elements --enable-id-stripping --protect-ids-noninkscape\r\n```\r\nThose options are the same as the ones described on the wiki. \r\n\r\nThe tests, will make sure that the icons and the templates are optimized correctly. \r\n"},"comment":{"url":"https://api.github.com/repos/numixproject/numix-core/issues/comments/329822931","html_url":"https://github.com/numixproject/numix-core/pull/3920#issuecomment-329822931","issue_url":"https://api.github.com/repos/numixproject/numix-core/issues/3920","id":329822931,"user":{"login":"bil-elmoussaoui","id":7660997,"avatar_url":"https://avatars2.githubusercontent.com/u/7660997?v=4","gravatar_id":"","url":"https://api.github.com/users/bil-elmoussaoui","html_url":"https://github.com/bil-elmoussaoui","followers_url":"https://api.github.com/users/bil-elmoussaoui/followers","following_url":"https://api.github.com/users/bil-elmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bil-elmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bil-elmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bil-elmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bil-elmoussaoui/orgs","repos_url":"https://api.github.com/users/bil-elmoussaoui/repos","events_url":"https://api.github.com/users/bil-elmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bil-elmoussaoui/received_events","type":"User","site_admin":false},"created_at":"2017-09-15T15:52:57Z","updated_at":"2017-09-15T15:52:57Z","author_association":"MEMBER","body":"Yeah, i will take care of the PEPing. For testing this, you can easily optimize few icons from circle (the icons are ordered alphabetically) so you can take 0ad.svg for example, optimize it using Inkscape or scour, and then just run python3 ./tests/scour.py from the numix-core directory. And you should see that the 0ad icon is optimized correctly 👍 \nFor now, this shouldn't be merged as the tests verifies all the icons which will take a huge time each time... So we should optimize everything first and then i will switch to verifying the latest icons added on the latest commit or something like that"}}
{"actor":{"display_login":"bil-elmoussaoui"}}