{"action":"created","comment":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/110538103","pull_request_review_id":31720738,"id":110538103,"diff_hunk":"@@ -102,12 +102,21 @@ else:\n     SysLock {.importc: \"pthread_mutex_t\", pure, final,\n                header: \"\"\"#include <sys/types.h>\n                           #include <pthread.h>\"\"\".} = object\n+      when defined(linux) and defined(amd64):\n+        abi: array[40, uint8]","path":"lib/system/syslocks.nim","position":5,"original_position":5,"commit_id":"8b878dda5a7b77c5d3d489e04b053de41e338ae1","original_commit_id":"b3a0d68cab10d8ece071d3d69dc9f21114f0de04","user":{"login":"arnetheduck","id":1382986,"avatar_url":"https://avatars0.githubusercontent.com/u/1382986?v=3","gravatar_id":"","url":"https://api.github.com/users/arnetheduck","html_url":"https://github.com/arnetheduck","followers_url":"https://api.github.com/users/arnetheduck/followers","following_url":"https://api.github.com/users/arnetheduck/following{/other_user}","gists_url":"https://api.github.com/users/arnetheduck/gists{/gist_id}","starred_url":"https://api.github.com/users/arnetheduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnetheduck/subscriptions","organizations_url":"https://api.github.com/users/arnetheduck/orgs","repos_url":"https://api.github.com/users/arnetheduck/repos","events_url":"https://api.github.com/users/arnetheduck/events{/privacy}","received_events_url":"https://api.github.com/users/arnetheduck/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2017-04-09T10:42:00Z","updated_at":"2017-04-09T10:42:00Z","html_url":"https://github.com/nim-lang/Nim/pull/5674#discussion_r110538103","pull_request_url":"https://api.github.com/repos/nim-lang/Nim/pulls/5674","_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/110538103"},"html":{"href":"https://github.com/nim-lang/Nim/pull/5674#discussion_r110538103"},"pull_request":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/5674"}}},"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/5674","id":114803120,"html_url":"https://github.com/nim-lang/Nim/pull/5674","diff_url":"https://github.com/nim-lang/Nim/pull/5674.diff","patch_url":"https://github.com/nim-lang/Nim/pull/5674.patch","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/5674","number":5674,"state":"open","locked":false,"title":"Linux amd64 abi fixes","user":{"login":"arnetheduck","id":1382986,"avatar_url":"https://avatars0.githubusercontent.com/u/1382986?v=3","gravatar_id":"","url":"https://api.github.com/users/arnetheduck","html_url":"https://github.com/arnetheduck","followers_url":"https://api.github.com/users/arnetheduck/followers","following_url":"https://api.github.com/users/arnetheduck/following{/other_user}","gists_url":"https://api.github.com/users/arnetheduck/gists{/gist_id}","starred_url":"https://api.github.com/users/arnetheduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnetheduck/subscriptions","organizations_url":"https://api.github.com/users/arnetheduck/orgs","repos_url":"https://api.github.com/users/arnetheduck/repos","events_url":"https://api.github.com/users/arnetheduck/events{/privacy}","received_events_url":"https://api.github.com/users/arnetheduck/received_events","type":"User","site_admin":false},"body":"This builds on #5656 to fix abi on linux amd64. Instead of going the way of #5018 which touched all arches, this branch isolates the changes in specific linux_amd64 blocks - this is the similar to how for example the musl c library approaches cross-platform.\r\n\r\nA natural extension here would be to automate the process, but since that's far off, this branch brute-forces it ;) Let's see if the tests are happy.","created_at":"2017-04-07T12:11:48Z","updated_at":"2017-04-09T10:42:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63bf47d890f3ccde1b173069909db4a112c46a1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nim-lang/Nim/pulls/5674/commits","review_comments_url":"https://api.github.com/repos/nim-lang/Nim/pulls/5674/comments","review_comment_url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/5674/comments","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/8b878dda5a7b77c5d3d489e04b053de41e338ae1","head":{"label":"arnetheduck:linux-amd64-abi-fixes","ref":"linux-amd64-abi-fixes","sha":"8b878dda5a7b77c5d3d489e04b053de41e338ae1","user":{"login":"arnetheduck","id":1382986,"avatar_url":"https://avatars0.githubusercontent.com/u/1382986?v=3","gravatar_id":"","url":"https://api.github.com/users/arnetheduck","html_url":"https://github.com/arnetheduck","followers_url":"https://api.github.com/users/arnetheduck/followers","following_url":"https://api.github.com/users/arnetheduck/following{/other_user}","gists_url":"https://api.github.com/users/arnetheduck/gists{/gist_id}","starred_url":"https://api.github.com/users/arnetheduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnetheduck/subscriptions","organizations_url":"https://api.github.com/users/arnetheduck/orgs","repos_url":"https://api.github.com/users/arnetheduck/repos","events_url":"https://api.github.com/users/arnetheduck/events{/privacy}","received_events_url":"https://api.github.com/users/arnetheduck/received_events","type":"User","site_admin":false},"repo":{"id":32519569,"name":"Nim","full_name":"arnetheduck/Nim","owner":{"login":"arnetheduck","id":1382986,"avatar_url":"https://avatars0.githubusercontent.com/u/1382986?v=3","gravatar_id":"","url":"https://api.github.com/users/arnetheduck","html_url":"https://github.com/arnetheduck","followers_url":"https://api.github.com/users/arnetheduck/followers","following_url":"https://api.github.com/users/arnetheduck/following{/other_user}","gists_url":"https://api.github.com/users/arnetheduck/gists{/gist_id}","starred_url":"https://api.github.com/users/arnetheduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnetheduck/subscriptions","organizations_url":"https://api.github.com/users/arnetheduck/orgs","repos_url":"https://api.github.com/users/arnetheduck/repos","events_url":"https://api.github.com/users/arnetheduck/events{/privacy}","received_events_url":"https://api.github.com/users/arnetheduck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnetheduck/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":true,"url":"https://api.github.com/repos/arnetheduck/Nim","forks_url":"https://api.github.com/repos/arnetheduck/Nim/forks","keys_url":"https://api.github.com/repos/arnetheduck/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnetheduck/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnetheduck/Nim/teams","hooks_url":"https://api.github.com/repos/arnetheduck/Nim/hooks","issue_events_url":"https://api.github.com/repos/arnetheduck/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/arnetheduck/Nim/events","assignees_url":"https://api.github.com/repos/arnetheduck/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/arnetheduck/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/arnetheduck/Nim/tags","blobs_url":"https://api.github.com/repos/arnetheduck/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnetheduck/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnetheduck/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnetheduck/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnetheduck/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/arnetheduck/Nim/languages","stargazers_url":"https://api.github.com/repos/arnetheduck/Nim/stargazers","contributors_url":"https://api.github.com/repos/arnetheduck/Nim/contributors","subscribers_url":"https://api.github.com/repos/arnetheduck/Nim/subscribers","subscription_url":"https://api.github.com/repos/arnetheduck/Nim/subscription","commits_url":"https://api.github.com/repos/arnetheduck/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnetheduck/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnetheduck/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnetheduck/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnetheduck/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/arnetheduck/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnetheduck/Nim/merges","archive_url":"https://api.github.com/repos/arnetheduck/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnetheduck/Nim/downloads","issues_url":"https://api.github.com/repos/arnetheduck/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/arnetheduck/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/arnetheduck/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/arnetheduck/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnetheduck/Nim/labels{/name}","releases_url":"https://api.github.com/repos/arnetheduck/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/arnetheduck/Nim/deployments","created_at":"2015-03-19T12:20:00Z","updated_at":"2017-03-25T06:54:51Z","pushed_at":"2017-04-09T10:40:56Z","git_url":"git://github.com/arnetheduck/Nim.git","ssh_url":"git@github.com:arnetheduck/Nim.git","clone_url":"https://github.com/arnetheduck/Nim.git","svn_url":"https://github.com/arnetheduck/Nim","homepage":"http://nim-lang.org/","size":60279,"stargazers_count":0,"watchers_count":0,"language":"Nim","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"nim-lang:devel","ref":"devel","sha":"cdfcc12529d716786683c997f1f673bd423432b6","user":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars2.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"nim-lang/Nim","owner":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars2.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nim-lang/Nim","description":"Nim is a compiled, garbage-collected systems programming language with a design that focuses on efficiency, expressiveness, and elegance (in the order of priority).","fork":false,"url":"https://api.github.com/repos/nim-lang/Nim","forks_url":"https://api.github.com/repos/nim-lang/Nim/forks","keys_url":"https://api.github.com/repos/nim-lang/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim-lang/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim-lang/Nim/teams","hooks_url":"https://api.github.com/repos/nim-lang/Nim/hooks","issue_events_url":"https://api.github.com/repos/nim-lang/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nim-lang/Nim/events","assignees_url":"https://api.github.com/repos/nim-lang/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nim-lang/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nim-lang/Nim/tags","blobs_url":"https://api.github.com/repos/nim-lang/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim-lang/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim-lang/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim-lang/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nim-lang/Nim/languages","stargazers_url":"https://api.github.com/repos/nim-lang/Nim/stargazers","contributors_url":"https://api.github.com/repos/nim-lang/Nim/contributors","subscribers_url":"https://api.github.com/repos/nim-lang/Nim/subscribers","subscription_url":"https://api.github.com/repos/nim-lang/Nim/subscription","commits_url":"https://api.github.com/repos/nim-lang/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim-lang/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim-lang/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim-lang/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim-lang/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nim-lang/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim-lang/Nim/merges","archive_url":"https://api.github.com/repos/nim-lang/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim-lang/Nim/downloads","issues_url":"https://api.github.com/repos/nim-lang/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nim-lang/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nim-lang/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nim-lang/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim-lang/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nim-lang/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/nim-lang/Nim/deployments","created_at":"2010-08-16T20:38:58Z","updated_at":"2017-04-09T08:48:34Z","pushed_at":"2017-04-09T10:40:57Z","git_url":"git://github.com/nim-lang/Nim.git","ssh_url":"git@github.com:nim-lang/Nim.git","clone_url":"https://github.com/nim-lang/Nim.git","svn_url":"https://github.com/nim-lang/Nim","homepage":"http://nim-lang.org/","size":60547,"stargazers_count":3490,"watchers_count":3490,"language":"Nim","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":481,"mirror_url":null,"open_issues_count":936,"forks":481,"open_issues":936,"watchers":3490,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/5674"},"html":{"href":"https://github.com/nim-lang/Nim/pull/5674"},"issue":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/5674"},"comments":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/5674/comments"},"review_comments":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/5674/comments"},"review_comment":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/5674/commits"},"statuses":{"href":"https://api.github.com/repos/nim-lang/Nim/statuses/8b878dda5a7b77c5d3d489e04b053de41e338ae1"}}}}
{"actor":{"display_login":"arnetheduck"}}