{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/101659848","pull_request_review_id":22396332,"id":101659848,"diff_hunk":"@@ -39,7 +40,17 @@ object BrokerApiVersionsCommand {\n   def execute(args: Array[String], out: PrintStream): Unit = {\n     val opts = new BrokerVersionCommandOptions(args)\n     val adminClient = createAdminClient(opts)\n-    val brokerMap = adminClient.listAllBrokerVersionInfo()\n+\n+    // Wait until AdminClient#findAllBrokers returns a non-empty list of brokers\n+    // before continuing.\n+    var nodes = List[Node]()\n+    while (nodes.isEmpty) {\n+      nodes = adminClient.findAllBrokers()\n+      if (nodes.isEmpty)\n+        Thread.sleep(1)","path":"core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala","position":20,"original_position":20,"commit_id":"40301f128e748e690d8939ffc61f83617d61f8f1","original_commit_id":"40301f128e748e690d8939ffc61f83617d61f8f1","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2017-02-17T00:14:06Z","updated_at":"2017-02-17T00:14:06Z","html_url":"https://github.com/apache/kafka/pull/2489#discussion_r101659848","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/2489","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/101659848"},"html":{"href":"https://github.com/apache/kafka/pull/2489#discussion_r101659848"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/2489"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/2489","id":104457822,"html_url":"https://github.com/apache/kafka/pull/2489","diff_url":"https://github.com/apache/kafka/pull/2489.diff","patch_url":"https://github.com/apache/kafka/pull/2489.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/2489","number":2489,"state":"open","locked":false,"title":"KAFKA-4708: Fix Transient Failure in BrokerApiVersionsCommandTest.che…","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"body":"…ckBrokerApiVersionCommandOutput","created_at":"2017-02-03T01:06:30Z","updated_at":"2017-02-17T00:14:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7545c94b4639a84f7e77478c14c39f014891199f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/2489/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/2489/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/2489/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/40301f128e748e690d8939ffc61f83617d61f8f1","head":{"label":"cmccabe:KAFKA-4708","ref":"KAFKA-4708","sha":"40301f128e748e690d8939ffc61f83617d61f8f1","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"repo":{"id":74628042,"name":"kafka","full_name":"cmccabe/kafka","owner":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmccabe/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/cmccabe/kafka","forks_url":"https://api.github.com/repos/cmccabe/kafka/forks","keys_url":"https://api.github.com/repos/cmccabe/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmccabe/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmccabe/kafka/teams","hooks_url":"https://api.github.com/repos/cmccabe/kafka/hooks","issue_events_url":"https://api.github.com/repos/cmccabe/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/cmccabe/kafka/events","assignees_url":"https://api.github.com/repos/cmccabe/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/cmccabe/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/cmccabe/kafka/tags","blobs_url":"https://api.github.com/repos/cmccabe/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmccabe/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmccabe/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmccabe/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmccabe/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/cmccabe/kafka/languages","stargazers_url":"https://api.github.com/repos/cmccabe/kafka/stargazers","contributors_url":"https://api.github.com/repos/cmccabe/kafka/contributors","subscribers_url":"https://api.github.com/repos/cmccabe/kafka/subscribers","subscription_url":"https://api.github.com/repos/cmccabe/kafka/subscription","commits_url":"https://api.github.com/repos/cmccabe/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmccabe/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmccabe/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmccabe/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmccabe/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/cmccabe/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmccabe/kafka/merges","archive_url":"https://api.github.com/repos/cmccabe/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmccabe/kafka/downloads","issues_url":"https://api.github.com/repos/cmccabe/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/cmccabe/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/cmccabe/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/cmccabe/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmccabe/kafka/labels{/name}","releases_url":"https://api.github.com/repos/cmccabe/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/cmccabe/kafka/deployments","created_at":"2016-11-24T01:40:33Z","updated_at":"2016-11-24T01:40:38Z","pushed_at":"2017-02-16T21:53:21Z","git_url":"git://github.com/cmccabe/kafka.git","ssh_url":"git@github.com:cmccabe/kafka.git","clone_url":"https://github.com/cmccabe/kafka.git","svn_url":"https://github.com/cmccabe/kafka","homepage":null,"size":43660,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"a1900ada7fdc3318f24e94e4aac956dca3463bbf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-02-16T20:04:37Z","pushed_at":"2017-02-17T00:05:51Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":43525,"stargazers_count":4592,"watchers_count":4592,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2874,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":278,"forks":2874,"open_issues":278,"watchers":4592,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/2489"},"html":{"href":"https://github.com/apache/kafka/pull/2489"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/2489"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/2489/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/2489/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/2489/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/40301f128e748e690d8939ffc61f83617d61f8f1"}}}}
{"actor":{"display_login":"cmccabe"}}