{"action":"created","comment":{"url":"https://api.github.com/repos/cryptag/leapchat/pulls/comments/116392068","pull_request_review_id":38009777,"id":116392068,"diff_hunk":"@@ -7,68 +7,127 @@ body {\n   font-size: 16px;\n   font-family: 'Lato', sans-serif; }\n \n-.container {\n-  width: 100%; }\n+.encloser {\n+  display: flex;\n+  min-height: 100vh;\n+  flex-direction: row; }\n+\n+@media (max-width: 768px) {\n+  .encloser {\n+    flex-direction: column; } }\n \n ul {\n   list-style: none; }\n \n-.alert-container {\n-  position: fixed;\n-  top: 0;\n-  width: 100%;\n-  z-index: 10; }\n-\n-.message-box ul li {\n-  display: block;\n-  border: solid 1px #eee;\n-  border-radius: 10px;\n-  padding: 5px 10px;\n-  margin-bottom: 5px;\n-  width: 90%;\n-  position: relative;\n-  word-wrap: break-word; }\n-  .message-box ul li .username {\n-    display: block;\n+header {\n+  display: flex;\n+  background-color: #1e202f;\n+  color: #fff;\n+  padding: 10px 10px 5px;\n+  flex-direction: row;\n+  justify-content: space-between; }\n+  header .users-list {\n+    order: -1; }\n+    header .users-list .users-icon {\n+      cursor: pointer; }\n+    header .users-list ul {\n+      display: none; }\n+  header .logo {\n+    text-align: center;\n+    font-size: 24px;\n     font-weight: bold; }\n-  .message-box ul li.chat-outgoing {\n-    float: right;\n-    color: white;\n-    background-color: #827cd2; }\n-    .message-box ul li.chat-outgoing a {\n-      text-decoration: underline;\n-      color: white; }\n-    .message-box ul li.chat-outgoing a:hover {\n-      color: #ddd; }\n-  .message-box ul li.chat-incoming {\n-    float: left;\n-    color: #333; }\n+  header .menu-list {\n+    display: none; }\n+    header .menu-list i.fa {\n+      margin-right: 5px; }\n \n-.message-box ul li:hover .delete-message {\n-  visibility: visible; }\n+@media (min-width: 768px) {\n+  header {\n+    flex: 1;\n+    min-width: 300px;\n+    flex-direction: column;\n+    justify-content: start;\n+    height: 100vh; }\n+    header .logo {\n+      text-align: left;\n+      order: -3; }\n+    header .settings {\n+      order: -2; } }\n \n-.message-form {\n-  position: fixed;\n-  width: 100%;\n-  left: 0px;\n-  bottom: 0px;\n-  padding: 5px;\n-  background-color: white;\n-  border-top: solid 1px #ccc; }\n-  .message-form textarea {\n-    /* this font-size disables zooming\n-    on mobile safari, which breaks layout */\n-    font-size: 16px;\n-    width: calc(100% - 40px); }\n-  .message-form button {\n-    border: none;\n-    padding: 5px;\n-    float: right;\n-    height: 54px;\n-    vertical-align: bottom; }\n-    .message-form button i {\n-      color: #1e202f; }\n+main {\n+  display: flex;\n+  flex-grow: 1; }\n+  main .content {\n+    display: flex;\n+    flex-direction: column;\n+    flex-grow: 1; }\n+    main .content .message-box {\n+      height: calc(100vh - 120px);\n+      overflow-y: scroll;\n+      padding-top: 5px; }\n+      main .content .message-box ul li {\n+        display: block;\n+        border: solid 1px #eee;\n+        border-radius: 10px;\n+        padding: 5px 10px;\n+        margin-bottom: 5px;\n+        width: 90%;\n+        position: relative;","path":"static/css/main.css","position":123,"original_position":123,"commit_id":"8a0d63578bc48a33be6762c7bcb61fe4efb788a8","original_commit_id":"024b7d7037746dd83414a9f3d74485b58c88d8d0","user":{"login":"jimmcgaw","id":89764,"avatar_url":"https://avatars1.githubusercontent.com/u/89764?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmcgaw","html_url":"https://github.com/jimmcgaw","followers_url":"https://api.github.com/users/jimmcgaw/followers","following_url":"https://api.github.com/users/jimmcgaw/following{/other_user}","gists_url":"https://api.github.com/users/jimmcgaw/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmcgaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmcgaw/subscriptions","organizations_url":"https://api.github.com/users/jimmcgaw/orgs","repos_url":"https://api.github.com/users/jimmcgaw/repos","events_url":"https://api.github.com/users/jimmcgaw/events{/privacy}","received_events_url":"https://api.github.com/users/jimmcgaw/received_events","type":"User","site_admin":false},"body":"If this is in reference to `position: relative`, I believe it was originally used to position the \"delete message\" button absolutely within the message element itself. That element was removed at some point, maybe in the transition from backchannel, so the answer here is: nothing. :)","created_at":"2017-05-14T22:18:07Z","updated_at":"2017-05-14T22:18:07Z","html_url":"https://github.com/cryptag/leapchat/pull/85#discussion_r116392068","pull_request_url":"https://api.github.com/repos/cryptag/leapchat/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/cryptag/leapchat/pulls/comments/116392068"},"html":{"href":"https://github.com/cryptag/leapchat/pull/85#discussion_r116392068"},"pull_request":{"href":"https://api.github.com/repos/cryptag/leapchat/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/cryptag/leapchat/pulls/85","id":120495361,"html_url":"https://github.com/cryptag/leapchat/pull/85","diff_url":"https://github.com/cryptag/leapchat/pull/85.diff","patch_url":"https://github.com/cryptag/leapchat/pull/85.patch","issue_url":"https://api.github.com/repos/cryptag/leapchat/issues/85","number":85,"state":"open","locked":false,"title":"Fix #77: Responsive Header","user":{"login":"jimmcgaw","id":89764,"avatar_url":"https://avatars1.githubusercontent.com/u/89764?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmcgaw","html_url":"https://github.com/jimmcgaw","followers_url":"https://api.github.com/users/jimmcgaw/followers","following_url":"https://api.github.com/users/jimmcgaw/following{/other_user}","gists_url":"https://api.github.com/users/jimmcgaw/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmcgaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmcgaw/subscriptions","organizations_url":"https://api.github.com/users/jimmcgaw/orgs","repos_url":"https://api.github.com/users/jimmcgaw/repos","events_url":"https://api.github.com/users/jimmcgaw/events{/privacy}","received_events_url":"https://api.github.com/users/jimmcgaw/received_events","type":"User","site_admin":false},"body":"This change creates a responsive header for the app that lives at the\r\ntop of the site on mobile and as a sidebar for larger desktop screens.\r\nIt converts the primary elements in the layout to use the new flexbox\r\napi. It also sets a fixed height on the messages container to allow for\r\nscrolling when the message list overflows the height of the container,\r\nwhich is less than flexy but will work for now. Elements are reordered\r\nin the header between the mobile and desktop versions.","created_at":"2017-05-14T18:08:04Z","updated_at":"2017-05-14T22:18:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"580bcb8076440930a7cb83e10da7c251d9b5db41","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cryptag/leapchat/pulls/85/commits","review_comments_url":"https://api.github.com/repos/cryptag/leapchat/pulls/85/comments","review_comment_url":"https://api.github.com/repos/cryptag/leapchat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cryptag/leapchat/issues/85/comments","statuses_url":"https://api.github.com/repos/cryptag/leapchat/statuses/8a0d63578bc48a33be6762c7bcb61fe4efb788a8","head":{"label":"cryptag:header","ref":"header","sha":"8a0d63578bc48a33be6762c7bcb61fe4efb788a8","user":{"login":"cryptag","id":20253311,"avatar_url":"https://avatars1.githubusercontent.com/u/20253311?v=3","gravatar_id":"","url":"https://api.github.com/users/cryptag","html_url":"https://github.com/cryptag","followers_url":"https://api.github.com/users/cryptag/followers","following_url":"https://api.github.com/users/cryptag/following{/other_user}","gists_url":"https://api.github.com/users/cryptag/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptag/subscriptions","organizations_url":"https://api.github.com/users/cryptag/orgs","repos_url":"https://api.github.com/users/cryptag/repos","events_url":"https://api.github.com/users/cryptag/events{/privacy}","received_events_url":"https://api.github.com/users/cryptag/received_events","type":"Organization","site_admin":false},"repo":{"id":86648570,"name":"leapchat","full_name":"cryptag/leapchat","owner":{"login":"cryptag","id":20253311,"avatar_url":"https://avatars1.githubusercontent.com/u/20253311?v=3","gravatar_id":"","url":"https://api.github.com/users/cryptag","html_url":"https://github.com/cryptag","followers_url":"https://api.github.com/users/cryptag/followers","following_url":"https://api.github.com/users/cryptag/following{/other_user}","gists_url":"https://api.github.com/users/cryptag/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptag/subscriptions","organizations_url":"https://api.github.com/users/cryptag/orgs","repos_url":"https://api.github.com/users/cryptag/repos","events_url":"https://api.github.com/users/cryptag/events{/privacy}","received_events_url":"https://api.github.com/users/cryptag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cryptag/leapchat","description":"Ephemeral, self-destructing, optionally in-browser, end-to-end encrypted chat rooms","fork":false,"url":"https://api.github.com/repos/cryptag/leapchat","forks_url":"https://api.github.com/repos/cryptag/leapchat/forks","keys_url":"https://api.github.com/repos/cryptag/leapchat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryptag/leapchat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryptag/leapchat/teams","hooks_url":"https://api.github.com/repos/cryptag/leapchat/hooks","issue_events_url":"https://api.github.com/repos/cryptag/leapchat/issues/events{/number}","events_url":"https://api.github.com/repos/cryptag/leapchat/events","assignees_url":"https://api.github.com/repos/cryptag/leapchat/assignees{/user}","branches_url":"https://api.github.com/repos/cryptag/leapchat/branches{/branch}","tags_url":"https://api.github.com/repos/cryptag/leapchat/tags","blobs_url":"https://api.github.com/repos/cryptag/leapchat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryptag/leapchat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryptag/leapchat/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryptag/leapchat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryptag/leapchat/statuses/{sha}","languages_url":"https://api.github.com/repos/cryptag/leapchat/languages","stargazers_url":"https://api.github.com/repos/cryptag/leapchat/stargazers","contributors_url":"https://api.github.com/repos/cryptag/leapchat/contributors","subscribers_url":"https://api.github.com/repos/cryptag/leapchat/subscribers","subscription_url":"https://api.github.com/repos/cryptag/leapchat/subscription","commits_url":"https://api.github.com/repos/cryptag/leapchat/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryptag/leapchat/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryptag/leapchat/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryptag/leapchat/issues/comments{/number}","contents_url":"https://api.github.com/repos/cryptag/leapchat/contents/{+path}","compare_url":"https://api.github.com/repos/cryptag/leapchat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryptag/leapchat/merges","archive_url":"https://api.github.com/repos/cryptag/leapchat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryptag/leapchat/downloads","issues_url":"https://api.github.com/repos/cryptag/leapchat/issues{/number}","pulls_url":"https://api.github.com/repos/cryptag/leapchat/pulls{/number}","milestones_url":"https://api.github.com/repos/cryptag/leapchat/milestones{/number}","notifications_url":"https://api.github.com/repos/cryptag/leapchat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryptag/leapchat/labels{/name}","releases_url":"https://api.github.com/repos/cryptag/leapchat/releases{/id}","deployments_url":"https://api.github.com/repos/cryptag/leapchat/deployments","created_at":"2017-03-30T02:10:10Z","updated_at":"2017-04-23T05:24:55Z","pushed_at":"2017-05-14T21:44:25Z","git_url":"git://github.com/cryptag/leapchat.git","ssh_url":"git@github.com:cryptag/leapchat.git","clone_url":"https://github.com/cryptag/leapchat.git","svn_url":"https://github.com/cryptag/leapchat","homepage":"https://www.leapchat.org/","size":483,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":27,"forks":1,"open_issues":27,"watchers":3,"default_branch":"master"}},"base":{"label":"cryptag:master","ref":"master","sha":"4ec753cda9fe712fe5c575690ec2890a930e3459","user":{"login":"cryptag","id":20253311,"avatar_url":"https://avatars1.githubusercontent.com/u/20253311?v=3","gravatar_id":"","url":"https://api.github.com/users/cryptag","html_url":"https://github.com/cryptag","followers_url":"https://api.github.com/users/cryptag/followers","following_url":"https://api.github.com/users/cryptag/following{/other_user}","gists_url":"https://api.github.com/users/cryptag/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptag/subscriptions","organizations_url":"https://api.github.com/users/cryptag/orgs","repos_url":"https://api.github.com/users/cryptag/repos","events_url":"https://api.github.com/users/cryptag/events{/privacy}","received_events_url":"https://api.github.com/users/cryptag/received_events","type":"Organization","site_admin":false},"repo":{"id":86648570,"name":"leapchat","full_name":"cryptag/leapchat","owner":{"login":"cryptag","id":20253311,"avatar_url":"https://avatars1.githubusercontent.com/u/20253311?v=3","gravatar_id":"","url":"https://api.github.com/users/cryptag","html_url":"https://github.com/cryptag","followers_url":"https://api.github.com/users/cryptag/followers","following_url":"https://api.github.com/users/cryptag/following{/other_user}","gists_url":"https://api.github.com/users/cryptag/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptag/subscriptions","organizations_url":"https://api.github.com/users/cryptag/orgs","repos_url":"https://api.github.com/users/cryptag/repos","events_url":"https://api.github.com/users/cryptag/events{/privacy}","received_events_url":"https://api.github.com/users/cryptag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cryptag/leapchat","description":"Ephemeral, self-destructing, optionally in-browser, end-to-end encrypted chat rooms","fork":false,"url":"https://api.github.com/repos/cryptag/leapchat","forks_url":"https://api.github.com/repos/cryptag/leapchat/forks","keys_url":"https://api.github.com/repos/cryptag/leapchat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryptag/leapchat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryptag/leapchat/teams","hooks_url":"https://api.github.com/repos/cryptag/leapchat/hooks","issue_events_url":"https://api.github.com/repos/cryptag/leapchat/issues/events{/number}","events_url":"https://api.github.com/repos/cryptag/leapchat/events","assignees_url":"https://api.github.com/repos/cryptag/leapchat/assignees{/user}","branches_url":"https://api.github.com/repos/cryptag/leapchat/branches{/branch}","tags_url":"https://api.github.com/repos/cryptag/leapchat/tags","blobs_url":"https://api.github.com/repos/cryptag/leapchat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryptag/leapchat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryptag/leapchat/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryptag/leapchat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryptag/leapchat/statuses/{sha}","languages_url":"https://api.github.com/repos/cryptag/leapchat/languages","stargazers_url":"https://api.github.com/repos/cryptag/leapchat/stargazers","contributors_url":"https://api.github.com/repos/cryptag/leapchat/contributors","subscribers_url":"https://api.github.com/repos/cryptag/leapchat/subscribers","subscription_url":"https://api.github.com/repos/cryptag/leapchat/subscription","commits_url":"https://api.github.com/repos/cryptag/leapchat/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryptag/leapchat/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryptag/leapchat/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryptag/leapchat/issues/comments{/number}","contents_url":"https://api.github.com/repos/cryptag/leapchat/contents/{+path}","compare_url":"https://api.github.com/repos/cryptag/leapchat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryptag/leapchat/merges","archive_url":"https://api.github.com/repos/cryptag/leapchat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryptag/leapchat/downloads","issues_url":"https://api.github.com/repos/cryptag/leapchat/issues{/number}","pulls_url":"https://api.github.com/repos/cryptag/leapchat/pulls{/number}","milestones_url":"https://api.github.com/repos/cryptag/leapchat/milestones{/number}","notifications_url":"https://api.github.com/repos/cryptag/leapchat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryptag/leapchat/labels{/name}","releases_url":"https://api.github.com/repos/cryptag/leapchat/releases{/id}","deployments_url":"https://api.github.com/repos/cryptag/leapchat/deployments","created_at":"2017-03-30T02:10:10Z","updated_at":"2017-04-23T05:24:55Z","pushed_at":"2017-05-14T21:44:25Z","git_url":"git://github.com/cryptag/leapchat.git","ssh_url":"git@github.com:cryptag/leapchat.git","clone_url":"https://github.com/cryptag/leapchat.git","svn_url":"https://github.com/cryptag/leapchat","homepage":"https://www.leapchat.org/","size":483,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":27,"forks":1,"open_issues":27,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cryptag/leapchat/pulls/85"},"html":{"href":"https://github.com/cryptag/leapchat/pull/85"},"issue":{"href":"https://api.github.com/repos/cryptag/leapchat/issues/85"},"comments":{"href":"https://api.github.com/repos/cryptag/leapchat/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/cryptag/leapchat/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/cryptag/leapchat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cryptag/leapchat/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/cryptag/leapchat/statuses/8a0d63578bc48a33be6762c7bcb61fe4efb788a8"}}}}
{"actor":{"display_login":"jimmcgaw"}}