{"action":"created","comment":{"url":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments/146588899","pull_request_review_id":71552229,"id":146588899,"diff_hunk":"@@ -244,6 +246,170 @@ def evaluate_gradient(self, x, t=None):\n         return grad_mean - 0.5 * grad_var * np.sqrt(self._beta(t) / var)\n \n \n+class MaxVar(AcquisitionBase):\n+    r\"\"\"The maximum variance acquisition method.\n+\n+    The next evaluation point is acquired in the maximiser of the variance of\n+    the unnormalised approximate posterior.\n+\n+    \\theta_{t+1} = arg max Var(p(\\theta) * p_a(\\theta)),\n+\n+    where the unnormalised likelihood p_a is defined\n+    using the CDF of normal distribution, \\Phi, as follows:\n+\n+    p_a(\\theta) =\n+        (\\Phi((\\epsilon - \\mu_{1:t}(\\theta)) / \\sqrt(\\sigma_{1:t}(\\theta) + \\sigma_n))),\n+","path":"elfi/methods/bo/acquisition.py","position":53,"original_position":53,"commit_id":"5f2aed4bb06b546109d7289cb0726073406d2a64","original_commit_id":"5f2aed4bb06b546109d7289cb0726073406d2a64","user":{"login":"mjarvenpaa","id":22050608,"avatar_url":"https://avatars2.githubusercontent.com/u/22050608?v=4","gravatar_id":"","url":"https://api.github.com/users/mjarvenpaa","html_url":"https://github.com/mjarvenpaa","followers_url":"https://api.github.com/users/mjarvenpaa/followers","following_url":"https://api.github.com/users/mjarvenpaa/following{/other_user}","gists_url":"https://api.github.com/users/mjarvenpaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mjarvenpaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjarvenpaa/subscriptions","organizations_url":"https://api.github.com/users/mjarvenpaa/orgs","repos_url":"https://api.github.com/users/mjarvenpaa/repos","events_url":"https://api.github.com/users/mjarvenpaa/events{/privacy}","received_events_url":"https://api.github.com/users/mjarvenpaa/received_events","type":"User","site_admin":false},"body":"Now that I look this again, unlike I commented before, I think you should use sigma^2 here, otherwise the user might be confused as sigma usually refers to standard deviation and not variance as here! (Sigma is used for the variance in the code though but it is better to keep the potential confusion there, or if you can change that, that would be of course good)","created_at":"2017-10-24T14:58:31Z","updated_at":"2017-10-24T15:00:00Z","html_url":"https://github.com/elfi-dev/elfi/pull/235#discussion_r146588899","pull_request_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/235","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments/146588899"},"html":{"href":"https://github.com/elfi-dev/elfi/pull/235#discussion_r146588899"},"pull_request":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/elfi-dev/elfi/pulls/235","id":139787575,"html_url":"https://github.com/elfi-dev/elfi/pull/235","diff_url":"https://github.com/elfi-dev/elfi/pull/235.diff","patch_url":"https://github.com/elfi-dev/elfi/pull/235.patch","issue_url":"https://api.github.com/repos/elfi-dev/elfi/issues/235","number":235,"state":"open","locked":false,"title":"[MaxVar split, Part 3] Added the MaxVar acquisition.","user":{"login":"perdaug","id":14854408,"avatar_url":"https://avatars2.githubusercontent.com/u/14854408?v=4","gravatar_id":"","url":"https://api.github.com/users/perdaug","html_url":"https://github.com/perdaug","followers_url":"https://api.github.com/users/perdaug/followers","following_url":"https://api.github.com/users/perdaug/following{/other_user}","gists_url":"https://api.github.com/users/perdaug/gists{/gist_id}","starred_url":"https://api.github.com/users/perdaug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perdaug/subscriptions","organizations_url":"https://api.github.com/users/perdaug/orgs","repos_url":"https://api.github.com/users/perdaug/repos","events_url":"https://api.github.com/users/perdaug/events{/privacy}","received_events_url":"https://api.github.com/users/perdaug/received_events","type":"User","site_admin":false},"body":"#### Summary:\r\n- Added the MaxVar acquisition.\r\n- Added the respective tests.\r\n\r\n#### Please make sure\r\n- You have updated the CHANGELOG.rst\r\n- You have updated the documentation (if applicable)\r\n\r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD3 (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n","created_at":"2017-09-07T12:04:16Z","updated_at":"2017-10-24T15:00:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69fb6af35946df103490c4d8f2a6a29dc19c50ca","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/235/commits","review_comments_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/235/comments","review_comment_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elfi-dev/elfi/issues/235/comments","statuses_url":"https://api.github.com/repos/elfi-dev/elfi/statuses/5f2aed4bb06b546109d7289cb0726073406d2a64","head":{"label":"elfi-dev:maxvar_split_maxvar","ref":"maxvar_split_maxvar","sha":"5f2aed4bb06b546109d7289cb0726073406d2a64","user":{"login":"elfi-dev","id":24249379,"avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":69855441,"name":"elfi","full_name":"elfi-dev/elfi","owner":{"login":"elfi-dev","id":24249379,"avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elfi-dev/elfi","description":"ELFI - Engine for Likelihood-Free Inference","fork":false,"url":"https://api.github.com/repos/elfi-dev/elfi","forks_url":"https://api.github.com/repos/elfi-dev/elfi/forks","keys_url":"https://api.github.com/repos/elfi-dev/elfi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elfi-dev/elfi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elfi-dev/elfi/teams","hooks_url":"https://api.github.com/repos/elfi-dev/elfi/hooks","issue_events_url":"https://api.github.com/repos/elfi-dev/elfi/issues/events{/number}","events_url":"https://api.github.com/repos/elfi-dev/elfi/events","assignees_url":"https://api.github.com/repos/elfi-dev/elfi/assignees{/user}","branches_url":"https://api.github.com/repos/elfi-dev/elfi/branches{/branch}","tags_url":"https://api.github.com/repos/elfi-dev/elfi/tags","blobs_url":"https://api.github.com/repos/elfi-dev/elfi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elfi-dev/elfi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elfi-dev/elfi/git/refs{/sha}","trees_url":"https://api.github.com/repos/elfi-dev/elfi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elfi-dev/elfi/statuses/{sha}","languages_url":"https://api.github.com/repos/elfi-dev/elfi/languages","stargazers_url":"https://api.github.com/repos/elfi-dev/elfi/stargazers","contributors_url":"https://api.github.com/repos/elfi-dev/elfi/contributors","subscribers_url":"https://api.github.com/repos/elfi-dev/elfi/subscribers","subscription_url":"https://api.github.com/repos/elfi-dev/elfi/subscription","commits_url":"https://api.github.com/repos/elfi-dev/elfi/commits{/sha}","git_commits_url":"https://api.github.com/repos/elfi-dev/elfi/git/commits{/sha}","comments_url":"https://api.github.com/repos/elfi-dev/elfi/comments{/number}","issue_comment_url":"https://api.github.com/repos/elfi-dev/elfi/issues/comments{/number}","contents_url":"https://api.github.com/repos/elfi-dev/elfi/contents/{+path}","compare_url":"https://api.github.com/repos/elfi-dev/elfi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elfi-dev/elfi/merges","archive_url":"https://api.github.com/repos/elfi-dev/elfi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elfi-dev/elfi/downloads","issues_url":"https://api.github.com/repos/elfi-dev/elfi/issues{/number}","pulls_url":"https://api.github.com/repos/elfi-dev/elfi/pulls{/number}","milestones_url":"https://api.github.com/repos/elfi-dev/elfi/milestones{/number}","notifications_url":"https://api.github.com/repos/elfi-dev/elfi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elfi-dev/elfi/labels{/name}","releases_url":"https://api.github.com/repos/elfi-dev/elfi/releases{/id}","deployments_url":"https://api.github.com/repos/elfi-dev/elfi/deployments","created_at":"2016-10-03T09:03:38Z","updated_at":"2017-10-24T12:11:24Z","pushed_at":"2017-10-24T11:15:47Z","git_url":"git://github.com/elfi-dev/elfi.git","ssh_url":"git@github.com:elfi-dev/elfi.git","clone_url":"https://github.com/elfi-dev/elfi.git","svn_url":"https://github.com/elfi-dev/elfi","homepage":"http://elfi.readthedocs.io","size":1135,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":15,"open_issues":9,"watchers":89,"default_branch":"dev"}},"base":{"label":"elfi-dev:dev","ref":"dev","sha":"cff6aaec1b8cf22256ec07ad30c7b50b1f0c703c","user":{"login":"elfi-dev","id":24249379,"avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":69855441,"name":"elfi","full_name":"elfi-dev/elfi","owner":{"login":"elfi-dev","id":24249379,"avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elfi-dev/elfi","description":"ELFI - Engine for Likelihood-Free Inference","fork":false,"url":"https://api.github.com/repos/elfi-dev/elfi","forks_url":"https://api.github.com/repos/elfi-dev/elfi/forks","keys_url":"https://api.github.com/repos/elfi-dev/elfi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elfi-dev/elfi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elfi-dev/elfi/teams","hooks_url":"https://api.github.com/repos/elfi-dev/elfi/hooks","issue_events_url":"https://api.github.com/repos/elfi-dev/elfi/issues/events{/number}","events_url":"https://api.github.com/repos/elfi-dev/elfi/events","assignees_url":"https://api.github.com/repos/elfi-dev/elfi/assignees{/user}","branches_url":"https://api.github.com/repos/elfi-dev/elfi/branches{/branch}","tags_url":"https://api.github.com/repos/elfi-dev/elfi/tags","blobs_url":"https://api.github.com/repos/elfi-dev/elfi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elfi-dev/elfi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elfi-dev/elfi/git/refs{/sha}","trees_url":"https://api.github.com/repos/elfi-dev/elfi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elfi-dev/elfi/statuses/{sha}","languages_url":"https://api.github.com/repos/elfi-dev/elfi/languages","stargazers_url":"https://api.github.com/repos/elfi-dev/elfi/stargazers","contributors_url":"https://api.github.com/repos/elfi-dev/elfi/contributors","subscribers_url":"https://api.github.com/repos/elfi-dev/elfi/subscribers","subscription_url":"https://api.github.com/repos/elfi-dev/elfi/subscription","commits_url":"https://api.github.com/repos/elfi-dev/elfi/commits{/sha}","git_commits_url":"https://api.github.com/repos/elfi-dev/elfi/git/commits{/sha}","comments_url":"https://api.github.com/repos/elfi-dev/elfi/comments{/number}","issue_comment_url":"https://api.github.com/repos/elfi-dev/elfi/issues/comments{/number}","contents_url":"https://api.github.com/repos/elfi-dev/elfi/contents/{+path}","compare_url":"https://api.github.com/repos/elfi-dev/elfi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elfi-dev/elfi/merges","archive_url":"https://api.github.com/repos/elfi-dev/elfi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elfi-dev/elfi/downloads","issues_url":"https://api.github.com/repos/elfi-dev/elfi/issues{/number}","pulls_url":"https://api.github.com/repos/elfi-dev/elfi/pulls{/number}","milestones_url":"https://api.github.com/repos/elfi-dev/elfi/milestones{/number}","notifications_url":"https://api.github.com/repos/elfi-dev/elfi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elfi-dev/elfi/labels{/name}","releases_url":"https://api.github.com/repos/elfi-dev/elfi/releases{/id}","deployments_url":"https://api.github.com/repos/elfi-dev/elfi/deployments","created_at":"2016-10-03T09:03:38Z","updated_at":"2017-10-24T12:11:24Z","pushed_at":"2017-10-24T11:15:47Z","git_url":"git://github.com/elfi-dev/elfi.git","ssh_url":"git@github.com:elfi-dev/elfi.git","clone_url":"https://github.com/elfi-dev/elfi.git","svn_url":"https://github.com/elfi-dev/elfi","homepage":"http://elfi.readthedocs.io","size":1135,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":15,"open_issues":9,"watchers":89,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/235"},"html":{"href":"https://github.com/elfi-dev/elfi/pull/235"},"issue":{"href":"https://api.github.com/repos/elfi-dev/elfi/issues/235"},"comments":{"href":"https://api.github.com/repos/elfi-dev/elfi/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/elfi-dev/elfi/statuses/5f2aed4bb06b546109d7289cb0726073406d2a64"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mjarvenpaa"}}