{"action":"created","comment":{"url":"https://api.github.com/repos/mskeving/fortyseven/pulls/comments/127381534","pull_request_review_id":49960132,"id":127381534,"diff_hunk":"@@ -0,0 +1,81 @@\n+from __future__ import with_statement\n+from alembic import context\n+from sqlalchemy import engine_from_config, pool\n+from logging.config import fileConfig\n+import os, sys\n+sys.path.append(os.getcwd())\n+\n+from app import db, create_app\n+\n+# this is the Alembic Config object, which provides\n+# access to the values within the .ini file in use.\n+config = context.config\n+\n+# app = create_app(os.environ['CONFIG_ENV'])\n+app = create_app('Development')\n+\n+config.set_main_option('sqlalchemy.url', app.config['SQLALCHEMY_DATABASE_URI'])\n+\n+# Interpret the config file for Python logging.\n+# This line sets up loggers basically.\n+fileConfig(config.config_file_name)\n+\n+# add your model's MetaData object here\n+# for 'autogenerate' support\n+# from myapp import mymodel\n+# target_metadata = mymodel.Base.metadata\n+#target_metadata = db.metadata\n+target_metadata = db.metadata\n+\n+# other values from the config, defined by the needs of env.py,\n+# can be acquired:\n+# my_important_option = config.get_main_option(\"my_important_option\")\n+# ... etc.\n+\n+def run_migrations_offline():\n+    \"\"\"Run migrations in 'offline' mode.\n+\n+    This configures the context with just a URL\n+    and not an Engine, though an Engine is acceptable\n+    here as well.  By skipping the Engine creation\n+    we don't even need a DBAPI to be available.\n+\n+    Calls to context.execute() here emit the given string to the\n+    script output.\n+\n+    \"\"\"\n+    url = config.get_main_option(\"sqlalchemy.url\")\n+    context.configure(url=url, target_metadata=target_metadata)\n+\n+    with context.begin_transaction():\n+        context.run_migrations()\n+\n+def run_migrations_online():\n+    \"\"\"Run migrations in 'online' mode.\n+\n+    In this scenario we need to create an Engine\n+    and associate a connection with the context.\n+\n+    \"\"\"\n+    engine = engine_from_config(\n+                config.get_section(config.config_ini_section),","path":"alembic/env.py","position":61,"original_position":61,"commit_id":"d9db98261b15c90f452e197d5329abc883ad6148","original_commit_id":"d9db98261b15c90f452e197d5329abc883ad6148","user":{"login":"prha","id":1040172,"avatar_url":"https://avatars7.githubusercontent.com/u/1040172?v=4","gravatar_id":"","url":"https://api.github.com/users/prha","html_url":"https://github.com/prha","followers_url":"https://api.github.com/users/prha/followers","following_url":"https://api.github.com/users/prha/following{/other_user}","gists_url":"https://api.github.com/users/prha/gists{/gist_id}","starred_url":"https://api.github.com/users/prha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prha/subscriptions","organizations_url":"https://api.github.com/users/prha/orgs","repos_url":"https://api.github.com/users/prha/repos","events_url":"https://api.github.com/users/prha/events{/privacy}","received_events_url":"https://api.github.com/users/prha/received_events","type":"User","site_admin":false},"body":"do you have style preferences around indentation?  line limits?\r\n\r\nshould closing parens be on a line of their own or on the same line as the last arg.  Seems like we have two different styles on line 63 and line 69.","created_at":"2017-07-14T04:06:11Z","updated_at":"2017-07-14T04:15:25Z","html_url":"https://github.com/mskeving/fortyseven/pull/2#discussion_r127381534","pull_request_url":"https://api.github.com/repos/mskeving/fortyseven/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/mskeving/fortyseven/pulls/comments/127381534"},"html":{"href":"https://github.com/mskeving/fortyseven/pull/2#discussion_r127381534"},"pull_request":{"href":"https://api.github.com/repos/mskeving/fortyseven/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/mskeving/fortyseven/pulls/2","id":130283242,"html_url":"https://github.com/mskeving/fortyseven/pull/2","diff_url":"https://github.com/mskeving/fortyseven/pull/2.diff","patch_url":"https://github.com/mskeving/fortyseven/pull/2.patch","issue_url":"https://api.github.com/repos/mskeving/fortyseven/issues/2","number":2,"state":"open","locked":false,"title":"models draft","user":{"login":"mskeving","id":1342734,"avatar_url":"https://avatars5.githubusercontent.com/u/1342734?v=4","gravatar_id":"","url":"https://api.github.com/users/mskeving","html_url":"https://github.com/mskeving","followers_url":"https://api.github.com/users/mskeving/followers","following_url":"https://api.github.com/users/mskeving/following{/other_user}","gists_url":"https://api.github.com/users/mskeving/gists{/gist_id}","starred_url":"https://api.github.com/users/mskeving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mskeving/subscriptions","organizations_url":"https://api.github.com/users/mskeving/orgs","repos_url":"https://api.github.com/users/mskeving/repos","events_url":"https://api.github.com/users/mskeving/events{/privacy}","received_events_url":"https://api.github.com/users/mskeving/received_events","type":"User","site_admin":false},"body":"Draft of what we might need to store.\r\n\r\nQuestions\r\n- Are we going to restrict this to communication that's only between us? If yes, then we don't need to keep track of whom the recipients are.\r\n- Do we each only have one email address we care about? I think yes.\r\n- Is there a better way to signify if it's an email or a chat? Like a constraint that would be one of `['email', 'chat']`? We could also call it `label` instead of `type`. Then emails would have `label == None` and chats have `label == 'chats'` to mirror gmail. I'm making the assumption we'll want both in there.\r\n\r\nAny other suggestions?\r\n\r\n","created_at":"2017-07-13T04:14:42Z","updated_at":"2017-07-14T04:15:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c269afb54409de42d522ca202350052cbdbcc546","assignee":{"login":"prha","id":1040172,"avatar_url":"https://avatars7.githubusercontent.com/u/1040172?v=4","gravatar_id":"","url":"https://api.github.com/users/prha","html_url":"https://github.com/prha","followers_url":"https://api.github.com/users/prha/followers","following_url":"https://api.github.com/users/prha/following{/other_user}","gists_url":"https://api.github.com/users/prha/gists{/gist_id}","starred_url":"https://api.github.com/users/prha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prha/subscriptions","organizations_url":"https://api.github.com/users/prha/orgs","repos_url":"https://api.github.com/users/prha/repos","events_url":"https://api.github.com/users/prha/events{/privacy}","received_events_url":"https://api.github.com/users/prha/received_events","type":"User","site_admin":false},"assignees":[{"login":"prha","id":1040172,"avatar_url":"https://avatars7.githubusercontent.com/u/1040172?v=4","gravatar_id":"","url":"https://api.github.com/users/prha","html_url":"https://github.com/prha","followers_url":"https://api.github.com/users/prha/followers","following_url":"https://api.github.com/users/prha/following{/other_user}","gists_url":"https://api.github.com/users/prha/gists{/gist_id}","starred_url":"https://api.github.com/users/prha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prha/subscriptions","organizations_url":"https://api.github.com/users/prha/orgs","repos_url":"https://api.github.com/users/prha/repos","events_url":"https://api.github.com/users/prha/events{/privacy}","received_events_url":"https://api.github.com/users/prha/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mskeving/fortyseven/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mskeving/fortyseven/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mskeving/fortyseven/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mskeving/fortyseven/issues/2/comments","statuses_url":"https://api.github.com/repos/mskeving/fortyseven/statuses/d9db98261b15c90f452e197d5329abc883ad6148","head":{"label":"mskeving:models","ref":"models","sha":"d9db98261b15c90f452e197d5329abc883ad6148","user":{"login":"mskeving","id":1342734,"avatar_url":"https://avatars5.githubusercontent.com/u/1342734?v=4","gravatar_id":"","url":"https://api.github.com/users/mskeving","html_url":"https://github.com/mskeving","followers_url":"https://api.github.com/users/mskeving/followers","following_url":"https://api.github.com/users/mskeving/following{/other_user}","gists_url":"https://api.github.com/users/mskeving/gists{/gist_id}","starred_url":"https://api.github.com/users/mskeving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mskeving/subscriptions","organizations_url":"https://api.github.com/users/mskeving/orgs","repos_url":"https://api.github.com/users/mskeving/repos","events_url":"https://api.github.com/users/mskeving/events{/privacy}","received_events_url":"https://api.github.com/users/mskeving/received_events","type":"User","site_admin":false},"repo":{"id":96638919,"name":"fortyseven","full_name":"mskeving/fortyseven","owner":{"login":"mskeving","id":1342734,"avatar_url":"https://avatars5.githubusercontent.com/u/1342734?v=4","gravatar_id":"","url":"https://api.github.com/users/mskeving","html_url":"https://github.com/mskeving","followers_url":"https://api.github.com/users/mskeving/followers","following_url":"https://api.github.com/users/mskeving/following{/other_user}","gists_url":"https://api.github.com/users/mskeving/gists{/gist_id}","starred_url":"https://api.github.com/users/mskeving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mskeving/subscriptions","organizations_url":"https://api.github.com/users/mskeving/orgs","repos_url":"https://api.github.com/users/mskeving/repos","events_url":"https://api.github.com/users/mskeving/events{/privacy}","received_events_url":"https://api.github.com/users/mskeving/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mskeving/fortyseven","description":null,"fork":false,"url":"https://api.github.com/repos/mskeving/fortyseven","forks_url":"https://api.github.com/repos/mskeving/fortyseven/forks","keys_url":"https://api.github.com/repos/mskeving/fortyseven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mskeving/fortyseven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mskeving/fortyseven/teams","hooks_url":"https://api.github.com/repos/mskeving/fortyseven/hooks","issue_events_url":"https://api.github.com/repos/mskeving/fortyseven/issues/events{/number}","events_url":"https://api.github.com/repos/mskeving/fortyseven/events","assignees_url":"https://api.github.com/repos/mskeving/fortyseven/assignees{/user}","branches_url":"https://api.github.com/repos/mskeving/fortyseven/branches{/branch}","tags_url":"https://api.github.com/repos/mskeving/fortyseven/tags","blobs_url":"https://api.github.com/repos/mskeving/fortyseven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mskeving/fortyseven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mskeving/fortyseven/git/refs{/sha}","trees_url":"https://api.github.com/repos/mskeving/fortyseven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mskeving/fortyseven/statuses/{sha}","languages_url":"https://api.github.com/repos/mskeving/fortyseven/languages","stargazers_url":"https://api.github.com/repos/mskeving/fortyseven/stargazers","contributors_url":"https://api.github.com/repos/mskeving/fortyseven/contributors","subscribers_url":"https://api.github.com/repos/mskeving/fortyseven/subscribers","subscription_url":"https://api.github.com/repos/mskeving/fortyseven/subscription","commits_url":"https://api.github.com/repos/mskeving/fortyseven/commits{/sha}","git_commits_url":"https://api.github.com/repos/mskeving/fortyseven/git/commits{/sha}","comments_url":"https://api.github.com/repos/mskeving/fortyseven/comments{/number}","issue_comment_url":"https://api.github.com/repos/mskeving/fortyseven/issues/comments{/number}","contents_url":"https://api.github.com/repos/mskeving/fortyseven/contents/{+path}","compare_url":"https://api.github.com/repos/mskeving/fortyseven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mskeving/fortyseven/merges","archive_url":"https://api.github.com/repos/mskeving/fortyseven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mskeving/fortyseven/downloads","issues_url":"https://api.github.com/repos/mskeving/fortyseven/issues{/number}","pulls_url":"https://api.github.com/repos/mskeving/fortyseven/pulls{/number}","milestones_url":"https://api.github.com/repos/mskeving/fortyseven/milestones{/number}","notifications_url":"https://api.github.com/repos/mskeving/fortyseven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mskeving/fortyseven/labels{/name}","releases_url":"https://api.github.com/repos/mskeving/fortyseven/releases{/id}","deployments_url":"https://api.github.com/repos/mskeving/fortyseven/deployments","created_at":"2017-07-08T19:11:09Z","updated_at":"2017-07-13T04:06:52Z","pushed_at":"2017-07-13T05:22:42Z","git_url":"git://github.com/mskeving/fortyseven.git","ssh_url":"git@github.com:mskeving/fortyseven.git","clone_url":"https://github.com/mskeving/fortyseven.git","svn_url":"https://github.com/mskeving/fortyseven","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mskeving:master","ref":"master","sha":"2c8160ef050b89426f2f99cd1efc01a85d5320fa","user":{"login":"mskeving","id":1342734,"avatar_url":"https://avatars5.githubusercontent.com/u/1342734?v=4","gravatar_id":"","url":"https://api.github.com/users/mskeving","html_url":"https://github.com/mskeving","followers_url":"https://api.github.com/users/mskeving/followers","following_url":"https://api.github.com/users/mskeving/following{/other_user}","gists_url":"https://api.github.com/users/mskeving/gists{/gist_id}","starred_url":"https://api.github.com/users/mskeving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mskeving/subscriptions","organizations_url":"https://api.github.com/users/mskeving/orgs","repos_url":"https://api.github.com/users/mskeving/repos","events_url":"https://api.github.com/users/mskeving/events{/privacy}","received_events_url":"https://api.github.com/users/mskeving/received_events","type":"User","site_admin":false},"repo":{"id":96638919,"name":"fortyseven","full_name":"mskeving/fortyseven","owner":{"login":"mskeving","id":1342734,"avatar_url":"https://avatars5.githubusercontent.com/u/1342734?v=4","gravatar_id":"","url":"https://api.github.com/users/mskeving","html_url":"https://github.com/mskeving","followers_url":"https://api.github.com/users/mskeving/followers","following_url":"https://api.github.com/users/mskeving/following{/other_user}","gists_url":"https://api.github.com/users/mskeving/gists{/gist_id}","starred_url":"https://api.github.com/users/mskeving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mskeving/subscriptions","organizations_url":"https://api.github.com/users/mskeving/orgs","repos_url":"https://api.github.com/users/mskeving/repos","events_url":"https://api.github.com/users/mskeving/events{/privacy}","received_events_url":"https://api.github.com/users/mskeving/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mskeving/fortyseven","description":null,"fork":false,"url":"https://api.github.com/repos/mskeving/fortyseven","forks_url":"https://api.github.com/repos/mskeving/fortyseven/forks","keys_url":"https://api.github.com/repos/mskeving/fortyseven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mskeving/fortyseven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mskeving/fortyseven/teams","hooks_url":"https://api.github.com/repos/mskeving/fortyseven/hooks","issue_events_url":"https://api.github.com/repos/mskeving/fortyseven/issues/events{/number}","events_url":"https://api.github.com/repos/mskeving/fortyseven/events","assignees_url":"https://api.github.com/repos/mskeving/fortyseven/assignees{/user}","branches_url":"https://api.github.com/repos/mskeving/fortyseven/branches{/branch}","tags_url":"https://api.github.com/repos/mskeving/fortyseven/tags","blobs_url":"https://api.github.com/repos/mskeving/fortyseven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mskeving/fortyseven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mskeving/fortyseven/git/refs{/sha}","trees_url":"https://api.github.com/repos/mskeving/fortyseven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mskeving/fortyseven/statuses/{sha}","languages_url":"https://api.github.com/repos/mskeving/fortyseven/languages","stargazers_url":"https://api.github.com/repos/mskeving/fortyseven/stargazers","contributors_url":"https://api.github.com/repos/mskeving/fortyseven/contributors","subscribers_url":"https://api.github.com/repos/mskeving/fortyseven/subscribers","subscription_url":"https://api.github.com/repos/mskeving/fortyseven/subscription","commits_url":"https://api.github.com/repos/mskeving/fortyseven/commits{/sha}","git_commits_url":"https://api.github.com/repos/mskeving/fortyseven/git/commits{/sha}","comments_url":"https://api.github.com/repos/mskeving/fortyseven/comments{/number}","issue_comment_url":"https://api.github.com/repos/mskeving/fortyseven/issues/comments{/number}","contents_url":"https://api.github.com/repos/mskeving/fortyseven/contents/{+path}","compare_url":"https://api.github.com/repos/mskeving/fortyseven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mskeving/fortyseven/merges","archive_url":"https://api.github.com/repos/mskeving/fortyseven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mskeving/fortyseven/downloads","issues_url":"https://api.github.com/repos/mskeving/fortyseven/issues{/number}","pulls_url":"https://api.github.com/repos/mskeving/fortyseven/pulls{/number}","milestones_url":"https://api.github.com/repos/mskeving/fortyseven/milestones{/number}","notifications_url":"https://api.github.com/repos/mskeving/fortyseven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mskeving/fortyseven/labels{/name}","releases_url":"https://api.github.com/repos/mskeving/fortyseven/releases{/id}","deployments_url":"https://api.github.com/repos/mskeving/fortyseven/deployments","created_at":"2017-07-08T19:11:09Z","updated_at":"2017-07-13T04:06:52Z","pushed_at":"2017-07-13T05:22:42Z","git_url":"git://github.com/mskeving/fortyseven.git","ssh_url":"git@github.com:mskeving/fortyseven.git","clone_url":"https://github.com/mskeving/fortyseven.git","svn_url":"https://github.com/mskeving/fortyseven","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mskeving/fortyseven/pulls/2"},"html":{"href":"https://github.com/mskeving/fortyseven/pull/2"},"issue":{"href":"https://api.github.com/repos/mskeving/fortyseven/issues/2"},"comments":{"href":"https://api.github.com/repos/mskeving/fortyseven/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mskeving/fortyseven/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mskeving/fortyseven/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mskeving/fortyseven/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mskeving/fortyseven/statuses/d9db98261b15c90f452e197d5329abc883ad6148"}}}}
{"actor":{"display_login":"prha"}}