{"action":"created","comment":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/comments/124510156","pull_request_review_id":46803881,"id":124510156,"diff_hunk":"@@ -8,7 +8,7 @@ import url from 'url';\n //   'preview.0d2d3d845f78399fd6d5e859daa152a9.css',\n //   'static/preview.9adbb5ef965106be1cc3.bundle.js.map',\n //   'preview.0d2d3d845f78399fd6d5e859daa152a9.css.map' ]\n-const urlsFromAssets = assets => {\n+export const urlsFromAssets = assets => {","path":"app/react/src/server/iframe.html.js","position":5,"original_position":5,"commit_id":"6c8898e7bf76fc238dd1ccece71bdf8607043479","original_commit_id":"6c8898e7bf76fc238dd1ccece71bdf8607043479","user":{"login":"shilman","id":488689,"avatar_url":"https://avatars1.githubusercontent.com/u/488689?v=3","gravatar_id":"","url":"https://api.github.com/users/shilman","html_url":"https://github.com/shilman","followers_url":"https://api.github.com/users/shilman/followers","following_url":"https://api.github.com/users/shilman/following{/other_user}","gists_url":"https://api.github.com/users/shilman/gists{/gist_id}","starred_url":"https://api.github.com/users/shilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shilman/subscriptions","organizations_url":"https://api.github.com/users/shilman/orgs","repos_url":"https://api.github.com/users/shilman/repos","events_url":"https://api.github.com/users/shilman/events{/privacy}","received_events_url":"https://api.github.com/users/shilman/received_events","type":"User","site_admin":false},"body":"who uses this? does it need to be exported?","created_at":"2017-06-28T10:53:35Z","updated_at":"2017-06-28T10:55:55Z","html_url":"https://github.com/storybooks/storybook/pull/1363#discussion_r124510156","pull_request_url":"https://api.github.com/repos/storybooks/storybook/pulls/1363","_links":{"self":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/comments/124510156"},"html":{"href":"https://github.com/storybooks/storybook/pull/1363#discussion_r124510156"},"pull_request":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/1363"}}},"pull_request":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/1363","id":127592257,"html_url":"https://github.com/storybooks/storybook/pull/1363","diff_url":"https://github.com/storybooks/storybook/pull/1363.diff","patch_url":"https://github.com/storybooks/storybook/pull/1363.patch","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/1363","number":1363,"state":"open","locked":false,"title":"fix: allow multiple assets with different types","user":{"login":"joscha","id":188038,"avatar_url":"https://avatars0.githubusercontent.com/u/188038?v=3","gravatar_id":"","url":"https://api.github.com/users/joscha","html_url":"https://github.com/joscha","followers_url":"https://api.github.com/users/joscha/followers","following_url":"https://api.github.com/users/joscha/following{/other_user}","gists_url":"https://api.github.com/users/joscha/gists{/gist_id}","starred_url":"https://api.github.com/users/joscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscha/subscriptions","organizations_url":"https://api.github.com/users/joscha/orgs","repos_url":"https://api.github.com/users/joscha/repos","events_url":"https://api.github.com/users/joscha/events{/privacy}","received_events_url":"https://api.github.com/users/joscha/received_events","type":"User","site_admin":false},"body":"Issue: CSS not displaying when using the `exract-text-webpack-plugin`, regression introduced in 38b9dfabfb1b8691c1f7b378f9dfff05b99603f5\r\n\r\n## What I did\r\n\r\nUpgraded from `@kadira/storybook@1.x` and had the [`extract-text-webpack-plugin`](https://github.com/webpack-contrib/extract-text-webpack-plugin/) enabled.\r\n\r\nUnfortunately my CSS didn't load, encountering the same issue as described in #1104 and most likely #388 and #708.\r\n\r\nUsing the `extract-text-webpack-plugin` creates a new entry point however, making the asset list look something like this:\r\n```js\r\n{ manager: 'static/manager.02f732c9002a59214667.bundle.js',\r\n  preview:\r\n   [ 'static/preview.352040d027a7c22331ae.bundle.js',\r\n     'static/preview.1f62768c19a65e75e4259a4c418d292d.css',\r\n     'static/preview.1f62768c19a65e75e4259a4c418d292d.css.map' ] }\r\n```\r\nand due to https://github.com/storybooks/storybook/blob/34b96aae764a386c35d4db2a057e85236bd8ddfe/app/react/src/server/iframe.html.js#L33 only ever taking the very first asset, the CSS never makes it into `iframe.html`.\r\n\r\n## How to test\r\n\r\nI added new tests :)\r\n\r\nfixes #388 \r\nfixes #708\r\nfixes #1104","created_at":"2017-06-27T00:49:43Z","updated_at":"2017-06-28T10:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae884de8b98a5f40d58d5fa6e17d01bdbd484266","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ndelangen","id":3070389,"avatar_url":"https://avatars1.githubusercontent.com/u/3070389?v=3","gravatar_id":"","url":"https://api.github.com/users/ndelangen","html_url":"https://github.com/ndelangen","followers_url":"https://api.github.com/users/ndelangen/followers","following_url":"https://api.github.com/users/ndelangen/following{/other_user}","gists_url":"https://api.github.com/users/ndelangen/gists{/gist_id}","starred_url":"https://api.github.com/users/ndelangen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndelangen/subscriptions","organizations_url":"https://api.github.com/users/ndelangen/orgs","repos_url":"https://api.github.com/users/ndelangen/repos","events_url":"https://api.github.com/users/ndelangen/events{/privacy}","received_events_url":"https://api.github.com/users/ndelangen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/storybooks/storybook/pulls/1363/commits","review_comments_url":"https://api.github.com/repos/storybooks/storybook/pulls/1363/comments","review_comment_url":"https://api.github.com/repos/storybooks/storybook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/1363/comments","statuses_url":"https://api.github.com/repos/storybooks/storybook/statuses/6c8898e7bf76fc238dd1ccece71bdf8607043479","head":{"label":"joscha:joscha/fix-extract-text-webpack-plugin-usage","ref":"joscha/fix-extract-text-webpack-plugin-usage","sha":"6c8898e7bf76fc238dd1ccece71bdf8607043479","user":{"login":"joscha","id":188038,"avatar_url":"https://avatars0.githubusercontent.com/u/188038?v=3","gravatar_id":"","url":"https://api.github.com/users/joscha","html_url":"https://github.com/joscha","followers_url":"https://api.github.com/users/joscha/followers","following_url":"https://api.github.com/users/joscha/following{/other_user}","gists_url":"https://api.github.com/users/joscha/gists{/gist_id}","starred_url":"https://api.github.com/users/joscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscha/subscriptions","organizations_url":"https://api.github.com/users/joscha/orgs","repos_url":"https://api.github.com/users/joscha/repos","events_url":"https://api.github.com/users/joscha/events{/privacy}","received_events_url":"https://api.github.com/users/joscha/received_events","type":"User","site_admin":false},"repo":{"id":72712304,"name":"react-storybook","full_name":"joscha/react-storybook","owner":{"login":"joscha","id":188038,"avatar_url":"https://avatars0.githubusercontent.com/u/188038?v=3","gravatar_id":"","url":"https://api.github.com/users/joscha","html_url":"https://github.com/joscha","followers_url":"https://api.github.com/users/joscha/followers","following_url":"https://api.github.com/users/joscha/following{/other_user}","gists_url":"https://api.github.com/users/joscha/gists{/gist_id}","starred_url":"https://api.github.com/users/joscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joscha/subscriptions","organizations_url":"https://api.github.com/users/joscha/orgs","repos_url":"https://api.github.com/users/joscha/repos","events_url":"https://api.github.com/users/joscha/events{/privacy}","received_events_url":"https://api.github.com/users/joscha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joscha/react-storybook","description":"UI Component Dev Environment for React","fork":true,"url":"https://api.github.com/repos/joscha/react-storybook","forks_url":"https://api.github.com/repos/joscha/react-storybook/forks","keys_url":"https://api.github.com/repos/joscha/react-storybook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joscha/react-storybook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joscha/react-storybook/teams","hooks_url":"https://api.github.com/repos/joscha/react-storybook/hooks","issue_events_url":"https://api.github.com/repos/joscha/react-storybook/issues/events{/number}","events_url":"https://api.github.com/repos/joscha/react-storybook/events","assignees_url":"https://api.github.com/repos/joscha/react-storybook/assignees{/user}","branches_url":"https://api.github.com/repos/joscha/react-storybook/branches{/branch}","tags_url":"https://api.github.com/repos/joscha/react-storybook/tags","blobs_url":"https://api.github.com/repos/joscha/react-storybook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joscha/react-storybook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joscha/react-storybook/git/refs{/sha}","trees_url":"https://api.github.com/repos/joscha/react-storybook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joscha/react-storybook/statuses/{sha}","languages_url":"https://api.github.com/repos/joscha/react-storybook/languages","stargazers_url":"https://api.github.com/repos/joscha/react-storybook/stargazers","contributors_url":"https://api.github.com/repos/joscha/react-storybook/contributors","subscribers_url":"https://api.github.com/repos/joscha/react-storybook/subscribers","subscription_url":"https://api.github.com/repos/joscha/react-storybook/subscription","commits_url":"https://api.github.com/repos/joscha/react-storybook/commits{/sha}","git_commits_url":"https://api.github.com/repos/joscha/react-storybook/git/commits{/sha}","comments_url":"https://api.github.com/repos/joscha/react-storybook/comments{/number}","issue_comment_url":"https://api.github.com/repos/joscha/react-storybook/issues/comments{/number}","contents_url":"https://api.github.com/repos/joscha/react-storybook/contents/{+path}","compare_url":"https://api.github.com/repos/joscha/react-storybook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joscha/react-storybook/merges","archive_url":"https://api.github.com/repos/joscha/react-storybook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joscha/react-storybook/downloads","issues_url":"https://api.github.com/repos/joscha/react-storybook/issues{/number}","pulls_url":"https://api.github.com/repos/joscha/react-storybook/pulls{/number}","milestones_url":"https://api.github.com/repos/joscha/react-storybook/milestones{/number}","notifications_url":"https://api.github.com/repos/joscha/react-storybook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joscha/react-storybook/labels{/name}","releases_url":"https://api.github.com/repos/joscha/react-storybook/releases{/id}","deployments_url":"https://api.github.com/repos/joscha/react-storybook/deployments","created_at":"2016-11-03T05:38:15Z","updated_at":"2016-11-03T09:02:45Z","pushed_at":"2017-06-27T12:13:55Z","git_url":"git://github.com/joscha/react-storybook.git","ssh_url":"git@github.com:joscha/react-storybook.git","clone_url":"https://github.com/joscha/react-storybook.git","svn_url":"https://github.com/joscha/react-storybook","homepage":"https://getstorybook.io","size":24795,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"storybooks:master","ref":"master","sha":"da6bd6555e94d2db71b108cc35a2f7e68f1c388f","user":{"login":"storybooks","id":22632046,"avatar_url":"https://avatars0.githubusercontent.com/u/22632046?v=3","gravatar_id":"","url":"https://api.github.com/users/storybooks","html_url":"https://github.com/storybooks","followers_url":"https://api.github.com/users/storybooks/followers","following_url":"https://api.github.com/users/storybooks/following{/other_user}","gists_url":"https://api.github.com/users/storybooks/gists{/gist_id}","starred_url":"https://api.github.com/users/storybooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storybooks/subscriptions","organizations_url":"https://api.github.com/users/storybooks/orgs","repos_url":"https://api.github.com/users/storybooks/repos","events_url":"https://api.github.com/users/storybooks/events{/privacy}","received_events_url":"https://api.github.com/users/storybooks/received_events","type":"Organization","site_admin":false},"repo":{"id":54173593,"name":"storybook","full_name":"storybooks/storybook","owner":{"login":"storybooks","id":22632046,"avatar_url":"https://avatars0.githubusercontent.com/u/22632046?v=3","gravatar_id":"","url":"https://api.github.com/users/storybooks","html_url":"https://github.com/storybooks","followers_url":"https://api.github.com/users/storybooks/followers","following_url":"https://api.github.com/users/storybooks/following{/other_user}","gists_url":"https://api.github.com/users/storybooks/gists{/gist_id}","starred_url":"https://api.github.com/users/storybooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storybooks/subscriptions","organizations_url":"https://api.github.com/users/storybooks/orgs","repos_url":"https://api.github.com/users/storybooks/repos","events_url":"https://api.github.com/users/storybooks/events{/privacy}","received_events_url":"https://api.github.com/users/storybooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storybooks/storybook","description":"📓 Interactive development & testing environment for React and React-Native UI components","fork":false,"url":"https://api.github.com/repos/storybooks/storybook","forks_url":"https://api.github.com/repos/storybooks/storybook/forks","keys_url":"https://api.github.com/repos/storybooks/storybook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storybooks/storybook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storybooks/storybook/teams","hooks_url":"https://api.github.com/repos/storybooks/storybook/hooks","issue_events_url":"https://api.github.com/repos/storybooks/storybook/issues/events{/number}","events_url":"https://api.github.com/repos/storybooks/storybook/events","assignees_url":"https://api.github.com/repos/storybooks/storybook/assignees{/user}","branches_url":"https://api.github.com/repos/storybooks/storybook/branches{/branch}","tags_url":"https://api.github.com/repos/storybooks/storybook/tags","blobs_url":"https://api.github.com/repos/storybooks/storybook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storybooks/storybook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storybooks/storybook/git/refs{/sha}","trees_url":"https://api.github.com/repos/storybooks/storybook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storybooks/storybook/statuses/{sha}","languages_url":"https://api.github.com/repos/storybooks/storybook/languages","stargazers_url":"https://api.github.com/repos/storybooks/storybook/stargazers","contributors_url":"https://api.github.com/repos/storybooks/storybook/contributors","subscribers_url":"https://api.github.com/repos/storybooks/storybook/subscribers","subscription_url":"https://api.github.com/repos/storybooks/storybook/subscription","commits_url":"https://api.github.com/repos/storybooks/storybook/commits{/sha}","git_commits_url":"https://api.github.com/repos/storybooks/storybook/git/commits{/sha}","comments_url":"https://api.github.com/repos/storybooks/storybook/comments{/number}","issue_comment_url":"https://api.github.com/repos/storybooks/storybook/issues/comments{/number}","contents_url":"https://api.github.com/repos/storybooks/storybook/contents/{+path}","compare_url":"https://api.github.com/repos/storybooks/storybook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storybooks/storybook/merges","archive_url":"https://api.github.com/repos/storybooks/storybook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storybooks/storybook/downloads","issues_url":"https://api.github.com/repos/storybooks/storybook/issues{/number}","pulls_url":"https://api.github.com/repos/storybooks/storybook/pulls{/number}","milestones_url":"https://api.github.com/repos/storybooks/storybook/milestones{/number}","notifications_url":"https://api.github.com/repos/storybooks/storybook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storybooks/storybook/labels{/name}","releases_url":"https://api.github.com/repos/storybooks/storybook/releases{/id}","deployments_url":"https://api.github.com/repos/storybooks/storybook/deployments","created_at":"2016-03-18T04:23:44Z","updated_at":"2017-06-28T10:38:35Z","pushed_at":"2017-06-28T09:30:44Z","git_url":"git://github.com/storybooks/storybook.git","ssh_url":"git@github.com:storybooks/storybook.git","clone_url":"https://github.com/storybooks/storybook.git","svn_url":"https://github.com/storybooks/storybook","homepage":"https://storybook.js.org","size":36312,"stargazers_count":11576,"watchers_count":11576,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":699,"mirror_url":null,"open_issues_count":307,"forks":699,"open_issues":307,"watchers":11576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/1363"},"html":{"href":"https://github.com/storybooks/storybook/pull/1363"},"issue":{"href":"https://api.github.com/repos/storybooks/storybook/issues/1363"},"comments":{"href":"https://api.github.com/repos/storybooks/storybook/issues/1363/comments"},"review_comments":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/1363/comments"},"review_comment":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/1363/commits"},"statuses":{"href":"https://api.github.com/repos/storybooks/storybook/statuses/6c8898e7bf76fc238dd1ccece71bdf8607043479"}}}}
{"actor":{"display_login":"shilman"}}