{"action":"opened","number":604,"pull_request":{"url":"https://api.github.com/repos/kelseyhightower/confd/pulls/604","id":141699096,"html_url":"https://github.com/kelseyhightower/confd/pull/604","diff_url":"https://github.com/kelseyhightower/confd/pull/604.diff","patch_url":"https://github.com/kelseyhightower/confd/pull/604.patch","issue_url":"https://api.github.com/repos/kelseyhightower/confd/issues/604","number":604,"state":"open","locked":false,"title":"Redis Client Updates: WatchPrefix, Hash support, key naming conventions","user":{"login":"jmooradi","id":20848384,"avatar_url":"https://avatars2.githubusercontent.com/u/20848384?v=4","gravatar_id":"","url":"https://api.github.com/users/jmooradi","html_url":"https://github.com/jmooradi","followers_url":"https://api.github.com/users/jmooradi/followers","following_url":"https://api.github.com/users/jmooradi/following{/other_user}","gists_url":"https://api.github.com/users/jmooradi/gists{/gist_id}","starred_url":"https://api.github.com/users/jmooradi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmooradi/subscriptions","organizations_url":"https://api.github.com/users/jmooradi/orgs","repos_url":"https://api.github.com/users/jmooradi/repos","events_url":"https://api.github.com/users/jmooradi/events{/privacy}","received_events_url":"https://api.github.com/users/jmooradi/received_events","type":"User","site_admin":false},"body":"I've made some updates to the redis backend based on some needs for a project I was working on. I figured some of these might be useful for others as well as I wanted a second look at all the code for additional feedback on any problems you might see in the implementation.\r\nOverview of additions:\r\n- WatchPrefix support using redis pubsub and keyspace events\r\n- GetValues rewrite to support redis hashes which is preferable since a normal scan has to iterate over every key in the entire database\r\n- Convert confd \"/\" key naming notation to redis standard \":\" notation when doing key lookups, this change will break existing setups, maybe it would be better to use a config flag to enable this?","created_at":"2017-09-18T20:41:18Z","updated_at":"2017-09-18T20:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kelseyhightower/confd/pulls/604/commits","review_comments_url":"https://api.github.com/repos/kelseyhightower/confd/pulls/604/comments","review_comment_url":"https://api.github.com/repos/kelseyhightower/confd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kelseyhightower/confd/issues/604/comments","statuses_url":"https://api.github.com/repos/kelseyhightower/confd/statuses/3e25a1966978b6167f8b1e709640fc09f46db57b","head":{"label":"jmooradi:master","ref":"master","sha":"3e25a1966978b6167f8b1e709640fc09f46db57b","user":{"login":"jmooradi","id":20848384,"avatar_url":"https://avatars2.githubusercontent.com/u/20848384?v=4","gravatar_id":"","url":"https://api.github.com/users/jmooradi","html_url":"https://github.com/jmooradi","followers_url":"https://api.github.com/users/jmooradi/followers","following_url":"https://api.github.com/users/jmooradi/following{/other_user}","gists_url":"https://api.github.com/users/jmooradi/gists{/gist_id}","starred_url":"https://api.github.com/users/jmooradi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmooradi/subscriptions","organizations_url":"https://api.github.com/users/jmooradi/orgs","repos_url":"https://api.github.com/users/jmooradi/repos","events_url":"https://api.github.com/users/jmooradi/events{/privacy}","received_events_url":"https://api.github.com/users/jmooradi/received_events","type":"User","site_admin":false},"repo":{"id":103988850,"name":"confd","full_name":"jmooradi/confd","owner":{"login":"jmooradi","id":20848384,"avatar_url":"https://avatars2.githubusercontent.com/u/20848384?v=4","gravatar_id":"","url":"https://api.github.com/users/jmooradi","html_url":"https://github.com/jmooradi","followers_url":"https://api.github.com/users/jmooradi/followers","following_url":"https://api.github.com/users/jmooradi/following{/other_user}","gists_url":"https://api.github.com/users/jmooradi/gists{/gist_id}","starred_url":"https://api.github.com/users/jmooradi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmooradi/subscriptions","organizations_url":"https://api.github.com/users/jmooradi/orgs","repos_url":"https://api.github.com/users/jmooradi/repos","events_url":"https://api.github.com/users/jmooradi/events{/privacy}","received_events_url":"https://api.github.com/users/jmooradi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmooradi/confd","description":"Manage local application configuration files using templates and data from etcd or consul","fork":true,"url":"https://api.github.com/repos/jmooradi/confd","forks_url":"https://api.github.com/repos/jmooradi/confd/forks","keys_url":"https://api.github.com/repos/jmooradi/confd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmooradi/confd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmooradi/confd/teams","hooks_url":"https://api.github.com/repos/jmooradi/confd/hooks","issue_events_url":"https://api.github.com/repos/jmooradi/confd/issues/events{/number}","events_url":"https://api.github.com/repos/jmooradi/confd/events","assignees_url":"https://api.github.com/repos/jmooradi/confd/assignees{/user}","branches_url":"https://api.github.com/repos/jmooradi/confd/branches{/branch}","tags_url":"https://api.github.com/repos/jmooradi/confd/tags","blobs_url":"https://api.github.com/repos/jmooradi/confd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmooradi/confd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmooradi/confd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmooradi/confd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmooradi/confd/statuses/{sha}","languages_url":"https://api.github.com/repos/jmooradi/confd/languages","stargazers_url":"https://api.github.com/repos/jmooradi/confd/stargazers","contributors_url":"https://api.github.com/repos/jmooradi/confd/contributors","subscribers_url":"https://api.github.com/repos/jmooradi/confd/subscribers","subscription_url":"https://api.github.com/repos/jmooradi/confd/subscription","commits_url":"https://api.github.com/repos/jmooradi/confd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmooradi/confd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmooradi/confd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmooradi/confd/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmooradi/confd/contents/{+path}","compare_url":"https://api.github.com/repos/jmooradi/confd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmooradi/confd/merges","archive_url":"https://api.github.com/repos/jmooradi/confd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmooradi/confd/downloads","issues_url":"https://api.github.com/repos/jmooradi/confd/issues{/number}","pulls_url":"https://api.github.com/repos/jmooradi/confd/pulls{/number}","milestones_url":"https://api.github.com/repos/jmooradi/confd/milestones{/number}","notifications_url":"https://api.github.com/repos/jmooradi/confd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmooradi/confd/labels{/name}","releases_url":"https://api.github.com/repos/jmooradi/confd/releases{/id}","deployments_url":"https://api.github.com/repos/jmooradi/confd/deployments","created_at":"2017-09-18T20:31:10Z","updated_at":"2017-09-18T20:31:12Z","pushed_at":"2017-09-18T20:34:42Z","git_url":"git://github.com/jmooradi/confd.git","ssh_url":"git@github.com:jmooradi/confd.git","clone_url":"https://github.com/jmooradi/confd.git","svn_url":"https://github.com/jmooradi/confd","homepage":"","size":6633,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kelseyhightower:master","ref":"master","sha":"61652a2ca442a5b15753a3c0bfc494e1a8a379ee","user":{"login":"kelseyhightower","id":1123322,"avatar_url":"https://avatars2.githubusercontent.com/u/1123322?v=4","gravatar_id":"","url":"https://api.github.com/users/kelseyhightower","html_url":"https://github.com/kelseyhightower","followers_url":"https://api.github.com/users/kelseyhightower/followers","following_url":"https://api.github.com/users/kelseyhightower/following{/other_user}","gists_url":"https://api.github.com/users/kelseyhightower/gists{/gist_id}","starred_url":"https://api.github.com/users/kelseyhightower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelseyhightower/subscriptions","organizations_url":"https://api.github.com/users/kelseyhightower/orgs","repos_url":"https://api.github.com/users/kelseyhightower/repos","events_url":"https://api.github.com/users/kelseyhightower/events{/privacy}","received_events_url":"https://api.github.com/users/kelseyhightower/received_events","type":"User","site_admin":false},"repo":{"id":13234395,"name":"confd","full_name":"kelseyhightower/confd","owner":{"login":"kelseyhightower","id":1123322,"avatar_url":"https://avatars2.githubusercontent.com/u/1123322?v=4","gravatar_id":"","url":"https://api.github.com/users/kelseyhightower","html_url":"https://github.com/kelseyhightower","followers_url":"https://api.github.com/users/kelseyhightower/followers","following_url":"https://api.github.com/users/kelseyhightower/following{/other_user}","gists_url":"https://api.github.com/users/kelseyhightower/gists{/gist_id}","starred_url":"https://api.github.com/users/kelseyhightower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelseyhightower/subscriptions","organizations_url":"https://api.github.com/users/kelseyhightower/orgs","repos_url":"https://api.github.com/users/kelseyhightower/repos","events_url":"https://api.github.com/users/kelseyhightower/events{/privacy}","received_events_url":"https://api.github.com/users/kelseyhightower/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kelseyhightower/confd","description":"Manage local application configuration files using templates and data from etcd or consul","fork":false,"url":"https://api.github.com/repos/kelseyhightower/confd","forks_url":"https://api.github.com/repos/kelseyhightower/confd/forks","keys_url":"https://api.github.com/repos/kelseyhightower/confd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelseyhightower/confd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelseyhightower/confd/teams","hooks_url":"https://api.github.com/repos/kelseyhightower/confd/hooks","issue_events_url":"https://api.github.com/repos/kelseyhightower/confd/issues/events{/number}","events_url":"https://api.github.com/repos/kelseyhightower/confd/events","assignees_url":"https://api.github.com/repos/kelseyhightower/confd/assignees{/user}","branches_url":"https://api.github.com/repos/kelseyhightower/confd/branches{/branch}","tags_url":"https://api.github.com/repos/kelseyhightower/confd/tags","blobs_url":"https://api.github.com/repos/kelseyhightower/confd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelseyhightower/confd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelseyhightower/confd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelseyhightower/confd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelseyhightower/confd/statuses/{sha}","languages_url":"https://api.github.com/repos/kelseyhightower/confd/languages","stargazers_url":"https://api.github.com/repos/kelseyhightower/confd/stargazers","contributors_url":"https://api.github.com/repos/kelseyhightower/confd/contributors","subscribers_url":"https://api.github.com/repos/kelseyhightower/confd/subscribers","subscription_url":"https://api.github.com/repos/kelseyhightower/confd/subscription","commits_url":"https://api.github.com/repos/kelseyhightower/confd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelseyhightower/confd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelseyhightower/confd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelseyhightower/confd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelseyhightower/confd/contents/{+path}","compare_url":"https://api.github.com/repos/kelseyhightower/confd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelseyhightower/confd/merges","archive_url":"https://api.github.com/repos/kelseyhightower/confd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelseyhightower/confd/downloads","issues_url":"https://api.github.com/repos/kelseyhightower/confd/issues{/number}","pulls_url":"https://api.github.com/repos/kelseyhightower/confd/pulls{/number}","milestones_url":"https://api.github.com/repos/kelseyhightower/confd/milestones{/number}","notifications_url":"https://api.github.com/repos/kelseyhightower/confd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelseyhightower/confd/labels{/name}","releases_url":"https://api.github.com/repos/kelseyhightower/confd/releases{/id}","deployments_url":"https://api.github.com/repos/kelseyhightower/confd/deployments","created_at":"2013-10-01T04:06:09Z","updated_at":"2017-09-18T08:02:37Z","pushed_at":"2017-09-16T18:38:58Z","git_url":"git://github.com/kelseyhightower/confd.git","ssh_url":"git@github.com:kelseyhightower/confd.git","clone_url":"https://github.com/kelseyhightower/confd.git","svn_url":"https://github.com/kelseyhightower/confd","homepage":"","size":6633,"stargazers_count":4170,"watchers_count":4170,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":695,"mirror_url":null,"open_issues_count":67,"forks":695,"open_issues":67,"watchers":4170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kelseyhightower/confd/pulls/604"},"html":{"href":"https://github.com/kelseyhightower/confd/pull/604"},"issue":{"href":"https://api.github.com/repos/kelseyhightower/confd/issues/604"},"comments":{"href":"https://api.github.com/repos/kelseyhightower/confd/issues/604/comments"},"review_comments":{"href":"https://api.github.com/repos/kelseyhightower/confd/pulls/604/comments"},"review_comment":{"href":"https://api.github.com/repos/kelseyhightower/confd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kelseyhightower/confd/pulls/604/commits"},"statuses":{"href":"https://api.github.com/repos/kelseyhightower/confd/statuses/3e25a1966978b6167f8b1e709640fc09f46db57b"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":170,"deletions":42,"changed_files":2}}
{"actor":{"display_login":"jmooradi"}}