{"action":"created","issue":{"url":"https://api.github.com/repos/andres-montanez/Magallanes/issues/331","repository_url":"https://api.github.com/repos/andres-montanez/Magallanes","labels_url":"https://api.github.com/repos/andres-montanez/Magallanes/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/andres-montanez/Magallanes/issues/331/comments","events_url":"https://api.github.com/repos/andres-montanez/Magallanes/issues/331/events","html_url":"https://github.com/andres-montanez/Magallanes/issues/331","id":204614113,"number":331,"title":"Commit the composer.lock","user":{"login":"Toflar","id":481937,"avatar_url":"https://avatars.githubusercontent.com/u/481937?v=3","gravatar_id":"","url":"https://api.github.com/users/Toflar","html_url":"https://github.com/Toflar","followers_url":"https://api.github.com/users/Toflar/followers","following_url":"https://api.github.com/users/Toflar/following{/other_user}","gists_url":"https://api.github.com/users/Toflar/gists{/gist_id}","starred_url":"https://api.github.com/users/Toflar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toflar/subscriptions","organizations_url":"https://api.github.com/users/Toflar/orgs","repos_url":"https://api.github.com/users/Toflar/repos","events_url":"https://api.github.com/users/Toflar/events{/privacy}","received_events_url":"https://api.github.com/users/Toflar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-01T15:25:56Z","updated_at":"2017-02-03T00:35:47Z","closed_at":null,"body":"As this is a project, you should commit the `composer.lock` file. Cheers :)"},"comment":{"url":"https://api.github.com/repos/andres-montanez/Magallanes/issues/comments/277130587","html_url":"https://github.com/andres-montanez/Magallanes/issues/331#issuecomment-277130587","issue_url":"https://api.github.com/repos/andres-montanez/Magallanes/issues/331","id":277130587,"user":{"login":"andres-montanez","id":541125,"avatar_url":"https://avatars.githubusercontent.com/u/541125?v=3","gravatar_id":"","url":"https://api.github.com/users/andres-montanez","html_url":"https://github.com/andres-montanez","followers_url":"https://api.github.com/users/andres-montanez/followers","following_url":"https://api.github.com/users/andres-montanez/following{/other_user}","gists_url":"https://api.github.com/users/andres-montanez/gists{/gist_id}","starred_url":"https://api.github.com/users/andres-montanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andres-montanez/subscriptions","organizations_url":"https://api.github.com/users/andres-montanez/orgs","repos_url":"https://api.github.com/users/andres-montanez/repos","events_url":"https://api.github.com/users/andres-montanez/events{/privacy}","received_events_url":"https://api.github.com/users/andres-montanez/received_events","type":"User","site_admin":false},"created_at":"2017-02-03T00:35:47Z","updated_at":"2017-02-03T00:35:47Z","body":"Hi @Toflar , I had a bit of a debate with myself about this, I added it, then remove it, then added it and remove it again.\r\n\r\nI decided to keep it of the repo mainly because Magallanes is more close to a library than to an app (and the Composer documentation is indifferent regarding the lock in this case), and also without it we can ensure that the CI tests will run with the latests versions of the dependencies.\r\n\r\nWith the lock added the tests will run with those versions, but when Magallanes is used as a dependency those versions wont be taken into consideration, so in short we may end up running CI tests with outdated versions compared to the average user."}}
{"actor":{"display_login":"andres-montanez"}}