{"action":"created","comment":{"url":"https://api.github.com/repos/julianguyen/ifme/pulls/comments/124709305","pull_request_review_id":47022248,"id":124709305,"diff_hunk":"@@ -22,15 +22,19 @@ def show\n       end\n     else\n       @comment = Comment.new\n-      @comments = Comment.where(:commented_on => @meeting.id, :comment_type => \"meeting\").all.order(\"created_at DESC\")\n+      @comments = Comment.where(commented_on: @meeting.id, comment_type: 'meeting').all.order('created_at DESC')\n       @no_hide_page = true\n     end\n   end\n \n   def comment\n-    @comment = Comment.new(:comment_type => params[:comment_type], :commented_on => params[:commented_on], :comment_by => params[:comment_by], :comment => params[:comment], :visibility => 'all')\n+    @comment = Comment.new(comment_type: params[:comment_type], commented_on: params[:commented_on], comment_by: params[:comment_by], comment: params[:comment], visibility: 'all')\n \n-    if !@comment.save\n+    # TODO: it is quite unclear what the expected outcome is here. If nothing\n+    #       more should be done, then a return statement should be added. If\n+    #       the follow work should be performed, then the responce actions\n+    #       should be grouped at the end of the method\n+    unless @comment.save","path":"app/controllers/meetings_controller.rb","position":26,"original_position":26,"commit_id":"27dcb41bb09b17e708877ca0b1418dfbca782fd7","original_commit_id":"27dcb41bb09b17e708877ca0b1418dfbca782fd7","user":{"login":"julianguyen","id":3010728,"avatar_url":"https://avatars2.githubusercontent.com/u/3010728?v=3","gravatar_id":"","url":"https://api.github.com/users/julianguyen","html_url":"https://github.com/julianguyen","followers_url":"https://api.github.com/users/julianguyen/followers","following_url":"https://api.github.com/users/julianguyen/following{/other_user}","gists_url":"https://api.github.com/users/julianguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/julianguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianguyen/subscriptions","organizations_url":"https://api.github.com/users/julianguyen/orgs","repos_url":"https://api.github.com/users/julianguyen/repos","events_url":"https://api.github.com/users/julianguyen/events{/privacy}","received_events_url":"https://api.github.com/users/julianguyen/received_events","type":"User","site_admin":false},"body":"The expected outcome is to render `{ no_save: true }` to indicate that the comment was able to be saved. Otherwise, create notifications.","created_at":"2017-06-29T04:22:00Z","updated_at":"2017-06-29T04:24:47Z","html_url":"https://github.com/julianguyen/ifme/pull/469#discussion_r124709305","pull_request_url":"https://api.github.com/repos/julianguyen/ifme/pulls/469","_links":{"self":{"href":"https://api.github.com/repos/julianguyen/ifme/pulls/comments/124709305"},"html":{"href":"https://github.com/julianguyen/ifme/pull/469#discussion_r124709305"},"pull_request":{"href":"https://api.github.com/repos/julianguyen/ifme/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/julianguyen/ifme/pulls/469","id":127839496,"html_url":"https://github.com/julianguyen/ifme/pull/469","diff_url":"https://github.com/julianguyen/ifme/pull/469.diff","patch_url":"https://github.com/julianguyen/ifme/pull/469.patch","issue_url":"https://api.github.com/repos/julianguyen/ifme/issues/469","number":469,"state":"open","locked":false,"title":"Chore: Cop","user":{"login":"HashNotAdam","id":902714,"avatar_url":"https://avatars0.githubusercontent.com/u/902714?v=3","gravatar_id":"","url":"https://api.github.com/users/HashNotAdam","html_url":"https://github.com/HashNotAdam","followers_url":"https://api.github.com/users/HashNotAdam/followers","following_url":"https://api.github.com/users/HashNotAdam/following{/other_user}","gists_url":"https://api.github.com/users/HashNotAdam/gists{/gist_id}","starred_url":"https://api.github.com/users/HashNotAdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashNotAdam/subscriptions","organizations_url":"https://api.github.com/users/HashNotAdam/orgs","repos_url":"https://api.github.com/users/HashNotAdam/repos","events_url":"https://api.github.com/users/HashNotAdam/events{/privacy}","received_events_url":"https://api.github.com/users/HashNotAdam/received_events","type":"User","site_admin":false},"body":"This addresses only the most basic style guide violations. Once this has been agreed to, I'll start on the next level of refactoring.","created_at":"2017-06-28T04:19:41Z","updated_at":"2017-06-29T04:24:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54620857cd0ce15daa35ff641dde740c917c65a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/julianguyen/ifme/pulls/469/commits","review_comments_url":"https://api.github.com/repos/julianguyen/ifme/pulls/469/comments","review_comment_url":"https://api.github.com/repos/julianguyen/ifme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/julianguyen/ifme/issues/469/comments","statuses_url":"https://api.github.com/repos/julianguyen/ifme/statuses/27dcb41bb09b17e708877ca0b1418dfbca782fd7","head":{"label":"HashNotAdam:chore/cop","ref":"chore/cop","sha":"27dcb41bb09b17e708877ca0b1418dfbca782fd7","user":{"login":"HashNotAdam","id":902714,"avatar_url":"https://avatars0.githubusercontent.com/u/902714?v=3","gravatar_id":"","url":"https://api.github.com/users/HashNotAdam","html_url":"https://github.com/HashNotAdam","followers_url":"https://api.github.com/users/HashNotAdam/followers","following_url":"https://api.github.com/users/HashNotAdam/following{/other_user}","gists_url":"https://api.github.com/users/HashNotAdam/gists{/gist_id}","starred_url":"https://api.github.com/users/HashNotAdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashNotAdam/subscriptions","organizations_url":"https://api.github.com/users/HashNotAdam/orgs","repos_url":"https://api.github.com/users/HashNotAdam/repos","events_url":"https://api.github.com/users/HashNotAdam/events{/privacy}","received_events_url":"https://api.github.com/users/HashNotAdam/received_events","type":"User","site_admin":false},"repo":{"id":83262956,"name":"ifme","full_name":"HashNotAdam/ifme","owner":{"login":"HashNotAdam","id":902714,"avatar_url":"https://avatars0.githubusercontent.com/u/902714?v=3","gravatar_id":"","url":"https://api.github.com/users/HashNotAdam","html_url":"https://github.com/HashNotAdam","followers_url":"https://api.github.com/users/HashNotAdam/followers","following_url":"https://api.github.com/users/HashNotAdam/following{/other_user}","gists_url":"https://api.github.com/users/HashNotAdam/gists{/gist_id}","starred_url":"https://api.github.com/users/HashNotAdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashNotAdam/subscriptions","organizations_url":"https://api.github.com/users/HashNotAdam/orgs","repos_url":"https://api.github.com/users/HashNotAdam/repos","events_url":"https://api.github.com/users/HashNotAdam/events{/privacy}","received_events_url":"https://api.github.com/users/HashNotAdam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HashNotAdam/ifme","description":"Open source app to share mental health experiences with loved ones","fork":true,"url":"https://api.github.com/repos/HashNotAdam/ifme","forks_url":"https://api.github.com/repos/HashNotAdam/ifme/forks","keys_url":"https://api.github.com/repos/HashNotAdam/ifme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HashNotAdam/ifme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HashNotAdam/ifme/teams","hooks_url":"https://api.github.com/repos/HashNotAdam/ifme/hooks","issue_events_url":"https://api.github.com/repos/HashNotAdam/ifme/issues/events{/number}","events_url":"https://api.github.com/repos/HashNotAdam/ifme/events","assignees_url":"https://api.github.com/repos/HashNotAdam/ifme/assignees{/user}","branches_url":"https://api.github.com/repos/HashNotAdam/ifme/branches{/branch}","tags_url":"https://api.github.com/repos/HashNotAdam/ifme/tags","blobs_url":"https://api.github.com/repos/HashNotAdam/ifme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HashNotAdam/ifme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HashNotAdam/ifme/git/refs{/sha}","trees_url":"https://api.github.com/repos/HashNotAdam/ifme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HashNotAdam/ifme/statuses/{sha}","languages_url":"https://api.github.com/repos/HashNotAdam/ifme/languages","stargazers_url":"https://api.github.com/repos/HashNotAdam/ifme/stargazers","contributors_url":"https://api.github.com/repos/HashNotAdam/ifme/contributors","subscribers_url":"https://api.github.com/repos/HashNotAdam/ifme/subscribers","subscription_url":"https://api.github.com/repos/HashNotAdam/ifme/subscription","commits_url":"https://api.github.com/repos/HashNotAdam/ifme/commits{/sha}","git_commits_url":"https://api.github.com/repos/HashNotAdam/ifme/git/commits{/sha}","comments_url":"https://api.github.com/repos/HashNotAdam/ifme/comments{/number}","issue_comment_url":"https://api.github.com/repos/HashNotAdam/ifme/issues/comments{/number}","contents_url":"https://api.github.com/repos/HashNotAdam/ifme/contents/{+path}","compare_url":"https://api.github.com/repos/HashNotAdam/ifme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HashNotAdam/ifme/merges","archive_url":"https://api.github.com/repos/HashNotAdam/ifme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HashNotAdam/ifme/downloads","issues_url":"https://api.github.com/repos/HashNotAdam/ifme/issues{/number}","pulls_url":"https://api.github.com/repos/HashNotAdam/ifme/pulls{/number}","milestones_url":"https://api.github.com/repos/HashNotAdam/ifme/milestones{/number}","notifications_url":"https://api.github.com/repos/HashNotAdam/ifme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HashNotAdam/ifme/labels{/name}","releases_url":"https://api.github.com/repos/HashNotAdam/ifme/releases{/id}","deployments_url":"https://api.github.com/repos/HashNotAdam/ifme/deployments","created_at":"2017-02-27T03:11:11Z","updated_at":"2017-02-27T03:11:13Z","pushed_at":"2017-06-29T00:46:49Z","git_url":"git://github.com/HashNotAdam/ifme.git","ssh_url":"git@github.com:HashNotAdam/ifme.git","clone_url":"https://github.com/HashNotAdam/ifme.git","svn_url":"https://github.com/HashNotAdam/ifme","homepage":"http://www.if-me.org/","size":22715,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"julianguyen:master","ref":"master","sha":"d66f2b12ba69bf2d723e8c1b7c16b727e7833bbe","user":{"login":"julianguyen","id":3010728,"avatar_url":"https://avatars2.githubusercontent.com/u/3010728?v=3","gravatar_id":"","url":"https://api.github.com/users/julianguyen","html_url":"https://github.com/julianguyen","followers_url":"https://api.github.com/users/julianguyen/followers","following_url":"https://api.github.com/users/julianguyen/following{/other_user}","gists_url":"https://api.github.com/users/julianguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/julianguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianguyen/subscriptions","organizations_url":"https://api.github.com/users/julianguyen/orgs","repos_url":"https://api.github.com/users/julianguyen/repos","events_url":"https://api.github.com/users/julianguyen/events{/privacy}","received_events_url":"https://api.github.com/users/julianguyen/received_events","type":"User","site_admin":false},"repo":{"id":18935740,"name":"ifme","full_name":"julianguyen/ifme","owner":{"login":"julianguyen","id":3010728,"avatar_url":"https://avatars2.githubusercontent.com/u/3010728?v=3","gravatar_id":"","url":"https://api.github.com/users/julianguyen","html_url":"https://github.com/julianguyen","followers_url":"https://api.github.com/users/julianguyen/followers","following_url":"https://api.github.com/users/julianguyen/following{/other_user}","gists_url":"https://api.github.com/users/julianguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/julianguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianguyen/subscriptions","organizations_url":"https://api.github.com/users/julianguyen/orgs","repos_url":"https://api.github.com/users/julianguyen/repos","events_url":"https://api.github.com/users/julianguyen/events{/privacy}","received_events_url":"https://api.github.com/users/julianguyen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julianguyen/ifme","description":"Open source app to share mental health experiences with loved ones","fork":false,"url":"https://api.github.com/repos/julianguyen/ifme","forks_url":"https://api.github.com/repos/julianguyen/ifme/forks","keys_url":"https://api.github.com/repos/julianguyen/ifme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julianguyen/ifme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julianguyen/ifme/teams","hooks_url":"https://api.github.com/repos/julianguyen/ifme/hooks","issue_events_url":"https://api.github.com/repos/julianguyen/ifme/issues/events{/number}","events_url":"https://api.github.com/repos/julianguyen/ifme/events","assignees_url":"https://api.github.com/repos/julianguyen/ifme/assignees{/user}","branches_url":"https://api.github.com/repos/julianguyen/ifme/branches{/branch}","tags_url":"https://api.github.com/repos/julianguyen/ifme/tags","blobs_url":"https://api.github.com/repos/julianguyen/ifme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julianguyen/ifme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julianguyen/ifme/git/refs{/sha}","trees_url":"https://api.github.com/repos/julianguyen/ifme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julianguyen/ifme/statuses/{sha}","languages_url":"https://api.github.com/repos/julianguyen/ifme/languages","stargazers_url":"https://api.github.com/repos/julianguyen/ifme/stargazers","contributors_url":"https://api.github.com/repos/julianguyen/ifme/contributors","subscribers_url":"https://api.github.com/repos/julianguyen/ifme/subscribers","subscription_url":"https://api.github.com/repos/julianguyen/ifme/subscription","commits_url":"https://api.github.com/repos/julianguyen/ifme/commits{/sha}","git_commits_url":"https://api.github.com/repos/julianguyen/ifme/git/commits{/sha}","comments_url":"https://api.github.com/repos/julianguyen/ifme/comments{/number}","issue_comment_url":"https://api.github.com/repos/julianguyen/ifme/issues/comments{/number}","contents_url":"https://api.github.com/repos/julianguyen/ifme/contents/{+path}","compare_url":"https://api.github.com/repos/julianguyen/ifme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julianguyen/ifme/merges","archive_url":"https://api.github.com/repos/julianguyen/ifme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julianguyen/ifme/downloads","issues_url":"https://api.github.com/repos/julianguyen/ifme/issues{/number}","pulls_url":"https://api.github.com/repos/julianguyen/ifme/pulls{/number}","milestones_url":"https://api.github.com/repos/julianguyen/ifme/milestones{/number}","notifications_url":"https://api.github.com/repos/julianguyen/ifme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julianguyen/ifme/labels{/name}","releases_url":"https://api.github.com/repos/julianguyen/ifme/releases{/id}","deployments_url":"https://api.github.com/repos/julianguyen/ifme/deployments","created_at":"2014-04-19T06:58:25Z","updated_at":"2017-06-28T00:55:28Z","pushed_at":"2017-06-29T00:46:50Z","git_url":"git://github.com/julianguyen/ifme.git","ssh_url":"git@github.com:julianguyen/ifme.git","clone_url":"https://github.com/julianguyen/ifme.git","svn_url":"https://github.com/julianguyen/ifme","homepage":"http://www.if-me.org/","size":22624,"stargazers_count":223,"watchers_count":223,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":48,"forks":164,"open_issues":48,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/julianguyen/ifme/pulls/469"},"html":{"href":"https://github.com/julianguyen/ifme/pull/469"},"issue":{"href":"https://api.github.com/repos/julianguyen/ifme/issues/469"},"comments":{"href":"https://api.github.com/repos/julianguyen/ifme/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/julianguyen/ifme/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/julianguyen/ifme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/julianguyen/ifme/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/julianguyen/ifme/statuses/27dcb41bb09b17e708877ca0b1418dfbca782fd7"}}}}
{"actor":{"display_login":"julianguyen"}}