{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/121492009","pull_request_review_id":43523486,"id":121492009,"diff_hunk":"@@ -635,7 +635,8 @@ func newAdmissionChain(pluginNames []string, admissionConfigFilename string, plu\n \n \t\tcase serviceadmit.RestrictedEndpointsPluginName:\n \t\t\t// we need to set some customer parameters, so create by hand\n-\t\t\trestrictedNetworks, err := serviceadmit.ParseSimpleCIDRRules([]string{options.NetworkConfig.ClusterNetworkCIDR, options.NetworkConfig.ServiceNetworkCIDR})\n+\t\t\t// PLACEHOLDER HAVE TO FIGURE OUT OUT TO DO\n+\t\t\trestrictedNetworks, err := serviceadmit.ParseSimpleCIDRRules([]string{options.NetworkConfig.ServiceNetworkCIDR})","path":"pkg/cmd/server/origin/master_config.go","position":6,"original_position":6,"commit_id":"5dfee728981f8505f38229dcdc9c78149d37425f","original_commit_id":"5dfee728981f8505f38229dcdc9c78149d37425f","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars3.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"body":"You need to pass an array containing all of the clusternetwork cidr values and the servicenetwork cidr value","created_at":"2017-06-12T18:34:41Z","updated_at":"2017-06-12T18:54:02Z","html_url":"https://github.com/openshift/origin/pull/14558#discussion_r121492009","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/14558","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/121492009"},"html":{"href":"https://github.com/openshift/origin/pull/14558#discussion_r121492009"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/14558"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/14558","id":124926596,"html_url":"https://github.com/openshift/origin/pull/14558","diff_url":"https://github.com/openshift/origin/pull/14558.diff","patch_url":"https://github.com/openshift/origin/pull/14558.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/14558","number":14558,"state":"open","locked":false,"title":"[WIP Do Not Merge] multiple CIDR addresses ","user":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars3.githubusercontent.com/u/13948445?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"body":"Work in progress PR for multiple CIDR address work. addresses can be defined in the master config file by \r\n\r\n\r\n```\r\nnetworkConfig:\r\n  clusterNetworkCIDR: \"\"\r\n  clusterNetworkConfig:\r\n  - clusterNetworkCIDR: 10.128.0.0/28\r\n  - clusterNetworkCIDR: 12.128.0.0/28\r\n  externalIPNetworkCIDRs: null\r\n\r\n```\r\n\r\nor by passing a comma seporated list of them on the command line using --network-cidr=\"10.128.0.0/28,12.128.0.0/28\"\r\n\r\n\r\nbesides general review - I could use some feedback on how to do a few things \r\n\r\n- [ ] How should I deal with a config file that defined ClusterNetworkCIDR the old way?\r\n\r\n- [ ] In pkg/sdn/plugin/master.go there where checks to see if the cluster cidr was shrunk, I don't think that check is still required. It should be valid to break a large cluster cidr into it's smaller components. Is checking that all objects are allocated in defined places enough? As done by checkclusterobjects() in pkg/sdn/plugin/common.go\r\n\r\n- [x] I need to change oc get clusternetwork to show a comma separated list \r\n\r\n- [ ] finish the unit testing\r\n\r\n\r\nreview of the work so far and input on the above questions are appreciated \r\n@knobunc @dcbw @danwinship @rajatchopra \r\n\r\n\r\n\r\n","created_at":"2017-06-09T18:38:53Z","updated_at":"2017-06-12T18:54:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b840cd1be4441d36844ebf67587c31c4f0c27126","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/14558/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/14558/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/14558/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/5dfee728981f8505f38229dcdc9c78149d37425f","head":{"label":"JacobTanenbaum:CIDR-work","ref":"CIDR-work","sha":"5dfee728981f8505f38229dcdc9c78149d37425f","user":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars3.githubusercontent.com/u/13948445?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"repo":{"id":55235618,"name":"origin","full_name":"JacobTanenbaum/origin","owner":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars3.githubusercontent.com/u/13948445?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacobTanenbaum/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":true,"url":"https://api.github.com/repos/JacobTanenbaum/origin","forks_url":"https://api.github.com/repos/JacobTanenbaum/origin/forks","keys_url":"https://api.github.com/repos/JacobTanenbaum/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacobTanenbaum/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacobTanenbaum/origin/teams","hooks_url":"https://api.github.com/repos/JacobTanenbaum/origin/hooks","issue_events_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues/events{/number}","events_url":"https://api.github.com/repos/JacobTanenbaum/origin/events","assignees_url":"https://api.github.com/repos/JacobTanenbaum/origin/assignees{/user}","branches_url":"https://api.github.com/repos/JacobTanenbaum/origin/branches{/branch}","tags_url":"https://api.github.com/repos/JacobTanenbaum/origin/tags","blobs_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacobTanenbaum/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/JacobTanenbaum/origin/languages","stargazers_url":"https://api.github.com/repos/JacobTanenbaum/origin/stargazers","contributors_url":"https://api.github.com/repos/JacobTanenbaum/origin/contributors","subscribers_url":"https://api.github.com/repos/JacobTanenbaum/origin/subscribers","subscription_url":"https://api.github.com/repos/JacobTanenbaum/origin/subscription","commits_url":"https://api.github.com/repos/JacobTanenbaum/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacobTanenbaum/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacobTanenbaum/origin/contents/{+path}","compare_url":"https://api.github.com/repos/JacobTanenbaum/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacobTanenbaum/origin/merges","archive_url":"https://api.github.com/repos/JacobTanenbaum/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacobTanenbaum/origin/downloads","issues_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues{/number}","pulls_url":"https://api.github.com/repos/JacobTanenbaum/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/JacobTanenbaum/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/JacobTanenbaum/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacobTanenbaum/origin/labels{/name}","releases_url":"https://api.github.com/repos/JacobTanenbaum/origin/releases{/id}","deployments_url":"https://api.github.com/repos/JacobTanenbaum/origin/deployments","created_at":"2016-04-01T13:46:55Z","updated_at":"2016-04-01T13:47:03Z","pushed_at":"2017-06-09T20:04:37Z","git_url":"git://github.com/JacobTanenbaum/origin.git","ssh_url":"git@github.com:JacobTanenbaum/origin.git","clone_url":"https://github.com/JacobTanenbaum/origin.git","svn_url":"https://github.com/JacobTanenbaum/origin","homepage":"http://www.openshift.org","size":658801,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8844065495a4dffc9b82c544647f973e522ba664","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2017-06-12T16:57:43Z","pushed_at":"2017-06-12T18:50:36Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":667678,"stargazers_count":2941,"watchers_count":2941,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1961,"mirror_url":null,"open_issues_count":1335,"forks":1961,"open_issues":1335,"watchers":2941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/14558"},"html":{"href":"https://github.com/openshift/origin/pull/14558"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/14558"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/14558/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/14558/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/14558/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/5dfee728981f8505f38229dcdc9c78149d37425f"}}}}
{"actor":{"display_login":"danwinship"}}