{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/110896573","pull_request_review_id":32097835,"id":110896573,"diff_hunk":"@@ -108,17 +109,18 @@ func NewNode(datadir string, config *NodeConfig) (stack *Node, _ error) {\n \t}\n \t// Create the empty networking stack\n \tnodeConf := &node.Config{\n-\t\tName:             clientIdentifier,\n-\t\tVersion:          params.Version,\n-\t\tDataDir:          datadir,\n-\t\tKeyStoreDir:      filepath.Join(datadir, \"keystore\"), // Mobile should never use internal keystores!\n-\t\tNoDiscovery:      true,","path":"mobile/geth.go","position":26,"original_position":26,"commit_id":"fa260e7f65b3f81cb50683f44a076bab9d286c7e","original_commit_id":"fa260e7f65b3f81cb50683f44a076bab9d286c7e","user":{"login":"karalabe","id":129561,"avatar_url":"https://avatars1.githubusercontent.com/u/129561?v=3","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false},"body":"Didn't the NoDiscover get lost accidentally?","created_at":"2017-04-11T13:07:59Z","updated_at":"2017-04-11T13:18:07Z","html_url":"https://github.com/ethereum/go-ethereum/pull/13875#discussion_r110896573","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/110896573"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/13875#discussion_r110896573"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875","id":114646503,"html_url":"https://github.com/ethereum/go-ethereum/pull/13875","diff_url":"https://github.com/ethereum/go-ethereum/pull/13875.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/13875.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/13875","number":13875,"state":"open","locked":false,"title":"cmd/geth: add --config file flag","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars3.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"body":"In this PR, geth gets a new `--config <file>` option. The new option causes it to read configuration options from a file in TOML syntax. The implementation approach and motivation for it is described in https://twurst.com/articles/geth-config-file.html.","created_at":"2017-04-06T16:48:26Z","updated_at":"2017-04-11T13:18:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9df1c2b3449e8e1e31dad1788488033e9df3e47","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/28","html_url":"https://github.com/ethereum/go-ethereum/milestone/28","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/28/labels","id":1642558,"number":28,"title":"1.6.0","description":"","creator":{"login":"obscuren","id":6264126,"avatar_url":"https://avatars1.githubusercontent.com/u/6264126?v=3","gravatar_id":"","url":"https://api.github.com/users/obscuren","html_url":"https://github.com/obscuren","followers_url":"https://api.github.com/users/obscuren/followers","following_url":"https://api.github.com/users/obscuren/following{/other_user}","gists_url":"https://api.github.com/users/obscuren/gists{/gist_id}","starred_url":"https://api.github.com/users/obscuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obscuren/subscriptions","organizations_url":"https://api.github.com/users/obscuren/orgs","repos_url":"https://api.github.com/users/obscuren/repos","events_url":"https://api.github.com/users/obscuren/events{/privacy}","received_events_url":"https://api.github.com/users/obscuren/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":102,"state":"open","created_at":"2016-03-14T11:47:17Z","updated_at":"2017-04-11T09:40:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/13875/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/fa260e7f65b3f81cb50683f44a076bab9d286c7e","head":{"label":"fjl:config-wip","ref":"config-wip","sha":"fa260e7f65b3f81cb50683f44a076bab9d286c7e","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars3.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"repo":{"id":24951427,"name":"go-ethereum","full_name":"fjl/go-ethereum","owner":{"login":"fjl","id":6915,"avatar_url":"https://avatars3.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjl/go-ethereum","description":"Work fork of go-ethereum.","fork":true,"url":"https://api.github.com/repos/fjl/go-ethereum","forks_url":"https://api.github.com/repos/fjl/go-ethereum/forks","keys_url":"https://api.github.com/repos/fjl/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjl/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjl/go-ethereum/teams","hooks_url":"https://api.github.com/repos/fjl/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/fjl/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/fjl/go-ethereum/events","assignees_url":"https://api.github.com/repos/fjl/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/fjl/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/fjl/go-ethereum/tags","blobs_url":"https://api.github.com/repos/fjl/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjl/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjl/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjl/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjl/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/fjl/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/fjl/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/fjl/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/fjl/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/fjl/go-ethereum/subscription","commits_url":"https://api.github.com/repos/fjl/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjl/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjl/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjl/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/fjl/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/fjl/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjl/go-ethereum/merges","archive_url":"https://api.github.com/repos/fjl/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjl/go-ethereum/downloads","issues_url":"https://api.github.com/repos/fjl/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/fjl/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/fjl/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/fjl/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjl/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/fjl/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/fjl/go-ethereum/deployments","created_at":"2014-10-08T17:12:04Z","updated_at":"2015-05-29T23:48:03Z","pushed_at":"2017-04-11T11:31:50Z","git_url":"git://github.com/fjl/go-ethereum.git","ssh_url":"git@github.com:fjl/go-ethereum.git","clone_url":"https://github.com/fjl/go-ethereum.git","svn_url":"https://github.com/fjl/go-ethereum","homepage":"","size":79461,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"706a1e552c96bf75c60844c1dc28fc83778795fc","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2017-04-11T11:26:31Z","pushed_at":"2017-04-11T11:31:51Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":85611,"stargazers_count":3475,"watchers_count":3475,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1215,"mirror_url":null,"open_issues_count":312,"forks":1215,"open_issues":312,"watchers":3475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/13875"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/13875"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/13875/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/13875/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/fa260e7f65b3f81cb50683f44a076bab9d286c7e"}}}}
{"actor":{"display_login":"karalabe"}}