{"action":"created","issue":{"url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1628","repository_url":"https://api.github.com/repos/HerculesWS/Hercules","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1628/labels{/name}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1628/comments","events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1628/events","html_url":"https://github.com/HerculesWS/Hercules/pull/1628","id":213706540,"number":1628,"title":"Fixes #1626. Adds missed mapflags on instances.","user":{"login":"iRagno","id":17467874,"avatar_url":"https://avatars1.githubusercontent.com/u/17467874?v=3","gravatar_id":"","url":"https://api.github.com/users/iRagno","html_url":"https://github.com/iRagno","followers_url":"https://api.github.com/users/iRagno/followers","following_url":"https://api.github.com/users/iRagno/following{/other_user}","gists_url":"https://api.github.com/users/iRagno/gists{/gist_id}","starred_url":"https://api.github.com/users/iRagno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iRagno/subscriptions","organizations_url":"https://api.github.com/users/iRagno/orgs","repos_url":"https://api.github.com/users/iRagno/repos","events_url":"https://api.github.com/users/iRagno/events{/privacy}","received_events_url":"https://api.github.com/users/iRagno/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-13T09:00:19Z","updated_at":"2017-03-13T11:11:59Z","closed_at":"2017-03-13T10:17:27Z","pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1628","html_url":"https://github.com/HerculesWS/Hercules/pull/1628","diff_url":"https://github.com/HerculesWS/Hercules/pull/1628.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/1628.patch"},"body":"[//]: # (**********************************)\r\n[//]: # (** Fill in the following fields **)\r\n[//]: # (**********************************)\r\n\r\n[//]: # (Note: Lines beginning with syntax such as this one, are comments and will not be visible in your report!)\r\n\r\n### Pull Request Prelude\r\n\r\n[//]: # (Thank you for working on improving Hercules!)\r\n\r\n[//]: # (Please complete these steps and check the following boxes by putting an `x` inside the brackets _before_ filing your Pull Request.)\r\n\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\n\r\nAdds missing mapflags to some instances and move them into Memorial Dungeon Zone, making easier add mapflags to instances.\r\n\r\n**Affected Branches:** `master`\r\n\r\n**Issues addressed:** #1626 Instance Mapflags\r\n\r\n### Known Issues and TODO List\r\n\r\nNone\r\n\r\n[//]: # (**NOTE** Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request if you have not already enabled it.)\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/herculesws/hercules/1628)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments/286078617","html_url":"https://github.com/HerculesWS/Hercules/pull/1628#issuecomment-286078617","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1628","id":286078617,"user":{"login":"iRagno","id":17467874,"avatar_url":"https://avatars1.githubusercontent.com/u/17467874?v=3","gravatar_id":"","url":"https://api.github.com/users/iRagno","html_url":"https://github.com/iRagno","followers_url":"https://api.github.com/users/iRagno/followers","following_url":"https://api.github.com/users/iRagno/following{/other_user}","gists_url":"https://api.github.com/users/iRagno/gists{/gist_id}","starred_url":"https://api.github.com/users/iRagno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iRagno/subscriptions","organizations_url":"https://api.github.com/users/iRagno/orgs","repos_url":"https://api.github.com/users/iRagno/repos","events_url":"https://api.github.com/users/iRagno/events{/privacy}","received_events_url":"https://api.github.com/users/iRagno/received_events","type":"User","site_admin":false},"created_at":"2017-03-13T11:11:59Z","updated_at":"2017-03-13T11:11:59Z","body":"I had that doubt too when doing pr, @Emistry, but then I check mapflags field on map_zone_db uses tabs instead of spaces (checked it with GvG and PK Mode and Battleground zones, and since pvp mapflag seted on mapflag\\nopvp.txt file uses also tab and then argument, I leave it in that way."}}
{"actor":{"display_login":"iRagno"}}