{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/45348","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/45348/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/45348/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/45348/events","html_url":"https://github.com/rust-lang/rust/pull/45348","id":266323125,"number":45348,"title":"rustc: Add `_imp_` symbols later in compilation","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"labels":[{"id":583437191,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-bors","name":"S-waiting-on-bors","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-10-18T00:33:23Z","updated_at":"2017-10-21T01:59:38Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/45348","html_url":"https://github.com/rust-lang/rust/pull/45348","diff_url":"https://github.com/rust-lang/rust/pull/45348.diff","patch_url":"https://github.com/rust-lang/rust/pull/45348.patch"},"body":"On MSVC targets rustc will add symbols prefixed with `_imp_` to LLVM modules to\r\n\"emulate\" dllexported statics as that workaround is still in place after #27438\r\nhasn't been solved otherwise. These statics, however, were getting gc'd by\r\nThinLTO accidentally which later would cause linking failures.\r\n\r\nThis commit updates the location we add such symbols to happen just before\r\ncodegen to ensure that (a) they're not eliminated by the optimizer and (b) the\r\noptimizer doesn't even worry about them.\r\n\r\nCloses #45347"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/338356500","html_url":"https://github.com/rust-lang/rust/pull/45348#issuecomment-338356500","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/45348","id":338356500,"user":{"login":"bors","id":3372342,"avatar_url":"https://avatars2.githubusercontent.com/u/3372342?v=4","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"created_at":"2017-10-21T01:59:38Z","updated_at":"2017-10-21T01:59:38Z","author_association":"CONTRIBUTOR","body":":sunny: Test successful - [status-appveyor](https://ci.appveyor.com/project/rust-lang/rust/build/1.0.5072), [status-travis](https://travis-ci.org/rust-lang/rust/builds/290673702?utm_source=github_status&utm_medium=notification)\nApproved by: michaelwoerister\nPushing 6511b4f7ee19fbc2e0dd98fa65f23fa11fece722 to master..."}}
{"actor":{"display_login":"bors"}}