{"action":"created","issue":{"url":"https://api.github.com/repos/Miserlou/Zappa/issues/1022","repository_url":"https://api.github.com/repos/Miserlou/Zappa","labels_url":"https://api.github.com/repos/Miserlou/Zappa/issues/1022/labels{/name}","comments_url":"https://api.github.com/repos/Miserlou/Zappa/issues/1022/comments","events_url":"https://api.github.com/repos/Miserlou/Zappa/issues/1022/events","html_url":"https://github.com/Miserlou/Zappa/pull/1022","id":246350883,"number":1022,"title":"slim_handler reduce /tmp use and enable significantly larger deployments  ","user":{"login":"olirice","id":12958657,"avatar_url":"https://avatars3.githubusercontent.com/u/12958657?v=4","gravatar_id":"","url":"https://api.github.com/users/olirice","html_url":"https://github.com/olirice","followers_url":"https://api.github.com/users/olirice/followers","following_url":"https://api.github.com/users/olirice/following{/other_user}","gists_url":"https://api.github.com/users/olirice/gists{/gist_id}","starred_url":"https://api.github.com/users/olirice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olirice/subscriptions","organizations_url":"https://api.github.com/users/olirice/orgs","repos_url":"https://api.github.com/users/olirice/repos","events_url":"https://api.github.com/users/olirice/events{/privacy}","received_events_url":"https://api.github.com/users/olirice/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-07-28T13:42:08Z","updated_at":"2017-08-07T00:48:24Z","closed_at":"2017-08-07T00:48:24Z","pull_request":{"url":"https://api.github.com/repos/Miserlou/Zappa/pulls/1022","html_url":"https://github.com/Miserlou/Zappa/pull/1022","diff_url":"https://github.com/Miserlou/Zappa/pull/1022.diff","patch_url":"https://github.com/Miserlou/Zappa/pull/1022.patch"},"body":"<!--\r\n\r\nBefore you submit this PR, please make sure that you meet these criteria:\r\n\r\n* Did you read the [contributing guide](https://github.com/Miserlou/Zappa/#contributing)?\r\n\r\n* If this is a non-trivial commit, did you **open a ticket** for discussion?\r\n\r\n* Did you **put the URL for that ticket in a comment** in the code?\r\n\r\n* If you made a new function, did you **write a good docstring** for it?\r\n\r\n* Did you avoid putting \"_\" in front of your new function for no reason?\r\n\r\n* Did you write a test for your new code?\r\n\r\n* Did the Travis build pass?\r\n\r\n* Did you improve (or at least not significantly reduce)  the amount of code test coverage?\r\n\r\n* Did you **make sure this code actually works on Lambda**, as well as locally?\r\n\r\n* Did you test this code with both **Python 2.7** and **Python 3.6**? \r\n\r\nIf so, awesome! If not, please try to fix those issues before submitting your Pull Request.\r\n\r\nThank you for your contribution!\r\n\r\n-->\r\n\r\n## Description\r\n<!-- Please describe the changes included in this PR --> \r\nUpdated slim_handler behavior to:\r\n  - Delete project.zip after it has been extracted\r\n  - Enable significantly larger deployments (see #1020)\r\n\r\nPreviously:\r\n  - Download project.zip from s3 to /tmp\r\n  - Unzip project.zip to /tmp/project\r\n  - Do not delete project.zip\r\n\r\nNow:\r\n  - Download project.zip into an SpooledTemporaryFile\r\n       - SpooledTempfile is in-memory\r\n       - SpooledTempfile has a max_size based on the Lambda function's memory from an env var\r\n       - SpooledTempfile seamlessly dumps to /tmp and continues if max_size is exceeded (safe)\r\n       - SpooledTempfile deletes automatically once it falls out of scope\r\n   - Unzip project.zip to /tmp\r\n\r\n## GitHub Issues\r\n<!-- Proposed changes should be discussed in an issue before submitting a PR. -->\r\n<!-- Link to relevant tickets here. -->\r\n#1020\r\n#961\r\n#881 "},"comment":{"url":"https://api.github.com/repos/Miserlou/Zappa/issues/comments/320544149","html_url":"https://github.com/Miserlou/Zappa/pull/1022#issuecomment-320544149","issue_url":"https://api.github.com/repos/Miserlou/Zappa/issues/1022","id":320544149,"user":{"login":"olirice","id":12958657,"avatar_url":"https://avatars3.githubusercontent.com/u/12958657?v=4","gravatar_id":"","url":"https://api.github.com/users/olirice","html_url":"https://github.com/olirice","followers_url":"https://api.github.com/users/olirice/followers","following_url":"https://api.github.com/users/olirice/following{/other_user}","gists_url":"https://api.github.com/users/olirice/gists{/gist_id}","starred_url":"https://api.github.com/users/olirice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olirice/subscriptions","organizations_url":"https://api.github.com/users/olirice/orgs","repos_url":"https://api.github.com/users/olirice/repos","events_url":"https://api.github.com/users/olirice/events{/privacy}","received_events_url":"https://api.github.com/users/olirice/received_events","type":"User","site_admin":false},"created_at":"2017-08-07T00:48:24Z","updated_at":"2017-08-07T00:48:24Z","body":"Closing due to better solution at #1037"}}
{"actor":{"display_login":"olirice"}}