{"action":"closed","issue":{"url":"https://api.github.com/repos/socketio/socket.io/issues/2673","repository_url":"https://api.github.com/repos/socketio/socket.io","labels_url":"https://api.github.com/repos/socketio/socket.io/issues/2673/labels{/name}","comments_url":"https://api.github.com/repos/socketio/socket.io/issues/2673/comments","events_url":"https://api.github.com/repos/socketio/socket.io/issues/2673/events","html_url":"https://github.com/socketio/socket.io/issues/2673","id":176040397,"number":2673,"title":"Namespace.prototype.emit performance","user":{"login":"jorgemsrs","id":45540,"avatar_url":"https://avatars.githubusercontent.com/u/45540?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgemsrs","html_url":"https://github.com/jorgemsrs","followers_url":"https://api.github.com/users/jorgemsrs/followers","following_url":"https://api.github.com/users/jorgemsrs/following{/other_user}","gists_url":"https://api.github.com/users/jorgemsrs/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgemsrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgemsrs/subscriptions","organizations_url":"https://api.github.com/users/jorgemsrs/orgs","repos_url":"https://api.github.com/users/jorgemsrs/repos","events_url":"https://api.github.com/users/jorgemsrs/events{/privacy}","received_events_url":"https://api.github.com/users/jorgemsrs/received_events","type":"User","site_admin":false},"labels":[{"id":516855872,"url":"https://api.github.com/repos/socketio/socket.io/labels/Closed%20due%20to%20inactivity","name":"Closed due to inactivity","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-09T15:39:41Z","updated_at":"2017-01-12T16:57:20Z","closed_at":"2017-01-12T16:57:20Z","body":"Hello.\n\n`Namespace.prototype.emit` always checks if the data to emit is binary by calling `hasBin` and passing it to the adapter to broadcast.\n\nCan the `hasBin` check move to the adapter so it can be optimised for the case when we're emitting data for namespaces/rooms with no connected clients?\n\nI can help providing a merge request for this if you see value.\n\nCheers\n"}}
{"actor":{"display_login":"darrachequesne"}}