{"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/111186894","pull_request_review_id":32414607,"id":111186894,"diff_hunk":"@@ -302,17 +350,28 @@\n \t\t\t\t\tfilters: this._currentFilters\n \t\t\t\t});\n \t\t\t},\n-\t\t\t__onSearchResults: function(entity, moreUrlPath, hasMorePath) {\n+\t\t\t__onSearchResults: function(entity, moreUrlPath, hasMorePath, hasPath) {\n \t\t\t\tif (!entity.hasLinkByRel) {\n \t\t\t\t\tentity = this.parseEntity(entity);\n \t\t\t\t}\n \n+\t\t\t\tthis.set(hasPath, (entity.entities || []).length > 0);\n \t\t\t\tthis.set(hasMorePath, entity.hasLinkByRel('next'));\n \t\t\t\tthis.set(moreUrlPath, this[hasMorePath] ? entity.getLinkByRel('next').href : '');\n \t\t\t},\n \t\t\t_onDepartmentSearchResults: function(e) {\n+\t\t\t\tif (!this._departmentsLoaded) {\n+\t\t\t\t\t// If this is the first load, select the semester list after we've fetched the contents\n+\t\t\t\t\tthis._selectSemesterList();","path":"d2l-filter-menu-content/d2l-filter-menu-content-tabbed.html","position":163,"original_position":163,"commit_id":"fa586724c76d50e58b77f74418a50d84d5ac6076","original_commit_id":"fa586724c76d50e58b77f74418a50d84d5ac6076","user":{"login":"ryantmer","id":6231623,"avatar_url":"https://avatars0.githubusercontent.com/u/6231623?v=3","gravatar_id":"","url":"https://api.github.com/users/ryantmer","html_url":"https://github.com/ryantmer","followers_url":"https://api.github.com/users/ryantmer/followers","following_url":"https://api.github.com/users/ryantmer/following{/other_user}","gists_url":"https://api.github.com/users/ryantmer/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantmer/subscriptions","organizations_url":"https://api.github.com/users/ryantmer/orgs","repos_url":"https://api.github.com/users/ryantmer/repos","events_url":"https://api.github.com/users/ryantmer/events{/privacy}","received_events_url":"https://api.github.com/users/ryantmer/received_events","type":"User","site_admin":false},"body":"It's kind of awkward, but no - the intent here is to select the semester list the first time the menu is opened, after fetching both semesters and departments. It's a bit of a janky approach, and will look much nicer if I use the Promise-based `d2l-ajax` stuff, but didn't want to change that in this PR since it's a bit unrelated (and would be a bigger change than the other Promise-`d2l-ajax` change I did make in this PR)","created_at":"2017-04-12T15:44:10Z","updated_at":"2017-04-12T15:44:10Z","html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/358#discussion_r111186894","pull_request_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments/111186894"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/358#discussion_r111186894"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358","id":115173956,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/358","diff_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/358.diff","patch_url":"https://github.com/Brightspace/d2l-my-courses-ui/pull/358.patch","issue_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/358","number":358,"state":"open","locked":false,"title":"DE25540 - Always show filter menu; allow for new HM API routes","user":{"login":"ryantmer","id":6231623,"avatar_url":"https://avatars0.githubusercontent.com/u/6231623?v=3","gravatar_id":"","url":"https://api.github.com/users/ryantmer","html_url":"https://github.com/ryantmer","followers_url":"https://api.github.com/users/ryantmer/followers","following_url":"https://api.github.com/users/ryantmer/following{/other_user}","gists_url":"https://api.github.com/users/ryantmer/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantmer/subscriptions","organizations_url":"https://api.github.com/users/ryantmer/orgs","repos_url":"https://api.github.com/users/ryantmer/repos","events_url":"https://api.github.com/users/ryantmer/events{/privacy}","received_events_url":"https://api.github.com/users/ryantmer/received_events","type":"User","site_admin":false},"body":"Two main things being accomplished here:\r\n\r\n1. Always show the filter menu for all users, and display an empty-state message for those that don't have anything relevant to show.\r\n2. Use both old and new HM API routes - see https://git.dev.d2l/projects/CORE/repos/lp/pull-requests/5307/overview\r\n\r\nAcceptance Criteria:\r\n\r\n- Filter menu shows for all users, regardless of number of enrollments, or number of department/semester enrollments\r\n- Filter menu shows empty state message for users without any department/semester enrollments\r\n- Works with both master as well as the changes implemented in https://git.dev.d2l/projects/CORE/repos/lp/pull-requests/5307/overview (note that the returned results will differ slightly; this is intentional)","created_at":"2017-04-10T19:27:58Z","updated_at":"2017-04-12T15:44:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5ac9915bbe3dce156dd49fdaf40726dfa76ebf6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358/commits","review_comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358/comments","review_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/358/comments","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/fa586724c76d50e58b77f74418a50d84d5ac6076","head":{"label":"Brightspace:rmahler/DE25540","ref":"rmahler/DE25540","sha":"fa586724c76d50e58b77f74418a50d84d5ac6076","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars1.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars1.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-10-24T17:33:57Z","pushed_at":"2017-04-10T21:29:09Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":1126,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"9d279e3eb659bd69f2c6c6ce74512685dd79a5a3","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars1.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":54492398,"name":"d2l-my-courses-ui","full_name":"Brightspace/d2l-my-courses-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars1.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-my-courses-ui","description":null,"fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/deployments","created_at":"2016-03-22T16:48:09Z","updated_at":"2016-10-24T17:33:57Z","pushed_at":"2017-04-10T21:29:09Z","git_url":"git://github.com/Brightspace/d2l-my-courses-ui.git","ssh_url":"git@github.com:Brightspace/d2l-my-courses-ui.git","clone_url":"https://github.com/Brightspace/d2l-my-courses-ui.git","svn_url":"https://github.com/Brightspace/d2l-my-courses-ui","homepage":null,"size":1126,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358"},"html":{"href":"https://github.com/Brightspace/d2l-my-courses-ui/pull/358"},"issue":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/358"},"comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/statuses/fa586724c76d50e58b77f74418a50d84d5ac6076"}}}}
{"actor":{"display_login":"ryantmer"}}