{"action":"created","comment":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments/154233988","pull_request_review_id":80365398,"id":154233988,"diff_hunk":"@@ -146,34 +174,73 @@ QString Service::getKey(const QString &id)\n     return QString();\n }\n \n+QList<QString> Service::getKeys(const QString &id)\n+{\n+    QList<QString> keys;\n+    QList<Entry*> entries = getConfigEntries();\n+    for (Entry* config : entries) {\n+        keys << config->attributes()->value(QLatin1String(ASSOCIATE_KEY_PREFIX) + id);\n+    }\n+    return keys;\n+}\n+\n+bool Service::attributeExists(QList<Entry*> entries, const QString &attribute)\n+{\n+    for (Entry* entry: entries)","path":"src/http/Service.cpp","position":63,"original_position":63,"commit_id":"1797eec3c61487e8716426bde0953c097269c1f0","original_commit_id":"1797eec3c61487e8716426bde0953c097269c1f0","user":{"login":"weslly","id":107672,"avatar_url":"https://avatars2.githubusercontent.com/u/107672?v=4","gravatar_id":"","url":"https://api.github.com/users/weslly","html_url":"https://github.com/weslly","followers_url":"https://api.github.com/users/weslly/followers","following_url":"https://api.github.com/users/weslly/following{/other_user}","gists_url":"https://api.github.com/users/weslly/gists{/gist_id}","starred_url":"https://api.github.com/users/weslly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weslly/subscriptions","organizations_url":"https://api.github.com/users/weslly/orgs","repos_url":"https://api.github.com/users/weslly/repos","events_url":"https://api.github.com/users/weslly/events{/privacy}","received_events_url":"https://api.github.com/users/weslly/received_events","type":"User","site_admin":false},"body":"Missing braces on this `for` block.","created_at":"2017-11-30T23:42:21Z","updated_at":"2017-11-30T23:57:10Z","html_url":"https://github.com/keepassxreboot/keepassxc/pull/850#discussion_r154233988","pull_request_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments/154233988"},"html":{"href":"https://github.com/keepassxreboot/keepassxc/pull/850#discussion_r154233988"},"pull_request":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850"}}},"pull_request":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850","id":134315294,"html_url":"https://github.com/keepassxreboot/keepassxc/pull/850","diff_url":"https://github.com/keepassxreboot/keepassxc/pull/850.diff","patch_url":"https://github.com/keepassxreboot/keepassxc/pull/850.patch","issue_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850","number":850,"state":"open","locked":false,"title":"[WIP] Create new KeepassHTTP KeyAcceptDialog","user":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars2.githubusercontent.com/u/611471?v=4","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"body":"WIP - Creates a new dialog widget for accepting keys - needed for #838\r\n\r\nFor #838, #530\r\n\r\nThis is a proof-of-concept for myself that I can make changes to KeePassXC and a first step towards making some big changes to the KeepassHTTP authorization key management in order to address #838 and #530 and my own usability / workflow itches as someone who generally works with multiple databases open at the same time.\r\n\r\nPlease give this change a quick look and tell me if this is a good direction to go in, as well as anything problematic in the code I've changed (as far as it isn't a temporary mock-up / stub)\r\n\r\n## Description\r\n\r\nPlanned changes:\r\n* Fix #530 \r\n* Allow to select which database(s) to add a KeepassHTTP authorization key to. (#838)\r\n* Figure out if more information about the source of the authorization request can be taken from the KeepassHTTP connection and display it\r\n\r\n## Motivation and context\r\nSee #530, #838 \r\n\r\n## How has this been tested?\r\n\r\n* Not yet, WIP changes\r\n\r\n## Screenshots (if appropriate):\r\n\r\n![keepassnewkey](https://user-images.githubusercontent.com/611471/29000914-26f26c12-7abe-11e7-948b-da275d8a30d7.png)\r\n\r\n\r\n## Types of changes\r\n- ✅ Bug fix (non-breaking change which fixes an issue)\r\n- ✅ New feature (non-breaking change which adds functionality)\r\n- ✅ Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]**\r\n- ? My code follows the code style of this project. **[REQUIRED]**\r\n- X All new and existing tests passed. **[REQUIRED]**\r\n- X I have compiled and verified my code with `-DWITH_ASAN=ON`. **[REQUIRED]**\r\n- ? My change requires a change to the documentation and I have updated it accordingly.\r\n- X I have added tests to cover my changes.\r\n","created_at":"2017-08-06T05:47:35Z","updated_at":"2017-11-30T23:57:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d49e2ddfb2049e357cf35477a82b576675588b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones/3","html_url":"https://github.com/keepassxreboot/keepassxc/milestone/3","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones/3/labels","id":2252096,"number":3,"title":"v2.3.0","description":"Next major feature release. Introduce breaking features to include KDBX4 support, replace qhttp with qhttpengine, entry preview panel, ssh-agent support, merge improvements, improved CLI program, and many many bug fixes.","creator":{"login":"phoerious","id":911270,"avatar_url":"https://avatars1.githubusercontent.com/u/911270?v=4","gravatar_id":"","url":"https://api.github.com/users/phoerious","html_url":"https://github.com/phoerious","followers_url":"https://api.github.com/users/phoerious/followers","following_url":"https://api.github.com/users/phoerious/following{/other_user}","gists_url":"https://api.github.com/users/phoerious/gists{/gist_id}","starred_url":"https://api.github.com/users/phoerious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoerious/subscriptions","organizations_url":"https://api.github.com/users/phoerious/orgs","repos_url":"https://api.github.com/users/phoerious/repos","events_url":"https://api.github.com/users/phoerious/events{/privacy}","received_events_url":"https://api.github.com/users/phoerious/received_events","type":"User","site_admin":false},"open_issues":64,"closed_issues":99,"state":"open","created_at":"2017-01-14T20:32:36Z","updated_at":"2017-11-30T19:10:52Z","due_on":"2017-12-18T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/commits","review_comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/comments","review_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850/comments","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/1797eec3c61487e8716426bde0953c097269c1f0","head":{"label":"duk3luk3:feature/838-keepasshttp-keys","ref":"feature/838-keepasshttp-keys","sha":"1797eec3c61487e8716426bde0953c097269c1f0","user":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars2.githubusercontent.com/u/611471?v=4","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"repo":{"id":99460027,"name":"keepassxc","full_name":"duk3luk3/keepassxc","owner":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars2.githubusercontent.com/u/611471?v=4","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duk3luk3/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":true,"url":"https://api.github.com/repos/duk3luk3/keepassxc","forks_url":"https://api.github.com/repos/duk3luk3/keepassxc/forks","keys_url":"https://api.github.com/repos/duk3luk3/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duk3luk3/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duk3luk3/keepassxc/teams","hooks_url":"https://api.github.com/repos/duk3luk3/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/duk3luk3/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/duk3luk3/keepassxc/events","assignees_url":"https://api.github.com/repos/duk3luk3/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/duk3luk3/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/duk3luk3/keepassxc/tags","blobs_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duk3luk3/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/duk3luk3/keepassxc/languages","stargazers_url":"https://api.github.com/repos/duk3luk3/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/duk3luk3/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/duk3luk3/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/duk3luk3/keepassxc/subscription","commits_url":"https://api.github.com/repos/duk3luk3/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/duk3luk3/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/duk3luk3/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/duk3luk3/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/duk3luk3/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duk3luk3/keepassxc/merges","archive_url":"https://api.github.com/repos/duk3luk3/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duk3luk3/keepassxc/downloads","issues_url":"https://api.github.com/repos/duk3luk3/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/duk3luk3/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/duk3luk3/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/duk3luk3/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duk3luk3/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/duk3luk3/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/duk3luk3/keepassxc/deployments","created_at":"2017-08-06T02:41:29Z","updated_at":"2017-08-06T02:41:32Z","pushed_at":"2017-09-25T12:07:30Z","git_url":"git://github.com/duk3luk3/keepassxc.git","ssh_url":"git@github.com:duk3luk3/keepassxc.git","clone_url":"https://github.com/duk3luk3/keepassxc.git","svn_url":"https://github.com/duk3luk3/keepassxc","homepage":"https://keepassxc.org/","size":8722,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"keepassxreboot:develop","ref":"develop","sha":"8e8d9f39cb867b0d2ddce151f34d1c89d171a392","user":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"repo":{"id":52729242,"name":"keepassxc","full_name":"keepassxreboot/keepassxc","owner":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepassxreboot/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":false,"url":"https://api.github.com/repos/keepassxreboot/keepassxc","forks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/forks","keys_url":"https://api.github.com/repos/keepassxreboot/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepassxreboot/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepassxreboot/keepassxc/teams","hooks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/events","assignees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/keepassxreboot/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/tags","blobs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/keepassxreboot/keepassxc/languages","stargazers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscription","commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/keepassxreboot/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepassxreboot/keepassxc/merges","archive_url":"https://api.github.com/repos/keepassxreboot/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepassxreboot/keepassxc/downloads","issues_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/keepassxreboot/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/keepassxreboot/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/deployments","created_at":"2016-02-28T15:52:40Z","updated_at":"2017-11-30T22:52:05Z","pushed_at":"2017-11-30T19:39:00Z","git_url":"git://github.com/keepassxreboot/keepassxc.git","ssh_url":"git@github.com:keepassxreboot/keepassxc.git","clone_url":"https://github.com/keepassxreboot/keepassxc.git","svn_url":"https://github.com/keepassxreboot/keepassxc","homepage":"https://keepassxc.org/","size":9897,"stargazers_count":2692,"watchers_count":2692,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"archived":false,"open_issues_count":265,"license":null,"forks":189,"open_issues":265,"watchers":2692,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850"},"html":{"href":"https://github.com/keepassxreboot/keepassxc/pull/850"},"issue":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850"},"comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/1797eec3c61487e8716426bde0953c097269c1f0"}},"author_association":"NONE"}}
{"actor":{"display_login":"weslly"}}