{"action":"closed","number":656,"pull_request":{"url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/656","id":96784836,"html_url":"https://github.com/UW-Hydro/VIC/pull/656","diff_url":"https://github.com/UW-Hydro/VIC/pull/656.diff","patch_url":"https://github.com/UW-Hydro/VIC/pull/656.patch","issue_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/656","number":656,"state":"closed","locked":false,"title":"Improve Q12 calculation","user":{"login":"yixinmao","id":5818020,"avatar_url":"https://avatars.githubusercontent.com/u/5818020?v=3","gravatar_id":"","url":"https://api.github.com/users/yixinmao","html_url":"https://github.com/yixinmao","followers_url":"https://api.github.com/users/yixinmao/followers","following_url":"https://api.github.com/users/yixinmao/following{/other_user}","gists_url":"https://api.github.com/users/yixinmao/gists{/gist_id}","starred_url":"https://api.github.com/users/yixinmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yixinmao/subscriptions","organizations_url":"https://api.github.com/users/yixinmao/orgs","repos_url":"https://api.github.com/users/yixinmao/repos","events_url":"https://api.github.com/users/yixinmao/events{/privacy}","received_events_url":"https://api.github.com/users/yixinmao/received_events","type":"User","site_admin":false},"body":"Drainage from upper layer to adjacent lower layer is calculated by Brook & Corey curve (where drainage rate is a function of upper-layer soil moisture). Before this PR, a simple numerical solution is applied which uses the timestep-beginning upper-layer soil moisture to calculate drainage rate, and assume this constant rate over the entire timestep. This can cause unreasonably large drainage if the curve has a steep shape and when soil moisture is high.\r\n\r\nThis PR modify layer drainage (Q12) calculation - use exact integral (instead of numerical solution) in order to avoid unreasonably-strong soil moisture oscilation when the Brook & Corey curve is steep.\r\n\r\nThis PR should close issue #655 ","created_at":"2016-12-06T19:01:13Z","updated_at":"2017-01-09T20:49:05Z","closed_at":"2017-01-09T20:49:05Z","merged_at":"2017-01-09T20:49:05Z","merge_commit_sha":"739d20babbdd396490565185303906605862e5ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/656/commits","review_comments_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/656/comments","review_comment_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/656/comments","statuses_url":"https://api.github.com/repos/UW-Hydro/VIC/statuses/5760fe48c8e7f353c6a527cca5bbb650ddac9d43","head":{"label":"yixinmao:update_Q12_calculation_from_release5.0.0","ref":"update_Q12_calculation_from_release5.0.0","sha":"5760fe48c8e7f353c6a527cca5bbb650ddac9d43","user":{"login":"yixinmao","id":5818020,"avatar_url":"https://avatars.githubusercontent.com/u/5818020?v=3","gravatar_id":"","url":"https://api.github.com/users/yixinmao","html_url":"https://github.com/yixinmao","followers_url":"https://api.github.com/users/yixinmao/followers","following_url":"https://api.github.com/users/yixinmao/following{/other_user}","gists_url":"https://api.github.com/users/yixinmao/gists{/gist_id}","starred_url":"https://api.github.com/users/yixinmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yixinmao/subscriptions","organizations_url":"https://api.github.com/users/yixinmao/orgs","repos_url":"https://api.github.com/users/yixinmao/repos","events_url":"https://api.github.com/users/yixinmao/events{/privacy}","received_events_url":"https://api.github.com/users/yixinmao/received_events","type":"User","site_admin":false},"repo":{"id":14030286,"name":"VIC","full_name":"yixinmao/VIC","owner":{"login":"yixinmao","id":5818020,"avatar_url":"https://avatars.githubusercontent.com/u/5818020?v=3","gravatar_id":"","url":"https://api.github.com/users/yixinmao","html_url":"https://github.com/yixinmao","followers_url":"https://api.github.com/users/yixinmao/followers","following_url":"https://api.github.com/users/yixinmao/following{/other_user}","gists_url":"https://api.github.com/users/yixinmao/gists{/gist_id}","starred_url":"https://api.github.com/users/yixinmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yixinmao/subscriptions","organizations_url":"https://api.github.com/users/yixinmao/orgs","repos_url":"https://api.github.com/users/yixinmao/repos","events_url":"https://api.github.com/users/yixinmao/events{/privacy}","received_events_url":"https://api.github.com/users/yixinmao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yixinmao/VIC","description":"The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model","fork":true,"url":"https://api.github.com/repos/yixinmao/VIC","forks_url":"https://api.github.com/repos/yixinmao/VIC/forks","keys_url":"https://api.github.com/repos/yixinmao/VIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yixinmao/VIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yixinmao/VIC/teams","hooks_url":"https://api.github.com/repos/yixinmao/VIC/hooks","issue_events_url":"https://api.github.com/repos/yixinmao/VIC/issues/events{/number}","events_url":"https://api.github.com/repos/yixinmao/VIC/events","assignees_url":"https://api.github.com/repos/yixinmao/VIC/assignees{/user}","branches_url":"https://api.github.com/repos/yixinmao/VIC/branches{/branch}","tags_url":"https://api.github.com/repos/yixinmao/VIC/tags","blobs_url":"https://api.github.com/repos/yixinmao/VIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yixinmao/VIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yixinmao/VIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/yixinmao/VIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yixinmao/VIC/statuses/{sha}","languages_url":"https://api.github.com/repos/yixinmao/VIC/languages","stargazers_url":"https://api.github.com/repos/yixinmao/VIC/stargazers","contributors_url":"https://api.github.com/repos/yixinmao/VIC/contributors","subscribers_url":"https://api.github.com/repos/yixinmao/VIC/subscribers","subscription_url":"https://api.github.com/repos/yixinmao/VIC/subscription","commits_url":"https://api.github.com/repos/yixinmao/VIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/yixinmao/VIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/yixinmao/VIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/yixinmao/VIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/yixinmao/VIC/contents/{+path}","compare_url":"https://api.github.com/repos/yixinmao/VIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yixinmao/VIC/merges","archive_url":"https://api.github.com/repos/yixinmao/VIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yixinmao/VIC/downloads","issues_url":"https://api.github.com/repos/yixinmao/VIC/issues{/number}","pulls_url":"https://api.github.com/repos/yixinmao/VIC/pulls{/number}","milestones_url":"https://api.github.com/repos/yixinmao/VIC/milestones{/number}","notifications_url":"https://api.github.com/repos/yixinmao/VIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yixinmao/VIC/labels{/name}","releases_url":"https://api.github.com/repos/yixinmao/VIC/releases{/id}","deployments_url":"https://api.github.com/repos/yixinmao/VIC/deployments","created_at":"2013-10-31T22:50:53Z","updated_at":"2016-04-14T19:50:12Z","pushed_at":"2017-01-09T18:59:27Z","git_url":"git://github.com/yixinmao/VIC.git","ssh_url":"git@github.com:yixinmao/VIC.git","clone_url":"https://github.com/yixinmao/VIC.git","svn_url":"https://github.com/yixinmao/VIC","homepage":"http://www.hydro.washington.edu/Lettenmaier/Models/VIC/index.shtml","size":15498,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UW-Hydro:develop","ref":"develop","sha":"d1872e72936eda65c7f30effe2aa56a3e75f9e74","user":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars.githubusercontent.com/u/3475662?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"repo":{"id":8064928,"name":"VIC","full_name":"UW-Hydro/VIC","owner":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars.githubusercontent.com/u/3475662?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Hydro/VIC","description":"The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model","fork":false,"url":"https://api.github.com/repos/UW-Hydro/VIC","forks_url":"https://api.github.com/repos/UW-Hydro/VIC/forks","keys_url":"https://api.github.com/repos/UW-Hydro/VIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Hydro/VIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Hydro/VIC/teams","hooks_url":"https://api.github.com/repos/UW-Hydro/VIC/hooks","issue_events_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Hydro/VIC/events","assignees_url":"https://api.github.com/repos/UW-Hydro/VIC/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Hydro/VIC/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Hydro/VIC/tags","blobs_url":"https://api.github.com/repos/UW-Hydro/VIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Hydro/VIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Hydro/VIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Hydro/VIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Hydro/VIC/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Hydro/VIC/languages","stargazers_url":"https://api.github.com/repos/UW-Hydro/VIC/stargazers","contributors_url":"https://api.github.com/repos/UW-Hydro/VIC/contributors","subscribers_url":"https://api.github.com/repos/UW-Hydro/VIC/subscribers","subscription_url":"https://api.github.com/repos/UW-Hydro/VIC/subscription","commits_url":"https://api.github.com/repos/UW-Hydro/VIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Hydro/VIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Hydro/VIC/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Hydro/VIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Hydro/VIC/merges","archive_url":"https://api.github.com/repos/UW-Hydro/VIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Hydro/VIC/downloads","issues_url":"https://api.github.com/repos/UW-Hydro/VIC/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Hydro/VIC/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Hydro/VIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Hydro/VIC/labels{/name}","releases_url":"https://api.github.com/repos/UW-Hydro/VIC/releases{/id}","deployments_url":"https://api.github.com/repos/UW-Hydro/VIC/deployments","created_at":"2013-02-07T02:30:14Z","updated_at":"2017-01-04T21:55:52Z","pushed_at":"2017-01-09T20:49:05Z","git_url":"git://github.com/UW-Hydro/VIC.git","ssh_url":"git@github.com:UW-Hydro/VIC.git","clone_url":"https://github.com/UW-Hydro/VIC.git","svn_url":"https://github.com/UW-Hydro/VIC","homepage":"http://vic.readthedocs.io","size":21019,"stargazers_count":43,"watchers_count":43,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":67,"forks":130,"open_issues":67,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/656"},"html":{"href":"https://github.com/UW-Hydro/VIC/pull/656"},"issue":{"href":"https://api.github.com/repos/UW-Hydro/VIC/issues/656"},"comments":{"href":"https://api.github.com/repos/UW-Hydro/VIC/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Hydro/VIC/statuses/5760fe48c8e7f353c6a527cca5bbb650ddac9d43"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bartnijssen","id":1106706,"avatar_url":"https://avatars.githubusercontent.com/u/1106706?v=3","gravatar_id":"","url":"https://api.github.com/users/bartnijssen","html_url":"https://github.com/bartnijssen","followers_url":"https://api.github.com/users/bartnijssen/followers","following_url":"https://api.github.com/users/bartnijssen/following{/other_user}","gists_url":"https://api.github.com/users/bartnijssen/gists{/gist_id}","starred_url":"https://api.github.com/users/bartnijssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartnijssen/subscriptions","organizations_url":"https://api.github.com/users/bartnijssen/orgs","repos_url":"https://api.github.com/users/bartnijssen/repos","events_url":"https://api.github.com/users/bartnijssen/events{/privacy}","received_events_url":"https://api.github.com/users/bartnijssen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":35,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"bartnijssen"}}