{"action":"created","issue":{"url":"https://api.github.com/repos/vertexproject/synapse/issues/334","repository_url":"https://api.github.com/repos/vertexproject/synapse","labels_url":"https://api.github.com/repos/vertexproject/synapse/issues/334/labels{/name}","comments_url":"https://api.github.com/repos/vertexproject/synapse/issues/334/comments","events_url":"https://api.github.com/repos/vertexproject/synapse/issues/334/events","html_url":"https://github.com/vertexproject/synapse/issues/334","id":242123929,"number":334,"title":"Ingest subsystem does not apply tags to all relevant nodes","user":{"login":"therealsilence","id":26488667,"avatar_url":"https://avatars0.githubusercontent.com/u/26488667?v=4","gravatar_id":"","url":"https://api.github.com/users/therealsilence","html_url":"https://github.com/therealsilence","followers_url":"https://api.github.com/users/therealsilence/followers","following_url":"https://api.github.com/users/therealsilence/following{/other_user}","gists_url":"https://api.github.com/users/therealsilence/gists{/gist_id}","starred_url":"https://api.github.com/users/therealsilence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealsilence/subscriptions","organizations_url":"https://api.github.com/users/therealsilence/orgs","repos_url":"https://api.github.com/users/therealsilence/repos","events_url":"https://api.github.com/users/therealsilence/events{/privacy}","received_events_url":"https://api.github.com/users/therealsilence/received_events","type":"User","site_admin":false},"labels":[{"id":645406424,"url":"https://api.github.com/repos/vertexproject/synapse/labels/needs%20triage","name":"needs triage","color":"39FF14","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-11T17:25:29Z","updated_at":"2017-08-30T12:56:14Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"When requesting application of a tag based on a secondary property via an ingest file (ingest.json), the ingest subsystem does not apply the tag to all relevant nodes.\r\n\r\nSpecifically, file:bytes nodes can be created based on knowledge of an individual hash (md5, sha1, sha256, etc) in the absence of actual file bytes (results in a file:bytes node with a single secondary \"hash\" property) as well as based on the actual file bytes (in which case all hashes can be calculated and are present as secondary props).\r\n\r\nAddtag() from the command line correctly applies a tag to all relevant nodes:\r\n```\r\ncli> ask file:bytes:sha256=027cc450ef5f8c5f653329641ec1fed91f694e0d229928963b30f6b0d7d3a745 [ #thesilence.testtag ]\r\nfile:bytes = 12eb3d4c3f2264b7056bcf6ebaf7e88d\r\n    #thesilence.testtag (added 2017/07/11 17:08:32.798)\r\nfile:bytes = e090d1364d34aa8de6fe6db99e9855ac\r\n    #thesilence.testtag (added 2017/07/11 17:08:33.074)\r\n(2 results)\r\n```\r\n\r\nRequesting a tag addition from an ingest.json file applies the tag to one node only (seems to favor the node based on actual bytes vs a single-hash node):\r\nIngest file (snippet):\r\n```\r\n \"tags\":[  \"thesilence.mytest\"  ],\r\n\r\n\"nodes\":[\r\n    [\"file:bytes:sha256\", [ \"027cc450ef5f8c5f653329641ec1fed91f694e0d229928963b30f6b0d7d3a745\" ]]\r\n             ]\r\n```\r\nStorm query following ingest:\r\n```\r\ncli> ask file:bytes:sha256=027cc450ef5f8c5f653329641ec1fed91f694e0d229928963b30f6b0d7d3a745\r\nfile:bytes = 12eb3d4c3f2264b7056bcf6ebaf7e88d\r\n    #thesilence.testtag (added 2017/07/11 17:08:32.798)\r\nfile:bytes = e090d1364d34aa8de6fe6db99e9855ac\r\n    #thesilence.mytest (added 2017/07/11 17:11:09.352)\r\n    #thesilence.testtag (added 2017/07/11 17:08:33.074)\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/vertexproject/synapse/issues/comments/325981420","html_url":"https://github.com/vertexproject/synapse/issues/334#issuecomment-325981420","issue_url":"https://api.github.com/repos/vertexproject/synapse/issues/334","id":325981420,"user":{"login":"vEpiphyte","id":26100278,"avatar_url":"https://avatars2.githubusercontent.com/u/26100278?v=4","gravatar_id":"","url":"https://api.github.com/users/vEpiphyte","html_url":"https://github.com/vEpiphyte","followers_url":"https://api.github.com/users/vEpiphyte/followers","following_url":"https://api.github.com/users/vEpiphyte/following{/other_user}","gists_url":"https://api.github.com/users/vEpiphyte/gists{/gist_id}","starred_url":"https://api.github.com/users/vEpiphyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vEpiphyte/subscriptions","organizations_url":"https://api.github.com/users/vEpiphyte/orgs","repos_url":"https://api.github.com/users/vEpiphyte/repos","events_url":"https://api.github.com/users/vEpiphyte/events{/privacy}","received_events_url":"https://api.github.com/users/vEpiphyte/received_events","type":"User","site_admin":false},"created_at":"2017-08-30T12:56:14Z","updated_at":"2017-08-30T12:56:14Z","author_association":"CONTRIBUTOR","body":"@therealsilence The problem described in this issue appears to have been the result of #347.  However, we still have the issue where secondary nodes created as a result of the primary node are NOT tagged by the ingest defined tag .  I'm not certain if there is a way to do that which does negatively impact on the performance of the ingest subsystem; or result in significant changes to other Cortex APIs."}}
{"actor":{"display_login":"vEpiphyte"}}