{"action":"created","comment":{"url":"https://api.github.com/repos/kubic-project/salt/pulls/comments/113441503","pull_request_review_id":34829026,"id":113441503,"diff_hunk":"@@ -0,0 +1,14 @@\n+{%- for minion_id, addrlist in salt['mine.get']('roles:kube-master', 'network.ip_addrs', 'grain').items() %}\n+{{ minion_id }}-host-entry:\n+  host.present:\n+{% if addrlist is string %}\n+    - ip: {{ addrlist }}\n+{% else %}\n+    - ip: {{ addrlist|first }}\n+{% endif %}\n+    - names:\n+      - api\n+      - api.{{ pillar['internal_infra_domain'] }}\n+      - {{ minion_id }}\n+      - {{ minion_id }}.{{ pillar['internal_infra_domain'] }}\n+{% endfor %}","path":"salt/hosts-minion/init.sls","position":14,"original_position":14,"commit_id":"d86de0f1d423e207a7922ab648e7d4dd4cfc5d05","original_commit_id":"bc1a216e5ac01ebefcd258a00a3eb3971af32e0d","user":{"login":"grahamhayes","id":122395,"avatar_url":"https://avatars0.githubusercontent.com/u/122395?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamhayes","html_url":"https://github.com/grahamhayes","followers_url":"https://api.github.com/users/grahamhayes/followers","following_url":"https://api.github.com/users/grahamhayes/following{/other_user}","gists_url":"https://api.github.com/users/grahamhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamhayes/subscriptions","organizations_url":"https://api.github.com/users/grahamhayes/orgs","repos_url":"https://api.github.com/users/grahamhayes/repos","events_url":"https://api.github.com/users/grahamhayes/events{/privacy}","received_events_url":"https://api.github.com/users/grahamhayes/received_events","type":"User","site_admin":false},"body":"That is a massive overstatement - this can be used in a multi master cluster, just only using one API server.\r\n\r\nIf we have enough worker nodes to DoS our API, other things in the cluster are going to fall over first.\r\n\r\nThis is not a problem, and will not be a problem for the foreseeable future, at which point a lot of how we do the system set will have changed.","created_at":"2017-04-26T12:47:44Z","updated_at":"2017-04-26T12:47:44Z","html_url":"https://github.com/kubic-project/salt/pull/44#discussion_r113441503","pull_request_url":"https://api.github.com/repos/kubic-project/salt/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/comments/113441503"},"html":{"href":"https://github.com/kubic-project/salt/pull/44#discussion_r113441503"},"pull_request":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/kubic-project/salt/pulls/44","id":117469590,"html_url":"https://github.com/kubic-project/salt/pull/44","diff_url":"https://github.com/kubic-project/salt/pull/44.diff","patch_url":"https://github.com/kubic-project/salt/pull/44.patch","issue_url":"https://api.github.com/repos/kubic-project/salt/issues/44","number":44,"state":"open","locked":false,"title":"Render /etc/hosts on all nodes","user":{"login":"grahamhayes","id":122395,"avatar_url":"https://avatars0.githubusercontent.com/u/122395?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamhayes","html_url":"https://github.com/grahamhayes","followers_url":"https://api.github.com/users/grahamhayes/followers","following_url":"https://api.github.com/users/grahamhayes/following{/other_user}","gists_url":"https://api.github.com/users/grahamhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamhayes/subscriptions","organizations_url":"https://api.github.com/users/grahamhayes/orgs","repos_url":"https://api.github.com/users/grahamhayes/repos","events_url":"https://api.github.com/users/grahamhayes/events{/privacy}","received_events_url":"https://api.github.com/users/grahamhayes/received_events","type":"User","site_admin":false},"body":"Render `/etc/hosts` with the machine IDs for all other hosts in the cluster.","created_at":"2017-04-25T12:14:57Z","updated_at":"2017-04-26T12:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21b175c75122e6fc304c354a4c8213baf44beb7e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubic-project/salt/pulls/44/commits","review_comments_url":"https://api.github.com/repos/kubic-project/salt/pulls/44/comments","review_comment_url":"https://api.github.com/repos/kubic-project/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubic-project/salt/issues/44/comments","statuses_url":"https://api.github.com/repos/kubic-project/salt/statuses/d86de0f1d423e207a7922ab648e7d4dd4cfc5d05","head":{"label":"kubic-project:etc-hosts-generation","ref":"etc-hosts-generation","sha":"d86de0f1d423e207a7922ab648e7d4dd4cfc5d05","user":{"login":"kubic-project","id":25507587,"avatar_url":"https://avatars1.githubusercontent.com/u/25507587?v=3","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"repo":{"id":83561000,"name":"salt","full_name":"kubic-project/salt","owner":{"login":"kubic-project","id":25507587,"avatar_url":"https://avatars1.githubusercontent.com/u/25507587?v=3","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubic-project/salt","description":"A collection of salt states used to provision a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubic-project/salt","forks_url":"https://api.github.com/repos/kubic-project/salt/forks","keys_url":"https://api.github.com/repos/kubic-project/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubic-project/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubic-project/salt/teams","hooks_url":"https://api.github.com/repos/kubic-project/salt/hooks","issue_events_url":"https://api.github.com/repos/kubic-project/salt/issues/events{/number}","events_url":"https://api.github.com/repos/kubic-project/salt/events","assignees_url":"https://api.github.com/repos/kubic-project/salt/assignees{/user}","branches_url":"https://api.github.com/repos/kubic-project/salt/branches{/branch}","tags_url":"https://api.github.com/repos/kubic-project/salt/tags","blobs_url":"https://api.github.com/repos/kubic-project/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubic-project/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubic-project/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubic-project/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubic-project/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubic-project/salt/languages","stargazers_url":"https://api.github.com/repos/kubic-project/salt/stargazers","contributors_url":"https://api.github.com/repos/kubic-project/salt/contributors","subscribers_url":"https://api.github.com/repos/kubic-project/salt/subscribers","subscription_url":"https://api.github.com/repos/kubic-project/salt/subscription","commits_url":"https://api.github.com/repos/kubic-project/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubic-project/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubic-project/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubic-project/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubic-project/salt/contents/{+path}","compare_url":"https://api.github.com/repos/kubic-project/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubic-project/salt/merges","archive_url":"https://api.github.com/repos/kubic-project/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubic-project/salt/downloads","issues_url":"https://api.github.com/repos/kubic-project/salt/issues{/number}","pulls_url":"https://api.github.com/repos/kubic-project/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubic-project/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubic-project/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubic-project/salt/labels{/name}","releases_url":"https://api.github.com/repos/kubic-project/salt/releases{/id}","deployments_url":"https://api.github.com/repos/kubic-project/salt/deployments","created_at":"2017-03-01T14:04:14Z","updated_at":"2017-04-04T15:36:44Z","pushed_at":"2017-04-26T12:05:52Z","git_url":"git://github.com/kubic-project/salt.git","ssh_url":"git@github.com:kubic-project/salt.git","clone_url":"https://github.com/kubic-project/salt.git","svn_url":"https://github.com/kubic-project/salt","homepage":null,"size":250,"stargazers_count":13,"watchers_count":13,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":13,"default_branch":"master"}},"base":{"label":"kubic-project:master","ref":"master","sha":"46cff0e73bc365ca84971c2741b8e2e580c83a24","user":{"login":"kubic-project","id":25507587,"avatar_url":"https://avatars1.githubusercontent.com/u/25507587?v=3","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"repo":{"id":83561000,"name":"salt","full_name":"kubic-project/salt","owner":{"login":"kubic-project","id":25507587,"avatar_url":"https://avatars1.githubusercontent.com/u/25507587?v=3","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubic-project/salt","description":"A collection of salt states used to provision a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubic-project/salt","forks_url":"https://api.github.com/repos/kubic-project/salt/forks","keys_url":"https://api.github.com/repos/kubic-project/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubic-project/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubic-project/salt/teams","hooks_url":"https://api.github.com/repos/kubic-project/salt/hooks","issue_events_url":"https://api.github.com/repos/kubic-project/salt/issues/events{/number}","events_url":"https://api.github.com/repos/kubic-project/salt/events","assignees_url":"https://api.github.com/repos/kubic-project/salt/assignees{/user}","branches_url":"https://api.github.com/repos/kubic-project/salt/branches{/branch}","tags_url":"https://api.github.com/repos/kubic-project/salt/tags","blobs_url":"https://api.github.com/repos/kubic-project/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubic-project/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubic-project/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubic-project/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubic-project/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubic-project/salt/languages","stargazers_url":"https://api.github.com/repos/kubic-project/salt/stargazers","contributors_url":"https://api.github.com/repos/kubic-project/salt/contributors","subscribers_url":"https://api.github.com/repos/kubic-project/salt/subscribers","subscription_url":"https://api.github.com/repos/kubic-project/salt/subscription","commits_url":"https://api.github.com/repos/kubic-project/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubic-project/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubic-project/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubic-project/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubic-project/salt/contents/{+path}","compare_url":"https://api.github.com/repos/kubic-project/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubic-project/salt/merges","archive_url":"https://api.github.com/repos/kubic-project/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubic-project/salt/downloads","issues_url":"https://api.github.com/repos/kubic-project/salt/issues{/number}","pulls_url":"https://api.github.com/repos/kubic-project/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubic-project/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubic-project/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubic-project/salt/labels{/name}","releases_url":"https://api.github.com/repos/kubic-project/salt/releases{/id}","deployments_url":"https://api.github.com/repos/kubic-project/salt/deployments","created_at":"2017-03-01T14:04:14Z","updated_at":"2017-04-04T15:36:44Z","pushed_at":"2017-04-26T12:05:52Z","git_url":"git://github.com/kubic-project/salt.git","ssh_url":"git@github.com:kubic-project/salt.git","clone_url":"https://github.com/kubic-project/salt.git","svn_url":"https://github.com/kubic-project/salt","homepage":null,"size":250,"stargazers_count":13,"watchers_count":13,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/44"},"html":{"href":"https://github.com/kubic-project/salt/pull/44"},"issue":{"href":"https://api.github.com/repos/kubic-project/salt/issues/44"},"comments":{"href":"https://api.github.com/repos/kubic-project/salt/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubic-project/salt/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/kubic-project/salt/statuses/d86de0f1d423e207a7922ab648e7d4dd4cfc5d05"}}}}
{"actor":{"display_login":"grahamhayes"}}