{"action":"created","comment":{"url":"https://api.github.com/repos/ciao-project/ciao/pulls/comments/153012471","pull_request_review_id":78967240,"id":153012471,"diff_hunk":"@@ -2497,15 +2497,13 @@ func (ds *Datastore) UnMapExternalIP(address string) error {\n \n // GenerateCNCIWorkload is used to create a workload definition for the CNCI.\n // This function should be called prior to any workload launch.\n-func (ds *Datastore) GenerateCNCIWorkload(vcpus int, memMB int, diskMB int, key string, password string) {\n+func (ds *Datastore) GenerateCNCIWorkload(vcpus int, memMB int, diskMB int, key string) {\n \t// generate the CNCI workload.\n \tconfig := `---\n #cloud-config\n users:\n   - name: cloud-admin\n     gecos: CIAO Cloud Admin\n-    lock-passwd: false","path":"ciao-controller/internal/datastore/datastore.go","position":12,"original_position":12,"commit_id":"b2d58e6de0b86c9f09604cf3b54572bda41a6436","original_commit_id":"b2d58e6de0b86c9f09604cf3b54572bda41a6436","user":{"login":"markdryan","id":984073,"avatar_url":"https://avatars3.githubusercontent.com/u/984073?v=4","gravatar_id":"","url":"https://api.github.com/users/markdryan","html_url":"https://github.com/markdryan","followers_url":"https://api.github.com/users/markdryan/followers","following_url":"https://api.github.com/users/markdryan/following{/other_user}","gists_url":"https://api.github.com/users/markdryan/gists{/gist_id}","starred_url":"https://api.github.com/users/markdryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdryan/subscriptions","organizations_url":"https://api.github.com/users/markdryan/orgs","repos_url":"https://api.github.com/users/markdryan/repos","events_url":"https://api.github.com/users/markdryan/events{/privacy}","received_events_url":"https://api.github.com/users/markdryan/received_events","type":"User","site_admin":false},"body":"I think we should set this explicitly to true otherwise ucd wont lock the password","created_at":"2017-11-24T17:49:51Z","updated_at":"2017-11-24T17:49:51Z","html_url":"https://github.com/ciao-project/ciao/pull/1598#discussion_r153012471","pull_request_url":"https://api.github.com/repos/ciao-project/ciao/pulls/1598","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ciao-project/ciao/pulls/comments/153012471"},"html":{"href":"https://github.com/ciao-project/ciao/pull/1598#discussion_r153012471"},"pull_request":{"href":"https://api.github.com/repos/ciao-project/ciao/pulls/1598"}}},"pull_request":{"url":"https://api.github.com/repos/ciao-project/ciao/pulls/1598","id":154590842,"html_url":"https://github.com/ciao-project/ciao/pull/1598","diff_url":"https://github.com/ciao-project/ciao/pull/1598.diff","patch_url":"https://github.com/ciao-project/ciao/pull/1598.patch","issue_url":"https://api.github.com/repos/ciao-project/ciao/issues/1598","number":1598,"state":"open","locked":false,"title":"Remove CNCI admin password","user":{"login":"rbradford","id":588224,"avatar_url":"https://avatars0.githubusercontent.com/u/588224?v=4","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"body":"Remove admin password for CNCI. The admin can provide an SSH key and get passwordless sudo anyway. This fixes a security issue where not specifying a password would set it to \"ciao\" and allow access.","created_at":"2017-11-24T17:40:07Z","updated_at":"2017-11-24T17:49:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7e05028142fedfee35e91cdb3f67cf6ea377c31","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciao-project/ciao/pulls/1598/commits","review_comments_url":"https://api.github.com/repos/ciao-project/ciao/pulls/1598/comments","review_comment_url":"https://api.github.com/repos/ciao-project/ciao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciao-project/ciao/issues/1598/comments","statuses_url":"https://api.github.com/repos/ciao-project/ciao/statuses/b2d58e6de0b86c9f09604cf3b54572bda41a6436","head":{"label":"rbradford:remove-cnci-password","ref":"remove-cnci-password","sha":"b2d58e6de0b86c9f09604cf3b54572bda41a6436","user":{"login":"rbradford","id":588224,"avatar_url":"https://avatars0.githubusercontent.com/u/588224?v=4","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"repo":{"id":67804093,"name":"ciao","full_name":"rbradford/ciao","owner":{"login":"rbradford","id":588224,"avatar_url":"https://avatars0.githubusercontent.com/u/588224?v=4","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbradford/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":true,"url":"https://api.github.com/repos/rbradford/ciao","forks_url":"https://api.github.com/repos/rbradford/ciao/forks","keys_url":"https://api.github.com/repos/rbradford/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbradford/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbradford/ciao/teams","hooks_url":"https://api.github.com/repos/rbradford/ciao/hooks","issue_events_url":"https://api.github.com/repos/rbradford/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/rbradford/ciao/events","assignees_url":"https://api.github.com/repos/rbradford/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/rbradford/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/rbradford/ciao/tags","blobs_url":"https://api.github.com/repos/rbradford/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbradford/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbradford/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbradford/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbradford/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/rbradford/ciao/languages","stargazers_url":"https://api.github.com/repos/rbradford/ciao/stargazers","contributors_url":"https://api.github.com/repos/rbradford/ciao/contributors","subscribers_url":"https://api.github.com/repos/rbradford/ciao/subscribers","subscription_url":"https://api.github.com/repos/rbradford/ciao/subscription","commits_url":"https://api.github.com/repos/rbradford/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbradford/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbradford/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbradford/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbradford/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/rbradford/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbradford/ciao/merges","archive_url":"https://api.github.com/repos/rbradford/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbradford/ciao/downloads","issues_url":"https://api.github.com/repos/rbradford/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/rbradford/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/rbradford/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/rbradford/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbradford/ciao/labels{/name}","releases_url":"https://api.github.com/repos/rbradford/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/rbradford/ciao/deployments","created_at":"2016-09-09T14:07:04Z","updated_at":"2016-09-09T14:07:06Z","pushed_at":"2017-11-24T17:40:46Z","git_url":"git://github.com/rbradford/ciao.git","ssh_url":"git@github.com:rbradford/ciao.git","clone_url":"https://github.com/rbradford/ciao.git","svn_url":"https://github.com/rbradford/ciao","homepage":"","size":12915,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciao-project:master","ref":"master","sha":"9ebe36f6c5befe52b1caad4da8ea8dd4a1112035","user":{"login":"ciao-project","id":31866473,"avatar_url":"https://avatars2.githubusercontent.com/u/31866473?v=4","gravatar_id":"","url":"https://api.github.com/users/ciao-project","html_url":"https://github.com/ciao-project","followers_url":"https://api.github.com/users/ciao-project/followers","following_url":"https://api.github.com/users/ciao-project/following{/other_user}","gists_url":"https://api.github.com/users/ciao-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ciao-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciao-project/subscriptions","organizations_url":"https://api.github.com/users/ciao-project/orgs","repos_url":"https://api.github.com/users/ciao-project/repos","events_url":"https://api.github.com/users/ciao-project/events{/privacy}","received_events_url":"https://api.github.com/users/ciao-project/received_events","type":"Organization","site_admin":false},"repo":{"id":54660486,"name":"ciao","full_name":"ciao-project/ciao","owner":{"login":"ciao-project","id":31866473,"avatar_url":"https://avatars2.githubusercontent.com/u/31866473?v=4","gravatar_id":"","url":"https://api.github.com/users/ciao-project","html_url":"https://github.com/ciao-project","followers_url":"https://api.github.com/users/ciao-project/followers","following_url":"https://api.github.com/users/ciao-project/following{/other_user}","gists_url":"https://api.github.com/users/ciao-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ciao-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciao-project/subscriptions","organizations_url":"https://api.github.com/users/ciao-project/orgs","repos_url":"https://api.github.com/users/ciao-project/repos","events_url":"https://api.github.com/users/ciao-project/events{/privacy}","received_events_url":"https://api.github.com/users/ciao-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciao-project/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":false,"url":"https://api.github.com/repos/ciao-project/ciao","forks_url":"https://api.github.com/repos/ciao-project/ciao/forks","keys_url":"https://api.github.com/repos/ciao-project/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciao-project/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciao-project/ciao/teams","hooks_url":"https://api.github.com/repos/ciao-project/ciao/hooks","issue_events_url":"https://api.github.com/repos/ciao-project/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/ciao-project/ciao/events","assignees_url":"https://api.github.com/repos/ciao-project/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/ciao-project/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/ciao-project/ciao/tags","blobs_url":"https://api.github.com/repos/ciao-project/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciao-project/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciao-project/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciao-project/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciao-project/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/ciao-project/ciao/languages","stargazers_url":"https://api.github.com/repos/ciao-project/ciao/stargazers","contributors_url":"https://api.github.com/repos/ciao-project/ciao/contributors","subscribers_url":"https://api.github.com/repos/ciao-project/ciao/subscribers","subscription_url":"https://api.github.com/repos/ciao-project/ciao/subscription","commits_url":"https://api.github.com/repos/ciao-project/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciao-project/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciao-project/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciao-project/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciao-project/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/ciao-project/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciao-project/ciao/merges","archive_url":"https://api.github.com/repos/ciao-project/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciao-project/ciao/downloads","issues_url":"https://api.github.com/repos/ciao-project/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/ciao-project/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/ciao-project/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/ciao-project/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciao-project/ciao/labels{/name}","releases_url":"https://api.github.com/repos/ciao-project/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/ciao-project/ciao/deployments","created_at":"2016-03-24T17:19:34Z","updated_at":"2017-11-20T22:50:18Z","pushed_at":"2017-11-24T17:40:08Z","git_url":"git://github.com/ciao-project/ciao.git","ssh_url":"git@github.com:ciao-project/ciao.git","clone_url":"https://github.com/ciao-project/ciao.git","svn_url":"https://github.com/ciao-project/ciao","homepage":"","size":12992,"stargazers_count":197,"watchers_count":197,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":206,"forks":49,"open_issues":206,"watchers":197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciao-project/ciao/pulls/1598"},"html":{"href":"https://github.com/ciao-project/ciao/pull/1598"},"issue":{"href":"https://api.github.com/repos/ciao-project/ciao/issues/1598"},"comments":{"href":"https://api.github.com/repos/ciao-project/ciao/issues/1598/comments"},"review_comments":{"href":"https://api.github.com/repos/ciao-project/ciao/pulls/1598/comments"},"review_comment":{"href":"https://api.github.com/repos/ciao-project/ciao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciao-project/ciao/pulls/1598/commits"},"statuses":{"href":"https://api.github.com/repos/ciao-project/ciao/statuses/b2d58e6de0b86c9f09604cf3b54572bda41a6436"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markdryan"}}