{"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments/153496446","pull_request_review_id":79508143,"id":153496446,"diff_hunk":"@@ -100,7 +100,15 @@ public ProjectImports load(final Path path) {\n                 saveProjectImports(path);\n             }\n             final String content = ioService.readAllString(Paths.convert(path));\n-            return projectConfigurationContentHandler.toModel(content);\n+            final ProjectImports projectImports = projectConfigurationContentHandler.toModel(content);\n+\n+            // java.lang.Number imported by default in new guided rule\n+            // include it into project imports if not present already\n+            final Import javaLangNumber = new Import(java.lang.Number.class.getName());","path":"kie-wb-common-services/kie-wb-common-services-backend/src/main/java/org/kie/workbench/common/services/backend/project/ProjectImportsServiceImpl.java","position":9,"original_position":9,"commit_id":"6377dca6a1d1bc439d229f3253661866242c0527","original_commit_id":"6377dca6a1d1bc439d229f3253661866242c0527","user":{"login":"triceo","id":247403,"avatar_url":"https://avatars0.githubusercontent.com/u/247403?v=4","gravatar_id":"","url":"https://api.github.com/users/triceo","html_url":"https://github.com/triceo","followers_url":"https://api.github.com/users/triceo/followers","following_url":"https://api.github.com/users/triceo/following{/other_user}","gists_url":"https://api.github.com/users/triceo/gists{/gist_id}","starred_url":"https://api.github.com/users/triceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triceo/subscriptions","organizations_url":"https://api.github.com/users/triceo/orgs","repos_url":"https://api.github.com/users/triceo/repos","events_url":"https://api.github.com/users/triceo/events{/privacy}","received_events_url":"https://api.github.com/users/triceo/received_events","type":"User","site_admin":false},"body":"A suggestion: if the `Import(String name)` constructor had a friend (`Import(Class<?> cls)`), callers wouldn't need to repeat `.getName()` all the time. Also, it looks a bit better, saying \"import this class\", as opposed to \"import class represented by this textual FQN\".","created_at":"2017-11-28T13:51:45Z","updated_at":"2017-11-28T13:53:47Z","html_url":"https://github.com/kiegroup/kie-wb-common/pull/1306#discussion_r153496446","pull_request_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments/153496446"},"html":{"href":"https://github.com/kiegroup/kie-wb-common/pull/1306#discussion_r153496446"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306","id":155073679,"html_url":"https://github.com/kiegroup/kie-wb-common/pull/1306","diff_url":"https://github.com/kiegroup/kie-wb-common/pull/1306.diff","patch_url":"https://github.com/kiegroup/kie-wb-common/pull/1306.patch","issue_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1306","number":1306,"state":"open","locked":false,"title":"[DO NOT MERGE] DROOLS-1798: Include java.lang.Number in project imports by default","user":{"login":"jomarko","id":8044780,"avatar_url":"https://avatars3.githubusercontent.com/u/8044780?v=4","gravatar_id":"","url":"https://api.github.com/users/jomarko","html_url":"https://github.com/jomarko","followers_url":"https://api.github.com/users/jomarko/followers","following_url":"https://api.github.com/users/jomarko/following{/other_user}","gists_url":"https://api.github.com/users/jomarko/gists{/gist_id}","starred_url":"https://api.github.com/users/jomarko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jomarko/subscriptions","organizations_url":"https://api.github.com/users/jomarko/orgs","repos_url":"https://api.github.com/users/jomarko/repos","events_url":"https://api.github.com/users/jomarko/events{/privacy}","received_events_url":"https://api.github.com/users/jomarko/received_events","type":"User","site_admin":false},"body":"Ensemble with kiegroup/drools-wb#714","created_at":"2017-11-28T13:40:37Z","updated_at":"2017-11-28T13:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f5b87e8b9bc2281b824ad9f7a972f37d9cca92f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306/commits","review_comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306/comments","review_comment_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1306/comments","statuses_url":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/6377dca6a1d1bc439d229f3253661866242c0527","head":{"label":"jomarko:DROOLS-1798","ref":"DROOLS-1798","sha":"6377dca6a1d1bc439d229f3253661866242c0527","user":{"login":"jomarko","id":8044780,"avatar_url":"https://avatars3.githubusercontent.com/u/8044780?v=4","gravatar_id":"","url":"https://api.github.com/users/jomarko","html_url":"https://github.com/jomarko","followers_url":"https://api.github.com/users/jomarko/followers","following_url":"https://api.github.com/users/jomarko/following{/other_user}","gists_url":"https://api.github.com/users/jomarko/gists{/gist_id}","starred_url":"https://api.github.com/users/jomarko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jomarko/subscriptions","organizations_url":"https://api.github.com/users/jomarko/orgs","repos_url":"https://api.github.com/users/jomarko/repos","events_url":"https://api.github.com/users/jomarko/events{/privacy}","received_events_url":"https://api.github.com/users/jomarko/received_events","type":"User","site_admin":false},"repo":{"id":38682395,"name":"kie-wb-common","full_name":"jomarko/kie-wb-common","owner":{"login":"jomarko","id":8044780,"avatar_url":"https://avatars3.githubusercontent.com/u/8044780?v=4","gravatar_id":"","url":"https://api.github.com/users/jomarko","html_url":"https://github.com/jomarko","followers_url":"https://api.github.com/users/jomarko/followers","following_url":"https://api.github.com/users/jomarko/following{/other_user}","gists_url":"https://api.github.com/users/jomarko/gists{/gist_id}","starred_url":"https://api.github.com/users/jomarko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jomarko/subscriptions","organizations_url":"https://api.github.com/users/jomarko/orgs","repos_url":"https://api.github.com/users/jomarko/repos","events_url":"https://api.github.com/users/jomarko/events{/privacy}","received_events_url":"https://api.github.com/users/jomarko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jomarko/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":true,"url":"https://api.github.com/repos/jomarko/kie-wb-common","forks_url":"https://api.github.com/repos/jomarko/kie-wb-common/forks","keys_url":"https://api.github.com/repos/jomarko/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jomarko/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jomarko/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/jomarko/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/jomarko/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/jomarko/kie-wb-common/events","assignees_url":"https://api.github.com/repos/jomarko/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/jomarko/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/jomarko/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/jomarko/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jomarko/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jomarko/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/jomarko/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jomarko/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/jomarko/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/jomarko/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/jomarko/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/jomarko/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/jomarko/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/jomarko/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/jomarko/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/jomarko/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/jomarko/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/jomarko/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/jomarko/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jomarko/kie-wb-common/merges","archive_url":"https://api.github.com/repos/jomarko/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jomarko/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/jomarko/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/jomarko/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/jomarko/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/jomarko/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jomarko/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/jomarko/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/jomarko/kie-wb-common/deployments","created_at":"2015-07-07T11:04:54Z","updated_at":"2016-01-17T10:05:37Z","pushed_at":"2017-11-28T13:36:29Z","git_url":"git://github.com/jomarko/kie-wb-common.git","ssh_url":"git@github.com:jomarko/kie-wb-common.git","clone_url":"https://github.com/jomarko/kie-wb-common.git","svn_url":"https://github.com/jomarko/kie-wb-common","homepage":"","size":29865,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"97b0f801969bb8a60ae8dcc5bcc65a6a4a94f71d","user":{"login":"kiegroup","id":517980,"avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":10522120,"name":"kie-wb-common","full_name":"kiegroup/kie-wb-common","owner":{"login":"kiegroup","id":517980,"avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiegroup/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":false,"url":"https://api.github.com/repos/kiegroup/kie-wb-common","forks_url":"https://api.github.com/repos/kiegroup/kie-wb-common/forks","keys_url":"https://api.github.com/repos/kiegroup/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/kiegroup/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/kie-wb-common/events","assignees_url":"https://api.github.com/repos/kiegroup/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/kiegroup/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/kie-wb-common/merges","archive_url":"https://api.github.com/repos/kiegroup/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/deployments","created_at":"2013-06-06T08:32:03Z","updated_at":"2017-11-10T13:13:50Z","pushed_at":"2017-11-28T13:40:38Z","git_url":"git://github.com/kiegroup/kie-wb-common.git","ssh_url":"git@github.com:kiegroup/kie-wb-common.git","clone_url":"https://github.com/kiegroup/kie-wb-common.git","svn_url":"https://github.com/kiegroup/kie-wb-common","homepage":"","size":32046,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":134,"open_issues":16,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306"},"html":{"href":"https://github.com/kiegroup/kie-wb-common/pull/1306"},"issue":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1306"},"comments":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1306/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1306/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/6377dca6a1d1bc439d229f3253661866242c0527"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"triceo"}}