{"action":"created","issue":{"url":"https://api.github.com/repos/huttarichard/instagram-private-api/issues/213","repository_url":"https://api.github.com/repos/huttarichard/instagram-private-api","labels_url":"https://api.github.com/repos/huttarichard/instagram-private-api/issues/213/labels{/name}","comments_url":"https://api.github.com/repos/huttarichard/instagram-private-api/issues/213/comments","events_url":"https://api.github.com/repos/huttarichard/instagram-private-api/issues/213/events","html_url":"https://github.com/huttarichard/instagram-private-api/issues/213","id":223808902,"number":213,"title":"[Request] Support for async CookieStorage","user":{"login":"IvanMMM","id":3692403,"avatar_url":"https://avatars3.githubusercontent.com/u/3692403?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanMMM","html_url":"https://github.com/IvanMMM","followers_url":"https://api.github.com/users/IvanMMM/followers","following_url":"https://api.github.com/users/IvanMMM/following{/other_user}","gists_url":"https://api.github.com/users/IvanMMM/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanMMM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanMMM/subscriptions","organizations_url":"https://api.github.com/users/IvanMMM/orgs","repos_url":"https://api.github.com/users/IvanMMM/repos","events_url":"https://api.github.com/users/IvanMMM/events{/privacy}","received_events_url":"https://api.github.com/users/IvanMMM/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2017-04-24T12:49:48Z","updated_at":"2017-04-26T11:20:03Z","closed_at":null,"body":"Hey, Richard. You mentioned that we can use any Storage we want to, but there's a problem. You designed IPA to work only with synchronous Stores and it goes reeeealy deep nearly to all your files :(\r\nI tried to rewrite some of your methods to work with both sync/async methods, but I'l have to rewrite even getters, so it will break most existing code for most apps.\r\nYou also mentioned you want to search for better solution with this async cookie problem at #66, so why not doing it now? :) I'm ready to help you with it, and maybe @dilame too."},"comment":{"url":"https://api.github.com/repos/huttarichard/instagram-private-api/issues/comments/297364816","html_url":"https://github.com/huttarichard/instagram-private-api/issues/213#issuecomment-297364816","issue_url":"https://api.github.com/repos/huttarichard/instagram-private-api/issues/213","id":297364816,"user":{"login":"huttarichard","id":1809268,"avatar_url":"https://avatars2.githubusercontent.com/u/1809268?v=3","gravatar_id":"","url":"https://api.github.com/users/huttarichard","html_url":"https://github.com/huttarichard","followers_url":"https://api.github.com/users/huttarichard/followers","following_url":"https://api.github.com/users/huttarichard/following{/other_user}","gists_url":"https://api.github.com/users/huttarichard/gists{/gist_id}","starred_url":"https://api.github.com/users/huttarichard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huttarichard/subscriptions","organizations_url":"https://api.github.com/users/huttarichard/orgs","repos_url":"https://api.github.com/users/huttarichard/repos","events_url":"https://api.github.com/users/huttarichard/events{/privacy}","received_events_url":"https://api.github.com/users/huttarichard/received_events","type":"User","site_admin":false},"created_at":"2017-04-26T11:20:03Z","updated_at":"2017-04-26T11:20:03Z","body":"request js class is handling cookies trough jar. Jar is interface for storing cookies. This lib https://github.com/salesforce/tough-cookie makes working with jar easy. Support both async and sync methods. You need to work with jar for two reasons, handling cookies by hand would be messy and akward, and implement interface for serializing cookies would be just pain. On top of this there is additional logic in repo. \r\n\r\nHere you create new jar https://github.com/huttarichard/instagram-private-api/blob/master/client/v1/session.js#L75\r\n\r\nJar interface is same as tough cookie JAR and its mirroring original class.\r\nhttps://github.com/huttarichard/instagram-private-api/blob/master/client/v1/jar.js\r\nReson for that is that we need to have for web api and private same cookies.\r\n\r\nthis jar method is then passed to request js class here\r\nhttps://github.com/huttarichard/instagram-private-api/blob/master/client/v1/request.js#L225"}}
{"actor":{"display_login":"huttarichard"}}