{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments/153727462","pull_request_review_id":79775486,"id":153727462,"diff_hunk":"@@ -0,0 +1,30 @@\n+class govuk::apps::email_status_updates {\n+  $port = '3088'\n+  $app_domain = hiera('app_domain')\n+\n+  nginx::config::site { \"email-status-updates.${app_domain}\":\n+    content => \"\n+      upstream email-status-updates.${app_domain}-proxy {\n+        server localhost:${port};\n+      }\n+\n+      server {\n+        server_name email-status-updates.${app_domain};\n+\n+        listen 80;\n+        listen 443 ssl;\n+\n+        ssl_certificate /etc/nginx/ssl/email-alert-api.${app_domain}.crt;\n+        ssl_certificate_key /etc/nginx/ssl/email-alert-api.${app_domain}.key;\n+        include /etc/nginx/ssl.conf;\n+\n+        add_header Access-Control-Allow-Origin *;\n+        add_header Access-Control-Allow-Methods POST;\n+\n+        location / {\n+          proxy_pass http://email-status-updates.${app_domain}-proxy/status_updates;","path":"modules/govuk/manifests/apps/email_status_updates.pp","position":25,"original_position":25,"commit_id":"29c1fe3902b77e24ea0a8d399baaace5c2905057","original_commit_id":"29c1fe3902b77e24ea0a8d399baaace5c2905057","user":{"login":"rubenarakelyan","id":444232,"avatar_url":"https://avatars0.githubusercontent.com/u/444232?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenarakelyan","html_url":"https://github.com/rubenarakelyan","followers_url":"https://api.github.com/users/rubenarakelyan/followers","following_url":"https://api.github.com/users/rubenarakelyan/following{/other_user}","gists_url":"https://api.github.com/users/rubenarakelyan/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenarakelyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenarakelyan/subscriptions","organizations_url":"https://api.github.com/users/rubenarakelyan/orgs","repos_url":"https://api.github.com/users/rubenarakelyan/repos","events_url":"https://api.github.com/users/rubenarakelyan/events{/privacy}","received_events_url":"https://api.github.com/users/rubenarakelyan/received_events","type":"User","site_admin":false},"body":"Should this be proxying to `email-alert-api`?","created_at":"2017-11-29T09:11:06Z","updated_at":"2017-11-29T09:11:06Z","html_url":"https://github.com/alphagov/govuk-puppet/pull/6860#discussion_r153727462","pull_request_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments/153727462"},"html":{"href":"https://github.com/alphagov/govuk-puppet/pull/6860#discussion_r153727462"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860","id":155118694,"html_url":"https://github.com/alphagov/govuk-puppet/pull/6860","diff_url":"https://github.com/alphagov/govuk-puppet/pull/6860.diff","patch_url":"https://github.com/alphagov/govuk-puppet/pull/6860.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/6860","number":6860,"state":"open","locked":false,"title":"Proxy email-status-updates.* to email-alert-api/status_updates","user":{"login":"tuzz","id":892251,"avatar_url":"https://avatars3.githubusercontent.com/u/892251?v=4","gravatar_id":"","url":"https://api.github.com/users/tuzz","html_url":"https://github.com/tuzz","followers_url":"https://api.github.com/users/tuzz/followers","following_url":"https://api.github.com/users/tuzz/following{/other_user}","gists_url":"https://api.github.com/users/tuzz/gists{/gist_id}","starred_url":"https://api.github.com/users/tuzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuzz/subscriptions","organizations_url":"https://api.github.com/users/tuzz/orgs","repos_url":"https://api.github.com/users/tuzz/repos","events_url":"https://api.github.com/users/tuzz/events{/privacy}","received_events_url":"https://api.github.com/users/tuzz/received_events","type":"User","site_admin":false},"body":"https://trello.com/c/7pDM2swr/372-proxy-requests-from-a-public-url-to-the-statusupdates-endpoint\r\n\r\nTo do:\r\n\r\n- ensure dns changes have propogated\r\n- document the puppet module\r\n- re-use email-alert-api's port\r\n- add bearer token checking to /status_updates\r\n- (optional) validate request for presence of fields before enqueueing job?","created_at":"2017-11-28T16:25:12Z","updated_at":"2017-11-29T09:11:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16984269278fc3b856b4df76f6a25dba52a2395d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/6860/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/29c1fe3902b77e24ea0a8d399baaace5c2905057","head":{"label":"alphagov:email-status-updates","ref":"email-status-updates","sha":"29c1fe3902b77e24ea0a8d399baaace5c2905057","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47834743,"name":"govuk-puppet","full_name":"alphagov/govuk-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-puppet","description":"Puppet manifests used to provision the main GOV.UK web stack","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-puppet","forks_url":"https://api.github.com/repos/alphagov/govuk-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-puppet/deployments","created_at":"2015-12-11T15:36:24Z","updated_at":"2017-11-23T10:31:59Z","pushed_at":"2017-11-28T19:10:53Z","git_url":"git://github.com/alphagov/govuk-puppet.git","ssh_url":"git@github.com:alphagov/govuk-puppet.git","clone_url":"https://github.com/alphagov/govuk-puppet.git","svn_url":"https://github.com/alphagov/govuk-puppet","homepage":"https://www.gov.uk/","size":32955,"stargazers_count":69,"watchers_count":69,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":20,"watchers":69,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"1acffed43b743b22e570a64a6f6e2c56f171e0dd","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47834743,"name":"govuk-puppet","full_name":"alphagov/govuk-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-puppet","description":"Puppet manifests used to provision the main GOV.UK web stack","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-puppet","forks_url":"https://api.github.com/repos/alphagov/govuk-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-puppet/deployments","created_at":"2015-12-11T15:36:24Z","updated_at":"2017-11-23T10:31:59Z","pushed_at":"2017-11-28T19:10:53Z","git_url":"git://github.com/alphagov/govuk-puppet.git","ssh_url":"git@github.com:alphagov/govuk-puppet.git","clone_url":"https://github.com/alphagov/govuk-puppet.git","svn_url":"https://github.com/alphagov/govuk-puppet","homepage":"https://www.gov.uk/","size":32955,"stargazers_count":69,"watchers_count":69,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":20,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860"},"html":{"href":"https://github.com/alphagov/govuk-puppet/pull/6860"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/issues/6860"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/issues/6860/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/6860/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/29c1fe3902b77e24ea0a8d399baaace5c2905057"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rubenarakelyan"}}