{"action":"created","comment":{"url":"https://api.github.com/repos/Neufund/ico-contracts/pulls/comments/139080259","pull_request_review_id":62964521,"id":139080259,"diff_hunk":"@@ -21,23 +61,52 @@ contract Agreement {\n         address indexed accepter\n     );\n \n+    event LogAgreementAmended(\n+        address platformOperatorRepresentative,\n+        string agreementUri\n+    );\n+\n     ////////////////////////\n     // Modifiers\n     ////////////////////////\n \n+    /// @notice logs that agreement was accepted by platform user\n+    /// @dev intended to be added to functions that if used make 'accepter' origin to enter legally binding agreement\n     modifier acceptAgreement(address accepter) {\n-        LogAgreementAccepted(accepter);\n+        require(_amendments.length > 0);\n+        if(!_signatories[accepter]) {\n+            _signatories[accepter] = true;\n+            LogAgreementAccepted(accepter);\n+        }","path":"contracts/Agreement.sol","position":81,"original_position":81,"commit_id":"9ec7b49845af787395c4f7b1d2789310728c5930","original_commit_id":"9ec7b49845af787395c4f7b1d2789310728c5930","user":{"login":"Recmo","id":4532328,"avatar_url":"https://avatars2.githubusercontent.com/u/4532328?v=4","gravatar_id":"","url":"https://api.github.com/users/Recmo","html_url":"https://github.com/Recmo","followers_url":"https://api.github.com/users/Recmo/followers","following_url":"https://api.github.com/users/Recmo/following{/other_user}","gists_url":"https://api.github.com/users/Recmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Recmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Recmo/subscriptions","organizations_url":"https://api.github.com/users/Recmo/orgs","repos_url":"https://api.github.com/users/Recmo/repos","events_url":"https://api.github.com/users/Recmo/events{/privacy}","received_events_url":"https://api.github.com/users/Recmo/received_events","type":"User","site_admin":false},"body":"We can safely move the `require` inside the conditional, because no-one can be accepted before the first amendment is posted.\r\nThis doesn't look as good, but it saves an expensive storage lookup in the common case where user has already signed. I think it's worth it.","created_at":"2017-09-15T07:25:45Z","updated_at":"2017-09-15T07:25:45Z","html_url":"https://github.com/Neufund/ico-contracts/pull/76#discussion_r139080259","pull_request_url":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Neufund/ico-contracts/pulls/comments/139080259"},"html":{"href":"https://github.com/Neufund/ico-contracts/pull/76#discussion_r139080259"},"pull_request":{"href":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76","id":140407443,"html_url":"https://github.com/Neufund/ico-contracts/pull/76","diff_url":"https://github.com/Neufund/ico-contracts/pull/76.diff","patch_url":"https://github.com/Neufund/ico-contracts/pull/76.patch","issue_url":"https://api.github.com/repos/Neufund/ico-contracts/issues/76","number":76,"state":"open","locked":false,"title":"extends Agreement contract","user":{"login":"rudolfix","id":17202864,"avatar_url":"https://avatars2.githubusercontent.com/u/17202864?v=4","gravatar_id":"","url":"https://api.github.com/users/rudolfix","html_url":"https://github.com/rudolfix","followers_url":"https://api.github.com/users/rudolfix/followers","following_url":"https://api.github.com/users/rudolfix/following{/other_user}","gists_url":"https://api.github.com/users/rudolfix/gists{/gist_id}","starred_url":"https://api.github.com/users/rudolfix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudolfix/subscriptions","organizations_url":"https://api.github.com/users/rudolfix/orgs","repos_url":"https://api.github.com/users/rudolfix/repos","events_url":"https://api.github.com/users/rudolfix/events{/privacy}","received_events_url":"https://api.github.com/users/rudolfix/received_events","type":"User","site_admin":false},"body":"Extends Agreement contracts according to legal guidelines. Please check Agreement contract header for details.\r\nIf this direction is approved I will continue with code cleanup and proper test update/coverage","created_at":"2017-09-11T18:45:59Z","updated_at":"2017-09-15T07:25:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"689a8b38c6d8a9516e51c98d38a4114ba241df0b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76/commits","review_comments_url":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76/comments","review_comment_url":"https://api.github.com/repos/Neufund/ico-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neufund/ico-contracts/issues/76/comments","statuses_url":"https://api.github.com/repos/Neufund/ico-contracts/statuses/9ec7b49845af787395c4f7b1d2789310728c5930","head":{"label":"Neufund:rfix/extends-agreement","ref":"rfix/extends-agreement","sha":"9ec7b49845af787395c4f7b1d2789310728c5930","user":{"login":"Neufund","id":25393169,"avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"repo":{"id":98998268,"name":"ico-contracts","full_name":"Neufund/ico-contracts","owner":{"login":"Neufund","id":25393169,"avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Neufund/ico-contracts","description":null,"fork":false,"url":"https://api.github.com/repos/Neufund/ico-contracts","forks_url":"https://api.github.com/repos/Neufund/ico-contracts/forks","keys_url":"https://api.github.com/repos/Neufund/ico-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neufund/ico-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neufund/ico-contracts/teams","hooks_url":"https://api.github.com/repos/Neufund/ico-contracts/hooks","issue_events_url":"https://api.github.com/repos/Neufund/ico-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/Neufund/ico-contracts/events","assignees_url":"https://api.github.com/repos/Neufund/ico-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/Neufund/ico-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/Neufund/ico-contracts/tags","blobs_url":"https://api.github.com/repos/Neufund/ico-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neufund/ico-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neufund/ico-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neufund/ico-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neufund/ico-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/Neufund/ico-contracts/languages","stargazers_url":"https://api.github.com/repos/Neufund/ico-contracts/stargazers","contributors_url":"https://api.github.com/repos/Neufund/ico-contracts/contributors","subscribers_url":"https://api.github.com/repos/Neufund/ico-contracts/subscribers","subscription_url":"https://api.github.com/repos/Neufund/ico-contracts/subscription","commits_url":"https://api.github.com/repos/Neufund/ico-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neufund/ico-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neufund/ico-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neufund/ico-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neufund/ico-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/Neufund/ico-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neufund/ico-contracts/merges","archive_url":"https://api.github.com/repos/Neufund/ico-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neufund/ico-contracts/downloads","issues_url":"https://api.github.com/repos/Neufund/ico-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/Neufund/ico-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/Neufund/ico-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/Neufund/ico-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neufund/ico-contracts/labels{/name}","releases_url":"https://api.github.com/repos/Neufund/ico-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/Neufund/ico-contracts/deployments","created_at":"2017-08-01T12:21:19Z","updated_at":"2017-09-06T23:00:29Z","pushed_at":"2017-09-14T21:43:50Z","git_url":"git://github.com/Neufund/ico-contracts.git","ssh_url":"git@github.com:Neufund/ico-contracts.git","clone_url":"https://github.com/Neufund/ico-contracts.git","svn_url":"https://github.com/Neufund/ico-contracts","homepage":null,"size":926,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":4,"default_branch":"master"}},"base":{"label":"Neufund:master","ref":"master","sha":"5df1070a282439bdc00e2b1dc87404ca84822550","user":{"login":"Neufund","id":25393169,"avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"repo":{"id":98998268,"name":"ico-contracts","full_name":"Neufund/ico-contracts","owner":{"login":"Neufund","id":25393169,"avatar_url":"https://avatars2.githubusercontent.com/u/25393169?v=4","gravatar_id":"","url":"https://api.github.com/users/Neufund","html_url":"https://github.com/Neufund","followers_url":"https://api.github.com/users/Neufund/followers","following_url":"https://api.github.com/users/Neufund/following{/other_user}","gists_url":"https://api.github.com/users/Neufund/gists{/gist_id}","starred_url":"https://api.github.com/users/Neufund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neufund/subscriptions","organizations_url":"https://api.github.com/users/Neufund/orgs","repos_url":"https://api.github.com/users/Neufund/repos","events_url":"https://api.github.com/users/Neufund/events{/privacy}","received_events_url":"https://api.github.com/users/Neufund/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Neufund/ico-contracts","description":null,"fork":false,"url":"https://api.github.com/repos/Neufund/ico-contracts","forks_url":"https://api.github.com/repos/Neufund/ico-contracts/forks","keys_url":"https://api.github.com/repos/Neufund/ico-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neufund/ico-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neufund/ico-contracts/teams","hooks_url":"https://api.github.com/repos/Neufund/ico-contracts/hooks","issue_events_url":"https://api.github.com/repos/Neufund/ico-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/Neufund/ico-contracts/events","assignees_url":"https://api.github.com/repos/Neufund/ico-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/Neufund/ico-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/Neufund/ico-contracts/tags","blobs_url":"https://api.github.com/repos/Neufund/ico-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neufund/ico-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neufund/ico-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neufund/ico-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neufund/ico-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/Neufund/ico-contracts/languages","stargazers_url":"https://api.github.com/repos/Neufund/ico-contracts/stargazers","contributors_url":"https://api.github.com/repos/Neufund/ico-contracts/contributors","subscribers_url":"https://api.github.com/repos/Neufund/ico-contracts/subscribers","subscription_url":"https://api.github.com/repos/Neufund/ico-contracts/subscription","commits_url":"https://api.github.com/repos/Neufund/ico-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neufund/ico-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neufund/ico-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neufund/ico-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neufund/ico-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/Neufund/ico-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neufund/ico-contracts/merges","archive_url":"https://api.github.com/repos/Neufund/ico-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neufund/ico-contracts/downloads","issues_url":"https://api.github.com/repos/Neufund/ico-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/Neufund/ico-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/Neufund/ico-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/Neufund/ico-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neufund/ico-contracts/labels{/name}","releases_url":"https://api.github.com/repos/Neufund/ico-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/Neufund/ico-contracts/deployments","created_at":"2017-08-01T12:21:19Z","updated_at":"2017-09-06T23:00:29Z","pushed_at":"2017-09-14T21:43:50Z","git_url":"git://github.com/Neufund/ico-contracts.git","ssh_url":"git@github.com:Neufund/ico-contracts.git","clone_url":"https://github.com/Neufund/ico-contracts.git","svn_url":"https://github.com/Neufund/ico-contracts","homepage":null,"size":926,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76"},"html":{"href":"https://github.com/Neufund/ico-contracts/pull/76"},"issue":{"href":"https://api.github.com/repos/Neufund/ico-contracts/issues/76"},"comments":{"href":"https://api.github.com/repos/Neufund/ico-contracts/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/Neufund/ico-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neufund/ico-contracts/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/Neufund/ico-contracts/statuses/9ec7b49845af787395c4f7b1d2789310728c5930"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Recmo"}}