{"action":"created","issue":{"url":"https://api.github.com/repos/ionic-team/stencil/issues/222","repository_url":"https://api.github.com/repos/ionic-team/stencil","labels_url":"https://api.github.com/repos/ionic-team/stencil/issues/222/labels{/name}","comments_url":"https://api.github.com/repos/ionic-team/stencil/issues/222/comments","events_url":"https://api.github.com/repos/ionic-team/stencil/issues/222/events","html_url":"https://github.com/ionic-team/stencil/pull/222","id":263625276,"number":222,"title":"Use own service worker","user":{"login":"kubii","id":11795175,"avatar_url":"https://avatars1.githubusercontent.com/u/11795175?v=4","gravatar_id":"","url":"https://api.github.com/users/kubii","html_url":"https://github.com/kubii","followers_url":"https://api.github.com/users/kubii/followers","following_url":"https://api.github.com/users/kubii/following{/other_user}","gists_url":"https://api.github.com/users/kubii/gists{/gist_id}","starred_url":"https://api.github.com/users/kubii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubii/subscriptions","organizations_url":"https://api.github.com/users/kubii/orgs","repos_url":"https://api.github.com/users/kubii/repos","events_url":"https://api.github.com/users/kubii/events{/privacy}","received_events_url":"https://api.github.com/users/kubii/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jgw96","id":8823093,"avatar_url":"https://avatars3.githubusercontent.com/u/8823093?v=4","gravatar_id":"","url":"https://api.github.com/users/jgw96","html_url":"https://github.com/jgw96","followers_url":"https://api.github.com/users/jgw96/followers","following_url":"https://api.github.com/users/jgw96/following{/other_user}","gists_url":"https://api.github.com/users/jgw96/gists{/gist_id}","starred_url":"https://api.github.com/users/jgw96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgw96/subscriptions","organizations_url":"https://api.github.com/users/jgw96/orgs","repos_url":"https://api.github.com/users/jgw96/repos","events_url":"https://api.github.com/users/jgw96/events{/privacy}","received_events_url":"https://api.github.com/users/jgw96/received_events","type":"User","site_admin":false},"assignees":[{"login":"jgw96","id":8823093,"avatar_url":"https://avatars3.githubusercontent.com/u/8823093?v=4","gravatar_id":"","url":"https://api.github.com/users/jgw96","html_url":"https://github.com/jgw96","followers_url":"https://api.github.com/users/jgw96/followers","following_url":"https://api.github.com/users/jgw96/following{/other_user}","gists_url":"https://api.github.com/users/jgw96/gists{/gist_id}","starred_url":"https://api.github.com/users/jgw96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgw96/subscriptions","organizations_url":"https://api.github.com/users/jgw96/orgs","repos_url":"https://api.github.com/users/jgw96/repos","events_url":"https://api.github.com/users/jgw96/events{/privacy}","received_events_url":"https://api.github.com/users/jgw96/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-10-07T08:10:44Z","updated_at":"2017-10-19T20:13:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ionic-team/stencil/pulls/222","html_url":"https://github.com/ionic-team/stencil/pull/222","diff_url":"https://github.com/ionic-team/stencil/pull/222.diff","patch_url":"https://github.com/ionic-team/stencil/pull/222.patch"},"body":"Pull request for #192 \r\n\r\nIf swSrc config is not specified then the service worker\r\nwill be genereted otherwise injectManfiest will be executed.\r\n\r\nNotes:\r\n1; Now there is an inconsistency with the base paths since the base path of the `copy` functionality is the `/src` directory but the base path of the `swSrc` is the root of the project. Couldn't find any option for workbox to set the base path of the `swSrc`. Maybe we could prefix the path with `src/`. What do you think? Does it make sense?\r\n\r\n2; When using `swSrc` then the config won't be passed to WorkboxSW's constructor. This is normal since WorkboxSW needs to be instantiated manually by the user.\r\nAll of these things are documented in the workbox docs. Quote:\r\n> Note: This option is only valid when used with generateSW(). When using injectManifest(), you can explicitly pass the desired value in to the WorkboxSW() constructor in your swSrc file.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ionic-team/stencil/issues/comments/338024378","html_url":"https://github.com/ionic-team/stencil/pull/222#issuecomment-338024378","issue_url":"https://api.github.com/repos/ionic-team/stencil/issues/222","id":338024378,"user":{"login":"jgw96","id":8823093,"avatar_url":"https://avatars3.githubusercontent.com/u/8823093?v=4","gravatar_id":"","url":"https://api.github.com/users/jgw96","html_url":"https://github.com/jgw96","followers_url":"https://api.github.com/users/jgw96/followers","following_url":"https://api.github.com/users/jgw96/following{/other_user}","gists_url":"https://api.github.com/users/jgw96/gists{/gist_id}","starred_url":"https://api.github.com/users/jgw96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgw96/subscriptions","organizations_url":"https://api.github.com/users/jgw96/orgs","repos_url":"https://api.github.com/users/jgw96/repos","events_url":"https://api.github.com/users/jgw96/events{/privacy}","received_events_url":"https://api.github.com/users/jgw96/received_events","type":"User","site_admin":false},"created_at":"2017-10-19T20:13:45Z","updated_at":"2017-10-19T20:13:45Z","author_association":"MEMBER","body":"Ahh i got ya. Hmm, i think this is fine though actually, just something we will have to document. Ill test, we can get this merged and then ill write docs for it. Thanks again for the PR!"}}
{"actor":{"display_login":"jgw96"}}