{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20721","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20721/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20721/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20721/events","html_url":"https://github.com/cockroachdb/cockroach/pull/20721","id":282190026,"number":20721,"title":"sqlccl: gate experimental MVCC backups on version check","user":{"login":"dt","id":15615,"avatar_url":"https://avatars2.githubusercontent.com/u/15615?v=4","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-12-14T18:05:07Z","updated_at":"2017-12-14T20:54:10Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/20721","html_url":"https://github.com/cockroachdb/cockroach/pull/20721","diff_url":"https://github.com/cockroachdb/cockroach/pull/20721.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/20721.patch"},"body":"older nodes would execute the commands incorrectly, ignoring the new flag.\r\n\r\nRelease note: none."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/351832695","html_url":"https://github.com/cockroachdb/cockroach/pull/20721#issuecomment-351832695","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20721","id":351832695,"user":{"login":"mjibson","id":41181,"avatar_url":"https://avatars1.githubusercontent.com/u/41181?v=4","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"created_at":"2017-12-14T20:54:10Z","updated_at":"2017-12-14T20:54:10Z","author_association":"OWNER","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.\n\n---\n\n*[pkg/ccl/sqlccl/backup.go, line 731 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/20721#-L0LnJGyQArIIxJuHaBS:-L0LnJGyQArIIxJuHaBT:bfgvcik) ([raw file](https://github.com/cockroachdb/cockroach/blob/8b77c13d87d12598034eb74b771847fe6e907c3f/pkg/ccl/sqlccl/backup.go#L731)):*\n> ```Go\n> \t\tmvccFilter := MVCCFilter_Latest\n> \t\tif _, ok := opts[backupOptRevisionHistory]; ok {\n> \t\t\t// older nodes don't know about MVCCAll and would incorrectly do latest.\n> ```\n\nThis code looks correct, but it is in the wrong place. We can't start any backups with an old node in the cluster because of the new BackupDescriptor field, which old nodes won't see. It is possible we should do the same thing for RESTORE (i.e., put the version check at the top and not in any feature-detection block).\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/20721)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mjibson"}}