{"action":"created","comment":{"url":"https://api.github.com/repos/google/protobuf/pulls/comments/148039600","pull_request_review_id":73221015,"id":148039600,"diff_hunk":"@@ -749,6 +760,12 @@ void GPBSetInt32IvarWithFieldInternal(GPBMessage *self,\n #endif\n   uint8_t *storage = (uint8_t *)self->messageStorage_;\n   int32_t *typePtr = (int32_t *)&storage[field->description_->offset];\n+  if (GPBGetHasIvar(self, hasIndex, fieldNumber) && *typePtr == value) return;","path":"objectivec/GPBUtilities.m","position":98,"original_position":98,"commit_id":"1649c77eeae392982da06dc44e34bd1ab606ee1e","original_commit_id":"1649c77eeae392982da06dc44e34bd1ab606ee1e","user":{"login":"dmaclach","id":320201,"avatar_url":"https://avatars3.githubusercontent.com/u/320201?v=4","gravatar_id":"","url":"https://api.github.com/users/dmaclach","html_url":"https://github.com/dmaclach","followers_url":"https://api.github.com/users/dmaclach/followers","following_url":"https://api.github.com/users/dmaclach/following{/other_user}","gists_url":"https://api.github.com/users/dmaclach/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaclach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaclach/subscriptions","organizations_url":"https://api.github.com/users/dmaclach/orgs","repos_url":"https://api.github.com/users/dmaclach/repos","events_url":"https://api.github.com/users/dmaclach/events{/privacy}","received_events_url":"https://api.github.com/users/dmaclach/received_events","type":"User","site_admin":false},"body":"Please use braces around blocks following if statements even if they are only one line.","created_at":"2017-10-31T15:51:28Z","updated_at":"2017-10-31T15:53:23Z","html_url":"https://github.com/google/protobuf/pull/3797#discussion_r148039600","pull_request_url":"https://api.github.com/repos/google/protobuf/pulls/3797","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments/148039600"},"html":{"href":"https://github.com/google/protobuf/pull/3797#discussion_r148039600"},"pull_request":{"href":"https://api.github.com/repos/google/protobuf/pulls/3797"}}},"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/3797","id":148559017,"html_url":"https://github.com/google/protobuf/pull/3797","diff_url":"https://github.com/google/protobuf/pull/3797.diff","patch_url":"https://github.com/google/protobuf/pull/3797.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/3797","number":3797,"state":"open","locked":false,"title":"ObjC: Implement KVO compliance.","user":{"login":"au-phiware","id":816686,"avatar_url":"https://avatars0.githubusercontent.com/u/816686?v=4","gravatar_id":"","url":"https://api.github.com/users/au-phiware","html_url":"https://github.com/au-phiware","followers_url":"https://api.github.com/users/au-phiware/followers","following_url":"https://api.github.com/users/au-phiware/following{/other_user}","gists_url":"https://api.github.com/users/au-phiware/gists{/gist_id}","starred_url":"https://api.github.com/users/au-phiware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/au-phiware/subscriptions","organizations_url":"https://api.github.com/users/au-phiware/orgs","repos_url":"https://api.github.com/users/au-phiware/repos","events_url":"https://api.github.com/users/au-phiware/events{/privacy}","received_events_url":"https://api.github.com/users/au-phiware/received_events","type":"User","site_admin":false},"body":"Introduces a much used feature (personally speaking).","created_at":"2017-10-25T02:54:59Z","updated_at":"2017-10-31T15:53:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0eff9958c90c6426a2fe92bc0b643fdf7404942a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/3797/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/3797/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/3797/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/1649c77eeae392982da06dc44e34bd1ab606ee1e","head":{"label":"au-phiware:objc-kvo","ref":"objc-kvo","sha":"1649c77eeae392982da06dc44e34bd1ab606ee1e","user":{"login":"au-phiware","id":816686,"avatar_url":"https://avatars0.githubusercontent.com/u/816686?v=4","gravatar_id":"","url":"https://api.github.com/users/au-phiware","html_url":"https://github.com/au-phiware","followers_url":"https://api.github.com/users/au-phiware/followers","following_url":"https://api.github.com/users/au-phiware/following{/other_user}","gists_url":"https://api.github.com/users/au-phiware/gists{/gist_id}","starred_url":"https://api.github.com/users/au-phiware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/au-phiware/subscriptions","organizations_url":"https://api.github.com/users/au-phiware/orgs","repos_url":"https://api.github.com/users/au-phiware/repos","events_url":"https://api.github.com/users/au-phiware/events{/privacy}","received_events_url":"https://api.github.com/users/au-phiware/received_events","type":"User","site_admin":false},"repo":{"id":108211532,"name":"protobuf","full_name":"au-phiware/protobuf","owner":{"login":"au-phiware","id":816686,"avatar_url":"https://avatars0.githubusercontent.com/u/816686?v=4","gravatar_id":"","url":"https://api.github.com/users/au-phiware","html_url":"https://github.com/au-phiware","followers_url":"https://api.github.com/users/au-phiware/followers","following_url":"https://api.github.com/users/au-phiware/following{/other_user}","gists_url":"https://api.github.com/users/au-phiware/gists{/gist_id}","starred_url":"https://api.github.com/users/au-phiware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/au-phiware/subscriptions","organizations_url":"https://api.github.com/users/au-phiware/orgs","repos_url":"https://api.github.com/users/au-phiware/repos","events_url":"https://api.github.com/users/au-phiware/events{/privacy}","received_events_url":"https://api.github.com/users/au-phiware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/au-phiware/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/au-phiware/protobuf","forks_url":"https://api.github.com/repos/au-phiware/protobuf/forks","keys_url":"https://api.github.com/repos/au-phiware/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/au-phiware/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/au-phiware/protobuf/teams","hooks_url":"https://api.github.com/repos/au-phiware/protobuf/hooks","issue_events_url":"https://api.github.com/repos/au-phiware/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/au-phiware/protobuf/events","assignees_url":"https://api.github.com/repos/au-phiware/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/au-phiware/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/au-phiware/protobuf/tags","blobs_url":"https://api.github.com/repos/au-phiware/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/au-phiware/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/au-phiware/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/au-phiware/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/au-phiware/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/au-phiware/protobuf/languages","stargazers_url":"https://api.github.com/repos/au-phiware/protobuf/stargazers","contributors_url":"https://api.github.com/repos/au-phiware/protobuf/contributors","subscribers_url":"https://api.github.com/repos/au-phiware/protobuf/subscribers","subscription_url":"https://api.github.com/repos/au-phiware/protobuf/subscription","commits_url":"https://api.github.com/repos/au-phiware/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/au-phiware/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/au-phiware/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/au-phiware/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/au-phiware/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/au-phiware/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/au-phiware/protobuf/merges","archive_url":"https://api.github.com/repos/au-phiware/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/au-phiware/protobuf/downloads","issues_url":"https://api.github.com/repos/au-phiware/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/au-phiware/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/au-phiware/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/au-phiware/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/au-phiware/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/au-phiware/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/au-phiware/protobuf/deployments","created_at":"2017-10-25T02:51:47Z","updated_at":"2017-10-25T02:51:57Z","pushed_at":"2017-10-25T05:06:09Z","git_url":"git://github.com/au-phiware/protobuf.git","ssh_url":"git@github.com:au-phiware/protobuf.git","clone_url":"https://github.com/au-phiware/protobuf.git","svn_url":"https://github.com/au-phiware/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":41979,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"ee8a0911cbaca2a1849a847bbdc523120d003a31","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/google/protobuf/deployments","created_at":"2014-08-26T15:52:15Z","updated_at":"2017-10-31T15:52:45Z","pushed_at":"2017-10-31T11:00:41Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":42402,"stargazers_count":21102,"watchers_count":21102,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6243,"mirror_url":null,"archived":false,"open_issues_count":716,"forks":6243,"open_issues":716,"watchers":21102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/3797"},"html":{"href":"https://github.com/google/protobuf/pull/3797"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/3797"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/3797/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/3797/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/3797/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/1649c77eeae392982da06dc44e34bd1ab606ee1e"}},"author_association":"NONE"}}
{"actor":{"display_login":"dmaclach"}}