{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/18","id":95337142,"html_url":"https://github.com/pixijs/pixi-gl-core/pull/18","diff_url":"https://github.com/pixijs/pixi-gl-core/pull/18.diff","patch_url":"https://github.com/pixijs/pixi-gl-core/pull/18.patch","issue_url":"https://api.github.com/repos/pixijs/pixi-gl-core/issues/18","number":18,"state":"closed","locked":false,"title":"Support Bind attribute location","user":{"login":"finscn","id":288367,"avatar_url":"https://avatars3.githubusercontent.com/u/288367?v=4","gravatar_id":"","url":"https://api.github.com/users/finscn","html_url":"https://github.com/finscn","followers_url":"https://api.github.com/users/finscn/followers","following_url":"https://api.github.com/users/finscn/following{/other_user}","gists_url":"https://api.github.com/users/finscn/gists{/gist_id}","starred_url":"https://api.github.com/users/finscn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finscn/subscriptions","organizations_url":"https://api.github.com/users/finscn/orgs","repos_url":"https://api.github.com/users/finscn/repos","events_url":"https://api.github.com/users/finscn/events{/privacy}","received_events_url":"https://api.github.com/users/finscn/received_events","type":"User","site_admin":false},"body":"When I try to extend PIXI.js, I found the  bindAttribLocation  is necessary in some cases.\r\n\r\nexample：\r\n\r\nI create many shader ,  they are share the same attributes :  indexBuffer, aVertexPosition and aTextureCoord, and the data also same.\r\n\r\nif PIXI support  bindAttribLocation, I could use one quad & vao ,  call quad.initVao one time , set quad.vertices & quad.uvs one time ,  and call quad.upload one time.\r\n\r\nAnd I hope  the  Shader of PIXI.js could support this feature too.\r\n\r\n","created_at":"2016-11-25T18:09:30Z","updated_at":"2017-11-20T16:34:26Z","closed_at":"2017-11-20T16:34:26Z","merged_at":null,"merge_commit_sha":"3fc6ec0de53fd29b70f33a879b9eaec147fa5795","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/18/commits","review_comments_url":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/18/comments","review_comment_url":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixijs/pixi-gl-core/issues/18/comments","statuses_url":"https://api.github.com/repos/pixijs/pixi-gl-core/statuses/24e5b2a95c08650b5440d90cfd2d6f8414ddcc31","head":{"label":"finscn:bindAttribLocation","ref":"bindAttribLocation","sha":"24e5b2a95c08650b5440d90cfd2d6f8414ddcc31","user":{"login":"finscn","id":288367,"avatar_url":"https://avatars3.githubusercontent.com/u/288367?v=4","gravatar_id":"","url":"https://api.github.com/users/finscn","html_url":"https://github.com/finscn","followers_url":"https://api.github.com/users/finscn/followers","following_url":"https://api.github.com/users/finscn/following{/other_user}","gists_url":"https://api.github.com/users/finscn/gists{/gist_id}","starred_url":"https://api.github.com/users/finscn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finscn/subscriptions","organizations_url":"https://api.github.com/users/finscn/orgs","repos_url":"https://api.github.com/users/finscn/repos","events_url":"https://api.github.com/users/finscn/events{/privacy}","received_events_url":"https://api.github.com/users/finscn/received_events","type":"User","site_admin":false},"repo":{"id":74776072,"name":"pixi-gl-core","full_name":"finscn/pixi-gl-core","owner":{"login":"finscn","id":288367,"avatar_url":"https://avatars3.githubusercontent.com/u/288367?v=4","gravatar_id":"","url":"https://api.github.com/users/finscn","html_url":"https://github.com/finscn","followers_url":"https://api.github.com/users/finscn/followers","following_url":"https://api.github.com/users/finscn/following{/other_user}","gists_url":"https://api.github.com/users/finscn/gists{/gist_id}","starred_url":"https://api.github.com/users/finscn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finscn/subscriptions","organizations_url":"https://api.github.com/users/finscn/orgs","repos_url":"https://api.github.com/users/finscn/repos","events_url":"https://api.github.com/users/finscn/events{/privacy}","received_events_url":"https://api.github.com/users/finscn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/finscn/pixi-gl-core","description":"A set of tidy little pixi objects that make working with WebGL simpler","fork":true,"url":"https://api.github.com/repos/finscn/pixi-gl-core","forks_url":"https://api.github.com/repos/finscn/pixi-gl-core/forks","keys_url":"https://api.github.com/repos/finscn/pixi-gl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finscn/pixi-gl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finscn/pixi-gl-core/teams","hooks_url":"https://api.github.com/repos/finscn/pixi-gl-core/hooks","issue_events_url":"https://api.github.com/repos/finscn/pixi-gl-core/issues/events{/number}","events_url":"https://api.github.com/repos/finscn/pixi-gl-core/events","assignees_url":"https://api.github.com/repos/finscn/pixi-gl-core/assignees{/user}","branches_url":"https://api.github.com/repos/finscn/pixi-gl-core/branches{/branch}","tags_url":"https://api.github.com/repos/finscn/pixi-gl-core/tags","blobs_url":"https://api.github.com/repos/finscn/pixi-gl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finscn/pixi-gl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finscn/pixi-gl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/finscn/pixi-gl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finscn/pixi-gl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/finscn/pixi-gl-core/languages","stargazers_url":"https://api.github.com/repos/finscn/pixi-gl-core/stargazers","contributors_url":"https://api.github.com/repos/finscn/pixi-gl-core/contributors","subscribers_url":"https://api.github.com/repos/finscn/pixi-gl-core/subscribers","subscription_url":"https://api.github.com/repos/finscn/pixi-gl-core/subscription","commits_url":"https://api.github.com/repos/finscn/pixi-gl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/finscn/pixi-gl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/finscn/pixi-gl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/finscn/pixi-gl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/finscn/pixi-gl-core/contents/{+path}","compare_url":"https://api.github.com/repos/finscn/pixi-gl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finscn/pixi-gl-core/merges","archive_url":"https://api.github.com/repos/finscn/pixi-gl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finscn/pixi-gl-core/downloads","issues_url":"https://api.github.com/repos/finscn/pixi-gl-core/issues{/number}","pulls_url":"https://api.github.com/repos/finscn/pixi-gl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/finscn/pixi-gl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/finscn/pixi-gl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finscn/pixi-gl-core/labels{/name}","releases_url":"https://api.github.com/repos/finscn/pixi-gl-core/releases{/id}","deployments_url":"https://api.github.com/repos/finscn/pixi-gl-core/deployments","created_at":"2016-11-25T17:12:41Z","updated_at":"2016-11-25T17:12:41Z","pushed_at":"2017-11-20T16:21:16Z","git_url":"git://github.com/finscn/pixi-gl-core.git","ssh_url":"git@github.com:finscn/pixi-gl-core.git","clone_url":"https://github.com/finscn/pixi-gl-core.git","svn_url":"https://github.com/finscn/pixi-gl-core","homepage":"http://pixijs.github.io/pixi-gl-core/","size":379,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pixijs:master","ref":"master","sha":"23f0d7763ed15800f2f6980b22a23ceefeac13f0","user":{"login":"pixijs","id":5406849,"avatar_url":"https://avatars0.githubusercontent.com/u/5406849?v=4","gravatar_id":"","url":"https://api.github.com/users/pixijs","html_url":"https://github.com/pixijs","followers_url":"https://api.github.com/users/pixijs/followers","following_url":"https://api.github.com/users/pixijs/following{/other_user}","gists_url":"https://api.github.com/users/pixijs/gists{/gist_id}","starred_url":"https://api.github.com/users/pixijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixijs/subscriptions","organizations_url":"https://api.github.com/users/pixijs/orgs","repos_url":"https://api.github.com/users/pixijs/repos","events_url":"https://api.github.com/users/pixijs/events{/privacy}","received_events_url":"https://api.github.com/users/pixijs/received_events","type":"Organization","site_admin":false},"repo":{"id":49059510,"name":"pixi-gl-core","full_name":"pixijs/pixi-gl-core","owner":{"login":"pixijs","id":5406849,"avatar_url":"https://avatars0.githubusercontent.com/u/5406849?v=4","gravatar_id":"","url":"https://api.github.com/users/pixijs","html_url":"https://github.com/pixijs","followers_url":"https://api.github.com/users/pixijs/followers","following_url":"https://api.github.com/users/pixijs/following{/other_user}","gists_url":"https://api.github.com/users/pixijs/gists{/gist_id}","starred_url":"https://api.github.com/users/pixijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixijs/subscriptions","organizations_url":"https://api.github.com/users/pixijs/orgs","repos_url":"https://api.github.com/users/pixijs/repos","events_url":"https://api.github.com/users/pixijs/events{/privacy}","received_events_url":"https://api.github.com/users/pixijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pixijs/pixi-gl-core","description":"A set of tidy little pixi objects that make working with WebGL simpler","fork":false,"url":"https://api.github.com/repos/pixijs/pixi-gl-core","forks_url":"https://api.github.com/repos/pixijs/pixi-gl-core/forks","keys_url":"https://api.github.com/repos/pixijs/pixi-gl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixijs/pixi-gl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixijs/pixi-gl-core/teams","hooks_url":"https://api.github.com/repos/pixijs/pixi-gl-core/hooks","issue_events_url":"https://api.github.com/repos/pixijs/pixi-gl-core/issues/events{/number}","events_url":"https://api.github.com/repos/pixijs/pixi-gl-core/events","assignees_url":"https://api.github.com/repos/pixijs/pixi-gl-core/assignees{/user}","branches_url":"https://api.github.com/repos/pixijs/pixi-gl-core/branches{/branch}","tags_url":"https://api.github.com/repos/pixijs/pixi-gl-core/tags","blobs_url":"https://api.github.com/repos/pixijs/pixi-gl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixijs/pixi-gl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixijs/pixi-gl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixijs/pixi-gl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixijs/pixi-gl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/pixijs/pixi-gl-core/languages","stargazers_url":"https://api.github.com/repos/pixijs/pixi-gl-core/stargazers","contributors_url":"https://api.github.com/repos/pixijs/pixi-gl-core/contributors","subscribers_url":"https://api.github.com/repos/pixijs/pixi-gl-core/subscribers","subscription_url":"https://api.github.com/repos/pixijs/pixi-gl-core/subscription","commits_url":"https://api.github.com/repos/pixijs/pixi-gl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixijs/pixi-gl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixijs/pixi-gl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixijs/pixi-gl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixijs/pixi-gl-core/contents/{+path}","compare_url":"https://api.github.com/repos/pixijs/pixi-gl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixijs/pixi-gl-core/merges","archive_url":"https://api.github.com/repos/pixijs/pixi-gl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixijs/pixi-gl-core/downloads","issues_url":"https://api.github.com/repos/pixijs/pixi-gl-core/issues{/number}","pulls_url":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/pixijs/pixi-gl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/pixijs/pixi-gl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixijs/pixi-gl-core/labels{/name}","releases_url":"https://api.github.com/repos/pixijs/pixi-gl-core/releases{/id}","deployments_url":"https://api.github.com/repos/pixijs/pixi-gl-core/deployments","created_at":"2016-01-05T10:36:42Z","updated_at":"2017-11-19T08:28:21Z","pushed_at":"2017-11-20T16:11:03Z","git_url":"git://github.com/pixijs/pixi-gl-core.git","ssh_url":"git@github.com:pixijs/pixi-gl-core.git","clone_url":"https://github.com/pixijs/pixi-gl-core.git","svn_url":"https://github.com/pixijs/pixi-gl-core","homepage":"http://pixijs.github.io/pixi-gl-core/","size":402,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":10,"forks":13,"open_issues":10,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/18"},"html":{"href":"https://github.com/pixijs/pixi-gl-core/pull/18"},"issue":{"href":"https://api.github.com/repos/pixijs/pixi-gl-core/issues/18"},"comments":{"href":"https://api.github.com/repos/pixijs/pixi-gl-core/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixijs/pixi-gl-core/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/pixijs/pixi-gl-core/statuses/24e5b2a95c08650b5440d90cfd2d6f8414ddcc31"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":52,"deletions":41,"changed_files":2}}
{"actor":{"display_login":"finscn"}}