{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/115900071","pull_request_review_id":37478432,"id":115900071,"diff_hunk":"@@ -202,6 +202,7 @@ stats-dump-period-sec = 600\n #   bzip2:  kBZip2Compression\n #   lz4:    kLZ4Compression\n #   lz4hc:  kLZ4HCCompression\n+#   zstd:   KZSTD","path":"etc/config-template.toml","position":4,"original_position":4,"commit_id":"9692bdf03dcdf476173a1690ea2b40779f2ea008","original_commit_id":"9692bdf03dcdf476173a1690ea2b40779f2ea008","user":{"login":"andelf","id":72891,"avatar_url":"https://avatars2.githubusercontent.com/u/72891?v=3","gravatar_id":"","url":"https://api.github.com/users/andelf","html_url":"https://github.com/andelf","followers_url":"https://api.github.com/users/andelf/followers","following_url":"https://api.github.com/users/andelf/following{/other_user}","gists_url":"https://api.github.com/users/andelf/gists{/gist_id}","starred_url":"https://api.github.com/users/andelf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andelf/subscriptions","organizations_url":"https://api.github.com/users/andelf/orgs","repos_url":"https://api.github.com/users/andelf/repos","events_url":"https://api.github.com/users/andelf/events{/privacy}","received_events_url":"https://api.github.com/users/andelf/received_events","type":"User","site_admin":false},"body":"yes, ref rocksdb:\r\n\r\n```cpp\r\nenum CompressionType : unsigned char {\r\n  // NOTE: do not change the values of existing entries, as these are\r\n  // part of the persistent format on disk.\r\n  kNoCompression = 0x0,\r\n  kSnappyCompression = 0x1,\r\n  kZlibCompression = 0x2,\r\n  kBZip2Compression = 0x3,\r\n  kLZ4Compression = 0x4,\r\n  kLZ4HCCompression = 0x5,\r\n  kXpressCompression = 0x6,\r\n  kZSTD = 0x7,\r\n\r\n  // Only use kZSTDNotFinalCompression if you have to use ZSTD lib older than\r\n  // 0.8.0 or consider a possibility of downgrading the service or copying\r\n  // the database files to another service running with an older version of\r\n  // RocksDB that doesn't have kZSTD. Otherwise, you should use kZSTD. We will\r\n  // eventually remove the option from the public API.\r\n  kZSTDNotFinalCompression = 0x40,\r\n\r\n  // kDisableCompressionOption is used to disable some compression options.\r\n  kDisableCompressionOption = 0xff,\r\n};\r\n```","created_at":"2017-05-11T03:45:11Z","updated_at":"2017-05-11T03:45:11Z","html_url":"https://github.com/pingcap/tikv/pull/1831#discussion_r115900071","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/1831","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/115900071"},"html":{"href":"https://github.com/pingcap/tikv/pull/1831#discussion_r115900071"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1831"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/1831","id":120013722,"html_url":"https://github.com/pingcap/tikv/pull/1831","diff_url":"https://github.com/pingcap/tikv/pull/1831.diff","patch_url":"https://github.com/pingcap/tikv/pull/1831.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/1831","number":1831,"state":"open","locked":false,"title":"rocksdb: support ZSTD compression type","user":{"login":"zhangjinpeng1987","id":19700528,"avatar_url":"https://avatars1.githubusercontent.com/u/19700528?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangjinpeng1987","html_url":"https://github.com/zhangjinpeng1987","followers_url":"https://api.github.com/users/zhangjinpeng1987/followers","following_url":"https://api.github.com/users/zhangjinpeng1987/following{/other_user}","gists_url":"https://api.github.com/users/zhangjinpeng1987/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangjinpeng1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangjinpeng1987/subscriptions","organizations_url":"https://api.github.com/users/zhangjinpeng1987/orgs","repos_url":"https://api.github.com/users/zhangjinpeng1987/repos","events_url":"https://api.github.com/users/zhangjinpeng1987/events{/privacy}","received_events_url":"https://api.github.com/users/zhangjinpeng1987/received_events","type":"User","site_admin":false},"body":"@lishihai9017 @siddontang PTAL","created_at":"2017-05-11T02:08:36Z","updated_at":"2017-05-11T03:45:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"325a1d895b2d2b3133e16670be2dbe9e7230a6f5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/1831/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/1831/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/1831/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/9692bdf03dcdf476173a1690ea2b40779f2ea008","head":{"label":"pingcap:zhangjinpeng/more-compression-types","ref":"zhangjinpeng/more-compression-types","sha":"9692bdf03dcdf476173a1690ea2b40779f2ea008","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2017-05-11T00:40:15Z","pushed_at":"2017-05-11T03:38:06Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"","size":7985,"stargazers_count":1801,"watchers_count":1801,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":108,"forks":178,"open_issues":108,"watchers":1801,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"d95bb3d1d461413935ac53e73f9d20fb4405d3a7","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2017-05-11T00:40:15Z","pushed_at":"2017-05-11T03:38:06Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"","size":7985,"stargazers_count":1801,"watchers_count":1801,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":108,"forks":178,"open_issues":108,"watchers":1801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1831"},"html":{"href":"https://github.com/pingcap/tikv/pull/1831"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/1831"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/1831/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1831/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1831/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/9692bdf03dcdf476173a1690ea2b40779f2ea008"}}}}
{"actor":{"display_login":"andelf"}}