{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/cling/pulls/comments/124256672","pull_request_review_id":46528818,"id":124256672,"diff_hunk":"@@ -628,20 +632,21 @@ static void stringifyPreprocSetting(PreprocessorOptions& PPOpts,\n   }\n \n   static bool\n-  SetupCompiler(CompilerInstance* CI, bool Lang = true, bool Targ = true) {\n+  SetupCompiler(CompilerInstance* CI, const CompilerOptions& CompilerOpts,\n+                bool Lang = true, bool Targ = true) {\n     // Set the language options, which cling needs.\n     // This may have already been done via a precompiled header\n     if (Lang)\n-      SetClingCustomLangOpts(CI->getLangOpts());\n+      SetClingCustomLangOpts(CI->getLangOpts(), CompilerOpts);\n \n     PreprocessorOptions& PPOpts = CI->getInvocation().getPreprocessorOpts();\n     SetPreprocessorFromBinary(PPOpts);\n \n     PPOpts.addMacroDef(\"__CLING__\");\n-    if (CI->getLangOpts().CPlusPlus11 == 1) {\n-      // http://llvm.org/bugs/show_bug.cgi?id=13530\n+    if (CI->getLangOpts().CPlusPlus11 == 1)\n       PPOpts.addMacroDef(\"__CLING__CXX11\");\n-    }\n+    if (CI->getLangOpts().CPlusPlus14 == 1)\n+      PPOpts.addMacroDef(\"__CLING__CXX14\");","path":"lib/Interpreter/CIFactory.cpp","position":119,"original_position":119,"commit_id":"cb43c3d18927ca02d77f777cc9c3104a1d9b8f9e","original_commit_id":"cb43c3d18927ca02d77f777cc9c3104a1d9b8f9e","user":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars1.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"body":"One day, I didn't think wise to mark __CLING__CXX17 until C++17 was ratified.","created_at":"2017-06-27T12:20:49Z","updated_at":"2017-06-27T12:20:49Z","html_url":"https://github.com/root-project/cling/pull/162#discussion_r124256672","pull_request_url":"https://api.github.com/repos/root-project/cling/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/root-project/cling/pulls/comments/124256672"},"html":{"href":"https://github.com/root-project/cling/pull/162#discussion_r124256672"},"pull_request":{"href":"https://api.github.com/repos/root-project/cling/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/root-project/cling/pulls/162","id":127616411,"html_url":"https://github.com/root-project/cling/pull/162","diff_url":"https://github.com/root-project/cling/pull/162.diff","patch_url":"https://github.com/root-project/cling/pull/162.patch","issue_url":"https://api.github.com/repos/root-project/cling/issues/162","number":162,"state":"open","locked":false,"title":"Allow GNU extensions when requested.","user":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars1.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"body":"& remove outdated comments.","created_at":"2017-06-27T05:53:07Z","updated_at":"2017-06-27T12:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"493c39e337bf9ce3069626445cb804759354a942","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/cling/pulls/162/commits","review_comments_url":"https://api.github.com/repos/root-project/cling/pulls/162/comments","review_comment_url":"https://api.github.com/repos/root-project/cling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/cling/issues/162/comments","statuses_url":"https://api.github.com/repos/root-project/cling/statuses/cb43c3d18927ca02d77f777cc9c3104a1d9b8f9e","head":{"label":"marsupial:PR/16","ref":"PR/16","sha":"cb43c3d18927ca02d77f777cc9c3104a1d9b8f9e","user":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars1.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"repo":{"id":60884930,"name":"cling","full_name":"marsupial/cling","owner":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars1.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marsupial/cling","description":"cling, the C++ interpreter","fork":true,"url":"https://api.github.com/repos/marsupial/cling","forks_url":"https://api.github.com/repos/marsupial/cling/forks","keys_url":"https://api.github.com/repos/marsupial/cling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marsupial/cling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marsupial/cling/teams","hooks_url":"https://api.github.com/repos/marsupial/cling/hooks","issue_events_url":"https://api.github.com/repos/marsupial/cling/issues/events{/number}","events_url":"https://api.github.com/repos/marsupial/cling/events","assignees_url":"https://api.github.com/repos/marsupial/cling/assignees{/user}","branches_url":"https://api.github.com/repos/marsupial/cling/branches{/branch}","tags_url":"https://api.github.com/repos/marsupial/cling/tags","blobs_url":"https://api.github.com/repos/marsupial/cling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marsupial/cling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marsupial/cling/git/refs{/sha}","trees_url":"https://api.github.com/repos/marsupial/cling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marsupial/cling/statuses/{sha}","languages_url":"https://api.github.com/repos/marsupial/cling/languages","stargazers_url":"https://api.github.com/repos/marsupial/cling/stargazers","contributors_url":"https://api.github.com/repos/marsupial/cling/contributors","subscribers_url":"https://api.github.com/repos/marsupial/cling/subscribers","subscription_url":"https://api.github.com/repos/marsupial/cling/subscription","commits_url":"https://api.github.com/repos/marsupial/cling/commits{/sha}","git_commits_url":"https://api.github.com/repos/marsupial/cling/git/commits{/sha}","comments_url":"https://api.github.com/repos/marsupial/cling/comments{/number}","issue_comment_url":"https://api.github.com/repos/marsupial/cling/issues/comments{/number}","contents_url":"https://api.github.com/repos/marsupial/cling/contents/{+path}","compare_url":"https://api.github.com/repos/marsupial/cling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marsupial/cling/merges","archive_url":"https://api.github.com/repos/marsupial/cling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marsupial/cling/downloads","issues_url":"https://api.github.com/repos/marsupial/cling/issues{/number}","pulls_url":"https://api.github.com/repos/marsupial/cling/pulls{/number}","milestones_url":"https://api.github.com/repos/marsupial/cling/milestones{/number}","notifications_url":"https://api.github.com/repos/marsupial/cling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marsupial/cling/labels{/name}","releases_url":"https://api.github.com/repos/marsupial/cling/releases{/id}","deployments_url":"https://api.github.com/repos/marsupial/cling/deployments","created_at":"2016-06-11T00:57:45Z","updated_at":"2016-06-11T00:57:46Z","pushed_at":"2017-06-27T07:14:26Z","git_url":"git://github.com/marsupial/cling.git","ssh_url":"git@github.com:marsupial/cling.git","clone_url":"https://github.com/marsupial/cling.git","svn_url":"https://github.com/marsupial/cling","homepage":null,"size":18191,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"8fae02604532060e7de8d3b5bb9279be355715bc","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars2.githubusercontent.com/u/6450093?v=3","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":49210203,"name":"cling","full_name":"root-project/cling","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars2.githubusercontent.com/u/6450093?v=3","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/cling","description":"The cling C++ interpreter","fork":false,"url":"https://api.github.com/repos/root-project/cling","forks_url":"https://api.github.com/repos/root-project/cling/forks","keys_url":"https://api.github.com/repos/root-project/cling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/cling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/cling/teams","hooks_url":"https://api.github.com/repos/root-project/cling/hooks","issue_events_url":"https://api.github.com/repos/root-project/cling/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/cling/events","assignees_url":"https://api.github.com/repos/root-project/cling/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/cling/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/cling/tags","blobs_url":"https://api.github.com/repos/root-project/cling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/cling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/cling/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/cling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/cling/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/cling/languages","stargazers_url":"https://api.github.com/repos/root-project/cling/stargazers","contributors_url":"https://api.github.com/repos/root-project/cling/contributors","subscribers_url":"https://api.github.com/repos/root-project/cling/subscribers","subscription_url":"https://api.github.com/repos/root-project/cling/subscription","commits_url":"https://api.github.com/repos/root-project/cling/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/cling/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/cling/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/cling/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/cling/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/cling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/cling/merges","archive_url":"https://api.github.com/repos/root-project/cling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/cling/downloads","issues_url":"https://api.github.com/repos/root-project/cling/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/cling/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/cling/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/cling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/cling/labels{/name}","releases_url":"https://api.github.com/repos/root-project/cling/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/cling/deployments","created_at":"2016-01-07T14:45:35Z","updated_at":"2017-06-27T05:36:55Z","pushed_at":"2017-06-27T08:31:21Z","git_url":"git://github.com/root-project/cling.git","ssh_url":"git@github.com:root-project/cling.git","clone_url":"https://github.com/root-project/cling.git","svn_url":"https://github.com/root-project/cling","homepage":"","size":17446,"stargazers_count":218,"watchers_count":218,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":14,"forks":29,"open_issues":14,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/cling/pulls/162"},"html":{"href":"https://github.com/root-project/cling/pull/162"},"issue":{"href":"https://api.github.com/repos/root-project/cling/issues/162"},"comments":{"href":"https://api.github.com/repos/root-project/cling/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/cling/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/cling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/cling/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/cling/statuses/cb43c3d18927ca02d77f777cc9c3104a1d9b8f9e"}}}}
{"actor":{"display_login":"marsupial"}}