{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/1487","repository_url":"https://api.github.com/repos/openzipkin/zipkin","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1487/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1487/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1487/events","html_url":"https://github.com/openzipkin/zipkin/pull/1487","id":200744011,"number":1487,"title":"do not silently drop subsequent spans missing a parent","user":{"login":"cburroughs","id":24433,"avatar_url":"https://avatars.githubusercontent.com/u/24433?v=3","gravatar_id":"","url":"https://api.github.com/users/cburroughs","html_url":"https://github.com/cburroughs","followers_url":"https://api.github.com/users/cburroughs/followers","following_url":"https://api.github.com/users/cburroughs/following{/other_user}","gists_url":"https://api.github.com/users/cburroughs/gists{/gist_id}","starred_url":"https://api.github.com/users/cburroughs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburroughs/subscriptions","organizations_url":"https://api.github.com/users/cburroughs/orgs","repos_url":"https://api.github.com/users/cburroughs/repos","events_url":"https://api.github.com/users/cburroughs/events{/privacy}","received_events_url":"https://api.github.com/users/cburroughs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-01-13T22:11:41Z","updated_at":"2017-01-16T10:18:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1487","html_url":"https://github.com/openzipkin/zipkin/pull/1487","diff_url":"https://github.com/openzipkin/zipkin/pull/1487.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/1487.patch"},"body":"Currently zipkin models traces as a tree of spans.  During the\r\nconversation from a list (or whatever the underlying storage engine\r\nuses) to a tree, spans are dropped if more than one of them is missing\r\na parentId (it is a \"root\" node).  This appears to be an unintentional\r\nregression (possibly around 9d8261a33c3adaad9aecd290744b651290c72e24),\r\nsince the comment still indicate a workaround for this problem:\r\nattribute missing parents to root.\r\n\r\nThis is still imperfect, but exposes it to the the user so they can\r\ndebug the instrumentation problem instead of silently dropping data.\r\nNote that the workaround only applies when constructing a tree\r\ninternally the actual spans returned by the API still have no\r\nparentID, and this is what is displayed in the web ui.\r\n\r\nThis problem is alluded to in #324, but the thrust of that ticket is\r\nmodeling asynchronous actions.\r\n\r\nHighlighting suspect traces is discussed in #1484 and this condition\r\nwould be a prime candidate."},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/272822747","html_url":"https://github.com/openzipkin/zipkin/pull/1487#issuecomment-272822747","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1487","id":272822747,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2017-01-16T10:18:22Z","updated_at":"2017-01-16T10:18:22Z","body":"At first, I was a bit hesitant, but after seeing this in action, I think it would be silly not to merge. Thanks, @cburroughs!"}}
{"actor":{"display_login":"adriancole"}}