{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/154804144","pull_request_review_id":81022686,"id":154804144,"diff_hunk":"@@ -945,7 +945,7 @@ namespace {\n         llvm::MapVector<CanType, llvm::Value *> &typeToMetadataVec,\n         SILType T) const override {\n       auto canType = T.getSwiftRValueType();\n-      assert(!canType->hasArchetype() &&\n+      assert(!canType->getWithoutSpecifierType()->is<ArchetypeType>() &&","path":"lib/IRGen/GenEnum.cpp","position":5,"original_position":5,"commit_id":"b890e3ebff4f793fd577e7d0c2cd0a1be1b74c4f","original_commit_id":"b890e3ebff4f793fd577e7d0c2cd0a1be1b74c4f","user":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"body":"Do you have an example where getWithoutSpecifierType() is not a no-op?","created_at":"2017-12-04T23:13:43Z","updated_at":"2017-12-04T23:13:43Z","html_url":"https://github.com/apple/swift/pull/13257#discussion_r154804144","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/13257","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/154804144"},"html":{"href":"https://github.com/apple/swift/pull/13257#discussion_r154804144"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/13257"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/13257","id":156326561,"html_url":"https://github.com/apple/swift/pull/13257","diff_url":"https://github.com/apple/swift/pull/13257.diff","patch_url":"https://github.com/apple/swift/pull/13257.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/13257","number":13257,"state":"open","locked":false,"title":"Fixes an invalid assert in No Payload Enum's collectArchetypeMetadata: the type itself might contain an Archetype. We need to check that it is not an Archetype itself","user":{"login":"shajrawi","id":17753158,"avatar_url":"https://avatars3.githubusercontent.com/u/17753158?v=4","gravatar_id":"","url":"https://api.github.com/users/shajrawi","html_url":"https://github.com/shajrawi","followers_url":"https://api.github.com/users/shajrawi/followers","following_url":"https://api.github.com/users/shajrawi/following{/other_user}","gists_url":"https://api.github.com/users/shajrawi/gists{/gist_id}","starred_url":"https://api.github.com/users/shajrawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajrawi/subscriptions","organizations_url":"https://api.github.com/users/shajrawi/orgs","repos_url":"https://api.github.com/users/shajrawi/repos","events_url":"https://api.github.com/users/shajrawi/events{/privacy}","received_events_url":"https://api.github.com/users/shajrawi/received_events","type":"User","site_admin":false},"body":"radar rdar://problem/35831517","created_at":"2017-12-04T22:44:05Z","updated_at":"2017-12-04T23:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82a0b0bff65fad43dd2229da297dad660342669e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/13257/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/13257/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/13257/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/b890e3ebff4f793fd577e7d0c2cd0a1be1b74c4f","head":{"label":"shajrawi:fix_outline_assert","ref":"fix_outline_assert","sha":"b890e3ebff4f793fd577e7d0c2cd0a1be1b74c4f","user":{"login":"shajrawi","id":17753158,"avatar_url":"https://avatars3.githubusercontent.com/u/17753158?v=4","gravatar_id":"","url":"https://api.github.com/users/shajrawi","html_url":"https://github.com/shajrawi","followers_url":"https://api.github.com/users/shajrawi/followers","following_url":"https://api.github.com/users/shajrawi/following{/other_user}","gists_url":"https://api.github.com/users/shajrawi/gists{/gist_id}","starred_url":"https://api.github.com/users/shajrawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajrawi/subscriptions","organizations_url":"https://api.github.com/users/shajrawi/orgs","repos_url":"https://api.github.com/users/shajrawi/repos","events_url":"https://api.github.com/users/shajrawi/events{/privacy}","received_events_url":"https://api.github.com/users/shajrawi/received_events","type":"User","site_admin":false},"repo":{"id":66983924,"name":"swift","full_name":"shajrawi/swift","owner":{"login":"shajrawi","id":17753158,"avatar_url":"https://avatars3.githubusercontent.com/u/17753158?v=4","gravatar_id":"","url":"https://api.github.com/users/shajrawi","html_url":"https://github.com/shajrawi","followers_url":"https://api.github.com/users/shajrawi/followers","following_url":"https://api.github.com/users/shajrawi/following{/other_user}","gists_url":"https://api.github.com/users/shajrawi/gists{/gist_id}","starred_url":"https://api.github.com/users/shajrawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shajrawi/subscriptions","organizations_url":"https://api.github.com/users/shajrawi/orgs","repos_url":"https://api.github.com/users/shajrawi/repos","events_url":"https://api.github.com/users/shajrawi/events{/privacy}","received_events_url":"https://api.github.com/users/shajrawi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shajrawi/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/shajrawi/swift","forks_url":"https://api.github.com/repos/shajrawi/swift/forks","keys_url":"https://api.github.com/repos/shajrawi/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shajrawi/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shajrawi/swift/teams","hooks_url":"https://api.github.com/repos/shajrawi/swift/hooks","issue_events_url":"https://api.github.com/repos/shajrawi/swift/issues/events{/number}","events_url":"https://api.github.com/repos/shajrawi/swift/events","assignees_url":"https://api.github.com/repos/shajrawi/swift/assignees{/user}","branches_url":"https://api.github.com/repos/shajrawi/swift/branches{/branch}","tags_url":"https://api.github.com/repos/shajrawi/swift/tags","blobs_url":"https://api.github.com/repos/shajrawi/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shajrawi/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shajrawi/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/shajrawi/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shajrawi/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/shajrawi/swift/languages","stargazers_url":"https://api.github.com/repos/shajrawi/swift/stargazers","contributors_url":"https://api.github.com/repos/shajrawi/swift/contributors","subscribers_url":"https://api.github.com/repos/shajrawi/swift/subscribers","subscription_url":"https://api.github.com/repos/shajrawi/swift/subscription","commits_url":"https://api.github.com/repos/shajrawi/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/shajrawi/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/shajrawi/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/shajrawi/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/shajrawi/swift/contents/{+path}","compare_url":"https://api.github.com/repos/shajrawi/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shajrawi/swift/merges","archive_url":"https://api.github.com/repos/shajrawi/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shajrawi/swift/downloads","issues_url":"https://api.github.com/repos/shajrawi/swift/issues{/number}","pulls_url":"https://api.github.com/repos/shajrawi/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/shajrawi/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/shajrawi/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shajrawi/swift/labels{/name}","releases_url":"https://api.github.com/repos/shajrawi/swift/releases{/id}","deployments_url":"https://api.github.com/repos/shajrawi/swift/deployments","created_at":"2016-08-30T23:02:28Z","updated_at":"2016-08-30T23:02:52Z","pushed_at":"2017-12-04T22:43:23Z","git_url":"git://github.com/shajrawi/swift.git","ssh_url":"git@github.com:shajrawi/swift.git","clone_url":"https://github.com/shajrawi/swift.git","svn_url":"https://github.com/shajrawi/swift","homepage":"https://swift.org/","size":231109,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"1a7f1911b8f87ef6cd4225850ef706ad6b721162","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-12-04T23:06:01Z","pushed_at":"2017-12-04T23:10:00Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":244943,"stargazers_count":41796,"watchers_count":41796,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6555,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6555,"open_issues":217,"watchers":41796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/13257"},"html":{"href":"https://github.com/apple/swift/pull/13257"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/13257"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/13257/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/13257/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/13257/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/b890e3ebff4f793fd577e7d0c2cd0a1be1b74c4f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"slavapestov"}}