{"action":"created","comment":{"url":"https://api.github.com/repos/eayunstack/senlin/pulls/comments/128140194","pull_request_review_id":50790685,"id":128140194,"diff_hunk":"@@ -548,24 +547,21 @@ def do_create(self, obj):\n                 hints.update({'group': group_id})\n                 kwargs['scheduler_hints'] = hints\n \n+        server = None\n+        resource_id = None\n         try:\n             server = self.compute(obj).server_create(**kwargs)\n             self.compute(obj).wait_for_server(server.id)\n+            if float_ip:\n+                self.compute(obj).server_floatingip_associate(server.id,\n+                                                              float_ip)\n+            return server.id","path":"senlin/profiles/os/nova/server.py","position":37,"original_position":37,"commit_id":"f71ebc450ae22d7979cd4c426aa0f8f470d40ed0","original_commit_id":"f71ebc450ae22d7979cd4c426aa0f8f470d40ed0","user":{"login":"huntxu","id":137809,"avatar_url":"https://avatars3.githubusercontent.com/u/137809?v=4","gravatar_id":"","url":"https://api.github.com/users/huntxu","html_url":"https://github.com/huntxu","followers_url":"https://api.github.com/users/huntxu/followers","following_url":"https://api.github.com/users/huntxu/following{/other_user}","gists_url":"https://api.github.com/users/huntxu/gists{/gist_id}","starred_url":"https://api.github.com/users/huntxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntxu/subscriptions","organizations_url":"https://api.github.com/users/huntxu/orgs","repos_url":"https://api.github.com/users/huntxu/repos","events_url":"https://api.github.com/users/huntxu/events{/privacy}","received_events_url":"https://api.github.com/users/huntxu/received_events","type":"User","site_admin":false},"body":"明白，因为原来代码也有相应的异常处理，所以不是很明白移动它的原因。","created_at":"2017-07-19T02:24:08Z","updated_at":"2017-07-19T02:24:08Z","html_url":"https://github.com/eayunstack/senlin/pull/42#discussion_r128140194","pull_request_url":"https://api.github.com/repos/eayunstack/senlin/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/eayunstack/senlin/pulls/comments/128140194"},"html":{"href":"https://github.com/eayunstack/senlin/pull/42#discussion_r128140194"},"pull_request":{"href":"https://api.github.com/repos/eayunstack/senlin/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/eayunstack/senlin/pulls/42","id":130986608,"html_url":"https://github.com/eayunstack/senlin/pull/42","diff_url":"https://github.com/eayunstack/senlin/pull/42.diff","patch_url":"https://github.com/eayunstack/senlin/pull/42.patch","issue_url":"https://api.github.com/repos/eayunstack/senlin/issues/42","number":42,"state":"open","locked":false,"title":"Fix senlin nova create error","user":{"login":"fabian4","id":10691174,"avatar_url":"https://avatars1.githubusercontent.com/u/10691174?v=4","gravatar_id":"","url":"https://api.github.com/users/fabian4","html_url":"https://github.com/fabian4","followers_url":"https://api.github.com/users/fabian4/followers","following_url":"https://api.github.com/users/fabian4/following{/other_user}","gists_url":"https://api.github.com/users/fabian4/gists{/gist_id}","starred_url":"https://api.github.com/users/fabian4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabian4/subscriptions","organizations_url":"https://api.github.com/users/fabian4/orgs","repos_url":"https://api.github.com/users/fabian4/repos","events_url":"https://api.github.com/users/fabian4/events{/privacy}","received_events_url":"https://api.github.com/users/fabian4/received_events","type":"User","site_admin":false},"body":"This patch fix nova create hand error, the node don't finish the status\r\nupdate when create appear error.\r\n\r\nBug-ES #10574\r\nhttp://192.168.15.2/issues/10574\r\n\r\nSigned-off-by: Yuanbin.Chen <cybing4@gmail.com>","created_at":"2017-07-18T01:46:37Z","updated_at":"2017-07-19T02:24:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cea9afd7639b1cac8ec5c85f7c3a17103f9768c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eayunstack/senlin/pulls/42/commits","review_comments_url":"https://api.github.com/repos/eayunstack/senlin/pulls/42/comments","review_comment_url":"https://api.github.com/repos/eayunstack/senlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eayunstack/senlin/issues/42/comments","statuses_url":"https://api.github.com/repos/eayunstack/senlin/statuses/f71ebc450ae22d7979cd4c426aa0f8f470d40ed0","head":{"label":"fabian4:fix_nova_create","ref":"fix_nova_create","sha":"f71ebc450ae22d7979cd4c426aa0f8f470d40ed0","user":{"login":"fabian4","id":10691174,"avatar_url":"https://avatars1.githubusercontent.com/u/10691174?v=4","gravatar_id":"","url":"https://api.github.com/users/fabian4","html_url":"https://github.com/fabian4","followers_url":"https://api.github.com/users/fabian4/followers","following_url":"https://api.github.com/users/fabian4/following{/other_user}","gists_url":"https://api.github.com/users/fabian4/gists{/gist_id}","starred_url":"https://api.github.com/users/fabian4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabian4/subscriptions","organizations_url":"https://api.github.com/users/fabian4/orgs","repos_url":"https://api.github.com/users/fabian4/repos","events_url":"https://api.github.com/users/fabian4/events{/privacy}","received_events_url":"https://api.github.com/users/fabian4/received_events","type":"User","site_admin":false},"repo":{"id":74536035,"name":"senlin","full_name":"fabian4/senlin","owner":{"login":"fabian4","id":10691174,"avatar_url":"https://avatars1.githubusercontent.com/u/10691174?v=4","gravatar_id":"","url":"https://api.github.com/users/fabian4","html_url":"https://github.com/fabian4","followers_url":"https://api.github.com/users/fabian4/followers","following_url":"https://api.github.com/users/fabian4/following{/other_user}","gists_url":"https://api.github.com/users/fabian4/gists{/gist_id}","starred_url":"https://api.github.com/users/fabian4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabian4/subscriptions","organizations_url":"https://api.github.com/users/fabian4/orgs","repos_url":"https://api.github.com/users/fabian4/repos","events_url":"https://api.github.com/users/fabian4/events{/privacy}","received_events_url":"https://api.github.com/users/fabian4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabian4/senlin","description":"Clustering service for managing homogeneous objects in OpenStack","fork":true,"url":"https://api.github.com/repos/fabian4/senlin","forks_url":"https://api.github.com/repos/fabian4/senlin/forks","keys_url":"https://api.github.com/repos/fabian4/senlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabian4/senlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabian4/senlin/teams","hooks_url":"https://api.github.com/repos/fabian4/senlin/hooks","issue_events_url":"https://api.github.com/repos/fabian4/senlin/issues/events{/number}","events_url":"https://api.github.com/repos/fabian4/senlin/events","assignees_url":"https://api.github.com/repos/fabian4/senlin/assignees{/user}","branches_url":"https://api.github.com/repos/fabian4/senlin/branches{/branch}","tags_url":"https://api.github.com/repos/fabian4/senlin/tags","blobs_url":"https://api.github.com/repos/fabian4/senlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabian4/senlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabian4/senlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabian4/senlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabian4/senlin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabian4/senlin/languages","stargazers_url":"https://api.github.com/repos/fabian4/senlin/stargazers","contributors_url":"https://api.github.com/repos/fabian4/senlin/contributors","subscribers_url":"https://api.github.com/repos/fabian4/senlin/subscribers","subscription_url":"https://api.github.com/repos/fabian4/senlin/subscription","commits_url":"https://api.github.com/repos/fabian4/senlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabian4/senlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabian4/senlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabian4/senlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabian4/senlin/contents/{+path}","compare_url":"https://api.github.com/repos/fabian4/senlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabian4/senlin/merges","archive_url":"https://api.github.com/repos/fabian4/senlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabian4/senlin/downloads","issues_url":"https://api.github.com/repos/fabian4/senlin/issues{/number}","pulls_url":"https://api.github.com/repos/fabian4/senlin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabian4/senlin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabian4/senlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabian4/senlin/labels{/name}","releases_url":"https://api.github.com/repos/fabian4/senlin/releases{/id}","deployments_url":"https://api.github.com/repos/fabian4/senlin/deployments","created_at":"2016-11-23T03:13:43Z","updated_at":"2016-11-23T03:13:45Z","pushed_at":"2017-07-18T09:49:53Z","git_url":"git://github.com/fabian4/senlin.git","ssh_url":"git@github.com:fabian4/senlin.git","clone_url":"https://github.com/fabian4/senlin.git","svn_url":"https://github.com/fabian4/senlin","homepage":"http://openstack.org","size":9872,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eayunstack:Development","ref":"Development","sha":"8cf02da4c079ac83406b42c005d84f131ad2eb35","user":{"login":"eayunstack","id":8656371,"avatar_url":"https://avatars0.githubusercontent.com/u/8656371?v=4","gravatar_id":"","url":"https://api.github.com/users/eayunstack","html_url":"https://github.com/eayunstack","followers_url":"https://api.github.com/users/eayunstack/followers","following_url":"https://api.github.com/users/eayunstack/following{/other_user}","gists_url":"https://api.github.com/users/eayunstack/gists{/gist_id}","starred_url":"https://api.github.com/users/eayunstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eayunstack/subscriptions","organizations_url":"https://api.github.com/users/eayunstack/orgs","repos_url":"https://api.github.com/users/eayunstack/repos","events_url":"https://api.github.com/users/eayunstack/events{/privacy}","received_events_url":"https://api.github.com/users/eayunstack/received_events","type":"Organization","site_admin":false},"repo":{"id":77420912,"name":"senlin","full_name":"eayunstack/senlin","owner":{"login":"eayunstack","id":8656371,"avatar_url":"https://avatars0.githubusercontent.com/u/8656371?v=4","gravatar_id":"","url":"https://api.github.com/users/eayunstack","html_url":"https://github.com/eayunstack","followers_url":"https://api.github.com/users/eayunstack/followers","following_url":"https://api.github.com/users/eayunstack/following{/other_user}","gists_url":"https://api.github.com/users/eayunstack/gists{/gist_id}","starred_url":"https://api.github.com/users/eayunstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eayunstack/subscriptions","organizations_url":"https://api.github.com/users/eayunstack/orgs","repos_url":"https://api.github.com/users/eayunstack/repos","events_url":"https://api.github.com/users/eayunstack/events{/privacy}","received_events_url":"https://api.github.com/users/eayunstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eayunstack/senlin","description":"Clustering service for managing homogeneous objects in OpenStack","fork":true,"url":"https://api.github.com/repos/eayunstack/senlin","forks_url":"https://api.github.com/repos/eayunstack/senlin/forks","keys_url":"https://api.github.com/repos/eayunstack/senlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eayunstack/senlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eayunstack/senlin/teams","hooks_url":"https://api.github.com/repos/eayunstack/senlin/hooks","issue_events_url":"https://api.github.com/repos/eayunstack/senlin/issues/events{/number}","events_url":"https://api.github.com/repos/eayunstack/senlin/events","assignees_url":"https://api.github.com/repos/eayunstack/senlin/assignees{/user}","branches_url":"https://api.github.com/repos/eayunstack/senlin/branches{/branch}","tags_url":"https://api.github.com/repos/eayunstack/senlin/tags","blobs_url":"https://api.github.com/repos/eayunstack/senlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eayunstack/senlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eayunstack/senlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/eayunstack/senlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eayunstack/senlin/statuses/{sha}","languages_url":"https://api.github.com/repos/eayunstack/senlin/languages","stargazers_url":"https://api.github.com/repos/eayunstack/senlin/stargazers","contributors_url":"https://api.github.com/repos/eayunstack/senlin/contributors","subscribers_url":"https://api.github.com/repos/eayunstack/senlin/subscribers","subscription_url":"https://api.github.com/repos/eayunstack/senlin/subscription","commits_url":"https://api.github.com/repos/eayunstack/senlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/eayunstack/senlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/eayunstack/senlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/eayunstack/senlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/eayunstack/senlin/contents/{+path}","compare_url":"https://api.github.com/repos/eayunstack/senlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eayunstack/senlin/merges","archive_url":"https://api.github.com/repos/eayunstack/senlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eayunstack/senlin/downloads","issues_url":"https://api.github.com/repos/eayunstack/senlin/issues{/number}","pulls_url":"https://api.github.com/repos/eayunstack/senlin/pulls{/number}","milestones_url":"https://api.github.com/repos/eayunstack/senlin/milestones{/number}","notifications_url":"https://api.github.com/repos/eayunstack/senlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eayunstack/senlin/labels{/name}","releases_url":"https://api.github.com/repos/eayunstack/senlin/releases{/id}","deployments_url":"https://api.github.com/repos/eayunstack/senlin/deployments","created_at":"2016-12-27T02:52:57Z","updated_at":"2016-12-27T02:53:01Z","pushed_at":"2017-07-18T09:52:23Z","git_url":"git://github.com/eayunstack/senlin.git","ssh_url":"git@github.com:eayunstack/senlin.git","clone_url":"https://github.com/eayunstack/senlin.git","svn_url":"https://github.com/eayunstack/senlin","homepage":"http://openstack.org","size":8766,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eayunstack/senlin/pulls/42"},"html":{"href":"https://github.com/eayunstack/senlin/pull/42"},"issue":{"href":"https://api.github.com/repos/eayunstack/senlin/issues/42"},"comments":{"href":"https://api.github.com/repos/eayunstack/senlin/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/eayunstack/senlin/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/eayunstack/senlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eayunstack/senlin/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/eayunstack/senlin/statuses/f71ebc450ae22d7979cd4c426aa0f8f470d40ed0"}}}}
{"actor":{"display_login":"huntxu"}}