{"action":"created","issue":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/3331","repository_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3","labels_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/3331/labels{/name}","comments_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/3331/comments","events_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/3331/events","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/3331","id":157212494,"number":3331,"title":"Adding retry logic for tiles and images","user":{"login":"gjn","id":2572317,"avatar_url":"https://avatars1.githubusercontent.com/u/2572317?v=3","gravatar_id":"","url":"https://api.github.com/users/gjn","html_url":"https://github.com/gjn","followers_url":"https://api.github.com/users/gjn/followers","following_url":"https://api.github.com/users/gjn/following{/other_user}","gists_url":"https://api.github.com/users/gjn/gists{/gist_id}","starred_url":"https://api.github.com/users/gjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjn/subscriptions","organizations_url":"https://api.github.com/users/gjn/orgs","repos_url":"https://api.github.com/users/gjn/repos","events_url":"https://api.github.com/users/gjn/events{/privacy}","received_events_url":"https://api.github.com/users/gjn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-05-27T13:56:55Z","updated_at":"2017-06-26T09:00:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/3331","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/3331","diff_url":"https://github.com/geoadmin/mf-geoadmin3/pull/3331.diff","patch_url":"https://github.com/geoadmin/mf-geoadmin3/pull/3331.patch"},"body":"This adresses and potentially fixes https://github.com/geoadmin/mf-geoadmin3/issues/3206\n\nIn OL2, the libary supported a number of retries per tiles. This came in handy when the network was not stable (2G, wifi holes, etc). OL3 removed this out of the box. There an PR in ol3 for this https://github.com/openlayers/ol3/pull/5270, but it lacks a little bit of subtility (no way to limit number of retries or to wait between retries).\n\nThis PR allows to define the maximum number of retries (currently 100) and the interval between 2 retries (currently 5 seconds). It supports wmts layers and integrated wms layers (single tile and tiled)\n\nTo test it, you need to have either a spotty internet connection or work with the developer console (F12 in chrome). Open the network tab and when tiles start loading, cut the internet connection [1] by selecting 'offline' from the dropdown list. The map is not complete and contains white tiles. After a while, re-enable the internet connection (no throttle option) and the tiles/images should appear again.\n\nA couple of questions:\n- I'm not sure about the current settings (interval, max_retries)\n- Should be tested together with offline -> @oterral \n- Should be tested more with mobile device on the field.\n\n[Testlink](https://mf-geoadmin3.int.bgdi.ch/gjn_reload/index.html?lang=de&topic=ech&bgLayer=ch.swisstopo.swissimage&X=199206.24&Y=689021.88&zoom=2&layers=ch.bakom.mobil-antennenstandorte-gsm,ch.bazl.luftfahrthindernis)\n\n[1]\n![image](https://cloud.githubusercontent.com/assets/2572317/15609975/47398f5c-2423-11e6-904f-4e8eca444c4a.png)\n\nping @oterral @davidoesch @procrastinatio \n"},"comment":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/comments/311002597","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/3331#issuecomment-311002597","issue_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/3331","id":311002597,"user":{"login":"oterral","id":621420,"avatar_url":"https://avatars3.githubusercontent.com/u/621420?v=3","gravatar_id":"","url":"https://api.github.com/users/oterral","html_url":"https://github.com/oterral","followers_url":"https://api.github.com/users/oterral/followers","following_url":"https://api.github.com/users/oterral/following{/other_user}","gists_url":"https://api.github.com/users/oterral/gists{/gist_id}","starred_url":"https://api.github.com/users/oterral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oterral/subscriptions","organizations_url":"https://api.github.com/users/oterral/orgs","repos_url":"https://api.github.com/users/oterral/repos","events_url":"https://api.github.com/users/oterral/events{/privacy}","received_events_url":"https://api.github.com/users/oterral/received_events","type":"User","site_admin":false},"created_at":"2017-06-26T09:00:14Z","updated_at":"2017-06-26T09:00:14Z","body":"I think this PR can still be useful . \r\n\r\nBut I've seen that the offline detection seems broken on that branch. Click on offline checkbox in dev tools should display the offline header\r\n\r\nand missing tests."}}
{"actor":{"display_login":"oterral"}}