{"action":"created","comment":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/110827413","pull_request_review_id":32023392,"id":110827413,"diff_hunk":"@@ -106,35 +106,29 @@ void MomentumRangeParticleGun::generateParticle(Gaudi::LorentzVector& momentum,\n }\n \n StatusCode MomentumRangeParticleGun::getNextEvent(HepMC::GenEvent& theEvent) {\n-  Gaudi::LorentzVector theFourMomentum ;\n-  Gaudi::LorentzVector origin ;\n+  Gaudi::LorentzVector theFourMomentum;\n+  Gaudi::LorentzVector origin;\n   // note: pgdid is set in function generateParticle\n-  int thePdgId ;\n-  generateParticle( theFourMomentum , origin , thePdgId );\n+  int thePdgId;\n+  generateParticle(theFourMomentum, origin, thePdgId);\n \n   // create HepMC Vertex --\n   // by calling add_vertex(), the hepmc event is given ownership\n   //  of the vertex\n-  HepMC::GenVertex * v = new HepMC::GenVertex( HepMC::FourVector( origin.X() ,\n-\t\t\t\t\t\t\t\t  origin.Y() ,\n-\t\t\t\t\t\t\t\t  origin.Z() ,\n-\t\t\t\t\t\t\t\t  origin.T() ) ) ;\n+  HepMC::GenVertex* v = new HepMC::GenVertex(HepMC::FourVector(origin.X(), origin.Y(), origin.Z(), origin.T()));\n   // create HepMC particle --\n   // by calling add_particle_out(), the hepmc vertex is given ownership\n   // of the particle\n-  HepMC::GenParticle * p = new HepMC::GenParticle( HepMC::FourVector( theFourMomentum.Px() ,\n-\t\t\t\t\t\t\t\t      theFourMomentum.Py() ,\n-\t\t\t\t\t\t\t\t      theFourMomentum.Pz() ,\n-\t\t\t\t\t\t\t\t      theFourMomentum.E()  ) ,\n-\t\t\t\t\t\t   thePdgId ,\n-\t\t\t\t\t\t   1 ) ; // hepmc status code for final state particle\n+  HepMC::GenParticle* p = new HepMC::GenParticle(\n+      HepMC::FourVector(theFourMomentum.Px(), theFourMomentum.Py(), theFourMomentum.Pz(), theFourMomentum.E()),\n+      thePdgId,\n+      1);  // hepmc status code for final state particle\n \n-  v -> add_particle_out( p ) ;\n+  v->add_particle_out(p);\n \n-  theEvent.add_vertex( v ) ;\n-  theEvent.set_signal_process_id( 0 ) ;\n-  theEvent.set_signal_process_vertex( v ) ;\n+  theEvent.add_vertex(v);\n+  theEvent.set_signal_process_id(0);","path":"Generation/src/components/MomentumRangeParticleGun.cpp","position":null,"original_position":43,"commit_id":"79ef5644cfbc2ad2400429aad40fea3e89a2cfea","original_commit_id":"79ef5644cfbc2ad2400429aad40fea3e89a2cfea","user":{"login":"jlingema","id":5601483,"avatar_url":"https://avatars1.githubusercontent.com/u/5601483?v=3","gravatar_id":"","url":"https://api.github.com/users/jlingema","html_url":"https://github.com/jlingema","followers_url":"https://api.github.com/users/jlingema/followers","following_url":"https://api.github.com/users/jlingema/following{/other_user}","gists_url":"https://api.github.com/users/jlingema/gists{/gist_id}","starred_url":"https://api.github.com/users/jlingema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlingema/subscriptions","organizations_url":"https://api.github.com/users/jlingema/orgs","repos_url":"https://api.github.com/users/jlingema/repos","events_url":"https://api.github.com/users/jlingema/events{/privacy}","received_events_url":"https://api.github.com/users/jlingema/received_events","type":"User","site_admin":false},"body":"Should this be hard-coded to 0?","created_at":"2017-04-11T07:03:15Z","updated_at":"2017-04-11T07:11:15Z","html_url":"https://github.com/HEP-FCC/FCCSW/pull/173#discussion_r110827413","pull_request_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/110827413"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/173#discussion_r110827413"},"pull_request":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173","id":109023831,"html_url":"https://github.com/HEP-FCC/FCCSW/pull/173","diff_url":"https://github.com/HEP-FCC/FCCSW/pull/173.diff","patch_url":"https://github.com/HEP-FCC/FCCSW/pull/173.patch","issue_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/173","number":173,"state":"open","locked":false,"title":"Restructure generation","user":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars2.githubusercontent.com/u/5057884?v=3","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"body":"This PR removes the separate HepMCReader-, Pythia8- and ParticleGun Algorithms, in favor of a more centralised `GenAlg`, changing some of those components to tools in the process. The `GenAlg` has separate tools for signal- and pileup-hepmc input, making the pileup handling more flexible. It also adds the possibility to merge generation edm data after conversion.","created_at":"2017-03-03T17:58:20Z","updated_at":"2017-04-11T07:11:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2cfec8a56cfb0b55ef674791f1fa2e44df24f86","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/milestones/1","html_url":"https://github.com/HEP-FCC/FCCSW/milestone/1","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/milestones/1/labels","id":2438807,"number":1,"title":"FCCSW v0.8.1","description":"","creator":{"login":"jlingema","id":5601483,"avatar_url":"https://avatars1.githubusercontent.com/u/5601483?v=3","gravatar_id":"","url":"https://api.github.com/users/jlingema","html_url":"https://github.com/jlingema","followers_url":"https://api.github.com/users/jlingema/followers","following_url":"https://api.github.com/users/jlingema/following{/other_user}","gists_url":"https://api.github.com/users/jlingema/gists{/gist_id}","starred_url":"https://api.github.com/users/jlingema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlingema/subscriptions","organizations_url":"https://api.github.com/users/jlingema/orgs","repos_url":"https://api.github.com/users/jlingema/repos","events_url":"https://api.github.com/users/jlingema/events{/privacy}","received_events_url":"https://api.github.com/users/jlingema/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2017-04-06T07:14:30Z","updated_at":"2017-04-06T07:18:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173/commits","review_comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173/comments","review_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/173/comments","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/79ef5644cfbc2ad2400429aad40fea3e89a2cfea","head":{"label":"vvolkl:generation-pileup-restructure","ref":"generation-pileup-restructure","sha":"79ef5644cfbc2ad2400429aad40fea3e89a2cfea","user":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars2.githubusercontent.com/u/5057884?v=3","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"repo":{"id":43544566,"name":"FCCSW","full_name":"vvolkl/FCCSW","owner":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars2.githubusercontent.com/u/5057884?v=3","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvolkl/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":true,"url":"https://api.github.com/repos/vvolkl/FCCSW","forks_url":"https://api.github.com/repos/vvolkl/FCCSW/forks","keys_url":"https://api.github.com/repos/vvolkl/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvolkl/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvolkl/FCCSW/teams","hooks_url":"https://api.github.com/repos/vvolkl/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/vvolkl/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/vvolkl/FCCSW/events","assignees_url":"https://api.github.com/repos/vvolkl/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/vvolkl/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/vvolkl/FCCSW/tags","blobs_url":"https://api.github.com/repos/vvolkl/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvolkl/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvolkl/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvolkl/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvolkl/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/vvolkl/FCCSW/languages","stargazers_url":"https://api.github.com/repos/vvolkl/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/vvolkl/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/vvolkl/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/vvolkl/FCCSW/subscription","commits_url":"https://api.github.com/repos/vvolkl/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvolkl/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvolkl/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvolkl/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvolkl/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/vvolkl/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvolkl/FCCSW/merges","archive_url":"https://api.github.com/repos/vvolkl/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvolkl/FCCSW/downloads","issues_url":"https://api.github.com/repos/vvolkl/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/vvolkl/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/vvolkl/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/vvolkl/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvolkl/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/vvolkl/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/vvolkl/FCCSW/deployments","created_at":"2015-10-02T09:16:24Z","updated_at":"2016-01-25T06:00:12Z","pushed_at":"2017-04-11T07:01:56Z","git_url":"git://github.com/vvolkl/FCCSW.git","ssh_url":"git@github.com:vvolkl/FCCSW.git","clone_url":"https://github.com/vvolkl/FCCSW.git","svn_url":"https://github.com/vvolkl/FCCSW","homepage":null,"size":182726,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HEP-FCC:master","ref":"master","sha":"7d0929915f8ef505740814668dac1611845838c4","user":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars3.githubusercontent.com/u/8003187?v=3","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"repo":{"id":21388221,"name":"FCCSW","full_name":"HEP-FCC/FCCSW","owner":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars3.githubusercontent.com/u/8003187?v=3","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HEP-FCC/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":false,"url":"https://api.github.com/repos/HEP-FCC/FCCSW","forks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/forks","keys_url":"https://api.github.com/repos/HEP-FCC/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HEP-FCC/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HEP-FCC/FCCSW/teams","hooks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/events","assignees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/HEP-FCC/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/tags","blobs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/HEP-FCC/FCCSW/languages","stargazers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscription","commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/HEP-FCC/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HEP-FCC/FCCSW/merges","archive_url":"https://api.github.com/repos/HEP-FCC/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HEP-FCC/FCCSW/downloads","issues_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/HEP-FCC/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/HEP-FCC/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/HEP-FCC/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/deployments","created_at":"2014-07-01T13:16:22Z","updated_at":"2017-04-05T11:11:11Z","pushed_at":"2017-04-11T07:01:57Z","git_url":"git://github.com/HEP-FCC/FCCSW.git","ssh_url":"git@github.com:HEP-FCC/FCCSW.git","clone_url":"https://github.com/HEP-FCC/FCCSW.git","svn_url":"https://github.com/HEP-FCC/FCCSW","homepage":"http://fccsw.web.cern.ch","size":174898,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":17,"forks":71,"open_issues":17,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/173"},"issue":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/173"},"comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/79ef5644cfbc2ad2400429aad40fea3e89a2cfea"}}}}
{"actor":{"display_login":"jlingema"}}