{"action":"closed","issue":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3486","repository_url":"https://api.github.com/repos/shogun-toolbox/shogun","labels_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3486/labels{/name}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3486/comments","events_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3486/events","html_url":"https://github.com/shogun-toolbox/shogun/issues/3486","id":186110565,"number":3486,"title":"eigen3 operator bug workaround fix","user":{"login":"karlnapf","id":699071,"avatar_url":"https://avatars0.githubusercontent.com/u/699071?v=4","gravatar_id":"","url":"https://api.github.com/users/karlnapf","html_url":"https://github.com/karlnapf","followers_url":"https://api.github.com/users/karlnapf/followers","following_url":"https://api.github.com/users/karlnapf/following{/other_user}","gists_url":"https://api.github.com/users/karlnapf/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnapf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnapf/subscriptions","organizations_url":"https://api.github.com/users/karlnapf/orgs","repos_url":"https://api.github.com/users/karlnapf/repos","events_url":"https://api.github.com/users/karlnapf/events{/privacy}","received_events_url":"https://api.github.com/users/karlnapf/received_events","type":"User","site_admin":false},"labels":[{"id":284227528,"url":"https://api.github.com/repos/shogun-toolbox/shogun/labels/BUG","name":"BUG","color":"ff0000","default":false},{"id":181051,"url":"https://api.github.com/repos/shogun-toolbox/shogun/labels/bugfixing","name":"bugfixing","color":"DDDDDD","default":false},{"id":51282819,"url":"https://api.github.com/repos/shogun-toolbox/shogun/labels/cmake","name":"cmake","color":"006b75","default":false},{"id":28273495,"url":"https://api.github.com/repos/shogun-toolbox/shogun/labels/entrance","name":"entrance","color":"e102d8","default":false},{"id":109609539,"url":"https://api.github.com/repos/shogun-toolbox/shogun/labels/New%20methods","name":"New methods","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/milestones/11","html_url":"https://github.com/shogun-toolbox/shogun/milestone/11","labels_url":"https://api.github.com/repos/shogun-toolbox/shogun/milestones/11/labels","id":2102474,"number":11,"title":"Shogun 6.1.0","description":"Aka -- new features that break the 5.0 release","creator":{"login":"karlnapf","id":699071,"avatar_url":"https://avatars0.githubusercontent.com/u/699071?v=4","gravatar_id":"","url":"https://api.github.com/users/karlnapf","html_url":"https://github.com/karlnapf","followers_url":"https://api.github.com/users/karlnapf/followers","following_url":"https://api.github.com/users/karlnapf/following{/other_user}","gists_url":"https://api.github.com/users/karlnapf/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnapf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnapf/subscriptions","organizations_url":"https://api.github.com/users/karlnapf/orgs","repos_url":"https://api.github.com/users/karlnapf/repos","events_url":"https://api.github.com/users/karlnapf/events{/privacy}","received_events_url":"https://api.github.com/users/karlnapf/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":15,"state":"open","created_at":"2016-10-30T19:06:48Z","updated_at":"2017-11-28T19:37:46Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-10-30T01:13:43Z","updated_at":"2017-11-28T19:37:46Z","closed_at":"2017-11-28T19:37:46Z","author_association":"OWNER","body":"See file https://github.com/shogun-toolbox/shogun/blob/769a56112ad34738c7fd0e949124cfaef96de6ff/src/shogun/classifier/LDA.cpp#L176\n\nReplace the line \n\n```\ncen_pos=cen_pos*cen_pos.transpose()/(float64_t(num_pos-1));\n```\n\nwith\n\n```\ncen_pos=cen_pos*cen_pos.transpose()\ncen_pos/=(float64_t(num_pos-1));\n```\n\nfixes the eigen3 operator bug (TODO needs to be reported) that is currently fixed in via bundling eigen3 in the main `CMakeLists.txt`.\nThe issue is caused by eigen3 putting zeros only in the left hand side if the statement is done in one line\n\nWe want to fix all failing unit tests in xenial (eigen3.3+) in this way using the guard `EIGEN_WITH_OPERATOR_BUG`\n\nTo reproduce, disable bundling eigen3 with ubuntu xenial, run unit tests, modify code in the above way to fix, use guards to only apply the fix for the \"bad\" eigen3 versions\n"}}
{"actor":{"display_login":"vigsterkr"}}