{"action":"created","issue":{"url":"https://api.github.com/repos/JabRef/jabref/issues/3418","repository_url":"https://api.github.com/repos/JabRef/jabref","labels_url":"https://api.github.com/repos/JabRef/jabref/issues/3418/labels{/name}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/3418/comments","events_url":"https://api.github.com/repos/JabRef/jabref/issues/3418/events","html_url":"https://github.com/JabRef/jabref/pull/3418","id":272440552,"number":3418,"title":"Checking Java version on startup","user":{"login":"halirutan","id":511683,"avatar_url":"https://avatars1.githubusercontent.com/u/511683?v=4","gravatar_id":"","url":"https://api.github.com/users/halirutan","html_url":"https://github.com/halirutan","followers_url":"https://api.github.com/users/halirutan/followers","following_url":"https://api.github.com/users/halirutan/following{/other_user}","gists_url":"https://api.github.com/users/halirutan/gists{/gist_id}","starred_url":"https://api.github.com/users/halirutan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halirutan/subscriptions","organizations_url":"https://api.github.com/users/halirutan/orgs","repos_url":"https://api.github.com/users/halirutan/repos","events_url":"https://api.github.com/users/halirutan/events{/privacy}","received_events_url":"https://api.github.com/users/halirutan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-11-09T04:54:56Z","updated_at":"2017-11-11T12:37:31Z","closed_at":"2017-11-11T00:39:26Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/3418","html_url":"https://github.com/JabRef/jabref/pull/3418","diff_url":"https://github.com/JabRef/jabref/pull/3418.diff","patch_url":"https://github.com/JabRef/jabref/pull/3418.patch"},"body":"This is not quite ready for review, but I appreciate some feedback. Since `localizationUpdate` seems broken, the messages are currently not added and I'm waiting for the fix.The logic behind the java check is as follows:\r\n\r\n1. In `gradle.build` we can define the `minRequiredJavaVersion` which is added as a value to `build.properties` as this was the most fitting place and it makes the version check quite flexible. I did not use an upper bound for the version but a boolean `allowJava9` indicator. The reasoning behind it is that a developer who is actually working on the Java 9 support just has to change this value to make JabRef start.\r\n2. I put the version check as a method into `BuildInfo`. Other possible places would be `Globals` or when we give the build-info as a parameter then `JavaVersionCheck` itself. Suggestions?\r\n3. The version check is called pretty early in `main` (as soon as localization is set up). I didn't bother to put the single error dialog into a separate class. Therefore, the logic of checking, showing the message and probably exiting is done directly there. Is this acceptable?\r\n\r\nThe version check itself has the only requirement to successfully access `System.getProperty(\"java.version\")`. I implemented a very *optimistic* check that doesn't fail if we cannot determine or compare the versions. Only if we are sure that the used version is not sufficient, it will fail.\r\n\r\nThis will solve\r\nhttps://github.com/JabRef/jabref/issues/3310\r\n"},"comment":{"url":"https://api.github.com/repos/JabRef/jabref/issues/comments/343661886","html_url":"https://github.com/JabRef/jabref/pull/3418#issuecomment-343661886","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/3418","id":343661886,"user":{"login":"tobiasdiez","id":5037600,"avatar_url":"https://avatars3.githubusercontent.com/u/5037600?v=4","gravatar_id":"","url":"https://api.github.com/users/tobiasdiez","html_url":"https://github.com/tobiasdiez","followers_url":"https://api.github.com/users/tobiasdiez/followers","following_url":"https://api.github.com/users/tobiasdiez/following{/other_user}","gists_url":"https://api.github.com/users/tobiasdiez/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasdiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasdiez/subscriptions","organizations_url":"https://api.github.com/users/tobiasdiez/orgs","repos_url":"https://api.github.com/users/tobiasdiez/repos","events_url":"https://api.github.com/users/tobiasdiez/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasdiez/received_events","type":"User","site_admin":false},"created_at":"2017-11-11T12:37:31Z","updated_at":"2017-11-11T12:37:31Z","author_association":"CONTRIBUTOR","body":"Yes, just keep the current swing dialog 😄  If it would work instantaneously, then using JavaFX is of course preferable.  "}}
{"actor":{"display_login":"tobiasdiez"}}