{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/docker/pulls/comments/105875660","pull_request_review_id":26773567,"id":105875660,"diff_hunk":"@@ -157,6 +157,14 @@ FROM jenkins\n RUN /usr/local/bin/install-plugins.sh docker-slaves github-branch-source:1.8\n ```\n \n+Furthermore it is possible to pass a file that contains this set of plugins (with or without line breaks).\n+\n+```\n+FROM jenkins\n+COPY plugins.txt /usr/share/jenkins/ref/plugins.txt\n+RUN /usr/local/bin/install-plugins.sh </usr/share/jenkins/ref/plugins.txt","path":"README.md","position":9,"original_position":9,"commit_id":"e23d8ec65962799b082b542fb9d2c96723eea09a","original_commit_id":"e23d8ec65962799b082b542fb9d2c96723eea09a","user":{"login":"pathob","id":4580157,"avatar_url":"https://avatars1.githubusercontent.com/u/4580157?v=3","gravatar_id":"","url":"https://api.github.com/users/pathob","html_url":"https://github.com/pathob","followers_url":"https://api.github.com/users/pathob/followers","following_url":"https://api.github.com/users/pathob/following{/other_user}","gists_url":"https://api.github.com/users/pathob/gists{/gist_id}","starred_url":"https://api.github.com/users/pathob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathob/subscriptions","organizations_url":"https://api.github.com/users/pathob/orgs","repos_url":"https://api.github.com/users/pathob/repos","events_url":"https://api.github.com/users/pathob/events{/privacy}","received_events_url":"https://api.github.com/users/pathob/received_events","type":"User","site_admin":false},"body":"Yes, to make it even more clear, I will add a space there.","created_at":"2017-03-14T10:48:59Z","updated_at":"2017-03-14T10:48:59Z","html_url":"https://github.com/jenkinsci/docker/pull/365#discussion_r105875660","pull_request_url":"https://api.github.com/repos/jenkinsci/docker/pulls/365","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/comments/105875660"},"html":{"href":"https://github.com/jenkinsci/docker/pull/365#discussion_r105875660"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/docker/pulls/365","id":88684873,"html_url":"https://github.com/jenkinsci/docker/pull/365","diff_url":"https://github.com/jenkinsci/docker/pull/365.diff","patch_url":"https://github.com/jenkinsci/docker/pull/365.patch","issue_url":"https://api.github.com/repos/jenkinsci/docker/issues/365","number":365,"state":"open","locked":false,"title":"Add plugins.txt file compability for install-plugins.sh","user":{"login":"pathob","id":4580157,"avatar_url":"https://avatars1.githubusercontent.com/u/4580157?v=3","gravatar_id":"","url":"https://api.github.com/users/pathob","html_url":"https://github.com/pathob","followers_url":"https://api.github.com/users/pathob/followers","following_url":"https://api.github.com/users/pathob/following{/other_user}","gists_url":"https://api.github.com/users/pathob/gists{/gist_id}","starred_url":"https://api.github.com/users/pathob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathob/subscriptions","organizations_url":"https://api.github.com/users/pathob/orgs","repos_url":"https://api.github.com/users/pathob/repos","events_url":"https://api.github.com/users/pathob/events{/privacy}","received_events_url":"https://api.github.com/users/pathob/received_events","type":"User","site_admin":false},"body":"The new install-plugins.sh script removed the possibility to pass a file\ncontaining a list of plugins that was given with the 'old' plugins.sh\nscript, although this functionality can be provided with only a few\nlines more.\n\nNow, when the install-plugins.sh script is called with only a single\nargument that matches an existing file on the file system, it is assumed\nthat this file contains the list of plugins that should be installed,\nnewlines are replaced by spaces and this manipulated content is used as\nthe plugins list for further processing.\n\nCloses #348.\n","created_at":"2016-10-10T15:38:40Z","updated_at":"2017-03-14T10:48:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b674743b103203e8e7cb3bcfcf36bc93f117e8ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/docker/pulls/365/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/docker/pulls/365/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/docker/issues/365/comments","statuses_url":"https://api.github.com/repos/jenkinsci/docker/statuses/e23d8ec65962799b082b542fb9d2c96723eea09a","head":{"label":"pathob:install-plugins","ref":"install-plugins","sha":"e23d8ec65962799b082b542fb9d2c96723eea09a","user":{"login":"pathob","id":4580157,"avatar_url":"https://avatars1.githubusercontent.com/u/4580157?v=3","gravatar_id":"","url":"https://api.github.com/users/pathob","html_url":"https://github.com/pathob","followers_url":"https://api.github.com/users/pathob/followers","following_url":"https://api.github.com/users/pathob/following{/other_user}","gists_url":"https://api.github.com/users/pathob/gists{/gist_id}","starred_url":"https://api.github.com/users/pathob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathob/subscriptions","organizations_url":"https://api.github.com/users/pathob/orgs","repos_url":"https://api.github.com/users/pathob/repos","events_url":"https://api.github.com/users/pathob/events{/privacy}","received_events_url":"https://api.github.com/users/pathob/received_events","type":"User","site_admin":false},"repo":{"id":70488914,"name":"jenkinsci-docker","full_name":"pathob/jenkinsci-docker","owner":{"login":"pathob","id":4580157,"avatar_url":"https://avatars1.githubusercontent.com/u/4580157?v=3","gravatar_id":"","url":"https://api.github.com/users/pathob","html_url":"https://github.com/pathob","followers_url":"https://api.github.com/users/pathob/followers","following_url":"https://api.github.com/users/pathob/following{/other_user}","gists_url":"https://api.github.com/users/pathob/gists{/gist_id}","starred_url":"https://api.github.com/users/pathob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathob/subscriptions","organizations_url":"https://api.github.com/users/pathob/orgs","repos_url":"https://api.github.com/users/pathob/repos","events_url":"https://api.github.com/users/pathob/events{/privacy}","received_events_url":"https://api.github.com/users/pathob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pathob/jenkinsci-docker","description":"Docker official jenkins repo","fork":true,"url":"https://api.github.com/repos/pathob/jenkinsci-docker","forks_url":"https://api.github.com/repos/pathob/jenkinsci-docker/forks","keys_url":"https://api.github.com/repos/pathob/jenkinsci-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pathob/jenkinsci-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pathob/jenkinsci-docker/teams","hooks_url":"https://api.github.com/repos/pathob/jenkinsci-docker/hooks","issue_events_url":"https://api.github.com/repos/pathob/jenkinsci-docker/issues/events{/number}","events_url":"https://api.github.com/repos/pathob/jenkinsci-docker/events","assignees_url":"https://api.github.com/repos/pathob/jenkinsci-docker/assignees{/user}","branches_url":"https://api.github.com/repos/pathob/jenkinsci-docker/branches{/branch}","tags_url":"https://api.github.com/repos/pathob/jenkinsci-docker/tags","blobs_url":"https://api.github.com/repos/pathob/jenkinsci-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pathob/jenkinsci-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pathob/jenkinsci-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/pathob/jenkinsci-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pathob/jenkinsci-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/pathob/jenkinsci-docker/languages","stargazers_url":"https://api.github.com/repos/pathob/jenkinsci-docker/stargazers","contributors_url":"https://api.github.com/repos/pathob/jenkinsci-docker/contributors","subscribers_url":"https://api.github.com/repos/pathob/jenkinsci-docker/subscribers","subscription_url":"https://api.github.com/repos/pathob/jenkinsci-docker/subscription","commits_url":"https://api.github.com/repos/pathob/jenkinsci-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/pathob/jenkinsci-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/pathob/jenkinsci-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/pathob/jenkinsci-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/pathob/jenkinsci-docker/contents/{+path}","compare_url":"https://api.github.com/repos/pathob/jenkinsci-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pathob/jenkinsci-docker/merges","archive_url":"https://api.github.com/repos/pathob/jenkinsci-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pathob/jenkinsci-docker/downloads","issues_url":"https://api.github.com/repos/pathob/jenkinsci-docker/issues{/number}","pulls_url":"https://api.github.com/repos/pathob/jenkinsci-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/pathob/jenkinsci-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/pathob/jenkinsci-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pathob/jenkinsci-docker/labels{/name}","releases_url":"https://api.github.com/repos/pathob/jenkinsci-docker/releases{/id}","deployments_url":"https://api.github.com/repos/pathob/jenkinsci-docker/deployments","created_at":"2016-10-10T13:10:09Z","updated_at":"2016-10-10T13:23:27Z","pushed_at":"2016-10-17T11:40:46Z","git_url":"git://github.com/pathob/jenkinsci-docker.git","ssh_url":"git@github.com:pathob/jenkinsci-docker.git","clone_url":"https://github.com/pathob/jenkinsci-docker.git","svn_url":"https://github.com/pathob/jenkinsci-docker","homepage":"https://hub.docker.com","size":265,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"2fb0684fe6eb11a3c1145d71e0cb50bf2dda8d11","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":21969270,"name":"docker","full_name":"jenkinsci/docker","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/docker","description":"Docker official jenkins repo","fork":true,"url":"https://api.github.com/repos/jenkinsci/docker","forks_url":"https://api.github.com/repos/jenkinsci/docker/forks","keys_url":"https://api.github.com/repos/jenkinsci/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/docker/teams","hooks_url":"https://api.github.com/repos/jenkinsci/docker/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/docker/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/docker/events","assignees_url":"https://api.github.com/repos/jenkinsci/docker/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/docker/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/docker/tags","blobs_url":"https://api.github.com/repos/jenkinsci/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/docker/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/docker/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/docker/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/docker/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/docker/subscription","commits_url":"https://api.github.com/repos/jenkinsci/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/docker/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/docker/merges","archive_url":"https://api.github.com/repos/jenkinsci/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/docker/downloads","issues_url":"https://api.github.com/repos/jenkinsci/docker/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/docker/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/docker/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/docker/deployments","created_at":"2014-07-18T05:51:05Z","updated_at":"2017-03-13T01:07:52Z","pushed_at":"2017-03-10T13:09:17Z","git_url":"git://github.com/jenkinsci/docker.git","ssh_url":"git@github.com:jenkinsci/docker.git","clone_url":"https://github.com/jenkinsci/docker.git","svn_url":"https://github.com/jenkinsci/docker","homepage":"https://hub.docker.com","size":315,"stargazers_count":1020,"watchers_count":1020,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":837,"mirror_url":null,"open_issues_count":24,"forks":837,"open_issues":24,"watchers":1020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/365"},"html":{"href":"https://github.com/jenkinsci/docker/pull/365"},"issue":{"href":"https://api.github.com/repos/jenkinsci/docker/issues/365"},"comments":{"href":"https://api.github.com/repos/jenkinsci/docker/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/docker/statuses/e23d8ec65962799b082b542fb9d2c96723eea09a"}}}}
{"actor":{"display_login":"pathob"}}