{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/100835581","pull_request_review_id":21551629,"id":100835581,"diff_hunk":"@@ -1518,6 +1521,7 @@ def multinomial_wo_replacement(self, size=None, n=1, pvals=None,\n         warnings.warn('MRG_RandomStreams.multinomial_wo_replacement() is '\n                       'deprecated and will be removed in the next release of '\n                       'Theano. Please use MRG_RandomStreams.choice() instead.')\n+        assert size is None","path":"theano/sandbox/rng_mrg.py","position":null,"original_position":39,"commit_id":"4dc613eb4810e191fe82dc2ccc7206b0b5668f5d","original_commit_id":"4dc613eb4810e191fe82dc2ccc7206b0b5668f5d","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"The definition of size for multinomial_wo_replacement and choice aren't the same. size must be None for multinomial_wo_replacement. But the size of choice correspond to the n parameter of multinomial_wo_replacement.","created_at":"2017-02-13T16:33:10Z","updated_at":"2017-02-13T16:33:10Z","html_url":"https://github.com/Theano/Theano/pull/5457#discussion_r100835581","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/5457","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/100835581"},"html":{"href":"https://github.com/Theano/Theano/pull/5457#discussion_r100835581"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5457"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/5457","id":103401656,"html_url":"https://github.com/Theano/Theano/pull/5457","diff_url":"https://github.com/Theano/Theano/pull/5457.diff","patch_url":"https://github.com/Theano/Theano/pull/5457.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/5457","number":5457,"state":"open","locked":false,"title":"replace multinomial_wo_replacement by choice","user":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"body":"First part of #5408, @nouiz.\r\n\r\nI copied the same signature as the choice method in tensor/raw_random.py , which is not the same as the choice signature of the numpy function (order of a, size reversed).\r\n\r\nAlso, should I replace multinomial_wo_replacement in the tests now? ","created_at":"2017-01-26T22:17:40Z","updated_at":"2017-02-13T16:33:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3af282cf8b29c200b518fdd0c1c9b8d76764c83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/5457/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/5457/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/5457/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/4dc613eb4810e191fe82dc2ccc7206b0b5668f5d","head":{"label":"adbrebs:mrg_choice","ref":"mrg_choice","sha":"4dc613eb4810e191fe82dc2ccc7206b0b5668f5d","user":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"repo":{"id":29032332,"name":"Theano","full_name":"adbrebs/Theano","owner":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adbrebs/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/adbrebs/Theano","forks_url":"https://api.github.com/repos/adbrebs/Theano/forks","keys_url":"https://api.github.com/repos/adbrebs/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adbrebs/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adbrebs/Theano/teams","hooks_url":"https://api.github.com/repos/adbrebs/Theano/hooks","issue_events_url":"https://api.github.com/repos/adbrebs/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/adbrebs/Theano/events","assignees_url":"https://api.github.com/repos/adbrebs/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/adbrebs/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/adbrebs/Theano/tags","blobs_url":"https://api.github.com/repos/adbrebs/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adbrebs/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adbrebs/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/adbrebs/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adbrebs/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/adbrebs/Theano/languages","stargazers_url":"https://api.github.com/repos/adbrebs/Theano/stargazers","contributors_url":"https://api.github.com/repos/adbrebs/Theano/contributors","subscribers_url":"https://api.github.com/repos/adbrebs/Theano/subscribers","subscription_url":"https://api.github.com/repos/adbrebs/Theano/subscription","commits_url":"https://api.github.com/repos/adbrebs/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/adbrebs/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/adbrebs/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/adbrebs/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/adbrebs/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/adbrebs/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adbrebs/Theano/merges","archive_url":"https://api.github.com/repos/adbrebs/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adbrebs/Theano/downloads","issues_url":"https://api.github.com/repos/adbrebs/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/adbrebs/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/adbrebs/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/adbrebs/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adbrebs/Theano/labels{/name}","releases_url":"https://api.github.com/repos/adbrebs/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/adbrebs/Theano/deployments","created_at":"2015-01-09T19:45:48Z","updated_at":"2016-01-22T15:17:00Z","pushed_at":"2017-02-10T20:17:13Z","git_url":"git://github.com/adbrebs/Theano.git","ssh_url":"git@github.com:adbrebs/Theano.git","clone_url":"https://github.com/adbrebs/Theano.git","svn_url":"https://github.com/adbrebs/Theano","homepage":"http://www.deeplearning.net/software/theano","size":61338,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"8b9f73365e4932f1c005a0a37b907d28985fbc5f","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2017-02-13T15:09:33Z","pushed_at":"2017-02-13T14:35:43Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":62188,"stargazers_count":5657,"watchers_count":5657,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1962,"mirror_url":null,"open_issues_count":708,"forks":1962,"open_issues":708,"watchers":5657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5457"},"html":{"href":"https://github.com/Theano/Theano/pull/5457"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/5457"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/5457/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5457/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5457/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/4dc613eb4810e191fe82dc2ccc7206b0b5668f5d"}}}}
{"actor":{"display_login":"nouiz"}}