{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/cf-ui/pulls/comments/103948946","pull_request_review_id":24757180,"id":103948946,"diff_hunk":"@@ -64,7 +64,9 @@ class Tabs extends React.Component {\n             })}\n           </ul>\n         </Viewport>\n-        {this.props.children}\n+        {this.props.children.find(child => {","path":"packages/cf-component-tabs/src/Tabs.js","position":5,"original_position":5,"commit_id":"3f3b67ab3639639926e898759729dfc8d5901166","original_commit_id":"3f3b67ab3639639926e898759729dfc8d5901166","user":{"login":"hturan","id":65447,"avatar_url":"https://avatars2.githubusercontent.com/u/65447?v=3","gravatar_id":"","url":"https://api.github.com/users/hturan","html_url":"https://github.com/hturan","followers_url":"https://api.github.com/users/hturan/followers","following_url":"https://api.github.com/users/hturan/following{/other_user}","gists_url":"https://api.github.com/users/hturan/gists{/gist_id}","starred_url":"https://api.github.com/users/hturan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hturan/subscriptions","organizations_url":"https://api.github.com/users/hturan/orgs","repos_url":"https://api.github.com/users/hturan/repos","events_url":"https://api.github.com/users/hturan/events{/privacy}","received_events_url":"https://api.github.com/users/hturan/received_events","type":"User","site_admin":false},"body":"Be careful when dealing with `this.props.children`, it's perfectly valid for it to be a string. See https://facebook.github.io/react/docs/react-api.html#react.children for more info.","created_at":"2017-03-02T15:23:19Z","updated_at":"2017-03-02T15:24:44Z","html_url":"https://github.com/cloudflare/cf-ui/pull/90#discussion_r103948946","pull_request_url":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cf-ui/pulls/comments/103948946"},"html":{"href":"https://github.com/cloudflare/cf-ui/pull/90#discussion_r103948946"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90","id":108780072,"html_url":"https://github.com/cloudflare/cf-ui/pull/90","diff_url":"https://github.com/cloudflare/cf-ui/pull/90.diff","patch_url":"https://github.com/cloudflare/cf-ui/pull/90.patch","issue_url":"https://api.github.com/repos/cloudflare/cf-ui/issues/90","number":90,"state":"open","locked":false,"title":"Don't render tab panels unless they are clicked","user":{"login":"koddsson","id":318208,"avatar_url":"https://avatars1.githubusercontent.com/u/318208?v=3","gravatar_id":"","url":"https://api.github.com/users/koddsson","html_url":"https://github.com/koddsson","followers_url":"https://api.github.com/users/koddsson/followers","following_url":"https://api.github.com/users/koddsson/following{/other_user}","gists_url":"https://api.github.com/users/koddsson/gists{/gist_id}","starred_url":"https://api.github.com/users/koddsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koddsson/subscriptions","organizations_url":"https://api.github.com/users/koddsson/orgs","repos_url":"https://api.github.com/users/koddsson/repos","events_url":"https://api.github.com/users/koddsson/events{/privacy}","received_events_url":"https://api.github.com/users/koddsson/received_events","type":"User","site_admin":false},"body":"`cf-component-tabs` would render all the tabpanel components when a tab component would get rendered. This has the potential of loading a bunch of data over the network that the user will never see.\r\n\r\nBy changing it this way we are able to only request the data needed to render the tabs the user actually clicks on","created_at":"2017-03-02T15:14:05Z","updated_at":"2017-03-02T15:24:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3108246788d4daf61165f86f57999568424d704","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90/commits","review_comments_url":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90/comments","review_comment_url":"https://api.github.com/repos/cloudflare/cf-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/cf-ui/issues/90/comments","statuses_url":"https://api.github.com/repos/cloudflare/cf-ui/statuses/3f3b67ab3639639926e898759729dfc8d5901166","head":{"label":"cloudflare:render-tabs-only-when-selected","ref":"render-tabs-only-when-selected","sha":"3f3b67ab3639639926e898759729dfc8d5901166","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars0.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":60779483,"name":"cf-ui","full_name":"cloudflare/cf-ui","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars0.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cf-ui","description":":gem: Cloudflare UI Framework","fork":false,"url":"https://api.github.com/repos/cloudflare/cf-ui","forks_url":"https://api.github.com/repos/cloudflare/cf-ui/forks","keys_url":"https://api.github.com/repos/cloudflare/cf-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cf-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cf-ui/teams","hooks_url":"https://api.github.com/repos/cloudflare/cf-ui/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cf-ui/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cf-ui/events","assignees_url":"https://api.github.com/repos/cloudflare/cf-ui/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cf-ui/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cf-ui/tags","blobs_url":"https://api.github.com/repos/cloudflare/cf-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cf-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cf-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cf-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cf-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cf-ui/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cf-ui/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cf-ui/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cf-ui/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cf-ui/subscription","commits_url":"https://api.github.com/repos/cloudflare/cf-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cf-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cf-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cf-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cf-ui/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cf-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cf-ui/merges","archive_url":"https://api.github.com/repos/cloudflare/cf-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cf-ui/downloads","issues_url":"https://api.github.com/repos/cloudflare/cf-ui/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cf-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cf-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cf-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cf-ui/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cf-ui/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/cf-ui/deployments","created_at":"2016-06-09T14:05:46Z","updated_at":"2017-03-01T02:21:55Z","pushed_at":"2017-03-02T15:15:14Z","git_url":"git://github.com/cloudflare/cf-ui.git","ssh_url":"git@github.com:cloudflare/cf-ui.git","clone_url":"https://github.com/cloudflare/cf-ui.git","svn_url":"https://github.com/cloudflare/cf-ui","homepage":"https://cloudflare.github.io/cf-ui/","size":3891,"stargazers_count":1160,"watchers_count":1160,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":14,"forks":55,"open_issues":14,"watchers":1160,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"30c9dbb8bc78405222720863e0d132ee0fc23570","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars0.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":60779483,"name":"cf-ui","full_name":"cloudflare/cf-ui","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars0.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cf-ui","description":":gem: Cloudflare UI Framework","fork":false,"url":"https://api.github.com/repos/cloudflare/cf-ui","forks_url":"https://api.github.com/repos/cloudflare/cf-ui/forks","keys_url":"https://api.github.com/repos/cloudflare/cf-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cf-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cf-ui/teams","hooks_url":"https://api.github.com/repos/cloudflare/cf-ui/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cf-ui/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cf-ui/events","assignees_url":"https://api.github.com/repos/cloudflare/cf-ui/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cf-ui/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cf-ui/tags","blobs_url":"https://api.github.com/repos/cloudflare/cf-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cf-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cf-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cf-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cf-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cf-ui/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cf-ui/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cf-ui/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cf-ui/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cf-ui/subscription","commits_url":"https://api.github.com/repos/cloudflare/cf-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cf-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cf-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cf-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cf-ui/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cf-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cf-ui/merges","archive_url":"https://api.github.com/repos/cloudflare/cf-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cf-ui/downloads","issues_url":"https://api.github.com/repos/cloudflare/cf-ui/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cf-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cf-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cf-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cf-ui/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cf-ui/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/cf-ui/deployments","created_at":"2016-06-09T14:05:46Z","updated_at":"2017-03-01T02:21:55Z","pushed_at":"2017-03-02T15:15:14Z","git_url":"git://github.com/cloudflare/cf-ui.git","ssh_url":"git@github.com:cloudflare/cf-ui.git","clone_url":"https://github.com/cloudflare/cf-ui.git","svn_url":"https://github.com/cloudflare/cf-ui","homepage":"https://cloudflare.github.io/cf-ui/","size":3891,"stargazers_count":1160,"watchers_count":1160,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":14,"forks":55,"open_issues":14,"watchers":1160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90"},"html":{"href":"https://github.com/cloudflare/cf-ui/pull/90"},"issue":{"href":"https://api.github.com/repos/cloudflare/cf-ui/issues/90"},"comments":{"href":"https://api.github.com/repos/cloudflare/cf-ui/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/cf-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/cf-ui/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/cf-ui/statuses/3f3b67ab3639639926e898759729dfc8d5901166"}}}}
{"actor":{"display_login":"hturan"}}