{"action":"created","issue":{"url":"https://api.github.com/repos/cmangos/issues/issues/1296","repository_url":"https://api.github.com/repos/cmangos/issues","labels_url":"https://api.github.com/repos/cmangos/issues/issues/1296/labels{/name}","comments_url":"https://api.github.com/repos/cmangos/issues/issues/1296/comments","events_url":"https://api.github.com/repos/cmangos/issues/issues/1296/events","html_url":"https://github.com/cmangos/issues/issues/1296","id":208663508,"number":1296,"title":"[WOTLK] [PATCH] CanRewardQuest","user":{"login":"virusav","id":323130,"avatar_url":"https://avatars3.githubusercontent.com/u/323130?v=4","gravatar_id":"","url":"https://api.github.com/users/virusav","html_url":"https://github.com/virusav","followers_url":"https://api.github.com/users/virusav/followers","following_url":"https://api.github.com/users/virusav/following{/other_user}","gists_url":"https://api.github.com/users/virusav/gists{/gist_id}","starred_url":"https://api.github.com/users/virusav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virusav/subscriptions","organizations_url":"https://api.github.com/users/virusav/orgs","repos_url":"https://api.github.com/users/virusav/repos","events_url":"https://api.github.com/users/virusav/events{/privacy}","received_events_url":"https://api.github.com/users/virusav/received_events","type":"User","site_admin":false},"labels":[{"id":33783660,"url":"https://api.github.com/repos/cmangos/issues/labels/System-Loot","name":"System-Loot","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"xfurry","id":172444,"avatar_url":"https://avatars0.githubusercontent.com/u/172444?v=4","gravatar_id":"","url":"https://api.github.com/users/xfurry","html_url":"https://github.com/xfurry","followers_url":"https://api.github.com/users/xfurry/followers","following_url":"https://api.github.com/users/xfurry/following{/other_user}","gists_url":"https://api.github.com/users/xfurry/gists{/gist_id}","starred_url":"https://api.github.com/users/xfurry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfurry/subscriptions","organizations_url":"https://api.github.com/users/xfurry/orgs","repos_url":"https://api.github.com/users/xfurry/repos","events_url":"https://api.github.com/users/xfurry/events{/privacy}","received_events_url":"https://api.github.com/users/xfurry/received_events","type":"User","site_admin":false},"assignees":[{"login":"xfurry","id":172444,"avatar_url":"https://avatars0.githubusercontent.com/u/172444?v=4","gravatar_id":"","url":"https://api.github.com/users/xfurry","html_url":"https://github.com/xfurry","followers_url":"https://api.github.com/users/xfurry/followers","following_url":"https://api.github.com/users/xfurry/following{/other_user}","gists_url":"https://api.github.com/users/xfurry/gists{/gist_id}","starred_url":"https://api.github.com/users/xfurry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfurry/subscriptions","organizations_url":"https://api.github.com/users/xfurry/orgs","repos_url":"https://api.github.com/users/xfurry/repos","events_url":"https://api.github.com/users/xfurry/events{/privacy}","received_events_url":"https://api.github.com/users/xfurry/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-02-18T19:14:48Z","updated_at":"2017-12-20T19:17:55Z","closed_at":null,"author_association":"NONE","body":"Before the patch: if the quest give a few things (choice and no choice), and the bags are free only one cell, it was given only to the first item.\r\n\r\nAfter patch: you can take the quest if there is room in the bags (on every thing or certain things are added to the pack).\r\n\r\n```DIFF\r\ndiff --git a/src/game/Player.cpp b/src/game/Player.cpp\r\nindex 82efa7947..23e60c046 100644\r\n--- a/src/game/Player.cpp\r\n+++ b/src/game/Player.cpp\r\n@@ -13534,11 +13534,11 @@ bool Player::CanRewardQuest(Quest const* pQuest, uint32 reward, bool msg) const\r\n     if (!CanRewardQuest(pQuest, msg))\r\n         return false;\r\n \r\n+    ItemPosCountVec dest;\r\n     if (pQuest->GetRewChoiceItemsCount() > 0)\r\n     {\r\n         if (pQuest->RewChoiceItemId[reward])\r\n         {\r\n-            ItemPosCountVec dest;\r\n             InventoryResult res = CanStoreNewItem(NULL_BAG, NULL_SLOT, dest, pQuest->RewChoiceItemId[reward], pQuest->RewChoiceItemCount[reward]);\r\n             if (res != EQUIP_ERR_OK)\r\n             {\r\n@@ -13554,7 +13554,6 @@ bool Player::CanRewardQuest(Quest const* pQuest, uint32 reward, bool msg) const\r\n         {\r\n             if (pQuest->RewItemId[i])\r\n             {\r\n-                ItemPosCountVec dest;\r\n                 InventoryResult res = CanStoreNewItem(NULL_BAG, NULL_SLOT, dest, pQuest->RewItemId[i], pQuest->RewItemCount[i]);\r\n                 if (res != EQUIP_ERR_OK)\r\n                 { \r\n```\r\n\r\nWhat a situation I have not considered?"},"comment":{"url":"https://api.github.com/repos/cmangos/issues/issues/comments/353157084","html_url":"https://github.com/cmangos/issues/issues/1296#issuecomment-353157084","issue_url":"https://api.github.com/repos/cmangos/issues/issues/1296","id":353157084,"user":{"login":"xfurry","id":172444,"avatar_url":"https://avatars0.githubusercontent.com/u/172444?v=4","gravatar_id":"","url":"https://api.github.com/users/xfurry","html_url":"https://github.com/xfurry","followers_url":"https://api.github.com/users/xfurry/followers","following_url":"https://api.github.com/users/xfurry/following{/other_user}","gists_url":"https://api.github.com/users/xfurry/gists{/gist_id}","starred_url":"https://api.github.com/users/xfurry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfurry/subscriptions","organizations_url":"https://api.github.com/users/xfurry/orgs","repos_url":"https://api.github.com/users/xfurry/repos","events_url":"https://api.github.com/users/xfurry/events{/privacy}","received_events_url":"https://api.github.com/users/xfurry/received_events","type":"User","site_admin":false},"created_at":"2017-12-20T19:17:55Z","updated_at":"2017-12-20T19:17:55Z","author_association":"OWNER","body":"It should be still relevant.\r\nAgain, poke @killerwife "}}
{"actor":{"display_login":"xfurry"}}