{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/151168340","pull_request_review_id":76832559,"id":151168340,"diff_hunk":"@@ -0,0 +1,212 @@\n+\n+/* Switchboard\n+   ========================================================================== */\n+\n+$local-gutter: $gs-gutter / 1.75;\n+$checkbox-size: $gs-gutter / 1.25;\n+\n+.manage-account__switchboard ul,\n+.manage-account__switchboard li {\n+    list-style: none;\n+    padding: 0;\n+    margin: 0;\n+}\n+\n+.manage-account__switchboard {\n+\n+    ul {\n+        grid-template-columns: repeat(auto-fit, minmax(gs-span(3), 1fr));\n+        grid-auto-rows: 1fr;\n+        display: grid;\n+        padding-top: $local-gutter;\n+        grid-row-gap: $local-gutter;\n+        grid-column-gap: $local-gutter;\n+        * {\n+            width: 100%;\n+            height: auto;\n+            margin: 0;\n+            margin-bottom: $local-gutter;\n+            @supports(display: grid) {\n+                margin: 0;\n+            }\n+        }\n+    }\n+\n+    &--narrow ul {\n+        @include mq(tablet) {\n+            grid-template-columns: repeat(auto-fit, minmax(gs-span(3), .5fr));\n+        }\n+    }\n+\n+    li {\n+        display: flex;\n+    }\n+\n+}\n+\n+.manage-account__switchboardLabel {\n+\n+    @include fs-textSans(1);\n+    display: block;\n+    background-color: $neutral-8;\n+    border-top: 1px solid $neutral-4;\n+    overflow: hidden;\n+    position: relative;\n+\n+    .account__switchboardLabelHeader {\n+        @include f-header;\n+        @include fs-headline(2, true);\n+        background-size: 100% auto;\n+        background-position: 0 0;\n+        background-repeat: no-repeat;\n+        padding: $local-gutter ($local-gutter * 1.5);\n+        text-transform: lowercase;\n+        display: flex;\n+        justify-content: space-between;\n+        flex-direction: column;\n+        svg {\n+            height: 2em;\n+            width: 2em;\n+            fill: #ffffff;\n+            margin-top: $local-gutter;\n+        }\n+    }\n+\n+    .account__switchboardLabelContent {\n+        width: auto;\n+        padding: $local-gutter * 1.5;\n+        padding-left: $local-gutter * 2 + $checkbox-size;\n+        padding-top: $local-gutter * .9;\n+        position: relative;\n+    }\n+\n+    &:hover {\n+        background-color: darken($neutral-8, 1%);\n+    }\n+\n+    @supports (background-size: cover) {\n+        input[type=checkbox] {\n+            visibility: hidden;\n+            position: absolute;\n+            top: 0;\n+            right: 0;\n+            & + .manage-account__switchboardCheckbox {\n+                display: block;\n+                width: $checkbox-size;\n+                height: $checkbox-size;\n+                border: 1px solid $neutral-3;\n+                border-radius: 1.5px;\n+                background-size: $checkbox-size / 1.5;\n+                background: #ffffff no-repeat center center;\n+                position: absolute;\n+                top: $local-gutter;\n+                left: $local-gutter;\n+                cursor: pointer;\n+            }\n+            &:checked + .manage-account__switchboardCheckbox {\n+                background-image: url('data:image/svg+xml;charset=utf-8,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20width%3D%2210.79%22%20height%3D%228.61%22%20viewBox%3D%220%200%2010.79%208.608%22%3E%3Cpath%20fill%3D%22%23005689%22%20d%3D%22M3%206.58L10.23%200l.55.53L3%208.6h-.27L0%204.8l.55-.56%202.44%202.33z%22%2F%3E%3C%2Fsvg%3E')  }\n+        }\n+    }\n+\n+    .manage-account__switchboardTitle {\n+        @include fs-bodyCopy(1);\n+        font-weight: 400;\n+        margin-bottom: $local-gutter * .5;\n+        cursor: pointer;\n+        display: block;\n+    }\n+\n+    .manage-account__switchboardCopy {\n+        cursor: pointer;\n+        opacity: .9;\n+    }\n+\n+    .manage-account__switchboardTidbit {\n+        @include fs-textSans(1);\n+        opacity: .75;\n+        svg {\n+            vertical-align: -10%;\n+            margin-right: .25em;\n+        }\n+    }\n+\n+    .manage-account__switchboardFooter {\n+        margin-top: $local-gutter * 2;\n+        display: flex;\n+        justify-content: space-between;\n+        width: 100%;\n+    }\n+\n+    &:before {\n+        content: '\\0020';\n+        position: absolute;\n+        display: block;\n+        top: 0;\n+        left: 0;\n+        right: 0;\n+        background-color: $guardian-brand;\n+        height: 2px;\n+        transform-origin: center;\n+        opacity: 0;\n+        transition: .2s;\n+    }\n+\n+    &--branded {\n+        display: flex;\n+        flex-direction: row;\n+        > * {\n+            flex: 1 1 0;\n+            width: auto!important;\n+        }\n+        .account__switchboardLabelHeader {\n+            background: #f5b3c7;\n+            color: #e71c77;\n+        }\n+    }\n+\n+    &.is-updating {\n+        cursor: wait;\n+        pointer-events: none;\n+        background-image: none;\n+\n+        &:before {\n+            animation: manage-account__switchboardLoading 1s infinite both;\n+            opacity: 1;\n+        }\n+\n+        > * {\n+            opacity: .5;\n+        }","path":"static/src/stylesheets/module/identity/_switchboard.scss","position":179,"original_position":179,"commit_id":"4eabe5890fb2716aa4d9f403926c9bd3f4cfa8b2","original_commit_id":"1a41ab12d2787da5382c48b9ac53f9014959c0e8","user":{"login":"walaura","id":11539094,"avatar_url":"https://avatars1.githubusercontent.com/u/11539094?v=4","gravatar_id":"","url":"https://api.github.com/users/walaura","html_url":"https://github.com/walaura","followers_url":"https://api.github.com/users/walaura/followers","following_url":"https://api.github.com/users/walaura/following{/other_user}","gists_url":"https://api.github.com/users/walaura/gists{/gist_id}","starred_url":"https://api.github.com/users/walaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walaura/subscriptions","organizations_url":"https://api.github.com/users/walaura/orgs","repos_url":"https://api.github.com/users/walaura/repos","events_url":"https://api.github.com/users/walaura/events{/privacy}","received_events_url":"https://api.github.com/users/walaura/received_events","type":"User","site_admin":false},"body":"sadly in this case it does mess them up :(","created_at":"2017-11-15T15:57:05Z","updated_at":"2017-11-15T15:57:05Z","html_url":"https://github.com/guardian/frontend/pull/18241#discussion_r151168340","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/18241","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/151168340"},"html":{"href":"https://github.com/guardian/frontend/pull/18241#discussion_r151168340"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/18241"}},"in_reply_to_id":151168025},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/18241","id":152793851,"html_url":"https://github.com/guardian/frontend/pull/18241","diff_url":"https://github.com/guardian/frontend/pull/18241.diff","patch_url":"https://github.com/guardian/frontend/pull/18241.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/18241","number":18241,"state":"open","locked":false,"title":"Ajaxify the user preferences consent page","user":{"login":"walaura","id":11539094,"avatar_url":"https://avatars1.githubusercontent.com/u/11539094?v=4","gravatar_id":"","url":"https://api.github.com/users/walaura","html_url":"https://github.com/walaura","followers_url":"https://api.github.com/users/walaura/followers","following_url":"https://api.github.com/users/walaura/following{/other_user}","gists_url":"https://api.github.com/users/walaura/gists{/gist_id}","starred_url":"https://api.github.com/users/walaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walaura/subscriptions","organizations_url":"https://api.github.com/users/walaura/orgs","repos_url":"https://api.github.com/users/walaura/repos","events_url":"https://api.github.com/users/walaura/events{/privacy}","received_events_url":"https://api.github.com/users/walaura/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nThis PR updates the existing 3 consent checkboxes so clicking them instantly submits their status to backend as opposed to needing a click of the save button. This update also contains design preparations for the denser v2 gdpr compliant consent page \r\n\r\n## What is the value of this and can you measure success?\r\nThe preferences page looks a bit more structured today and _way_ more importantly merging this code now means a lighter PR in the future\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNo\r\n\r\n## Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\nNo\r\n\r\n## Screenshots\r\n![screen shot 2017-11-15 at 14 01 58](https://user-images.githubusercontent.com/11539094/32841536-78c3f40e-ca12-11e7-8175-8c594dd16ad9.png)\r\n![screen shot 2017-11-15 at 14 02 07](https://user-images.githubusercontent.com/11539094/32841539-7b8d2aa2-ca12-11e7-85c0-45fbe688e730.png)\r\n\r\n## Tested in CODE?\r\nNo\r\n\r\n<!-- AB test? https://git.io/v1V0x -->\r\n<!-- AMP question? https://git.io/v9zIE -->\r\n<!-- Does this PR meet the contributing guidelines? https://git.io/v1VEJ -->\r\n","created_at":"2017-11-15T14:47:56Z","updated_at":"2017-11-15T15:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb7b606cf9994d4597033a601f1ef606230ce813","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/18241/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/18241/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/18241/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/4eabe5890fb2716aa4d9f403926c9bd3f4cfa8b2","head":{"label":"guardian:gdpr-checkboxes-on-privacy-page","ref":"gdpr-checkboxes-on-privacy-page","sha":"4eabe5890fb2716aa4d9f403926c9bd3f4cfa8b2","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-11-15T06:37:24Z","pushed_at":"2017-11-15T15:54:59Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":543928,"stargazers_count":3718,"watchers_count":3718,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":397,"mirror_url":null,"archived":false,"open_issues_count":57,"forks":397,"open_issues":57,"watchers":3718,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"69031d61b989eb68a4e3a37f6519e389dc5c103a","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-11-15T06:37:24Z","pushed_at":"2017-11-15T15:54:59Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":543928,"stargazers_count":3718,"watchers_count":3718,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":397,"mirror_url":null,"archived":false,"open_issues_count":57,"forks":397,"open_issues":57,"watchers":3718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/18241"},"html":{"href":"https://github.com/guardian/frontend/pull/18241"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/18241"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/18241/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/18241/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/18241/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/4eabe5890fb2716aa4d9f403926c9bd3f4cfa8b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"walaura"}}