{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/113965237","pull_request_review_id":35399502,"id":113965237,"diff_hunk":"@@ -108,6 +111,22 @@ class KafkaSinkSuite extends StreamTest with SharedSQLContext {\n       s\"save mode overwrite not allowed for kafka\"))\n   }\n \n+  test(\"batch - enforce analyzed plans SPARK-20496\") {\n+    val inputEvents =\n+      spark.range(1, 1000)\n+        .select(to_json(struct(\"*\")) as 'value)\n+\n+    val topic = newTopic()\n+    testUtils.createTopic(topic)\n+\n+     inputEvents.write","path":"external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala","position":29,"original_position":29,"commit_id":"77e25f1bddbeb9345d8589b36c179eaf0d846158","original_commit_id":"77e25f1bddbeb9345d8589b36c179eaf0d846158","user":{"login":"brkyvz","id":5243515,"avatar_url":"https://avatars2.githubusercontent.com/u/5243515?v=3","gravatar_id":"","url":"https://api.github.com/users/brkyvz","html_url":"https://github.com/brkyvz","followers_url":"https://api.github.com/users/brkyvz/followers","following_url":"https://api.github.com/users/brkyvz/following{/other_user}","gists_url":"https://api.github.com/users/brkyvz/gists{/gist_id}","starred_url":"https://api.github.com/users/brkyvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brkyvz/subscriptions","organizations_url":"https://api.github.com/users/brkyvz/orgs","repos_url":"https://api.github.com/users/brkyvz/repos","events_url":"https://api.github.com/users/brkyvz/events{/privacy}","received_events_url":"https://api.github.com/users/brkyvz/received_events","type":"User","site_admin":false},"body":"nit: wrong indentation. + I would add a comment here that this would used to throw an `UnresolvedException`","created_at":"2017-04-28T16:07:45Z","updated_at":"2017-04-28T16:08:30Z","html_url":"https://github.com/apache/spark/pull/17804#discussion_r113965237","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/17804","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/113965237"},"html":{"href":"https://github.com/apache/spark/pull/17804#discussion_r113965237"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/17804"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17804","id":118169498,"html_url":"https://github.com/apache/spark/pull/17804","diff_url":"https://github.com/apache/spark/pull/17804.diff","patch_url":"https://github.com/apache/spark/pull/17804.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/17804","number":17804,"state":"open","locked":false,"title":"[SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed Plans","user":{"login":"anabranch","id":1642503,"avatar_url":"https://avatars1.githubusercontent.com/u/1642503?v=3","gravatar_id":"","url":"https://api.github.com/users/anabranch","html_url":"https://github.com/anabranch","followers_url":"https://api.github.com/users/anabranch/followers","following_url":"https://api.github.com/users/anabranch/following{/other_user}","gists_url":"https://api.github.com/users/anabranch/gists{/gist_id}","starred_url":"https://api.github.com/users/anabranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anabranch/subscriptions","organizations_url":"https://api.github.com/users/anabranch/orgs","repos_url":"https://api.github.com/users/anabranch/repos","events_url":"https://api.github.com/users/anabranch/events{/privacy}","received_events_url":"https://api.github.com/users/anabranch/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nWe didn't enforce analyzed plans in Spark 2.1 when writing out to Kafka.\r\n\r\n## How was this patch tested?\r\n\r\nNew unit test.\r\n\r\nPlease review http://spark.apache.org/contributing.html before opening a pull request.\r\n","created_at":"2017-04-28T14:51:00Z","updated_at":"2017-04-28T16:08:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"891d7b3e42423570c926500deba1c8d170d05b72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/17804/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/17804/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/17804/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/77e25f1bddbeb9345d8589b36c179eaf0d846158","head":{"label":"anabranch:SPARK-20496-2","ref":"SPARK-20496-2","sha":"77e25f1bddbeb9345d8589b36c179eaf0d846158","user":{"login":"anabranch","id":1642503,"avatar_url":"https://avatars1.githubusercontent.com/u/1642503?v=3","gravatar_id":"","url":"https://api.github.com/users/anabranch","html_url":"https://github.com/anabranch","followers_url":"https://api.github.com/users/anabranch/followers","following_url":"https://api.github.com/users/anabranch/following{/other_user}","gists_url":"https://api.github.com/users/anabranch/gists{/gist_id}","starred_url":"https://api.github.com/users/anabranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anabranch/subscriptions","organizations_url":"https://api.github.com/users/anabranch/orgs","repos_url":"https://api.github.com/users/anabranch/repos","events_url":"https://api.github.com/users/anabranch/events{/privacy}","received_events_url":"https://api.github.com/users/anabranch/received_events","type":"User","site_admin":false},"repo":{"id":32840050,"name":"spark","full_name":"anabranch/spark","owner":{"login":"anabranch","id":1642503,"avatar_url":"https://avatars1.githubusercontent.com/u/1642503?v=3","gravatar_id":"","url":"https://api.github.com/users/anabranch","html_url":"https://github.com/anabranch","followers_url":"https://api.github.com/users/anabranch/followers","following_url":"https://api.github.com/users/anabranch/following{/other_user}","gists_url":"https://api.github.com/users/anabranch/gists{/gist_id}","starred_url":"https://api.github.com/users/anabranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anabranch/subscriptions","organizations_url":"https://api.github.com/users/anabranch/orgs","repos_url":"https://api.github.com/users/anabranch/repos","events_url":"https://api.github.com/users/anabranch/events{/privacy}","received_events_url":"https://api.github.com/users/anabranch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anabranch/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/anabranch/spark","forks_url":"https://api.github.com/repos/anabranch/spark/forks","keys_url":"https://api.github.com/repos/anabranch/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anabranch/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anabranch/spark/teams","hooks_url":"https://api.github.com/repos/anabranch/spark/hooks","issue_events_url":"https://api.github.com/repos/anabranch/spark/issues/events{/number}","events_url":"https://api.github.com/repos/anabranch/spark/events","assignees_url":"https://api.github.com/repos/anabranch/spark/assignees{/user}","branches_url":"https://api.github.com/repos/anabranch/spark/branches{/branch}","tags_url":"https://api.github.com/repos/anabranch/spark/tags","blobs_url":"https://api.github.com/repos/anabranch/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anabranch/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anabranch/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/anabranch/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anabranch/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/anabranch/spark/languages","stargazers_url":"https://api.github.com/repos/anabranch/spark/stargazers","contributors_url":"https://api.github.com/repos/anabranch/spark/contributors","subscribers_url":"https://api.github.com/repos/anabranch/spark/subscribers","subscription_url":"https://api.github.com/repos/anabranch/spark/subscription","commits_url":"https://api.github.com/repos/anabranch/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/anabranch/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/anabranch/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/anabranch/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/anabranch/spark/contents/{+path}","compare_url":"https://api.github.com/repos/anabranch/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anabranch/spark/merges","archive_url":"https://api.github.com/repos/anabranch/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anabranch/spark/downloads","issues_url":"https://api.github.com/repos/anabranch/spark/issues{/number}","pulls_url":"https://api.github.com/repos/anabranch/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/anabranch/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/anabranch/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anabranch/spark/labels{/name}","releases_url":"https://api.github.com/repos/anabranch/spark/releases{/id}","deployments_url":"https://api.github.com/repos/anabranch/spark/deployments","created_at":"2015-03-25T03:19:30Z","updated_at":"2016-02-05T19:11:54Z","pushed_at":"2017-04-28T14:53:44Z","git_url":"git://github.com/anabranch/spark.git","ssh_url":"git@github.com:anabranch/spark.git","clone_url":"https://github.com/anabranch/spark.git","svn_url":"https://github.com/anabranch/spark","homepage":null,"size":258965,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8c911adac56a1b1d95bc19915e0070ce7305257c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-04-28T09:38:43Z","pushed_at":"2017-04-28T15:48:56Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":272428,"stargazers_count":12630,"watchers_count":12630,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11879,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":483,"forks":11879,"open_issues":483,"watchers":12630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/17804"},"html":{"href":"https://github.com/apache/spark/pull/17804"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/17804"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/17804/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/17804/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/17804/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/77e25f1bddbeb9345d8589b36c179eaf0d846158"}}}}
{"actor":{"display_login":"brkyvz"}}