{"action":"created","comment":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/144542782","pull_request_review_id":69213859,"id":144542782,"diff_hunk":"@@ -112,6 +121,13 @@ public function getXdmodAccount()\n         return false;\n     }\n \n+    /**\n+     * Retrieves the login url we want to use with this authentication provider. \n+     * \n+     * @param returnTo the URI to redirect to after auth, if any. null by default.","path":"classes/Authentication/SAML/XDSamlAuthentication.php","position":null,"original_position":43,"commit_id":"9be1ab90e5f8cb83cd2bfbcc0edd7cd36095ecc6","original_commit_id":"4c9ddc33b2c1273d4631061c5b71d8c05b1e6e31","user":{"login":"smgallo","id":2301909,"avatar_url":"https://avatars1.githubusercontent.com/u/2301909?v=4","gravatar_id":"","url":"https://api.github.com/users/smgallo","html_url":"https://github.com/smgallo","followers_url":"https://api.github.com/users/smgallo/followers","following_url":"https://api.github.com/users/smgallo/following{/other_user}","gists_url":"https://api.github.com/users/smgallo/gists{/gist_id}","starred_url":"https://api.github.com/users/smgallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smgallo/subscriptions","organizations_url":"https://api.github.com/users/smgallo/orgs","repos_url":"https://api.github.com/users/smgallo/repos","events_url":"https://api.github.com/users/smgallo/events{/privacy}","received_events_url":"https://api.github.com/users/smgallo/received_events","type":"User","site_admin":false},"body":"Please add the type of each parameter\r\n```\r\n* @param $returnTo string The URI to...\r\n```","created_at":"2017-10-13T12:44:17Z","updated_at":"2017-10-13T12:44:46Z","html_url":"https://github.com/ubccr/xdmod/pull/297#discussion_r144542782","pull_request_url":"https://api.github.com/repos/ubccr/xdmod/pulls/297","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/144542782"},"html":{"href":"https://github.com/ubccr/xdmod/pull/297#discussion_r144542782"},"pull_request":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/297","id":146095207,"html_url":"https://github.com/ubccr/xdmod/pull/297","diff_url":"https://github.com/ubccr/xdmod/pull/297.diff","patch_url":"https://github.com/ubccr/xdmod/pull/297.patch","issue_url":"https://api.github.com/repos/ubccr/xdmod/issues/297","number":297,"state":"open","locked":false,"title":"Better Federated/Local UI Support","user":{"login":"chakrabortyr","id":2617780,"avatar_url":"https://avatars0.githubusercontent.com/u/2617780?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrabortyr","html_url":"https://github.com/chakrabortyr","followers_url":"https://api.github.com/users/chakrabortyr/followers","following_url":"https://api.github.com/users/chakrabortyr/following{/other_user}","gists_url":"https://api.github.com/users/chakrabortyr/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabortyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabortyr/subscriptions","organizations_url":"https://api.github.com/users/chakrabortyr/orgs","repos_url":"https://api.github.com/users/chakrabortyr/repos","events_url":"https://api.github.com/users/chakrabortyr/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabortyr/received_events","type":"User","site_admin":false},"body":"## Description\r\nOld Login UI (metrics-dev):\r\n![screen shot 2017-10-11 at 8 49 17 pm](https://user-images.githubusercontent.com/2617780/31474005-0154b5d2-aec6-11e7-810a-ae6b879710ba.png)\r\n\r\nNew UI:\r\n![screen shot 2017-10-11 at 8 48 40 pm](https://user-images.githubusercontent.com/2617780/31474006-052571f6-aec6-11e7-862b-7ecda99c4806.png)\r\n\r\n\r\n## Motivation and Context\r\nA concise look that fits in better with the rest of the GUI. More clearly associates the Forgot Password/Sign Up stuff with your local account rather than federated account.\r\n\r\nOn the federated side, addresses excess spacing issues by making the federated button and the window adapt itself to the login. We've also merged XSEDE/Non-XSEDE based logins so we have either a federated or a non-federated login. It's now also possible (and looks) better when you have either federated or local enabled.\r\n\r\n## Tests performed\r\nVerified in Travis + Shippable (ran continuous integration tests).\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [X] New feature (non-breaking change which adds functionality)\r\n- [X] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project as found in the **CONTRIBUTING** document.\r\n- [X] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n","created_at":"2017-10-12T00:56:07Z","updated_at":"2017-10-13T12:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"127e66ee8e99b682cf467bc69c508ce3eb5ee270","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ubccr/xdmod/pulls/297/commits","review_comments_url":"https://api.github.com/repos/ubccr/xdmod/pulls/297/comments","review_comment_url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubccr/xdmod/issues/297/comments","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/9be1ab90e5f8cb83cd2bfbcc0edd7cd36095ecc6","head":{"label":"chakrabortyr:RC_GlobusCommit","ref":"RC_GlobusCommit","sha":"9be1ab90e5f8cb83cd2bfbcc0edd7cd36095ecc6","user":{"login":"chakrabortyr","id":2617780,"avatar_url":"https://avatars0.githubusercontent.com/u/2617780?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrabortyr","html_url":"https://github.com/chakrabortyr","followers_url":"https://api.github.com/users/chakrabortyr/followers","following_url":"https://api.github.com/users/chakrabortyr/following{/other_user}","gists_url":"https://api.github.com/users/chakrabortyr/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabortyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabortyr/subscriptions","organizations_url":"https://api.github.com/users/chakrabortyr/orgs","repos_url":"https://api.github.com/users/chakrabortyr/repos","events_url":"https://api.github.com/users/chakrabortyr/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabortyr/received_events","type":"User","site_admin":false},"repo":{"id":89559818,"name":"xdmod","full_name":"chakrabortyr/xdmod","owner":{"login":"chakrabortyr","id":2617780,"avatar_url":"https://avatars0.githubusercontent.com/u/2617780?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrabortyr","html_url":"https://github.com/chakrabortyr","followers_url":"https://api.github.com/users/chakrabortyr/followers","following_url":"https://api.github.com/users/chakrabortyr/following{/other_user}","gists_url":"https://api.github.com/users/chakrabortyr/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrabortyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrabortyr/subscriptions","organizations_url":"https://api.github.com/users/chakrabortyr/orgs","repos_url":"https://api.github.com/users/chakrabortyr/repos","events_url":"https://api.github.com/users/chakrabortyr/events{/privacy}","received_events_url":"https://api.github.com/users/chakrabortyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chakrabortyr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":true,"url":"https://api.github.com/repos/chakrabortyr/xdmod","forks_url":"https://api.github.com/repos/chakrabortyr/xdmod/forks","keys_url":"https://api.github.com/repos/chakrabortyr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chakrabortyr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chakrabortyr/xdmod/teams","hooks_url":"https://api.github.com/repos/chakrabortyr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/chakrabortyr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/chakrabortyr/xdmod/events","assignees_url":"https://api.github.com/repos/chakrabortyr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/chakrabortyr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/chakrabortyr/xdmod/tags","blobs_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chakrabortyr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/chakrabortyr/xdmod/languages","stargazers_url":"https://api.github.com/repos/chakrabortyr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/chakrabortyr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/chakrabortyr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/chakrabortyr/xdmod/subscription","commits_url":"https://api.github.com/repos/chakrabortyr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/chakrabortyr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/chakrabortyr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/chakrabortyr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/chakrabortyr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/chakrabortyr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chakrabortyr/xdmod/merges","archive_url":"https://api.github.com/repos/chakrabortyr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chakrabortyr/xdmod/downloads","issues_url":"https://api.github.com/repos/chakrabortyr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/chakrabortyr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/chakrabortyr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/chakrabortyr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chakrabortyr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/chakrabortyr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/chakrabortyr/xdmod/deployments","created_at":"2017-04-27T05:39:43Z","updated_at":"2017-04-27T05:39:47Z","pushed_at":"2017-10-13T01:41:31Z","git_url":"git://github.com/chakrabortyr/xdmod.git","ssh_url":"git@github.com:chakrabortyr/xdmod.git","clone_url":"https://github.com/chakrabortyr/xdmod.git","svn_url":"https://github.com/chakrabortyr/xdmod","homepage":"http://open.xdmod.org","size":5738,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"xdmod6.6"}},"base":{"label":"ubccr:xdmod7.1","ref":"xdmod7.1","sha":"0524d5a7e3f333d6b7f92d19d5a3c6cb4cfeb725","user":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"repo":{"id":72233032,"name":"xdmod","full_name":"ubccr/xdmod","owner":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubccr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":false,"url":"https://api.github.com/repos/ubccr/xdmod","forks_url":"https://api.github.com/repos/ubccr/xdmod/forks","keys_url":"https://api.github.com/repos/ubccr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubccr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubccr/xdmod/teams","hooks_url":"https://api.github.com/repos/ubccr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ubccr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ubccr/xdmod/events","assignees_url":"https://api.github.com/repos/ubccr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ubccr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ubccr/xdmod/tags","blobs_url":"https://api.github.com/repos/ubccr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubccr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubccr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubccr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ubccr/xdmod/languages","stargazers_url":"https://api.github.com/repos/ubccr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ubccr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ubccr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ubccr/xdmod/subscription","commits_url":"https://api.github.com/repos/ubccr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubccr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubccr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubccr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubccr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ubccr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubccr/xdmod/merges","archive_url":"https://api.github.com/repos/ubccr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubccr/xdmod/downloads","issues_url":"https://api.github.com/repos/ubccr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ubccr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ubccr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ubccr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubccr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ubccr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ubccr/xdmod/deployments","created_at":"2016-10-28T18:41:25Z","updated_at":"2017-09-26T12:58:44Z","pushed_at":"2017-10-13T01:41:33Z","git_url":"git://github.com/ubccr/xdmod.git","ssh_url":"git@github.com:ubccr/xdmod.git","clone_url":"https://github.com/ubccr/xdmod.git","svn_url":"https://github.com/ubccr/xdmod","homepage":"http://open.xdmod.org","size":5616,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":9,"forks":20,"open_issues":9,"watchers":17,"default_branch":"xdmod7.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/297"},"html":{"href":"https://github.com/ubccr/xdmod/pull/297"},"issue":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/297"},"comments":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/ubccr/xdmod/statuses/9be1ab90e5f8cb83cd2bfbcc0edd7cd36095ecc6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"smgallo"}}