{"action":"created","comment":{"url":"https://api.github.com/repos/cbeust/testng/pulls/comments/145682309","pull_request_review_id":70516146,"id":145682309,"diff_hunk":"@@ -18,9 +18,9 @@ public void testMethod(Class<?> clazz, int expectedStatus) {\n     @DataProvider\n     public Object[][] getData() {\n         return new Object[][]{\n-                {TestClassWithConfigFailureSample.class, 3},\n-                {TestClassWithConfigSkipSample.class, 2},\n-                {TestClassWithConfigSkipAndFailureSample.class, 3},\n+                {TestClassWithConfigFailureSample.class, 6},","path":"src/test/java/test/cli/github1517/ExitCodeListenerBehaviorTest.java","position":7,"original_position":7,"commit_id":"d6ecc005e9e5a1482cc604934da97a40bf7cb0d7","original_commit_id":"d6ecc005e9e5a1482cc604934da97a40bf7cb0d7","user":{"login":"krmahadevan","id":909773,"avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"body":"Sure I will fix it.","created_at":"2017-10-19T12:20:32Z","updated_at":"2017-10-19T12:20:33Z","html_url":"https://github.com/cbeust/testng/pull/1579#discussion_r145682309","pull_request_url":"https://api.github.com/repos/cbeust/testng/pulls/1579","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments/145682309"},"html":{"href":"https://github.com/cbeust/testng/pull/1579#discussion_r145682309"},"pull_request":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1579"}},"in_reply_to_id":145672807},"pull_request":{"url":"https://api.github.com/repos/cbeust/testng/pulls/1579","id":147493360,"html_url":"https://github.com/cbeust/testng/pull/1579","diff_url":"https://github.com/cbeust/testng/pull/1579.diff","patch_url":"https://github.com/cbeust/testng/pull/1579.patch","issue_url":"https://api.github.com/repos/cbeust/testng/issues/1579","number":1579,"state":"open","locked":false,"title":"Exception in DataProvider doesn't fail test run","user":{"login":"krmahadevan","id":909773,"avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"body":"Closes #217\r\n\r\nFollowing is the gist of changes done:\r\n* Deprecated the nested ExitCodeListener and added a new one.\r\n* Added null checks to ensure that an ITestResult object created based on a Description object is not\r\nnull. Description Object is typically seen to be null when JUnit encounters problems in parsing a method  as a test method.\r\n* The new ExitCodeListener now considers pass/fail/skip methods through-out the entire suite of suites to determine the effective return code (or) status. So altered some tests to now assert on the new status\r\n* Removed an invalid JUnit @Test (annotation on a  static method is not valid in JUnit world)\r\n* Since new ExitCodeListener is a reporter backed listener, altered a test that asserts on the reporter count. (UniqueReporterInjectionTest.java)\r\n\r\nFixes #217.\r\n\r\n### Did you remember to?\r\n\r\n- [X] Add test case(s)\r\n- [X] Update `CHANGES.txt`\r\n\r\nWe encourage pull requests that:\r\n\r\n* Add new features to TestNG (or)\r\n* Fix bugs in TestNG\r\n\r\nIf your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the \r\n[TestNG-dev](https://groups.google.com/forum/#!forum/testng-dev) before you spend time working on it.\r\n","created_at":"2017-10-19T08:21:05Z","updated_at":"2017-10-19T12:20:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0961f671307295c229515aa7e37844ed55615bbd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbeust/testng/pulls/1579/commits","review_comments_url":"https://api.github.com/repos/cbeust/testng/pulls/1579/comments","review_comment_url":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbeust/testng/issues/1579/comments","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/d6ecc005e9e5a1482cc604934da97a40bf7cb0d7","head":{"label":"krmahadevan:krmahadevan-fix-217","ref":"krmahadevan-fix-217","sha":"d6ecc005e9e5a1482cc604934da97a40bf7cb0d7","user":{"login":"krmahadevan","id":909773,"avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"repo":{"id":35460849,"name":"testng","full_name":"krmahadevan/testng","owner":{"login":"krmahadevan","id":909773,"avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krmahadevan/testng","description":"TestNG testing framework","fork":true,"url":"https://api.github.com/repos/krmahadevan/testng","forks_url":"https://api.github.com/repos/krmahadevan/testng/forks","keys_url":"https://api.github.com/repos/krmahadevan/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krmahadevan/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krmahadevan/testng/teams","hooks_url":"https://api.github.com/repos/krmahadevan/testng/hooks","issue_events_url":"https://api.github.com/repos/krmahadevan/testng/issues/events{/number}","events_url":"https://api.github.com/repos/krmahadevan/testng/events","assignees_url":"https://api.github.com/repos/krmahadevan/testng/assignees{/user}","branches_url":"https://api.github.com/repos/krmahadevan/testng/branches{/branch}","tags_url":"https://api.github.com/repos/krmahadevan/testng/tags","blobs_url":"https://api.github.com/repos/krmahadevan/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krmahadevan/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krmahadevan/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/krmahadevan/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krmahadevan/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/krmahadevan/testng/languages","stargazers_url":"https://api.github.com/repos/krmahadevan/testng/stargazers","contributors_url":"https://api.github.com/repos/krmahadevan/testng/contributors","subscribers_url":"https://api.github.com/repos/krmahadevan/testng/subscribers","subscription_url":"https://api.github.com/repos/krmahadevan/testng/subscription","commits_url":"https://api.github.com/repos/krmahadevan/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/krmahadevan/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/krmahadevan/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/krmahadevan/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/krmahadevan/testng/contents/{+path}","compare_url":"https://api.github.com/repos/krmahadevan/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krmahadevan/testng/merges","archive_url":"https://api.github.com/repos/krmahadevan/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krmahadevan/testng/downloads","issues_url":"https://api.github.com/repos/krmahadevan/testng/issues{/number}","pulls_url":"https://api.github.com/repos/krmahadevan/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/krmahadevan/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/krmahadevan/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krmahadevan/testng/labels{/name}","releases_url":"https://api.github.com/repos/krmahadevan/testng/releases{/id}","deployments_url":"https://api.github.com/repos/krmahadevan/testng/deployments","created_at":"2015-05-12T02:00:29Z","updated_at":"2016-01-21T03:27:54Z","pushed_at":"2017-10-19T08:18:22Z","git_url":"git://github.com/krmahadevan/testng.git","ssh_url":"git@github.com:krmahadevan/testng.git","clone_url":"https://github.com/krmahadevan/testng.git","svn_url":"https://github.com/krmahadevan/testng","homepage":"http://testng.org","size":26167,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbeust:master","ref":"master","sha":"f4a6eb4f53c5585780381ed456c4edec5b944f0f","user":{"login":"cbeust","id":92322,"avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"repo":{"id":745749,"name":"testng","full_name":"cbeust/testng","owner":{"login":"cbeust","id":92322,"avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbeust/testng","description":"TestNG testing framework","fork":false,"url":"https://api.github.com/repos/cbeust/testng","forks_url":"https://api.github.com/repos/cbeust/testng/forks","keys_url":"https://api.github.com/repos/cbeust/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbeust/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbeust/testng/teams","hooks_url":"https://api.github.com/repos/cbeust/testng/hooks","issue_events_url":"https://api.github.com/repos/cbeust/testng/issues/events{/number}","events_url":"https://api.github.com/repos/cbeust/testng/events","assignees_url":"https://api.github.com/repos/cbeust/testng/assignees{/user}","branches_url":"https://api.github.com/repos/cbeust/testng/branches{/branch}","tags_url":"https://api.github.com/repos/cbeust/testng/tags","blobs_url":"https://api.github.com/repos/cbeust/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbeust/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbeust/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbeust/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/cbeust/testng/languages","stargazers_url":"https://api.github.com/repos/cbeust/testng/stargazers","contributors_url":"https://api.github.com/repos/cbeust/testng/contributors","subscribers_url":"https://api.github.com/repos/cbeust/testng/subscribers","subscription_url":"https://api.github.com/repos/cbeust/testng/subscription","commits_url":"https://api.github.com/repos/cbeust/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbeust/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbeust/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbeust/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbeust/testng/contents/{+path}","compare_url":"https://api.github.com/repos/cbeust/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbeust/testng/merges","archive_url":"https://api.github.com/repos/cbeust/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbeust/testng/downloads","issues_url":"https://api.github.com/repos/cbeust/testng/issues{/number}","pulls_url":"https://api.github.com/repos/cbeust/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/cbeust/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/cbeust/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbeust/testng/labels{/name}","releases_url":"https://api.github.com/repos/cbeust/testng/releases{/id}","deployments_url":"https://api.github.com/repos/cbeust/testng/deployments","created_at":"2010-06-28T23:10:17Z","updated_at":"2017-10-19T02:29:59Z","pushed_at":"2017-10-19T08:21:06Z","git_url":"git://github.com/cbeust/testng.git","ssh_url":"git@github.com:cbeust/testng.git","clone_url":"https://github.com/cbeust/testng.git","svn_url":"https://github.com/cbeust/testng","homepage":"http://testng.org","size":26158,"stargazers_count":923,"watchers_count":923,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":625,"mirror_url":null,"open_issues_count":301,"forks":625,"open_issues":301,"watchers":923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1579"},"html":{"href":"https://github.com/cbeust/testng/pull/1579"},"issue":{"href":"https://api.github.com/repos/cbeust/testng/issues/1579"},"comments":{"href":"https://api.github.com/repos/cbeust/testng/issues/1579/comments"},"review_comments":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1579/comments"},"review_comment":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1579/commits"},"statuses":{"href":"https://api.github.com/repos/cbeust/testng/statuses/d6ecc005e9e5a1482cc604934da97a40bf7cb0d7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"krmahadevan"}}