{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/3404","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/3404/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/3404/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/3404/events","html_url":"https://github.com/LMMS/lmms/pull/3404","id":211935135,"number":3404,"title":"Fixes to CLI renderer","user":{"login":"PaulBatchelor","id":8139389,"avatar_url":"https://avatars0.githubusercontent.com/u/8139389?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulBatchelor","html_url":"https://github.com/PaulBatchelor","followers_url":"https://api.github.com/users/PaulBatchelor/followers","following_url":"https://api.github.com/users/PaulBatchelor/following{/other_user}","gists_url":"https://api.github.com/users/PaulBatchelor/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulBatchelor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulBatchelor/subscriptions","organizations_url":"https://api.github.com/users/PaulBatchelor/orgs","repos_url":"https://api.github.com/users/PaulBatchelor/repos","events_url":"https://api.github.com/users/PaulBatchelor/events{/privacy}","received_events_url":"https://api.github.com/users/PaulBatchelor/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-03-05T06:49:36Z","updated_at":"2017-03-22T07:17:30Z","closed_at":"2017-03-21T16:52:29Z","pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/3404","html_url":"https://github.com/LMMS/lmms/pull/3404","diff_url":"https://github.com/LMMS/lmms/pull/3404.diff","patch_url":"https://github.com/LMMS/lmms/pull/3404.patch"},"body":"This PR contains some tweaks which address #3402 \r\n\r\nThis fix should now allow individuals to render audio using \"lmms -r\" without having to worry about the glitches or pops from before. \r\n\r\nI noticed that calling the CLI renderer was unnecessarily calling JACK, and possibly interfering with the renderer processing thread. What I did was ensure that the audio/MIDI devices were set to \"dummy\" when renderOnly mode was set to true. After applying this fix, I was able to render offline without having things skip or crash. \r\n\r\nNote that this fix is only for the CLI renderer, and not for the internal LMMS exporter (this still crashes for me). "},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/288317468","html_url":"https://github.com/LMMS/lmms/pull/3404#issuecomment-288317468","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/3404","id":288317468,"user":{"login":"Lukas-W","id":2879917,"avatar_url":"https://avatars1.githubusercontent.com/u/2879917?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukas-W","html_url":"https://github.com/Lukas-W","followers_url":"https://api.github.com/users/Lukas-W/followers","following_url":"https://api.github.com/users/Lukas-W/following{/other_user}","gists_url":"https://api.github.com/users/Lukas-W/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukas-W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukas-W/subscriptions","organizations_url":"https://api.github.com/users/Lukas-W/orgs","repos_url":"https://api.github.com/users/Lukas-W/repos","events_url":"https://api.github.com/users/Lukas-W/events{/privacy}","received_events_url":"https://api.github.com/users/Lukas-W/received_events","type":"User","site_admin":false},"created_at":"2017-03-22T07:17:30Z","updated_at":"2017-03-22T07:17:30Z","body":"@jasp00 I'm not sure what you're saying. I tried doing the following:\r\n\r\n1. Started LMMS, opened `abc.mmp`, closed LMMS\r\n2. Ran `lmms -r xyz.mmp`\r\n3. Started LMMS\r\n\r\n\"Recent files\" then showed `xyz.mmp` and `abc.mmp` in that order, which is pretty much what I'd expect. Am I getting you wrong?"}}
{"actor":{"display_login":"Lukas-W"}}