{"action":"created","issue":{"url":"https://api.github.com/repos/TrueCar/gluestick/issues/380","repository_url":"https://api.github.com/repos/TrueCar/gluestick","labels_url":"https://api.github.com/repos/TrueCar/gluestick/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/TrueCar/gluestick/issues/380/comments","events_url":"https://api.github.com/repos/TrueCar/gluestick/issues/380/events","html_url":"https://github.com/TrueCar/gluestick/pull/380","id":197048654,"number":380,"title":"Static support","user":{"login":"marcdel","id":693730,"avatar_url":"https://avatars.githubusercontent.com/u/693730?v=3","gravatar_id":"","url":"https://api.github.com/users/marcdel","html_url":"https://github.com/marcdel","followers_url":"https://api.github.com/users/marcdel/followers","following_url":"https://api.github.com/users/marcdel/following{/other_user}","gists_url":"https://api.github.com/users/marcdel/gists{/gist_id}","starred_url":"https://api.github.com/users/marcdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcdel/subscriptions","organizations_url":"https://api.github.com/users/marcdel/orgs","repos_url":"https://api.github.com/users/marcdel/repos","events_url":"https://api.github.com/users/marcdel/events{/privacy}","received_events_url":"https://api.github.com/users/marcdel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"cybrass","id":59530,"avatar_url":"https://avatars.githubusercontent.com/u/59530?v=3","gravatar_id":"","url":"https://api.github.com/users/cybrass","html_url":"https://github.com/cybrass","followers_url":"https://api.github.com/users/cybrass/followers","following_url":"https://api.github.com/users/cybrass/following{/other_user}","gists_url":"https://api.github.com/users/cybrass/gists{/gist_id}","starred_url":"https://api.github.com/users/cybrass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cybrass/subscriptions","organizations_url":"https://api.github.com/users/cybrass/orgs","repos_url":"https://api.github.com/users/cybrass/repos","events_url":"https://api.github.com/users/cybrass/events{/privacy}","received_events_url":"https://api.github.com/users/cybrass/received_events","type":"User","site_admin":false},"assignees":[{"login":"cybrass","id":59530,"avatar_url":"https://avatars.githubusercontent.com/u/59530?v=3","gravatar_id":"","url":"https://api.github.com/users/cybrass","html_url":"https://github.com/cybrass","followers_url":"https://api.github.com/users/cybrass/followers","following_url":"https://api.github.com/users/cybrass/following{/other_user}","gists_url":"https://api.github.com/users/cybrass/gists{/gist_id}","starred_url":"https://api.github.com/users/cybrass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cybrass/subscriptions","organizations_url":"https://api.github.com/users/cybrass/orgs","repos_url":"https://api.github.com/users/cybrass/repos","events_url":"https://api.github.com/users/cybrass/events{/privacy}","received_events_url":"https://api.github.com/users/cybrass/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-21T22:28:36Z","updated_at":"2017-02-06T22:57:22Z","closed_at":"2017-02-06T22:57:22Z","pull_request":{"url":"https://api.github.com/repos/TrueCar/gluestick/pulls/380","html_url":"https://github.com/TrueCar/gluestick/pull/380","diff_url":"https://github.com/TrueCar/gluestick/pull/380.diff","patch_url":"https://github.com/TrueCar/gluestick/pull/380.patch"},"body":"Hey @toddw / @cybrass,\r\n\r\nI wasn't sure whether to PR against `develop` or `toddw/static-support`, but the later was a bit noisy since the branch is out of date. Happy to make another one there instead if you'd rather though.\r\n\r\nThe feature itself is now working (I was able to create/build a [test app](http://gluestick-static-test.s3-website-us-east-1.amazonaws.com/) with my branch and upload the `build` folder to S3 and it works great), and normal start/build commands seem to be working again as well.\r\n\r\nI could use some guidance on the tests. I'm a bit stumped writing the tests for generateStaticHTMLFile (see the PR [here](https://github.com/marcdel/gluestick/pull/1) for weirdo webpack issues). Also, some of the tests I wrote for RequestHandler.prepareOutput may not be necessary and there may be some that I missed. Open to any suggestions."},"comment":{"url":"https://api.github.com/repos/TrueCar/gluestick/issues/comments/277841916","html_url":"https://github.com/TrueCar/gluestick/pull/380#issuecomment-277841916","issue_url":"https://api.github.com/repos/TrueCar/gluestick/issues/380","id":277841916,"user":{"login":"marcdel","id":693730,"avatar_url":"https://avatars.githubusercontent.com/u/693730?v=3","gravatar_id":"","url":"https://api.github.com/users/marcdel","html_url":"https://github.com/marcdel","followers_url":"https://api.github.com/users/marcdel/followers","following_url":"https://api.github.com/users/marcdel/following{/other_user}","gists_url":"https://api.github.com/users/marcdel/gists{/gist_id}","starred_url":"https://api.github.com/users/marcdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcdel/subscriptions","organizations_url":"https://api.github.com/users/marcdel/orgs","repos_url":"https://api.github.com/users/marcdel/repos","events_url":"https://api.github.com/users/marcdel/events{/privacy}","received_events_url":"https://api.github.com/users/marcdel/received_events","type":"User","site_admin":false},"created_at":"2017-02-06T22:57:22Z","updated_at":"2017-02-06T22:57:22Z","body":"Closing in favor of https://github.com/TrueCar/gluestick/pull/539"}}
{"actor":{"display_login":"marcdel"}}