{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/7474","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/7474/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/7474/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/7474/events","html_url":"https://github.com/librenms/librenms/pull/7474","id":264463064,"number":7474,"title":"feature: Web validation","user":{"login":"murrant","id":39462,"avatar_url":"https://avatars2.githubusercontent.com/u/39462?v=4","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-11T05:40:05Z","updated_at":"2017-10-12T15:37:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/7474","html_url":"https://github.com/librenms/librenms/pull/7474","diff_url":"https://github.com/librenms/librenms/pull/7474.diff","patch_url":"https://github.com/librenms/librenms/pull/7474.patch"},"body":"Allow validations to be run and viewed from the web page.\r\nPre-check cannot be run on the web, because we won't get a web page if those don't work.\r\nMake validations modular and hopefully easier to manage/write.\r\n\r\nWork In Progress, looking for feedback.\r\n\r\nTODO:\r\n\r\n- [ ] fix certain validations that fail when run under the webui\r\n- [ ] clickable links\r\n- [ ] Review new console output\r\n- [ ] go through and pull out or create fixes text\r\n- [ ] clean up code and standardize names\r\n- [ ] Create tests?\r\n\r\nProbably future:\r\nmake fixes actionable (like a fix button)\r\nmake async instead of running on page load\r\n\r\n![image](https://user-images.githubusercontent.com/39462/31423910-056e85c0-ae1d-11e7-8b80-0d71a4b78ebd.png)\r\n\r\n\r\nDO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\n"},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/336176480","html_url":"https://github.com/librenms/librenms/pull/7474#issuecomment-336176480","issue_url":"https://api.github.com/repos/librenms/librenms/issues/7474","id":336176480,"user":{"login":"scrutinizer-notifier","id":6398257,"avatar_url":"https://avatars3.githubusercontent.com/u/6398257?v=4","gravatar_id":"","url":"https://api.github.com/users/scrutinizer-notifier","html_url":"https://github.com/scrutinizer-notifier","followers_url":"https://api.github.com/users/scrutinizer-notifier/followers","following_url":"https://api.github.com/users/scrutinizer-notifier/following{/other_user}","gists_url":"https://api.github.com/users/scrutinizer-notifier/gists{/gist_id}","starred_url":"https://api.github.com/users/scrutinizer-notifier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrutinizer-notifier/subscriptions","organizations_url":"https://api.github.com/users/scrutinizer-notifier/orgs","repos_url":"https://api.github.com/users/scrutinizer-notifier/repos","events_url":"https://api.github.com/users/scrutinizer-notifier/events{/privacy}","received_events_url":"https://api.github.com/users/scrutinizer-notifier/received_events","type":"User","site_admin":false},"created_at":"2017-10-12T15:37:51Z","updated_at":"2017-10-12T15:37:51Z","author_association":"NONE","body":"The [inspection](https://scrutinizer-ci.com/g/librenms/librenms/inspections/9545b90d-ce8f-4842-9905-c8314d1f6869) completed: **1 updated code elements**"}}
{"actor":{"display_login":"scrutinizer-notifier"}}