{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/129863013","pull_request_review_id":52679440,"id":129863013,"diff_hunk":"@@ -27,7 +30,7 @@ def is_first_master(self):\n         return masters[0] == hostname\n \n     def run(self):\n-        pass\n+        return {}","path":"roles/openshift_health_checker/openshift_checks/logging/logging.py","position":15,"original_position":15,"commit_id":"d6d5fe2954942a6706f5ae0255d94435ceade50b","original_commit_id":"85bb52d586297233728d331e37ef238e902bfeac","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars0.githubusercontent.com/u/88819?v=4","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"I believe the more appropriate change would be to make this a `LoggingMixin` or such, and then this class wouldn't be listed as a check. For now, simply making it comply with the API and return a dict, avoiding an unhandled exception.","created_at":"2017-07-27T14:48:06Z","updated_at":"2017-07-27T14:49:29Z","html_url":"https://github.com/openshift/openshift-ansible/pull/4899#discussion_r129863013","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/129863013"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/4899#discussion_r129863013"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899","id":132766164,"html_url":"https://github.com/openshift/openshift-ansible/pull/4899","diff_url":"https://github.com/openshift/openshift-ansible/pull/4899.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/4899.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/4899","number":4899,"state":"open","locked":false,"title":"Misc cleanup and input normalization","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars0.githubusercontent.com/u/88819?v=4","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"Taking some commits out of #4570 to make it easier to review.","created_at":"2017-07-27T14:43:23Z","updated_at":"2017-07-27T14:49:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57cb6cae7887d060cd8913634d7ad0d91b9346c7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/4899/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/d6d5fe2954942a6706f5ae0255d94435ceade50b","head":{"label":"rhcarvalho:misc-cleanup-normalize-input","ref":"misc-cleanup-normalize-input","sha":"d6d5fe2954942a6706f5ae0255d94435ceade50b","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars0.githubusercontent.com/u/88819?v=4","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"repo":{"id":71343790,"name":"openshift-ansible","full_name":"rhcarvalho/openshift-ansible","owner":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars0.githubusercontent.com/u/88819?v=4","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhcarvalho/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/rhcarvalho/openshift-ansible","forks_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/forks","keys_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/events","assignees_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/merges","archive_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/rhcarvalho/openshift-ansible/deployments","created_at":"2016-10-19T10:01:26Z","updated_at":"2016-12-06T15:34:18Z","pushed_at":"2017-07-27T14:41:32Z","git_url":"git://github.com/rhcarvalho/openshift-ansible.git","ssh_url":"git@github.com:rhcarvalho/openshift-ansible.git","clone_url":"https://github.com/rhcarvalho/openshift-ansible.git","svn_url":"https://github.com/rhcarvalho/openshift-ansible","homepage":"install.openshift.com","size":14255,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6a9fd57be17d03818eb1f72cc9d62505690eec14","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2017-07-27T12:19:45Z","pushed_at":"2017-07-27T14:43:24Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":15978,"stargazers_count":503,"watchers_count":503,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":783,"mirror_url":null,"open_issues_count":536,"forks":783,"open_issues":536,"watchers":503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/4899"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/4899"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/4899/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/4899/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/d6d5fe2954942a6706f5ae0255d94435ceade50b"}}}}
{"actor":{"display_login":"rhcarvalho"}}