{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/comments/157823494","pull_request_review_id":84529943,"id":157823494,"diff_hunk":"@@ -78,12 +75,18 @@ def client_options\n                                     \"[#{VALID_TXT_OPTIONS.join(', ')}].\".freeze\n \n       MISTMATCHED_DOMAINNAME = \"Parent domain name in SRV record result (%s) does not match \" +\n-                                 \"hostname (%s)\".freeze\n+                                 \"that of the hostname (%s)\".freeze\n+\n+      FORMAT = 'mongodb+srv://[username:password@]host[/[database][?options]]'.freeze","path":"lib/mongo/uri/srv_protocol.rb","position":null,"original_position":49,"commit_id":"1c47873e24281b0fc6a1142f8486fb227909d422","original_commit_id":"c115dd3b094ba5caae1da64dd7e0fe1ad77c6a8f","user":{"login":"saghm","id":5875560,"avatar_url":"https://avatars2.githubusercontent.com/u/5875560?v=4","gravatar_id":"","url":"https://api.github.com/users/saghm","html_url":"https://github.com/saghm","followers_url":"https://api.github.com/users/saghm/followers","following_url":"https://api.github.com/users/saghm/following{/other_user}","gists_url":"https://api.github.com/users/saghm/gists{/gist_id}","starred_url":"https://api.github.com/users/saghm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghm/subscriptions","organizations_url":"https://api.github.com/users/saghm/orgs","repos_url":"https://api.github.com/users/saghm/repos","events_url":"https://api.github.com/users/saghm/events{/privacy}","received_events_url":"https://api.github.com/users/saghm/received_events","type":"User","site_admin":false},"body":"I think it should begin with `mongodb[+srv]` since the \"+srv\" is optional","created_at":"2017-12-19T17:34:26Z","updated_at":"2017-12-19T17:34:54Z","html_url":"https://github.com/mongodb/mongo-ruby-driver/pull/898#discussion_r157823494","pull_request_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/comments/157823494"},"html":{"href":"https://github.com/mongodb/mongo-ruby-driver/pull/898#discussion_r157823494"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898"}}},"pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898","id":158905766,"html_url":"https://github.com/mongodb/mongo-ruby-driver/pull/898","diff_url":"https://github.com/mongodb/mongo-ruby-driver/pull/898.diff","patch_url":"https://github.com/mongodb/mongo-ruby-driver/pull/898.patch","issue_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/issues/898","number":898,"state":"open","locked":false,"title":"RUBY-1245 Support SRV protocol for connection strings","user":{"login":"estolfo","id":699369,"avatar_url":"https://avatars1.githubusercontent.com/u/699369?v=4","gravatar_id":"","url":"https://api.github.com/users/estolfo","html_url":"https://github.com/estolfo","followers_url":"https://api.github.com/users/estolfo/followers","following_url":"https://api.github.com/users/estolfo/following{/other_user}","gists_url":"https://api.github.com/users/estolfo/gists{/gist_id}","starred_url":"https://api.github.com/users/estolfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estolfo/subscriptions","organizations_url":"https://api.github.com/users/estolfo/orgs","repos_url":"https://api.github.com/users/estolfo/repos","events_url":"https://api.github.com/users/estolfo/events{/privacy}","received_events_url":"https://api.github.com/users/estolfo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-18T12:48:59Z","updated_at":"2017-12-19T17:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6649a730d2f58570c638de5152ab57d7c52cda37","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898/commits","review_comments_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898/comments","review_comment_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/issues/898/comments","statuses_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/statuses/1c47873e24281b0fc6a1142f8486fb227909d422","head":{"label":"estolfo:RUBY-1245-srv","ref":"RUBY-1245-srv","sha":"1c47873e24281b0fc6a1142f8486fb227909d422","user":{"login":"estolfo","id":699369,"avatar_url":"https://avatars1.githubusercontent.com/u/699369?v=4","gravatar_id":"","url":"https://api.github.com/users/estolfo","html_url":"https://github.com/estolfo","followers_url":"https://api.github.com/users/estolfo/followers","following_url":"https://api.github.com/users/estolfo/following{/other_user}","gists_url":"https://api.github.com/users/estolfo/gists{/gist_id}","starred_url":"https://api.github.com/users/estolfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estolfo/subscriptions","organizations_url":"https://api.github.com/users/estolfo/orgs","repos_url":"https://api.github.com/users/estolfo/repos","events_url":"https://api.github.com/users/estolfo/events{/privacy}","received_events_url":"https://api.github.com/users/estolfo/received_events","type":"User","site_admin":false},"repo":{"id":8504548,"name":"mongo-ruby-driver","full_name":"estolfo/mongo-ruby-driver","owner":{"login":"estolfo","id":699369,"avatar_url":"https://avatars1.githubusercontent.com/u/699369?v=4","gravatar_id":"","url":"https://api.github.com/users/estolfo","html_url":"https://github.com/estolfo","followers_url":"https://api.github.com/users/estolfo/followers","following_url":"https://api.github.com/users/estolfo/following{/other_user}","gists_url":"https://api.github.com/users/estolfo/gists{/gist_id}","starred_url":"https://api.github.com/users/estolfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estolfo/subscriptions","organizations_url":"https://api.github.com/users/estolfo/orgs","repos_url":"https://api.github.com/users/estolfo/repos","events_url":"https://api.github.com/users/estolfo/events{/privacy}","received_events_url":"https://api.github.com/users/estolfo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estolfo/mongo-ruby-driver","description":"My fork of the Ruby driver to MongoDB","fork":true,"url":"https://api.github.com/repos/estolfo/mongo-ruby-driver","forks_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/forks","keys_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/teams","hooks_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/hooks","issue_events_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/issues/events{/number}","events_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/events","assignees_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/assignees{/user}","branches_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/branches{/branch}","tags_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/tags","blobs_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/languages","stargazers_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/stargazers","contributors_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/contributors","subscribers_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/subscribers","subscription_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/subscription","commits_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/contents/{+path}","compare_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/merges","archive_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/downloads","issues_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/issues{/number}","pulls_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/labels{/name}","releases_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/releases{/id}","deployments_url":"https://api.github.com/repos/estolfo/mongo-ruby-driver/deployments","created_at":"2013-03-01T15:47:27Z","updated_at":"2017-01-11T16:43:27Z","pushed_at":"2017-12-19T15:42:26Z","git_url":"git://github.com/estolfo/mongo-ruby-driver.git","ssh_url":"git@github.com:estolfo/mongo-ruby-driver.git","clone_url":"https://github.com/estolfo/mongo-ruby-driver.git","svn_url":"https://github.com/estolfo/mongo-ruby-driver","homepage":"http://api.mongodb.org/ruby","size":33166,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"a6d7a6aa3c036859bdb6039205f7127a61ef2fb5","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":108125,"name":"mongo-ruby-driver","full_name":"mongodb/mongo-ruby-driver","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-ruby-driver","description":"Ruby driver for MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-ruby-driver","forks_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/mongo-ruby-driver/deployments","created_at":"2009-01-15T16:40:45Z","updated_at":"2017-12-16T19:35:21Z","pushed_at":"2017-12-19T15:43:05Z","git_url":"git://github.com/mongodb/mongo-ruby-driver.git","ssh_url":"git@github.com:mongodb/mongo-ruby-driver.git","clone_url":"https://github.com/mongodb/mongo-ruby-driver.git","svn_url":"https://github.com/mongodb/mongo-ruby-driver","homepage":"http://api.mongodb.org/ruby","size":33082,"stargazers_count":1323,"watchers_count":1323,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":473,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":473,"open_issues":7,"watchers":1323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898"},"html":{"href":"https://github.com/mongodb/mongo-ruby-driver/pull/898"},"issue":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/issues/898"},"comments":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/mongo-ruby-driver/statuses/1c47873e24281b0fc6a1142f8486fb227909d422"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"saghm"}}