{"action":"created","issue":{"url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/issues/199","repository_url":"https://api.github.com/repos/PlasmaPy/PlasmaPy","labels_url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/issues/199/labels{/name}","comments_url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/issues/199/comments","events_url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/issues/199/events","html_url":"https://github.com/PlasmaPy/PlasmaPy/pull/199","id":282722973,"number":199,"title":"Braginskii","user":{"login":"samurai688","id":12175315,"avatar_url":"https://avatars1.githubusercontent.com/u/12175315?v=4","gravatar_id":"","url":"https://api.github.com/users/samurai688","html_url":"https://github.com/samurai688","followers_url":"https://api.github.com/users/samurai688/followers","following_url":"https://api.github.com/users/samurai688/following{/other_user}","gists_url":"https://api.github.com/users/samurai688/gists{/gist_id}","starred_url":"https://api.github.com/users/samurai688/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samurai688/subscriptions","organizations_url":"https://api.github.com/users/samurai688/orgs","repos_url":"https://api.github.com/users/samurai688/repos","events_url":"https://api.github.com/users/samurai688/events{/privacy}","received_events_url":"https://api.github.com/users/samurai688/received_events","type":"User","site_admin":false},"labels":[{"id":662380318,"url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/labels/Physics","name":"Physics","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"StanczakDominik","id":11289391,"avatar_url":"https://avatars0.githubusercontent.com/u/11289391?v=4","gravatar_id":"","url":"https://api.github.com/users/StanczakDominik","html_url":"https://github.com/StanczakDominik","followers_url":"https://api.github.com/users/StanczakDominik/followers","following_url":"https://api.github.com/users/StanczakDominik/following{/other_user}","gists_url":"https://api.github.com/users/StanczakDominik/gists{/gist_id}","starred_url":"https://api.github.com/users/StanczakDominik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanczakDominik/subscriptions","organizations_url":"https://api.github.com/users/StanczakDominik/orgs","repos_url":"https://api.github.com/users/StanczakDominik/repos","events_url":"https://api.github.com/users/StanczakDominik/events{/privacy}","received_events_url":"https://api.github.com/users/StanczakDominik/received_events","type":"User","site_admin":false},"assignees":[{"login":"StanczakDominik","id":11289391,"avatar_url":"https://avatars0.githubusercontent.com/u/11289391?v=4","gravatar_id":"","url":"https://api.github.com/users/StanczakDominik","html_url":"https://github.com/StanczakDominik","followers_url":"https://api.github.com/users/StanczakDominik/followers","following_url":"https://api.github.com/users/StanczakDominik/following{/other_user}","gists_url":"https://api.github.com/users/StanczakDominik/gists{/gist_id}","starred_url":"https://api.github.com/users/StanczakDominik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanczakDominik/subscriptions","organizations_url":"https://api.github.com/users/StanczakDominik/orgs","repos_url":"https://api.github.com/users/StanczakDominik/repos","events_url":"https://api.github.com/users/StanczakDominik/events{/privacy}","received_events_url":"https://api.github.com/users/StanczakDominik/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/milestones/1","html_url":"https://github.com/PlasmaPy/PlasmaPy/milestone/1","labels_url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/milestones/1/labels","id":2541199,"number":1,"title":"v0.1","description":"Tasks and features for our first minor release. Feature freeze intended for 01/18/2018.","creator":{"login":"namurphy","id":8931994,"avatar_url":"https://avatars0.githubusercontent.com/u/8931994?v=4","gravatar_id":"","url":"https://api.github.com/users/namurphy","html_url":"https://github.com/namurphy","followers_url":"https://api.github.com/users/namurphy/followers","following_url":"https://api.github.com/users/namurphy/following{/other_user}","gists_url":"https://api.github.com/users/namurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/namurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namurphy/subscriptions","organizations_url":"https://api.github.com/users/namurphy/orgs","repos_url":"https://api.github.com/users/namurphy/repos","events_url":"https://api.github.com/users/namurphy/events{/privacy}","received_events_url":"https://api.github.com/users/namurphy/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":73,"state":"open","created_at":"2017-05-24T17:24:00Z","updated_at":"2017-12-29T19:37:47Z","due_on":"2018-02-18T08:00:00Z","closed_at":null},"comments":15,"created_at":"2017-12-17T20:54:12Z","updated_at":"2017-12-29T21:14:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/pulls/199","html_url":"https://github.com/PlasmaPy/PlasmaPy/pull/199","diff_url":"https://github.com/PlasmaPy/PlasmaPy/pull/199.diff","patch_url":"https://github.com/PlasmaPy/PlasmaPy/pull/199.patch"},"body":"Working on Issue #35 . I've put in some functionality and done some preliminary checks and tests. Definitely still a work in progress, needs tests and documentation and then is going to need some ruthless refactoring. Oh shoot, and the PEP8 checking-thing is going to have a fit.\r\n"},"comment":{"url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/issues/comments/354501281","html_url":"https://github.com/PlasmaPy/PlasmaPy/pull/199#issuecomment-354501281","issue_url":"https://api.github.com/repos/PlasmaPy/PlasmaPy/issues/199","id":354501281,"user":{"login":"StanczakDominik","id":11289391,"avatar_url":"https://avatars0.githubusercontent.com/u/11289391?v=4","gravatar_id":"","url":"https://api.github.com/users/StanczakDominik","html_url":"https://github.com/StanczakDominik","followers_url":"https://api.github.com/users/StanczakDominik/followers","following_url":"https://api.github.com/users/StanczakDominik/following{/other_user}","gists_url":"https://api.github.com/users/StanczakDominik/gists{/gist_id}","starred_url":"https://api.github.com/users/StanczakDominik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanczakDominik/subscriptions","organizations_url":"https://api.github.com/users/StanczakDominik/orgs","repos_url":"https://api.github.com/users/StanczakDominik/repos","events_url":"https://api.github.com/users/StanczakDominik/events{/privacy}","received_events_url":"https://api.github.com/users/StanczakDominik/received_events","type":"User","site_admin":false},"created_at":"2017-12-29T21:14:51Z","updated_at":"2017-12-29T21:14:51Z","author_association":"OWNER","body":"Okay then! I'm pushing those changes here. The `if hall_e` is a very valid point, I thought it would simplify the code but it will indeed mess up on zero. (Hopefully tomorrow) I'll fix it and try to add the subclasses to models.\r\n\r\nBy the way,  two more questions:\r\n* what do you think about making most of the variables like `get_spitzer_harm_coeffs` or `nondim_whatever` private (as in, `_nondim_whatever` starting with a `_`)? That way it can still be imported if someone really wants to, but it doesn't populate the namespace by default (as we have * imports in our __init__.py's, which I'm not really sure about either). So the default and preferred way to access resistivity etc. functions would be through `classical_transport` or subclasses.\r\n* I forgot the second one. I'll probably ask it later :laughing: \r\n\r\nAnyway, I'd still like to ask @namurphy and @lemmatum for a brief review of the proposed API to these coefficients. It's working right now, let's get it working nicely."}}
{"actor":{"display_login":"StanczakDominik"}}