{"action":"created","issue":{"url":"https://api.github.com/repos/zalando/skipper/issues/251","repository_url":"https://api.github.com/repos/zalando/skipper","labels_url":"https://api.github.com/repos/zalando/skipper/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/zalando/skipper/issues/251/comments","events_url":"https://api.github.com/repos/zalando/skipper/issues/251/events","html_url":"https://github.com/zalando/skipper/issues/251","id":201686010,"number":251,"title":"consider using ULID for flowid","user":{"login":"lmineiro","id":4234681,"avatar_url":"https://avatars.githubusercontent.com/u/4234681?v=3","gravatar_id":"","url":"https://api.github.com/users/lmineiro","html_url":"https://github.com/lmineiro","followers_url":"https://api.github.com/users/lmineiro/followers","following_url":"https://api.github.com/users/lmineiro/following{/other_user}","gists_url":"https://api.github.com/users/lmineiro/gists{/gist_id}","starred_url":"https://api.github.com/users/lmineiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmineiro/subscriptions","organizations_url":"https://api.github.com/users/lmineiro/orgs","repos_url":"https://api.github.com/users/lmineiro/repos","events_url":"https://api.github.com/users/lmineiro/events{/privacy}","received_events_url":"https://api.github.com/users/lmineiro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-01-18T20:39:03Z","updated_at":"2017-01-19T20:01:21Z","closed_at":null,"body":"Recently learned about https://github.com/oklog/ulid which, without entropy, seems very performant and could offer lexicographically sortable flow Ids.\r\n\r\nI also like the alphabet better.\r\n\r\nExisting filter can be refactored to support a a new parameter defining the generator.\r\n\r\nhead to head benchmarking should be enough to add to the docs.\r\n\r\nI suggest the fastest to become the default"},"comment":{"url":"https://api.github.com/repos/zalando/skipper/issues/comments/273882337","html_url":"https://github.com/zalando/skipper/issues/251#issuecomment-273882337","issue_url":"https://api.github.com/repos/zalando/skipper/issues/251","id":273882337,"user":{"login":"lmineiro","id":4234681,"avatar_url":"https://avatars.githubusercontent.com/u/4234681?v=3","gravatar_id":"","url":"https://api.github.com/users/lmineiro","html_url":"https://github.com/lmineiro","followers_url":"https://api.github.com/users/lmineiro/followers","following_url":"https://api.github.com/users/lmineiro/following{/other_user}","gists_url":"https://api.github.com/users/lmineiro/gists{/gist_id}","starred_url":"https://api.github.com/users/lmineiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmineiro/subscriptions","organizations_url":"https://api.github.com/users/lmineiro/orgs","repos_url":"https://api.github.com/users/lmineiro/repos","events_url":"https://api.github.com/users/lmineiro/events{/privacy}","received_events_url":"https://api.github.com/users/lmineiro/received_events","type":"User","site_admin":false},"created_at":"2017-01-19T20:01:21Z","updated_at":"2017-01-19T20:01:21Z","body":"For the sake of confirmation, I made some additional tests.\r\n\r\n1. Reusing the same entropy provider directly as a generator internal member (**not thread safe**)\r\n```\r\nBenchmarkFlowId/ULID-Generator-8    \t10000000\t       170 ns/op\r\n```\r\n2. sync.Pool Get() always returning the same entropy provider (**not thread safe**)\r\n```\r\nBenchmarkFlowId/ULID-Generator-8    \t 5000000\t       291 ns/op\r\n```\r\n3. It's exactly the same as 1) above, but uses a mutex (**thread safe**)\r\n```\r\nBenchmarkFlowId/ULID-Generator-8    \t 5000000\t       288 ns/op\r\n```"}}
{"actor":{"display_login":"lmineiro"}}