{"action":"created","issue":{"url":"https://api.github.com/repos/jwilm/alacritty/issues/268","repository_url":"https://api.github.com/repos/jwilm/alacritty","labels_url":"https://api.github.com/repos/jwilm/alacritty/issues/268/labels{/name}","comments_url":"https://api.github.com/repos/jwilm/alacritty/issues/268/comments","events_url":"https://api.github.com/repos/jwilm/alacritty/issues/268/events","html_url":"https://github.com/jwilm/alacritty/pull/268","id":199740566,"number":268,"title":"Fixing panic on cat /dev/urandom","user":{"login":"mbrumlow","id":1245807,"avatar_url":"https://avatars.githubusercontent.com/u/1245807?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrumlow","html_url":"https://github.com/mbrumlow","followers_url":"https://api.github.com/users/mbrumlow/followers","following_url":"https://api.github.com/users/mbrumlow/following{/other_user}","gists_url":"https://api.github.com/users/mbrumlow/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrumlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrumlow/subscriptions","organizations_url":"https://api.github.com/users/mbrumlow/orgs","repos_url":"https://api.github.com/users/mbrumlow/repos","events_url":"https://api.github.com/users/mbrumlow/events{/privacy}","received_events_url":"https://api.github.com/users/mbrumlow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-10T06:11:49Z","updated_at":"2017-01-10T07:11:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jwilm/alacritty/pulls/268","html_url":"https://github.com/jwilm/alacritty/pull/268","diff_url":"https://github.com/jwilm/alacritty/pull/268.diff","patch_url":"https://github.com/jwilm/alacritty/pull/268.patch"},"body":"- Checks to make sure lines count coming from the pty are within a proper\r\nrange before doing scrolling.\r\n\r\n- Sanitizes scroll region when being set.\r\n\r\n- Changes panic for unimplemented screen clear to a print statement.\r\n\r\nThe first two changes ensure scrolling won't crash us. By sanitizing the\r\nregion on set we don't have to complicate the scroll code with limits,\r\nmins, or maxes to ensure the scroll operation is within the range.\r\nChecking if the lines is greater than the total region allows us to\r\nsimply clear the region and avoid subtracting large numbers from small\r\nones.\r\n\r\nFixes #63\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jwilm/alacritty/issues/comments/271502779","html_url":"https://github.com/jwilm/alacritty/pull/268#issuecomment-271502779","issue_url":"https://api.github.com/repos/jwilm/alacritty/issues/268","id":271502779,"user":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"created_at":"2017-01-10T07:11:32Z","updated_at":"2017-01-10T07:11:32Z","body":"I was still getting one panic after your changes. I pushed one more change on top of them, and `cat /dev/urandom` no longer panics for me (at least within 10 minutes)."}}
{"actor":{"display_login":"jwilm"}}