{"action":"created","comment":{"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments/135400019","pull_request_review_id":58811656,"id":135400019,"diff_hunk":"@@ -186,35 +296,65 @@ def publish_ballots_to_audit(seed, cvrs):\n             if i in new_list:\n                 cvr['record_type'] = 'AUDITOR_ENTERED'\n                 selected.append(cvr)\n-                print(\"Selected cvr %d: id: %d RecordID: %s\" % (i, cvr['id'], cvr['imprinted_id']))\n+                logging.info(\"Selected cvr %d: id: %d RecordID: %s\" % (i, cvr['id'], cvr['imprinted_id']))\n \n         ballots_to_audit.append([county_id, selected])\n \n     return ballots_to_audit\n \n \n-def upload_files(baseurl, s):\n+def upload_files(ac, s):\n     \"\"\"Directly upload files, which zerotest doesn't support.\n     See \"File upload via POST request not working: Issue #12\"\n      https://github.com/jjyr/zerotest/issues/12\n     \"\"\"\n \n-    upload_manifest(baseurl, s, \"../e-1/arapahoe-manifest.csv\",\n-                \"42d409d3394243046cf92e3ce569b7078cba0815d626602d15d0da3e5e844a94\")\n+    # TODO: predefine more manifests\n+    manifestfile = \"../e-1/arapahoe-manifest.csv\"\n+    hash = \"42d409d3394243046cf92e3ce569b7078cba0815d626602d15d0da3e5e844a94\"\n \n-    v = 1\n-    if v == 1:\n-        upload_cvrs(baseurl, s, \"../e-1/arapahoe-regent-3-clear-CVR_Export.csv\",\n-                    \"413befb5bc3e577e637bd789a92da425d0309310c51cfe796e57c01a1987f4bf\")\n-    if v == 2:\n-        upload_cvrs(baseurl, s, \"../dominion-2017-CVR_Export_20170310104116.csv\",\n-                    \"4e3844b0dabfcea64a499d65bc1cdc00d139cd5cdcaf502f20dd2beaa3d518d2\")\n+    manifest = ac.args.manifest # TODO finish when we have more manifests and they make a difference\n \n-    if v == 3:\n-        upload_cvrs(baseurl, s, \"../Denver2016Test/CVR_Export_20170804111144.csv\",\n-                    \"1def4aa4c0e1421b4e5adcd4cc18a8d275f709bc07820a37e76e11a038195d02\")\n+    if ac.args.ye_olde_upload:","path":"test/smoketest/main.py","position":316,"original_position":316,"commit_id":"43f580c94e5dfa955dda6caa5d6b3e4444874023","original_commit_id":"43f580c94e5dfa955dda6caa5d6b3e4444874023","user":{"login":"dmzimmerman","id":75249,"avatar_url":"https://avatars1.githubusercontent.com/u/75249?v=4","gravatar_id":"","url":"https://api.github.com/users/dmzimmerman","html_url":"https://github.com/dmzimmerman","followers_url":"https://api.github.com/users/dmzimmerman/followers","following_url":"https://api.github.com/users/dmzimmerman/following{/other_user}","gists_url":"https://api.github.com/users/dmzimmerman/gists{/gist_id}","starred_url":"https://api.github.com/users/dmzimmerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmzimmerman/subscriptions","organizations_url":"https://api.github.com/users/dmzimmerman/orgs","repos_url":"https://api.github.com/users/dmzimmerman/repos","events_url":"https://api.github.com/users/dmzimmerman/events{/privacy}","received_events_url":"https://api.github.com/users/dmzimmerman/received_events","type":"User","site_admin":false},"body":"I would remove this argument and logic. The old upload endpoints will go away soon, and there isn't much point in doing further testing on them; moreover, if somebody for some reason wants to test an old version, they can use the smoketest script that's current at that version in the repo.","created_at":"2017-08-26T23:58:11Z","updated_at":"2017-08-26T23:58:55Z","html_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/413#discussion_r135400019","pull_request_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments/135400019"},"html":{"href":"https://github.com/FreeAndFair/ColoradoRLA/pull/413#discussion_r135400019"},"pull_request":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413","id":137330746,"html_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/413","diff_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/413.diff","patch_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/413.patch","issue_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/413","number":413,"state":"open","locked":false,"title":"New main.py with command-line arguments.","user":{"login":"nealmcb","id":119472,"avatar_url":"https://avatars2.githubusercontent.com/u/119472?v=4","gravatar_id":"","url":"https://api.github.com/users/nealmcb","html_url":"https://github.com/nealmcb","followers_url":"https://api.github.com/users/nealmcb/followers","following_url":"https://api.github.com/users/nealmcb/following{/other_user}","gists_url":"https://api.github.com/users/nealmcb/gists{/gist_id}","starred_url":"https://api.github.com/users/nealmcb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealmcb/subscriptions","organizations_url":"https://api.github.com/users/nealmcb/orgs","repos_url":"https://api.github.com/users/nealmcb/repos","events_url":"https://api.github.com/users/nealmcb/events{/privacy}","received_events_url":"https://api.github.com/users/nealmcb/received_events","type":"User","site_admin":false},"body":"Worth merging I think, whenever you want it.\r\n\r\n~Currently requires a county option, like \"./main.py -c 3\" for Arapahoe.~\r\n\r\n~Not quite working yet: never sees any ballots to audit for some reason.~","created_at":"2017-08-23T22:17:57Z","updated_at":"2017-08-26T23:58:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c891fe0d61c311e6da8be8ad5269c87703fc6c02","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kiniry","id":478911,"avatar_url":"https://avatars3.githubusercontent.com/u/478911?v=4","gravatar_id":"","url":"https://api.github.com/users/kiniry","html_url":"https://github.com/kiniry","followers_url":"https://api.github.com/users/kiniry/followers","following_url":"https://api.github.com/users/kiniry/following{/other_user}","gists_url":"https://api.github.com/users/kiniry/gists{/gist_id}","starred_url":"https://api.github.com/users/kiniry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiniry/subscriptions","organizations_url":"https://api.github.com/users/kiniry/orgs","repos_url":"https://api.github.com/users/kiniry/repos","events_url":"https://api.github.com/users/kiniry/events{/privacy}","received_events_url":"https://api.github.com/users/kiniry/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones/3","html_url":"https://github.com/FreeAndFair/ColoradoRLA/milestone/3","labels_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones/3/labels","id":2648568,"number":3,"title":"phase-3","description":"3rd iteration of CORLA system, after round 2 of user acceptance testing.","creator":{"login":"ranweiler","id":515835,"avatar_url":"https://avatars1.githubusercontent.com/u/515835?v=4","gravatar_id":"","url":"https://api.github.com/users/ranweiler","html_url":"https://github.com/ranweiler","followers_url":"https://api.github.com/users/ranweiler/followers","following_url":"https://api.github.com/users/ranweiler/following{/other_user}","gists_url":"https://api.github.com/users/ranweiler/gists{/gist_id}","starred_url":"https://api.github.com/users/ranweiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranweiler/subscriptions","organizations_url":"https://api.github.com/users/ranweiler/orgs","repos_url":"https://api.github.com/users/ranweiler/repos","events_url":"https://api.github.com/users/ranweiler/events{/privacy}","received_events_url":"https://api.github.com/users/ranweiler/received_events","type":"User","site_admin":false},"open_issues":76,"closed_issues":14,"state":"open","created_at":"2017-07-18T21:27:06Z","updated_at":"2017-08-26T22:41:53Z","due_on":"2017-09-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413/commits","review_comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413/comments","review_comment_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/413/comments","statuses_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/43f580c94e5dfa955dda6caa5d6b3e4444874023","head":{"label":"FreeAndFair:test","ref":"test","sha":"43f580c94e5dfa955dda6caa5d6b3e4444874023","user":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"repo":{"id":95474825,"name":"ColoradoRLA","full_name":"FreeAndFair/ColoradoRLA","owner":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeAndFair/ColoradoRLA","description":"Software to facilitate risk-limiting audits at the state level, developed for the state of Colorado.","fork":false,"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA","forks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/forks","keys_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/teams","hooks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/hooks","issue_events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/events{/number}","events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/events","assignees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/assignees{/user}","branches_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/branches{/branch}","tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/tags","blobs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/languages","stargazers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/stargazers","contributors_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contributors","subscribers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscribers","subscription_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscription","commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contents/{+path}","compare_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/merges","archive_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/downloads","issues_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues{/number}","pulls_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/labels{/name}","releases_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/releases{/id}","deployments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/deployments","created_at":"2017-06-26T18:05:40Z","updated_at":"2017-08-20T18:55:42Z","pushed_at":"2017-08-26T23:32:21Z","git_url":"git://github.com/FreeAndFair/ColoradoRLA.git","ssh_url":"git@github.com:FreeAndFair/ColoradoRLA.git","clone_url":"https://github.com/FreeAndFair/ColoradoRLA.git","svn_url":"https://github.com/FreeAndFair/ColoradoRLA","homepage":null,"size":46067,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":99,"forks":2,"open_issues":99,"watchers":7,"default_branch":"master"}},"base":{"label":"FreeAndFair:master","ref":"master","sha":"045c4b85f49683f96104dc4b858e340416ffbf53","user":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"repo":{"id":95474825,"name":"ColoradoRLA","full_name":"FreeAndFair/ColoradoRLA","owner":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeAndFair/ColoradoRLA","description":"Software to facilitate risk-limiting audits at the state level, developed for the state of Colorado.","fork":false,"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA","forks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/forks","keys_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/teams","hooks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/hooks","issue_events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/events{/number}","events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/events","assignees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/assignees{/user}","branches_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/branches{/branch}","tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/tags","blobs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/languages","stargazers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/stargazers","contributors_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contributors","subscribers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscribers","subscription_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscription","commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contents/{+path}","compare_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/merges","archive_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/downloads","issues_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues{/number}","pulls_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/labels{/name}","releases_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/releases{/id}","deployments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/deployments","created_at":"2017-06-26T18:05:40Z","updated_at":"2017-08-20T18:55:42Z","pushed_at":"2017-08-26T23:32:21Z","git_url":"git://github.com/FreeAndFair/ColoradoRLA.git","ssh_url":"git@github.com:FreeAndFair/ColoradoRLA.git","clone_url":"https://github.com/FreeAndFair/ColoradoRLA.git","svn_url":"https://github.com/FreeAndFair/ColoradoRLA","homepage":null,"size":46067,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":99,"forks":2,"open_issues":99,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413"},"html":{"href":"https://github.com/FreeAndFair/ColoradoRLA/pull/413"},"issue":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/413"},"comments":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/43f580c94e5dfa955dda6caa5d6b3e4444874023"}}}}
{"actor":{"display_login":"dmzimmerman"}}