{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/app-manifest/pulls/comments/127796539","pull_request_review_id":50416701,"id":127796539,"diff_hunk":"@@ -0,0 +1,17 @@\n+require 'test_helper'\n+\n+module AppManifest\n+  class AddonTest < MiniTest::Test\n+    def test_attributes","path":"test/app_manifest/addon_test.rb","position":5,"original_position":5,"commit_id":"f3584190bab1557f27cc05da244bc02d30d49bd7","original_commit_id":"1254e772f6d225472819f7de26e399c5518a630c","user":{"login":"joshwlewis","id":917672,"avatar_url":"https://avatars1.githubusercontent.com/u/917672?v=4","gravatar_id":"","url":"https://api.github.com/users/joshwlewis","html_url":"https://github.com/joshwlewis","followers_url":"https://api.github.com/users/joshwlewis/followers","following_url":"https://api.github.com/users/joshwlewis/following{/other_user}","gists_url":"https://api.github.com/users/joshwlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwlewis/subscriptions","organizations_url":"https://api.github.com/users/joshwlewis/orgs","repos_url":"https://api.github.com/users/joshwlewis/repos","events_url":"https://api.github.com/users/joshwlewis/events{/privacy}","received_events_url":"https://api.github.com/users/joshwlewis/received_events","type":"User","site_admin":false},"body":"Yeah, that's a good point. I feel like we should test something, though.","created_at":"2017-07-17T19:06:56Z","updated_at":"2017-07-17T19:06:56Z","html_url":"https://github.com/heroku/app-manifest/pull/7#discussion_r127796539","pull_request_url":"https://api.github.com/repos/heroku/app-manifest/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/heroku/app-manifest/pulls/comments/127796539"},"html":{"href":"https://github.com/heroku/app-manifest/pull/7#discussion_r127796539"},"pull_request":{"href":"https://api.github.com/repos/heroku/app-manifest/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/app-manifest/pulls/7","id":130324886,"html_url":"https://github.com/heroku/app-manifest/pull/7","diff_url":"https://github.com/heroku/app-manifest/pull/7.diff","patch_url":"https://github.com/heroku/app-manifest/pull/7.patch","issue_url":"https://api.github.com/repos/heroku/app-manifest/issues/7","number":7,"state":"open","locked":false,"title":"Add models for nested data","user":{"login":"appleton","id":241576,"avatar_url":"https://avatars3.githubusercontent.com/u/241576?v=4","gravatar_id":"","url":"https://api.github.com/users/appleton","html_url":"https://github.com/appleton","followers_url":"https://api.github.com/users/appleton/followers","following_url":"https://api.github.com/users/appleton/following{/other_user}","gists_url":"https://api.github.com/users/appleton/gists{/gist_id}","starred_url":"https://api.github.com/users/appleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleton/subscriptions","organizations_url":"https://api.github.com/users/appleton/orgs","repos_url":"https://api.github.com/users/appleton/repos","events_url":"https://api.github.com/users/appleton/events{/privacy}","received_events_url":"https://api.github.com/users/appleton/received_events","type":"User","site_admin":false},"body":"This PR adds formal modeling and serialization to the manifest and it's nested data. It gives consumers additional APIs to read, modify, and re-serialize app.json content.\r\n\r\nAdditionally, it tidies up a few rough edges:\r\n\r\n- Previously, `Manifest#environment(:test)` would return a model with additional \"environments\" hanging around. This is not supported by the app.json schema and was a bit misleading. Now, `Manifest#environment(:test)` returns an `Environment` instance, which does not have nested `environments`.\r\n- Accepting any \"environments\" or \"formation\" keys and converting them to symbols was a little troublesome, since user specified keys might be reasonably symbolizable. Additionally, this had the potential to leak memory in older Rubies. Now, user specified environment and formation keys are strings, similar to the serialization of \"env\" keys.\r\n","created_at":"2017-07-13T09:27:58Z","updated_at":"2017-07-17T19:06:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fca664e13f319ff85cc107e2df70ea06c45ec26","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/heroku/app-manifest/pulls/7/commits","review_comments_url":"https://api.github.com/repos/heroku/app-manifest/pulls/7/comments","review_comment_url":"https://api.github.com/repos/heroku/app-manifest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/app-manifest/issues/7/comments","statuses_url":"https://api.github.com/repos/heroku/app-manifest/statuses/f3584190bab1557f27cc05da244bc02d30d49bd7","head":{"label":"heroku:modeling","ref":"modeling","sha":"f3584190bab1557f27cc05da244bc02d30d49bd7","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":82976307,"name":"app-manifest","full_name":"heroku/app-manifest","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/app-manifest","description":"A Ruby library for parsing app.json manifests","fork":false,"url":"https://api.github.com/repos/heroku/app-manifest","forks_url":"https://api.github.com/repos/heroku/app-manifest/forks","keys_url":"https://api.github.com/repos/heroku/app-manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/app-manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/app-manifest/teams","hooks_url":"https://api.github.com/repos/heroku/app-manifest/hooks","issue_events_url":"https://api.github.com/repos/heroku/app-manifest/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/app-manifest/events","assignees_url":"https://api.github.com/repos/heroku/app-manifest/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/app-manifest/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/app-manifest/tags","blobs_url":"https://api.github.com/repos/heroku/app-manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/app-manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/app-manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/app-manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/app-manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/app-manifest/languages","stargazers_url":"https://api.github.com/repos/heroku/app-manifest/stargazers","contributors_url":"https://api.github.com/repos/heroku/app-manifest/contributors","subscribers_url":"https://api.github.com/repos/heroku/app-manifest/subscribers","subscription_url":"https://api.github.com/repos/heroku/app-manifest/subscription","commits_url":"https://api.github.com/repos/heroku/app-manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/app-manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/app-manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/app-manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/app-manifest/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/app-manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/app-manifest/merges","archive_url":"https://api.github.com/repos/heroku/app-manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/app-manifest/downloads","issues_url":"https://api.github.com/repos/heroku/app-manifest/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/app-manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/app-manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/app-manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/app-manifest/labels{/name}","releases_url":"https://api.github.com/repos/heroku/app-manifest/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/app-manifest/deployments","created_at":"2017-02-23T22:08:22Z","updated_at":"2017-02-28T19:33:13Z","pushed_at":"2017-07-17T19:03:41Z","git_url":"git://github.com/heroku/app-manifest.git","ssh_url":"git@github.com:heroku/app-manifest.git","clone_url":"https://github.com/heroku/app-manifest.git","svn_url":"https://github.com/heroku/app-manifest","homepage":null,"size":81,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"47013b95b97424a92c223b531e19f3d8e150fc79","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":82976307,"name":"app-manifest","full_name":"heroku/app-manifest","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars3.githubusercontent.com/u/23211?v=4","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/app-manifest","description":"A Ruby library for parsing app.json manifests","fork":false,"url":"https://api.github.com/repos/heroku/app-manifest","forks_url":"https://api.github.com/repos/heroku/app-manifest/forks","keys_url":"https://api.github.com/repos/heroku/app-manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/app-manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/app-manifest/teams","hooks_url":"https://api.github.com/repos/heroku/app-manifest/hooks","issue_events_url":"https://api.github.com/repos/heroku/app-manifest/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/app-manifest/events","assignees_url":"https://api.github.com/repos/heroku/app-manifest/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/app-manifest/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/app-manifest/tags","blobs_url":"https://api.github.com/repos/heroku/app-manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/app-manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/app-manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/app-manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/app-manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/app-manifest/languages","stargazers_url":"https://api.github.com/repos/heroku/app-manifest/stargazers","contributors_url":"https://api.github.com/repos/heroku/app-manifest/contributors","subscribers_url":"https://api.github.com/repos/heroku/app-manifest/subscribers","subscription_url":"https://api.github.com/repos/heroku/app-manifest/subscription","commits_url":"https://api.github.com/repos/heroku/app-manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/app-manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/app-manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/app-manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/app-manifest/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/app-manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/app-manifest/merges","archive_url":"https://api.github.com/repos/heroku/app-manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/app-manifest/downloads","issues_url":"https://api.github.com/repos/heroku/app-manifest/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/app-manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/app-manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/app-manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/app-manifest/labels{/name}","releases_url":"https://api.github.com/repos/heroku/app-manifest/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/app-manifest/deployments","created_at":"2017-02-23T22:08:22Z","updated_at":"2017-02-28T19:33:13Z","pushed_at":"2017-07-17T19:03:41Z","git_url":"git://github.com/heroku/app-manifest.git","ssh_url":"git@github.com:heroku/app-manifest.git","clone_url":"https://github.com/heroku/app-manifest.git","svn_url":"https://github.com/heroku/app-manifest","homepage":null,"size":81,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/app-manifest/pulls/7"},"html":{"href":"https://github.com/heroku/app-manifest/pull/7"},"issue":{"href":"https://api.github.com/repos/heroku/app-manifest/issues/7"},"comments":{"href":"https://api.github.com/repos/heroku/app-manifest/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/app-manifest/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/app-manifest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/app-manifest/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/app-manifest/statuses/f3584190bab1557f27cc05da244bc02d30d49bd7"}}}}
{"actor":{"display_login":"joshwlewis"}}