{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50838","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50838/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50838/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50838/events","html_url":"https://github.com/kubernetes/kubernetes/pull/50838","id":250887867,"number":50838,"title":"Reject unknown container resource names in the default `*kubernetes.io/` namespace.","user":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars3.githubusercontent.com/u/379372?v=4","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":125550211,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars2.githubusercontent.com/u/8264113?v=4","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidopp","id":8264113,"avatar_url":"https://avatars2.githubusercontent.com/u/8264113?v=4","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-08-17T09:48:55Z","updated_at":"2017-08-17T20:09:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50838","html_url":"https://github.com/kubernetes/kubernetes/pull/50838","diff_url":"https://github.com/kubernetes/kubernetes/pull/50838.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50838.patch"},"body":"- Requires resource names in container requests and limits to be known to the system if in the *kubernetes.io/ namespace, or no namespace is specified.\r\n- Fixes #50658.\r\n\r\n**Example**:\r\n\r\n_Contents of `fc1.yaml`_\r\n\r\n```yaml\r\napiVersion: v1\r\nkind: Pod\r\nmetadata:\r\n  name: fc1\r\nspec:\r\n  containers:\r\n    - image: nginx\r\n      name: fc1\r\n      resources:\r\n        requests:\r\n          kubernetes.io/foo: 1\r\n          cpu: \"100m\"\r\n          memory: \"128M\"\r\n```\r\n\r\n```\r\n$ kubectl create -f fc1.yaml\r\nThe Pod \"fc1\" is invalid: spec.containers[0].resources.requests[kubernetes.io/foo]:\r\nInvalid value: \"kubernetes.io/foo\": must be a standard resource for containers or\r\nfully qualified\r\n```\r\n\r\n**Release note**:\r\n```release-note\r\nReject unknown container resource names in the default `*kubernetes.io/` namespace.\r\n```\r\n\r\n@kubernetes/sig-scheduling-api-reviews \r\n@kubernetes/api-reviewers \r\n\r\ncc @vishh @davidopp @xiangpengzhao @balajismaniam "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/323180411","html_url":"https://github.com/kubernetes/kubernetes/pull/50838#issuecomment-323180411","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50838","id":323180411,"user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars2.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"created_at":"2017-08-17T20:09:32Z","updated_at":"2017-08-17T20:09:32Z","body":"The issues mentioned thus far would make this change risky irrespective of\nwhen it's made right? I think the main question we need an answer for is\nwhether it's ok to enforce ownership of kubernetes.io domain for compute\nresource types.\n\nOn Thu, Aug 17, 2017 at 1:00 PM, Connor Doyle <notifications@github.com>\nwrote:\n\n> Based on the feedback so far, and the risk/benefit ratio do we shelve this\n> until after v1.8 is tagged?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kubernetes/kubernetes/pull/50838#issuecomment-323178079>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AGvIKNyQOSpb6dSu1kltyEjn6ha6YAZtks5sZJvzgaJpZM4O6BtU>\n> .\n>\n"}}
{"actor":{"display_login":"vishh"}}