{"action":"opened","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2817","repository_url":"https://api.github.com/repos/magnumripper/JohnTheRipper","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2817/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2817/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2817/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/2817","id":266323462,"number":2817,"title":"Salt resume problem (potentially severe bug)","user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars3.githubusercontent.com/u/1268598?v=4","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"labels":[{"id":51606860,"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/bug","name":"bug","color":"e11d21","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2","html_url":"https://github.com/magnumripper/JohnTheRipper/milestone/2","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2/labels","id":492145,"number":2,"title":"1.8.0-jumbo-2","description":"Please assign ALL issues which should be in J2 to this milestone, and lets push forward in fixing all of them.","creator":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars3.githubusercontent.com/u/1268598?v=4","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":304,"state":"open","created_at":"2013-11-21T06:59:25Z","updated_at":"2017-10-18T00:35:32Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-10-18T00:35:32Z","updated_at":"2017-10-18T00:35:32Z","closed_at":null,"author_association":"OWNER","body":"Since Jim added \"salt resume\" (which is basically an excellent thing but was never systematically tested), I believe we have the following problem:\r\n\r\nSay we run some OpenCL format that happened to auto-tune to 2K keys per crypt and we have 500 salts loaded. After eg. 200 salts, we abort the job.\r\n\r\nWhen resuming, the same format could just as well auto-tune to 4K keys per crypt (due to random variations). The salt-resume code will happily skip the first 200 salts that were \"already processed\" - but the problem is **they all miss 2K candidates** which will never be tested. Possible false negatives...\r\n\r\nThe same thing would happen at smaller scale if eg. running AVX and resuming on AVX2.\r\n\r\nWhat to do about this? Not sure. Perhaps we could store the active \"keys per crypt\" in the rec file, and check when resuming that it didn't increase. If it did, we can skip the salt-resuming and just start over from salt 0. As an attempt to avoid that, we might be able to instead ensure the very first batch runs with that same kpc."}}
{"actor":{"display_login":"magnumripper"}}