{"action":"closed","number":74,"pull_request":{"url":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/74","id":151683158,"html_url":"https://github.com/pusher/pusher-platform-js/pull/74","diff_url":"https://github.com/pusher/pusher-platform-js/pull/74.diff","patch_url":"https://github.com/pusher/pusher-platform-js/pull/74.patch","issue_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues/74","number":74,"state":"closed","locked":false,"title":"React native support","user":{"login":"hamchapman","id":2475150,"avatar_url":"https://avatars2.githubusercontent.com/u/2475150?v=4","gravatar_id":"","url":"https://api.github.com/users/hamchapman","html_url":"https://github.com/hamchapman","followers_url":"https://api.github.com/users/hamchapman/followers","following_url":"https://api.github.com/users/hamchapman/following{/other_user}","gists_url":"https://api.github.com/users/hamchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/hamchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamchapman/subscriptions","organizations_url":"https://api.github.com/users/hamchapman/orgs","repos_url":"https://api.github.com/users/hamchapman/repos","events_url":"https://api.github.com/users/hamchapman/events{/privacy}","received_events_url":"https://api.github.com/users/hamchapman/received_events","type":"User","site_admin":false},"body":"### What?\r\n\r\nAdd react native support\r\n\r\n### Why?\r\n\r\nChatkit wants it and so the platform SDK needs to be updated first\r\n\r\n### How?\r\n\r\nWebpack and a few other changes.\r\n\r\n### Notes\r\n\r\nThings worth looking at in particular: \r\n\r\n- `tsconfig.json`: https://github.com/pusher/pusher-platform-js/pull/74/files#diff-e5e546dd2eb0351f813d63d1b39dbc48\r\n- all of the new `webpack.*.js` files\r\n- declarations: do we need them, especially do we need them in the repo?\r\n\r\nAlso removed `dts-bundle` because it caused some errors. Do we need to generate a single declarations file for other typescript users?\r\n\r\nIntegration tests don't work because I need to update the [`platform-sdk-tester`](https://github.com/pusher/platform-sdk-tester) (PR has been made)\r\n\r\n----\r\n\r\nCC @pusher/sigsdk","created_at":"2017-11-09T15:33:06Z","updated_at":"2017-11-15T10:43:33Z","closed_at":"2017-11-15T10:43:33Z","merged_at":"2017-11-15T10:43:33Z","merge_commit_sha":"50945502dae2783545dad415c881c9992dec5fa8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/74/commits","review_comments_url":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/74/comments","review_comment_url":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues/74/comments","statuses_url":"https://api.github.com/repos/pusher/pusher-platform-js/statuses/7b6d3c7b57b5cacecf2a867cabb94bc193cbcc94","head":{"label":"pusher:react-native-support","ref":"react-native-support","sha":"7b6d3c7b57b5cacecf2a867cabb94bc193cbcc94","user":{"login":"pusher","id":739550,"avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"repo":{"id":79353741,"name":"pusher-platform-js","full_name":"pusher/pusher-platform-js","owner":{"login":"pusher","id":739550,"avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pusher/pusher-platform-js","description":"Pusher Platform client library for web browsers","fork":false,"url":"https://api.github.com/repos/pusher/pusher-platform-js","forks_url":"https://api.github.com/repos/pusher/pusher-platform-js/forks","keys_url":"https://api.github.com/repos/pusher/pusher-platform-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pusher/pusher-platform-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pusher/pusher-platform-js/teams","hooks_url":"https://api.github.com/repos/pusher/pusher-platform-js/hooks","issue_events_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues/events{/number}","events_url":"https://api.github.com/repos/pusher/pusher-platform-js/events","assignees_url":"https://api.github.com/repos/pusher/pusher-platform-js/assignees{/user}","branches_url":"https://api.github.com/repos/pusher/pusher-platform-js/branches{/branch}","tags_url":"https://api.github.com/repos/pusher/pusher-platform-js/tags","blobs_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pusher/pusher-platform-js/statuses/{sha}","languages_url":"https://api.github.com/repos/pusher/pusher-platform-js/languages","stargazers_url":"https://api.github.com/repos/pusher/pusher-platform-js/stargazers","contributors_url":"https://api.github.com/repos/pusher/pusher-platform-js/contributors","subscribers_url":"https://api.github.com/repos/pusher/pusher-platform-js/subscribers","subscription_url":"https://api.github.com/repos/pusher/pusher-platform-js/subscription","commits_url":"https://api.github.com/repos/pusher/pusher-platform-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pusher/pusher-platform-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/pusher/pusher-platform-js/contents/{+path}","compare_url":"https://api.github.com/repos/pusher/pusher-platform-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pusher/pusher-platform-js/merges","archive_url":"https://api.github.com/repos/pusher/pusher-platform-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pusher/pusher-platform-js/downloads","issues_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues{/number}","pulls_url":"https://api.github.com/repos/pusher/pusher-platform-js/pulls{/number}","milestones_url":"https://api.github.com/repos/pusher/pusher-platform-js/milestones{/number}","notifications_url":"https://api.github.com/repos/pusher/pusher-platform-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pusher/pusher-platform-js/labels{/name}","releases_url":"https://api.github.com/repos/pusher/pusher-platform-js/releases{/id}","deployments_url":"https://api.github.com/repos/pusher/pusher-platform-js/deployments","created_at":"2017-01-18T15:30:16Z","updated_at":"2017-07-31T13:14:23Z","pushed_at":"2017-11-15T10:43:33Z","git_url":"git://github.com/pusher/pusher-platform-js.git","ssh_url":"git@github.com:pusher/pusher-platform-js.git","clone_url":"https://github.com/pusher/pusher-platform-js.git","svn_url":"https://github.com/pusher/pusher-platform-js","homepage":null,"size":679,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"pusher:master","ref":"master","sha":"e3f5edf10167b4c1b91fb6733b2f35bbb664939e","user":{"login":"pusher","id":739550,"avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"repo":{"id":79353741,"name":"pusher-platform-js","full_name":"pusher/pusher-platform-js","owner":{"login":"pusher","id":739550,"avatar_url":"https://avatars0.githubusercontent.com/u/739550?v=4","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pusher/pusher-platform-js","description":"Pusher Platform client library for web browsers","fork":false,"url":"https://api.github.com/repos/pusher/pusher-platform-js","forks_url":"https://api.github.com/repos/pusher/pusher-platform-js/forks","keys_url":"https://api.github.com/repos/pusher/pusher-platform-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pusher/pusher-platform-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pusher/pusher-platform-js/teams","hooks_url":"https://api.github.com/repos/pusher/pusher-platform-js/hooks","issue_events_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues/events{/number}","events_url":"https://api.github.com/repos/pusher/pusher-platform-js/events","assignees_url":"https://api.github.com/repos/pusher/pusher-platform-js/assignees{/user}","branches_url":"https://api.github.com/repos/pusher/pusher-platform-js/branches{/branch}","tags_url":"https://api.github.com/repos/pusher/pusher-platform-js/tags","blobs_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pusher/pusher-platform-js/statuses/{sha}","languages_url":"https://api.github.com/repos/pusher/pusher-platform-js/languages","stargazers_url":"https://api.github.com/repos/pusher/pusher-platform-js/stargazers","contributors_url":"https://api.github.com/repos/pusher/pusher-platform-js/contributors","subscribers_url":"https://api.github.com/repos/pusher/pusher-platform-js/subscribers","subscription_url":"https://api.github.com/repos/pusher/pusher-platform-js/subscription","commits_url":"https://api.github.com/repos/pusher/pusher-platform-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pusher/pusher-platform-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pusher/pusher-platform-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/pusher/pusher-platform-js/contents/{+path}","compare_url":"https://api.github.com/repos/pusher/pusher-platform-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pusher/pusher-platform-js/merges","archive_url":"https://api.github.com/repos/pusher/pusher-platform-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pusher/pusher-platform-js/downloads","issues_url":"https://api.github.com/repos/pusher/pusher-platform-js/issues{/number}","pulls_url":"https://api.github.com/repos/pusher/pusher-platform-js/pulls{/number}","milestones_url":"https://api.github.com/repos/pusher/pusher-platform-js/milestones{/number}","notifications_url":"https://api.github.com/repos/pusher/pusher-platform-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pusher/pusher-platform-js/labels{/name}","releases_url":"https://api.github.com/repos/pusher/pusher-platform-js/releases{/id}","deployments_url":"https://api.github.com/repos/pusher/pusher-platform-js/deployments","created_at":"2017-01-18T15:30:16Z","updated_at":"2017-07-31T13:14:23Z","pushed_at":"2017-11-15T10:43:33Z","git_url":"git://github.com/pusher/pusher-platform-js.git","ssh_url":"git@github.com:pusher/pusher-platform-js.git","clone_url":"https://github.com/pusher/pusher-platform-js.git","svn_url":"https://github.com/pusher/pusher-platform-js","homepage":null,"size":679,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/74"},"html":{"href":"https://github.com/pusher/pusher-platform-js/pull/74"},"issue":{"href":"https://api.github.com/repos/pusher/pusher-platform-js/issues/74"},"comments":{"href":"https://api.github.com/repos/pusher/pusher-platform-js/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pusher/pusher-platform-js/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/pusher/pusher-platform-js/statuses/7b6d3c7b57b5cacecf2a867cabb94bc193cbcc94"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hamchapman","id":2475150,"avatar_url":"https://avatars2.githubusercontent.com/u/2475150?v=4","gravatar_id":"","url":"https://api.github.com/users/hamchapman","html_url":"https://github.com/hamchapman","followers_url":"https://api.github.com/users/hamchapman/followers","following_url":"https://api.github.com/users/hamchapman/following{/other_user}","gists_url":"https://api.github.com/users/hamchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/hamchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamchapman/subscriptions","organizations_url":"https://api.github.com/users/hamchapman/orgs","repos_url":"https://api.github.com/users/hamchapman/repos","events_url":"https://api.github.com/users/hamchapman/events{/privacy}","received_events_url":"https://api.github.com/users/hamchapman/received_events","type":"User","site_admin":false},"comments":2,"review_comments":10,"maintainer_can_modify":false,"commits":2,"additions":4471,"deletions":203,"changed_files":54}}
{"actor":{"display_login":"hamchapman"}}