{"action":"opened","issue":{"url":"https://api.github.com/repos/2ndQuadrant/pglogical/issues/124","repository_url":"https://api.github.com/repos/2ndQuadrant/pglogical","labels_url":"https://api.github.com/repos/2ndQuadrant/pglogical/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/2ndQuadrant/pglogical/issues/124/comments","events_url":"https://api.github.com/repos/2ndQuadrant/pglogical/issues/124/events","html_url":"https://github.com/2ndQuadrant/pglogical/issues/124","id":259622937,"number":124,"title":"Fails to build against latest v10","user":{"login":"mbanck","id":1670301,"avatar_url":"https://avatars0.githubusercontent.com/u/1670301?v=4","gravatar_id":"","url":"https://api.github.com/users/mbanck","html_url":"https://github.com/mbanck","followers_url":"https://api.github.com/users/mbanck/followers","following_url":"https://api.github.com/users/mbanck/following{/other_user}","gists_url":"https://api.github.com/users/mbanck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbanck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbanck/subscriptions","organizations_url":"https://api.github.com/users/mbanck/orgs","repos_url":"https://api.github.com/users/mbanck/repos","events_url":"https://api.github.com/users/mbanck/events{/privacy}","received_events_url":"https://api.github.com/users/mbanck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-21T20:31:22Z","updated_at":"2017-09-21T20:31:22Z","closed_at":null,"author_association":"NONE","body":"If I try to build 2.0.1 (but master seems to be unchanged in this regard) against v10 RC1 I get:\r\n\r\n```\r\ngcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -g -O2 -fdebug-prefix-map=/build/postgresql-10-ccxnXW/postgresql-10-10~rc1=. -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -fPIC -fPIC -I/usr/include/postgresql -I/<<PKGBUILDDIR>>/compat10 -I. -I/<<PKGBUILDDIR>> -I/usr/include/postgresql/10/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5  -c -o pglogical_functions.o /<<PKGBUILDDIR>>/pglogical_functions.c\r\n/<<PKGBUILDDIR>>/pglogical_functions.c: In function 'pglogical_drop_subscription':\r\n/<<PKGBUILDDIR>>/pglogical_functions.c:604:4: error: too few arguments to function 'replorigin_drop'\r\n    replorigin_drop(originid);\r\n    ^~~~~~~~~~~~~~~\r\nIn file included from /<<PKGBUILDDIR>>/pglogical_functions.c:49:0:\r\n/usr/include/postgresql/10/server/replication/origin.h:44:13: note: declared here\r\n extern void replorigin_drop(RepOriginId roident, bool nowait);\r\n             ^~~~~~~~~~~~~~~\r\n<builtin>: recipe for target 'pglogical_functions.o' failed\r\nmake[2]: *** [pglogical_functions.o] Error 1\r\n```\r\n\r\nIndeed, in `b2c95a37`, this got changed:\r\n\r\n```\r\n-extern void replorigin_drop(RepOriginId roident);\r\n+extern void replorigin_drop(RepOriginId roident, bool nowait);\r\n```"}}
{"actor":{"display_login":"mbanck"}}