{"action":"created","comment":{"url":"https://api.github.com/repos/smolamarcin/battleship/pulls/comments/155715119","pull_request_review_id":82079838,"id":155715119,"diff_hunk":"@@ -6,16 +6,25 @@\n import java.net.Socket;\n \n class ShipSocketServer implements ShipServer {\n-    private final int portNumber = 8080;\n+\n+    private final String ip;\n+\n+    ShipSocketServer(String ip) {\n+        this.ip = ip;\n+    }\n \n     @Override\n     public void run() {\n-        try (ServerSocket serverSocket = new ServerSocket(portNumber, 0, InetAddress.getLoopbackAddress())) {\n+        int portNumber = 8080;","path":"battleship-server/src/main/java/com.epam.solid.nie/server/ShipSocketServer.java","position":15,"original_position":15,"commit_id":"3e657448df806244359417a0847f47c8cec6360c","original_commit_id":"3e657448df806244359417a0847f47c8cec6360c","user":{"login":"rivalez","id":11312356,"avatar_url":"https://avatars0.githubusercontent.com/u/11312356?v=4","gravatar_id":"","url":"https://api.github.com/users/rivalez","html_url":"https://github.com/rivalez","followers_url":"https://api.github.com/users/rivalez/followers","following_url":"https://api.github.com/users/rivalez/following{/other_user}","gists_url":"https://api.github.com/users/rivalez/gists{/gist_id}","starred_url":"https://api.github.com/users/rivalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivalez/subscriptions","organizations_url":"https://api.github.com/users/rivalez/orgs","repos_url":"https://api.github.com/users/rivalez/repos","events_url":"https://api.github.com/users/rivalez/events{/privacy}","received_events_url":"https://api.github.com/users/rivalez/received_events","type":"User","site_admin":false},"body":"private final int variable was good idea","created_at":"2017-12-08T07:10:43Z","updated_at":"2017-12-08T07:10:43Z","html_url":"https://github.com/smolamarcin/battleship/pull/63#discussion_r155715119","pull_request_url":"https://api.github.com/repos/smolamarcin/battleship/pulls/63","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/smolamarcin/battleship/pulls/comments/155715119"},"html":{"href":"https://github.com/smolamarcin/battleship/pull/63#discussion_r155715119"},"pull_request":{"href":"https://api.github.com/repos/smolamarcin/battleship/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/smolamarcin/battleship/pulls/63","id":157044105,"html_url":"https://github.com/smolamarcin/battleship/pull/63","diff_url":"https://github.com/smolamarcin/battleship/pull/63.diff","patch_url":"https://github.com/smolamarcin/battleship/pull/63.patch","issue_url":"https://api.github.com/repos/smolamarcin/battleship/issues/63","number":63,"state":"open","locked":false,"title":"62 make game machin independent","user":{"login":"Ozymadias","id":16693061,"avatar_url":"https://avatars2.githubusercontent.com/u/16693061?v=4","gravatar_id":"","url":"https://api.github.com/users/Ozymadias","html_url":"https://github.com/Ozymadias","followers_url":"https://api.github.com/users/Ozymadias/followers","following_url":"https://api.github.com/users/Ozymadias/following{/other_user}","gists_url":"https://api.github.com/users/Ozymadias/gists{/gist_id}","starred_url":"https://api.github.com/users/Ozymadias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ozymadias/subscriptions","organizations_url":"https://api.github.com/users/Ozymadias/orgs","repos_url":"https://api.github.com/users/Ozymadias/repos","events_url":"https://api.github.com/users/Ozymadias/events{/privacy}","received_events_url":"https://api.github.com/users/Ozymadias/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-07T16:40:04Z","updated_at":"2017-12-08T07:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"634509f560bc7bf8ebac6c43231185f996c5dee4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/smolamarcin/battleship/pulls/63/commits","review_comments_url":"https://api.github.com/repos/smolamarcin/battleship/pulls/63/comments","review_comment_url":"https://api.github.com/repos/smolamarcin/battleship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smolamarcin/battleship/issues/63/comments","statuses_url":"https://api.github.com/repos/smolamarcin/battleship/statuses/3e657448df806244359417a0847f47c8cec6360c","head":{"label":"smolamarcin:62-make_game_machin_independent","ref":"62-make_game_machin_independent","sha":"3e657448df806244359417a0847f47c8cec6360c","user":{"login":"smolamarcin","id":27737154,"avatar_url":"https://avatars2.githubusercontent.com/u/27737154?v=4","gravatar_id":"","url":"https://api.github.com/users/smolamarcin","html_url":"https://github.com/smolamarcin","followers_url":"https://api.github.com/users/smolamarcin/followers","following_url":"https://api.github.com/users/smolamarcin/following{/other_user}","gists_url":"https://api.github.com/users/smolamarcin/gists{/gist_id}","starred_url":"https://api.github.com/users/smolamarcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolamarcin/subscriptions","organizations_url":"https://api.github.com/users/smolamarcin/orgs","repos_url":"https://api.github.com/users/smolamarcin/repos","events_url":"https://api.github.com/users/smolamarcin/events{/privacy}","received_events_url":"https://api.github.com/users/smolamarcin/received_events","type":"User","site_admin":false},"repo":{"id":113014494,"name":"battleship","full_name":"smolamarcin/battleship","owner":{"login":"smolamarcin","id":27737154,"avatar_url":"https://avatars2.githubusercontent.com/u/27737154?v=4","gravatar_id":"","url":"https://api.github.com/users/smolamarcin","html_url":"https://github.com/smolamarcin","followers_url":"https://api.github.com/users/smolamarcin/followers","following_url":"https://api.github.com/users/smolamarcin/following{/other_user}","gists_url":"https://api.github.com/users/smolamarcin/gists{/gist_id}","starred_url":"https://api.github.com/users/smolamarcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolamarcin/subscriptions","organizations_url":"https://api.github.com/users/smolamarcin/orgs","repos_url":"https://api.github.com/users/smolamarcin/repos","events_url":"https://api.github.com/users/smolamarcin/events{/privacy}","received_events_url":"https://api.github.com/users/smolamarcin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smolamarcin/battleship","description":"Battleship","fork":false,"url":"https://api.github.com/repos/smolamarcin/battleship","forks_url":"https://api.github.com/repos/smolamarcin/battleship/forks","keys_url":"https://api.github.com/repos/smolamarcin/battleship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smolamarcin/battleship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smolamarcin/battleship/teams","hooks_url":"https://api.github.com/repos/smolamarcin/battleship/hooks","issue_events_url":"https://api.github.com/repos/smolamarcin/battleship/issues/events{/number}","events_url":"https://api.github.com/repos/smolamarcin/battleship/events","assignees_url":"https://api.github.com/repos/smolamarcin/battleship/assignees{/user}","branches_url":"https://api.github.com/repos/smolamarcin/battleship/branches{/branch}","tags_url":"https://api.github.com/repos/smolamarcin/battleship/tags","blobs_url":"https://api.github.com/repos/smolamarcin/battleship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smolamarcin/battleship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smolamarcin/battleship/git/refs{/sha}","trees_url":"https://api.github.com/repos/smolamarcin/battleship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smolamarcin/battleship/statuses/{sha}","languages_url":"https://api.github.com/repos/smolamarcin/battleship/languages","stargazers_url":"https://api.github.com/repos/smolamarcin/battleship/stargazers","contributors_url":"https://api.github.com/repos/smolamarcin/battleship/contributors","subscribers_url":"https://api.github.com/repos/smolamarcin/battleship/subscribers","subscription_url":"https://api.github.com/repos/smolamarcin/battleship/subscription","commits_url":"https://api.github.com/repos/smolamarcin/battleship/commits{/sha}","git_commits_url":"https://api.github.com/repos/smolamarcin/battleship/git/commits{/sha}","comments_url":"https://api.github.com/repos/smolamarcin/battleship/comments{/number}","issue_comment_url":"https://api.github.com/repos/smolamarcin/battleship/issues/comments{/number}","contents_url":"https://api.github.com/repos/smolamarcin/battleship/contents/{+path}","compare_url":"https://api.github.com/repos/smolamarcin/battleship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smolamarcin/battleship/merges","archive_url":"https://api.github.com/repos/smolamarcin/battleship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smolamarcin/battleship/downloads","issues_url":"https://api.github.com/repos/smolamarcin/battleship/issues{/number}","pulls_url":"https://api.github.com/repos/smolamarcin/battleship/pulls{/number}","milestones_url":"https://api.github.com/repos/smolamarcin/battleship/milestones{/number}","notifications_url":"https://api.github.com/repos/smolamarcin/battleship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smolamarcin/battleship/labels{/name}","releases_url":"https://api.github.com/repos/smolamarcin/battleship/releases{/id}","deployments_url":"https://api.github.com/repos/smolamarcin/battleship/deployments","created_at":"2017-12-04T08:14:38Z","updated_at":"2017-12-06T11:00:37Z","pushed_at":"2017-12-08T07:07:26Z","git_url":"git://github.com/smolamarcin/battleship.git","ssh_url":"git@github.com:smolamarcin/battleship.git","clone_url":"https://github.com/smolamarcin/battleship.git","svn_url":"https://github.com/smolamarcin/battleship","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":0,"open_issues":30,"watchers":0,"default_branch":"master"}},"base":{"label":"smolamarcin:development","ref":"development","sha":"4613848fabaf5b7077d89d8c336395e857cafbcb","user":{"login":"smolamarcin","id":27737154,"avatar_url":"https://avatars2.githubusercontent.com/u/27737154?v=4","gravatar_id":"","url":"https://api.github.com/users/smolamarcin","html_url":"https://github.com/smolamarcin","followers_url":"https://api.github.com/users/smolamarcin/followers","following_url":"https://api.github.com/users/smolamarcin/following{/other_user}","gists_url":"https://api.github.com/users/smolamarcin/gists{/gist_id}","starred_url":"https://api.github.com/users/smolamarcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolamarcin/subscriptions","organizations_url":"https://api.github.com/users/smolamarcin/orgs","repos_url":"https://api.github.com/users/smolamarcin/repos","events_url":"https://api.github.com/users/smolamarcin/events{/privacy}","received_events_url":"https://api.github.com/users/smolamarcin/received_events","type":"User","site_admin":false},"repo":{"id":113014494,"name":"battleship","full_name":"smolamarcin/battleship","owner":{"login":"smolamarcin","id":27737154,"avatar_url":"https://avatars2.githubusercontent.com/u/27737154?v=4","gravatar_id":"","url":"https://api.github.com/users/smolamarcin","html_url":"https://github.com/smolamarcin","followers_url":"https://api.github.com/users/smolamarcin/followers","following_url":"https://api.github.com/users/smolamarcin/following{/other_user}","gists_url":"https://api.github.com/users/smolamarcin/gists{/gist_id}","starred_url":"https://api.github.com/users/smolamarcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolamarcin/subscriptions","organizations_url":"https://api.github.com/users/smolamarcin/orgs","repos_url":"https://api.github.com/users/smolamarcin/repos","events_url":"https://api.github.com/users/smolamarcin/events{/privacy}","received_events_url":"https://api.github.com/users/smolamarcin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smolamarcin/battleship","description":"Battleship","fork":false,"url":"https://api.github.com/repos/smolamarcin/battleship","forks_url":"https://api.github.com/repos/smolamarcin/battleship/forks","keys_url":"https://api.github.com/repos/smolamarcin/battleship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smolamarcin/battleship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smolamarcin/battleship/teams","hooks_url":"https://api.github.com/repos/smolamarcin/battleship/hooks","issue_events_url":"https://api.github.com/repos/smolamarcin/battleship/issues/events{/number}","events_url":"https://api.github.com/repos/smolamarcin/battleship/events","assignees_url":"https://api.github.com/repos/smolamarcin/battleship/assignees{/user}","branches_url":"https://api.github.com/repos/smolamarcin/battleship/branches{/branch}","tags_url":"https://api.github.com/repos/smolamarcin/battleship/tags","blobs_url":"https://api.github.com/repos/smolamarcin/battleship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smolamarcin/battleship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smolamarcin/battleship/git/refs{/sha}","trees_url":"https://api.github.com/repos/smolamarcin/battleship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smolamarcin/battleship/statuses/{sha}","languages_url":"https://api.github.com/repos/smolamarcin/battleship/languages","stargazers_url":"https://api.github.com/repos/smolamarcin/battleship/stargazers","contributors_url":"https://api.github.com/repos/smolamarcin/battleship/contributors","subscribers_url":"https://api.github.com/repos/smolamarcin/battleship/subscribers","subscription_url":"https://api.github.com/repos/smolamarcin/battleship/subscription","commits_url":"https://api.github.com/repos/smolamarcin/battleship/commits{/sha}","git_commits_url":"https://api.github.com/repos/smolamarcin/battleship/git/commits{/sha}","comments_url":"https://api.github.com/repos/smolamarcin/battleship/comments{/number}","issue_comment_url":"https://api.github.com/repos/smolamarcin/battleship/issues/comments{/number}","contents_url":"https://api.github.com/repos/smolamarcin/battleship/contents/{+path}","compare_url":"https://api.github.com/repos/smolamarcin/battleship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smolamarcin/battleship/merges","archive_url":"https://api.github.com/repos/smolamarcin/battleship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smolamarcin/battleship/downloads","issues_url":"https://api.github.com/repos/smolamarcin/battleship/issues{/number}","pulls_url":"https://api.github.com/repos/smolamarcin/battleship/pulls{/number}","milestones_url":"https://api.github.com/repos/smolamarcin/battleship/milestones{/number}","notifications_url":"https://api.github.com/repos/smolamarcin/battleship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smolamarcin/battleship/labels{/name}","releases_url":"https://api.github.com/repos/smolamarcin/battleship/releases{/id}","deployments_url":"https://api.github.com/repos/smolamarcin/battleship/deployments","created_at":"2017-12-04T08:14:38Z","updated_at":"2017-12-06T11:00:37Z","pushed_at":"2017-12-08T07:07:26Z","git_url":"git://github.com/smolamarcin/battleship.git","ssh_url":"git@github.com:smolamarcin/battleship.git","clone_url":"https://github.com/smolamarcin/battleship.git","svn_url":"https://github.com/smolamarcin/battleship","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":0,"open_issues":30,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smolamarcin/battleship/pulls/63"},"html":{"href":"https://github.com/smolamarcin/battleship/pull/63"},"issue":{"href":"https://api.github.com/repos/smolamarcin/battleship/issues/63"},"comments":{"href":"https://api.github.com/repos/smolamarcin/battleship/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/smolamarcin/battleship/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/smolamarcin/battleship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smolamarcin/battleship/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/smolamarcin/battleship/statuses/3e657448df806244359417a0847f47c8cec6360c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rivalez"}}