{"action":"created","issue":{"url":"https://api.github.com/repos/freebroccolo/vscode-reasonml/issues/58","repository_url":"https://api.github.com/repos/freebroccolo/vscode-reasonml","labels_url":"https://api.github.com/repos/freebroccolo/vscode-reasonml/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/freebroccolo/vscode-reasonml/issues/58/comments","events_url":"https://api.github.com/repos/freebroccolo/vscode-reasonml/issues/58/events","html_url":"https://github.com/freebroccolo/vscode-reasonml/issues/58","id":228344481,"number":58,"title":"No definition found ...","user":{"login":"kristojorg","id":4398775,"avatar_url":"https://avatars1.githubusercontent.com/u/4398775?v=3","gravatar_id":"","url":"https://api.github.com/users/kristojorg","html_url":"https://github.com/kristojorg","followers_url":"https://api.github.com/users/kristojorg/followers","following_url":"https://api.github.com/users/kristojorg/following{/other_user}","gists_url":"https://api.github.com/users/kristojorg/gists{/gist_id}","starred_url":"https://api.github.com/users/kristojorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristojorg/subscriptions","organizations_url":"https://api.github.com/users/kristojorg/orgs","repos_url":"https://api.github.com/users/kristojorg/repos","events_url":"https://api.github.com/users/kristojorg/events{/privacy}","received_events_url":"https://api.github.com/users/kristojorg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-05-12T16:32:49Z","updated_at":"2017-05-14T19:07:13Z","closed_at":null,"body":"I'm not entirely sure this is an issue with vscode-reason, but I'm also not sure where else to look. I am starting a project with the `reason-react-example` code found [here](https://github.com/chenglou/reason-react-example). One of the files looks like this: \r\n\r\n```\r\nmodule PageReason = {\r\n  include ReactRe.Component.JsProps;\r\n  type props = {message: string, extraGreeting: option string};\r\n  let name = \"PageReason\";\r\n  let render {props} => {\r\n    let greeting =\r\n      switch props.extraGreeting {\r\n      | None => \"How are you?\"\r\n      | Some g => g\r\n      };\r\n    <div> <MyBannerRe show=true message=(props.message ^ \" \" ^ greeting) /> </div>\r\n  };\r\n  /* extraGreeting is optional, which means the JS side might pass in a null or undefined */\r\n  type jsProps = Js.t {. message : string, extraGreeting : Js.null_undefined string};\r\n  let jsPropsToReasonProps =\r\n    Some (\r\n      fun jsProps => {\r\n        message: jsProps##message,\r\n        extraGreeting: Js.Null_undefined.to_opt jsProps##extraGreeting\r\n      }\r\n    );\r\n};\r\n\r\ninclude ReactRe.CreateComponent PageReason;\r\n\r\nlet createElement ::message ::extraGreeting=? => wrapProps {message, extraGreeting};\r\n```\r\n\r\nI am trying to understand where the `Js` variable is coming from, what it does etc. but jump to definition is not working on it, instead it says no definition found. This is also true of the `MyBannerRe` component, which is in a sibling file. \r\n\r\nAny help would be appreciated. Thank you!!"},"comment":{"url":"https://api.github.com/repos/freebroccolo/vscode-reasonml/issues/comments/301332931","html_url":"https://github.com/freebroccolo/vscode-reasonml/issues/58#issuecomment-301332931","issue_url":"https://api.github.com/repos/freebroccolo/vscode-reasonml/issues/58","id":301332931,"user":{"login":"freebroccolo","id":151197,"avatar_url":"https://avatars3.githubusercontent.com/u/151197?v=3","gravatar_id":"","url":"https://api.github.com/users/freebroccolo","html_url":"https://github.com/freebroccolo","followers_url":"https://api.github.com/users/freebroccolo/followers","following_url":"https://api.github.com/users/freebroccolo/following{/other_user}","gists_url":"https://api.github.com/users/freebroccolo/gists{/gist_id}","starred_url":"https://api.github.com/users/freebroccolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freebroccolo/subscriptions","organizations_url":"https://api.github.com/users/freebroccolo/orgs","repos_url":"https://api.github.com/users/freebroccolo/repos","events_url":"https://api.github.com/users/freebroccolo/events{/privacy}","received_events_url":"https://api.github.com/users/freebroccolo/received_events","type":"User","site_admin":false},"created_at":"2017-05-14T19:07:13Z","updated_at":"2017-05-14T19:07:13Z","body":"> For example, if .merlin is in the parent directory, then this does not pick it up\r\n> \r\n> open test.re -a /Applications/Visual\\ Studio\\ Code.app/\r\n\r\nJust to be clear, are we talking about a directory structure like this?\r\n\r\n```\r\nsrc\r\n|- .merlin\r\n|- test.re\r\n```\r\n\r\n... or like this?\r\n\r\n```\r\nproject\r\n|- .merlin\r\n|- src\r\n   |- test.re\r\n```\r\n\r\nBoth cases can probably be dealt with but the second one will be messier due to the fact that vscode really wants to be opened in the project root."}}
{"actor":{"display_login":"freebroccolo"}}