{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/117913161","pull_request_review_id":39656771,"id":117913161,"diff_hunk":"@@ -534,8 +534,8 @@ var RTE = Widget.extend({\n             this.$last = null;\n         }\n         if ($editable.length && (!this.$last || this.$last[0] !== $editable[0]) &&\n-                ($target.closest('[contenteditable]').attr('contenteditable') || \"\").toLowerCase() !== 'false') {\n-\n+                ($target.closest('[contenteditable]').attr('contenteditable') || \"\").toLowerCase() !== 'false' ||\n+                (dom.isImg($target[0]) && (!this.$last || this.$last[0] !== $editable[0]))) {","path":"addons/web_editor/static/src/js/rte.js","position":7,"original_position":7,"commit_id":"1766da7d8e9f4e9343d4c8a28892e831ff4cfa06","original_commit_id":"7a81ed4dbaf0cbe18c4ab12bea42f927812c951d","user":{"login":"dbh-odoo","id":20393833,"avatar_url":"https://avatars2.githubusercontent.com/u/20393833?v=3","gravatar_id":"","url":"https://api.github.com/users/dbh-odoo","html_url":"https://github.com/dbh-odoo","followers_url":"https://api.github.com/users/dbh-odoo/followers","following_url":"https://api.github.com/users/dbh-odoo/following{/other_user}","gists_url":"https://api.github.com/users/dbh-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/dbh-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbh-odoo/subscriptions","organizations_url":"https://api.github.com/users/dbh-odoo/orgs","repos_url":"https://api.github.com/users/dbh-odoo/repos","events_url":"https://api.github.com/users/dbh-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/dbh-odoo/received_events","type":"User","site_admin":false},"body":"if image added first time in image gallery snippet then it is not focused or not selectable so to select the image this condition is added and very last condition is in and operation with this:{ dom.isImg($target[0]) } otherwise this condition will always true and it will go in infinite. ","created_at":"2017-05-23T07:03:34Z","updated_at":"2017-05-23T07:03:34Z","html_url":"https://github.com/odoo/odoo/pull/15460#discussion_r117913161","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/15460","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/117913161"},"html":{"href":"https://github.com/odoo/odoo/pull/15460#discussion_r117913161"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15460"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/15460","id":105830279,"html_url":"https://github.com/odoo/odoo/pull/15460","diff_url":"https://github.com/odoo/odoo/pull/15460.diff","patch_url":"https://github.com/odoo/odoo/pull/15460.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/15460","number":15460,"state":"open","locked":false,"title":"Master website clean issue framework dbh","user":{"login":"dbh-odoo","id":20393833,"avatar_url":"https://avatars2.githubusercontent.com/u/20393833?v=3","gravatar_id":"","url":"https://api.github.com/users/dbh-odoo","html_url":"https://github.com/dbh-odoo","followers_url":"https://api.github.com/users/dbh-odoo/followers","following_url":"https://api.github.com/users/dbh-odoo/following{/other_user}","gists_url":"https://api.github.com/users/dbh-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/dbh-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbh-odoo/subscriptions","organizations_url":"https://api.github.com/users/dbh-odoo/orgs","repos_url":"https://api.github.com/users/dbh-odoo/repos","events_url":"https://api.github.com/users/dbh-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/dbh-odoo/received_events","type":"User","site_admin":false},"body":"Task: https://www.odoo.com/web#id=30407&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720\r\n\r\nPad: https://pad.odoo.com/p/r.49574d4261054aab57b79812df9c48e8\r\n\r\nDescription of the issue/feature this PR addresses:\r\n\r\nCurrent behavior before PR:\r\n\r\nDesired behavior after PR is merged:\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2017-02-13T05:09:05Z","updated_at":"2017-05-23T07:03:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cd62117a1231ade3c76b70a26ab737f4485de78","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/15460/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/15460/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/15460/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/1766da7d8e9f4e9343d4c8a28892e831ff4cfa06","head":{"label":"odoo-dev:master-website-clean-issue-framework-dbh","ref":"master-website-clean-issue-framework-dbh","sha":"1766da7d8e9f4e9343d4c8a28892e831ff4cfa06","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars3.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars3.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2016-10-31T14:56:45Z","pushed_at":"2017-05-23T06:58:14Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1777915,"stargazers_count":71,"watchers_count":71,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":0,"forks":30,"open_issues":0,"watchers":71,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"f1767d5c88b72579863a2a7c325889b24f373fb9","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars1.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars1.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2017-05-23T04:17:14Z","pushed_at":"2017-05-23T06:44:46Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1772565,"stargazers_count":6701,"watchers_count":6701,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6177,"mirror_url":null,"open_issues_count":3647,"forks":6177,"open_issues":3647,"watchers":6701,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15460"},"html":{"href":"https://github.com/odoo/odoo/pull/15460"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/15460"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/15460/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15460/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15460/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/1766da7d8e9f4e9343d4c8a28892e831ff4cfa06"}}}}
{"actor":{"display_login":"dbh-odoo"}}