{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1711","repository_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1711/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1711/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1711/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1711","id":277508315,"number":1711,"title":"Cap state/local deductions as fraction of AGI","user":{"login":"derrickchoe","id":32269181,"avatar_url":"https://avatars0.githubusercontent.com/u/32269181?v=4","gravatar_id":"","url":"https://api.github.com/users/derrickchoe","html_url":"https://github.com/derrickchoe","followers_url":"https://api.github.com/users/derrickchoe/followers","following_url":"https://api.github.com/users/derrickchoe/following{/other_user}","gists_url":"https://api.github.com/users/derrickchoe/gists{/gist_id}","starred_url":"https://api.github.com/users/derrickchoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derrickchoe/subscriptions","organizations_url":"https://api.github.com/users/derrickchoe/orgs","repos_url":"https://api.github.com/users/derrickchoe/repos","events_url":"https://api.github.com/users/derrickchoe/events{/privacy}","received_events_url":"https://api.github.com/users/derrickchoe/received_events","type":"User","site_admin":false},"labels":[{"id":431564923,"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/labels/ready","name":"ready","color":"d1fcab","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":47,"created_at":"2017-11-28T19:26:09Z","updated_at":"2017-12-21T17:57:20Z","closed_at":"2017-12-19T14:57:05Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/1711","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1711","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1711.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1711.patch"},"body":"I'm adding a reform I made a few months back for a project. I created the parameter StateLocalTax_crt, which caps state/local tax deductions as a decimal fraction of agi. "},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/353415939","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/1711#issuecomment-353415939","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/1711","id":353415939,"user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T17:57:20Z","updated_at":"2017-12-21T17:57:20Z","author_association":"CONTRIBUTOR","body":"@derrickchoe said:\r\n> In test_4package.py, I'm getting a \"file not found\" error for lib\\subprocess.py (I don't know if this means that subprocess.py is missing). Is this a common issue?\r\n\r\nNo its not common, but more on that below.\r\n\r\nMy understanding is that subprocess is part of the standard, built-in Python library.\r\nSo, if you fail the tests in `test_4package.py`, then you must also be failing the tests in `test_notebooks.py`.  Is that the case?  I'm guessing that because the subprocess library is imported in both those files as seen below:\r\n```\r\n- grep; default-directory: \"~/work/OSPC/tax-calculator/taxcalc/tests/\" -*-\r\ngrep -nH -e subprocess *\r\ntest_4package.py:10:import subprocess\r\ntest_4package.py:22:    out = subprocess.check_output(['conda', 'list', 'taxcalc']).decode('ascii')\r\ntest_notebooks.py:3:import subprocess\r\ntest_notebooks.py:16:    rcode = subprocess.check_call(['python', sfilename], cwd=test_path)\r\n```\r\nNobody has ever reported this as a problem, but maybe that's because all the other developers are working on Macs and you're working on Windows.  That's just a guess.\r\n\r\nAre you executing `py.test -n4` from the Windows command prompt or from inside some IDE?\r\n\r\n"}}
{"actor":{"display_login":"martinholmer"}}