{"action":"opened","number":513,"pull_request":{"url":"https://api.github.com/repos/proftpd/proftpd/pulls/513","id":121297693,"html_url":"https://github.com/proftpd/proftpd/pull/513","diff_url":"https://github.com/proftpd/proftpd/pull/513.diff","patch_url":"https://github.com/proftpd/proftpd/pull/513.patch","issue_url":"https://api.github.com/repos/proftpd/proftpd/issues/513","number":513,"state":"open","locked":false,"title":"Fix pr_str_get_similars","user":{"login":"pghmcfc","id":947224,"avatar_url":"https://avatars1.githubusercontent.com/u/947224?v=3","gravatar_id":"","url":"https://api.github.com/users/pghmcfc","html_url":"https://github.com/pghmcfc","followers_url":"https://api.github.com/users/pghmcfc/followers","following_url":"https://api.github.com/users/pghmcfc/following{/other_user}","gists_url":"https://api.github.com/users/pghmcfc/gists{/gist_id}","starred_url":"https://api.github.com/users/pghmcfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pghmcfc/subscriptions","organizations_url":"https://api.github.com/users/pghmcfc/orgs","repos_url":"https://api.github.com/users/pghmcfc/repos","events_url":"https://api.github.com/users/pghmcfc/events{/privacy}","received_events_url":"https://api.github.com/users/pghmcfc/received_events","type":"User","site_admin":false},"body":"The comparison function used with qsort(3) for pr_str_get_similars\r\nwas missing a level of pointer dereferencing, and hence did not\r\nactually work as intended.\r\n\r\nThe accompanying test, which had workarounds for some of the\r\nresulting flakiness, can now be more deterministic.","created_at":"2017-05-18T14:29:38Z","updated_at":"2017-05-18T14:29:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/proftpd/proftpd/pulls/513/commits","review_comments_url":"https://api.github.com/repos/proftpd/proftpd/pulls/513/comments","review_comment_url":"https://api.github.com/repos/proftpd/proftpd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/proftpd/proftpd/issues/513/comments","statuses_url":"https://api.github.com/repos/proftpd/proftpd/statuses/b99af9a9f367a138dfd0a32201827f103bb547c9","head":{"label":"pghmcfc:similars","ref":"similars","sha":"b99af9a9f367a138dfd0a32201827f103bb547c9","user":{"login":"pghmcfc","id":947224,"avatar_url":"https://avatars1.githubusercontent.com/u/947224?v=3","gravatar_id":"","url":"https://api.github.com/users/pghmcfc","html_url":"https://github.com/pghmcfc","followers_url":"https://api.github.com/users/pghmcfc/followers","following_url":"https://api.github.com/users/pghmcfc/following{/other_user}","gists_url":"https://api.github.com/users/pghmcfc/gists{/gist_id}","starred_url":"https://api.github.com/users/pghmcfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pghmcfc/subscriptions","organizations_url":"https://api.github.com/users/pghmcfc/orgs","repos_url":"https://api.github.com/users/pghmcfc/repos","events_url":"https://api.github.com/users/pghmcfc/events{/privacy}","received_events_url":"https://api.github.com/users/pghmcfc/received_events","type":"User","site_admin":false},"repo":{"id":88753739,"name":"proftpd","full_name":"pghmcfc/proftpd","owner":{"login":"pghmcfc","id":947224,"avatar_url":"https://avatars1.githubusercontent.com/u/947224?v=3","gravatar_id":"","url":"https://api.github.com/users/pghmcfc","html_url":"https://github.com/pghmcfc","followers_url":"https://api.github.com/users/pghmcfc/followers","following_url":"https://api.github.com/users/pghmcfc/following{/other_user}","gists_url":"https://api.github.com/users/pghmcfc/gists{/gist_id}","starred_url":"https://api.github.com/users/pghmcfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pghmcfc/subscriptions","organizations_url":"https://api.github.com/users/pghmcfc/orgs","repos_url":"https://api.github.com/users/pghmcfc/repos","events_url":"https://api.github.com/users/pghmcfc/events{/privacy}","received_events_url":"https://api.github.com/users/pghmcfc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pghmcfc/proftpd","description":"ProFTPD source code","fork":true,"url":"https://api.github.com/repos/pghmcfc/proftpd","forks_url":"https://api.github.com/repos/pghmcfc/proftpd/forks","keys_url":"https://api.github.com/repos/pghmcfc/proftpd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pghmcfc/proftpd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pghmcfc/proftpd/teams","hooks_url":"https://api.github.com/repos/pghmcfc/proftpd/hooks","issue_events_url":"https://api.github.com/repos/pghmcfc/proftpd/issues/events{/number}","events_url":"https://api.github.com/repos/pghmcfc/proftpd/events","assignees_url":"https://api.github.com/repos/pghmcfc/proftpd/assignees{/user}","branches_url":"https://api.github.com/repos/pghmcfc/proftpd/branches{/branch}","tags_url":"https://api.github.com/repos/pghmcfc/proftpd/tags","blobs_url":"https://api.github.com/repos/pghmcfc/proftpd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pghmcfc/proftpd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pghmcfc/proftpd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pghmcfc/proftpd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pghmcfc/proftpd/statuses/{sha}","languages_url":"https://api.github.com/repos/pghmcfc/proftpd/languages","stargazers_url":"https://api.github.com/repos/pghmcfc/proftpd/stargazers","contributors_url":"https://api.github.com/repos/pghmcfc/proftpd/contributors","subscribers_url":"https://api.github.com/repos/pghmcfc/proftpd/subscribers","subscription_url":"https://api.github.com/repos/pghmcfc/proftpd/subscription","commits_url":"https://api.github.com/repos/pghmcfc/proftpd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pghmcfc/proftpd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pghmcfc/proftpd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pghmcfc/proftpd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pghmcfc/proftpd/contents/{+path}","compare_url":"https://api.github.com/repos/pghmcfc/proftpd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pghmcfc/proftpd/merges","archive_url":"https://api.github.com/repos/pghmcfc/proftpd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pghmcfc/proftpd/downloads","issues_url":"https://api.github.com/repos/pghmcfc/proftpd/issues{/number}","pulls_url":"https://api.github.com/repos/pghmcfc/proftpd/pulls{/number}","milestones_url":"https://api.github.com/repos/pghmcfc/proftpd/milestones{/number}","notifications_url":"https://api.github.com/repos/pghmcfc/proftpd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pghmcfc/proftpd/labels{/name}","releases_url":"https://api.github.com/repos/pghmcfc/proftpd/releases{/id}","deployments_url":"https://api.github.com/repos/pghmcfc/proftpd/deployments","created_at":"2017-04-19T14:19:28Z","updated_at":"2017-04-19T14:19:37Z","pushed_at":"2017-05-18T14:28:22Z","git_url":"git://github.com/pghmcfc/proftpd.git","ssh_url":"git@github.com:pghmcfc/proftpd.git","clone_url":"https://github.com/pghmcfc/proftpd.git","svn_url":"https://github.com/pghmcfc/proftpd","homepage":"http://www.proftpd.org","size":66120,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"proftpd:master","ref":"master","sha":"b101ba1f9f74b15bab40c388001f5b78d163ec99","user":{"login":"proftpd","id":821731,"avatar_url":"https://avatars0.githubusercontent.com/u/821731?v=3","gravatar_id":"","url":"https://api.github.com/users/proftpd","html_url":"https://github.com/proftpd","followers_url":"https://api.github.com/users/proftpd/followers","following_url":"https://api.github.com/users/proftpd/following{/other_user}","gists_url":"https://api.github.com/users/proftpd/gists{/gist_id}","starred_url":"https://api.github.com/users/proftpd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proftpd/subscriptions","organizations_url":"https://api.github.com/users/proftpd/orgs","repos_url":"https://api.github.com/users/proftpd/repos","events_url":"https://api.github.com/users/proftpd/events{/privacy}","received_events_url":"https://api.github.com/users/proftpd/received_events","type":"Organization","site_admin":false},"repo":{"id":19863023,"name":"proftpd","full_name":"proftpd/proftpd","owner":{"login":"proftpd","id":821731,"avatar_url":"https://avatars0.githubusercontent.com/u/821731?v=3","gravatar_id":"","url":"https://api.github.com/users/proftpd","html_url":"https://github.com/proftpd","followers_url":"https://api.github.com/users/proftpd/followers","following_url":"https://api.github.com/users/proftpd/following{/other_user}","gists_url":"https://api.github.com/users/proftpd/gists{/gist_id}","starred_url":"https://api.github.com/users/proftpd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proftpd/subscriptions","organizations_url":"https://api.github.com/users/proftpd/orgs","repos_url":"https://api.github.com/users/proftpd/repos","events_url":"https://api.github.com/users/proftpd/events{/privacy}","received_events_url":"https://api.github.com/users/proftpd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/proftpd/proftpd","description":"ProFTPD source code","fork":false,"url":"https://api.github.com/repos/proftpd/proftpd","forks_url":"https://api.github.com/repos/proftpd/proftpd/forks","keys_url":"https://api.github.com/repos/proftpd/proftpd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proftpd/proftpd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proftpd/proftpd/teams","hooks_url":"https://api.github.com/repos/proftpd/proftpd/hooks","issue_events_url":"https://api.github.com/repos/proftpd/proftpd/issues/events{/number}","events_url":"https://api.github.com/repos/proftpd/proftpd/events","assignees_url":"https://api.github.com/repos/proftpd/proftpd/assignees{/user}","branches_url":"https://api.github.com/repos/proftpd/proftpd/branches{/branch}","tags_url":"https://api.github.com/repos/proftpd/proftpd/tags","blobs_url":"https://api.github.com/repos/proftpd/proftpd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proftpd/proftpd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proftpd/proftpd/git/refs{/sha}","trees_url":"https://api.github.com/repos/proftpd/proftpd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proftpd/proftpd/statuses/{sha}","languages_url":"https://api.github.com/repos/proftpd/proftpd/languages","stargazers_url":"https://api.github.com/repos/proftpd/proftpd/stargazers","contributors_url":"https://api.github.com/repos/proftpd/proftpd/contributors","subscribers_url":"https://api.github.com/repos/proftpd/proftpd/subscribers","subscription_url":"https://api.github.com/repos/proftpd/proftpd/subscription","commits_url":"https://api.github.com/repos/proftpd/proftpd/commits{/sha}","git_commits_url":"https://api.github.com/repos/proftpd/proftpd/git/commits{/sha}","comments_url":"https://api.github.com/repos/proftpd/proftpd/comments{/number}","issue_comment_url":"https://api.github.com/repos/proftpd/proftpd/issues/comments{/number}","contents_url":"https://api.github.com/repos/proftpd/proftpd/contents/{+path}","compare_url":"https://api.github.com/repos/proftpd/proftpd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proftpd/proftpd/merges","archive_url":"https://api.github.com/repos/proftpd/proftpd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proftpd/proftpd/downloads","issues_url":"https://api.github.com/repos/proftpd/proftpd/issues{/number}","pulls_url":"https://api.github.com/repos/proftpd/proftpd/pulls{/number}","milestones_url":"https://api.github.com/repos/proftpd/proftpd/milestones{/number}","notifications_url":"https://api.github.com/repos/proftpd/proftpd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proftpd/proftpd/labels{/name}","releases_url":"https://api.github.com/repos/proftpd/proftpd/releases{/id}","deployments_url":"https://api.github.com/repos/proftpd/proftpd/deployments","created_at":"2014-05-16T16:22:01Z","updated_at":"2017-04-14T14:51:10Z","pushed_at":"2017-05-17T21:29:03Z","git_url":"git://github.com/proftpd/proftpd.git","ssh_url":"git@github.com:proftpd/proftpd.git","clone_url":"https://github.com/proftpd/proftpd.git","svn_url":"https://github.com/proftpd/proftpd","homepage":"http://www.proftpd.org","size":65992,"stargazers_count":102,"watchers_count":102,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":49,"forks":58,"open_issues":49,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/proftpd/proftpd/pulls/513"},"html":{"href":"https://github.com/proftpd/proftpd/pull/513"},"issue":{"href":"https://api.github.com/repos/proftpd/proftpd/issues/513"},"comments":{"href":"https://api.github.com/repos/proftpd/proftpd/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/proftpd/proftpd/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/proftpd/proftpd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/proftpd/proftpd/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/proftpd/proftpd/statuses/b99af9a9f367a138dfd0a32201827f103bb547c9"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":21,"deletions":19,"changed_files":2}}
{"actor":{"display_login":"pghmcfc"}}