{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/design/pulls/comments/134747639","pull_request_review_id":58074707,"id":134747639,"diff_hunk":"@@ -104,6 +104,13 @@ All other constants are declared as `static const` members in the struct and the\n ### Constructors\n \n The *default constructor* initializes all members with their default value.\n+In some cases this may not be desirable, since these fields will often be immediately overwritten with user-provided values.\n+Therefore, the constructor takes an optional directive of type `enum rcl_msg_init_type` to control how initialization is done:","path":"articles/112_generated_interfaces_cpp.md","position":5,"original_position":5,"commit_id":"03ecf35404ecc20fca0c027e231f7d6c90200b3c","original_commit_id":"03ecf35404ecc20fca0c027e231f7d6c90200b3c","user":{"login":"clalancette","id":163000,"avatar_url":"https://avatars0.githubusercontent.com/u/163000?v=4","gravatar_id":"","url":"https://api.github.com/users/clalancette","html_url":"https://github.com/clalancette","followers_url":"https://api.github.com/users/clalancette/followers","following_url":"https://api.github.com/users/clalancette/following{/other_user}","gists_url":"https://api.github.com/users/clalancette/gists{/gist_id}","starred_url":"https://api.github.com/users/clalancette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clalancette/subscriptions","organizations_url":"https://api.github.com/users/clalancette/orgs","repos_url":"https://api.github.com/users/clalancette/repos","events_url":"https://api.github.com/users/clalancette/events{/privacy}","received_events_url":"https://api.github.com/users/clalancette/received_events","type":"User","site_admin":false},"body":"rcl seems to me a decent place to put this enum, but I'm certainly open to moving it elsewhere.","created_at":"2017-08-23T13:16:21Z","updated_at":"2017-08-23T13:16:21Z","html_url":"https://github.com/ros2/design/pull/136#discussion_r134747639","pull_request_url":"https://api.github.com/repos/ros2/design/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/ros2/design/pulls/comments/134747639"},"html":{"href":"https://github.com/ros2/design/pull/136#discussion_r134747639"},"pull_request":{"href":"https://api.github.com/repos/ros2/design/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/design/pulls/136","id":137215632,"html_url":"https://github.com/ros2/design/pull/136","diff_url":"https://github.com/ros2/design/pull/136.diff","patch_url":"https://github.com/ros2/design/pull/136.patch","issue_url":"https://api.github.com/repos/ros2/design/issues/136","number":136,"state":"open","locked":false,"title":"Update the CPP article to talk about initialization.","user":{"login":"clalancette","id":163000,"avatar_url":"https://avatars0.githubusercontent.com/u/163000?v=4","gravatar_id":"","url":"https://api.github.com/users/clalancette","html_url":"https://github.com/clalancette","followers_url":"https://api.github.com/users/clalancette/followers","following_url":"https://api.github.com/users/clalancette/following{/other_user}","gists_url":"https://api.github.com/users/clalancette/gists{/gist_id}","starred_url":"https://api.github.com/users/clalancette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clalancette/subscriptions","organizations_url":"https://api.github.com/users/clalancette/orgs","repos_url":"https://api.github.com/users/clalancette/repos","events_url":"https://api.github.com/users/clalancette/events{/privacy}","received_events_url":"https://api.github.com/users/clalancette/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>\r\n\r\n@ros2/team Despite our long conversations elsewhere, this ends up being a short addition to the design document.  I'll put some more notes inline; feedback is welcome.","created_at":"2017-08-23T13:15:47Z","updated_at":"2017-08-23T13:16:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4b51cd475bab773d18632c123dafdec96facf2e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/design/pulls/136/commits","review_comments_url":"https://api.github.com/repos/ros2/design/pulls/136/comments","review_comment_url":"https://api.github.com/repos/ros2/design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/design/issues/136/comments","statuses_url":"https://api.github.com/repos/ros2/design/statuses/03ecf35404ecc20fca0c027e231f7d6c90200b3c","head":{"label":"ros2:default-constructors","ref":"default-constructors","sha":"03ecf35404ecc20fca0c027e231f7d6c90200b3c","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":14241623,"name":"design","full_name":"ros2/design","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/design","description":"Design documentation for ROS 2.0 effort","fork":false,"url":"https://api.github.com/repos/ros2/design","forks_url":"https://api.github.com/repos/ros2/design/forks","keys_url":"https://api.github.com/repos/ros2/design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/design/teams","hooks_url":"https://api.github.com/repos/ros2/design/hooks","issue_events_url":"https://api.github.com/repos/ros2/design/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/design/events","assignees_url":"https://api.github.com/repos/ros2/design/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/design/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/design/tags","blobs_url":"https://api.github.com/repos/ros2/design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/design/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/design/languages","stargazers_url":"https://api.github.com/repos/ros2/design/stargazers","contributors_url":"https://api.github.com/repos/ros2/design/contributors","subscribers_url":"https://api.github.com/repos/ros2/design/subscribers","subscription_url":"https://api.github.com/repos/ros2/design/subscription","commits_url":"https://api.github.com/repos/ros2/design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/design/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/design/merges","archive_url":"https://api.github.com/repos/ros2/design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/design/downloads","issues_url":"https://api.github.com/repos/ros2/design/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/design/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/design/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/design/labels{/name}","releases_url":"https://api.github.com/repos/ros2/design/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/design/deployments","created_at":"2013-11-08T18:56:29Z","updated_at":"2017-08-20T15:33:13Z","pushed_at":"2017-08-23T13:15:48Z","git_url":"git://github.com/ros2/design.git","ssh_url":"git@github.com:ros2/design.git","clone_url":"https://github.com/ros2/design.git","svn_url":"https://github.com/ros2/design","homepage":"http://design.ros2.org/","size":1295,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":22,"forks":58,"open_issues":22,"watchers":44,"default_branch":"gh-pages"}},"base":{"label":"ros2:gh-pages","ref":"gh-pages","sha":"4ee8cc4061a530be77521a92f33ffd0f047ce788","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":14241623,"name":"design","full_name":"ros2/design","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/design","description":"Design documentation for ROS 2.0 effort","fork":false,"url":"https://api.github.com/repos/ros2/design","forks_url":"https://api.github.com/repos/ros2/design/forks","keys_url":"https://api.github.com/repos/ros2/design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/design/teams","hooks_url":"https://api.github.com/repos/ros2/design/hooks","issue_events_url":"https://api.github.com/repos/ros2/design/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/design/events","assignees_url":"https://api.github.com/repos/ros2/design/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/design/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/design/tags","blobs_url":"https://api.github.com/repos/ros2/design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/design/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/design/languages","stargazers_url":"https://api.github.com/repos/ros2/design/stargazers","contributors_url":"https://api.github.com/repos/ros2/design/contributors","subscribers_url":"https://api.github.com/repos/ros2/design/subscribers","subscription_url":"https://api.github.com/repos/ros2/design/subscription","commits_url":"https://api.github.com/repos/ros2/design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/design/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/design/merges","archive_url":"https://api.github.com/repos/ros2/design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/design/downloads","issues_url":"https://api.github.com/repos/ros2/design/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/design/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/design/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/design/labels{/name}","releases_url":"https://api.github.com/repos/ros2/design/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/design/deployments","created_at":"2013-11-08T18:56:29Z","updated_at":"2017-08-20T15:33:13Z","pushed_at":"2017-08-23T13:15:48Z","git_url":"git://github.com/ros2/design.git","ssh_url":"git@github.com:ros2/design.git","clone_url":"https://github.com/ros2/design.git","svn_url":"https://github.com/ros2/design","homepage":"http://design.ros2.org/","size":1295,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":22,"forks":58,"open_issues":22,"watchers":44,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/design/pulls/136"},"html":{"href":"https://github.com/ros2/design/pull/136"},"issue":{"href":"https://api.github.com/repos/ros2/design/issues/136"},"comments":{"href":"https://api.github.com/repos/ros2/design/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/design/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/design/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/design/statuses/03ecf35404ecc20fca0c027e231f7d6c90200b3c"}}}}
{"actor":{"display_login":"clalancette"}}