{"action":"created","comment":{"url":"https://api.github.com/repos/aelsabbahy/goss/pulls/comments/131679457","pull_request_review_id":54682556,"id":131679457,"diff_hunk":"@@ -25,9 +25,26 @@ run(){\n     [[ -e \"${GOSS_FILES_PATH}/goss.yaml\" ]] && cp \"${GOSS_FILES_PATH}/goss.yaml\" \"$tmp_dir\"\n     [[ -e \"${GOSS_FILES_PATH}/goss_wait.yaml\" ]] && cp \"${GOSS_FILES_PATH}/goss_wait.yaml\" \"$tmp_dir\"\n     [[ ! -z \"${GOSS_VARS}\" ]] && [[ -e \"${GOSS_FILES_PATH}/${GOSS_VARS}\" ]] && cp \"${GOSS_FILES_PATH}/${GOSS_VARS}\" \"$tmp_dir\"\n-    info \"Starting docker container\"\n-    id=$(docker run -d -v \"$tmp_dir:/goss\" \"${@:2}\")\n-    docker logs -f \"$id\" > \"$tmp_dir/docker_output.log\" 2>&1 &\n+\n+    # Switch between mount or cp files strategy\n+    GOSS_FILES_STRATEGY=${GOSS_FILES_STRATEGY:=\"mount\"}\n+    case \"$GOSS_FILES_STRATEGY\" in\n+      mount)\n+        info \"Starting docker container\"\n+        id=$(docker run -d -v \"$tmp_dir:/goss\" \"${@:2}\")\n+        docker logs -f \"$id\" > \"$tmp_dir/docker_output.log\" 2>&1 &\n+        ;;\n+      cp)\n+        info \"Creating docker container\"\n+        id=$(docker create \"${@:2}\")\n+        info \"Copy goss files into container\"\n+        docker cp $tmp_dir $id:/goss\n+        info \"Starting docker container\"\n+        docker start $id > /dev/null\n+        ;;\n+      *) error \"Wrong goss files strategy used! Correct options are \\\"mount\\\" of \\\"cp\\\".\"","path":"extras/dgoss/dgoss","position":24,"original_position":24,"commit_id":"f435470e48a298b294005d3c7794fb7aa816751b","original_commit_id":"f435470e48a298b294005d3c7794fb7aa816751b","user":{"login":"elliotweiser","id":4729331,"avatar_url":"https://avatars2.githubusercontent.com/u/4729331?v=4","gravatar_id":"","url":"https://api.github.com/users/elliotweiser","html_url":"https://github.com/elliotweiser","followers_url":"https://api.github.com/users/elliotweiser/followers","following_url":"https://api.github.com/users/elliotweiser/following{/other_user}","gists_url":"https://api.github.com/users/elliotweiser/gists{/gist_id}","starred_url":"https://api.github.com/users/elliotweiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliotweiser/subscriptions","organizations_url":"https://api.github.com/users/elliotweiser/orgs","repos_url":"https://api.github.com/users/elliotweiser/repos","events_url":"https://api.github.com/users/elliotweiser/events{/privacy}","received_events_url":"https://api.github.com/users/elliotweiser/received_events","type":"User","site_admin":false},"body":"Yep just a typo: I meant `of` vs `or`.\r\n\r\nWhatever your preference is for `copy` vs `cp` ;)","created_at":"2017-08-07T15:08:00Z","updated_at":"2017-08-07T15:08:00Z","html_url":"https://github.com/aelsabbahy/goss/pull/271#discussion_r131679457","pull_request_url":"https://api.github.com/repos/aelsabbahy/goss/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/aelsabbahy/goss/pulls/comments/131679457"},"html":{"href":"https://github.com/aelsabbahy/goss/pull/271#discussion_r131679457"},"pull_request":{"href":"https://api.github.com/repos/aelsabbahy/goss/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/aelsabbahy/goss/pulls/271","id":134448068,"html_url":"https://github.com/aelsabbahy/goss/pull/271","diff_url":"https://github.com/aelsabbahy/goss/pull/271.diff","patch_url":"https://github.com/aelsabbahy/goss/pull/271.patch","issue_url":"https://api.github.com/repos/aelsabbahy/goss/issues/271","number":271,"state":"open","locked":false,"title":"Add the ability to run dgoss when the docker daemon is not local. ","user":{"login":"plispe","id":12450382,"avatar_url":"https://avatars3.githubusercontent.com/u/12450382?v=4","gravatar_id":"","url":"https://api.github.com/users/plispe","html_url":"https://github.com/plispe","followers_url":"https://api.github.com/users/plispe/followers","following_url":"https://api.github.com/users/plispe/following{/other_user}","gists_url":"https://api.github.com/users/plispe/gists{/gist_id}","starred_url":"https://api.github.com/users/plispe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plispe/subscriptions","organizations_url":"https://api.github.com/users/plispe/orgs","repos_url":"https://api.github.com/users/plispe/repos","events_url":"https://api.github.com/users/plispe/events{/privacy}","received_events_url":"https://api.github.com/users/plispe/received_events","type":"User","site_admin":false},"body":"I created pull request which is discussed in #269 and #243. All the changes should be backwards compatible.","created_at":"2017-08-07T14:14:14Z","updated_at":"2017-08-07T15:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc1e71b60c75256e150e628eec5351fca4ce2331","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aelsabbahy/goss/pulls/271/commits","review_comments_url":"https://api.github.com/repos/aelsabbahy/goss/pulls/271/comments","review_comment_url":"https://api.github.com/repos/aelsabbahy/goss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aelsabbahy/goss/issues/271/comments","statuses_url":"https://api.github.com/repos/aelsabbahy/goss/statuses/f435470e48a298b294005d3c7794fb7aa816751b","head":{"label":"plispe:master","ref":"master","sha":"f435470e48a298b294005d3c7794fb7aa816751b","user":{"login":"plispe","id":12450382,"avatar_url":"https://avatars3.githubusercontent.com/u/12450382?v=4","gravatar_id":"","url":"https://api.github.com/users/plispe","html_url":"https://github.com/plispe","followers_url":"https://api.github.com/users/plispe/followers","following_url":"https://api.github.com/users/plispe/following{/other_user}","gists_url":"https://api.github.com/users/plispe/gists{/gist_id}","starred_url":"https://api.github.com/users/plispe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plispe/subscriptions","organizations_url":"https://api.github.com/users/plispe/orgs","repos_url":"https://api.github.com/users/plispe/repos","events_url":"https://api.github.com/users/plispe/events{/privacy}","received_events_url":"https://api.github.com/users/plispe/received_events","type":"User","site_admin":false},"repo":{"id":99577603,"name":"goss","full_name":"plispe/goss","owner":{"login":"plispe","id":12450382,"avatar_url":"https://avatars3.githubusercontent.com/u/12450382?v=4","gravatar_id":"","url":"https://api.github.com/users/plispe","html_url":"https://github.com/plispe","followers_url":"https://api.github.com/users/plispe/followers","following_url":"https://api.github.com/users/plispe/following{/other_user}","gists_url":"https://api.github.com/users/plispe/gists{/gist_id}","starred_url":"https://api.github.com/users/plispe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plispe/subscriptions","organizations_url":"https://api.github.com/users/plispe/orgs","repos_url":"https://api.github.com/users/plispe/repos","events_url":"https://api.github.com/users/plispe/events{/privacy}","received_events_url":"https://api.github.com/users/plispe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plispe/goss","description":"Quick and Easy server testing/validation","fork":true,"url":"https://api.github.com/repos/plispe/goss","forks_url":"https://api.github.com/repos/plispe/goss/forks","keys_url":"https://api.github.com/repos/plispe/goss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plispe/goss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plispe/goss/teams","hooks_url":"https://api.github.com/repos/plispe/goss/hooks","issue_events_url":"https://api.github.com/repos/plispe/goss/issues/events{/number}","events_url":"https://api.github.com/repos/plispe/goss/events","assignees_url":"https://api.github.com/repos/plispe/goss/assignees{/user}","branches_url":"https://api.github.com/repos/plispe/goss/branches{/branch}","tags_url":"https://api.github.com/repos/plispe/goss/tags","blobs_url":"https://api.github.com/repos/plispe/goss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plispe/goss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plispe/goss/git/refs{/sha}","trees_url":"https://api.github.com/repos/plispe/goss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plispe/goss/statuses/{sha}","languages_url":"https://api.github.com/repos/plispe/goss/languages","stargazers_url":"https://api.github.com/repos/plispe/goss/stargazers","contributors_url":"https://api.github.com/repos/plispe/goss/contributors","subscribers_url":"https://api.github.com/repos/plispe/goss/subscribers","subscription_url":"https://api.github.com/repos/plispe/goss/subscription","commits_url":"https://api.github.com/repos/plispe/goss/commits{/sha}","git_commits_url":"https://api.github.com/repos/plispe/goss/git/commits{/sha}","comments_url":"https://api.github.com/repos/plispe/goss/comments{/number}","issue_comment_url":"https://api.github.com/repos/plispe/goss/issues/comments{/number}","contents_url":"https://api.github.com/repos/plispe/goss/contents/{+path}","compare_url":"https://api.github.com/repos/plispe/goss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plispe/goss/merges","archive_url":"https://api.github.com/repos/plispe/goss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plispe/goss/downloads","issues_url":"https://api.github.com/repos/plispe/goss/issues{/number}","pulls_url":"https://api.github.com/repos/plispe/goss/pulls{/number}","milestones_url":"https://api.github.com/repos/plispe/goss/milestones{/number}","notifications_url":"https://api.github.com/repos/plispe/goss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plispe/goss/labels{/name}","releases_url":"https://api.github.com/repos/plispe/goss/releases{/id}","deployments_url":"https://api.github.com/repos/plispe/goss/deployments","created_at":"2017-08-07T12:50:39Z","updated_at":"2017-08-07T12:50:41Z","pushed_at":"2017-08-07T14:08:48Z","git_url":"git://github.com/plispe/goss.git","ssh_url":"git@github.com:plispe/goss.git","clone_url":"https://github.com/plispe/goss.git","svn_url":"https://github.com/plispe/goss","homepage":"https://goss.rocks","size":457,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aelsabbahy:master","ref":"master","sha":"00adcc216836533cefe5573627eec95e30a6a583","user":{"login":"aelsabbahy","id":6783261,"avatar_url":"https://avatars2.githubusercontent.com/u/6783261?v=4","gravatar_id":"","url":"https://api.github.com/users/aelsabbahy","html_url":"https://github.com/aelsabbahy","followers_url":"https://api.github.com/users/aelsabbahy/followers","following_url":"https://api.github.com/users/aelsabbahy/following{/other_user}","gists_url":"https://api.github.com/users/aelsabbahy/gists{/gist_id}","starred_url":"https://api.github.com/users/aelsabbahy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelsabbahy/subscriptions","organizations_url":"https://api.github.com/users/aelsabbahy/orgs","repos_url":"https://api.github.com/users/aelsabbahy/repos","events_url":"https://api.github.com/users/aelsabbahy/events{/privacy}","received_events_url":"https://api.github.com/users/aelsabbahy/received_events","type":"User","site_admin":false},"repo":{"id":43526066,"name":"goss","full_name":"aelsabbahy/goss","owner":{"login":"aelsabbahy","id":6783261,"avatar_url":"https://avatars2.githubusercontent.com/u/6783261?v=4","gravatar_id":"","url":"https://api.github.com/users/aelsabbahy","html_url":"https://github.com/aelsabbahy","followers_url":"https://api.github.com/users/aelsabbahy/followers","following_url":"https://api.github.com/users/aelsabbahy/following{/other_user}","gists_url":"https://api.github.com/users/aelsabbahy/gists{/gist_id}","starred_url":"https://api.github.com/users/aelsabbahy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelsabbahy/subscriptions","organizations_url":"https://api.github.com/users/aelsabbahy/orgs","repos_url":"https://api.github.com/users/aelsabbahy/repos","events_url":"https://api.github.com/users/aelsabbahy/events{/privacy}","received_events_url":"https://api.github.com/users/aelsabbahy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aelsabbahy/goss","description":"Quick and Easy server testing/validation","fork":false,"url":"https://api.github.com/repos/aelsabbahy/goss","forks_url":"https://api.github.com/repos/aelsabbahy/goss/forks","keys_url":"https://api.github.com/repos/aelsabbahy/goss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aelsabbahy/goss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aelsabbahy/goss/teams","hooks_url":"https://api.github.com/repos/aelsabbahy/goss/hooks","issue_events_url":"https://api.github.com/repos/aelsabbahy/goss/issues/events{/number}","events_url":"https://api.github.com/repos/aelsabbahy/goss/events","assignees_url":"https://api.github.com/repos/aelsabbahy/goss/assignees{/user}","branches_url":"https://api.github.com/repos/aelsabbahy/goss/branches{/branch}","tags_url":"https://api.github.com/repos/aelsabbahy/goss/tags","blobs_url":"https://api.github.com/repos/aelsabbahy/goss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aelsabbahy/goss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aelsabbahy/goss/git/refs{/sha}","trees_url":"https://api.github.com/repos/aelsabbahy/goss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aelsabbahy/goss/statuses/{sha}","languages_url":"https://api.github.com/repos/aelsabbahy/goss/languages","stargazers_url":"https://api.github.com/repos/aelsabbahy/goss/stargazers","contributors_url":"https://api.github.com/repos/aelsabbahy/goss/contributors","subscribers_url":"https://api.github.com/repos/aelsabbahy/goss/subscribers","subscription_url":"https://api.github.com/repos/aelsabbahy/goss/subscription","commits_url":"https://api.github.com/repos/aelsabbahy/goss/commits{/sha}","git_commits_url":"https://api.github.com/repos/aelsabbahy/goss/git/commits{/sha}","comments_url":"https://api.github.com/repos/aelsabbahy/goss/comments{/number}","issue_comment_url":"https://api.github.com/repos/aelsabbahy/goss/issues/comments{/number}","contents_url":"https://api.github.com/repos/aelsabbahy/goss/contents/{+path}","compare_url":"https://api.github.com/repos/aelsabbahy/goss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aelsabbahy/goss/merges","archive_url":"https://api.github.com/repos/aelsabbahy/goss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aelsabbahy/goss/downloads","issues_url":"https://api.github.com/repos/aelsabbahy/goss/issues{/number}","pulls_url":"https://api.github.com/repos/aelsabbahy/goss/pulls{/number}","milestones_url":"https://api.github.com/repos/aelsabbahy/goss/milestones{/number}","notifications_url":"https://api.github.com/repos/aelsabbahy/goss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aelsabbahy/goss/labels{/name}","releases_url":"https://api.github.com/repos/aelsabbahy/goss/releases{/id}","deployments_url":"https://api.github.com/repos/aelsabbahy/goss/deployments","created_at":"2015-10-01T23:13:01Z","updated_at":"2017-08-07T07:42:06Z","pushed_at":"2017-08-07T14:14:14Z","git_url":"git://github.com/aelsabbahy/goss.git","ssh_url":"git@github.com:aelsabbahy/goss.git","clone_url":"https://github.com/aelsabbahy/goss.git","svn_url":"https://github.com/aelsabbahy/goss","homepage":"https://goss.rocks","size":457,"stargazers_count":1547,"watchers_count":1547,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":37,"forks":102,"open_issues":37,"watchers":1547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aelsabbahy/goss/pulls/271"},"html":{"href":"https://github.com/aelsabbahy/goss/pull/271"},"issue":{"href":"https://api.github.com/repos/aelsabbahy/goss/issues/271"},"comments":{"href":"https://api.github.com/repos/aelsabbahy/goss/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/aelsabbahy/goss/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/aelsabbahy/goss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aelsabbahy/goss/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/aelsabbahy/goss/statuses/f435470e48a298b294005d3c7794fb7aa816751b"}}}}
{"actor":{"display_login":"elliotweiser"}}