{"push_id":1515965821,"size":8,"distinct_size":8,"ref":"refs/heads/master","head":"ec480f1efbd2fef800b74a23628ce56cee63e0f3","before":"5843c94a9a04bbae471c3da99f5d482a65dc8b35","commits":[{"sha":"8c109ad93e97df43491402062a282d68264e298c","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"refactor spawning into ChildProcess class\n\nSummary:\nThis refactors a couple of call sites that spawn child processes to\nuse a new ChildProcess class.\n\nThis class is similar to the python subprocess class and thus also the\nfolly::Subprocess class.  It is a little different in that we're continuing to\ntarget our posix_spawn compatible approach.\n\nThe ChildProcess class makes it difficult to leak a child process and helped\nuncover a couple of bugs in the trigger command where we could forget and never\nreap a child.\n\nThe main motivation for this is enabling reading output from the child process,\nwhich is something that we'll need to do when we add more SCM integration.\n\nReviewed By: sid0\n\nDifferential Revision: D4402785\n\nfbshipit-source-id: 9ffb9bc95ba12197ac96b7d0d9f152992e68f2c7","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/8c109ad93e97df43491402062a282d68264e298c"},{"sha":"be1290a661b5fe8df4d22e0fe68a3378e45ed6b3","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"refactor main.cpp to use ChildProcess\n\nSummary: There are no longer any naked posix_spawn calls\n\nReviewed By: sid0\n\nDifferential Revision: D4402788\n\nfbshipit-source-id: e042e8113d37d27d61de56c4c81784d23f30454e","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/be1290a661b5fe8df4d22e0fe68a3378e45ed6b3"},{"sha":"60727f98758a43405eef2845229203e3d71463c2","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"refactor the launchd.plist construction\n\nSummary:\nSwitches from `fprintf` to `watchman::to<std::string>` and `fwrite` to\nbuild the string.  This helps clarify where the parameters are substituted and\nmakes the next diff much clearer.\n\nReviewed By: sid0\n\nDifferential Revision: D4417605\n\nfbshipit-source-id: b301a2f87fed891dc31485038a720227f3527bbe","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/60727f98758a43405eef2845229203e3d71463c2"},{"sha":"83dab352fd593313b35f9ee605b5cb77bfa60887","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"remove socket activation from launchd.plist\n\nSummary:\nThis will help prevent a situation like\nhttps://github.com/facebook/watchman/issues/358 from having a similar impact in\nthe future.\n\nLaunchd will still launch watchman at startup and keep it running if it falls\nover, but should get out of the way when we upgrade in the future.\n\nI'll look at adding some explicit unloading of the plist at installation time\nin the homebrew recipe.\n\nReviewed By: sid0\n\nDifferential Revision: D4417672\n\nfbshipit-source-id: b4d4597107f26f2e4e51ecd540dfb36586cfa44c","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/83dab352fd593313b35f9ee605b5cb77bfa60887"},{"sha":"be9aabefa7511d656720cbdde96553fe144f8e38","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"remove w_argv_copy_from_json\n\nSummary: This has been superseded by the ChildProcess helper.\n\nReviewed By: sid0\n\nDifferential Revision: D4418027\n\nfbshipit-source-id: 2ce5297ccebb459fea8bb1e9c093b4a12466e4cd","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/be9aabefa7511d656720cbdde96553fe144f8e38"},{"sha":"09bf45d0c919acc60ed73184e8d76b0b347306f6","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"triggers now use ChildProcess::Environment rather than envht\n\nSummary: Tidies up the code a bit and standardizes on the newer API for this stuff\n\nReviewed By: sid0\n\nDifferential Revision: D4424941\n\nfbshipit-source-id: b3f117f73120a8a551cf4cf96414d5345582f1e8","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/09bf45d0c919acc60ed73184e8d76b0b347306f6"},{"sha":"3aec455f146bdc625baec8e9f4d9074d8c0ae263","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"replace envp.cpp with ChildProcess::Environment\n\nSummary:\nThis moves the more significant portions of that code into the\nEnvironment class and removes the old source files.\n\nReviewed By: sid0\n\nDifferential Revision: D4424984\n\nfbshipit-source-id: 672aef65e0d477b7ab8fb0e3edbff2038dcc799e","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/3aec455f146bdc625baec8e9f4d9074d8c0ae263"},{"sha":"ec480f1efbd2fef800b74a23628ce56cee63e0f3","author":{"name":"Wez Furlong","email":"92e16b623bc94cc533e54a0abb2cce286874616b@fb.com"},"message":"add tests to verify capturing output from ChildProcess\n\nSummary: as above.\n\nReviewed By: sid0\n\nDifferential Revision: D4424911\n\nfbshipit-source-id: 595457173c4b21d512a18fd17c360d529e72299b","distinct":true,"url":"https://api.github.com/repos/facebook/watchman/commits/ec480f1efbd2fef800b74a23628ce56cee63e0f3"}]}
{"actor":{"display_login":"facebook-github-bot"}}