{"action":"created","comment":{"url":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/comments/126695045","pull_request_review_id":49202462,"id":126695045,"diff_hunk":"@@ -608,8 +645,17 @@ def prime_menu_items(\n             menuitem.link_page = page\n \n         # Both `Page` and `MenuItem` objects have a `relative_url` method\n-        # we can use to calculate a value for the `href` attribute.\n-        setattr(item, 'href', item.relative_url(current_site))\n+        # and a `get_full_url` method (added in Wagtail 1.11) or `full_url`","path":"wagtailmenus/templatetags/menu_tags.py","position":240,"original_position":240,"commit_id":"543a792ad4778cb28e514a3eb64f97bde0b0f90e","original_commit_id":"fc5ae35f3400b4dc1b1704bc0bf44879526d6fcf","user":{"login":"ababic","id":7779588,"avatar_url":"https://avatars3.githubusercontent.com/u/7779588?v=3","gravatar_id":"","url":"https://api.github.com/users/ababic","html_url":"https://github.com/ababic","followers_url":"https://api.github.com/users/ababic/followers","following_url":"https://api.github.com/users/ababic/following{/other_user}","gists_url":"https://api.github.com/users/ababic/gists{/gist_id}","starred_url":"https://api.github.com/users/ababic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ababic/subscriptions","organizations_url":"https://api.github.com/users/ababic/orgs","repos_url":"https://api.github.com/users/ababic/repos","events_url":"https://api.github.com/users/ababic/events{/privacy}","received_events_url":"https://api.github.com/users/ababic/received_events","type":"User","site_admin":false},"body":"Talking about `Page` and `MenuItem` objects in the same comment here is a little confusing now, as the wagtail version stuff applies to one and not the other. I think we should probably remove this all together, and replace it with two shorter comments.\r\n\r\nAnd one above what is currently at line `652`:\r\n\r\n> Pages only have `get_full_url` from Wagtail 1.11 onwards\r\n\r\nAnd one above what is currently at line `655`:\r\n\r\n> Fallback for Wagtail versions prior to 1.11","created_at":"2017-07-11T13:55:08Z","updated_at":"2017-07-11T13:55:08Z","html_url":"https://github.com/rkhleics/wagtailmenus/pull/144#discussion_r126695045","pull_request_url":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/comments/126695045"},"html":{"href":"https://github.com/rkhleics/wagtailmenus/pull/144#discussion_r126695045"},"pull_request":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144","id":129468952,"html_url":"https://github.com/rkhleics/wagtailmenus/pull/144","diff_url":"https://github.com/rkhleics/wagtailmenus/pull/144.diff","patch_url":"https://github.com/rkhleics/wagtailmenus/pull/144.patch","issue_url":"https://api.github.com/repos/rkhleics/wagtailmenus/issues/144","number":144,"state":"open","locked":false,"title":"Added option to templatetags to use the full url","user":{"login":"trumpet2012","id":6753326,"avatar_url":"https://avatars0.githubusercontent.com/u/6753326?v=3","gravatar_id":"","url":"https://api.github.com/users/trumpet2012","html_url":"https://github.com/trumpet2012","followers_url":"https://api.github.com/users/trumpet2012/followers","following_url":"https://api.github.com/users/trumpet2012/following{/other_user}","gists_url":"https://api.github.com/users/trumpet2012/gists{/gist_id}","starred_url":"https://api.github.com/users/trumpet2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trumpet2012/subscriptions","organizations_url":"https://api.github.com/users/trumpet2012/orgs","repos_url":"https://api.github.com/users/trumpet2012/repos","events_url":"https://api.github.com/users/trumpet2012/events{/privacy}","received_events_url":"https://api.github.com/users/trumpet2012/received_events","type":"User","site_admin":false},"body":"This PR is in reference to #143.\r\n\r\nI added the ability to specify at the templatetag level whether or not to use the full url when creating menu items.\r\n\r\nThis adds the ability to do: `{% main_menu use_absolute_urls=True %}`\r\n\r\n## Upgrade considerations\r\n- Signature of `get_repeated_menu_item` and `modify_submenu_items` for MenuPageMixin now includes the kwarg `use_absolute_urls`, which defaults to False. Anybody who overrode either of these methods will need to update their method signature.\r\n\r\n## TODO:\r\n- [x] Finish tests\r\n- [ ] Update changelog\r\n- [ ] Update documentation","created_at":"2017-07-07T19:08:41Z","updated_at":"2017-07-11T13:55:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d9116ee426b704d62ecd8c3da278bb22820f2f0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144/commits","review_comments_url":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144/comments","review_comment_url":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rkhleics/wagtailmenus/issues/144/comments","statuses_url":"https://api.github.com/repos/rkhleics/wagtailmenus/statuses/543a792ad4778cb28e514a3eb64f97bde0b0f90e","head":{"label":"morris-tech:absolute_url","ref":"absolute_url","sha":"543a792ad4778cb28e514a3eb64f97bde0b0f90e","user":{"login":"morris-tech","id":16800628,"avatar_url":"https://avatars3.githubusercontent.com/u/16800628?v=3","gravatar_id":"","url":"https://api.github.com/users/morris-tech","html_url":"https://github.com/morris-tech","followers_url":"https://api.github.com/users/morris-tech/followers","following_url":"https://api.github.com/users/morris-tech/following{/other_user}","gists_url":"https://api.github.com/users/morris-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-tech/subscriptions","organizations_url":"https://api.github.com/users/morris-tech/orgs","repos_url":"https://api.github.com/users/morris-tech/repos","events_url":"https://api.github.com/users/morris-tech/events{/privacy}","received_events_url":"https://api.github.com/users/morris-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":96466497,"name":"wagtailmenus","full_name":"morris-tech/wagtailmenus","owner":{"login":"morris-tech","id":16800628,"avatar_url":"https://avatars3.githubusercontent.com/u/16800628?v=3","gravatar_id":"","url":"https://api.github.com/users/morris-tech","html_url":"https://github.com/morris-tech","followers_url":"https://api.github.com/users/morris-tech/followers","following_url":"https://api.github.com/users/morris-tech/following{/other_user}","gists_url":"https://api.github.com/users/morris-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-tech/subscriptions","organizations_url":"https://api.github.com/users/morris-tech/orgs","repos_url":"https://api.github.com/users/morris-tech/repos","events_url":"https://api.github.com/users/morris-tech/events{/privacy}","received_events_url":"https://api.github.com/users/morris-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/morris-tech/wagtailmenus","description":"An app to help you manage and render menus in your Wagtail projects more effectively","fork":true,"url":"https://api.github.com/repos/morris-tech/wagtailmenus","forks_url":"https://api.github.com/repos/morris-tech/wagtailmenus/forks","keys_url":"https://api.github.com/repos/morris-tech/wagtailmenus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morris-tech/wagtailmenus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morris-tech/wagtailmenus/teams","hooks_url":"https://api.github.com/repos/morris-tech/wagtailmenus/hooks","issue_events_url":"https://api.github.com/repos/morris-tech/wagtailmenus/issues/events{/number}","events_url":"https://api.github.com/repos/morris-tech/wagtailmenus/events","assignees_url":"https://api.github.com/repos/morris-tech/wagtailmenus/assignees{/user}","branches_url":"https://api.github.com/repos/morris-tech/wagtailmenus/branches{/branch}","tags_url":"https://api.github.com/repos/morris-tech/wagtailmenus/tags","blobs_url":"https://api.github.com/repos/morris-tech/wagtailmenus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morris-tech/wagtailmenus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morris-tech/wagtailmenus/git/refs{/sha}","trees_url":"https://api.github.com/repos/morris-tech/wagtailmenus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morris-tech/wagtailmenus/statuses/{sha}","languages_url":"https://api.github.com/repos/morris-tech/wagtailmenus/languages","stargazers_url":"https://api.github.com/repos/morris-tech/wagtailmenus/stargazers","contributors_url":"https://api.github.com/repos/morris-tech/wagtailmenus/contributors","subscribers_url":"https://api.github.com/repos/morris-tech/wagtailmenus/subscribers","subscription_url":"https://api.github.com/repos/morris-tech/wagtailmenus/subscription","commits_url":"https://api.github.com/repos/morris-tech/wagtailmenus/commits{/sha}","git_commits_url":"https://api.github.com/repos/morris-tech/wagtailmenus/git/commits{/sha}","comments_url":"https://api.github.com/repos/morris-tech/wagtailmenus/comments{/number}","issue_comment_url":"https://api.github.com/repos/morris-tech/wagtailmenus/issues/comments{/number}","contents_url":"https://api.github.com/repos/morris-tech/wagtailmenus/contents/{+path}","compare_url":"https://api.github.com/repos/morris-tech/wagtailmenus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morris-tech/wagtailmenus/merges","archive_url":"https://api.github.com/repos/morris-tech/wagtailmenus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morris-tech/wagtailmenus/downloads","issues_url":"https://api.github.com/repos/morris-tech/wagtailmenus/issues{/number}","pulls_url":"https://api.github.com/repos/morris-tech/wagtailmenus/pulls{/number}","milestones_url":"https://api.github.com/repos/morris-tech/wagtailmenus/milestones{/number}","notifications_url":"https://api.github.com/repos/morris-tech/wagtailmenus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morris-tech/wagtailmenus/labels{/name}","releases_url":"https://api.github.com/repos/morris-tech/wagtailmenus/releases{/id}","deployments_url":"https://api.github.com/repos/morris-tech/wagtailmenus/deployments","created_at":"2017-07-06T19:48:09Z","updated_at":"2017-07-06T19:48:11Z","pushed_at":"2017-07-11T13:42:11Z","git_url":"git://github.com/morris-tech/wagtailmenus.git","ssh_url":"git@github.com:morris-tech/wagtailmenus.git","clone_url":"https://github.com/morris-tech/wagtailmenus.git","svn_url":"https://github.com/morris-tech/wagtailmenus","homepage":"","size":2661,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rkhleics:master","ref":"master","sha":"a8d9cca63bee122d174d2113e56a787df9f9cef9","user":{"login":"rkhleics","id":5148147,"avatar_url":"https://avatars3.githubusercontent.com/u/5148147?v=3","gravatar_id":"","url":"https://api.github.com/users/rkhleics","html_url":"https://github.com/rkhleics","followers_url":"https://api.github.com/users/rkhleics/followers","following_url":"https://api.github.com/users/rkhleics/following{/other_user}","gists_url":"https://api.github.com/users/rkhleics/gists{/gist_id}","starred_url":"https://api.github.com/users/rkhleics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkhleics/subscriptions","organizations_url":"https://api.github.com/users/rkhleics/orgs","repos_url":"https://api.github.com/users/rkhleics/repos","events_url":"https://api.github.com/users/rkhleics/events{/privacy}","received_events_url":"https://api.github.com/users/rkhleics/received_events","type":"Organization","site_admin":false},"repo":{"id":50591665,"name":"wagtailmenus","full_name":"rkhleics/wagtailmenus","owner":{"login":"rkhleics","id":5148147,"avatar_url":"https://avatars3.githubusercontent.com/u/5148147?v=3","gravatar_id":"","url":"https://api.github.com/users/rkhleics","html_url":"https://github.com/rkhleics","followers_url":"https://api.github.com/users/rkhleics/followers","following_url":"https://api.github.com/users/rkhleics/following{/other_user}","gists_url":"https://api.github.com/users/rkhleics/gists{/gist_id}","starred_url":"https://api.github.com/users/rkhleics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkhleics/subscriptions","organizations_url":"https://api.github.com/users/rkhleics/orgs","repos_url":"https://api.github.com/users/rkhleics/repos","events_url":"https://api.github.com/users/rkhleics/events{/privacy}","received_events_url":"https://api.github.com/users/rkhleics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rkhleics/wagtailmenus","description":"An app to help you manage and render menus in your Wagtail projects more effectively","fork":false,"url":"https://api.github.com/repos/rkhleics/wagtailmenus","forks_url":"https://api.github.com/repos/rkhleics/wagtailmenus/forks","keys_url":"https://api.github.com/repos/rkhleics/wagtailmenus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rkhleics/wagtailmenus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rkhleics/wagtailmenus/teams","hooks_url":"https://api.github.com/repos/rkhleics/wagtailmenus/hooks","issue_events_url":"https://api.github.com/repos/rkhleics/wagtailmenus/issues/events{/number}","events_url":"https://api.github.com/repos/rkhleics/wagtailmenus/events","assignees_url":"https://api.github.com/repos/rkhleics/wagtailmenus/assignees{/user}","branches_url":"https://api.github.com/repos/rkhleics/wagtailmenus/branches{/branch}","tags_url":"https://api.github.com/repos/rkhleics/wagtailmenus/tags","blobs_url":"https://api.github.com/repos/rkhleics/wagtailmenus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rkhleics/wagtailmenus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rkhleics/wagtailmenus/git/refs{/sha}","trees_url":"https://api.github.com/repos/rkhleics/wagtailmenus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rkhleics/wagtailmenus/statuses/{sha}","languages_url":"https://api.github.com/repos/rkhleics/wagtailmenus/languages","stargazers_url":"https://api.github.com/repos/rkhleics/wagtailmenus/stargazers","contributors_url":"https://api.github.com/repos/rkhleics/wagtailmenus/contributors","subscribers_url":"https://api.github.com/repos/rkhleics/wagtailmenus/subscribers","subscription_url":"https://api.github.com/repos/rkhleics/wagtailmenus/subscription","commits_url":"https://api.github.com/repos/rkhleics/wagtailmenus/commits{/sha}","git_commits_url":"https://api.github.com/repos/rkhleics/wagtailmenus/git/commits{/sha}","comments_url":"https://api.github.com/repos/rkhleics/wagtailmenus/comments{/number}","issue_comment_url":"https://api.github.com/repos/rkhleics/wagtailmenus/issues/comments{/number}","contents_url":"https://api.github.com/repos/rkhleics/wagtailmenus/contents/{+path}","compare_url":"https://api.github.com/repos/rkhleics/wagtailmenus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rkhleics/wagtailmenus/merges","archive_url":"https://api.github.com/repos/rkhleics/wagtailmenus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rkhleics/wagtailmenus/downloads","issues_url":"https://api.github.com/repos/rkhleics/wagtailmenus/issues{/number}","pulls_url":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls{/number}","milestones_url":"https://api.github.com/repos/rkhleics/wagtailmenus/milestones{/number}","notifications_url":"https://api.github.com/repos/rkhleics/wagtailmenus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rkhleics/wagtailmenus/labels{/name}","releases_url":"https://api.github.com/repos/rkhleics/wagtailmenus/releases{/id}","deployments_url":"https://api.github.com/repos/rkhleics/wagtailmenus/deployments","created_at":"2016-01-28T15:19:08Z","updated_at":"2017-07-07T06:35:09Z","pushed_at":"2017-07-11T13:42:12Z","git_url":"git://github.com/rkhleics/wagtailmenus.git","ssh_url":"git@github.com:rkhleics/wagtailmenus.git","clone_url":"https://github.com/rkhleics/wagtailmenus.git","svn_url":"https://github.com/rkhleics/wagtailmenus","homepage":"","size":2630,"stargazers_count":104,"watchers_count":104,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":6,"forks":28,"open_issues":6,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144"},"html":{"href":"https://github.com/rkhleics/wagtailmenus/pull/144"},"issue":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/issues/144"},"comments":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/rkhleics/wagtailmenus/statuses/543a792ad4778cb28e514a3eb64f97bde0b0f90e"}}}}
{"actor":{"display_login":"ababic"}}