{"action":"created","comment":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments/144629672","pull_request_review_id":69316972,"id":144629672,"diff_hunk":"@@ -155,6 +207,37 @@ export default Component.extend({\n       })\n     }\n \n+    const componentKeyNamesForTypes = this.get('componentKeyNamesForTypes')","path":"addon/components/frost-list.js","position":84,"original_position":86,"commit_id":"d648c84ec7f0cab0bfd19a19f3ce4a6aee4f0c89","original_commit_id":"76ff39d1448a874cf946b7963f91e1f07e5ca713","user":{"login":"dafortin","id":18552536,"avatar_url":"https://avatars1.githubusercontent.com/u/18552536?v=4","gravatar_id":"","url":"https://api.github.com/users/dafortin","html_url":"https://github.com/dafortin","followers_url":"https://api.github.com/users/dafortin/followers","following_url":"https://api.github.com/users/dafortin/following{/other_user}","gists_url":"https://api.github.com/users/dafortin/gists{/gist_id}","starred_url":"https://api.github.com/users/dafortin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafortin/subscriptions","organizations_url":"https://api.github.com/users/dafortin/orgs","repos_url":"https://api.github.com/users/dafortin/repos","events_url":"https://api.github.com/users/dafortin/events{/privacy}","received_events_url":"https://api.github.com/users/dafortin/received_events","type":"User","site_admin":false},"body":"Did you handle this?","created_at":"2017-10-13T18:42:13Z","updated_at":"2017-10-13T18:42:13Z","html_url":"https://github.com/ciena-frost/ember-frost-list/pull/148#discussion_r144629672","pull_request_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments/144629672"},"html":{"href":"https://github.com/ciena-frost/ember-frost-list/pull/148#discussion_r144629672"},"pull_request":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148"}},"in_reply_to_id":144447234},"pull_request":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148","id":145004721,"html_url":"https://github.com/ciena-frost/ember-frost-list/pull/148","diff_url":"https://github.com/ciena-frost/ember-frost-list/pull/148.diff","patch_url":"https://github.com/ciena-frost/ember-frost-list/pull/148.patch","issue_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/148","number":148,"state":"open","locked":false,"title":"List item types","user":{"login":"jscharf","id":1317293,"avatar_url":"https://avatars3.githubusercontent.com/u/1317293?v=4","gravatar_id":"","url":"https://api.github.com/users/jscharf","html_url":"https://github.com/jscharf","followers_url":"https://api.github.com/users/jscharf/followers","following_url":"https://api.github.com/users/jscharf/following{/other_user}","gists_url":"https://api.github.com/users/jscharf/gists{/gist_id}","starred_url":"https://api.github.com/users/jscharf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscharf/subscriptions","organizations_url":"https://api.github.com/users/jscharf/orgs","repos_url":"https://api.github.com/users/jscharf/repos","events_url":"https://api.github.com/users/jscharf/events{/privacy}","received_events_url":"https://api.github.com/users/jscharf/received_events","type":"User","site_admin":false},"body":"### This project uses [semver](semver.org), please check the scope of this pr:\r\n\r\n- [ ] #none# - documentation fixes and/or test additions\r\n- [ ] #patch# - backwards-compatible bug fix\r\n- [ ] #minor# - adding functionality in a backwards-compatible manner\r\n- [x] #major# - incompatible API change\r\n\r\n# CHANGELOG\r\n\r\n* Added a new frost-list-item-content component\r\n* Added support for rendering different list-item and list-item-expansion components based on a set of types via new `itemTypes` property\r\n* Added support for rendering different controls based on list-item type\r\n* Added support for consumer-defined list-item type via new `itemTypeKey` property\r\n* Added a warning if consumer defines `itemTypeKey` property but not `itemKey` property\r\n* Changed hook from `-item` to `-itemContent-item` for list-item component\r\n* Changed hook from `-expansion` to `-itemContent-expansion` for frost-list-item-expansion component\r\n* Changed hook from `-selection` to `-itemContent-selection` for frost-list-item-selection component\r\n* Changed hook from `-item-container` to `-itemContent-item-container` for frost-list-item-container DOM element\r\n* Changed hook from `-item` to `-itemExpansion` for list-item-expansion component","created_at":"2017-10-05T19:48:36Z","updated_at":"2017-10-13T18:42:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ae453ef404823a2d65ce99e47c6182cb80b8de9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rox163","id":313318,"avatar_url":"https://avatars1.githubusercontent.com/u/313318?v=4","gravatar_id":"","url":"https://api.github.com/users/rox163","html_url":"https://github.com/rox163","followers_url":"https://api.github.com/users/rox163/followers","following_url":"https://api.github.com/users/rox163/following{/other_user}","gists_url":"https://api.github.com/users/rox163/gists{/gist_id}","starred_url":"https://api.github.com/users/rox163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rox163/subscriptions","organizations_url":"https://api.github.com/users/rox163/orgs","repos_url":"https://api.github.com/users/rox163/repos","events_url":"https://api.github.com/users/rox163/events{/privacy}","received_events_url":"https://api.github.com/users/rox163/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148/commits","review_comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148/comments","review_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/148/comments","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/statuses/d648c84ec7f0cab0bfd19a19f3ce4a6aee4f0c89","head":{"label":"jscharf:list-item-types","ref":"list-item-types","sha":"d648c84ec7f0cab0bfd19a19f3ce4a6aee4f0c89","user":{"login":"jscharf","id":1317293,"avatar_url":"https://avatars3.githubusercontent.com/u/1317293?v=4","gravatar_id":"","url":"https://api.github.com/users/jscharf","html_url":"https://github.com/jscharf","followers_url":"https://api.github.com/users/jscharf/followers","following_url":"https://api.github.com/users/jscharf/following{/other_user}","gists_url":"https://api.github.com/users/jscharf/gists{/gist_id}","starred_url":"https://api.github.com/users/jscharf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscharf/subscriptions","organizations_url":"https://api.github.com/users/jscharf/orgs","repos_url":"https://api.github.com/users/jscharf/repos","events_url":"https://api.github.com/users/jscharf/events{/privacy}","received_events_url":"https://api.github.com/users/jscharf/received_events","type":"User","site_admin":false},"repo":{"id":103690007,"name":"ember-frost-list","full_name":"jscharf/ember-frost-list","owner":{"login":"jscharf","id":1317293,"avatar_url":"https://avatars3.githubusercontent.com/u/1317293?v=4","gravatar_id":"","url":"https://api.github.com/users/jscharf","html_url":"https://github.com/jscharf","followers_url":"https://api.github.com/users/jscharf/followers","following_url":"https://api.github.com/users/jscharf/following{/other_user}","gists_url":"https://api.github.com/users/jscharf/gists{/gist_id}","starred_url":"https://api.github.com/users/jscharf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscharf/subscriptions","organizations_url":"https://api.github.com/users/jscharf/orgs","repos_url":"https://api.github.com/users/jscharf/repos","events_url":"https://api.github.com/users/jscharf/events{/privacy}","received_events_url":"https://api.github.com/users/jscharf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jscharf/ember-frost-list","description":"Breakin' down table-centric application views","fork":true,"url":"https://api.github.com/repos/jscharf/ember-frost-list","forks_url":"https://api.github.com/repos/jscharf/ember-frost-list/forks","keys_url":"https://api.github.com/repos/jscharf/ember-frost-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jscharf/ember-frost-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jscharf/ember-frost-list/teams","hooks_url":"https://api.github.com/repos/jscharf/ember-frost-list/hooks","issue_events_url":"https://api.github.com/repos/jscharf/ember-frost-list/issues/events{/number}","events_url":"https://api.github.com/repos/jscharf/ember-frost-list/events","assignees_url":"https://api.github.com/repos/jscharf/ember-frost-list/assignees{/user}","branches_url":"https://api.github.com/repos/jscharf/ember-frost-list/branches{/branch}","tags_url":"https://api.github.com/repos/jscharf/ember-frost-list/tags","blobs_url":"https://api.github.com/repos/jscharf/ember-frost-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jscharf/ember-frost-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jscharf/ember-frost-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/jscharf/ember-frost-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jscharf/ember-frost-list/statuses/{sha}","languages_url":"https://api.github.com/repos/jscharf/ember-frost-list/languages","stargazers_url":"https://api.github.com/repos/jscharf/ember-frost-list/stargazers","contributors_url":"https://api.github.com/repos/jscharf/ember-frost-list/contributors","subscribers_url":"https://api.github.com/repos/jscharf/ember-frost-list/subscribers","subscription_url":"https://api.github.com/repos/jscharf/ember-frost-list/subscription","commits_url":"https://api.github.com/repos/jscharf/ember-frost-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/jscharf/ember-frost-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/jscharf/ember-frost-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/jscharf/ember-frost-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/jscharf/ember-frost-list/contents/{+path}","compare_url":"https://api.github.com/repos/jscharf/ember-frost-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jscharf/ember-frost-list/merges","archive_url":"https://api.github.com/repos/jscharf/ember-frost-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jscharf/ember-frost-list/downloads","issues_url":"https://api.github.com/repos/jscharf/ember-frost-list/issues{/number}","pulls_url":"https://api.github.com/repos/jscharf/ember-frost-list/pulls{/number}","milestones_url":"https://api.github.com/repos/jscharf/ember-frost-list/milestones{/number}","notifications_url":"https://api.github.com/repos/jscharf/ember-frost-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jscharf/ember-frost-list/labels{/name}","releases_url":"https://api.github.com/repos/jscharf/ember-frost-list/releases{/id}","deployments_url":"https://api.github.com/repos/jscharf/ember-frost-list/deployments","created_at":"2017-09-15T18:41:37Z","updated_at":"2017-09-15T18:41:39Z","pushed_at":"2017-10-13T15:22:55Z","git_url":"git://github.com/jscharf/ember-frost-list.git","ssh_url":"git@github.com:jscharf/ember-frost-list.git","clone_url":"https://github.com/jscharf/ember-frost-list.git","svn_url":"https://github.com/jscharf/ember-frost-list","homepage":"http://ciena-frost.github.io/ember-frost-list","size":9311,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciena-frost:master","ref":"master","sha":"679785807c9512df6e7e1940300215e653d5a491","user":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars2.githubusercontent.com/u/16601148?v=4","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"repo":{"id":51887742,"name":"ember-frost-list","full_name":"ciena-frost/ember-frost-list","owner":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars2.githubusercontent.com/u/16601148?v=4","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciena-frost/ember-frost-list","description":"Breakin' down table-centric application views","fork":false,"url":"https://api.github.com/repos/ciena-frost/ember-frost-list","forks_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/forks","keys_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/teams","hooks_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/hooks","issue_events_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/events{/number}","events_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/events","assignees_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/assignees{/user}","branches_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/branches{/branch}","tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/tags","blobs_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/statuses/{sha}","languages_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/languages","stargazers_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/stargazers","contributors_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/contributors","subscribers_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/subscribers","subscription_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/subscription","commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/contents/{+path}","compare_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/merges","archive_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/downloads","issues_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues{/number}","pulls_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls{/number}","milestones_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/milestones{/number}","notifications_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/labels{/name}","releases_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/releases{/id}","deployments_url":"https://api.github.com/repos/ciena-frost/ember-frost-list/deployments","created_at":"2016-02-17T02:28:53Z","updated_at":"2017-10-12T07:38:17Z","pushed_at":"2017-10-13T15:22:57Z","git_url":"git://github.com/ciena-frost/ember-frost-list.git","ssh_url":"git@github.com:ciena-frost/ember-frost-list.git","clone_url":"https://github.com/ciena-frost/ember-frost-list.git","svn_url":"https://github.com/ciena-frost/ember-frost-list","homepage":"http://ciena-frost.github.io/ember-frost-list","size":9247,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":20,"forks":23,"open_issues":20,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148"},"html":{"href":"https://github.com/ciena-frost/ember-frost-list/pull/148"},"issue":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/148"},"comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-list/statuses/d648c84ec7f0cab0bfd19a19f3ce4a6aee4f0c89"}},"author_association":"NONE"}}
{"actor":{"display_login":"dafortin"}}