{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4895","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4895/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4895/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4895/events","html_url":"https://github.com/RobotLocomotion/drake/pull/4895","id":202982822,"number":4895,"title":"Port drake/solvers to use drake_copyable","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sammy-tri","id":17596504,"avatar_url":"https://avatars.githubusercontent.com/u/17596504?v=3","gravatar_id":"","url":"https://api.github.com/users/sammy-tri","html_url":"https://github.com/sammy-tri","followers_url":"https://api.github.com/users/sammy-tri/followers","following_url":"https://api.github.com/users/sammy-tri/following{/other_user}","gists_url":"https://api.github.com/users/sammy-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/sammy-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammy-tri/subscriptions","organizations_url":"https://api.github.com/users/sammy-tri/orgs","repos_url":"https://api.github.com/users/sammy-tri/repos","events_url":"https://api.github.com/users/sammy-tri/events{/privacy}","received_events_url":"https://api.github.com/users/sammy-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"sammy-tri","id":17596504,"avatar_url":"https://avatars.githubusercontent.com/u/17596504?v=3","gravatar_id":"","url":"https://api.github.com/users/sammy-tri","html_url":"https://github.com/sammy-tri","followers_url":"https://api.github.com/users/sammy-tri/followers","following_url":"https://api.github.com/users/sammy-tri/following{/other_user}","gists_url":"https://api.github.com/users/sammy-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/sammy-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammy-tri/subscriptions","organizations_url":"https://api.github.com/users/sammy-tri/orgs","repos_url":"https://api.github.com/users/sammy-tri/repos","events_url":"https://api.github.com/users/sammy-tri/events{/privacy}","received_events_url":"https://api.github.com/users/sammy-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-01-25T00:42:37Z","updated_at":"2017-01-25T15:36:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4895","html_url":"https://github.com/RobotLocomotion/drake/pull/4895","diff_url":"https://github.com/RobotLocomotion/drake/pull/4895.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/4895.patch"},"body":"A portion of #4861.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/4895)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/275140782","html_url":"https://github.com/RobotLocomotion/drake/pull/4895#issuecomment-275140782","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4895","id":275140782,"user":{"login":"soonho-tri","id":20779767,"avatar_url":"https://avatars.githubusercontent.com/u/20779767?v=3","gravatar_id":"","url":"https://api.github.com/users/soonho-tri","html_url":"https://github.com/soonho-tri","followers_url":"https://api.github.com/users/soonho-tri/followers","following_url":"https://api.github.com/users/soonho-tri/following{/other_user}","gists_url":"https://api.github.com/users/soonho-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/soonho-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonho-tri/subscriptions","organizations_url":"https://api.github.com/users/soonho-tri/orgs","repos_url":"https://api.github.com/users/soonho-tri/repos","events_url":"https://api.github.com/users/soonho-tri/events{/privacy}","received_events_url":"https://api.github.com/users/soonho-tri/received_events","type":"User","site_admin":false},"created_at":"2017-01-25T15:36:48Z","updated_at":"2017-01-25T15:36:48Z","body":"\n\n\n\nReviewed 17 of 17 files at r1.\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[drake/solvers/mathematical_program.h, line 20 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/4895#-KbLDYLXaJlUQmacM-lm:-KbLDYLYgwAHTJDR3ZMP:b-i13v8a) ([raw file](https://github.com/robotlocomotion/drake/blob/eef616d67eeb2ee85f1bb0e388a1d069473cb2c5/drake/solvers/mathematical_program.h#L20)):*\n> ```objc\n> #include \"drake/common/drake_assert.h\"\n> #include \"drake/common/eigen_autodiff_types.h\"\n> #include \"drake/common/drake_copyable.h\"\n> ```\n\nFYI, this section is not sorted.\n\n---\n\n*[drake/solvers/mathematical_program.h, line 190 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/4895#-KbLDnQ5SxLdaAWxTcGQ:-KbLDnQ5SxLdaAWxTcGR:b-9maksg) ([raw file](https://github.com/robotlocomotion/drake/blob/eef616d67eeb2ee85f1bb0e388a1d069473cb2c5/drake/solvers/mathematical_program.h#L190)):*\n> ```objc\n> \n>    public:\n>     DRAKE_NO_COPY_NO_MOVE_NO_ASSIGN(ConstraintImpl)\n> ```\n\nFirst of all, this looks perfectly fine to me. I have a non-blocking question for learning.\n\nHere its base class `Constraint` has `DRAKE_NO_COPY_NO_MOVE_NO_ASSIGN`. Does that fact still leave any choice for this derived class `ConstraintImpl`? In other words, is this line more about explicitly documenting the status or actually constraining this class?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/4895)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"soonho-tri"}}