{"action":"created","comment":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/149801738","pull_request_review_id":75255335,"id":149801738,"diff_hunk":"@@ -41,7 +41,7 @@\n         '',\n         $_POST['last_name'],\n         array_keys($acls),\n-        null,\n+        ROLE_ID_USER,","path":"html/controllers/user_admin/create_user.php","position":5,"original_position":5,"commit_id":"26563f785e02cdacc47fa2245347cc11151b8e7e","original_commit_id":"26563f785e02cdacc47fa2245347cc11151b8e7e","user":{"login":"jpwhite4","id":5342179,"avatar_url":"https://avatars2.githubusercontent.com/u/5342179?v=4","gravatar_id":"","url":"https://api.github.com/users/jpwhite4","html_url":"https://github.com/jpwhite4","followers_url":"https://api.github.com/users/jpwhite4/followers","following_url":"https://api.github.com/users/jpwhite4/following{/other_user}","gists_url":"https://api.github.com/users/jpwhite4/gists{/gist_id}","starred_url":"https://api.github.com/users/jpwhite4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpwhite4/subscriptions","organizations_url":"https://api.github.com/users/jpwhite4/orgs","repos_url":"https://api.github.com/users/jpwhite4/repos","events_url":"https://api.github.com/users/jpwhite4/events{/privacy}","received_events_url":"https://api.github.com/users/jpwhite4/received_events","type":"User","site_admin":false},"body":"What happens if you create a user account that does not have the \"usr\" role? This would happen if you do not check the \"User\" check box in the internal dashboard GUI.","created_at":"2017-11-08T21:28:17Z","updated_at":"2017-11-08T21:28:17Z","html_url":"https://github.com/ubccr/xdmod/pull/325#discussion_r149801738","pull_request_url":"https://api.github.com/repos/ubccr/xdmod/pulls/325","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/149801738"},"html":{"href":"https://github.com/ubccr/xdmod/pull/325#discussion_r149801738"},"pull_request":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/325"}}},"pull_request":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/325","id":151421302,"html_url":"https://github.com/ubccr/xdmod/pull/325","diff_url":"https://github.com/ubccr/xdmod/pull/325.diff","patch_url":"https://github.com/ubccr/xdmod/pull/325.patch","issue_url":"https://api.github.com/repos/ubccr/xdmod/issues/325","number":325,"state":"open","locked":false,"title":"XDUser Construction: Primary Role","user":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"body":"\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n- A slight change that modifies XDUser so that during construction it honors the\r\n  `primary_role` parameter which is used to populate the `activeRole` property.\r\n- Updated the create_user.php to take this change into account ( it now provides\r\n  ROLE_ID_USER )\r\n\r\n\r\n## Motivation and Context\r\nEnsure that current uses of XDUser::_construct do not break and behave as intended.\r\n\r\n## Tests performed\r\nAdded a component test to ensure we test for the desired behavior implemented by this change.\r\n- i.e. that the primaryRole supplied during XDUser construction is taken into consideration when retrieving / populating the activeRole. \r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project as found in the **CONTRIBUTING** document.\r\n- [X] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n","created_at":"2017-11-08T15:57:10Z","updated_at":"2017-11-08T21:28:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9898c23dfb972875e5d5f78214e7fe0d28c1c082","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ubccr/xdmod/pulls/325/commits","review_comments_url":"https://api.github.com/repos/ubccr/xdmod/pulls/325/comments","review_comment_url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubccr/xdmod/issues/325/comments","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/26563f785e02cdacc47fa2245347cc11151b8e7e","head":{"label":"ryanrath:xduser_primary_role","ref":"xduser_primary_role","sha":"26563f785e02cdacc47fa2245347cc11151b8e7e","user":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"repo":{"id":77923709,"name":"xdmod","full_name":"ryanrath/xdmod","owner":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars2.githubusercontent.com/u/10520715?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanrath/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":true,"url":"https://api.github.com/repos/ryanrath/xdmod","forks_url":"https://api.github.com/repos/ryanrath/xdmod/forks","keys_url":"https://api.github.com/repos/ryanrath/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanrath/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanrath/xdmod/teams","hooks_url":"https://api.github.com/repos/ryanrath/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ryanrath/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ryanrath/xdmod/events","assignees_url":"https://api.github.com/repos/ryanrath/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ryanrath/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ryanrath/xdmod/tags","blobs_url":"https://api.github.com/repos/ryanrath/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanrath/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanrath/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanrath/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanrath/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanrath/xdmod/languages","stargazers_url":"https://api.github.com/repos/ryanrath/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ryanrath/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ryanrath/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ryanrath/xdmod/subscription","commits_url":"https://api.github.com/repos/ryanrath/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanrath/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanrath/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanrath/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanrath/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ryanrath/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanrath/xdmod/merges","archive_url":"https://api.github.com/repos/ryanrath/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanrath/xdmod/downloads","issues_url":"https://api.github.com/repos/ryanrath/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ryanrath/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanrath/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanrath/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanrath/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ryanrath/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ryanrath/xdmod/deployments","created_at":"2017-01-03T14:23:30Z","updated_at":"2017-01-03T14:23:34Z","pushed_at":"2017-11-08T19:57:25Z","git_url":"git://github.com/ryanrath/xdmod.git","ssh_url":"git@github.com:ryanrath/xdmod.git","clone_url":"https://github.com/ryanrath/xdmod.git","svn_url":"https://github.com/ryanrath/xdmod","homepage":"http://open.xdmod.org","size":6344,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"xdmod6.5"}},"base":{"label":"ubccr:xdmod7.1","ref":"xdmod7.1","sha":"a37a2e06ca512b4028591333677440d888271f4c","user":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"repo":{"id":72233032,"name":"xdmod","full_name":"ubccr/xdmod","owner":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars2.githubusercontent.com/u/2301947?v=4","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubccr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":false,"url":"https://api.github.com/repos/ubccr/xdmod","forks_url":"https://api.github.com/repos/ubccr/xdmod/forks","keys_url":"https://api.github.com/repos/ubccr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubccr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubccr/xdmod/teams","hooks_url":"https://api.github.com/repos/ubccr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ubccr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ubccr/xdmod/events","assignees_url":"https://api.github.com/repos/ubccr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ubccr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ubccr/xdmod/tags","blobs_url":"https://api.github.com/repos/ubccr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubccr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubccr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubccr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ubccr/xdmod/languages","stargazers_url":"https://api.github.com/repos/ubccr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ubccr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ubccr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ubccr/xdmod/subscription","commits_url":"https://api.github.com/repos/ubccr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubccr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubccr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubccr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubccr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ubccr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubccr/xdmod/merges","archive_url":"https://api.github.com/repos/ubccr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubccr/xdmod/downloads","issues_url":"https://api.github.com/repos/ubccr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ubccr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ubccr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ubccr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubccr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ubccr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ubccr/xdmod/deployments","created_at":"2016-10-28T18:41:25Z","updated_at":"2017-10-27T18:24:39Z","pushed_at":"2017-11-08T19:43:45Z","git_url":"git://github.com/ubccr/xdmod.git","ssh_url":"git@github.com:ubccr/xdmod.git","clone_url":"https://github.com/ubccr/xdmod.git","svn_url":"https://github.com/ubccr/xdmod","homepage":"http://open.xdmod.org","size":5711,"stargazers_count":20,"watchers_count":20,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":10,"forks":20,"open_issues":10,"watchers":20,"default_branch":"xdmod7.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/325"},"html":{"href":"https://github.com/ubccr/xdmod/pull/325"},"issue":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/325"},"comments":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/ubccr/xdmod/statuses/26563f785e02cdacc47fa2245347cc11151b8e7e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jpwhite4"}}