{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/integrations-core/issues/509","repository_url":"https://api.github.com/repos/DataDog/integrations-core","labels_url":"https://api.github.com/repos/DataDog/integrations-core/issues/509/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/issues/509/comments","events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/509/events","html_url":"https://github.com/DataDog/integrations-core/pull/509","id":239571714,"number":509,"title":"add Kubernetes Container name to tags","user":{"login":"sophaskins","id":6773143,"avatar_url":"https://avatars2.githubusercontent.com/u/6773143?v=3","gravatar_id":"","url":"https://api.github.com/users/sophaskins","html_url":"https://github.com/sophaskins","followers_url":"https://api.github.com/users/sophaskins/followers","following_url":"https://api.github.com/users/sophaskins/following{/other_user}","gists_url":"https://api.github.com/users/sophaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/sophaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophaskins/subscriptions","organizations_url":"https://api.github.com/users/sophaskins/orgs","repos_url":"https://api.github.com/users/sophaskins/repos","events_url":"https://api.github.com/users/sophaskins/events{/privacy}","received_events_url":"https://api.github.com/users/sophaskins/received_events","type":"User","site_admin":true},"labels":[{"id":563229400,"url":"https://api.github.com/repos/DataDog/integrations-core/labels/community","name":"community","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-06-29T18:30:19Z","updated_at":"2017-07-01T00:39:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/509","html_url":"https://github.com/DataDog/integrations-core/pull/509","diff_url":"https://github.com/DataDog/integrations-core/pull/509.diff","patch_url":"https://github.com/DataDog/integrations-core/pull/509.patch"},"body":"### What does this PR do?\r\n\r\nThis PR adds a tag to `docker_daemon` and `kubernetes` metrics `pod_container_name` that takes the name of the Kubernetes Container resource corresponding to the container in question. This is kinda subtle (I'd love some feedback on naming / good ways to document something like this) - the *name* of a Container resource https://kubernetes.io/docs/api-reference/v1.6/#container-v1-core, not the actual Docker name of the container (which is already covered in `container_name`)\r\n\r\n### Motivation\r\n\r\nBecause some stats are reported on a per-container basis, being able to easily select data using the same names that are in a Pod manifest is useful.\r\n\r\n### Testing Guidelines\r\n\r\nNotably, I haven't been able to get the `docker_daemon` check's tests working locally (on either OSX or Linux), so I'm hoping that the CI system tells me if I missed anything 😄 \r\n\r\n\r\nThis PR has a corresponding change to `dd-agent`'s `kubeutil.py` to have the `CONTAINER_NAME_LABEL` constant - submitting that separately."},"comment":{"url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments/312399616","html_url":"https://github.com/DataDog/integrations-core/pull/509#issuecomment-312399616","issue_url":"https://api.github.com/repos/DataDog/integrations-core/issues/509","id":312399616,"user":{"login":"irabinovitch","id":289654,"avatar_url":"https://avatars3.githubusercontent.com/u/289654?v=3","gravatar_id":"","url":"https://api.github.com/users/irabinovitch","html_url":"https://github.com/irabinovitch","followers_url":"https://api.github.com/users/irabinovitch/followers","following_url":"https://api.github.com/users/irabinovitch/following{/other_user}","gists_url":"https://api.github.com/users/irabinovitch/gists{/gist_id}","starred_url":"https://api.github.com/users/irabinovitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irabinovitch/subscriptions","organizations_url":"https://api.github.com/users/irabinovitch/orgs","repos_url":"https://api.github.com/users/irabinovitch/repos","events_url":"https://api.github.com/users/irabinovitch/events{/privacy}","received_events_url":"https://api.github.com/users/irabinovitch/received_events","type":"User","site_admin":false},"created_at":"2017-07-01T00:39:28Z","updated_at":"2017-07-01T00:39:28Z","body":"@sophaskins Can we catch up after the holiday weekend to discuss? "}}
{"actor":{"display_login":"irabinovitch"}}