{"action":"created","comment":{"url":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/comments/103679893","pull_request_review_id":24473184,"id":103679893,"diff_hunk":"@@ -0,0 +1,64 @@\n+module Import\n+  \n+  def upload_page\n+  end\n+\n+  def home\n+    @histories_array = []\n+    if current_offeror.history != nil","path":"app/controllers/concerns/import.rb","position":8,"original_position":8,"commit_id":"8b6fdb0ba971b14df338e3202fbf9d8c73f7d786","original_commit_id":"8b6fdb0ba971b14df338e3202fbf9d8c73f7d786","user":{"login":"alexander-kh","id":19606885,"avatar_url":"https://avatars3.githubusercontent.com/u/19606885?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-kh","html_url":"https://github.com/alexander-kh","followers_url":"https://api.github.com/users/alexander-kh/followers","following_url":"https://api.github.com/users/alexander-kh/following{/other_user}","gists_url":"https://api.github.com/users/alexander-kh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-kh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-kh/subscriptions","organizations_url":"https://api.github.com/users/alexander-kh/orgs","repos_url":"https://api.github.com/users/alexander-kh/repos","events_url":"https://api.github.com/users/alexander-kh/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-kh/received_events","type":"User","site_admin":false},"body":"Thanks for pointing out. I rewrote Offeror.home_set\r\n```\r\ndef self.home_set(histories)\r\n  if histories.blank?\r\n    return []\r\n  else\r\n    ...\r\n    return histories_array\r\n  end\r\nend\r\n```\r\nimport.rb:\r\n```\r\ndef home\r\n  @histories_array = Offeror.home_set(current_offeror.history)\r\n  ...\r\nend\r\n```","created_at":"2017-03-01T13:13:30Z","updated_at":"2017-03-01T13:13:30Z","html_url":"https://github.com/strawberrycanyon/redeemify/pull/75#discussion_r103679893","pull_request_url":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/comments/103679893"},"html":{"href":"https://github.com/strawberrycanyon/redeemify/pull/75#discussion_r103679893"},"pull_request":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75","id":105924907,"html_url":"https://github.com/strawberrycanyon/redeemify/pull/75","diff_url":"https://github.com/strawberrycanyon/redeemify/pull/75.diff","patch_url":"https://github.com/strawberrycanyon/redeemify/pull/75.patch","issue_url":"https://api.github.com/repos/strawberrycanyon/redeemify/issues/75","number":75,"state":"open","locked":false,"title":"Eliminates duplication of code in the controllers; fixes#74","user":{"login":"alexander-kh","id":19606885,"avatar_url":"https://avatars3.githubusercontent.com/u/19606885?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-kh","html_url":"https://github.com/alexander-kh","followers_url":"https://api.github.com/users/alexander-kh/followers","following_url":"https://api.github.com/users/alexander-kh/following{/other_user}","gists_url":"https://api.github.com/users/alexander-kh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-kh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-kh/subscriptions","organizations_url":"https://api.github.com/users/alexander-kh/orgs","repos_url":"https://api.github.com/users/alexander-kh/repos","events_url":"https://api.github.com/users/alexander-kh/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-kh/received_events","type":"User","site_admin":false},"body":"- Common methods related to uploading of codes were reworked and moved from the vendors_controller.rb into Import module.\r\n- Corresponding methods from Vendor model were moved into Offeror module.\r\n- import method have been updated in order to reduce complexity.\r\n- upload_page.html.erb templates for both offerors have been refactored.\r\n- RSpec and Cucumber tests have been updated in accordance with changes.","created_at":"2017-02-13T16:11:38Z","updated_at":"2017-03-01T13:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7967ecef27c6c8b50dadf17c6cb44c3c73f213ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75/commits","review_comments_url":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75/comments","review_comment_url":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strawberrycanyon/redeemify/issues/75/comments","statuses_url":"https://api.github.com/repos/strawberrycanyon/redeemify/statuses/8b6fdb0ba971b14df338e3202fbf9d8c73f7d786","head":{"label":"alexander-kh:import","ref":"import","sha":"8b6fdb0ba971b14df338e3202fbf9d8c73f7d786","user":{"login":"alexander-kh","id":19606885,"avatar_url":"https://avatars3.githubusercontent.com/u/19606885?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-kh","html_url":"https://github.com/alexander-kh","followers_url":"https://api.github.com/users/alexander-kh/followers","following_url":"https://api.github.com/users/alexander-kh/following{/other_user}","gists_url":"https://api.github.com/users/alexander-kh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-kh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-kh/subscriptions","organizations_url":"https://api.github.com/users/alexander-kh/orgs","repos_url":"https://api.github.com/users/alexander-kh/repos","events_url":"https://api.github.com/users/alexander-kh/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-kh/received_events","type":"User","site_admin":false},"repo":{"id":74121658,"name":"redeemify","full_name":"alexander-kh/redeemify","owner":{"login":"alexander-kh","id":19606885,"avatar_url":"https://avatars3.githubusercontent.com/u/19606885?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-kh","html_url":"https://github.com/alexander-kh","followers_url":"https://api.github.com/users/alexander-kh/followers","following_url":"https://api.github.com/users/alexander-kh/following{/other_user}","gists_url":"https://api.github.com/users/alexander-kh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-kh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-kh/subscriptions","organizations_url":"https://api.github.com/users/alexander-kh/orgs","repos_url":"https://api.github.com/users/alexander-kh/repos","events_url":"https://api.github.com/users/alexander-kh/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-kh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexander-kh/redeemify","description":"CS 169 redeemify","fork":true,"url":"https://api.github.com/repos/alexander-kh/redeemify","forks_url":"https://api.github.com/repos/alexander-kh/redeemify/forks","keys_url":"https://api.github.com/repos/alexander-kh/redeemify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexander-kh/redeemify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexander-kh/redeemify/teams","hooks_url":"https://api.github.com/repos/alexander-kh/redeemify/hooks","issue_events_url":"https://api.github.com/repos/alexander-kh/redeemify/issues/events{/number}","events_url":"https://api.github.com/repos/alexander-kh/redeemify/events","assignees_url":"https://api.github.com/repos/alexander-kh/redeemify/assignees{/user}","branches_url":"https://api.github.com/repos/alexander-kh/redeemify/branches{/branch}","tags_url":"https://api.github.com/repos/alexander-kh/redeemify/tags","blobs_url":"https://api.github.com/repos/alexander-kh/redeemify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexander-kh/redeemify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexander-kh/redeemify/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexander-kh/redeemify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexander-kh/redeemify/statuses/{sha}","languages_url":"https://api.github.com/repos/alexander-kh/redeemify/languages","stargazers_url":"https://api.github.com/repos/alexander-kh/redeemify/stargazers","contributors_url":"https://api.github.com/repos/alexander-kh/redeemify/contributors","subscribers_url":"https://api.github.com/repos/alexander-kh/redeemify/subscribers","subscription_url":"https://api.github.com/repos/alexander-kh/redeemify/subscription","commits_url":"https://api.github.com/repos/alexander-kh/redeemify/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexander-kh/redeemify/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexander-kh/redeemify/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexander-kh/redeemify/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexander-kh/redeemify/contents/{+path}","compare_url":"https://api.github.com/repos/alexander-kh/redeemify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexander-kh/redeemify/merges","archive_url":"https://api.github.com/repos/alexander-kh/redeemify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexander-kh/redeemify/downloads","issues_url":"https://api.github.com/repos/alexander-kh/redeemify/issues{/number}","pulls_url":"https://api.github.com/repos/alexander-kh/redeemify/pulls{/number}","milestones_url":"https://api.github.com/repos/alexander-kh/redeemify/milestones{/number}","notifications_url":"https://api.github.com/repos/alexander-kh/redeemify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexander-kh/redeemify/labels{/name}","releases_url":"https://api.github.com/repos/alexander-kh/redeemify/releases{/id}","deployments_url":"https://api.github.com/repos/alexander-kh/redeemify/deployments","created_at":"2016-11-18T10:52:07Z","updated_at":"2016-11-18T10:52:08Z","pushed_at":"2017-02-16T20:33:28Z","git_url":"git://github.com/alexander-kh/redeemify.git","ssh_url":"git@github.com:alexander-kh/redeemify.git","clone_url":"https://github.com/alexander-kh/redeemify.git","svn_url":"https://github.com/alexander-kh/redeemify","homepage":null,"size":16022,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strawberrycanyon:master","ref":"master","sha":"378e6c6828e11a437393b30c73b5c4cdeddf560f","user":{"login":"strawberrycanyon","id":18676638,"avatar_url":"https://avatars1.githubusercontent.com/u/18676638?v=3","gravatar_id":"","url":"https://api.github.com/users/strawberrycanyon","html_url":"https://github.com/strawberrycanyon","followers_url":"https://api.github.com/users/strawberrycanyon/followers","following_url":"https://api.github.com/users/strawberrycanyon/following{/other_user}","gists_url":"https://api.github.com/users/strawberrycanyon/gists{/gist_id}","starred_url":"https://api.github.com/users/strawberrycanyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strawberrycanyon/subscriptions","organizations_url":"https://api.github.com/users/strawberrycanyon/orgs","repos_url":"https://api.github.com/users/strawberrycanyon/repos","events_url":"https://api.github.com/users/strawberrycanyon/events{/privacy}","received_events_url":"https://api.github.com/users/strawberrycanyon/received_events","type":"Organization","site_admin":false},"repo":{"id":38259656,"name":"redeemify","full_name":"strawberrycanyon/redeemify","owner":{"login":"strawberrycanyon","id":18676638,"avatar_url":"https://avatars1.githubusercontent.com/u/18676638?v=3","gravatar_id":"","url":"https://api.github.com/users/strawberrycanyon","html_url":"https://github.com/strawberrycanyon","followers_url":"https://api.github.com/users/strawberrycanyon/followers","following_url":"https://api.github.com/users/strawberrycanyon/following{/other_user}","gists_url":"https://api.github.com/users/strawberrycanyon/gists{/gist_id}","starred_url":"https://api.github.com/users/strawberrycanyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strawberrycanyon/subscriptions","organizations_url":"https://api.github.com/users/strawberrycanyon/orgs","repos_url":"https://api.github.com/users/strawberrycanyon/repos","events_url":"https://api.github.com/users/strawberrycanyon/events{/privacy}","received_events_url":"https://api.github.com/users/strawberrycanyon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strawberrycanyon/redeemify","description":"CS 169 redeemify","fork":true,"url":"https://api.github.com/repos/strawberrycanyon/redeemify","forks_url":"https://api.github.com/repos/strawberrycanyon/redeemify/forks","keys_url":"https://api.github.com/repos/strawberrycanyon/redeemify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strawberrycanyon/redeemify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strawberrycanyon/redeemify/teams","hooks_url":"https://api.github.com/repos/strawberrycanyon/redeemify/hooks","issue_events_url":"https://api.github.com/repos/strawberrycanyon/redeemify/issues/events{/number}","events_url":"https://api.github.com/repos/strawberrycanyon/redeemify/events","assignees_url":"https://api.github.com/repos/strawberrycanyon/redeemify/assignees{/user}","branches_url":"https://api.github.com/repos/strawberrycanyon/redeemify/branches{/branch}","tags_url":"https://api.github.com/repos/strawberrycanyon/redeemify/tags","blobs_url":"https://api.github.com/repos/strawberrycanyon/redeemify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strawberrycanyon/redeemify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strawberrycanyon/redeemify/git/refs{/sha}","trees_url":"https://api.github.com/repos/strawberrycanyon/redeemify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strawberrycanyon/redeemify/statuses/{sha}","languages_url":"https://api.github.com/repos/strawberrycanyon/redeemify/languages","stargazers_url":"https://api.github.com/repos/strawberrycanyon/redeemify/stargazers","contributors_url":"https://api.github.com/repos/strawberrycanyon/redeemify/contributors","subscribers_url":"https://api.github.com/repos/strawberrycanyon/redeemify/subscribers","subscription_url":"https://api.github.com/repos/strawberrycanyon/redeemify/subscription","commits_url":"https://api.github.com/repos/strawberrycanyon/redeemify/commits{/sha}","git_commits_url":"https://api.github.com/repos/strawberrycanyon/redeemify/git/commits{/sha}","comments_url":"https://api.github.com/repos/strawberrycanyon/redeemify/comments{/number}","issue_comment_url":"https://api.github.com/repos/strawberrycanyon/redeemify/issues/comments{/number}","contents_url":"https://api.github.com/repos/strawberrycanyon/redeemify/contents/{+path}","compare_url":"https://api.github.com/repos/strawberrycanyon/redeemify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strawberrycanyon/redeemify/merges","archive_url":"https://api.github.com/repos/strawberrycanyon/redeemify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strawberrycanyon/redeemify/downloads","issues_url":"https://api.github.com/repos/strawberrycanyon/redeemify/issues{/number}","pulls_url":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls{/number}","milestones_url":"https://api.github.com/repos/strawberrycanyon/redeemify/milestones{/number}","notifications_url":"https://api.github.com/repos/strawberrycanyon/redeemify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strawberrycanyon/redeemify/labels{/name}","releases_url":"https://api.github.com/repos/strawberrycanyon/redeemify/releases{/id}","deployments_url":"https://api.github.com/repos/strawberrycanyon/redeemify/deployments","created_at":"2015-06-29T17:01:53Z","updated_at":"2016-12-12T16:40:52Z","pushed_at":"2017-02-16T20:33:29Z","git_url":"git://github.com/strawberrycanyon/redeemify.git","ssh_url":"git@github.com:strawberrycanyon/redeemify.git","clone_url":"https://github.com/strawberrycanyon/redeemify.git","svn_url":"https://github.com/strawberrycanyon/redeemify","homepage":null,"size":16001,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75"},"html":{"href":"https://github.com/strawberrycanyon/redeemify/pull/75"},"issue":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/issues/75"},"comments":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/strawberrycanyon/redeemify/statuses/8b6fdb0ba971b14df338e3202fbf9d8c73f7d786"}}}}
{"actor":{"display_login":"alexander-kh"}}