{"action":"created","issue":{"url":"https://api.github.com/repos/CARTAvis/carta/issues/89","repository_url":"https://api.github.com/repos/CARTAvis/carta","labels_url":"https://api.github.com/repos/CARTAvis/carta/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/CARTAvis/carta/issues/89/comments","events_url":"https://api.github.com/repos/CARTAvis/carta/issues/89/events","html_url":"https://github.com/CARTAvis/carta/issues/89","id":225034042,"number":89,"title":"no (intensity) unit conversion","user":{"login":"grimmer0125","id":5940941,"avatar_url":"https://avatars2.githubusercontent.com/u/5940941?v=4","gravatar_id":"","url":"https://api.github.com/users/grimmer0125","html_url":"https://github.com/grimmer0125","followers_url":"https://api.github.com/users/grimmer0125/followers","following_url":"https://api.github.com/users/grimmer0125/following{/other_user}","gists_url":"https://api.github.com/users/grimmer0125/gists{/gist_id}","starred_url":"https://api.github.com/users/grimmer0125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimmer0125/subscriptions","organizations_url":"https://api.github.com/users/grimmer0125/orgs","repos_url":"https://api.github.com/users/grimmer0125/repos","events_url":"https://api.github.com/users/grimmer0125/events{/privacy}","received_events_url":"https://api.github.com/users/grimmer0125/received_events","type":"User","site_admin":false},"labels":[{"id":605188991,"url":"https://api.github.com/repos/CARTAvis/carta/labels/colormap","name":"colormap","color":"f9d0c4","default":false},{"id":491407517,"url":"https://api.github.com/repos/CARTAvis/carta/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"confluence","id":651030,"avatar_url":"https://avatars3.githubusercontent.com/u/651030?v=4","gravatar_id":"","url":"https://api.github.com/users/confluence","html_url":"https://github.com/confluence","followers_url":"https://api.github.com/users/confluence/followers","following_url":"https://api.github.com/users/confluence/following{/other_user}","gists_url":"https://api.github.com/users/confluence/gists{/gist_id}","starred_url":"https://api.github.com/users/confluence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluence/subscriptions","organizations_url":"https://api.github.com/users/confluence/orgs","repos_url":"https://api.github.com/users/confluence/repos","events_url":"https://api.github.com/users/confluence/events{/privacy}","received_events_url":"https://api.github.com/users/confluence/received_events","type":"User","site_admin":false},"assignees":[{"login":"confluence","id":651030,"avatar_url":"https://avatars3.githubusercontent.com/u/651030?v=4","gravatar_id":"","url":"https://api.github.com/users/confluence","html_url":"https://github.com/confluence","followers_url":"https://api.github.com/users/confluence/followers","following_url":"https://api.github.com/users/confluence/following{/other_user}","gists_url":"https://api.github.com/users/confluence/gists{/gist_id}","starred_url":"https://api.github.com/users/confluence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluence/subscriptions","organizations_url":"https://api.github.com/users/confluence/orgs","repos_url":"https://api.github.com/users/confluence/repos","events_url":"https://api.github.com/users/confluence/events{/privacy}","received_events_url":"https://api.github.com/users/confluence/received_events","type":"User","site_admin":false}],"milestone":null,"comments":45,"created_at":"2017-04-28T09:56:30Z","updated_at":"2017-09-04T06:19:57Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"related doc: https://docs.google.com/document/d/1VZ64s2V47mJzXX4YBBTDN6jORu9XQKc6WFy3QeCdviU/edit\r\n*Need to consider multi-beam during conversion.* \r\n\r\n\r\nif the unit conversion is not frame-property dependent, such as Jy/arcsec^2 to MJy/sr, the bound values (such global min/max or the min/max per frame or clip level at non-100% levels) can be directly converted to new unit which is also not frame-property dependent. \r\n\r\nAs long as the unit conversion dependents on frame properties, such as frequency and/or beam size (which may also change from frame to frame), conversion of all pixels needs to be done first before running percentile/quantile. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/CARTAvis/carta/issues/comments/326875404","html_url":"https://github.com/CARTAvis/carta/issues/89#issuecomment-326875404","issue_url":"https://api.github.com/repos/CARTAvis/carta/issues/89","id":326875404,"user":{"login":"confluence","id":651030,"avatar_url":"https://avatars3.githubusercontent.com/u/651030?v=4","gravatar_id":"","url":"https://api.github.com/users/confluence","html_url":"https://github.com/confluence","followers_url":"https://api.github.com/users/confluence/followers","following_url":"https://api.github.com/users/confluence/following{/other_user}","gists_url":"https://api.github.com/users/confluence/gists{/gist_id}","starred_url":"https://api.github.com/users/confluence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluence/subscriptions","organizations_url":"https://api.github.com/users/confluence/orgs","repos_url":"https://api.github.com/users/confluence/repos","events_url":"https://api.github.com/users/confluence/events{/privacy}","received_events_url":"https://api.github.com/users/confluence/received_events","type":"User","site_admin":false},"created_at":"2017-09-04T06:19:57Z","updated_at":"2017-09-04T06:19:57Z","author_association":"CONTRIBUTOR","body":"There is already an error message printed in the UI when a conversion fails. Currently I believe the only possibilities are: the conversion is unsupported, or it's frame-dependent and spectral axis is missing. I have already edited UnitsIntensity not to add conversions to/from Kelvin if there's no spectral axis, and corrected the code for not putting in conversions to/from Jy/Beam if there is no beam info. If we agree that it's best to comment out unsupported conversions for now I  can easily do that.\r\n\r\nBut the quoted text was in reference to the more serious problem, which is that there is currently no support for units in the pixel pipeline (which controls the actual display of the image for the given clipping values). For now I am passing in intensity values in the image units (recalculated from the stored percentages), but this is not the correct behaviour for frame-dependent conversions: the pixel pipeline should actually behave analogously to the algorithm for calculating percentages from intensities, and convert image values to the same units as the intensity. Or at least do the same thing as the intensity-to-percentile algorithm does, which is convert the intensity value in reverse for each frame -- but I'm not sure how easily this can be integrated into the pipeline. The current behaviour is less buggy than the previous behaviour, but we're currently missing support for manipulating the alternate set of statistics obtained by converting the image to or from Kelvin, which seems to be an important part of being able to convert the image to those units."}}
{"actor":{"display_login":"confluence"}}