{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/comments/122570606","pull_request_review_id":44701362,"id":122570606,"diff_hunk":"@@ -196,6 +195,17 @@ func MakeRegistry() *Registry {\n \t\t},\n \t}\n \n+\tk8sControllersTypeFilter := APITopologyOptionGroup{\n+\t\tID:         \"grouptype\",\n+\t\tDefault:    \"\",","path":"app/api_topologies.go","position":25,"original_position":25,"commit_id":"4a4c248abe53c15291cb6f3cf32e66ce0b1b649a","original_commit_id":"4a4c248abe53c15291cb6f3cf32e66ce0b1b649a","user":{"login":"rade","id":109109,"avatar_url":"https://avatars0.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"body":"When I test this branch, the type filter has nothing selected. Unlike, say, the namespace filter, which has \"All Namespaces\" selected.\r\n\r\nI suspect that's because the above ought to be `Default: \"none\"`. Even though you say this branch fixes #2525. (in which case, btw, I would expect existing filters, such as the namespace filter, to make use of this functionality - which suggests this change would be better off in its own PR)","created_at":"2017-06-17T15:14:53Z","updated_at":"2017-06-17T15:37:49Z","html_url":"https://github.com/weaveworks/scope/pull/2552#discussion_r122570606","pull_request_url":"https://api.github.com/repos/weaveworks/scope/pulls/2552","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/comments/122570606"},"html":{"href":"https://github.com/weaveworks/scope/pull/2552#discussion_r122570606"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/2552"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/2552","id":123399089,"html_url":"https://github.com/weaveworks/scope/pull/2552","diff_url":"https://github.com/weaveworks/scope/pull/2552.diff","patch_url":"https://github.com/weaveworks/scope/pull/2552.patch","issue_url":"https://api.github.com/repos/weaveworks/scope/issues/2552","number":2552,"state":"open","locked":false,"title":"add k8s combined view","user":{"login":"ekimekim","id":570052,"avatar_url":"https://avatars2.githubusercontent.com/u/570052?v=3","gravatar_id":"","url":"https://api.github.com/users/ekimekim","html_url":"https://github.com/ekimekim","followers_url":"https://api.github.com/users/ekimekim/followers","following_url":"https://api.github.com/users/ekimekim/following{/other_user}","gists_url":"https://api.github.com/users/ekimekim/gists{/gist_id}","starred_url":"https://api.github.com/users/ekimekim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekimekim/subscriptions","organizations_url":"https://api.github.com/users/ekimekim/orgs","repos_url":"https://api.github.com/users/ekimekim/repos","events_url":"https://api.github.com/users/ekimekim/events{/privacy}","received_events_url":"https://api.github.com/users/ekimekim/received_events","type":"User","site_admin":false},"body":"This adds a 'combined' kubernetes view that shows each pod at the 'highest level of abstraction', as follows:\n\t* Any daemonsets the pod is in\n\t* Any deployments the pod is in\n\t* Any replica-sets the pod is in that do not map to a deployment\n\t* If none of the above, the bare pod itself\n\n\nAlong the way, it fixes https://github.com/weaveworks/scope/issues/2525 by removing the omitempty for the default value, further generalises render.Map2Parent, and introduces a new Renderer type for combining a set of nodes with a set containing the same nodes with more information, but with the output set of nodes only being the original set (but with the extra information), unlike Reduce which takes a union.\n\nFixes https://github.com/weaveworks/scope/issues/2525\n\nStill to do:\n\t* How does the table view work in this setup?\n\t* We want to assign shapes to the different topologies present to differentiate them graphically","created_at":"2017-06-01T00:52:26Z","updated_at":"2017-06-17T15:37:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95392dbbbf26cc21dc6301f0f3ca237e22a94b65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"2opremio","id":2362916,"avatar_url":"https://avatars3.githubusercontent.com/u/2362916?v=3","gravatar_id":"","url":"https://api.github.com/users/2opremio","html_url":"https://github.com/2opremio","followers_url":"https://api.github.com/users/2opremio/followers","following_url":"https://api.github.com/users/2opremio/following{/other_user}","gists_url":"https://api.github.com/users/2opremio/gists{/gist_id}","starred_url":"https://api.github.com/users/2opremio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2opremio/subscriptions","organizations_url":"https://api.github.com/users/2opremio/orgs","repos_url":"https://api.github.com/users/2opremio/repos","events_url":"https://api.github.com/users/2opremio/events{/privacy}","received_events_url":"https://api.github.com/users/2opremio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/scope/pulls/2552/commits","review_comments_url":"https://api.github.com/repos/weaveworks/scope/pulls/2552/comments","review_comment_url":"https://api.github.com/repos/weaveworks/scope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/scope/issues/2552/comments","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/4a4c248abe53c15291cb6f3cf32e66ce0b1b649a","head":{"label":"weaveworks:mike/k8s/combined-view","ref":"mike/k8s/combined-view","sha":"4a4c248abe53c15291cb6f3cf32e66ce0b1b649a","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":34659664,"name":"scope","full_name":"weaveworks/scope","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/scope","description":"Monitoring, visualisation & management for Docker & Kubernetes","fork":false,"url":"https://api.github.com/repos/weaveworks/scope","forks_url":"https://api.github.com/repos/weaveworks/scope/forks","keys_url":"https://api.github.com/repos/weaveworks/scope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/scope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/scope/teams","hooks_url":"https://api.github.com/repos/weaveworks/scope/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/scope/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/scope/events","assignees_url":"https://api.github.com/repos/weaveworks/scope/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/scope/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/scope/tags","blobs_url":"https://api.github.com/repos/weaveworks/scope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/scope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/scope/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/scope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/scope/languages","stargazers_url":"https://api.github.com/repos/weaveworks/scope/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/scope/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/scope/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/scope/subscription","commits_url":"https://api.github.com/repos/weaveworks/scope/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/scope/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/scope/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/scope/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/scope/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/scope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/scope/merges","archive_url":"https://api.github.com/repos/weaveworks/scope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/scope/downloads","issues_url":"https://api.github.com/repos/weaveworks/scope/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/scope/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/scope/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/scope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/scope/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/scope/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/scope/deployments","created_at":"2015-04-27T10:12:35Z","updated_at":"2017-06-15T08:57:38Z","pushed_at":"2017-06-16T21:45:58Z","git_url":"git://github.com/weaveworks/scope.git","ssh_url":"git@github.com:weaveworks/scope.git","clone_url":"https://github.com/weaveworks/scope.git","svn_url":"https://github.com/weaveworks/scope","homepage":"https://www.weave.works/product/weave-scope/","size":52747,"stargazers_count":1197,"watchers_count":1197,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":346,"forks":125,"open_issues":346,"watchers":1197,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"8c0c20f289b84d014e7a4bba27840dbdc3bd69f8","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":34659664,"name":"scope","full_name":"weaveworks/scope","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars2.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/scope","description":"Monitoring, visualisation & management for Docker & Kubernetes","fork":false,"url":"https://api.github.com/repos/weaveworks/scope","forks_url":"https://api.github.com/repos/weaveworks/scope/forks","keys_url":"https://api.github.com/repos/weaveworks/scope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/scope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/scope/teams","hooks_url":"https://api.github.com/repos/weaveworks/scope/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/scope/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/scope/events","assignees_url":"https://api.github.com/repos/weaveworks/scope/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/scope/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/scope/tags","blobs_url":"https://api.github.com/repos/weaveworks/scope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/scope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/scope/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/scope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/scope/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/scope/languages","stargazers_url":"https://api.github.com/repos/weaveworks/scope/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/scope/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/scope/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/scope/subscription","commits_url":"https://api.github.com/repos/weaveworks/scope/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/scope/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/scope/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/scope/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/scope/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/scope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/scope/merges","archive_url":"https://api.github.com/repos/weaveworks/scope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/scope/downloads","issues_url":"https://api.github.com/repos/weaveworks/scope/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/scope/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/scope/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/scope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/scope/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/scope/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/scope/deployments","created_at":"2015-04-27T10:12:35Z","updated_at":"2017-06-15T08:57:38Z","pushed_at":"2017-06-16T21:45:58Z","git_url":"git://github.com/weaveworks/scope.git","ssh_url":"git@github.com:weaveworks/scope.git","clone_url":"https://github.com/weaveworks/scope.git","svn_url":"https://github.com/weaveworks/scope","homepage":"https://www.weave.works/product/weave-scope/","size":52747,"stargazers_count":1197,"watchers_count":1197,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":346,"forks":125,"open_issues":346,"watchers":1197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/2552"},"html":{"href":"https://github.com/weaveworks/scope/pull/2552"},"issue":{"href":"https://api.github.com/repos/weaveworks/scope/issues/2552"},"comments":{"href":"https://api.github.com/repos/weaveworks/scope/issues/2552/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/2552/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/scope/pulls/2552/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/scope/statuses/4a4c248abe53c15291cb6f3cf32e66ce0b1b649a"}}}}
{"actor":{"display_login":"rade"}}