{"action":"created","comment":{"url":"https://api.github.com/repos/electron/node-rcedit/pulls/comments/104533152","pull_request_review_id":25374855,"id":104533152,"diff_hunk":"@@ -2,7 +2,7 @@ var path = require('path')\n var spawn = require('child_process').spawn\n \n var pairSettings = ['version-string']\n-var singleSettings = ['file-version', 'product-version', 'icon']\n+var singleSettings = ['file-version', 'product-version', 'icon', 'requested-executation-level']","path":"lib/rcedit.js","position":5,"original_position":5,"commit_id":"fa42d1d194b217db7fcab5c53e47fc6ca79330fe","original_commit_id":"fa42d1d194b217db7fcab5c53e47fc6ca79330fe","user":{"login":"dmascord","id":1801667,"avatar_url":"https://avatars1.githubusercontent.com/u/1801667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmascord","html_url":"https://github.com/dmascord","followers_url":"https://api.github.com/users/dmascord/followers","following_url":"https://api.github.com/users/dmascord/following{/other_user}","gists_url":"https://api.github.com/users/dmascord/gists{/gist_id}","starred_url":"https://api.github.com/users/dmascord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmascord/subscriptions","organizations_url":"https://api.github.com/users/dmascord/orgs","repos_url":"https://api.github.com/users/dmascord/repos","events_url":"https://api.github.com/users/dmascord/events{/privacy}","received_events_url":"https://api.github.com/users/dmascord/received_events","type":"User","site_admin":false},"body":"good catch!","created_at":"2017-03-06T21:53:47Z","updated_at":"2017-03-06T21:53:47Z","html_url":"https://github.com/electron/node-rcedit/pull/27#discussion_r104533152","pull_request_url":"https://api.github.com/repos/electron/node-rcedit/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/electron/node-rcedit/pulls/comments/104533152"},"html":{"href":"https://github.com/electron/node-rcedit/pull/27#discussion_r104533152"},"pull_request":{"href":"https://api.github.com/repos/electron/node-rcedit/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/electron/node-rcedit/pulls/27","id":109237353,"html_url":"https://github.com/electron/node-rcedit/pull/27","diff_url":"https://github.com/electron/node-rcedit/pull/27.diff","patch_url":"https://github.com/electron/node-rcedit/pull/27.patch","issue_url":"https://api.github.com/repos/electron/node-rcedit/issues/27","number":27,"state":"open","locked":false,"title":"Add ability to set the requested execution level for UAC","user":{"login":"dmascord","id":1801667,"avatar_url":"https://avatars1.githubusercontent.com/u/1801667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmascord","html_url":"https://github.com/dmascord","followers_url":"https://api.github.com/users/dmascord/followers","following_url":"https://api.github.com/users/dmascord/following{/other_user}","gists_url":"https://api.github.com/users/dmascord/gists{/gist_id}","starred_url":"https://api.github.com/users/dmascord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmascord/subscriptions","organizations_url":"https://api.github.com/users/dmascord/orgs","repos_url":"https://api.github.com/users/dmascord/repos","events_url":"https://api.github.com/users/dmascord/events{/privacy}","received_events_url":"https://api.github.com/users/dmascord/received_events","type":"User","site_admin":false},"body":"As per http://layer0.authentise.com/electron-and-uac-on-windows.html, add the ability for rcedit.exe to modify execution level in the Manifest.\r\n\r\nrcedit.exe modifications are present in https://github.com/dmascord/rcedit, and already submitted for review.","created_at":"2017-03-06T11:18:36Z","updated_at":"2017-03-06T21:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eca53fbf29c44616a224728a653ae65a988cd28e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron/node-rcedit/pulls/27/commits","review_comments_url":"https://api.github.com/repos/electron/node-rcedit/pulls/27/comments","review_comment_url":"https://api.github.com/repos/electron/node-rcedit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/node-rcedit/issues/27/comments","statuses_url":"https://api.github.com/repos/electron/node-rcedit/statuses/fa42d1d194b217db7fcab5c53e47fc6ca79330fe","head":{"label":"dmascord:master","ref":"master","sha":"fa42d1d194b217db7fcab5c53e47fc6ca79330fe","user":{"login":"dmascord","id":1801667,"avatar_url":"https://avatars1.githubusercontent.com/u/1801667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmascord","html_url":"https://github.com/dmascord","followers_url":"https://api.github.com/users/dmascord/followers","following_url":"https://api.github.com/users/dmascord/following{/other_user}","gists_url":"https://api.github.com/users/dmascord/gists{/gist_id}","starred_url":"https://api.github.com/users/dmascord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmascord/subscriptions","organizations_url":"https://api.github.com/users/dmascord/orgs","repos_url":"https://api.github.com/users/dmascord/repos","events_url":"https://api.github.com/users/dmascord/events{/privacy}","received_events_url":"https://api.github.com/users/dmascord/received_events","type":"User","site_admin":false},"repo":{"id":84064281,"name":"node-rcedit","full_name":"dmascord/node-rcedit","owner":{"login":"dmascord","id":1801667,"avatar_url":"https://avatars1.githubusercontent.com/u/1801667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmascord","html_url":"https://github.com/dmascord","followers_url":"https://api.github.com/users/dmascord/followers","following_url":"https://api.github.com/users/dmascord/following{/other_user}","gists_url":"https://api.github.com/users/dmascord/gists{/gist_id}","starred_url":"https://api.github.com/users/dmascord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmascord/subscriptions","organizations_url":"https://api.github.com/users/dmascord/orgs","repos_url":"https://api.github.com/users/dmascord/repos","events_url":"https://api.github.com/users/dmascord/events{/privacy}","received_events_url":"https://api.github.com/users/dmascord/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmascord/node-rcedit","description":"Node module to edit resources of exe","fork":true,"url":"https://api.github.com/repos/dmascord/node-rcedit","forks_url":"https://api.github.com/repos/dmascord/node-rcedit/forks","keys_url":"https://api.github.com/repos/dmascord/node-rcedit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmascord/node-rcedit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmascord/node-rcedit/teams","hooks_url":"https://api.github.com/repos/dmascord/node-rcedit/hooks","issue_events_url":"https://api.github.com/repos/dmascord/node-rcedit/issues/events{/number}","events_url":"https://api.github.com/repos/dmascord/node-rcedit/events","assignees_url":"https://api.github.com/repos/dmascord/node-rcedit/assignees{/user}","branches_url":"https://api.github.com/repos/dmascord/node-rcedit/branches{/branch}","tags_url":"https://api.github.com/repos/dmascord/node-rcedit/tags","blobs_url":"https://api.github.com/repos/dmascord/node-rcedit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmascord/node-rcedit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmascord/node-rcedit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmascord/node-rcedit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmascord/node-rcedit/statuses/{sha}","languages_url":"https://api.github.com/repos/dmascord/node-rcedit/languages","stargazers_url":"https://api.github.com/repos/dmascord/node-rcedit/stargazers","contributors_url":"https://api.github.com/repos/dmascord/node-rcedit/contributors","subscribers_url":"https://api.github.com/repos/dmascord/node-rcedit/subscribers","subscription_url":"https://api.github.com/repos/dmascord/node-rcedit/subscription","commits_url":"https://api.github.com/repos/dmascord/node-rcedit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmascord/node-rcedit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmascord/node-rcedit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmascord/node-rcedit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmascord/node-rcedit/contents/{+path}","compare_url":"https://api.github.com/repos/dmascord/node-rcedit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmascord/node-rcedit/merges","archive_url":"https://api.github.com/repos/dmascord/node-rcedit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmascord/node-rcedit/downloads","issues_url":"https://api.github.com/repos/dmascord/node-rcedit/issues{/number}","pulls_url":"https://api.github.com/repos/dmascord/node-rcedit/pulls{/number}","milestones_url":"https://api.github.com/repos/dmascord/node-rcedit/milestones{/number}","notifications_url":"https://api.github.com/repos/dmascord/node-rcedit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmascord/node-rcedit/labels{/name}","releases_url":"https://api.github.com/repos/dmascord/node-rcedit/releases{/id}","deployments_url":"https://api.github.com/repos/dmascord/node-rcedit/deployments","created_at":"2017-03-06T11:14:47Z","updated_at":"2017-03-06T11:14:49Z","pushed_at":"2017-03-06T12:43:03Z","git_url":"git://github.com/dmascord/node-rcedit.git","ssh_url":"git@github.com:dmascord/node-rcedit.git","clone_url":"https://github.com/dmascord/node-rcedit.git","svn_url":"https://github.com/dmascord/node-rcedit","homepage":null,"size":26935,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"0340f4800c323ec64a2bf89eac4cefb45e7a5702","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars2.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":14167785,"name":"node-rcedit","full_name":"electron/node-rcedit","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars2.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/node-rcedit","description":"Node module to edit resources of exe","fork":false,"url":"https://api.github.com/repos/electron/node-rcedit","forks_url":"https://api.github.com/repos/electron/node-rcedit/forks","keys_url":"https://api.github.com/repos/electron/node-rcedit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/node-rcedit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/node-rcedit/teams","hooks_url":"https://api.github.com/repos/electron/node-rcedit/hooks","issue_events_url":"https://api.github.com/repos/electron/node-rcedit/issues/events{/number}","events_url":"https://api.github.com/repos/electron/node-rcedit/events","assignees_url":"https://api.github.com/repos/electron/node-rcedit/assignees{/user}","branches_url":"https://api.github.com/repos/electron/node-rcedit/branches{/branch}","tags_url":"https://api.github.com/repos/electron/node-rcedit/tags","blobs_url":"https://api.github.com/repos/electron/node-rcedit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/node-rcedit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/node-rcedit/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/node-rcedit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/node-rcedit/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/node-rcedit/languages","stargazers_url":"https://api.github.com/repos/electron/node-rcedit/stargazers","contributors_url":"https://api.github.com/repos/electron/node-rcedit/contributors","subscribers_url":"https://api.github.com/repos/electron/node-rcedit/subscribers","subscription_url":"https://api.github.com/repos/electron/node-rcedit/subscription","commits_url":"https://api.github.com/repos/electron/node-rcedit/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/node-rcedit/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/node-rcedit/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/node-rcedit/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/node-rcedit/contents/{+path}","compare_url":"https://api.github.com/repos/electron/node-rcedit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/node-rcedit/merges","archive_url":"https://api.github.com/repos/electron/node-rcedit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/node-rcedit/downloads","issues_url":"https://api.github.com/repos/electron/node-rcedit/issues{/number}","pulls_url":"https://api.github.com/repos/electron/node-rcedit/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/node-rcedit/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/node-rcedit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/node-rcedit/labels{/name}","releases_url":"https://api.github.com/repos/electron/node-rcedit/releases{/id}","deployments_url":"https://api.github.com/repos/electron/node-rcedit/deployments","created_at":"2013-11-06T09:08:11Z","updated_at":"2017-02-24T22:50:36Z","pushed_at":"2017-03-06T12:43:05Z","git_url":"git://github.com/electron/node-rcedit.git","ssh_url":"git@github.com:electron/node-rcedit.git","clone_url":"https://github.com/electron/node-rcedit.git","svn_url":"https://github.com/electron/node-rcedit","homepage":null,"size":26581,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":10,"forks":8,"open_issues":10,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/node-rcedit/pulls/27"},"html":{"href":"https://github.com/electron/node-rcedit/pull/27"},"issue":{"href":"https://api.github.com/repos/electron/node-rcedit/issues/27"},"comments":{"href":"https://api.github.com/repos/electron/node-rcedit/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/node-rcedit/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/node-rcedit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/node-rcedit/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/electron/node-rcedit/statuses/fa42d1d194b217db7fcab5c53e47fc6ca79330fe"}}}}
{"actor":{"display_login":"dmascord"}}