{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/115366697","pull_request_review_id":36899652,"id":115366697,"diff_hunk":"@@ -7,7 +7,12 @@ export default (server) => {\n     handler: (req, reply) => {\n       return getFields(req)","path":"src/core_plugins/metrics/server/routes/fields.js","position":2,"original_position":2,"commit_id":"902895e15ccf85cc5f032dfcb71cd59d96024000","original_commit_id":"902895e15ccf85cc5f032dfcb71cd59d96024000","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars2.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"body":"hapi route handlers are not promise aware, but could be if you pass the promise to reply instead of returning it. Then the resolve value or error is treated as the argument to reply (like you are doing below).","created_at":"2017-05-08T22:14:15Z","updated_at":"2017-05-08T22:16:22Z","html_url":"https://github.com/elastic/kibana/pull/11656#discussion_r115366697","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/11656","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/115366697"},"html":{"href":"https://github.com/elastic/kibana/pull/11656#discussion_r115366697"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11656"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/11656","id":119502526,"html_url":"https://github.com/elastic/kibana/pull/11656","diff_url":"https://github.com/elastic/kibana/pull/11656.diff","patch_url":"https://github.com/elastic/kibana/pull/11656.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/11656","number":11656,"state":"open","locked":false,"title":"Fixed #11643 - Return Boom errors directly to the browser for Time Series Visual Builder","user":{"login":"simianhacker","id":41702,"avatar_url":"https://avatars1.githubusercontent.com/u/41702?v=3","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"body":"This PR fixes #11643 by returning Boom errors to the client directly instead of serializing them into the response. Errors from the ES client usually are Boom errors when there is an authentication issue.","created_at":"2017-05-08T18:08:17Z","updated_at":"2017-05-08T22:16:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b982a5ddfdbbe955d61bbdebd6f0f2eadfbf28e","assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars2.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"assignees":[{"login":"spalger","id":1329312,"avatar_url":"https://avatars2.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/11656/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/11656/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/11656/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/902895e15ccf85cc5f032dfcb71cd59d96024000","head":{"label":"simianhacker:issue-11643","ref":"issue-11643","sha":"902895e15ccf85cc5f032dfcb71cd59d96024000","user":{"login":"simianhacker","id":41702,"avatar_url":"https://avatars1.githubusercontent.com/u/41702?v=3","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"repo":{"id":14648766,"name":"kibana","full_name":"simianhacker/kibana","owner":{"login":"simianhacker","id":41702,"avatar_url":"https://avatars1.githubusercontent.com/u/41702?v=3","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simianhacker/kibana","description":"Kibana 3","fork":true,"url":"https://api.github.com/repos/simianhacker/kibana","forks_url":"https://api.github.com/repos/simianhacker/kibana/forks","keys_url":"https://api.github.com/repos/simianhacker/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simianhacker/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simianhacker/kibana/teams","hooks_url":"https://api.github.com/repos/simianhacker/kibana/hooks","issue_events_url":"https://api.github.com/repos/simianhacker/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/simianhacker/kibana/events","assignees_url":"https://api.github.com/repos/simianhacker/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/simianhacker/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/simianhacker/kibana/tags","blobs_url":"https://api.github.com/repos/simianhacker/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simianhacker/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simianhacker/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/simianhacker/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simianhacker/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/simianhacker/kibana/languages","stargazers_url":"https://api.github.com/repos/simianhacker/kibana/stargazers","contributors_url":"https://api.github.com/repos/simianhacker/kibana/contributors","subscribers_url":"https://api.github.com/repos/simianhacker/kibana/subscribers","subscription_url":"https://api.github.com/repos/simianhacker/kibana/subscription","commits_url":"https://api.github.com/repos/simianhacker/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/simianhacker/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/simianhacker/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/simianhacker/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/simianhacker/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/simianhacker/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simianhacker/kibana/merges","archive_url":"https://api.github.com/repos/simianhacker/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simianhacker/kibana/downloads","issues_url":"https://api.github.com/repos/simianhacker/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/simianhacker/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/simianhacker/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/simianhacker/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simianhacker/kibana/labels{/name}","releases_url":"https://api.github.com/repos/simianhacker/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/simianhacker/kibana/deployments","created_at":"2013-11-23T19:19:22Z","updated_at":"2016-10-26T17:39:22Z","pushed_at":"2017-05-08T21:28:56Z","git_url":"git://github.com/simianhacker/kibana.git","ssh_url":"git@github.com:simianhacker/kibana.git","clone_url":"https://github.com/simianhacker/kibana.git","svn_url":"https://github.com/simianhacker/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":244204,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"24b9b229af37b1858a19096dfc4cab0346ba8993","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-05-08T15:28:51Z","pushed_at":"2017-05-08T22:11:04Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":255355,"stargazers_count":7245,"watchers_count":7245,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2735,"mirror_url":null,"open_issues_count":1649,"forks":2735,"open_issues":1649,"watchers":7245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11656"},"html":{"href":"https://github.com/elastic/kibana/pull/11656"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/11656"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/11656/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11656/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11656/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/902895e15ccf85cc5f032dfcb71cd59d96024000"}}}}
{"actor":{"display_login":"spalger"}}