{"action":"created","issue":{"url":"https://api.github.com/repos/paulcollett/react-masonry-css/issues/5","repository_url":"https://api.github.com/repos/paulcollett/react-masonry-css","labels_url":"https://api.github.com/repos/paulcollett/react-masonry-css/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/paulcollett/react-masonry-css/issues/5/comments","events_url":"https://api.github.com/repos/paulcollett/react-masonry-css/issues/5/events","html_url":"https://github.com/paulcollett/react-masonry-css/pull/5","id":265001854,"number":5,"title":"Media queries + window.matchMedia()","user":{"login":"freder","id":724844,"avatar_url":"https://avatars3.githubusercontent.com/u/724844?v=4","gravatar_id":"","url":"https://api.github.com/users/freder","html_url":"https://github.com/freder","followers_url":"https://api.github.com/users/freder/followers","following_url":"https://api.github.com/users/freder/following{/other_user}","gists_url":"https://api.github.com/users/freder/gists{/gist_id}","starred_url":"https://api.github.com/users/freder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freder/subscriptions","organizations_url":"https://api.github.com/users/freder/orgs","repos_url":"https://api.github.com/users/freder/repos","events_url":"https://api.github.com/users/freder/events{/privacy}","received_events_url":"https://api.github.com/users/freder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-12T16:14:57Z","updated_at":"2017-10-12T19:43:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/paulcollett/react-masonry-css/pulls/5","html_url":"https://github.com/paulcollett/react-masonry-css/pull/5","diff_url":"https://github.com/paulcollett/react-masonry-css/pull/5.diff","patch_url":"https://github.com/paulcollett/react-masonry-css/pull/5.patch"},"body":"being able to specify media queries (rather than window width in pixels) makes it a bit more flexible, I think.\r\n\r\nsee: https://developer.mozilla.org/en-US/docs/Web/API/Window/matchMedia"},"comment":{"url":"https://api.github.com/repos/paulcollett/react-masonry-css/issues/comments/336244829","html_url":"https://github.com/paulcollett/react-masonry-css/pull/5#issuecomment-336244829","issue_url":"https://api.github.com/repos/paulcollett/react-masonry-css/issues/5","id":336244829,"user":{"login":"paulcollett","id":1904774,"avatar_url":"https://avatars1.githubusercontent.com/u/1904774?v=4","gravatar_id":"","url":"https://api.github.com/users/paulcollett","html_url":"https://github.com/paulcollett","followers_url":"https://api.github.com/users/paulcollett/followers","following_url":"https://api.github.com/users/paulcollett/following{/other_user}","gists_url":"https://api.github.com/users/paulcollett/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcollett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcollett/subscriptions","organizations_url":"https://api.github.com/users/paulcollett/orgs","repos_url":"https://api.github.com/users/paulcollett/repos","events_url":"https://api.github.com/users/paulcollett/events{/privacy}","received_events_url":"https://api.github.com/users/paulcollett/received_events","type":"User","site_admin":false},"created_at":"2017-10-12T19:43:17Z","updated_at":"2017-10-12T19:43:17Z","author_association":"OWNER","body":"I've found as well the order in which mediaQueries are specified is important (always needs to be lowest size to highest) which may make the interface a little more error prone. Clear documentation would help though there is a trade off over making sure the setup is correct and the value it brings. \r\n\r\nI may be missing something but can media queries do anything that the current interface can't?\r\n\r\nWe could also allow two interfaces, one as an passed object (as currently) and an array of media queries, what do you think?\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"paulcollett"}}