{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/111263322","pull_request_review_id":32497230,"id":111263322,"diff_hunk":"@@ -226,6 +226,13 @@ void TBDGenVisitor::visitClassDecl(ClassDecl *CD) {\n     if (hasWitnessTableOffset) {\n       addSymbol(LinkEntity::forWitnessTableOffset(value));\n     }\n+\n+    auto var = dyn_cast<VarDecl>(value);\n+    auto hasFieldOffset = var && var->hasStorage() && !var->isStatic();\n+    if (hasFieldOffset) {\n+      // FIXME: indirect vs not is likely incorrect.\n+      addSymbol(LinkEntity::forFieldOffset(var, /*isIndirect=*/false));","path":"lib/TBDGen/TBDGen.cpp","position":208,"original_position":9,"commit_id":"1c55175b479f222786b1b7459c1620d19f4de1e7","original_commit_id":"9520cf107e1f0285567f92ed2465bf7ce7318c12","user":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars2.githubusercontent.com/u/66486?v=3","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"body":"I don't think anything is ever 'indirect' here.","created_at":"2017-04-12T21:20:27Z","updated_at":"2017-04-12T21:20:27Z","html_url":"https://github.com/apple/swift/pull/8728#discussion_r111263322","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/8728","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/111263322"},"html":{"href":"https://github.com/apple/swift/pull/8728#discussion_r111263322"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/8728"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/8728","id":115633617,"html_url":"https://github.com/apple/swift/pull/8728","diff_url":"https://github.com/apple/swift/pull/8728.diff","patch_url":"https://github.com/apple/swift/pull/8728.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/8728","number":8728,"state":"open","locked":false,"title":"More TBDGen work","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars2.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-12T20:54:12Z","updated_at":"2017-04-12T21:20:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0668ae03bf938b6d4dd4eb8a79b47c41bc830929","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/8728/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/8728/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/8728/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/1c55175b479f222786b1b7459c1620d19f4de1e7","head":{"label":"huonw:symbol-list-4","ref":"symbol-list-4","sha":"1c55175b479f222786b1b7459c1620d19f4de1e7","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars2.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"repo":{"id":67061123,"name":"swift","full_name":"huonw/swift","owner":{"login":"huonw","id":1203825,"avatar_url":"https://avatars2.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huonw/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/huonw/swift","forks_url":"https://api.github.com/repos/huonw/swift/forks","keys_url":"https://api.github.com/repos/huonw/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huonw/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huonw/swift/teams","hooks_url":"https://api.github.com/repos/huonw/swift/hooks","issue_events_url":"https://api.github.com/repos/huonw/swift/issues/events{/number}","events_url":"https://api.github.com/repos/huonw/swift/events","assignees_url":"https://api.github.com/repos/huonw/swift/assignees{/user}","branches_url":"https://api.github.com/repos/huonw/swift/branches{/branch}","tags_url":"https://api.github.com/repos/huonw/swift/tags","blobs_url":"https://api.github.com/repos/huonw/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huonw/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huonw/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/huonw/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huonw/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/huonw/swift/languages","stargazers_url":"https://api.github.com/repos/huonw/swift/stargazers","contributors_url":"https://api.github.com/repos/huonw/swift/contributors","subscribers_url":"https://api.github.com/repos/huonw/swift/subscribers","subscription_url":"https://api.github.com/repos/huonw/swift/subscription","commits_url":"https://api.github.com/repos/huonw/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/huonw/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/huonw/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/huonw/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/huonw/swift/contents/{+path}","compare_url":"https://api.github.com/repos/huonw/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huonw/swift/merges","archive_url":"https://api.github.com/repos/huonw/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huonw/swift/downloads","issues_url":"https://api.github.com/repos/huonw/swift/issues{/number}","pulls_url":"https://api.github.com/repos/huonw/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/huonw/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/huonw/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huonw/swift/labels{/name}","releases_url":"https://api.github.com/repos/huonw/swift/releases{/id}","deployments_url":"https://api.github.com/repos/huonw/swift/deployments","created_at":"2016-08-31T18:00:30Z","updated_at":"2016-08-31T18:00:55Z","pushed_at":"2017-04-12T20:53:27Z","git_url":"git://github.com/huonw/swift.git","ssh_url":"git@github.com:huonw/swift.git","clone_url":"https://github.com/huonw/swift.git","svn_url":"https://github.com/huonw/swift","homepage":"https://swift.org/","size":178699,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"2edefb2e40735b047cd4d8372d3b0cc0c37eb983","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-04-12T20:04:41Z","pushed_at":"2017-04-12T21:13:08Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":185784,"stargazers_count":37847,"watchers_count":37847,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5626,"mirror_url":null,"open_issues_count":164,"forks":5626,"open_issues":164,"watchers":37847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/8728"},"html":{"href":"https://github.com/apple/swift/pull/8728"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/8728"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/8728/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/8728/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/8728/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/1c55175b479f222786b1b7459c1620d19f4de1e7"}}}}
{"actor":{"display_login":"slavapestov"}}