{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/4213","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/4213/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/4213/comments","events_url":"https://api.github.com/repos/minio/minio/issues/4213/events","html_url":"https://github.com/minio/minio/pull/4213","id":225530209,"number":4213,"title":"Cleanup code that checks for updates","user":{"login":"donatello","id":200059,"avatar_url":"https://avatars3.githubusercontent.com/u/200059?v=3","gravatar_id":"","url":"https://api.github.com/users/donatello","html_url":"https://github.com/donatello","followers_url":"https://api.github.com/users/donatello/followers","following_url":"https://api.github.com/users/donatello/following{/other_user}","gists_url":"https://api.github.com/users/donatello/gists{/gist_id}","starred_url":"https://api.github.com/users/donatello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donatello/subscriptions","organizations_url":"https://api.github.com/users/donatello/orgs","repos_url":"https://api.github.com/users/donatello/repos","events_url":"https://api.github.com/users/donatello/events{/privacy}","received_events_url":"https://api.github.com/users/donatello/received_events","type":"User","site_admin":false},"labels":[{"id":574009484,"url":"https://api.github.com/repos/minio/minio/labels/blocked","name":"blocked","color":"59564D","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-05-01T21:19:37Z","updated_at":"2017-05-10T17:20:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/4213","html_url":"https://github.com/minio/minio/pull/4213","diff_url":"https://github.com/minio/minio/pull/4213.diff","patch_url":"https://github.com/minio/minio/pull/4213.patch"},"body":"## Description\r\n<!--- Describe your changes in detail -->\r\nThis patch introduces a new type `updateParams` to parameterize the\r\ncode that checks for updates.\r\n\r\n* Eliminate passing variables as-is across multiple function (e.g. the\r\n  `mode` string in the earlier code).\r\n\r\n* Remove trivial functions (e.g. earlier version of `DownloadReleaseData()` and\r\n  `IsSourceBuild()`).\r\n\r\n* Maintain testability of the code.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\nCleanup for better readability and maintainability.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nExisting test cases pass (`make test`)\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/300552685","html_url":"https://github.com/minio/minio/pull/4213#issuecomment-300552685","issue_url":"https://api.github.com/repos/minio/minio/issues/4213","id":300552685,"user":{"login":"deekoder","id":1700901,"avatar_url":"https://avatars2.githubusercontent.com/u/1700901?v=3","gravatar_id":"","url":"https://api.github.com/users/deekoder","html_url":"https://github.com/deekoder","followers_url":"https://api.github.com/users/deekoder/followers","following_url":"https://api.github.com/users/deekoder/following{/other_user}","gists_url":"https://api.github.com/users/deekoder/gists{/gist_id}","starred_url":"https://api.github.com/users/deekoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deekoder/subscriptions","organizations_url":"https://api.github.com/users/deekoder/orgs","repos_url":"https://api.github.com/users/deekoder/repos","events_url":"https://api.github.com/users/deekoder/events{/privacy}","received_events_url":"https://api.github.com/users/deekoder/received_events","type":"User","site_admin":false},"created_at":"2017-05-10T17:20:58Z","updated_at":"2017-05-10T17:20:58Z","body":"@donatello  - Will have a discussion today with @abperiasamy , @krishnasrinivas  and @balamurugana "}}
{"actor":{"display_login":"deekoder"}}