{"action":"closed","number":602,"pull_request":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/602","id":116984011,"html_url":"https://github.com/Exa-Networks/exabgp/pull/602","diff_url":"https://github.com/Exa-Networks/exabgp/pull/602.diff","patch_url":"https://github.com/Exa-Networks/exabgp/pull/602.patch","issue_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/602","number":602,"state":"closed","locked":false,"title":"Add support base64 encoding the md5 password","user":{"login":"brijohn","id":776,"avatar_url":"https://avatars1.githubusercontent.com/u/776?v=3","gravatar_id":"","url":"https://api.github.com/users/brijohn","html_url":"https://github.com/brijohn","followers_url":"https://api.github.com/users/brijohn/followers","following_url":"https://api.github.com/users/brijohn/following{/other_user}","gists_url":"https://api.github.com/users/brijohn/gists{/gist_id}","starred_url":"https://api.github.com/users/brijohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijohn/subscriptions","organizations_url":"https://api.github.com/users/brijohn/orgs","repos_url":"https://api.github.com/users/brijohn/repos","events_url":"https://api.github.com/users/brijohn/events{/privacy}","received_events_url":"https://api.github.com/users/brijohn/received_events","type":"User","site_admin":false},"body":"This patch adds an option to support using base64 encoding for the md5 password. \r\n\r\nWe use this to prevent issues with md5 passwords that might contain characters, like ;,  {, } or \". Even if we quote the md5 password in the config file there will still be issues if someone passes in a string containing quote marks.\r\n\r\nBy being able to set a base64 encoded version of the password we no longer have to worry about having exabgp crash if someone sets a password containing such characters.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/exa-networks/exabgp/602)\n<!-- Reviewable:end -->\n","created_at":"2017-04-21T13:22:20Z","updated_at":"2017-04-24T10:29:25Z","closed_at":"2017-04-24T10:29:24Z","merged_at":"2017-04-24T10:29:24Z","merge_commit_sha":"0bf58b6660f64b303601409ad678d4c91063fc14","assignee":{"login":"brijohn","id":776,"avatar_url":"https://avatars1.githubusercontent.com/u/776?v=3","gravatar_id":"","url":"https://api.github.com/users/brijohn","html_url":"https://github.com/brijohn","followers_url":"https://api.github.com/users/brijohn/followers","following_url":"https://api.github.com/users/brijohn/following{/other_user}","gists_url":"https://api.github.com/users/brijohn/gists{/gist_id}","starred_url":"https://api.github.com/users/brijohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijohn/subscriptions","organizations_url":"https://api.github.com/users/brijohn/orgs","repos_url":"https://api.github.com/users/brijohn/repos","events_url":"https://api.github.com/users/brijohn/events{/privacy}","received_events_url":"https://api.github.com/users/brijohn/received_events","type":"User","site_admin":false},"assignees":[{"login":"brijohn","id":776,"avatar_url":"https://avatars1.githubusercontent.com/u/776?v=3","gravatar_id":"","url":"https://api.github.com/users/brijohn","html_url":"https://github.com/brijohn","followers_url":"https://api.github.com/users/brijohn/followers","following_url":"https://api.github.com/users/brijohn/following{/other_user}","gists_url":"https://api.github.com/users/brijohn/gists{/gist_id}","starred_url":"https://api.github.com/users/brijohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijohn/subscriptions","organizations_url":"https://api.github.com/users/brijohn/orgs","repos_url":"https://api.github.com/users/brijohn/repos","events_url":"https://api.github.com/users/brijohn/events{/privacy}","received_events_url":"https://api.github.com/users/brijohn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/602/commits","review_comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/602/comments","review_comment_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/602/comments","statuses_url":"https://api.github.com/repos/Exa-Networks/exabgp/statuses/a6ea1538842fe0ad233fd0df0251f95a295397b6","head":{"label":"brijohn:base_64_encode_md5_passwords_option","ref":"base_64_encode_md5_passwords_option","sha":"a6ea1538842fe0ad233fd0df0251f95a295397b6","user":{"login":"brijohn","id":776,"avatar_url":"https://avatars1.githubusercontent.com/u/776?v=3","gravatar_id":"","url":"https://api.github.com/users/brijohn","html_url":"https://github.com/brijohn","followers_url":"https://api.github.com/users/brijohn/followers","following_url":"https://api.github.com/users/brijohn/following{/other_user}","gists_url":"https://api.github.com/users/brijohn/gists{/gist_id}","starred_url":"https://api.github.com/users/brijohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijohn/subscriptions","organizations_url":"https://api.github.com/users/brijohn/orgs","repos_url":"https://api.github.com/users/brijohn/repos","events_url":"https://api.github.com/users/brijohn/events{/privacy}","received_events_url":"https://api.github.com/users/brijohn/received_events","type":"User","site_admin":false},"repo":{"id":65487232,"name":"exabgp","full_name":"brijohn/exabgp","owner":{"login":"brijohn","id":776,"avatar_url":"https://avatars1.githubusercontent.com/u/776?v=3","gravatar_id":"","url":"https://api.github.com/users/brijohn","html_url":"https://github.com/brijohn","followers_url":"https://api.github.com/users/brijohn/followers","following_url":"https://api.github.com/users/brijohn/following{/other_user}","gists_url":"https://api.github.com/users/brijohn/gists{/gist_id}","starred_url":"https://api.github.com/users/brijohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijohn/subscriptions","organizations_url":"https://api.github.com/users/brijohn/orgs","repos_url":"https://api.github.com/users/brijohn/repos","events_url":"https://api.github.com/users/brijohn/events{/privacy}","received_events_url":"https://api.github.com/users/brijohn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brijohn/exabgp","description":"The BGP swiss army knife of networking","fork":true,"url":"https://api.github.com/repos/brijohn/exabgp","forks_url":"https://api.github.com/repos/brijohn/exabgp/forks","keys_url":"https://api.github.com/repos/brijohn/exabgp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brijohn/exabgp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brijohn/exabgp/teams","hooks_url":"https://api.github.com/repos/brijohn/exabgp/hooks","issue_events_url":"https://api.github.com/repos/brijohn/exabgp/issues/events{/number}","events_url":"https://api.github.com/repos/brijohn/exabgp/events","assignees_url":"https://api.github.com/repos/brijohn/exabgp/assignees{/user}","branches_url":"https://api.github.com/repos/brijohn/exabgp/branches{/branch}","tags_url":"https://api.github.com/repos/brijohn/exabgp/tags","blobs_url":"https://api.github.com/repos/brijohn/exabgp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brijohn/exabgp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brijohn/exabgp/git/refs{/sha}","trees_url":"https://api.github.com/repos/brijohn/exabgp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brijohn/exabgp/statuses/{sha}","languages_url":"https://api.github.com/repos/brijohn/exabgp/languages","stargazers_url":"https://api.github.com/repos/brijohn/exabgp/stargazers","contributors_url":"https://api.github.com/repos/brijohn/exabgp/contributors","subscribers_url":"https://api.github.com/repos/brijohn/exabgp/subscribers","subscription_url":"https://api.github.com/repos/brijohn/exabgp/subscription","commits_url":"https://api.github.com/repos/brijohn/exabgp/commits{/sha}","git_commits_url":"https://api.github.com/repos/brijohn/exabgp/git/commits{/sha}","comments_url":"https://api.github.com/repos/brijohn/exabgp/comments{/number}","issue_comment_url":"https://api.github.com/repos/brijohn/exabgp/issues/comments{/number}","contents_url":"https://api.github.com/repos/brijohn/exabgp/contents/{+path}","compare_url":"https://api.github.com/repos/brijohn/exabgp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brijohn/exabgp/merges","archive_url":"https://api.github.com/repos/brijohn/exabgp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brijohn/exabgp/downloads","issues_url":"https://api.github.com/repos/brijohn/exabgp/issues{/number}","pulls_url":"https://api.github.com/repos/brijohn/exabgp/pulls{/number}","milestones_url":"https://api.github.com/repos/brijohn/exabgp/milestones{/number}","notifications_url":"https://api.github.com/repos/brijohn/exabgp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brijohn/exabgp/labels{/name}","releases_url":"https://api.github.com/repos/brijohn/exabgp/releases{/id}","deployments_url":"https://api.github.com/repos/brijohn/exabgp/deployments","created_at":"2016-08-11T17:11:12Z","updated_at":"2016-08-11T17:11:14Z","pushed_at":"2017-04-20T18:28:34Z","git_url":"git://github.com/brijohn/exabgp.git","ssh_url":"git@github.com:brijohn/exabgp.git","clone_url":"https://github.com/brijohn/exabgp.git","svn_url":"https://github.com/brijohn/exabgp","homepage":null,"size":10979,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Exa-Networks:master","ref":"master","sha":"a2a7ccade4fee2620e58f75837ce590725b91042","user":{"login":"Exa-Networks","id":5339170,"avatar_url":"https://avatars3.githubusercontent.com/u/5339170?v=3","gravatar_id":"","url":"https://api.github.com/users/Exa-Networks","html_url":"https://github.com/Exa-Networks","followers_url":"https://api.github.com/users/Exa-Networks/followers","following_url":"https://api.github.com/users/Exa-Networks/following{/other_user}","gists_url":"https://api.github.com/users/Exa-Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/Exa-Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exa-Networks/subscriptions","organizations_url":"https://api.github.com/users/Exa-Networks/orgs","repos_url":"https://api.github.com/users/Exa-Networks/repos","events_url":"https://api.github.com/users/Exa-Networks/events{/privacy}","received_events_url":"https://api.github.com/users/Exa-Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":12407457,"name":"exabgp","full_name":"Exa-Networks/exabgp","owner":{"login":"Exa-Networks","id":5339170,"avatar_url":"https://avatars3.githubusercontent.com/u/5339170?v=3","gravatar_id":"","url":"https://api.github.com/users/Exa-Networks","html_url":"https://github.com/Exa-Networks","followers_url":"https://api.github.com/users/Exa-Networks/followers","following_url":"https://api.github.com/users/Exa-Networks/following{/other_user}","gists_url":"https://api.github.com/users/Exa-Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/Exa-Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exa-Networks/subscriptions","organizations_url":"https://api.github.com/users/Exa-Networks/orgs","repos_url":"https://api.github.com/users/Exa-Networks/repos","events_url":"https://api.github.com/users/Exa-Networks/events{/privacy}","received_events_url":"https://api.github.com/users/Exa-Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exa-Networks/exabgp","description":"The BGP swiss army knife of networking","fork":false,"url":"https://api.github.com/repos/Exa-Networks/exabgp","forks_url":"https://api.github.com/repos/Exa-Networks/exabgp/forks","keys_url":"https://api.github.com/repos/Exa-Networks/exabgp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exa-Networks/exabgp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exa-Networks/exabgp/teams","hooks_url":"https://api.github.com/repos/Exa-Networks/exabgp/hooks","issue_events_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/events{/number}","events_url":"https://api.github.com/repos/Exa-Networks/exabgp/events","assignees_url":"https://api.github.com/repos/Exa-Networks/exabgp/assignees{/user}","branches_url":"https://api.github.com/repos/Exa-Networks/exabgp/branches{/branch}","tags_url":"https://api.github.com/repos/Exa-Networks/exabgp/tags","blobs_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exa-Networks/exabgp/statuses/{sha}","languages_url":"https://api.github.com/repos/Exa-Networks/exabgp/languages","stargazers_url":"https://api.github.com/repos/Exa-Networks/exabgp/stargazers","contributors_url":"https://api.github.com/repos/Exa-Networks/exabgp/contributors","subscribers_url":"https://api.github.com/repos/Exa-Networks/exabgp/subscribers","subscription_url":"https://api.github.com/repos/Exa-Networks/exabgp/subscription","commits_url":"https://api.github.com/repos/Exa-Networks/exabgp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exa-Networks/exabgp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exa-Networks/exabgp/contents/{+path}","compare_url":"https://api.github.com/repos/Exa-Networks/exabgp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exa-Networks/exabgp/merges","archive_url":"https://api.github.com/repos/Exa-Networks/exabgp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exa-Networks/exabgp/downloads","issues_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues{/number}","pulls_url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls{/number}","milestones_url":"https://api.github.com/repos/Exa-Networks/exabgp/milestones{/number}","notifications_url":"https://api.github.com/repos/Exa-Networks/exabgp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exa-Networks/exabgp/labels{/name}","releases_url":"https://api.github.com/repos/Exa-Networks/exabgp/releases{/id}","deployments_url":"https://api.github.com/repos/Exa-Networks/exabgp/deployments","created_at":"2013-08-27T13:56:08Z","updated_at":"2017-04-21T15:49:15Z","pushed_at":"2017-04-24T10:29:24Z","git_url":"git://github.com/Exa-Networks/exabgp.git","ssh_url":"git@github.com:Exa-Networks/exabgp.git","clone_url":"https://github.com/Exa-Networks/exabgp.git","svn_url":"https://github.com/Exa-Networks/exabgp","homepage":null,"size":11043,"stargazers_count":840,"watchers_count":840,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"open_issues_count":60,"forks":215,"open_issues":60,"watchers":840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/602"},"html":{"href":"https://github.com/Exa-Networks/exabgp/pull/602"},"issue":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/issues/602"},"comments":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/Exa-Networks/exabgp/statuses/a6ea1538842fe0ad233fd0df0251f95a295397b6"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"thomas-mangin","id":1227755,"avatar_url":"https://avatars3.githubusercontent.com/u/1227755?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-mangin","html_url":"https://github.com/thomas-mangin","followers_url":"https://api.github.com/users/thomas-mangin/followers","following_url":"https://api.github.com/users/thomas-mangin/following{/other_user}","gists_url":"https://api.github.com/users/thomas-mangin/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-mangin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-mangin/subscriptions","organizations_url":"https://api.github.com/users/thomas-mangin/orgs","repos_url":"https://api.github.com/users/thomas-mangin/repos","events_url":"https://api.github.com/users/thomas-mangin/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-mangin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":36,"deletions":12,"changed_files":9}}
{"actor":{"display_login":"thomas-mangin"}}