{"action":"created","comment":{"url":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments/156936946","pull_request_review_id":83494547,"id":156936946,"diff_hunk":"@@ -105,10 +105,10 @@ export default class ContextMenu extends React.Component {\n     const { sampleID, defaultParameters, shape, sampleData } = this.props;\n     const sid = _shape ? _shape.id : shape.id;\n \n-    if (this.props.clickCentring) {\n-      this.props.sampleActions.stopClickCentring();","path":"mxcube3/ui/components/SampleView/ContextMenu.js","position":5,"original_position":5,"commit_id":"3f6961f24e757ead4cf1837e5289c140d77727b0","original_commit_id":"8478024a141e0386ca34f5adeeea9b4f91494746","user":{"login":"marcus-oscarsson","id":4331447,"avatar_url":"https://avatars0.githubusercontent.com/u/4331447?v=4","gravatar_id":"","url":"https://api.github.com/users/marcus-oscarsson","html_url":"https://github.com/marcus-oscarsson","followers_url":"https://api.github.com/users/marcus-oscarsson/followers","following_url":"https://api.github.com/users/marcus-oscarsson/following{/other_user}","gists_url":"https://api.github.com/users/marcus-oscarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/marcus-oscarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcus-oscarsson/subscriptions","organizations_url":"https://api.github.com/users/marcus-oscarsson/orgs","repos_url":"https://api.github.com/users/marcus-oscarsson/repos","events_url":"https://api.github.com/users/marcus-oscarsson/events{/privacy}","received_events_url":"https://api.github.com/users/marcus-oscarsson/received_events","type":"User","site_admin":false},"body":"This seems strange to me, why do we need to stop a click centering which is not started ?\r\n\r\nThe 2D centring routine should either start a click centring, or if its not really a click centering but translation of sampx sampy, just do sendAddShape or maybe sendAcceptCentring.\r\n\r\nI dont know exactly how your 2D centring is implemented, is it simply a call to move to beam ?\r\n\r\n\r\n\r\n","created_at":"2017-12-14T13:01:35Z","updated_at":"2017-12-14T13:01:35Z","html_url":"https://github.com/mxcube/mxcube3/pull/719#discussion_r156936946","pull_request_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/719","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments/156936946"},"html":{"href":"https://github.com/mxcube/mxcube3/pull/719#discussion_r156936946"},"pull_request":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/719"}}},"pull_request":{"url":"https://api.github.com/repos/mxcube/mxcube3/pulls/719","id":157585176,"html_url":"https://github.com/mxcube/mxcube3/pull/719","diff_url":"https://github.com/mxcube/mxcube3/pull/719.diff","patch_url":"https://github.com/mxcube/mxcube3/pull/719.patch","issue_url":"https://api.github.com/repos/mxcube/mxcube3/issues/719","number":719,"state":"open","locked":false,"title":"[WIP] various fixes","user":{"login":"meguiraun","id":12758327,"avatar_url":"https://avatars3.githubusercontent.com/u/12758327?v=4","gravatar_id":"","url":"https://api.github.com/users/meguiraun","html_url":"https://github.com/meguiraun","followers_url":"https://api.github.com/users/meguiraun/followers","following_url":"https://api.github.com/users/meguiraun/following{/other_user}","gists_url":"https://api.github.com/users/meguiraun/gists{/gist_id}","starred_url":"https://api.github.com/users/meguiraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meguiraun/subscriptions","organizations_url":"https://api.github.com/users/meguiraun/orgs","repos_url":"https://api.github.com/users/meguiraun/repos","events_url":"https://api.github.com/users/meguiraun/events{/privacy}","received_events_url":"https://api.github.com/users/meguiraun/received_events","type":"User","site_admin":false},"body":"Hej,\r\n\r\nA temporary PR for fixes. Some are only relevant to us (like the prepare_beamline on new sample, in manual mode), and the dc link for non exi.\r\n\r\nI found a few bugs with the centring mechanism when several points are on the canvas, point selection has a bug that prevents working with helical under some circumstances (like removing points before), added Cryo, transmission and Mach Info, and default number of snapshot in  the mxcollect.xml.\r\n\r\nI am doing this PR so you can see and perhaps cherry-pick fixes if you cannot wait, I still need to apply these on master to be mergeable.\r\n\r\n","created_at":"2017-12-11T15:02:01Z","updated_at":"2017-12-14T13:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/719/commits","review_comments_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/719/comments","review_comment_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxcube/mxcube3/issues/719/comments","statuses_url":"https://api.github.com/repos/mxcube/mxcube3/statuses/3f6961f24e757ead4cf1837e5289c140d77727b0","head":{"label":"meguiraun:fixes_users","ref":"fixes_users","sha":"3f6961f24e757ead4cf1837e5289c140d77727b0","user":{"login":"meguiraun","id":12758327,"avatar_url":"https://avatars3.githubusercontent.com/u/12758327?v=4","gravatar_id":"","url":"https://api.github.com/users/meguiraun","html_url":"https://github.com/meguiraun","followers_url":"https://api.github.com/users/meguiraun/followers","following_url":"https://api.github.com/users/meguiraun/following{/other_user}","gists_url":"https://api.github.com/users/meguiraun/gists{/gist_id}","starred_url":"https://api.github.com/users/meguiraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meguiraun/subscriptions","organizations_url":"https://api.github.com/users/meguiraun/orgs","repos_url":"https://api.github.com/users/meguiraun/repos","events_url":"https://api.github.com/users/meguiraun/events{/privacy}","received_events_url":"https://api.github.com/users/meguiraun/received_events","type":"User","site_admin":false},"repo":{"id":47250838,"name":"mxcube3","full_name":"meguiraun/mxcube3","owner":{"login":"meguiraun","id":12758327,"avatar_url":"https://avatars3.githubusercontent.com/u/12758327?v=4","gravatar_id":"","url":"https://api.github.com/users/meguiraun","html_url":"https://github.com/meguiraun","followers_url":"https://api.github.com/users/meguiraun/followers","following_url":"https://api.github.com/users/meguiraun/following{/other_user}","gists_url":"https://api.github.com/users/meguiraun/gists{/gist_id}","starred_url":"https://api.github.com/users/meguiraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meguiraun/subscriptions","organizations_url":"https://api.github.com/users/meguiraun/orgs","repos_url":"https://api.github.com/users/meguiraun/repos","events_url":"https://api.github.com/users/meguiraun/events{/privacy}","received_events_url":"https://api.github.com/users/meguiraun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meguiraun/mxcube3","description":"MXCuBE 3 (web)","fork":true,"url":"https://api.github.com/repos/meguiraun/mxcube3","forks_url":"https://api.github.com/repos/meguiraun/mxcube3/forks","keys_url":"https://api.github.com/repos/meguiraun/mxcube3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meguiraun/mxcube3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meguiraun/mxcube3/teams","hooks_url":"https://api.github.com/repos/meguiraun/mxcube3/hooks","issue_events_url":"https://api.github.com/repos/meguiraun/mxcube3/issues/events{/number}","events_url":"https://api.github.com/repos/meguiraun/mxcube3/events","assignees_url":"https://api.github.com/repos/meguiraun/mxcube3/assignees{/user}","branches_url":"https://api.github.com/repos/meguiraun/mxcube3/branches{/branch}","tags_url":"https://api.github.com/repos/meguiraun/mxcube3/tags","blobs_url":"https://api.github.com/repos/meguiraun/mxcube3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meguiraun/mxcube3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meguiraun/mxcube3/git/refs{/sha}","trees_url":"https://api.github.com/repos/meguiraun/mxcube3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meguiraun/mxcube3/statuses/{sha}","languages_url":"https://api.github.com/repos/meguiraun/mxcube3/languages","stargazers_url":"https://api.github.com/repos/meguiraun/mxcube3/stargazers","contributors_url":"https://api.github.com/repos/meguiraun/mxcube3/contributors","subscribers_url":"https://api.github.com/repos/meguiraun/mxcube3/subscribers","subscription_url":"https://api.github.com/repos/meguiraun/mxcube3/subscription","commits_url":"https://api.github.com/repos/meguiraun/mxcube3/commits{/sha}","git_commits_url":"https://api.github.com/repos/meguiraun/mxcube3/git/commits{/sha}","comments_url":"https://api.github.com/repos/meguiraun/mxcube3/comments{/number}","issue_comment_url":"https://api.github.com/repos/meguiraun/mxcube3/issues/comments{/number}","contents_url":"https://api.github.com/repos/meguiraun/mxcube3/contents/{+path}","compare_url":"https://api.github.com/repos/meguiraun/mxcube3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meguiraun/mxcube3/merges","archive_url":"https://api.github.com/repos/meguiraun/mxcube3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meguiraun/mxcube3/downloads","issues_url":"https://api.github.com/repos/meguiraun/mxcube3/issues{/number}","pulls_url":"https://api.github.com/repos/meguiraun/mxcube3/pulls{/number}","milestones_url":"https://api.github.com/repos/meguiraun/mxcube3/milestones{/number}","notifications_url":"https://api.github.com/repos/meguiraun/mxcube3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meguiraun/mxcube3/labels{/name}","releases_url":"https://api.github.com/repos/meguiraun/mxcube3/releases{/id}","deployments_url":"https://api.github.com/repos/meguiraun/mxcube3/deployments","created_at":"2015-12-02T09:30:42Z","updated_at":"2016-01-12T11:11:55Z","pushed_at":"2017-12-11T14:56:02Z","git_url":"git://github.com/meguiraun/mxcube3.git","ssh_url":"git@github.com:meguiraun/mxcube3.git","clone_url":"https://github.com/meguiraun/mxcube3.git","svn_url":"https://github.com/meguiraun/mxcube3","homepage":null,"size":4990,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mxcube:master","ref":"master","sha":"a105c1e88cff5d9abae949ee1a4ceb222d6c5f52","user":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars2.githubusercontent.com/u/4322027?v=4","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"repo":{"id":42655839,"name":"mxcube3","full_name":"mxcube/mxcube3","owner":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars2.githubusercontent.com/u/4322027?v=4","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mxcube/mxcube3","description":"MXCuBE 3 (web)","fork":false,"url":"https://api.github.com/repos/mxcube/mxcube3","forks_url":"https://api.github.com/repos/mxcube/mxcube3/forks","keys_url":"https://api.github.com/repos/mxcube/mxcube3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxcube/mxcube3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxcube/mxcube3/teams","hooks_url":"https://api.github.com/repos/mxcube/mxcube3/hooks","issue_events_url":"https://api.github.com/repos/mxcube/mxcube3/issues/events{/number}","events_url":"https://api.github.com/repos/mxcube/mxcube3/events","assignees_url":"https://api.github.com/repos/mxcube/mxcube3/assignees{/user}","branches_url":"https://api.github.com/repos/mxcube/mxcube3/branches{/branch}","tags_url":"https://api.github.com/repos/mxcube/mxcube3/tags","blobs_url":"https://api.github.com/repos/mxcube/mxcube3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxcube/mxcube3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxcube/mxcube3/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxcube/mxcube3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxcube/mxcube3/statuses/{sha}","languages_url":"https://api.github.com/repos/mxcube/mxcube3/languages","stargazers_url":"https://api.github.com/repos/mxcube/mxcube3/stargazers","contributors_url":"https://api.github.com/repos/mxcube/mxcube3/contributors","subscribers_url":"https://api.github.com/repos/mxcube/mxcube3/subscribers","subscription_url":"https://api.github.com/repos/mxcube/mxcube3/subscription","commits_url":"https://api.github.com/repos/mxcube/mxcube3/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxcube/mxcube3/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxcube/mxcube3/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxcube/mxcube3/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxcube/mxcube3/contents/{+path}","compare_url":"https://api.github.com/repos/mxcube/mxcube3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxcube/mxcube3/merges","archive_url":"https://api.github.com/repos/mxcube/mxcube3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxcube/mxcube3/downloads","issues_url":"https://api.github.com/repos/mxcube/mxcube3/issues{/number}","pulls_url":"https://api.github.com/repos/mxcube/mxcube3/pulls{/number}","milestones_url":"https://api.github.com/repos/mxcube/mxcube3/milestones{/number}","notifications_url":"https://api.github.com/repos/mxcube/mxcube3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxcube/mxcube3/labels{/name}","releases_url":"https://api.github.com/repos/mxcube/mxcube3/releases{/id}","deployments_url":"https://api.github.com/repos/mxcube/mxcube3/deployments","created_at":"2015-09-17T12:47:34Z","updated_at":"2017-11-23T16:57:30Z","pushed_at":"2017-12-14T10:09:10Z","git_url":"git://github.com/mxcube/mxcube3.git","ssh_url":"git@github.com:mxcube/mxcube3.git","clone_url":"https://github.com/mxcube/mxcube3.git","svn_url":"https://github.com/mxcube/mxcube3","homepage":null,"size":5081,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":13,"open_issues":29,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/719"},"html":{"href":"https://github.com/mxcube/mxcube3/pull/719"},"issue":{"href":"https://api.github.com/repos/mxcube/mxcube3/issues/719"},"comments":{"href":"https://api.github.com/repos/mxcube/mxcube3/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/mxcube/mxcube3/statuses/3f6961f24e757ead4cf1837e5289c140d77727b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marcus-oscarsson"}}