{"action":"created","comment":{"url":"https://api.github.com/repos/zoyi/bingodb/pulls/comments/139878509","pull_request_review_id":63869319,"id":139878509,"diff_hunk":"@@ -31,22 +31,24 @@ func (doc *Document) Merge(op *Document) *Document {\n \treturn &Document{data: newbie, schema: doc.schema}\n }\n \n-func ParseDoc(data *Data, schema *TableSchema) *Document {\n+func ParseDoc(data *Data, schema *TableSchema) (*Document, bool) {\n+\t//for doc, parsing nil equivalent to success\n \tif data == nil {\n-\t\treturn nil\n+\t\treturn nil, true\n \t}\n+\n \tfor _, field := range schema.fields {\n \t\traw, present := (*data)[field.Name]\n \t\tif present {\n \t\t\tval, ok := field.Parse(raw)\n \t\t\tif !ok {\n-\t\t\t\tcontinue\n+\t\t\t\treturn nil, false","path":"document.go","position":18,"original_position":18,"commit_id":"bc207aceced6bb9ca98a44040d14f0caedf5b8fb","original_commit_id":"bc207aceced6bb9ca98a44040d14f0caedf5b8fb","user":{"login":"siwonred","id":316726,"avatar_url":"https://avatars1.githubusercontent.com/u/316726?v=4","gravatar_id":"","url":"https://api.github.com/users/siwonred","html_url":"https://github.com/siwonred","followers_url":"https://api.github.com/users/siwonred/followers","following_url":"https://api.github.com/users/siwonred/following{/other_user}","gists_url":"https://api.github.com/users/siwonred/gists{/gist_id}","starred_url":"https://api.github.com/users/siwonred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siwonred/subscriptions","organizations_url":"https://api.github.com/users/siwonred/orgs","repos_url":"https://api.github.com/users/siwonred/repos","events_url":"https://api.github.com/users/siwonred/events{/privacy}","received_events_url":"https://api.github.com/users/siwonred/received_events","type":"User","site_admin":false},"body":"return nil, err","created_at":"2017-09-20T05:33:13Z","updated_at":"2017-09-20T05:33:30Z","html_url":"https://github.com/zoyi/bingodb/pull/39#discussion_r139878509","pull_request_url":"https://api.github.com/repos/zoyi/bingodb/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zoyi/bingodb/pulls/comments/139878509"},"html":{"href":"https://github.com/zoyi/bingodb/pull/39#discussion_r139878509"},"pull_request":{"href":"https://api.github.com/repos/zoyi/bingodb/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/zoyi/bingodb/pulls/39","id":141798617,"html_url":"https://github.com/zoyi/bingodb/pull/39","diff_url":"https://github.com/zoyi/bingodb/pull/39.diff","patch_url":"https://github.com/zoyi/bingodb/pull/39.patch","issue_url":"https://api.github.com/repos/zoyi/bingodb/issues/39","number":39,"state":"open","locked":false,"title":"Added expiresAt for Put validation","user":{"login":"intoxicated","id":848531,"avatar_url":"https://avatars3.githubusercontent.com/u/848531?v=4","gravatar_id":"","url":"https://api.github.com/users/intoxicated","html_url":"https://github.com/intoxicated","followers_url":"https://api.github.com/users/intoxicated/followers","following_url":"https://api.github.com/users/intoxicated/following{/other_user}","gists_url":"https://api.github.com/users/intoxicated/gists{/gist_id}","starred_url":"https://api.github.com/users/intoxicated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intoxicated/subscriptions","organizations_url":"https://api.github.com/users/intoxicated/orgs","repos_url":"https://api.github.com/users/intoxicated/repos","events_url":"https://api.github.com/users/intoxicated/events{/privacy}","received_events_url":"https://api.github.com/users/intoxicated/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-19T09:25:44Z","updated_at":"2017-09-20T05:33:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"472d8ac768b3a5626b0998d6c331c52d61ea489a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zoyi/bingodb/pulls/39/commits","review_comments_url":"https://api.github.com/repos/zoyi/bingodb/pulls/39/comments","review_comment_url":"https://api.github.com/repos/zoyi/bingodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zoyi/bingodb/issues/39/comments","statuses_url":"https://api.github.com/repos/zoyi/bingodb/statuses/bc207aceced6bb9ca98a44040d14f0caedf5b8fb","head":{"label":"zoyi:hotfix/validate_expiresAt","ref":"hotfix/validate_expiresAt","sha":"bc207aceced6bb9ca98a44040d14f0caedf5b8fb","user":{"login":"zoyi","id":2077024,"avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"repo":{"id":93488199,"name":"bingodb","full_name":"zoyi/bingodb","owner":{"login":"zoyi","id":2077024,"avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zoyi/bingodb","description":null,"fork":false,"url":"https://api.github.com/repos/zoyi/bingodb","forks_url":"https://api.github.com/repos/zoyi/bingodb/forks","keys_url":"https://api.github.com/repos/zoyi/bingodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zoyi/bingodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zoyi/bingodb/teams","hooks_url":"https://api.github.com/repos/zoyi/bingodb/hooks","issue_events_url":"https://api.github.com/repos/zoyi/bingodb/issues/events{/number}","events_url":"https://api.github.com/repos/zoyi/bingodb/events","assignees_url":"https://api.github.com/repos/zoyi/bingodb/assignees{/user}","branches_url":"https://api.github.com/repos/zoyi/bingodb/branches{/branch}","tags_url":"https://api.github.com/repos/zoyi/bingodb/tags","blobs_url":"https://api.github.com/repos/zoyi/bingodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zoyi/bingodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zoyi/bingodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zoyi/bingodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zoyi/bingodb/statuses/{sha}","languages_url":"https://api.github.com/repos/zoyi/bingodb/languages","stargazers_url":"https://api.github.com/repos/zoyi/bingodb/stargazers","contributors_url":"https://api.github.com/repos/zoyi/bingodb/contributors","subscribers_url":"https://api.github.com/repos/zoyi/bingodb/subscribers","subscription_url":"https://api.github.com/repos/zoyi/bingodb/subscription","commits_url":"https://api.github.com/repos/zoyi/bingodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zoyi/bingodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zoyi/bingodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zoyi/bingodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zoyi/bingodb/contents/{+path}","compare_url":"https://api.github.com/repos/zoyi/bingodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zoyi/bingodb/merges","archive_url":"https://api.github.com/repos/zoyi/bingodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zoyi/bingodb/downloads","issues_url":"https://api.github.com/repos/zoyi/bingodb/issues{/number}","pulls_url":"https://api.github.com/repos/zoyi/bingodb/pulls{/number}","milestones_url":"https://api.github.com/repos/zoyi/bingodb/milestones{/number}","notifications_url":"https://api.github.com/repos/zoyi/bingodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zoyi/bingodb/labels{/name}","releases_url":"https://api.github.com/repos/zoyi/bingodb/releases{/id}","deployments_url":"https://api.github.com/repos/zoyi/bingodb/deployments","created_at":"2017-06-06T07:18:33Z","updated_at":"2017-09-06T04:42:05Z","pushed_at":"2017-09-20T05:17:46Z","git_url":"git://github.com/zoyi/bingodb.git","ssh_url":"git@github.com:zoyi/bingodb.git","clone_url":"https://github.com/zoyi/bingodb.git","svn_url":"https://github.com/zoyi/bingodb","homepage":null,"size":443,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"zoyi:master","ref":"master","sha":"2fa04560245415a5fda4985ae10af026bfca33ce","user":{"login":"zoyi","id":2077024,"avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"repo":{"id":93488199,"name":"bingodb","full_name":"zoyi/bingodb","owner":{"login":"zoyi","id":2077024,"avatar_url":"https://avatars1.githubusercontent.com/u/2077024?v=4","gravatar_id":"","url":"https://api.github.com/users/zoyi","html_url":"https://github.com/zoyi","followers_url":"https://api.github.com/users/zoyi/followers","following_url":"https://api.github.com/users/zoyi/following{/other_user}","gists_url":"https://api.github.com/users/zoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoyi/subscriptions","organizations_url":"https://api.github.com/users/zoyi/orgs","repos_url":"https://api.github.com/users/zoyi/repos","events_url":"https://api.github.com/users/zoyi/events{/privacy}","received_events_url":"https://api.github.com/users/zoyi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zoyi/bingodb","description":null,"fork":false,"url":"https://api.github.com/repos/zoyi/bingodb","forks_url":"https://api.github.com/repos/zoyi/bingodb/forks","keys_url":"https://api.github.com/repos/zoyi/bingodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zoyi/bingodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zoyi/bingodb/teams","hooks_url":"https://api.github.com/repos/zoyi/bingodb/hooks","issue_events_url":"https://api.github.com/repos/zoyi/bingodb/issues/events{/number}","events_url":"https://api.github.com/repos/zoyi/bingodb/events","assignees_url":"https://api.github.com/repos/zoyi/bingodb/assignees{/user}","branches_url":"https://api.github.com/repos/zoyi/bingodb/branches{/branch}","tags_url":"https://api.github.com/repos/zoyi/bingodb/tags","blobs_url":"https://api.github.com/repos/zoyi/bingodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zoyi/bingodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zoyi/bingodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zoyi/bingodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zoyi/bingodb/statuses/{sha}","languages_url":"https://api.github.com/repos/zoyi/bingodb/languages","stargazers_url":"https://api.github.com/repos/zoyi/bingodb/stargazers","contributors_url":"https://api.github.com/repos/zoyi/bingodb/contributors","subscribers_url":"https://api.github.com/repos/zoyi/bingodb/subscribers","subscription_url":"https://api.github.com/repos/zoyi/bingodb/subscription","commits_url":"https://api.github.com/repos/zoyi/bingodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zoyi/bingodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zoyi/bingodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zoyi/bingodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zoyi/bingodb/contents/{+path}","compare_url":"https://api.github.com/repos/zoyi/bingodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zoyi/bingodb/merges","archive_url":"https://api.github.com/repos/zoyi/bingodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zoyi/bingodb/downloads","issues_url":"https://api.github.com/repos/zoyi/bingodb/issues{/number}","pulls_url":"https://api.github.com/repos/zoyi/bingodb/pulls{/number}","milestones_url":"https://api.github.com/repos/zoyi/bingodb/milestones{/number}","notifications_url":"https://api.github.com/repos/zoyi/bingodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zoyi/bingodb/labels{/name}","releases_url":"https://api.github.com/repos/zoyi/bingodb/releases{/id}","deployments_url":"https://api.github.com/repos/zoyi/bingodb/deployments","created_at":"2017-06-06T07:18:33Z","updated_at":"2017-09-06T04:42:05Z","pushed_at":"2017-09-20T05:17:46Z","git_url":"git://github.com/zoyi/bingodb.git","ssh_url":"git@github.com:zoyi/bingodb.git","clone_url":"https://github.com/zoyi/bingodb.git","svn_url":"https://github.com/zoyi/bingodb","homepage":null,"size":443,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zoyi/bingodb/pulls/39"},"html":{"href":"https://github.com/zoyi/bingodb/pull/39"},"issue":{"href":"https://api.github.com/repos/zoyi/bingodb/issues/39"},"comments":{"href":"https://api.github.com/repos/zoyi/bingodb/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/zoyi/bingodb/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/zoyi/bingodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zoyi/bingodb/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/zoyi/bingodb/statuses/bc207aceced6bb9ca98a44040d14f0caedf5b8fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"siwonred"}}