{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/108735041","pull_request_review_id":29786338,"id":108735041,"diff_hunk":"@@ -333,11 +333,17 @@ class VariantDatasetFunctions(private val vds: VariantSampleMatrix[Genotype]) ex\n     val (paths, types, f) = Parser.parseAnnotationExprs(expr, ec, Some(Annotation.VARIANT_HEAD))\n \n     val inserterBuilder = mutable.ArrayBuilder.make[Inserter]\n-    val finalType = (paths, types).zipped.foldLeft(vds.vaSignature) { case (vas, (ids, signature)) =>\n+    val newType = (paths, types).zipped.foldLeft(vds.vaSignature) { case (vas, (ids, signature)) =>\n       val (s, i) = vas.insert(TArray(signature), ids)\n       inserterBuilder += i\n       s\n     }\n+    val finalType = if (newType.isInstanceOf[TStruct])\n+      paths.foldLeft(newType.asInstanceOf[TStruct]) {\n+        case (res, path) => res.setFieldAttributes(path, Map(\"Number\" -> \"A\"))","path":"src/main/scala/is/hail/variant/VariantDataset.scala","position":12,"original_position":12,"commit_id":"6926a6bc86e4112cc937a12bad68806455a33fd3","original_commit_id":"6926a6bc86e4112cc937a12bad68806455a33fd3","user":{"login":"lfrancioli","id":3502465,"avatar_url":"https://avatars2.githubusercontent.com/u/3502465?v=3","gravatar_id":"","url":"https://api.github.com/users/lfrancioli","html_url":"https://github.com/lfrancioli","followers_url":"https://api.github.com/users/lfrancioli/followers","following_url":"https://api.github.com/users/lfrancioli/following{/other_user}","gists_url":"https://api.github.com/users/lfrancioli/gists{/gist_id}","starred_url":"https://api.github.com/users/lfrancioli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfrancioli/subscriptions","organizations_url":"https://api.github.com/users/lfrancioli/orgs","repos_url":"https://api.github.com/users/lfrancioli/repos","events_url":"https://api.github.com/users/lfrancioli/events{/privacy}","received_events_url":"https://api.github.com/users/lfrancioli/received_events","type":"User","site_admin":false},"body":"So we actually use this also for VDSs. Because there is no concept of A-arrays, we set this attribute and then rely on it for automatically splitting the array when calling split-multi. Ideally I'd really want an AArray type.","created_at":"2017-03-29T17:19:07Z","updated_at":"2017-03-29T17:19:07Z","html_url":"https://github.com/hail-is/hail/pull/1557#discussion_r108735041","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/1557","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/108735041"},"html":{"href":"https://github.com/hail-is/hail/pull/1557#discussion_r108735041"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1557"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/1557","id":111151367,"html_url":"https://github.com/hail-is/hail/pull/1557","diff_url":"https://github.com/hail-is/hail/pull/1557.diff","patch_url":"https://github.com/hail-is/hail/pull/1557.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/1557","number":1557,"state":"open","locked":false,"title":"Added get_va_attributse, set_va_attributes and delete_va_attribute","user":{"login":"lfrancioli","id":3502465,"avatar_url":"https://avatars2.githubusercontent.com/u/3502465?v=3","gravatar_id":"","url":"https://api.github.com/users/lfrancioli","html_url":"https://github.com/lfrancioli","followers_url":"https://api.github.com/users/lfrancioli/followers","following_url":"https://api.github.com/users/lfrancioli/following{/other_user}","gists_url":"https://api.github.com/users/lfrancioli/gists{/gist_id}","starred_url":"https://api.github.com/users/lfrancioli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfrancioli/subscriptions","organizations_url":"https://api.github.com/users/lfrancioli/orgs","repos_url":"https://api.github.com/users/lfrancioli/repos","events_url":"https://api.github.com/users/lfrancioli/events{/privacy}","received_events_url":"https://api.github.com/users/lfrancioli/received_events","type":"User","site_admin":false},"body":"The functions expose Field attributes (useful for VCF header)\r\n- Annotations generated using annotate_alleles_expr now have 'Number=A'\r\n- VEP now parses the Description when using csq=True option (required to know the fields stored in the  |-delimited field)","created_at":"2017-03-16T19:51:01Z","updated_at":"2017-03-29T17:19:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e580f53462ef70770aec774e477cbce22c1971a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/1557/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/1557/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/1557/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/6926a6bc86e4112cc937a12bad68806455a33fd3","head":{"label":"lfrancioli:lf_attributes","ref":"lf_attributes","sha":"6926a6bc86e4112cc937a12bad68806455a33fd3","user":{"login":"lfrancioli","id":3502465,"avatar_url":"https://avatars2.githubusercontent.com/u/3502465?v=3","gravatar_id":"","url":"https://api.github.com/users/lfrancioli","html_url":"https://github.com/lfrancioli","followers_url":"https://api.github.com/users/lfrancioli/followers","following_url":"https://api.github.com/users/lfrancioli/following{/other_user}","gists_url":"https://api.github.com/users/lfrancioli/gists{/gist_id}","starred_url":"https://api.github.com/users/lfrancioli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfrancioli/subscriptions","organizations_url":"https://api.github.com/users/lfrancioli/orgs","repos_url":"https://api.github.com/users/lfrancioli/repos","events_url":"https://api.github.com/users/lfrancioli/events{/privacy}","received_events_url":"https://api.github.com/users/lfrancioli/received_events","type":"User","site_admin":false},"repo":{"id":64695684,"name":"hail","full_name":"lfrancioli/hail","owner":{"login":"lfrancioli","id":3502465,"avatar_url":"https://avatars2.githubusercontent.com/u/3502465?v=3","gravatar_id":"","url":"https://api.github.com/users/lfrancioli","html_url":"https://github.com/lfrancioli","followers_url":"https://api.github.com/users/lfrancioli/followers","following_url":"https://api.github.com/users/lfrancioli/following{/other_user}","gists_url":"https://api.github.com/users/lfrancioli/gists{/gist_id}","starred_url":"https://api.github.com/users/lfrancioli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfrancioli/subscriptions","organizations_url":"https://api.github.com/users/lfrancioli/orgs","repos_url":"https://api.github.com/users/lfrancioli/repos","events_url":"https://api.github.com/users/lfrancioli/events{/privacy}","received_events_url":"https://api.github.com/users/lfrancioli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lfrancioli/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/lfrancioli/hail","forks_url":"https://api.github.com/repos/lfrancioli/hail/forks","keys_url":"https://api.github.com/repos/lfrancioli/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lfrancioli/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lfrancioli/hail/teams","hooks_url":"https://api.github.com/repos/lfrancioli/hail/hooks","issue_events_url":"https://api.github.com/repos/lfrancioli/hail/issues/events{/number}","events_url":"https://api.github.com/repos/lfrancioli/hail/events","assignees_url":"https://api.github.com/repos/lfrancioli/hail/assignees{/user}","branches_url":"https://api.github.com/repos/lfrancioli/hail/branches{/branch}","tags_url":"https://api.github.com/repos/lfrancioli/hail/tags","blobs_url":"https://api.github.com/repos/lfrancioli/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lfrancioli/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lfrancioli/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/lfrancioli/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lfrancioli/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/lfrancioli/hail/languages","stargazers_url":"https://api.github.com/repos/lfrancioli/hail/stargazers","contributors_url":"https://api.github.com/repos/lfrancioli/hail/contributors","subscribers_url":"https://api.github.com/repos/lfrancioli/hail/subscribers","subscription_url":"https://api.github.com/repos/lfrancioli/hail/subscription","commits_url":"https://api.github.com/repos/lfrancioli/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/lfrancioli/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/lfrancioli/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/lfrancioli/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/lfrancioli/hail/contents/{+path}","compare_url":"https://api.github.com/repos/lfrancioli/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lfrancioli/hail/merges","archive_url":"https://api.github.com/repos/lfrancioli/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lfrancioli/hail/downloads","issues_url":"https://api.github.com/repos/lfrancioli/hail/issues{/number}","pulls_url":"https://api.github.com/repos/lfrancioli/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/lfrancioli/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/lfrancioli/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lfrancioli/hail/labels{/name}","releases_url":"https://api.github.com/repos/lfrancioli/hail/releases{/id}","deployments_url":"https://api.github.com/repos/lfrancioli/hail/deployments","created_at":"2016-08-01T19:31:07Z","updated_at":"2016-10-27T20:28:19Z","pushed_at":"2017-03-28T20:27:16Z","git_url":"git://github.com/lfrancioli/hail.git","ssh_url":"git@github.com:lfrancioli/hail.git","clone_url":"https://github.com/lfrancioli/hail.git","svn_url":"https://github.com/lfrancioli/hail","homepage":"","size":17232,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"65e79b82d85a705efc612ab6eaa7394688d570a9","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars2.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars2.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genetic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2017-03-25T22:06:34Z","pushed_at":"2017-03-29T16:43:36Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":11210,"stargazers_count":133,"watchers_count":133,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":295,"forks":37,"open_issues":295,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1557"},"html":{"href":"https://github.com/hail-is/hail/pull/1557"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/1557"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/1557/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1557/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1557/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/6926a6bc86e4112cc937a12bad68806455a33fd3"}}}}
{"actor":{"display_login":"lfrancioli"}}