{"action":"created","comment":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments/152104923","pull_request_review_id":77913192,"id":152104923,"diff_hunk":"@@ -72,13 +92,25 @@ void SetupTotpDialog::setSeed(QString value)\n     m_ui->seedEdit->setText(value);\n }\n \n+void SetupTotpDialog::setSettings(quint8 digits) {\n+    quint8 step = m_ui->stepSpinBox->value();\n+\n+    bool isDefault = step == QTotp::defaultStep &&\n+        digits == QTotp::defaultDigits;\n+    bool isSteam = digits == QTotp::ENCODER_STEAM;","path":"src/gui/SetupTotpDialog.cpp","position":54,"original_position":54,"commit_id":"e53421d7a394a14591f2f449c24adfe96eb47434","original_commit_id":"e53421d7a394a14591f2f449c24adfe96eb47434","user":{"login":"phoerious","id":911270,"avatar_url":"https://avatars1.githubusercontent.com/u/911270?v=4","gravatar_id":"","url":"https://api.github.com/users/phoerious","html_url":"https://github.com/phoerious","followers_url":"https://api.github.com/users/phoerious/followers","following_url":"https://api.github.com/users/phoerious/following{/other_user}","gists_url":"https://api.github.com/users/phoerious/gists{/gist_id}","starred_url":"https://api.github.com/users/phoerious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoerious/subscriptions","organizations_url":"https://api.github.com/users/phoerious/orgs","repos_url":"https://api.github.com/users/phoerious/repos","events_url":"https://api.github.com/users/phoerious/events{/privacy}","received_events_url":"https://api.github.com/users/phoerious/received_events","type":"User","site_admin":false},"body":"Maybe use brackets here to visually separate the parts of these statements better.","created_at":"2017-11-20T20:41:03Z","updated_at":"2017-11-20T20:52:29Z","html_url":"https://github.com/keepassxreboot/keepassxc/pull/1206#discussion_r152104923","pull_request_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments/152104923"},"html":{"href":"https://github.com/keepassxreboot/keepassxc/pull/1206#discussion_r152104923"},"pull_request":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206"}}},"pull_request":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206","id":153701405,"html_url":"https://github.com/keepassxreboot/keepassxc/pull/1206","diff_url":"https://github.com/keepassxreboot/keepassxc/pull/1206.diff","patch_url":"https://github.com/keepassxreboot/keepassxc/pull/1206.patch","issue_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/1206","number":1206,"state":"open","locked":false,"title":"Add initial Steam TOTP support","user":{"login":"joelsmith","id":329907,"avatar_url":"https://avatars2.githubusercontent.com/u/329907?v=4","gravatar_id":"","url":"https://api.github.com/users/joelsmith","html_url":"https://github.com/joelsmith","followers_url":"https://api.github.com/users/joelsmith/followers","following_url":"https://api.github.com/users/joelsmith/following{/other_user}","gists_url":"https://api.github.com/users/joelsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/joelsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelsmith/subscriptions","organizations_url":"https://api.github.com/users/joelsmith/orgs","repos_url":"https://api.github.com/users/joelsmith/repos","events_url":"https://api.github.com/users/joelsmith/events{/privacy}","received_events_url":"https://api.github.com/users/joelsmith/received_events","type":"User","site_admin":false},"body":"Add initial Steam TOTP support\r\n\r\n* Add the concept of custom TOTP encoders, each with potential for custom\r\n  code alphabet, length, step interval and code direction (i.e. reversed)\r\n* Select custom encoder via overload of the digits field of a loaded entry\r\n* Allow selection of custom encoders via the \"TOTP Settings\" field's\r\n  size, as currently done by KeeTrayTOTP for Steam. Use \"S\" for the\r\n  short name of the Steam custom encoder\r\n* Allow selection of custom encoders via the \"otp\" field by appending\r\n  a \"&encoder=<name>\" field to the URL query. For example,\r\n  \"&encoder=steam\"\r\n* Update TOTP set-up dialog to permit selection between (default,\r\n  steam, custom) settings.\r\n\r\n\r\n## Description\r\nAdds the ability to generate Steam Guard TOTP codes using the secret\r\nassociated with a Steam account.\r\n\r\n## Motivation and context\r\n\r\nFixes #594\r\n\r\n## How has this been tested?\r\nUnit tests added\r\n\r\nTested existing TOTP entries\r\n\r\nAdded new Steam TOTP entries and verified code output\r\n\r\n## Screenshots (if appropriate):\r\n\r\n![screenshot_20171120_112911](https://user-images.githubusercontent.com/329907/33034833-581222a8-cde6-11e7-8bf7-2ab4efcca290.png)\r\n\r\n![screenshot_20171120_113540](https://user-images.githubusercontent.com/329907/33035014-f51c03c0-cde6-11e7-9262-cb44fe519f5e.png)\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? -->\r\n<!--- Please remove all lines which don't apply. -->\r\n- ✅ New feature (non-breaking change which adds functionality)\r\n\r\n## Checklist:\r\n- ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]**\r\n- ✅ My code follows the code style of this project. **[REQUIRED]**\r\n- ✅ All new and existing tests passed. **[REQUIRED]**\r\n- ✅ I have compiled and verified my code with `-DWITH_ASAN=ON`. **[REQUIRED]**\r\n- ✅ I have added tests to cover my changes.","created_at":"2017-11-20T18:25:05Z","updated_at":"2017-11-20T20:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"777fca35a1b9c0a77447ed2cda9ad173866fff03","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206/commits","review_comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206/comments","review_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/1206/comments","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/e53421d7a394a14591f2f449c24adfe96eb47434","head":{"label":"joelsmith:feature/steamtotp","ref":"feature/steamtotp","sha":"e53421d7a394a14591f2f449c24adfe96eb47434","user":{"login":"joelsmith","id":329907,"avatar_url":"https://avatars2.githubusercontent.com/u/329907?v=4","gravatar_id":"","url":"https://api.github.com/users/joelsmith","html_url":"https://github.com/joelsmith","followers_url":"https://api.github.com/users/joelsmith/followers","following_url":"https://api.github.com/users/joelsmith/following{/other_user}","gists_url":"https://api.github.com/users/joelsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/joelsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelsmith/subscriptions","organizations_url":"https://api.github.com/users/joelsmith/orgs","repos_url":"https://api.github.com/users/joelsmith/repos","events_url":"https://api.github.com/users/joelsmith/events{/privacy}","received_events_url":"https://api.github.com/users/joelsmith/received_events","type":"User","site_admin":false},"repo":{"id":111159777,"name":"keepassxc","full_name":"joelsmith/keepassxc","owner":{"login":"joelsmith","id":329907,"avatar_url":"https://avatars2.githubusercontent.com/u/329907?v=4","gravatar_id":"","url":"https://api.github.com/users/joelsmith","html_url":"https://github.com/joelsmith","followers_url":"https://api.github.com/users/joelsmith/followers","following_url":"https://api.github.com/users/joelsmith/following{/other_user}","gists_url":"https://api.github.com/users/joelsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/joelsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelsmith/subscriptions","organizations_url":"https://api.github.com/users/joelsmith/orgs","repos_url":"https://api.github.com/users/joelsmith/repos","events_url":"https://api.github.com/users/joelsmith/events{/privacy}","received_events_url":"https://api.github.com/users/joelsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joelsmith/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":true,"url":"https://api.github.com/repos/joelsmith/keepassxc","forks_url":"https://api.github.com/repos/joelsmith/keepassxc/forks","keys_url":"https://api.github.com/repos/joelsmith/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joelsmith/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joelsmith/keepassxc/teams","hooks_url":"https://api.github.com/repos/joelsmith/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/joelsmith/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/joelsmith/keepassxc/events","assignees_url":"https://api.github.com/repos/joelsmith/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/joelsmith/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/joelsmith/keepassxc/tags","blobs_url":"https://api.github.com/repos/joelsmith/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joelsmith/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joelsmith/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/joelsmith/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joelsmith/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/joelsmith/keepassxc/languages","stargazers_url":"https://api.github.com/repos/joelsmith/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/joelsmith/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/joelsmith/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/joelsmith/keepassxc/subscription","commits_url":"https://api.github.com/repos/joelsmith/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/joelsmith/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/joelsmith/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/joelsmith/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/joelsmith/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/joelsmith/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joelsmith/keepassxc/merges","archive_url":"https://api.github.com/repos/joelsmith/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joelsmith/keepassxc/downloads","issues_url":"https://api.github.com/repos/joelsmith/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/joelsmith/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/joelsmith/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/joelsmith/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joelsmith/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/joelsmith/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/joelsmith/keepassxc/deployments","created_at":"2017-11-17T23:19:40Z","updated_at":"2017-11-17T23:19:43Z","pushed_at":"2017-11-20T20:05:17Z","git_url":"git://github.com/joelsmith/keepassxc.git","ssh_url":"git@github.com:joelsmith/keepassxc.git","clone_url":"https://github.com/joelsmith/keepassxc.git","svn_url":"https://github.com/joelsmith/keepassxc","homepage":"https://keepassxc.org/","size":9453,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"keepassxreboot:develop","ref":"develop","sha":"1cb91fabb65544ecd8facae6a0d1ddc242589a2e","user":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"repo":{"id":52729242,"name":"keepassxc","full_name":"keepassxreboot/keepassxc","owner":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepassxreboot/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":false,"url":"https://api.github.com/repos/keepassxreboot/keepassxc","forks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/forks","keys_url":"https://api.github.com/repos/keepassxreboot/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepassxreboot/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepassxreboot/keepassxc/teams","hooks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/events","assignees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/keepassxreboot/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/tags","blobs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/keepassxreboot/keepassxc/languages","stargazers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscription","commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/keepassxreboot/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepassxreboot/keepassxc/merges","archive_url":"https://api.github.com/repos/keepassxreboot/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepassxreboot/keepassxc/downloads","issues_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/keepassxreboot/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/keepassxreboot/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/deployments","created_at":"2016-02-28T15:52:40Z","updated_at":"2017-11-20T20:15:36Z","pushed_at":"2017-11-20T20:05:18Z","git_url":"git://github.com/keepassxreboot/keepassxc.git","ssh_url":"git@github.com:keepassxreboot/keepassxc.git","clone_url":"https://github.com/keepassxreboot/keepassxc.git","svn_url":"https://github.com/keepassxreboot/keepassxc","homepage":"https://keepassxc.org/","size":9450,"stargazers_count":2623,"watchers_count":2623,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"archived":false,"open_issues_count":260,"forks":185,"open_issues":260,"watchers":2623,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206"},"html":{"href":"https://github.com/keepassxreboot/keepassxc/pull/1206"},"issue":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/1206"},"comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/1206/comments"},"review_comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206/comments"},"review_comment":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/1206/commits"},"statuses":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/e53421d7a394a14591f2f449c24adfe96eb47434"}},"author_association":"NONE"}}
{"actor":{"display_login":"phoerious"}}