{"action":"created","comment":{"url":"https://api.github.com/repos/cyverse/troposphere/pulls/comments/127872643","pull_request_review_id":50497873,"id":127872643,"diff_hunk":"@@ -6,6 +6,9 @@\n     //     \"eslint:recommended\",\n     //     \"plugin:react/recommended\",\n     // ],\n+    \"extends\": [\n+        \"eslint:recommended\",\n+    ],","path":".eslintrc","position":6,"original_position":6,"commit_id":"22faa722e95e94e9b9c6574a86e6002f9542fa51","original_commit_id":"22faa722e95e94e9b9c6574a86e6002f9542fa51","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"body":"We could allow `comma-dangle` and drop out the commit that fixes the occurrences of `comma-dangle`. ","created_at":"2017-07-18T02:52:25Z","updated_at":"2017-07-18T02:52:25Z","html_url":"https://github.com/cyverse/troposphere/pull/654#discussion_r127872643","pull_request_url":"https://api.github.com/repos/cyverse/troposphere/pulls/654","_links":{"self":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/comments/127872643"},"html":{"href":"https://github.com/cyverse/troposphere/pull/654#discussion_r127872643"},"pull_request":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/654"}}},"pull_request":{"url":"https://api.github.com/repos/cyverse/troposphere/pulls/654","id":130685201,"html_url":"https://github.com/cyverse/troposphere/pull/654","diff_url":"https://github.com/cyverse/troposphere/pull/654.diff","patch_url":"https://github.com/cyverse/troposphere/pull/654.patch","issue_url":"https://api.github.com/repos/cyverse/troposphere/issues/654","number":654,"state":"open","locked":false,"title":"Problem: do not apply a recommended set of ESLint rules","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis work resolves a number of `eslint:recommended` violations:\r\n- comma-dangle\r\n- no-extra-semi\r\n- no-unused-vars\r\n- no-extra-boolean-cast\r\n- no-redeclare\r\n\r\nThe results of merging this would be enabling `\"eslint:recommended\"` rules, plus our existing `.eslintrc` definition.\r\n\r\nNote: I have \"disable\" a violation for one issue related to removing licenses from an imaging request. This has been captured within [the product's internal issue tracking](https://pods.iplantcollaborative.org/jira/browse/ATMO-1962) (noted within commit 7d39a6c).\r\n\r\n## Checklist before merging Pull Requests\r\n- [ ] ~New test(s) included to reproduce the bug/verify the feature~\r\n- [ ] ~Documentation created/updated at [Example link to documentation](https://example.test/doc#new_section) to give context to the feature~\r\n- [ ] Reviewed and approved by at least one other contributor.\r\n","created_at":"2017-07-14T22:21:12Z","updated_at":"2017-07-18T02:52:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"738ac065358055ce981927cd74466b9d36a79812","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cyverse/troposphere/pulls/654/commits","review_comments_url":"https://api.github.com/repos/cyverse/troposphere/pulls/654/comments","review_comment_url":"https://api.github.com/repos/cyverse/troposphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyverse/troposphere/issues/654/comments","statuses_url":"https://api.github.com/repos/cyverse/troposphere/statuses/22faa722e95e94e9b9c6574a86e6002f9542fa51","head":{"label":"lenards:toward-a-eslint-recommended-lint","ref":"toward-a-eslint-recommended-lint","sha":"22faa722e95e94e9b9c6574a86e6002f9542fa51","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"repo":{"id":42893619,"name":"troposphere","full_name":"lenards/troposphere","owner":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lenards/troposphere","description":"Atmosphere web client","fork":true,"url":"https://api.github.com/repos/lenards/troposphere","forks_url":"https://api.github.com/repos/lenards/troposphere/forks","keys_url":"https://api.github.com/repos/lenards/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lenards/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lenards/troposphere/teams","hooks_url":"https://api.github.com/repos/lenards/troposphere/hooks","issue_events_url":"https://api.github.com/repos/lenards/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/lenards/troposphere/events","assignees_url":"https://api.github.com/repos/lenards/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/lenards/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/lenards/troposphere/tags","blobs_url":"https://api.github.com/repos/lenards/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lenards/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lenards/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/lenards/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lenards/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/lenards/troposphere/languages","stargazers_url":"https://api.github.com/repos/lenards/troposphere/stargazers","contributors_url":"https://api.github.com/repos/lenards/troposphere/contributors","subscribers_url":"https://api.github.com/repos/lenards/troposphere/subscribers","subscription_url":"https://api.github.com/repos/lenards/troposphere/subscription","commits_url":"https://api.github.com/repos/lenards/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/lenards/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/lenards/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/lenards/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/lenards/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/lenards/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lenards/troposphere/merges","archive_url":"https://api.github.com/repos/lenards/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lenards/troposphere/downloads","issues_url":"https://api.github.com/repos/lenards/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/lenards/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/lenards/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/lenards/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lenards/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/lenards/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/lenards/troposphere/deployments","created_at":"2015-09-21T21:05:47Z","updated_at":"2016-03-22T20:17:51Z","pushed_at":"2017-07-14T22:16:24Z","git_url":"git://github.com/lenards/troposphere.git","ssh_url":"git@github.com:lenards/troposphere.git","clone_url":"https://github.com/lenards/troposphere.git","svn_url":"https://github.com/lenards/troposphere","homepage":null,"size":9607,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyverse:master","ref":"master","sha":"91e118b58763a257f725b81cb870319299174f52","user":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars0.githubusercontent.com/u/15638129?v=4","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":17913633,"name":"troposphere","full_name":"cyverse/troposphere","owner":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars0.githubusercontent.com/u/15638129?v=4","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse/troposphere","description":"Atmosphere web client","fork":false,"url":"https://api.github.com/repos/cyverse/troposphere","forks_url":"https://api.github.com/repos/cyverse/troposphere/forks","keys_url":"https://api.github.com/repos/cyverse/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse/troposphere/teams","hooks_url":"https://api.github.com/repos/cyverse/troposphere/hooks","issue_events_url":"https://api.github.com/repos/cyverse/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse/troposphere/events","assignees_url":"https://api.github.com/repos/cyverse/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse/troposphere/tags","blobs_url":"https://api.github.com/repos/cyverse/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse/troposphere/languages","stargazers_url":"https://api.github.com/repos/cyverse/troposphere/stargazers","contributors_url":"https://api.github.com/repos/cyverse/troposphere/contributors","subscribers_url":"https://api.github.com/repos/cyverse/troposphere/subscribers","subscription_url":"https://api.github.com/repos/cyverse/troposphere/subscription","commits_url":"https://api.github.com/repos/cyverse/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse/troposphere/merges","archive_url":"https://api.github.com/repos/cyverse/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse/troposphere/downloads","issues_url":"https://api.github.com/repos/cyverse/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/cyverse/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse/troposphere/deployments","created_at":"2014-03-19T17:26:44Z","updated_at":"2016-11-21T17:04:16Z","pushed_at":"2017-07-18T02:45:38Z","git_url":"git://github.com/cyverse/troposphere.git","ssh_url":"git@github.com:cyverse/troposphere.git","clone_url":"https://github.com/cyverse/troposphere.git","svn_url":"https://github.com/cyverse/troposphere","homepage":null,"size":9210,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":15,"forks":16,"open_issues":15,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/654"},"html":{"href":"https://github.com/cyverse/troposphere/pull/654"},"issue":{"href":"https://api.github.com/repos/cyverse/troposphere/issues/654"},"comments":{"href":"https://api.github.com/repos/cyverse/troposphere/issues/654/comments"},"review_comments":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/654/comments"},"review_comment":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/654/commits"},"statuses":{"href":"https://api.github.com/repos/cyverse/troposphere/statuses/22faa722e95e94e9b9c6574a86e6002f9542fa51"}}}}
{"actor":{"display_login":"lenards"}}