{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/amiable/pulls/comments/103187499","pull_request_review_id":23963559,"id":103187499,"diff_hunk":"@@ -0,0 +1,40 @@\n+package models\n+\n+import org.scalatest.{FreeSpec, Matchers}\n+import util.Fixtures._\n+\n+class InstanceTest extends FreeSpec with Matchers {","path":"test/models/InstanceTest.scala","position":6,"original_position":6,"commit_id":"506f2c8558376f86230a0746dc2008615e3d852d","original_commit_id":"506f2c8558376f86230a0746dc2008615e3d852d","user":{"login":"adamnfish","id":29761,"avatar_url":"https://avatars.githubusercontent.com/u/29761?v=3","gravatar_id":"","url":"https://api.github.com/users/adamnfish","html_url":"https://github.com/adamnfish","followers_url":"https://api.github.com/users/adamnfish/followers","following_url":"https://api.github.com/users/adamnfish/following{/other_user}","gists_url":"https://api.github.com/users/adamnfish/gists{/gist_id}","starred_url":"https://api.github.com/users/adamnfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamnfish/subscriptions","organizations_url":"https://api.github.com/users/adamnfish/orgs","repos_url":"https://api.github.com/users/adamnfish/repos","events_url":"https://api.github.com/users/adamnfish/events{/privacy}","received_events_url":"https://api.github.com/users/adamnfish/received_events","type":"User","site_admin":false},"body":"`Instance` of what? These are testing `Stack`s at the moment, I think `StackTest` would be a batter name. That said, as I mentioned above, tests on model instances is a sign that data definitions and logic have been muddled together.","created_at":"2017-02-27T11:34:55Z","updated_at":"2017-02-27T11:46:16Z","html_url":"https://github.com/guardian/amiable/pull/40#discussion_r103187499","pull_request_url":"https://api.github.com/repos/guardian/amiable/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/guardian/amiable/pulls/comments/103187499"},"html":{"href":"https://github.com/guardian/amiable/pull/40#discussion_r103187499"},"pull_request":{"href":"https://api.github.com/repos/guardian/amiable/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/amiable/pulls/40","id":108079540,"html_url":"https://github.com/guardian/amiable/pull/40","diff_url":"https://github.com/guardian/amiable/pull/40.diff","patch_url":"https://github.com/guardian/amiable/pull/40.patch","issue_url":"https://api.github.com/repos/guardian/amiable/issues/40","number":40,"state":"open","locked":false,"title":"Show instances count for each AMIs","user":{"login":"TBonnin","id":233326,"avatar_url":"https://avatars.githubusercontent.com/u/233326?v=3","gravatar_id":"","url":"https://api.github.com/users/TBonnin","html_url":"https://github.com/TBonnin","followers_url":"https://api.github.com/users/TBonnin/followers","following_url":"https://api.github.com/users/TBonnin/following{/other_user}","gists_url":"https://api.github.com/users/TBonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/TBonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBonnin/subscriptions","organizations_url":"https://api.github.com/users/TBonnin/orgs","repos_url":"https://api.github.com/users/TBonnin/repos","events_url":"https://api.github.com/users/TBonnin/events{/privacy}","received_events_url":"https://api.github.com/users/TBonnin/received_events","type":"User","site_admin":false},"body":"![screen shot 2017-02-24 at 17 54 00](https://cloud.githubusercontent.com/assets/233326/23314877/9fcd1700-fabb-11e6-8821-a689c3b6f170.png)\r\n\r\nRegarding the UI: @zef mentioned that it would be better if the icons (age and machine) is before the number.","created_at":"2017-02-27T09:53:10Z","updated_at":"2017-02-27T11:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68229ee9e97a5a573f3fee6fad15e294d9f12fef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/amiable/pulls/40/commits","review_comments_url":"https://api.github.com/repos/guardian/amiable/pulls/40/comments","review_comment_url":"https://api.github.com/repos/guardian/amiable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/amiable/issues/40/comments","statuses_url":"https://api.github.com/repos/guardian/amiable/statuses/506f2c8558376f86230a0746dc2008615e3d852d","head":{"label":"guardian:tb-add-instances-count-per-ami","ref":"tb-add-instances-count-per-ami","sha":"506f2c8558376f86230a0746dc2008615e3d852d","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":51507385,"name":"amiable","full_name":"guardian/amiable","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/amiable","description":"AMI management tool","fork":false,"url":"https://api.github.com/repos/guardian/amiable","forks_url":"https://api.github.com/repos/guardian/amiable/forks","keys_url":"https://api.github.com/repos/guardian/amiable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/amiable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/amiable/teams","hooks_url":"https://api.github.com/repos/guardian/amiable/hooks","issue_events_url":"https://api.github.com/repos/guardian/amiable/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/amiable/events","assignees_url":"https://api.github.com/repos/guardian/amiable/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/amiable/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/amiable/tags","blobs_url":"https://api.github.com/repos/guardian/amiable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/amiable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/amiable/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/amiable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/amiable/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/amiable/languages","stargazers_url":"https://api.github.com/repos/guardian/amiable/stargazers","contributors_url":"https://api.github.com/repos/guardian/amiable/contributors","subscribers_url":"https://api.github.com/repos/guardian/amiable/subscribers","subscription_url":"https://api.github.com/repos/guardian/amiable/subscription","commits_url":"https://api.github.com/repos/guardian/amiable/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/amiable/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/amiable/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/amiable/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/amiable/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/amiable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/amiable/merges","archive_url":"https://api.github.com/repos/guardian/amiable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/amiable/downloads","issues_url":"https://api.github.com/repos/guardian/amiable/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/amiable/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/amiable/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/amiable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/amiable/labels{/name}","releases_url":"https://api.github.com/repos/guardian/amiable/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/amiable/deployments","created_at":"2016-02-11T10:21:34Z","updated_at":"2017-02-22T15:18:36Z","pushed_at":"2017-02-27T09:53:11Z","git_url":"git://github.com/guardian/amiable.git","ssh_url":"git@github.com:guardian/amiable.git","clone_url":"https://github.com/guardian/amiable.git","svn_url":"https://github.com/guardian/amiable","homepage":null,"size":2694,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"d6f2bb48b94a9adcea9901123a0dc7af4a4e8303","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":51507385,"name":"amiable","full_name":"guardian/amiable","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/amiable","description":"AMI management tool","fork":false,"url":"https://api.github.com/repos/guardian/amiable","forks_url":"https://api.github.com/repos/guardian/amiable/forks","keys_url":"https://api.github.com/repos/guardian/amiable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/amiable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/amiable/teams","hooks_url":"https://api.github.com/repos/guardian/amiable/hooks","issue_events_url":"https://api.github.com/repos/guardian/amiable/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/amiable/events","assignees_url":"https://api.github.com/repos/guardian/amiable/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/amiable/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/amiable/tags","blobs_url":"https://api.github.com/repos/guardian/amiable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/amiable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/amiable/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/amiable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/amiable/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/amiable/languages","stargazers_url":"https://api.github.com/repos/guardian/amiable/stargazers","contributors_url":"https://api.github.com/repos/guardian/amiable/contributors","subscribers_url":"https://api.github.com/repos/guardian/amiable/subscribers","subscription_url":"https://api.github.com/repos/guardian/amiable/subscription","commits_url":"https://api.github.com/repos/guardian/amiable/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/amiable/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/amiable/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/amiable/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/amiable/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/amiable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/amiable/merges","archive_url":"https://api.github.com/repos/guardian/amiable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/amiable/downloads","issues_url":"https://api.github.com/repos/guardian/amiable/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/amiable/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/amiable/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/amiable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/amiable/labels{/name}","releases_url":"https://api.github.com/repos/guardian/amiable/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/amiable/deployments","created_at":"2016-02-11T10:21:34Z","updated_at":"2017-02-22T15:18:36Z","pushed_at":"2017-02-27T09:53:11Z","git_url":"git://github.com/guardian/amiable.git","ssh_url":"git@github.com:guardian/amiable.git","clone_url":"https://github.com/guardian/amiable.git","svn_url":"https://github.com/guardian/amiable","homepage":null,"size":2694,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/amiable/pulls/40"},"html":{"href":"https://github.com/guardian/amiable/pull/40"},"issue":{"href":"https://api.github.com/repos/guardian/amiable/issues/40"},"comments":{"href":"https://api.github.com/repos/guardian/amiable/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/amiable/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/amiable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/amiable/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/amiable/statuses/506f2c8558376f86230a0746dc2008615e3d852d"}}}}
{"actor":{"display_login":"adamnfish"}}