{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/106693540","pull_request_review_id":27632107,"id":106693540,"diff_hunk":"@@ -101,6 +101,12 @@ static std::vector<std::vector<char>> storeArgumentsCCompatible(std::vector<std:\n   std::vector<std::vector<char>> output;\n   std::transform(input.begin(), input.end(), std::back_inserter(output),\n                 [](std::string const & i) { return std::vector<char>(i.c_str(), i.c_str() + i.length() + 1); });\n+\n+  if(output.empty())\n+  {\n+    output.push_back(std::vector<char>(1u, '\\0'));\n+  }","path":"xbmc/interfaces/python/PythonInvoker.cpp","position":8,"original_position":8,"commit_id":"fbdab808869a311fef2a4102686f0aacefc4f499","original_commit_id":"fbdab808869a311fef2a4102686f0aacefc4f499","user":{"login":"garbear","id":531482,"avatar_url":"https://avatars1.githubusercontent.com/u/531482?v=3","gravatar_id":"","url":"https://api.github.com/users/garbear","html_url":"https://github.com/garbear","followers_url":"https://api.github.com/users/garbear/followers","following_url":"https://api.github.com/users/garbear/following{/other_user}","gists_url":"https://api.github.com/users/garbear/gists{/gist_id}","starred_url":"https://api.github.com/users/garbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbear/subscriptions","organizations_url":"https://api.github.com/users/garbear/orgs","repos_url":"https://api.github.com/users/garbear/repos","events_url":"https://api.github.com/users/garbear/events{/privacy}","received_events_url":"https://api.github.com/users/garbear/received_events","type":"User","site_admin":false},"body":"Style nitpick - can you make this\r\n\r\n```c++\r\nif (output.empty())\r\n  output.push_back(std::vector<char>(1u, '\\0'));\r\n```\r\n\r\nIt looks like you're on a roll with fixes, so future ones should follow our coding style or the bike shedding police will speak up :)","created_at":"2017-03-17T16:40:50Z","updated_at":"2017-03-17T16:40:50Z","html_url":"https://github.com/xbmc/xbmc/pull/11860#discussion_r106693540","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11860","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/106693540"},"html":{"href":"https://github.com/xbmc/xbmc/pull/11860#discussion_r106693540"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11860"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/11860","id":111182323,"html_url":"https://github.com/xbmc/xbmc/pull/11860","diff_url":"https://github.com/xbmc/xbmc/pull/11860.diff","patch_url":"https://github.com/xbmc/xbmc/pull/11860.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/11860","number":11860,"state":"open","locked":false,"title":"Fix for YouTube Add-On Crash","user":{"login":"thebrid","id":20609276,"avatar_url":"https://avatars1.githubusercontent.com/u/20609276?v=3","gravatar_id":"","url":"https://api.github.com/users/thebrid","html_url":"https://github.com/thebrid","followers_url":"https://api.github.com/users/thebrid/followers","following_url":"https://api.github.com/users/thebrid/following{/other_user}","gists_url":"https://api.github.com/users/thebrid/gists{/gist_id}","starred_url":"https://api.github.com/users/thebrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebrid/subscriptions","organizations_url":"https://api.github.com/users/thebrid/orgs","repos_url":"https://api.github.com/users/thebrid/repos","events_url":"https://api.github.com/users/thebrid/events{/privacy}","received_events_url":"https://api.github.com/users/thebrid/received_events","type":"User","site_admin":false},"body":"## Description\r\n #11814 caused crash in Youtube plugin which has 0 argc. Turns out we still need to call PySys_SetArgv but with argc=0 and argv as pointer to empty string.\r\n\r\n## Motivation and Context\r\nYoutube crash introduced in #11814 \r\n\r\n## How Has This Been Tested?\r\nTested manually on x86_64 Ubuntu Linux. Tested both Weather and YouTube add-ons. Both load & work now. Also ran under valgrind & confirmed no errors in these cases.\r\n\r\n## Types of change\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [X] All new and existing tests passed\r\n","created_at":"2017-03-16T22:53:46Z","updated_at":"2017-03-17T16:40:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fcd744ceed4559341dffde409fdb77fd723573f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11860/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11860/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/11860/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/fbdab808869a311fef2a4102686f0aacefc4f499","head":{"label":"thebrid:valgrind1","ref":"valgrind1","sha":"fbdab808869a311fef2a4102686f0aacefc4f499","user":{"login":"thebrid","id":20609276,"avatar_url":"https://avatars1.githubusercontent.com/u/20609276?v=3","gravatar_id":"","url":"https://api.github.com/users/thebrid","html_url":"https://github.com/thebrid","followers_url":"https://api.github.com/users/thebrid/followers","following_url":"https://api.github.com/users/thebrid/following{/other_user}","gists_url":"https://api.github.com/users/thebrid/gists{/gist_id}","starred_url":"https://api.github.com/users/thebrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebrid/subscriptions","organizations_url":"https://api.github.com/users/thebrid/orgs","repos_url":"https://api.github.com/users/thebrid/repos","events_url":"https://api.github.com/users/thebrid/events{/privacy}","received_events_url":"https://api.github.com/users/thebrid/received_events","type":"User","site_admin":false},"repo":{"id":77695575,"name":"xbmc","full_name":"thebrid/xbmc","owner":{"login":"thebrid","id":20609276,"avatar_url":"https://avatars1.githubusercontent.com/u/20609276?v=3","gravatar_id":"","url":"https://api.github.com/users/thebrid","html_url":"https://github.com/thebrid","followers_url":"https://api.github.com/users/thebrid/followers","following_url":"https://api.github.com/users/thebrid/following{/other_user}","gists_url":"https://api.github.com/users/thebrid/gists{/gist_id}","starred_url":"https://api.github.com/users/thebrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebrid/subscriptions","organizations_url":"https://api.github.com/users/thebrid/orgs","repos_url":"https://api.github.com/users/thebrid/repos","events_url":"https://api.github.com/users/thebrid/events{/privacy}","received_events_url":"https://api.github.com/users/thebrid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thebrid/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/thebrid/xbmc","forks_url":"https://api.github.com/repos/thebrid/xbmc/forks","keys_url":"https://api.github.com/repos/thebrid/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thebrid/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thebrid/xbmc/teams","hooks_url":"https://api.github.com/repos/thebrid/xbmc/hooks","issue_events_url":"https://api.github.com/repos/thebrid/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/thebrid/xbmc/events","assignees_url":"https://api.github.com/repos/thebrid/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/thebrid/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/thebrid/xbmc/tags","blobs_url":"https://api.github.com/repos/thebrid/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thebrid/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thebrid/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/thebrid/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thebrid/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/thebrid/xbmc/languages","stargazers_url":"https://api.github.com/repos/thebrid/xbmc/stargazers","contributors_url":"https://api.github.com/repos/thebrid/xbmc/contributors","subscribers_url":"https://api.github.com/repos/thebrid/xbmc/subscribers","subscription_url":"https://api.github.com/repos/thebrid/xbmc/subscription","commits_url":"https://api.github.com/repos/thebrid/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/thebrid/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/thebrid/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/thebrid/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/thebrid/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/thebrid/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thebrid/xbmc/merges","archive_url":"https://api.github.com/repos/thebrid/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thebrid/xbmc/downloads","issues_url":"https://api.github.com/repos/thebrid/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/thebrid/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/thebrid/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/thebrid/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thebrid/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/thebrid/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/thebrid/xbmc/deployments","created_at":"2016-12-30T15:50:51Z","updated_at":"2016-12-30T15:51:17Z","pushed_at":"2017-03-16T22:48:09Z","git_url":"git://github.com/thebrid/xbmc.git","ssh_url":"git@github.com:thebrid/xbmc.git","clone_url":"https://github.com/thebrid/xbmc.git","svn_url":"https://github.com/thebrid/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":585071,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"25de4115f0477ec75781acc909d862dbffe2889f","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars1.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars1.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2017-03-17T15:39:54Z","pushed_at":"2017-03-17T15:07:34Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1400122,"stargazers_count":5655,"watchers_count":5655,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4013,"mirror_url":null,"open_issues_count":177,"forks":4013,"open_issues":177,"watchers":5655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11860"},"html":{"href":"https://github.com/xbmc/xbmc/pull/11860"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/11860"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/11860/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11860/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11860/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/fbdab808869a311fef2a4102686f0aacefc4f499"}}}}
{"actor":{"display_login":"garbear"}}