{"action":"closed","number":299,"pull_request":{"url":"https://api.github.com/repos/graphql-python/graphene-django/pulls/299","id":148566487,"html_url":"https://github.com/graphql-python/graphene-django/pull/299","diff_url":"https://github.com/graphql-python/graphene-django/pull/299.diff","patch_url":"https://github.com/graphql-python/graphene-django/pull/299.patch","issue_url":"https://api.github.com/repos/graphql-python/graphene-django/issues/299","number":299,"state":"closed","locked":false,"title":"Use maybe_queryset in DjangoFilterConnectionField","user":{"login":"furious-luke","id":561722,"avatar_url":"https://avatars2.githubusercontent.com/u/561722?v=4","gravatar_id":"","url":"https://api.github.com/users/furious-luke","html_url":"https://github.com/furious-luke","followers_url":"https://api.github.com/users/furious-luke/followers","following_url":"https://api.github.com/users/furious-luke/following{/other_user}","gists_url":"https://api.github.com/users/furious-luke/gists{/gist_id}","starred_url":"https://api.github.com/users/furious-luke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furious-luke/subscriptions","organizations_url":"https://api.github.com/users/furious-luke/orgs","repos_url":"https://api.github.com/users/furious-luke/repos","events_url":"https://api.github.com/users/furious-luke/events{/privacy}","received_events_url":"https://api.github.com/users/furious-luke/received_events","type":"User","site_admin":false},"body":"In our projects we've found a need to inherit from\r\nDjangoFilterConnectionField in order to customize the queryset. When\r\npassing the queryset into \"connection_resolver\", an error was\r\nraised about \"get_queryset\" not existing. This is due to the\r\nassumption that the \"base_manager\" is always a manager. Using\r\n\"maybe_queryset\" resolves the issue.\r\n\r\nIf there's a better way of doing any of this please let me know.","created_at":"2017-10-25T04:11:31Z","updated_at":"2017-10-30T04:56:46Z","closed_at":"2017-10-30T04:56:46Z","merged_at":null,"merge_commit_sha":"46e090f6dece2ca48cf3acd8d3ed40d87bccf5b5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphql-python/graphene-django/pulls/299/commits","review_comments_url":"https://api.github.com/repos/graphql-python/graphene-django/pulls/299/comments","review_comment_url":"https://api.github.com/repos/graphql-python/graphene-django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphql-python/graphene-django/issues/299/comments","statuses_url":"https://api.github.com/repos/graphql-python/graphene-django/statuses/0b5f8e8507851dfe2c48cf27b307a97aed92d6f6","head":{"label":"ABASystems:master","ref":"master","sha":"0b5f8e8507851dfe2c48cf27b307a97aed92d6f6","user":{"login":"ABASystems","id":10147530,"avatar_url":"https://avatars1.githubusercontent.com/u/10147530?v=4","gravatar_id":"","url":"https://api.github.com/users/ABASystems","html_url":"https://github.com/ABASystems","followers_url":"https://api.github.com/users/ABASystems/followers","following_url":"https://api.github.com/users/ABASystems/following{/other_user}","gists_url":"https://api.github.com/users/ABASystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ABASystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ABASystems/subscriptions","organizations_url":"https://api.github.com/users/ABASystems/orgs","repos_url":"https://api.github.com/users/ABASystems/repos","events_url":"https://api.github.com/users/ABASystems/events{/privacy}","received_events_url":"https://api.github.com/users/ABASystems/received_events","type":"Organization","site_admin":false},"repo":{"id":108218189,"name":"graphene-django","full_name":"ABASystems/graphene-django","owner":{"login":"ABASystems","id":10147530,"avatar_url":"https://avatars1.githubusercontent.com/u/10147530?v=4","gravatar_id":"","url":"https://api.github.com/users/ABASystems","html_url":"https://github.com/ABASystems","followers_url":"https://api.github.com/users/ABASystems/followers","following_url":"https://api.github.com/users/ABASystems/following{/other_user}","gists_url":"https://api.github.com/users/ABASystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ABASystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ABASystems/subscriptions","organizations_url":"https://api.github.com/users/ABASystems/orgs","repos_url":"https://api.github.com/users/ABASystems/repos","events_url":"https://api.github.com/users/ABASystems/events{/privacy}","received_events_url":"https://api.github.com/users/ABASystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ABASystems/graphene-django","description":"Graphene Django integration","fork":true,"url":"https://api.github.com/repos/ABASystems/graphene-django","forks_url":"https://api.github.com/repos/ABASystems/graphene-django/forks","keys_url":"https://api.github.com/repos/ABASystems/graphene-django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ABASystems/graphene-django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ABASystems/graphene-django/teams","hooks_url":"https://api.github.com/repos/ABASystems/graphene-django/hooks","issue_events_url":"https://api.github.com/repos/ABASystems/graphene-django/issues/events{/number}","events_url":"https://api.github.com/repos/ABASystems/graphene-django/events","assignees_url":"https://api.github.com/repos/ABASystems/graphene-django/assignees{/user}","branches_url":"https://api.github.com/repos/ABASystems/graphene-django/branches{/branch}","tags_url":"https://api.github.com/repos/ABASystems/graphene-django/tags","blobs_url":"https://api.github.com/repos/ABASystems/graphene-django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ABASystems/graphene-django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ABASystems/graphene-django/git/refs{/sha}","trees_url":"https://api.github.com/repos/ABASystems/graphene-django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ABASystems/graphene-django/statuses/{sha}","languages_url":"https://api.github.com/repos/ABASystems/graphene-django/languages","stargazers_url":"https://api.github.com/repos/ABASystems/graphene-django/stargazers","contributors_url":"https://api.github.com/repos/ABASystems/graphene-django/contributors","subscribers_url":"https://api.github.com/repos/ABASystems/graphene-django/subscribers","subscription_url":"https://api.github.com/repos/ABASystems/graphene-django/subscription","commits_url":"https://api.github.com/repos/ABASystems/graphene-django/commits{/sha}","git_commits_url":"https://api.github.com/repos/ABASystems/graphene-django/git/commits{/sha}","comments_url":"https://api.github.com/repos/ABASystems/graphene-django/comments{/number}","issue_comment_url":"https://api.github.com/repos/ABASystems/graphene-django/issues/comments{/number}","contents_url":"https://api.github.com/repos/ABASystems/graphene-django/contents/{+path}","compare_url":"https://api.github.com/repos/ABASystems/graphene-django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ABASystems/graphene-django/merges","archive_url":"https://api.github.com/repos/ABASystems/graphene-django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ABASystems/graphene-django/downloads","issues_url":"https://api.github.com/repos/ABASystems/graphene-django/issues{/number}","pulls_url":"https://api.github.com/repos/ABASystems/graphene-django/pulls{/number}","milestones_url":"https://api.github.com/repos/ABASystems/graphene-django/milestones{/number}","notifications_url":"https://api.github.com/repos/ABASystems/graphene-django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ABASystems/graphene-django/labels{/name}","releases_url":"https://api.github.com/repos/ABASystems/graphene-django/releases{/id}","deployments_url":"https://api.github.com/repos/ABASystems/graphene-django/deployments","created_at":"2017-10-25T04:06:17Z","updated_at":"2017-10-25T04:06:19Z","pushed_at":"2017-10-30T03:59:45Z","git_url":"git://github.com/ABASystems/graphene-django.git","ssh_url":"git@github.com:ABASystems/graphene-django.git","clone_url":"https://github.com/ABASystems/graphene-django.git","svn_url":"https://github.com/ABASystems/graphene-django","homepage":"http://docs.graphene-python.org/projects/django/en/latest/","size":284,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphql-python:master","ref":"master","sha":"283bccf9d38a77252eabdfcc8f1e8d3caa01ae9d","user":{"login":"graphql-python","id":15002022,"avatar_url":"https://avatars3.githubusercontent.com/u/15002022?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-python","html_url":"https://github.com/graphql-python","followers_url":"https://api.github.com/users/graphql-python/followers","following_url":"https://api.github.com/users/graphql-python/following{/other_user}","gists_url":"https://api.github.com/users/graphql-python/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-python/subscriptions","organizations_url":"https://api.github.com/users/graphql-python/orgs","repos_url":"https://api.github.com/users/graphql-python/repos","events_url":"https://api.github.com/users/graphql-python/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-python/received_events","type":"Organization","site_admin":false},"repo":{"id":68483365,"name":"graphene-django","full_name":"graphql-python/graphene-django","owner":{"login":"graphql-python","id":15002022,"avatar_url":"https://avatars3.githubusercontent.com/u/15002022?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-python","html_url":"https://github.com/graphql-python","followers_url":"https://api.github.com/users/graphql-python/followers","following_url":"https://api.github.com/users/graphql-python/following{/other_user}","gists_url":"https://api.github.com/users/graphql-python/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-python/subscriptions","organizations_url":"https://api.github.com/users/graphql-python/orgs","repos_url":"https://api.github.com/users/graphql-python/repos","events_url":"https://api.github.com/users/graphql-python/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphql-python/graphene-django","description":"Graphene Django integration","fork":false,"url":"https://api.github.com/repos/graphql-python/graphene-django","forks_url":"https://api.github.com/repos/graphql-python/graphene-django/forks","keys_url":"https://api.github.com/repos/graphql-python/graphene-django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphql-python/graphene-django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphql-python/graphene-django/teams","hooks_url":"https://api.github.com/repos/graphql-python/graphene-django/hooks","issue_events_url":"https://api.github.com/repos/graphql-python/graphene-django/issues/events{/number}","events_url":"https://api.github.com/repos/graphql-python/graphene-django/events","assignees_url":"https://api.github.com/repos/graphql-python/graphene-django/assignees{/user}","branches_url":"https://api.github.com/repos/graphql-python/graphene-django/branches{/branch}","tags_url":"https://api.github.com/repos/graphql-python/graphene-django/tags","blobs_url":"https://api.github.com/repos/graphql-python/graphene-django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphql-python/graphene-django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphql-python/graphene-django/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphql-python/graphene-django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphql-python/graphene-django/statuses/{sha}","languages_url":"https://api.github.com/repos/graphql-python/graphene-django/languages","stargazers_url":"https://api.github.com/repos/graphql-python/graphene-django/stargazers","contributors_url":"https://api.github.com/repos/graphql-python/graphene-django/contributors","subscribers_url":"https://api.github.com/repos/graphql-python/graphene-django/subscribers","subscription_url":"https://api.github.com/repos/graphql-python/graphene-django/subscription","commits_url":"https://api.github.com/repos/graphql-python/graphene-django/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphql-python/graphene-django/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphql-python/graphene-django/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphql-python/graphene-django/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphql-python/graphene-django/contents/{+path}","compare_url":"https://api.github.com/repos/graphql-python/graphene-django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphql-python/graphene-django/merges","archive_url":"https://api.github.com/repos/graphql-python/graphene-django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphql-python/graphene-django/downloads","issues_url":"https://api.github.com/repos/graphql-python/graphene-django/issues{/number}","pulls_url":"https://api.github.com/repos/graphql-python/graphene-django/pulls{/number}","milestones_url":"https://api.github.com/repos/graphql-python/graphene-django/milestones{/number}","notifications_url":"https://api.github.com/repos/graphql-python/graphene-django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphql-python/graphene-django/labels{/name}","releases_url":"https://api.github.com/repos/graphql-python/graphene-django/releases{/id}","deployments_url":"https://api.github.com/repos/graphql-python/graphene-django/deployments","created_at":"2016-09-17T23:26:25Z","updated_at":"2017-10-29T06:47:37Z","pushed_at":"2017-10-30T03:59:47Z","git_url":"git://github.com/graphql-python/graphene-django.git","ssh_url":"git@github.com:graphql-python/graphene-django.git","clone_url":"https://github.com/graphql-python/graphene-django.git","svn_url":"https://github.com/graphql-python/graphene-django","homepage":"http://docs.graphene-python.org/projects/django/en/latest/","size":286,"stargazers_count":769,"watchers_count":769,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":139,"forks":142,"open_issues":139,"watchers":769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphql-python/graphene-django/pulls/299"},"html":{"href":"https://github.com/graphql-python/graphene-django/pull/299"},"issue":{"href":"https://api.github.com/repos/graphql-python/graphene-django/issues/299"},"comments":{"href":"https://api.github.com/repos/graphql-python/graphene-django/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/graphql-python/graphene-django/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/graphql-python/graphene-django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphql-python/graphene-django/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/graphql-python/graphene-django/statuses/0b5f8e8507851dfe2c48cf27b307a97aed92d6f6"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":18,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"furious-luke"}}