{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/97638706","pull_request_review_id":18254701,"id":97638706,"diff_hunk":"@@ -209,6 +209,12 @@ struct bluestore_extent_ref_map_t {\n   bool empty() const {\n     return ref_map.empty();\n   }\n+  bool contains_only(uint64_t offset, uint32_t length) const {\n+    return ref_map.size() == 1 &&\n+      ref_map.begin()->first == offset &&\n+      ref_map.begin()->second.length == length &&\n+      ref_map.begin()->second.refs == 1;\n+  }","path":"src/os/bluestore/bluestore_types.h","position":19,"original_position":9,"commit_id":"20e62bb5b34d2200736183efb32c0fd29c29feed","original_commit_id":"559a81b5298af13a1c7688e2350b1ff00870b3c3","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"this hunk is obsolete","created_at":"2017-01-24T20:04:31Z","updated_at":"2017-01-24T20:04:32Z","html_url":"https://github.com/ceph/ceph/pull/12144#discussion_r97638706","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/12144","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/97638706"},"html":{"href":"https://github.com/ceph/ceph/pull/12144#discussion_r97638706"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12144"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/12144","id":94902157,"html_url":"https://github.com/ceph/ceph/pull/12144","diff_url":"https://github.com/ceph/ceph/pull/12144.diff","patch_url":"https://github.com/ceph/ceph/pull/12144.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/12144","number":12144,"state":"open","locked":false,"title":"os/bluestore: add new garbage collector","user":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars.githubusercontent.com/u/7138176?v=3","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"body":"This is a final version version that estimates how many allocation units one can save if uncompress overlapped blob(s) and save them in raw format.\r\nRebased on top of PR #12904 ","created_at":"2016-11-22T21:32:31Z","updated_at":"2017-01-24T20:04:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d78199dba122cd09d3bc9cfc0633afbff44c87ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/12144/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/12144/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/12144/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/20e62bb5b34d2200736183efb32c0fd29c29feed","head":{"label":"ifed01:wip-bluestore-no-blobdepth","ref":"wip-bluestore-no-blobdepth","sha":"20e62bb5b34d2200736183efb32c0fd29c29feed","user":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars.githubusercontent.com/u/7138176?v=3","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"repo":{"id":42860525,"name":"ceph","full_name":"ifed01/ceph","owner":{"login":"ifed01","id":7138176,"avatar_url":"https://avatars.githubusercontent.com/u/7138176?v=3","gravatar_id":"","url":"https://api.github.com/users/ifed01","html_url":"https://github.com/ifed01","followers_url":"https://api.github.com/users/ifed01/followers","following_url":"https://api.github.com/users/ifed01/following{/other_user}","gists_url":"https://api.github.com/users/ifed01/gists{/gist_id}","starred_url":"https://api.github.com/users/ifed01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifed01/subscriptions","organizations_url":"https://api.github.com/users/ifed01/orgs","repos_url":"https://api.github.com/users/ifed01/repos","events_url":"https://api.github.com/users/ifed01/events{/privacy}","received_events_url":"https://api.github.com/users/ifed01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifed01/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/ifed01/ceph","forks_url":"https://api.github.com/repos/ifed01/ceph/forks","keys_url":"https://api.github.com/repos/ifed01/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifed01/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifed01/ceph/teams","hooks_url":"https://api.github.com/repos/ifed01/ceph/hooks","issue_events_url":"https://api.github.com/repos/ifed01/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ifed01/ceph/events","assignees_url":"https://api.github.com/repos/ifed01/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ifed01/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ifed01/ceph/tags","blobs_url":"https://api.github.com/repos/ifed01/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifed01/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifed01/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifed01/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifed01/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ifed01/ceph/languages","stargazers_url":"https://api.github.com/repos/ifed01/ceph/stargazers","contributors_url":"https://api.github.com/repos/ifed01/ceph/contributors","subscribers_url":"https://api.github.com/repos/ifed01/ceph/subscribers","subscription_url":"https://api.github.com/repos/ifed01/ceph/subscription","commits_url":"https://api.github.com/repos/ifed01/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifed01/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifed01/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifed01/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifed01/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ifed01/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifed01/ceph/merges","archive_url":"https://api.github.com/repos/ifed01/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifed01/ceph/downloads","issues_url":"https://api.github.com/repos/ifed01/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ifed01/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ifed01/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ifed01/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifed01/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ifed01/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ifed01/ceph/deployments","created_at":"2015-09-21T10:49:23Z","updated_at":"2016-01-12T23:28:29Z","pushed_at":"2017-01-24T13:58:03Z","git_url":"git://github.com/ifed01/ceph.git","ssh_url":"git@github.com:ifed01/ceph.git","clone_url":"https://github.com/ifed01/ceph.git","svn_url":"https://github.com/ifed01/ceph","homepage":"http://ceph.com","size":193304,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"b2df030a5075484cf8122eb4785e277f3f40eff6","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-01-24T15:50:11Z","pushed_at":"2017-01-24T19:58:59Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":189064,"stargazers_count":2832,"watchers_count":2832,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1668,"mirror_url":null,"open_issues_count":471,"forks":1668,"open_issues":471,"watchers":2832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12144"},"html":{"href":"https://github.com/ceph/ceph/pull/12144"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/12144"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/12144/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12144/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12144/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/20e62bb5b34d2200736183efb32c0fd29c29feed"}}}}
{"actor":{"display_login":"liewegas"}}