{"action":"created","issue":{"url":"https://api.github.com/repos/geodynamics/aspect/issues/1429","repository_url":"https://api.github.com/repos/geodynamics/aspect","labels_url":"https://api.github.com/repos/geodynamics/aspect/issues/1429/labels{/name}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/1429/comments","events_url":"https://api.github.com/repos/geodynamics/aspect/issues/1429/events","html_url":"https://github.com/geodynamics/aspect/pull/1429","id":219435761,"number":1429,"title":"Fix statistics output for nonlinear iterations","user":{"login":"jdannberg","id":7517347,"avatar_url":"https://avatars2.githubusercontent.com/u/7517347?v=3","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-04-05T01:23:31Z","updated_at":"2017-04-09T21:26:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/1429","html_url":"https://github.com/geodynamics/aspect/pull/1429","diff_url":"https://github.com/geodynamics/aspect/pull/1429.diff","patch_url":"https://github.com/geodynamics/aspect/pull/1429.patch"},"body":"In cases where more than one nonlinear iteration is done, until now the global statistics output of a new time step (time step number, number of cells, etc.) was added to the row of the last nonlinear iteration of the previous time step in the statistics file. This has to do with the way the TableHandler works. It does not know when we start a new time step, it just adds a new row when there already is an entry for that given column in the previous row. As during the nonlinear iterations we add a low of rows with only iteration counts, the behaviour described above is what happens. \r\n\r\nThis pull request fixes this bug (and keeps the same order of the columns in the statistics file) by initializing the columns at the beginning of the model run, but adding the global statistics output at the end of every time step.\r\n\r\nThis will probably change a lot of tests, and I also will still have to go through all of them as there are so many different cases that I am not quite sure I've covered all of them. "},"comment":{"url":"https://api.github.com/repos/geodynamics/aspect/issues/comments/292814196","html_url":"https://github.com/geodynamics/aspect/pull/1429#issuecomment-292814196","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/1429","id":292814196,"user":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars3.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"created_at":"2017-04-09T21:26:11Z","updated_at":"2017-04-09T21:26:11Z","body":"> No, I think there definitely is value in outputting things for each nonlinear\r\n> iteration.\r\n\r\nYou are talking about linear solver iteration numbers only or is there anything else you care about? Could we move them into a separate statistics file maybe?"}}
{"actor":{"display_login":"tjhei"}}