{"action":"created","comment":{"url":"https://api.github.com/repos/phpstan/phpstan/pulls/comments/153725683","pull_request_review_id":79773425,"id":153725683,"diff_hunk":"@@ -115,6 +115,16 @@ public function getIterableValueType(): Type\n \t\treturn new ErrorType();\n \t}\n \n+\tpublic function isOffsetAccesible(): TrinaryLogic\n+\t{\n+\t\treturn TrinaryLogic::createNo();","path":"src/Type/NullType.php","position":6,"original_position":6,"commit_id":"6930a50476f3697560685f66b5d6196ea2d4d4ad","original_commit_id":"6930a50476f3697560685f66b5d6196ea2d4d4ad","user":{"login":"JanTvrdik","id":175109,"avatar_url":"https://avatars1.githubusercontent.com/u/175109?v=4","gravatar_id":"","url":"https://api.github.com/users/JanTvrdik","html_url":"https://github.com/JanTvrdik","followers_url":"https://api.github.com/users/JanTvrdik/followers","following_url":"https://api.github.com/users/JanTvrdik/following{/other_user}","gists_url":"https://api.github.com/users/JanTvrdik/gists{/gist_id}","starred_url":"https://api.github.com/users/JanTvrdik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanTvrdik/subscriptions","organizations_url":"https://api.github.com/users/JanTvrdik/orgs","repos_url":"https://api.github.com/users/JanTvrdik/repos","events_url":"https://api.github.com/users/JanTvrdik/events{/privacy}","received_events_url":"https://api.github.com/users/JanTvrdik/received_events","type":"User","site_admin":false},"body":"This is technically not true. as you can do `null[123]` or `null[new stdClass]`. I'm not sure how many people rely on this behavior. Similar is true of booleans, but AFAIK `null[123]` is used a lot more in real world than `true[123]`.\r\n\r\nI'd recommend keeping the No result and seeing how many stuff will it break in real world.","created_at":"2017-11-29T09:02:55Z","updated_at":"2017-11-29T09:02:56Z","html_url":"https://github.com/phpstan/phpstan/pull/620#discussion_r153725683","pull_request_url":"https://api.github.com/repos/phpstan/phpstan/pulls/620","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/phpstan/phpstan/pulls/comments/153725683"},"html":{"href":"https://github.com/phpstan/phpstan/pull/620#discussion_r153725683"},"pull_request":{"href":"https://api.github.com/repos/phpstan/phpstan/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/phpstan/phpstan/pulls/620","id":155071795,"html_url":"https://github.com/phpstan/phpstan/pull/620","diff_url":"https://github.com/phpstan/phpstan/pull/620.diff","patch_url":"https://github.com/phpstan/phpstan/pull/620.patch","issue_url":"https://api.github.com/repos/phpstan/phpstan/issues/620","number":620,"state":"open","locked":false,"title":"Support for array access on objects with ArrayAccess interface","user":{"login":"pepakriz","id":383294,"avatar_url":"https://avatars2.githubusercontent.com/u/383294?v=4","gravatar_id":"","url":"https://api.github.com/users/pepakriz","html_url":"https://github.com/pepakriz","followers_url":"https://api.github.com/users/pepakriz/followers","following_url":"https://api.github.com/users/pepakriz/following{/other_user}","gists_url":"https://api.github.com/users/pepakriz/gists{/gist_id}","starred_url":"https://api.github.com/users/pepakriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepakriz/subscriptions","organizations_url":"https://api.github.com/users/pepakriz/orgs","repos_url":"https://api.github.com/users/pepakriz/repos","events_url":"https://api.github.com/users/pepakriz/events{/privacy}","received_events_url":"https://api.github.com/users/pepakriz/received_events","type":"User","site_admin":false},"body":"This is very naive solution, but it works. Do you know some better solution for detecting `ArrayAccess` interface?","created_at":"2017-11-28T13:32:21Z","updated_at":"2017-11-29T09:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37d0122ded47a1acbf4c9b9629efb55e226dcc69","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpstan/phpstan/pulls/620/commits","review_comments_url":"https://api.github.com/repos/phpstan/phpstan/pulls/620/comments","review_comment_url":"https://api.github.com/repos/phpstan/phpstan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpstan/phpstan/issues/620/comments","statuses_url":"https://api.github.com/repos/phpstan/phpstan/statuses/6930a50476f3697560685f66b5d6196ea2d4d4ad","head":{"label":"pepakriz:array-accessable","ref":"array-accessable","sha":"6930a50476f3697560685f66b5d6196ea2d4d4ad","user":{"login":"pepakriz","id":383294,"avatar_url":"https://avatars2.githubusercontent.com/u/383294?v=4","gravatar_id":"","url":"https://api.github.com/users/pepakriz","html_url":"https://github.com/pepakriz","followers_url":"https://api.github.com/users/pepakriz/followers","following_url":"https://api.github.com/users/pepakriz/following{/other_user}","gists_url":"https://api.github.com/users/pepakriz/gists{/gist_id}","starred_url":"https://api.github.com/users/pepakriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepakriz/subscriptions","organizations_url":"https://api.github.com/users/pepakriz/orgs","repos_url":"https://api.github.com/users/pepakriz/repos","events_url":"https://api.github.com/users/pepakriz/events{/privacy}","received_events_url":"https://api.github.com/users/pepakriz/received_events","type":"User","site_admin":false},"repo":{"id":68318594,"name":"phpstan","full_name":"pepakriz/phpstan","owner":{"login":"pepakriz","id":383294,"avatar_url":"https://avatars2.githubusercontent.com/u/383294?v=4","gravatar_id":"","url":"https://api.github.com/users/pepakriz","html_url":"https://github.com/pepakriz","followers_url":"https://api.github.com/users/pepakriz/followers","following_url":"https://api.github.com/users/pepakriz/following{/other_user}","gists_url":"https://api.github.com/users/pepakriz/gists{/gist_id}","starred_url":"https://api.github.com/users/pepakriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepakriz/subscriptions","organizations_url":"https://api.github.com/users/pepakriz/orgs","repos_url":"https://api.github.com/users/pepakriz/repos","events_url":"https://api.github.com/users/pepakriz/events{/privacy}","received_events_url":"https://api.github.com/users/pepakriz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pepakriz/phpstan","description":"PHP Static Analysis Tool","fork":true,"url":"https://api.github.com/repos/pepakriz/phpstan","forks_url":"https://api.github.com/repos/pepakriz/phpstan/forks","keys_url":"https://api.github.com/repos/pepakriz/phpstan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pepakriz/phpstan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pepakriz/phpstan/teams","hooks_url":"https://api.github.com/repos/pepakriz/phpstan/hooks","issue_events_url":"https://api.github.com/repos/pepakriz/phpstan/issues/events{/number}","events_url":"https://api.github.com/repos/pepakriz/phpstan/events","assignees_url":"https://api.github.com/repos/pepakriz/phpstan/assignees{/user}","branches_url":"https://api.github.com/repos/pepakriz/phpstan/branches{/branch}","tags_url":"https://api.github.com/repos/pepakriz/phpstan/tags","blobs_url":"https://api.github.com/repos/pepakriz/phpstan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pepakriz/phpstan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pepakriz/phpstan/git/refs{/sha}","trees_url":"https://api.github.com/repos/pepakriz/phpstan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pepakriz/phpstan/statuses/{sha}","languages_url":"https://api.github.com/repos/pepakriz/phpstan/languages","stargazers_url":"https://api.github.com/repos/pepakriz/phpstan/stargazers","contributors_url":"https://api.github.com/repos/pepakriz/phpstan/contributors","subscribers_url":"https://api.github.com/repos/pepakriz/phpstan/subscribers","subscription_url":"https://api.github.com/repos/pepakriz/phpstan/subscription","commits_url":"https://api.github.com/repos/pepakriz/phpstan/commits{/sha}","git_commits_url":"https://api.github.com/repos/pepakriz/phpstan/git/commits{/sha}","comments_url":"https://api.github.com/repos/pepakriz/phpstan/comments{/number}","issue_comment_url":"https://api.github.com/repos/pepakriz/phpstan/issues/comments{/number}","contents_url":"https://api.github.com/repos/pepakriz/phpstan/contents/{+path}","compare_url":"https://api.github.com/repos/pepakriz/phpstan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pepakriz/phpstan/merges","archive_url":"https://api.github.com/repos/pepakriz/phpstan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pepakriz/phpstan/downloads","issues_url":"https://api.github.com/repos/pepakriz/phpstan/issues{/number}","pulls_url":"https://api.github.com/repos/pepakriz/phpstan/pulls{/number}","milestones_url":"https://api.github.com/repos/pepakriz/phpstan/milestones{/number}","notifications_url":"https://api.github.com/repos/pepakriz/phpstan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pepakriz/phpstan/labels{/name}","releases_url":"https://api.github.com/repos/pepakriz/phpstan/releases{/id}","deployments_url":"https://api.github.com/repos/pepakriz/phpstan/deployments","created_at":"2016-09-15T18:06:50Z","updated_at":"2016-09-15T18:06:52Z","pushed_at":"2017-11-29T08:06:20Z","git_url":"git://github.com/pepakriz/phpstan.git","ssh_url":"git@github.com:pepakriz/phpstan.git","clone_url":"https://github.com/pepakriz/phpstan.git","svn_url":"https://github.com/pepakriz/phpstan","homepage":"","size":2334,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpstan:master","ref":"master","sha":"324e591f1f31730501d079a24aa3c8c64a66b016","user":{"login":"phpstan","id":16435710,"avatar_url":"https://avatars0.githubusercontent.com/u/16435710?v=4","gravatar_id":"","url":"https://api.github.com/users/phpstan","html_url":"https://github.com/phpstan","followers_url":"https://api.github.com/users/phpstan/followers","following_url":"https://api.github.com/users/phpstan/following{/other_user}","gists_url":"https://api.github.com/users/phpstan/gists{/gist_id}","starred_url":"https://api.github.com/users/phpstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpstan/subscriptions","organizations_url":"https://api.github.com/users/phpstan/orgs","repos_url":"https://api.github.com/users/phpstan/repos","events_url":"https://api.github.com/users/phpstan/events{/privacy}","received_events_url":"https://api.github.com/users/phpstan/received_events","type":"Organization","site_admin":false},"repo":{"id":49014795,"name":"phpstan","full_name":"phpstan/phpstan","owner":{"login":"phpstan","id":16435710,"avatar_url":"https://avatars0.githubusercontent.com/u/16435710?v=4","gravatar_id":"","url":"https://api.github.com/users/phpstan","html_url":"https://github.com/phpstan","followers_url":"https://api.github.com/users/phpstan/followers","following_url":"https://api.github.com/users/phpstan/following{/other_user}","gists_url":"https://api.github.com/users/phpstan/gists{/gist_id}","starred_url":"https://api.github.com/users/phpstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpstan/subscriptions","organizations_url":"https://api.github.com/users/phpstan/orgs","repos_url":"https://api.github.com/users/phpstan/repos","events_url":"https://api.github.com/users/phpstan/events{/privacy}","received_events_url":"https://api.github.com/users/phpstan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpstan/phpstan","description":"PHP Static Analysis Tool - discover bugs in your code without running it!","fork":false,"url":"https://api.github.com/repos/phpstan/phpstan","forks_url":"https://api.github.com/repos/phpstan/phpstan/forks","keys_url":"https://api.github.com/repos/phpstan/phpstan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpstan/phpstan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpstan/phpstan/teams","hooks_url":"https://api.github.com/repos/phpstan/phpstan/hooks","issue_events_url":"https://api.github.com/repos/phpstan/phpstan/issues/events{/number}","events_url":"https://api.github.com/repos/phpstan/phpstan/events","assignees_url":"https://api.github.com/repos/phpstan/phpstan/assignees{/user}","branches_url":"https://api.github.com/repos/phpstan/phpstan/branches{/branch}","tags_url":"https://api.github.com/repos/phpstan/phpstan/tags","blobs_url":"https://api.github.com/repos/phpstan/phpstan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpstan/phpstan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpstan/phpstan/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpstan/phpstan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpstan/phpstan/statuses/{sha}","languages_url":"https://api.github.com/repos/phpstan/phpstan/languages","stargazers_url":"https://api.github.com/repos/phpstan/phpstan/stargazers","contributors_url":"https://api.github.com/repos/phpstan/phpstan/contributors","subscribers_url":"https://api.github.com/repos/phpstan/phpstan/subscribers","subscription_url":"https://api.github.com/repos/phpstan/phpstan/subscription","commits_url":"https://api.github.com/repos/phpstan/phpstan/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpstan/phpstan/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpstan/phpstan/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpstan/phpstan/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpstan/phpstan/contents/{+path}","compare_url":"https://api.github.com/repos/phpstan/phpstan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpstan/phpstan/merges","archive_url":"https://api.github.com/repos/phpstan/phpstan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpstan/phpstan/downloads","issues_url":"https://api.github.com/repos/phpstan/phpstan/issues{/number}","pulls_url":"https://api.github.com/repos/phpstan/phpstan/pulls{/number}","milestones_url":"https://api.github.com/repos/phpstan/phpstan/milestones{/number}","notifications_url":"https://api.github.com/repos/phpstan/phpstan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpstan/phpstan/labels{/name}","releases_url":"https://api.github.com/repos/phpstan/phpstan/releases{/id}","deployments_url":"https://api.github.com/repos/phpstan/phpstan/deployments","created_at":"2016-01-04T18:22:16Z","updated_at":"2017-11-29T08:46:45Z","pushed_at":"2017-11-29T08:24:01Z","git_url":"git://github.com/phpstan/phpstan.git","ssh_url":"git@github.com:phpstan/phpstan.git","clone_url":"https://github.com/phpstan/phpstan.git","svn_url":"https://github.com/phpstan/phpstan","homepage":"","size":2338,"stargazers_count":2507,"watchers_count":2507,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":158,"open_issues":102,"watchers":2507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpstan/phpstan/pulls/620"},"html":{"href":"https://github.com/phpstan/phpstan/pull/620"},"issue":{"href":"https://api.github.com/repos/phpstan/phpstan/issues/620"},"comments":{"href":"https://api.github.com/repos/phpstan/phpstan/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/phpstan/phpstan/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/phpstan/phpstan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpstan/phpstan/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/phpstan/phpstan/statuses/6930a50476f3697560685f66b5d6196ea2d4d4ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JanTvrdik"}}