{"action":"created","comment":{"url":"https://api.github.com/repos/Cloudef/wlc/pulls/comments/95797678","pull_request_review_id":16363559,"id":95797678,"diff_hunk":"@@ -209,7 +209,11 @@ read_properties(struct wlc_xwm *xwm, struct wlc_x11_window *win, const xcb_atom_\n             size_t class_total_len = xcb_get_property_value_length(reply);\n \n             size_t class_class_offset = strnlen(class, class_total_len)+1;\n-            wlc_view_set_class_ptr(view, class+class_class_offset, class_total_len-class_class_offset);\n+            if (class_class_offset >= class_total_len) {","path":"src/xwayland/xwm.c","position":null,"original_position":5,"commit_id":"30ee83526d91207e3a33f0852534665f26079ce2","original_commit_id":"30ee83526d91207e3a33f0852534665f26079ce2","user":{"login":"Cloudef","id":480330,"avatar_url":"https://avatars.githubusercontent.com/u/480330?v=3","gravatar_id":"","url":"https://api.github.com/users/Cloudef","html_url":"https://github.com/Cloudef","followers_url":"https://api.github.com/users/Cloudef/followers","following_url":"https://api.github.com/users/Cloudef/following{/other_user}","gists_url":"https://api.github.com/users/Cloudef/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudef/subscriptions","organizations_url":"https://api.github.com/users/Cloudef/orgs","repos_url":"https://api.github.com/users/Cloudef/repos","events_url":"https://api.github.com/users/Cloudef/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudef/received_events","type":"User","site_admin":false},"body":"Won't this fail if class_total_len == 0?","created_at":"2017-01-12T14:08:36Z","updated_at":"2017-01-12T14:08:36Z","html_url":"https://github.com/Cloudef/wlc/pull/222#discussion_r95797678","pull_request_url":"https://api.github.com/repos/Cloudef/wlc/pulls/222","_links":{"self":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/comments/95797678"},"html":{"href":"https://github.com/Cloudef/wlc/pull/222#discussion_r95797678"},"pull_request":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/Cloudef/wlc/pulls/222","id":100571722,"html_url":"https://github.com/Cloudef/wlc/pull/222","diff_url":"https://github.com/Cloudef/wlc/pull/222.diff","patch_url":"https://github.com/Cloudef/wlc/pull/222.patch","issue_url":"https://api.github.com/repos/Cloudef/wlc/issues/222","number":222,"state":"open","locked":false,"title":"Use WM_CLASS class instead of instance (fix #218)","user":{"login":"LeonardKoenig","id":7831843,"avatar_url":"https://avatars.githubusercontent.com/u/7831843?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonardKoenig","html_url":"https://github.com/LeonardKoenig","followers_url":"https://api.github.com/users/LeonardKoenig/followers","following_url":"https://api.github.com/users/LeonardKoenig/following{/other_user}","gists_url":"https://api.github.com/users/LeonardKoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonardKoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonardKoenig/subscriptions","organizations_url":"https://api.github.com/users/LeonardKoenig/orgs","repos_url":"https://api.github.com/users/LeonardKoenig/repos","events_url":"https://api.github.com/users/LeonardKoenig/events{/privacy}","received_events_url":"https://api.github.com/users/LeonardKoenig/received_events","type":"User","site_admin":false},"body":"Usually the second part of WM_CLASS (the actual window class, not the instance) is\r\nexpected (compare to i3wm class property) so we use this one.\r\n\r\nThis fixes #218 ","created_at":"2017-01-07T15:12:07Z","updated_at":"2017-01-12T14:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"873c1d7a78d781b2718c0e34c540b1523012a119","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cloudef/wlc/pulls/222/commits","review_comments_url":"https://api.github.com/repos/Cloudef/wlc/pulls/222/comments","review_comment_url":"https://api.github.com/repos/Cloudef/wlc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cloudef/wlc/issues/222/comments","statuses_url":"https://api.github.com/repos/Cloudef/wlc/statuses/30ee83526d91207e3a33f0852534665f26079ce2","head":{"label":"LeonardKoenig:prq_WM_CLASS","ref":"prq_WM_CLASS","sha":"30ee83526d91207e3a33f0852534665f26079ce2","user":{"login":"LeonardKoenig","id":7831843,"avatar_url":"https://avatars.githubusercontent.com/u/7831843?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonardKoenig","html_url":"https://github.com/LeonardKoenig","followers_url":"https://api.github.com/users/LeonardKoenig/followers","following_url":"https://api.github.com/users/LeonardKoenig/following{/other_user}","gists_url":"https://api.github.com/users/LeonardKoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonardKoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonardKoenig/subscriptions","organizations_url":"https://api.github.com/users/LeonardKoenig/orgs","repos_url":"https://api.github.com/users/LeonardKoenig/repos","events_url":"https://api.github.com/users/LeonardKoenig/events{/privacy}","received_events_url":"https://api.github.com/users/LeonardKoenig/received_events","type":"User","site_admin":false},"repo":{"id":78282898,"name":"wlc","full_name":"LeonardKoenig/wlc","owner":{"login":"LeonardKoenig","id":7831843,"avatar_url":"https://avatars.githubusercontent.com/u/7831843?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonardKoenig","html_url":"https://github.com/LeonardKoenig","followers_url":"https://api.github.com/users/LeonardKoenig/followers","following_url":"https://api.github.com/users/LeonardKoenig/following{/other_user}","gists_url":"https://api.github.com/users/LeonardKoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonardKoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonardKoenig/subscriptions","organizations_url":"https://api.github.com/users/LeonardKoenig/orgs","repos_url":"https://api.github.com/users/LeonardKoenig/repos","events_url":"https://api.github.com/users/LeonardKoenig/events{/privacy}","received_events_url":"https://api.github.com/users/LeonardKoenig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LeonardKoenig/wlc","description":"Wayland compositor library","fork":true,"url":"https://api.github.com/repos/LeonardKoenig/wlc","forks_url":"https://api.github.com/repos/LeonardKoenig/wlc/forks","keys_url":"https://api.github.com/repos/LeonardKoenig/wlc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeonardKoenig/wlc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeonardKoenig/wlc/teams","hooks_url":"https://api.github.com/repos/LeonardKoenig/wlc/hooks","issue_events_url":"https://api.github.com/repos/LeonardKoenig/wlc/issues/events{/number}","events_url":"https://api.github.com/repos/LeonardKoenig/wlc/events","assignees_url":"https://api.github.com/repos/LeonardKoenig/wlc/assignees{/user}","branches_url":"https://api.github.com/repos/LeonardKoenig/wlc/branches{/branch}","tags_url":"https://api.github.com/repos/LeonardKoenig/wlc/tags","blobs_url":"https://api.github.com/repos/LeonardKoenig/wlc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeonardKoenig/wlc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeonardKoenig/wlc/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeonardKoenig/wlc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeonardKoenig/wlc/statuses/{sha}","languages_url":"https://api.github.com/repos/LeonardKoenig/wlc/languages","stargazers_url":"https://api.github.com/repos/LeonardKoenig/wlc/stargazers","contributors_url":"https://api.github.com/repos/LeonardKoenig/wlc/contributors","subscribers_url":"https://api.github.com/repos/LeonardKoenig/wlc/subscribers","subscription_url":"https://api.github.com/repos/LeonardKoenig/wlc/subscription","commits_url":"https://api.github.com/repos/LeonardKoenig/wlc/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeonardKoenig/wlc/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeonardKoenig/wlc/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeonardKoenig/wlc/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeonardKoenig/wlc/contents/{+path}","compare_url":"https://api.github.com/repos/LeonardKoenig/wlc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeonardKoenig/wlc/merges","archive_url":"https://api.github.com/repos/LeonardKoenig/wlc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeonardKoenig/wlc/downloads","issues_url":"https://api.github.com/repos/LeonardKoenig/wlc/issues{/number}","pulls_url":"https://api.github.com/repos/LeonardKoenig/wlc/pulls{/number}","milestones_url":"https://api.github.com/repos/LeonardKoenig/wlc/milestones{/number}","notifications_url":"https://api.github.com/repos/LeonardKoenig/wlc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeonardKoenig/wlc/labels{/name}","releases_url":"https://api.github.com/repos/LeonardKoenig/wlc/releases{/id}","deployments_url":"https://api.github.com/repos/LeonardKoenig/wlc/deployments","created_at":"2017-01-07T14:15:07Z","updated_at":"2017-01-07T14:15:09Z","pushed_at":"2017-01-12T13:34:05Z","git_url":"git://github.com/LeonardKoenig/wlc.git","ssh_url":"git@github.com:LeonardKoenig/wlc.git","clone_url":"https://github.com/LeonardKoenig/wlc.git","svn_url":"https://github.com/LeonardKoenig/wlc","homepage":null,"size":1511,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cloudef:master","ref":"master","sha":"61dbcf2c98b931a4920d5abca6c7b3e677f68253","user":{"login":"Cloudef","id":480330,"avatar_url":"https://avatars.githubusercontent.com/u/480330?v=3","gravatar_id":"","url":"https://api.github.com/users/Cloudef","html_url":"https://github.com/Cloudef","followers_url":"https://api.github.com/users/Cloudef/followers","following_url":"https://api.github.com/users/Cloudef/following{/other_user}","gists_url":"https://api.github.com/users/Cloudef/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudef/subscriptions","organizations_url":"https://api.github.com/users/Cloudef/orgs","repos_url":"https://api.github.com/users/Cloudef/repos","events_url":"https://api.github.com/users/Cloudef/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudef/received_events","type":"User","site_admin":false},"repo":{"id":22349616,"name":"wlc","full_name":"Cloudef/wlc","owner":{"login":"Cloudef","id":480330,"avatar_url":"https://avatars.githubusercontent.com/u/480330?v=3","gravatar_id":"","url":"https://api.github.com/users/Cloudef","html_url":"https://github.com/Cloudef","followers_url":"https://api.github.com/users/Cloudef/followers","following_url":"https://api.github.com/users/Cloudef/following{/other_user}","gists_url":"https://api.github.com/users/Cloudef/gists{/gist_id}","starred_url":"https://api.github.com/users/Cloudef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cloudef/subscriptions","organizations_url":"https://api.github.com/users/Cloudef/orgs","repos_url":"https://api.github.com/users/Cloudef/repos","events_url":"https://api.github.com/users/Cloudef/events{/privacy}","received_events_url":"https://api.github.com/users/Cloudef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cloudef/wlc","description":"Wayland compositor library","fork":false,"url":"https://api.github.com/repos/Cloudef/wlc","forks_url":"https://api.github.com/repos/Cloudef/wlc/forks","keys_url":"https://api.github.com/repos/Cloudef/wlc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cloudef/wlc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cloudef/wlc/teams","hooks_url":"https://api.github.com/repos/Cloudef/wlc/hooks","issue_events_url":"https://api.github.com/repos/Cloudef/wlc/issues/events{/number}","events_url":"https://api.github.com/repos/Cloudef/wlc/events","assignees_url":"https://api.github.com/repos/Cloudef/wlc/assignees{/user}","branches_url":"https://api.github.com/repos/Cloudef/wlc/branches{/branch}","tags_url":"https://api.github.com/repos/Cloudef/wlc/tags","blobs_url":"https://api.github.com/repos/Cloudef/wlc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cloudef/wlc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cloudef/wlc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cloudef/wlc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cloudef/wlc/statuses/{sha}","languages_url":"https://api.github.com/repos/Cloudef/wlc/languages","stargazers_url":"https://api.github.com/repos/Cloudef/wlc/stargazers","contributors_url":"https://api.github.com/repos/Cloudef/wlc/contributors","subscribers_url":"https://api.github.com/repos/Cloudef/wlc/subscribers","subscription_url":"https://api.github.com/repos/Cloudef/wlc/subscription","commits_url":"https://api.github.com/repos/Cloudef/wlc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cloudef/wlc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cloudef/wlc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cloudef/wlc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cloudef/wlc/contents/{+path}","compare_url":"https://api.github.com/repos/Cloudef/wlc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cloudef/wlc/merges","archive_url":"https://api.github.com/repos/Cloudef/wlc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cloudef/wlc/downloads","issues_url":"https://api.github.com/repos/Cloudef/wlc/issues{/number}","pulls_url":"https://api.github.com/repos/Cloudef/wlc/pulls{/number}","milestones_url":"https://api.github.com/repos/Cloudef/wlc/milestones{/number}","notifications_url":"https://api.github.com/repos/Cloudef/wlc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cloudef/wlc/labels{/name}","releases_url":"https://api.github.com/repos/Cloudef/wlc/releases{/id}","deployments_url":"https://api.github.com/repos/Cloudef/wlc/deployments","created_at":"2014-07-28T16:27:14Z","updated_at":"2017-01-11T19:58:32Z","pushed_at":"2017-01-12T13:34:06Z","git_url":"git://github.com/Cloudef/wlc.git","ssh_url":"git@github.com:Cloudef/wlc.git","clone_url":"https://github.com/Cloudef/wlc.git","svn_url":"https://github.com/Cloudef/wlc","homepage":null,"size":1510,"stargazers_count":203,"watchers_count":203,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":65,"forks":49,"open_issues":65,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/222"},"html":{"href":"https://github.com/Cloudef/wlc/pull/222"},"issue":{"href":"https://api.github.com/repos/Cloudef/wlc/issues/222"},"comments":{"href":"https://api.github.com/repos/Cloudef/wlc/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cloudef/wlc/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/Cloudef/wlc/statuses/30ee83526d91207e3a33f0852534665f26079ce2"}}}}
{"actor":{"display_login":"Cloudef"}}