{"action":"created","comment":{"url":"https://api.github.com/repos/tvs/uaa/pulls/comments/96743421","pull_request_review_id":17335729,"id":96743421,"diff_hunk":"@@ -79,42 +79,84 @@ public IdentityZone retrieveBySubdomain(String subdomain) {\n     @Override\n     public List<IdentityZone> retrieveAll() {\n         try {\n-            String systemTenant = this._idmClient.getSystemTenant();\n             ArrayList<IdentityZone> list = new ArrayList<IdentityZone>();\n             for (String tenant : this._idmClient.getAllTenants()) {\n-                list.add(identityZoneForTenant(this._idmClient.getTenant(tenant),\n-                        systemTenant.equalsIgnoreCase(tenant)));\n+                list.add(getIdentityZoneFromTenant(tenant));\n             }\n-\n+            \n             return list;\n         } catch (Exception ex) {\n             throw new IllegalStateException(\"Failed to retrieve zones.\", ex);\n         }\n     }\n+    \n+    private IdentityZone identityZoneForTenant(String tenantName) throws Exception {\n+        IdentityZone zone = new IdentityZone();\n+        Tenant t = this._idmClient.getTenant(tenantName);\n+        \n+        zone.setId(t.getName());\n+        zone.setName(t.getName());\n+        zone.setSubdomain(t.getName());\n+        zone.setDescription(t._longName);\n+        zone.setVersion(1);\n+        \n+        return zone;\n+    }\n+    \n+    private void configureIdentityZone(String tenantName, IdentityZone zone) throws Exception {\n+        IdentityZoneConfiguration config = this._configs.get(tenantName);","path":"server/src/main/java/org/cloudfoundry/identity/uaa/zone/VmidentityIdentityZoneProvisioning.java","position":79,"original_position":79,"commit_id":"b0cdeebb6ad31c9d8a915f2836555759e67e08aa","original_commit_id":"b0cdeebb6ad31c9d8a915f2836555759e67e08aa","user":{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false},"body":"They're not fully wired - updates are unavailable, so at least some of it still get stored only in memory.","created_at":"2017-01-18T21:57:19Z","updated_at":"2017-01-18T21:57:20Z","html_url":"https://github.com/tvs/uaa/pull/4#discussion_r96743421","pull_request_url":"https://api.github.com/repos/tvs/uaa/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/tvs/uaa/pulls/comments/96743421"},"html":{"href":"https://github.com/tvs/uaa/pull/4#discussion_r96743421"},"pull_request":{"href":"https://api.github.com/repos/tvs/uaa/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/tvs/uaa/pulls/4","id":101962570,"html_url":"https://github.com/tvs/uaa/pull/4","diff_url":"https://github.com/tvs/uaa/pull/4.diff","patch_url":"https://github.com/tvs/uaa/pull/4.patch","issue_url":"https://api.github.com/repos/tvs/uaa/issues/4","number":4,"state":"open","locked":false,"title":"Wire in signing certs taken from IDM","user":{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-17T22:41:20Z","updated_at":"2017-01-18T21:57:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8658cfc34cef8c1da9d08e201cb0f57f878da62e","assignee":{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false},"assignees":[{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tvs/uaa/pulls/4/commits","review_comments_url":"https://api.github.com/repos/tvs/uaa/pulls/4/comments","review_comment_url":"https://api.github.com/repos/tvs/uaa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tvs/uaa/issues/4/comments","statuses_url":"https://api.github.com/repos/tvs/uaa/statuses/b0cdeebb6ad31c9d8a915f2836555759e67e08aa","head":{"label":"tvs:add-signing-certs","ref":"add-signing-certs","sha":"b0cdeebb6ad31c9d8a915f2836555759e67e08aa","user":{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false},"repo":{"id":78046217,"name":"uaa","full_name":"tvs/uaa","owner":{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tvs/uaa","description":"CloudFoundry User Account and Authentication (UAA) Server","fork":true,"url":"https://api.github.com/repos/tvs/uaa","forks_url":"https://api.github.com/repos/tvs/uaa/forks","keys_url":"https://api.github.com/repos/tvs/uaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tvs/uaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tvs/uaa/teams","hooks_url":"https://api.github.com/repos/tvs/uaa/hooks","issue_events_url":"https://api.github.com/repos/tvs/uaa/issues/events{/number}","events_url":"https://api.github.com/repos/tvs/uaa/events","assignees_url":"https://api.github.com/repos/tvs/uaa/assignees{/user}","branches_url":"https://api.github.com/repos/tvs/uaa/branches{/branch}","tags_url":"https://api.github.com/repos/tvs/uaa/tags","blobs_url":"https://api.github.com/repos/tvs/uaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tvs/uaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tvs/uaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/tvs/uaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tvs/uaa/statuses/{sha}","languages_url":"https://api.github.com/repos/tvs/uaa/languages","stargazers_url":"https://api.github.com/repos/tvs/uaa/stargazers","contributors_url":"https://api.github.com/repos/tvs/uaa/contributors","subscribers_url":"https://api.github.com/repos/tvs/uaa/subscribers","subscription_url":"https://api.github.com/repos/tvs/uaa/subscription","commits_url":"https://api.github.com/repos/tvs/uaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/tvs/uaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/tvs/uaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/tvs/uaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/tvs/uaa/contents/{+path}","compare_url":"https://api.github.com/repos/tvs/uaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tvs/uaa/merges","archive_url":"https://api.github.com/repos/tvs/uaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tvs/uaa/downloads","issues_url":"https://api.github.com/repos/tvs/uaa/issues{/number}","pulls_url":"https://api.github.com/repos/tvs/uaa/pulls{/number}","milestones_url":"https://api.github.com/repos/tvs/uaa/milestones{/number}","notifications_url":"https://api.github.com/repos/tvs/uaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tvs/uaa/labels{/name}","releases_url":"https://api.github.com/repos/tvs/uaa/releases{/id}","deployments_url":"https://api.github.com/repos/tvs/uaa/deployments","created_at":"2017-01-04T19:29:16Z","updated_at":"2017-01-04T19:29:23Z","pushed_at":"2017-01-17T22:41:21Z","git_url":"git://github.com/tvs/uaa.git","ssh_url":"git@github.com:tvs/uaa.git","clone_url":"https://github.com/tvs/uaa.git","svn_url":"https://github.com/tvs/uaa","homepage":"","size":33973,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tvs:vmidentity","ref":"vmidentity","sha":"9a5d884c9213b387078404b1d4449c04a89cf6f9","user":{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false},"repo":{"id":78046217,"name":"uaa","full_name":"tvs/uaa","owner":{"login":"tvs","id":145500,"avatar_url":"https://avatars.githubusercontent.com/u/145500?v=3","gravatar_id":"","url":"https://api.github.com/users/tvs","html_url":"https://github.com/tvs","followers_url":"https://api.github.com/users/tvs/followers","following_url":"https://api.github.com/users/tvs/following{/other_user}","gists_url":"https://api.github.com/users/tvs/gists{/gist_id}","starred_url":"https://api.github.com/users/tvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvs/subscriptions","organizations_url":"https://api.github.com/users/tvs/orgs","repos_url":"https://api.github.com/users/tvs/repos","events_url":"https://api.github.com/users/tvs/events{/privacy}","received_events_url":"https://api.github.com/users/tvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tvs/uaa","description":"CloudFoundry User Account and Authentication (UAA) Server","fork":true,"url":"https://api.github.com/repos/tvs/uaa","forks_url":"https://api.github.com/repos/tvs/uaa/forks","keys_url":"https://api.github.com/repos/tvs/uaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tvs/uaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tvs/uaa/teams","hooks_url":"https://api.github.com/repos/tvs/uaa/hooks","issue_events_url":"https://api.github.com/repos/tvs/uaa/issues/events{/number}","events_url":"https://api.github.com/repos/tvs/uaa/events","assignees_url":"https://api.github.com/repos/tvs/uaa/assignees{/user}","branches_url":"https://api.github.com/repos/tvs/uaa/branches{/branch}","tags_url":"https://api.github.com/repos/tvs/uaa/tags","blobs_url":"https://api.github.com/repos/tvs/uaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tvs/uaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tvs/uaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/tvs/uaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tvs/uaa/statuses/{sha}","languages_url":"https://api.github.com/repos/tvs/uaa/languages","stargazers_url":"https://api.github.com/repos/tvs/uaa/stargazers","contributors_url":"https://api.github.com/repos/tvs/uaa/contributors","subscribers_url":"https://api.github.com/repos/tvs/uaa/subscribers","subscription_url":"https://api.github.com/repos/tvs/uaa/subscription","commits_url":"https://api.github.com/repos/tvs/uaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/tvs/uaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/tvs/uaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/tvs/uaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/tvs/uaa/contents/{+path}","compare_url":"https://api.github.com/repos/tvs/uaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tvs/uaa/merges","archive_url":"https://api.github.com/repos/tvs/uaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tvs/uaa/downloads","issues_url":"https://api.github.com/repos/tvs/uaa/issues{/number}","pulls_url":"https://api.github.com/repos/tvs/uaa/pulls{/number}","milestones_url":"https://api.github.com/repos/tvs/uaa/milestones{/number}","notifications_url":"https://api.github.com/repos/tvs/uaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tvs/uaa/labels{/name}","releases_url":"https://api.github.com/repos/tvs/uaa/releases{/id}","deployments_url":"https://api.github.com/repos/tvs/uaa/deployments","created_at":"2017-01-04T19:29:16Z","updated_at":"2017-01-04T19:29:23Z","pushed_at":"2017-01-17T22:41:21Z","git_url":"git://github.com/tvs/uaa.git","ssh_url":"git@github.com:tvs/uaa.git","clone_url":"https://github.com/tvs/uaa.git","svn_url":"https://github.com/tvs/uaa","homepage":"","size":33973,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tvs/uaa/pulls/4"},"html":{"href":"https://github.com/tvs/uaa/pull/4"},"issue":{"href":"https://api.github.com/repos/tvs/uaa/issues/4"},"comments":{"href":"https://api.github.com/repos/tvs/uaa/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/tvs/uaa/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/tvs/uaa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tvs/uaa/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/tvs/uaa/statuses/b0cdeebb6ad31c9d8a915f2836555759e67e08aa"}}}}
{"actor":{"display_login":"tvs"}}