{"action":"created","comment":{"url":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/comments/118296280","pull_request_review_id":40044468,"id":118296280,"diff_hunk":"@@ -57,13 +57,14 @@ use strict;\n use Template::Latex;\n use Template::Parser;\n use LedgerSMB::Template::TTI18N;\n+use LedgerSMB::Magic qw( UNI_aring UNI_Aring );\n use Log::Log4perl;\n use TeX::Encode::charmap;\n use TeX::Encode;\n \n BEGIN {\n-    delete $TeX::Encode::charmap::ACCENTED_CHARS{chr(0x00c5)};\n-    delete $TeX::Encode::charmap::ACCENTED_CHARS{chr(0x00e5)};\n+    delete $TeX::Encode::charmap::ACCENTED_CHARS{chr(UNI_Aring)};\n+    delete $TeX::Encode::charmap::ACCENTED_CHARS{chr(UNI_aring)};","path":"lib/LedgerSMB/Template/LaTeX.pm","position":13,"original_position":13,"commit_id":"a839868db66a10b3647e38085a1e357350157f83","original_commit_id":"a839868db66a10b3647e38085a1e357350157f83","user":{"login":"sbts","id":11002795,"avatar_url":"https://avatars3.githubusercontent.com/u/11002795?v=3","gravatar_id":"","url":"https://api.github.com/users/sbts","html_url":"https://github.com/sbts","followers_url":"https://api.github.com/users/sbts/followers","following_url":"https://api.github.com/users/sbts/following{/other_user}","gists_url":"https://api.github.com/users/sbts/gists{/gist_id}","starred_url":"https://api.github.com/users/sbts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbts/subscriptions","organizations_url":"https://api.github.com/users/sbts/orgs","repos_url":"https://api.github.com/users/sbts/repos","events_url":"https://api.github.com/users/sbts/events{/privacy}","received_events_url":"https://api.github.com/users/sbts/received_events","type":"User","site_admin":false},"body":"Hmm. Why are we deleting these specific chars?\r\nAt a minimum we need some comments as to why it's necessary.\r\n@ehuelsmann and @eihnverfr can one of you cast some light on this?","created_at":"2017-05-24T16:08:51Z","updated_at":"2017-05-24T16:22:06Z","html_url":"https://github.com/ledgersmb/LedgerSMB/pull/2833#discussion_r118296280","pull_request_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833","_links":{"self":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/comments/118296280"},"html":{"href":"https://github.com/ledgersmb/LedgerSMB/pull/2833#discussion_r118296280"},"pull_request":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833"}}},"pull_request":{"url":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833","id":121868197,"html_url":"https://github.com/ledgersmb/LedgerSMB/pull/2833","diff_url":"https://github.com/ledgersmb/LedgerSMB/pull/2833.diff","patch_url":"https://github.com/ledgersmb/LedgerSMB/pull/2833.patch","issue_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/issues/2833","number":2833,"state":"open","locked":false,"title":"  Nm1","user":{"login":"ziuq","id":14331463,"avatar_url":"https://avatars0.githubusercontent.com/u/14331463?v=3","gravatar_id":"","url":"https://api.github.com/users/ziuq","html_url":"https://github.com/ziuq","followers_url":"https://api.github.com/users/ziuq/followers","following_url":"https://api.github.com/users/ziuq/following{/other_user}","gists_url":"https://api.github.com/users/ziuq/gists{/gist_id}","starred_url":"https://api.github.com/users/ziuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziuq/subscriptions","organizations_url":"https://api.github.com/users/ziuq/orgs","repos_url":"https://api.github.com/users/ziuq/repos","events_url":"https://api.github.com/users/ziuq/events{/privacy}","received_events_url":"https://api.github.com/users/ziuq/received_events","type":"User","site_admin":false},"body":"Problems with Pod coverage on Magic.pm on Perls 5.18, 5.16, and 5.14.   I am just not seeing it.\r\n\r\nReworked  negativising code to bool and unary minus vs. multiplying negative one.\r\n\r\nNamed many magicals.\r\n\r\nI will be not be adding to this pull request.   The response to these changes will guide how I\r\ndo the rest.","created_at":"2017-05-22T21:22:07Z","updated_at":"2017-05-24T16:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f66e8d48e9a9fc1fc3e5c6e91ad39d0164c5329d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833/commits","review_comments_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833/comments","review_comment_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/issues/2833/comments","statuses_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/statuses/a839868db66a10b3647e38085a1e357350157f83","head":{"label":"ziuq:nm1","ref":"nm1","sha":"a839868db66a10b3647e38085a1e357350157f83","user":{"login":"ziuq","id":14331463,"avatar_url":"https://avatars0.githubusercontent.com/u/14331463?v=3","gravatar_id":"","url":"https://api.github.com/users/ziuq","html_url":"https://github.com/ziuq","followers_url":"https://api.github.com/users/ziuq/followers","following_url":"https://api.github.com/users/ziuq/following{/other_user}","gists_url":"https://api.github.com/users/ziuq/gists{/gist_id}","starred_url":"https://api.github.com/users/ziuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziuq/subscriptions","organizations_url":"https://api.github.com/users/ziuq/orgs","repos_url":"https://api.github.com/users/ziuq/repos","events_url":"https://api.github.com/users/ziuq/events{/privacy}","received_events_url":"https://api.github.com/users/ziuq/received_events","type":"User","site_admin":false},"repo":{"id":90878726,"name":"LedgerSMB","full_name":"ziuq/LedgerSMB","owner":{"login":"ziuq","id":14331463,"avatar_url":"https://avatars0.githubusercontent.com/u/14331463?v=3","gravatar_id":"","url":"https://api.github.com/users/ziuq","html_url":"https://github.com/ziuq","followers_url":"https://api.github.com/users/ziuq/followers","following_url":"https://api.github.com/users/ziuq/following{/other_user}","gists_url":"https://api.github.com/users/ziuq/gists{/gist_id}","starred_url":"https://api.github.com/users/ziuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziuq/subscriptions","organizations_url":"https://api.github.com/users/ziuq/orgs","repos_url":"https://api.github.com/users/ziuq/repos","events_url":"https://api.github.com/users/ziuq/events{/privacy}","received_events_url":"https://api.github.com/users/ziuq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ziuq/LedgerSMB","description":"Master repository for the LedgerSMB project","fork":true,"url":"https://api.github.com/repos/ziuq/LedgerSMB","forks_url":"https://api.github.com/repos/ziuq/LedgerSMB/forks","keys_url":"https://api.github.com/repos/ziuq/LedgerSMB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ziuq/LedgerSMB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ziuq/LedgerSMB/teams","hooks_url":"https://api.github.com/repos/ziuq/LedgerSMB/hooks","issue_events_url":"https://api.github.com/repos/ziuq/LedgerSMB/issues/events{/number}","events_url":"https://api.github.com/repos/ziuq/LedgerSMB/events","assignees_url":"https://api.github.com/repos/ziuq/LedgerSMB/assignees{/user}","branches_url":"https://api.github.com/repos/ziuq/LedgerSMB/branches{/branch}","tags_url":"https://api.github.com/repos/ziuq/LedgerSMB/tags","blobs_url":"https://api.github.com/repos/ziuq/LedgerSMB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ziuq/LedgerSMB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ziuq/LedgerSMB/git/refs{/sha}","trees_url":"https://api.github.com/repos/ziuq/LedgerSMB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ziuq/LedgerSMB/statuses/{sha}","languages_url":"https://api.github.com/repos/ziuq/LedgerSMB/languages","stargazers_url":"https://api.github.com/repos/ziuq/LedgerSMB/stargazers","contributors_url":"https://api.github.com/repos/ziuq/LedgerSMB/contributors","subscribers_url":"https://api.github.com/repos/ziuq/LedgerSMB/subscribers","subscription_url":"https://api.github.com/repos/ziuq/LedgerSMB/subscription","commits_url":"https://api.github.com/repos/ziuq/LedgerSMB/commits{/sha}","git_commits_url":"https://api.github.com/repos/ziuq/LedgerSMB/git/commits{/sha}","comments_url":"https://api.github.com/repos/ziuq/LedgerSMB/comments{/number}","issue_comment_url":"https://api.github.com/repos/ziuq/LedgerSMB/issues/comments{/number}","contents_url":"https://api.github.com/repos/ziuq/LedgerSMB/contents/{+path}","compare_url":"https://api.github.com/repos/ziuq/LedgerSMB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ziuq/LedgerSMB/merges","archive_url":"https://api.github.com/repos/ziuq/LedgerSMB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ziuq/LedgerSMB/downloads","issues_url":"https://api.github.com/repos/ziuq/LedgerSMB/issues{/number}","pulls_url":"https://api.github.com/repos/ziuq/LedgerSMB/pulls{/number}","milestones_url":"https://api.github.com/repos/ziuq/LedgerSMB/milestones{/number}","notifications_url":"https://api.github.com/repos/ziuq/LedgerSMB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ziuq/LedgerSMB/labels{/name}","releases_url":"https://api.github.com/repos/ziuq/LedgerSMB/releases{/id}","deployments_url":"https://api.github.com/repos/ziuq/LedgerSMB/deployments","created_at":"2017-05-10T15:17:08Z","updated_at":"2017-05-10T15:17:14Z","pushed_at":"2017-05-24T14:24:50Z","git_url":"git://github.com/ziuq/LedgerSMB.git","ssh_url":"git@github.com:ziuq/LedgerSMB.git","clone_url":"https://github.com/ziuq/LedgerSMB.git","svn_url":"https://github.com/ziuq/LedgerSMB","homepage":"http://ledgersmb.org","size":80875,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ledgersmb:master","ref":"master","sha":"af83d4345ecb1d2fe11568f63b1ed258d79195a2","user":{"login":"ledgersmb","id":2297436,"avatar_url":"https://avatars3.githubusercontent.com/u/2297436?v=3","gravatar_id":"","url":"https://api.github.com/users/ledgersmb","html_url":"https://github.com/ledgersmb","followers_url":"https://api.github.com/users/ledgersmb/followers","following_url":"https://api.github.com/users/ledgersmb/following{/other_user}","gists_url":"https://api.github.com/users/ledgersmb/gists{/gist_id}","starred_url":"https://api.github.com/users/ledgersmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledgersmb/subscriptions","organizations_url":"https://api.github.com/users/ledgersmb/orgs","repos_url":"https://api.github.com/users/ledgersmb/repos","events_url":"https://api.github.com/users/ledgersmb/events{/privacy}","received_events_url":"https://api.github.com/users/ledgersmb/received_events","type":"Organization","site_admin":false},"repo":{"id":18471236,"name":"LedgerSMB","full_name":"ledgersmb/LedgerSMB","owner":{"login":"ledgersmb","id":2297436,"avatar_url":"https://avatars3.githubusercontent.com/u/2297436?v=3","gravatar_id":"","url":"https://api.github.com/users/ledgersmb","html_url":"https://github.com/ledgersmb","followers_url":"https://api.github.com/users/ledgersmb/followers","following_url":"https://api.github.com/users/ledgersmb/following{/other_user}","gists_url":"https://api.github.com/users/ledgersmb/gists{/gist_id}","starred_url":"https://api.github.com/users/ledgersmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledgersmb/subscriptions","organizations_url":"https://api.github.com/users/ledgersmb/orgs","repos_url":"https://api.github.com/users/ledgersmb/repos","events_url":"https://api.github.com/users/ledgersmb/events{/privacy}","received_events_url":"https://api.github.com/users/ledgersmb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ledgersmb/LedgerSMB","description":"Master repository for the LedgerSMB project","fork":false,"url":"https://api.github.com/repos/ledgersmb/LedgerSMB","forks_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/forks","keys_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/teams","hooks_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/hooks","issue_events_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/issues/events{/number}","events_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/events","assignees_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/assignees{/user}","branches_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/branches{/branch}","tags_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/tags","blobs_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/git/refs{/sha}","trees_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/statuses/{sha}","languages_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/languages","stargazers_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/stargazers","contributors_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/contributors","subscribers_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/subscribers","subscription_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/subscription","commits_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/commits{/sha}","git_commits_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/git/commits{/sha}","comments_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/comments{/number}","issue_comment_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/issues/comments{/number}","contents_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/contents/{+path}","compare_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/merges","archive_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/downloads","issues_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/issues{/number}","pulls_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls{/number}","milestones_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/milestones{/number}","notifications_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/labels{/name}","releases_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/releases{/id}","deployments_url":"https://api.github.com/repos/ledgersmb/LedgerSMB/deployments","created_at":"2014-04-05T16:43:59Z","updated_at":"2017-05-22T08:27:06Z","pushed_at":"2017-05-24T14:47:37Z","git_url":"git://github.com/ledgersmb/LedgerSMB.git","ssh_url":"git@github.com:ledgersmb/LedgerSMB.git","clone_url":"https://github.com/ledgersmb/LedgerSMB.git","svn_url":"https://github.com/ledgersmb/LedgerSMB","homepage":"http://ledgersmb.org","size":81103,"stargazers_count":33,"watchers_count":33,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":365,"forks":36,"open_issues":365,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833"},"html":{"href":"https://github.com/ledgersmb/LedgerSMB/pull/2833"},"issue":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/issues/2833"},"comments":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/issues/2833/comments"},"review_comments":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833/comments"},"review_comment":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/pulls/2833/commits"},"statuses":{"href":"https://api.github.com/repos/ledgersmb/LedgerSMB/statuses/a839868db66a10b3647e38085a1e357350157f83"}}}}
{"actor":{"display_login":"sbts"}}