{"action":"created","comment":{"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments/148066250","pull_request_review_id":73252995,"id":148066250,"diff_hunk":"@@ -11,8 +11,30 @@\n #include <phylanx/config/export_definitions.hpp>\n #include <phylanx/config/version.hpp>\n \n+// TODO: If windows.h is included, ensure min and max macros are not defined\n+// after here or the code will fail to compile pointing at header files in\n+// Blaze. Therefore, the ordering of the includes matter. This needs a\n+// permanent fix\n #if defined(_MSC_VER) && !defined(NOMINMAX)\n #define NOMINMAX\n-#endif\n+#endif // NOMINMAX\n+\n+// Use HPX threads. Do not use C++11 threads\n+#if !defined(BLAZE_USE_HPX_THREADS)\n+#define BLAZE_USE_HPX_THREADS 1\n+\n+#if !defined(BLAZE_USE_SHARED_MEMORY_PARALLELIZATION) || BLAZE_USE_SHARED_MEMORY_PARALLELIZATION != 1\n+#define BLAZE_USE_SHARED_MEMORY_PARALLELIZATION 1\n+#endif BLAZE_USE_SHARED_MEMORY_PARALLELIZATION\n \n+#ifdef BLAZE_USE_CPP_THREADS\n+#undef BLAZE_USE_CPP_THREADS\n+#endif // BLAZE_USE_CPP_THREADS\n+\n+#ifdef BLAZE_USE_BOOST_THREADS","path":"phylanx/config.hpp","position":25,"original_position":25,"commit_id":"c0dd0b5c775a1513ddae98c7570bb021526dbcf0","original_commit_id":"c0dd0b5c775a1513ddae98c7570bb021526dbcf0","user":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars1.githubusercontent.com/u/568063?v=4","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"body":"No need to guard the `#undef`. It's perfectly valid to in-define a non-defined variable.","created_at":"2017-10-31T17:16:49Z","updated_at":"2017-10-31T17:16:49Z","html_url":"https://github.com/STEllAR-GROUP/phylanx/pull/88#discussion_r148066250","pull_request_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments/148066250"},"html":{"href":"https://github.com/STEllAR-GROUP/phylanx/pull/88#discussion_r148066250"},"pull_request":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88","id":149321810,"html_url":"https://github.com/STEllAR-GROUP/phylanx/pull/88","diff_url":"https://github.com/STEllAR-GROUP/phylanx/pull/88.diff","patch_url":"https://github.com/STEllAR-GROUP/phylanx/pull/88.patch","issue_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/88","number":88,"state":"open","locked":false,"title":"Remove Blaze CMake hacks","user":{"login":"parsa","id":322657,"avatar_url":"https://avatars2.githubusercontent.com/u/322657?v=4","gravatar_id":"","url":"https://api.github.com/users/parsa","html_url":"https://github.com/parsa","followers_url":"https://api.github.com/users/parsa/followers","following_url":"https://api.github.com/users/parsa/following{/other_user}","gists_url":"https://api.github.com/users/parsa/gists{/gist_id}","starred_url":"https://api.github.com/users/parsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsa/subscriptions","organizations_url":"https://api.github.com/users/parsa/orgs","repos_url":"https://api.github.com/users/parsa/repos","events_url":"https://api.github.com/users/parsa/events{/privacy}","received_events_url":"https://api.github.com/users/parsa/received_events","type":"User","site_admin":false},"body":"* Remove `blaze_INCLUDE_DIR` flag\r\n* Microsoft/vcpkg#1996 is resolved \r\n    * Vcpkg properly installs Blaze through CMake \r\n    * Remove the use of undocumented variables to handle Blaze installations available through Vcpkg","created_at":"2017-10-28T06:40:12Z","updated_at":"2017-10-31T17:16:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cbca49d8c08e3e10644878090e8ecfcba7d2de4","assignee":{"login":"parsa","id":322657,"avatar_url":"https://avatars2.githubusercontent.com/u/322657?v=4","gravatar_id":"","url":"https://api.github.com/users/parsa","html_url":"https://github.com/parsa","followers_url":"https://api.github.com/users/parsa/followers","following_url":"https://api.github.com/users/parsa/following{/other_user}","gists_url":"https://api.github.com/users/parsa/gists{/gist_id}","starred_url":"https://api.github.com/users/parsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsa/subscriptions","organizations_url":"https://api.github.com/users/parsa/orgs","repos_url":"https://api.github.com/users/parsa/repos","events_url":"https://api.github.com/users/parsa/events{/privacy}","received_events_url":"https://api.github.com/users/parsa/received_events","type":"User","site_admin":false},"assignees":[{"login":"parsa","id":322657,"avatar_url":"https://avatars2.githubusercontent.com/u/322657?v=4","gravatar_id":"","url":"https://api.github.com/users/parsa","html_url":"https://github.com/parsa","followers_url":"https://api.github.com/users/parsa/followers","following_url":"https://api.github.com/users/parsa/following{/other_user}","gists_url":"https://api.github.com/users/parsa/gists{/gist_id}","starred_url":"https://api.github.com/users/parsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsa/subscriptions","organizations_url":"https://api.github.com/users/parsa/orgs","repos_url":"https://api.github.com/users/parsa/repos","events_url":"https://api.github.com/users/parsa/events{/privacy}","received_events_url":"https://api.github.com/users/parsa/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/milestones/1","html_url":"https://github.com/STEllAR-GROUP/phylanx/milestone/1","labels_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/milestones/1/labels","id":2724904,"number":1,"title":"0.0.1","description":"","creator":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars1.githubusercontent.com/u/568063?v=4","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":67,"state":"open","created_at":"2017-08-27T01:38:21Z","updated_at":"2017-10-31T17:00:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88/commits","review_comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88/comments","review_comment_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/88/comments","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/c0dd0b5c775a1513ddae98c7570bb021526dbcf0","head":{"label":"STEllAR-GROUP:blaze_dir","ref":"blaze_dir","sha":"c0dd0b5c775a1513ddae98c7570bb021526dbcf0","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":101409977,"name":"phylanx","full_name":"STEllAR-GROUP/phylanx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/phylanx","description":"A Distributed C++ Array Processing Toolkit","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/deployments","created_at":"2017-08-25T14:07:21Z","updated_at":"2017-10-30T19:35:10Z","pushed_at":"2017-10-31T17:00:21Z","git_url":"git://github.com/STEllAR-GROUP/phylanx.git","ssh_url":"git@github.com:STEllAR-GROUP/phylanx.git","clone_url":"https://github.com/STEllAR-GROUP/phylanx.git","svn_url":"https://github.com/STEllAR-GROUP/phylanx","homepage":"","size":797,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":18,"forks":6,"open_issues":18,"watchers":12,"default_branch":"master"}},"base":{"label":"STEllAR-GROUP:master","ref":"master","sha":"517ea540da446997e0ed35ce89e83c94faad15e2","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":101409977,"name":"phylanx","full_name":"STEllAR-GROUP/phylanx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/phylanx","description":"A Distributed C++ Array Processing Toolkit","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/deployments","created_at":"2017-08-25T14:07:21Z","updated_at":"2017-10-30T19:35:10Z","pushed_at":"2017-10-31T17:00:21Z","git_url":"git://github.com/STEllAR-GROUP/phylanx.git","ssh_url":"git@github.com:STEllAR-GROUP/phylanx.git","clone_url":"https://github.com/STEllAR-GROUP/phylanx.git","svn_url":"https://github.com/STEllAR-GROUP/phylanx","homepage":"","size":797,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":18,"forks":6,"open_issues":18,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88"},"html":{"href":"https://github.com/STEllAR-GROUP/phylanx/pull/88"},"issue":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/88"},"comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/c0dd0b5c775a1513ddae98c7570bb021526dbcf0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hkaiser"}}