{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/132006824","pull_request_review_id":54809731,"id":132006824,"diff_hunk":"@@ -966,6 +902,21 @@ func (ac *addrConn) resetTransport(drain bool) error {\n \t\t\tAddr:     ac.addr.Addr,\n \t\t\tMetadata: ac.addr.Metadata,\n \t\t}\n+\t\tac.mu.Lock()\n+\t\tif ac.state == connectivity.Shutdown {\n+\t\t\tcancel()\n+\t\t\t// ac.tearDown(...) has been invoked.\n+\t\t\tac.mu.Unlock()\n+\t\t\treturn errConnClosing\n+\t\t}\n+\t\tac.printf(\"connecting\")\n+\t\toldState := ac.state\n+\t\tac.state = connectivity.Connecting\n+\t\tac.csEvltr.recordTransition(oldState, ac.state)\n+\t\tif ac.cc.balancer != nil {","path":"clientconn.go","position":null,"original_position":641,"commit_id":"0528896920591c808a36f54d97d1bf77f8cbe2ff","original_commit_id":"9095cdca087d0661cc6689c51dff20b7a897f233","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-08-08T19:19:44Z","updated_at":"2017-08-08T19:21:38Z","html_url":"https://github.com/grpc/grpc-go/pull/1408#discussion_r132006824","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1408","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/132006824"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1408#discussion_r132006824"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1408"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/1408","id":133353747,"html_url":"https://github.com/grpc/grpc-go/pull/1408","diff_url":"https://github.com/grpc/grpc-go/pull/1408.diff","patch_url":"https://github.com/grpc/grpc-go/pull/1408.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/1408","number":1408,"state":"open","locked":false,"title":"Add new Resolver and Balancer APIs (gRFC L9)","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"body":"This is the first step for #1388.\r\nSee gRFC L9 for details: grpc/proposal#30\r\n\r\nThis PR adds package `balancer`, `resolver` and `connectivity`.\r\nIt changes ClientConn internals to new APIs and adds a wrapper for v1 balancer.\r\n\r\nIt does minimal change to ClientConn's behavior:\r\n- Blocking dial blocks until the ClientConn's state is READY","created_at":"2017-07-31T22:46:18Z","updated_at":"2017-08-08T19:21:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70d90a9cca0bfa9eaf3b2d84186532a40076a943","assignee":{"login":"dfawley","id":26072277,"avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"assignees":[{"login":"dfawley","id":26072277,"avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1408/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1408/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/1408/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/0528896920591c808a36f54d97d1bf77f8cbe2ff","head":{"label":"menghanl:bar_api_change","ref":"bar_api_change","sha":"0528896920591c808a36f54d97d1bf77f8cbe2ff","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"repo":{"id":54156883,"name":"grpc-go","full_name":"menghanl/grpc-go","owner":{"login":"menghanl","id":960845,"avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menghanl/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/menghanl/grpc-go","forks_url":"https://api.github.com/repos/menghanl/grpc-go/forks","keys_url":"https://api.github.com/repos/menghanl/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menghanl/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menghanl/grpc-go/teams","hooks_url":"https://api.github.com/repos/menghanl/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/menghanl/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/menghanl/grpc-go/events","assignees_url":"https://api.github.com/repos/menghanl/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/menghanl/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/menghanl/grpc-go/tags","blobs_url":"https://api.github.com/repos/menghanl/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menghanl/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menghanl/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/menghanl/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menghanl/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/menghanl/grpc-go/languages","stargazers_url":"https://api.github.com/repos/menghanl/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/menghanl/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/menghanl/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/menghanl/grpc-go/subscription","commits_url":"https://api.github.com/repos/menghanl/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/menghanl/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/menghanl/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/menghanl/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/menghanl/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/menghanl/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menghanl/grpc-go/merges","archive_url":"https://api.github.com/repos/menghanl/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menghanl/grpc-go/downloads","issues_url":"https://api.github.com/repos/menghanl/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/menghanl/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/menghanl/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/menghanl/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menghanl/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/menghanl/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/menghanl/grpc-go/deployments","created_at":"2016-03-17T22:55:39Z","updated_at":"2016-03-17T22:55:40Z","pushed_at":"2017-08-08T19:21:32Z","git_url":"git://github.com/menghanl/grpc-go.git","ssh_url":"git@github.com:menghanl/grpc-go.git","clone_url":"https://github.com/menghanl/grpc-go.git","svn_url":"https://github.com/menghanl/grpc-go","homepage":"","size":4001,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"383b11435b2ef4975958fc46f84d8f268b3b760b","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2017-08-08T03:55:13Z","pushed_at":"2017-08-08T19:21:34Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":3727,"stargazers_count":3697,"watchers_count":3697,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":687,"mirror_url":null,"open_issues_count":99,"forks":687,"open_issues":99,"watchers":3697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1408"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1408"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1408"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1408/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1408/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1408/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/0528896920591c808a36f54d97d1bf77f8cbe2ff"}}}}
{"actor":{"display_login":"menghanl"}}