{"action":"created","issue":{"url":"https://api.github.com/repos/streamlink/streamlink/issues/623","repository_url":"https://api.github.com/repos/streamlink/streamlink","labels_url":"https://api.github.com/repos/streamlink/streamlink/issues/623/labels{/name}","comments_url":"https://api.github.com/repos/streamlink/streamlink/issues/623/comments","events_url":"https://api.github.com/repos/streamlink/streamlink/issues/623/events","html_url":"https://github.com/streamlink/streamlink/pull/623","id":210020122,"number":623,"title":"Window Titles = Stream Titles","user":{"login":"Hubcapp","id":1337967,"avatar_url":"https://avatars1.githubusercontent.com/u/1337967?v=3","gravatar_id":"","url":"https://api.github.com/users/Hubcapp","html_url":"https://github.com/Hubcapp","followers_url":"https://api.github.com/users/Hubcapp/followers","following_url":"https://api.github.com/users/Hubcapp/following{/other_user}","gists_url":"https://api.github.com/users/Hubcapp/gists{/gist_id}","starred_url":"https://api.github.com/users/Hubcapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hubcapp/subscriptions","organizations_url":"https://api.github.com/users/Hubcapp/orgs","repos_url":"https://api.github.com/users/Hubcapp/repos","events_url":"https://api.github.com/users/Hubcapp/events{/privacy}","received_events_url":"https://api.github.com/users/Hubcapp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2017-02-24T11:03:47Z","updated_at":"2017-04-04T16:50:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/streamlink/streamlink/pulls/623","html_url":"https://github.com/streamlink/streamlink/pull/623","diff_url":"https://github.com/streamlink/streamlink/pull/623.diff","patch_url":"https://github.com/streamlink/streamlink/pull/623.patch"},"body":"This pull request is based on https://github.com/chrippa/livestreamer/pull/1167/\r\n\r\nI reworked it to only use the first commit though, so that instead of being restricted to just VLC, it allows the user to specify whatever command line argument they need for their special player.\r\n\r\nexample usage:\r\n\r\n```\r\nstreamlink https://www.twitch.tv/coolstreamer source -p 'vlc --meta-title=\"{title}\"'\r\n\r\nstreamlink https://www.twitch.tv/coolstreamer source -p 'mpv --title=\"{title}\"'\r\n```\r\n\r\nIn this pull request, I've only implemented Twitch support. Other sources we'll try to give them just the channel name as the title, and if we can't do that, we just give them back the url they entered as the title.\r\n\r\nThere is a mild security concern in this pull request. Because we are putting the stream title into subprocess.Popen, if this were implemented in the worst way possible, a streamer could name their stream e.g. `\";echo \"hacked` and get arbitrary code execution. Because we don't have shell=True set in subprocess.Popen anywhere and I've replaced \", it should be fine. I'd like confirmation anyway.\r\n\r\nIt would also be nice to replace the title by default instead of requiring the `--player` argument, but this pull request doesn't do that."},"comment":{"url":"https://api.github.com/repos/streamlink/streamlink/issues/comments/291562037","html_url":"https://github.com/streamlink/streamlink/pull/623#issuecomment-291562037","issue_url":"https://api.github.com/repos/streamlink/streamlink/issues/623","id":291562037,"user":{"login":"gravyboat","id":1396878,"avatar_url":"https://avatars1.githubusercontent.com/u/1396878?v=3","gravatar_id":"","url":"https://api.github.com/users/gravyboat","html_url":"https://github.com/gravyboat","followers_url":"https://api.github.com/users/gravyboat/followers","following_url":"https://api.github.com/users/gravyboat/following{/other_user}","gists_url":"https://api.github.com/users/gravyboat/gists{/gist_id}","starred_url":"https://api.github.com/users/gravyboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravyboat/subscriptions","organizations_url":"https://api.github.com/users/gravyboat/orgs","repos_url":"https://api.github.com/users/gravyboat/repos","events_url":"https://api.github.com/users/gravyboat/events{/privacy}","received_events_url":"https://api.github.com/users/gravyboat/received_events","type":"User","site_admin":false},"created_at":"2017-04-04T16:50:16Z","updated_at":"2017-04-04T16:50:16Z","body":"@beardypig and @bastimeyer Can you re-review this one when you get a chance?"}}
{"actor":{"display_login":"gravyboat"}}