{"action":"created","comment":{"url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/comments/120307319","pull_request_review_id":42256689,"id":120307319,"diff_hunk":"@@ -95,20 +96,23 @@ StaticMap.prototype._recordUserMap = function(socket, options) {\n         .then(() => trace(`Stored map for ${socket.roleId}: ${JSON.stringify(map)}`));\n };\n \n-StaticMap.prototype.getMap = function(latitude, longitude, width, height, zoom) {\n-    var response = this.response,\n+\n+\n+StaticMap.prototype._getMap = function(latitude, longitude, width, height, zoom, mapType, self) {","path":"src/server/rpc/procedures/static-map/static-map.js","position":25,"original_position":25,"commit_id":"0a3741727cb25bb5a8a8950b0590af2e7de8f64a","original_commit_id":"0a3741727cb25bb5a8a8950b0590af2e7de8f64a","user":{"login":"brollb","id":4982789,"avatar_url":"https://avatars3.githubusercontent.com/u/4982789?v=3","gravatar_id":"","url":"https://api.github.com/users/brollb","html_url":"https://github.com/brollb","followers_url":"https://api.github.com/users/brollb/followers","following_url":"https://api.github.com/users/brollb/following{/other_user}","gists_url":"https://api.github.com/users/brollb/gists{/gist_id}","starred_url":"https://api.github.com/users/brollb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brollb/subscriptions","organizations_url":"https://api.github.com/users/brollb/orgs","repos_url":"https://api.github.com/users/brollb/repos","events_url":"https://api.github.com/users/brollb/events{/privacy}","received_events_url":"https://api.github.com/users/brollb/received_events","type":"User","site_admin":false},"body":"It would probably be better if you did `var self = this` at the beginning rather than implicitly doing the variable declaration here.\r\n\r\nIs there any other reason why you added `self` as a function parameter?","created_at":"2017-06-06T09:38:41Z","updated_at":"2017-06-06T09:38:41Z","html_url":"https://github.com/NetsBlox/NetsBlox/pull/1042#discussion_r120307319","pull_request_url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042","_links":{"self":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/comments/120307319"},"html":{"href":"https://github.com/NetsBlox/NetsBlox/pull/1042#discussion_r120307319"},"pull_request":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042"}}},"pull_request":{"url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042","id":124013864,"html_url":"https://github.com/NetsBlox/NetsBlox/pull/1042","diff_url":"https://github.com/NetsBlox/NetsBlox/pull/1042.diff","patch_url":"https://github.com/NetsBlox/NetsBlox/pull/1042.patch","issue_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/1042","number":1042,"state":"open","locked":false,"title":"satellite and terrain map support for staticmap","user":{"login":"hamidzr","id":12127420,"avatar_url":"https://avatars0.githubusercontent.com/u/12127420?v=3","gravatar_id":"","url":"https://api.github.com/users/hamidzr","html_url":"https://github.com/hamidzr","followers_url":"https://api.github.com/users/hamidzr/followers","following_url":"https://api.github.com/users/hamidzr/following{/other_user}","gists_url":"https://api.github.com/users/hamidzr/gists{/gist_id}","starred_url":"https://api.github.com/users/hamidzr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamidzr/subscriptions","organizations_url":"https://api.github.com/users/hamidzr/orgs","repos_url":"https://api.github.com/users/hamidzr/repos","events_url":"https://api.github.com/users/hamidzr/events{/privacy}","received_events_url":"https://api.github.com/users/hamidzr/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-05T16:43:37Z","updated_at":"2017-06-06T09:38:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf86a84ac847fa418f0382c8fba1e2bc477f6ec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042/commits","review_comments_url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042/comments","review_comment_url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/1042/comments","statuses_url":"https://api.github.com/repos/NetsBlox/NetsBlox/statuses/0a3741727cb25bb5a8a8950b0590af2e7de8f64a","head":{"label":"NetsBlox:1041-static-map-types","ref":"1041-static-map-types","sha":"0a3741727cb25bb5a8a8950b0590af2e7de8f64a","user":{"login":"NetsBlox","id":11653971,"avatar_url":"https://avatars0.githubusercontent.com/u/11653971?v=3","gravatar_id":"","url":"https://api.github.com/users/NetsBlox","html_url":"https://github.com/NetsBlox","followers_url":"https://api.github.com/users/NetsBlox/followers","following_url":"https://api.github.com/users/NetsBlox/following{/other_user}","gists_url":"https://api.github.com/users/NetsBlox/gists{/gist_id}","starred_url":"https://api.github.com/users/NetsBlox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetsBlox/subscriptions","organizations_url":"https://api.github.com/users/NetsBlox/orgs","repos_url":"https://api.github.com/users/NetsBlox/repos","events_url":"https://api.github.com/users/NetsBlox/events{/privacy}","received_events_url":"https://api.github.com/users/NetsBlox/received_events","type":"Organization","site_admin":false},"repo":{"id":32888294,"name":"NetsBlox","full_name":"NetsBlox/NetsBlox","owner":{"login":"NetsBlox","id":11653971,"avatar_url":"https://avatars0.githubusercontent.com/u/11653971?v=3","gravatar_id":"","url":"https://api.github.com/users/NetsBlox","html_url":"https://github.com/NetsBlox","followers_url":"https://api.github.com/users/NetsBlox/followers","following_url":"https://api.github.com/users/NetsBlox/following{/other_user}","gists_url":"https://api.github.com/users/NetsBlox/gists{/gist_id}","starred_url":"https://api.github.com/users/NetsBlox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetsBlox/subscriptions","organizations_url":"https://api.github.com/users/NetsBlox/orgs","repos_url":"https://api.github.com/users/NetsBlox/repos","events_url":"https://api.github.com/users/NetsBlox/events{/privacy}","received_events_url":"https://api.github.com/users/NetsBlox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetsBlox/NetsBlox","description":"a networked visual programming language based on Snap!","fork":false,"url":"https://api.github.com/repos/NetsBlox/NetsBlox","forks_url":"https://api.github.com/repos/NetsBlox/NetsBlox/forks","keys_url":"https://api.github.com/repos/NetsBlox/NetsBlox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetsBlox/NetsBlox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetsBlox/NetsBlox/teams","hooks_url":"https://api.github.com/repos/NetsBlox/NetsBlox/hooks","issue_events_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/events{/number}","events_url":"https://api.github.com/repos/NetsBlox/NetsBlox/events","assignees_url":"https://api.github.com/repos/NetsBlox/NetsBlox/assignees{/user}","branches_url":"https://api.github.com/repos/NetsBlox/NetsBlox/branches{/branch}","tags_url":"https://api.github.com/repos/NetsBlox/NetsBlox/tags","blobs_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetsBlox/NetsBlox/statuses/{sha}","languages_url":"https://api.github.com/repos/NetsBlox/NetsBlox/languages","stargazers_url":"https://api.github.com/repos/NetsBlox/NetsBlox/stargazers","contributors_url":"https://api.github.com/repos/NetsBlox/NetsBlox/contributors","subscribers_url":"https://api.github.com/repos/NetsBlox/NetsBlox/subscribers","subscription_url":"https://api.github.com/repos/NetsBlox/NetsBlox/subscription","commits_url":"https://api.github.com/repos/NetsBlox/NetsBlox/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetsBlox/NetsBlox/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetsBlox/NetsBlox/contents/{+path}","compare_url":"https://api.github.com/repos/NetsBlox/NetsBlox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetsBlox/NetsBlox/merges","archive_url":"https://api.github.com/repos/NetsBlox/NetsBlox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetsBlox/NetsBlox/downloads","issues_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues{/number}","pulls_url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls{/number}","milestones_url":"https://api.github.com/repos/NetsBlox/NetsBlox/milestones{/number}","notifications_url":"https://api.github.com/repos/NetsBlox/NetsBlox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetsBlox/NetsBlox/labels{/name}","releases_url":"https://api.github.com/repos/NetsBlox/NetsBlox/releases{/id}","deployments_url":"https://api.github.com/repos/NetsBlox/NetsBlox/deployments","created_at":"2015-03-25T20:13:41Z","updated_at":"2017-05-26T01:04:19Z","pushed_at":"2017-06-05T23:07:03Z","git_url":"git://github.com/NetsBlox/NetsBlox.git","ssh_url":"git@github.com:NetsBlox/NetsBlox.git","clone_url":"https://github.com/NetsBlox/NetsBlox.git","svn_url":"https://github.com/NetsBlox/NetsBlox","homepage":"https://www.netsblox.org","size":39996,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":70,"forks":7,"open_issues":70,"watchers":27,"default_branch":"master"}},"base":{"label":"NetsBlox:master","ref":"master","sha":"9104f1f3f35401f3c09085c06c559982e44595a6","user":{"login":"NetsBlox","id":11653971,"avatar_url":"https://avatars0.githubusercontent.com/u/11653971?v=3","gravatar_id":"","url":"https://api.github.com/users/NetsBlox","html_url":"https://github.com/NetsBlox","followers_url":"https://api.github.com/users/NetsBlox/followers","following_url":"https://api.github.com/users/NetsBlox/following{/other_user}","gists_url":"https://api.github.com/users/NetsBlox/gists{/gist_id}","starred_url":"https://api.github.com/users/NetsBlox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetsBlox/subscriptions","organizations_url":"https://api.github.com/users/NetsBlox/orgs","repos_url":"https://api.github.com/users/NetsBlox/repos","events_url":"https://api.github.com/users/NetsBlox/events{/privacy}","received_events_url":"https://api.github.com/users/NetsBlox/received_events","type":"Organization","site_admin":false},"repo":{"id":32888294,"name":"NetsBlox","full_name":"NetsBlox/NetsBlox","owner":{"login":"NetsBlox","id":11653971,"avatar_url":"https://avatars0.githubusercontent.com/u/11653971?v=3","gravatar_id":"","url":"https://api.github.com/users/NetsBlox","html_url":"https://github.com/NetsBlox","followers_url":"https://api.github.com/users/NetsBlox/followers","following_url":"https://api.github.com/users/NetsBlox/following{/other_user}","gists_url":"https://api.github.com/users/NetsBlox/gists{/gist_id}","starred_url":"https://api.github.com/users/NetsBlox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetsBlox/subscriptions","organizations_url":"https://api.github.com/users/NetsBlox/orgs","repos_url":"https://api.github.com/users/NetsBlox/repos","events_url":"https://api.github.com/users/NetsBlox/events{/privacy}","received_events_url":"https://api.github.com/users/NetsBlox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetsBlox/NetsBlox","description":"a networked visual programming language based on Snap!","fork":false,"url":"https://api.github.com/repos/NetsBlox/NetsBlox","forks_url":"https://api.github.com/repos/NetsBlox/NetsBlox/forks","keys_url":"https://api.github.com/repos/NetsBlox/NetsBlox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetsBlox/NetsBlox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetsBlox/NetsBlox/teams","hooks_url":"https://api.github.com/repos/NetsBlox/NetsBlox/hooks","issue_events_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/events{/number}","events_url":"https://api.github.com/repos/NetsBlox/NetsBlox/events","assignees_url":"https://api.github.com/repos/NetsBlox/NetsBlox/assignees{/user}","branches_url":"https://api.github.com/repos/NetsBlox/NetsBlox/branches{/branch}","tags_url":"https://api.github.com/repos/NetsBlox/NetsBlox/tags","blobs_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetsBlox/NetsBlox/statuses/{sha}","languages_url":"https://api.github.com/repos/NetsBlox/NetsBlox/languages","stargazers_url":"https://api.github.com/repos/NetsBlox/NetsBlox/stargazers","contributors_url":"https://api.github.com/repos/NetsBlox/NetsBlox/contributors","subscribers_url":"https://api.github.com/repos/NetsBlox/NetsBlox/subscribers","subscription_url":"https://api.github.com/repos/NetsBlox/NetsBlox/subscription","commits_url":"https://api.github.com/repos/NetsBlox/NetsBlox/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetsBlox/NetsBlox/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetsBlox/NetsBlox/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetsBlox/NetsBlox/contents/{+path}","compare_url":"https://api.github.com/repos/NetsBlox/NetsBlox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetsBlox/NetsBlox/merges","archive_url":"https://api.github.com/repos/NetsBlox/NetsBlox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetsBlox/NetsBlox/downloads","issues_url":"https://api.github.com/repos/NetsBlox/NetsBlox/issues{/number}","pulls_url":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls{/number}","milestones_url":"https://api.github.com/repos/NetsBlox/NetsBlox/milestones{/number}","notifications_url":"https://api.github.com/repos/NetsBlox/NetsBlox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetsBlox/NetsBlox/labels{/name}","releases_url":"https://api.github.com/repos/NetsBlox/NetsBlox/releases{/id}","deployments_url":"https://api.github.com/repos/NetsBlox/NetsBlox/deployments","created_at":"2015-03-25T20:13:41Z","updated_at":"2017-05-26T01:04:19Z","pushed_at":"2017-06-05T23:07:03Z","git_url":"git://github.com/NetsBlox/NetsBlox.git","ssh_url":"git@github.com:NetsBlox/NetsBlox.git","clone_url":"https://github.com/NetsBlox/NetsBlox.git","svn_url":"https://github.com/NetsBlox/NetsBlox","homepage":"https://www.netsblox.org","size":39996,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":70,"forks":7,"open_issues":70,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042"},"html":{"href":"https://github.com/NetsBlox/NetsBlox/pull/1042"},"issue":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/1042"},"comments":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/issues/1042/comments"},"review_comments":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042/comments"},"review_comment":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/pulls/1042/commits"},"statuses":{"href":"https://api.github.com/repos/NetsBlox/NetsBlox/statuses/0a3741727cb25bb5a8a8950b0590af2e7de8f64a"}}}}
{"actor":{"display_login":"brollb"}}