{"action":"closed","issue":{"url":"https://api.github.com/repos/Bitcoin-ABC/bitcoin-abc/issues/60","repository_url":"https://api.github.com/repos/Bitcoin-ABC/bitcoin-abc","labels_url":"https://api.github.com/repos/Bitcoin-ABC/bitcoin-abc/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/Bitcoin-ABC/bitcoin-abc/issues/60/comments","events_url":"https://api.github.com/repos/Bitcoin-ABC/bitcoin-abc/issues/60/events","html_url":"https://github.com/Bitcoin-ABC/bitcoin-abc/issues/60","id":247718209,"number":60,"title":"About nHashType on sign","user":{"login":"matiu","id":98844,"avatar_url":"https://avatars1.githubusercontent.com/u/98844?v=4","gravatar_id":"","url":"https://api.github.com/users/matiu","html_url":"https://github.com/matiu","followers_url":"https://api.github.com/users/matiu/followers","following_url":"https://api.github.com/users/matiu/following{/other_user}","gists_url":"https://api.github.com/users/matiu/gists{/gist_id}","starred_url":"https://api.github.com/users/matiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matiu/subscriptions","organizations_url":"https://api.github.com/users/matiu/orgs","repos_url":"https://api.github.com/users/matiu/repos","events_url":"https://api.github.com/users/matiu/events{/privacy}","received_events_url":"https://api.github.com/users/matiu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-03T14:06:56Z","updated_at":"2017-08-03T14:55:24Z","closed_at":"2017-08-03T14:55:24Z","body":"On  the code, the sigHash seems to be pushed as it is before hashing:\r\n\r\nhttps://github.com/Bitcoin-ABC/bitcoin-abc/blob/e49826c1fcc36e5ae26de0ad4d06e2063a759e73/src/script/interpreter.cpp#L1399\r\n\r\nBut on the spec:\r\n\r\nhttps://github.com/Bitcoin-ABC/bitcoin-abc/blob/e49826c1fcc36e5ae26de0ad4d06e2063a759e73/src/script/interpreter.cpp#L1399\r\n\r\nIt says:\r\n```\r\n    ss << ((GetForkId() << 8) | nHashType);\r\n```\r\n\r\nCould someone help me to understand this? Thanks."}}
{"actor":{"display_login":"matiu"}}