{"action":"created","comment":{"url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments/137224090","pull_request_review_id":60860968,"id":137224090,"diff_hunk":"@@ -0,0 +1,63 @@\n+#!/bin/bash\n+\n+# Ensure you have repo in this dir\n+# from https://source.android.com/source/downloading#installing-repo\n+\n+repo-setup ()  \n+{\n+    # Create a place to put repo in your path\n+    mkdir ~/bin\n+    PATH=~/bin:$PATH\n+\n+    # Download the Repo tool and ensure that it is executable:\n+    curl https://storage.googleapis.com/git-repo-downloads/repo > ~/bin/repo\n+    chmod a+x ~/bin/repo\n+}\n+\n+# check that the repo tool exists, if not, set it up\n+REPOTOOL=$( which repo )\n+if [ ! -e ${REPOTOOL} ]; then\n+    repo-setup\n+fi\n+\n+# repo init -u https://github.com/Pelagicore/pelux-manifests.git -m pelux-intel.xml -b master\n+# repo sync\n+\n+# if [ ! -e ./build]; then\n+#     mkdir build\n+# fi\n+\n+# build ()\n+# {\n+#     export TEMPLATECONF=$( pwd )/sources/meta-pelux-bsp-intel/conf/\n+#     source sources/poky/oe-init-build-env build\n+#     bitbake core-image-pelux\n+# }\n+\n+# # You can (must?) do a repo sync before re-building\n+# repo sync\n+\n+# Troubleshooting\n+# \"Please use a locale setting which supports utf-8.\n+# Python can't change the filesystem locale after loading so we need a utf-8 when python starts or things won't work.\"\n+# export LANGUAGE=en_US.UTF-8\n+# export LANG=en_US.UTF-8\n+# export LC_ALL=en_US.UTF-8\n+# dpkg-reconfigure locales\n+\n+\n+sd-image-create ()\n+{\n+    # hic sunt dracones!\n+\n+    # Create a new sd image based on the name of the image we're building\n+    dd if=/dev/zero of=\"pelux-intel.sdimg\" bs=1024 count=1M\n+    sudo losetup -d /dev/loop0\n+    sudo losetup /dev/loop0 pelux-intel.sdimg\n+    sudo bash ~/pelux/sources/poky/scripts/contrib/mkefidisk.sh /dev/loop0 core-image-pelux-intel-corei7-64.hddimg /dev/mmcblk2","path":"build-pelux.sh","position":57,"original_position":57,"commit_id":"3d34566f4de08cc481803485813f05f0f1f84a6b","original_commit_id":"3d34566f4de08cc481803485813f05f0f1f84a6b","user":{"login":"jonte","id":67082,"avatar_url":"https://avatars0.githubusercontent.com/u/67082?v=4","gravatar_id":"","url":"https://api.github.com/users/jonte","html_url":"https://github.com/jonte","followers_url":"https://api.github.com/users/jonte/followers","following_url":"https://api.github.com/users/jonte/following{/other_user}","gists_url":"https://api.github.com/users/jonte/gists{/gist_id}","starred_url":"https://api.github.com/users/jonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonte/subscriptions","organizations_url":"https://api.github.com/users/jonte/orgs","repos_url":"https://api.github.com/users/jonte/repos","events_url":"https://api.github.com/users/jonte/events{/privacy}","received_events_url":"https://api.github.com/users/jonte/received_events","type":"User","site_admin":false},"body":"Also, we should probably rely on the hashbang in mkefidisk.sh rather than assume that bash should be invoked on the script (this is unlikely to cause issues, but technically the script hashbang could change, and a different interpreter could be specified).","created_at":"2017-09-06T10:01:16Z","updated_at":"2017-09-06T10:01:16Z","html_url":"https://github.com/Pelagicore/pelux-manifests/pull/68#discussion_r137224090","pull_request_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments/137224090"},"html":{"href":"https://github.com/Pelagicore/pelux-manifests/pull/68#discussion_r137224090"},"pull_request":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68"}},"in_reply_to_id":137223835},"pull_request":{"url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68","id":139227115,"html_url":"https://github.com/Pelagicore/pelux-manifests/pull/68","diff_url":"https://github.com/Pelagicore/pelux-manifests/pull/68.diff","patch_url":"https://github.com/Pelagicore/pelux-manifests/pull/68.patch","issue_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/68","number":68,"state":"open","locked":false,"title":"Changes made after feedback","user":{"login":"jeremiah","id":5260,"avatar_url":"https://avatars1.githubusercontent.com/u/5260?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiah","html_url":"https://github.com/jeremiah","followers_url":"https://api.github.com/users/jeremiah/followers","following_url":"https://api.github.com/users/jeremiah/following{/other_user}","gists_url":"https://api.github.com/users/jeremiah/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiah/subscriptions","organizations_url":"https://api.github.com/users/jeremiah/orgs","repos_url":"https://api.github.com/users/jeremiah/repos","events_url":"https://api.github.com/users/jeremiah/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiah/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-05T02:29:07Z","updated_at":"2017-09-06T10:01:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd8bae37d191ec0f4df04bd30ac9c7694dec791a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frznlogic","id":6243348,"avatar_url":"https://avatars0.githubusercontent.com/u/6243348?v=4","gravatar_id":"","url":"https://api.github.com/users/frznlogic","html_url":"https://github.com/frznlogic","followers_url":"https://api.github.com/users/frznlogic/followers","following_url":"https://api.github.com/users/frznlogic/following{/other_user}","gists_url":"https://api.github.com/users/frznlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/frznlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frznlogic/subscriptions","organizations_url":"https://api.github.com/users/frznlogic/orgs","repos_url":"https://api.github.com/users/frznlogic/repos","events_url":"https://api.github.com/users/frznlogic/events{/privacy}","received_events_url":"https://api.github.com/users/frznlogic/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68/commits","review_comments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68/comments","review_comment_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/68/comments","statuses_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/statuses/3d34566f4de08cc481803485813f05f0f1f84a6b","head":{"label":"jeremiah:master","ref":"master","sha":"3d34566f4de08cc481803485813f05f0f1f84a6b","user":{"login":"jeremiah","id":5260,"avatar_url":"https://avatars1.githubusercontent.com/u/5260?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiah","html_url":"https://github.com/jeremiah","followers_url":"https://api.github.com/users/jeremiah/followers","following_url":"https://api.github.com/users/jeremiah/following{/other_user}","gists_url":"https://api.github.com/users/jeremiah/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiah/subscriptions","organizations_url":"https://api.github.com/users/jeremiah/orgs","repos_url":"https://api.github.com/users/jeremiah/repos","events_url":"https://api.github.com/users/jeremiah/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiah/received_events","type":"User","site_admin":false},"repo":{"id":102034366,"name":"pelux-manifests","full_name":"jeremiah/pelux-manifests","owner":{"login":"jeremiah","id":5260,"avatar_url":"https://avatars1.githubusercontent.com/u/5260?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiah","html_url":"https://github.com/jeremiah","followers_url":"https://api.github.com/users/jeremiah/followers","following_url":"https://api.github.com/users/jeremiah/following{/other_user}","gists_url":"https://api.github.com/users/jeremiah/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiah/subscriptions","organizations_url":"https://api.github.com/users/jeremiah/orgs","repos_url":"https://api.github.com/users/jeremiah/repos","events_url":"https://api.github.com/users/jeremiah/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremiah/pelux-manifests","description":"A set of manifests that can be used to build variants of PELUX {FORKED!}","fork":true,"url":"https://api.github.com/repos/jeremiah/pelux-manifests","forks_url":"https://api.github.com/repos/jeremiah/pelux-manifests/forks","keys_url":"https://api.github.com/repos/jeremiah/pelux-manifests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremiah/pelux-manifests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremiah/pelux-manifests/teams","hooks_url":"https://api.github.com/repos/jeremiah/pelux-manifests/hooks","issue_events_url":"https://api.github.com/repos/jeremiah/pelux-manifests/issues/events{/number}","events_url":"https://api.github.com/repos/jeremiah/pelux-manifests/events","assignees_url":"https://api.github.com/repos/jeremiah/pelux-manifests/assignees{/user}","branches_url":"https://api.github.com/repos/jeremiah/pelux-manifests/branches{/branch}","tags_url":"https://api.github.com/repos/jeremiah/pelux-manifests/tags","blobs_url":"https://api.github.com/repos/jeremiah/pelux-manifests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremiah/pelux-manifests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremiah/pelux-manifests/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremiah/pelux-manifests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremiah/pelux-manifests/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremiah/pelux-manifests/languages","stargazers_url":"https://api.github.com/repos/jeremiah/pelux-manifests/stargazers","contributors_url":"https://api.github.com/repos/jeremiah/pelux-manifests/contributors","subscribers_url":"https://api.github.com/repos/jeremiah/pelux-manifests/subscribers","subscription_url":"https://api.github.com/repos/jeremiah/pelux-manifests/subscription","commits_url":"https://api.github.com/repos/jeremiah/pelux-manifests/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremiah/pelux-manifests/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremiah/pelux-manifests/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremiah/pelux-manifests/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremiah/pelux-manifests/contents/{+path}","compare_url":"https://api.github.com/repos/jeremiah/pelux-manifests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremiah/pelux-manifests/merges","archive_url":"https://api.github.com/repos/jeremiah/pelux-manifests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremiah/pelux-manifests/downloads","issues_url":"https://api.github.com/repos/jeremiah/pelux-manifests/issues{/number}","pulls_url":"https://api.github.com/repos/jeremiah/pelux-manifests/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremiah/pelux-manifests/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremiah/pelux-manifests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremiah/pelux-manifests/labels{/name}","releases_url":"https://api.github.com/repos/jeremiah/pelux-manifests/releases{/id}","deployments_url":"https://api.github.com/repos/jeremiah/pelux-manifests/deployments","created_at":"2017-08-31T18:54:23Z","updated_at":"2017-09-05T17:05:41Z","pushed_at":"2017-09-05T17:05:16Z","git_url":"git://github.com/jeremiah/pelux-manifests.git","ssh_url":"git@github.com:jeremiah/pelux-manifests.git","clone_url":"https://github.com/jeremiah/pelux-manifests.git","svn_url":"https://github.com/jeremiah/pelux-manifests","homepage":"","size":75,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pelagicore:master","ref":"master","sha":"f3ef368c18f0fb199e509bbe5ca0b25f040b5f12","user":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars3.githubusercontent.com/u/4661080?v=4","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"repo":{"id":76041595,"name":"pelux-manifests","full_name":"Pelagicore/pelux-manifests","owner":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars3.githubusercontent.com/u/4661080?v=4","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pelagicore/pelux-manifests","description":"A set of manifests that can be used to build variants of PELUX","fork":false,"url":"https://api.github.com/repos/Pelagicore/pelux-manifests","forks_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/forks","keys_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/teams","hooks_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/hooks","issue_events_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/events{/number}","events_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/events","assignees_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/assignees{/user}","branches_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/branches{/branch}","tags_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/tags","blobs_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/statuses/{sha}","languages_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/languages","stargazers_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/stargazers","contributors_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/contributors","subscribers_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/subscribers","subscription_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/subscription","commits_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/contents/{+path}","compare_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/merges","archive_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/downloads","issues_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues{/number}","pulls_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls{/number}","milestones_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/milestones{/number}","notifications_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/labels{/name}","releases_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/releases{/id}","deployments_url":"https://api.github.com/repos/Pelagicore/pelux-manifests/deployments","created_at":"2016-12-09T14:19:46Z","updated_at":"2017-06-08T07:11:31Z","pushed_at":"2017-09-05T17:05:17Z","git_url":"git://github.com/Pelagicore/pelux-manifests.git","ssh_url":"git@github.com:Pelagicore/pelux-manifests.git","clone_url":"https://github.com/Pelagicore/pelux-manifests.git","svn_url":"https://github.com/Pelagicore/pelux-manifests","homepage":"","size":69,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68"},"html":{"href":"https://github.com/Pelagicore/pelux-manifests/pull/68"},"issue":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/68"},"comments":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/Pelagicore/pelux-manifests/statuses/3d34566f4de08cc481803485813f05f0f1f84a6b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jonte"}}