{"action":"created","issue":{"url":"https://api.github.com/repos/Financial-Times/notifications-push/issues/50","repository_url":"https://api.github.com/repos/Financial-Times/notifications-push","labels_url":"https://api.github.com/repos/Financial-Times/notifications-push/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/Financial-Times/notifications-push/issues/50/comments","events_url":"https://api.github.com/repos/Financial-Times/notifications-push/issues/50/events","html_url":"https://github.com/Financial-Times/notifications-push/pull/50","id":252236634,"number":50,"title":"Filter notifications by content type","user":{"login":"ioanaciont","id":25034588,"avatar_url":"https://avatars1.githubusercontent.com/u/25034588?v=4","gravatar_id":"","url":"https://api.github.com/users/ioanaciont","html_url":"https://github.com/ioanaciont","followers_url":"https://api.github.com/users/ioanaciont/followers","following_url":"https://api.github.com/users/ioanaciont/following{/other_user}","gists_url":"https://api.github.com/users/ioanaciont/gists{/gist_id}","starred_url":"https://api.github.com/users/ioanaciont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioanaciont/subscriptions","organizations_url":"https://api.github.com/users/ioanaciont/orgs","repos_url":"https://api.github.com/users/ioanaciont/repos","events_url":"https://api.github.com/users/ioanaciont/events{/privacy}","received_events_url":"https://api.github.com/users/ioanaciont/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-23T10:37:30Z","updated_at":"2017-08-23T15:00:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Financial-Times/notifications-push/pulls/50","html_url":"https://github.com/Financial-Times/notifications-push/pull/50","diff_url":"https://github.com/Financial-Times/notifications-push/pull/50.diff","patch_url":"https://github.com/Financial-Times/notifications-push/pull/50.patch"},"body":"Clients can filter the content adding a request param for content type (e.g. https://api.ft.com/content/notifications-push?type=article)\r\nFor the moment, we do not support multiple types in a single request -> agreed with David L. (`type=article&type=content` does not work as expected, it will filter results based on the first value from the request -> article)\r\n\r\n- If the type is not specified, the filter will be set to `type=Article`\r\n- Clients can specify `type=All` that will return all the notifications, despite of their type.\r\n- `DELETE` notifications will be always sent to the clients, because their payload is empty (in Kafka) and we cannot extract the type\r\n\r\nSupported types in notifications push are: `Article`, `Content` (for content placeholders), `ContentPackage`."},"comment":{"url":"https://api.github.com/repos/Financial-Times/notifications-push/issues/comments/324363986","html_url":"https://github.com/Financial-Times/notifications-push/pull/50#issuecomment-324363986","issue_url":"https://api.github.com/repos/Financial-Times/notifications-push/issues/50","id":324363986,"user":{"login":"kovacshuni","id":1782646,"avatar_url":"https://avatars3.githubusercontent.com/u/1782646?v=4","gravatar_id":"","url":"https://api.github.com/users/kovacshuni","html_url":"https://github.com/kovacshuni","followers_url":"https://api.github.com/users/kovacshuni/followers","following_url":"https://api.github.com/users/kovacshuni/following{/other_user}","gists_url":"https://api.github.com/users/kovacshuni/gists{/gist_id}","starred_url":"https://api.github.com/users/kovacshuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovacshuni/subscriptions","organizations_url":"https://api.github.com/users/kovacshuni/orgs","repos_url":"https://api.github.com/users/kovacshuni/repos","events_url":"https://api.github.com/users/kovacshuni/events{/privacy}","received_events_url":"https://api.github.com/users/kovacshuni/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T15:00:38Z","updated_at":"2017-08-23T15:00:38Z","body":"I don't know why is not the `contentType` inside the `Notification` struct. We have multiple levels now. I know maybe you wanted to leave the `Notification` struct to remain compatible with the `/notifications` format, but i don't know if it's worth it. You could discuss with others, Next and PO's.\r\n\r\nVery nicely written description (of the PR)."}}
{"actor":{"display_login":"kovacshuni"}}