{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cordova-windows/pulls/comments/155570284","pull_request_review_id":81911234,"id":155570284,"diff_hunk":"@@ -69,18 +69,21 @@ function readPreferencesFromCfg(cfg, manifest) {\n         splashImageSrc = schema + ':///' + manifest.getSplashScreenImagePath().replace(/\\\\/g, '/');\n \n         bgColor = cfg.getPreferenceValue('SplashScreenBackgroundColor') || bgColor;\n-        bgColor = bgColor.replace('0x', '#').replace('0X', '#');\n-        if (bgColor.length > 7) {\n-            // Remove aplha\n-            bgColor = bgColor.slice(0, 1) + bgColor.slice(3, bgColor.length);\n-        }\n+        bgColor = bgColor.toLowerCase().replace('0x', '#');\n+\n+        if (bgColor !== 'transparent') {\n+            if (bgColor.length > 7) {\n+                // Remove aplha","path":"cordova-js-src/splashscreen.js","position":13,"original_position":13,"commit_id":"f688b27d2ec25cff98268b2e93cf18c4618d81b9","original_commit_id":"f688b27d2ec25cff98268b2e93cf18c4618d81b9","user":{"login":"IndieSW","id":6879890,"avatar_url":"https://avatars1.githubusercontent.com/u/6879890?v=4","gravatar_id":"","url":"https://api.github.com/users/IndieSW","html_url":"https://github.com/IndieSW","followers_url":"https://api.github.com/users/IndieSW/followers","following_url":"https://api.github.com/users/IndieSW/following{/other_user}","gists_url":"https://api.github.com/users/IndieSW/gists{/gist_id}","starred_url":"https://api.github.com/users/IndieSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IndieSW/subscriptions","organizations_url":"https://api.github.com/users/IndieSW/orgs","repos_url":"https://api.github.com/users/IndieSW/repos","events_url":"https://api.github.com/users/IndieSW/events{/privacy}","received_events_url":"https://api.github.com/users/IndieSW/received_events","type":"User","site_admin":false},"body":":)","created_at":"2017-12-07T16:24:37Z","updated_at":"2017-12-07T16:24:37Z","html_url":"https://github.com/apache/cordova-windows/pull/244#discussion_r155570284","pull_request_url":"https://api.github.com/repos/apache/cordova-windows/pulls/244","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/comments/155570284"},"html":{"href":"https://github.com/apache/cordova-windows/pull/244#discussion_r155570284"},"pull_request":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/244"}},"in_reply_to_id":155561058},"pull_request":{"url":"https://api.github.com/repos/apache/cordova-windows/pulls/244","id":157027877,"html_url":"https://github.com/apache/cordova-windows/pull/244","diff_url":"https://github.com/apache/cordova-windows/pull/244.diff","patch_url":"https://github.com/apache/cordova-windows/pull/244.patch","issue_url":"https://api.github.com/repos/apache/cordova-windows/issues/244","number":244,"state":"open","locked":false,"title":"CB-13641: (windows) allow for transparent splash screen background co…","user":{"login":"IndieSW","id":6879890,"avatar_url":"https://avatars1.githubusercontent.com/u/6879890?v=4","gravatar_id":"","url":"https://api.github.com/users/IndieSW","html_url":"https://github.com/IndieSW","followers_url":"https://api.github.com/users/IndieSW/followers","following_url":"https://api.github.com/users/IndieSW/following{/other_user}","gists_url":"https://api.github.com/users/IndieSW/gists{/gist_id}","starred_url":"https://api.github.com/users/IndieSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IndieSW/subscriptions","organizations_url":"https://api.github.com/users/IndieSW/orgs","repos_url":"https://api.github.com/users/IndieSW/repos","events_url":"https://api.github.com/users/IndieSW/events{/privacy}","received_events_url":"https://api.github.com/users/IndieSW/received_events","type":"User","site_admin":false},"body":"…lor.\r\n\r\n<!--\r\nPlease make sure the checklist boxes are all checked before submitting the PR. The checklist\r\nis intended as a quick reference, for complete details please see our Contributor Guidelines:\r\n\r\nhttp://cordova.apache.org/contribute/contribute_guidelines.html\r\n\r\nThanks!\r\n-->\r\n\r\n### Platforms affected\r\nwindows\r\n\r\n### What does this PR do?\r\nallows for configuration of transparent splash screen background color.\r\n\r\n### What testing has been done on this change?\r\nbuilt app with forked/updated repository and manually tested splash screen background color configuration with RGB and 'transparent' values.\r\n\r\n### Checklist\r\n- [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database\r\n- [ x] Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected.\r\n- [ x] Added automated test coverage as appropriate for this change.\r\n","created_at":"2017-12-07T15:41:26Z","updated_at":"2017-12-07T16:24:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9f28b0f0bf90d6aa279d646781b568f53ca0ba","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-windows/pulls/244/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-windows/pulls/244/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cordova-windows/issues/244/comments","statuses_url":"https://api.github.com/repos/apache/cordova-windows/statuses/f688b27d2ec25cff98268b2e93cf18c4618d81b9","head":{"label":"IndieSW:master","ref":"master","sha":"f688b27d2ec25cff98268b2e93cf18c4618d81b9","user":{"login":"IndieSW","id":6879890,"avatar_url":"https://avatars1.githubusercontent.com/u/6879890?v=4","gravatar_id":"","url":"https://api.github.com/users/IndieSW","html_url":"https://github.com/IndieSW","followers_url":"https://api.github.com/users/IndieSW/followers","following_url":"https://api.github.com/users/IndieSW/following{/other_user}","gists_url":"https://api.github.com/users/IndieSW/gists{/gist_id}","starred_url":"https://api.github.com/users/IndieSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IndieSW/subscriptions","organizations_url":"https://api.github.com/users/IndieSW/orgs","repos_url":"https://api.github.com/users/IndieSW/repos","events_url":"https://api.github.com/users/IndieSW/events{/privacy}","received_events_url":"https://api.github.com/users/IndieSW/received_events","type":"User","site_admin":false},"repo":{"id":113450179,"name":"cordova-windows","full_name":"IndieSW/cordova-windows","owner":{"login":"IndieSW","id":6879890,"avatar_url":"https://avatars1.githubusercontent.com/u/6879890?v=4","gravatar_id":"","url":"https://api.github.com/users/IndieSW","html_url":"https://github.com/IndieSW","followers_url":"https://api.github.com/users/IndieSW/followers","following_url":"https://api.github.com/users/IndieSW/following{/other_user}","gists_url":"https://api.github.com/users/IndieSW/gists{/gist_id}","starred_url":"https://api.github.com/users/IndieSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IndieSW/subscriptions","organizations_url":"https://api.github.com/users/IndieSW/orgs","repos_url":"https://api.github.com/users/IndieSW/repos","events_url":"https://api.github.com/users/IndieSW/events{/privacy}","received_events_url":"https://api.github.com/users/IndieSW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IndieSW/cordova-windows","description":"Mirror of Apache Cordova Windows","fork":true,"url":"https://api.github.com/repos/IndieSW/cordova-windows","forks_url":"https://api.github.com/repos/IndieSW/cordova-windows/forks","keys_url":"https://api.github.com/repos/IndieSW/cordova-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IndieSW/cordova-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IndieSW/cordova-windows/teams","hooks_url":"https://api.github.com/repos/IndieSW/cordova-windows/hooks","issue_events_url":"https://api.github.com/repos/IndieSW/cordova-windows/issues/events{/number}","events_url":"https://api.github.com/repos/IndieSW/cordova-windows/events","assignees_url":"https://api.github.com/repos/IndieSW/cordova-windows/assignees{/user}","branches_url":"https://api.github.com/repos/IndieSW/cordova-windows/branches{/branch}","tags_url":"https://api.github.com/repos/IndieSW/cordova-windows/tags","blobs_url":"https://api.github.com/repos/IndieSW/cordova-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IndieSW/cordova-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IndieSW/cordova-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/IndieSW/cordova-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IndieSW/cordova-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/IndieSW/cordova-windows/languages","stargazers_url":"https://api.github.com/repos/IndieSW/cordova-windows/stargazers","contributors_url":"https://api.github.com/repos/IndieSW/cordova-windows/contributors","subscribers_url":"https://api.github.com/repos/IndieSW/cordova-windows/subscribers","subscription_url":"https://api.github.com/repos/IndieSW/cordova-windows/subscription","commits_url":"https://api.github.com/repos/IndieSW/cordova-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/IndieSW/cordova-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/IndieSW/cordova-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/IndieSW/cordova-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/IndieSW/cordova-windows/contents/{+path}","compare_url":"https://api.github.com/repos/IndieSW/cordova-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IndieSW/cordova-windows/merges","archive_url":"https://api.github.com/repos/IndieSW/cordova-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IndieSW/cordova-windows/downloads","issues_url":"https://api.github.com/repos/IndieSW/cordova-windows/issues{/number}","pulls_url":"https://api.github.com/repos/IndieSW/cordova-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/IndieSW/cordova-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/IndieSW/cordova-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IndieSW/cordova-windows/labels{/name}","releases_url":"https://api.github.com/repos/IndieSW/cordova-windows/releases{/id}","deployments_url":"https://api.github.com/repos/IndieSW/cordova-windows/deployments","created_at":"2017-12-07T12:48:03Z","updated_at":"2017-12-07T12:48:05Z","pushed_at":"2017-12-07T15:33:30Z","git_url":"git://github.com/IndieSW/cordova-windows.git","ssh_url":"git@github.com:IndieSW/cordova-windows.git","clone_url":"https://github.com/IndieSW/cordova-windows.git","svn_url":"https://github.com/IndieSW/cordova-windows","homepage":null,"size":38419,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c9c69feaca9f5adad8550e314e3b8274a4e121b9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":6898394,"name":"cordova-windows","full_name":"apache/cordova-windows","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-windows","description":"Mirror of Apache Cordova Windows","fork":false,"url":"https://api.github.com/repos/apache/cordova-windows","forks_url":"https://api.github.com/repos/apache/cordova-windows/forks","keys_url":"https://api.github.com/repos/apache/cordova-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-windows/teams","hooks_url":"https://api.github.com/repos/apache/cordova-windows/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-windows/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-windows/events","assignees_url":"https://api.github.com/repos/apache/cordova-windows/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-windows/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-windows/tags","blobs_url":"https://api.github.com/repos/apache/cordova-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-windows/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-windows/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-windows/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-windows/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-windows/subscription","commits_url":"https://api.github.com/repos/apache/cordova-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-windows/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-windows/merges","archive_url":"https://api.github.com/repos/apache/cordova-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-windows/downloads","issues_url":"https://api.github.com/repos/apache/cordova-windows/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-windows/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-windows/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cordova-windows/deployments","created_at":"2012-11-28T08:00:28Z","updated_at":"2017-11-22T10:12:11Z","pushed_at":"2017-12-07T15:41:27Z","git_url":"git://github.com/apache/cordova-windows.git","ssh_url":"git@github.com:apache/cordova-windows.git","clone_url":"https://github.com/apache/cordova-windows.git","svn_url":"https://github.com/apache/cordova-windows","homepage":null,"size":38417,"stargazers_count":157,"watchers_count":157,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":154,"open_issues":3,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/244"},"html":{"href":"https://github.com/apache/cordova-windows/pull/244"},"issue":{"href":"https://api.github.com/repos/apache/cordova-windows/issues/244"},"comments":{"href":"https://api.github.com/repos/apache/cordova-windows/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-windows/statuses/f688b27d2ec25cff98268b2e93cf18c4618d81b9"}},"author_association":"NONE"}}
{"actor":{"display_login":"IndieSW"}}