{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/143553052","pull_request_review_id":68080619,"id":143553052,"diff_hunk":"@@ -642,9 +642,13 @@ def test_pinned_task_does_not_scale_to_unpinned_host():\n \n     app_def = apps.sleep_app()\n     app_id = app_def['id']\n-    app_def['cpus'] = 3.5\n+\n     host = common.ip_other_than_mom()\n     print('Constraint set to host: {}'.format(host))\n+    # the size of cpus is designed to be greater than 1/2 of a node","path":"tests/system/marathon_common_tests.py","position":8,"original_position":8,"commit_id":"961547d17fc2ce6d002fff4641c75e5bd921a607","original_commit_id":"f1016bad55e878e2adc27d3c90802c9abf49669a","user":{"login":"kensipe","id":27497,"avatar_url":"https://avatars2.githubusercontent.com/u/27497?v=4","gravatar_id":"","url":"https://api.github.com/users/kensipe","html_url":"https://github.com/kensipe","followers_url":"https://api.github.com/users/kensipe/followers","following_url":"https://api.github.com/users/kensipe/following{/other_user}","gists_url":"https://api.github.com/users/kensipe/gists{/gist_id}","starred_url":"https://api.github.com/users/kensipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kensipe/subscriptions","organizations_url":"https://api.github.com/users/kensipe/orgs","repos_url":"https://api.github.com/users/kensipe/repos","events_url":"https://api.github.com/users/kensipe/events{/privacy}","received_events_url":"https://api.github.com/users/kensipe/received_events","type":"User","site_admin":false},"body":"it's a good catch... however if we start using 1 core vms I quit :) ","created_at":"2017-10-09T19:09:41Z","updated_at":"2017-10-09T19:09:41Z","html_url":"https://github.com/mesosphere/marathon/pull/5581#discussion_r143553052","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5581","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/143553052"},"html":{"href":"https://github.com/mesosphere/marathon/pull/5581#discussion_r143553052"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5581"}},"in_reply_to_id":143535473},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/5581","id":145510929,"html_url":"https://github.com/mesosphere/marathon/pull/5581","diff_url":"https://github.com/mesosphere/marathon/pull/5581.diff","patch_url":"https://github.com/mesosphere/marathon/pull/5581.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/5581","number":5581,"state":"open","locked":false,"title":"Enable successful SI Test runs with cluster of agents with different core counts","user":{"login":"kensipe","id":27497,"avatar_url":"https://avatars2.githubusercontent.com/u/27497?v=4","gravatar_id":"","url":"https://api.github.com/users/kensipe","html_url":"https://github.com/kensipe","followers_url":"https://api.github.com/users/kensipe/followers","following_url":"https://api.github.com/users/kensipe/following{/other_user}","gists_url":"https://api.github.com/users/kensipe/gists{/gist_id}","starred_url":"https://api.github.com/users/kensipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kensipe/subscriptions","organizations_url":"https://api.github.com/users/kensipe/orgs","repos_url":"https://api.github.com/users/kensipe/repos","events_url":"https://api.github.com/users/kensipe/events{/privacy}","received_events_url":"https://api.github.com/users/kensipe/received_events","type":"User","site_admin":false},"body":"Enable successful SI Test runs with cluster of agents with different core counts\r\n\r\nSummary:\r\nThe test was originally written assuming an agent core count of 4 which has been true for years.   Based on cost cutting measures the latest clusters are made of 2 core agents.   However CCM still creates the 4 core count agents.   This change allows this test to pass for changes in the agent core count.\r\n\r\nJIRA issues:\r\n??","created_at":"2017-10-09T17:46:38Z","updated_at":"2017-10-09T19:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c10da7cc10cc4cf2ef67038693f5aac1a3fd5c0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5581/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/5581/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/5581/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/961547d17fc2ce6d002fff4641c75e5bd921a607","head":{"label":"mesosphere:ken/si-fix-on-host-size-change","ref":"ken/si-fix-on-host-size-change","sha":"961547d17fc2ce6d002fff4641c75e5bd921a607","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2017-10-09T09:58:33Z","pushed_at":"2017-10-09T19:09:11Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":31619,"stargazers_count":3455,"watchers_count":3455,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":796,"mirror_url":null,"open_issues_count":26,"forks":796,"open_issues":26,"watchers":3455,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"897bd439ddb6aeb92faa9f2de8bcd291131d1e85","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2017-10-09T09:58:33Z","pushed_at":"2017-10-09T19:09:11Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":31619,"stargazers_count":3455,"watchers_count":3455,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":796,"mirror_url":null,"open_issues_count":26,"forks":796,"open_issues":26,"watchers":3455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5581"},"html":{"href":"https://github.com/mesosphere/marathon/pull/5581"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/5581"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/5581/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5581/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/5581/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/961547d17fc2ce6d002fff4641c75e5bd921a607"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kensipe"}}