{"action":"created","comment":{"url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/comments/144318236","pull_request_review_id":68958701,"id":144318236,"diff_hunk":"@@ -0,0 +1,15 @@\n+'''\n+hold_position_demo_controller.py\n+'''\n+\n+from roombasim.ai import Controller\n+\n+class TakeoffDemoController(Controller):","path":"roombasim/pittras/ai/hold_position_demo_controller.py","position":null,"original_position":7,"commit_id":"f80494d3d8c3a9d6bb12cdefac483438b765480d","original_commit_id":"0627bf346b96008aea2295833c81e867d11eb43b","user":{"login":"zacyu","id":1730305,"avatar_url":"https://avatars2.githubusercontent.com/u/1730305?v=4","gravatar_id":"","url":"https://api.github.com/users/zacyu","html_url":"https://github.com/zacyu","followers_url":"https://api.github.com/users/zacyu/followers","following_url":"https://api.github.com/users/zacyu/following{/other_user}","gists_url":"https://api.github.com/users/zacyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zacyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zacyu/subscriptions","organizations_url":"https://api.github.com/users/zacyu/orgs","repos_url":"https://api.github.com/users/zacyu/repos","events_url":"https://api.github.com/users/zacyu/events{/privacy}","received_events_url":"https://api.github.com/users/zacyu/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-10-12T15:07:14Z","updated_at":"2017-10-12T15:10:19Z","html_url":"https://github.com/Pitt-RAS/RoombaSIM/pull/7#discussion_r144318236","pull_request_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/comments/144318236"},"html":{"href":"https://github.com/Pitt-RAS/RoombaSIM/pull/7#discussion_r144318236"},"pull_request":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7"}},"in_reply_to_id":144202542},"pull_request":{"url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7","id":146123469,"html_url":"https://github.com/Pitt-RAS/RoombaSIM/pull/7","diff_url":"https://github.com/Pitt-RAS/RoombaSIM/pull/7.diff","patch_url":"https://github.com/Pitt-RAS/RoombaSIM/pull/7.patch","issue_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/7","number":7,"state":"open","locked":false,"title":"Add hold position task.","user":{"login":"zacyu","id":1730305,"avatar_url":"https://avatars2.githubusercontent.com/u/1730305?v=4","gravatar_id":"","url":"https://api.github.com/users/zacyu","html_url":"https://github.com/zacyu","followers_url":"https://api.github.com/users/zacyu/followers","following_url":"https://api.github.com/users/zacyu/following{/other_user}","gists_url":"https://api.github.com/users/zacyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zacyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zacyu/subscriptions","organizations_url":"https://api.github.com/users/zacyu/orgs","repos_url":"https://api.github.com/users/zacyu/repos","events_url":"https://api.github.com/users/zacyu/events{/privacy}","received_events_url":"https://api.github.com/users/zacyu/received_events","type":"User","site_admin":false},"body":"The Hold Position task contains pretty much only boilerplates for now since we currently don't have the capability to signal the termination of a task. Also if I understood it correctly, there is no need to adjust the position manually to some saved initial position, under the assumption that only one task can be executed at any given time.\r\nThis change also fixes some imported errors.","created_at":"2017-10-12T05:58:33Z","updated_at":"2017-10-12T15:10:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cdbc50f9f0511880c164c2bdd745a5208a4f3d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hgarrereyn","id":4087148,"avatar_url":"https://avatars3.githubusercontent.com/u/4087148?v=4","gravatar_id":"","url":"https://api.github.com/users/hgarrereyn","html_url":"https://github.com/hgarrereyn","followers_url":"https://api.github.com/users/hgarrereyn/followers","following_url":"https://api.github.com/users/hgarrereyn/following{/other_user}","gists_url":"https://api.github.com/users/hgarrereyn/gists{/gist_id}","starred_url":"https://api.github.com/users/hgarrereyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgarrereyn/subscriptions","organizations_url":"https://api.github.com/users/hgarrereyn/orgs","repos_url":"https://api.github.com/users/hgarrereyn/repos","events_url":"https://api.github.com/users/hgarrereyn/events{/privacy}","received_events_url":"https://api.github.com/users/hgarrereyn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/7/comments","statuses_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/statuses/f80494d3d8c3a9d6bb12cdefac483438b765480d","head":{"label":"Pitt-RAS:zyu_tasks","ref":"zyu_tasks","sha":"f80494d3d8c3a9d6bb12cdefac483438b765480d","user":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars3.githubusercontent.com/u/15024509?v=4","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"repo":{"id":102907155,"name":"RoombaSIM","full_name":"Pitt-RAS/RoombaSIM","owner":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars3.githubusercontent.com/u/15024509?v=4","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pitt-RAS/RoombaSIM","description":"An AI training environment for IARC mission 7","fork":false,"url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM","forks_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/forks","keys_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/teams","hooks_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/hooks","issue_events_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/events{/number}","events_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/events","assignees_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/assignees{/user}","branches_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/branches{/branch}","tags_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/tags","blobs_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/statuses/{sha}","languages_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/languages","stargazers_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/stargazers","contributors_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/contributors","subscribers_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/subscribers","subscription_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/subscription","commits_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/contents/{+path}","compare_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/merges","archive_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/downloads","issues_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues{/number}","pulls_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls{/number}","milestones_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/milestones{/number}","notifications_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/labels{/name}","releases_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/releases{/id}","deployments_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/deployments","created_at":"2017-09-08T21:47:38Z","updated_at":"2017-09-10T22:37:34Z","pushed_at":"2017-10-12T15:08:39Z","git_url":"git://github.com/Pitt-RAS/RoombaSIM.git","ssh_url":"git@github.com:Pitt-RAS/RoombaSIM.git","clone_url":"https://github.com/Pitt-RAS/RoombaSIM.git","svn_url":"https://github.com/Pitt-RAS/RoombaSIM","homepage":"","size":202,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Pitt-RAS:master","ref":"master","sha":"95f31f17c2b1815235d5ebf7f2b11b3cf440863e","user":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars3.githubusercontent.com/u/15024509?v=4","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"repo":{"id":102907155,"name":"RoombaSIM","full_name":"Pitt-RAS/RoombaSIM","owner":{"login":"Pitt-RAS","id":15024509,"avatar_url":"https://avatars3.githubusercontent.com/u/15024509?v=4","gravatar_id":"","url":"https://api.github.com/users/Pitt-RAS","html_url":"https://github.com/Pitt-RAS","followers_url":"https://api.github.com/users/Pitt-RAS/followers","following_url":"https://api.github.com/users/Pitt-RAS/following{/other_user}","gists_url":"https://api.github.com/users/Pitt-RAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Pitt-RAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pitt-RAS/subscriptions","organizations_url":"https://api.github.com/users/Pitt-RAS/orgs","repos_url":"https://api.github.com/users/Pitt-RAS/repos","events_url":"https://api.github.com/users/Pitt-RAS/events{/privacy}","received_events_url":"https://api.github.com/users/Pitt-RAS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pitt-RAS/RoombaSIM","description":"An AI training environment for IARC mission 7","fork":false,"url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM","forks_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/forks","keys_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/teams","hooks_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/hooks","issue_events_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/events{/number}","events_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/events","assignees_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/assignees{/user}","branches_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/branches{/branch}","tags_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/tags","blobs_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/statuses/{sha}","languages_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/languages","stargazers_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/stargazers","contributors_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/contributors","subscribers_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/subscribers","subscription_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/subscription","commits_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/contents/{+path}","compare_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/merges","archive_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/downloads","issues_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues{/number}","pulls_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls{/number}","milestones_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/milestones{/number}","notifications_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/labels{/name}","releases_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/releases{/id}","deployments_url":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/deployments","created_at":"2017-09-08T21:47:38Z","updated_at":"2017-09-10T22:37:34Z","pushed_at":"2017-10-12T15:08:39Z","git_url":"git://github.com/Pitt-RAS/RoombaSIM.git","ssh_url":"git@github.com:Pitt-RAS/RoombaSIM.git","clone_url":"https://github.com/Pitt-RAS/RoombaSIM.git","svn_url":"https://github.com/Pitt-RAS/RoombaSIM","homepage":"","size":202,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7"},"html":{"href":"https://github.com/Pitt-RAS/RoombaSIM/pull/7"},"issue":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/7"},"comments":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Pitt-RAS/RoombaSIM/statuses/f80494d3d8c3a9d6bb12cdefac483438b765480d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zacyu"}}