{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/142629845","pull_request_review_id":67015302,"id":142629845,"diff_hunk":"@@ -220,6 +246,36 @@ def testComputeRFFromGraphDefNonSquareRF(self):\n     self.assertEqual(effective_padding_x, 0)\n     self.assertEqual(effective_padding_y, 0)\n \n+  def testComputeRFFromGraphDefStopPropagation(self):\n+    graph_def = create_test_network_6().as_graph_def()\n+    input_node = 'input_image'\n+    output_node = 'output'\n+    # Compute the receptive field but stop the propagation for the random\n+    # uniform variable of the dropout\n+    (receptive_field_x, receptive_field_y, effective_stride_x,\n+     effective_stride_y, effective_padding_x, effective_padding_y) = (\n+         receptive_field.compute_receptive_field_from_graph_def(\n+             graph_def, input_node, output_node,\n+             ['Dropout/dropout/random_uniform']))","path":"tensorflow/contrib/receptive_field/python/util/receptive_field_test.py","position":54,"original_position":54,"commit_id":"ea026849754d18bed25c14ff7d713d031b75cedc","original_commit_id":"912fe504b01198d51aa809cd9230cdec67a71fb8","user":{"login":"tillahoffmann","id":966348,"avatar_url":"https://avatars2.githubusercontent.com/u/966348?v=4","gravatar_id":"","url":"https://api.github.com/users/tillahoffmann","html_url":"https://github.com/tillahoffmann","followers_url":"https://api.github.com/users/tillahoffmann/followers","following_url":"https://api.github.com/users/tillahoffmann/following{/other_user}","gists_url":"https://api.github.com/users/tillahoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillahoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillahoffmann/subscriptions","organizations_url":"https://api.github.com/users/tillahoffmann/orgs","repos_url":"https://api.github.com/users/tillahoffmann/repos","events_url":"https://api.github.com/users/tillahoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillahoffmann/received_events","type":"User","site_admin":false},"body":"Almost. The implementation of `dropout` uses the shape of the input features to generate uniform random numbers of matching shape. That introduces a dependency of a `RandomUniform` operation on the input features but there is no meaningful way to propagate the receptive field. So the propagation of the receptive field needs to be stopped rather than passed through unchanged.","created_at":"2017-10-04T10:03:41Z","updated_at":"2017-10-04T10:03:41Z","html_url":"https://github.com/tensorflow/tensorflow/pull/13239#discussion_r142629845","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/142629845"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/13239#discussion_r142629845"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239"}},"in_reply_to_id":142454290},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239","id":142634857,"html_url":"https://github.com/tensorflow/tensorflow/pull/13239","diff_url":"https://github.com/tensorflow/tensorflow/pull/13239.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/13239.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/13239","number":13239,"state":"open","locked":false,"title":"Add ReceptiveField class and coordinate conversion methods.","user":{"login":"tillahoffmann","id":966348,"avatar_url":"https://avatars2.githubusercontent.com/u/966348?v=4","gravatar_id":"","url":"https://api.github.com/users/tillahoffmann","html_url":"https://github.com/tillahoffmann","followers_url":"https://api.github.com/users/tillahoffmann/followers","following_url":"https://api.github.com/users/tillahoffmann/following{/other_user}","gists_url":"https://api.github.com/users/tillahoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillahoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillahoffmann/subscriptions","organizations_url":"https://api.github.com/users/tillahoffmann/orgs","repos_url":"https://api.github.com/users/tillahoffmann/repos","events_url":"https://api.github.com/users/tillahoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillahoffmann/received_events","type":"User","site_admin":false},"body":"This PR adds a `ReceptiveField` class which supports coordinate conversion from the input to the feature space and vice versa while maintaining backwards compatibility.","created_at":"2017-09-22T17:52:34Z","updated_at":"2017-10-04T10:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98359ee6355411f4108faa1576bf20bcbe03b418","assignee":{"login":"martinwicke","id":577277,"avatar_url":"https://avatars2.githubusercontent.com/u/577277?v=4","gravatar_id":"","url":"https://api.github.com/users/martinwicke","html_url":"https://github.com/martinwicke","followers_url":"https://api.github.com/users/martinwicke/followers","following_url":"https://api.github.com/users/martinwicke/following{/other_user}","gists_url":"https://api.github.com/users/martinwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/martinwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinwicke/subscriptions","organizations_url":"https://api.github.com/users/martinwicke/orgs","repos_url":"https://api.github.com/users/martinwicke/repos","events_url":"https://api.github.com/users/martinwicke/events{/privacy}","received_events_url":"https://api.github.com/users/martinwicke/received_events","type":"User","site_admin":false},"assignees":[{"login":"martinwicke","id":577277,"avatar_url":"https://avatars2.githubusercontent.com/u/577277?v=4","gravatar_id":"","url":"https://api.github.com/users/martinwicke","html_url":"https://github.com/martinwicke","followers_url":"https://api.github.com/users/martinwicke/followers","following_url":"https://api.github.com/users/martinwicke/following{/other_user}","gists_url":"https://api.github.com/users/martinwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/martinwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinwicke/subscriptions","organizations_url":"https://api.github.com/users/martinwicke/orgs","repos_url":"https://api.github.com/users/martinwicke/repos","events_url":"https://api.github.com/users/martinwicke/events{/privacy}","received_events_url":"https://api.github.com/users/martinwicke/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/13239/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/ea026849754d18bed25c14ff7d713d031b75cedc","head":{"label":"tillahoffmann:rf","ref":"rf","sha":"ea026849754d18bed25c14ff7d713d031b75cedc","user":{"login":"tillahoffmann","id":966348,"avatar_url":"https://avatars2.githubusercontent.com/u/966348?v=4","gravatar_id":"","url":"https://api.github.com/users/tillahoffmann","html_url":"https://github.com/tillahoffmann","followers_url":"https://api.github.com/users/tillahoffmann/followers","following_url":"https://api.github.com/users/tillahoffmann/following{/other_user}","gists_url":"https://api.github.com/users/tillahoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillahoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillahoffmann/subscriptions","organizations_url":"https://api.github.com/users/tillahoffmann/orgs","repos_url":"https://api.github.com/users/tillahoffmann/repos","events_url":"https://api.github.com/users/tillahoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillahoffmann/received_events","type":"User","site_admin":false},"repo":{"id":55236016,"name":"tensorflow","full_name":"tillahoffmann/tensorflow","owner":{"login":"tillahoffmann","id":966348,"avatar_url":"https://avatars2.githubusercontent.com/u/966348?v=4","gravatar_id":"","url":"https://api.github.com/users/tillahoffmann","html_url":"https://github.com/tillahoffmann","followers_url":"https://api.github.com/users/tillahoffmann/followers","following_url":"https://api.github.com/users/tillahoffmann/following{/other_user}","gists_url":"https://api.github.com/users/tillahoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillahoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillahoffmann/subscriptions","organizations_url":"https://api.github.com/users/tillahoffmann/orgs","repos_url":"https://api.github.com/users/tillahoffmann/repos","events_url":"https://api.github.com/users/tillahoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillahoffmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tillahoffmann/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/tillahoffmann/tensorflow","forks_url":"https://api.github.com/repos/tillahoffmann/tensorflow/forks","keys_url":"https://api.github.com/repos/tillahoffmann/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tillahoffmann/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tillahoffmann/tensorflow/teams","hooks_url":"https://api.github.com/repos/tillahoffmann/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tillahoffmann/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tillahoffmann/tensorflow/events","assignees_url":"https://api.github.com/repos/tillahoffmann/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tillahoffmann/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tillahoffmann/tensorflow/tags","blobs_url":"https://api.github.com/repos/tillahoffmann/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tillahoffmann/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tillahoffmann/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tillahoffmann/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tillahoffmann/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tillahoffmann/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tillahoffmann/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tillahoffmann/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tillahoffmann/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tillahoffmann/tensorflow/subscription","commits_url":"https://api.github.com/repos/tillahoffmann/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tillahoffmann/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tillahoffmann/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tillahoffmann/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tillahoffmann/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tillahoffmann/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tillahoffmann/tensorflow/merges","archive_url":"https://api.github.com/repos/tillahoffmann/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tillahoffmann/tensorflow/downloads","issues_url":"https://api.github.com/repos/tillahoffmann/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tillahoffmann/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tillahoffmann/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tillahoffmann/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tillahoffmann/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tillahoffmann/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tillahoffmann/tensorflow/deployments","created_at":"2016-04-01T13:53:22Z","updated_at":"2017-05-22T11:10:51Z","pushed_at":"2017-10-04T10:01:43Z","git_url":"git://github.com/tillahoffmann/tensorflow.git","ssh_url":"git@github.com:tillahoffmann/tensorflow.git","clone_url":"https://github.com/tillahoffmann/tensorflow.git","svn_url":"https://github.com/tillahoffmann/tensorflow","homepage":"http://tensorflow.org","size":124945,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"b72f1e106e42343dab63bbe55a24023be59d2c19","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2017-10-04T09:43:47Z","pushed_at":"2017-10-04T10:02:11Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"http://tensorflow.org","size":126785,"stargazers_count":71642,"watchers_count":71642,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35384,"mirror_url":null,"open_issues_count":1205,"forks":35384,"open_issues":1205,"watchers":71642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/13239"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/13239"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/13239/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/13239/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/ea026849754d18bed25c14ff7d713d031b75cedc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tillahoffmann"}}