{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/140385545","pull_request_review_id":64452877,"id":140385545,"diff_hunk":"@@ -0,0 +1,526 @@\n+// Copyright 2014 Citra Emulator Project\n+// Licensed under GPLv2 or any later version\n+// Refer to the license.txt file included.\n+\n+#pragma once\n+\n+#include \"common/common_types.h\"\n+\n+namespace Pica {\n+namespace CommandProcessor {\n+\n+struct Command;\n+\n+void TriggerIRQ(const Command&);\n+void TriangleTopology(const Command&);\n+void RestartPrimitive(const Command&);\n+void DefaultAttributes(const Command&);\n+void GpuMode(const Command&);\n+void TriggerCommandBuffer(const Command&);\n+void TriggerDraw(const Command&);\n+void DefaultAttribSetup(const Command&);\n+void UniformBoolGs(const Command&);\n+void UniformBoolVs(const Command&);\n+void UniformIntGs(const Command&);\n+void UniformIntVs(const Command&);\n+void UniformFloatGs(const Command&);\n+void UniformFloatVs(const Command&);\n+void SetWordGs(const Command&);\n+void SetWordVs(const Command&);\n+void SetWordSwizzleGs(const Command&);\n+void SetWordSwizzleVs(const Command&);\n+void LightingLut(const Command&);\n+void FogLut(const Command&);\n+void ProcTexLut(const Command&);\n+\n+typedef void (*CommandAction)(const Command&);\n+void nop(const Command&) {}\n+\n+#define _(id) nop","path":"src/video_core/command_map.h","position":39,"original_position":39,"commit_id":"04350f53dc2ecd830e3b5a144d5dada9ecb7194f","original_commit_id":"04350f53dc2ecd830e3b5a144d5dada9ecb7194f","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"That exists only as a workaround to a bug in the Visual Studio 2015 compiler (said bug may already be fixed in VS 2017). It's the only reason the constants were hardcoded.","created_at":"2017-09-21T23:48:47Z","updated_at":"2017-09-21T23:48:47Z","html_url":"https://github.com/citra-emu/citra/pull/2943#discussion_r140385545","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/2943","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/140385545"},"html":{"href":"https://github.com/citra-emu/citra/pull/2943#discussion_r140385545"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2943"}},"in_reply_to_id":140353101},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/2943","id":142436367,"html_url":"https://github.com/citra-emu/citra/pull/2943","diff_url":"https://github.com/citra-emu/citra/pull/2943.diff","patch_url":"https://github.com/citra-emu/citra/pull/2943.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/2943","number":2943,"state":"open","locked":false,"title":"Extract functions on Command Processor","user":{"login":"huwpascoe","id":1812087,"avatar_url":"https://avatars0.githubusercontent.com/u/1812087?v=4","gravatar_id":"","url":"https://api.github.com/users/huwpascoe","html_url":"https://github.com/huwpascoe","followers_url":"https://api.github.com/users/huwpascoe/followers","following_url":"https://api.github.com/users/huwpascoe/following{/other_user}","gists_url":"https://api.github.com/users/huwpascoe/gists{/gist_id}","starred_url":"https://api.github.com/users/huwpascoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwpascoe/subscriptions","organizations_url":"https://api.github.com/users/huwpascoe/orgs","repos_url":"https://api.github.com/users/huwpascoe/repos","events_url":"https://api.github.com/users/huwpascoe/events{/privacy}","received_events_url":"https://api.github.com/users/huwpascoe/received_events","type":"User","site_admin":false},"body":"Using the fastest method, which turns out to be an array of c-style function pointers (after testing with std::function, etc.)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/citra-emu/citra/2943)\n<!-- Reviewable:end -->\n","created_at":"2017-09-21T20:21:31Z","updated_at":"2017-09-21T23:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd16c6be1e810d64eaf9ee6fc94c3ea4c5558418","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/2943/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/2943/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/2943/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/04350f53dc2ecd830e3b5a144d5dada9ecb7194f","head":{"label":"huwpascoe:perf-2","ref":"perf-2","sha":"04350f53dc2ecd830e3b5a144d5dada9ecb7194f","user":{"login":"huwpascoe","id":1812087,"avatar_url":"https://avatars0.githubusercontent.com/u/1812087?v=4","gravatar_id":"","url":"https://api.github.com/users/huwpascoe","html_url":"https://github.com/huwpascoe","followers_url":"https://api.github.com/users/huwpascoe/followers","following_url":"https://api.github.com/users/huwpascoe/following{/other_user}","gists_url":"https://api.github.com/users/huwpascoe/gists{/gist_id}","starred_url":"https://api.github.com/users/huwpascoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwpascoe/subscriptions","organizations_url":"https://api.github.com/users/huwpascoe/orgs","repos_url":"https://api.github.com/users/huwpascoe/repos","events_url":"https://api.github.com/users/huwpascoe/events{/privacy}","received_events_url":"https://api.github.com/users/huwpascoe/received_events","type":"User","site_admin":false},"repo":{"id":103720007,"name":"citra","full_name":"huwpascoe/citra","owner":{"login":"huwpascoe","id":1812087,"avatar_url":"https://avatars0.githubusercontent.com/u/1812087?v=4","gravatar_id":"","url":"https://api.github.com/users/huwpascoe","html_url":"https://github.com/huwpascoe","followers_url":"https://api.github.com/users/huwpascoe/followers","following_url":"https://api.github.com/users/huwpascoe/following{/other_user}","gists_url":"https://api.github.com/users/huwpascoe/gists{/gist_id}","starred_url":"https://api.github.com/users/huwpascoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwpascoe/subscriptions","organizations_url":"https://api.github.com/users/huwpascoe/orgs","repos_url":"https://api.github.com/users/huwpascoe/repos","events_url":"https://api.github.com/users/huwpascoe/events{/privacy}","received_events_url":"https://api.github.com/users/huwpascoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huwpascoe/citra","description":"A Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/huwpascoe/citra","forks_url":"https://api.github.com/repos/huwpascoe/citra/forks","keys_url":"https://api.github.com/repos/huwpascoe/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huwpascoe/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huwpascoe/citra/teams","hooks_url":"https://api.github.com/repos/huwpascoe/citra/hooks","issue_events_url":"https://api.github.com/repos/huwpascoe/citra/issues/events{/number}","events_url":"https://api.github.com/repos/huwpascoe/citra/events","assignees_url":"https://api.github.com/repos/huwpascoe/citra/assignees{/user}","branches_url":"https://api.github.com/repos/huwpascoe/citra/branches{/branch}","tags_url":"https://api.github.com/repos/huwpascoe/citra/tags","blobs_url":"https://api.github.com/repos/huwpascoe/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huwpascoe/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huwpascoe/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/huwpascoe/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huwpascoe/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/huwpascoe/citra/languages","stargazers_url":"https://api.github.com/repos/huwpascoe/citra/stargazers","contributors_url":"https://api.github.com/repos/huwpascoe/citra/contributors","subscribers_url":"https://api.github.com/repos/huwpascoe/citra/subscribers","subscription_url":"https://api.github.com/repos/huwpascoe/citra/subscription","commits_url":"https://api.github.com/repos/huwpascoe/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/huwpascoe/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/huwpascoe/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/huwpascoe/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/huwpascoe/citra/contents/{+path}","compare_url":"https://api.github.com/repos/huwpascoe/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huwpascoe/citra/merges","archive_url":"https://api.github.com/repos/huwpascoe/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huwpascoe/citra/downloads","issues_url":"https://api.github.com/repos/huwpascoe/citra/issues{/number}","pulls_url":"https://api.github.com/repos/huwpascoe/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/huwpascoe/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/huwpascoe/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huwpascoe/citra/labels{/name}","releases_url":"https://api.github.com/repos/huwpascoe/citra/releases{/id}","deployments_url":"https://api.github.com/repos/huwpascoe/citra/deployments","created_at":"2017-09-16T02:59:25Z","updated_at":"2017-09-16T21:27:08Z","pushed_at":"2017-09-21T20:18:20Z","git_url":"git://github.com/huwpascoe/citra.git","ssh_url":"git@github.com:huwpascoe/citra.git","clone_url":"https://github.com/huwpascoe/citra.git","svn_url":"https://github.com/huwpascoe/citra","homepage":"https://citra-emu.org","size":17010,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"6fc123d67c628ede43e1b970d19fde15c20f61f2","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"A Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2017-09-21T20:22:30Z","pushed_at":"2017-09-21T20:21:38Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":19755,"stargazers_count":3269,"watchers_count":3269,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":787,"mirror_url":null,"open_issues_count":240,"forks":787,"open_issues":240,"watchers":3269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2943"},"html":{"href":"https://github.com/citra-emu/citra/pull/2943"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/2943"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/2943/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2943/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2943/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/04350f53dc2ecd830e3b5a144d5dada9ecb7194f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lioncash"}}