{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/152610368","pull_request_review_id":78498461,"id":152610368,"diff_hunk":"@@ -64,79 +64,82 @@ class Expression\n \n \tstatic Expression ite(Expression _condition, Expression _trueValue, Expression _falseValue)\n \t{\n+\t\tsolAssert(_trueValue.sort == _falseValue.sort, \"\");\n \t\treturn Expression(\"ite\", std::vector<Expression>{\n \t\t\tstd::move(_condition), std::move(_trueValue), std::move(_falseValue)\n-\t\t});\n+\t\t}, _trueValue.sort);\n \t}\n \n \tfriend Expression operator!(Expression _a)\n \t{\n-\t\treturn Expression(\"not\", std::move(_a));\n+\t\treturn Expression(\"not\", std::move(_a), Sort::Bool);\n \t}\n \tfriend Expression operator&&(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"and\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"and\", std::move(_a), std::move(_b), Sort::Bool);\n \t}\n \tfriend Expression operator||(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"or\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"or\", std::move(_a), std::move(_b), Sort::Bool);\n \t}\n \tfriend Expression operator==(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"=\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"=\", std::move(_a), std::move(_b), Sort::Bool);\n \t}\n \tfriend Expression operator!=(Expression _a, Expression _b)\n \t{\n \t\treturn !(std::move(_a) == std::move(_b));\n \t}\n \tfriend Expression operator<(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"<\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"<\", std::move(_a), std::move(_b), Sort::Bool);\n \t}\n \tfriend Expression operator<=(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"<=\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"<=\", std::move(_a), std::move(_b), Sort::Bool);\n \t}\n \tfriend Expression operator>(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\">\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\">\", std::move(_a), std::move(_b), Sort::Bool);\n \t}\n \tfriend Expression operator>=(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\">=\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\">=\", std::move(_a), std::move(_b), Sort::Bool);\n \t}\n \tfriend Expression operator+(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"+\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"+\", std::move(_a), std::move(_b), Sort::Int);\n \t}\n \tfriend Expression operator-(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"-\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"-\", std::move(_a), std::move(_b), Sort::Int);\n \t}\n \tfriend Expression operator*(Expression _a, Expression _b)\n \t{\n-\t\treturn Expression(\"*\", std::move(_a), std::move(_b));\n+\t\treturn Expression(\"*\", std::move(_a), std::move(_b), Sort::Int);\n \t}\n \tExpression operator()(Expression _a) const\n \t{\n+\t\tsolAssert(sort == Sort::IntIntFun, \"Attempted function application to non-function.\");\n \t\tsolAssert(arguments.empty(), \"Attempted function application to non-function.\");","path":"libsolidity/formal/SolverInterface.h","position":97,"original_position":97,"commit_id":"762d591a4755fbabfe8d2556bab10b77ec1d5bb5","original_commit_id":"762d591a4755fbabfe8d2556bab10b77ec1d5bb5","user":{"login":"axic","id":20340,"avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"Could merge these two? Does the second assert make any sense though? Wouldn't it be enough on its own?","created_at":"2017-11-22T16:09:41Z","updated_at":"2017-11-22T16:09:41Z","html_url":"https://github.com/ethereum/solidity/pull/3234#discussion_r152610368","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/3234","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/152610368"},"html":{"href":"https://github.com/ethereum/solidity/pull/3234#discussion_r152610368"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3234"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/3234","id":154166434,"html_url":"https://github.com/ethereum/solidity/pull/3234","diff_url":"https://github.com/ethereum/solidity/pull/3234.diff","patch_url":"https://github.com/ethereum/solidity/pull/3234.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/3234","number":3234,"state":"open","locked":false,"title":"Introduce sorts for smt expressions.","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"This will fix the assertion failures on MacOS. More specifically: It fixes assertion failures related to the smt solver when z3 is not found at build time.\r\n\r\nIt will not fix the tests themselves, because we do not have a way to invoke the smt solver on macos yet.","created_at":"2017-11-22T14:23:14Z","updated_at":"2017-11-22T16:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f174f6220251f69d327b05714ad176a41a7c0f65","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/3234/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/3234/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/3234/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/762d591a4755fbabfe8d2556bab10b77ec1d5bb5","head":{"label":"ethereum:sortsForExpressions","ref":"sortsForExpressions","sha":"762d591a4755fbabfe8d2556bab10b77ec1d5bb5","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2017-11-22T16:06:05Z","pushed_at":"2017-11-22T15:41:21Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"","size":16223,"stargazers_count":2351,"watchers_count":2351,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":702,"mirror_url":null,"archived":false,"open_issues_count":447,"forks":702,"open_issues":447,"watchers":2351,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"ff229ab05a43d113bcd2de79f25caf52017c3486","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2017-11-22T16:06:05Z","pushed_at":"2017-11-22T15:41:21Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"","size":16223,"stargazers_count":2351,"watchers_count":2351,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":702,"mirror_url":null,"archived":false,"open_issues_count":447,"forks":702,"open_issues":447,"watchers":2351,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3234"},"html":{"href":"https://github.com/ethereum/solidity/pull/3234"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/3234"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/3234/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3234/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3234/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/762d591a4755fbabfe8d2556bab10b77ec1d5bb5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"axic"}}