{"action":"created","issue":{"url":"https://api.github.com/repos/NativeScript/android-runtime/issues/842","repository_url":"https://api.github.com/repos/NativeScript/android-runtime","labels_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/842/labels{/name}","comments_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/842/comments","events_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/842/events","html_url":"https://github.com/NativeScript/android-runtime/pull/842","id":255246866,"number":842,"title":"Metadata generator is more tolerable now","user":{"login":"Pip3r4o","id":10464986,"avatar_url":"https://avatars3.githubusercontent.com/u/10464986?v=4","gravatar_id":"","url":"https://api.github.com/users/Pip3r4o","html_url":"https://github.com/Pip3r4o","followers_url":"https://api.github.com/users/Pip3r4o/followers","following_url":"https://api.github.com/users/Pip3r4o/following{/other_user}","gists_url":"https://api.github.com/users/Pip3r4o/gists{/gist_id}","starred_url":"https://api.github.com/users/Pip3r4o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pip3r4o/subscriptions","organizations_url":"https://api.github.com/users/Pip3r4o/orgs","repos_url":"https://api.github.com/users/Pip3r4o/repos","events_url":"https://api.github.com/users/Pip3r4o/events{/privacy}","received_events_url":"https://api.github.com/users/Pip3r4o/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-09-05T11:34:28Z","updated_at":"2017-09-11T08:36:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NativeScript/android-runtime/pulls/842","html_url":"https://github.com/NativeScript/android-runtime/pull/842","diff_url":"https://github.com/NativeScript/android-runtime/pull/842.diff","patch_url":"https://github.com/NativeScript/android-runtime/pull/842.patch"},"body":"Addresses issue https://github.com/NativeScript/android-runtime/issues/832 by making the following small changes:\r\n\r\n- when collecting classes from input jars, do not crash on clashing classes (classes that are already brought in from another library). The assumption here is that the build will crash at earlier point during the java compilation step, and it should not concern the metadata generator.\r\n(e.g. An android library depends on appache http library, but if imported in gradle as a dependency, the class collection logic in the metadata generation would fail, complaining that 3 classes coincide in name - some of the appache http classes are left inside the android sdk packages for whatever legacy reasons they have)\r\n\r\n- when traversing a class's methods/fields, do not skip class if the parameter of a single method is not found in the ClassLoader. Instead continue, and try to generate as much metadata as possible for the class being analyzed."},"comment":{"url":"https://api.github.com/repos/NativeScript/android-runtime/issues/comments/328459082","html_url":"https://github.com/NativeScript/android-runtime/pull/842#issuecomment-328459082","issue_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/842","id":328459082,"user":{"login":"ns-bot","id":8101183,"avatar_url":"https://avatars3.githubusercontent.com/u/8101183?v=4","gravatar_id":"","url":"https://api.github.com/users/ns-bot","html_url":"https://github.com/ns-bot","followers_url":"https://api.github.com/users/ns-bot/followers","following_url":"https://api.github.com/users/ns-bot/following{/other_user}","gists_url":"https://api.github.com/users/ns-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/ns-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ns-bot/subscriptions","organizations_url":"https://api.github.com/users/ns-bot/orgs","repos_url":"https://api.github.com/users/ns-bot/repos","events_url":"https://api.github.com/users/ns-bot/events{/privacy}","received_events_url":"https://api.github.com/users/ns-bot/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T08:36:05Z","updated_at":"2017-09-11T08:36:05Z","author_association":"NONE","body":":green_heart:\n"}}
{"actor":{"display_login":"ns-bot"}}