{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/issues/1892","repository_url":"https://api.github.com/repos/mozilla/thimble.mozilla.org","labels_url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/issues/1892/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/issues/1892/comments","events_url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/issues/1892/events","html_url":"https://github.com/mozilla/thimble.mozilla.org/pull/1892","id":214559137,"number":1892,"title":"Makes sure the adapt method gets called after resizing","user":{"login":"flukeout","id":25212,"avatar_url":"https://avatars3.githubusercontent.com/u/25212?v=3","gravatar_id":"","url":"https://api.github.com/users/flukeout","html_url":"https://github.com/flukeout","followers_url":"https://api.github.com/users/flukeout/followers","following_url":"https://api.github.com/users/flukeout/following{/other_user}","gists_url":"https://api.github.com/users/flukeout/gists{/gist_id}","starred_url":"https://api.github.com/users/flukeout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flukeout/subscriptions","organizations_url":"https://api.github.com/users/flukeout/orgs","repos_url":"https://api.github.com/users/flukeout/repos","events_url":"https://api.github.com/users/flukeout/events{/privacy}","received_events_url":"https://api.github.com/users/flukeout/received_events","type":"User","site_admin":false},"labels":[{"id":425871884,"url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/labels/PR%20%E2%80%93%20Changes%20Requested","name":"PR – Changes Requested","color":"ea5818","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-15T23:45:28Z","updated_at":"2017-03-29T19:27:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/pulls/1892","html_url":"https://github.com/mozilla/thimble.mozilla.org/pull/1892","diff_url":"https://github.com/mozilla/thimble.mozilla.org/pull/1892.diff","patch_url":"https://github.com/mozilla/thimble.mozilla.org/pull/1892.patch"},"body":"The old implementation waits 200ms after adapting the layout before it calls the adapt method again. A lot can happen in that 200ms, so we want to also make sure we call it once after the last UI resize.\r\n\r\nThis feels a bit janky @Pomax so I'm curious about your thoughts.\r\n\r\nThe goal is to call the adapt method frequently, but not more often than 200ms, while also calling it one last time at the end.\r\n\r\nTo test this, resize the windows quickly - the icons should always adapt."},"comment":{"url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/issues/comments/290198948","html_url":"https://github.com/mozilla/thimble.mozilla.org/pull/1892#issuecomment-290198948","issue_url":"https://api.github.com/repos/mozilla/thimble.mozilla.org/issues/1892","id":290198948,"user":{"login":"flukeout","id":25212,"avatar_url":"https://avatars3.githubusercontent.com/u/25212?v=3","gravatar_id":"","url":"https://api.github.com/users/flukeout","html_url":"https://github.com/flukeout","followers_url":"https://api.github.com/users/flukeout/followers","following_url":"https://api.github.com/users/flukeout/following{/other_user}","gists_url":"https://api.github.com/users/flukeout/gists{/gist_id}","starred_url":"https://api.github.com/users/flukeout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flukeout/subscriptions","organizations_url":"https://api.github.com/users/flukeout/orgs","repos_url":"https://api.github.com/users/flukeout/repos","events_url":"https://api.github.com/users/flukeout/events{/privacy}","received_events_url":"https://api.github.com/users/flukeout/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T19:27:18Z","updated_at":"2017-03-29T19:27:18Z","body":"Yeah, it's on my list - prioritizing smaller PRs and contributor stuff at the moment."}}
{"actor":{"display_login":"flukeout"}}