{"action":"created","comment":{"url":"https://api.github.com/repos/amiturgman/secure-communication/pulls/comments/158604803","pull_request_review_id":85444256,"id":158604803,"diff_hunk":"@@ -6,6 +6,49 @@ C. Secrets manager for the communication pipeline - for abstracting the needed s\n \n This project also contains a \"Sample\" directory, to get you started.  \n \n+# Installation\n+1. 'Contracts' contains all of the interfaces\n+2. 'SecuredComm' contains the library implementation. consume it: clone the repository and add the dependency to the library.\n+(later we might release this as a nuget / package).\n+3. Usage examples:\n+\n+## Ethererum node wrapper\n+```\n+            // Create the instance\n+            var ethereumNodeWrapper = new EthereumNodeWrapper(kv, ConfigurationManager.AppSettings[\"EthereumNodeUrl\"]);\n+\n+            // Call methods\n+            var result = await ethereumNodeWrapper.GetPublicAddressAsync(\"0x012345...\");   \n+```\n+\n+## Secrets Manager\n+```\n+            // Create\n+            var secretsMgmnt = new KeyVaultSecretManager(encryptionKeyName, decryptionKeyName, signKeyName, verifyKeyName, publicKv, privateKv);\n+            // Initialize\n+            await secretsMgmnt.Initialize();\n+\n+            // Call methods\n+            secretsMgmnt.Encrypt(msgAsBytes);  \n+```\n+## Communication pipeline\n+```\n+            // The following code enqueues a message to a queue named 'MyQueue'\n+            // Create","path":"README.md","position":32,"original_position":32,"commit_id":"1be21d7a438b1c1e2163d896d93c52ee1e4e43db","original_commit_id":"1be21d7a438b1c1e2163d896d93c52ee1e4e43db","user":{"login":"Ilanak","id":13463870,"avatar_url":"https://avatars2.githubusercontent.com/u/13463870?v=4","gravatar_id":"","url":"https://api.github.com/users/Ilanak","html_url":"https://github.com/Ilanak","followers_url":"https://api.github.com/users/Ilanak/followers","following_url":"https://api.github.com/users/Ilanak/following{/other_user}","gists_url":"https://api.github.com/users/Ilanak/gists{/gist_id}","starred_url":"https://api.github.com/users/Ilanak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ilanak/subscriptions","organizations_url":"https://api.github.com/users/Ilanak/orgs","repos_url":"https://api.github.com/users/Ilanak/repos","events_url":"https://api.github.com/users/Ilanak/events{/privacy}","received_events_url":"https://api.github.com/users/Ilanak/received_events","type":"User","site_admin":false},"body":"consider renaming to \"queue\"","created_at":"2017-12-24T15:45:36Z","updated_at":"2017-12-24T15:45:50Z","html_url":"https://github.com/amiturgman/secure-communication/pull/5#discussion_r158604803","pull_request_url":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/amiturgman/secure-communication/pulls/comments/158604803"},"html":{"href":"https://github.com/amiturgman/secure-communication/pull/5#discussion_r158604803"},"pull_request":{"href":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5","id":160003464,"html_url":"https://github.com/amiturgman/secure-communication/pull/5","diff_url":"https://github.com/amiturgman/secure-communication/pull/5.diff","patch_url":"https://github.com/amiturgman/secure-communication/pull/5.patch","issue_url":"https://api.github.com/repos/amiturgman/secure-communication/issues/5","number":5,"state":"open","locked":false,"title":"Adding usage examples to readme","user":{"login":"eladiw","id":13205761,"avatar_url":"https://avatars0.githubusercontent.com/u/13205761?v=4","gravatar_id":"","url":"https://api.github.com/users/eladiw","html_url":"https://github.com/eladiw","followers_url":"https://api.github.com/users/eladiw/followers","following_url":"https://api.github.com/users/eladiw/following{/other_user}","gists_url":"https://api.github.com/users/eladiw/gists{/gist_id}","starred_url":"https://api.github.com/users/eladiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladiw/subscriptions","organizations_url":"https://api.github.com/users/eladiw/orgs","repos_url":"https://api.github.com/users/eladiw/repos","events_url":"https://api.github.com/users/eladiw/events{/privacy}","received_events_url":"https://api.github.com/users/eladiw/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-24T15:42:36Z","updated_at":"2017-12-24T15:45:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb5f909551424ec09a2e2e2cf58c7df1f911dbfd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5/commits","review_comments_url":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5/comments","review_comment_url":"https://api.github.com/repos/amiturgman/secure-communication/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amiturgman/secure-communication/issues/5/comments","statuses_url":"https://api.github.com/repos/amiturgman/secure-communication/statuses/1be21d7a438b1c1e2163d896d93c52ee1e4e43db","head":{"label":"amiturgman:readmeupdate","ref":"readmeupdate","sha":"1be21d7a438b1c1e2163d896d93c52ee1e4e43db","user":{"login":"amiturgman","id":1033174,"avatar_url":"https://avatars1.githubusercontent.com/u/1033174?v=4","gravatar_id":"","url":"https://api.github.com/users/amiturgman","html_url":"https://github.com/amiturgman","followers_url":"https://api.github.com/users/amiturgman/followers","following_url":"https://api.github.com/users/amiturgman/following{/other_user}","gists_url":"https://api.github.com/users/amiturgman/gists{/gist_id}","starred_url":"https://api.github.com/users/amiturgman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiturgman/subscriptions","organizations_url":"https://api.github.com/users/amiturgman/orgs","repos_url":"https://api.github.com/users/amiturgman/repos","events_url":"https://api.github.com/users/amiturgman/events{/privacy}","received_events_url":"https://api.github.com/users/amiturgman/received_events","type":"User","site_admin":false},"repo":{"id":110434090,"name":"secure-communication","full_name":"amiturgman/secure-communication","owner":{"login":"amiturgman","id":1033174,"avatar_url":"https://avatars1.githubusercontent.com/u/1033174?v=4","gravatar_id":"","url":"https://api.github.com/users/amiturgman","html_url":"https://github.com/amiturgman","followers_url":"https://api.github.com/users/amiturgman/followers","following_url":"https://api.github.com/users/amiturgman/following{/other_user}","gists_url":"https://api.github.com/users/amiturgman/gists{/gist_id}","starred_url":"https://api.github.com/users/amiturgman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiturgman/subscriptions","organizations_url":"https://api.github.com/users/amiturgman/orgs","repos_url":"https://api.github.com/users/amiturgman/repos","events_url":"https://api.github.com/users/amiturgman/events{/privacy}","received_events_url":"https://api.github.com/users/amiturgman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amiturgman/secure-communication","description":"Secure Communication Library Over a Queue","fork":false,"url":"https://api.github.com/repos/amiturgman/secure-communication","forks_url":"https://api.github.com/repos/amiturgman/secure-communication/forks","keys_url":"https://api.github.com/repos/amiturgman/secure-communication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amiturgman/secure-communication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amiturgman/secure-communication/teams","hooks_url":"https://api.github.com/repos/amiturgman/secure-communication/hooks","issue_events_url":"https://api.github.com/repos/amiturgman/secure-communication/issues/events{/number}","events_url":"https://api.github.com/repos/amiturgman/secure-communication/events","assignees_url":"https://api.github.com/repos/amiturgman/secure-communication/assignees{/user}","branches_url":"https://api.github.com/repos/amiturgman/secure-communication/branches{/branch}","tags_url":"https://api.github.com/repos/amiturgman/secure-communication/tags","blobs_url":"https://api.github.com/repos/amiturgman/secure-communication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amiturgman/secure-communication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amiturgman/secure-communication/git/refs{/sha}","trees_url":"https://api.github.com/repos/amiturgman/secure-communication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amiturgman/secure-communication/statuses/{sha}","languages_url":"https://api.github.com/repos/amiturgman/secure-communication/languages","stargazers_url":"https://api.github.com/repos/amiturgman/secure-communication/stargazers","contributors_url":"https://api.github.com/repos/amiturgman/secure-communication/contributors","subscribers_url":"https://api.github.com/repos/amiturgman/secure-communication/subscribers","subscription_url":"https://api.github.com/repos/amiturgman/secure-communication/subscription","commits_url":"https://api.github.com/repos/amiturgman/secure-communication/commits{/sha}","git_commits_url":"https://api.github.com/repos/amiturgman/secure-communication/git/commits{/sha}","comments_url":"https://api.github.com/repos/amiturgman/secure-communication/comments{/number}","issue_comment_url":"https://api.github.com/repos/amiturgman/secure-communication/issues/comments{/number}","contents_url":"https://api.github.com/repos/amiturgman/secure-communication/contents/{+path}","compare_url":"https://api.github.com/repos/amiturgman/secure-communication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amiturgman/secure-communication/merges","archive_url":"https://api.github.com/repos/amiturgman/secure-communication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amiturgman/secure-communication/downloads","issues_url":"https://api.github.com/repos/amiturgman/secure-communication/issues{/number}","pulls_url":"https://api.github.com/repos/amiturgman/secure-communication/pulls{/number}","milestones_url":"https://api.github.com/repos/amiturgman/secure-communication/milestones{/number}","notifications_url":"https://api.github.com/repos/amiturgman/secure-communication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amiturgman/secure-communication/labels{/name}","releases_url":"https://api.github.com/repos/amiturgman/secure-communication/releases{/id}","deployments_url":"https://api.github.com/repos/amiturgman/secure-communication/deployments","created_at":"2017-11-12T13:17:39Z","updated_at":"2017-11-13T14:30:27Z","pushed_at":"2017-12-24T15:42:36Z","git_url":"git://github.com/amiturgman/secure-communication.git","ssh_url":"git@github.com:amiturgman/secure-communication.git","clone_url":"https://github.com/amiturgman/secure-communication.git","svn_url":"https://github.com/amiturgman/secure-communication","homepage":null,"size":204,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"amiturgman:master","ref":"master","sha":"3ada6d426b7fed4154ea629f3bc8ae06b252fddf","user":{"login":"amiturgman","id":1033174,"avatar_url":"https://avatars1.githubusercontent.com/u/1033174?v=4","gravatar_id":"","url":"https://api.github.com/users/amiturgman","html_url":"https://github.com/amiturgman","followers_url":"https://api.github.com/users/amiturgman/followers","following_url":"https://api.github.com/users/amiturgman/following{/other_user}","gists_url":"https://api.github.com/users/amiturgman/gists{/gist_id}","starred_url":"https://api.github.com/users/amiturgman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiturgman/subscriptions","organizations_url":"https://api.github.com/users/amiturgman/orgs","repos_url":"https://api.github.com/users/amiturgman/repos","events_url":"https://api.github.com/users/amiturgman/events{/privacy}","received_events_url":"https://api.github.com/users/amiturgman/received_events","type":"User","site_admin":false},"repo":{"id":110434090,"name":"secure-communication","full_name":"amiturgman/secure-communication","owner":{"login":"amiturgman","id":1033174,"avatar_url":"https://avatars1.githubusercontent.com/u/1033174?v=4","gravatar_id":"","url":"https://api.github.com/users/amiturgman","html_url":"https://github.com/amiturgman","followers_url":"https://api.github.com/users/amiturgman/followers","following_url":"https://api.github.com/users/amiturgman/following{/other_user}","gists_url":"https://api.github.com/users/amiturgman/gists{/gist_id}","starred_url":"https://api.github.com/users/amiturgman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiturgman/subscriptions","organizations_url":"https://api.github.com/users/amiturgman/orgs","repos_url":"https://api.github.com/users/amiturgman/repos","events_url":"https://api.github.com/users/amiturgman/events{/privacy}","received_events_url":"https://api.github.com/users/amiturgman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amiturgman/secure-communication","description":"Secure Communication Library Over a Queue","fork":false,"url":"https://api.github.com/repos/amiturgman/secure-communication","forks_url":"https://api.github.com/repos/amiturgman/secure-communication/forks","keys_url":"https://api.github.com/repos/amiturgman/secure-communication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amiturgman/secure-communication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amiturgman/secure-communication/teams","hooks_url":"https://api.github.com/repos/amiturgman/secure-communication/hooks","issue_events_url":"https://api.github.com/repos/amiturgman/secure-communication/issues/events{/number}","events_url":"https://api.github.com/repos/amiturgman/secure-communication/events","assignees_url":"https://api.github.com/repos/amiturgman/secure-communication/assignees{/user}","branches_url":"https://api.github.com/repos/amiturgman/secure-communication/branches{/branch}","tags_url":"https://api.github.com/repos/amiturgman/secure-communication/tags","blobs_url":"https://api.github.com/repos/amiturgman/secure-communication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amiturgman/secure-communication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amiturgman/secure-communication/git/refs{/sha}","trees_url":"https://api.github.com/repos/amiturgman/secure-communication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amiturgman/secure-communication/statuses/{sha}","languages_url":"https://api.github.com/repos/amiturgman/secure-communication/languages","stargazers_url":"https://api.github.com/repos/amiturgman/secure-communication/stargazers","contributors_url":"https://api.github.com/repos/amiturgman/secure-communication/contributors","subscribers_url":"https://api.github.com/repos/amiturgman/secure-communication/subscribers","subscription_url":"https://api.github.com/repos/amiturgman/secure-communication/subscription","commits_url":"https://api.github.com/repos/amiturgman/secure-communication/commits{/sha}","git_commits_url":"https://api.github.com/repos/amiturgman/secure-communication/git/commits{/sha}","comments_url":"https://api.github.com/repos/amiturgman/secure-communication/comments{/number}","issue_comment_url":"https://api.github.com/repos/amiturgman/secure-communication/issues/comments{/number}","contents_url":"https://api.github.com/repos/amiturgman/secure-communication/contents/{+path}","compare_url":"https://api.github.com/repos/amiturgman/secure-communication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amiturgman/secure-communication/merges","archive_url":"https://api.github.com/repos/amiturgman/secure-communication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amiturgman/secure-communication/downloads","issues_url":"https://api.github.com/repos/amiturgman/secure-communication/issues{/number}","pulls_url":"https://api.github.com/repos/amiturgman/secure-communication/pulls{/number}","milestones_url":"https://api.github.com/repos/amiturgman/secure-communication/milestones{/number}","notifications_url":"https://api.github.com/repos/amiturgman/secure-communication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amiturgman/secure-communication/labels{/name}","releases_url":"https://api.github.com/repos/amiturgman/secure-communication/releases{/id}","deployments_url":"https://api.github.com/repos/amiturgman/secure-communication/deployments","created_at":"2017-11-12T13:17:39Z","updated_at":"2017-11-13T14:30:27Z","pushed_at":"2017-12-24T15:42:36Z","git_url":"git://github.com/amiturgman/secure-communication.git","ssh_url":"git@github.com:amiturgman/secure-communication.git","clone_url":"https://github.com/amiturgman/secure-communication.git","svn_url":"https://github.com/amiturgman/secure-communication","homepage":null,"size":204,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5"},"html":{"href":"https://github.com/amiturgman/secure-communication/pull/5"},"issue":{"href":"https://api.github.com/repos/amiturgman/secure-communication/issues/5"},"comments":{"href":"https://api.github.com/repos/amiturgman/secure-communication/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/amiturgman/secure-communication/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amiturgman/secure-communication/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/amiturgman/secure-communication/statuses/1be21d7a438b1c1e2163d896d93c52ee1e4e43db"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Ilanak"}}