{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/154796729","pull_request_review_id":81014130,"id":154796729,"diff_hunk":"@@ -8,6 +8,17 @@ function hydrateUserSettings(userSettings) {\n     .reduce((acc, { key, userValue }) => ({ ...acc, [key]: { userValue } }), {});\n }\n \n+/**\n+ * Invalid value for UiSetting\n+ * @class InvalidValudError\n+ */\n+export class InvalidValueError extends Error {","path":"src/ui/ui_settings/ui_settings_service.js","position":8,"original_position":8,"commit_id":"e4841457936e2dad4f7b03e137e4d6d5ea60fec9","original_commit_id":"e4841457936e2dad4f7b03e137e4d6d5ea60fec9","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars1.githubusercontent.com/u/1329312?v=4","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"body":"We have a fairly established convention for handling service-specific errors. See: \r\n\r\n -\r\n [SavedObjectsClient/errors](https://github.com/elastic/kibana/blob/131b63c0f8b294083f77a141016e053c2a19d811/src/server/saved_objects/client/lib/errors.js)\r\n - [SavedObjectsClient#errors](https://github.com/elastic/kibana/blob/131b63c0f8b294083f77a141016e053c2a19d811/src/server/saved_objects/client/saved_objects_client.js#L94-L95)","created_at":"2017-12-04T22:36:35Z","updated_at":"2017-12-04T22:36:35Z","html_url":"https://github.com/elastic/kibana/pull/15342#discussion_r154796729","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/15342","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/154796729"},"html":{"href":"https://github.com/elastic/kibana/pull/15342#discussion_r154796729"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15342"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/15342","id":155897117,"html_url":"https://github.com/elastic/kibana/pull/15342","diff_url":"https://github.com/elastic/kibana/pull/15342.diff","patch_url":"https://github.com/elastic/kibana/pull/15342.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/15342","number":15342,"state":"open","locked":false,"title":"Advanced Settings - Image Input","user":{"login":"kobelb","id":627123,"avatar_url":"https://avatars0.githubusercontent.com/u/627123?v=4","gravatar_id":"","url":"https://api.github.com/users/kobelb","html_url":"https://github.com/kobelb","followers_url":"https://api.github.com/users/kobelb/followers","following_url":"https://api.github.com/users/kobelb/following{/other_user}","gists_url":"https://api.github.com/users/kobelb/gists{/gist_id}","starred_url":"https://api.github.com/users/kobelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobelb/subscriptions","organizations_url":"https://api.github.com/users/kobelb/orgs","repos_url":"https://api.github.com/users/kobelb/repos","events_url":"https://api.github.com/users/kobelb/events{/privacy}","received_events_url":"https://api.github.com/users/kobelb/received_events","type":"User","site_admin":false},"body":"Adds an \"image\" advanced setting type. The maximum size is currently hard-coded for all images to 200kB, we could potentially make this configurable and allow the uiSetting configuration to specify this value, but I figured 200kB was reasonable for the time being. The `inputBaseSixtyFour` only supports a single file for the time being, and will throw an Error that results in a \"fatal error\" if it's given multiple files.\r\n\r\nI used RxJs/Observables for the `inputBaseSixtyFour` directive so that we could abort the FileReader when the `change` event is fired before the reading has finished.","created_at":"2017-12-01T16:05:33Z","updated_at":"2017-12-04T22:36:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab44969caf9242aa586700ebe4d1f9a173bbdf37","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars3.githubusercontent.com/u/16563603?v=4","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/15342/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/15342/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/15342/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/e4841457936e2dad4f7b03e137e4d6d5ea60fec9","head":{"label":"kobelb:reporting-logo","ref":"reporting-logo","sha":"e4841457936e2dad4f7b03e137e4d6d5ea60fec9","user":{"login":"kobelb","id":627123,"avatar_url":"https://avatars0.githubusercontent.com/u/627123?v=4","gravatar_id":"","url":"https://api.github.com/users/kobelb","html_url":"https://github.com/kobelb","followers_url":"https://api.github.com/users/kobelb/followers","following_url":"https://api.github.com/users/kobelb/following{/other_user}","gists_url":"https://api.github.com/users/kobelb/gists{/gist_id}","starred_url":"https://api.github.com/users/kobelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobelb/subscriptions","organizations_url":"https://api.github.com/users/kobelb/orgs","repos_url":"https://api.github.com/users/kobelb/repos","events_url":"https://api.github.com/users/kobelb/events{/privacy}","received_events_url":"https://api.github.com/users/kobelb/received_events","type":"User","site_admin":false},"repo":{"id":69892470,"name":"kibana","full_name":"kobelb/kibana","owner":{"login":"kobelb","id":627123,"avatar_url":"https://avatars0.githubusercontent.com/u/627123?v=4","gravatar_id":"","url":"https://api.github.com/users/kobelb","html_url":"https://github.com/kobelb","followers_url":"https://api.github.com/users/kobelb/followers","following_url":"https://api.github.com/users/kobelb/following{/other_user}","gists_url":"https://api.github.com/users/kobelb/gists{/gist_id}","starred_url":"https://api.github.com/users/kobelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobelb/subscriptions","organizations_url":"https://api.github.com/users/kobelb/orgs","repos_url":"https://api.github.com/users/kobelb/repos","events_url":"https://api.github.com/users/kobelb/events{/privacy}","received_events_url":"https://api.github.com/users/kobelb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kobelb/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/kobelb/kibana","forks_url":"https://api.github.com/repos/kobelb/kibana/forks","keys_url":"https://api.github.com/repos/kobelb/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kobelb/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kobelb/kibana/teams","hooks_url":"https://api.github.com/repos/kobelb/kibana/hooks","issue_events_url":"https://api.github.com/repos/kobelb/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/kobelb/kibana/events","assignees_url":"https://api.github.com/repos/kobelb/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/kobelb/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/kobelb/kibana/tags","blobs_url":"https://api.github.com/repos/kobelb/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kobelb/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kobelb/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/kobelb/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kobelb/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/kobelb/kibana/languages","stargazers_url":"https://api.github.com/repos/kobelb/kibana/stargazers","contributors_url":"https://api.github.com/repos/kobelb/kibana/contributors","subscribers_url":"https://api.github.com/repos/kobelb/kibana/subscribers","subscription_url":"https://api.github.com/repos/kobelb/kibana/subscription","commits_url":"https://api.github.com/repos/kobelb/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/kobelb/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/kobelb/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/kobelb/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/kobelb/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/kobelb/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kobelb/kibana/merges","archive_url":"https://api.github.com/repos/kobelb/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kobelb/kibana/downloads","issues_url":"https://api.github.com/repos/kobelb/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/kobelb/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/kobelb/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/kobelb/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kobelb/kibana/labels{/name}","releases_url":"https://api.github.com/repos/kobelb/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/kobelb/kibana/deployments","created_at":"2016-10-03T17:12:25Z","updated_at":"2016-10-03T17:12:31Z","pushed_at":"2017-12-04T19:31:04Z","git_url":"git://github.com/kobelb/kibana.git","ssh_url":"git@github.com:kobelb/kibana.git","clone_url":"https://github.com/kobelb/kibana.git","svn_url":"https://github.com/kobelb/kibana","homepage":"https://www.elastic.co/products/kibana","size":299594,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"97e5e2538c3875f9a3eac87f8923b0e33ca007d3","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-12-04T18:32:06Z","pushed_at":"2017-12-04T22:31:55Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":297487,"stargazers_count":8453,"watchers_count":8453,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3245,"mirror_url":null,"archived":false,"open_issues_count":2109,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3245,"open_issues":2109,"watchers":8453,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15342"},"html":{"href":"https://github.com/elastic/kibana/pull/15342"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/15342"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/15342/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15342/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/15342/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/e4841457936e2dad4f7b03e137e4d6d5ea60fec9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spalger"}}