{"action":"created","comment":{"url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/comments/138945160","pull_request_review_id":62810325,"id":138945160,"diff_hunk":"@@ -0,0 +1,27 @@\n+{\n+  \"name\": \"in-toto-layout-tool\",\n+  \"version\": \"1.0.0-beta.0\",\n+  \"description\": \"A Flask-based web app that helps to create a custom in-toto software supply chain layout\",\n+  \"repository\": {\n+    \"type\": \"git\",\n+    \"url\": \"git+https://github.com/in-toto/layout-web-tool.git\"","path":"package.json","position":null,"original_position":7,"commit_id":"6f8e13d7f4f38c81d04999c9f6cc097315370bb9","original_commit_id":"1bbbc531cc1cf30981677beaa575461b7f6761fe","user":{"login":"lukpueh","id":589324,"avatar_url":"https://avatars2.githubusercontent.com/u/589324?v=4","gravatar_id":"","url":"https://api.github.com/users/lukpueh","html_url":"https://github.com/lukpueh","followers_url":"https://api.github.com/users/lukpueh/followers","following_url":"https://api.github.com/users/lukpueh/following{/other_user}","gists_url":"https://api.github.com/users/lukpueh/gists{/gist_id}","starred_url":"https://api.github.com/users/lukpueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukpueh/subscriptions","organizations_url":"https://api.github.com/users/lukpueh/orgs","repos_url":"https://api.github.com/users/lukpueh/repos","events_url":"https://api.github.com/users/lukpueh/events{/privacy}","received_events_url":"https://api.github.com/users/lukpueh/received_events","type":"User","site_admin":false},"body":"Let's not waste too much time with this: 6f8e13d7f4f38c81d04999c9f6cc097315370bb9","created_at":"2017-09-14T16:30:24Z","updated_at":"2017-09-14T16:30:24Z","html_url":"https://github.com/in-toto/layout-web-tool/pull/14#discussion_r138945160","pull_request_url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/comments/138945160"},"html":{"href":"https://github.com/in-toto/layout-web-tool/pull/14#discussion_r138945160"},"pull_request":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14"}},"in_reply_to_id":137051487},"pull_request":{"url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14","id":138286330,"html_url":"https://github.com/in-toto/layout-web-tool/pull/14","diff_url":"https://github.com/in-toto/layout-web-tool/pull/14.diff","patch_url":"https://github.com/in-toto/layout-web-tool/pull/14.patch","issue_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues/14","number":14,"state":"open","locked":false,"title":"Initial PR (complete layout tool)","user":{"login":"lukpueh","id":589324,"avatar_url":"https://avatars2.githubusercontent.com/u/589324?v=4","gravatar_id":"","url":"https://api.github.com/users/lukpueh","html_url":"https://github.com/lukpueh","followers_url":"https://api.github.com/users/lukpueh/followers","following_url":"https://api.github.com/users/lukpueh/following{/other_user}","gists_url":"https://api.github.com/users/lukpueh/gists{/gist_id}","starred_url":"https://api.github.com/users/lukpueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukpueh/subscriptions","organizations_url":"https://api.github.com/users/lukpueh/orgs","repos_url":"https://api.github.com/users/lukpueh/repos","events_url":"https://api.github.com/users/lukpueh/events{/privacy}","received_events_url":"https://api.github.com/users/lukpueh/received_events","type":"User","site_admin":false},"body":"This PR contains an entire [Flask](http://flask.pocoo.org/)-based web app, used to serve a website that guides through the creation of an [*in-toto layout*](https://github.com/in-toto/in-toto#layout). \r\n\r\nA deployed instance of the web-app can be found at [in-toto.engineering.nyu.edu](https://in-toto.engineering.nyu.edu).\r\n\r\nPlease pardon the humongous PR, but given the workflow for this project it wouldn't have made a lot of sense to incrementally submit PRs. I thought about chopping up the diff to artificially create smaller-sized, themed PRs, but I guess that's not really worth the effort and just messes up the commit history.\r\n\r\nConsider reviewing file by file. It does not have to be a single person who reviews everything. Just pick a group of files from below and notify the others that you are reviewing. And don't hesitate to ask me if anything is unclear.\r\n\r\nBefore starting to review, take a quick look at the [issue tracker](https://github.com/in-toto/layout-web-tool/issues) and also consider comments in the file headers and inline `FIXME`s/`TODO`s. There is no need to point out issues that I'm already aware of. \r\n\r\n\r\n---\r\n\r\n**Readme**\r\nPlease review for completeness and conciseness. It would be great if you could\r\nalso try to set up the app locally using this Readme.\r\n- [ ] README.md\r\n\r\n**Monolithic back-end script**\r\nContains all back-end code. Please review thoroughly!\r\n- [ ] wizard.py\r\n\r\n**Monolithic front-end script**\r\nContains all non-third-party front-end code (mostly UI-related). Please review thoroughly!\r\n- [ ] static/js/main.js\r\n\r\n**Standalone layout creation module**\r\nA module used by the back-end script (view: `download_layout`) to create the actual in-toto layout.\r\nPlease review thoroughly!\r\n- [ ] reverse_layout.py\r\n\r\n**Front-end content and style**\r\nA quick look at these files should be enough\r\n- [ ] static/js/main.scss\r\n- [ ] templates/*.html\r\n\r\n**Front- and back-end dependency management**\r\nA quick look at these files should be enough\r\n- [ ] gulpfile.js\r\n- [ ] package.json\r\n- [ ] requirements.txt\r\n\r\n**Miscellaneous**\r\nA quick look at these files should be enough\r\n- [ ] LICENSE (check if conform with our license guidelines)\r\n- [ ] tooldb.py (don't review, the tool collection will change substantially)\r\n- [ ] wizard.wsgi (this is just an example, maybe take it out of vcs?)\r\n- [ ] .gitignore\r\n\r\n","created_at":"2017-08-29T21:17:54Z","updated_at":"2017-09-14T16:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"831036ea3eda84105fbe92684d8d1a18bc4ea82e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vladimir-v-diaz","id":3520883,"avatar_url":"https://avatars2.githubusercontent.com/u/3520883?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-v-diaz","html_url":"https://github.com/vladimir-v-diaz","followers_url":"https://api.github.com/users/vladimir-v-diaz/followers","following_url":"https://api.github.com/users/vladimir-v-diaz/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-v-diaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-v-diaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-v-diaz/subscriptions","organizations_url":"https://api.github.com/users/vladimir-v-diaz/orgs","repos_url":"https://api.github.com/users/vladimir-v-diaz/repos","events_url":"https://api.github.com/users/vladimir-v-diaz/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-v-diaz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14/commits","review_comments_url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14/comments","review_comment_url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues/14/comments","statuses_url":"https://api.github.com/repos/in-toto/layout-web-tool/statuses/6f8e13d7f4f38c81d04999c9f6cc097315370bb9","head":{"label":"in-toto:wizard-beta","ref":"wizard-beta","sha":"6f8e13d7f4f38c81d04999c9f6cc097315370bb9","user":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars0.githubusercontent.com/u/22891761?v=4","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"repo":{"id":81597552,"name":"layout-web-tool","full_name":"in-toto/layout-web-tool","owner":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars0.githubusercontent.com/u/22891761?v=4","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/in-toto/layout-web-tool","description":"A flask app that helps to create, modify and visualize in-toto layouts.","fork":false,"url":"https://api.github.com/repos/in-toto/layout-web-tool","forks_url":"https://api.github.com/repos/in-toto/layout-web-tool/forks","keys_url":"https://api.github.com/repos/in-toto/layout-web-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/in-toto/layout-web-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/in-toto/layout-web-tool/teams","hooks_url":"https://api.github.com/repos/in-toto/layout-web-tool/hooks","issue_events_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues/events{/number}","events_url":"https://api.github.com/repos/in-toto/layout-web-tool/events","assignees_url":"https://api.github.com/repos/in-toto/layout-web-tool/assignees{/user}","branches_url":"https://api.github.com/repos/in-toto/layout-web-tool/branches{/branch}","tags_url":"https://api.github.com/repos/in-toto/layout-web-tool/tags","blobs_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/in-toto/layout-web-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/in-toto/layout-web-tool/languages","stargazers_url":"https://api.github.com/repos/in-toto/layout-web-tool/stargazers","contributors_url":"https://api.github.com/repos/in-toto/layout-web-tool/contributors","subscribers_url":"https://api.github.com/repos/in-toto/layout-web-tool/subscribers","subscription_url":"https://api.github.com/repos/in-toto/layout-web-tool/subscription","commits_url":"https://api.github.com/repos/in-toto/layout-web-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/in-toto/layout-web-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/in-toto/layout-web-tool/contents/{+path}","compare_url":"https://api.github.com/repos/in-toto/layout-web-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/in-toto/layout-web-tool/merges","archive_url":"https://api.github.com/repos/in-toto/layout-web-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/in-toto/layout-web-tool/downloads","issues_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues{/number}","pulls_url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/in-toto/layout-web-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/in-toto/layout-web-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/in-toto/layout-web-tool/labels{/name}","releases_url":"https://api.github.com/repos/in-toto/layout-web-tool/releases{/id}","deployments_url":"https://api.github.com/repos/in-toto/layout-web-tool/deployments","created_at":"2017-02-10T19:06:08Z","updated_at":"2017-07-25T20:12:27Z","pushed_at":"2017-09-14T16:29:19Z","git_url":"git://github.com/in-toto/layout-web-tool.git","ssh_url":"git@github.com:in-toto/layout-web-tool.git","clone_url":"https://github.com/in-toto/layout-web-tool.git","svn_url":"https://github.com/in-toto/layout-web-tool","homepage":null,"size":3237,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":28,"forks":1,"open_issues":28,"watchers":0,"default_branch":"develop"}},"base":{"label":"in-toto:develop","ref":"develop","sha":"d18ea35b535216b0252f6fcf690dafca54a5470c","user":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars0.githubusercontent.com/u/22891761?v=4","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"repo":{"id":81597552,"name":"layout-web-tool","full_name":"in-toto/layout-web-tool","owner":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars0.githubusercontent.com/u/22891761?v=4","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/in-toto/layout-web-tool","description":"A flask app that helps to create, modify and visualize in-toto layouts.","fork":false,"url":"https://api.github.com/repos/in-toto/layout-web-tool","forks_url":"https://api.github.com/repos/in-toto/layout-web-tool/forks","keys_url":"https://api.github.com/repos/in-toto/layout-web-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/in-toto/layout-web-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/in-toto/layout-web-tool/teams","hooks_url":"https://api.github.com/repos/in-toto/layout-web-tool/hooks","issue_events_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues/events{/number}","events_url":"https://api.github.com/repos/in-toto/layout-web-tool/events","assignees_url":"https://api.github.com/repos/in-toto/layout-web-tool/assignees{/user}","branches_url":"https://api.github.com/repos/in-toto/layout-web-tool/branches{/branch}","tags_url":"https://api.github.com/repos/in-toto/layout-web-tool/tags","blobs_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/in-toto/layout-web-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/in-toto/layout-web-tool/languages","stargazers_url":"https://api.github.com/repos/in-toto/layout-web-tool/stargazers","contributors_url":"https://api.github.com/repos/in-toto/layout-web-tool/contributors","subscribers_url":"https://api.github.com/repos/in-toto/layout-web-tool/subscribers","subscription_url":"https://api.github.com/repos/in-toto/layout-web-tool/subscription","commits_url":"https://api.github.com/repos/in-toto/layout-web-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/in-toto/layout-web-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/in-toto/layout-web-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/in-toto/layout-web-tool/contents/{+path}","compare_url":"https://api.github.com/repos/in-toto/layout-web-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/in-toto/layout-web-tool/merges","archive_url":"https://api.github.com/repos/in-toto/layout-web-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/in-toto/layout-web-tool/downloads","issues_url":"https://api.github.com/repos/in-toto/layout-web-tool/issues{/number}","pulls_url":"https://api.github.com/repos/in-toto/layout-web-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/in-toto/layout-web-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/in-toto/layout-web-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/in-toto/layout-web-tool/labels{/name}","releases_url":"https://api.github.com/repos/in-toto/layout-web-tool/releases{/id}","deployments_url":"https://api.github.com/repos/in-toto/layout-web-tool/deployments","created_at":"2017-02-10T19:06:08Z","updated_at":"2017-07-25T20:12:27Z","pushed_at":"2017-09-14T16:29:19Z","git_url":"git://github.com/in-toto/layout-web-tool.git","ssh_url":"git@github.com:in-toto/layout-web-tool.git","clone_url":"https://github.com/in-toto/layout-web-tool.git","svn_url":"https://github.com/in-toto/layout-web-tool","homepage":null,"size":3237,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":28,"forks":1,"open_issues":28,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14"},"html":{"href":"https://github.com/in-toto/layout-web-tool/pull/14"},"issue":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/issues/14"},"comments":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/in-toto/layout-web-tool/statuses/6f8e13d7f4f38c81d04999c9f6cc097315370bb9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lukpueh"}}