{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/118801117","pull_request_review_id":40632195,"id":118801117,"diff_hunk":"@@ -566,6 +566,11 @@ function createBaseCustomElementClass(win) {\n \n       /** @private {?./layout-delay-meter.LayoutDelayMeter} */\n       this.layoutDelayMeter_ = null;\n+\n+      if (this['whenUpgradedToCustomElement']) {\n+        this['whenUpgradedToCustomElement'](this);\n+        this['whenUpgradedToCustomElement'] = null;","path":"src/custom-element.js","position":7,"original_position":7,"commit_id":"efe8925b888804bd632e88ec1f39313302c0fcde","original_commit_id":"efe8925b888804bd632e88ec1f39313302c0fcde","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars3.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"body":"Agree. Probably better to clear the promise out.","created_at":"2017-05-26T22:40:48Z","updated_at":"2017-05-26T22:40:48Z","html_url":"https://github.com/ampproject/amphtml/pull/9542#discussion_r118801117","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/9542","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/118801117"},"html":{"href":"https://github.com/ampproject/amphtml/pull/9542#discussion_r118801117"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/9542"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/9542","id":122353685,"html_url":"https://github.com/ampproject/amphtml/pull/9542","diff_url":"https://github.com/ampproject/amphtml/pull/9542.diff","patch_url":"https://github.com/ampproject/amphtml/pull/9542.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/9542","number":9542,"state":"open","locked":false,"title":"Provide a helper method waiting for HTMLElement upgrade to CustomElement","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars3.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"body":"For #9126 ","created_at":"2017-05-25T01:06:21Z","updated_at":"2017-05-26T22:40:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0975460387bb9ba098db743e2dae92fc1b95d305","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/9542/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/9542/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/9542/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/efe8925b888804bd632e88ec1f39313302c0fcde","head":{"label":"zhouyx:wait-for-customElement","ref":"wait-for-customElement","sha":"efe8925b888804bd632e88ec1f39313302c0fcde","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars3.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"repo":{"id":55454453,"name":"amphtml","full_name":"zhouyx/amphtml","owner":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars3.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhouyx/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/zhouyx/amphtml","forks_url":"https://api.github.com/repos/zhouyx/amphtml/forks","keys_url":"https://api.github.com/repos/zhouyx/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhouyx/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhouyx/amphtml/teams","hooks_url":"https://api.github.com/repos/zhouyx/amphtml/hooks","issue_events_url":"https://api.github.com/repos/zhouyx/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/zhouyx/amphtml/events","assignees_url":"https://api.github.com/repos/zhouyx/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/zhouyx/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/zhouyx/amphtml/tags","blobs_url":"https://api.github.com/repos/zhouyx/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhouyx/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhouyx/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhouyx/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhouyx/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/zhouyx/amphtml/languages","stargazers_url":"https://api.github.com/repos/zhouyx/amphtml/stargazers","contributors_url":"https://api.github.com/repos/zhouyx/amphtml/contributors","subscribers_url":"https://api.github.com/repos/zhouyx/amphtml/subscribers","subscription_url":"https://api.github.com/repos/zhouyx/amphtml/subscription","commits_url":"https://api.github.com/repos/zhouyx/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhouyx/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhouyx/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhouyx/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhouyx/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/zhouyx/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhouyx/amphtml/merges","archive_url":"https://api.github.com/repos/zhouyx/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhouyx/amphtml/downloads","issues_url":"https://api.github.com/repos/zhouyx/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/zhouyx/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/zhouyx/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/zhouyx/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhouyx/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/zhouyx/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/zhouyx/amphtml/deployments","created_at":"2016-04-05T00:10:42Z","updated_at":"2016-04-05T00:10:45Z","pushed_at":"2017-05-26T21:59:02Z","git_url":"git://github.com/zhouyx/amphtml.git","ssh_url":"git@github.com:zhouyx/amphtml.git","clone_url":"https://github.com/zhouyx/amphtml.git","svn_url":"https://github.com/zhouyx/amphtml","homepage":"https://ampproject.org","size":253546,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"75151065723b11e7dee23a4b4de210fc819fd4ba","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars0.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars0.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-05-26T19:25:46Z","pushed_at":"2017-05-26T22:32:07Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":253626,"stargazers_count":10107,"watchers_count":10107,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1747,"mirror_url":null,"open_issues_count":852,"forks":1747,"open_issues":852,"watchers":10107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/9542"},"html":{"href":"https://github.com/ampproject/amphtml/pull/9542"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/9542"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/9542/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/9542/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/9542/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/efe8925b888804bd632e88ec1f39313302c0fcde"}}}}
{"actor":{"display_login":"dvoytenko"}}