{"action":"created","comment":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/126307780","pull_request_review_id":48780236,"id":126307780,"diff_hunk":"@@ -52,6 +52,7 @@ bool CAveragedPerceptron::train_machine(CFeatures* data)\n \tASSERT(num_vec==train_labels.vlen)\n \tSGVector<float64_t> w(num_feat);\n \tfloat64_t* tmp_w=SG_MALLOC(float64_t, num_feat);\n+\tmemset(tmp_w, 0, sizeof(float64_t)*num_feat);","path":"src/shogun/classifier/AveragedPerceptron.cpp","position":4,"original_position":4,"commit_id":"7bcbc5fd4033cdef67886a72c563060a9aa46fca","original_commit_id":"7bcbc5fd4033cdef67886a72c563060a9aa46fca","user":{"login":"karlnapf","id":699071,"avatar_url":"https://avatars3.githubusercontent.com/u/699071?v=3","gravatar_id":"","url":"https://api.github.com/users/karlnapf","html_url":"https://github.com/karlnapf","followers_url":"https://api.github.com/users/karlnapf/followers","following_url":"https://api.github.com/users/karlnapf/following{/other_user}","gists_url":"https://api.github.com/users/karlnapf/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnapf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnapf/subscriptions","organizations_url":"https://api.github.com/users/karlnapf/orgs","repos_url":"https://api.github.com/users/karlnapf/repos","events_url":"https://api.github.com/users/karlnapf/events{/privacy}","received_events_url":"https://api.github.com/users/karlnapf/received_events","type":"User","site_admin":false},"body":"@micmn thanks for doing that.\r\nBTW we should remove such code from Shogun, allocation of memory, memset, all that. We have more high level constructs that do all this\r\n@MikeLing might be a nice one for you to change such code to using `SGVector`","created_at":"2017-07-09T15:20:10Z","updated_at":"2017-07-09T15:20:10Z","html_url":"https://github.com/shogun-toolbox/shogun/pull/3918#discussion_r126307780","pull_request_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918","_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/126307780"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/3918#discussion_r126307780"},"pull_request":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918"}}},"pull_request":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918","id":129562090,"html_url":"https://github.com/shogun-toolbox/shogun/pull/3918","diff_url":"https://github.com/shogun-toolbox/shogun/pull/3918.diff","patch_url":"https://github.com/shogun-toolbox/shogun/pull/3918.patch","issue_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3918","number":3918,"state":"closed","locked":false,"title":"Fix uninitialized memory read in AveragedPerceptron","user":{"login":"micmn","id":10615374,"avatar_url":"https://avatars1.githubusercontent.com/u/10615374?v=3","gravatar_id":"","url":"https://api.github.com/users/micmn","html_url":"https://github.com/micmn","followers_url":"https://api.github.com/users/micmn/followers","following_url":"https://api.github.com/users/micmn/following{/other_user}","gists_url":"https://api.github.com/users/micmn/gists{/gist_id}","starred_url":"https://api.github.com/users/micmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmn/subscriptions","organizations_url":"https://api.github.com/users/micmn/orgs","repos_url":"https://api.github.com/users/micmn/repos","events_url":"https://api.github.com/users/micmn/events{/privacy}","received_events_url":"https://api.github.com/users/micmn/received_events","type":"User","site_admin":false},"body":"Once merged FreeBSD build on buildbot should be fine.","created_at":"2017-07-09T12:14:31Z","updated_at":"2017-07-09T15:20:10Z","closed_at":"2017-07-09T12:32:12Z","merged_at":"2017-07-09T12:32:12Z","merge_commit_sha":"5e5ebb03b5718bed970c2b719356173696e49750","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918/commits","review_comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918/comments","review_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3918/comments","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/7bcbc5fd4033cdef67886a72c563060a9aa46fca","head":{"label":"micmn:feature/averaged-perceptron-uninitialized-read","ref":"feature/averaged-perceptron-uninitialized-read","sha":"7bcbc5fd4033cdef67886a72c563060a9aa46fca","user":{"login":"micmn","id":10615374,"avatar_url":"https://avatars1.githubusercontent.com/u/10615374?v=3","gravatar_id":"","url":"https://api.github.com/users/micmn","html_url":"https://github.com/micmn","followers_url":"https://api.github.com/users/micmn/followers","following_url":"https://api.github.com/users/micmn/following{/other_user}","gists_url":"https://api.github.com/users/micmn/gists{/gist_id}","starred_url":"https://api.github.com/users/micmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmn/subscriptions","organizations_url":"https://api.github.com/users/micmn/orgs","repos_url":"https://api.github.com/users/micmn/repos","events_url":"https://api.github.com/users/micmn/events{/privacy}","received_events_url":"https://api.github.com/users/micmn/received_events","type":"User","site_admin":false},"repo":{"id":80613923,"name":"shogun","full_name":"micmn/shogun","owner":{"login":"micmn","id":10615374,"avatar_url":"https://avatars1.githubusercontent.com/u/10615374?v=3","gravatar_id":"","url":"https://api.github.com/users/micmn","html_url":"https://github.com/micmn","followers_url":"https://api.github.com/users/micmn/followers","following_url":"https://api.github.com/users/micmn/following{/other_user}","gists_url":"https://api.github.com/users/micmn/gists{/gist_id}","starred_url":"https://api.github.com/users/micmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmn/subscriptions","organizations_url":"https://api.github.com/users/micmn/orgs","repos_url":"https://api.github.com/users/micmn/repos","events_url":"https://api.github.com/users/micmn/events{/privacy}","received_events_url":"https://api.github.com/users/micmn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micmn/shogun","description":"The Shogun Machine Learning Toolbox (Source Code)","fork":true,"url":"https://api.github.com/repos/micmn/shogun","forks_url":"https://api.github.com/repos/micmn/shogun/forks","keys_url":"https://api.github.com/repos/micmn/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micmn/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micmn/shogun/teams","hooks_url":"https://api.github.com/repos/micmn/shogun/hooks","issue_events_url":"https://api.github.com/repos/micmn/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/micmn/shogun/events","assignees_url":"https://api.github.com/repos/micmn/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/micmn/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/micmn/shogun/tags","blobs_url":"https://api.github.com/repos/micmn/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micmn/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micmn/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/micmn/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micmn/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/micmn/shogun/languages","stargazers_url":"https://api.github.com/repos/micmn/shogun/stargazers","contributors_url":"https://api.github.com/repos/micmn/shogun/contributors","subscribers_url":"https://api.github.com/repos/micmn/shogun/subscribers","subscription_url":"https://api.github.com/repos/micmn/shogun/subscription","commits_url":"https://api.github.com/repos/micmn/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/micmn/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/micmn/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/micmn/shogun/issues/comments{/number}","contents_url":"https://api.github.com/repos/micmn/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/micmn/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micmn/shogun/merges","archive_url":"https://api.github.com/repos/micmn/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micmn/shogun/downloads","issues_url":"https://api.github.com/repos/micmn/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/micmn/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/micmn/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/micmn/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micmn/shogun/labels{/name}","releases_url":"https://api.github.com/repos/micmn/shogun/releases{/id}","deployments_url":"https://api.github.com/repos/micmn/shogun/deployments","created_at":"2017-02-01T11:28:30Z","updated_at":"2017-02-01T11:28:39Z","pushed_at":"2017-07-09T12:33:21Z","git_url":"git://github.com/micmn/shogun.git","ssh_url":"git@github.com:micmn/shogun.git","clone_url":"https://github.com/micmn/shogun.git","svn_url":"https://github.com/micmn/shogun","homepage":"http://www.shogun-toolbox.org","size":62672,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"shogun-toolbox:develop","ref":"develop","sha":"6a11ab23d26e032e7f926f1c22dd8b7866b210cf","user":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars2.githubusercontent.com/u/690673?v=3","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":1555094,"name":"shogun","full_name":"shogun-toolbox/shogun","owner":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars2.githubusercontent.com/u/690673?v=3","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shogun-toolbox/shogun","description":"The Shogun Machine Learning Toolbox (Source Code)","fork":false,"url":"https://api.github.com/repos/shogun-toolbox/shogun","forks_url":"https://api.github.com/repos/shogun-toolbox/shogun/forks","keys_url":"https://api.github.com/repos/shogun-toolbox/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shogun-toolbox/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shogun-toolbox/shogun/teams","hooks_url":"https://api.github.com/repos/shogun-toolbox/shogun/hooks","issue_events_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/shogun-toolbox/shogun/events","assignees_url":"https://api.github.com/repos/shogun-toolbox/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/shogun-toolbox/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/tags","blobs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/shogun-toolbox/shogun/languages","stargazers_url":"https://api.github.com/repos/shogun-toolbox/shogun/stargazers","contributors_url":"https://api.github.com/repos/shogun-toolbox/shogun/contributors","subscribers_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscribers","subscription_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscription","commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/comments{/number}","contents_url":"https://api.github.com/repos/shogun-toolbox/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/shogun-toolbox/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shogun-toolbox/shogun/merges","archive_url":"https://api.github.com/repos/shogun-toolbox/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shogun-toolbox/shogun/downloads","issues_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/shogun-toolbox/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/shogun-toolbox/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shogun-toolbox/shogun/labels{/name}","releases_url":"https://api.github.com/repos/shogun-toolbox/shogun/releases{/id}","deployments_url":"https://api.github.com/repos/shogun-toolbox/shogun/deployments","created_at":"2011-04-01T10:44:32Z","updated_at":"2017-07-09T11:57:08Z","pushed_at":"2017-07-09T12:32:12Z","git_url":"git://github.com/shogun-toolbox/shogun.git","ssh_url":"git@github.com:shogun-toolbox/shogun.git","clone_url":"https://github.com/shogun-toolbox/shogun.git","svn_url":"https://github.com/shogun-toolbox/shogun","homepage":"http://shogun.ml","size":62609,"stargazers_count":1463,"watchers_count":1463,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":738,"mirror_url":null,"open_issues_count":489,"forks":738,"open_issues":489,"watchers":1463,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/3918"},"issue":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3918"},"comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3918/comments"},"review_comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918/comments"},"review_comment":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3918/commits"},"statuses":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/7bcbc5fd4033cdef67886a72c563060a9aa46fca"}}}}
{"actor":{"display_login":"karlnapf"}}