{"action":"created","issue":{"url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/444","repository_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core","labels_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/444/labels{/name}","comments_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/444/comments","events_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/444/events","html_url":"https://github.com/mupen64plus/mupen64plus-core/pull/444","id":266646877,"number":444,"title":"Re-work the way VI interrupts are timed","user":{"login":"loganmc10","id":848146,"avatar_url":"https://avatars0.githubusercontent.com/u/848146?v=4","gravatar_id":"","url":"https://api.github.com/users/loganmc10","html_url":"https://github.com/loganmc10","followers_url":"https://api.github.com/users/loganmc10/followers","following_url":"https://api.github.com/users/loganmc10/following{/other_user}","gists_url":"https://api.github.com/users/loganmc10/gists{/gist_id}","starred_url":"https://api.github.com/users/loganmc10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganmc10/subscriptions","organizations_url":"https://api.github.com/users/loganmc10/orgs","repos_url":"https://api.github.com/users/loganmc10/repos","events_url":"https://api.github.com/users/loganmc10/events{/privacy}","received_events_url":"https://api.github.com/users/loganmc10/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-10-18T21:24:09Z","updated_at":"2017-12-15T14:02:01Z","closed_at":"2017-10-19T03:42:53Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/444","html_url":"https://github.com/mupen64plus/mupen64plus-core/pull/444","diff_url":"https://github.com/mupen64plus/mupen64plus-core/pull/444.diff","patch_url":"https://github.com/mupen64plus/mupen64plus-core/pull/444.patch"},"body":"A VI interrupt should happen when VI_CURRENT_REG = VI_V_INTR_REG. VI_CURRENT_REG basically has no meaning unless VI_V_SYNC_REG is set. Therefore no interrupt should be triggered until VI_V_SYNC_REG is set.\r\n\r\nSo, this removes the more hackish method we currently use of just kicking off the VI's when the game starts, and replaces it with this method:\r\n\r\nThe first VI is triggered when VI_V_SYNC_REG has a nonzero value written to it.\r\n\r\nBenefits:\r\n\r\n- Indiana Jones used to not boot with CountPerOp=1 (if no save file existed), now it does\r\n- Both BattleTanx (U) games needed CountPerOp=3 to boot, now they don't\r\n\r\nI think this shows that this is probably a more accurate way to kick off the VI's. I tested a few games, including the usual suspects like Pokemon Puzzle League and didn't see any regressions."},"comment":{"url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/comments/352012812","html_url":"https://github.com/mupen64plus/mupen64plus-core/pull/444#issuecomment-352012812","issue_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/444","id":352012812,"user":{"login":"Gillou68310","id":2852068,"avatar_url":"https://avatars0.githubusercontent.com/u/2852068?v=4","gravatar_id":"","url":"https://api.github.com/users/Gillou68310","html_url":"https://github.com/Gillou68310","followers_url":"https://api.github.com/users/Gillou68310/followers","following_url":"https://api.github.com/users/Gillou68310/following{/other_user}","gists_url":"https://api.github.com/users/Gillou68310/gists{/gist_id}","starred_url":"https://api.github.com/users/Gillou68310/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gillou68310/subscriptions","organizations_url":"https://api.github.com/users/Gillou68310/orgs","repos_url":"https://api.github.com/users/Gillou68310/repos","events_url":"https://api.github.com/users/Gillou68310/events{/privacy}","received_events_url":"https://api.github.com/users/Gillou68310/received_events","type":"User","site_admin":false},"created_at":"2017-12-15T14:02:01Z","updated_at":"2017-12-15T14:02:01Z","author_association":"MEMBER","body":"> Is it really that long for you? I don't really notice it.\r\n\r\nWhen reverting this commit I went from 10 sec waiting to instant boot in WDC. I just tested again so I'm pretty sure it's not related to any other plugin update ;-)\r\n\r\nAlso I'm not talking about reverting this commit because I agree with what it addresses. I would rather try to find a non intrusive workaround in order to bypass the startup delay."}}
{"actor":{"display_login":"Gillou68310"}}