{"action":"created","issue":{"url":"https://api.github.com/repos/coala/coala/issues/3680","repository_url":"https://api.github.com/repos/coala/coala","labels_url":"https://api.github.com/repos/coala/coala/issues/3680/labels{/name}","comments_url":"https://api.github.com/repos/coala/coala/issues/3680/comments","events_url":"https://api.github.com/repos/coala/coala/issues/3680/events","html_url":"https://github.com/coala/coala/pull/3680","id":204959264,"number":3680,"title":"Add ShellCommandResult for accessing return codes","user":{"login":"userzimmermann","id":2088633,"avatar_url":"https://avatars.githubusercontent.com/u/2088633?v=3","gravatar_id":"","url":"https://api.github.com/users/userzimmermann","html_url":"https://github.com/userzimmermann","followers_url":"https://api.github.com/users/userzimmermann/followers","following_url":"https://api.github.com/users/userzimmermann/following{/other_user}","gists_url":"https://api.github.com/users/userzimmermann/gists{/gist_id}","starred_url":"https://api.github.com/users/userzimmermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/userzimmermann/subscriptions","organizations_url":"https://api.github.com/users/userzimmermann/orgs","repos_url":"https://api.github.com/users/userzimmermann/repos","events_url":"https://api.github.com/users/userzimmermann/events{/privacy}","received_events_url":"https://api.github.com/users/userzimmermann/received_events","type":"User","site_admin":false},"labels":[{"id":141036774,"url":"https://api.github.com/repos/coala/coala/labels/process/pending%20review","name":"process/pending review","color":"bfe5bf","default":false},{"id":293861057,"url":"https://api.github.com/repos/coala/coala/labels/size/M","name":"size/M","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":{"login":"userzimmermann","id":2088633,"avatar_url":"https://avatars.githubusercontent.com/u/2088633?v=3","gravatar_id":"","url":"https://api.github.com/users/userzimmermann","html_url":"https://github.com/userzimmermann","followers_url":"https://api.github.com/users/userzimmermann/followers","following_url":"https://api.github.com/users/userzimmermann/following{/other_user}","gists_url":"https://api.github.com/users/userzimmermann/gists{/gist_id}","starred_url":"https://api.github.com/users/userzimmermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/userzimmermann/subscriptions","organizations_url":"https://api.github.com/users/userzimmermann/orgs","repos_url":"https://api.github.com/users/userzimmermann/repos","events_url":"https://api.github.com/users/userzimmermann/events{/privacy}","received_events_url":"https://api.github.com/users/userzimmermann/received_events","type":"User","site_admin":false},"assignees":[{"login":"userzimmermann","id":2088633,"avatar_url":"https://avatars.githubusercontent.com/u/2088633?v=3","gravatar_id":"","url":"https://api.github.com/users/userzimmermann","html_url":"https://github.com/userzimmermann","followers_url":"https://api.github.com/users/userzimmermann/followers","following_url":"https://api.github.com/users/userzimmermann/following{/other_user}","gists_url":"https://api.github.com/users/userzimmermann/gists{/gist_id}","starred_url":"https://api.github.com/users/userzimmermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/userzimmermann/subscriptions","organizations_url":"https://api.github.com/users/userzimmermann/orgs","repos_url":"https://api.github.com/users/userzimmermann/repos","events_url":"https://api.github.com/users/userzimmermann/events{/privacy}","received_events_url":"https://api.github.com/users/userzimmermann/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-02-02T18:38:27Z","updated_at":"2017-02-02T19:40:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coala/coala/pulls/3680","html_url":"https://github.com/coala/coala/pull/3680","diff_url":"https://github.com/coala/coala/pull/3680.diff","patch_url":"https://github.com/coala/coala/pull/3680.patch"},"body":"`@linter` bears can produce wrong results when the external linting tools fail, which can't be checked with the current `coalib.misc.Shell` API. No chance to check the `returncode` of the process created by `run_shell_command`.\r\n\r\nThis is most probably also the reason for https://github.com/coala/coala-bears/issues/1235\r\n\r\nCurrently `run_shell_command` only returns the `(stdout, stderr)` tuple from `Popen.communicate`. I wrapped that in a backwards-compatible `tuple`-derived `ShellCommandResult` class which additionally stores the `Popen` instance and has a `.code` property to easily check the return code of the process."},"comment":{"url":"https://api.github.com/repos/coala/coala/issues/comments/277060391","html_url":"https://github.com/coala/coala/pull/3680#issuecomment-277060391","issue_url":"https://api.github.com/repos/coala/coala/issues/3680","id":277060391,"user":{"login":"userzimmermann","id":2088633,"avatar_url":"https://avatars.githubusercontent.com/u/2088633?v=3","gravatar_id":"","url":"https://api.github.com/users/userzimmermann","html_url":"https://github.com/userzimmermann","followers_url":"https://api.github.com/users/userzimmermann/followers","following_url":"https://api.github.com/users/userzimmermann/following{/other_user}","gists_url":"https://api.github.com/users/userzimmermann/gists{/gist_id}","starred_url":"https://api.github.com/users/userzimmermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/userzimmermann/subscriptions","organizations_url":"https://api.github.com/users/userzimmermann/orgs","repos_url":"https://api.github.com/users/userzimmermann/repos","events_url":"https://api.github.com/users/userzimmermann/events{/privacy}","received_events_url":"https://api.github.com/users/userzimmermann/received_events","type":"User","site_admin":false},"created_at":"2017-02-02T19:40:36Z","updated_at":"2017-02-02T19:40:36Z","body":"@Makman2 `run_shell_command` is also directly used in certain bears :/"}}
{"actor":{"display_login":"userzimmermann"}}