{"action":"closed","number":633,"pull_request":{"url":"https://api.github.com/repos/rails/webpacker/pulls/633","id":135269412,"html_url":"https://github.com/rails/webpacker/pull/633","diff_url":"https://github.com/rails/webpacker/pull/633.diff","patch_url":"https://github.com/rails/webpacker/pull/633.patch","issue_url":"https://api.github.com/repos/rails/webpacker/issues/633","number":633,"state":"closed","locked":false,"title":"Allow blank public_output_path","user":{"login":"alexchee","id":337455,"avatar_url":"https://avatars0.githubusercontent.com/u/337455?v=4","gravatar_id":"","url":"https://api.github.com/users/alexchee","html_url":"https://github.com/alexchee","followers_url":"https://api.github.com/users/alexchee/followers","following_url":"https://api.github.com/users/alexchee/following{/other_user}","gists_url":"https://api.github.com/users/alexchee/gists{/gist_id}","starred_url":"https://api.github.com/users/alexchee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexchee/subscriptions","organizations_url":"https://api.github.com/users/alexchee/orgs","repos_url":"https://api.github.com/users/alexchee/repos","events_url":"https://api.github.com/users/alexchee/events{/privacy}","received_events_url":"https://api.github.com/users/alexchee/received_events","type":"User","site_admin":false},"body":"If `public_output_path` is an empty string `public_output_path: ''`, all the packed assets would be prefixed with an extra slash (ex. `https://HOST//service-worker.js`. \r\n\r\nThis change would allow public_output_path to be at the root of the host, by applying the outer slash removal on final formatPublicPath to remove the extra slash.\r\n\r\nI was running into an issue trying to hook a service worker into the root path of the site to work on other URLs within the site. This might be useful for others doing the same.","created_at":"2017-08-11T05:30:41Z","updated_at":"2017-08-13T17:02:01Z","closed_at":"2017-08-13T17:02:01Z","merged_at":null,"merge_commit_sha":"c5900c107cc580aa7bee846b1992ef4d4dd5232f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/webpacker/pulls/633/commits","review_comments_url":"https://api.github.com/repos/rails/webpacker/pulls/633/comments","review_comment_url":"https://api.github.com/repos/rails/webpacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/webpacker/issues/633/comments","statuses_url":"https://api.github.com/repos/rails/webpacker/statuses/18c1762cd668504ee5542814db42b31a99146ae5","head":{"label":"alexchee:allow_root_public_output_path","ref":"allow_root_public_output_path","sha":"18c1762cd668504ee5542814db42b31a99146ae5","user":{"login":"alexchee","id":337455,"avatar_url":"https://avatars0.githubusercontent.com/u/337455?v=4","gravatar_id":"","url":"https://api.github.com/users/alexchee","html_url":"https://github.com/alexchee","followers_url":"https://api.github.com/users/alexchee/followers","following_url":"https://api.github.com/users/alexchee/following{/other_user}","gists_url":"https://api.github.com/users/alexchee/gists{/gist_id}","starred_url":"https://api.github.com/users/alexchee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexchee/subscriptions","organizations_url":"https://api.github.com/users/alexchee/orgs","repos_url":"https://api.github.com/users/alexchee/repos","events_url":"https://api.github.com/users/alexchee/events{/privacy}","received_events_url":"https://api.github.com/users/alexchee/received_events","type":"User","site_admin":false},"repo":{"id":99993913,"name":"webpacker","full_name":"alexchee/webpacker","owner":{"login":"alexchee","id":337455,"avatar_url":"https://avatars0.githubusercontent.com/u/337455?v=4","gravatar_id":"","url":"https://api.github.com/users/alexchee","html_url":"https://github.com/alexchee","followers_url":"https://api.github.com/users/alexchee/followers","following_url":"https://api.github.com/users/alexchee/following{/other_user}","gists_url":"https://api.github.com/users/alexchee/gists{/gist_id}","starred_url":"https://api.github.com/users/alexchee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexchee/subscriptions","organizations_url":"https://api.github.com/users/alexchee/orgs","repos_url":"https://api.github.com/users/alexchee/repos","events_url":"https://api.github.com/users/alexchee/events{/privacy}","received_events_url":"https://api.github.com/users/alexchee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexchee/webpacker","description":"Use Webpack to manage app-like JavaScript modules in Rails","fork":true,"url":"https://api.github.com/repos/alexchee/webpacker","forks_url":"https://api.github.com/repos/alexchee/webpacker/forks","keys_url":"https://api.github.com/repos/alexchee/webpacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexchee/webpacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexchee/webpacker/teams","hooks_url":"https://api.github.com/repos/alexchee/webpacker/hooks","issue_events_url":"https://api.github.com/repos/alexchee/webpacker/issues/events{/number}","events_url":"https://api.github.com/repos/alexchee/webpacker/events","assignees_url":"https://api.github.com/repos/alexchee/webpacker/assignees{/user}","branches_url":"https://api.github.com/repos/alexchee/webpacker/branches{/branch}","tags_url":"https://api.github.com/repos/alexchee/webpacker/tags","blobs_url":"https://api.github.com/repos/alexchee/webpacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexchee/webpacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexchee/webpacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexchee/webpacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexchee/webpacker/statuses/{sha}","languages_url":"https://api.github.com/repos/alexchee/webpacker/languages","stargazers_url":"https://api.github.com/repos/alexchee/webpacker/stargazers","contributors_url":"https://api.github.com/repos/alexchee/webpacker/contributors","subscribers_url":"https://api.github.com/repos/alexchee/webpacker/subscribers","subscription_url":"https://api.github.com/repos/alexchee/webpacker/subscription","commits_url":"https://api.github.com/repos/alexchee/webpacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexchee/webpacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexchee/webpacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexchee/webpacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexchee/webpacker/contents/{+path}","compare_url":"https://api.github.com/repos/alexchee/webpacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexchee/webpacker/merges","archive_url":"https://api.github.com/repos/alexchee/webpacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexchee/webpacker/downloads","issues_url":"https://api.github.com/repos/alexchee/webpacker/issues{/number}","pulls_url":"https://api.github.com/repos/alexchee/webpacker/pulls{/number}","milestones_url":"https://api.github.com/repos/alexchee/webpacker/milestones{/number}","notifications_url":"https://api.github.com/repos/alexchee/webpacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexchee/webpacker/labels{/name}","releases_url":"https://api.github.com/repos/alexchee/webpacker/releases{/id}","deployments_url":"https://api.github.com/repos/alexchee/webpacker/deployments","created_at":"2017-08-11T05:13:44Z","updated_at":"2017-08-11T05:13:45Z","pushed_at":"2017-08-11T05:21:43Z","git_url":"git://github.com/alexchee/webpacker.git","ssh_url":"git@github.com:alexchee/webpacker.git","clone_url":"https://github.com/alexchee/webpacker.git","svn_url":"https://github.com/alexchee/webpacker","homepage":null,"size":368,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"7d58a67f859b2ff8f5ec62e7c0534d793864a162","user":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":75785147,"name":"webpacker","full_name":"rails/webpacker","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/webpacker","description":"Use Webpack to manage app-like JavaScript modules in Rails","fork":false,"url":"https://api.github.com/repos/rails/webpacker","forks_url":"https://api.github.com/repos/rails/webpacker/forks","keys_url":"https://api.github.com/repos/rails/webpacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/webpacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/webpacker/teams","hooks_url":"https://api.github.com/repos/rails/webpacker/hooks","issue_events_url":"https://api.github.com/repos/rails/webpacker/issues/events{/number}","events_url":"https://api.github.com/repos/rails/webpacker/events","assignees_url":"https://api.github.com/repos/rails/webpacker/assignees{/user}","branches_url":"https://api.github.com/repos/rails/webpacker/branches{/branch}","tags_url":"https://api.github.com/repos/rails/webpacker/tags","blobs_url":"https://api.github.com/repos/rails/webpacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/webpacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/webpacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/webpacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/webpacker/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/webpacker/languages","stargazers_url":"https://api.github.com/repos/rails/webpacker/stargazers","contributors_url":"https://api.github.com/repos/rails/webpacker/contributors","subscribers_url":"https://api.github.com/repos/rails/webpacker/subscribers","subscription_url":"https://api.github.com/repos/rails/webpacker/subscription","commits_url":"https://api.github.com/repos/rails/webpacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/webpacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/webpacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/webpacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/webpacker/contents/{+path}","compare_url":"https://api.github.com/repos/rails/webpacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/webpacker/merges","archive_url":"https://api.github.com/repos/rails/webpacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/webpacker/downloads","issues_url":"https://api.github.com/repos/rails/webpacker/issues{/number}","pulls_url":"https://api.github.com/repos/rails/webpacker/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/webpacker/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/webpacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/webpacker/labels{/name}","releases_url":"https://api.github.com/repos/rails/webpacker/releases{/id}","deployments_url":"https://api.github.com/repos/rails/webpacker/deployments","created_at":"2016-12-07T00:55:03Z","updated_at":"2017-08-13T14:29:42Z","pushed_at":"2017-08-13T16:53:35Z","git_url":"git://github.com/rails/webpacker.git","ssh_url":"git@github.com:rails/webpacker.git","clone_url":"https://github.com/rails/webpacker.git","svn_url":"https://github.com/rails/webpacker","homepage":null,"size":413,"stargazers_count":1983,"watchers_count":1983,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":44,"forks":225,"open_issues":44,"watchers":1983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/webpacker/pulls/633"},"html":{"href":"https://github.com/rails/webpacker/pull/633"},"issue":{"href":"https://api.github.com/repos/rails/webpacker/issues/633"},"comments":{"href":"https://api.github.com/repos/rails/webpacker/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/webpacker/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/webpacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/webpacker/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/rails/webpacker/statuses/18c1762cd668504ee5542814db42b31a99146ae5"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"dhh"}}