{"action":"created","comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/134793915","pull_request_review_id":58128303,"id":134793915,"diff_hunk":"@@ -80,7 +89,7 @@ EXTRA_PCRE2 = @EXTRA_PCRE2@\n # Various flags\n #\n CXXFLAGS = @CXXFLAGS@ $(EXTRA_CXXFLAGS)\n-CPPFLAGS = -DLOCALEDIR=\\\"$(localedir)\\\" -DPREFIX=L\\\"$(prefix)\\\" -DDATADIR=L\\\"$(datadir)\\\" -DSYSCONFDIR=L\\\"$(sysconfdir)\\\" -DBINDIR=L\\\"$(bindir)\\\" -DDOCDIR=L\\\"$(docdir)\\\" -iquote. -iquote./src/\n+CPPFLAGS = -D_UNICODE=1 -DLOCALEDIR=\\\"$(localedir)\\\" -DPREFIX=L\\\"$(prefix)\\\" -DDATADIR=L\\\"$(datadir)\\\" -DSYSCONFDIR=L\\\"$(sysconfdir)\\\" -DBINDIR=L\\\"$(bindir)\\\" -DDOCDIR=L\\\"$(docdir)\\\" -iquote. -iquote./src/","path":"Makefile.in","position":21,"original_position":21,"commit_id":"8c53d3bfeeff50d4a3b40e418f858bbd5c6b18e5","original_commit_id":"8c53d3bfeeff50d4a3b40e418f858bbd5c6b18e5","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars2.githubusercontent.com/u/7545917?v=4","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"body":"Why would we care about that? We don't support building fish as a native Windows app. And this is the only approved mechanism by the MuParser project for enabling wide character support.","created_at":"2017-08-23T15:54:15Z","updated_at":"2017-08-23T15:54:15Z","html_url":"https://github.com/fish-shell/fish-shell/pull/4352#discussion_r134793915","pull_request_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352","_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/134793915"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/4352#discussion_r134793915"},"pull_request":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352"}}},"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352","id":137127388,"html_url":"https://github.com/fish-shell/fish-shell/pull/4352","diff_url":"https://github.com/fish-shell/fish-shell/pull/4352.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/4352.patch","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4352","number":4352,"state":"open","locked":false,"title":"Incorporate MuParser into fish","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars2.githubusercontent.com/u/7545917?v=4","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"body":"This is not a usable math replacement. It is the absolute bare minimum to incorporate the MuParser source and introduce a builtin `math` command. The point of this PR is to ensure no one has any objections before I take the next steps to make this actually useful per issue #3157. In particular I want people to double-check that the licensing is acceptable and that our updated license document is okay.","created_at":"2017-08-23T04:18:02Z","updated_at":"2017-08-23T15:54:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c71d9d4ec2facfedb1a64f031c124c4ac84e271","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/18","html_url":"https://github.com/fish-shell/fish-shell/milestone/18","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/18/labels","id":2597361,"number":18,"title":"fish-3.0","description":"The proposed 3.0 major release of fish. May contain breaking changes.","creator":{"login":"faho","id":5185367,"avatar_url":"https://avatars3.githubusercontent.com/u/5185367?v=4","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":22,"state":"open","created_at":"2017-06-22T00:28:56Z","updated_at":"2017-08-23T04:49:38Z","due_on":"2018-01-10T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352/commits","review_comments_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352/comments","review_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/4352/comments","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/8c53d3bfeeff50d4a3b40e418f858bbd5c6b18e5","head":{"label":"krader1961:muparser","ref":"muparser","sha":"8c53d3bfeeff50d4a3b40e418f858bbd5c6b18e5","user":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars2.githubusercontent.com/u/7545917?v=4","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"repo":{"id":46686263,"name":"fish-shell","full_name":"krader1961/fish-shell","owner":{"login":"krader1961","id":7545917,"avatar_url":"https://avatars2.githubusercontent.com/u/7545917?v=4","gravatar_id":"","url":"https://api.github.com/users/krader1961","html_url":"https://github.com/krader1961","followers_url":"https://api.github.com/users/krader1961/followers","following_url":"https://api.github.com/users/krader1961/following{/other_user}","gists_url":"https://api.github.com/users/krader1961/gists{/gist_id}","starred_url":"https://api.github.com/users/krader1961/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krader1961/subscriptions","organizations_url":"https://api.github.com/users/krader1961/orgs","repos_url":"https://api.github.com/users/krader1961/repos","events_url":"https://api.github.com/users/krader1961/events{/privacy}","received_events_url":"https://api.github.com/users/krader1961/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krader1961/fish-shell","description":"The user-friendly command line shell.","fork":true,"url":"https://api.github.com/repos/krader1961/fish-shell","forks_url":"https://api.github.com/repos/krader1961/fish-shell/forks","keys_url":"https://api.github.com/repos/krader1961/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krader1961/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krader1961/fish-shell/teams","hooks_url":"https://api.github.com/repos/krader1961/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/krader1961/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/krader1961/fish-shell/events","assignees_url":"https://api.github.com/repos/krader1961/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/krader1961/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/krader1961/fish-shell/tags","blobs_url":"https://api.github.com/repos/krader1961/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krader1961/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krader1961/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/krader1961/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krader1961/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/krader1961/fish-shell/languages","stargazers_url":"https://api.github.com/repos/krader1961/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/krader1961/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/krader1961/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/krader1961/fish-shell/subscription","commits_url":"https://api.github.com/repos/krader1961/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/krader1961/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/krader1961/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/krader1961/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/krader1961/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/krader1961/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krader1961/fish-shell/merges","archive_url":"https://api.github.com/repos/krader1961/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krader1961/fish-shell/downloads","issues_url":"https://api.github.com/repos/krader1961/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/krader1961/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/krader1961/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/krader1961/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krader1961/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/krader1961/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/krader1961/fish-shell/deployments","created_at":"2015-11-22T23:46:18Z","updated_at":"2016-08-17T03:04:38Z","pushed_at":"2017-08-23T04:12:11Z","git_url":"git://github.com/krader1961/fish-shell.git","ssh_url":"git@github.com:krader1961/fish-shell.git","clone_url":"https://github.com/krader1961/fish-shell.git","svn_url":"https://github.com/krader1961/fish-shell","homepage":"http://fishshell.com","size":37707,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fish-shell:master","ref":"master","sha":"ba53242b266a0901b176ef7f7de872dc6b5e9956","user":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars0.githubusercontent.com/u/1828073?v=4","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":4279682,"name":"fish-shell","full_name":"fish-shell/fish-shell","owner":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars0.githubusercontent.com/u/1828073?v=4","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fish-shell/fish-shell","description":"The user-friendly command line shell.","fork":false,"url":"https://api.github.com/repos/fish-shell/fish-shell","forks_url":"https://api.github.com/repos/fish-shell/fish-shell/forks","keys_url":"https://api.github.com/repos/fish-shell/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/fish-shell/teams","hooks_url":"https://api.github.com/repos/fish-shell/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/fish-shell/events","assignees_url":"https://api.github.com/repos/fish-shell/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/fish-shell/tags","blobs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/fish-shell/languages","stargazers_url":"https://api.github.com/repos/fish-shell/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/fish-shell/subscription","commits_url":"https://api.github.com/repos/fish-shell/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/fish-shell/merges","archive_url":"https://api.github.com/repos/fish-shell/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/fish-shell/downloads","issues_url":"https://api.github.com/repos/fish-shell/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/fish-shell/fish-shell/deployments","created_at":"2012-05-10T03:00:55Z","updated_at":"2017-08-23T14:20:17Z","pushed_at":"2017-08-23T06:59:12Z","git_url":"git://github.com/fish-shell/fish-shell.git","ssh_url":"git@github.com:fish-shell/fish-shell.git","clone_url":"https://github.com/fish-shell/fish-shell.git","svn_url":"https://github.com/fish-shell/fish-shell","homepage":"http://fishshell.com","size":37528,"stargazers_count":8045,"watchers_count":8045,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":796,"mirror_url":null,"open_issues_count":439,"forks":796,"open_issues":439,"watchers":8045,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/4352"},"issue":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/4352"},"comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/4352/comments"},"review_comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352/comments"},"review_comment":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/4352/commits"},"statuses":{"href":"https://api.github.com/repos/fish-shell/fish-shell/statuses/8c53d3bfeeff50d4a3b40e418f858bbd5c6b18e5"}}}}
{"actor":{"display_login":"krader1961"}}