{"action":"created","comment":{"url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/comments/124710408","pull_request_review_id":47024915,"id":124710408,"diff_hunk":"@@ -27,18 +33,20 @@ publishGlobalConfigurations {\n     groupId = project.groupId\n     versionName = libraryVersion\n \n-    url = \"https://github.com/saantiaguilera/android-api-SecureKeys\"\n+    githubUrl = \"https://github.com/saantiaguilera/android-api-SecureKeys\"\n+\n+    bintrayRepository = 'maven-tests'","path":"build.gradle","position":33,"original_position":33,"commit_id":"f02cd4bd40902fc898dec0419a4d478c1af7a20f","original_commit_id":"f02cd4bd40902fc898dec0419a4d478c1af7a20f","user":{"login":"saantiaguilera","id":9096015,"avatar_url":"https://avatars0.githubusercontent.com/u/9096015?v=3","gravatar_id":"","url":"https://api.github.com/users/saantiaguilera","html_url":"https://github.com/saantiaguilera","followers_url":"https://api.github.com/users/saantiaguilera/followers","following_url":"https://api.github.com/users/saantiaguilera/following{/other_user}","gists_url":"https://api.github.com/users/saantiaguilera/gists{/gist_id}","starred_url":"https://api.github.com/users/saantiaguilera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saantiaguilera/subscriptions","organizations_url":"https://api.github.com/users/saantiaguilera/orgs","repos_url":"https://api.github.com/users/saantiaguilera/repos","events_url":"https://api.github.com/users/saantiaguilera/events{/privacy}","received_events_url":"https://api.github.com/users/saantiaguilera/received_events","type":"User","site_admin":false},"body":"Remove","created_at":"2017-06-29T04:34:58Z","updated_at":"2017-06-29T04:35:58Z","html_url":"https://github.com/saantiaguilera/android-api-SecureKeys/pull/15#discussion_r124710408","pull_request_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/comments/124710408"},"html":{"href":"https://github.com/saantiaguilera/android-api-SecureKeys/pull/15#discussion_r124710408"},"pull_request":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15","id":128059132,"html_url":"https://github.com/saantiaguilera/android-api-SecureKeys/pull/15","diff_url":"https://github.com/saantiaguilera/android-api-SecureKeys/pull/15.diff","patch_url":"https://github.com/saantiaguilera/android-api-SecureKeys/pull/15.patch","issue_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/15","number":15,"state":"open","locked":false,"title":"Defering native compile to the application","user":{"login":"saantiaguilera","id":9096015,"avatar_url":"https://avatars0.githubusercontent.com/u/9096015?v=3","gravatar_id":"","url":"https://api.github.com/users/saantiaguilera","html_url":"https://github.com/saantiaguilera","followers_url":"https://api.github.com/users/saantiaguilera/followers","following_url":"https://api.github.com/users/saantiaguilera/following{/other_user}","gists_url":"https://api.github.com/users/saantiaguilera/gists{/gist_id}","starred_url":"https://api.github.com/users/saantiaguilera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saantiaguilera/subscriptions","organizations_url":"https://api.github.com/users/saantiaguilera/orgs","repos_url":"https://api.github.com/users/saantiaguilera/repos","events_url":"https://api.github.com/users/saantiaguilera/events{/privacy}","received_events_url":"https://api.github.com/users/saantiaguilera/received_events","type":"User","site_admin":false},"body":"## Description \r\n\r\nProposes the aforementioned solution for feature #14 \r\n\r\n## Issues fixed \r\n\r\n- adds feature #14 \r\n\r\n## TODO\r\n\r\n- [x] Create gradle plugin that repackages the aar / unpacks the native files from aar and configures the application for `.so` generation\r\n- [ ] Make native module use (and validate existence?) of generated apt `.h` class\r\n- [ ] Make apt generate `.h` class and save it somewhere findable with cmake\r\n- [ ] Fix CI errors\r\n- [ ] Add tests?\r\n- [ ] Test with abis","created_at":"2017-06-29T02:46:11Z","updated_at":"2017-06-29T04:35:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c25d5d9b1fc629793482cbbe04ea263772993cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15/commits","review_comments_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15/comments","review_comment_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/15/comments","statuses_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/statuses/f02cd4bd40902fc898dec0419a4d478c1af7a20f","head":{"label":"saantiaguilera:feature/sa-defer_native_compile","ref":"feature/sa-defer_native_compile","sha":"f02cd4bd40902fc898dec0419a4d478c1af7a20f","user":{"login":"saantiaguilera","id":9096015,"avatar_url":"https://avatars0.githubusercontent.com/u/9096015?v=3","gravatar_id":"","url":"https://api.github.com/users/saantiaguilera","html_url":"https://github.com/saantiaguilera","followers_url":"https://api.github.com/users/saantiaguilera/followers","following_url":"https://api.github.com/users/saantiaguilera/following{/other_user}","gists_url":"https://api.github.com/users/saantiaguilera/gists{/gist_id}","starred_url":"https://api.github.com/users/saantiaguilera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saantiaguilera/subscriptions","organizations_url":"https://api.github.com/users/saantiaguilera/orgs","repos_url":"https://api.github.com/users/saantiaguilera/repos","events_url":"https://api.github.com/users/saantiaguilera/events{/privacy}","received_events_url":"https://api.github.com/users/saantiaguilera/received_events","type":"User","site_admin":false},"repo":{"id":83336513,"name":"android-api-SecureKeys","full_name":"saantiaguilera/android-api-SecureKeys","owner":{"login":"saantiaguilera","id":9096015,"avatar_url":"https://avatars0.githubusercontent.com/u/9096015?v=3","gravatar_id":"","url":"https://api.github.com/users/saantiaguilera","html_url":"https://github.com/saantiaguilera","followers_url":"https://api.github.com/users/saantiaguilera/followers","following_url":"https://api.github.com/users/saantiaguilera/following{/other_user}","gists_url":"https://api.github.com/users/saantiaguilera/gists{/gist_id}","starred_url":"https://api.github.com/users/saantiaguilera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saantiaguilera/subscriptions","organizations_url":"https://api.github.com/users/saantiaguilera/orgs","repos_url":"https://api.github.com/users/saantiaguilera/repos","events_url":"https://api.github.com/users/saantiaguilera/events{/privacy}","received_events_url":"https://api.github.com/users/saantiaguilera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saantiaguilera/android-api-SecureKeys","description":"Store sensible data in a simple and secure way","fork":false,"url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys","forks_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/forks","keys_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/teams","hooks_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/hooks","issue_events_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/events{/number}","events_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/events","assignees_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/assignees{/user}","branches_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/branches{/branch}","tags_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/tags","blobs_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/statuses/{sha}","languages_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/languages","stargazers_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/stargazers","contributors_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/contributors","subscribers_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/subscribers","subscription_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/subscription","commits_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/contents/{+path}","compare_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/merges","archive_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/downloads","issues_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues{/number}","pulls_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls{/number}","milestones_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/milestones{/number}","notifications_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/labels{/name}","releases_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/releases{/id}","deployments_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/deployments","created_at":"2017-02-27T17:15:20Z","updated_at":"2017-06-29T02:53:49Z","pushed_at":"2017-06-29T04:31:20Z","git_url":"git://github.com/saantiaguilera/android-api-SecureKeys.git","ssh_url":"git@github.com:saantiaguilera/android-api-SecureKeys.git","clone_url":"https://github.com/saantiaguilera/android-api-SecureKeys.git","svn_url":"https://github.com/saantiaguilera/android-api-SecureKeys","homepage":"","size":494,"stargazers_count":166,"watchers_count":166,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":2,"forks":16,"open_issues":2,"watchers":166,"default_branch":"develop"}},"base":{"label":"saantiaguilera:develop","ref":"develop","sha":"1c4192e0a12ab1cce95389e1a7a75d450b542d91","user":{"login":"saantiaguilera","id":9096015,"avatar_url":"https://avatars0.githubusercontent.com/u/9096015?v=3","gravatar_id":"","url":"https://api.github.com/users/saantiaguilera","html_url":"https://github.com/saantiaguilera","followers_url":"https://api.github.com/users/saantiaguilera/followers","following_url":"https://api.github.com/users/saantiaguilera/following{/other_user}","gists_url":"https://api.github.com/users/saantiaguilera/gists{/gist_id}","starred_url":"https://api.github.com/users/saantiaguilera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saantiaguilera/subscriptions","organizations_url":"https://api.github.com/users/saantiaguilera/orgs","repos_url":"https://api.github.com/users/saantiaguilera/repos","events_url":"https://api.github.com/users/saantiaguilera/events{/privacy}","received_events_url":"https://api.github.com/users/saantiaguilera/received_events","type":"User","site_admin":false},"repo":{"id":83336513,"name":"android-api-SecureKeys","full_name":"saantiaguilera/android-api-SecureKeys","owner":{"login":"saantiaguilera","id":9096015,"avatar_url":"https://avatars0.githubusercontent.com/u/9096015?v=3","gravatar_id":"","url":"https://api.github.com/users/saantiaguilera","html_url":"https://github.com/saantiaguilera","followers_url":"https://api.github.com/users/saantiaguilera/followers","following_url":"https://api.github.com/users/saantiaguilera/following{/other_user}","gists_url":"https://api.github.com/users/saantiaguilera/gists{/gist_id}","starred_url":"https://api.github.com/users/saantiaguilera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saantiaguilera/subscriptions","organizations_url":"https://api.github.com/users/saantiaguilera/orgs","repos_url":"https://api.github.com/users/saantiaguilera/repos","events_url":"https://api.github.com/users/saantiaguilera/events{/privacy}","received_events_url":"https://api.github.com/users/saantiaguilera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saantiaguilera/android-api-SecureKeys","description":"Store sensible data in a simple and secure way","fork":false,"url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys","forks_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/forks","keys_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/teams","hooks_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/hooks","issue_events_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/events{/number}","events_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/events","assignees_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/assignees{/user}","branches_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/branches{/branch}","tags_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/tags","blobs_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/statuses/{sha}","languages_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/languages","stargazers_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/stargazers","contributors_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/contributors","subscribers_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/subscribers","subscription_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/subscription","commits_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/contents/{+path}","compare_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/merges","archive_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/downloads","issues_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues{/number}","pulls_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls{/number}","milestones_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/milestones{/number}","notifications_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/labels{/name}","releases_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/releases{/id}","deployments_url":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/deployments","created_at":"2017-02-27T17:15:20Z","updated_at":"2017-06-29T02:53:49Z","pushed_at":"2017-06-29T04:31:20Z","git_url":"git://github.com/saantiaguilera/android-api-SecureKeys.git","ssh_url":"git@github.com:saantiaguilera/android-api-SecureKeys.git","clone_url":"https://github.com/saantiaguilera/android-api-SecureKeys.git","svn_url":"https://github.com/saantiaguilera/android-api-SecureKeys","homepage":"","size":494,"stargazers_count":166,"watchers_count":166,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":2,"forks":16,"open_issues":2,"watchers":166,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15"},"html":{"href":"https://github.com/saantiaguilera/android-api-SecureKeys/pull/15"},"issue":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/15"},"comments":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/saantiaguilera/android-api-SecureKeys/statuses/f02cd4bd40902fc898dec0419a4d478c1af7a20f"}}}}
{"actor":{"display_login":"saantiaguilera"}}