{"action":"created","issue":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1717","repository_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1717/labels{/name}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1717/comments","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1717/events","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1717","id":211241351,"number":1717,"title":"Remove LatLng display","user":{"login":"mmcfarland","id":1014341,"avatar_url":"https://avatars2.githubusercontent.com/u/1014341?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcfarland","html_url":"https://github.com/mmcfarland","followers_url":"https://api.github.com/users/mmcfarland/followers","following_url":"https://api.github.com/users/mmcfarland/following{/other_user}","gists_url":"https://api.github.com/users/mmcfarland/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcfarland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcfarland/subscriptions","organizations_url":"https://api.github.com/users/mmcfarland/orgs","repos_url":"https://api.github.com/users/mmcfarland/repos","events_url":"https://api.github.com/users/mmcfarland/events{/privacy}","received_events_url":"https://api.github.com/users/mmcfarland/received_events","type":"User","site_admin":false},"labels":[{"id":194213367,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars2.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"assignees":[{"login":"kellyi","id":4165523,"avatar_url":"https://avatars2.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-03-01T23:24:52Z","updated_at":"2017-03-01T23:38:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1717","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1717","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1717.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1717.patch"},"body":"## Overview\r\nLatLngControl was added to aide in debugging RWD issues. I've left the control in the src, but removed its addition to the map so that it's not displayed on production.\r\n\r\nSee https://github.com/WikiWatershed/model-my-watershed/commit/a78d8d9ad6b5a0910d96f8980d588811e9af63af\r\n\r\nConnects #1393 \r\n\r\n### Demo\r\n\r\n![screenshot from 2017-03-01 18 22 24](https://cloud.githubusercontent.com/assets/1014341/23485985/0fb4026a-feac-11e6-9b01-8d398d7e01b9.png)\r\n\r\n### Notes\r\n\r\nI believe we didn't want this in production, so I'm targeting that branch, but if it misses the window we can just have in the next release.\r\n\r\n## Testing Instructions\r\n\r\nEnsure that the LatLng control is not displayed in the lower left corner.\r\n"},"comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments/283507783","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1717#issuecomment-283507783","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1717","id":283507783,"user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars2.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"created_at":"2017-03-01T23:38:11Z","updated_at":"2017-03-01T23:38:11Z","body":"Oof, removing the control without the import led to some lint:\r\n\r\n```sh\r\nTASK [model-my-watershed.app : Check for lint] *********************************\r\nWednesday 01 March 2017  18:32:37 -0500 (0:00:06.301)       0:00:55.324 ******* \r\nfatal: [app]: FAILED! => {\"changed\": true, \"cmd\": [\"npm\", \"run\", \"lint\"], \"delta\": \"0:00:03.533195\", \"end\": \"2017-03-01 23:32:43.124348\", \"failed\": true, \"rc\": 1, \"start\": \"2017-03-01 23:32:39.591153\", \"stderr\": \"\\nnpm ERR! Linux 3.13.0-107-generic\\nnpm ERR! argv \\\"node\\\" \\\"/usr/local/bin/npm\\\" \\\"run\\\" \\\"lint\\\"\\nnpm ERR! node v0.10.32\\nnpm ERR! npm  v2.1.17\\nnpm ERR! code ELIFECYCLE\\nnpm ERR! model-my-watershed@0.0.1 lint: `jshint $(find js -name *.js -not -path '*/shim/*')`\\nnpm ERR! Exit status 2\\nnpm ERR! \\nnpm ERR! Failed at the model-my-watershed@0.0.1 lint script 'jshint $(find js -name *.js -not -path '*/shim/*')'.\\nnpm ERR! This is most likely a problem with the model-my-watershed package,\\nnpm ERR! not with npm itself.\\nnpm ERR! Tell the author that this fails on your system:\\nnpm ERR!     jshint $(find js -name *.js -not -path '*/shim/*')\\nnpm ERR! You can get their info via:\\nnpm ERR!     npm owner ls model-my-watershed\\nnpm ERR! There is likely additional logging output above.\\n\\nnpm ERR! Please include the following file with any support request:\\nnpm ERR!     /opt/app/npm-debug.log\", \"stdout\": \"\\n> model-my-watershed@0.0.1 lint /opt/app\\n> jshint $(find js -name *.js -not -path '*/shim/*')\\n\\njs/src/core/views.js: line 22, col 5, 'LatLngControl' is defined but never used.\\n\\n1 error\", \"stdout_lines\": [\"\", \"> model-my-watershed@0.0.1 lint /opt/app\", \"> jshint $(find js -name *.js -not -path '*/shim/*')\", \"\", \"js/src/core/views.js: line 22, col 5, 'LatLngControl' is defined but never used.\", \"\", \"1 error\"], \"warnings\": []}\r\n...ignoring\r\n```"}}
{"actor":{"display_login":"kellyi"}}