{"action":"created","issue":{"url":"https://api.github.com/repos/fonttools/fonttools/issues/916","repository_url":"https://api.github.com/repos/fonttools/fonttools","labels_url":"https://api.github.com/repos/fonttools/fonttools/issues/916/labels{/name}","comments_url":"https://api.github.com/repos/fonttools/fonttools/issues/916/comments","events_url":"https://api.github.com/repos/fonttools/fonttools/issues/916/events","html_url":"https://github.com/fonttools/fonttools/issues/916","id":221033156,"number":916,"title":"Update varLib to current designspace spec","user":{"login":"brawer","id":1527880,"avatar_url":"https://avatars1.githubusercontent.com/u/1527880?v=3","gravatar_id":"","url":"https://api.github.com/users/brawer","html_url":"https://github.com/brawer","followers_url":"https://api.github.com/users/brawer/followers","following_url":"https://api.github.com/users/brawer/following{/other_user}","gists_url":"https://api.github.com/users/brawer/gists{/gist_id}","starred_url":"https://api.github.com/users/brawer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brawer/subscriptions","organizations_url":"https://api.github.com/users/brawer/orgs","repos_url":"https://api.github.com/users/brawer/repos","events_url":"https://api.github.com/users/brawer/events{/privacy}","received_events_url":"https://api.github.com/users/brawer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2017-04-11T18:02:12Z","updated_at":"2017-04-13T22:43:58Z","closed_at":null,"body":"@behdad, does varLib need to be updated to implement the [current designspace spec](https://github.com/LettError/designSpaceDocument/blob/master/README.md)? When building a variable font for [Noto Sans Cherokee](https://github.com/googlei18n/noto-source/raw/master/src/NotoSansCherokee-MM.glyphs) with fontmake, varLib crashes like this:\r\n\r\n```text\r\n  File \"/home/sascha/src/fontmake/Lib/fontmake/font_project.py\", line 200, in build_variable_font\r\n    font, _, _ = varLib.build(designspace_path, finder)\r\n  File \"/home/sascha/src/fontmake/env/src/fonttools/Lib/fontTools/varLib/__init__.py\", line 380, in build\r\n    model = models.VariationModel(master_locs)\r\n  File \"/home/sascha/src/fontmake/env/src/fonttools/Lib/fontTools/varLib/models.py\", line 137, in __init__\r\n    keyFunc = self.getMasterLocationsSortKeyFunc(locations, axisOrder=axisOrder)\r\n  File \"/home/sascha/src/fontmake/env/src/fonttools/Lib/fontTools/varLib/models.py\", line 148, in getMasterLocationsSortKeyFunc\r\n    assert {} in locations, \"Base master not found.\"\r\nAssertionError: Base master not found.\r\n```\r\n\r\nWhen compiling NotoSansCherokee, the `locations` variable has the value `[{u'wght': -1.0}, {u'wght': -1.0}, {u'wght': -0.7}]`, which seems a bit surprising given the generated designspace:\r\n\r\n```xml\r\n<?xml version='1.0' encoding='utf-8'?>\r\n<designspace format=\"3\">\r\n    <axes>\r\n        <axis default=\"400\" maximum=\"900.0\" minimum=\"100.0\" name=\"weight\" tag=\"wght\">\r\n            <map input=\"100.0\" output=\"26\" />\r\n            <map input=\"200.0\" output=\"39\" />\r\n            <map input=\"300.0\" output=\"58\" />\r\n            <map input=\"400.0\" output=\"90\" />\r\n            <map input=\"500.0\" output=\"108\" />\r\n            <map input=\"600.0\" output=\"128\" />\r\n            <map input=\"700.0\" output=\"151\" />\r\n            <map input=\"800.0\" output=\"169\" />\r\n            <map input=\"900.0\" output=\"190\" />\r\n            <labelname xml:lang=\"en\">Weight</labelname>\r\n        </axis>\r\n    </axes>\r\n    <sources>\r\n        <source familyname=\"Noto Sans Cherokee\" filename=\"NotoSansCherokee-Light.ufo\" name=\"Noto Sans Cherokee Light\" stylename=\"Light\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"26.000000\" />\r\n            </location>\r\n        </source>\r\n        <source familyname=\"Noto Sans Cherokee\" filename=\"NotoSansCherokee-Regular.ufo\" name=\"Noto Sans Cherokee Regular\" stylename=\"Regular\">\r\n            <lib copy=\"1\" />\r\n            <groups copy=\"1\" />\r\n            <features copy=\"1\" />\r\n            <info copy=\"1\" />\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"90.000000\" />\r\n            </location>\r\n        </source>\r\n        <source familyname=\"Noto Sans Cherokee\" filename=\"NotoSansCherokee-Bold.ufo\" name=\"Noto Sans Cherokee Bold\" stylename=\"Bold\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"190.000000\" />\r\n            </location>\r\n        </source>\r\n    </sources>\r\n    <instances>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-Thin.ufo\" name=\"Noto Sans Cherokee Thin\" stylename=\"Thin\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"26.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-ExtraLight.ufo\" name=\"Noto Sans Cherokee ExtraLight\" stylename=\"ExtraLight\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"39.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-Light.ufo\" name=\"Noto Sans Cherokee Light\" stylename=\"Light\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"58.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-Regular.ufo\" name=\"Noto Sans Cherokee Regular\" stylename=\"Regular\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"90.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-Medium.ufo\" name=\"Noto Sans Cherokee Medium\" stylename=\"Medium\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"108.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-SemiBold.ufo\" name=\"Noto Sans Cherokee SemiBold\" stylename=\"SemiBold\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"128.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-Bold.ufo\" name=\"Noto Sans Cherokee Bold\" stylename=\"Bold\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"151.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-ExtraBold.ufo\" name=\"Noto Sans Cherokee ExtraBold\" stylename=\"ExtraBold\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"169.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n        <instance familyname=\"Noto Sans Cherokee\" filename=\"../instance_ufo/NotoSansCherokee-Black.ufo\" name=\"Noto Sans Cherokee Black\" stylename=\"Black\">\r\n            <location>\r\n                <dimension name=\"weight\" xvalue=\"190.000000\" />\r\n            </location>\r\n            <info />\r\n            <kerning />\r\n        </instance>\r\n    </instances>\r\n</designspace>\r\n```\r\n\r\nI won’t be able to fix this during the coming days (need to prepare for a Google committee; then a full day of committee meetings; then there’s the Easter holiday in Switzerland). So it would be great if @behdad or somebody else could look into this."},"comment":{"url":"https://api.github.com/repos/fonttools/fonttools/issues/comments/294040501","html_url":"https://github.com/fonttools/fonttools/issues/916#issuecomment-294040501","issue_url":"https://api.github.com/repos/fonttools/fonttools/issues/916","id":294040501,"user":{"login":"behdad","id":142891,"avatar_url":"https://avatars0.githubusercontent.com/u/142891?v=3","gravatar_id":"","url":"https://api.github.com/users/behdad","html_url":"https://github.com/behdad","followers_url":"https://api.github.com/users/behdad/followers","following_url":"https://api.github.com/users/behdad/following{/other_user}","gists_url":"https://api.github.com/users/behdad/gists{/gist_id}","starred_url":"https://api.github.com/users/behdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behdad/subscriptions","organizations_url":"https://api.github.com/users/behdad/orgs","repos_url":"https://api.github.com/users/behdad/repos","events_url":"https://api.github.com/users/behdad/events{/privacy}","received_events_url":"https://api.github.com/users/behdad/received_events","type":"User","site_admin":false},"created_at":"2017-04-13T22:43:58Z","updated_at":"2017-04-13T22:43:58Z","body":"> I can think of a bunch of people - say, Belleve, Lasse, Peter Sikking, Marc Foley, Girish Dalvi - who are keenly interested to follow along. There are countless others.\r\n\r\nYou have to draw the line somewhere.  First: this collaboration would have been impossible without regular day-long face-to-face meetings.  There's no way we could have resolved things in looooooooooong email threads.  When you take that into consideration, then there's a limit to how many people you can get into the same room and design things efficiently.  We somehow managed to not bikeshed a lot and not suffer from groupthink much.  That's a major achievement.  Couldn't have been done with another twenty people in the room IMO.\r\n\r\nStill, let's focus on specific issues.  I haven't seen any proposal or problem statement paper yet.  If you send me one, I'd happily share with the group and relay back the response.\r\n\r\nAlso, note that the group is not actively working on the next steps right now. I talked to Peter and we tentatively agreed to start talking about next steps around ATypI time.  In the meantime everyone is busy finishing their implementations.\r\n\r\n> And then there is the historical record to preserve.\r\n\r\nI like opening up design documents, yes.\r\n"}}
{"actor":{"display_login":"behdad"}}