{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl/issues/20","repository_url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl","labels_url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl/issues/20/comments","events_url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl/issues/20/events","html_url":"https://github.com/JuliaArchive/LegacyStrings.jl/pull/20","id":230671509,"number":20,"title":"Remove string(::Union{ByteString,Char}...) method","user":{"login":"martinholters","id":15785210,"avatar_url":"https://avatars3.githubusercontent.com/u/15785210?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholters","html_url":"https://github.com/martinholters","followers_url":"https://api.github.com/users/martinholters/followers","following_url":"https://api.github.com/users/martinholters/following{/other_user}","gists_url":"https://api.github.com/users/martinholters/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholters/subscriptions","organizations_url":"https://api.github.com/users/martinholters/orgs","repos_url":"https://api.github.com/users/martinholters/repos","events_url":"https://api.github.com/users/martinholters/events{/privacy}","received_events_url":"https://api.github.com/users/martinholters/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-23T11:14:00Z","updated_at":"2017-05-26T13:58:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl/pulls/20","html_url":"https://github.com/JuliaArchive/LegacyStrings.jl/pull/20","diff_url":"https://github.com/JuliaArchive/LegacyStrings.jl/pull/20.diff","patch_url":"https://github.com/JuliaArchive/LegacyStrings.jl/pull/20.patch"},"body":"Given how long #8 has been dormant, I propose this simple fix. For `string(::ByteString...)`, the dedicated method above the deleted one is used. For `string(::Char...)` the method from `Base` is used (that previously was the cause of the ambiguity). For a mixture of `ByteString` and `Char` arguments, the `string(::Any...)` fallback is used, which should give the correct result, but might be a bit slower (though I haven't checked this)."},"comment":{"url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl/issues/comments/304289328","html_url":"https://github.com/JuliaArchive/LegacyStrings.jl/pull/20#issuecomment-304289328","issue_url":"https://api.github.com/repos/JuliaArchive/LegacyStrings.jl/issues/20","id":304289328,"user":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars0.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"created_at":"2017-05-26T13:58:53Z","updated_at":"2017-05-26T13:58:53Z","body":"We shouldn't use invoke. I doubt it is worth optimizing this "}}
{"actor":{"display_login":"stevengj"}}