{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/22861","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/22861/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/22861/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/22861/events","html_url":"https://github.com/Microsoft/vscode/pull/22861","id":215298044,"number":22861,"title":"Feature/part resize: Add key bindings to resize focused view","user":{"login":"cleidigh","id":25272315,"avatar_url":"https://avatars3.githubusercontent.com/u/25272315?v=3","gravatar_id":"","url":"https://api.github.com/users/cleidigh","html_url":"https://github.com/cleidigh","followers_url":"https://api.github.com/users/cleidigh/followers","following_url":"https://api.github.com/users/cleidigh/following{/other_user}","gists_url":"https://api.github.com/users/cleidigh/gists{/gist_id}","starred_url":"https://api.github.com/users/cleidigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleidigh/subscriptions","organizations_url":"https://api.github.com/users/cleidigh/orgs","repos_url":"https://api.github.com/users/cleidigh/repos","events_url":"https://api.github.com/users/cleidigh/events{/privacy}","received_events_url":"https://api.github.com/users/cleidigh/received_events","type":"User","site_admin":false},"labels":[{"id":287229833,"url":"https://api.github.com/repos/Microsoft/vscode/labels/cla-signed","name":"cla-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"bpasero","id":900690,"avatar_url":"https://avatars0.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"assignees":[{"login":"bpasero","id":900690,"avatar_url":"https://avatars0.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/37","html_url":"https://github.com/Microsoft/vscode/milestone/37","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/37/labels","id":2317844,"number":37,"title":"March 2017","description":"","creator":{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars0.githubusercontent.com/u/22350?v=3","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"open_issues":178,"closed_issues":426,"state":"open","created_at":"2017-02-13T07:33:31Z","updated_at":"2017-03-24T21:10:42Z","due_on":"2017-03-31T07:00:00Z","closed_at":null},"comments":14,"created_at":"2017-03-19T21:50:31Z","updated_at":"2017-03-24T21:53:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/22861","html_url":"https://github.com/Microsoft/vscode/pull/22861","diff_url":"https://github.com/Microsoft/vscode/pull/22861.diff","patch_url":"https://github.com/Microsoft/vscode/pull/22861.patch"},"body":"See issue #22645 \r\n\r\n\r\nPart Resize Feature Notes:\r\n\r\n\r\nProposed feature to address issue #22645:\r\n\tKeyboard bindings to expand or contract the main axis of the focused view\r\n\r\nTwo key bindings expand view, contract view\r\n\r\nkey bindings based on part focus (potential reduction of key collisions)\r\n\r\nexpansion or contraction follow main axis of part and orientation\r\n\r\neg sidebar has focus, expand moves border right if on left\r\nor left if sidebar on right\r\neg panel has focus expand moves border up...\r\neditor focus: expand moves right border right (h. layout)\r\ntop up (v. layout) or opposite if single editor\r\napproach still works if a new part eg secondary sidebar\r\nis added in the future\r\n\r\nPossible (mnemonic) key bindings: (probably none assigned by default)\r\n\r\n[expand part]: ctrl+alt+shift+ >\r\n[contract part]: ctrl+alt+shift+ <\r\n\r\n[expand part]: ctrl+alt+shift+ x\r\n[contract part]: ctrl+alt+shift+ c\r\n\r\n[expand part]: ctrl+alt+shift+ )\r\n[contract part]: ctrl+alt+shift+ (\r\n\r\n[restore default part size]: ctrl+alt+shift+ d\r\n[restore default part size]: ctrl+alt+shift+ r\r\n\r\nPotential Future Issues:\r\n\r\nA part with no \"primary axis\" (expanding contract ambiguous)\r\n\r\nMain file work:\r\n\r\nMain file, follows toggleSideBarVisibility.ts design approach\r\n- workbench command registrations\r\n- action functions\r\n\r\n.\\src\\vs\\workbench\\browser\\actions\\resizePart.ts\r\n\r\nWorkbench Support Functions\r\n- set up per Part\r\n- access to workbench layout\r\n.\\src\\vs\\workbench\\electron-browser\\workbench.ts\r\n\r\nLayout Support Functions\r\n- adjust main access dimensions pre- layout call\r\n- possible reset to default option\r\n.\\src\\vs\\workbench\\browser\\layout.ts\r\n\r\nThe prototype implementation sports resize\r\nof the sidebar, the panel and one editor.\r\n\r\nAfter looking more into the code base as well\r\nas the navigation contribution by @misoguy\r\nI think some files need to be moved around.\r\nmy first implementation was based on toggleSideBarVisibility\r\nbut I think the more recent code  add\r\nthe commands to actions.ts\r\n\r\nThe next step is to flush out support for the editors\r\nwhere more than one is visible. and re- factor\r\nper suggestion input.\r\n\r\nThanks for considering..."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/289152186","html_url":"https://github.com/Microsoft/vscode/pull/22861#issuecomment-289152186","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/22861","id":289152186,"user":{"login":"cleidigh","id":25272315,"avatar_url":"https://avatars3.githubusercontent.com/u/25272315?v=3","gravatar_id":"","url":"https://api.github.com/users/cleidigh","html_url":"https://github.com/cleidigh","followers_url":"https://api.github.com/users/cleidigh/followers","following_url":"https://api.github.com/users/cleidigh/following{/other_user}","gists_url":"https://api.github.com/users/cleidigh/gists{/gist_id}","starred_url":"https://api.github.com/users/cleidigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleidigh/subscriptions","organizations_url":"https://api.github.com/users/cleidigh/orgs","repos_url":"https://api.github.com/users/cleidigh/repos","events_url":"https://api.github.com/users/cleidigh/events{/privacy}","received_events_url":"https://api.github.com/users/cleidigh/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T21:53:22Z","updated_at":"2017-03-24T21:53:22Z","body":"F2 helps a lot !\r\nbut it seemed to miss some files, maybe there's a scope thing I don't understand"}}
{"actor":{"display_login":"cleidigh"}}