{"action":"created","issue":{"url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/51","repository_url":"https://api.github.com/repos/prabirshrestha/vim-lsp","labels_url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/51/comments","events_url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/51/events","html_url":"https://github.com/prabirshrestha/vim-lsp/pull/51","id":265923649,"number":51,"title":"Fix errors and warnings produced by vint","user":{"login":"jacwah","id":3816754,"avatar_url":"https://avatars3.githubusercontent.com/u/3816754?v=4","gravatar_id":"","url":"https://api.github.com/users/jacwah","html_url":"https://github.com/jacwah","followers_url":"https://api.github.com/users/jacwah/followers","following_url":"https://api.github.com/users/jacwah/following{/other_user}","gists_url":"https://api.github.com/users/jacwah/gists{/gist_id}","starred_url":"https://api.github.com/users/jacwah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacwah/subscriptions","organizations_url":"https://api.github.com/users/jacwah/orgs","repos_url":"https://api.github.com/users/jacwah/repos","events_url":"https://api.github.com/users/jacwah/events{/privacy}","received_events_url":"https://api.github.com/users/jacwah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-16T21:33:31Z","updated_at":"2017-10-17T17:56:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/prabirshrestha/vim-lsp/pulls/51","html_url":"https://github.com/prabirshrestha/vim-lsp/pull/51","diff_url":"https://github.com/prabirshrestha/vim-lsp/pull/51.diff","patch_url":"https://github.com/prabirshrestha/vim-lsp/pull/51.patch"},"body":"I checked the the codebase with the vint vimscript linter. The errors and relevant warnings are fixed in these commits, roughly ordered by severity.\r\n\r\n1. The first commit fixes plain errors (caused by typos probably).\r\n2. The second commit ensures function signatures are correct.\r\n3. The third commit changes occurences of `==` to either `==#` or `==?` depending on context. Read more about why this is important [here](http://learnvimscriptthehardway.stevelosh.com/chapters/22.html).\r\n4. The fourth commit wraps the `silent` autocommands in a group and resets them when the file is sourced. While not strictly necessary, this is more prudent and silences the warnings."},"comment":{"url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/comments/337314638","html_url":"https://github.com/prabirshrestha/vim-lsp/pull/51#issuecomment-337314638","issue_url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/51","id":337314638,"user":{"login":"prabirshrestha","id":287744,"avatar_url":"https://avatars3.githubusercontent.com/u/287744?v=4","gravatar_id":"","url":"https://api.github.com/users/prabirshrestha","html_url":"https://github.com/prabirshrestha","followers_url":"https://api.github.com/users/prabirshrestha/followers","following_url":"https://api.github.com/users/prabirshrestha/following{/other_user}","gists_url":"https://api.github.com/users/prabirshrestha/gists{/gist_id}","starred_url":"https://api.github.com/users/prabirshrestha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabirshrestha/subscriptions","organizations_url":"https://api.github.com/users/prabirshrestha/orgs","repos_url":"https://api.github.com/users/prabirshrestha/repos","events_url":"https://api.github.com/users/prabirshrestha/events{/privacy}","received_events_url":"https://api.github.com/users/prabirshrestha/received_events","type":"User","site_admin":false},"created_at":"2017-10-17T17:56:35Z","updated_at":"2017-10-17T17:56:35Z","author_association":"OWNER","body":"Makes sense. Thanks."}}
{"actor":{"display_login":"prabirshrestha"}}