{"action":"created","comment":{"url":"https://api.github.com/repos/skycocker/chromebrew/pulls/comments/134093386","pull_request_review_id":57351667,"id":134093386,"diff_hunk":"@@ -23,26 +23,41 @@ def self.build\n           (Addr)&VG_(x86_linux_REDIR_FOR_strlen), mandatory);\n +#endif\n     }\n-\n+ \n  #  elif defined(VGP_amd64_linux)\n-@@ -1238,6 +1240,7 @@\n-       the start, otherwise ld.so makes a lot of noise. */\n-    if (0==VG_(strcmp)(\"Memcheck\", VG_(details).name)) {\n-\n+@@ -1367,6 +1369,7 @@\n+       add_hardwired_spec(\n+          \"ld-linux-x86-64.so.2\", \"index\",\n+          (Addr)&VG_(amd64_linux_REDIR_FOR_index), NULL);\n +#if CI_HACK_strlen\n        add_hardwired_spec(\n           \"ld-linux-x86-64.so.2\", \"strlen\",\n           (Addr)&VG_(amd64_linux_REDIR_FOR_strlen),\n-@@ -1251,6 +1254,8 @@\n+@@ -1378,6 +1381,7 @@\n           complain_about_stripped_glibc_ldso\n  #        endif\n-       );\n+       );   \n +#endif\n-+\n     }\n-\n+ \n  #  elif defined(VGP_ppc32_linux)\n- EOF'\n+@@ -1452,6 +1456,7 @@\n+       distros, ld.so\\'s soname is ld-linux.so.3, but Ubuntu 14.04 on\n+       Odroid uses ld-linux-armhf.so.3 for some reason. */\n+    if (0==VG_(strcmp)(\"Memcheck\", VG_(details).name)) {\n++#if CI_HACK_strlen\n+       /* strlen */\n+       add_hardwired_spec(\n+          \"ld-linux.so.3\", \"strlen\",\n+@@ -1485,6 +1490,7 @@\n+          (Addr)&VG_(arm_linux_REDIR_FOR_strcmp),\n+          complain_about_stripped_glibc_ldso\n+       );\n++#endif\n+    }\n+ \n+ #  elif defined(VGP_arm64_linux)\n+EOF'\n     system './configure --prefix=/usr/local'","path":"packages/valgrind.rb","position":null,"original_position":67,"commit_id":"06693d3c78f15595da2c042aee8d6f1b6298977c","original_commit_id":"5caa39e4a28ebdaab616b08ee21e90b7a2b09a6d","user":{"login":"jam7","id":13596993,"avatar_url":"https://avatars1.githubusercontent.com/u/13596993?v=4","gravatar_id":"","url":"https://api.github.com/users/jam7","html_url":"https://github.com/jam7","followers_url":"https://api.github.com/users/jam7/followers","following_url":"https://api.github.com/users/jam7/following{/other_user}","gists_url":"https://api.github.com/users/jam7/gists{/gist_id}","starred_url":"https://api.github.com/users/jam7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jam7/subscriptions","organizations_url":"https://api.github.com/users/jam7/orgs","repos_url":"https://api.github.com/users/jam7/repos","events_url":"https://api.github.com/users/jam7/events{/privacy}","received_events_url":"https://api.github.com/users/jam7/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-08-19T14:44:27Z","updated_at":"2017-08-19T14:44:27Z","html_url":"https://github.com/skycocker/chromebrew/pull/1106#discussion_r134093386","pull_request_url":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106","_links":{"self":{"href":"https://api.github.com/repos/skycocker/chromebrew/pulls/comments/134093386"},"html":{"href":"https://github.com/skycocker/chromebrew/pull/1106#discussion_r134093386"},"pull_request":{"href":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106"}}},"pull_request":{"url":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106","id":136449708,"html_url":"https://github.com/skycocker/chromebrew/pull/1106","diff_url":"https://github.com/skycocker/chromebrew/pull/1106.diff","patch_url":"https://github.com/skycocker/chromebrew/pull/1106.patch","issue_url":"https://api.github.com/repos/skycocker/chromebrew/issues/1106","number":1106,"state":"open","locked":false,"title":"Change valgrind.rb to make it work on arm","user":{"login":"jam7","id":13596993,"avatar_url":"https://avatars1.githubusercontent.com/u/13596993?v=4","gravatar_id":"","url":"https://api.github.com/users/jam7","html_url":"https://github.com/jam7","followers_url":"https://api.github.com/users/jam7/followers","following_url":"https://api.github.com/users/jam7/following{/other_user}","gists_url":"https://api.github.com/users/jam7/gists{/gist_id}","starred_url":"https://api.github.com/users/jam7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jam7/subscriptions","organizations_url":"https://api.github.com/users/jam7/orgs","repos_url":"https://api.github.com/users/jam7/repos","events_url":"https://api.github.com/users/jam7/events{/privacy}","received_events_url":"https://api.github.com/users/jam7/received_events","type":"User","site_admin":false},"body":"In #959, @yancouto showed how to fix valgind for x86_64 and i686.  This PR applies similar techniques to armv7l.  This fixes valgrind on armv7l also.\r\n\r\nTested on armv7l, i686, x86_64.","created_at":"2017-08-18T10:36:07Z","updated_at":"2017-08-19T14:44:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f451a4df01ef5ddb42bae93d64e209a1b75fbf3d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/skycocker/chromebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skycocker/chromebrew/issues/1106/comments","statuses_url":"https://api.github.com/repos/skycocker/chromebrew/statuses/06693d3c78f15595da2c042aee8d6f1b6298977c","head":{"label":"jam7:update/valgrind","ref":"update/valgrind","sha":"06693d3c78f15595da2c042aee8d6f1b6298977c","user":{"login":"jam7","id":13596993,"avatar_url":"https://avatars1.githubusercontent.com/u/13596993?v=4","gravatar_id":"","url":"https://api.github.com/users/jam7","html_url":"https://github.com/jam7","followers_url":"https://api.github.com/users/jam7/followers","following_url":"https://api.github.com/users/jam7/following{/other_user}","gists_url":"https://api.github.com/users/jam7/gists{/gist_id}","starred_url":"https://api.github.com/users/jam7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jam7/subscriptions","organizations_url":"https://api.github.com/users/jam7/orgs","repos_url":"https://api.github.com/users/jam7/repos","events_url":"https://api.github.com/users/jam7/events{/privacy}","received_events_url":"https://api.github.com/users/jam7/received_events","type":"User","site_admin":false},"repo":{"id":73558511,"name":"chromebrew","full_name":"jam7/chromebrew","owner":{"login":"jam7","id":13596993,"avatar_url":"https://avatars1.githubusercontent.com/u/13596993?v=4","gravatar_id":"","url":"https://api.github.com/users/jam7","html_url":"https://github.com/jam7","followers_url":"https://api.github.com/users/jam7/followers","following_url":"https://api.github.com/users/jam7/following{/other_user}","gists_url":"https://api.github.com/users/jam7/gists{/gist_id}","starred_url":"https://api.github.com/users/jam7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jam7/subscriptions","organizations_url":"https://api.github.com/users/jam7/orgs","repos_url":"https://api.github.com/users/jam7/repos","events_url":"https://api.github.com/users/jam7/events{/privacy}","received_events_url":"https://api.github.com/users/jam7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jam7/chromebrew","description":"Package manager for Chrome OS with ARM support","fork":true,"url":"https://api.github.com/repos/jam7/chromebrew","forks_url":"https://api.github.com/repos/jam7/chromebrew/forks","keys_url":"https://api.github.com/repos/jam7/chromebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jam7/chromebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jam7/chromebrew/teams","hooks_url":"https://api.github.com/repos/jam7/chromebrew/hooks","issue_events_url":"https://api.github.com/repos/jam7/chromebrew/issues/events{/number}","events_url":"https://api.github.com/repos/jam7/chromebrew/events","assignees_url":"https://api.github.com/repos/jam7/chromebrew/assignees{/user}","branches_url":"https://api.github.com/repos/jam7/chromebrew/branches{/branch}","tags_url":"https://api.github.com/repos/jam7/chromebrew/tags","blobs_url":"https://api.github.com/repos/jam7/chromebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jam7/chromebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jam7/chromebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/jam7/chromebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jam7/chromebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/jam7/chromebrew/languages","stargazers_url":"https://api.github.com/repos/jam7/chromebrew/stargazers","contributors_url":"https://api.github.com/repos/jam7/chromebrew/contributors","subscribers_url":"https://api.github.com/repos/jam7/chromebrew/subscribers","subscription_url":"https://api.github.com/repos/jam7/chromebrew/subscription","commits_url":"https://api.github.com/repos/jam7/chromebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/jam7/chromebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/jam7/chromebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/jam7/chromebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/jam7/chromebrew/contents/{+path}","compare_url":"https://api.github.com/repos/jam7/chromebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jam7/chromebrew/merges","archive_url":"https://api.github.com/repos/jam7/chromebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jam7/chromebrew/downloads","issues_url":"https://api.github.com/repos/jam7/chromebrew/issues{/number}","pulls_url":"https://api.github.com/repos/jam7/chromebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/jam7/chromebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/jam7/chromebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jam7/chromebrew/labels{/name}","releases_url":"https://api.github.com/repos/jam7/chromebrew/releases{/id}","deployments_url":"https://api.github.com/repos/jam7/chromebrew/deployments","created_at":"2016-11-12T14:48:49Z","updated_at":"2017-03-15T13:33:14Z","pushed_at":"2017-08-19T14:44:20Z","git_url":"git://github.com/jam7/chromebrew.git","ssh_url":"git@github.com:jam7/chromebrew.git","clone_url":"https://github.com/jam7/chromebrew.git","svn_url":"https://github.com/jam7/chromebrew","homepage":"http://skycocker.github.io/chromebrew/","size":1747,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"skycocker:master","ref":"master","sha":"e88622d44358631c8ecfcbfacf0fd57cde1806df","user":{"login":"skycocker","id":2119326,"avatar_url":"https://avatars2.githubusercontent.com/u/2119326?v=4","gravatar_id":"","url":"https://api.github.com/users/skycocker","html_url":"https://github.com/skycocker","followers_url":"https://api.github.com/users/skycocker/followers","following_url":"https://api.github.com/users/skycocker/following{/other_user}","gists_url":"https://api.github.com/users/skycocker/gists{/gist_id}","starred_url":"https://api.github.com/users/skycocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skycocker/subscriptions","organizations_url":"https://api.github.com/users/skycocker/orgs","repos_url":"https://api.github.com/users/skycocker/repos","events_url":"https://api.github.com/users/skycocker/events{/privacy}","received_events_url":"https://api.github.com/users/skycocker/received_events","type":"User","site_admin":false},"repo":{"id":11909954,"name":"chromebrew","full_name":"skycocker/chromebrew","owner":{"login":"skycocker","id":2119326,"avatar_url":"https://avatars2.githubusercontent.com/u/2119326?v=4","gravatar_id":"","url":"https://api.github.com/users/skycocker","html_url":"https://github.com/skycocker","followers_url":"https://api.github.com/users/skycocker/followers","following_url":"https://api.github.com/users/skycocker/following{/other_user}","gists_url":"https://api.github.com/users/skycocker/gists{/gist_id}","starred_url":"https://api.github.com/users/skycocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skycocker/subscriptions","organizations_url":"https://api.github.com/users/skycocker/orgs","repos_url":"https://api.github.com/users/skycocker/repos","events_url":"https://api.github.com/users/skycocker/events{/privacy}","received_events_url":"https://api.github.com/users/skycocker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skycocker/chromebrew","description":"Package manager for Chrome OS","fork":false,"url":"https://api.github.com/repos/skycocker/chromebrew","forks_url":"https://api.github.com/repos/skycocker/chromebrew/forks","keys_url":"https://api.github.com/repos/skycocker/chromebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skycocker/chromebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skycocker/chromebrew/teams","hooks_url":"https://api.github.com/repos/skycocker/chromebrew/hooks","issue_events_url":"https://api.github.com/repos/skycocker/chromebrew/issues/events{/number}","events_url":"https://api.github.com/repos/skycocker/chromebrew/events","assignees_url":"https://api.github.com/repos/skycocker/chromebrew/assignees{/user}","branches_url":"https://api.github.com/repos/skycocker/chromebrew/branches{/branch}","tags_url":"https://api.github.com/repos/skycocker/chromebrew/tags","blobs_url":"https://api.github.com/repos/skycocker/chromebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skycocker/chromebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skycocker/chromebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/skycocker/chromebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skycocker/chromebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/skycocker/chromebrew/languages","stargazers_url":"https://api.github.com/repos/skycocker/chromebrew/stargazers","contributors_url":"https://api.github.com/repos/skycocker/chromebrew/contributors","subscribers_url":"https://api.github.com/repos/skycocker/chromebrew/subscribers","subscription_url":"https://api.github.com/repos/skycocker/chromebrew/subscription","commits_url":"https://api.github.com/repos/skycocker/chromebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/skycocker/chromebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/skycocker/chromebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/skycocker/chromebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/skycocker/chromebrew/contents/{+path}","compare_url":"https://api.github.com/repos/skycocker/chromebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skycocker/chromebrew/merges","archive_url":"https://api.github.com/repos/skycocker/chromebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skycocker/chromebrew/downloads","issues_url":"https://api.github.com/repos/skycocker/chromebrew/issues{/number}","pulls_url":"https://api.github.com/repos/skycocker/chromebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/skycocker/chromebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/skycocker/chromebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skycocker/chromebrew/labels{/name}","releases_url":"https://api.github.com/repos/skycocker/chromebrew/releases{/id}","deployments_url":"https://api.github.com/repos/skycocker/chromebrew/deployments","created_at":"2013-08-05T22:05:57Z","updated_at":"2017-08-16T08:33:17Z","pushed_at":"2017-08-19T14:44:22Z","git_url":"git://github.com/skycocker/chromebrew.git","ssh_url":"git@github.com:skycocker/chromebrew.git","clone_url":"https://github.com/skycocker/chromebrew.git","svn_url":"https://github.com/skycocker/chromebrew","homepage":"http://skycocker.github.io/chromebrew/","size":1534,"stargazers_count":682,"watchers_count":682,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":180,"mirror_url":null,"open_issues_count":52,"forks":180,"open_issues":52,"watchers":682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106"},"html":{"href":"https://github.com/skycocker/chromebrew/pull/1106"},"issue":{"href":"https://api.github.com/repos/skycocker/chromebrew/issues/1106"},"comments":{"href":"https://api.github.com/repos/skycocker/chromebrew/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/skycocker/chromebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skycocker/chromebrew/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/skycocker/chromebrew/statuses/06693d3c78f15595da2c042aee8d6f1b6298977c"}}}}
{"actor":{"display_login":"jam7"}}