{"action":"created","comment":{"url":"https://api.github.com/repos/google/blockly/pulls/comments/148417996","pull_request_review_id":73657140,"id":148417996,"diff_hunk":"@@ -825,18 +830,24 @@ Blockly.Constants.Text.TEXT_CHARAT_MUTATOR_MIXIN = {\n         this.appendDummyInput('ORDINAL')\n             .appendField(Blockly.Msg.ORDINAL_NUMBER_SUFFIX);\n       }\n-    } else {\n-      this.appendDummyInput('AT');\n     }\n     if (Blockly.Msg.TEXT_CHARAT_TAIL) {\n       this.removeInput('TAIL', true);\n       this.appendDummyInput('TAIL')\n           .appendField(Blockly.Msg.TEXT_CHARAT_TAIL);\n     }\n-    var menu = new Blockly.FieldDropdown(this.WHERE_OPTIONS, function(value) {\n+\n+    this.isAt_ = isAt;\n+  }\n+};\n+\n+// Does the initial mutator update of text_charAt and adds the tooltip\n+Blockly.Constants.Text.TEXT_CHARAT_EXTENSION = function() {","path":"blocks/text.js","position":null,"original_position":44,"commit_id":"cfcf9d54c34e34743154e455ebfe11eb10491d5c","original_commit_id":"3da7205699c191a03e44b2be1ba0bc271c7123a9","user":{"login":"RoboErikG","id":11066279,"avatar_url":"https://avatars2.githubusercontent.com/u/11066279?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboErikG","html_url":"https://github.com/RoboErikG","followers_url":"https://api.github.com/users/RoboErikG/followers","following_url":"https://api.github.com/users/RoboErikG/following{/other_user}","gists_url":"https://api.github.com/users/RoboErikG/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboErikG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboErikG/subscriptions","organizations_url":"https://api.github.com/users/RoboErikG/orgs","repos_url":"https://api.github.com/users/RoboErikG/repos","events_url":"https://api.github.com/users/RoboErikG/events{/privacy}","received_events_url":"https://api.github.com/users/RoboErikG/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2017-11-02T00:16:58Z","updated_at":"2017-11-02T00:22:27Z","html_url":"https://github.com/google/blockly/pull/1410#discussion_r148417996","pull_request_url":"https://api.github.com/repos/google/blockly/pulls/1410","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/comments/148417996"},"html":{"href":"https://github.com/google/blockly/pull/1410#discussion_r148417996"},"pull_request":{"href":"https://api.github.com/repos/google/blockly/pulls/1410"}},"in_reply_to_id":148407177},"pull_request":{"url":"https://api.github.com/repos/google/blockly/pulls/1410","id":150162524,"html_url":"https://github.com/google/blockly/pull/1410","diff_url":"https://github.com/google/blockly/pull/1410.diff","patch_url":"https://github.com/google/blockly/pull/1410.patch","issue_url":"https://api.github.com/repos/google/blockly/issues/1410","number":1410,"state":"open","locked":false,"title":"Fix #1397 by being more careful with mutator","user":{"login":"RoboErikG","id":11066279,"avatar_url":"https://avatars2.githubusercontent.com/u/11066279?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboErikG","html_url":"https://github.com/RoboErikG","followers_url":"https://api.github.com/users/RoboErikG/followers","following_url":"https://api.github.com/users/RoboErikG/following{/other_user}","gists_url":"https://api.github.com/users/RoboErikG/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboErikG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboErikG/subscriptions","organizations_url":"https://api.github.com/users/RoboErikG/orgs","repos_url":"https://api.github.com/users/RoboErikG/repos","events_url":"https://api.github.com/users/RoboErikG/events{/privacy}","received_events_url":"https://api.github.com/users/RoboErikG/received_events","type":"User","site_admin":false},"body":"\r\n\r\nThanks for submitting code to Blockly!  Please fill out the following as part of your pull request so we can review your code more easily.\r\n\r\n## The basics\r\n\r\n- [x] I branched from develop\r\n- [x] My pull request is against develop\r\n- [x] My code follows the [style guide](https://developers.google.com/blockly/guides/modify/web/style-guide)\r\n\r\n## The details\r\n### Resolves\r\n\r\n#1397 \r\n\r\n### Proposed Changes\r\n\r\nThe text_charAt mutator was replacing more of the title string than\r\nnecessary, which would lead to losing some of the relevant text in\r\nthe label. Updated the mutator to only add/remove a new input on the\r\nend instead of replacing the default dummy input.\r\n\r\n### Test Coverage\r\n\r\nRan existing unit tests and added X and Y to the TEXT_CHARAT_TITLE string as demonstrated in the bug to verify manually.\r\n\r\nTested on:\r\n_Remove this hint: these checkboxes can be checked like this: [x]_\r\n- [x] Desktop:\r\n  - [x] Chrome\r\n  - [ ] Firefox\r\n  - [ ] Safari\r\n  - [ ] Opera\r\n  - [ ] IE 10+\r\n  - [ ] IE 11\r\n  - [ ] EDGE\r\n\r\n- [ ] Smartphone/Tablet/Chromebook (please complete the following information):\r\n  - Device: [e.g. iPhone6]\r\n  - OS: [e.g. iOS8.1]\r\n  - Browser [e.g. stock browser, safari]\r\n  - Version [e.g. 22]\r\n  \r\n### Additional Information\r\n\r\n_Anything else we should know?_\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/blockly/1410)\n<!-- Reviewable:end -->\n","created_at":"2017-11-01T22:29:26Z","updated_at":"2017-11-02T00:22:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fa1cde0bce8a1996e8eb05dc125df5cf183ef8d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/blockly/pulls/1410/commits","review_comments_url":"https://api.github.com/repos/google/blockly/pulls/1410/comments","review_comment_url":"https://api.github.com/repos/google/blockly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/blockly/issues/1410/comments","statuses_url":"https://api.github.com/repos/google/blockly/statuses/cfcf9d54c34e34743154e455ebfe11eb10491d5c","head":{"label":"RoboErikG:RoboErikG-charat","ref":"RoboErikG-charat","sha":"cfcf9d54c34e34743154e455ebfe11eb10491d5c","user":{"login":"RoboErikG","id":11066279,"avatar_url":"https://avatars2.githubusercontent.com/u/11066279?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboErikG","html_url":"https://github.com/RoboErikG","followers_url":"https://api.github.com/users/RoboErikG/followers","following_url":"https://api.github.com/users/RoboErikG/following{/other_user}","gists_url":"https://api.github.com/users/RoboErikG/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboErikG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboErikG/subscriptions","organizations_url":"https://api.github.com/users/RoboErikG/orgs","repos_url":"https://api.github.com/users/RoboErikG/repos","events_url":"https://api.github.com/users/RoboErikG/events{/privacy}","received_events_url":"https://api.github.com/users/RoboErikG/received_events","type":"User","site_admin":false},"repo":{"id":87976342,"name":"blockly","full_name":"RoboErikG/blockly","owner":{"login":"RoboErikG","id":11066279,"avatar_url":"https://avatars2.githubusercontent.com/u/11066279?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboErikG","html_url":"https://github.com/RoboErikG","followers_url":"https://api.github.com/users/RoboErikG/followers","following_url":"https://api.github.com/users/RoboErikG/following{/other_user}","gists_url":"https://api.github.com/users/RoboErikG/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboErikG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboErikG/subscriptions","organizations_url":"https://api.github.com/users/RoboErikG/orgs","repos_url":"https://api.github.com/users/RoboErikG/repos","events_url":"https://api.github.com/users/RoboErikG/events{/privacy}","received_events_url":"https://api.github.com/users/RoboErikG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RoboErikG/blockly","description":"The web-based visual programming editor.","fork":true,"url":"https://api.github.com/repos/RoboErikG/blockly","forks_url":"https://api.github.com/repos/RoboErikG/blockly/forks","keys_url":"https://api.github.com/repos/RoboErikG/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoboErikG/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoboErikG/blockly/teams","hooks_url":"https://api.github.com/repos/RoboErikG/blockly/hooks","issue_events_url":"https://api.github.com/repos/RoboErikG/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/RoboErikG/blockly/events","assignees_url":"https://api.github.com/repos/RoboErikG/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/RoboErikG/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/RoboErikG/blockly/tags","blobs_url":"https://api.github.com/repos/RoboErikG/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoboErikG/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoboErikG/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoboErikG/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoboErikG/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/RoboErikG/blockly/languages","stargazers_url":"https://api.github.com/repos/RoboErikG/blockly/stargazers","contributors_url":"https://api.github.com/repos/RoboErikG/blockly/contributors","subscribers_url":"https://api.github.com/repos/RoboErikG/blockly/subscribers","subscription_url":"https://api.github.com/repos/RoboErikG/blockly/subscription","commits_url":"https://api.github.com/repos/RoboErikG/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoboErikG/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoboErikG/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoboErikG/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/RoboErikG/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/RoboErikG/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoboErikG/blockly/merges","archive_url":"https://api.github.com/repos/RoboErikG/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoboErikG/blockly/downloads","issues_url":"https://api.github.com/repos/RoboErikG/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/RoboErikG/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/RoboErikG/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/RoboErikG/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoboErikG/blockly/labels{/name}","releases_url":"https://api.github.com/repos/RoboErikG/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/RoboErikG/blockly/deployments","created_at":"2017-04-11T20:26:15Z","updated_at":"2017-04-11T20:26:18Z","pushed_at":"2017-11-02T00:22:26Z","git_url":"git://github.com/RoboErikG/blockly.git","ssh_url":"git@github.com:RoboErikG/blockly.git","clone_url":"https://github.com/RoboErikG/blockly.git","svn_url":"https://github.com/RoboErikG/blockly","homepage":"https://developers.google.com/blockly/","size":64747,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:develop","ref":"develop","sha":"63637a927ab662db25b50db0146c99b791458b7b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":13872231,"name":"blockly","full_name":"google/blockly","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/blockly","description":"The web-based visual programming editor.","fork":false,"url":"https://api.github.com/repos/google/blockly","forks_url":"https://api.github.com/repos/google/blockly/forks","keys_url":"https://api.github.com/repos/google/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/blockly/teams","hooks_url":"https://api.github.com/repos/google/blockly/hooks","issue_events_url":"https://api.github.com/repos/google/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/google/blockly/events","assignees_url":"https://api.github.com/repos/google/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/google/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/google/blockly/tags","blobs_url":"https://api.github.com/repos/google/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/google/blockly/languages","stargazers_url":"https://api.github.com/repos/google/blockly/stargazers","contributors_url":"https://api.github.com/repos/google/blockly/contributors","subscribers_url":"https://api.github.com/repos/google/blockly/subscribers","subscription_url":"https://api.github.com/repos/google/blockly/subscription","commits_url":"https://api.github.com/repos/google/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/google/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/blockly/merges","archive_url":"https://api.github.com/repos/google/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/blockly/downloads","issues_url":"https://api.github.com/repos/google/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/google/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/google/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/google/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/blockly/labels{/name}","releases_url":"https://api.github.com/repos/google/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/google/blockly/deployments","created_at":"2013-10-25T21:13:33Z","updated_at":"2017-11-01T21:51:09Z","pushed_at":"2017-11-01T23:55:56Z","git_url":"git://github.com/google/blockly.git","ssh_url":"git@github.com:google/blockly.git","clone_url":"https://github.com/google/blockly.git","svn_url":"https://github.com/google/blockly","homepage":"https://developers.google.com/blockly/","size":66084,"stargazers_count":3857,"watchers_count":3857,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1385,"mirror_url":null,"archived":false,"open_issues_count":270,"forks":1385,"open_issues":270,"watchers":3857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/1410"},"html":{"href":"https://github.com/google/blockly/pull/1410"},"issue":{"href":"https://api.github.com/repos/google/blockly/issues/1410"},"comments":{"href":"https://api.github.com/repos/google/blockly/issues/1410/comments"},"review_comments":{"href":"https://api.github.com/repos/google/blockly/pulls/1410/comments"},"review_comment":{"href":"https://api.github.com/repos/google/blockly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/blockly/pulls/1410/commits"},"statuses":{"href":"https://api.github.com/repos/google/blockly/statuses/cfcf9d54c34e34743154e455ebfe11eb10491d5c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RoboErikG"}}