{"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/comments/158173673","pull_request_review_id":84941541,"id":158173673,"diff_hunk":"@@ -0,0 +1,198 @@\n+# Copyright 2017 OpenCensus Authors\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+module OpenCensus\n+  module Trace\n+    ##\n+    # Span represents a span in a trace record. Spans are contained in\n+    # a trace and arranged in a forest. That is, each span may be a root span\n+    # or have a parent span, and may have zero or more children.\n+    #\n+    class Span\n+      ##\n+      # A unique identifier for a trace. All spans from the same trace share\n+      # the same `trace_id`. The ID is a 16-byte value represented as a\n+      # hexadecimal string.\n+      #\n+      # @return [String]\n+      #\n+      attr_reader :trace_id\n+\n+      ##\n+      # A unique identifier for a span within a trace, assigned when the span\n+      # is created. The ID is an 8-byte value represented as a hexadecimal\n+      # string.\n+      #\n+      # @return [String]\n+      #\n+      attr_reader :span_id\n+\n+      ##\n+      # The `span_id` of this span's parent span. If this is a root span, then\n+      # this field must be empty. The ID is an 8-byte value represented as a\n+      # hexadecimal string.\n+      #\n+      # @return [String]\n+      #\n+      attr_reader :parent_span_id\n+\n+      ##\n+      # The name of this span.\n+      #\n+      # @return [OpenCensus::Trace::TruncatableString]\n+      #\n+      attr_reader :name\n+\n+      ##\n+      # The starting timestamp of this span in UTC, or `nil` if the\n+      # starting timestamp has not yet been populated.\n+      #\n+      # @return [Time, nil]\n+      #\n+      attr_reader :start_time\n+\n+      ##\n+      # The ending timestamp of this span in UTC, or `nil` if the\n+      # ending timestamp has not yet been populated.\n+      #\n+      # @return [Time, nil]\n+      #\n+      attr_reader :end_time\n+\n+      ##\n+      # The properties of this span.\n+      #\n+      # @return [Hash{String => String}]\n+      #\n+      attr_reader :attributes\n+\n+      ##\n+      # The number of attributes that were discarded. Attributes can be\n+      # discarded because their keys are too long or because there are too\n+      # many attributes. If this value is 0, then no attributes were dropped.\n+      attr_reader :dropped_attributes_count\n+\n+      ##\n+      # A stack trace captured at the start of the span.\n+      #\n+      # @return [Thread::Backtrace::Location[]]","path":"lib/opencensus/trace/span.rb","position":89,"original_position":89,"commit_id":"8e3cd4c876820b41ca9e4997a1edc06ddeaba57f","original_commit_id":"8e3cd4c876820b41ca9e4997a1edc06ddeaba57f","user":{"login":"dazuma","id":8911,"avatar_url":"https://avatars2.githubusercontent.com/u/8911?v=4","gravatar_id":"","url":"https://api.github.com/users/dazuma","html_url":"https://github.com/dazuma","followers_url":"https://api.github.com/users/dazuma/followers","following_url":"https://api.github.com/users/dazuma/following{/other_user}","gists_url":"https://api.github.com/users/dazuma/gists{/gist_id}","starred_url":"https://api.github.com/users/dazuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dazuma/subscriptions","organizations_url":"https://api.github.com/users/dazuma/orgs","repos_url":"https://api.github.com/users/dazuma/repos","events_url":"https://api.github.com/users/dazuma/events{/privacy}","received_events_url":"https://api.github.com/users/dazuma/received_events","type":"User","site_admin":false},"body":"Okay, according to https://yardoc.org/types.html Array specifically uses angle brackets, while Hash specifically uses curly braces. :-/","created_at":"2017-12-21T00:52:05Z","updated_at":"2017-12-21T00:52:05Z","html_url":"https://github.com/census-instrumentation/opencensus-ruby/pull/1#discussion_r158173673","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/comments/158173673"},"html":{"href":"https://github.com/census-instrumentation/opencensus-ruby/pull/1#discussion_r158173673"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1"}},"in_reply_to_id":158165205},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1","id":159048793,"html_url":"https://github.com/census-instrumentation/opencensus-ruby/pull/1","diff_url":"https://github.com/census-instrumentation/opencensus-ruby/pull/1.diff","patch_url":"https://github.com/census-instrumentation/opencensus-ruby/pull/1.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/1","number":1,"state":"open","locked":false,"title":"WIP: Read only models","user":{"login":"chingor13","id":32483,"avatar_url":"https://avatars0.githubusercontent.com/u/32483?v=4","gravatar_id":"","url":"https://api.github.com/users/chingor13","html_url":"https://github.com/chingor13","followers_url":"https://api.github.com/users/chingor13/followers","following_url":"https://api.github.com/users/chingor13/following{/other_user}","gists_url":"https://api.github.com/users/chingor13/gists{/gist_id}","starred_url":"https://api.github.com/users/chingor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingor13/subscriptions","organizations_url":"https://api.github.com/users/chingor13/orgs","repos_url":"https://api.github.com/users/chingor13/repos","events_url":"https://api.github.com/users/chingor13/events{/privacy}","received_events_url":"https://api.github.com/users/chingor13/received_events","type":"User","site_admin":false},"body":"Open questions:\r\n\r\n- [x] Mix these types into the normal namespace? (remove the `Proto` namespace)\r\n- [x] Flatten the collection objects (`Attributes`, `Links`, `TimeEvents` - move dropped counts to parent object)\r\n- [x] ~Add `StackFrame` object? It might be easier to just keep the results as the return from `caller()`~","created_at":"2017-12-19T00:06:33Z","updated_at":"2017-12-21T00:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49a586c31b4f6c1bb85ba602d2cde9a3b56d234f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/1/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/statuses/8e3cd4c876820b41ca9e4997a1edc06ddeaba57f","head":{"label":"census-instrumentation:read-only-models","ref":"read-only-models","sha":"8e3cd4c876820b41ca9e4997a1edc06ddeaba57f","user":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":107332122,"name":"opencensus-ruby","full_name":"census-instrumentation/opencensus-ruby","owner":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/census-instrumentation/opencensus-ruby","description":"A stats collection and distributed tracing framework","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/deployments","created_at":"2017-10-17T22:45:19Z","updated_at":"2017-12-08T03:21:57Z","pushed_at":"2017-12-20T23:34:26Z","git_url":"git://github.com/census-instrumentation/opencensus-ruby.git","ssh_url":"git@github.com:census-instrumentation/opencensus-ruby.git","clone_url":"https://github.com/census-instrumentation/opencensus-ruby.git","svn_url":"https://github.com/census-instrumentation/opencensus-ruby","homepage":"","size":77,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"ebd72b99e8ddbc04b9a1f82ba8dc249559c1c9c5","user":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":107332122,"name":"opencensus-ruby","full_name":"census-instrumentation/opencensus-ruby","owner":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/census-instrumentation/opencensus-ruby","description":"A stats collection and distributed tracing framework","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/deployments","created_at":"2017-10-17T22:45:19Z","updated_at":"2017-12-08T03:21:57Z","pushed_at":"2017-12-20T23:34:26Z","git_url":"git://github.com/census-instrumentation/opencensus-ruby.git","ssh_url":"git@github.com:census-instrumentation/opencensus-ruby.git","clone_url":"https://github.com/census-instrumentation/opencensus-ruby.git","svn_url":"https://github.com/census-instrumentation/opencensus-ruby","homepage":"","size":77,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1"},"html":{"href":"https://github.com/census-instrumentation/opencensus-ruby/pull/1"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/1"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-ruby/statuses/8e3cd4c876820b41ca9e4997a1edc06ddeaba57f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dazuma"}}