{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/6625","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/6625/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/6625/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/6625/events","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/6625","id":255402618,"number":6625,"title":"Feature/global notification setting","user":{"login":"theck13","id":3827611,"avatar_url":"https://avatars2.githubusercontent.com/u/3827611?v=4","gravatar_id":"","url":"https://api.github.com/users/theck13","html_url":"https://github.com/theck13","followers_url":"https://api.github.com/users/theck13/followers","following_url":"https://api.github.com/users/theck13/following{/other_user}","gists_url":"https://api.github.com/users/theck13/gists{/gist_id}","starred_url":"https://api.github.com/users/theck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theck13/subscriptions","organizations_url":"https://api.github.com/users/theck13/orgs","repos_url":"https://api.github.com/users/theck13/repos","events_url":"https://api.github.com/users/theck13/events{/privacy}","received_events_url":"https://api.github.com/users/theck13/received_events","type":"User","site_admin":false},"labels":[{"id":90791782,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Notifications","name":"Notifications","color":"006b75","default":false},{"id":620843776,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/[Status]%20Needs%20Copy%20Review","name":"[Status] Needs Copy Review","color":"c2e0c6","default":false},{"id":538686626,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/[Status]%20Needs%20Design%20Review","name":"[Status] Needs Design Review","color":"13CDF7","default":false},{"id":35106420,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-05T20:42:34Z","updated_at":"2017-09-06T19:27:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/6625","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/6625","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/6625.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/6625.patch"},"body":"### Fix\r\nAdd a global notification preference to the ***Notification Settings*** screen under the ***Sights and Sounds*** section to allow users to enable/disable notifications on their device.  See the screenshots below for illustration.\r\n\r\n![notification_settings](https://user-images.githubusercontent.com/3827611/30082538-688648c8-9248-11e7-9725-59582002cfc4.png)\r\n\r\n### Test\r\n1. Go to ***Me*** tab.\r\n2. Tap ***Notification Settings*** option.\r\n3. Notice ***Receive notifications*** setting.\r\n4. Notice ***Receive notifications*** setting is on.\r\n5. Notice all ***Sights and Sounds*** settings are enabled.\r\n6. Like a post from another account.\r\n7. Notice notification is received.\r\n8. Tap ***Receive notifications*** setting.\r\n9. Notice ***Receive notifications*** setting is off.\r\n10. Notice all ***Sights and Sounds*** settings are disabled.\r\n11. Like a post from another account.\r\n12. Notice notification is not received."},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments/327588558","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/6625#issuecomment-327588558","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/6625","id":327588558,"user":{"login":"theck13","id":3827611,"avatar_url":"https://avatars2.githubusercontent.com/u/3827611?v=4","gravatar_id":"","url":"https://api.github.com/users/theck13","html_url":"https://github.com/theck13","followers_url":"https://api.github.com/users/theck13/followers","following_url":"https://api.github.com/users/theck13/following{/other_user}","gists_url":"https://api.github.com/users/theck13/gists{/gist_id}","starred_url":"https://api.github.com/users/theck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theck13/subscriptions","organizations_url":"https://api.github.com/users/theck13/orgs","repos_url":"https://api.github.com/users/theck13/repos","events_url":"https://api.github.com/users/theck13/events{/privacy}","received_events_url":"https://api.github.com/users/theck13/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T19:27:32Z","updated_at":"2017-09-06T19:27:32Z","author_association":"CONTRIBUTOR","body":"After discussing the changes with @folletto, it was decided to update the wording of the preference from ***Receive notification*** to ***Allow app notifications*** which was done with 7ffacb7462560fa41ba439f020ce07ce1f3ed01b.  A summary stating ***Disabling this will block all app notifications, regardless of type*** was added to the preference as well with 7c7b56f170f6148c919df790375009c668d19f71.  These two labels will need copy review and are shown in the screenshot below.\r\n\r\n![settings_wording](https://user-images.githubusercontent.com/3827611/30129870-97a9573c-9304-11e7-998c-203b74487448.png)\r\n\r\n@mattmiklic suggested adding a link from the Settings app to the WordPress app to follow [Material guidelines for notification settings](https://material.io/guidelines/patterns/notifications.html#notifications-settings-priority).  That was added with 720fa7d333f9ffb8ccb3957bc3afdfedcce5c442.  The link is signified by the [`ic_settings`](https://material.io/icons/#ic_settings) icon on the Settings > Notifications > WordPress screen for Nougat.  See the screenshots below for illustration.\r\n\r\n![settings_link](https://user-images.githubusercontent.com/3827611/30130471-7e3219a4-9306-11e7-9cb0-44b236876a1e.png)\r\n\r\nThe link from the Settings app to the WordPress app is signified by the ***Additional settings in the app*** button on the Settings > Apps & notifications > Notifications > Notifications > WordPress screen for Oreo.  Since the WordPress app targets Nougat, the ***Additional settings in the app*** button will not be shown on a device running Oreo.  Once we update the [`targetSdkVersion`](https://github.com/wordpress-mobile/WordPress-Android/blob/develop/WordPress/build.gradle#L41) to 26, the ***Additional settings in the app*** button will be shown.  See the screenshots below for reference.\r\n\r\n![settings_oreo](https://user-images.githubusercontent.com/3827611/30130476-85cba34c-9306-11e7-8ab5-0313cb9e8e8f.png)"}}
{"actor":{"display_login":"theck13"}}