{"action":"created","comment":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments/110304503","pull_request_review_id":31469201,"id":110304503,"diff_hunk":"@@ -2210,35 +2210,32 @@ - (void)imagePickerController:(UIImagePickerController *)picker\n \n - (void)sendMessageAttachment:(SignalAttachment *)attachment\n {\n+    OWSAssert([NSThread isMainThread]);\n     // TODO: Should we assume non-nil or should we check for non-nil?\n     OWSAssert(attachment != nil);\n     OWSAssert(![attachment hasError]);\n     OWSAssert([attachment mimeType].length > 0);\n-    \n-    DispatchMainThreadSafe(^{","path":"Signal/src/ViewControllers/MessagesViewController.m","position":28,"original_position":28,"commit_id":"3c13d8e9f1076477875d27a8b346a0738a59de0b","original_commit_id":"3c13d8e9f1076477875d27a8b346a0738a59de0b","user":{"login":"charlesmchen","id":625803,"avatar_url":"https://avatars2.githubusercontent.com/u/625803?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesmchen","html_url":"https://github.com/charlesmchen","followers_url":"https://api.github.com/users/charlesmchen/followers","following_url":"https://api.github.com/users/charlesmchen/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen/orgs","repos_url":"https://api.github.com/users/charlesmchen/repos","events_url":"https://api.github.com/users/charlesmchen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen/received_events","type":"User","site_admin":false},"body":"This method is now only called from `tryToSendAttachmentIfApproved:` which ensures that this will be called on the main thread.","created_at":"2017-04-07T02:05:31Z","updated_at":"2017-04-07T02:05:31Z","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1947#discussion_r110304503","pull_request_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments/110304503"},"html":{"href":"https://github.com/WhisperSystems/Signal-iOS/pull/1947#discussion_r110304503"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947"}}},"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947","id":114730424,"html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1947","diff_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1947.diff","patch_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1947.patch","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1947","number":1947,"state":"open","locked":false,"title":"Show attachment approval dialog for all attachments.","user":{"login":"charlesmchen","id":625803,"avatar_url":"https://avatars2.githubusercontent.com/u/625803?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesmchen","html_url":"https://github.com/charlesmchen","followers_url":"https://api.github.com/users/charlesmchen/followers","following_url":"https://api.github.com/users/charlesmchen/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen/orgs","repos_url":"https://api.github.com/users/charlesmchen/repos","events_url":"https://api.github.com/users/charlesmchen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen/received_events","type":"User","site_admin":false},"body":"PTAL @michaelkirk ","created_at":"2017-04-07T02:04:32Z","updated_at":"2017-04-07T02:05:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79ee1af1435ecf8a98fc1a3dc3773f4c1759b188","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947/commits","review_comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947/comments","review_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1947/comments","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/3c13d8e9f1076477875d27a8b346a0738a59de0b","head":{"label":"WhisperSystems:charlesmchen/approveAllAttachments","ref":"charlesmchen/approveAllAttachments","sha":"3c13d8e9f1076477875d27a8b346a0738a59de0b","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars1.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"WhisperSystems/Signal-iOS","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars1.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-iOS","description":"A private messenger for iOS","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2017-04-06T07:44:07Z","pushed_at":"2017-04-07T02:04:32Z","git_url":"git://github.com/WhisperSystems/Signal-iOS.git","ssh_url":"git@github.com:WhisperSystems/Signal-iOS.git","clone_url":"https://github.com/WhisperSystems/Signal-iOS.git","svn_url":"https://github.com/WhisperSystems/Signal-iOS","homepage":"https://whispersystems.org/","size":43349,"stargazers_count":2627,"watchers_count":2627,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":602,"mirror_url":null,"open_issues_count":299,"forks":602,"open_issues":299,"watchers":2627,"default_branch":"master"}},"base":{"label":"WhisperSystems:master","ref":"master","sha":"8c5ceffe17b72e04c20995c55fb444b52940944f","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars1.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"WhisperSystems/Signal-iOS","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars1.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-iOS","description":"A private messenger for iOS","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2017-04-06T07:44:07Z","pushed_at":"2017-04-07T02:04:32Z","git_url":"git://github.com/WhisperSystems/Signal-iOS.git","ssh_url":"git@github.com:WhisperSystems/Signal-iOS.git","clone_url":"https://github.com/WhisperSystems/Signal-iOS.git","svn_url":"https://github.com/WhisperSystems/Signal-iOS","homepage":"https://whispersystems.org/","size":43349,"stargazers_count":2627,"watchers_count":2627,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":602,"mirror_url":null,"open_issues_count":299,"forks":602,"open_issues":299,"watchers":2627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947"},"html":{"href":"https://github.com/WhisperSystems/Signal-iOS/pull/1947"},"issue":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1947"},"comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1947/comments"},"review_comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947/comments"},"review_comment":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1947/commits"},"statuses":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/3c13d8e9f1076477875d27a8b346a0738a59de0b"}}}}
{"actor":{"display_login":"charlesmchen"}}