{"action":"created","comment":{"url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments/127509582","pull_request_review_id":50106939,"id":127509582,"diff_hunk":"@@ -6,101 +6,108 @@\n Location Service\n \"\"\"\n \n-import struct\n import wifiphisher.common.constants as constants\n import scapy.layers.dot11 as dot11\n \n \n class Lure10(object):\n     \"\"\"\n-    Sends a number of beacons to fool Windows Location Service.\n+    Sends a number of beacons to fool Windows Location Service\n     \"\"\"\n \n     def __init__(self, shared_data):\n         \"\"\"\n-        Setup the class with all the given arguments.\n+        Setup the class with all the given arguments\n \n-        :param self: A Lure10 object.\n+        :param self: A Lure10 object\n         :param data: Shared data from main engine\n         :type self: Deauthentication\n-        :type data: dictionary\n+        :type data: dict\n         :return: None\n         :rtype: None\n         \"\"\"\n \n-        self.first = True\n-        self.first_output = True\n+        self.first_run = True\n         self.data = shared_data\n-        self.beacons_num = 0\n \n     def get_packet(self, pkt):\n         \"\"\"\n-        We start broadcasting the beacons on the first received packet.\n+        We start broadcasting the beacons on the first received packet\n \n-        :param self: A Lure10 object.\n-        :param packet: A scapy.layers.RadioTap object.\n+        :param self: A Lure10 object\n+        :param packet: A scapy.layers.RadioTap object\n         :type self: Lure10\n         :type packet: scapy.layers.RadioTap\n-        :return: list with the crafted beacon frames\n-        :rtype: list\n+        :return: A tuple containing [\"*\"] followed by a list of\n+            the crafted beacon frames\n+        :rtype: tuple(list, list)\n+        .. warning: pkt is not used here but should not be removed since\n+            this prototype is requirement\n         \"\"\"\n \n-        beacons = []\n-\n-        if self.first:\n-            if self.data.args.lure10_exploit:\n-                area_file = constants.LOCS_DIR + self.data.args.lure10_exploit\n-                with open(area_file) as a_file:\n-                    wlans = [x.strip() for x in a_file.readlines()]","path":"wifiphisher/extensions/lure10.py","position":62,"original_position":62,"commit_id":"201d82cd3c0b5195cf24f55bdab311e42028e17c","original_commit_id":"201d82cd3c0b5195cf24f55bdab311e42028e17c","user":{"login":"blackHatMonkey","id":25112506,"avatar_url":"https://avatars6.githubusercontent.com/u/25112506?v=4","gravatar_id":"","url":"https://api.github.com/users/blackHatMonkey","html_url":"https://github.com/blackHatMonkey","followers_url":"https://api.github.com/users/blackHatMonkey/followers","following_url":"https://api.github.com/users/blackHatMonkey/following{/other_user}","gists_url":"https://api.github.com/users/blackHatMonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/blackHatMonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackHatMonkey/subscriptions","organizations_url":"https://api.github.com/users/blackHatMonkey/orgs","repos_url":"https://api.github.com/users/blackHatMonkey/repos","events_url":"https://api.github.com/users/blackHatMonkey/events{/privacy}","received_events_url":"https://api.github.com/users/blackHatMonkey/received_events","type":"User","site_admin":false},"body":"Instead of using multiple loops to first read each line and then do the operations, they are combined in a single loop for better performance.","created_at":"2017-07-14T17:38:21Z","updated_at":"2017-07-14T17:38:21Z","html_url":"https://github.com/wifiphisher/wifiphisher/pull/674#discussion_r127509582","pull_request_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments/127509582"},"html":{"href":"https://github.com/wifiphisher/wifiphisher/pull/674#discussion_r127509582"},"pull_request":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674","id":130637282,"html_url":"https://github.com/wifiphisher/wifiphisher/pull/674","diff_url":"https://github.com/wifiphisher/wifiphisher/pull/674.diff","patch_url":"https://github.com/wifiphisher/wifiphisher/pull/674.patch","issue_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/674","number":674,"state":"open","locked":false,"title":"refactor(lure10): increase performance by using new algorithms","user":{"login":"blackHatMonkey","id":25112506,"avatar_url":"https://avatars6.githubusercontent.com/u/25112506?v=4","gravatar_id":"","url":"https://api.github.com/users/blackHatMonkey","html_url":"https://github.com/blackHatMonkey","followers_url":"https://api.github.com/users/blackHatMonkey/followers","following_url":"https://api.github.com/users/blackHatMonkey/following{/other_user}","gists_url":"https://api.github.com/users/blackHatMonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/blackHatMonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackHatMonkey/subscriptions","organizations_url":"https://api.github.com/users/blackHatMonkey/orgs","repos_url":"https://api.github.com/users/blackHatMonkey/repos","events_url":"https://api.github.com/users/blackHatMonkey/events{/privacy}","received_events_url":"https://api.github.com/users/blackHatMonkey/received_events","type":"User","site_admin":false},"body":"Increase the performance by refactoring the code and changing the algorithms in the lure10 module.","created_at":"2017-07-14T17:35:29Z","updated_at":"2017-07-14T17:38:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd454857d59cd6faa68f34ec02f6852f1a6a1441","assignee":{"login":"sophron","id":554314,"avatar_url":"https://avatars6.githubusercontent.com/u/554314?v=4","gravatar_id":"","url":"https://api.github.com/users/sophron","html_url":"https://github.com/sophron","followers_url":"https://api.github.com/users/sophron/followers","following_url":"https://api.github.com/users/sophron/following{/other_user}","gists_url":"https://api.github.com/users/sophron/gists{/gist_id}","starred_url":"https://api.github.com/users/sophron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophron/subscriptions","organizations_url":"https://api.github.com/users/sophron/orgs","repos_url":"https://api.github.com/users/sophron/repos","events_url":"https://api.github.com/users/sophron/events{/privacy}","received_events_url":"https://api.github.com/users/sophron/received_events","type":"User","site_admin":false},"assignees":[{"login":"sophron","id":554314,"avatar_url":"https://avatars6.githubusercontent.com/u/554314?v=4","gravatar_id":"","url":"https://api.github.com/users/sophron","html_url":"https://github.com/sophron","followers_url":"https://api.github.com/users/sophron/followers","following_url":"https://api.github.com/users/sophron/following{/other_user}","gists_url":"https://api.github.com/users/sophron/gists{/gist_id}","starred_url":"https://api.github.com/users/sophron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophron/subscriptions","organizations_url":"https://api.github.com/users/sophron/orgs","repos_url":"https://api.github.com/users/sophron/repos","events_url":"https://api.github.com/users/sophron/events{/privacy}","received_events_url":"https://api.github.com/users/sophron/received_events","type":"User","site_admin":false},{"login":"anakin1028","id":6182530,"avatar_url":"https://avatars6.githubusercontent.com/u/6182530?v=4","gravatar_id":"","url":"https://api.github.com/users/anakin1028","html_url":"https://github.com/anakin1028","followers_url":"https://api.github.com/users/anakin1028/followers","following_url":"https://api.github.com/users/anakin1028/following{/other_user}","gists_url":"https://api.github.com/users/anakin1028/gists{/gist_id}","starred_url":"https://api.github.com/users/anakin1028/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anakin1028/subscriptions","organizations_url":"https://api.github.com/users/anakin1028/orgs","repos_url":"https://api.github.com/users/anakin1028/repos","events_url":"https://api.github.com/users/anakin1028/events{/privacy}","received_events_url":"https://api.github.com/users/anakin1028/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sophron","id":554314,"avatar_url":"https://avatars6.githubusercontent.com/u/554314?v=4","gravatar_id":"","url":"https://api.github.com/users/sophron","html_url":"https://github.com/sophron","followers_url":"https://api.github.com/users/sophron/followers","following_url":"https://api.github.com/users/sophron/following{/other_user}","gists_url":"https://api.github.com/users/sophron/gists{/gist_id}","starred_url":"https://api.github.com/users/sophron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophron/subscriptions","organizations_url":"https://api.github.com/users/sophron/orgs","repos_url":"https://api.github.com/users/sophron/repos","events_url":"https://api.github.com/users/sophron/events{/privacy}","received_events_url":"https://api.github.com/users/sophron/received_events","type":"User","site_admin":false},{"login":"anakin1028","id":6182530,"avatar_url":"https://avatars6.githubusercontent.com/u/6182530?v=4","gravatar_id":"","url":"https://api.github.com/users/anakin1028","html_url":"https://github.com/anakin1028","followers_url":"https://api.github.com/users/anakin1028/followers","following_url":"https://api.github.com/users/anakin1028/following{/other_user}","gists_url":"https://api.github.com/users/anakin1028/gists{/gist_id}","starred_url":"https://api.github.com/users/anakin1028/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anakin1028/subscriptions","organizations_url":"https://api.github.com/users/anakin1028/orgs","repos_url":"https://api.github.com/users/anakin1028/repos","events_url":"https://api.github.com/users/anakin1028/events{/privacy}","received_events_url":"https://api.github.com/users/anakin1028/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674/commits","review_comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674/comments","review_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/674/comments","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/201d82cd3c0b5195cf24f55bdab311e42028e17c","head":{"label":"wifiphisher:lure10-refactor","ref":"lure10-refactor","sha":"201d82cd3c0b5195cf24f55bdab311e42028e17c","user":{"login":"wifiphisher","id":25661467,"avatar_url":"https://avatars4.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"repo":{"id":24499174,"name":"wifiphisher","full_name":"wifiphisher/wifiphisher","owner":{"login":"wifiphisher","id":25661467,"avatar_url":"https://avatars4.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wifiphisher/wifiphisher","description":"Automated victim-customized phishing attacks against Wi-Fi clients","fork":false,"url":"https://api.github.com/repos/wifiphisher/wifiphisher","forks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/forks","keys_url":"https://api.github.com/repos/wifiphisher/wifiphisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wifiphisher/wifiphisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wifiphisher/wifiphisher/teams","hooks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/hooks","issue_events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/events{/number}","events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/events","assignees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/assignees{/user}","branches_url":"https://api.github.com/repos/wifiphisher/wifiphisher/branches{/branch}","tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/tags","blobs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/{sha}","languages_url":"https://api.github.com/repos/wifiphisher/wifiphisher/languages","stargazers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/stargazers","contributors_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contributors","subscribers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscribers","subscription_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscription","commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contents/{+path}","compare_url":"https://api.github.com/repos/wifiphisher/wifiphisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wifiphisher/wifiphisher/merges","archive_url":"https://api.github.com/repos/wifiphisher/wifiphisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wifiphisher/wifiphisher/downloads","issues_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues{/number}","pulls_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls{/number}","milestones_url":"https://api.github.com/repos/wifiphisher/wifiphisher/milestones{/number}","notifications_url":"https://api.github.com/repos/wifiphisher/wifiphisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wifiphisher/wifiphisher/labels{/name}","releases_url":"https://api.github.com/repos/wifiphisher/wifiphisher/releases{/id}","deployments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/deployments","created_at":"2014-09-26T12:47:28Z","updated_at":"2017-07-14T13:39:38Z","pushed_at":"2017-07-14T17:35:30Z","git_url":"git://github.com/wifiphisher/wifiphisher.git","ssh_url":"git@github.com:wifiphisher/wifiphisher.git","clone_url":"https://github.com/wifiphisher/wifiphisher.git","svn_url":"https://github.com/wifiphisher/wifiphisher","homepage":"https://wifiphisher.org","size":3565,"stargazers_count":5309,"watchers_count":5309,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1187,"mirror_url":null,"open_issues_count":71,"forks":1187,"open_issues":71,"watchers":5309,"default_branch":"master"}},"base":{"label":"wifiphisher:master","ref":"master","sha":"62b9bda1e2e65d1dffdc011bed69646555bcd5c4","user":{"login":"wifiphisher","id":25661467,"avatar_url":"https://avatars4.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"repo":{"id":24499174,"name":"wifiphisher","full_name":"wifiphisher/wifiphisher","owner":{"login":"wifiphisher","id":25661467,"avatar_url":"https://avatars4.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wifiphisher/wifiphisher","description":"Automated victim-customized phishing attacks against Wi-Fi clients","fork":false,"url":"https://api.github.com/repos/wifiphisher/wifiphisher","forks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/forks","keys_url":"https://api.github.com/repos/wifiphisher/wifiphisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wifiphisher/wifiphisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wifiphisher/wifiphisher/teams","hooks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/hooks","issue_events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/events{/number}","events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/events","assignees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/assignees{/user}","branches_url":"https://api.github.com/repos/wifiphisher/wifiphisher/branches{/branch}","tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/tags","blobs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/{sha}","languages_url":"https://api.github.com/repos/wifiphisher/wifiphisher/languages","stargazers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/stargazers","contributors_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contributors","subscribers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscribers","subscription_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscription","commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contents/{+path}","compare_url":"https://api.github.com/repos/wifiphisher/wifiphisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wifiphisher/wifiphisher/merges","archive_url":"https://api.github.com/repos/wifiphisher/wifiphisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wifiphisher/wifiphisher/downloads","issues_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues{/number}","pulls_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls{/number}","milestones_url":"https://api.github.com/repos/wifiphisher/wifiphisher/milestones{/number}","notifications_url":"https://api.github.com/repos/wifiphisher/wifiphisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wifiphisher/wifiphisher/labels{/name}","releases_url":"https://api.github.com/repos/wifiphisher/wifiphisher/releases{/id}","deployments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/deployments","created_at":"2014-09-26T12:47:28Z","updated_at":"2017-07-14T13:39:38Z","pushed_at":"2017-07-14T17:35:30Z","git_url":"git://github.com/wifiphisher/wifiphisher.git","ssh_url":"git@github.com:wifiphisher/wifiphisher.git","clone_url":"https://github.com/wifiphisher/wifiphisher.git","svn_url":"https://github.com/wifiphisher/wifiphisher","homepage":"https://wifiphisher.org","size":3565,"stargazers_count":5309,"watchers_count":5309,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1187,"mirror_url":null,"open_issues_count":71,"forks":1187,"open_issues":71,"watchers":5309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674"},"html":{"href":"https://github.com/wifiphisher/wifiphisher/pull/674"},"issue":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/674"},"comments":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/201d82cd3c0b5195cf24f55bdab311e42028e17c"}}}}
{"actor":{"display_login":"blackHatMonkey"}}