{"action":"created","issue":{"url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/21","repository_url":"https://api.github.com/repos/openzfsonwindows/ZFSin","labels_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/21/comments","events_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/21/events","html_url":"https://github.com/openzfsonwindows/ZFSin/pull/21","id":273140442,"number":21,"title":"Potential fix issue #19 Deleting files does not reclaim space","user":{"login":"gamlerhart","id":201876,"avatar_url":"https://avatars3.githubusercontent.com/u/201876?v=4","gravatar_id":"","url":"https://api.github.com/users/gamlerhart","html_url":"https://github.com/gamlerhart","followers_url":"https://api.github.com/users/gamlerhart/followers","following_url":"https://api.github.com/users/gamlerhart/following{/other_user}","gists_url":"https://api.github.com/users/gamlerhart/gists{/gist_id}","starred_url":"https://api.github.com/users/gamlerhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamlerhart/subscriptions","organizations_url":"https://api.github.com/users/gamlerhart/orgs","repos_url":"https://api.github.com/users/gamlerhart/repos","events_url":"https://api.github.com/users/gamlerhart/events{/privacy}","received_events_url":"https://api.github.com/users/gamlerhart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-11T11:55:01Z","updated_at":"2017-11-12T03:33:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/21","html_url":"https://github.com/openzfsonwindows/ZFSin/pull/21","diff_url":"https://github.com/openzfsonwindows/ZFSin/pull/21.diff","patch_url":"https://github.com/openzfsonwindows/ZFSin/pull/21.patch"},"body":"Potential fix for https://github.com/openzfsonwindows/ZFSin/issues/19. \r\n\r\nFeels icky and hacky.\r\n- In the Windows cleanup routine we may `vnode_recycle` & `zfs_znode_delete`. Then the vnode is marked as `DEAD`.\r\n- On the way out and on close, we now check if the `vnode` is dead.\r\n- Kind of strange to have a 'dead' vnode.\r\n- Also the vnode_isinuse checks seem 'icky'.\r\n\r\nProbably more correct solution?\r\n- Mark the file as pending delete. Maybe on the vnode?\r\n- Then do the `vnode_recycle` & `zfs_znode_delete` on the close, if the inuse count drops to zero.\r\n"},"comment":{"url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/comments/343711006","html_url":"https://github.com/openzfsonwindows/ZFSin/pull/21#issuecomment-343711006","issue_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/21","id":343711006,"user":{"login":"gamlerhart","id":201876,"avatar_url":"https://avatars3.githubusercontent.com/u/201876?v=4","gravatar_id":"","url":"https://api.github.com/users/gamlerhart","html_url":"https://github.com/gamlerhart","followers_url":"https://api.github.com/users/gamlerhart/followers","following_url":"https://api.github.com/users/gamlerhart/following{/other_user}","gists_url":"https://api.github.com/users/gamlerhart/gists{/gist_id}","starred_url":"https://api.github.com/users/gamlerhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamlerhart/subscriptions","organizations_url":"https://api.github.com/users/gamlerhart/orgs","repos_url":"https://api.github.com/users/gamlerhart/repos","events_url":"https://api.github.com/users/gamlerhart/events{/privacy}","received_events_url":"https://api.github.com/users/gamlerhart/received_events","type":"User","site_admin":false},"created_at":"2017-11-12T03:33:58Z","updated_at":"2017-11-12T03:33:58Z","author_association":"CONTRIBUTOR","body":"Will try moving `vnode_recycle` next to `vnode_recycle`. I hope then it flows more natural with the inuse count and vnode cleanp."}}
{"actor":{"display_login":"gamlerhart"}}