{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/101706426","pull_request_review_id":22442978,"id":101706426,"diff_hunk":"@@ -135,99 +137,117 @@ public static HitPolicy getDefault() {\n      */\n     public List<Pattern52> getPatterns() {\n         final List<Pattern52> patterns = new ArrayList<Pattern52>();\n-        for ( CompositeColumn<?> cc : conditionPatterns ) {\n-            if ( cc instanceof Pattern52 ) {\n-                patterns.add( (Pattern52) cc );\n+        for (CompositeColumn<?> cc : conditionPatterns) {\n+            if (cc instanceof Pattern52) {\n+                patterns.add((Pattern52) cc);\n             }\n         }\n-        return Collections.unmodifiableList( patterns );\n+        return Collections.unmodifiableList(patterns);\n     }\n \n     public List<CompositeColumn<? extends BaseColumn>> getConditions() {\n         return this.conditionPatterns;\n     }\n \n-    public Pattern52 getConditionPattern( final String boundName ) {\n-        for ( CompositeColumn<?> cc : conditionPatterns ) {\n-            if ( cc instanceof Pattern52 ) {\n+    public Pattern52 getConditionPattern(final String boundName) {\n+        for (CompositeColumn<?> cc : conditionPatterns) {\n+            if (cc instanceof Pattern52) {\n                 final Pattern52 p = (Pattern52) cc;\n-                if ( p.isBound() && p.getBoundName().equals( boundName ) ) {\n+                if (p.isBound() && p.getBoundName().equals(boundName)) {\n                     return p;\n                 }\n-            } else if ( cc instanceof BRLConditionColumn ) {\n+            } else if (cc instanceof BRLConditionColumn) {\n                 final BRLConditionColumn brlConditionColumn = (BRLConditionColumn) cc;\n-                for ( IPattern p : brlConditionColumn.getDefinition() ) {\n-                    if ( p instanceof FactPattern ) {\n-                        final FactPattern fp = (FactPattern) p;\n-                        if ( fp.isBound() && fp.getBoundName().equals( boundName ) ) {\n-                            return new FactPatternPattern52Adaptor( fp );\n-                        }\n+                for (IPattern p : brlConditionColumn.getDefinition()) {","path":"drools-workbench-models/drools-workbench-models-guided-dtable/src/main/java/org/drools/workbench/models/guided/dtable/shared/model/GuidedDecisionTable52.java","position":55,"original_position":55,"commit_id":"bce613c5408a156407d751378554b049afe8cefe","original_commit_id":"bce613c5408a156407d751378554b049afe8cefe","user":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"body":"This is the change in this class; instead of just checking ```FactPattern``` I use a new method ```getConditionPattern(..)```","created_at":"2017-02-17T08:22:57Z","updated_at":"2017-02-17T08:22:57Z","html_url":"https://github.com/droolsjbpm/drools/pull/1100#discussion_r101706426","pull_request_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/101706426"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/1100#discussion_r101706426"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100","id":106534912,"html_url":"https://github.com/droolsjbpm/drools/pull/1100","diff_url":"https://github.com/droolsjbpm/drools/pull/1100.diff","patch_url":"https://github.com/droolsjbpm/drools/pull/1100.patch","issue_url":"https://api.github.com/repos/droolsjbpm/drools/issues/1100","number":1100,"state":"open","locked":false,"title":"GUVNOR-2829: [Guided Decision Table] No access to bound facts from BRL Condition fragment","user":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"body":"See https://issues.jboss.org/browse/GUVNOR-2829\r\n\r\nBound Facts/Fields for the Guided Decision Table Editor were only checked in ```FactPattern``` and not also ```FromCompositeFactPattern``` as is supported by the Guided Rule Editor.","created_at":"2017-02-16T14:22:30Z","updated_at":"2017-02-17T08:22:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a78eaeb7131d066fb7f8240a89253e6daa18d6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/issues/1100/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/bce613c5408a156407d751378554b049afe8cefe","head":{"label":"manstis:GUVNOR-2829","ref":"GUVNOR-2829","sha":"bce613c5408a156407d751378554b049afe8cefe","user":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"repo":{"id":36004004,"name":"drools","full_name":"manstis/drools","owner":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manstis/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":true,"url":"https://api.github.com/repos/manstis/drools","forks_url":"https://api.github.com/repos/manstis/drools/forks","keys_url":"https://api.github.com/repos/manstis/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manstis/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manstis/drools/teams","hooks_url":"https://api.github.com/repos/manstis/drools/hooks","issue_events_url":"https://api.github.com/repos/manstis/drools/issues/events{/number}","events_url":"https://api.github.com/repos/manstis/drools/events","assignees_url":"https://api.github.com/repos/manstis/drools/assignees{/user}","branches_url":"https://api.github.com/repos/manstis/drools/branches{/branch}","tags_url":"https://api.github.com/repos/manstis/drools/tags","blobs_url":"https://api.github.com/repos/manstis/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manstis/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manstis/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/manstis/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manstis/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/manstis/drools/languages","stargazers_url":"https://api.github.com/repos/manstis/drools/stargazers","contributors_url":"https://api.github.com/repos/manstis/drools/contributors","subscribers_url":"https://api.github.com/repos/manstis/drools/subscribers","subscription_url":"https://api.github.com/repos/manstis/drools/subscription","commits_url":"https://api.github.com/repos/manstis/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/manstis/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/manstis/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/manstis/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/manstis/drools/contents/{+path}","compare_url":"https://api.github.com/repos/manstis/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manstis/drools/merges","archive_url":"https://api.github.com/repos/manstis/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manstis/drools/downloads","issues_url":"https://api.github.com/repos/manstis/drools/issues{/number}","pulls_url":"https://api.github.com/repos/manstis/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/manstis/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/manstis/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manstis/drools/labels{/name}","releases_url":"https://api.github.com/repos/manstis/drools/releases{/id}","deployments_url":"https://api.github.com/repos/manstis/drools/deployments","created_at":"2015-05-21T09:33:07Z","updated_at":"2016-01-11T09:15:21Z","pushed_at":"2017-02-16T14:18:50Z","git_url":"git://github.com/manstis/drools.git","ssh_url":"git@github.com:manstis/drools.git","clone_url":"https://github.com/manstis/drools.git","svn_url":"https://github.com/manstis/drools","homepage":"http://www.drools.org","size":141811,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"6834492fb9f141b5b425ede5fe8d91796656bdee","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1381673,"name":"drools","full_name":"droolsjbpm/drools","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":false,"url":"https://api.github.com/repos/droolsjbpm/drools","forks_url":"https://api.github.com/repos/droolsjbpm/drools/forks","keys_url":"https://api.github.com/repos/droolsjbpm/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/drools/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/drools/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/drools/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/drools/events","assignees_url":"https://api.github.com/repos/droolsjbpm/drools/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/drools/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/drools/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/drools/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/drools/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/drools/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/drools/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/drools/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/drools/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/drools/merges","archive_url":"https://api.github.com/repos/droolsjbpm/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/drools/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/drools/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/drools/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/drools/releases{/id}","deployments_url":"https://api.github.com/repos/droolsjbpm/drools/deployments","created_at":"2011-02-18T08:37:05Z","updated_at":"2017-02-17T05:54:17Z","pushed_at":"2017-02-16T14:22:31Z","git_url":"git://github.com/droolsjbpm/drools.git","ssh_url":"git@github.com:droolsjbpm/drools.git","clone_url":"https://github.com/droolsjbpm/drools.git","svn_url":"https://github.com/droolsjbpm/drools","homepage":"http://www.drools.org","size":142273,"stargazers_count":795,"watchers_count":795,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1018,"mirror_url":null,"open_issues_count":7,"forks":1018,"open_issues":7,"watchers":795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/1100"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/1100"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/drools/statuses/bce613c5408a156407d751378554b049afe8cefe"}}}}
{"actor":{"display_login":"manstis"}}