{"action":"created","issue":{"url":"https://api.github.com/repos/PolymerLabs/lit-html/issues/229","repository_url":"https://api.github.com/repos/PolymerLabs/lit-html","labels_url":"https://api.github.com/repos/PolymerLabs/lit-html/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/PolymerLabs/lit-html/issues/229/comments","events_url":"https://api.github.com/repos/PolymerLabs/lit-html/issues/229/events","html_url":"https://github.com/PolymerLabs/lit-html/pull/229","id":281900357,"number":229,"title":"Switch to using text nodes with a marker instead of empty comment nodes","user":{"login":"bgotink","id":821510,"avatar_url":"https://avatars1.githubusercontent.com/u/821510?v=4","gravatar_id":"","url":"https://api.github.com/users/bgotink","html_url":"https://github.com/bgotink","followers_url":"https://api.github.com/users/bgotink/followers","following_url":"https://api.github.com/users/bgotink/following{/other_user}","gists_url":"https://api.github.com/users/bgotink/gists{/gist_id}","starred_url":"https://api.github.com/users/bgotink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgotink/subscriptions","organizations_url":"https://api.github.com/users/bgotink/orgs","repos_url":"https://api.github.com/users/bgotink/repos","events_url":"https://api.github.com/users/bgotink/events{/privacy}","received_events_url":"https://api.github.com/users/bgotink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-13T21:18:56Z","updated_at":"2017-12-15T12:48:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PolymerLabs/lit-html/pulls/229","html_url":"https://github.com/PolymerLabs/lit-html/pull/229","diff_url":"https://github.com/PolymerLabs/lit-html/pull/229.diff","patch_url":"https://github.com/PolymerLabs/lit-html/pull/229.patch"},"body":"Comment nodes are problematic when inserted into textContent, e.g. a `<style>`\r\nelement. This commit changes to using a text node with a marker content rather\r\nthan an empty comment. The markers are removed at clone time.\r\n\r\nAll of this is implemented using a platform check to ensure that we only do\r\nthis on platforms that don't clone empty text nodes (IE).\r\n\r\nFixes #214\r\n\r\nNote: not yet tested on IE because I can't access any Windows machine/vm atm."},"comment":{"url":"https://api.github.com/repos/PolymerLabs/lit-html/issues/comments/351997855","html_url":"https://github.com/PolymerLabs/lit-html/pull/229#issuecomment-351997855","issue_url":"https://api.github.com/repos/PolymerLabs/lit-html/issues/229","id":351997855,"user":{"login":"daKmoR","id":24378,"avatar_url":"https://avatars2.githubusercontent.com/u/24378?v=4","gravatar_id":"","url":"https://api.github.com/users/daKmoR","html_url":"https://github.com/daKmoR","followers_url":"https://api.github.com/users/daKmoR/followers","following_url":"https://api.github.com/users/daKmoR/following{/other_user}","gists_url":"https://api.github.com/users/daKmoR/gists{/gist_id}","starred_url":"https://api.github.com/users/daKmoR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daKmoR/subscriptions","organizations_url":"https://api.github.com/users/daKmoR/orgs","repos_url":"https://api.github.com/users/daKmoR/repos","events_url":"https://api.github.com/users/daKmoR/events{/privacy}","received_events_url":"https://api.github.com/users/daKmoR/received_events","type":"User","site_admin":false},"created_at":"2017-12-15T12:48:47Z","updated_at":"2017-12-15T12:48:47Z","author_association":"CONTRIBUTOR","body":"running this in IE11\r\n```\r\nvar envDoesntCloneEmptyTextNodes = function() {\r\n var container = document.createElement('template');\r\n container.content.appendChild(document.createTextNode(''));\r\n return !document.importNode(container.content, true).childNodes.length;\r\n}();\r\nconsole.log(envDoesntCloneEmptyTextNodes); // true\r\n```\r\n\r\nso that should be fine...\r\n\r\n"}}
{"actor":{"display_login":"daKmoR"}}