{"push_id":2066496151,"size":4,"distinct_size":4,"ref":"refs/heads/master","head":"f8b5bb2fd82a39ab4c0b27d21bd492bc61177742","before":"ebab2e2d42bd13a85b355264603d63f9f988572f","commits":[{"sha":"f0804db7f722b0a3bb03f7392d96c5118e6235da","author":{"name":"Sagar Vemuri","email":"a88052e63a10b8355704b4b45d2cf40cba2ee75c@fb.com"},"message":"Make FIFO compaction options dynamically configurable\n\nSummary:\nColumnFamilyOptions::compaction_options_fifo and all its sub-fields can be set dynamically now.\n\nSome of the ways in which the fifo compaction options can be set are:\n- `SetOptions({{\"compaction_options_fifo\", \"{max_table_files_size=1024}\"}})`\n- `SetOptions({{\"compaction_options_fifo\", \"{ttl=600;}\"}})`\n- `SetOptions({{\"compaction_options_fifo\", \"{max_table_files_size=1024;ttl=600;}\"}})`\n- `SetOptions({{\"compaction_options_fifo\", \"{max_table_files_size=51;ttl=49;allow_compaction=true;}\"}})`\n\nMost of the code has been made generic enough so that it could be reused later to make universal options (and other such nested defined-types) dynamic with very few lines of parsing/serializing code changes.\nIntroduced a few new functions like `ParseStruct`, `SerializeStruct` and `GetStringFromStruct`.\nThe duplicate code in `GetStringFromDBOptions` and `GetStringFromColumnFamilyOptions` has been moved into `GetStringFromStruct`. So they become just simple wrappers now.\nCloses https://github.com/facebook/rocksdb/pull/3006\n\nDifferential Revision: D6058619\n\nPulled By: sagar0\n\nfbshipit-source-id: 1e8f78b3374ca5249bb4f3be8a6d3bb4cbc52f92","distinct":true,"url":"https://api.github.com/repos/zhouyuan/rocksdb/commits/f0804db7f722b0a3bb03f7392d96c5118e6235da"},{"sha":"ee2b1ec1e8776d6ed154f2d66435be8e2a620da5","author":{"name":"raistlin","email":"2f24b7fb51f172926d48af5e56b6badf05a08452@gmail.com"},"message":"Fix unstable floating point exception\n\nSummary:\nFix unstable floating point exception, tested on Windows, 64-bit build.\nThe problem appeared in `SetCapacity()` method at line\n\n`high_pri_pool_capacity_ = capacity_ * high_pri_pool_ratio_;`\n\n`high_pri_pool_ratio_` was not initialized at that moment, because\n`SetHighPriorityPoolRatio()` is called after `SetCapacity()`. So,\n`high_pri_pool_ratio_` contained garbage, which caused \"Floating point\nexception\" sometimes.\nCloses https://github.com/facebook/rocksdb/pull/3052\n\nDifferential Revision: D6111161\n\nPulled By: yiwu-arbug\n\nfbshipit-source-id: d170329111ad12b4bf9bbcf37bcb6411523438ae","distinct":true,"url":"https://api.github.com/repos/zhouyuan/rocksdb/commits/ee2b1ec1e8776d6ed154f2d66435be8e2a620da5"},{"sha":"57fd4a823b79dcd982dc67d50018632bd31fcd45","author":{"name":"Andrew Kryczka","email":"2767857978544a72f0f744c149483746f43eec21@fb.com"},"message":"update HISTORY with recent changes\n\nSummary:\nWe should mention these:\n\n- `EventListener::OnStallConditionsChanged()` in 01542400a87ad130aed790bf895c029082745cbe\n- `DeleteRange()` fix in 966b32b57c673774ea677fe3a40d255e6c8916ba\nCloses https://github.com/facebook/rocksdb/pull/3054\n\nDifferential Revision: D6113989\n\nPulled By: ajkr\n\nfbshipit-source-id: d5e058e1ab07570df22936e8d5939fb30fb4d381","distinct":true,"url":"https://api.github.com/repos/zhouyuan/rocksdb/commits/57fd4a823b79dcd982dc67d50018632bd31fcd45"},{"sha":"f8b5bb2fd82a39ab4c0b27d21bd492bc61177742","author":{"name":"Andrew Kryczka","email":"2767857978544a72f0f744c149483746f43eec21@fb.com"},"message":"remove unused code\n\nSummary:\nfixup 6a541afcc4d1e5b6e6d78e288b9bee3bb2a933b5. This code didn't do anything because (1) `bytes_per_sync` is assigned in `EnvOptions`'s constructor; and (2) `OptimizeForCompactionTableWrite`'s return value was ignored, even though its only purpose is to return something.\nCloses https://github.com/facebook/rocksdb/pull/3055\n\nDifferential Revision: D6114132\n\nPulled By: ajkr\n\nfbshipit-source-id: ea4831770930e9cf83518e13eb2e1934d1f5487c","distinct":true,"url":"https://api.github.com/repos/zhouyuan/rocksdb/commits/f8b5bb2fd82a39ab4c0b27d21bd492bc61177742"}]}
{"actor":{"display_login":"zhouyuan"}}