{"action":"created","comment":{"url":"https://api.github.com/repos/docker/notary/pulls/comments/98058994","pull_request_review_id":18688673,"id":98058994,"diff_hunk":"@@ -300,15 +300,15 @@ func Test0Dot3RepoFormat(t *testing.T) {\n \n // Ensures that the current client can download metadata that is published from notary 0.1 repos\n func TestDownloading0Dot1RepoFormat(t *testing.T) {\n-\tgun := \"docker.com/notary0.1/samplerepo\"\n+\tgun := data.NewGUN(\"docker.com/notary0.1/samplerepo\")\n \tpasswd := \"randompass\"\n \n \tmetaCache, err := store.NewFileStore(\n-\t\tfilepath.Join(\"../fixtures/compatibility/notary0.1/tuf\", filepath.FromSlash(gun), \"metadata\"),\n+\t\tfilepath.Join(\"../fixtures/compatibility/notary0.1/tuf\", filepath.FromSlash(gun.String()), \"metadata\"),\n \t\t\"json\")\n \trequire.NoError(t, err)\n \n-\tts := readOnlyServer(t, metaCache, http.StatusNotFound, gun)\n+\tts := readOnlyServer(t, metaCache, http.StatusNotFound, gun.String())","path":"client/backwards_compatibility_test.go","position":78,"original_position":78,"commit_id":"c3b9c80254d0cba17487348170ea2c0994130079","original_commit_id":"c3b9c80254d0cba17487348170ea2c0994130079","user":{"login":"ecordell","id":58055,"avatar_url":"https://avatars.githubusercontent.com/u/58055?v=3","gravatar_id":"","url":"https://api.github.com/users/ecordell","html_url":"https://github.com/ecordell","followers_url":"https://api.github.com/users/ecordell/followers","following_url":"https://api.github.com/users/ecordell/following{/other_user}","gists_url":"https://api.github.com/users/ecordell/gists{/gist_id}","starred_url":"https://api.github.com/users/ecordell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecordell/subscriptions","organizations_url":"https://api.github.com/users/ecordell/orgs","repos_url":"https://api.github.com/users/ecordell/repos","events_url":"https://api.github.com/users/ecordell/events{/privacy}","received_events_url":"https://api.github.com/users/ecordell/received_events","type":"User","site_admin":false},"body":"Why not make `readOnlyServer` take a `data.GUN` instead of a string?","created_at":"2017-01-26T18:31:14Z","updated_at":"2017-01-26T18:38:16Z","html_url":"https://github.com/docker/notary/pull/1087#discussion_r98058994","pull_request_url":"https://api.github.com/repos/docker/notary/pulls/1087","_links":{"self":{"href":"https://api.github.com/repos/docker/notary/pulls/comments/98058994"},"html":{"href":"https://github.com/docker/notary/pull/1087#discussion_r98058994"},"pull_request":{"href":"https://api.github.com/repos/docker/notary/pulls/1087"}}},"pull_request":{"url":"https://api.github.com/repos/docker/notary/pulls/1087","id":103221477,"html_url":"https://github.com/docker/notary/pull/1087","diff_url":"https://github.com/docker/notary/pull/1087.diff","patch_url":"https://github.com/docker/notary/pull/1087.patch","issue_url":"https://api.github.com/repos/docker/notary/issues/1087","number":1087,"state":"open","locked":false,"title":"WIP: Type updates","user":{"login":"grantleehoffman","id":603848,"avatar_url":"https://avatars.githubusercontent.com/u/603848?v=3","gravatar_id":"","url":"https://api.github.com/users/grantleehoffman","html_url":"https://github.com/grantleehoffman","followers_url":"https://api.github.com/users/grantleehoffman/followers","following_url":"https://api.github.com/users/grantleehoffman/following{/other_user}","gists_url":"https://api.github.com/users/grantleehoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/grantleehoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantleehoffman/subscriptions","organizations_url":"https://api.github.com/users/grantleehoffman/orgs","repos_url":"https://api.github.com/users/grantleehoffman/repos","events_url":"https://api.github.com/users/grantleehoffman/events{/privacy}","received_events_url":"https://api.github.com/users/grantleehoffman/received_events","type":"User","site_admin":false},"body":"This PR is for Issue #997  \r\nI'm having some issues narrowing down the test failures. I am also seeing a large number of output errors while running `make test`. Hoping some of you more familiar with the codebase could help me narrow down the cause of the issues. I apologize in advance for the large number of changes in this PR. What I thought would be a small change turned into a very large project, touching a lot of the existing code. Thanks in advance!","created_at":"2017-01-25T22:50:59Z","updated_at":"2017-01-26T18:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0289f85a343a0035e5e98364aa7571758b023f44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/notary/pulls/1087/commits","review_comments_url":"https://api.github.com/repos/docker/notary/pulls/1087/comments","review_comment_url":"https://api.github.com/repos/docker/notary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/notary/issues/1087/comments","statuses_url":"https://api.github.com/repos/docker/notary/statuses/c3b9c80254d0cba17487348170ea2c0994130079","head":{"label":"grantleehoffman:type_updates","ref":"type_updates","sha":"c3b9c80254d0cba17487348170ea2c0994130079","user":{"login":"grantleehoffman","id":603848,"avatar_url":"https://avatars.githubusercontent.com/u/603848?v=3","gravatar_id":"","url":"https://api.github.com/users/grantleehoffman","html_url":"https://github.com/grantleehoffman","followers_url":"https://api.github.com/users/grantleehoffman/followers","following_url":"https://api.github.com/users/grantleehoffman/following{/other_user}","gists_url":"https://api.github.com/users/grantleehoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/grantleehoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantleehoffman/subscriptions","organizations_url":"https://api.github.com/users/grantleehoffman/orgs","repos_url":"https://api.github.com/users/grantleehoffman/repos","events_url":"https://api.github.com/users/grantleehoffman/events{/privacy}","received_events_url":"https://api.github.com/users/grantleehoffman/received_events","type":"User","site_admin":false},"repo":{"id":78689108,"name":"notary","full_name":"grantleehoffman/notary","owner":{"login":"grantleehoffman","id":603848,"avatar_url":"https://avatars.githubusercontent.com/u/603848?v=3","gravatar_id":"","url":"https://api.github.com/users/grantleehoffman","html_url":"https://github.com/grantleehoffman","followers_url":"https://api.github.com/users/grantleehoffman/followers","following_url":"https://api.github.com/users/grantleehoffman/following{/other_user}","gists_url":"https://api.github.com/users/grantleehoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/grantleehoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantleehoffman/subscriptions","organizations_url":"https://api.github.com/users/grantleehoffman/orgs","repos_url":"https://api.github.com/users/grantleehoffman/repos","events_url":"https://api.github.com/users/grantleehoffman/events{/privacy}","received_events_url":"https://api.github.com/users/grantleehoffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grantleehoffman/notary","description":"Notary is a Docker project that allows anyone to have trust over arbitrary collections of data","fork":true,"url":"https://api.github.com/repos/grantleehoffman/notary","forks_url":"https://api.github.com/repos/grantleehoffman/notary/forks","keys_url":"https://api.github.com/repos/grantleehoffman/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grantleehoffman/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grantleehoffman/notary/teams","hooks_url":"https://api.github.com/repos/grantleehoffman/notary/hooks","issue_events_url":"https://api.github.com/repos/grantleehoffman/notary/issues/events{/number}","events_url":"https://api.github.com/repos/grantleehoffman/notary/events","assignees_url":"https://api.github.com/repos/grantleehoffman/notary/assignees{/user}","branches_url":"https://api.github.com/repos/grantleehoffman/notary/branches{/branch}","tags_url":"https://api.github.com/repos/grantleehoffman/notary/tags","blobs_url":"https://api.github.com/repos/grantleehoffman/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grantleehoffman/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grantleehoffman/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/grantleehoffman/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grantleehoffman/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/grantleehoffman/notary/languages","stargazers_url":"https://api.github.com/repos/grantleehoffman/notary/stargazers","contributors_url":"https://api.github.com/repos/grantleehoffman/notary/contributors","subscribers_url":"https://api.github.com/repos/grantleehoffman/notary/subscribers","subscription_url":"https://api.github.com/repos/grantleehoffman/notary/subscription","commits_url":"https://api.github.com/repos/grantleehoffman/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/grantleehoffman/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/grantleehoffman/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/grantleehoffman/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/grantleehoffman/notary/contents/{+path}","compare_url":"https://api.github.com/repos/grantleehoffman/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grantleehoffman/notary/merges","archive_url":"https://api.github.com/repos/grantleehoffman/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grantleehoffman/notary/downloads","issues_url":"https://api.github.com/repos/grantleehoffman/notary/issues{/number}","pulls_url":"https://api.github.com/repos/grantleehoffman/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/grantleehoffman/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/grantleehoffman/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grantleehoffman/notary/labels{/name}","releases_url":"https://api.github.com/repos/grantleehoffman/notary/releases{/id}","deployments_url":"https://api.github.com/repos/grantleehoffman/notary/deployments","created_at":"2017-01-11T23:22:43Z","updated_at":"2017-01-11T23:22:47Z","pushed_at":"2017-01-26T17:06:31Z","git_url":"git://github.com/grantleehoffman/notary.git","ssh_url":"git@github.com:grantleehoffman/notary.git","clone_url":"https://github.com/grantleehoffman/notary.git","svn_url":"https://github.com/grantleehoffman/notary","homepage":"https://docker.com","size":28935,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"905fffb0287f5ca965b8d607e427988d7c813017","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":37743436,"name":"notary","full_name":"docker/notary","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/notary","description":"Notary is a Docker project that allows anyone to have trust over arbitrary collections of data","fork":false,"url":"https://api.github.com/repos/docker/notary","forks_url":"https://api.github.com/repos/docker/notary/forks","keys_url":"https://api.github.com/repos/docker/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/notary/teams","hooks_url":"https://api.github.com/repos/docker/notary/hooks","issue_events_url":"https://api.github.com/repos/docker/notary/issues/events{/number}","events_url":"https://api.github.com/repos/docker/notary/events","assignees_url":"https://api.github.com/repos/docker/notary/assignees{/user}","branches_url":"https://api.github.com/repos/docker/notary/branches{/branch}","tags_url":"https://api.github.com/repos/docker/notary/tags","blobs_url":"https://api.github.com/repos/docker/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/notary/languages","stargazers_url":"https://api.github.com/repos/docker/notary/stargazers","contributors_url":"https://api.github.com/repos/docker/notary/contributors","subscribers_url":"https://api.github.com/repos/docker/notary/subscribers","subscription_url":"https://api.github.com/repos/docker/notary/subscription","commits_url":"https://api.github.com/repos/docker/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/notary/contents/{+path}","compare_url":"https://api.github.com/repos/docker/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/notary/merges","archive_url":"https://api.github.com/repos/docker/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/notary/downloads","issues_url":"https://api.github.com/repos/docker/notary/issues{/number}","pulls_url":"https://api.github.com/repos/docker/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/notary/labels{/name}","releases_url":"https://api.github.com/repos/docker/notary/releases{/id}","deployments_url":"https://api.github.com/repos/docker/notary/deployments","created_at":"2015-06-19T20:07:53Z","updated_at":"2017-01-26T05:32:18Z","pushed_at":"2017-01-26T17:07:09Z","git_url":"git://github.com/docker/notary.git","ssh_url":"git@github.com:docker/notary.git","clone_url":"https://github.com/docker/notary.git","svn_url":"https://github.com/docker/notary","homepage":"https://docker.com","size":28868,"stargazers_count":789,"watchers_count":789,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":122,"forks":124,"open_issues":122,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/notary/pulls/1087"},"html":{"href":"https://github.com/docker/notary/pull/1087"},"issue":{"href":"https://api.github.com/repos/docker/notary/issues/1087"},"comments":{"href":"https://api.github.com/repos/docker/notary/issues/1087/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/notary/pulls/1087/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/notary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/notary/pulls/1087/commits"},"statuses":{"href":"https://api.github.com/repos/docker/notary/statuses/c3b9c80254d0cba17487348170ea2c0994130079"}}}}
{"actor":{"display_login":"ecordell"}}