{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/95047181","pull_request_review_id":15594627,"id":95047181,"diff_hunk":"@@ -146,6 +148,7 @@ class LanguageServiceImpl implements LanguageService {\n         span = template.query.getSpanAt(e.line, e.column) || span;\n       }\n       result = {errors: [{kind: DiagnosticKind.Error, message: e.message, span}]};\n+      throw e;","path":"modules/@angular/language-service/src/language_service.ts","position":29,"original_position":29,"commit_id":"e8656cba5146f439319b9bdef483878b978e86b5","original_commit_id":"65989f1e54e432fc1c8fe0729a8d535913333c82","user":{"login":"RyanCavanaugh","id":6685088,"avatar_url":"https://avatars.githubusercontent.com/u/6685088?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanCavanaugh","html_url":"https://github.com/RyanCavanaugh","followers_url":"https://api.github.com/users/RyanCavanaugh/followers","following_url":"https://api.github.com/users/RyanCavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/RyanCavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanCavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanCavanaugh/subscriptions","organizations_url":"https://api.github.com/users/RyanCavanaugh/orgs","repos_url":"https://api.github.com/users/RyanCavanaugh/repos","events_url":"https://api.github.com/users/RyanCavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/RyanCavanaugh/received_events","type":"User","site_admin":false},"body":"Removed","created_at":"2017-01-07T01:15:42Z","updated_at":"2017-01-07T01:15:42Z","html_url":"https://github.com/angular/angular/pull/13716#discussion_r95047181","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/13716","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/95047181"},"html":{"href":"https://github.com/angular/angular/pull/13716#discussion_r95047181"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/13716"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/13716","id":99712780,"html_url":"https://github.com/angular/angular/pull/13716","diff_url":"https://github.com/angular/angular/pull/13716.diff","patch_url":"https://github.com/angular/angular/pull/13716.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/13716","number":13716,"state":"open","locked":false,"title":"Support TypeScript plugin extensibility model for Language Service features","user":{"login":"RyanCavanaugh","id":6685088,"avatar_url":"https://avatars.githubusercontent.com/u/6685088?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanCavanaugh","html_url":"https://github.com/RyanCavanaugh","followers_url":"https://api.github.com/users/RyanCavanaugh/followers","following_url":"https://api.github.com/users/RyanCavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/RyanCavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanCavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanCavanaugh/subscriptions","organizations_url":"https://api.github.com/users/RyanCavanaugh/orgs","repos_url":"https://api.github.com/users/RyanCavanaugh/repos","events_url":"https://api.github.com/users/RyanCavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/RyanCavanaugh/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features) (n/a)\r\n- [x] Docs have been added / updated (for bug fixes / features) (n/a)\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[ ] Bugfix\r\n[x] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nNo language service for the new TypeScript plugin model exists\r\n\r\n**What is the new behavior?**\r\nA language service for the new TypeScript plugin model exists\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n**Other information**:\r\n\r\nCommits in this PR:\r\n* **Add some null checking**: Additional diagnostics\r\n* **Avoid crashing in certain situations**: Null checks were missing in a few places\r\n* **Port ts2.1 compat fixes from Chuck**: Patches from @chuckjaz to make things cross-compatible with TS2.0 and TS2.1\r\n* **Support new plugin model from TypeScript**: New proxy LS plugin model\r\n* **'create' method from LS module**: Expose the plugin factory function from the language-service module\r\n\r\nWhen the corresponding PR Microsoft/TypeScript#12231 goes in, the following workflow will be enabled:\r\n * Clone `angular/quickstart`\r\n * Add `\"plugins\": [{ \"name\": \"@angular/language-service\" }, }]` to `tsconfig.json`\r\n * `npm install --save-dev @angular/language-service`\r\n * :tada: Completions, go-to-def, diagnostics, and hover info appear in VS Code and other tsserver-based plugins\r\n","created_at":"2016-12-30T00:35:56Z","updated_at":"2017-01-07T01:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"003e4c1a6776f0c3513ddaded8cde40ea7ee274d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/13716/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/13716/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/13716/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/e8656cba5146f439319b9bdef483878b978e86b5","head":{"label":"RyanCavanaugh:ls-fixes","ref":"ls-fixes","sha":"e8656cba5146f439319b9bdef483878b978e86b5","user":{"login":"RyanCavanaugh","id":6685088,"avatar_url":"https://avatars.githubusercontent.com/u/6685088?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanCavanaugh","html_url":"https://github.com/RyanCavanaugh","followers_url":"https://api.github.com/users/RyanCavanaugh/followers","following_url":"https://api.github.com/users/RyanCavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/RyanCavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanCavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanCavanaugh/subscriptions","organizations_url":"https://api.github.com/users/RyanCavanaugh/orgs","repos_url":"https://api.github.com/users/RyanCavanaugh/repos","events_url":"https://api.github.com/users/RyanCavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/RyanCavanaugh/received_events","type":"User","site_admin":false},"repo":{"id":75126094,"name":"angular","full_name":"RyanCavanaugh/angular","owner":{"login":"RyanCavanaugh","id":6685088,"avatar_url":"https://avatars.githubusercontent.com/u/6685088?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanCavanaugh","html_url":"https://github.com/RyanCavanaugh","followers_url":"https://api.github.com/users/RyanCavanaugh/followers","following_url":"https://api.github.com/users/RyanCavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/RyanCavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanCavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanCavanaugh/subscriptions","organizations_url":"https://api.github.com/users/RyanCavanaugh/orgs","repos_url":"https://api.github.com/users/RyanCavanaugh/repos","events_url":"https://api.github.com/users/RyanCavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/RyanCavanaugh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RyanCavanaugh/angular","description":null,"fork":true,"url":"https://api.github.com/repos/RyanCavanaugh/angular","forks_url":"https://api.github.com/repos/RyanCavanaugh/angular/forks","keys_url":"https://api.github.com/repos/RyanCavanaugh/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RyanCavanaugh/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RyanCavanaugh/angular/teams","hooks_url":"https://api.github.com/repos/RyanCavanaugh/angular/hooks","issue_events_url":"https://api.github.com/repos/RyanCavanaugh/angular/issues/events{/number}","events_url":"https://api.github.com/repos/RyanCavanaugh/angular/events","assignees_url":"https://api.github.com/repos/RyanCavanaugh/angular/assignees{/user}","branches_url":"https://api.github.com/repos/RyanCavanaugh/angular/branches{/branch}","tags_url":"https://api.github.com/repos/RyanCavanaugh/angular/tags","blobs_url":"https://api.github.com/repos/RyanCavanaugh/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RyanCavanaugh/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RyanCavanaugh/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/RyanCavanaugh/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RyanCavanaugh/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/RyanCavanaugh/angular/languages","stargazers_url":"https://api.github.com/repos/RyanCavanaugh/angular/stargazers","contributors_url":"https://api.github.com/repos/RyanCavanaugh/angular/contributors","subscribers_url":"https://api.github.com/repos/RyanCavanaugh/angular/subscribers","subscription_url":"https://api.github.com/repos/RyanCavanaugh/angular/subscription","commits_url":"https://api.github.com/repos/RyanCavanaugh/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/RyanCavanaugh/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/RyanCavanaugh/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/RyanCavanaugh/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/RyanCavanaugh/angular/contents/{+path}","compare_url":"https://api.github.com/repos/RyanCavanaugh/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RyanCavanaugh/angular/merges","archive_url":"https://api.github.com/repos/RyanCavanaugh/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RyanCavanaugh/angular/downloads","issues_url":"https://api.github.com/repos/RyanCavanaugh/angular/issues{/number}","pulls_url":"https://api.github.com/repos/RyanCavanaugh/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/RyanCavanaugh/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/RyanCavanaugh/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RyanCavanaugh/angular/labels{/name}","releases_url":"https://api.github.com/repos/RyanCavanaugh/angular/releases{/id}","deployments_url":"https://api.github.com/repos/RyanCavanaugh/angular/deployments","created_at":"2016-11-29T22:01:16Z","updated_at":"2016-11-29T22:01:39Z","pushed_at":"2017-01-06T22:03:04Z","git_url":"git://github.com/RyanCavanaugh/angular.git","ssh_url":"git@github.com:RyanCavanaugh/angular.git","clone_url":"https://github.com/RyanCavanaugh/angular.git","svn_url":"https://github.com/RyanCavanaugh/angular","homepage":"https://angular.io","size":35114,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1c85e9958874402b404909056bec64a13763984d","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":null,"fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-01-07T00:23:01Z","pushed_at":"2017-01-07T00:28:37Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":35572,"stargazers_count":19533,"watchers_count":19533,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5071,"mirror_url":null,"open_issues_count":994,"forks":5071,"open_issues":994,"watchers":19533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/13716"},"html":{"href":"https://github.com/angular/angular/pull/13716"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/13716"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/13716/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/13716/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/13716/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/e8656cba5146f439319b9bdef483878b978e86b5"}}}}
{"actor":{"display_login":"RyanCavanaugh"}}