{"action":"created","comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments/96021123","pull_request_review_id":16595964,"id":96021123,"diff_hunk":"@@ -2,29 +2,29 @@\n \n email = email\n \n-err.logerr = Login Error\n+err.logerr = Log in Error\n \n gen.alert = \n \n invalid = Invalid\n \n log.log    = Log in\n log.cancel = Cancel\n-log.login  = Login\n-log.logreq = Login Required\n+log.login  = Log in\n+log.logreq = Log in Required\n log.pass   = password\n-log.ple    = Please Login\n+log.ple    = Please Log in\n \n orpass = or password\n \n userid = user id\n \n wel.wel = Welcome\n \n-log.invalid = Invalid login\n-log.canceled = Login canceled\n+log.invalid = Invalid log in","path":"login/login-tool/tool/src/bundle/auth.properties","position":29,"original_position":29,"commit_id":"c63ea3e0ee638eefd8ef7ad9244e023ca3034e97","original_commit_id":"c63ea3e0ee638eefd8ef7ad9244e023ca3034e97","user":{"login":"ottenhoff","id":810505,"avatar_url":"https://avatars.githubusercontent.com/u/810505?v=3","gravatar_id":"","url":"https://api.github.com/users/ottenhoff","html_url":"https://github.com/ottenhoff","followers_url":"https://api.github.com/users/ottenhoff/followers","following_url":"https://api.github.com/users/ottenhoff/following{/other_user}","gists_url":"https://api.github.com/users/ottenhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ottenhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottenhoff/subscriptions","organizations_url":"https://api.github.com/users/ottenhoff/orgs","repos_url":"https://api.github.com/users/ottenhoff/repos","events_url":"https://api.github.com/users/ottenhoff/events{/privacy}","received_events_url":"https://api.github.com/users/ottenhoff/received_events","type":"User","site_admin":false},"body":"Isn't \"invalid\" modifying the noun \"login\"?","created_at":"2017-01-13T15:52:07Z","updated_at":"2017-01-13T15:52:08Z","html_url":"https://github.com/sakaiproject/sakai/pull/3757#discussion_r96021123","pull_request_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757","_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments/96021123"},"html":{"href":"https://github.com/sakaiproject/sakai/pull/3757#discussion_r96021123"},"pull_request":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757"}}},"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757","id":101287149,"html_url":"https://github.com/sakaiproject/sakai/pull/3757","diff_url":"https://github.com/sakaiproject/sakai/pull/3757.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/3757.patch","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3757","number":3757,"state":"open","locked":false,"title":"SAK-32085 xlogin screen still uses 'login' instead of 'log in'","user":{"login":"bjones86","id":10403943,"avatar_url":"https://avatars.githubusercontent.com/u/10403943?v=3","gravatar_id":"","url":"https://api.github.com/users/bjones86","html_url":"https://github.com/bjones86","followers_url":"https://api.github.com/users/bjones86/followers","following_url":"https://api.github.com/users/bjones86/following{/other_user}","gists_url":"https://api.github.com/users/bjones86/gists{/gist_id}","starred_url":"https://api.github.com/users/bjones86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjones86/subscriptions","organizations_url":"https://api.github.com/users/bjones86/orgs","repos_url":"https://api.github.com/users/bjones86/repos","events_url":"https://api.github.com/users/bjones86/events{/privacy}","received_events_url":"https://api.github.com/users/bjones86/received_events","type":"User","site_admin":false},"body":"https://jira.sakaiproject.org/browse/SAK-32085\r\n\r\nThe xlogin screen (when you type your password wrong) still says \"Login required\" and \"Invalid login\", and the button is still \"Login\". See SAK-29728 for reasoning behind the switch from \"login\" to \"log in\".\r\n\r\nhttps://jira.sakaiproject.org/browse/SAK-29728","created_at":"2017-01-12T15:59:14Z","updated_at":"2017-01-13T15:52:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"279d854d2cc9d4e40f9aa711f9cf5ab470e68e09","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757/commits","review_comments_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757/comments","review_comment_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3757/comments","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/c63ea3e0ee638eefd8ef7ad9244e023ca3034e97","head":{"label":"bjones86:SAK-32085","ref":"SAK-32085","sha":"c63ea3e0ee638eefd8ef7ad9244e023ca3034e97","user":{"login":"bjones86","id":10403943,"avatar_url":"https://avatars.githubusercontent.com/u/10403943?v=3","gravatar_id":"","url":"https://api.github.com/users/bjones86","html_url":"https://github.com/bjones86","followers_url":"https://api.github.com/users/bjones86/followers","following_url":"https://api.github.com/users/bjones86/following{/other_user}","gists_url":"https://api.github.com/users/bjones86/gists{/gist_id}","starred_url":"https://api.github.com/users/bjones86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjones86/subscriptions","organizations_url":"https://api.github.com/users/bjones86/orgs","repos_url":"https://api.github.com/users/bjones86/repos","events_url":"https://api.github.com/users/bjones86/events{/privacy}","received_events_url":"https://api.github.com/users/bjones86/received_events","type":"User","site_admin":false},"repo":{"id":28820362,"name":"sakai","full_name":"bjones86/sakai","owner":{"login":"bjones86","id":10403943,"avatar_url":"https://avatars.githubusercontent.com/u/10403943?v=3","gravatar_id":"","url":"https://api.github.com/users/bjones86","html_url":"https://github.com/bjones86","followers_url":"https://api.github.com/users/bjones86/followers","following_url":"https://api.github.com/users/bjones86/following{/other_user}","gists_url":"https://api.github.com/users/bjones86/gists{/gist_id}","starred_url":"https://api.github.com/users/bjones86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjones86/subscriptions","organizations_url":"https://api.github.com/users/bjones86/orgs","repos_url":"https://api.github.com/users/bjones86/repos","events_url":"https://api.github.com/users/bjones86/events{/privacy}","received_events_url":"https://api.github.com/users/bjones86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjones86/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":true,"url":"https://api.github.com/repos/bjones86/sakai","forks_url":"https://api.github.com/repos/bjones86/sakai/forks","keys_url":"https://api.github.com/repos/bjones86/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjones86/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjones86/sakai/teams","hooks_url":"https://api.github.com/repos/bjones86/sakai/hooks","issue_events_url":"https://api.github.com/repos/bjones86/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/bjones86/sakai/events","assignees_url":"https://api.github.com/repos/bjones86/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/bjones86/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/bjones86/sakai/tags","blobs_url":"https://api.github.com/repos/bjones86/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjones86/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjones86/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjones86/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjones86/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/bjones86/sakai/languages","stargazers_url":"https://api.github.com/repos/bjones86/sakai/stargazers","contributors_url":"https://api.github.com/repos/bjones86/sakai/contributors","subscribers_url":"https://api.github.com/repos/bjones86/sakai/subscribers","subscription_url":"https://api.github.com/repos/bjones86/sakai/subscription","commits_url":"https://api.github.com/repos/bjones86/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjones86/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjones86/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjones86/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjones86/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/bjones86/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjones86/sakai/merges","archive_url":"https://api.github.com/repos/bjones86/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjones86/sakai/downloads","issues_url":"https://api.github.com/repos/bjones86/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/bjones86/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/bjones86/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/bjones86/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjones86/sakai/labels{/name}","releases_url":"https://api.github.com/repos/bjones86/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/bjones86/sakai/deployments","created_at":"2015-01-05T16:14:36Z","updated_at":"2016-10-24T13:54:52Z","pushed_at":"2017-01-12T20:27:32Z","git_url":"git://github.com/bjones86/sakai.git","ssh_url":"git@github.com:bjones86/sakai.git","clone_url":"https://github.com/bjones86/sakai.git","svn_url":"https://github.com/bjones86/sakai","homepage":"https://www.sakaiproject.org","size":319041,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sakaiproject:master","ref":"master","sha":"20e3d7eb15e8da4a533ca7f36ae1f2dc29d3360a","user":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars.githubusercontent.com/u/314726?v=3","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"repo":{"id":28589709,"name":"sakai","full_name":"sakaiproject/sakai","owner":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars.githubusercontent.com/u/314726?v=3","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sakaiproject/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":false,"url":"https://api.github.com/repos/sakaiproject/sakai","forks_url":"https://api.github.com/repos/sakaiproject/sakai/forks","keys_url":"https://api.github.com/repos/sakaiproject/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakaiproject/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakaiproject/sakai/teams","hooks_url":"https://api.github.com/repos/sakaiproject/sakai/hooks","issue_events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/sakaiproject/sakai/events","assignees_url":"https://api.github.com/repos/sakaiproject/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/sakaiproject/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/sakaiproject/sakai/tags","blobs_url":"https://api.github.com/repos/sakaiproject/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakaiproject/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakaiproject/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakaiproject/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/sakaiproject/sakai/languages","stargazers_url":"https://api.github.com/repos/sakaiproject/sakai/stargazers","contributors_url":"https://api.github.com/repos/sakaiproject/sakai/contributors","subscribers_url":"https://api.github.com/repos/sakaiproject/sakai/subscribers","subscription_url":"https://api.github.com/repos/sakaiproject/sakai/subscription","commits_url":"https://api.github.com/repos/sakaiproject/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakaiproject/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakaiproject/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/sakaiproject/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakaiproject/sakai/merges","archive_url":"https://api.github.com/repos/sakaiproject/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakaiproject/sakai/downloads","issues_url":"https://api.github.com/repos/sakaiproject/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/sakaiproject/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/sakaiproject/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/sakaiproject/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakaiproject/sakai/labels{/name}","releases_url":"https://api.github.com/repos/sakaiproject/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/sakaiproject/sakai/deployments","created_at":"2014-12-29T11:14:17Z","updated_at":"2017-01-12T05:07:26Z","pushed_at":"2017-01-13T15:40:41Z","git_url":"git://github.com/sakaiproject/sakai.git","ssh_url":"git@github.com:sakaiproject/sakai.git","clone_url":"https://github.com/sakaiproject/sakai.git","svn_url":"https://github.com/sakaiproject/sakai","homepage":"https://www.sakaiproject.org","size":319058,"stargazers_count":203,"watchers_count":203,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":339,"mirror_url":null,"open_issues_count":82,"forks":339,"open_issues":82,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757"},"html":{"href":"https://github.com/sakaiproject/sakai/pull/3757"},"issue":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/3757"},"comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/3757/comments"},"review_comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757/comments"},"review_comment":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3757/commits"},"statuses":{"href":"https://api.github.com/repos/sakaiproject/sakai/statuses/c63ea3e0ee638eefd8ef7ad9244e023ca3034e97"}}}}
{"actor":{"display_login":"ottenhoff"}}